"""Integrity checks on the three linked tables. Returns a list of problems; empty means valid.""" import pandas as pd from .schema import ALIGNMENTS, EVALUATIONS, MERGES, METHODS, MODELS, TASKS def validate(models: pd.DataFrame, merges: pd.DataFrame, evals: pd.DataFrame) -> list: errs = [] for name, df, cols in (("models", models, MODELS), ("merges", merges, MERGES), ("evaluations", evals, EVALUATIONS)): missing = [c for c in cols if c not in df.columns] if missing: errs.append(f"{name}: missing columns {missing}") if errs: return errs if models["model_id"].duplicated().any(): errs.append(f"models: {models['model_id'].duplicated().sum()} duplicate model_id") if merges["merge_id"].duplicated().any(): errs.append(f"merges: {merges['merge_id'].duplicated().sum()} duplicate merge_id") known_models = set(models["model_id"]) for col in ("parent_a", "parent_b"): bad = set(merges[col].dropna()) - known_models - {""} if bad: errs.append(f"merges.{col}: {len(bad)} ids not in models, e.g. {sorted(bad)[:3]}") bad = set(evals["model_id"].dropna()) - known_models - {""} if bad: errs.append(f"evaluations.model_id: {len(bad)} ids not in models, e.g. {sorted(bad)[:3]}") bad = set(evals["merge_id"].dropna()) - set(merges["merge_id"]) - {""} if bad: errs.append(f"evaluations.merge_id: {len(bad)} ids not in merges, e.g. {sorted(bad)[:3]}") for col, allowed, df in (("merge_method", METHODS, merges), ("alignment_method", ALIGNMENTS, merges), ("task_name", set(TASKS), evals)): bad = set(df[col].dropna()) - allowed - {""} if bad: errs.append(f"{col}: non-canonical values {sorted(bad)[:5]}") v = pd.to_numeric(evals["metric_value"], errors="coerce") n_bad = int(v.isna().sum() - (evals["evaluation_status"] == "failed").sum()) if n_bad > 0: errs.append(f"evaluations: {n_bad} non-numeric metric_value rows not marked failed") if (evals["source_file"].fillna("") == "").any(): errs.append("evaluations: rows without source_file") if (merges["source_file"].fillna("") == "").any(): errs.append("merges: rows without source_file") dup = evals.duplicated(subset=["experiment_id", "merge_id", "model_id", "task_name", "dataset_config", "split", "metric_name", "evaluation_seed"]) if dup.any(): errs.append(f"evaluations: {int(dup.sum())} duplicate measurement rows") return errs