<nb> public abstract class AbstractCandidateItemsStrategy implements CandidateItemsSt
 return doGetCandidateItems ( itemIDs , dataModel ) ;
 }

 - abstract FastIDSet doGetCandidateItems ( long [ ] preferredItemIDs , DataModel dataModel ) throws TasteException ;
 + protected abstract FastIDSet doGetCandidateItems ( long [ ] preferredItemIDs , DataModel dataModel ) throws TasteException ;

 @ override
 public void refresh ( Collection < Refreshable > alreadyRefreshed ) {

Cannot extend CandidateItemsStrategy due to restricted visibility


<nb> public class DriverConductor implements Agent
 switch ( connection . status ( ) )
 {
 case INACTIVE :
 - if ( connection . remaining ( ) == NUMBER0 ||
 - now > ( connection . timeOfLastStatusChange ( ) + CONNECTION_LIVENESS_TIMEOUT_NS ) )
 + if ( connection . isDrained ( ) || now > ( connection . timeOfLastStatusChange ( ) + CONNECTION_LIVENESS_TIMEOUT_NS ) )
 {
 connection . status ( DriverConnection . Status . LINGER ) ;

 <nb> public class DriverConnection extends DriverConnectionPadding3 implements AutoCl
 }

 COMMENT
 - COMMENT
 + COMMENT
 COMMENT
 - COMMENT
 + COMMENT
 COMMENT
 - public long remaining ( )
 + public boolean isDrained ( )
 {
 - return Math . max ( completedPosition - subscribersPosition , NUMBER0 ) ;
 + return subscribersPosition >= completedPosition ;
 }

 COMMENT

Clarify logic for checking if a connection is drained before changing state to linger


<nb> public class GCMIntentService extends GCMBaseIntentService {
 . setSmallIcon ( R . drawable . notification_icon )
 . setColor ( getResources ( ) . getColor ( R . color . wordpress_blue ) )
 . setContentTitle ( title )
 - . setContentText ( message ) . setTicker ( message ) . setAutoCancel ( true )
 + . setContentText ( message )
 + . setTicker ( message )
 + . setAutoCancel ( true )
 . setStyle ( new NotificationCompat . BigTextStyle ( ) . bigText ( message ) ) ;

 if ( note_id != null ) {


<nb> import NAMESPACE ;

 public class PdfToSwfSlidesGenerationService {
 private static Logger log = LoggerFactory . getLogger ( PdfToSwfSlidesGenerationService . class ) ;
 -
 +
 + private final ExecutorService executor = Executors . newFixedThreadPool ( NUMBER0 ) ;
 +
 private SwfSlidesGenerationProgressNotifier notifier ;
 private PageCounterService counterService ;
 private PageConverter pdfToSwfConverter ;
 <nb> public class PdfToSwfSlidesGenerationService {
 private void convertPdfToSwf ( UploadedPresentation pres ) {
 int numPages = pres . getNumberOfPages ( ) ;
 List < PdfToSwfSlide > slides = setupSlides ( pres , numPages ) ;
 -
 - ExecutorService executor ;
 +
 CompletionService < PdfToSwfSlide > completionService ;
 - int numThreads = Runtime . getRuntime ( ) . availableProcessors ( ) ;
 - executor = Executors . newFixedThreadPool ( numThreads ) ;
 +
 completionService = new ExecutorCompletionService < PdfToSwfSlide > ( executor ) ;
 generateSlides ( pres , slides , completionService ) ;
 }

don t create threads unnecessarily when processing uploaded presentations


<nb> import NAMESPACE ;
 public class FromFtpStartingDirAndFileNameClashTest extends FtpServerTestSupport {

 private String getFtpUrl ( ) {
 - return STRING0 + getPort ( ) + STRING1 ;
 + return STRING0 + getPort ( ) + STRING2 ;
 }

 @ override
 <nb> public class FromFtpStartingDirAndFileNameClashTest extends FtpServerTestSupport
 Endpoint endpoint = context . getEndpoint ( getFtpUrl ( ) ) ;
 Exchange exchange = endpoint . createExchange ( ) ;
 exchange . getIn ( ) . setBody ( STRING3 ) ;
 - exchange . getIn ( ) . setHeader ( Exchange . FILE_NAME , STRING4 ) ;
 + exchange . getIn ( ) . setHeader ( Exchange . FILE_NAME , STRING5 ) ;
 Producer producer = endpoint . createProducer ( ) ;
 producer . start ( ) ;
 producer . process ( exchange ) ;


<nb> public class TupleAnalyzer
 if ( ! ( optimizedExpression instanceof Expression ) ) {
 throw new SemanticException ( TYPE_MISMATCH , node , STRING0 ) ;
 }
 + SINGLE
 + SINGLE
 + analyzer = new ExpressionAnalyzer ( analysis , session , metadata , sqlParser , experimentalSyntaxEnabled ) ;
 + analyzer . analyze ( ( Expression ) optimizedExpression , output , context ) ;
 + analysis . addCoercions ( analyzer . getExpressionCoercions ( ) ) ;

 for ( Expression conjunct : ExpressionUtils . extractConjuncts ( ( Expression ) optimizedExpression ) ) {
 if ( ! ( conjunct instanceof ComparisonExpression ) ) {
 <nb> public abstract class AbstractTestQueries
 }

 @ test
 + public void testJoinCoercion ( )
 + throws Exception
 + {
 + assertQuery ( STRING1 ) ;
 + }
 +
 + @ test
 public void testGroupByNoAggregations ( )
 throws Exception
 {


<nb> public class ApiHelper {
 HttpRequest request = HttpRequest . get ( urlString ) ;

 SINGLE
 - if ( request . code ( ) == HttpURLConnection . HTTP_MOVED_PERM
 - || request . code ( ) == HttpURLConnection . HTTP_MOVED_TEMP ) {
 - String location = request . location ( ) ;
 - if ( location != null ) {
 - request = HttpRequest . get ( location ) ;
 + if ( request != null ) {
 + if ( request . code ( ) == HttpURLConnection . HTTP_MOVED_PERM
 + || request . code ( ) == HttpURLConnection . HTTP_MOVED_TEMP ) {
 + String location = request . location ( ) ;
 + if ( location != null ) {
 + request = HttpRequest . get ( location ) ;
 + }
 }
 }

add null check when fetching http resource


<nb> import NAMESPACE ;

 COMMENT
 COMMENT
 - COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 COMMENT
 public interface InputType {
 COMMENT


<nb> public class QueryStringQueryBuilder extends BaseQueryBuilder {
 COMMENT
 COMMENT
 COMMENT
 - public void autoGeneratePhraseQueries ( boolean autoGeneratePhraseQueries ) {
 + public QueryStringQueryBuilder autoGeneratePhraseQueries ( boolean autoGeneratePhraseQueries ) {
 this . autoGeneratePhraseQueries = autoGeneratePhraseQueries ;
 + return this ;
 }

 COMMENT


<nb> public class GrailsCoreDependencies {
 ModuleRevisionId . newInstance ( STRING0 , STRING1 , STRING2 ) ,
 ModuleRevisionId . newInstance ( STRING3 , STRING3 , STRING4 ) ,
 ModuleRevisionId . newInstance ( STRING5 , STRING5 , STRING6 ) ,
 - ModuleRevisionId . newInstance ( STRING7 , STRING8 , STRING9 ) ,
 SINGLE
 ModuleRevisionId . newInstance ( STRING10 , STRING10 , STRING11 ) ,
 ModuleRevisionId . newInstance ( STRING12 , STRING12 , STRING13 ) ,

remove jstl as a core dependencies since it is part of the tomcat jars


<nb> public final class OBJLoader implements AssetLoader {
 try {
 matList = ( MaterialList ) assetManager . loadAsset ( key . getFolder ( ) + name ) ;
 } catch ( AssetNotFoundException ex ) {
 - throw new AssetNotFoundException ( STRING0 + name + STRING1 + key . getName ( ) ) ;
 + throw new AssetNotFoundException ( STRING2 + name + STRING1 + key . getName ( ) , ex ) ;
 }

 if ( matList != null ) {
 <nb> public class AssetNotFoundException extends RuntimeException {
 public AssetNotFoundException ( String message ) {
 super ( message ) ;
 }
 + public AssetNotFoundException ( String message , Exception ex ) {
 + super ( message , ex ) ;
 + }
 }

Fixed issue with an exception getting silenced when MTL was loaded for an OBJ file


<nb> public abstract class OBinaryNetworkProtocolAbstract extends ONetworkProtocol {
 }
 channel . writeByte ( ( byte ) NUMBER0 ) ;

 - channel . clearInput ( ) ;
 + SINGLE

 } finally {
 channel . releaseExclusiveLock ( ) ;

removed clearInput on error as reported by Steven and Alex in ML


<nb> public class OOrientDBLoader extends OAbstractLoader implements OLoader {
 for ( ODocument idx : indexes ) {
 OIndex index ;

 - String idxName = idx . field ( STRING0 ) ;
 + String idxName = ( String ) resolve ( idx . field ( STRING0 ) ) ;
 if ( idxName != null ) {
 index = documentDatabase . getMetadata ( ) . getIndexManager ( ) . getIndex ( idxName ) ;
 if ( index != null )
 <nb> public class OOrientDBLoader extends OAbstractLoader implements OLoader {
 continue ;
 }

 - final String idxClass = idx . field ( STRING1 ) ;
 + final String idxClass = ( String ) resolve ( idx . field ( STRING1 ) ) ;
 if ( idxClass == null )
 throw new OConfigurationException ( STRING2 ) ;


<nb> import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;
 + import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;
 <nb> public class AtomicLongTest extends HazelcastTestSupport {

 @ test
 @ clientcompatibletest
 - @ category ( ProblematicTest . class )
 public void testAtomicLongSpawnNodeInParallel ( ) throws InterruptedException {
 int total = NUMBER0 ;
 int parallel = NUMBER1 ;

Removed a AtomicLongTest from problematic to regular


<nb> public class AsmClassGenerator extends ClassGenerator {
 }

 protected int getBytecodeVersion ( ) {
 - ClassNode classNode = controller . getClassNode ( ) ;
 - if ( ! classNode . isUsingGenerics ( ) &&
 - ! classNode . isAnnotated ( ) &&
 - ! classNode . isAnnotationDefinition ( ) )
 - {
 - return Opcodes . V1_3 ;
 - }
 -
 - final String target = getCompileUnit ( ) . getConfig ( ) . getTargetBytecode ( ) ;
 - return CompilerConfiguration . POST_JDK5 . equals ( target ) ? Opcodes . V1_5 : Opcodes . V1_3 ;
 + return Opcodes . V1_5 ;
 }

 public boolean addInnerClass ( ClassNode innerClass ) {


<nb> package NAMESPACE ;
 import NAMESPACE ;

 import NAMESPACE ;
 + import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;
 <nb> public class IndexCustomKeyTest {
 database . close ( ) ;
 }

 + @ afterclass
 + public void afterClass ( ) {
 + database . open ( STRING0 , STRING0 ) ;
 + database . getMetadata ( ) . getIndexManager ( ) . dropIndex ( STRING1 ) ;
 + }
 +
 @ parameters ( value = STRING2 )
 public IndexCustomKeyTest ( String iURL ) {
 database = new ODatabaseDocumentTx ( iURL ) ;


<nb> public class NewShinyWebApplication extends ModalDialog < NewShinyWebApplication . R
 appNameTextBox_ . getElement ( ) . setAttribute ( STRING0 , STRING1 ) ;
 addTextFieldValidator ( appNameTextBox_ ) ;

 - String cachedAppName = result_ . getAppName ( ) ;
 - String appName = StringUtil . isNullOrEmpty ( cachedAppName ) ? STRING2 : cachedAppName ;
 - appNameTextBox_ . setText ( appName ) ;
 -
 appTypeLabel_ = new Label ( STRING3 ) ;
 appTypeLabel_ . addStyleName ( RES . styles ( ) . label ( ) ) ;
 appTypeLabel_ . getElement ( ) . getStyle ( ) . setMarginTop ( NUMBER0 , Unit . PX ) ;


<nb> public class RegexNotQueryTest extends LuceneTestCase {
 assertFalse ( query1 . equals ( query2 ) ) ;
 }

 + SINGLE
 + SINGLE
 + SINGLE
 + SINGLE
 + SINGLE
 public void testJakartaCaseSensitive ( ) throws Exception {
 assertEquals ( NUMBER0 , regexQueryNrHits ( STRING0 , null ) ) ;
 }
 <nb> public class RegexNotQueryTest extends LuceneTestCase {
 assertEquals ( NUMBER0 , regexQueryNrHits ( STRING0 , null ) ) ;
 }

 + SINGLE
 + SINGLE
 + SINGLE
 + SINGLE
 + SINGLE
 public void testJakartaCaseInsensitive ( ) throws Exception {
 assertEquals (
 NUMBER1 ,


<nb> import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;
 + import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;

 <nb> public class MakePublicFix extends BaseFix {
 @ notnull
 public String getName ( ) {
 return DevKitBundle . message ( STRING0 ,
 - myElement . getLanguage ( ) . getFindUsagesProvider ( ) . getType ( myElement ) ) ;
 + LanguageFindUsages . INSTANCE . forLanguage ( myElement . getLanguage ( ) ) . getType ( myElement ) ) ;
 }

 protected void doFix ( Project project , ProblemDescriptor descriptor , boolean external ) throws IncorrectOperationException {

decouple FindUsagesProvider from Language


<nb> public class DatabaseReconciliatorTest {
 STRING0 ,
 STRING1 ,
 STRING2 , SINGLE
 - SINGLE
 + SINGLE
 SINGLE
 SINGLE
 SINGLE
 <nb> public class DatabaseReconciliatorTest {
 TestResult expectedTestResult = new TestResult ( ) ;

 expectedTestResult . winnersLastDatabaseVersionHeader = TestDatabaseUtil . createMapWithMachineKey ( new String [ ] {
 - STRING3 , STRING4
 + STRING5 , STRING6
 } ) . firstEntry ( ) ;

 SINGLE


<nb> public class IssueIndex extends BaseIndex < Issue , FakeIssueDto , String > {
 }
 }

 - public Collection < String > listTagsMatching ( String query , int pageSize ) {
 + public Collection < String > listTagsMatching ( @ nullable String query , int pageSize ) {
 SearchRequestBuilder count = getClient ( ) . prepareSearch ( IssueIndexDefinition . INDEX )
 . setTypes ( IssueIndexDefinition . TYPE_ISSUE )
 . setQuery ( QueryBuilders . matchAllQuery ( ) ) ;


<nb> public class TabWidget extends LinearLayout implements OnFocusChangeListener {
 COMMENT
 COMMENT
 public void setRightStripDrawable ( Drawable drawable ) {
 - mBottomLeftStrip = drawable ;
 + mBottomRightStrip = drawable ;
 requestLayout ( ) ;
 invalidate ( ) ; }

 <nb> public class TabWidget extends LinearLayout implements OnFocusChangeListener {
 COMMENT
 COMMENT
 public void setRightStripDrawable ( int resId ) {
 - mBottomLeftStrip = mContext . getResources ( ) . getDrawable ( resId ) ;
 + mBottomRightStrip = mContext . getResources ( ) . getDrawable ( resId ) ;
 requestLayout ( ) ;
 invalidate ( ) ;
 }


<nb> public class BottomBar extends FrameLayout implements View . OnClickListener , View
 } else {
 ViewCompat . setScaleX ( title , NUMBER0 ) ;
 ViewCompat . setScaleY ( title , NUMBER0 ) ;
 - ViewCompat . setTranslationY ( tab , - translationY ) ;
 + icon . setPadding ( icon . getPaddingLeft ( ) , icon . getPaddingTop ( ) - translationY ,
 + icon . getPaddingRight ( ) , icon . getPaddingBottom ( ) ) ;

 if ( mIsShiftingMode ) {
 ViewCompat . setAlpha ( icon , FLOAT0 ) ;


<nb> public class ECKey implements Serializable {
 DERInteger r = ( DERInteger ) seq . getObjectAt ( NUMBER0 ) ;
 DERInteger s = ( DERInteger ) seq . getObjectAt ( NUMBER1 ) ;
 decoder . close ( ) ;
 - return signer . verifySignature ( data , r . getValue ( ) , s . getValue ( ) ) ;
 + SINGLE
 + SINGLE
 + SINGLE
 + return signer . verifySignature ( data , r . getPositiveValue ( ) , s . getPositiveValue ( ) ) ;
 } catch ( IOException e ) {
 throw new RuntimeException ( e ) ;
 }

Fix handling of improperly encoded DER signatures to match OpenSSL


<nb> import static NAMESPACE ;
 COMMENT
 COMMENT
 @ suppresswarnings ( STRING0 )
 - public abstract class Invocation implements OperationResponseHandler , Runnable {
 + public abstract class Invocation implements OperationResponseHandler {

 private static final AtomicReferenceFieldUpdater < Invocation , Boolean > RESPONSE_RECEIVED =
 AtomicReferenceFieldUpdater . newUpdater ( Invocation . class , Boolean . class , STRING1 ) ;
 <nb> public abstract class Invocation implements OperationResponseHandler , Runnable {
 }
 }

 - @ override
 - public void run ( ) {
 - doInvoke ( false ) ;
 - }
 -
 private boolean engineActive ( ) {
 NodeState state = context . node . getState ( ) ;
 if ( state == NodeState . ACTIVE ) {
 <nb> public abstract class Invocation implements OperationResponseHandler , Runnable {
 context . executionService . schedule ( ASYNC_EXECUTOR , this , tryPauseMillis , MILLISECONDS ) ;
 return ;
 }
 - Invocation . this . run ( ) ;
 + doInvoke ( false ) ;
 }
 }

Invocation no longer implements Runnable


<nb> public class ReaderPostPagerActivity extends Activity
 super . onCreate ( savedInstanceState ) ;
 setContentView ( R . layout . reader_activity_post_pager ) ;

 - SINGLE
 - getWindow ( ) . setBackgroundDrawable ( null ) ;
 -
 ActionBar actionBar = getActionBar ( ) ;
 if ( actionBar != null ) {
 actionBar . setDisplayShowTitleEnabled ( true ) ;

No longer removing the window background


<nb> import NAMESPACE ;
 public class NotifyingSplitLayoutPanel extends SplitLayoutPanel
 {
 @ inject
 - public NotifyingSplitLayoutPanel ( EventBus events )
 + public NotifyingSplitLayoutPanel ( int splitterSize , EventBus events )
 {
 - super ( ) ;
 + super ( splitterSize ) ;

 events_ = events ;

 <nb> public class MainSplitPanel extends NotifyingSplitLayoutPanel
 public MainSplitPanel ( EventBus events ,
 Session session )
 {
 - super ( events ) ;
 + super ( NUMBER0 , events ) ;
 session_ = session ;
 addSplitterResizedHandler ( this ) ;
 }


<nb> public class SqlStageExecution
 if ( ! getState ( ) . isDone ( ) ) {
 transitionToState ( StageState . FAILED ) ;
 log . error ( e , STRING0 , stageId ) ;
 + cancelAll ( ) ;
 throw e ;
 }
 Throwables . propagateIfInstanceOf ( e , Error . class ) ;
 <nb> public class SqlStageExecution
 transitionToState ( StageState . FAILED ) ;
 }
 log . error ( e , STRING1 , stageId ) ;
 - cancel ( ) ;
 + cancelAll ( ) ;
 throw Throwables . propagate ( e ) ;
 }
 }


<nb> public class Command implements Serializable {

 @ override
 public String toString ( ) {
 - return getClass ( ) . getSimpleName ( ) ;
 + return String . format ( STRING0 , getClass ( ) . getSimpleName ( ) , System . identityHashCode ( this ) ) ;
 }
 }

provide a little more information in the toString of a command object for debugging


<nb> public final class TreeWalker
 walk ( rootAST , contents ) ;
 }
 catch ( FileNotFoundException fnfe ) {
 + SINGLE
 + SINGLE
 mMessages . add ( new LocalizedMessage ( NUMBER0 , Defn . CHECKSTYLE_BUNDLE ,
 STRING0 , null ) ) ;
 }

Added a flag something needs to be done about


<nb> import NAMESPACE ;

 import NAMESPACE ;
 import NAMESPACE ;
 - import NAMESPACE ;
 - import NAMESPACE ;

 public class ShowcaseViews {

 <nb> package NAMESPACE ;

 import NAMESPACE ;
 import NAMESPACE ;
 - import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;


<nb> public class ProfilerEditingTarget implements EditingTarget ,
 @ handler
 void onSaveSourceDoc ( )
 {
 - saveNewFile ( getPath ( ) ) ;
 + saveNewFile ( null ) ;
 }

 @ handler
 void onSaveSourceDocAs ( )
 {
 - saveNewFile ( getPath ( ) ) ;
 + saveNewFile ( isUserSaved_ ? getPath ( ) : null ) ;
 }

 public String getDefaultNamePrefix ( )

suggest a better directory when saving profiles


<nb> public class MediaScanner

 private boolean inScanDirectory ( String path , String [ ] directories ) {
 for ( int i = NUMBER0 ; i < directories . length ; i ++ ) {
 - if ( path . startsWith ( directories [ i ] ) ) {
 + String directory = directories [ i ] ;
 + if ( mExternalStoragePath != null && directory . equals ( mMediaStoragePath ) ) {
 + SINGLE
 + directory = mExternalStoragePath ;
 + }
 + if ( path . startsWith ( directory ) ) {
 return true ;
 }
 }

Fix path mismatch in code that check for missing files in postScan


<nb> import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;
 + import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;
 <nb> public class StorageUtils {
 public static long getFreeSpaceAvailable ( ) {
 StatFs stat = new StatFs ( UserPreferences . getDataFolder (
 PodcastApp . getInstance ( ) , null ) . getAbsolutePath ( ) ) ;
 - long availableBlocks = stat . getAvailableBlocks ( ) ;
 - long blockSize = stat . getBlockSize ( ) ;
 + long availableBlocks ;
 + long blockSize ;
 + if ( Build . VERSION . SDK_INT >= Build . VERSION_CODES . JELLY_BEAN_MR2 ) {
 + availableBlocks = stat . getAvailableBlocksLong ( ) ;
 + blockSize = stat . getBlockSizeLong ( ) ;
 + } else {
 + availableBlocks = stat . getAvailableBlocks ( ) ;
 + blockSize = stat . getBlockSize ( ) ;
 + }
 return availableBlocks * blockSize ;
 }
 }


<nb> public class OreDictionary
 registerOre ( STRING0 , Items . quartz ) ;
 registerOre ( STRING1 , Items . redstone ) ;
 registerOre ( STRING2 , Items . glowstone_dust ) ;
 - registerOre ( STRING3 , new ItemStack ( Items . dye , NUMBER0 , NUMBER1 ) ) ;
 + registerOre ( STRING4 , new ItemStack ( Items . dye , NUMBER0 , NUMBER1 ) ) ;
 registerOre ( STRING5 , Items . slime_ball ) ;
 registerOre ( STRING6 , Blocks . glowstone ) ;
 registerOre ( STRING7 , Items . wheat ) ;

Changed dustLapis to gemLapis to make OM SHUT THE HELL UP


<nb> public interface IExecutorService extends ExecutorService , DistributedObject {

 COMMENT
 COMMENT
 - COMMENT
 - COMMENT
 + COMMENT
 + COMMENT
 COMMENT
 COMMENT
 COMMENT
 <nb> public interface IExecutorService extends ExecutorService , DistributedObject {

 COMMENT
 COMMENT
 - COMMENT
 - COMMENT
 + COMMENT
 + COMMENT
 COMMENT
 COMMENT
 COMMENT
 <nb> public interface IExecutorService extends ExecutorService , DistributedObject {

 COMMENT
 COMMENT
 - COMMENT
 - COMMENT
 + COMMENT
 + COMMENT
 COMMENT
 COMMENT
 COMMENT
 <nb> public interface IExecutorService extends ExecutorService , DistributedObject {

 COMMENT
 COMMENT
 - COMMENT
 - COMMENT
 + COMMENT
 + COMMENT
 COMMENT
 COMMENT
 COMMENT

javadoc fixes for methods w a MultiExecutionCallback param


<nb> public class GridView extends AbsListView {
 final int selectedPosition = mSelectedPosition ;

 View child = null ;
 + final int nextChildDir = isLayoutRtl ? - NUMBER0 : + NUMBER0 ;
 for ( int pos = startPos ; pos < last ; pos ++ ) {
 SINGLE
 boolean selected = pos == selectedPosition ;
 <nb> public class GridView extends AbsListView {
 final int where = flow ? - NUMBER0 : pos - startPos ;
 child = makeAndAddView ( pos , y , flow , nextLeft , selected , where ) ;

 - nextLeft += ( isLayoutRtl ? - NUMBER0 : + NUMBER0 ) * columnWidth ;
 + nextLeft += nextChildDir * columnWidth ;
 if ( pos < last - NUMBER0 ) {
 - nextLeft += horizontalSpacing ;
 + nextLeft += nextChildDir * horizontalSpacing ;
 }

 if ( selected && ( hasFocus || inClick ) ) {


<nb> public class Resources {
 return true ;
 }

 - COMMENT
 + @ nullable
 + Drawable loadDrawable ( TypedValue value , int id , Theme theme ) throws NotFoundException {
 if ( TRACE_FOR_PRELOAD ) {
 SINGLE
 if ( ( id > > > NUMBER0 ) == NUMBER1 ) {
 <nb> public class Resources {
 SINGLE
 SINGLE
 SINGLE
 - final boolean canApplyTheme = dr . canApplyTheme ( ) ;
 + final boolean canApplyTheme = dr != null && dr . canApplyTheme ( ) ;
 if ( canApplyTheme && theme != null ) {
 dr = dr . mutate ( ) ;
 dr . applyTheme ( theme ) ;


<nb> public class LocalEventBusTest extends EventBusTestBase {
 closeVertx ( ) ;
 await ( ) ;
 }
 +
 + @ test
 + public void testHandlerRegistrationDoesNotCancelTimer0 ( ) throws Exception {
 + HandlerRegistration < String > handlerRegistration = new HandlerRegistration < String > ( vertx , null , null , null , false ,
 + false , null , - NUMBER0 ) ;
 +
 + AtomicBoolean timerFinished = new AtomicBoolean ( false ) ;
 +
 + long tid1 = vertx . setTimer ( NUMBER1 , id - > {
 + timerFinished . set ( true ) ;
 + } ) ;
 +
 + if ( tid1 != NUMBER2 ) {
 + fail ( STRING0 ) ;
 + }
 +
 + handlerRegistration . unregister ( ) ;
 +
 + vertx . setTimer ( NUMBER3 , id2 - > {
 + assertTrue ( STRING1 , timerFinished . get ( ) ) ;
 + testComplete ( ) ;
 + } ) ;
 + await ( ) ;
 + }
 }


<nb> public class DigestAuthenticator extends AuthenticatorBase {
 }

 private static class NonceInfo {
 - private volatile long timestamp ;
 - private volatile boolean seen [ ] ;
 - private volatile int offset ;
 - private volatile int count = NUMBER0 ;
 + private final long timestamp ;
 + private final boolean seen [ ] ;
 + private final int offset ;
 + private int count = NUMBER0 ;

 public NonceInfo ( long currentTime , int seenWindowSize ) {
 this . timestamp = currentTime ;

Remove volatile from variables as it is misleading


<nb> public class DeprecationLogger {
 if ( ! isEnabled ( ) ) {
 return ;
 }
 - nagUserWith ( STRING0
 - + STRING1 ) ;
 + nagUserWith ( STRING2 ) ;

 String propertyWithClass = target . getClass ( ) . getName ( ) + STRING3 + propertyName ;
 if ( DYNAMIC_PROPERTIES . add ( propertyWithClass ) ) {

Removed an extra line in the deprecation message for dynamic properties


<nb> public class HystrixCommandTest extends CommonHystrixCommandTests < TestHystrixCom
 assertTrue ( hook . fallbackEventsMatch ( NUMBER0 , NUMBER0 , NUMBER0 ) ) ;
 assertEquals ( TimeoutException . class , hook . getCommandException ( ) . getClass ( ) ) ;
 assertNull ( hook . getFallbackException ( ) ) ;
 + System . out . println ( STRING0 + HystrixRequestLog . getCurrentRequest ( ) . getExecutedCommandsAsString ( ) ) ;
 assertEquals ( STRING1 , hook . executionSequence . toString ( ) ) ;
 }
 } ) ;
 <nb> public class HystrixCommandTest extends CommonHystrixCommandTests < TestHystrixCom
 assertTrue ( hook . commandEmissionsMatch ( NUMBER1 , NUMBER0 , NUMBER1 ) ) ;
 assertTrue ( hook . executionEventsMatch ( NUMBER0 , NUMBER0 , NUMBER0 ) ) ;
 assertTrue ( hook . fallbackEventsMatch ( NUMBER1 , NUMBER0 , NUMBER1 ) ) ;
 + System . out . println ( STRING0 + HystrixRequestLog . getCurrentRequest ( ) . getExecutedCommandsAsString ( ) ) ;
 assertEquals ( STRING2 , hook . executionSequence . toString ( ) ) ;
 }
 } ) ;

Add printlns to understand why some tests are failing


<nb> public final class UrlImageViewHelper {
 }
 o = new Options ( ) ;
 o . inSampleSize = NUMBER0 < < scale ;
 - final Bitmap bitmap = BitmapFactory . decodeStream ( stream ) ;
 + final Bitmap bitmap = BitmapFactory . decodeStream ( stream , null , o ) ;
 SINGLE
 BitmapDrawable bd = new BitmapDrawable ( mResources , bitmap ) ;
 ZombieDrawable zd = new ZombieDrawable ( url , bd ) ;

readd some code I deleted during testing


<nb> import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;

 - COMMENT
 - COMMENT
 - COMMENT
 - COMMENT
 - COMMENT
 - COMMENT
 - COMMENT
 - COMMENT
 @ retention ( RetentionPolicy . CLASS )
 @ target ( {
 ElementType . ANNOTATION_TYPE ,

Dump some more blahblah into the Beta annotation to try to clear up some persistent misconceptions


<nb> package NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;
 - import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;

 <nb> public class Note {
 COMMENT
 COMMENT
 public String getCommentPreview ( ) {
 - return getCommentBody ( ) . toString ( ) . replace ( STRING0 , STRING1 ) . replaceAll ( STRING2 , STRING1 ) . trim ( ) ;
 + return getCommentBody ( ) . toString ( ) . replaceAll ( STRING3 , STRING4 ) . replace ( STRING0 , STRING1 ) . replaceAll ( STRING2 , STRING1 ) . trim ( ) ;
 }
 COMMENT
 COMMENT

Remove goofy looking obj image placeholder in comment preview of notifications list view


<nb>
 COMMENT
 - COMMENT
 + COMMENT
 COMMENT
 package NAMESPACE ;
 <nb>
 COMMENT
 - COMMENT
 + COMMENT
 COMMENT
 COMMENT
 COMMENT
 <nb>
 COMMENT
 - COMMENT
 + COMMENT
 COMMENT
 COMMENT
 COMMENT
 <nb>
 COMMENT
 - COMMENT
 + COMMENT
 COMMENT
 package NAMESPACE ;
 <nb>
 COMMENT
 - COMMENT
 + COMMENT
 COMMENT
 package NAMESPACE ;
 <nb>
 COMMENT
 - COMMENT
 + COMMENT
 COMMENT
 package NAMESPACE ;


<nb> public class MockHandler < T > implements MockAwareInterceptor < T > {
 InvocationMatcher invocationMatcher = matchersBinder . bindMatchers ( invocation ) ;

 if ( verificationMode != null ) {
 - SINGLE
 - verifyingRecorder . verify ( invocationMatcher , verificationMode ) ;
 + VerificationDataImpl data = new VerificationDataImpl ( verifyingRecorder . getRegisteredInvocations ( ) , invocationMatcher ) ;
 + verificationMode . verify ( data ) ;
 return null ;
 }

 <nb> package NAMESPACE ;
 import NAMESPACE ;

 import NAMESPACE ;
 - import NAMESPACE ;
 - import NAMESPACE ;

 - SINGLE
 public class VerifyingRecorder {

 private RegisteredInvocations registeredInvocations = new RegisteredInvocations ( ) ;
 <nb> public class VerifyingRecorder {
 public List < Invocation > getRegisteredInvocations ( ) {
 return registeredInvocations . getVerifiableInvocations ( ) ;
 }
 -
 - public void verify ( InvocationMatcher wanted , VerificationMode mode ) {
 - mode . verify ( new VerificationDataImpl ( getRegisteredInvocations ( ) , wanted ) ) ;
 - }
 }


<nb> public class GraphVisualizer extends JFrame implements VertexSelectionListener {
 JPanel pane = new JPanel ( ) ;
 pane . setLayout ( new GridLayout ( NUMBER0 , NUMBER1 ) ) ;

 - SINGLE
 + SINGLE
 walkCheckBox = new JCheckBox ( STRING0 ) ;
 walkCheckBox . setSelected ( true ) ;
 pane . add ( walkCheckBox ) ;
 <nb> public class GraphVisualizer extends JFrame implements VertexSelectionListener {
 carCheckBox = new JCheckBox ( STRING1 ) ;
 pane . add ( carCheckBox ) ;

 + SINGLE
 + JLabel dummyLabel = new JLabel ( STRING2 ) ;
 + pane . add ( dummyLabel ) ;
 +
 SINGLE
 JLabel arriveByLabel = new JLabel ( STRING3 ) ;
 pane . add ( arriveByLabel ) ;

Added empty label to fix the layout of the grid


<nb> public enum Token {
 PLACEHOLDER1 ,
 PLACEHOLDER2 ;

 - @ deprecated
 - public static String name ( Token token ) {
 - return token . toString ( ) ;
 - }
 -
 COMMENT
 public static int arity ( Token token ) {
 switch ( token ) {


<nb> import NAMESPACE ;
 import NAMESPACE ;

 COMMENT
 - COMMENT
 - COMMENT
 - COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 COMMENT
 COMMENT
 COMMENT
 <nb>

 package NAMESPACE ;

 - import NAMESPACE ;
 + import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;

 import NAMESPACE ;

 - COMMENT
 - COMMENT
 - COMMENT
 - COMMENT
 - COMMENT
 - COMMENT
 - @ notthreadsafe
 + @ threadsafe
 interface InternalConnection extends BufferProvider {

 COMMENT

Fixed Connection and InternalConnection Javadoc to reflect that both are now thread safe


<nb> public class ActivityApp extends ActivityBase {
 holder . imgCbMethodRestricted . setImageBitmap ( getCheckBoxImage ( rstate ) ) ;
 holder . imgCbMethodRestricted . setVisibility ( View . VISIBLE ) ;

 + SINGLE
 holder . imgCbMethodWhitelist . setVisibility ( whitelist ? View . VISIBLE : View . GONE ) ;
 + if ( whitelist )
 + holder . imgCbMethodWhitelist . setOnClickListener ( new View . OnClickListener ( ) {
 + @ override
 + public void onClick ( View view ) {
 + ActivityApp . this . optionWhitelists ( ) ;
 + }
 + } ) ;
 + else
 + holder . imgCbMethodWhitelist . setClickable ( false ) ;

 + SINGLE
 if ( ondemand ) {
 holder . imgCbMethodAsk . setImageBitmap ( getAskBoxImage ( rstate ) ) ;
 holder . imgCbMethodAsk . setVisibility ( View . VISIBLE ) ;


<nb> import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;
 + import NAMESPACE ;
 import NAMESPACE ;

 <nb> public class PendingRangeCalculatorService extends PendingRangeCalculatorService

 SINGLE
 SINGLE
 - synchronized ( bootstrapTokens )
 - {
 + synchronized ( bootstrapTokens ) {
 + bootstrapTokens = new LinkedHashMap < Token , InetAddress > ( bootstrapTokens ) ;
 + }
 +
 for ( Map . Entry < Token , InetAddress > entry : bootstrapTokens . entrySet ( ) )
 {
 InetAddress endpoint = entry . getValue ( ) ;
 <nb> public class PendingRangeCalculatorService extends PendingRangeCalculatorService
 pendingRanges . put ( range , endpoint ) ;
 allLeftMetadata . removeEndpoint ( endpoint ) ;
 }
 - }

 SINGLE
 SINGLE

Remove synchronization in long running PCRS


<nb> public class IntentionManagerSettings implements ApplicationComponent , NamedJDOM

 public static URL getIntentionDescriptionDirURL ( Class aClass , String prefix ) {
 URL pageURL = aClass . getClassLoader ( ) . getResource ( STRING0 + prefix ) ;
 + if ( LOG . isDebugEnabled ( ) ) {
 + LOG . debug ( STRING1 + aClass . getName ( ) ) ;
 + LOG . debug ( STRING2 + aClass . getClassLoader ( ) ) ;
 + LOG . debug ( STRING3 + STRING0 + prefix ) ;
 + LOG . debug ( STRING4 + pageURL ) ;
 + }
 return pageURL ;
 }

added trace for get intention description


<nb> public class InnerClassVisitor extends InnerClassVisitorHelper implements Opcode
 ve . setUseReferenceDirectly ( true ) ;
 expressions . add ( pCount , ve ) ;

 - Parameter p = new Parameter ( ClassHelper . REFERENCE_TYPE , STRING0 + pCount ) ;
 + ClassNode rawReferenceType = ClassHelper . REFERENCE_TYPE . getPlainNodeReference ( ) ;
 + Parameter p = new Parameter ( rawReferenceType , STRING0 + pCount ) ;
 parameters . add ( pCount , p ) ;
 p . setOriginType ( var . getOriginType ( ) ) ;
 final VariableExpression initial = new VariableExpression ( p ) ;
 initial . setUseReferenceDirectly ( true ) ;
 - final FieldNode pField = innerClass . addFieldFirst ( ve . getName ( ) , PUBLIC_SYNTHETIC , ClassHelper . REFERENCE_TYPE , initial ) ;
 + final FieldNode pField = innerClass . addFieldFirst ( ve . getName ( ) , PUBLIC_SYNTHETIC , rawReferenceType , initial ) ;
 pField . setHolder ( true ) ;
 pField . setOriginType ( ClassHelper . getWrapper ( var . getOriginType ( ) ) ) ;
 }

use the Reference Raw type instead of the generic version to avoid problems with generics


<nb> public class CheckedExceptionCompatibilityConstraint extends InputOutputConstrai

 @ override
 public boolean reduce ( InferenceSession session , List < ConstraintFormula > constraints ) {
 - if ( ! PsiPolyExpressionUtil . isPolyExpression ( myExpression ) ||
 - myExpression instanceof PsiCallExpression ) {
 + if ( myExpression instanceof PsiCallExpression || ! PsiPolyExpressionUtil . isPolyExpression ( myExpression ) ) {
 return true ;
 }
 if ( myExpression instanceof PsiParenthesizedExpression ) {


<nb> public class ClassRenamer {

 private String renameRetargetIfNecessary ( String string ) {
 String value = retargets . get ( string ) ;
 - if ( value != null ) {
 + if ( value != null ) {
 return value ;
 }
 - if ( string . indexOf ( oldname ) != - NUMBER0 ) {
 + if ( string != null && string . indexOf ( oldname ) != - NUMBER0 ) {
 return string . replace ( oldname , newname ) ;
 }
 return string ;


<nb> public class UsbConfirmActivity extends AlertActivity

 }

 + @ override
 + protected void onDestroy ( ) {
 + if ( mDisconnectedReceiver != null ) {
 + unregisterReceiver ( mDisconnectedReceiver ) ;
 + }
 + super . onDestroy ( ) ;
 + }
 +
 public void onClick ( DialogInterface dialog , int which ) {
 if ( which == AlertDialog . BUTTON_POSITIVE ) {
 try {

Fix broadcast receiver leak in UsbConfirmActivity


<nb> public class WPWebViewActivity extends WebViewActivity implements DownloadListen
 }

 class DownloadExportFileTask extends AsyncTask < String , Void , Void > {
 + private DownloadManager downloadManager ;
 + @ override
 + protected void onPreExecute ( ) {
 + super . onPreExecute ( ) ;
 + downloadManager = ( DownloadManager ) getSystemService ( DOWNLOAD_SERVICE ) ;
 + }
 +
 @ override
 protected Void doInBackground ( String . . . exportUrls ) {
 try {
 <nb> public class WPWebViewActivity extends WebViewActivity implements DownloadListen
 SINGLE
 fileOutput . close ( ) ;

 + downloadManager . addCompletedDownload ( STRING0 , STRING1 , true , STRING2 , file . getPath ( ) , file . length ( ) , true ) ;
 +
 } catch ( java . io . IOException e ) {
 e . printStackTrace ( ) ;
 }


<nb> import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;
 + import NAMESPACE ;

 COMMENT
 COMMENT
 <nb> public class CassandraServer extends FacebookBase implements

 public List < String > get_range ( String tablename , final String startkey ) throws CassandraException
 {
 + if ( ! ( StorageService . getPartitioner ( ) instanceof OrderPreservingPartitioner ) ) {
 + throw new CassandraException ( STRING0 ) ;
 + }
 +
 logger_ . debug ( STRING1 ) ;

 SINGLE


<nb>
 package NAMESPACE ;

 import NAMESPACE ;
 - import NAMESPACE ;
 - import NAMESPACE ;

 import NAMESPACE ;
 import NAMESPACE ;
 <nb> import NAMESPACE ;

 public abstract class AbstractJsonProvider implements JsonProvider {

 - private static final Logger logger = LoggerFactory . getLogger ( AbstractJsonProvider . class ) ;
 -
 -
 COMMENT
 COMMENT
 COMMENT


<nb> public class RestrictedPreferenceHelper {
 public boolean setDisabledByAdmin ( EnforcedAdmin admin ) {
 final boolean disabled = ( admin != null ? true : false ) ;
 mEnforcedAdmin = ( disabled ? admin : null ) ;
 + mPreference . setEnabled ( ! disabled ) ;
 if ( mDisabledByAdmin != disabled ) {
 mDisabledByAdmin = disabled ;
 - mPreference . setEnabled ( ! disabled ) ;
 return true ;
 }
 return false ;


<nb> public class MailBinding {

 if ( attachmentFilename . toLowerCase ( ) . startsWith ( STRING0 ) ) {
 SINGLE
 - messageBodyPart . addHeader ( STRING1 , attachmentFilename . substring ( NUMBER0 ) ) ;
 + SINGLE
 + messageBodyPart . addHeader ( STRING1 , STRING2 + attachmentFilename . substring ( NUMBER0 ) + STRING3 ) ;
 }

 SINGLE

attachments using cid must use angle brackets in Content ID according to RFC


<nb> public class WeightedRVFDataset < L , F > extends RVFDataset < L , F > {

 float [ ] weights = new float [ NUMBER0 ] ;

 - public WeightedRVFDataset ( Index < L > labelIndex , int [ ] trainLabels , Index < F > featureIndex , int [ ] [ ] trainData , double [ ] [ ] trainValues , float [ ] trainWeights ) {
 + public WeightedRVFDataset ( ) {
 + super ( ) ;
 + }
 +
 + protected WeightedRVFDataset ( Index < L > labelIndex , int [ ] trainLabels , Index < F > featureIndex , int [ ] [ ] trainData , double [ ] [ ] trainValues , float [ ] trainWeights ) {
 super ( labelIndex , trainLabels , featureIndex , trainData , trainValues ) ;
 this . weights = trainWeights ;
 }


<nb> public class UIPrefsAccessor extends Prefs

 public PrefValue < Boolean > showFunctionTooltipOnIdle ( )
 {
 - return bool ( STRING0 , true ) ;
 + return bool ( STRING1 , false ) ;
 }

 public static final String EDITOR_SURROUND_SELECTION_NEVER = STRING2 ;


<nb> public class LowMemoryWatcher {
 private static final Runnable ourJanitor = new Runnable ( ) {
 @ override
 public void run ( ) {
 + LOG . info ( STRING0 ) ;
 try {
 for ( LowMemoryWatcher watcher : ourInstances ) {
 try {
 <nb> public class PersistentHashMap < Key , Value > extends PersistentEnumeratorDelegate <
 private final LowMemoryWatcher myAppendCacheFlusher = LowMemoryWatcher . register ( new Runnable ( ) {
 @ override
 public void run ( ) {
 - LOG . info ( STRING1 ) ;
 dropMemoryCaches ( ) ;
 }
 } ) ;


<nb> import NAMESPACE ;
 COMMENT
 public class DefaultModuleRegistry implements ModuleRegistry {
 private final GradleDistributionLocator gradleDistributionLocator ;
 - private final ClassLoader classLoader ;
 private final Map < String , Module > modules = new HashMap < String , Module > ( ) ;
 private final List < File > classpath = new ArrayList < File > ( ) ;
 private final Map < String , File > classpathJars = new LinkedHashMap < String , File > ( ) ;
 <nb> public class DefaultModuleRegistry implements ModuleRegistry {
 }

 private DefaultModuleRegistry ( ClassLoader classLoader , ClassPath additionalModuleClassPath , GradleDistributionLocator gradleDistributionLocator ) {
 - this . classLoader = classLoader ;
 this . gradleDistributionLocator = gradleDistributionLocator ;

 for ( File classpathFile : new EffectiveClassPath ( classLoader ) . plus ( additionalModuleClassPath ) . getAsFiles ( ) ) {


<nb> import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;
 + import NAMESPACE ;

 COMMENT
 COMMENT
 <nb> public class SocketPacketWriteHandler implements ChannelHandler {
 SINGLE
 routingTable . routePacket ( packet . getFrom ( ) , packet ) ;
 }
 - else {
 + else if ( recipient . getResource ( ) != null || ! ( packet instanceof Presence ) ) {
 + SINGLE
 routingTable . routePacket ( recipient , packet ) ;
 }
 + else {
 + SINGLE
 + for ( JID route : routingTable . getRoutes ( recipient ) ) {
 + routingTable . routePacket ( route , packet ) ;
 + }
 + }
 }
 catch ( Exception e ) {
 Log . error ( LocaleUtils . getLocalizedString ( STRING0 ) + STRING1 + packet . toString ( ) , e ) ;

Fixed routing of Presence packets to bare jids


<nb>

 package NAMESPACE ;

 - import NAMESPACE ;
 -
 import NAMESPACE ;
 import NAMESPACE ;

 <nb> public class GradleWorkerMain {

 public static void main ( String [ ] args ) {
 try {
 - GradleJvmSystem . installSecurity ( ) ;
 new GradleWorkerMain ( ) . run ( ) ;
 - GradleJvmSystem . exit ( NUMBER0 ) ;
 } catch ( Throwable throwable ) {
 throwable . printStackTrace ( System . err ) ;
 - GradleJvmSystem . exit ( NUMBER1 ) ;
 }
 }
 }

Removed the gradle System exit protection from the GradleWorkerMain until I figure out how to fix failing UI tests


<nb> class DetailsPanel extends JPanel implements ListSelectionListener {
 add ( myAuthor , g . nextLine ( ) . next ( ) ) ;
 add ( myCommitMessage , g . nextLine ( ) . next ( ) ) ;

 - setBackground ( UIUtil . getTableBackground ( ) ) ;
 + setOpaque ( false ) ;
 }

 void setData ( VcsCommit commit ) {
 <nb> class DetailsPanel extends JPanel implements ListSelectionListener {
 myCommitMessage . setText ( commit . getFullMessage ( ) ) ;
 repaint ( ) ;
 }
 -
 }

 private static class RefsPanel extends JPanel {
 <nb> class DetailsPanel extends JPanel implements ListSelectionListener {
 myRefPainter = new RefPainter ( ) ;
 myRefs = Collections . emptyList ( ) ;
 setPreferredSize ( new Dimension ( - NUMBER0 , PrintParameters . HEIGHT_CELL + UIUtil . DEFAULT_VGAP ) ) ;
 - setBackground ( UIUtil . getTableBackground ( ) ) ;
 + setOpaque ( false ) ;
 }

 @ override


<nb> import NAMESPACE ;
 COMMENT
 COMMENT
 COMMENT
 - public class NtlmAwareLdapAuthenticatorImpl extends BindAuthenticator {
 + public class NtlmAwareLdapAuthenticator extends BindAuthenticator {
 SINGLE

 - private static final Log logger = LogFactory . getLog ( NtlmAwareLdapAuthenticatorImpl . class ) ;
 + private static final Log logger = LogFactory . getLog ( NtlmAwareLdapAuthenticator . class ) ;

 SINGLE

 - public NtlmAwareLdapAuthenticatorImpl ( InitialDirContextFactory initialDirContextFactory ) {
 + public NtlmAwareLdapAuthenticator ( InitialDirContextFactory initialDirContextFactory ) {
 super ( initialDirContextFactory ) ;
 }

Renamed NtlmAwareLdapAuthenticatorImpl to NtlmAwareLdapAuthenticator as there is no longer a corresponding interface


<nb> public class OpenSSLContext implements org . apache . tomcat . util . net . SSLContext {
 aprPool = Pool . create ( NUMBER0 ) ;
 boolean success = false ;
 try {
 - if ( SSLHostConfig . adjustRelativePath ( certificate . getCertificateFile ( ) ) == null ) {
 - SINGLE
 - SINGLE
 - }
 -
 SINGLE
 int value = SSL . SSL_PROTOCOL_NONE ;
 if ( sslHostConfig . getProtocols ( ) . size ( ) == NUMBER0 ) {


<nb> public final class MidiDeviceInfo implements Parcelable {
 mId = id ;
 mInputPortCount = numInputPorts ;
 mOutputPortCount = numOutputPorts ;
 - mInputPortNames = inputPortNames ;
 - mOutputPortNames = outputPortNames ;
 + if ( inputPortNames == null ) {
 + mInputPortNames = new String [ numInputPorts ] ;
 + } else {
 + mInputPortNames = inputPortNames ;
 + }
 + if ( outputPortNames == null ) {
 + mOutputPortNames = new String [ numOutputPorts ] ;
 + } else {
 + mOutputPortNames = outputPortNames ;
 + }
 mProperties = properties ;
 mIsPrivate = isPrivate ;
 }


<nb> public class KotlinBytecodeToolWindow extends JPanel implements Disposable {
 exhaust . getModuleDescriptor ( ) , exhaust . getBindingContext ( ) ,
 Collections . singletonList ( jetFile ) , true , true ,
 GenerationState . GenerateClassFilter . GENERATE_ALL ,
 - enableInline . isSelected ( ) , enableOptimization . isEnabled ( ) , null , null ,
 + enableInline . isSelected ( ) , enableOptimization . isSelected ( ) , null , null ,
 DiagnosticHolder . DO_NOTHING , null ) ;
 KotlinCodegenFacade . compileCorrectFiles ( state , CompilationErrorHandler . THROW_EXCEPTION ) ;
 }

Fix optimizations check box in bytecode toolwindow


<nb> public class StaticByteBuffer implements StaticBuffer {

 private final ByteBuffer b ;

 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 public StaticByteBuffer ( final ByteBuffer buffer ) {
 Preconditions . checkNotNull ( buffer ) ;
 this . b = buffer ;

Added Javadoc on StaticByteBuffer constructor


<nb> public class BNCCheck {
 private Main prg ;

 private BNCCheck ( ) throws IOException , ParserConfigurationException , SAXException {
 - prg = new Main ( false , Language . ENGLISH ) ;
 + prg = new Main ( false , Language . ENGLISH , null ) ;
 String [ ] disRules = new String [ ] { STRING0 , STRING1 ,
 STRING2 , STRING3 } ;
 System . err . println ( STRING4 ) ;


<nb> public final class Options {
 return this ;
 }

 + COMMENT
 + COMMENT
 + COMMENT
 public Options build ( ) {
 return mOptions ;
 }
 <nb> import NAMESPACE ;
 import NAMESPACE ;

 COMMENT
 - COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 COMMENT
 public class PullToRefreshLayout extends FrameLayout {


<nb> public class TextFileType extends EditableFileType
 results . add ( commands . goToLine ( ) ) ;
 if ( canExecuteCode ( ) || isC ( ) )
 {
 + results . add ( commands . reindent ( ) ) ;
 + }
 + if ( canExecuteCode ( ) ) {
 results . add ( commands . executeCode ( ) ) ;
 results . add ( commands . executeCodeWithoutFocus ( ) ) ;
 results . add ( commands . executeLastCode ( ) ) ;
 results . add ( commands . extractFunction ( ) ) ;
 results . add ( commands . extractLocalVariable ( ) ) ;
 results . add ( commands . commentUncomment ( ) ) ;
 - results . add ( commands . reindent ( ) ) ;
 results . add ( commands . reflowComment ( ) ) ;
 }
 if ( canExecuteAllCode ( ) )


<nb> public abstract class ProcessorDefinition < Type extends ProcessorDefinition < Type >

 COMMENT
 COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 COMMENT
 - COMMENT
 + COMMENT
 COMMENT
 public ChoiceDefinition endChoice ( ) {
 SINGLE


<nb> public class ExcelImporterTests extends ImporterTest {
 private static final double EPSILON = FLOAT0 ;
 private static final int SHEETS = NUMBER0 ;
 private static final int ROWS = NUMBER1 ;
 - private static final int COLUMNS = NUMBER2 ;
 + private static final int COLUMNS = NUMBER3 ;

 SINGLE
 private static final File xlsFile = createSpreadsheet ( false ) ;


<nb> public class SourceLineResultSetIteratorTest {
 @ test
 public void should_generate_source_line_documents ( ) throws Exception {
 db . prepareDbUnit ( getClass ( ) , STRING0 ) ;
 - Connection connection = db . openConnection ( ) ;
 PreparedStatement stmt = connection . prepareStatement ( STRING1 ) ;
 stmt . setString ( NUMBER0 , STRING2 +
 STRING3 +
 <nb> public class SourceLineResultSetIteratorTest {
 @ test
 public void should_fail_on_bad_csv ( ) throws Exception {
 db . prepareDbUnit ( getClass ( ) , STRING0 ) ;
 - Connection connection = db . openConnection ( ) ;
 PreparedStatement stmt = connection . prepareStatement ( STRING1 ) ;
 stmt . setString ( NUMBER0 , STRING4 ) ;
 stmt . executeUpdate ( ) ;


<nb> import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;
 - import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;
 <nb> import NAMESPACE ;
 import NAMESPACE ;

 import static NAMESPACE ;
 - import static NAMESPACE ;

 COMMENT
 COMMENT
 <nb> public class NearCacheImpl implements NearCache < Data , Object > {
 this . serializationService = nodeEngine . getSerializationService ( ) ;
 this . invalidateOnChange = nearCacheConfig . isInvalidateOnChange ( ) ;
 this . mapName = mapName ;
 - int partitionCount = getPartitionCount ( nodeEngine ) ;
 - }
 -
 - private int getPartitionCount ( NodeEngine nodeEngine ) {
 - HazelcastProperties properties = nodeEngine . getProperties ( ) ;
 - return properties . getInteger ( PARTITION_COUNT ) ;
 }

 SINGLE


<nb> import NAMESPACE ;
 COMMENT
 COMMENT
 COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 COMMENT
 COMMENT
 COMMENT

Added remark to Factory Javadocs concerning static imports


<nb> public class PooledByteBufAllocator extends AbstractByteBufAllocator {
 }
 }

 - @ deprecated
 - @ suppresswarnings ( STRING0 )
 - public PooledByteBufAllocator ( boolean preferDirect , int nHeapArena , int nDirectArena , int pageSize , int maxOrder ,
 - int tinyCacheSize , int smallCacheSize , int normalCacheSize ,
 - long cacheThreadAliveCheckInterval ) {
 - this ( preferDirect , nHeapArena , nDirectArena , pageSize , maxOrder ,
 - tinyCacheSize , smallCacheSize , normalCacheSize ) ;
 - }
 -
 @ suppresswarnings ( STRING1 )
 private static < T > PoolArena < T > [ ] newArenaArray ( int size ) {
 return new PoolArena [ size ] ;


<nb> public abstract class RoutingResource {
 boolean tripPlannedForNow = Math . abs ( request . getDateTime ( ) . getTime ( ) - new Date ( ) . getTime ( ) )
 < NOW_THRESHOLD_MILLIS ;
 request . setUseBikeRentalAvailabilityInformation ( tripPlannedForNow ) ;
 - if ( intermediatePlaces != null
 + if ( intermediatePlaces != null && intermediatePlaces . size ( ) > NUMBER0
 && ( request . getModes ( ) . isTransit ( ) ||
 ( request . getModes ( ) . getWalk ( ) &&
 request . getModes ( ) . getBicycle ( ) ) ) )

handle case of empty non null intermediateplaces


<nb> public abstract class XmlElementImpl extends CompositePsiElement implements XmlE
 if ( anchor != null ) {
 final PsiElement original = anchor . retrieve ( ) ;
 if ( original != null ) {
 - final int endOffset = getTextRange ( ) . getEndOffset ( ) ;
 + final int endOffset = getTextRange ( ) . getEndOffset ( ) + original . getTextRange ( ) . getStartOffset ( ) ;

 PsiElement candidate = original . findElementAt ( getTextRange ( ) . getStartOffset ( ) - root . getTextRange ( ) . getStartOffset ( ) ) ;
 - while ( candidate != null && candidate . getTextRange ( ) . getEndOffset ( ) < endOffset ) {
 + while ( candidate != null && candidate . getStartOffsetInParent ( ) == NUMBER0 && candidate . getTextRange ( ) . getEndOffset ( ) < endOffset ) {
 candidate = candidate . getParent ( ) ;
 }


<nb> public final class Icon implements Parcelable {
 }

 COMMENT
 - COMMENT
 - COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 COMMENT
 COMMENT
 COMMENT
 - COMMENT
 - COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 COMMENT
 public void loadDrawableAsync ( Context context , final OnDrawableLoadedListener listener ,
 Handler handler ) {

Fix javadoc for Icon loadDrawableAsync Context OnDrawableLoadedListener Handler


<nb> public class JobExecutorMBean {

 @ managedattribute ( description = STRING0 )
 public boolean isJobExecutorActivated ( ) {
 - return jobExecutor == null || jobExecutor . isActive ( ) ;
 + return jobExecutor != null && jobExecutor . isActive ( ) ;
 }

 @ managedoperation ( description = STRING1 )


<nb> public class HistogramTests extends ESIntegTestCase {

 SINGLE
 int bucketsCount = ( int ) ( ( boundsMaxKey - boundsMinKey ) / interval ) + NUMBER0 ;
 - long [ ] extendedValueCounts = new long [ bucketsCount ] ;
 + long [ ] extendedValueCounts = new long [ valueCounts . length + addedBucketsLeft + addedBucketsRight ] ;
 System . arraycopy ( valueCounts , NUMBER1 , extendedValueCounts , addedBucketsLeft , valueCounts . length ) ;

 SearchResponse response = null ;

TEST fix histogram test when extended bounds overlaps data


<nb> public class ShiftReduceOptions extends Options {
 } else if ( args [ i ] . equalsIgnoreCase ( STRING0 ) ) {
 trainOptions ( ) . cvAveragedModels = false ;
 i ++ ;
 + } else if ( args [ i ] . equalsIgnoreCase ( STRING1 ) ) {
 + trainOptions ( ) . retrainAfterCutoff = true ;
 + i ++ ;
 + } else if ( args [ i ] . equalsIgnoreCase ( STRING2 ) ) {
 + trainOptions ( ) . retrainAfterCutoff = false ;
 + i ++ ;
 } else if ( args [ i ] . equalsIgnoreCase ( STRING3 ) ) {
 trainOptions ( ) . trainingMethod = ShiftReduceTrainOptions . TrainingMethod . valueOf ( args [ i + NUMBER0 ] . toUpperCase ( ) ) ;
 if ( trainOptions ( ) . trainingMethod == ShiftReduceTrainOptions . TrainingMethod . BEAM ||


<nb> public abstract class AbstractHistogram extends AbstractHistogramBase implements
 return ; SINGLE
 }
 final long internalValue = value & ~ unitMagnitudeMask ; SINGLE
 - while ( internalValue < minNonZeroValue ) {
 - minNonZeroValueUpdater . compareAndSet ( this , minNonZeroValue , internalValue ) ;
 + long sampledMinNonZeroValue ;
 + while ( internalValue < ( sampledMinNonZeroValue = minNonZeroValue ) ) {
 + minNonZeroValueUpdater . compareAndSet ( this , sampledMinNonZeroValue , internalValue ) ;
 }
 }


<nb> import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;
 - import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;

 - import NAMESPACE ;
 - import NAMESPACE ;
 -
 import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;


<nb> public abstract class BaseStatusBar extends SystemUI implements

 protected void hideRecents ( boolean triggeredFromAltTab ) {
 if ( mRecents != null ) {
 - sendCloseSystemWindows ( mContext , SYSTEM_DIALOG_REASON_RECENT_APPS ) ;
 mRecents . hideRecents ( triggeredFromAltTab ) ;
 }
 }

Should not be closing system dialogs when Recents is hidden


<nb> public class ConstantBranchPruner extends TreeVisitor {
 @ override
 public void endVisit ( DoStatement node ) {
 if ( getValue ( node . getExpression ( ) ) == FALSE ) {
 - node . remove ( ) ;
 + node . replaceWith ( node . getBody ( ) . copy ( ) ) ;
 }
 }

 <nb> public class ConstantBranchPrunerTest extends GenerationTest {
 assertTranslatedLines ( translation , STRING0 , STRING1 , STRING2 , STRING3 ) ;
 }

 + SINGLE
 + public void testFalseDoExpression ( ) throws IOException {
 + String translation = translateSourceFile (
 + STRING4 ,
 + STRING5 , STRING6 ) ;
 + assertTranslatedLines ( translation , STRING7 , STRING8 , STRING9 , STRING2 , STRING2 ) ;
 + translation = translateSourceFile (
 + STRING10
 + + STRING11 ,
 + STRING5 , STRING6 ) ;
 + assertTranslatedLines ( translation , STRING7 , STRING8 , STRING9 , STRING2 , STRING2 ) ;
 + }
 +
 SINGLE
 public void testTrueIfExpression ( ) throws IOException {
 String translation = translateSourceFile (

Keep the do stmt body if the const exp is false


<nb> public class InternalComponentManager implements ComponentManager , RoutableChann
 }
 }
 catch ( Exception e ) {
 - Log . error ( STRING0 +
 - packet . toXML ( ) , e ) ;
 + Log . error ( STRING1 + component +
 + STRING2 + packet . toXML ( ) , e ) ;
 }
 }
 }

Added try catch when processing disco packet of external component


<nb> public class MediaCommandPlayerImpl extends AbstractPrologCommandPlayer {
 }

 @ override
 - public String [ ] getLibraries ( ) {
 - return new String [ ] { STRING0 } ;
 - }
 -
 - @ override
 public void playCommands ( CommandBuilder builder ) {
 filesToPlay . addAll ( builder . execute ( ) ) ;
 playQueue ( ) ;


<nb> public class K9 extends Application {

 public static boolean startIntegratedInbox ( ) {
 - return ! mHideSpecialAccounts && mStartIntegratedInbox ;
 + return mStartIntegratedInbox ;
 }

 public static void setStartIntegratedInbox ( boolean startIntegratedInbox ) {

Removed dup check keeping the more explicit one per cketti recommendation


<nb> public class TestChaosMonkeyResource {
 }

 @ test
 - public void testServlet ( ) {
 + public void testResource ( ) {
 MonkeyRunner . getInstance ( ) . replaceMonkey ( BasicChaosMonkey . class , MockTestChaosMonkeyContext . class ) ;

 ChaosMonkeyResource resource = new ChaosMonkeyResource ( ) ;


<nb> import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;
 + import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;
 <nb> public class UsbDeviceManager {
 }

 private static boolean containsFunction ( String functions , String function ) {
 - int index = functions . indexOf ( function ) ;
 - if ( index < NUMBER0 ) return false ;
 - if ( index > NUMBER0 && functions . charAt ( index - NUMBER1 ) != STRING0 ) return false ;
 - int charAfter = index + function . length ( ) ;
 - if ( charAfter < functions . length ( ) && functions . charAt ( charAfter ) != STRING0 ) return false ;
 - return true ;
 + return Arrays . asList ( functions . split ( STRING1 ) ) . contains ( function ) ;
 }

 private final class UsbHandler extends Handler {


<nb> public class Glide {
 private static Glide GLIDE ;
 private final GenericLoaderFactory loaderFactory = new GenericLoaderFactory ( ) ;
 private final RequestQueue requestQueue ;
 - private ImageManager imageManager = null ;
 + private final ImageManager imageManager ;

 COMMENT
 COMMENT


<nb>
 package NAMESPACE ;

 - import static NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;
 <nb> public class FrameSplitter extends H2OCountedCompleter {
 SINGLE
 assert cs [ i ] . _len == splits [ _partIdx ] ; SINGLE
 SINGLE
 - extractChunkPart ( _srcVecs [ i ] . chunkForChunkIdx ( cidx ) , cs [ i ] , startRow , splits [ _partIdx ] , _fs ) ;
 + ChunkSplitter . extractChunkPart ( _srcVecs [ i ] . chunkForChunkIdx ( cidx ) , cs [ i ] , startRow , splits [ _partIdx ] , _fs ) ;
 SINGLE
 }
 }
 <nb> import NAMESPACE ;
 COMMENT
 COMMENT
 COMMENT
 - public class NewChunkHelper {
 + public class ChunkSplitter {
 COMMENT
 public static NewChunk resetLen ( NewChunk nc ) {
 nc . _len = nc . _len2 = NUMBER0 ;


<nb> public class ODocument extends ORecordAbstract implements Iterable < Entry < String ,
 if ( _fields != null && ! _fields . isEmpty ( ) ) {
 boolean allFound = true ;
 for ( String f : iFields )
 - if ( ! f . startsWith ( STRING0 ) && ! _fields . containsKey ( f ) ) {
 + if ( f != null && ! f . startsWith ( STRING0 ) && ! _fields . containsKey ( f ) ) {
 allFound = false ;
 break ;
 }


<nb> public class CodeItem extends OffsettedItem < CodeItem > {
 return ItemType . TYPE_CODE_ITEM ;
 }

 + public int getRegisterCount ( ) {
 + return registersCountField . getCachedValue ( ) ;
 + }
 +
 + public List < InstructionField > getInstructions ( ) {
 + return ( List < InstructionField > ) instructionList . clone ( ) ;
 + }
 +
 public void copyTo ( DexFile dexFile , CodeItem copy )
 {
 for ( int i = NUMBER0 ; i < fields . length - NUMBER1 ; i ++ ) {


<nb> public class HttpServer extends AbstractLifecycleComponent < HttpServer > {
 if ( logger . isInfoEnabled ( ) ) {
 logger . info ( STRING0 , transport . boundAddress ( ) ) ;
 }
 - nodeService . putNodeAttribute ( STRING1 , transport . boundAddress ( ) . publishAddress ( ) . toString ( ) ) ;
 + nodeService . putAttribute ( STRING1 , transport . boundAddress ( ) . publishAddress ( ) . toString ( ) ) ;
 }

 @ override
 protected void doStop ( ) throws ElasticSearchException {
 - nodeService . removeNodeAttribute ( STRING1 ) ;
 + nodeService . removeAttribute ( STRING1 ) ;
 transport . stop ( ) ;
 }


<nb> public class BuckConfig {
 return Boolean . parseBoolean ( getValue ( STRING0 , STRING1 ) . or ( STRING2 ) ) ;
 }

 + public boolean getFlushEventsBeforeExit ( ) {
 + return getBooleanValue ( STRING3 , STRING4 , false ) ;
 + }
 +
 public ImmutableSet < String > getListenerJars ( ) {
 String jarPathsString = getValue ( STRING5 , STRING6 ) . or ( STRING7 ) ;
 Splitter splitter = Splitter . on ( STRING8 ) . omitEmptyStrings ( ) . trimResults ( ) ;
 <nb> public final class Main {
 } finally {
 commandSemaphore . release ( ) ; SINGLE
 }
 - if ( isDaemon ) {
 + if ( isDaemon && ! config . getFlushEventsBeforeExit ( ) ) {
 context . get ( ) . in . close ( ) ; SINGLE
 context . get ( ) . exit ( exitCode ) ; SINGLE
 }

Create a setting for not flushing event listeners after buckd returns


<nb> public class EditPOIFilterActivity extends OsmandListActivity {
 }

 public ListView selectAllFromCategory ( PoiCategory poiCategory ) {
 - filter . selectSubTypesToAccept ( poiCategory , null ) ;
 + filter . updateTypesToAccept ( poiCategory ) ;
 helper . editPoiFilter ( filter ) ;
 ListView lv = this . getListView ( ) ;
 AmenityAdapter la = this . getListAdapter ( ) ;


<nb> import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;

 + import static NAMESPACE ;
 import static NAMESPACE ;

 public class DefaultIssueQueryResultTest {
 +
 + @ test ( expected = IllegalArgumentException . class )
 + public void should_first_throw_exception_if_no_issue ( ) {
 + DefaultIssueQueryResult result = new DefaultIssueQueryResult ( Collections . < Issue > emptyList ( ) ) ;
 + result . first ( ) ;
 + }
 +
 @ test
 public void test_first_issue ( ) {
 - DefaultIssueQueryResult result = new DefaultIssueQueryResult ( Collections . < Issue > emptyList ( ) ) ;
 - assertThat ( result . first ( ) ) . isNull ( ) ;
 + DefaultIssueQueryResult result = new DefaultIssueQueryResult ( newArrayList ( ( Issue ) new DefaultIssue ( ) ) ) ;
 + assertThat ( result . first ( ) ) . isNotNull ( ) ;

 Issue first = new DefaultIssue ( ) ;
 Issue second = new DefaultIssue ( ) ;


<nb> import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;
 + import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;
 <nb> public final class WindowManagerImpl extends WindowManagerEx implements NamedCom
 myProject2Frame . put ( null , frame ) ;

 if ( myFrameBounds == null || ! ScreenUtil . isVisible ( myFrameBounds ) ) { SINGLE
 - final Rectangle rect = ScreenUtil . getMainScreenBounds ( ) ;
 - int yParts = rect . height / NUMBER0 ;
 - int xParts = rect . width / NUMBER1 ;
 - myFrameBounds = new Rectangle ( xParts / NUMBER2 , yParts / NUMBER2 , xParts * NUMBER3 , yParts * NUMBER4 ) ;
 + myFrameBounds = ScreenUtil . getMainScreenBounds ( ) ;
 + int xOff = myFrameBounds . width / NUMBER5 ;
 + int yOff = myFrameBounds . height / NUMBER5 ;
 + JBInsets . removeFrom ( myFrameBounds , new Insets ( yOff , xOff , yOff , xOff ) ) ;
 }

 fixForOracleBug8007219 ( frame ) ;

change the initial size of the main frame


<nb> public class NearCacheTest extends HazelcastTestSupport {
 @ test
 COMMENT
 COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 COMMENT
 public void testCacheLocalEntries ( ) {
 int n = NUMBER0 ;

add specific note to NearCacheTest testCacheLocalEntries


<nb> public class TextToSpeech {
 result = mITts . setLanguage ( mCachedParams [ Engine . TTS_PARAM_POSITION_LANGUAGE + NUMBER0 ] ,
 mCachedParams [ Engine . TTS_PARAM_POSITION_COUNTRY + NUMBER0 ] ,
 mCachedParams [ Engine . TTS_PARAM_POSITION_VARIANT + NUMBER0 ] ) ;
 + } catch ( RemoteException e ) {
 SINGLE
 mStarted = false ;
 initTts ( ) ;


<nb> import NAMESPACE ;
 import NAMESPACE ;

 COMMENT
 - COMMENT
 - COMMENT
 - COMMENT
 + COMMENT
 + COMMENT
 COMMENT
 COMMENT
 COMMENT
 <nb> public class PojoRouteTest extends TestCase {
 SINGLE
 camelContext . addRoutes ( new RouteBuilder ( ) {
 public void configure ( ) {
 - from ( STRING0 ) . to ( STRING1 ) ;
 + from ( STRING0 ) . to ( STRING2 ) ;
 }
 } ) ;
 SINGLE

Updated wiki sample to use bean instead of pojo that is deprecated


<nb> public class SimpleAttributes2GrantedAuthoritiesMapper implements Attributes2Gra
 return attributePrefix == null ? STRING0 : attributePrefix ;
 }

 - public void seAttributePrefix ( String string ) {
 + public void setAttributePrefix ( String string ) {
 attributePrefix = string ;
 }

Fixed typo in setter method seAttributePrefix


<nb> import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;
 + import NAMESPACE ;
 import NAMESPACE ;
 - import static NAMESPACE ;

 public class TestGlobalCount extends BaseRichBolt {
 <nb> public class TestGlobalCount extends BaseRichBolt {

 public void execute ( Tuple input ) {
 _count ++ ;
 - _collector . emit ( tuple ( _count ) ) ;
 + _collector . emit ( input , new Values ( _count ) ) ;
 _collector . ack ( input ) ;
 }

fix TestGlobalCount to anchor tuples to it doesn t cause errors in tests


<nb> public class Message extends AbstractEntity {

 public static final String TABLENAME = STRING0 ;

 - public static final String MERGE_SEPARATOR = STRING1 ;
 + public static final String MERGE_SEPARATOR = STRING2 ;

 public static final int STATUS_RECEIVED = NUMBER0 ;
 public static final int STATUS_UNSEND = NUMBER1 ;


<nb> public class SqlProducer extends DefaultProducer {
 } else {
 boolean isResultSet = ps . execute ( ) ;
 if ( isResultSet ) {
 + SINGLE
 + exchange . getOut ( ) . getHeaders ( ) . putAll ( exchange . getIn ( ) . getHeaders ( ) ) ;
 +
 ResultSet rs = ps . getResultSet ( ) ;
 SqlOutputType outputType = getEndpoint ( ) . getOutputType ( ) ;
 log . trace ( STRING0 , rs , outputType ) ;
 <nb> public class SqlProducer extends DefaultProducer {
 } else {
 throw new IllegalArgumentException ( STRING1 + outputType ) ;
 }
 -
 - SINGLE
 - exchange . getOut ( ) . getHeaders ( ) . putAll ( exchange . getIn ( ) . getHeaders ( ) ) ;
 } else {
 exchange . getIn ( ) . setHeader ( SqlConstants . SQL_UPDATE_COUNT , ps . getUpdateCount ( ) ) ;
 }

Fixed sql producer setting header after preserving


<nb> public class TemplateManagerImpl extends TemplateManager implements ProjectCompo
 }
 }

 - private static boolean containsTemplateStartingBefore ( Map < TemplateImpl , String > template2argument ,
 - int offset ,
 - int caretOffset ,
 - CharSequence text ) {
 - for ( TemplateImpl template : template2argument . keySet ( ) ) {
 - String argument = template2argument . get ( template ) ;
 - int templateStart = getTemplateStart ( template , argument , caretOffset , text ) ;
 - if ( templateStart <= offset ) {
 - return true ;
 - }
 - }
 - return false ;
 - }
 -
 public boolean startTemplate ( final Editor editor , char shortcutChar , final PairProcessor < String , String > processor ) {
 PsiFile file = PsiUtilBase . getPsiFileInEditor ( editor , myProject ) ;
 if ( file == null ) return false ;


<nb> public class RandomSeedGenerator {
 if ( log . isInfoEnabled ( ) ) {
 log . info ( STRING0 + value . asFormatString ( ) ) ;
 }
 - writer . append ( new Text ( key . toString ( ) ) , new Cluster ( value ) ) ;
 + Cluster val = new Cluster ( value ) ;
 + val . addPoint ( value ) ;
 + writer . append ( new Text ( key . toString ( ) ) , val ) ;
 count ++ ;
 }
 }


<nb> import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;

 - abstract class GitPushSource implements PushSource {
 + public abstract class GitPushSource implements PushSource {

 @ notnull
 - static GitPushSource create ( @ notnull GitLocalBranch branch ) {
 + public static GitPushSource create ( @ notnull GitLocalBranch branch ) {
 return new OnBranch ( branch ) ;
 }

 @ notnull
 - static GitPushSource create ( @ notnull String revision ) {
 + public static GitPushSource create ( @ notnull String revision ) {
 return new DetachedHead ( revision ) ;
 }

git Make GitPushSource public to let it available from plugins


<nb> public class SedaAsyncRouteTest extends ContextTestSupport {
 MockEndpoint mock = getMockEndpoint ( STRING0 ) ;
 mock . expectedBodiesReceived ( STRING1 ) ;

 + SINGLE
 Object out = template . requestBody ( STRING2 , STRING1 ) ;
 assertEquals ( STRING3 , out ) ;
 + SINGLE

 assertMockEndpointsSatisfied ( ) ;
 }
 <nb> public class SedaAsyncRouteTest extends ContextTestSupport {
 @ override
 protected RouteBuilder createRouteBuilder ( ) throws Exception {
 return new RouteBuilder ( ) {
 + SINGLE
 public void configure ( ) throws Exception {
 from ( STRING2 )
 SINGLE
 <nb> public class SedaAsyncRouteTest extends ContextTestSupport {

 from ( STRING4 ) . to ( STRING0 ) ;
 }
 + SINGLE
 } ;
 }
 }


<nb>
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 package NAMESPACE ;

 import NAMESPACE ;


<nb> public class InlineMarker {
 public static void afterInlineCall ( ) {

 }
 -
 - public static void beforeLambdaCall ( ) {
 -
 - }
 -
 - public static void afterLambdaCall ( ) {
 -
 - }
 -
 - }
 + }


<nb> public class BuiltInCheckerSuppliers {
 LongLiteralLowerCaseSuffix . class ,
 MislabeledAndroidString . class ,
 MisusedWeekYear . class ,
 + MockitoCast . class ,
 MockitoUsage . class ,
 NonCanonicalStaticImport . class ,
 NonFinalCompileTimeConstant . class ,
 <nb> public class BuiltInCheckerSuppliers {
 MissingCasesInEnumSwitch . class ,
 MissingFail . class ,
 MissingOverride . class ,
 - MockitoCast . class ,
 ModifyingCollectionWithItself . class ,
 NarrowingCompoundAssignment . class ,
 NoAllocationChecker . class ,


<nb> public class StringUtil

 public static String ensureSurroundedWith ( String string , char chr )
 {
 + if ( isNullOrEmpty ( string ) )
 + return STRING0 ;
 String result = string ;
 if ( result . charAt ( NUMBER0 ) != chr )
 result = chr + result ;


<nb> public class TtsService extends Service implements OnCompletionListener {
 if ( mSpeechQueue . size ( ) > NUMBER0 ) {
 mSpeechQueue . remove ( NUMBER0 ) ;
 }
 - } catch ( InterruptedException e ) {
 - Log . e ( STRING0 , STRING1 ) ;
 - e . printStackTrace ( ) ;
 } finally {
 SINGLE
 SINGLE


<nb> import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;
 + import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;
 <nb> public class DruidMasterTest

 EasyMock . expect ( serverInventoryView . getInventoryValue ( STRING0 ) ) . andReturn ( druidServer ) ;
 EasyMock . expect ( serverInventoryView . getInventoryValue ( STRING1 ) ) . andReturn ( druidServer ) ;
 + EasyMock . expect ( serverInventoryView . getInventoryManagerConfig ( ) ) . andReturn ( new InventoryManagerConfig ( )
 + {
 + @ override
 + public String getContainerPath ( )
 + {
 + return STRING2 ;
 + }
 +
 + @ override
 + public String getInventoryPath ( )
 + {
 + return STRING2 ;
 + }
 + } ) ;
 EasyMock . replay ( serverInventoryView ) ;

 master . moveSegment ( STRING0 , STRING1 , STRING3 , null ) ;


<nb> public interface GroovyContext extends Context {
 COMMENT
 COMMENT
 COMMENT
 + COMMENT
 COMMENT
 void byMethod ( @ delegatesto ( GroovyByMethodSpec . class ) Closure < ? > closure ) throws Exception ;

 <nb> public interface GroovyContext extends Context {
 COMMENT
 COMMENT
 COMMENT
 + COMMENT
 COMMENT
 void byContent ( @ delegatesto ( GroovyByContentSpec . class ) Closure < ? > closure ) throws Exception ;


<nb> final class Utils {
 return NUMBER0 ;
 }
 return cursor . getInt ( NUMBER0 ) ;
 - } catch ( IllegalArgumentException ignored ) {
 + } catch ( RuntimeException ignored ) {
 SINGLE
 return NUMBER0 ;
 } finally {

Catch a more general exception when checking for rotation from content


<nb> import NAMESPACE ;

 import NAMESPACE ;
 import NAMESPACE ;
 + import NAMESPACE ;
 + import NAMESPACE ;
 import NAMESPACE ;
 - import NAMESPACE ;
 - import NAMESPACE ;

 import NAMESPACE ;
 import NAMESPACE ;
 <nb> import NAMESPACE ;
 COMMENT
 COMMENT
 @ stateless
 + @ transactionmanagement ( TransactionManagementType . BEAN )
 public class ScheduledTasks {

 @ inject
 <nb> public class ScheduledTasks {
 @ inject
 DatabaseCleaningService cleaner ;

 - @ persistencecontext
 - EntityManager em ;
 -
 COMMENT
 COMMENT
 COMMENT

create a new transaction for each delete chunk


<nb> public class DefaultSensorContext implements SensorContext {
 }

 private Resource resourceOrProject ( Resource resource ) {
 - return resource != null ? getResource ( resource ) : project ;
 + if ( resource == null ) {
 + return project ;
 + }
 + Resource indexedResource = getResource ( resource ) ;
 + return indexedResource != null ? indexedResource : resource ;
 }

 @ override


<nb> public class ChangeContextUtil {
 }

 public static void encodeContextInfo ( PsiElement scope , boolean includeRefClasses , boolean canChangeQualifier ) {
 - encodeContextInfo ( scope , scope , includeRefClasses , true ) ;
 + encodeContextInfo ( scope , scope , includeRefClasses , canChangeQualifier ) ;
 }

 private static void encodeContextInfo ( PsiElement scope ,


<nb> public abstract class AAnimationObject3D extends BaseObject3D {
 mIsPlaying = false ;
 }

 + public boolean isPlaying ( ) {
 + return mIsPlaying ;
 + }
 +
 public int getFps ( ) {
 return mFps ;
 }


<nb> public final class Tools {
 COMMENT
 COMMENT
 COMMENT
 - public static void checkText ( final String contents , JLanguageTool lt ) throws IOException {
 + public static int checkText ( final String contents , JLanguageTool lt ) throws IOException {
 long startTime = System . currentTimeMillis ( ) ;
 List < RuleMatch > ruleMatches = lt . check ( contents ) ;
 long startTimeMatching = System . currentTimeMillis ( ) ;
 <nb> public final class Tools {
 System . out . printf ( Locale . ENGLISH ,
 STRING0 ,
 time , endTime - startTimeMatching , lt . getSentenceCount ( ) , sentencesPerSecond ) ;
 + return ruleMatches . size ( ) ;
 }

 public static InputStream getInputStream ( final String resourcePath ) throws IOException {


<nb> public class Fiber < V > extends Strand implements Joinable < V > , Serializable , Futur
 private void installFiberDataInThread ( Thread currentThread ) {
 record ( NUMBER0 , STRING0 , STRING1 , STRING2 , this , currentThread ) ;
 installFiberLocals ( currentThread ) ;
 - setCurrentFiber ( this , currentThread ) ;
 installFiberContextClassLoader ( currentThread ) ;
 if ( MAINTAIN_ACCESS_CONTROL_CONTEXT )
 installFiberInheritedAccessControlContext ( currentThread ) ;
 + setCurrentFiber ( this , currentThread ) ;
 }

 private void restoreThreadData ( Thread currentThread , Object old ) {

Reorder setCurrentFiber in installFiberDataInThread


<nb>
 package NAMESPACE ;

 import NAMESPACE ;
 + import NAMESPACE ;
 +
 import NAMESPACE ;

 COMMENT
 <nb> import NAMESPACE ;
 COMMENT
 COMMENT
 @ incubating
 + @ nonextensible
 public interface ComponentMetadataDetails {
 COMMENT
 COMMENT

Don t make ComponentMetadataDetails extensible


<nb> public final class TableInfo {
 for ( Field field : fields ) {
 if ( field . isAnnotationPresent ( Column . class ) ) {
 final Column columnAnnotation = field . getAnnotation ( Column . class ) ;
 - mColumnNames . put ( field , columnAnnotation . name ( ) ) ;
 + String columnName = columnAnnotation . name ( ) ;
 + if ( columnName == null || columnName . isEmpty ( ) ) {
 + columnName = field . getName ( ) ;
 + }
 + mColumnNames . put ( field , columnName ) ;
 }
 }
 }
 <nb>
 - package NAMESPACE ;
 + package NAMESPACE ;

 COMMENT
 COMMENT
 <nb> public @ interface Column {
 SET_NULL , SET_DEFAULT , CASCADE , RESTRICT , NO_ACTION
 }

 - public String name ( ) ;
 + public String name ( ) default STRING0 ;

 public int length ( ) default - NUMBER0 ;


<nb> public final class DocumentsContract {

 final ProviderInfo info = context . getPackageManager ( )
 . resolveContentProvider ( uri . getAuthority ( ) , PackageManager . GET_META_DATA ) ;
 - if ( info . metaData != null && info . metaData . containsKey (
 + if ( info != null && info . metaData != null && info . metaData . containsKey (
 DocumentsContract . META_DATA_DOCUMENT_PROVIDER ) ) {
 return true ;
 }


<nb> public class DribbbleSearch {
 . host ( STRING0 )
 . addPathSegment ( STRING1 )
 . addQueryParameter ( STRING2 , query )
 + . addQueryParameter ( STRING3 , sort )
 . addQueryParameter ( STRING4 , String . valueOf ( page ) )
 . addQueryParameter ( STRING5 , STRING6 )
 . build ( ) ;

Re added accidentally dropped sort order


<nb> public class OnCompletionProcessor extends ServiceSupport implements AsyncProces
 exchange . setProperty ( Exchange . ROLLBACK_ONLY , rollbackOnly ) ;
 }
 if ( rollbackOnlyLast != null ) {
 - exchange . setProperty ( Exchange . ROLLBACK_ONLY , rollbackOnlyLast ) ;
 + exchange . setProperty ( Exchange . ROLLBACK_ONLY_LAST , rollbackOnlyLast ) ;
 }
 if ( cause != null ) {
 exchange . setException ( cause ) ;

Fixed wrong restore of property in onCompletion


<nb> public class InMemoryDependencyMetadataCache implements Stoppable {

 private final static Logger LOG = Logging . getLogger ( InMemoryDependencyMetadataCache . class ) ;

 - Map < String , DependencyMetadataCache > cachePerRepo = new MapMaker ( ) . softValues ( ) . makeMap ( ) ;
 + Map < String , DependencyMetadataCache > cachePerRepo = new MapMaker ( ) . makeMap ( ) ;

 final DependencyMetadataCacheStats stats = new DependencyMetadataCacheStats ( ) ;

In memory dependency metadata cache no longer uses soft references


<nb> public class MetricReporterService extends AbstractPollingReporter implements Me
 tg = tg . getParent ( ) ;
 }

 - Thread [ ] t = new Thread [ tg . activeCount ( ) ] ;
 - tg . enumerate ( t ) ;
 -
 - for ( Thread thread : t )
 - {
 - System . out . println ( thread . getName ( ) ) ;
 - }
 -
 return tg . activeCount ( ) ;
 }
 }

Removed debug statement that printed out threads


<nb> public class DatabaseMetadata {
 initSequences ( connection , dialect ) ;
 }

 - private static final String [ ] TYPES = { STRING0 , STRING1 } ;
 + private static final String [ ] TYPES = { STRING0 , STRING1 , STRING2 } ;

 public TableMetadata getTableMetadata ( String name , String schema , String catalog , boolean isQuoted ) throws HibernateException {

Adding SYNONYM in the list of searched types


<nb> public class ClassProto implements TypeProto {
 SINGLE
 @ nonnull
 private Method [ ] loadVtable ( ) {
 - SINGLE
 List < Method > virtualMethodList = Lists . newLinkedList ( ) ;

 SINGLE


<nb> public class ListItemAdapter extends ArrayAdapter < ListItem > {
 }
 final Jid jid = item . getJid ( ) ;
 if ( jid != null ) {
 + tvJid . setVisibility ( View . VISIBLE ) ;
 tvJid . setText ( jid . toString ( ) ) ;
 } else {
 - tvJid . setText ( STRING0 ) ;
 + tvJid . setVisibility ( View . GONE ) ;
 }
 tvName . setText ( item . getDisplayName ( ) ) ;
 loadAvatar ( item , picture ) ;

hide jid row in list item list when jid is null


<nb> public abstract class Expr < D > {
 public D getConstant ( ) { return constant ; }
 @ override public java . lang . String toString ( ) { return constant . toString ( ) ; }
 }
 -
 +
 SINGLE
 SINGLE
 SINGLE


<nb> public class ReferrerPushStrategy implements PushStrategy
 this . referrerPushPeriod = referrerPushPeriod ;
 }

 + public Set < Pattern > getPushRegexps ( )
 + {
 + return pushRegexps ;
 + }
 +
 + public Set < String > getPushContentTypes ( )
 + {
 + return pushContentTypes ;
 + }
 +
 + public Set < Pattern > getAllowedPushOrigins ( )
 + {
 + return allowedPushOrigins ;
 + }
 +
 + public Set < Pattern > getUserAgentBlacklist ( )
 + {
 + return userAgentBlacklist ;
 + }
 +
 + public int getMaxAssociatedResources ( )
 + {
 + return maxAssociatedResources ;
 + }
 +
 + public int getReferrerPushPeriod ( )
 + {
 + return referrerPushPeriod ;
 + }
 +
 @ override
 public Set < String > apply ( Stream stream , Fields requestHeaders , Fields responseHeaders )
 {

Add getters to expose ReferrerPushStrategy Config


<nb> import NAMESPACE ;
 COMMENT
 COMMENT
 COMMENT
 + COMMENT
 + COMMENT
 COMMENT
 COMMENT
 COMMENT

Added note on requirement of columnAnnotation for ExtendedBeanSerializer


<nb> public abstract class BinaryBlockReader < M > {
 }

 int blockSize = readInt ( ) ;
 - LOG . debug ( STRING0 + blockSize ) ;
 + if ( LOG . isDebugEnabled ( ) ) {
 + LOG . debug ( STRING0 + blockSize ) ;
 + }
 if ( blockSize < NUMBER0 ) {
 LOG . debug ( STRING1 ) ;
 SINGLE

Don t allocate strings and do concat if debug mode isn t enabled


<nb> public class BuildManager implements ApplicationComponent {
 }

 for ( Project project : activeProjects ) {
 - if ( ProjectRootManager . getInstance ( project ) . getFileIndex ( ) . isInContent ( eventFile ) ) {
 + if ( ! project . isInitialized ( ) || ProjectRootManager . getInstance ( project ) . getFileIndex ( ) . isInContent ( eventFile ) ) {
 return true ;
 }
 }

skip project content check for not yet initialized projects


<nb> public class ShowcaseViews {
 }

 public void addView ( ItemViewProperties properties ) {
 - ShowcaseViewBuilder builder = new ShowcaseViewBuilder ( activity , showcaseTemplateId )
 + ShowcaseViewBuilder builder = new ShowcaseViewBuilder ( activity )
 . setText ( properties . titleResId , properties . messageResId )
 . setShowcaseIndicatorScale ( properties . scale ) ;


<nb> import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;
 + import NAMESPACE ;
 + import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;
 <nb> public final class SslCertificateServiceImpl implements SslCertificateService {

 certGen . addExtension ( Extension . subjectKeyIdentifier , false , new SubjectKeyIdentifier ( pubKey . getEncoded ( ) ) ) ;
 certGen . addExtension ( Extension . basicConstraints , false , new BasicConstraints ( false ) ) ;
 + certGen . addExtension ( Extension . subjectAlternativeName , false , new GeneralNames ( new GeneralName ( GeneralName . dNSName , hostname ) ) ) ;

 ContentSigner sigGen ;
 try {

include SubjectAlternativeName extension in generated certificates


<nb> public class NetworkManager extends Plugin {
 if ( action . equals ( STRING0 ) ) {
 this . connectionCallbackId = callbackId ;
 NetworkInfo info = sockMan . getActiveNetworkInfo ( ) ;
 - PluginResult pluginResult = new PluginResult ( status , this . getConnectionInfo ( info ) ) ;
 + PluginResult pluginResult = new PluginResult ( PluginResult . Status . OK , this . getConnectionInfo ( info ) ) ;
 pluginResult . setKeepCallback ( true ) ;
 return pluginResult ;
 }


<nb> public class DriverConnection extends DriverConnectionPadding3 implements AutoCl

 if ( changeNumber == beginLossChange )
 {
 - System . out . format ( STRING0 , termId , termOffset , length ) ;
 channelEndpoint . sendNakMessage ( controlAddress , sessionId , streamId , termId , termOffset , length ) ;
 lastChangeNumber = changeNumber ;
 systemCounters . nakMessagesSent ( ) . orderedIncrement ( ) ;
 <nb> public class LossDetector
 COMMENT
 COMMENT
 public LossDetector (
 - final TimerWheel wheel ,
 - final FeedbackDelayGenerator delayGenerator ,
 - final NakMessageSender nakMessageSender )
 + final TimerWheel wheel , final FeedbackDelayGenerator delayGenerator , final NakMessageSender nakMessageSender )
 {
 this . wheel = wheel ;
 this . timer = wheel . newBlankTimer ( ) ;


<nb> import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;
 + import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;
 <nb> import NAMESPACE ;

 import NAMESPACE ;

 - @ registersystem
 + @ registersystem ( RegisterMode . AUTHORITY )
 public class PlayerStartingInventorySystem extends BaseComponentSystem {

 private static final Logger logger = LoggerFactory . getLogger ( PlayerStartingInventorySystem . class ) ;
 <nb> public class PlayerStartingInventorySystem extends BaseComponentSystem {
 inventoryManager . giveItem ( player , EntityRef . NULL , entityManager . create ( STRING0 ) ) ;
 inventoryManager . giveItem ( player , EntityRef . NULL , chest ) ;
 }
 -
 -
 - @ command
 - public String test ( @ commandparam ( STRING1 ) String first , @ commandparam ( STRING2 ) String . . . remainder ) {
 - logger . info ( STRING3 , first , Arrays . asList ( remainder ) ) ;
 - return first + STRING4 + Arrays . asList ( remainder ) . toString ( ) ;
 - }
 }

Fixing the PlayerStartingInventorySystem to only be run on AUTHORITY and removing some random debug code


<nb> public class CordovaActivity extends Activity implements CordovaInterface {
 protected void onResume ( ) {
 super . onResume ( ) ;
 LOG . d ( TAG , STRING0 ) ;
 - SINGLE
 - Config . init ( this ) ;

 if ( this . activityState == ACTIVITY_STARTING ) {
 this . activityState = ACTIVITY_RUNNING ;


<nb> import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;
 + import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;
 <nb> public class CameraDeviceImpl extends CameraDevice {
 private volatile StateCallbackKK mSessionStateCallback ;
 private final Handler mDeviceHandler ;

 - private volatile boolean mClosing = false ;
 + private final AtomicBoolean mClosing = new AtomicBoolean ( ) ;
 private boolean mInError = false ;
 private boolean mIdle = true ;

 <nb> public class CameraDeviceImpl extends CameraDevice {
 @ override
 public void close ( ) {
 synchronized ( mInterfaceLock ) {
 + if ( mClosing . getAndSet ( true ) ) {
 + return ;
 + }
 +
 try {
 if ( mRemoteDevice != null ) {
 mRemoteDevice . disconnect ( ) ;
 <nb> public class CameraDeviceImpl extends CameraDevice {

 COMMENT
 private boolean isClosed ( ) {
 - return mClosing ;
 + return mClosing . get ( ) ;
 }

 private CameraCharacteristics getCharacteristics ( ) {

Make CameraDeviceImpl close idempotent for real


<nb> public final class Settings {
 STRING0 ;

 COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + public static final String VENDING_DOWNLOADING_KICK_TIMEOUT_MS =
 + STRING1 ;
 +
 + COMMENT
 COMMENT
 COMMENT
 public static final String VENDING_DISK_INPUT_BUFFER_BYTES =

Add Gservices flag for Vending doctor download complete timeout


<nb> public class Scene extends BaseEntity {
 }

 public void updatePreFrameHandlers ( final float pSecondsElapsed ) {
 - if ( this . mChildScene == null && ! this . mChildSceneModalUpdate ) {
 + if ( this . mChildScene == null || ! this . mChildSceneModalUpdate ) {
 this . mPreFrameHandlers . onUpdate ( pSecondsElapsed ) ;
 }

 <nb> public class Scene extends BaseEntity {
 }

 public void updatePostFrameHandlers ( final float pSecondsElapsed ) {
 - if ( this . mChildScene == null && ! this . mChildSceneModalUpdate ) {
 + if ( this . mChildScene == null || ! this . mChildSceneModalUpdate ) {
 this . mPostFrameHandlers . onUpdate ( pSecondsElapsed ) ;
 }

Fixed Bug with Scene not propagating Pre PostFrameHandlers correctly


<nb> public class Vec extends Keyed < Vec > {
 }

 COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + public TwoDimTable toTwoDimTable ( int off , int len ) {
 + return new Frame ( this ) . toTwoDimTable ( off , len ) ;
 + }
 +
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + public TwoDimTable toTwoDimTable ( ) {
 + int len = ( int ) Math . min ( Integer . MAX_VALUE , length ( ) ) ;
 + return new Frame ( this ) . toTwoDimTable ( NUMBER0 , len ) ;
 + }
 +
 + COMMENT
 COMMENT
 COMMENT
 COMMENT

Add convenience helper to print a Vec to string via TwoDimTable


<nb> public class PoiFiltersHelper {
 putValues ( types , AmenityType . TRANSPORTATION , STRING0 ) ;
 } else if ( UDF_FOOD_SHOP . equals ( key ) ) {
 putValues ( types , AmenityType . SHOP , STRING1 , STRING2 , STRING3 , STRING4 , STRING5 , STRING6 ,
 - STRING5 , STRING7 , STRING8 , STRING9 , STRING10 , STRING11 , STRING12 ) ;
 + STRING5 , STRING7 , STRING8 , STRING9 , STRING10 , STRING13 , STRING11 , STRING12 ) ;
 } else if ( UDF_SIGHTSEEING . equals ( key ) ) {
 putAll ( types , AmenityType . HISTORIC ) ;
 putValues ( types , AmenityType . TOURISM , STRING14 ,


<nb> public class Response
 COMMENT
 COMMENT
 protected static final String info =
 - STRING0 ;
 + STRING1 ;

 COMMENT

Update info should probably just delete all these


<nb> public class OTPConfigurator {
 }
 OpenStreetMapGraphBuilderImpl osmBuilder = new OpenStreetMapGraphBuilderImpl ( osmProviders ) ;
 DefaultStreetEdgeFactory streetEdgeFactory = new DefaultStreetEdgeFactory ( ) ;
 - streetEdgeFactory . useElevationData = params . elevation ;
 + streetEdgeFactory . useElevationData = params . elevation || ( demFile != null ) ;
 osmBuilder . edgeFactory = streetEdgeFactory ;
 DefaultWayPropertySetSource defaultWayPropertySetSource = new DefaultWayPropertySetSource ( ) ;
 osmBuilder . setDefaultWayPropertySetSource ( defaultWayPropertySetSource ) ;

Set streetEdgeFactory useElevationData to true when DEM file is present


<nb> public abstract class RootPage extends BasePage {
 }

 if ( filters . size ( ) > NUMBER0 ) {
 - SINGLE
 - filters . add ( new DropDownMenuItem ( ) ) ;
 SINGLE
 filters . add ( new DropDownMenuItem ( STRING0 , null , null ) ) ;
 }


<nb> public class LocationManagerService extends ILocationManager . Stub implements Run

 COMMENT
 COMMENT
 - COMMENT
 + COMMENT
 + COMMENT
 COMMENT
 @ override
 public List < String > getAllProviders ( ) {
 - checkPermission ( ) ;
 -
 ArrayList < String > out ;
 synchronized ( mLock ) {
 out = new ArrayList < String > ( mProviders . size ( ) ) ;

Remove checkPermission call in getAllProviders


<nb> import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;

 - import NAMESPACE ;
 import NAMESPACE ;

 import NAMESPACE ;
 <nb> public class ErrorInfo {
 isCatastrophic ) ;
 }

 - SINGLE
 - private transient NestedSet < SkyKey > rootCauses ;
 + private final NestedSet < SkyKey > rootCauses ;

 @ nullable private final Exception exception ;
 private final SkyKey rootCauseOfException ;
 <nb> public class ErrorInfo {
 return isCatastrophic ;
 }

 - private void readObject ( java . io . ObjectInputStream in ) throws IOException , ClassNotFoundException {
 - in . defaultReadObject ( ) ;
 - rootCauses = NestedSetBuilder . emptySet ( Order . STABLE_ORDER ) ;
 - }
 }

Remove vestigial serialization bits from ErrorInfo


<nb> public class NettyRemoteBlockReaderTest {
 return new RPCErrorResponse ( status ) ;
 }
 }
 -


<nb>
 COMMENT
 COMMENT
 COMMENT
 - COMMENT
 + COMMENT
 COMMENT
 - COMMENT
 + COMMENT
 COMMENT
 COMMENT
 COMMENT
 COMMENT
 COMMENT
 +
 package NAMESPACE ;

 import NAMESPACE ;
 <nb> public final class UtilsTest {

 COMMENT
 COMMENT
 - COMMENT
 + COMMENT
 COMMENT
 COMMENT
 COMMENT

Fix checkstyle problems with client module


<nb> public class ObjectProperty extends AbstractProperty implements Property {
 return isType ( type ) ;
 }

 + public ObjectProperty properties ( Map < String , Property > properties ) {
 + this . setProperties ( properties ) ;
 + return this ;
 + }
 +
 public Map < String , Property > getProperties ( ) {
 return this . properties ;
 }

Adding a builder pattern friendly method in ObjectProperty


<nb> import static NAMESPACE ;
 COMMENT
 COMMENT
 COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 COMMENT
 public final class CertificatePinner {
 public static final CertificatePinner DEFAULT = new Builder ( ) . build ( ) ;

Add Javadoc about self signed certificates


<nb> final class FlashlightManager {
 private static final Method setFlashEnabledMethod ;
 static {
 iHardwareService = getHardwareService ( ) ;
 + Log . v ( TAG , STRING0 + ( iHardwareService == null ? STRING1 : STRING2 ) + STRING3 ) ;
 setFlashEnabledMethod = getSetFlashEnabledMethod ( iHardwareService ) ;
 - if ( iHardwareService == null ) {
 - Log . v ( TAG , STRING4 ) ;
 - } else {
 - Log . v ( TAG , STRING5 ) ;
 - }
 }

 private FlashlightManager ( ) {


<nb> public class NotQueryParser implements QueryParser {
 SINGLE
 query = parseContext . parseInnerFilter ( currentFieldName ) ;
 }
 - } else if ( token == XContentParser . Token . START_ARRAY ) {
 - queryFound = true ;
 - SINGLE
 - query = parseContext . parseInnerFilter ( currentFieldName ) ;
 } else if ( token . isValue ( ) ) {
 if ( STRING0 . equals ( currentFieldName ) ) {
 queryName = parser . text ( ) ;

remove attemped not working support for array in not query parser


<nb> public class AndroidNet implements Net {

 private final ExecutorService executorService ;

 - HttpClient httpClient ;
 + DefaultHttpClient httpClient ;

 public AndroidNet ( AndroidApplication activity ) {
 app = activity ;
 <nb> public class AndroidNet implements Net {
 if ( httpRequest . getUrl ( ) == null ) throw new GdxRuntimeException ( STRING0 ) ;

 final HttpUriRequest httpClientRequest = getHttpClientRequest ( httpRequest ) ;
 -
 +
 SINGLE
 -
 +
 executorService . submit ( new Runnable ( ) {
 @ override
 public void run ( ) {
 <nb> public interface Net {
 public void setTimeOut ( long timeOut ) {
 this . timeOut = timeOut ;
 }
 +
 + public long getTimeOut ( ) {
 + return timeOut ;
 + }

 COMMENT
 public String getMethod ( ) {


<nb> import NAMESPACE ;

 import NAMESPACE ;
 import NAMESPACE ;
 + import NAMESPACE ;

 public class ReaderSearchSuggestionAdapter extends CursorAdapter {
 private static final int MAX_SUGGESTIONS = NUMBER0 ;
 <nb> public class ReaderSearchSuggestionAdapter extends CursorAdapter {
 super ( context , null , false ) ;
 String clearAllText = context . getString ( R . string . label_clear_saved_searches ) ;
 mClearAllRow = new Object [ ] { CLEAR_ALL_ROW_ID , clearAllText } ;
 - mClearAllBgColor = context . getResources ( ) . getColor ( R . color . grey_lighten_30 ) ;
 + mClearAllBgColor = ResourceUtils . getColorResource ( context , R . color . grey_lighten_30 ) ;
 }

 public void setFilter ( String filter ) {

Use the new ResourceUtils getColorResource


<nb> import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;
 + import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;
 import NAMESPACE ;


<nb>
 COMMENT
 - COMMENT
 + COMMENT
 COMMENT
 COMMENT
 COMMENT
 <nb> public class AdditionalOptionsPanel implements RefreshableOnComponent , TagNameFi

 public void refresh ( ) {
 myTagName . setText ( myConfiguration . TAG_AFTER_PROJECT_COMMIT_NAME ) ;
 - myOverrideExisting . setSelected ( myConfiguration . OVERRIDE_EXISTING_TAG_FOR_PROJECT ) ;
 + myOverrideExisting . setSelected ( false ) ; SINGLE
 updateEnable ( ) ;
 }

reset override existing tag checkbox on every invocation


<nb> public class IndicesStore extends AbstractComponent implements ClusterStateListe
 shardCanBeDeleted = false ;
 break ;
 }
 - String localNodeId = clusterService . localNode ( ) . id ( ) ;
 +
 + SINGLE
 + SINGLE
 + SINGLE
 + if ( ! event . state ( ) . nodes ( ) . nodeExists ( shardRouting . currentNodeId ( ) ) ) {
 + shardCanBeDeleted = false ;
 + break ;
 + }
 + if ( shardRouting . relocatingNodeId ( ) != null ) {
 + if ( ! event . state ( ) . nodes ( ) . nodeExists ( shardRouting . relocatingNodeId ( ) ) ) {
 + shardCanBeDeleted = false ;
 + break ;
 + }
 + }
 +
 SINGLE
 + String localNodeId = clusterService . localNode ( ) . id ( ) ;
 if ( localNodeId . equals ( shardRouting . currentNodeId ( ) ) || localNodeId . equals ( shardRouting . relocatingNodeId ( ) ) ) {
 - SINGLE
 shardCanBeDeleted = false ;
 break ;
 }

Don t delete local shard data when its allocated on a node that doesn t exists


<nb> public class SecurityContextAssociationValve extends ValveBase {
 principal = ( JBossGenericPrincipal ) session . getPrincipal ( ) ;
 }
 if ( principal == null ) {
 - principal = ( JBossGenericPrincipal ) request . getSessionInternal ( false ) . getNote ( Constants . FORM_PRINCIPAL_NOTE ) ;
 + Session sessionInternal = request . getSessionInternal ( false ) ;
 + if ( sessionInternal != null ) {
 + principal = ( JBossGenericPrincipal ) sessionInternal . getNote ( Constants . FORM_PRINCIPAL_NOTE ) ;
 + }
 }
 } else {
 SINGLE
 <nb> public class SecurityContextAssociationValve extends ValveBase {
 }
 }
 } catch ( Throwable e ) {
 - log . debugf ( STRING0 , e ) ;
 + SINGLE
 + log . debug ( STRING0 , e ) ;
 }
 SINGLE
 PolicyContext . setContextID ( deploymentUnit . getName ( ) ) ;

Added a check for null session reference


<nb> public class TestGremlin implements GraphHolder
 {
 String response = gen . get ( )
 . expectedStatus ( Status . OK . getStatusCode ( ) )
 - . payload ( STRING0 + URLEncoder . encode ( STRING1 + data . get ( ) . get ( STRING2 ) . getId ( ) + STRING3 , STRING4 ) )
 + . payload ( STRING0 + URLEncoder . encode ( STRING5 + data . get ( ) . get ( STRING2 ) . getId ( ) + STRING3 , STRING4 ) )
 . payloadType ( MediaType . APPLICATION_FORM_URLENCODED_TYPE )
 . post ( ENDPOINT )
 . entity ( ) ;


<nb> href = STRING0 > Traceview : A Graphical Lo
 COMMENT
 COMMENT
 COMMENT
 - COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 COMMENT
 COMMENT
 COMMENT
 COMMENT
 COMMENT
 - COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 + COMMENT
 COMMENT
 COMMENT
 COMMENT

Clarify art gc gc count rate histogram runtime stat


<nb> public class CoordinationTransformer implements TreeTransformer {
 private static final TregexPattern [ ] [ ] matchPatterns = {
 {
 SINGLE
 - TregexPattern . safeCompile ( STRING0 , true ) ,
 + TregexPattern . compile ( STRING0 ) ,
 SINGLE
 - TregexPattern . safeCompile ( STRING1 , true )
 + TregexPattern . compile ( STRING1 )
 } ,
 {
 SINGLE
 - TregexPattern . safeCompile ( STRING2 , true ) ,
 - TregexPattern . safeCompile ( STRING3 , true )
 + TregexPattern . compile ( STRING2 ) ,
 + TregexPattern . compile ( STRING3 )
 }
 } ;

No need to use safeCompile here we would actually want the exceptions


<nb> public class ConfigurationException extends Exception {
 final StringBuilder msg = new StringBuilder ( file . toString ( ) )
 . append ( STRING0 ) ;
 for ( String error : errors ) {
 - msg . append ( STRING1 ) . append ( error ) ;
 + msg . append ( STRING1 ) . append ( error ) . append ( STRING2 ) ;
 }
 return msg . toString ( ) ;
 }


<nb> public class BackupProtocolTest
 LifeSupport life = new LifeSupport ( ) ;

 LogEntryReader < ReadableClosablePositionAwareChannel > reader = new VersionAwareLogEntryReader < > ( ) ;
 - BackupClient client = life . add ( new BackupClient ( host , port , null , NullLogProvider . getInstance ( ) , storeId , NUMBER0 ,
 + BackupClient client = life . add ( new BackupClient ( host , port , null , NullLogProvider . getInstance ( ) , storeId , NUMBER1 ,
 mock ( ResponseUnpacker . class ) , mock ( ByteCounterMonitor . class ) , mock ( RequestMonitor . class ) , reader ) ) ;
 ControlledBackupInterface backup = new ControlledBackupInterface ( ) ;
 life . add ( new BackupServer ( backup , new HostnamePort ( host , port ) , NullLogProvider . getInstance ( ) , mock ( ByteCounterMonitor . class ) ,


<nb> public class StoredPaymentChannelServerStates implements WalletExtension {
 this . broadcasterFuture . set ( checkNotNull ( broadcaster ) ) ;
 }

 + COMMENT
 + @ nullable
 + public static StoredPaymentChannelServerStates getFromWallet ( Wallet wallet ) {
 + return ( StoredPaymentChannelServerStates ) wallet . getExtensions ( ) . get ( EXTENSION_ID ) ;
 + }
 +
 COMMENT
 COMMENT
 COMMENT

Added getFromWallet method to StoredPaymentChannelServerStates


<nb> public class ServerTestUtils

 public static File createTempPropertyFile ( File parentDir ) throws IOException
 {
 - File f = new File ( parentDir , STRING0 + new Random ( ) . nextInt ( ) + STRING1 ) ;
 + File f = new File ( parentDir , STRING0 + new Random ( ) . nextInt ( ) + STRING1 ) ;
 f . deleteOnExit ( ) ;
 return f ;
 }

Updating the way we create temporary files to hopefully solve the functional test problem where lots of files stick around


<nb> public class Peer {
 COMMENT
 COMMENT
 public void startBlockChainDownload ( ) throws IOException {
 - for ( PeerEventListener listener : eventListeners ) {
 - synchronized ( listener ) {
 - listener . onChainDownloadStarted ( this , getPeerBlocksToGet ( ) ) ;
 + SINGLE
 + SINGLE
 + if ( getPeerBlocksToGet ( ) > NUMBER0 ) {
 + for ( PeerEventListener listener : eventListeners ) {
 + synchronized ( listener ) {
 + listener . onChainDownloadStarted ( this , getPeerBlocksToGet ( ) ) ;
 + }
 }
 - }

 - if ( getPeerBlocksToGet ( ) > NUMBER0 ) {
 SINGLE
 blockChainDownload ( Sha256Hash . ZERO_HASH ) ;
 }

Do not callback if nothing to download from peer


<nb> public class RouteDirectionInfo {

 SINGLE
 public int getExpectedTime ( ) {
 - return ( int ) ( distance / averageSpeed ) ;
 + return ( int ) Math . round ( distance / averageSpeed ) ;
 }

 <nb> public class RouteProvider {
 RouteDirectionInfo last = directions . get ( directions . size ( ) - NUMBER0 ) ;
 SINGLE
 last . setAverageSpeed ( ( distanceToEnd [ last . routePointOffset ] - distanceToEnd [ offset ] ) / last . getAverageSpeed ( ) ) ;
 - last . distance = ( int ) ( distanceToEnd [ last . routePointOffset ] - distanceToEnd [ offset ] ) ;
 + last . distance = ( int ) Math . round ( distanceToEnd [ last . routePointOffset ] - distanceToEnd [ offset ] ) ;
 }
 SINGLE
 float avgSpeed = time ;


<nb> public final class ThreadReferenceProxyImpl extends ObjectReferenceProxyImpl imp
 try {
 getThreadReference ( ) . popFrames ( stackFrame . getStackFrame ( ) ) ;
 }
 + catch ( InvalidStackFrameException ignored ) {
 + }
 catch ( ObjectCollectedException ignored ) {
 }
 catch ( InternalException e ) {

ignore com sun jdi InvalidStackFrameException


<nb> public class SharedIndicesData {

 @ override
 protected void doDropMemoryCaches ( ) {
 - myStateCache . clear ( ) ;
 + if ( myStateCache != null ) myStateCache . clear ( ) ;
 super . doDropMemoryCaches ( ) ;
 }

 @ override
 protected void doForce ( ) {
 - myStateCache . clear ( ) ;
 + if ( myStateCache != null ) myStateCache . clear ( ) ;
 super . doForce ( ) ;
 }