/*---------------------------------------------------------------------------*\ ========= | \\ / F ield | OpenFOAM: The Open Source CFD Toolbox \\ / O peration | Website: https://openfoam.org \\ / A nd | Copyright (C) 2011-2026 OpenFOAM Foundation \\/ M anipulation | ------------------------------------------------------------------------------- License This file is part of OpenFOAM. OpenFOAM is free software: you can redistribute it and/or modify it under the terms of the GNU General Public License as published by the Free Software Foundation, either version 3 of the License, or (at your option) any later version. OpenFOAM is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License for more details. You should have received a copy of the GNU General Public License along with OpenFOAM. If not, see . \*---------------------------------------------------------------------------*/ #include "polyMeshCheck.H" #include "polyMeshTetDecomposition.H" #include "pyramidPointFaceRef.H" #include "tetPointRef.H" #include "syncTools.H" // * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * // namespace Foam { namespace meshCheck { // * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * // scalar checkNonOrtho ( const primitiveMesh& mesh, const bool report, const scalar severeNonorthogonalityThreshold, const label facei, const vector& s, // face area vector const vector& d, // cc-cc vector label& severeNonOrth, label& errorNonOrth, labelHashSet* setPtr ) { const scalar dDotS = (d & s)/(mag(d)*mag(s) + vSmall); if (dDotS < severeNonorthogonalityThreshold) { label nei = -1; if (mesh.isInternalFace(facei)) { nei = mesh.faceNeighbour()[facei]; } if (dDotS > small) { if (report) { // Severe non-orthogonality but mesh still OK Pout<< "Severe non-orthogonality for face " << facei << " between cells " << mesh.faceOwner()[facei] << " and " << nei << ": Angle = " << radToDeg(::acos(dDotS)) << " deg." << endl; } severeNonOrth++; } else { // Non-orthogonality greater than 90 deg if (report) { WarningInFunction << "Severe non-orthogonality detected for face " << facei << " between cells " << mesh.faceOwner()[facei] << " and " << nei << ": Angle = " << radToDeg(::acos(dDotS)) << " deg." << endl; } errorNonOrth++; } if (setPtr) { setPtr->insert(facei); } } return dDotS; } bool checkFaceTet ( const primitiveMesh& mesh, const bool report, const scalar minTetQuality, const pointField& p, const label facei, const point& fc, // face centre const point& cc, // cell centre labelHashSet* setPtr ) { const face& f = mesh.faces()[facei]; forAll(f, fp) { const scalar tetQual = tetPointRef ( p[f[fp]], p[f.nextLabel(fp)], fc, cc ).quality(); if (tetQual < minTetQuality) { if (report) { Pout<< "bool meshCheck::checkFaceTets(" << "const bool, const scalar, const pointField&" << ", const pointField&" << ", const labelList&, labelHashSet*) : " << "face " << facei << " has a triangle that points the wrong way." << endl << "Tet quality: " << tetQual << " Face " << facei << endl; } if (setPtr) { setPtr->insert(facei); } return true; } } return false; } labelList getAffectedCells ( const primitiveMesh& mesh, const labelList& changedFaces ) { const labelList& own = mesh.faceOwner(); const labelList& nei = mesh.faceNeighbour(); labelHashSet affectedCells(2*changedFaces.size()); forAll(changedFaces, i) { const label facei = changedFaces[i]; affectedCells.insert(own[facei]); if (mesh.isInternalFace(facei)) { affectedCells.insert(nei[facei]); } } return affectedCells.toc(); } // * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * // } // End namespace meshCheck } // End namespace Foam // * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * // bool Foam::meshCheck::checkFaceOrthogonality ( const bool report, const scalar orthWarn, const polyMesh& mesh, const vectorField& cellCentres, const vectorField& faceAreas, const labelList& checkFaces, const List& baffles, labelHashSet* setPtr ) { // for all internal and coupled faces check theat the d dot S product // is positive const labelList& own = mesh.faceOwner(); const labelList& nei = mesh.faceNeighbour(); const polyBoundaryMesh& patches = mesh.boundary(); // Severe nonorthogonality threshold const scalar severeNonorthogonalityThreshold = ::cos(orthWarn); // Calculate coupled cell centre pointField neiCc(mesh.nFaces() - mesh.nInternalFaces()); for (label facei = mesh.nInternalFaces(); facei < mesh.nFaces(); facei++) { neiCc[facei-mesh.nInternalFaces()] = cellCentres[own[facei]]; } syncTools::swapBoundaryFacePositions(mesh, neiCc); scalar minDDotS = great; scalar sumDDotS = 0; label nDDotS = 0; label severeNonOrth = 0; label errorNonOrth = 0; forAll(checkFaces, i) { const label facei = checkFaces[i]; const point& ownCc = cellCentres[own[facei]]; if (mesh.isInternalFace(facei)) { const scalar dDotS = checkNonOrtho ( mesh, report, severeNonorthogonalityThreshold, facei, faceAreas[facei], cellCentres[nei[facei]] - ownCc, severeNonOrth, errorNonOrth, setPtr ); if (dDotS < minDDotS) { minDDotS = dDotS; } sumDDotS += dDotS; nDDotS++; } else { const label patchi = patches.whichPatch(facei); if (patches[patchi].coupled()) { const scalar dDotS = checkNonOrtho ( mesh, report, severeNonorthogonalityThreshold, facei, faceAreas[facei], neiCc[facei-mesh.nInternalFaces()] - ownCc, severeNonOrth, errorNonOrth, setPtr ); if (dDotS < minDDotS) { minDDotS = dDotS; } sumDDotS += dDotS; nDDotS++; } } } forAll(baffles, i) { const label face0 = baffles[i].first(); const label face1 = baffles[i].second(); const point& ownCc = cellCentres[own[face0]]; const scalar dDotS = checkNonOrtho ( mesh, report, severeNonorthogonalityThreshold, face0, faceAreas[face0], cellCentres[own[face1]] - ownCc, severeNonOrth, errorNonOrth, setPtr ); if (dDotS < minDDotS) { minDDotS = dDotS; } sumDDotS += dDotS; nDDotS++; } reduce(minDDotS, minOp()); reduce(sumDDotS, sumOp()); reduce(nDDotS, sumOp()); reduce(severeNonOrth, sumOp()); reduce(errorNonOrth, sumOp()); // Only report if there are some internal faces if (nDDotS > 0) { if (report && minDDotS < severeNonorthogonalityThreshold) { Info<< "Number of non-orthogonality errors: " << errorNonOrth << ". Number of severely non-orthogonal faces: " << severeNonOrth << "." << endl; } } if (report) { if (nDDotS > 0) { Info<< "Mesh non-orthogonality Max: " << radToDeg(::acos(minDDotS)) << " average: " << radToDeg(::acos(sumDDotS/nDDotS)) << endl; } } if (errorNonOrth > 0) { if (report) { SeriousErrorInFunction << "Error in non-orthogonality detected" << endl; } return true; } else { if (report) { Info<< "Non-orthogonality check OK.\n" << endl; } return false; } } bool Foam::meshCheck::checkFacePyramids ( const bool report, const scalar minPyrVol, const polyMesh& mesh, const vectorField& cellCentres, const pointField& p, const labelList& checkFaces, const List& baffles, labelHashSet* setPtr ) { // check whether face area vector points to the cell with higher label const labelList& own = mesh.faceOwner(); const labelList& nei = mesh.faceNeighbour(); const faceList& f = mesh.faces(); label nErrorPyrs = 0; forAll(checkFaces, i) { const label facei = checkFaces[i]; // Create the owner pyramid - it will have negative volume const scalar pyrVol = pyramidPointFaceRef ( f[facei], cellCentres[own[facei]] ).mag(p); if (pyrVol > -minPyrVol) { if (report) { Pout<< "bool meshCheck::checkFacePyramids(" << "const bool, const scalar, const pointField&" << ", const labelList&, labelHashSet*): " << "face " << facei << " points the wrong way. " << endl << "Pyramid volume: " << -pyrVol << " Face " << f[facei] << " area: " << f[facei].mag(p) << " Owner cell: " << own[facei] << endl << "Owner cell vertex labels: " << mesh.cells()[own[facei]].labels(f) << endl; } if (setPtr) { setPtr->insert(facei); } nErrorPyrs++; } if (mesh.isInternalFace(facei)) { // Create the neighbour pyramid - it will have positive volume const scalar pyrVol = pyramidPointFaceRef(f[facei], cellCentres[nei[facei]]).mag(p); if (pyrVol < minPyrVol) { if (report) { Pout<< "bool meshCheck::checkFacePyramids(" << "const bool, const scalar, const pointField&" << ", const labelList&, labelHashSet*): " << "face " << facei << " points the wrong way. " << endl << "Pyramid volume: " << -pyrVol << " Face " << f[facei] << " area: " << f[facei].mag(p) << " Neighbour cell: " << nei[facei] << endl << "Neighbour cell vertex labels: " << mesh.cells()[nei[facei]].labels(f) << endl; } if (setPtr) { setPtr->insert(facei); } nErrorPyrs++; } } } forAll(baffles, i) { const label face0 = baffles[i].first(); const label face1 = baffles[i].second(); const point& ownCc = cellCentres[own[face0]]; // Create the owner pyramid - it will have negative volume const scalar pyrVolOwn = pyramidPointFaceRef ( f[face0], ownCc ).mag(p); if (pyrVolOwn > -minPyrVol) { if (report) { Pout<< "bool meshCheck::checkFacePyramids(" << "const bool, const scalar, const pointField&" << ", const labelList&, labelHashSet*): " << "face " << face0 << " points the wrong way. " << endl << "Pyramid volume: " << -pyrVolOwn << " Face " << f[face0] << " area: " << f[face0].mag(p) << " Owner cell: " << own[face0] << endl << "Owner cell vertex labels: " << mesh.cells()[own[face0]].labels(f) << endl; } if (setPtr) { setPtr->insert(face0); } nErrorPyrs++; } // Create the neighbour pyramid - it will have positive volume const scalar pyrVolNbr = pyramidPointFaceRef(f[face0], cellCentres[own[face1]]).mag(p); if (pyrVolNbr < minPyrVol) { if (report) { Pout<< "bool meshCheck::checkFacePyramids(" << "const bool, const scalar, const pointField&" << ", const labelList&, labelHashSet*): " << "face " << face0 << " points the wrong way. " << endl << "Pyramid volume: " << -pyrVolNbr << " Face " << f[face0] << " area: " << f[face0].mag(p) << " Neighbour cell: " << own[face1] << endl << "Neighbour cell vertex labels: " << mesh.cells()[own[face1]].labels(f) << endl; } if (setPtr) { setPtr->insert(face0); } nErrorPyrs++; } } reduce(nErrorPyrs, sumOp()); if (nErrorPyrs > 0) { if (report) { SeriousErrorInFunction << "Error in face pyramids: faces pointing the wrong way." << endl; } return true; } else { if (report) { Info<< "Face pyramids OK.\n" << endl; } return false; } } bool Foam::meshCheck::checkFaceTets ( const bool report, const scalar minTetQuality, const polyMesh& mesh, const vectorField& cellCentres, const vectorField& faceCentres, const pointField& p, const labelList& checkFaces, const List& baffles, labelHashSet* setPtr ) { // check whether decomposing each cell into tets results in // positive volume, non-flat tets const labelList& own = mesh.faceOwner(); const labelList& nei = mesh.faceNeighbour(); const polyBoundaryMesh& patches = mesh.boundary(); // Calculate coupled cell centre pointField neiCc(mesh.nFaces() - mesh.nInternalFaces()); for (label facei = mesh.nInternalFaces(); facei < mesh.nFaces(); facei++) { neiCc[facei - mesh.nInternalFaces()] = cellCentres[own[facei]]; } syncTools::swapBoundaryFacePositions(mesh, neiCc); label nErrorTets = 0; forAll(checkFaces, i) { const label facei = checkFaces[i]; // Create the owner pyramid - note: exchange cell and face centre // to get positive volume. bool tetError = checkFaceTet ( mesh, report, minTetQuality, p, facei, cellCentres[own[facei]], // face centre faceCentres[facei], // cell centre setPtr ); if (tetError) { nErrorTets++; } if (mesh.isInternalFace(facei)) { // Create the neighbour tets - they will have positive volume bool tetError = checkFaceTet ( mesh, report, minTetQuality, p, facei, faceCentres[facei], // face centre cellCentres[nei[facei]], // cell centre setPtr ); if (tetError) { nErrorTets++; } if ( polyMeshTetDecomposition::findSharedBasePoint ( mesh, facei, minTetQuality, report ) == -1 ) { if (setPtr) { setPtr->insert(facei); } nErrorTets++; } } else { const label patchi = patches.whichPatch(facei); if (patches[patchi].coupled()) { if ( polyMeshTetDecomposition::findSharedBasePoint ( mesh, facei, neiCc[facei - mesh.nInternalFaces()], minTetQuality, report ) == -1 ) { if (setPtr) { setPtr->insert(facei); } nErrorTets++; } } else { if ( polyMeshTetDecomposition::findBasePoint ( mesh, facei, minTetQuality, report ) == -1 ) { if (setPtr) { setPtr->insert(facei); } nErrorTets++; } } } } forAll(baffles, i) { const label face0 = baffles[i].first(); const label face1 = baffles[i].second(); bool tetError = checkFaceTet ( mesh, report, minTetQuality, p, face0, cellCentres[own[face0]], // face centre faceCentres[face0], // cell centre setPtr ); if (tetError) { nErrorTets++; } // Create the neighbour tets - they will have positive volume tetError = checkFaceTet ( mesh, report, minTetQuality, p, face0, faceCentres[face0], // face centre cellCentres[own[face1]], // cell centre setPtr ); if (tetError) { nErrorTets++; } if ( polyMeshTetDecomposition::findSharedBasePoint ( mesh, face0, cellCentres[own[face1]], minTetQuality, report ) == -1 ) { if (setPtr) { setPtr->insert(face0); } nErrorTets++; } } reduce(nErrorTets, sumOp()); if (nErrorTets > 0) { if (report) { SeriousErrorInFunction << "Error in face decomposition: negative tets." << endl; } return true; } else { if (report) { Info<< "Face tets OK.\n" << endl; } return false; } } bool Foam::meshCheck::checkFaceSkewness ( const bool report, const scalar internalSkew, const scalar boundarySkew, const polyMesh& mesh, const pointField& points, const vectorField& cellCentres, const vectorField& faceCentres, const vectorField& faceAreas, const labelList& checkFaces, const List& baffles, labelHashSet* setPtr ) { // Warn if the skew correction vector is more than skew times // larger than the face area vector const labelList& own = mesh.faceOwner(); const labelList& nei = mesh.faceNeighbour(); const polyBoundaryMesh& patches = mesh.boundary(); // Calculate coupled cell centre pointField neiCc; syncTools::swapBoundaryCellPositions(mesh, cellCentres, neiCc); scalar maxSkew = 0; label nWarnSkew = 0; forAll(checkFaces, i) { const label facei = checkFaces[i]; if (mesh.isInternalFace(facei)) { const scalar skewness = meshCheck::faceSkewness ( mesh, points, faceCentres, faceAreas, facei, cellCentres[own[facei]], cellCentres[nei[facei]] ); // Check if the skewness vector is greater than the PN vector. // This does not cause trouble but is a good indication of a poor // mesh. if (skewness > internalSkew) { if (report) { Pout<< "Severe skewness for face " << facei << " skewness = " << skewness << endl; } if (setPtr) { setPtr->insert(facei); } nWarnSkew++; } maxSkew = max(maxSkew, skewness); } else if (patches[patches.whichPatch(facei)].coupled()) { const scalar skewness = meshCheck::faceSkewness ( mesh, points, faceCentres, faceAreas, facei, cellCentres[own[facei]], neiCc[facei-mesh.nInternalFaces()] ); // Check if the skewness vector is greater than the PN vector. // This does not cause trouble but is a good indication of a poor // mesh. if (skewness > internalSkew) { if (report) { Pout<< "Severe skewness for coupled face " << facei << " skewness = " << skewness << endl; } if (setPtr) { setPtr->insert(facei); } nWarnSkew++; } maxSkew = max(maxSkew, skewness); } else { const scalar skewness = meshCheck::boundaryFaceSkewness ( mesh, points, faceCentres, faceAreas, facei, cellCentres[own[facei]] ); // Check if the skewness vector is greater than the PN vector. // This does not cause trouble but is a good indication of a poor // mesh. if (skewness > boundarySkew) { if (report) { Pout<< "Severe skewness for boundary face " << facei << " skewness = " << skewness << endl; } if (setPtr) { setPtr->insert(facei); } nWarnSkew++; } maxSkew = max(maxSkew, skewness); } } forAll(baffles, i) { const label face0 = baffles[i].first(); const label face1 = baffles[i].second(); const point& ownCc = cellCentres[own[face0]]; const point& neiCc = cellCentres[own[face1]]; const scalar skewness = meshCheck::faceSkewness ( mesh, points, faceCentres, faceAreas, face0, ownCc, neiCc ); // Check if the skewness vector is greater than the PN vector. // This does not cause trouble but is a good indication of a poor // mesh. if (skewness > internalSkew) { if (report) { Pout<< "Severe skewness for face " << face0 << " skewness = " << skewness << endl; } if (setPtr) { setPtr->insert(face0); } nWarnSkew++; } maxSkew = max(maxSkew, skewness); } reduce(maxSkew, maxOp()); reduce(nWarnSkew, sumOp()); if (nWarnSkew > 0) { if (report) { WarningInFunction << 100*maxSkew << " percent.\nThis may impair the quality of the result." << nl << nWarnSkew << " highly skew faces detected." << endl; } return true; } else { if (report) { Info<< "Max skewness = " << 100*maxSkew << " percent. Face skewness OK.\n" << endl; } return false; } } bool Foam::meshCheck::checkFaceWeights ( const bool report, const scalar warnWeight, const polyMesh& mesh, const vectorField& cellCentres, const vectorField& faceCentres, const vectorField& faceAreas, const labelList& checkFaces, const List& baffles, labelHashSet* setPtr ) { // Warn if the delta factor (0..1) is too large. const labelList& own = mesh.faceOwner(); const labelList& nei = mesh.faceNeighbour(); const polyBoundaryMesh& patches = mesh.boundary(); // Calculate coupled cell centre pointField neiCc(mesh.nFaces()-mesh.nInternalFaces()); for (label facei = mesh.nInternalFaces(); facei < mesh.nFaces(); facei++) { neiCc[facei-mesh.nInternalFaces()] = cellCentres[own[facei]]; } syncTools::swapBoundaryFacePositions(mesh, neiCc); scalar minWeight = great; label nWarnWeight = 0; forAll(checkFaces, i) { const label facei = checkFaces[i]; const point& fc = faceCentres[facei]; const vector& fa = faceAreas[facei]; const scalar dOwn = mag(fa & (fc-cellCentres[own[facei]])); if (mesh.isInternalFace(facei)) { const scalar dNei = mag(fa & (cellCentres[nei[facei]]-fc)); const scalar weight = min(dNei, dOwn)/(dNei + dOwn + vSmall); if (weight < warnWeight) { if (report) { Pout<< "Small weighting factor for face " << facei << " weight = " << weight << endl; } if (setPtr) { setPtr->insert(facei); } nWarnWeight++; } minWeight = min(minWeight, weight); } else { const label patchi = patches.whichPatch(facei); if (patches[patchi].coupled()) { const scalar dNei = mag(fa & (neiCc[facei-mesh.nInternalFaces()]-fc)); const scalar weight = min(dNei, dOwn)/(dNei + dOwn + vSmall); if (weight < warnWeight) { if (report) { Pout<< "Small weighting factor for face " << facei << " weight = " << weight << endl; } if (setPtr) { setPtr->insert(facei); } nWarnWeight++; } minWeight = min(minWeight, weight); } } } forAll(baffles, i) { const label face0 = baffles[i].first(); const label face1 = baffles[i].second(); const point& ownCc = cellCentres[own[face0]]; const point& fc = faceCentres[face0]; const vector& fa = faceAreas[face0]; const scalar dOwn = mag(fa & (fc-ownCc)); const scalar dNei = mag(fa & (cellCentres[own[face1]]-fc)); const scalar weight = min(dNei, dOwn)/(dNei + dOwn + vSmall); if (weight < warnWeight) { if (report) { Pout<< "Small weighting factor for face " << face0 << " weight = " << weight << endl; } if (setPtr) { setPtr->insert(face0); } nWarnWeight++; } minWeight = min(minWeight, weight); } reduce(minWeight, minOp()); reduce(nWarnWeight, sumOp()); if (minWeight < warnWeight) { if (report) { WarningInFunction << minWeight << '.' << nl << nWarnWeight << " faces with small weights detected." << endl; } return true; } else { if (report) { Info<< "Min weight = " << minWeight << ". Weights OK.\n" << endl; } return false; } } bool Foam::meshCheck::checkVolRatio ( const bool report, const scalar warnRatio, const polyMesh& mesh, const scalarField& cellVolumes, const labelList& checkFaces, const List& baffles, labelHashSet* setPtr ) { // Warn if the volume ratio between neighbouring cells is too large const labelList& own = mesh.faceOwner(); const labelList& nei = mesh.faceNeighbour(); const polyBoundaryMesh& patches = mesh.boundary(); // Calculate coupled cell vol scalarField neiVols(mesh.nFaces()-mesh.nInternalFaces()); for (label facei = mesh.nInternalFaces(); facei < mesh.nFaces(); facei++) { neiVols[facei-mesh.nInternalFaces()] = cellVolumes[own[facei]]; } syncTools::swapBoundaryFaceList(mesh, neiVols); scalar minRatio = great; label nWarnRatio = 0; forAll(checkFaces, i) { const label facei = checkFaces[i]; const scalar ownVol = mag(cellVolumes[own[facei]]); scalar neiVol = -great; if (mesh.isInternalFace(facei)) { neiVol = mag(cellVolumes[nei[facei]]); } else { const label patchi = patches.whichPatch(facei); if (patches[patchi].coupled()) { neiVol = mag(neiVols[facei-mesh.nInternalFaces()]); } } if (neiVol >= 0) { const scalar ratio = min(ownVol, neiVol)/(max(ownVol, neiVol) + vSmall); if (ratio < warnRatio) { if (report) { Pout<< "Small ratio for face " << facei << " ratio = " << ratio << endl; } if (setPtr) { setPtr->insert(facei); } nWarnRatio++; } minRatio = min(minRatio, ratio); } } forAll(baffles, i) { const label face0 = baffles[i].first(); const label face1 = baffles[i].second(); const scalar ownVol = mag(cellVolumes[own[face0]]); const scalar neiVol = mag(cellVolumes[own[face1]]); if (neiVol >= 0) { const scalar ratio = min(ownVol, neiVol)/(max(ownVol, neiVol) + vSmall); if (ratio < warnRatio) { if (report) { Pout<< "Small ratio for face " << face0 << " ratio = " << ratio << endl; } if (setPtr) { setPtr->insert(face0); } nWarnRatio++; } minRatio = min(minRatio, ratio); } } reduce(minRatio, minOp()); reduce(nWarnRatio, sumOp()); if (minRatio < warnRatio) { if (report) { WarningInFunction << minRatio << '.' << nl << nWarnRatio << " faces with small ratios detected." << endl; } return true; } else { if (report) { Info<< "Min ratio = " << minRatio << ". Ratios OK.\n" << endl; } return false; } } bool Foam::meshCheck::checkFaceAngles ( const bool report, const scalar maxConcave, const polyMesh& mesh, const vectorField& faceAreas, const pointField& p, const labelList& checkFaces, labelHashSet* setPtr ) { if (maxConcave < -small || maxConcave > degToRad(180)+small) { FatalErrorInFunction << "maxConcave should be [0..180] degrees but is " << radToDeg(maxConcave) << abort(FatalError); } const scalar maxSin = Foam::sin(maxConcave); const faceList& fcs = mesh.faces(); scalar maxEdgeSin = 0.0; label nConcave = 0; label errorFacei = -1; forAll(checkFaces, i) { const label facei = checkFaces[i]; const face& f = fcs[facei]; vector faceNormal = faceAreas[facei]; faceNormal /= mag(faceNormal) + vSmall; // Get edge from f[0] to f[size-1]; vector ePrev(p[f.first()] - p[f.last()]); scalar magEPrev = mag(ePrev); ePrev /= magEPrev + vSmall; forAll(f, fp0) { // Get vertex after fp const label fp1 = f.fcIndex(fp0); // Normalised vector between two consecutive points vector e10(p[f[fp1]] - p[f[fp0]]); const scalar magE10 = mag(e10); e10 /= magE10 + vSmall; if (magEPrev > small && magE10 > small) { vector edgeNormal = ePrev ^ e10; const scalar magEdgeNormal = mag(edgeNormal); if (magEdgeNormal < maxSin) { // Edges (almost) aligned -> face is ok. } else { // Check normal edgeNormal /= magEdgeNormal; if ((edgeNormal & faceNormal) < small) { if (facei != errorFacei) { // Count only one error per face. errorFacei = facei; nConcave++; } if (setPtr) { setPtr->insert(facei); } maxEdgeSin = max(maxEdgeSin, magEdgeNormal); } } } ePrev = e10; magEPrev = magE10; } } reduce(nConcave, sumOp()); reduce(maxEdgeSin, maxOp()); if (report) { if (maxEdgeSin > small) { const scalar maxConcaveDegr = radToDeg(Foam::asin(Foam::min(1.0, maxEdgeSin))); Info<< "There are " << nConcave << " faces with concave angles between consecutive" << " edges. Max concave angle = " << maxConcaveDegr << " degrees.\n" << endl; } else { Info<< "All angles in faces are convex or less than " << radToDeg(maxConcave) << " degrees concave.\n" << endl; } } if (nConcave > 0) { if (report) { WarningInFunction << nConcave << " face points with severe concave angle (> " << radToDeg(maxConcave) << " deg) found.\n" << endl; } return true; } else { return false; } } bool Foam::meshCheck::checkFaceTwist ( const bool report, const scalar minTwist, const polyMesh& mesh, const vectorField& cellCentres, const vectorField& faceAreas, const vectorField& faceCentres, const pointField& p, const labelList& checkFaces, labelHashSet* setPtr ) { if (minTwist < -1-small || minTwist > 1+small) { FatalErrorInFunction << "minTwist should be [-1..1] but is now " << minTwist << abort(FatalError); } const faceList& fcs = mesh.faces(); label nWarped = 0; const labelList& own = mesh.faceOwner(); const labelList& nei = mesh.faceNeighbour(); const polyBoundaryMesh& patches = mesh.boundary(); // Calculate coupled cell centre pointField neiCc(mesh.nFaces()-mesh.nInternalFaces()); for (label facei = mesh.nInternalFaces(); facei < mesh.nFaces(); facei++) { neiCc[facei-mesh.nInternalFaces()] = cellCentres[own[facei]]; } syncTools::swapBoundaryFacePositions(mesh, neiCc); forAll(checkFaces, i) { const label facei = checkFaces[i]; const face& f = fcs[facei]; if (f.size() > 3) { vector nf(Zero); if (mesh.isInternalFace(facei)) { nf = cellCentres[nei[facei]] - cellCentres[own[facei]]; nf /= mag(nf) + vSmall; } else if (patches[patches.whichPatch(facei)].coupled()) { nf = neiCc[facei-mesh.nInternalFaces()] - cellCentres[own[facei]]; nf /= mag(nf) + vSmall; } else { nf = faceCentres[facei] - cellCentres[own[facei]]; nf /= mag(nf) + vSmall; } if (nf != vector::zero) { const point& fc = faceCentres[facei]; forAll(f, fpI) { vector triArea ( triPointRef ( p[f[fpI]], p[f.nextLabel(fpI)], fc ).area() ); const scalar magTri = mag(triArea); if (magTri > vSmall && ((nf & triArea/magTri) < minTwist)) { nWarped++; if (setPtr) { setPtr->insert(facei); } break; } } } } } reduce(nWarped, sumOp()); if (report) { if (nWarped> 0) { Info<< "There are " << nWarped << " faces with cosine of the angle" << " between triangle normal and face normal less than " << minTwist << nl << endl; } else { Info<< "All faces are flat in that the cosine of the angle" << " between triangle normal and face normal less than " << minTwist << nl << endl; } } if (nWarped > 0) { if (report) { WarningInFunction << nWarped << " faces with severe warpage " << "(cosine of the angle between triangle normal and " << "face normal < " << minTwist << ") found.\n" << endl; } return true; } else { return false; } } bool Foam::meshCheck::checkTriangleTwist ( const bool report, const scalar minTwist, const polyMesh& mesh, const vectorField& faceAreas, const vectorField& faceCentres, const pointField& p, const labelList& checkFaces, labelHashSet* setPtr ) { if (minTwist < -1-small || minTwist > 1+small) { FatalErrorInFunction << "minTwist should be [-1..1] but is now " << minTwist << abort(FatalError); } const faceList& fcs = mesh.faces(); label nWarped = 0; forAll(checkFaces, i) { const label facei = checkFaces[i]; const face& f = fcs[facei]; if (f.size() > 3) { const point& fc = faceCentres[facei]; // Find starting triangle (at startFp) with non-zero area label startFp = -1; vector prevN; forAll(f, fp) { prevN = triPointRef ( p[f[fp]], p[f.nextLabel(fp)], fc ).area(); const scalar magTri = mag(prevN); if (magTri > vSmall) { startFp = fp; prevN /= magTri; break; } } if (startFp != -1) { label fp = startFp; do { fp = f.fcIndex(fp); vector triN ( triPointRef ( p[f[fp]], p[f.nextLabel(fp)], fc ).area() ); const scalar magTri = mag(triN); if (magTri > vSmall) { triN /= magTri; if ((prevN & triN) < minTwist) { nWarped++; if (setPtr) { setPtr->insert(facei); } break; } prevN = triN; } else if (minTwist > 0) { nWarped++; if (setPtr) { setPtr->insert(facei); } break; } } while (fp != startFp); } } } reduce(nWarped, sumOp()); if (report) { if (nWarped> 0) { Info<< "There are " << nWarped << " faces with cosine of the angle" << " between consecutive triangle normals less than " << minTwist << nl << endl; } else { Info<< "All faces are flat in that the cosine of the angle" << " between consecutive triangle normals is less than " << minTwist << nl << endl; } } if (nWarped > 0) { if (report) { WarningInFunction << nWarped << " faces with severe warpage " << "(cosine of the angle between consecutive triangle normals" << " < " << minTwist << ") found.\n" << endl; } return true; } else { return false; } } bool Foam::meshCheck::checkFaceFlatness ( const bool report, const scalar minFlatness, const polyMesh& mesh, const vectorField& faceAreas, const vectorField& faceCentres, const pointField& p, const labelList& checkFaces, labelHashSet* setPtr ) { if (minFlatness < -small || minFlatness > 1+small) { FatalErrorInFunction << "minFlatness should be [0..1] but is now " << minFlatness << abort(FatalError); } const faceList& fcs = mesh.faces(); label nWarped = 0; forAll(checkFaces, i) { const label facei = checkFaces[i]; const face& f = fcs[facei]; if (f.size() > 3) { const point& fc = faceCentres[facei]; // Sum triangle areas scalar sumArea = 0.0; forAll(f, fp) { sumArea += triPointRef ( p[f[fp]], p[f.nextLabel(fp)], fc ).mag(); } if (sumArea/mag(faceAreas[facei]) < minFlatness) { nWarped++; if (setPtr) { setPtr->insert(facei); } } } } reduce(nWarped, sumOp()); if (report) { if (nWarped> 0) { Info<< "There are " << nWarped << " faces with area of individual triangles" << " compared to overall area less than " << minFlatness << nl << endl; } else { Info<< "All faces are flat in that the area of individual triangles" << " compared to overall area is less than " << minFlatness << nl << endl; } } if (nWarped > 0) { if (report) { WarningInFunction << nWarped << " non-flat faces " << "(area of individual triangles" << " compared to overall area" << " < " << minFlatness << ") found.\n" << endl; } return true; } else { return false; } } bool Foam::meshCheck::checkFaceArea ( const bool report, const scalar minArea, const polyMesh& mesh, const vectorField& faceAreas, const labelList& checkFaces, labelHashSet* setPtr ) { label nZeroArea = 0; forAll(checkFaces, i) { const label facei = checkFaces[i]; if (mag(faceAreas[facei]) < minArea) { if (setPtr) { setPtr->insert(facei); } nZeroArea++; } } reduce(nZeroArea, sumOp()); if (report) { if (nZeroArea > 0) { Info<< "There are " << nZeroArea << " faces with area < " << minArea << '.' << nl << endl; } else { Info<< "All faces have area > " << minArea << '.' << nl << endl; } } if (nZeroArea > 0) { if (report) { WarningInFunction << nZeroArea << " faces with area < " << minArea << " found.\n" << endl; } return true; } else { return false; } } bool Foam::meshCheck::checkCellDeterminant ( const bool report, const scalar warnDet, const polyMesh& mesh, const vectorField& faceAreas, const labelList& checkFaces, labelHashSet* setPtr ) { const cellList& cells = mesh.cells(); scalar minDet = great; scalar sumDet = 0.0; label nSumDet = 0; label nWarnDet = 0; const labelList affectedCells(getAffectedCells(mesh, checkFaces)); forAll(affectedCells, i) { const cell& cFaces = cells[affectedCells[i]]; tensor areaSum(Zero); scalar magAreaSum = 0; forAll(cFaces, cFacei) { const label facei = cFaces[cFacei]; const scalar magArea = mag(faceAreas[facei]); magAreaSum += magArea; areaSum += faceAreas[facei]*(faceAreas[facei]/(magArea + vSmall)); } // Scalad by 1/(cube root(1/3)) = 27 const scalar scaledDet = 27*det(areaSum/(magAreaSum + vSmall)); minDet = min(minDet, scaledDet); sumDet += scaledDet; nSumDet++; if (scaledDet < warnDet) { if (setPtr) { // Insert all faces of the cell. forAll(cFaces, cFacei) { const label facei = cFaces[cFacei]; setPtr->insert(facei); } } nWarnDet++; } } reduce(minDet, minOp()); reduce(sumDet, sumOp()); reduce(nSumDet, sumOp()); reduce(nWarnDet, sumOp()); if (report) { if (nSumDet > 0) { Info<< "Cell determinant (1 = uniform cube) : average = " << sumDet / nSumDet << " min = " << minDet << endl; } if (nWarnDet > 0) { Info<< "There are " << nWarnDet << " cells with determinant < " << warnDet << '.' << nl << endl; } else { Info<< "All faces have determinant > " << warnDet << '.' << nl << endl; } } if (nWarnDet > 0) { if (report) { WarningInFunction << nWarnDet << " cells with determinant < " << warnDet << " found.\n" << endl; } return true; } else { return false; } } // ************************************************************************* //