Question:
I think the description of the checkfunds method () is faulty. ! It should be: "A method that accepts an amount as an argument. It returns if the amount is greater than the balance of the budget category and returns otherwise. This method should be used by both the method and method." This is more logical, makes the code simpler and actually works with the tests. Browser Version: Firefox 79 on Ubuntu Linux Operating System: Ubuntu 20.04 LTS
this is genuinely a mistake as how can the amount which needs to be withdrawn be more than the balance in the ledger. amount can only be withdrawn if it is less than the balance in ledger. however there can be a probability that a part of that amount can be deducted from balance but the challenge stated nothing for the same. also the test module asked for a False return value which i think is wrong here in the challenge. !
Hello! Has any resolution to this been implemented? Im not entirely sure what to do about submitting this project because this error still exists. Any help is greatly appreciated!
I don't think so, hasn't changed. It doesn't matter though, design the project as if it was modified the way I suggested and it'll be fine.
Thank you, for opening this. For anyone reading, before a fix: Change this: To this in the file: Can I get a sanity check here? What needs to change on the fCC repl account? I am opening this up to first-timers only Here is the repo: The README description makes sense, but the tests do not, in my opinion. So, the README does not need to change.
Thanks for your patience and for catching this Also, thanks for @ mentioning me, Sorry I didn't see this sooner. My first thought is that we don't need to change the test, but just the README like suggested. It seems like is supposed to be used by the other methods to make sure that there's a sufficient balance before calling or . So in the current test: It makes sense that the first condition is false and the second is true -- you shouldn't be able to buy 10. It's just that the current instructions in the README doesn't reflect that. is that what you were thinking for the method? Also, to answer your question once we decide what to do here and fix things in the boilerplate repo, someone on the team can sign into and mirror those changes.
Thanks for that. I was thinking about the use of the method in an odd way.
I'm willing to work on this one if it's agreed that the README needs to be changed instead of the test.
Thanks, for your eagerness and patience. I was a bit quick with approving the change to be made. So, right now, I suggest you leave your current PR open as is. Once we come to a consensus here, we will be sure to let you know which changes (if any) to make on your PR.
no problem. I think it could work the other way around, we would just need to change the description a bit more and maybe change the method name to something like . I heard back from and he agrees that changing the README makes the most sense. The wording that suggested sounds good to me.
Just mirrored the changes from PR in the project: Thanks again everyone for your suggestions, reviews, and for this fix.

<ins> { /* * ENVIRONMENTS * ================= */ // Define globals exposed by modern browsers. "browser": true, // Define globals exposed by jQuery. "jquery": true, /* * ENFORCING OPTIONS * ================= */ // Force all variable names to use either camelCase style or UPPER_CASE // with underscores. "camelcase": true, // Prohibit use of == and != in favor of === and !==. "eqeqeq": true, // Suppress warnings about == null comparisons. "eqnull": true, // Enforce tab width of 2 spaces. "indent": 2, // Prohibit use of a variable before it is defined. "latedef": true, // Require capitalized names for constructor functions. "newcap": true, // Enforce use of single quotation marks for strings. "quotmark": "single", // Prohibit trailing whitespace. "trailing": true, // Prohibit use of explicitly undeclared variables. "undef": true, // Warn when variables are defined but never used. "unused": true, // Enforce line length to 80 characters "maxlen": 80, // Enforce placing 'use strict' at the top function scope "strict": true' } </ins>


Question:
<!-- NOTE: If you're reporting a security issue, don't create a GitHub issue. Instead, email We will look into it immediately. --In the exercise, one of the condition is "The globalTitle variable should not change." but it returns an error if you modified the var (for debugging) at the top, even if your function doesn't mutate it. The verification should be that the initial globalTitle variable is the same as the final one, instead of simply looking to match it to a string. Add a Link to the page with the problem:
Hello there, Ideally, I agree, the tests would be robust enough to account for something like this. However, there is usually a reason for the comments, and users should not expect their code to pass, if they ignore this. If others agree to change this, I would not be opposed to the first test being removed. I cannot see it being used in any meaningful way in the seed.
I would argue that, as this lesson comes after the section, users should be somewhat comfortable with using . Changing a global variable's hard-coded value seems like a less practical debugging method than logging a function call with the argument value to debug. Additionally, as mentioned, the is present to indicate which portions of the seed code should not be modified.
for debugging purposes, instead of changing a variable you are told to not change you should change the function call, wiritng there but, yeah, it's a thing that trips many up. But dealing with small details is also something that should be learned
I believe the original purpose of the global variable was to actually pass a variable with a known value () to the function and validate that the function does not mutate it. However, the tests do not even check for this case. Such a test would look like: As states, the user should be writing their own calls to the function to test it, instead of changing the global variable. One way to possibly handle this, would be to remove the global variable declaration and use something similar as I mentioned above: I would argue, this kind of test should be to all the functional programming challenges, since this is one of the main concepts to learn.
I can go ahead and submit a PR if we'd like to go this route.
can a string even be mutated in that way? shouldn't strings be immutable and so that is not possible in any case? the test should be to make sure the user reference function parameter instead of a global variable even if the global variable is present, I think To see if passed in argument is not mutated should be a thing to check with arrays and objects, as those are mutable
you are correct that strings are immutable, but it is possible to reassign the value of the variable within the function (which is bad practise, thus the reason for the test I believe).
I mean if the global variable is removed from the editor you can't change a global string by operating on function parameter, right?
Correct - if we remove the global variable entirely, then it cannot be modified. If we leave it, it can only be modified by assigning the value to that variable name within the function. However, in general it is bad practise to modify the values of a function's arguments directly - with strings, it is less harmful than it is with arrays, but I believe that was the intent behind this particular test case. !
I should not have used the word "mutable". Looking at the challenge again, I think it would be fine to remove the global variable all together as it is not used in any other test (except the first). So, my suggestion is to remove the declaration and remove the first test, unless someone else can find a good reason to keep them.
I have some errands to run, but can submit a PR later this evening. If anyone else would like to tackle this before then, let me know and I'll gladly step back and give you the opportunity!
I would like to work on this issue, if that's okay with you .
By all means, go ahead! As a note, issues labelled with the "help wanted" tag (like this one) don't require permission before submitting a PR - I only made my earlier comment to ensure my interest didn't deter other contributors. Feel free to let me know if you have any questions!

```yml tests:  - text: The globalTitle variable should not change. testString: assert(globalTitle === "Winter Is Coming");  - text: Your code should not use the replace method for this challenge. testString: assert(!code.match(/.?[sS]*?replace/g)); - text: urlSlug("Winter Is Coming") should return "winter-is-coming".


Question:
<!-- NOTE: If you're reporting a security issue, don't create a GitHub issue. Instead, email We will look into it immediately. --In the exercise, one of the condition is "The globalTitle variable should not change." but it returns an error if you modified the var (for debugging) at the top, even if your function doesn't mutate it. The verification should be that the initial globalTitle variable is the same as the final one, instead of simply looking to match it to a string. Add a Link to the page with the problem:
Hello there, Ideally, I agree, the tests would be robust enough to account for something like this. However, there is usually a reason for the comments, and users should not expect their code to pass, if they ignore this. If others agree to change this, I would not be opposed to the first test being removed. I cannot see it being used in any meaningful way in the seed.
I would argue that, as this lesson comes after the section, users should be somewhat comfortable with using . Changing a global variable's hard-coded value seems like a less practical debugging method than logging a function call with the argument value to debug. Additionally, as mentioned, the is present to indicate which portions of the seed code should not be modified.
for debugging purposes, instead of changing a variable you are told to not change you should change the function call, wiritng there but, yeah, it's a thing that trips many up. But dealing with small details is also something that should be learned
I believe the original purpose of the global variable was to actually pass a variable with a known value () to the function and validate that the function does not mutate it. However, the tests do not even check for this case. Such a test would look like: As states, the user should be writing their own calls to the function to test it, instead of changing the global variable. One way to possibly handle this, would be to remove the global variable declaration and use something similar as I mentioned above: I would argue, this kind of test should be to all the functional programming challenges, since this is one of the main concepts to learn.
I can go ahead and submit a PR if we'd like to go this route.
can a string even be mutated in that way? shouldn't strings be immutable and so that is not possible in any case? the test should be to make sure the user reference function parameter instead of a global variable even if the global variable is present, I think To see if passed in argument is not mutated should be a thing to check with arrays and objects, as those are mutable
you are correct that strings are immutable, but it is possible to reassign the value of the variable within the function (which is bad practise, thus the reason for the test I believe).
I mean if the global variable is removed from the editor you can't change a global string by operating on function parameter, right?
Correct - if we remove the global variable entirely, then it cannot be modified. If we leave it, it can only be modified by assigning the value to that variable name within the function. However, in general it is bad practise to modify the values of a function's arguments directly - with strings, it is less harmful than it is with arrays, but I believe that was the intent behind this particular test case. !
I should not have used the word "mutable". Looking at the challenge again, I think it would be fine to remove the global variable all together as it is not used in any other test (except the first). So, my suggestion is to remove the declaration and remove the first test, unless someone else can find a good reason to keep them.
I have some errands to run, but can submit a PR later this evening. If anyone else would like to tackle this before then, let me know and I'll gladly step back and give you the opportunity!
I would like to work on this issue, if that's okay with you .
By all means, go ahead! As a note, issues labelled with the "help wanted" tag (like this one) don't require permission before submitting a PR - I only made my earlier comment to ensure my interest didn't deter other contributors. Feel free to let me know if you have any questions!

<div id='js-seed'> ```js <del> // The global variable var globalTitle = "Winter Is Coming"; </del> // Only change code below this line function urlSlug(title) {


Question:
<!-- NOTE: If you're reporting a security issue, don't create a GitHub issue. Instead, email We will look into it immediately. --In the exercise, one of the condition is "The globalTitle variable should not change." but it returns an error if you modified the var (for debugging) at the top, even if your function doesn't mutate it. The verification should be that the initial globalTitle variable is the same as the final one, instead of simply looking to match it to a string. Add a Link to the page with the problem:
Hello there, Ideally, I agree, the tests would be robust enough to account for something like this. However, there is usually a reason for the comments, and users should not expect their code to pass, if they ignore this. If others agree to change this, I would not be opposed to the first test being removed. I cannot see it being used in any meaningful way in the seed.
I would argue that, as this lesson comes after the section, users should be somewhat comfortable with using . Changing a global variable's hard-coded value seems like a less practical debugging method than logging a function call with the argument value to debug. Additionally, as mentioned, the is present to indicate which portions of the seed code should not be modified.
for debugging purposes, instead of changing a variable you are told to not change you should change the function call, wiritng there but, yeah, it's a thing that trips many up. But dealing with small details is also something that should be learned
I believe the original purpose of the global variable was to actually pass a variable with a known value () to the function and validate that the function does not mutate it. However, the tests do not even check for this case. Such a test would look like: As states, the user should be writing their own calls to the function to test it, instead of changing the global variable. One way to possibly handle this, would be to remove the global variable declaration and use something similar as I mentioned above: I would argue, this kind of test should be to all the functional programming challenges, since this is one of the main concepts to learn.
I can go ahead and submit a PR if we'd like to go this route.
can a string even be mutated in that way? shouldn't strings be immutable and so that is not possible in any case? the test should be to make sure the user reference function parameter instead of a global variable even if the global variable is present, I think To see if passed in argument is not mutated should be a thing to check with arrays and objects, as those are mutable
you are correct that strings are immutable, but it is possible to reassign the value of the variable within the function (which is bad practise, thus the reason for the test I believe).
I mean if the global variable is removed from the editor you can't change a global string by operating on function parameter, right?
Correct - if we remove the global variable entirely, then it cannot be modified. If we leave it, it can only be modified by assigning the value to that variable name within the function. However, in general it is bad practise to modify the values of a function's arguments directly - with strings, it is less harmful than it is with arrays, but I believe that was the intent behind this particular test case. !
I should not have used the word "mutable". Looking at the challenge again, I think it would be fine to remove the global variable all together as it is not used in any other test (except the first). So, my suggestion is to remove the declaration and remove the first test, unless someone else can find a good reason to keep them.
I have some errands to run, but can submit a PR later this evening. If anyone else would like to tackle this before then, let me know and I'll gladly step back and give you the opportunity!
I would like to work on this issue, if that's okay with you .
By all means, go ahead! As a note, issues labelled with the "help wanted" tag (like this one) don't require permission before submitting a PR - I only made my earlier comment to ensure my interest didn't deter other contributors. Feel free to let me know if you have any questions!

<section id='solution'> ```js <del> // The global variable var globalTitle = "Winter Is Coming"; </del> // Only change code below this line function urlSlug(title) { return title.trim().split(/s+/).join("-").toLowerCase();


Question:
Describe the bug The completion model buttons are not correctly aligned. To Reproduce Steps to reproduce the behavior: to out. to the challenge run tests error Screenshots ! This is only on the development server, probably created by the css changes introduced by the landing page redesign.
I am able to confirm this bug. Looking at the elements: The Go To Next Challenge button has a left margin of 5px. ! The Download My Solution button has a top margin of 5px. !

return ( <Button bsStyle='default' <del> className={(block ? 'btn-cta-big' : '') + ' signup-btn btn-cta'} </del> <ins> className={(block ? 'btn-cta-big btn-block' : '') + ' signup-btn btn-cta'} </ins> data-test-label={dataTestLabel} href={href} onClick={() => gtagReportConversion()}


Question:
Describe the bug The completion model buttons are not correctly aligned. To Reproduce Steps to reproduce the behavior: to out. to the challenge run tests error Screenshots ! This is only on the development server, probably created by the css changes introduced by the landing page redesign.
I am able to confirm this bug. Looking at the elements: The Go To Next Challenge button has a left margin of 5px. ! The Download My Solution button has a top margin of 5px. !

</Modal.Body> <Modal.Footer> {isSignedIn ? null : ( <del> <Login block={true} bsSize='lg' bsStyle='primary' className='btn-cta' > Sign in to save your progress </Login> </del> <ins> <Login block={true}>Sign in to save your progress</Login> </ins> )} <Button block={true}


Question:
If there is no name set in the settings, doesn't matter if name is public or private, instead of falling back to username, it gives an error and certificate is not shown
I assume the best UX is for a note to appear, if the Camper tries to set to public, without having first set to something.
the error appears also if name is not set and set to private - certificate does not appear saying that one has to put a name (I'm adding this on top message too)
Picture !
The objective here then is to show the username on the certification if the name is not set ? Maybe some message then must warn the camper that his username will be shown on the certification instead of his real name (I am not sure though that a certification given to a weird username would be ok)
already if the name is private the username is shown, this issue appears if the name is not set
Apologies if this has nothing to do with you, but I vaguely remember you being involved in the discussion I cannot find: Was there any conclusion as to disabling the certification until a Camper has set their name, and made it public?
Sorry for the late response here - The only thing that comes to mind is
Either we would need to remove having usernames as a fallback , or having a public name requirements when displaying certs. I now it might be inconvenient, but I vote for removing the fallback for simplicity and keeping the public name as a requirement.
Discussing in issue triage meeting. a camper sets the to a non-empty string and , the certificate renders with the . .When a camper sets the to an empty string and either or , the certificate does not render and redirects to with a flash message. We should update the behaviour of to mirror the behaviour of , and avoid using the username field as a fallback entirely.
Hello Is this issue solved ?

}); } <del> if (!user.name) { </del> <ins> // If the user does not have a name, and have set their name to public, // warn them. Otherwise, fallback to username if (!user.name && user.showName) { </ins> return res.json({ messages: [ {


Question: Describe your problem and how to reproduce it: SVG image in the challenge description is affected by SVG logo in navbar. They share some element s, what results in malformed image in description. Changing s to make them not overlap should deal with the issue. The simplest way seems to be, to change one of the images (probably one in the challenge), for example by adding unique prefix to s. That wouldn't eliminate completely the chance for some other conflict in future, but that's probably not something to worry about much. Add a Link to the page with the problem: If possible, add a screenshot here (you can drag and drop, png, jpg, gif, etc. in this box): Current look ! Proper image !

<div style="width: 100%; text-align: center;"> <svg xmlns="https://www.w3.org/2000/svg" xmlns:xlink="https://www.w3.org/1999/xlink" width="520" height="170" aria-hidden="true" alt="Diagram showing the possible paths for 2 by 2 and 4 by 3 rectangles"> <style> <del> .g { fill: none; stroke: #ccc } .s, .s2 { fill: #bff; stroke: black; fill-opacity: .4 } .s2 { fill: #fbf } .d { stroke:black; fill:none} </del> <ins> .diagram-g { fill: none; stroke: #ccc } .diagram-s, .diagram-s2 { fill: #bff; stroke: black; fill-opacity: .4 } .diagram-s2 { fill: #fbf } .diagram-d { stroke:black; fill:none} </ins> </style> <del> <defs>	<g id="m"> <g id="h4"><g id="h2"> <path id="h" d="m0 10h 640" class="g"/> <use xlink:href="#h" transform="translate(0,20)"/></g> <use xlink:href="#h2" transform="translate(0, 40)"/></g> <use xlink:href="#h4" transform="translate(0,80)"/> <g id="v8"><g id="v4"><g id="v2"> <path id="v" d="m10 0v160 m 20 0 v-160" class="g"/> <use xlink:href="#v" transform="translate(40,0)"/></g> <use xlink:href="#v2" transform="translate(80,0)"/></g> <use xlink:href="#v4" transform="translate(160,0)"/></g> <use xlink:href="#v8" transform="translate(320,0)"/></g> <path id="b" d="m0 0h80v60h-80z" class="s"/> </del> <ins> <defs> <g id="diagram-m"> <g id="diagram-h4"> <g id="diagram-h2"> <path id="diagram-h" d="m0 10h 640" class="diagram-g"/> <use xlink:href="#diagram-h" transform="translate(0, 20)"/> </g> <use xlink:href="#diagram-h2" transform="translate(0, 40)"/> </g> <use xlink:href="#diagram-h4" transform="translate(0, 80)"/> <g id="diagram-v8"> <g id="diagram-v4"> <g id="diagram-v2"> <path id="diagram-v" d="m10 0v160 m 20 0 v-160" class="diagram-g"/> <use xlink:href="#diagram-v" transform="translate(40, 0)"/> </g> <use xlink:href="#diagram-v2" transform="translate(80, 0)"/> </g> <use xlink:href="#diagram-v4" transform="translate(160, 0)"/> </g> <use xlink:href="#diagram-v8" transform="translate(320, 0)"/> </g> <path id="diagram-b" d="m0 0h80v60h-80z" class="diagram-s"/> </ins> </defs> <del> <g transform="translate(.5,.5)"> <use xlink:href="#m"/> <g transform="translate(10,10)"> <path d="m0 0v40h40v-40z" class="s2"/><path d="m20 0v40" class="d"/> <path d="m60 0v40h40v-40z" class="s2"/><path d="m60 20h40" class="d"/> <g transform="translate(120, 0)"> <use xlink:href="#b"/><path d="m0 20h40v20h40" class="d"/></g> <g transform="translate(220, 0)"> <use xlink:href="#b"/><path d="m0 40h40v-20h40" class="d"/></g> <g transform="translate(320, 0)"> <use xlink:href="#b"/><path d="m20 0v40h20v-20h20v40" class="d"/></g> <g transform="translate(420, 0)"> <use xlink:href="#b"/><path d="m60 0v40h-20v-20h-20v40" class="d"/></g> <g transform="translate(20, 80)"> <use xlink:href="#b"/><path d="m40 0v60" class="d"/></g> <g transform="translate(120, 80)"> <use xlink:href="#b"/><path d="m60 0v20h-20v20h-20v20" class="d"/></g> <g transform="translate(220, 80)"> <use xlink:href="#b"/><path d="m20 0v20h20v20h20v20" class="d"/></g> <g transform="translate(320, 80)"> <use xlink:href="#b"/><path d="m0 20h20v20h20v-20h20v20h20" class="d"/></g> <g transform="translate(420, 80)"> <use xlink:href="#b"/><path d="m0 40h20v-20h20v20h20v-20h20" class="d"/></g> </g></g> </svg> </div> </del> <ins> <g transform="translate(.5, .5)"> <use xlink:href="#diagram-m"/> <g transform="translate(10, 10)"> <path d="m0 0v40h40v-40z" class="diagram-s2"/> <path d="m20 0v40" class="diagram-d"/> <path d="m60 0v40h40v-40z" class="diagram-s2"/> <path d="m60 20h40" class="diagram-d"/> <g transform="translate(120, 0)"> <use xlink:href="#diagram-b"/> <path d="m0 20h40v20h40" class="diagram-d"/> </g> <g transform="translate(220, 0)"> <use xlink:href="#diagram-b"/> <path d="m0 40h40v-20h40" class="diagram-d"/> </g> <g transform="translate(320, 0)"> <use xlink:href="#diagram-b"/> <path d="m20 0v40h20v-20h20v40" class="diagram-d"/> </g> <g transform="translate(420, 0)"> <use xlink:href="#diagram-b"/> <path d="m60 0v40h-20v-20h-20v40" class="diagram-d"/> </g> <g transform="translate(20, 80)"> <use xlink:href="#diagram-b"/> <path d="m40 0v60" class="diagram-d"/> </g> <g transform="translate(120, 80)"> <use xlink:href="#diagram-b"/> <path d="m60 0v20h-20v20h-20v20" class="diagram-d"/> </g> <g transform="translate(220, 80)"> <use xlink:href="#diagram-b"/> <path d="m20 0v20h20v20h20v20" class="diagram-d"/> </g> <g transform="translate(320, 80)"> <use xlink:href="#diagram-b"/> <path d="m0 20h20v20h20v-20h20v20h20" class="diagram-d"/> </g> <g transform="translate(420, 80)"> <use xlink:href="#diagram-b"/> <path d="m0 40h20v-20h20v20h20v-20h20" class="diagram-d"/> </g> </g> </g> </svg> </div> </ins> # --instructions--


Question:
<!-- NOTE: If you want to become an author on freeCodeCamp, you can find everything here: --The sidebar text on "Standardize Times with the HTML5 datetime Attribute" says "The datetime attribute is an inline element that can wrap a date or time on a page." The attribute cannot be an inline element. Change it to: "The element is an inline element that can wrap a date or time on a page. " or "The is an inline element that can wrap a date or time on a page.". !
Hey good spot there I'll sort this

# --description-- <del> Continuing with the date theme, HTML5 also introduced the `time` element along with a `datetime` attribute to standardize times. The `datetime` attribute is an inline element that can wrap a date or time on a page. A `datetime` attribute holds a valid format of that date. This is the value accessed by assistive devices. It helps avoid confusion by stating a standardized version of a time, even if it's informally or colloquially written in the text. </del> <ins> Continuing with the date theme, HTML5 also introduced the `time` element along with a `datetime` attribute to standardize times. The `time` element is an inline element that can wrap a date or time on a page. A `datetime` attribute holds a valid format of that date. This is the value accessed by assistive devices. It helps avoid confusion by stating a standardized version of a time, even if it's informally or colloquially written in the text. </ins> Here's an example:


Question:
If I am signed in as a user while on and log out, I am redirected to the english home page. redirects to the chinese page.
wrong endpoint in server code? Thats what I would assume, but am not sure how to locate where the correct endpoint would be placed in the code.
Here is the endpoint: and most likely the issue is with the redirect "predictor" utility: However we would want to confirm the cause before we open this up for contributions.
yes, that's the issue. To fix it we can grab the from and combine that with to get the desired redirect.
Should that be done in the getRedirectParams function or should the path be put together from the data set returned by getRedirectParams in
You need to construct the URL from the values you get from the as a consumer of the function and not change its existing behavior. In simple terms the change is required within the endpoint handler.
That makes sense.
I got the codebase installed locally is there a way to run just
Not sure what you mean by running only one file? The API server is an express based application (Loopback 3). You need to start up at least the api-server app. If you want to do that, you should be able to do that by navigating to directory and using the run-script commands in its
I'm trying to figure out what gets passed in pathPrefix, from getRedirectParams, when one signs out from the Spanish page. But when running the site locally, switching to Espanol leads to a "This site can't be reached" error. Just for clarity's sake, I realize now that is not meant to be run alone and I am using the "npm run develop" command to try and recreate this bug locally. Is this a bad approach?
Ah - right. Sorry about sending you on a goose-chase. When you build locally, we do not have a way yet to develop both and at the same time alongside the API app. I am going to untag this from help-wanted and assign this instead. Oliver, you should be able to test / reproduce and recommend a fix on our staging instance - not sure because this may be needing access for "close to prod" type setup.
I was just in the process of going through the steps, when you commented Mrugesh! I'll leave them here for the curious: Unfortunately testing locally is quite a pain, because we use since is entirely separate from . It's a bit of a slow, memory intensive process, but you can do this: in your .env file Then you can go to

} api.get('/signout', (req, res) => { <del> const { origin } = getRedirectParams(req); </del> <ins> const { origin, returnTo } = getRedirectParams(req); </ins> req.logout(); req.session.destroy(err => { if (err) {


Question:
If I am signed in as a user while on and log out, I am redirected to the english home page. redirects to the chinese page.
wrong endpoint in server code? Thats what I would assume, but am not sure how to locate where the correct endpoint would be placed in the code.
Here is the endpoint: and most likely the issue is with the redirect "predictor" utility: However we would want to confirm the cause before we open this up for contributions.
yes, that's the issue. To fix it we can grab the from and combine that with to get the desired redirect.
Should that be done in the getRedirectParams function or should the path be put together from the data set returned by getRedirectParams in
You need to construct the URL from the values you get from the as a consumer of the function and not change its existing behavior. In simple terms the change is required within the endpoint handler.
That makes sense.
I got the codebase installed locally is there a way to run just
Not sure what you mean by running only one file? The API server is an express based application (Loopback 3). You need to start up at least the api-server app. If you want to do that, you should be able to do that by navigating to directory and using the run-script commands in its
I'm trying to figure out what gets passed in pathPrefix, from getRedirectParams, when one signs out from the Spanish page. But when running the site locally, switching to Espanol leads to a "This site can't be reached" error. Just for clarity's sake, I realize now that is not meant to be run alone and I am using the "npm run develop" command to try and recreate this bug locally. Is this a bad approach?
Ah - right. Sorry about sending you on a goose-chase. When you build locally, we do not have a way yet to develop both and at the same time alongside the API app. I am going to untag this from help-wanted and assign this instead. Oliver, you should be able to test / reproduce and recommend a fix on our staging instance - not sure because this may be needing access for "close to prod" type setup.
I was just in the process of going through the steps, when you commented Mrugesh! I'll leave them here for the curious: Unfortunately testing locally is quite a pain, because we use since is entirely separate from . It's a bit of a slow, memory intensive process, but you can do this: in your .env file Then you can go to

}); } removeCookies(req, res); <del> res.redirect(origin); </del> <ins> res.redirect(returnTo); </ins> }); });


Question:
If I am signed in as a user while on and log out, I am redirected to the english home page. redirects to the chinese page.
wrong endpoint in server code? Thats what I would assume, but am not sure how to locate where the correct endpoint would be placed in the code.
Here is the endpoint: and most likely the issue is with the redirect "predictor" utility: However we would want to confirm the cause before we open this up for contributions.
yes, that's the issue. To fix it we can grab the from and combine that with to get the desired redirect.
Should that be done in the getRedirectParams function or should the path be put together from the data set returned by getRedirectParams in
You need to construct the URL from the values you get from the as a consumer of the function and not change its existing behavior. In simple terms the change is required within the endpoint handler.
That makes sense.
I got the codebase installed locally is there a way to run just
Not sure what you mean by running only one file? The API server is an express based application (Loopback 3). You need to start up at least the api-server app. If you want to do that, you should be able to do that by navigating to directory and using the run-script commands in its
I'm trying to figure out what gets passed in pathPrefix, from getRedirectParams, when one signs out from the Spanish page. But when running the site locally, switching to Espanol leads to a "This site can't be reached" error. Just for clarity's sake, I realize now that is not meant to be run alone and I am using the "npm run develop" command to try and recreate this bug locally. Is this a bad approach?
Ah - right. Sorry about sending you on a goose-chase. When you build locally, we do not have a way yet to develop both and at the same time alongside the API app. I am going to untag this from help-wanted and assign this instead. Oliver, you should be able to test / reproduce and recommend a fix on our staging instance - not sure because this may be needing access for "close to prod" type setup.
I was just in the process of going through the steps, when you commented Mrugesh! I'll leave them here for the curious: Unfortunately testing locally is quite a pain, because we use since is entirely separate from . It's a bit of a slow, memory intensive process, but you can do this: in your .env file Then you can go to

isRootPath } from './utils/redirection'; import { jwtSecret } from '../../../config/secrets'; <ins> import { availableLangs } from '../../../config/i18n/all-langs'; </ins> const passportOptions = { emailOptional: true,


Question:
If I am signed in as a user while on and log out, I am redirected to the english home page. redirects to the chinese page.
wrong endpoint in server code? Thats what I would assume, but am not sure how to locate where the correct endpoint would be placed in the code.
Here is the endpoint: and most likely the issue is with the redirect "predictor" utility: However we would want to confirm the cause before we open this up for contributions.
yes, that's the issue. To fix it we can grab the from and combine that with to get the desired redirect.
Should that be done in the getRedirectParams function or should the path be put together from the data set returned by getRedirectParams in
You need to construct the URL from the values you get from the as a consumer of the function and not change its existing behavior. In simple terms the change is required within the endpoint handler.
That makes sense.
I got the codebase installed locally is there a way to run just
Not sure what you mean by running only one file? The API server is an express based application (Loopback 3). You need to start up at least the api-server app. If you want to do that, you should be able to do that by navigating to directory and using the run-script commands in its
I'm trying to figure out what gets passed in pathPrefix, from getRedirectParams, when one signs out from the Spanish page. But when running the site locally, switching to Espanol leads to a "This site can't be reached" error. Just for clarity's sake, I realize now that is not meant to be run alone and I am using the "npm run develop" command to try and recreate this bug locally. Is this a bad approach?
Ah - right. Sorry about sending you on a goose-chase. When you build locally, we do not have a way yet to develop both and at the same time alongside the API app. I am going to untag this from help-wanted and assign this instead. Oliver, you should be able to test / reproduce and recommend a fix on our staging instance - not sure because this may be needing access for "close to prod" type setup.
I was just in the process of going through the steps, when you commented Mrugesh! I'll leave them here for the curious: Unfortunately testing locally is quite a pain, because we use since is entirely separate from . It's a bit of a slow, memory intensive process, but you can do this: in your .env file Then you can go to

export const devLoginRedirect = () => { return (req, res) => { <del> // this mirrors the production approach, but without any validation </del> <ins> // this mirrors the production approach, but only validates the prefix </ins> let { returnTo, origin, pathPrefix } = getRedirectParams( req, <del> params => params </del> <ins> ({ returnTo, origin, pathPrefix }) => { pathPrefix = availableLangs.client.includes(pathPrefix) ? pathPrefix : ''; return { returnTo, origin, pathPrefix }; } </ins> ); returnTo += isRootPath(getRedirectBase(origin, pathPrefix), returnTo) <del> ? 'learn' </del> <ins> ? '/learn' </ins> : ''; return res.redirect(returnTo); };


Question:
If I am signed in as a user while on and log out, I am redirected to the english home page. redirects to the chinese page.
wrong endpoint in server code? Thats what I would assume, but am not sure how to locate where the correct endpoint would be placed in the code.
Here is the endpoint: and most likely the issue is with the redirect "predictor" utility: However we would want to confirm the cause before we open this up for contributions.
yes, that's the issue. To fix it we can grab the from and combine that with to get the desired redirect.
Should that be done in the getRedirectParams function or should the path be put together from the data set returned by getRedirectParams in
You need to construct the URL from the values you get from the as a consumer of the function and not change its existing behavior. In simple terms the change is required within the endpoint handler.
That makes sense.
I got the codebase installed locally is there a way to run just
Not sure what you mean by running only one file? The API server is an express based application (Loopback 3). You need to start up at least the api-server app. If you want to do that, you should be able to do that by navigating to directory and using the run-script commands in its
I'm trying to figure out what gets passed in pathPrefix, from getRedirectParams, when one signs out from the Spanish page. But when running the site locally, switching to Espanol leads to a "This site can't be reached" error. Just for clarity's sake, I realize now that is not meant to be run alone and I am using the "npm run develop" command to try and recreate this bug locally. Is this a bad approach?
Ah - right. Sorry about sending you on a goose-chase. When you build locally, we do not have a way yet to develop both and at the same time alongside the API app. I am going to untag this from help-wanted and assign this instead. Oliver, you should be able to test / reproduce and recommend a fix on our staging instance - not sure because this may be needing access for "close to prod" type setup.
I was just in the process of going through the steps, when you commented Mrugesh! I'll leave them here for the curious: Unfortunately testing locally is quite a pain, because we use since is entirely separate from . It's a bit of a slow, memory intensive process, but you can do this: in your .env file Then you can go to

const origin = returnUrl.origin; // if this is not one of the client languages, validation will convert // this to '' before it is used. <del> const pathPrefix = returnUrl.pathname.split('/')[0]; </del> <ins> const pathPrefix = returnUrl.pathname.split('/')[1]; </ins> return _normalizeParams({ returnTo: returnUrl.href, origin, pathPrefix }); }


Question:
Describe the bug The arrow to the left of Expand courses/Collapse courses buttons points down when the list is in collapsed state and points up when the list is in expanded state. This is opposed to standard behavior of similar features in other apps. To Reproduce Steps to reproduce the behavior: to at the arrow to the left of Collapse courses. It points up while the list is in expanded state. on the above mentioned button to collapse the list. the list is collapsed state but the arrow points down. Expected behavior By convention, the arrow should point to the right or up when the list is in collapsed state and point down when the list is in expanded state. Screenshots ! ! Desktop: OS: Ubuntu 20.04.2 LTS Browser: Opera Version: 76 Additional context Also tested this on the same OS with Firefox 88.0.1 with the same result.
I agree, we should have the arrow pointing to the left when the courses are collapsed and down when they are expanded.
Hi Ahmad, I think you mean we should have the arrow pointing to the right when the courses are collapsed, right?
Hi. I'm new to contributing to FreecodeCamp, and just read the guidelines. With your permission, I will fork the project and try to solve the issue with a pull request.

stroke: var(--color-quaternary); } <del> .map-title svg:first-child { transform: rotate(90deg); } </del> .open > .map-title svg:first-child { <del> transform: rotate(-90deg); </del> <ins> transform: rotate(90deg); </ins> } .map-challenges-ul {


Question: ! there is written stUnes instead of stOnes This looks something that can be fixed by "first time" code contributors to this repository. Here are the files that you should be looking at to work on a fix: List of files: Please make sure you read , we prioritize contributors following the instructions in our guides. Join us in or if you need help contributing, our moderators will guide you through this. Sometimes we may get more than one pull requests. We typically accept the most quality contribution followed by the one that is made first. Happy contributing.

A game is played with three piles of stones and two players. <del> On each player's turn, the player removes one or more stones from the piles. However, if the player takes stones from more than one pile, the same number of stunes must be removed from each of the selected piles. </del> <ins> On each player's turn, the player removes one or more stones from the piles. However, if the player takes stones from more than one pile, the same number of stones must be removed from each of the selected piles. </ins> In other words, the player chooses some $N > 0$ and removes:


Question:
!
If possible please assign this issue to me! as I am new to open source
For future reference, it would help to have a link to the challenge when creating an issue It's To clarify, you want to change: to: That's not bad. What about
Yes, that is better! and sorry for any inconvenience as I am new to open source
Please, can you assign me to resolve that issue? That'll be a great start for my open source journey!
We do not assign issues The first PR that fixes the problem will be accepted. If you have not done so already, you should read the . Thanks for your interest in contributing If you have any questions, feel free to ask - or you can reach out in the
Please review the PR
please be patient, people will review when they can.
Alright!

Text is often a large part of web content. CSS has several options for how to align it with the `text-align` property. <del> `text-align: justify;` causes all lines of text except the last line to meet the left and right edges of the line box. </del> <ins> `text-align: justify;` spaces the text so that each line has equal width. </ins> `text-align: center;` centers the text


Question:
Hey everyone! On the lesson , with regards to and , it says: I think this is not actually correct. A more appropriate definition could be: Otherwise it may lead people to believe it's getting before/after the actual element. Another definition could be (taken from the MDN):
i'll do it (i like MDN definition)

# --description-- <del> One of the most popular shapes in the world is the heart shape, and in this challenge you'll create one using pure CSS. But first, you need to understand the `::before` and `::after` pseudo-elements. These pseudo-elements are used to add something before or after a selected element. In the following example, a `::before` pseudo-element is used to add a rectangle to an element with the class `heart`: </del> <ins> One of the most popular shapes in the world is the heart shape, and in this challenge you'll create one using pure CSS. But first, you need to understand the `::before` and `::after` pseudo-elements. ::before creates a pseudo-element that is the first child of the selected element; ::after creates a pseudo-element that is the last child of the selected element. In the following example, a `::before` pseudo-element is used to add a rectangle to an element with the class `heart`: </ins> ```css .heart::before {


Question:
The instruction looks kinda confusing. The word can be replaced by . ! <!-- Please complete the following information. --- Device: Laptop OS: Windows 10 Browser: firefox Version: 98.0.1 (64-bit) <!-- Add any other context about the problem here. --
Yeah - I see what you mean here. While it's implicit and really a nitpick, we can be clear as water in verbiage.

The `fieldset` element is used to group related inputs and labels together in a web form. `fieldset` elements are <dfn>block-level elements</dfn>, meaning that they appear on a new line. <del> Nest the `Indoor` and `Outdoor` radio buttons within a `fieldset` element, and don't forget to indent the buttons. </del> <ins> Nest the `Indoor` and `Outdoor` radio buttons within a `fieldset` element, and don't forget to indent the radio buttons. </ins> # --hints--


Question:
The title for code preview modals is left aligned. The rest of our modals have a centered title. to on view -show code left aligned title it -click view -show project is centered Center the title Code modal: ! Preview modal: ! I think I would just center the title, not the HTML/CSS/JS title
I wonder how should I tackle these, If I can tackle it of course. there is there solution: adding inline CSS to the adding with value to file we can go wild and change value to include
I would look at how the other titles are getting centered. Maybe there's just a class to those we didn't add on the others or something.
I see there is with value , I will start working on it

show={solutionOpen} > <Modal.Header closeButton={true}> <del> <Modal.Title id='contained-modal-title'> </del> <ins> <Modal.Title id='contained-modal-title' className='text-center'> </ins> {`${username}'s Solution to ${ idToNameMap.get(id)?.challengeTitle ?? '' }`}


Question:
Even though on macOS it would seem that Ctrl+Enter does not work & Cmd+Enter does; website still tells you to use Ctrl+Enter. I think this might end up being confusing for some - and should be fairly straightforward of a change. All coding pages You must use macOS for this issue. to any coding challenge your changes will see button underneath says "Check your code (Ctrl + Enter)" Ctrl + Enter will happen. Cmd + Enter behaviour will occur. It should tell the user correct shortcut (Cmd + Enter) instead of (Ctrl + Enter) depending on the platform. <img width="647" alt="Screenshot 2022-06-09 at 16 52 28" src="https://user-"- Device: M1 MacBook Pro OS: macOS 12.0.1 Browser: Safari Version: 15.1 No response
I would like to handle this issue as a first contribution. My proposal would be to use (). Use Ctrl + Enter as a fallback and define a special case for macOS cases. Alternatively we could use () however that is not widely supported as opposed to . As far as I can tell on mobile we don't show modifier keys on the button; so I'll preserve that behaviour. I can't change the labels on this issue - I don't think this is severe enough to be classified as a bug based on definition; my apologies regarding that.
Hey thanks for raising this issue and don't worry about the labels, they need to be handled by maintainers. What you've suggested does sound good to me, so if you're happy to take this on, that's awesome.
I've created the PR however; I've updated non English translations as well in here to use dynamic values; however not really sure how to align it with the crowdin. Since updated translations should coincide with this change; any opinions on this?
Do not worry, I think you are putting too much effort into it. Simply drop the changes to those files and as the bot mentioned, they will get updated eventually via our translation workflow. As for the bug itself: I am 100% sure at some point we introduced a regression, because (in addition to the implicit Cmd + Enter) was working since the inception of the code editor. do you happen to know if this was just an accident with the new editor? To be clear it should always work with regardless of the OS in addition to implicitly working with just like it was before.
I can't check this myself, since I don't have a mac, but it should work. This is the code: and could you try and reproduce the issue?
I've shot a short video of the behaviour I am seeing; if that helps.
That does help, yeah. It seems to be ignoring the command button entirely, which is odd. I can't investigate myself, but this will help anyone that has access to a Mac.
Thanks for the video I don't recall if ctrl+enter ever worked on mac - I may or may not have ever used it. I just hit buttons without looking I'm not sure if you are trying to show something specific with those code snippets - that's the code on main. Which results in the current behavior. Edit: I get it now - you were just showing the code and that it should be working. I thought you trying to show new changes or something. Here's the current behavior I see (all on mac) - there's some nuance... New RWD: Execute: only command+enter works on mac Submit: Enter alone works, so any key+enter works Legacy RWD, JS, etc: Execute: Only cmd+enter works Submit: Enter alone does not work - both ctrl+enter or command+enter do work Multiple choice Python video questions: Execute: Enter alone does not work - ctrl+enter and cmd+enter work Submit: Enter alone does not work - both ctrl+enter or command+enter do work Projects with URL inputs - e.g. front end libs cert project, or backend api challenges, etc: Execute: Enter alone works cause it's a form I suppose, which also means any key+enter works Submit: Enter alone does not work - both ctrl+enter or command+enter do work The last three groups there have the same submit modal, so the behavior is the same on all of them. What I see is that the submit modal, and the video question both allow [ctrl or cmd] +enter - we should see what those are doing. Looking into to it...
K, I think I found a fix. ctrl+enter works when the hotkeys package/component is used. So crtl+enter actually does work on the legacy challenges when the instructions are focused. When the editor is focused, those hotkeys don't get used, the actions/hotkeys we add to the editor take over. I made ctrl+enter work when the editor is focused by changing that line 431 mentioned to this: That should work. There's a number of actions in that file that use the same hotkeys - lines 457 and 469 for example. There may be others. I think we should be safe to change all those. Do you mind playing with that a bit and updating the PR to make those changes.
Nice work, Tom. I thought CtrlCmd was "Ctrl or Command", but it must be Ctrl on Windows and Command on Mac :man_facepalming: I guess this has never worked properly.
happy to give it a look and update the PR. Thank you
Here's an I had created sometime back when working on the . Apparently the logic goes like this - the first word is Windows and the second one is Mac button.

id: 'execute-challenge', label: 'Run tests', /* eslint-disable no-bitwise */ <del> keybindings: [monaco.KeyMod.CtrlCmd | monaco.KeyCode.Enter], </del> <ins> keybindings: [ monaco.KeyMod.CtrlCmd | monaco.KeyCode.Enter, monaco.KeyMod.WinCtrl | monaco.KeyCode.Enter ], </ins> run: () => { if (props.usesMultifileEditor && !isFinalProject(props.challengeType)) { if (challengeIsComplete()) {


Question:
Even though on macOS it would seem that Ctrl+Enter does not work & Cmd+Enter does; website still tells you to use Ctrl+Enter. I think this might end up being confusing for some - and should be fairly straightforward of a change. All coding pages You must use macOS for this issue. to any coding challenge your changes will see button underneath says "Check your code (Ctrl + Enter)" Ctrl + Enter will happen. Cmd + Enter behaviour will occur. It should tell the user correct shortcut (Cmd + Enter) instead of (Ctrl + Enter) depending on the platform. <img width="647" alt="Screenshot 2022-06-09 at 16 52 28" src="https://user-"- Device: M1 MacBook Pro OS: macOS 12.0.1 Browser: Safari Version: 15.1 No response
I would like to handle this issue as a first contribution. My proposal would be to use (). Use Ctrl + Enter as a fallback and define a special case for macOS cases. Alternatively we could use () however that is not widely supported as opposed to . As far as I can tell on mobile we don't show modifier keys on the button; so I'll preserve that behaviour. I can't change the labels on this issue - I don't think this is severe enough to be classified as a bug based on definition; my apologies regarding that.
Hey thanks for raising this issue and don't worry about the labels, they need to be handled by maintainers. What you've suggested does sound good to me, so if you're happy to take this on, that's awesome.
I've created the PR however; I've updated non English translations as well in here to use dynamic values; however not really sure how to align it with the crowdin. Since updated translations should coincide with this change; any opinions on this?
Do not worry, I think you are putting too much effort into it. Simply drop the changes to those files and as the bot mentioned, they will get updated eventually via our translation workflow. As for the bug itself: I am 100% sure at some point we introduced a regression, because (in addition to the implicit Cmd + Enter) was working since the inception of the code editor. do you happen to know if this was just an accident with the new editor? To be clear it should always work with regardless of the OS in addition to implicitly working with just like it was before.
I can't check this myself, since I don't have a mac, but it should work. This is the code: and could you try and reproduce the issue?
I've shot a short video of the behaviour I am seeing; if that helps.
That does help, yeah. It seems to be ignoring the command button entirely, which is odd. I can't investigate myself, but this will help anyone that has access to a Mac.
Thanks for the video I don't recall if ctrl+enter ever worked on mac - I may or may not have ever used it. I just hit buttons without looking I'm not sure if you are trying to show something specific with those code snippets - that's the code on main. Which results in the current behavior. Edit: I get it now - you were just showing the code and that it should be working. I thought you trying to show new changes or something. Here's the current behavior I see (all on mac) - there's some nuance... New RWD: Execute: only command+enter works on mac Submit: Enter alone works, so any key+enter works Legacy RWD, JS, etc: Execute: Only cmd+enter works Submit: Enter alone does not work - both ctrl+enter or command+enter do work Multiple choice Python video questions: Execute: Enter alone does not work - ctrl+enter and cmd+enter work Submit: Enter alone does not work - both ctrl+enter or command+enter do work Projects with URL inputs - e.g. front end libs cert project, or backend api challenges, etc: Execute: Enter alone works cause it's a form I suppose, which also means any key+enter works Submit: Enter alone does not work - both ctrl+enter or command+enter do work The last three groups there have the same submit modal, so the behavior is the same on all of them. What I see is that the submit modal, and the video question both allow [ctrl or cmd] +enter - we should see what those are doing. Looking into to it...
K, I think I found a fix. ctrl+enter works when the hotkeys package/component is used. So crtl+enter actually does work on the legacy challenges when the instructions are focused. When the editor is focused, those hotkeys don't get used, the actions/hotkeys we add to the editor take over. I made ctrl+enter work when the editor is focused by changing that line 431 mentioned to this: That should work. There's a number of actions in that file that use the same hotkeys - lines 457 and 469 for example. There may be others. I think we should be safe to change all those. Do you mind playing with that a bit and updating the PR to make those changes.
Nice work, Tom. I thought CtrlCmd was "Ctrl or Command", but it must be Ctrl on Windows and Command on Mac :man_facepalming: I guess this has never worked properly.
happy to give it a look and update the PR. Thank you
Here's an I had created sometime back when working on the . Apparently the logic goes like this - the first word is Windows and the second one is Mac button.

editor.addAction({ id: 'save-editor-content', label: 'Save editor content', <del> keybindings: [monaco.KeyMod.CtrlCmd | monaco.KeyCode.KEY_S], </del> <ins> keybindings: [ monaco.KeyMod.CtrlCmd | monaco.KeyCode.KEY_S, monaco.KeyMod.WinCtrl | monaco.KeyCode.KEY_S ], </ins> run: props.challengeType === challengeTypes.multifileCertProject && props.isSignedIn


Question:
Even though on macOS it would seem that Ctrl+Enter does not work & Cmd+Enter does; website still tells you to use Ctrl+Enter. I think this might end up being confusing for some - and should be fairly straightforward of a change. All coding pages You must use macOS for this issue. to any coding challenge your changes will see button underneath says "Check your code (Ctrl + Enter)" Ctrl + Enter will happen. Cmd + Enter behaviour will occur. It should tell the user correct shortcut (Cmd + Enter) instead of (Ctrl + Enter) depending on the platform. <img width="647" alt="Screenshot 2022-06-09 at 16 52 28" src="https://user-"- Device: M1 MacBook Pro OS: macOS 12.0.1 Browser: Safari Version: 15.1 No response
I would like to handle this issue as a first contribution. My proposal would be to use (). Use Ctrl + Enter as a fallback and define a special case for macOS cases. Alternatively we could use () however that is not widely supported as opposed to . As far as I can tell on mobile we don't show modifier keys on the button; so I'll preserve that behaviour. I can't change the labels on this issue - I don't think this is severe enough to be classified as a bug based on definition; my apologies regarding that.
Hey thanks for raising this issue and don't worry about the labels, they need to be handled by maintainers. What you've suggested does sound good to me, so if you're happy to take this on, that's awesome.
I've created the PR however; I've updated non English translations as well in here to use dynamic values; however not really sure how to align it with the crowdin. Since updated translations should coincide with this change; any opinions on this?
Do not worry, I think you are putting too much effort into it. Simply drop the changes to those files and as the bot mentioned, they will get updated eventually via our translation workflow. As for the bug itself: I am 100% sure at some point we introduced a regression, because (in addition to the implicit Cmd + Enter) was working since the inception of the code editor. do you happen to know if this was just an accident with the new editor? To be clear it should always work with regardless of the OS in addition to implicitly working with just like it was before.
I can't check this myself, since I don't have a mac, but it should work. This is the code: and could you try and reproduce the issue?
I've shot a short video of the behaviour I am seeing; if that helps.
That does help, yeah. It seems to be ignoring the command button entirely, which is odd. I can't investigate myself, but this will help anyone that has access to a Mac.
Thanks for the video I don't recall if ctrl+enter ever worked on mac - I may or may not have ever used it. I just hit buttons without looking I'm not sure if you are trying to show something specific with those code snippets - that's the code on main. Which results in the current behavior. Edit: I get it now - you were just showing the code and that it should be working. I thought you trying to show new changes or something. Here's the current behavior I see (all on mac) - there's some nuance... New RWD: Execute: only command+enter works on mac Submit: Enter alone works, so any key+enter works Legacy RWD, JS, etc: Execute: Only cmd+enter works Submit: Enter alone does not work - both ctrl+enter or command+enter do work Multiple choice Python video questions: Execute: Enter alone does not work - ctrl+enter and cmd+enter work Submit: Enter alone does not work - both ctrl+enter or command+enter do work Projects with URL inputs - e.g. front end libs cert project, or backend api challenges, etc: Execute: Enter alone works cause it's a form I suppose, which also means any key+enter works Submit: Enter alone does not work - both ctrl+enter or command+enter do work The last three groups there have the same submit modal, so the behavior is the same on all of them. What I see is that the submit modal, and the video question both allow [ctrl or cmd] +enter - we should see what those are doing. Looking into to it...
K, I think I found a fix. ctrl+enter works when the hotkeys package/component is used. So crtl+enter actually does work on the legacy challenges when the instructions are focused. When the editor is focused, those hotkeys don't get used, the actions/hotkeys we add to the editor take over. I made ctrl+enter work when the editor is focused by changing that line 431 mentioned to this: That should work. There's a number of actions in that file that use the same hotkeys - lines 457 and 469 for example. There may be others. I think we should be safe to change all those. Do you mind playing with that a bit and updating the PR to make those changes.
Nice work, Tom. I thought CtrlCmd was "Ctrl or Command", but it must be Ctrl on Windows and Command on Mac :man_facepalming: I guess this has never worked properly.
happy to give it a look and update the PR. Thank you
Here's an I had created sometime back when working on the . Apparently the logic goes like this - the first word is Windows and the second one is Mac button.

editor.addAction({ id: 'toggle-accessibility', label: 'Toggle Accessibility Mode', <del> keybindings: [monaco.KeyMod.CtrlCmd | monaco.KeyCode.KEY_E], </del> <ins> keybindings: [ monaco.KeyMod.CtrlCmd | monaco.KeyCode.KEY_E, monaco.KeyMod.WinCtrl | monaco.KeyCode.KEY_E ], </ins> run: () => { const currentAccessibility = storedAccessibilityMode();


Question:
Overly strict whitespace tests The space between the input element and closing label tag shouldn't matter, right? No response All No response
Here is the markdown file: we can use regex in these tests Something like , but we have to use regex which is headache.
could we just trim the string?
Sure, I don't mind, because they aren't required to type text in this step, but the description will be altered
I'm not sure I see why the description would be changed. I was thinking of this:
Yes, this line while be unnecessary. And the test will check for `EnterYourLastName:<input' But I maybe misunderstanding something
Trim won't remove spaces in the middle. We are comparing against:

You should add the first `input` after the `label` text `Enter Your First Name:`, and include a space after the colon. ```js <del> assert.equal(document.querySelectorAll('label')?.[0]?.innerHTML, 'Enter Your First Name: <input>'); </del> <ins> assert.equal(document.querySelectorAll('label')?.[0]?.innerHTML.trim(), 'Enter Your First Name: <input>'); </ins> ``` You should add the second `input` after the `label` text `Enter Your Last Name:`, and include a space after the colon. ```js <del> assert.equal(document.querySelectorAll('label')?.[1]?.innerHTML, 'Enter Your Last Name: <input>'); </del> <ins> assert.equal(document.querySelectorAll('label')?.[1]?.innerHTML.trim(), 'Enter Your Last Name: <input>'); </ins> ``` You should add the third `input` after the `label` text `Enter Your Email:`, and include a space after the colon. ```js <del> assert.equal(document.querySelectorAll('label')?.[2]?.innerHTML, 'Enter Your Email: <input>'); </del> <ins> assert.equal(document.querySelectorAll('label')?.[2]?.innerHTML.trim(), 'Enter Your Email: <input>'); </ins> ``` You should add the fourth `input` after the `label` text `Create a New Password:`, and include a space after the colon. ```js <del> assert.equal(document.querySelectorAll('label')?.[3]?.innerHTML, 'Create a New Password: <input>'); </del> <ins> assert.equal(document.querySelectorAll('label')?.[3]?.innerHTML.trim(), 'Create a New Password: <input>'); </ins> ``` # --seed--


Question:
there is a typo in cramers-rule challenge, is used instead of which is wrong these sentences should be changed to Here is the markdown file Please make sure you read , we prioritize contributors following the instructions in our guides. Join us in or if you need help contributing, our moderators will guide you through this. Sometimes we may get more than one pull requests. We typically accept the most quality contribution, followed by the one that is made first. Happy contributing.
I wanted to work on this issue
feel free to open pull request after you have read

# --description--  Cramer's rule is a formula for solving a system of linear equations by using the determinants of matrixes formed from subsets of the coefficients and right hand side values.   Cramer's rule is a formula for solving a system of linear equations by using the determinants of matrices formed from subsets of the coefficients and right hand side values.   The determinate of a matrix with 2 rows and two columns is given by:   The determinant of a matrix with 2 rows and two columns is given by:  $begin{aligned}|A|={begin{vmatrix}a&bc&dend{vmatrix}}=ad-bc.end{aligned}$


Question:
In the page above, a question (Which activation function switches values between -1 and 1?) uses 'switches' when the actual word should be 'squishes' (like Tim says in the video) The question should be: Which activation function squishes values between -1 and 1? No response Device: Laptop OS: Windows 10 Browser: Chrome Version: 103.0.5060.114 No response
Just changing the word in this file should suffice, let me know if you want me to open a PR.
please go ahead.

## --text-- <del> Which activation function switches values between -1 and 1? </del> <ins> Which activation function squishes values between -1 and 1? </ins> ## --answers--


Question:
There is a typo in learn-intermediate-css-by-building-a-picasso-painting, is used instead of . Here is the typo Here is the markdown file Please make sure you read , we prioritize contributors following the instructions in our guides. Join us in or if you need help contributing, our moderators will guide you through this. Sometimes we may get more than one pull requests. We typically accept the most quality contribution, followed by the one that is made first. Happy contributing.
can i take this up
feel free to open pull request after you have read the guidelines

assert(document.querySelectorAll('.characters > div')?.length === 4); ``` <del> Your two new `div` elemnts should have the `class` set to `blue`. </del> <ins> Your two new `div` elements should have the `class` set to `blue`. </ins> ```js const divs = document.querySelectorAll('.characters > div');


Question:
In both the sentences on this line the word should be surrounded with backticks: In this line there is a period (full-stop) where there should be a comma. This looks like something that can be fixed by "first-time" code contributors to this repository. Here are the files that you should be looking at to work on a fix: List of files: Please make sure you read our , we prioritize contributors following the instructions in our guides. Join us in our or our if you need help contributing; our moderators will guide you through this. Sometimes we may get more than one pull request. We typically accept the most quality contribution followed by the one that is made first. Happy contributing.
Hello, I want to work on this.
Heyy, is this assigned to anyone?
I will work on this.
Hey! I would like to work on this issue.
Hi I have fixed the issue and you can find the PR here
Is this issue available or has it been resolved?

assert(isValidSolution_(solve24(testCases_[1]))); ``` <del> `solve24("6789")` should return `(6*8)/(9-7)`. `(8*6)/(9-7)`, or a similar valid string </del> <ins> `solve24("6789")` should return `(6*8)/(9-7)`, `(8*6)/(9-7)`, or a similar valid string </ins> ```js assert(isValidSolution_(solve24(testCases_[2])));


Question:
In both the sentences on this line the word should be surrounded with backticks: In this line there is a period (full-stop) where there should be a comma. This looks like something that can be fixed by "first-time" code contributors to this repository. Here are the files that you should be looking at to work on a fix: List of files: Please make sure you read our , we prioritize contributors following the instructions in our guides. Join us in our or our if you need help contributing; our moderators will guide you through this. Sometimes we may get more than one pull request. We typically accept the most quality contribution followed by the one that is made first. Happy contributing.
Hello, I want to work on this.
Heyy, is this assigned to anyone?
I will work on this.
Hey! I would like to work on this issue.
Hi I have fixed the issue and you can find the PR here
Is this issue available or has it been resolved?

assert($('p > a').length); ``` <del> The link's href value should be `https://freecatphotoapp.com`. You have either omitted the href value or have a typo. </del> <ins> The link's `href` value should be `https://freecatphotoapp.com`. You have either omitted the `href` value or have a typo. </ins> ```js const nestedAnchor = $('p > a')[0];


Question: The word json should be capitalized in the hint text: The endpoint /json should serve the json object {"message": "Hello json"} Referenced challenge file: curriculum/challenges/english/05-back-end-development-and-apis/basic-node-and-express/serve-json-on-a-specific- Use capitals instead of lowercase letters when referring to JSON No response Not applicable No response

# --hints-- <del> The endpoint `/json` should serve the json object `{"message": "Hello json"}` </del> <ins> The endpoint `/json` should serve the JSON object `{"message": "Hello json"}` </ins> ```js (getUserInput) =>


Question:
In RTL, these texts will be broken, because they are a mix of special character, numbers, which follow different direction in RTL than LTR. ~1.2.13 1.2.x 1.x.x To fix these, add code elements around the version number. File: change to there are multiple instances in these files All of them should be wrapped in code elements Speaking of weird interactions. Using special characters that relay on direction will break in RTL, because it will be reverted, in example. will be we can wrap in
I want to contribute towards this issue. Can you assign this issue to me.
The first comprehensive PR created will be reviewed and merged. We typically do not assign issues to anyone other than long-time contributors. If you would like to contribute, and have not read the contributors docs, please do so here: If you have any issues with contributing, be sure to join us on the , or on the

# --instructions-- <del> Add version "1.1.0" of the `@freecodecamp/example` package to the `dependencies` field of your `package.json` file. </del> <ins> Add version `1.1.0` of the `@freecodecamp/example` package to the `dependencies` field of your `package.json` file. </ins> **Note:** `@freecodecamp/example` is a faux package used as a learning tool.


Question:
In RTL, these texts will be broken, because they are a mix of special character, numbers, which follow different direction in RTL than LTR. ~1.2.13 1.2.x 1.x.x To fix these, add code elements around the version number. File: change to there are multiple instances in these files All of them should be wrapped in code elements Speaking of weird interactions. Using special characters that relay on direction will break in RTL, because it will be reverted, in example. will be we can wrap in
I want to contribute towards this issue. Can you assign this issue to me.
The first comprehensive PR created will be reviewed and merged. We typically do not assign issues to anyone other than long-time contributors. If you would like to contribute, and have not read the contributors docs, please do so here: If you have any issues with contributing, be sure to join us on the , or on the

When you are done, make sure a working demo of your project is hosted somewhere public. Then submit the URL to it in the Solution Link field. <del> The `package.json` file is the center of any Node.js project or npm package. It stores information about your project, similar to how the <head> section of an HTML document describes the content of a webpage. It consists of a single JSON object where information is stored in key-value pairs. There are only two required fields; "name" and "version", but it’s good practice to provide additional information about your project that could be useful to future users or maintainers. </del> <ins> The `package.json` file is the center of any Node.js project or npm package. It stores information about your project, similar to how the `head` section of an HTML document describes the content of a webpage. It consists of a single JSON object where information is stored in key-value pairs. There are only two required fields; `name` and `version`, but it’s good practice to provide additional information about your project that could be useful to future users or maintainers. </ins> <del> If you look at the file tree of your project, you will find the package.json file on the top level of the tree. This is the file that you will be improving in the next couple of challenges. </del> <ins> If you look at the file tree of your project, you will find the `package.json` file on the top level of the tree. This is the file that you will be improving in the next couple of challenges. </ins> One of the most common pieces of information in this file is the `author` field. It specifies who created the project, and can consist of a string or an object with contact or other details. An object is recommended for bigger projects, but a simple string like the following example will do for this project.


Question:
In RTL, these texts will be broken, because they are a mix of special character, numbers, which follow different direction in RTL than LTR. ~1.2.13 1.2.x 1.x.x To fix these, add code elements around the version number. File: change to there are multiple instances in these files All of them should be wrapped in code elements Speaking of weird interactions. Using special characters that relay on direction will break in RTL, because it will be reverted, in example. will be we can wrap in
I want to contribute towards this issue. Can you assign this issue to me.
The first comprehensive PR created will be reviewed and merged. We typically do not assign issues to anyone other than long-time contributors. If you would like to contribute, and have not read the contributors docs, please do so here: If you have any issues with contributing, be sure to join us on the , or on the

# --instructions-- <del> Add your name as the `author` of the project in the package.json file. </del> <ins> Add your name as the `author` of the project in the `package.json` file. </ins> **Note:** Remember that you’re writing JSON, so all field names must use double-quotes (") and be separated with a comma (,). # --hints-- <del> package.json should have a valid "author" key </del> <ins> `package.json` should have a valid "author" key </ins> ```js (getUserInput) =>


Question:
In RTL, these texts will be broken, because they are a mix of special character, numbers, which follow different direction in RTL than LTR. ~1.2.13 1.2.x 1.x.x To fix these, add code elements around the version number. File: change to there are multiple instances in these files All of them should be wrapped in code elements Speaking of weird interactions. Using special characters that relay on direction will break in RTL, because it will be reverted, in example. will be we can wrap in
I want to contribute towards this issue. Can you assign this issue to me.
The first comprehensive PR created will be reviewed and merged. We typically do not assign issues to anyone other than long-time contributors. If you would like to contribute, and have not read the contributors docs, please do so here: If you have any issues with contributing, be sure to join us on the , or on the

Similar to how the tilde we learned about in the last challenge allows npm to install the latest PATCH for a dependency, the caret (`^`) allows npm to install future updates as well. The difference is that the caret will allow both MINOR updates and PATCHes. <del> Your current version of `@freecodecamp/example` should be "~1.2.13" which allows npm to install to the latest 1.2.x version. If you were to use the caret (^) as a version prefix instead, npm would be allowed to update to any 1.x.x version. </del> <ins> Your current version of `@freecodecamp/example` should be `~1.2.13` which allows npm to install to the latest `1.2.x` version. If you were to use the caret (^) as a version prefix instead, npm would be allowed to update to any `1.x.x` version. </ins> ```json "package": "^1.3.8" ``` <del> This would allow updates to any 1.x.x version of the package. </del> <ins> This would allow updates to any `1.x.x` version of the package. </ins> # --instructions--


Question:
In RTL, these texts will be broken, because they are a mix of special character, numbers, which follow different direction in RTL than LTR. ~1.2.13 1.2.x 1.x.x To fix these, add code elements around the version number. File: change to there are multiple instances in these files All of them should be wrapped in code elements Speaking of weird interactions. Using special characters that relay on direction will break in RTL, because it will be reverted, in example. will be we can wrap in
I want to contribute towards this issue. Can you assign this issue to me.
The first comprehensive PR created will be reviewed and merged. We typically do not assign issues to anyone other than long-time contributors. If you would like to contribute, and have not read the contributors docs, please do so here: If you have any issues with contributing, be sure to join us on the , or on the

In the last challenge, you told npm to only include a specific version of a package. That’s a useful way to freeze your dependencies if you need to make sure that different parts of your project stay compatible with each other. But in most use cases, you don’t want to miss bug fixes since they often include important security patches and (hopefully) don’t break things in doing so. <del> To allow an npm dependency to update to the latest PATCH version, you can prefix the dependency’s version with the tilde (`~`) character. Here's an example of how to allow updates to any 1.3.x version. </del> <ins> To allow an npm dependency to update to the latest PATCH version, you can prefix the dependency’s version with the tilde (`~`) character. Here's an example of how to allow updates to any `1.3.x` version. </ins> ```json "package": "~1.3.8"


Question:
In RTL, these texts will be broken, because they are a mix of special character, numbers, which follow different direction in RTL than LTR. ~1.2.13 1.2.x 1.x.x To fix these, add code elements around the version number. File: change to there are multiple instances in these files All of them should be wrapped in code elements Speaking of weird interactions. Using special characters that relay on direction will break in RTL, because it will be reverted, in example. will be we can wrap in
I want to contribute towards this issue. Can you assign this issue to me.
The first comprehensive PR created will be reviewed and merged. We typically do not assign issues to anyone other than long-time contributors. If you would like to contribute, and have not read the contributors docs, please do so here: If you have any issues with contributing, be sure to join us on the , or on the

# --instructions-- <del> In the package.json file, your current rule for how npm may upgrade `@freecodecamp/example` is to use a specific version (1.2.13). But now, you want to allow the latest 1.2.x version. </del> <ins> In the package.json file, your current rule for how npm may upgrade `@freecodecamp/example` is to use a specific version (`1.2.13`). But now, you want to allow the latest `1.2.x` version. </ins> Use the tilde (`~`) character to prefix the version of `@freecodecamp/example` in your dependencies, and allow npm to update it to any new _patch_ release.


Question: 'just' is a bad word. If it doesn't already, our style guide should dissuade it. It implies the task is 'simple' which can frustrate learners who don't get it right. N/A Text should use friendly language. Possible fix: Note: the selector technically doesn't have the properties; the selector is part of a CSS rule that sets the desired properties. No response All No response_

Something does not look right. You added the correct `class` attribute value to the `p` element with `Donut` as its text, but you have not defined a selector for it. <del> Since the `flavor` class selector already has the properties you want, just add the `dessert` class name to it. </del> <ins> The CSS rule for the `flavor` class already sets the properties you want. Add the `dessert` class as an additional selector for this CSS rule. </ins> # --hints--


Question:
We have instances which is used to provide spacing for both side of the component to wrap it up in specific space Example: We can make the Spacer component smarter, and allow it to accept children, so the code be like. But in doing so, we need to: change the current values and how the padding is calculated, the old layout shouldn't change with the new spacers. change which padding has the new value, I think paddingBlock, which is paddingTop and paddingBottom, is the new padding property . I am requesting this because this will make live simpler, and we have to worry about less elements while controling the layout, and if we have specific cases, we can still use
There is an abstraction with , we need address, it's better if we can specify the direction of the padding. but this can be sorted in another issue, for now to solve this issue please allow to have children prop inside of it, but the current styles of the curriculum shouldn't change. If you would like to fix this issue, please make sure you read , we prioritize contributors following the instructions in our guides. Join us in or if you need help contributing, our prolific contributors will guide you through this.
Hey I have few questions while looking into this issue are few files where we have used Spacer, so may I just change wrap the content where ever needed or it would be handled in new issue? (I guess it must be done in other issue, as it would be easy to maintain) have implemented the children props, so may I raise a PR? Will break this issue in 2 other issues as well. 1 for wrapping the places it has been used, and 2nd for specifying the direction. I was wrapping and trying it out, I found out that Spacer has been used at every 2nd-3rd line of code, so do we need such a wrapper which would give spacing to all components present inside it or only to the parent component? EG: If we have 2 divs wrapped inside Spacer, then does both div have the spacing around them or only the outmost div.
sorry for the delay, it was difficult to understand what you mean without looking at an example of code, so to answer you: yes the direction will be in a second issue, but the spacing and values should still be in this issue, so the pages won't look different Of course, please raise a PR after reading the guideline, nicely done . The Spacer shouldn't affect the children inside of it, think of it as creating a container with margin-block to space the area of the children inside of it from other areas
I guess we could close this issue
will be closed when the height is removed in the other PR

} const Spacer = ({ size, children }: SpacerProps): JSX.Element => (  <div className='spacer' style={{ padding: `${Padding[size]}px 0`, height: '1px' }} >   <div className='spacer' style={{ padding: `${Padding[size]}px 0` }}>  {children}
 );


Question:
We have instances which is used to provide spacing for both side of the component to wrap it up in specific space Example: We can make the Spacer component smarter, and allow it to accept children, so the code be like. But in doing so, we need to: change the current values and how the padding is calculated, the old layout shouldn't change with the new spacers. change which padding has the new value, I think paddingBlock, which is paddingTop and paddingBottom, is the new padding property . I am requesting this because this will make live simpler, and we have to worry about less elements while controling the layout, and if we have specific cases, we can still use
There is an abstraction with , we need address, it's better if we can specify the direction of the padding. but this can be sorted in another issue, for now to solve this issue please allow to have children prop inside of it, but the current styles of the curriculum shouldn't change. If you would like to fix this issue, please make sure you read , we prioritize contributors following the instructions in our guides. Join us in or if you need help contributing, our prolific contributors will guide you through this.
Hey I have few questions while looking into this issue are few files where we have used Spacer, so may I just change wrap the content where ever needed or it would be handled in new issue? (I guess it must be done in other issue, as it would be easy to maintain) have implemented the children props, so may I raise a PR? Will break this issue in 2 other issues as well. 1 for wrapping the places it has been used, and 2nd for specifying the direction. I was wrapping and trying it out, I found out that Spacer has been used at every 2nd-3rd line of code, so do we need such a wrapper which would give spacing to all components present inside it or only to the parent component? EG: If we have 2 divs wrapped inside Spacer, then does both div have the spacing around them or only the outmost div.
sorry for the delay, it was difficult to understand what you mean without looking at an example of code, so to answer you: yes the direction will be in a second issue, but the spacing and values should still be in this issue, so the pages won't look different Of course, please raise a PR after reading the guideline, nicely done . The Spacer shouldn't affect the children inside of it, think of it as creating a container with margin-block to space the area of the children inside of it from other areas
I guess we could close this issue
will be closed when the height is removed in the other PR

 <div class="spacer"  style="padding: 15px 0px; height: 1px;"   style="padding: 15px 0px;"  />
 <div class="spacer"  style="padding: 15px 0px; height: 1px;"   style="padding: 15px 0px;"  />
 <div


Question:
We have instances which is used to provide spacing for both side of the component to wrap it up in specific space Example: We can make the Spacer component smarter, and allow it to accept children, so the code be like. But in doing so, we need to: change the current values and how the padding is calculated, the old layout shouldn't change with the new spacers. change which padding has the new value, I think paddingBlock, which is paddingTop and paddingBottom, is the new padding property . I am requesting this because this will make live simpler, and we have to worry about less elements while controling the layout, and if we have specific cases, we can still use
There is an abstraction with , we need address, it's better if we can specify the direction of the padding. but this can be sorted in another issue, for now to solve this issue please allow to have children prop inside of it, but the current styles of the curriculum shouldn't change. If you would like to fix this issue, please make sure you read , we prioritize contributors following the instructions in our guides. Join us in or if you need help contributing, our prolific contributors will guide you through this.
Hey I have few questions while looking into this issue are few files where we have used Spacer, so may I just change wrap the content where ever needed or it would be handled in new issue? (I guess it must be done in other issue, as it would be easy to maintain) have implemented the children props, so may I raise a PR? Will break this issue in 2 other issues as well. 1 for wrapping the places it has been used, and 2nd for specifying the direction. I was wrapping and trying it out, I found out that Spacer has been used at every 2nd-3rd line of code, so do we need such a wrapper which would give spacing to all components present inside it or only to the parent component? EG: If we have 2 divs wrapped inside Spacer, then does both div have the spacing around them or only the outmost div.
sorry for the delay, it was difficult to understand what you mean without looking at an example of code, so to answer you: yes the direction will be in a second issue, but the spacing and values should still be in this issue, so the pages won't look different Of course, please raise a PR after reading the guideline, nicely done . The Spacer shouldn't affect the children inside of it, think of it as creating a container with margin-block to space the area of the children inside of it from other areas
I guess we could close this issue
will be closed when the height is removed in the other PR

<div class="spacer"  style="padding: 15px 0px; height: 1px;"   style="padding: 15px 0px;"  /> <div class="text-center row"


Question:
We have instances which is used to provide spacing for both side of the component to wrap it up in specific space Example: We can make the Spacer component smarter, and allow it to accept children, so the code be like. But in doing so, we need to: change the current values and how the padding is calculated, the old layout shouldn't change with the new spacers. change which padding has the new value, I think paddingBlock, which is paddingTop and paddingBottom, is the new padding property . I am requesting this because this will make live simpler, and we have to worry about less elements while controling the layout, and if we have specific cases, we can still use
There is an abstraction with , we need address, it's better if we can specify the direction of the padding. but this can be sorted in another issue, for now to solve this issue please allow to have children prop inside of it, but the current styles of the curriculum shouldn't change. If you would like to fix this issue, please make sure you read , we prioritize contributors following the instructions in our guides. Join us in or if you need help contributing, our prolific contributors will guide you through this.
Hey I have few questions while looking into this issue are few files where we have used Spacer, so may I just change wrap the content where ever needed or it would be handled in new issue? (I guess it must be done in other issue, as it would be easy to maintain) have implemented the children props, so may I raise a PR? Will break this issue in 2 other issues as well. 1 for wrapping the places it has been used, and 2nd for specifying the direction. I was wrapping and trying it out, I found out that Spacer has been used at every 2nd-3rd line of code, so do we need such a wrapper which would give spacing to all components present inside it or only to the parent component? EG: If we have 2 divs wrapped inside Spacer, then does both div have the spacing around them or only the outmost div.
sorry for the delay, it was difficult to understand what you mean without looking at an example of code, so to answer you: yes the direction will be in a second issue, but the spacing and values should still be in this issue, so the pages won't look different Of course, please raise a PR after reading the guideline, nicely done . The Spacer shouldn't affect the children inside of it, think of it as creating a container with margin-block to space the area of the children inside of it from other areas
I guess we could close this issue
will be closed when the height is removed in the other PR

</div> <div class="spacer" <del> style="padding: 15px 0px; height: 1px;" </del> <ins> style="padding: 15px 0px;" </ins> /> </div> </div>


Question:
We have instances which is used to provide spacing for both side of the component to wrap it up in specific space Example: We can make the Spacer component smarter, and allow it to accept children, so the code be like. But in doing so, we need to: change the current values and how the padding is calculated, the old layout shouldn't change with the new spacers. change which padding has the new value, I think paddingBlock, which is paddingTop and paddingBottom, is the new padding property . I am requesting this because this will make live simpler, and we have to worry about less elements while controling the layout, and if we have specific cases, we can still use
There is an abstraction with , we need address, it's better if we can specify the direction of the padding. but this can be sorted in another issue, for now to solve this issue please allow to have children prop inside of it, but the current styles of the curriculum shouldn't change. If you would like to fix this issue, please make sure you read , we prioritize contributors following the instructions in our guides. Join us in or if you need help contributing, our prolific contributors will guide you through this.
Hey I have few questions while looking into this issue are few files where we have used Spacer, so may I just change wrap the content where ever needed or it would be handled in new issue? (I guess it must be done in other issue, as it would be easy to maintain) have implemented the children props, so may I raise a PR? Will break this issue in 2 other issues as well. 1 for wrapping the places it has been used, and 2nd for specifying the direction. I was wrapping and trying it out, I found out that Spacer has been used at every 2nd-3rd line of code, so do we need such a wrapper which would give spacing to all components present inside it or only to the parent component? EG: If we have 2 divs wrapped inside Spacer, then does both div have the spacing around them or only the outmost div.
sorry for the delay, it was difficult to understand what you mean without looking at an example of code, so to answer you: yes the direction will be in a second issue, but the spacing and values should still be in this issue, so the pages won't look different Of course, please raise a PR after reading the guideline, nicely done . The Spacer shouldn't affect the children inside of it, think of it as creating a container with margin-block to space the area of the children inside of it from other areas
I guess we could close this issue
will be closed when the height is removed in the other PR

className="spacer" style={ { <del> "height": "1px", </del> "padding": "5px 0", } }