Question:
Type: <bBug</bCC a new terminal and hit enter in a new line and hit enter (you must create at least two lines of code to test b/c the single line does not have this issue) UpArrow LeftArrow multiple times to test if you can hear "echo world" character by character. Notes: For NVDA and JAWS on Windows, it keeps saying "d" which is the last character. VS Code version: Code - Insiders 1.83.0-insider (, 2023-09-19T08:56:35.775Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (91)</summaryExtensionVersion ------ android-dev-ext1.3.2 aiprm-lang0.0.2 Bookmarks13.4.1 openscad1.2.1 spellright3.0.118 zoterolatex0.4.1 mermaid-markdown-syntax-highlighting1.5.2 doxdocgen1.4.0 vscode-markdownlint0.51.0 vscode-eslint2.4.2 vscode-quick-select0.2.9 vscode-deno3.22.0 gitlens14.3.0 EditorConfig0.16.4 prettier-vscode10.1.0 vscode-google-translate1.4.13 codespaces1.15.3 copilot1.112.422 copilot-chat0.8. remotehub0.60.0 vscode-github-actions0.26.2 vscode-pull-request-github0.72.0 overleaf-workshop0.1.5 cslpreview0.2.2 easy-snippet0.6.3 path-autocomplete1.25.0 latex-workshop9.14.0 lilypond-syntax0.1.1 scheme0.2.0 better-cpp-syntax1.17.2 google-search0.0.1 vscode-lua-format1.3.8 lilypond-formatter0.2.3 lilypond-pdf-preview0.2.8 lilypond-snippets0.1.1 vslilypond1.7.3 zotero0.1.10 git-graph1.30.0 vscode-docker1.26.0 black-formatter2023.4.1 flake82023.6.0 isort2023.11. python2023.16.0 vscode-pylance2023.9.10 jupyter2023.8. jupyter-keymap1.1.2 jupyter-renderers1.0.17 vscode-jupyter-cell-tags0.1.8 vscode-jupyter-slideshow0.1.5 remote-containers0.311.0 remote-ssh0.106.4 remote-ssh-edit0.86.0 remote-wsl0.81.3 vscode-remote-extensionpack0.24.0 azure-repos0.36.0 cmake-tools1.15.31 cpptools1.17.5 cpptools-extension-pack1.3.0 js-debug-nightly2023.9.1317 powershell2023.6.0 remote-repositories0.38.1 vscode-github-issue-notebooks0.0.129 vscode-selfhost-test-provider0.3.18 vscode-serial-monitor0.10.0 vsliveshare1.0.5883 autodocstring0.6.1 pandocciter0.10.3 shiny-python0.1.4 shinyuieditor0.4.3 quarto1.98.0 r-debugger0.5.4 java1.22.1 vscode-xml0.26.1 r2.8.1 multi-command1.6.0 vscode-deepl1.0.6 abc-music0.4.0 lua3.7.0 latex-utilities0.4.10 cmake0.0.17 errorlens3.13.0 intellicode-api-usage-examples0.2.8 vscodeintellicode1.2.30 vscode-arduino0.6.0 vscode-java-debug0.54.0 vscode-java-dependency0.23.1 vscode-java-pack0.25.14 vscode-java-test0.39.1 vscode-maven0.42.0 markdown-all-in-one3.5.1 grammarly0.22.1 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Yeah, this is acting very buggy on windows
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
repro steps as listed should work. Lmk if you have questions
Navigating left and right is fine, but after typing a command, NVDA reads out a misspelled version of the command multiple times !
reopening because marked verification-found per the process.
It's a lot better today. Closing and marking as verified. Edit: nvm, but will file a new issue for the bug.
can still repro. He's going to send me the output logs. The command decorations are off here. !
the command start line is off here, which is causing this issue. Do you know why / how that happens?
Does not reproduce for me on Windows.
this can happen sometimes on Windows. What I'd recommend is add some logic when a command starts that does a quick scan of nearby lines to re-adjust for the common PS/cmd prompt case if the current line does not look like a prompt. This is a workaround until shell integration sequences are passed through correctly by conpty.
feature as we'll want to call this out in the terminal section of the release notes

this._logService.debug('CommandDetectionCapability#handleCommandStart', this._currentCommand.commandStartX, this._currentCommand.commandStartMarker?.line); } <del> private _handleCommandStartWindows(): void { </del> <ins> private async _handleCommandStartWindows(): Promise<void> { </ins> this._currentCommand.commandStartX = this._terminal.buffer.active.cursorX; // On Windows track all cursor movements after the command start sequence this._commandMarkers.length = 0; <del> // HACK: Fire command started on the following frame on Windows to allow the cursor // position to update as conpty often prints the sequence on a different line to the // actual line the command started on. timeout(0).then(() => { if (!this._currentCommand.commandExecutedMarker) { this._onCursorMoveListener = this._terminal.onCursorMove(() => { if (this._commandMarkers.length === 0 || this._commandMarkers[this._commandMarkers.length - 1].line !== this._terminal.buffer.active.cursorY) { const marker = this._terminal.registerMarker(0); if (marker) { this._commandMarkers.push(marker); } } }); </del> <ins> const lastCommand = this.commands.at(-1); function cursorOnCorrectLine(terminal: Terminal): boolean { if (!lastCommand) { return false; </ins> } <del> this._currentCommand.commandStartMarker = this._terminal.registerMarker(0); if (this._currentCommand.commandStartMarker) { const line = this._terminal.buffer.active.getLine(this._currentCommand.commandStartMarker.line); if (line) { this._currentCommand.commandStartLineContent = line.translateToString(true); </del> <ins> const cursorYAbsolute = terminal.buffer.active.baseY + terminal.buffer.active.cursorY; // If the cursor position is within the last command, we should poll. const lastCommandYAbsolute = (lastCommand.endMarker ? lastCommand.endMarker.line : lastCommand.marker?.line) ?? -1; return cursorYAbsolute > lastCommandYAbsolute; } function lineIsPrompt(terminal: Terminal): boolean { const line = terminal.buffer.active.getLine(terminal.buffer.active.baseY + terminal.buffer.active.cursorY); if (!line) { return false; } // TODO: fine tune prompt regex to accomodate for unique configurtions. return line.translateToString(true)?.match(/^(PS.+>)|([A-Z]:.*>)/) !== null; } // Conpty could have the wrong cursor position at this point. if (!cursorOnCorrectLine(this._terminal) || !lineIsPrompt(this._terminal)) { // Poll for 200ms until the cursor position is correct. for (let i = 0; i < 20; i++) { await timeout(10); if (cursorOnCorrectLine(this._terminal) && lineIsPrompt(this._terminal)) { this._logService.debug('CommandDetectionCapability#_handleCommandStartWindows polling attempts required: ', i + 1); break; </ins> } } <del> this._onCommandStarted.fire({ marker: this._currentCommand.commandStartMarker } as ITerminalCommand); this._logService.debug('CommandDetectionCapability#_handleCommandStartWindows', this._currentCommand.commandStartX, this._currentCommand.commandStartMarker?.line); }); </del> <ins> } else { // HACK: Fire command started on the following frame on Windows to allow the cursor // position to update as conpty often prints the sequence on a different line to the // actual line the command started on. await timeout(0); } if (!this._currentCommand.commandExecutedMarker) { this._onCursorMoveListener = this._terminal.onCursorMove(() => { if (this._commandMarkers.length === 0 || this._commandMarkers[this._commandMarkers.length - 1].line !== this._terminal.buffer.active.cursorY) { const marker = this._terminal.registerMarker(0); if (marker) { this._commandMarkers.push(marker); } } }); } this._currentCommand.commandStartMarker = this._terminal.registerMarker(0); if (this._currentCommand.commandStartMarker) { const line = this._terminal.buffer.active.getLine(this._currentCommand.commandStartMarker.line); if (line) { this._currentCommand.commandStartLineContent = line.translateToString(true); } } this._onCommandStarted.fire({ marker: this._currentCommand.commandStartMarker } as ITerminalCommand); this._logService.debug('CommandDetectionCapability#_handleCommandStartWindows', this._currentCommand.commandStartX, this._currentCommand.commandStartMarker?.line); </ins> } handleGenericCommand(options?: IHandleCommandOptions): void {


Question:
Type: <bBug</bCC a new terminal and hit enter in a new line and hit enter (you must create at least two lines of code to test b/c the single line does not have this issue) UpArrow LeftArrow multiple times to test if you can hear "echo world" character by character. Notes: For NVDA and JAWS on Windows, it keeps saying "d" which is the last character. VS Code version: Code - Insiders 1.83.0-insider (, 2023-09-19T08:56:35.775Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (91)</summaryExtensionVersion ------ android-dev-ext1.3.2 aiprm-lang0.0.2 Bookmarks13.4.1 openscad1.2.1 spellright3.0.118 zoterolatex0.4.1 mermaid-markdown-syntax-highlighting1.5.2 doxdocgen1.4.0 vscode-markdownlint0.51.0 vscode-eslint2.4.2 vscode-quick-select0.2.9 vscode-deno3.22.0 gitlens14.3.0 EditorConfig0.16.4 prettier-vscode10.1.0 vscode-google-translate1.4.13 codespaces1.15.3 copilot1.112.422 copilot-chat0.8. remotehub0.60.0 vscode-github-actions0.26.2 vscode-pull-request-github0.72.0 overleaf-workshop0.1.5 cslpreview0.2.2 easy-snippet0.6.3 path-autocomplete1.25.0 latex-workshop9.14.0 lilypond-syntax0.1.1 scheme0.2.0 better-cpp-syntax1.17.2 google-search0.0.1 vscode-lua-format1.3.8 lilypond-formatter0.2.3 lilypond-pdf-preview0.2.8 lilypond-snippets0.1.1 vslilypond1.7.3 zotero0.1.10 git-graph1.30.0 vscode-docker1.26.0 black-formatter2023.4.1 flake82023.6.0 isort2023.11. python2023.16.0 vscode-pylance2023.9.10 jupyter2023.8. jupyter-keymap1.1.2 jupyter-renderers1.0.17 vscode-jupyter-cell-tags0.1.8 vscode-jupyter-slideshow0.1.5 remote-containers0.311.0 remote-ssh0.106.4 remote-ssh-edit0.86.0 remote-wsl0.81.3 vscode-remote-extensionpack0.24.0 azure-repos0.36.0 cmake-tools1.15.31 cpptools1.17.5 cpptools-extension-pack1.3.0 js-debug-nightly2023.9.1317 powershell2023.6.0 remote-repositories0.38.1 vscode-github-issue-notebooks0.0.129 vscode-selfhost-test-provider0.3.18 vscode-serial-monitor0.10.0 vsliveshare1.0.5883 autodocstring0.6.1 pandocciter0.10.3 shiny-python0.1.4 shinyuieditor0.4.3 quarto1.98.0 r-debugger0.5.4 java1.22.1 vscode-xml0.26.1 r2.8.1 multi-command1.6.0 vscode-deepl1.0.6 abc-music0.4.0 lua3.7.0 latex-utilities0.4.10 cmake0.0.17 errorlens3.13.0 intellicode-api-usage-examples0.2.8 vscodeintellicode1.2.30 vscode-arduino0.6.0 vscode-java-debug0.54.0 vscode-java-dependency0.23.1 vscode-java-pack0.25.14 vscode-java-test0.39.1 vscode-maven0.42.0 markdown-all-in-one3.5.1 grammarly0.22.1 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Yeah, this is acting very buggy on windows
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
repro steps as listed should work. Lmk if you have questions
Navigating left and right is fine, but after typing a command, NVDA reads out a misspelled version of the command multiple times !
reopening because marked verification-found per the process.
It's a lot better today. Closing and marking as verified. Edit: nvm, but will file a new issue for the bug.
can still repro. He's going to send me the output logs. The command decorations are off here. !
the command start line is off here, which is causing this issue. Do you know why / how that happens?
Does not reproduce for me on Windows.
this can happen sometimes on Windows. What I'd recommend is add some logic when a command starts that does a quick scan of nearby lines to re-adjust for the common PS/cmd prompt case if the current line does not look like a prompt. This is a workaround until shell integration sequences are passed through correctly by conpty.
feature as we'll want to call this out in the terminal section of the release notes

handleCommandExecuted(options?: IHandleCommandOptions): void { if (this._isWindowsPty) { <del> this._handleCommandExecutedWindows(); </del> <ins> this._commandStartWindowsPromise?.then(() => this._handleCommandExecutedWindows()); </ins> return; }


Question:
Type: <bBug</bCC a new terminal and hit enter in a new line and hit enter (you must create at least two lines of code to test b/c the single line does not have this issue) UpArrow LeftArrow multiple times to test if you can hear "echo world" character by character. Notes: For NVDA and JAWS on Windows, it keeps saying "d" which is the last character. VS Code version: Code - Insiders 1.83.0-insider (, 2023-09-19T08:56:35.775Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (91)</summaryExtensionVersion ------ android-dev-ext1.3.2 aiprm-lang0.0.2 Bookmarks13.4.1 openscad1.2.1 spellright3.0.118 zoterolatex0.4.1 mermaid-markdown-syntax-highlighting1.5.2 doxdocgen1.4.0 vscode-markdownlint0.51.0 vscode-eslint2.4.2 vscode-quick-select0.2.9 vscode-deno3.22.0 gitlens14.3.0 EditorConfig0.16.4 prettier-vscode10.1.0 vscode-google-translate1.4.13 codespaces1.15.3 copilot1.112.422 copilot-chat0.8. remotehub0.60.0 vscode-github-actions0.26.2 vscode-pull-request-github0.72.0 overleaf-workshop0.1.5 cslpreview0.2.2 easy-snippet0.6.3 path-autocomplete1.25.0 latex-workshop9.14.0 lilypond-syntax0.1.1 scheme0.2.0 better-cpp-syntax1.17.2 google-search0.0.1 vscode-lua-format1.3.8 lilypond-formatter0.2.3 lilypond-pdf-preview0.2.8 lilypond-snippets0.1.1 vslilypond1.7.3 zotero0.1.10 git-graph1.30.0 vscode-docker1.26.0 black-formatter2023.4.1 flake82023.6.0 isort2023.11. python2023.16.0 vscode-pylance2023.9.10 jupyter2023.8. jupyter-keymap1.1.2 jupyter-renderers1.0.17 vscode-jupyter-cell-tags0.1.8 vscode-jupyter-slideshow0.1.5 remote-containers0.311.0 remote-ssh0.106.4 remote-ssh-edit0.86.0 remote-wsl0.81.3 vscode-remote-extensionpack0.24.0 azure-repos0.36.0 cmake-tools1.15.31 cpptools1.17.5 cpptools-extension-pack1.3.0 js-debug-nightly2023.9.1317 powershell2023.6.0 remote-repositories0.38.1 vscode-github-issue-notebooks0.0.129 vscode-selfhost-test-provider0.3.18 vscode-serial-monitor0.10.0 vsliveshare1.0.5883 autodocstring0.6.1 pandocciter0.10.3 shiny-python0.1.4 shinyuieditor0.4.3 quarto1.98.0 r-debugger0.5.4 java1.22.1 vscode-xml0.26.1 r2.8.1 multi-command1.6.0 vscode-deepl1.0.6 abc-music0.4.0 lua3.7.0 latex-utilities0.4.10 cmake0.0.17 errorlens3.13.0 intellicode-api-usage-examples0.2.8 vscodeintellicode1.2.30 vscode-arduino0.6.0 vscode-java-debug0.54.0 vscode-java-dependency0.23.1 vscode-java-pack0.25.14 vscode-java-test0.39.1 vscode-maven0.42.0 markdown-all-in-one3.5.1 grammarly0.22.1 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
Yeah, this is acting very buggy on windows
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
repro steps as listed should work. Lmk if you have questions
Navigating left and right is fine, but after typing a command, NVDA reads out a misspelled version of the command multiple times !
reopening because marked verification-found per the process.
It's a lot better today. Closing and marking as verified. Edit: nvm, but will file a new issue for the bug.
can still repro. He's going to send me the output logs. The command decorations are off here. !
the command start line is off here, which is causing this issue. Do you know why / how that happens?
Does not reproduce for me on Windows.
this can happen sometimes on Windows. What I'd recommend is add some logic when a command starts that does a quick scan of nearby lines to re-adjust for the common PS/cmd prompt case if the current line does not look like a prompt. This is a workaround until shell integration sequences are passed through correctly by conpty.
feature as we'll want to call this out in the terminal section of the release notes

handleCommandFinished(exitCode: number | undefined, options?: IHandleCommandOptions): void { if (this._isWindowsPty) { <del> this._preHandleCommandFinishedWindows(); </del> <ins> this._commandStartWindowsPromise?.then(() => this._preHandleCommandFinishedWindows()); </ins> } this._currentCommand.commandFinishedMarker = options?.marker || this._terminal.registerMarker(0);


Question:
I'm on a mac. setting it to be works though
it started to work the moment I had at least one comment in the editor
did the original keybinding work after you comment? Even before adding a comment I'm seeing the command work.
that keybinding still doesn't work for me (maybe my keyboard or something)...? when I use a different keybinding, it does try to run the command, but I'm now seeing this error. !
I have confirmed that the default keyboard shortcut works on mac: . There's probably something up with your keybindings that's causing this. You could try the "Developer: Toggle Keyboard Shortcuts Troubleshooting" command and see what it outputs. I'm fixing this error though:

return range; } <del> return decorations[0].getActiveRange() ?? undefined; </del> <ins> return (decorations.length > 0 ? (decorations[0].getActiveRange() ?? undefined) : undefined); </ins> } public dispose(): void {


Question: Testing Followed the steps to turn on the debug toolbar with commandCenter options. However, when the debugging started, clicking the area around the directory name did not trigger 'search files'. (the blank space at the right side of 'vscode-python' in terms of the attached screenshot. I was able to trigger 'search files' only when pressing specifically on the directory name, in this case, 'vscode-python. ++ Nice feature by the way! <img width="983" alt="Screenshot 2023-09-26 at 10 42 11 AM" src=""<img width="512" alt="Screenshot 2023-09-26 at 11 02 46 AM" src=""

@IKeybindingService private _keybindingService: IKeybindingService, @IInstantiationService private _instaService: IInstantiationService, ) { <del> super(undefined, _submenu.actions[0], options); </del> <ins> super(undefined, _submenu.actions.find(action => action.id === 'workbench.action.quickOpenWithModes') ?? _submenu.actions[0], options); </ins> } override render(container: HTMLElement): void {


Question: Testing Followed the steps to turn on the debug toolbar with commandCenter options. However, when the debugging started, clicking the area around the directory name did not trigger 'search files'. (the blank space at the right side of 'vscode-python' in terms of the attached screenshot. I was able to trigger 'search files' only when pressing specifically on the directory name, in this case, 'vscode-python. ++ Nice feature by the way! <img width="983" alt="Screenshot 2023-09-26 at 10 42 11 AM" src=""<img width="512" alt="Screenshot 2023-09-26 at 11 02 46 AM" src=""

}); <ins> const CONTEXT_TOOLBAR_COMMAND_CENTER = ContextKeyExpr.equals('config.debug.toolBarLocation', 'commandCenter'); </ins> MenuRegistry.appendMenuItem(MenuId.CommandCenterCenter, { submenu: MenuId.DebugToolBar, title: 'Debug', icon: Codicon.debug, order: 1, <del> when: ContextKeyExpr.and(CONTEXT_IN_DEBUG_MODE, ContextKeyExpr.equals('config.debug.toolBarLocation', 'commandCenter')) </del> <ins> when: ContextKeyExpr.and(CONTEXT_IN_DEBUG_MODE, CONTEXT_TOOLBAR_COMMAND_CENTER) </ins> }); registerDebugToolBarItem(CONTINUE_ID, CONTINUE_LABEL, 10, icons.debugContinue, CONTEXT_DEBUG_STATE.isEqualTo('stopped'));


Question: Testing Followed the steps to turn on the debug toolbar with commandCenter options. However, when the debugging started, clicking the area around the directory name did not trigger 'search files'. (the blank space at the right side of 'vscode-python' in terms of the attached screenshot. I was able to trigger 'search files' only when pressing specifically on the directory name, in this case, 'vscode-python. ++ Nice feature by the way! <img width="983" alt="Screenshot 2023-09-26 at 10 42 11 AM" src=""<img width="512" alt="Screenshot 2023-09-26 at 11 02 46 AM" src=""

registerDebugToolBarItem(RESTART_SESSION_ID, RESTART_LABEL, 60, icons.debugRestart); registerDebugToolBarItem(STEP_BACK_ID, localize('stepBackDebug', "Step Back"), 50, icons.debugStepBack, CONTEXT_STEP_BACK_SUPPORTED, CONTEXT_DEBUG_STATE.isEqualTo('stopped')); registerDebugToolBarItem(REVERSE_CONTINUE_ID, localize('reverseContinue', "Reverse"), 55, icons.debugReverseContinue, CONTEXT_STEP_BACK_SUPPORTED, CONTEXT_DEBUG_STATE.isEqualTo('stopped')); <del> registerDebugToolBarItem(FOCUS_SESSION_ID, FOCUS_SESSION_LABEL, 100, Codicon.listTree, CONTEXT_MULTI_SESSION_DEBUG); </del> <ins> registerDebugToolBarItem(FOCUS_SESSION_ID, FOCUS_SESSION_LABEL, 100, Codicon.listTree, ContextKeyExpr.and(CONTEXT_MULTI_SESSION_DEBUG, CONTEXT_TOOLBAR_COMMAND_CENTER.negate())); </ins> MenuRegistry.appendMenuItem(MenuId.DebugToolBarStop, { group: 'navigation',


Question:
Testing I was expecting quick fixes for the whole line to be included, ranked by distance to the cursor, up to a certain maximum !
Yep! That was one thing I was experimenting with, and atm it does just find the closest one. Played around with allowing all quickfixes as well, but was unsure what would feel better. Will likely work on a version where we show all potential quickfixes in the line.

Registry.as<IConfigurationRegistry>(Extensions.Configuration).registerConfiguration({ ...editorConfigurationBaseNode, properties: { <del> 'editor.codeActionWidget.includeNearbyQuickfixes': { </del> <ins> 'editor.codeActionWidget.includeNearbyQuickFixes': { </ins> type: 'boolean', scope: ConfigurationScope.LANGUAGE_OVERRIDABLE, <del> description: nls.localize('includeNearbyQuickfixes', "Enable/disable showing nearest Quick Fix within a line when not currently on a diagnostic."), </del> <ins> description: nls.localize('includeNearbyQuickFixes', "Enable/disable showing nearest Quick Fix within a line when not currently on a diagnostic."), </ins> default: true, }, }


Question:
Testing I was expecting quick fixes for the whole line to be included, ranked by distance to the cursor, up to a certain maximum !
Yep! That was one thing I was experimenting with, and atm it does just find the closest one. Played around with allowing all quickfixes as well, but was unsure what would feel better. Will likely work on a version where we show all potential quickfixes in the line.

const currPosition = trigger.selection.getPosition(); let trackedPosition = currPosition; let distance = Number.MAX_VALUE; <del> let toBeModified = false; </del> <ins> const currentActions = [...codeActionSet.validActions]; </ins> for (const marker of allMarkers) { const col = marker.endColumn;


Question:
Testing I was expecting quick fixes for the whole line to be included, ranked by distance to the cursor, up to a certain maximum !
Yep! That was one thing I was experimenting with, and atm it does just find the closest one. Played around with allowing all quickfixes as well, but was unsure what would feel better. Will likely work on a version where we show all potential quickfixes in the line.

const startRow = marker.startLineNumber; // Found quickfix on the same line and check relative distance to other markers <del> if ((row === currPosition.lineNumber || startRow === currPosition.lineNumber) && Math.abs(currPosition.column - col) < distance) { distance = Math.abs(currPosition.column - col); toBeModified = true; </del> <ins> if ((row === currPosition.lineNumber || startRow === currPosition.lineNumber)) { </ins> trackedPosition = new Position(row, col); <ins> const newCodeActionTrigger: CodeActionTrigger = { type: trigger.trigger.type, triggerAction: trigger.trigger.triggerAction, filter: { include: trigger.trigger.filter?.include ? trigger.trigger.filter?.include : CodeActionKind.QuickFix }, autoApply: trigger.trigger.autoApply, context: { notAvailableMessage: trigger.trigger.context?.notAvailableMessage || '', position: trackedPosition } }; const selectionAsPosition = new Selection(trackedPosition.lineNumber, trackedPosition.column, trackedPosition.lineNumber, trackedPosition.column); const actionsAtMarker = await getCodeActions(this._registry, model, selectionAsPosition, newCodeActionTrigger, Progress.None, token); if (actionsAtMarker.validActions.length !== 0) { for (const action of actionsAtMarker.validActions) { action.highlightRange = action.action.isPreferred; } // Already filtered through to only get quickfixes, so no need to filter again. if (Math.abs(currPosition.column - col) < distance) { currentActions.unshift(...actionsAtMarker.validActions); } else { currentActions.push(...actionsAtMarker.validActions); } } distance = Math.abs(currPosition.column - col); </ins> } } <ins> currentActions.filter((action, index, self) => self.findIndex((a) => a.action.title === action.action.title) === index); currentActions.sort((a, b) => { if (a.action.isPreferred && !b.action.isPreferred) { return -1; } else if (!a.action.isPreferred && b.action.isPreferred) { return 1; } else { return 0; } }); </ins> // Only retriggers if actually found quickfix on the same line as cursor <del> if (toBeModified) { const newCodeActionTrigger: CodeActionTrigger = { type: trigger.trigger.type, triggerAction: trigger.trigger.triggerAction, filter: { include: trigger.trigger.filter?.include ? trigger.trigger.filter?.include : CodeActionKind.QuickFix }, autoApply: trigger.trigger.autoApply, context: { notAvailableMessage: trigger.trigger.context?.notAvailableMessage || '', position: trackedPosition } }; const selectionAsPosition = new Selection(trackedPosition.lineNumber, trackedPosition.column, trackedPosition.lineNumber, trackedPosition.column); const actionsAtMarker = await getCodeActions(this._registry, model, selectionAsPosition, newCodeActionTrigger, Progress.None, token); const currentActions = [...codeActionSet.validActions]; if (actionsAtMarker.validActions.length !== 0) { actionsAtMarker.validActions.forEach(action => { action.highlightRange = action.action.isPreferred; }); // Already filtered through to only get quickfixes, so no need to filter again. currentActions.push(...actionsAtMarker.validActions); } return { validActions: currentActions, allActions: codeActionSet.allActions, documentation: codeActionSet.documentation, hasAutoFix: codeActionSet.hasAutoFix, dispose: () => { codeActionSet.dispose(); } }; } </del> <ins> return { validActions: currentActions, allActions: codeActionSet.allActions, documentation: codeActionSet.documentation, hasAutoFix: codeActionSet.hasAutoFix, dispose: () => { codeActionSet.dispose(); } }; </ins> } } } // temporarilly hiding here as this is enabled/disabled behind a setting. return getCodeActions(this._registry, model, trigger.selection, trigger.trigger, Progress.None, token); }); if (trigger.trigger.type === CodeActionTriggerType.Invoke) { this._progressService?.showWhile(actions, 250); }


Question: <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Steps to Reproduce: on a file from the "All Changes" node that the diff editor does not have the commit for the right hand side !

return { ahead: Number(ahead) || 0, behind: Number(behind) || 0 }; } <ins> async revParse(ref: string): Promise<string | undefined> { try { const result = await this.exec(['rev-parse', ref]); if (result.stderr) { return undefined; } return result.stdout.trim(); } catch (err) { return undefined; } } </ins> async updateSubmodules(paths: string[]): Promise<void> { const args = ['submodule', 'update'];


Question: <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Steps to Reproduce: on a file from the "All Changes" node that the diff editor does not have the commit for the right hand side !

} const optionsRef = options.limit.id; <ins> const historyItemGroupIdRef = await this.repository.revParse(historyItemGroupId) ?? ''; </ins> const [commits, summary] = await Promise.all([ <del> this.repository.log({ range: `${optionsRef}..${historyItemGroupId}`, sortByAuthorDate: true }), this.getSummaryHistoryItem(optionsRef, historyItemGroupId) </del> <ins> this.repository.log({ range: `${optionsRef}..${historyItemGroupIdRef}`, sortByAuthorDate: true }), this.getSummaryHistoryItem(optionsRef, historyItemGroupIdRef) </ins> ]); const historyItems = commits.length === 0 ? [] : [summary];


Question: <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Steps to Reproduce: on a file from the "All Changes" node that the diff editor does not have the commit for the right hand side !

RevertFiles = 'RevertFiles', RevertFilesNoProgress = 'RevertFilesNoProgress', RevList = 'RevList', <ins> RevParse = 'RevParse', </ins> SetBranchUpstream = 'SetBranchUpstream', Show = 'Show', Stage = 'Stage',


Question: <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Steps to Reproduce: on a file from the "All Changes" node that the diff editor does not have the commit for the right hand side !

GetBranchOperation | GetBranchesOperation | GetCommitTemplateOperation | GetObjectDetailsOperation | GetRefsOperation | GetRemoteRefsOperation | HashObjectOperation | IgnoreOperation | LogOperation | LogFileOperation | MergeOperation | MergeAbortOperation | MergeBaseOperation | MoveOperation | PostCommitCommandOperation | PullOperation | PushOperation | RemoteOperation | RenameBranchOperation | RemoveOperation | <del> ResetOperation | RebaseOperation | RebaseAbortOperation | RebaseContinueOperation | RevertFilesOperation | RevListOperation | </del> <ins> ResetOperation | RebaseOperation | RebaseAbortOperation | RebaseContinueOperation | RevertFilesOperation | RevListOperation | RevParseOperation | </ins> SetBranchUpstreamOperation | ShowOperation | StageOperation | StatusOperation | StashOperation | SubmoduleUpdateOperation | SyncOperation | TagOperation;


Question: <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Steps to Reproduce: on a file from the "All Changes" node that the diff editor does not have the commit for the right hand side !

export type RebaseContinueOperation = BaseOperation & { kind: OperationKind.RebaseContinue }; export type RevertFilesOperation = BaseOperation & { kind: OperationKind.RevertFiles }; export type RevListOperation = BaseOperation & { kind: OperationKind.RevList }; <ins> export type RevParseOperation = BaseOperation & { kind: OperationKind.RevParse }; </ins> export type SetBranchUpstreamOperation = BaseOperation & { kind: OperationKind.SetBranchUpstream }; export type ShowOperation = BaseOperation & { kind: OperationKind.Show }; export type StageOperation = BaseOperation & { kind: OperationKind.Stage };


Question: <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Steps to Reproduce: on a file from the "All Changes" node that the diff editor does not have the commit for the right hand side !

RebaseContinue: { kind: OperationKind.RebaseContinue, blocking: false, readOnly: false, remote: false, retry: false, showProgress: true } as RebaseContinueOperation, RevertFiles: (showProgress: boolean) => ({ kind: OperationKind.RevertFiles, blocking: false, readOnly: false, remote: false, retry: false, showProgress } as RevertFilesOperation), RevList: { kind: OperationKind.RevList, blocking: false, readOnly: true, remote: false, retry: false, showProgress: false } as RevListOperation, <ins> RevParse: { kind: OperationKind.RevParse, blocking: false, readOnly: true, remote: false, retry: false, showProgress: false } as RevParseOperation, </ins> SetBranchUpstream: { kind: OperationKind.SetBranchUpstream, blocking: false, readOnly: false, remote: false, retry: false, showProgress: true } as SetBranchUpstreamOperation, Show: { kind: OperationKind.Show, blocking: false, readOnly: true, remote: false, retry: false, showProgress: false } as ShowOperation, Stage: { kind: OperationKind.Stage, blocking: false, readOnly: false, remote: false, retry: false, showProgress: true } as StageOperation,


Question: <!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Steps to Reproduce: on a file from the "All Changes" node that the diff editor does not have the commit for the right hand side !

return await this.run(Operation.RevList, () => this.repository.getCommitCount(range)); } <ins> async revParse(ref: string): Promise<string | undefined> { return await this.run(Operation.RevParse, () => this.repository.revParse(ref)); } </ins> async reset(treeish: string, hard?: boolean): Promise<void> { await this.run(Operation.Reset, () => this.repository.reset(treeish, hard)); }


Question:
<!-- Do Not Delete This! bugreporttemplate --- VS Code Version: 1.83 Insiders OS Version: Windows 11 The friendly Settings editor name for should be "Editor Code Action Widget: Include Nearby Quick Fixes" not "Quickfixes". Description should also be "...nearest Quick Fix within a line..." to make other mentions of Quick Fix. !
For example: !

'editor.codeActionWidget.includeNearbyQuickfixes': { type: 'boolean', scope: ConfigurationScope.LANGUAGE_OVERRIDABLE, <del> description: nls.localize('includeNearbyQuickfixes', "Enable/disable showing nearest quickfix within a line when not currently on a diagnostic."), default: false, </del> <ins> description: nls.localize('includeNearbyQuickfixes', "Enable/disable showing nearest Quick Fix within a line when not currently on a diagnostic."), default: true, </ins> }, } });


Question:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Steps to Reproduce: up a keybinding to launch quick text search a diff editor some text quick text search Nothing in input: ! Expected: !
Hi , I guess the PR has fixed this already. I tried reproducing it locally with the changes of my current PR, and it seems to be working fine. Attaching the screen recording for your reference.
You need to open a diff editor. For example: open a folder that is a git repo Make a change in any file Go to the source control viewlet and click on the changed file: <img width="1679" alt="Screenshot 2023-10-08 at 2 57 57 PM" src=""Select text in the right editor The bug appears.
Got it, will try to correct it
Hi , I understand that you must be busy. Can you take a look any time you are available? I need some help in figuring out where exactly the diff editor is interacting with search bindings. For example, I am not able to understand how hitting cmd+f calls the search function from the diff, or where it is getting called from. Similarly for the quickTextSearch, can you point me in the right direction?
I was looking for code pointers and ended up finding the bug anyways:

} editor = editor ?? this.editorService.activeTextEditorControl; <del> if (isDiffEditor(editor)) { if (editor.getOriginalEditor().hasTextFocus()) { editor = editor.getOriginalEditor(); } else { editor = editor.getModifiedEditor(); } } </del> if (!editor) { return null;


Question:
<!-- Do Not Delete This! bugreporttemplate --<!-- Please read our Rules of Conduct: --<!-- Read our guide about submitting issues: --<!-- Search existing issues to avoid creating duplicates. --<!-- Test using the latest Insiders build to see if your issue has already been fixed: --<!-- Instead of creating your report here, use 'Report Issue' from the 'Help' menu in VS Code to pre-fill useful information. --<!-- Launch with to check. --Does this issue occur when all extensions are disabled?: Yes/No <!-- If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. --<!-- Issues caused by an extension need to be reported directly to the extension publisher. The 'Help Report Issue' dialog can assist with this. --- VS Code Version: OS Version: Steps to Reproduce: up a keybinding to launch quick text search a diff editor some text quick text search Nothing in input: ! Expected: !
Hi , I guess the PR has fixed this already. I tried reproducing it locally with the changes of my current PR, and it seems to be working fine. Attaching the screen recording for your reference.
You need to open a diff editor. For example: open a folder that is a git repo Make a change in any file Go to the source control viewlet and click on the changed file: <img width="1679" alt="Screenshot 2023-10-08 at 2 57 57 PM" src=""Select text in the right editor The bug appears.
Got it, will try to correct it
Hi , I understand that you must be busy. Can you take a look any time you are available? I need some help in figuring out where exactly the diff editor is interacting with search bindings. For example, I am not able to understand how hitting cmd+f calls the search function from the diff, or where it is getting called from. Similarly for the quickTextSearch, can you point me in the right direction?
I was looking for code pointers and ended up finding the bug anyways:

return undefined; } <del> export function getSelectionTextFromEditor(allowUnselectedWord: boolean, editor: IEditor): string | null { </del> <ins> export function getSelectionTextFromEditor(allowUnselectedWord: boolean, activeEditor: IEditor): string | null { let editor = activeEditor; if (isDiffEditor(editor)) { if (editor.getOriginalEditor().hasTextFocus()) { editor = editor.getOriginalEditor(); } else { editor = editor.getModifiedEditor(); } } </ins> if (!isCodeEditor(editor) || !editor.hasModel()) { return null;


Question:
I tested on Win11 & Win10. It works as long as you start a new workbook and don't save the jupyter notebook. Once you save the notebook, your pastes of images from the clipboard will no longer be treated as inline attachments. Originally posted by in
Possibly getting overridden by a markdown file paste provider?
were you able to replicate my findings?
Reviewed this thoroughly, and found the following. All cases are performed with a screenshot copied to the clipboard, and pasting into markdown notebook cells using ctrl+v. Using Windows 11 and current insiders. With setting unsaved notebook (command pallete -new jupyuter notebook -) results in broken markdown image link pasted, broken rendering (see screenshots attached) ! ! saved notebook creates image file on disk, creates markdown image link, renders correctly. With setting unsaved notebook (command pallete -new jupyuter notebook -) results in correct inline attachment image link pasted, renders correctly saved notebook results in correct inline attachment image link pasted, renders correctly
With the above investigation, I believe this is likely an issue with markdown paste providers, assigning to take a look at this. to clarify, are you expecting the images to be created on-disk upon paste, and referenced via an image markdown link? Or are you looking for the experience, with images stored in the notebook itself. The latter can be achieved and still works properly with the setting
I prefer the later, where the images are stored in the notebook, this makes it easier to share with others in these scenarios. This used to be working and then stopped working in the build I noted in the original question refenced, but I just tested in the latest build and it is back to working as expected, so must have been a bug that has now been fixed: The version I just tested with is updated now and it is working as expected with the Version: 1.83.1 (system setup) Commit: Date: 2023-10-10T23:48:05.904Z Electron: 25.8.4 ElectronBuildId: Chromium: 114.0.5735.289 18.15.0 V8: 11.4.183.29-electron.0 OS: Windows_NT x64 10.0.
Works fine for me too with the default settings. Will disable pasting into untitled notebooks with the setting off

import { Mime, mediaMimes } from '../../util/mimes'; import { Schemes } from '../../util/schemes'; import { createEditForMediaFiles, tryGetUriListSnippet } from './shared'; <ins> import { getParentDocumentUri } from '../../util/document'; </ins> class ResourceDropProvider implements vscode.DocumentDropEditProvider {


Question:
I tested on Win11 & Win10. It works as long as you start a new workbook and don't save the jupyter notebook. Once you save the notebook, your pastes of images from the clipboard will no longer be treated as inline attachments. Originally posted by in
Possibly getting overridden by a markdown file paste provider?
were you able to replicate my findings?
Reviewed this thoroughly, and found the following. All cases are performed with a screenshot copied to the clipboard, and pasting into markdown notebook cells using ctrl+v. Using Windows 11 and current insiders. With setting unsaved notebook (command pallete -new jupyuter notebook -) results in broken markdown image link pasted, broken rendering (see screenshots attached) ! ! saved notebook creates image file on disk, creates markdown image link, renders correctly. With setting unsaved notebook (command pallete -new jupyuter notebook -) results in correct inline attachment image link pasted, renders correctly saved notebook results in correct inline attachment image link pasted, renders correctly
With the above investigation, I believe this is likely an issue with markdown paste providers, assigning to take a look at this. to clarify, are you expecting the images to be created on-disk upon paste, and referenced via an image markdown link? Or are you looking for the experience, with images stored in the notebook itself. The latter can be achieved and still works properly with the setting
I prefer the later, where the images are stored in the notebook, this makes it easier to share with others in these scenarios. This used to be working and then stopped working in the build I noted in the original question refenced, but I just tested in the latest build and it is back to working as expected, so must have been a bug that has now been fixed: The version I just tested with is updated now and it is working as expected with the Version: 1.83.1 (system setup) Commit: Date: 2023-10-10T23:48:05.904Z Electron: 25.8.4 ElectronBuildId: Chromium: 114.0.5735.289 18.15.0 V8: 11.4.183.29-electron.0 OS: Windows_NT x64 10.0.
Works fine for me too with the default settings. Will disable pasting into untitled notebooks with the setting off

} private async _getMediaFilesEdit(document: vscode.TextDocument, dataTransfer: vscode.DataTransfer, token: vscode.CancellationToken): Promise<vscode.DocumentDropEdit | undefined> { <del> if (document.uri.scheme === Schemes.untitled) { </del> <ins> if (getParentDocumentUri(document.uri).scheme === Schemes.untitled) { </ins> return; }


Question:
I tested on Win11 & Win10. It works as long as you start a new workbook and don't save the jupyter notebook. Once you save the notebook, your pastes of images from the clipboard will no longer be treated as inline attachments. Originally posted by in
Possibly getting overridden by a markdown file paste provider?
were you able to replicate my findings?
Reviewed this thoroughly, and found the following. All cases are performed with a screenshot copied to the clipboard, and pasting into markdown notebook cells using ctrl+v. Using Windows 11 and current insiders. With setting unsaved notebook (command pallete -new jupyuter notebook -) results in broken markdown image link pasted, broken rendering (see screenshots attached) ! ! saved notebook creates image file on disk, creates markdown image link, renders correctly. With setting unsaved notebook (command pallete -new jupyuter notebook -) results in correct inline attachment image link pasted, renders correctly saved notebook results in correct inline attachment image link pasted, renders correctly
With the above investigation, I believe this is likely an issue with markdown paste providers, assigning to take a look at this. to clarify, are you expecting the images to be created on-disk upon paste, and referenced via an image markdown link? Or are you looking for the experience, with images stored in the notebook itself. The latter can be achieved and still works properly with the setting
I prefer the later, where the images are stored in the notebook, this makes it easier to share with others in these scenarios. This used to be working and then stopped working in the build I noted in the original question refenced, but I just tested in the latest build and it is back to working as expected, so must have been a bug that has now been fixed: The version I just tested with is updated now and it is working as expected with the Version: 1.83.1 (system setup) Commit: Date: 2023-10-10T23:48:05.904Z Electron: 25.8.4 ElectronBuildId: Chromium: 114.0.5735.289 18.15.0 V8: 11.4.183.29-electron.0 OS: Windows_NT x64 10.0.
Works fine for me too with the default settings. Will disable pasting into untitled notebooks with the setting off

import { Mime, mediaMimes } from '../../util/mimes'; import { Schemes } from '../../util/schemes'; import { PasteUrlAsFormattedLink, createEditAddingLinksForUriList, createEditForMediaFiles, getPasteUrlAsFormattedLinkSetting } from './shared'; <ins> import { getParentDocumentUri } from '../../util/document'; </ins> class PasteResourceEditProvider implements vscode.DocumentPasteEditProvider {


Question:
I tested on Win11 & Win10. It works as long as you start a new workbook and don't save the jupyter notebook. Once you save the notebook, your pastes of images from the clipboard will no longer be treated as inline attachments. Originally posted by in
Possibly getting overridden by a markdown file paste provider?
were you able to replicate my findings?
Reviewed this thoroughly, and found the following. All cases are performed with a screenshot copied to the clipboard, and pasting into markdown notebook cells using ctrl+v. Using Windows 11 and current insiders. With setting unsaved notebook (command pallete -new jupyuter notebook -) results in broken markdown image link pasted, broken rendering (see screenshots attached) ! ! saved notebook creates image file on disk, creates markdown image link, renders correctly. With setting unsaved notebook (command pallete -new jupyuter notebook -) results in correct inline attachment image link pasted, renders correctly saved notebook results in correct inline attachment image link pasted, renders correctly
With the above investigation, I believe this is likely an issue with markdown paste providers, assigning to take a look at this. to clarify, are you expecting the images to be created on-disk upon paste, and referenced via an image markdown link? Or are you looking for the experience, with images stored in the notebook itself. The latter can be achieved and still works properly with the setting
I prefer the later, where the images are stored in the notebook, this makes it easier to share with others in these scenarios. This used to be working and then stopped working in the build I noted in the original question refenced, but I just tested in the latest build and it is back to working as expected, so must have been a bug that has now been fixed: The version I just tested with is updated now and it is working as expected with the Version: 1.83.1 (system setup) Commit: Date: 2023-10-10T23:48:05.904Z Electron: 25.8.4 ElectronBuildId: Chromium: 114.0.5735.289 18.15.0 V8: 11.4.183.29-electron.0 OS: Windows_NT x64 10.0.
Works fine for me too with the default settings. Will disable pasting into untitled notebooks with the setting off

} private async _getMediaFilesEdit(document: vscode.TextDocument, dataTransfer: vscode.DataTransfer, token: vscode.CancellationToken): Promise<vscode.DocumentPasteEdit | undefined> { <del> if (document.uri.scheme === Schemes.untitled) { </del> <ins> if (getParentDocumentUri(document.uri).scheme === Schemes.untitled) { </ins> return; }


Question:
I was working with a notebook, switched tabs, and tried to switch back, now the editor is blank and my progress with the notebook is lost. this seems to repro every time.
stack is irrelevant, the issue can repro without any errors

this._overlayContainer.style.position = 'absolute'; this._overlayContainer.style.overflow = 'hidden'; <del> if (this._isVisible) { this.layoutContainerOverShadowElement(dimension, position); } </del> <ins> this.layoutContainerOverShadowElement(dimension, position); </ins> if (this._webviewTransparentCover) { this._webviewTransparentCover.style.height = `${dimension.height}px`;


Question:
Type: <bBug</bPowerShell in editor area NOT type anything in the terminal input alt+F2 to open accessible view for the terminal ctrl+shift+o to open symbol list DownArrow key and you will hear: "No editor symbols" ESC key Note: pressing ESC key also closes the Accessible Buffer View. VS Code version: Code - Insiders 1.84.0-insider (, 2023-10-06T05:35:21.061Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (92)</summaryExtensionVersion ------ android-dev-ext1.3.2 aiprm-lang0.0.2 Bookmarks13.4.1 openscad1.2.1 spellright3.0.118 zoterolatex0.4.1 mermaid-markdown-syntax-highlighting1.5.2 doxdocgen1.4.0 vscode-markdownlint0.52.0 vscode-eslint2.4.2 vscode-quick-select0.2.9 vscode-deno3.25.1 gitlens14.3.0 EditorConfig0.16.4 prettier-vscode10.1.0 vscode-google-translate1.4.13 codespaces1.15.4 copilot1.123.470 copilot-chat0.9. remotehub0.62.0 vscode-github-actions0.26.2 vscode-pull-request-github0.74.0 overleaf-workshop0.3.0 cslpreview0.2.2 easy-snippet0.6.3 path-autocomplete1.25.0 latex-workshop9.14.1 lilypond-syntax0.1.1 scheme0.2.0 better-cpp-syntax1.17.2 vscode-bard0.0.10 google-search0.0.1 vscode-lua-format1.3.8 lilypond-formatter0.2.3 lilypond-pdf-preview0.2.8 lilypond-snippets0.1.1 vslilypond1.7.3 zotero0.1.10 git-graph1.30.0 vscode-docker1.26.1 black-formatter2023.4.1 flake82023.8.0 isort2023.11. python2023.18.0 vscode-pylance2023.10.10 jupyter2023.9. jupyter-keymap1.1.2 jupyter-renderers1.0.17 vscode-jupyter-cell-tags0.1.8 vscode-jupyter-slideshow0.1.5 remote-containers0.317.0 remote-ssh0.106.5 remote-ssh-edit0.86.0 remote-wsl0.81.7 vscode-remote-extensionpack0.24.0 azure-repos0.38.0 cmake-tools1.15.31 cpptools1.17.5 cpptools-extension-pack1.3.0 js-debug-nightly2023.10.417 powershell2023.9.4 remote-repositories0.40.0 vscode-github-issue-notebooks0.0.130 vscode-selfhost-test-provider0.3.18 vscode-serial-monitor0.10.0 vsliveshare1.0.5883 autodocstring0.6.1 pandocciter0.10.3 shiny-python0.1.4 shinyuieditor0.5.0 quarto1.101.0 r-debugger0.5.4 java1.23.0 vscode-xml0.26.1 r2.8.1 multi-command1.6.0 vscode-deepl1.0.6 abc-music0.4.0 lua3.7.0 latex-utilities0.4.10 cmake0.0.17 errorlens3.14.0 intellicode-api-usage-examples0.2.8 vscodeintellicode1.2.30 vscode-arduino0.6.0 vscode-java-debug0.54.0 vscode-java-dependency0.23.1 vscode-java-pack0.25.14 vscode-java-test0.40.0 vscode-maven0.42.0 markdown-all-in-one3.5.1 grammarly0.22.1 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
The editor's go to symbol is getting invoked in this case. We should prevent that from happening via a context key.
note that this action is disabled when there are not symbols for the current accessible view. good bug find though . The fix will make it such that no quick pick opens.

import { IEditorGroupsService } from 'vs/workbench/services/editor/common/editorGroupsService'; import { IOutlineModelService } from 'vs/editor/contrib/documentSymbols/browser/outlineModel'; import { ILanguageFeaturesService } from 'vs/editor/common/services/languageFeatures'; <ins> import { ContextKeyExpr } from 'vs/platform/contextkey/common/contextkey'; import { accessibilityHelpIsShown, accessibleViewIsShown } from 'vs/workbench/contrib/accessibility/browser/accessibilityConfiguration'; </ins> export class GotoSymbolQuickAccessProvider extends AbstractGotoSymbolQuickAccessProvider {


Question:
Type: <bBug</bPowerShell in editor area NOT type anything in the terminal input alt+F2 to open accessible view for the terminal ctrl+shift+o to open symbol list DownArrow key and you will hear: "No editor symbols" ESC key Note: pressing ESC key also closes the Accessible Buffer View. VS Code version: Code - Insiders 1.84.0-insider (, 2023-10-06T05:35:21.061Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (92)</summaryExtensionVersion ------ android-dev-ext1.3.2 aiprm-lang0.0.2 Bookmarks13.4.1 openscad1.2.1 spellright3.0.118 zoterolatex0.4.1 mermaid-markdown-syntax-highlighting1.5.2 doxdocgen1.4.0 vscode-markdownlint0.52.0 vscode-eslint2.4.2 vscode-quick-select0.2.9 vscode-deno3.25.1 gitlens14.3.0 EditorConfig0.16.4 prettier-vscode10.1.0 vscode-google-translate1.4.13 codespaces1.15.4 copilot1.123.470 copilot-chat0.9. remotehub0.62.0 vscode-github-actions0.26.2 vscode-pull-request-github0.74.0 overleaf-workshop0.3.0 cslpreview0.2.2 easy-snippet0.6.3 path-autocomplete1.25.0 latex-workshop9.14.1 lilypond-syntax0.1.1 scheme0.2.0 better-cpp-syntax1.17.2 vscode-bard0.0.10 google-search0.0.1 vscode-lua-format1.3.8 lilypond-formatter0.2.3 lilypond-pdf-preview0.2.8 lilypond-snippets0.1.1 vslilypond1.7.3 zotero0.1.10 git-graph1.30.0 vscode-docker1.26.1 black-formatter2023.4.1 flake82023.8.0 isort2023.11. python2023.18.0 vscode-pylance2023.10.10 jupyter2023.9. jupyter-keymap1.1.2 jupyter-renderers1.0.17 vscode-jupyter-cell-tags0.1.8 vscode-jupyter-slideshow0.1.5 remote-containers0.317.0 remote-ssh0.106.5 remote-ssh-edit0.86.0 remote-wsl0.81.7 vscode-remote-extensionpack0.24.0 azure-repos0.38.0 cmake-tools1.15.31 cpptools1.17.5 cpptools-extension-pack1.3.0 js-debug-nightly2023.10.417 powershell2023.9.4 remote-repositories0.40.0 vscode-github-issue-notebooks0.0.130 vscode-selfhost-test-provider0.3.18 vscode-serial-monitor0.10.0 vsliveshare1.0.5883 autodocstring0.6.1 pandocciter0.10.3 shiny-python0.1.4 shinyuieditor0.5.0 quarto1.101.0 r-debugger0.5.4 java1.23.0 vscode-xml0.26.1 r2.8.1 multi-command1.6.0 vscode-deepl1.0.6 abc-music0.4.0 lua3.7.0 latex-utilities0.4.10 cmake0.0.17 errorlens3.14.0 intellicode-api-usage-examples0.2.8 vscodeintellicode1.2.30 vscode-arduino0.6.0 vscode-java-debug0.54.0 vscode-java-dependency0.23.1 vscode-java-pack0.25.14 vscode-java-test0.40.0 vscode-maven0.42.0 markdown-all-in-one3.5.1 grammarly0.22.1 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --
The editor's go to symbol is getting invoked in this case. We should prevent that from happening via a context key.
note that this action is disabled when there are not symbols for the current accessible view. good bug find though . The fix will make it such that no quick pick opens.

}, f1: true, keybinding: { <del> when: undefined, </del> <ins> when: ContextKeyExpr.and(accessibleViewIsShown.negate(), accessibilityHelpIsShown.negate()), </ins> weight: KeybindingWeight.WorkbenchContrib, primary: KeyMod.CtrlCmd | KeyMod.Shift | KeyCode.KeyO },


Question:
I keep pressing the X on this message and it still keeps coming back. Every single time I open a window. I have told it to go away almost 50 times now. I am being driven towards insanity. <img width="826" alt="image" src=""May this bug report stand in evidence that I have gotten the message. Thank you. Version: 1.83.0 (Universal) Commit: Date: 2023-10-03T16:13:15.449Z (3 days ago) Electron: 25.8.4 ElectronBuildId: Chromium: 114.0.5735.289 18.15.0 V8: 11.4.183.29-electron.0 OS: Darwin x64 18.7.0
Will just remove the banner.
should we mark this as author verification required? I'm assuming those testing internally would have updated their MacOS
how do I remove the banner in windows 8?
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
is the issue fixed for you on the latest ?
Feel free to mark as verified via code review.

// Windows 32-bit warning if (isWindows && this.environmentService.os.arch === 'ia32') { const message = localize('windows32eolmessage', "You are running {0} 32-bit, which will soon stop receiving updates on Windows. Consider upgrading to the 64-bit build.", this.productService.nameLong); <del> const actions = [{ label: localize('windowseolBannerLearnMore', "Learn More"), href: 'https://aka.ms/vscode-faq-old-windows' }]; this.bannerService.show({ id: 'windows32eol.banner', message, ariaLabel: localize('windowseolarialabel', "{0}. Use navigation keys to access banner actions.", message), actions, icon: Codicon.warning }); </del> this.notificationService.prompt( Severity.Warning,


Question:
I keep pressing the X on this message and it still keeps coming back. Every single time I open a window. I have told it to go away almost 50 times now. I am being driven towards insanity. <img width="826" alt="image" src=""May this bug report stand in evidence that I have gotten the message. Thank you. Version: 1.83.0 (Universal) Commit: Date: 2023-10-03T16:13:15.449Z (3 days ago) Electron: 25.8.4 ElectronBuildId: Chromium: 114.0.5735.289 18.15.0 V8: 11.4.183.29-electron.0 OS: Darwin x64 18.7.0
Will just remove the banner.
should we mark this as author verification required? I'm assuming those testing internally would have updated their MacOS
how do I remove the banner in windows 8?
<!-- AUTHORVERIFICATIONREQUEST --This bug has been fixed in the latest release of ! you can help us out by commenting if things are now working as expected. If things still don't seem right, please ensure you're on version of Insiders (today's or later - you can use in the command palette to check), and leave a comment letting us know what isn't working as expected. Happy Coding!
is the issue fixed for you on the latest ?
Feel free to mark as verified via code review.

if (eolReleases.has(majorVersion)) { const message = localize('macoseolmessage', "{0} on {1} will soon stop receiving updates. Consider upgrading your macOS version.", this.productService.nameLong, eolReleases.get(majorVersion)); <del> const actions = [{ label: localize('macoseolBannerLearnMore', "Learn More"), href: 'https://aka.ms/vscode-faq-old-macOS' }]; this.bannerService.show({ id: 'macoseol.banner', message, ariaLabel: localize('macoseolarialabel', "{0}. Use navigation keys to access banner actions.", message), actions, icon: Codicon.warning }); </del> this.notificationService.prompt( Severity.Warning,


Question: Type: <bBug</bMake some notification and press ctrl+K, ctrl+shift+N and try to clear the notification list. Screen readers are expected to hear "Cleared"; however, it is not currently supported. VS Code version: Code - Insiders 1.84.0-insider (, 2023-10-09T06:11:57.204Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (92)</summaryExtensionVersion ------ android-dev-ext1.3.2 aiprm-lang0.0.2 Bookmarks13.4.2 openscad1.2.2 spellright3.0.118 zoterolatex0.4.1 mermaid-markdown-syntax-highlighting1.5.2 doxdocgen1.4.0 vscode-markdownlint0.52.0 vscode-eslint2.4.2 vscode-quick-select0.2.9 vscode-deno3.25.1 gitlens14.3.0 EditorConfig0.16.4 prettier-vscode10.1.0 vscode-google-translate1.4.13 codespaces1.15.4 copilot1.123.477 copilot-chat0.9. remotehub0.62.0 vscode-github-actions0.26.2 vscode-pull-request-github0.74.0 overleaf-workshop0.3.0 cslpreview0.2.2 easy-snippet0.6.3 path-autocomplete1.25.0 latex-workshop9.14.1 lilypond-syntax0.1.1 scheme0.2.0 better-cpp-syntax1.17.2 vscode-bard0.0.10 google-search0.0.1 vscode-lua-format1.3.8 lilypond-formatter0.2.3 lilypond-pdf-preview0.2.8 lilypond-snippets0.1.1 vslilypond1.7.3 zotero0.1.10 git-graph1.30.0 vscode-docker1.26.1 black-formatter2023.4.1 flake82023.8.0 isort2023.11. python2023.18.0 vscode-pylance2023.10.10 jupyter2023.9. jupyter-keymap1.1.2 jupyter-renderers1.0.17 vscode-jupyter-cell-tags0.1.8 vscode-jupyter-slideshow0.1.5 remote-containers0.317.0 remote-ssh0.106.5 remote-ssh-edit0.86.0 remote-wsl0.81.7 vscode-remote-extensionpack0.24.0 azure-repos0.38.0 cmake-tools1.15.31 cpptools1.17.5 cpptools-extension-pack1.3.0 js-debug-nightly2023.10.917 powershell2023.9.4 remote-repositories0.40.0 vscode-github-issue-notebooks0.0.130 vscode-selfhost-test-provider0.3.18 vscode-serial-monitor0.10.0 vsliveshare1.0.5883 autodocstring0.6.1 pandocciter0.10.3 shiny-python0.1.4 shinyuieditor0.5.0 quarto1.102.0 r-debugger0.5.4 java1.23.0 vscode-xml0.26.1 r2.8.2 multi-command1.6.0 vscode-deepl1.0.6 abc-music0.4.0 lua3.7.0 latex-utilities0.4.10 cmake0.0.17 errorlens3.14.0 intellicode-api-usage-examples0.2.8 vscodeintellicode1.2.30 vscode-arduino0.6.0 vscode-java-debug0.54.0 vscode-java-dependency0.23.1 vscode-java-pack0.25.14 vscode-java-test0.40.0 vscode-maven0.42.0 markdown-all-in-one3.5.1 grammarly0.22.1 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --

import { assertAllDefined, assertIsDefined } from 'vs/base/common/types'; import { NotificationsCenterVisibleContext } from 'vs/workbench/common/contextkeys'; import { INotificationService } from 'vs/platform/notification/common/notification'; <ins> import { AccessibleNotificationEvent, IAccessibleNotificationService } from 'vs/platform/accessibility/common/accessibility'; </ins> export class NotificationsCenter extends Themable implements INotificationsCenterController {


Question: Type: <bBug</bMake some notification and press ctrl+K, ctrl+shift+N and try to clear the notification list. Screen readers are expected to hear "Cleared"; however, it is not currently supported. VS Code version: Code - Insiders 1.84.0-insider (, 2023-10-09T06:11:57.204Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (92)</summaryExtensionVersion ------ android-dev-ext1.3.2 aiprm-lang0.0.2 Bookmarks13.4.2 openscad1.2.2 spellright3.0.118 zoterolatex0.4.1 mermaid-markdown-syntax-highlighting1.5.2 doxdocgen1.4.0 vscode-markdownlint0.52.0 vscode-eslint2.4.2 vscode-quick-select0.2.9 vscode-deno3.25.1 gitlens14.3.0 EditorConfig0.16.4 prettier-vscode10.1.0 vscode-google-translate1.4.13 codespaces1.15.4 copilot1.123.477 copilot-chat0.9. remotehub0.62.0 vscode-github-actions0.26.2 vscode-pull-request-github0.74.0 overleaf-workshop0.3.0 cslpreview0.2.2 easy-snippet0.6.3 path-autocomplete1.25.0 latex-workshop9.14.1 lilypond-syntax0.1.1 scheme0.2.0 better-cpp-syntax1.17.2 vscode-bard0.0.10 google-search0.0.1 vscode-lua-format1.3.8 lilypond-formatter0.2.3 lilypond-pdf-preview0.2.8 lilypond-snippets0.1.1 vslilypond1.7.3 zotero0.1.10 git-graph1.30.0 vscode-docker1.26.1 black-formatter2023.4.1 flake82023.8.0 isort2023.11. python2023.18.0 vscode-pylance2023.10.10 jupyter2023.9. jupyter-keymap1.1.2 jupyter-renderers1.0.17 vscode-jupyter-cell-tags0.1.8 vscode-jupyter-slideshow0.1.5 remote-containers0.317.0 remote-ssh0.106.5 remote-ssh-edit0.86.0 remote-wsl0.81.7 vscode-remote-extensionpack0.24.0 azure-repos0.38.0 cmake-tools1.15.31 cpptools1.17.5 cpptools-extension-pack1.3.0 js-debug-nightly2023.10.917 powershell2023.9.4 remote-repositories0.40.0 vscode-github-issue-notebooks0.0.130 vscode-selfhost-test-provider0.3.18 vscode-serial-monitor0.10.0 vsliveshare1.0.5883 autodocstring0.6.1 pandocciter0.10.3 shiny-python0.1.4 shinyuieditor0.5.0 quarto1.102.0 r-debugger0.5.4 java1.23.0 vscode-xml0.26.1 r2.8.2 multi-command1.6.0 vscode-deepl1.0.6 abc-music0.4.0 lua3.7.0 latex-utilities0.4.10 cmake0.0.17 errorlens3.14.0 intellicode-api-usage-examples0.2.8 vscodeintellicode1.2.30 vscode-arduino0.6.0 vscode-java-debug0.54.0 vscode-java-dependency0.23.1 vscode-java-pack0.25.14 vscode-java-test0.40.0 vscode-maven0.42.0 markdown-all-in-one3.5.1 grammarly0.22.1 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --

@IEditorGroupsService private readonly editorGroupService: IEditorGroupsService, @IKeybindingService private readonly keybindingService: IKeybindingService, @INotificationService private readonly notificationService: INotificationService, <ins> @IAccessibleNotificationService private readonly accessibleNotificationService: IAccessibleNotificationService </ins> ) { super(themeService);


Question: Type: <bBug</bMake some notification and press ctrl+K, ctrl+shift+N and try to clear the notification list. Screen readers are expected to hear "Cleared"; however, it is not currently supported. VS Code version: Code - Insiders 1.84.0-insider (, 2023-10-09T06:11:57.204Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (92)</summaryExtensionVersion ------ android-dev-ext1.3.2 aiprm-lang0.0.2 Bookmarks13.4.2 openscad1.2.2 spellright3.0.118 zoterolatex0.4.1 mermaid-markdown-syntax-highlighting1.5.2 doxdocgen1.4.0 vscode-markdownlint0.52.0 vscode-eslint2.4.2 vscode-quick-select0.2.9 vscode-deno3.25.1 gitlens14.3.0 EditorConfig0.16.4 prettier-vscode10.1.0 vscode-google-translate1.4.13 codespaces1.15.4 copilot1.123.477 copilot-chat0.9. remotehub0.62.0 vscode-github-actions0.26.2 vscode-pull-request-github0.74.0 overleaf-workshop0.3.0 cslpreview0.2.2 easy-snippet0.6.3 path-autocomplete1.25.0 latex-workshop9.14.1 lilypond-syntax0.1.1 scheme0.2.0 better-cpp-syntax1.17.2 vscode-bard0.0.10 google-search0.0.1 vscode-lua-format1.3.8 lilypond-formatter0.2.3 lilypond-pdf-preview0.2.8 lilypond-snippets0.1.1 vslilypond1.7.3 zotero0.1.10 git-graph1.30.0 vscode-docker1.26.1 black-formatter2023.4.1 flake82023.8.0 isort2023.11. python2023.18.0 vscode-pylance2023.10.10 jupyter2023.9. jupyter-keymap1.1.2 jupyter-renderers1.0.17 vscode-jupyter-cell-tags0.1.8 vscode-jupyter-slideshow0.1.5 remote-containers0.317.0 remote-ssh0.106.5 remote-ssh-edit0.86.0 remote-wsl0.81.7 vscode-remote-extensionpack0.24.0 azure-repos0.38.0 cmake-tools1.15.31 cpptools1.17.5 cpptools-extension-pack1.3.0 js-debug-nightly2023.10.917 powershell2023.9.4 remote-repositories0.40.0 vscode-github-issue-notebooks0.0.130 vscode-selfhost-test-provider0.3.18 vscode-serial-monitor0.10.0 vsliveshare1.0.5883 autodocstring0.6.1 pandocciter0.10.3 shiny-python0.1.4 shinyuieditor0.5.0 quarto1.102.0 r-debugger0.5.4 java1.23.0 vscode-xml0.26.1 r2.8.2 multi-command1.6.0 vscode-deepl1.0.6 abc-music0.4.0 lua3.7.0 latex-utilities0.4.10 cmake0.0.17 errorlens3.14.0 intellicode-api-usage-examples0.2.8 vscodeintellicode1.2.30 vscode-arduino0.6.0 vscode-java-debug0.54.0 vscode-java-dependency0.23.1 vscode-java-pack0.25.14 vscode-java-test0.40.0 vscode-maven0.42.0 markdown-all-in-one3.5.1 grammarly0.22.1 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --

if (!notification.hasProgress) { notification.close(); } <ins> this.accessibleNotificationService.notify(AccessibleNotificationEvent.Clear); </ins> } } }


Question: Type: <bBug</bMake some notification and press ctrl+K, ctrl+shift+N and try to clear the notification list. Screen readers are expected to hear "Cleared"; however, it is not currently supported. VS Code version: Code - Insiders 1.84.0-insider (, 2023-10-09T06:11:57.204Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (92)</summaryExtensionVersion ------ android-dev-ext1.3.2 aiprm-lang0.0.2 Bookmarks13.4.2 openscad1.2.2 spellright3.0.118 zoterolatex0.4.1 mermaid-markdown-syntax-highlighting1.5.2 doxdocgen1.4.0 vscode-markdownlint0.52.0 vscode-eslint2.4.2 vscode-quick-select0.2.9 vscode-deno3.25.1 gitlens14.3.0 EditorConfig0.16.4 prettier-vscode10.1.0 vscode-google-translate1.4.13 codespaces1.15.4 copilot1.123.477 copilot-chat0.9. remotehub0.62.0 vscode-github-actions0.26.2 vscode-pull-request-github0.74.0 overleaf-workshop0.3.0 cslpreview0.2.2 easy-snippet0.6.3 path-autocomplete1.25.0 latex-workshop9.14.1 lilypond-syntax0.1.1 scheme0.2.0 better-cpp-syntax1.17.2 vscode-bard0.0.10 google-search0.0.1 vscode-lua-format1.3.8 lilypond-formatter0.2.3 lilypond-pdf-preview0.2.8 lilypond-snippets0.1.1 vslilypond1.7.3 zotero0.1.10 git-graph1.30.0 vscode-docker1.26.1 black-formatter2023.4.1 flake82023.8.0 isort2023.11. python2023.18.0 vscode-pylance2023.10.10 jupyter2023.9. jupyter-keymap1.1.2 jupyter-renderers1.0.17 vscode-jupyter-cell-tags0.1.8 vscode-jupyter-slideshow0.1.5 remote-containers0.317.0 remote-ssh0.106.5 remote-ssh-edit0.86.0 remote-wsl0.81.7 vscode-remote-extensionpack0.24.0 azure-repos0.38.0 cmake-tools1.15.31 cpptools1.17.5 cpptools-extension-pack1.3.0 js-debug-nightly2023.10.917 powershell2023.9.4 remote-repositories0.40.0 vscode-github-issue-notebooks0.0.130 vscode-selfhost-test-provider0.3.18 vscode-serial-monitor0.10.0 vsliveshare1.0.5883 autodocstring0.6.1 pandocciter0.10.3 shiny-python0.1.4 shinyuieditor0.5.0 quarto1.102.0 r-debugger0.5.4 java1.23.0 vscode-xml0.26.1 r2.8.2 multi-command1.6.0 vscode-deepl1.0.6 abc-music0.4.0 lua3.7.0 latex-utilities0.4.10 cmake0.0.17 errorlens3.14.0 intellicode-api-usage-examples0.2.8 vscodeintellicode1.2.30 vscode-arduino0.6.0 vscode-java-debug0.54.0 vscode-java-dependency0.23.1 vscode-java-pack0.25.14 vscode-java-test0.40.0 vscode-maven0.42.0 markdown-all-in-one3.5.1 grammarly0.22.1 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --

import { ActionRunner, IAction, WorkbenchActionExecutedEvent, WorkbenchActionExecutedClassification } from 'vs/base/common/actions'; import { hash } from 'vs/base/common/hash'; import { firstOrDefault } from 'vs/base/common/arrays'; <ins> import { AccessibleNotificationEvent, IAccessibleNotificationService } from 'vs/platform/accessibility/common/accessibility'; </ins> // Center export const SHOW_NOTIFICATIONS_CENTER = 'notifications.showList';


Question: Type: <bBug</bMake some notification and press ctrl+K, ctrl+shift+N and try to clear the notification list. Screen readers are expected to hear "Cleared"; however, it is not currently supported. VS Code version: Code - Insiders 1.84.0-insider (, 2023-10-09T06:11:57.204Z) OS version: WindowsNT x64 10.0. Modes: <details<summarySystem Info</summary </details<details<summaryExtensions (92)</summaryExtensionVersion ------ android-dev-ext1.3.2 aiprm-lang0.0.2 Bookmarks13.4.2 openscad1.2.2 spellright3.0.118 zoterolatex0.4.1 mermaid-markdown-syntax-highlighting1.5.2 doxdocgen1.4.0 vscode-markdownlint0.52.0 vscode-eslint2.4.2 vscode-quick-select0.2.9 vscode-deno3.25.1 gitlens14.3.0 EditorConfig0.16.4 prettier-vscode10.1.0 vscode-google-translate1.4.13 codespaces1.15.4 copilot1.123.477 copilot-chat0.9. remotehub0.62.0 vscode-github-actions0.26.2 vscode-pull-request-github0.74.0 overleaf-workshop0.3.0 cslpreview0.2.2 easy-snippet0.6.3 path-autocomplete1.25.0 latex-workshop9.14.1 lilypond-syntax0.1.1 scheme0.2.0 better-cpp-syntax1.17.2 vscode-bard0.0.10 google-search0.0.1 vscode-lua-format1.3.8 lilypond-formatter0.2.3 lilypond-pdf-preview0.2.8 lilypond-snippets0.1.1 vslilypond1.7.3 zotero0.1.10 git-graph1.30.0 vscode-docker1.26.1 black-formatter2023.4.1 flake82023.8.0 isort2023.11. python2023.18.0 vscode-pylance2023.10.10 jupyter2023.9. jupyter-keymap1.1.2 jupyter-renderers1.0.17 vscode-jupyter-cell-tags0.1.8 vscode-jupyter-slideshow0.1.5 remote-containers0.317.0 remote-ssh0.106.5 remote-ssh-edit0.86.0 remote-wsl0.81.7 vscode-remote-extensionpack0.24.0 azure-repos0.38.0 cmake-tools1.15.31 cpptools1.17.5 cpptools-extension-pack1.3.0 js-debug-nightly2023.10.917 powershell2023.9.4 remote-repositories0.40.0 vscode-github-issue-notebooks0.0.130 vscode-selfhost-test-provider0.3.18 vscode-serial-monitor0.10.0 vsliveshare1.0.5883 autodocstring0.6.1 pandocciter0.10.3 shiny-python0.1.4 shinyuieditor0.5.0 quarto1.102.0 r-debugger0.5.4 java1.23.0 vscode-xml0.26.1 r2.8.2 multi-command1.6.0 vscode-deepl1.0.6 abc-music0.4.0 lua3.7.0 latex-utilities0.4.10 cmake0.0.17 errorlens3.14.0 intellicode-api-usage-examples0.2.8 vscodeintellicode1.2.30 vscode-arduino0.6.0 vscode-java-debug0.54.0 vscode-java-dependency0.23.1 vscode-java-pack0.25.14 vscode-java-test0.40.0 vscode-maven0.42.0 markdown-all-in-one3.5.1 grammarly0.22.1 (1 theme extensions excluded) </details<details<summaryA/B Experiments</summary</details<!-- generated by issue reporter --

primary: KeyMod.CtrlCmd | KeyCode.Backspace }, handler: (accessor, args?) => { <ins> const accessibleNotificationService = accessor.get(IAccessibleNotificationService); </ins> const notification = getNotificationFromContext(accessor.get(IListService), args); if (notification && !notification.hasProgress) { notification.close(); <ins> accessibleNotificationService.notify(AccessibleNotificationEvent.Clear); </ins> } } });


Question:
After updating I see this: ! After some investigation with we found that it's cause by this line in : Which calls into: Which calls in to which accesses state. This is only initialized later in the method though. Rough repro based on memory: 1 (Windows): Update client to latest 1: Set activity bar to top 1: Sync 2 (macOS, old client): Sync (pulls in activity bar top setting?) 2: Update to latest 2: Open client
Thanks for the fix. I got report of this bug from some users and I am asking for developer tools console log (thanks

this.stateModel.setRuntimeValue(LayoutStateKeys.EDITOR_HIDDEN, false); } <del> // Activity bar cannot be hidden if (this.stateModel.getRuntimeValue(LayoutStateKeys.ACTIVITYBAR_HIDDEN) && !this.canActivityBarBeHidden()) { this.stateModel.setRuntimeValue(LayoutStateKeys.ACTIVITYBAR_HIDDEN, false); } </del> this.stateModel.onDidChangeState(change => { if (change.key === LayoutStateKeys.ACTIVITYBAR_HIDDEN) { this.setActivityBarHidden(change.value as boolean);


Question:
After updating I see this: ! After some investigation with we found that it's cause by this line in : Which calls into: Which calls in to which accesses state. This is only initialized later in the method though. Rough repro based on memory: 1 (Windows): Update client to latest 1: Set activity bar to top 1: Sync 2 (macOS, old client): Sync (pulls in activity bar top setting?) 2: Update to latest 2: Open client
Thanks for the fix. I got report of this bug from some users and I am asking for developer tools console log (thanks

} } <ins> // Activity bar cannot be hidden // This check must be called after state is set // because canActivityBarBeHidden calls isVisible if (this.stateModel.getRuntimeValue(LayoutStateKeys.ACTIVITYBAR_HIDDEN) && !this.canActivityBarBeHidden()) { this.stateModel.setRuntimeValue(LayoutStateKeys.ACTIVITYBAR_HIDDEN, false); } </ins> // Window border this.updateWindowBorder(true); }


Question:
Testing Triggered by trying : !
Can you clarify what better message you would have expected?
Probably something telling me how I messed the URL up. Is their an allowlist or some way to know what the valid authorities are so you can tell me how I specified the wrong one? For instance, I specified an HTTP URL that I wanted to open, so being told that some port isn't opened suggested to me that some unspecified port wasn't opened on the GitHub side, not that I have a malformed URL.
Such a URL basically requires you to have an extension installed that can handle the remote authority. There is only very few: SSH, DevContainer, WSL and GH and GH Codespaces I think.

export function parseAuthorityWithPort(authority: string): { host: string; port: number } { const { host, port } = parseAuthority(authority); if (typeof port === 'undefined') { <del> throw new Error(`Remote authority doesn't contain a port!`); </del> <ins> throw new Error(`Invalid remote authority: ${authority}. It must either be a remote of form <remoteName>+<arg> or a remote host of form <host>:<port>.`); </ins> } return { host, port }; }


Question:
Expected ! Actual !
Regressed in
The markdown preview in the chat is also broken for Dark Modern but is fixed by your change: !
And the markdown preview in the settings editor: !
I looked into this some more and have the following findings block rendering is broken for Dark Modern, Light Modern, Dark HC and Light HC What changed: we a new theme token, , adopted it in and , and updated the values for to look good with a different background color But we didn't adopt token for blocks in Markdown previews, which is why is broken for Markdown preview Some options Adopt for blocks in Markdown preview -- this amounts to a rather drastic styling change for Markdown previews ! Revert Revert the change to and drop the usage of so that Markdown preview, chat, and settings UI are in a reasonable state for all themes, which I attempted in
Also affects the Extensions Details page since it is a Markdown preview !
Verification: for Light/Dark Modern and Light/Dark HC, make sure that blocks are properly rendered in Markdown preview, settings UI and chat

"textCodeBlock.background": "#2B2B2B", "textLink.activeForeground": "#4daafc", "textLink.foreground": "#4daafc", <del> "textPreformat.foreground": "#D0D0D0", </del> <ins> "textPreformat.foreground": "#D7BA7D", </ins> "textPreformat.background": "#3C3C3C", "textSeparator.foreground": "#21262D", "titleBar.activeBackground": "#181818",


Question:
Expected ! Actual !
Regressed in
The markdown preview in the chat is also broken for Dark Modern but is fixed by your change: !
And the markdown preview in the settings editor: !
I looked into this some more and have the following findings block rendering is broken for Dark Modern, Light Modern, Dark HC and Light HC What changed: we a new theme token, , adopted it in and , and updated the values for to look good with a different background color But we didn't adopt token for blocks in Markdown previews, which is why is broken for Markdown preview Some options Adopt for blocks in Markdown preview -- this amounts to a rather drastic styling change for Markdown previews ! Revert Revert the change to and drop the usage of so that Markdown preview, chat, and settings UI are in a reasonable state for all themes, which I attempted in
Also affects the Extensions Details page since it is a Markdown preview !
Verification: for Light/Dark Modern and Light/Dark HC, make sure that blocks are properly rendered in Markdown preview, settings UI and chat

"textCodeBlock.background": "#F8F8F8", "textLink.activeForeground": "#005FB8", "textLink.foreground": "#005FB8", <del> "textPreformat.foreground": "#3B3B3B", </del> <ins> "textPreformat.foreground": "#A31515", </ins> "textPreformat.background":	"#0000001F", "textSeparator.foreground": "#21262D", "titleBar.activeBackground": "#F8F8F8",


Question:
Expected ! Actual !
Regressed in
The markdown preview in the chat is also broken for Dark Modern but is fixed by your change: !
And the markdown preview in the settings editor: !
I looked into this some more and have the following findings block rendering is broken for Dark Modern, Light Modern, Dark HC and Light HC What changed: we a new theme token, , adopted it in and , and updated the values for to look good with a different background color But we didn't adopt token for blocks in Markdown previews, which is why is broken for Markdown preview Some options Adopt for blocks in Markdown preview -- this amounts to a rather drastic styling change for Markdown previews ! Revert Revert the change to and drop the usage of so that Markdown preview, chat, and settings UI are in a reasonable state for all themes, which I attempted in
Also affects the Extensions Details page since it is a Markdown preview !
Verification: for Light/Dark Modern and Light/Dark HC, make sure that blocks are properly rendered in Markdown preview, settings UI and chat

export const textSeparatorForeground = registerColor('textSeparator.foreground', { light: '#0000002e', dark: '#ffffff2e', hcDark: Color.black, hcLight: '#292929' }, nls.localize('textSeparatorForeground', "Color for text separators.")); export const textLinkForeground = registerColor('textLink.foreground', { light: '#006AB1', dark: '#3794FF', hcDark: '#3794FF', hcLight: '#0F4A85' }, nls.localize('textLinkForeground', "Foreground color for links in text.")); export const textLinkActiveForeground = registerColor('textLink.activeForeground', { light: '#006AB1', dark: '#3794FF', hcDark: '#3794FF', hcLight: '#0F4A85' }, nls.localize('textLinkActiveForeground', "Foreground color for links in text when clicked on and on mouse hover.")); <del> export const textPreformatForeground = registerColor('textPreformat.foreground', { light: '#A31515', dark: '#D7BA7D', hcDark: '#000000', hcLight: '#FFFFFF' }, nls.localize('textPreformatForeground', "Foreground color for preformatted text segments.")); </del> <ins> export const textPreformatForeground = registerColor('textPreformat.foreground', { light: '#A31515', dark: '#D7BA7D', hcDark: '#D7BA7D', hcLight: '#292929' }, nls.localize('textPreformatForeground', "Foreground color for preformatted text segments.")); </ins> export const textPreformatBackground = registerColor('textPreformat.background', { light: '#0000001A', dark: '#FFFFFF1A', hcDark: '#FFFFFF', hcLight: '#09345f' }, nls.localize('textPreformatBackground', "Background color for preformatted text segments.")); export const textBlockQuoteBackground = registerColor('textBlockQuote.background', { light: '#f2f2f2', dark: '#222222', hcDark: null, hcLight: '#F2F2F2' }, nls.localize('textBlockQuoteBackground', "Background color for block quotes in text.")); export const textBlockQuoteBorder = registerColor('textBlockQuote.border', { light: '#007acc80', dark: '#007acc80', hcDark: Color.white, hcLight: '#292929' }, nls.localize('textBlockQuoteBorder', "Border color for block quotes in text."));


Question:
Expected ! Actual !
Regressed in
The markdown preview in the chat is also broken for Dark Modern but is fixed by your change: !
And the markdown preview in the settings editor: !
I looked into this some more and have the following findings block rendering is broken for Dark Modern, Light Modern, Dark HC and Light HC What changed: we a new theme token, , adopted it in and , and updated the values for to look good with a different background color But we didn't adopt token for blocks in Markdown previews, which is why is broken for Markdown preview Some options Adopt for blocks in Markdown preview -- this amounts to a rather drastic styling change for Markdown previews ! Revert Revert the change to and drop the usage of so that Markdown preview, chat, and settings UI are in a reasonable state for all themes, which I attempted in
Also affects the Extensions Details page since it is a Markdown preview !
Verification: for Light/Dark Modern and Light/Dark HC, make sure that blocks are properly rendered in Markdown preview, settings UI and chat

font-family: var(--monaco-monospace-font); font-size: 12px; color: var(--vscode-textPreformat-foreground); <del> background-color: var(--vscode-textPreformat-background); </del> padding: 1px 3px; border-radius: 4px; }


Question:
Expected ! Actual !
Regressed in
The markdown preview in the chat is also broken for Dark Modern but is fixed by your change: !
And the markdown preview in the settings editor: !
I looked into this some more and have the following findings block rendering is broken for Dark Modern, Light Modern, Dark HC and Light HC What changed: we a new theme token, , adopted it in and , and updated the values for to look good with a different background color But we didn't adopt token for blocks in Markdown previews, which is why is broken for Markdown preview Some options Adopt for blocks in Markdown preview -- this amounts to a rather drastic styling change for Markdown previews ! Revert Revert the change to and drop the usage of so that Markdown preview, chat, and settings UI are in a reasonable state for all themes, which I attempted in
Also affects the Extensions Details page since it is a Markdown preview !
Verification: for Light/Dark Modern and Light/Dark HC, make sure that blocks are properly rendered in Markdown preview, settings UI and chat

font-family: var(--monaco-monospace-font); font-size: 11px; color: var(--vscode-textPreformat-foreground); <del> background-color: var(--vscode-textPreformat-background); </del> padding: 1px 3px; border-radius: 4px; }


Question:
Expected ! Actual !
Regressed in
The markdown preview in the chat is also broken for Dark Modern but is fixed by your change: !
And the markdown preview in the settings editor: !
I looked into this some more and have the following findings block rendering is broken for Dark Modern, Light Modern, Dark HC and Light HC What changed: we a new theme token, , adopted it in and , and updated the values for to look good with a different background color But we didn't adopt token for blocks in Markdown previews, which is why is broken for Markdown preview Some options Adopt for blocks in Markdown preview -- this amounts to a rather drastic styling change for Markdown previews ! Revert Revert the change to and drop the usage of so that Markdown preview, chat, and settings UI are in a reasonable state for all themes, which I attempted in
Also affects the Extensions Details page since it is a Markdown preview !
Verification: for Light/Dark Modern and Light/Dark HC, make sure that blocks are properly rendered in Markdown preview, settings UI and chat

font-family: var(--monaco-monospace-font); font-size: 12px; color: var(--vscode-textPreformat-foreground); <del> background-color: var(--vscode-textPreformat-background); </del> padding: 2px 5px; border-radius: 4px; }


Question:
VS Code version: Code - Insiders 1.84.0-insider (, 2023-10-27T10:41:08.734Z) OS version: WindowsNT x64 10.0. Try applying these variables using the environment collection API: Even though screenshot says they're applied as expected: ! equal sign is stripped from the end when printing the value: ! <details<summaryOriginal bug report </summary<pfrom dotenv import loaddotenv; import os with open(".env", "r") as f: f.readlines() ("TESTKEY") ("TESTKEY2") ("TESTKEY3") ("TESTKEY_4") envFile: "<placeholder" venvPath: "<placeholder" venvFolders: "<placeholder" languageServer: "Pylance" testing • unittestEnabled: true experiments • optInto: ["pythonTerminalEnvVarActivation"] </p</details
! Showing the environment variables have the '=' after I unset Python: Env File ! Showing the environment variables do not have '=' sign if loaded from the Python extension
Thanks for the bug report! We investigate issues in order based on priority and severity, which includes the impact it has on your ability to use the extension to do productive work, and the number of people affected. If other users come forward and leave a comment demonstrating they are seeing/reproducing the problem then we will raise this issue's priority. Thanks for understanding and the patience!
Thank you. I'm adding some more information if it can be useful in finding the problem. I cleared the python extension cache after re-setting the "Env File" setting, because I noticed it was loading a cached value. ! Note that when reading here in the trace log, the environment variable KEY2 has the equal sign at the end, and it's in a different color. The equal sign is also in the output of ".vscode-insiders/extensions/ms-" As far as I can tell the parsing code at is correct, and captures all the equal signs in the key. Hence the sign appears in all of the logs in the output tab, it's just not there in the terminal and/or python if the .env file is loaded by the extension: ! Last, I don't know if it's related, I'm getting the following debug messages from the Pylance extension:
Thanks, I'm able to reproduce it. Looks like an issue with environment collection API in VS Code itself, hence transferring.
This makes sense as we currently split on and so those characters won't work currently when applied via shell integration: For pwsh:
I have this issue too. I noticed if I run my backend server (which takes a secret key from the .env file) in my system terminal it behaves as expected, but if I run it in the vscode terminal it truncates the key after the equals sign in the key. This broke my backend! Please fix this. Thanks.
I face this issue too. Waiting for fixing. Thanks As a potential workaround, you can run the command directly from the terminal after every .env file changes for each terminal window
I am having the same issue when the project is setup for a C++ python extension with leak sanitizers. This requires to the sanitizer library and disable leak detection via . Unfortunately, in the terminal only remains which yields to a unusable terminal due to See
I am also experiencing this issue with a Django Secret key containing an '=' sign and would appreciate a fix. I can work around it, but it's not ideal since this runs counter to the expected behavior and how the command behaves. Thank you.
This so frustrating. I had my code working perfectly I was testing the whole day and then suddenly it broke. I spent hours figuring it out. I managed to debug it and found that the == signs in the .env variables were stripped out. I was so confused why did it work earlier and then I realised that a new version of VS Code was installed today. Did it break my code?Not 100% sure . Anyway VS Code is awesome. But the lesson of the day : stable environment . Don't update it constantly.
I'm facing the same issue. Here are some potential clues based on my project: it only occurs in the init constructor for a class. The class is located in a .py that is in a different folder than the .env. The error occurs when the code is invoked from an api endpoint but works fine otherwise. I tried making adjustments by setting the .env path explicitly but no luck. Please help.
Adding my use case: Azure services often have a connection string that's used when coding some integration and said strings usually have the '=' in them, For me, the problem can be mitigated if I leave the python.envFile config value empty, but it is a bit annoying that this "automatic" feature is somewhat hidden
Can confirm that I am also seeing this behavior in the exact same situation. VSCode Terminal - drops "=" ! Plain Terminal - returns correct !
Verification steps: Create an extension that does: Debug the extension Activate it Open a powershell terminal Run , ensure that it prints Repeat the same in a bash terminal but run
This still had an issue for fish shell which should be fixed in To verify, repeat steps above but for fish.
verified bash/fish/zsh

IFS=':' read -ra ADDR <<< "$VSCODE_ENV_REPLACE" for ITEM in "${ADDR[@]}"; do VARNAME="$(echo $ITEM | cut -d "=" -f 1)" <del> VALUE="$(echo -e "$ITEM" | cut -d "=" -f 2)" </del> <ins> VALUE="$(echo -e "$ITEM" | cut -d "=" -f 2-)" </ins> export $VARNAME="$VALUE" done builtin unset VSCODE_ENV_REPLACE