diff
stringlengths
65
26.7k
message
stringlengths
7
9.92k
diff --git a/lib/contacts/gmail.rb b/lib/contacts/gmail.rb index abc1234..def5678 100644 --- a/lib/contacts/gmail.rb +++ b/lib/contacts/gmail.rb @@ -18,9 +18,18 @@ @contacts = feed.elements.to_a('entry').collect do |entry| title, email = entry.elements['title'].text, nil + primary_email = ...
Use other Gmail emails if primary there is no primary
diff --git a/browscapper.gemspec b/browscapper.gemspec index abc1234..def5678 100644 --- a/browscapper.gemspec +++ b/browscapper.gemspec @@ -20,10 +20,10 @@ s.homepage = "http://github.com/dark-panda/browscapper" s.require_paths = ["lib"] - s.add_dependency("rdoc") - s.add_dependency("rake", ["~> 0.9"]) - s.a...
Make these gems into development dependencies.
diff --git a/spec/oga/xpath/parser/predicates_spec.rb b/spec/oga/xpath/parser/predicates_spec.rb index abc1234..def5678 100644 --- a/spec/oga/xpath/parser/predicates_spec.rb +++ b/spec/oga/xpath/parser/predicates_spec.rb @@ -10,7 +10,11 @@ s( :node_test, s(:name, nil, 'foo'), - ...
Use (name) nodes for @foo axes.
diff --git a/spec/quickeebooks/online/invoice_spec.rb b/spec/quickeebooks/online/invoice_spec.rb index abc1234..def5678 100644 --- a/spec/quickeebooks/online/invoice_spec.rb +++ b/spec/quickeebooks/online/invoice_spec.rb @@ -10,4 +10,28 @@ invoice.line_items.count.should == 1 invoice.line_items.first.unit_pric...
Online::Invoice: Test that id and sales_term_id are nil if not present
diff --git a/lib/github_cli/cli.rb b/lib/github_cli/cli.rb index abc1234..def5678 100644 --- a/lib/github_cli/cli.rb +++ b/lib/github_cli/cli.rb @@ -6,6 +6,19 @@ module GithubCLI class CLI < ::Thor + include Thor::Actions + + def initialize(*args) + super + say <<-TEXT + +Github CLI client + + ...
Initialize shell and describe options.
diff --git a/app/models/site_comment.rb b/app/models/site_comment.rb index abc1234..def5678 100644 --- a/app/models/site_comment.rb +++ b/app/models/site_comment.rb @@ -14,6 +14,8 @@ # class SiteComment < ActiveRecord::Base + attr_accessible :name, :email, :body, :context_url, :context_data + belongs_to :user ...
Add attr_accessible for site comments, and don't allow viewed_at to be set on new record creation.
diff --git a/lib/mocha-on-bacon.rb b/lib/mocha-on-bacon.rb index abc1234..def5678 100644 --- a/lib/mocha-on-bacon.rb +++ b/lib/mocha-on-bacon.rb @@ -13,11 +13,11 @@ alias_method :it_before_mocha, :it - def it(description) + def it(description, &block) it_before_mocha(description) do ...
Work around a bug in MacRuby where yield can't be used from a block.
diff --git a/lib/pariah/dataset.rb b/lib/pariah/dataset.rb index abc1234..def5678 100644 --- a/lib/pariah/dataset.rb +++ b/lib/pariah/dataset.rb @@ -29,17 +29,20 @@ r = conn.get(path: '_cluster/health') raise "Bad Elasticsearch connection!" unless r.status == 200 - conn.put \ - path: ...
Check the status of the initial index setup.
diff --git a/lib/solidus_affirm.rb b/lib/solidus_affirm.rb index abc1234..def5678 100644 --- a/lib/solidus_affirm.rb +++ b/lib/solidus_affirm.rb @@ -1,5 +1,5 @@ require 'solidus_core' +require "solidus_support" require 'solidus_affirm/engine' require 'solidus_affirm/callback_hook/base' require 'solidus_affirm/affirm...
Move solidus_support require before the engine This allows to use solidus support stuff into the engine file.
diff --git a/sinatra-activerecord.gemspec b/sinatra-activerecord.gemspec index abc1234..def5678 100644 --- a/sinatra-activerecord.gemspec +++ b/sinatra-activerecord.gemspec @@ -8,7 +8,7 @@ gem.summary = gem.description gem.homepage = "http://github.com/janko-m/sinatra-activerecord" - gem.author =...
Put back Mizerany's as gem's author
diff --git a/lib/tasks/legacy.rake b/lib/tasks/legacy.rake index abc1234..def5678 100644 --- a/lib/tasks/legacy.rake +++ b/lib/tasks/legacy.rake @@ -1,6 +1,6 @@ namespace :legacy do desc 'Load legacy data into database' - task :load do + task :load => :environment do legacy_file = File.join(Rails.root, 'db', ...
Make rake task load environment
diff --git a/lib/tasks/resque.rake b/lib/tasks/resque.rake index abc1234..def5678 100644 --- a/lib/tasks/resque.rake +++ b/lib/tasks/resque.rake @@ -1,4 +1,8 @@ #!/usr/bin/env ruby # vim: et ts=2 sw=2 -require "resque/tasks"+require "resque/tasks" + +task "resque:setup"=>:environment do + Grit::Git.git_timeout = 10...
Extend the git timeout for background jobs.
diff --git a/spec/features/ct101s_spec.rb b/spec/features/ct101s_spec.rb index abc1234..def5678 100644 --- a/spec/features/ct101s_spec.rb +++ b/spec/features/ct101s_spec.rb @@ -6,4 +6,10 @@ page.driver.browser.switch_to.alert.accept expect(page).to have_content("Clinical Trials 101") end + scenario "render...
Add test for rendering CT101 content after toggle
diff --git a/spec/unit/choice/eql_spec.rb b/spec/unit/choice/eql_spec.rb index abc1234..def5678 100644 --- a/spec/unit/choice/eql_spec.rb +++ b/spec/unit/choice/eql_spec.rb @@ -16,6 +16,11 @@ not_to eq(described_class.new(:large, 2)) end + it "is false with different key attribute" do + expect(described_...
Add test to ensure choice equality considers key attribute
diff --git a/lib/calyx/production/concat.rb b/lib/calyx/production/concat.rb index abc1234..def5678 100644 --- a/lib/calyx/production/concat.rb +++ b/lib/calyx/production/concat.rb @@ -6,6 +6,13 @@ END_TOKEN = '}'.freeze DEREF_TOKEN = '.'.freeze + # Parses an interpolated string into fragments combi...
Add method comments to `Production::Concat` source
diff --git a/lib/devise_invitable/schema.rb b/lib/devise_invitable/schema.rb index abc1234..def5678 100644 --- a/lib/devise_invitable/schema.rb +++ b/lib/devise_invitable/schema.rb @@ -16,7 +16,6 @@ # change_table :the_resources do |t| # t.string :invitation_token, :limit => 60 # t.datetime :i...
Remove example about non existent feature
diff --git a/lib/multi_site/rails/routes.rb b/lib/multi_site/rails/routes.rb index abc1234..def5678 100644 --- a/lib/multi_site/rails/routes.rb +++ b/lib/multi_site/rails/routes.rb @@ -10,6 +10,13 @@ class MultiSiteConstraints def matches?(request) - Site.exists?(:id => request.path_parameters[:multi_site]) + ...
Revert previous change. Handling Devise special case
diff --git a/lib/payroll_hero/api/errors.rb b/lib/payroll_hero/api/errors.rb index abc1234..def5678 100644 --- a/lib/payroll_hero/api/errors.rb +++ b/lib/payroll_hero/api/errors.rb @@ -9,11 +9,11 @@ class ServerReturnedError < GenericError def initialize(code, message) @code = code - ...
Fix error inheritance so that it's catchable by default.
diff --git a/lib/tasks/tkh_menus_tasks.rake b/lib/tasks/tkh_menus_tasks.rake index abc1234..def5678 100644 --- a/lib/tasks/tkh_menus_tasks.rake +++ b/lib/tasks/tkh_menus_tasks.rake @@ -1,4 +1,13 @@-# desc "Explaining what the task does" -# task :tkh_menus do -# # Task goes here -# end +namespace :tkh_menus do + desc...
Set up basic rake tasks.
diff --git a/lib/tech_docs_html_renderer.rb b/lib/tech_docs_html_renderer.rb index abc1234..def5678 100644 --- a/lib/tech_docs_html_renderer.rb +++ b/lib/tech_docs_html_renderer.rb @@ -14,4 +14,23 @@ </table> </div>) end + + def header(text, header_level) + %(<h#{header_level} id="#{githubify_fragment...
Fix issue with in-document links Documents imported from the publishing-api/docs folder have a table-of-contents which doesn't work here. The documents are published on github, and made available here. Due to a mismatch in Markdown -> HTML rendering between Github and Middleman/Redcarpet, generated fragment IDs are c...
diff --git a/config/routes.rb b/config/routes.rb index abc1234..def5678 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -9,7 +9,6 @@ delete '/vote/:id', to: 'votes#destroy', as: 'vote_delete' resources :users, only: [:show, :edit, :update, :delete] - # patch '/users/:id', to: 'users#update', as: 'users_...
Delete patch route for users
diff --git a/config/routes.rb b/config/routes.rb index abc1234..def5678 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -7,7 +7,7 @@ resources :newsitems, only: [:show], path: '/' end - scope '/api/v1', format: true, constraints: { format: 'json' } do + scope '/i', format: true, constraints: { format...
Move API url to `/i'
diff --git a/config/routes.rb b/config/routes.rb index abc1234..def5678 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -25,6 +25,7 @@ root :to => 'home#index' get 'map' => 'home#map' get 'new' => 'home#new' + get 'new/*all' => 'home#new' get 'contact' => 'contact_messages#new' get 'terms' => 'te...
Add wildcard route that sends all /new url to the SPA to enable client-side routing.
diff --git a/lib/barcade/scraper.rb b/lib/barcade/scraper.rb index abc1234..def5678 100644 --- a/lib/barcade/scraper.rb +++ b/lib/barcade/scraper.rb @@ -22,6 +22,7 @@ post = agent.get("#{BASE_URI}#{self.date_slug}") rescue Mechanize::ResponseCodeError => e puts "Today's tap hasn't been posted ye...
Add exit to stop execution if tap isn't available.
diff --git a/lib/calyx/modifiers.rb b/lib/calyx/modifiers.rb index abc1234..def5678 100644 --- a/lib/calyx/modifiers.rb +++ b/lib/calyx/modifiers.rb @@ -1,5 +1,15 @@ module Calyx class Modifiers + # Transforms an output string by delegating to the given output function. + # + # If a registered modifier meth...
Add method comments to `Modifiers` source
diff --git a/lib/dataly/importer.rb b/lib/dataly/importer.rb index abc1234..def5678 100644 --- a/lib/dataly/importer.rb +++ b/lib/dataly/importer.rb @@ -49,7 +49,7 @@ end def csv - CSV.read(@filename, headers: true) + CSV.read(@filename, { headers: true, encoding: 'utf-8' }) end end end
Set default encoding for csv file.
diff --git a/lib/detect_language.rb b/lib/detect_language.rb index abc1234..def5678 100644 --- a/lib/detect_language.rb +++ b/lib/detect_language.rb @@ -38,7 +38,7 @@ end def user_status - client.post('user/status') + client.get('user/status') end def languages
Use GET method to fetch user status
diff --git a/lib/middleware/base.rb b/lib/middleware/base.rb index abc1234..def5678 100644 --- a/lib/middleware/base.rb +++ b/lib/middleware/base.rb @@ -1,4 +1,6 @@ # -*- encoding : utf-8 -*- +require "forwardable" + # The base middleware class works just like a Tracksperanto::Export::Base, but it only wraps another e...
Use Forwardable to define Middleware methods
diff --git a/lib/web_game_engine.rb b/lib/web_game_engine.rb index abc1234..def5678 100644 --- a/lib/web_game_engine.rb +++ b/lib/web_game_engine.rb @@ -8,16 +8,12 @@ end def versus_user(current_board, player, user_input) - if current_board.valid_move?(user_input) - current_board = player.user_move(curre...
Refactor to take out duplicate checking of validmove
diff --git a/lib/yogo/schema_app.rb b/lib/yogo/schema_app.rb index abc1234..def5678 100644 --- a/lib/yogo/schema_app.rb +++ b/lib/yogo/schema_app.rb @@ -14,7 +14,7 @@ { :content => env['yogo.schema'] }.to_json end - post '/schema' do + post '/schema/?' do opts = Schema.parse_json(request.body....
Make the slash in schema/ optional
diff --git a/lib/avro2kafka.rb b/lib/avro2kafka.rb index abc1234..def5678 100644 --- a/lib/avro2kafka.rb +++ b/lib/avro2kafka.rb @@ -14,11 +14,14 @@ @options = options end + def reader + ARGF.lineno = 0 + ARGF + end + def publish - File.open(input_path, 'r') do |file| - records = AvroReader....
Use ARGF to read the avro file
diff --git a/test/changelog_test.rb b/test/changelog_test.rb index abc1234..def5678 100644 --- a/test/changelog_test.rb +++ b/test/changelog_test.rb @@ -14,12 +14,12 @@ end end - def test_entry_does_not_end_with_a_punctuation + def test_entry_does_end_with_a_punctuation lines = @changelog.each_line ...
Update test to assert line does end with punctuation
diff --git a/lib/active_model/validations/ip_validator.rb b/lib/active_model/validations/ip_validator.rb index abc1234..def5678 100644 --- a/lib/active_model/validations/ip_validator.rb +++ b/lib/active_model/validations/ip_validator.rb @@ -2,18 +2,23 @@ module Validations class IpValidator < EachValidator ...
Add validity check standard to IPValidator and refactor
diff --git a/lib/generators/pay_fu/templates/migration.rb b/lib/generators/pay_fu/templates/migration.rb index abc1234..def5678 100644 --- a/lib/generators/pay_fu/templates/migration.rb +++ b/lib/generators/pay_fu/templates/migration.rb @@ -7,7 +7,7 @@ t.string :payment_status t.datetime :payment_date ...
Use TEXT field to store raw_post data
diff --git a/lib/opskit/cli.rb b/lib/opskit/cli.rb index abc1234..def5678 100644 --- a/lib/opskit/cli.rb +++ b/lib/opskit/cli.rb @@ -6,9 +6,9 @@ class OdinSon < Thor class_option :dry, type: :boolean - desc "render TEMPLATE [CONF]", "generate apache vhost for TEMPLATE with [CONF] ." - def render(template...
Remove conf parameter for render method
diff --git a/lib/tasks/db.rake b/lib/tasks/db.rake index abc1234..def5678 100644 --- a/lib/tasks/db.rake +++ b/lib/tasks/db.rake @@ -27,3 +27,7 @@ Rake::Task["db:create"].enhance do Rake::Task["db:create_schemas"].invoke if using_postgres? end + +Rake::Task["db:migrate"].enhance do + Rake::Task["db:create_schemas"...
Create DB schemas when migrating as well
diff --git a/lib/vai/config.rb b/lib/vai/config.rb index abc1234..def5678 100644 --- a/lib/vai/config.rb +++ b/lib/vai/config.rb @@ -2,6 +2,7 @@ module Vai class Config < Vagrant.plugin("2", :config) attr_accessor :inventory_dir + attr_accessor :inventory_filename attr_accessor :groups ...
Add forgotten attr_accessor to inventory_filename
diff --git a/app/controllers/admin/metrics_controller.rb b/app/controllers/admin/metrics_controller.rb index abc1234..def5678 100644 --- a/app/controllers/admin/metrics_controller.rb +++ b/app/controllers/admin/metrics_controller.rb @@ -1,3 +1,5 @@+require 'sidekiq/testing/inline' if ENV['DEBUG'] + class Admin::Metric...
Move Sidekiq inline requirement for debugging Since the perform_async call has changed class I had to move the inline requirement if the DEBUG environment variable is set, too. Now debugging of Sidekiq worker is possible again. Signed-off-by: Konrad Reiche <4ff0213f56e2082fcd8c882d04c546881c579ce4@gmail.com>
diff --git a/app/controllers/api/v1/search_controller.rb b/app/controllers/api/v1/search_controller.rb index abc1234..def5678 100644 --- a/app/controllers/api/v1/search_controller.rb +++ b/app/controllers/api/v1/search_controller.rb @@ -33,7 +33,9 @@ end def cache_key(scope) - "#{scope.to_sql}-#{s...
Use hexdigest for cache key. To make the cache key small. Problems can arise if the cache key is too long.
diff --git a/app/decorators/models/artefact_decorator.rb b/app/decorators/models/artefact_decorator.rb index abc1234..def5678 100644 --- a/app/decorators/models/artefact_decorator.rb +++ b/app/decorators/models/artefact_decorator.rb @@ -3,5 +3,6 @@ "course", "news", "person" - ] + ], + 'whitehall' => [...
Include empty whitehall array in formats list So that GDS validators can work.
diff --git a/core/io/pos_spec.rb b/core/io/pos_spec.rb index abc1234..def5678 100644 --- a/core/io/pos_spec.rb +++ b/core/io/pos_spec.rb @@ -6,27 +6,6 @@ it_behaves_like :io_pos, :pos end -describe "IO#pos" do - before :each do - @fname = tmp('pos-text.txt') - File.open @fname, 'w' do |f| f.write "123" end ...
Remove spec depending on platform-dependent behavior from ungetc/lseek.
diff --git a/common_spree_dependencies.rb b/common_spree_dependencies.rb index abc1234..def5678 100644 --- a/common_spree_dependencies.rb +++ b/common_spree_dependencies.rb @@ -23,18 +23,10 @@ gem 'email_spec', '1.4.0' gem 'factory_girl_rails', '~> 4.4.0' gem 'launchy' + gem 'pry' gem 'rspec-rails', '~> 2.1...
Revert "Add pry and pry debuggers to common spree dependencies" This reverts commit 7c367d5ca0e2f293813278a0e37d9f731aa8befb. CI breaks with these errors: (lack of ruby 2.1 apparently) [03:52:55][Step 1/1] in directory: /mnt/72aec43634788be0/core [03:52:55][Step 1/1] `ruby_21` is not a valid platform. The availa...
diff --git a/db/migrate/20171211111544_change_order_to_integer.rb b/db/migrate/20171211111544_change_order_to_integer.rb index abc1234..def5678 100644 --- a/db/migrate/20171211111544_change_order_to_integer.rb +++ b/db/migrate/20171211111544_change_order_to_integer.rb @@ -1,6 +1,17 @@ class ChangeOrderToInteger < Activ...
Add down to change order migration
diff --git a/fuji.gemspec b/fuji.gemspec index abc1234..def5678 100644 --- a/fuji.gemspec +++ b/fuji.gemspec @@ -2,7 +2,7 @@ require File.expand_path('../lib/fuji/version', __FILE__) Gem::Specification.new do |gem| - gem.authors = ["Zeke Sikelianos", "Max Shoening", "Dominic Dagradi"] + gem.authors = [...
Fix name in gem authors
diff --git a/cassandra_object.gemspec b/cassandra_object.gemspec index abc1234..def5678 100644 --- a/cassandra_object.gemspec +++ b/cassandra_object.gemspec @@ -1,6 +1,6 @@ Gem::Specification.new do |s| s.name = 'cassandra_object' - s.version = '0.5.0' + s.version = '0.5.0.pre' s.email = "michael@koziarski...
Make this a pre-release as it depends on another prerelease
diff --git a/core/file/initialize_spec.rb b/core/file/initialize_spec.rb index abc1234..def5678 100644 --- a/core/file/initialize_spec.rb +++ b/core/file/initialize_spec.rb @@ -2,6 +2,14 @@ describe "File#initialize" do it "needs to be reviewed for spec completeness" +end + +ruby_version_is '1.8' do + describe "F...
Add spec for ignoring encoding options in 1.8
diff --git a/rubyapi.gemspec b/rubyapi.gemspec index abc1234..def5678 100644 --- a/rubyapi.gemspec +++ b/rubyapi.gemspec @@ -10,7 +10,7 @@ gem.homepage = "https://github.com/Burgestrand/rubyapi" gem.files = `git ls-files`.split("\n") - gem.test_files = `git ls-files -- {test,spec,features}/*`.sp...
Add test files to gemspec explicitly
diff --git a/rails/definitions/rails_app.rb b/rails/definitions/rails_app.rb index abc1234..def5678 100644 --- a/rails/definitions/rails_app.rb +++ b/rails/definitions/rails_app.rb @@ -20,7 +20,7 @@ group grp action params[:action] migration_command "rake db:migrate" - environment node[:rails][:environ...
Set the environment the new-style way
diff --git a/lib/odata/create_operation.rb b/lib/odata/create_operation.rb index abc1234..def5678 100644 --- a/lib/odata/create_operation.rb +++ b/lib/odata/create_operation.rb @@ -20,7 +20,7 @@ # If a belongs to field, add association the way OData wants it if @ar.class.belongs_to_field?(field) ...
Use table name for binding name
diff --git a/lib/percy/client/resources.rb b/lib/percy/client/resources.rb index abc1234..def5678 100644 --- a/lib/percy/client/resources.rb +++ b/lib/percy/client/resources.rb @@ -10,12 +10,17 @@ attr_accessor :resource_url attr_accessor :is_root attr_accessor :mimetype + attr_accessor :conten...
Add ability to hold content in Resource container.
diff --git a/recipes/geminstall.rb b/recipes/geminstall.rb index abc1234..def5678 100644 --- a/recipes/geminstall.rb +++ b/recipes/geminstall.rb @@ -1,4 +1,4 @@-node.set['build_essential']['compile_time'] = true +node.set['build-essential']['compile_time'] = true include_recipe 'build-essential' node['augeas']['pac...
Use build-essential instead of build_essential WARN: node['build_essential'] has been changed to node['build-essential'] to match the cookbook name and community standards. I have gracefully converted the attribute for you, but this warning and conversion will be removed in the next major release of the build-essentia...
diff --git a/scripts/puma.rb b/scripts/puma.rb index abc1234..def5678 100644 --- a/scripts/puma.rb +++ b/scripts/puma.rb @@ -11,5 +11,5 @@ unless ENV['DOCKERIZED'] stdout_redirect root + 'log/puma.log', root + 'log/puma.err.log', true end -threads 8, 32 -workers 3 +threads 4, 32 +workers 1
Reduce worker load per container instance
diff --git a/app/controllers/container_project_controller.rb b/app/controllers/container_project_controller.rb index abc1234..def5678 100644 --- a/app/controllers/container_project_controller.rb +++ b/app/controllers/container_project_controller.rb @@ -8,6 +8,7 @@ after_action :set_session_data def show_list + ...
Fix project main page showtype
diff --git a/app/helpers/application_helper/toolbar/basic.rb b/app/helpers/application_helper/toolbar/basic.rb index abc1234..def5678 100644 --- a/app/helpers/application_helper/toolbar/basic.rb +++ b/app/helpers/application_helper/toolbar/basic.rb @@ -1,19 +1,14 @@ class ApplicationHelper::Toolbar::Basic include Si...
Implement a simple toolbar definition DSL.
diff --git a/app/services/rails_workflow/process_importer.rb b/app/services/rails_workflow/process_importer.rb index abc1234..def5678 100644 --- a/app/services/rails_workflow/process_importer.rb +++ b/app/services/rails_workflow/process_importer.rb @@ -1,6 +1,9 @@ module RailsWorkflow class ProcessImporter def ...
Allow for operations to be embedded alongside (instead of inside) process templates in JSON exports of a Process
diff --git a/lib/active_relation_tracer/active_relation_tracer.rb b/lib/active_relation_tracer/active_relation_tracer.rb index abc1234..def5678 100644 --- a/lib/active_relation_tracer/active_relation_tracer.rb +++ b/lib/active_relation_tracer/active_relation_tracer.rb @@ -4,36 +4,20 @@ extend ActiveSupport::Concern ...
Refactor with wrap_method module method
diff --git a/lib/generators/headshot/install/install_generator.rb b/lib/generators/headshot/install/install_generator.rb index abc1234..def5678 100644 --- a/lib/generators/headshot/install/install_generator.rb +++ b/lib/generators/headshot/install/install_generator.rb @@ -23,6 +23,11 @@ say_status('copying', 'C...
Revert "Removed registration of Paperclip." This reverts commit 650db1e79ceb81af4db950302686c88ba29ea8d6.
diff --git a/lib/rdstation/error_handler/invalid_refresh_token.rb b/lib/rdstation/error_handler/invalid_refresh_token.rb index abc1234..def5678 100644 --- a/lib/rdstation/error_handler/invalid_refresh_token.rb +++ b/lib/rdstation/error_handler/invalid_refresh_token.rb @@ -10,7 +10,8 @@ end def raise_erro...
Fix blank? method called for nil
diff --git a/test/controllers/rails_invitable/api/v1/user_accepted_referrals_controller_test.rb b/test/controllers/rails_invitable/api/v1/user_accepted_referrals_controller_test.rb index abc1234..def5678 100644 --- a/test/controllers/rails_invitable/api/v1/user_accepted_referrals_controller_test.rb +++ b/test/controlle...
Fix the initiatial controller test
diff --git a/JROFBridge.podspec b/JROFBridge.podspec index abc1234..def5678 100644 --- a/JROFBridge.podspec +++ b/JROFBridge.podspec @@ -11,7 +11,7 @@ s.source = { :git => "https://github.com/jyruzicka/JROFBridge.git", :tag => s.version.to_s } s.social_media_url = 'https://twitter.com/akchizar' - s.os...
Drop deployment target to 10.9
diff --git a/cookbooks/sys_dns/recipes/do_set_private.rb b/cookbooks/sys_dns/recipes/do_set_private.rb index abc1234..def5678 100644 --- a/cookbooks/sys_dns/recipes/do_set_private.rb +++ b/cookbooks/sys_dns/recipes/do_set_private.rb @@ -22,7 +22,7 @@ if ! node.has_key?('cloud') private_ip = "#{local_ip}" else - pr...
Fix error on private_ip var ref.
diff --git a/spec/lib/i18n/core_ext_spec.rb b/spec/lib/i18n/core_ext_spec.rb index abc1234..def5678 100644 --- a/spec/lib/i18n/core_ext_spec.rb +++ b/spec/lib/i18n/core_ext_spec.rb @@ -11,7 +11,7 @@ I18n.backend.instance_variable_get(:@translations) end - before { I18n.backend = Simple.new }...
Change Simple.new to be fully namespaced for understandability's sake
diff --git a/spec/unit/proxy_object_spec.rb b/spec/unit/proxy_object_spec.rb index abc1234..def5678 100644 --- a/spec/unit/proxy_object_spec.rb +++ b/spec/unit/proxy_object_spec.rb @@ -37,4 +37,14 @@ it 'does not respond unknown method names' do expect(proxy).not_to respond_to(:no_idea_what_you_want) end + + ...
Add a test for multi-level proxying
diff --git a/ibge.gemspec b/ibge.gemspec index abc1234..def5678 100644 --- a/ibge.gemspec +++ b/ibge.gemspec @@ -21,5 +21,5 @@ spec.add_dependency "spreadsheet", "~> 1.0" spec.add_development_dependency "rake", "~> 13.0" - spec.add_development_dependency "rspec", "= 3.9.0" + spec.add_development_dependency "rs...
Update rspec requirement from = 3.9.0 to = 3.10.0 Updates the requirements on [rspec](https://github.com/rspec/rspec) to permit the latest version. - [Release notes](https://github.com/rspec/rspec/releases) - [Commits](https://github.com/rspec/rspec/compare/v3.9.0...v3.10.0) Signed-off-by: dependabot-preview[bot] <5b...
diff --git a/WiremockClient.podspec b/WiremockClient.podspec index abc1234..def5678 100644 --- a/WiremockClient.podspec +++ b/WiremockClient.podspec @@ -13,6 +13,7 @@ s.source = { :git => 'https://github.com/mobileforming/WiremockClient.git', :tag => '1.2.1' } s.ios.deployment_target = '9.0' s.osx.dep...
Add swift version to podspec
diff --git a/lib/feedjira/preprocessor.rb b/lib/feedjira/preprocessor.rb index abc1234..def5678 100644 --- a/lib/feedjira/preprocessor.rb +++ b/lib/feedjira/preprocessor.rb @@ -22,7 +22,7 @@ end def raw_html(node) - CGI.unescape_html(node.search('./div').first.inner_html) rescue '' + CGI.unescape_h...
Allow multiple div tags, should they occur.
diff --git a/app/services/notes/create_service.rb b/app/services/notes/create_service.rb index abc1234..def5678 100644 --- a/app/services/notes/create_service.rb +++ b/app/services/notes/create_service.rb @@ -3,6 +3,7 @@ def execute note = project.notes.new(params[:note]) note.author = current_user + ...
Make sure note.system is false if created by user Signed-off-by: Dmitriy Zaporozhets <be23d75b156792e5acab51b196a2deb155d35d6a@gmail.com>
diff --git a/tasks/application_generator.rb b/tasks/application_generator.rb index abc1234..def5678 100644 --- a/tasks/application_generator.rb +++ b/tasks/application_generator.rb @@ -29,7 +29,7 @@ env = { 'BUNDLE_GEMFILE' => ENV['BUNDLE_GEMFILE'], 'RAILS_ENV' => rails_env } - Bundler.with_original_...
Raise if subshell fails in application generator
diff --git a/oboe.gemspec b/oboe.gemspec index abc1234..def5678 100644 --- a/oboe.gemspec +++ b/oboe.gemspec @@ -16,14 +16,4 @@ s.test_files = Dir.glob("{spec}/**/*.rb") s.add_development_dependency 'rake' s.add_development_dependency 'rspec' - - s.post_install_message = " - -This oboe gem requires up...
Remove the gem post install message.
diff --git a/app/models/line.rb b/app/models/line.rb index abc1234..def5678 100644 --- a/app/models/line.rb +++ b/app/models/line.rb @@ -4,26 +4,18 @@ validates :person, :body, presence: true - MESSAGE_PATTERNS = [ - /<\s*([^>]+)\s*>\s*(.*)$/, - /([^:]+):\s*(.*)$/ - ] - - ACTION_PATTERNS = [ - /...
Fix the message pattern matching order.
diff --git a/app/models/team.rb b/app/models/team.rb index abc1234..def5678 100644 --- a/app/models/team.rb +++ b/app/models/team.rb @@ -20,11 +20,12 @@ users.include?(user) end - # Add a user to the class. + # Add a user to the team. def enroll(user) self.users << user end + # Remove the user ...
Add a comment explaining the method
diff --git a/app/models/user.rb b/app/models/user.rb index abc1234..def5678 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -1,4 +1,7 @@ class User < ActiveRecord::Base + extend FriendlyId + friendly_id :email, :use => [ :slugged, :history ] + devise :async, :database_authenticatable, :registerable, ...
Update User Model for FriendlyId Slug Update the User model to use the email address as the FriendlyId Slug.
diff --git a/app/models/user.rb b/app/models/user.rb index abc1234..def5678 100644 --- a/app/models/user.rb +++ b/app/models/user.rb @@ -2,10 +2,11 @@ has_secure_password validates :username, :email, presence: true validates :email, uniqueness: true + validates_format_of :email, :with => /\A([^@\s]+)@((?:[-a-z...
Add validation to put a format constraint on email attribute in User class
diff --git a/app/controllers/schools_controller.rb b/app/controllers/schools_controller.rb index abc1234..def5678 100644 --- a/app/controllers/schools_controller.rb +++ b/app/controllers/schools_controller.rb @@ -1,7 +1,5 @@ class SchoolsController < ApplicationController - # skip_before_action :verify_authenticity_tok...
Add additional properties to school so can be used for map
diff --git a/app/helpers/admin/resources_helper.rb b/app/helpers/admin/resources_helper.rb index abc1234..def5678 100644 --- a/app/helpers/admin/resources_helper.rb +++ b/app/helpers/admin/resources_helper.rb @@ -17,9 +17,7 @@ admin_user.application(app_name).each do |resource| klass = resource.constantize...
Revert "Do not use compact" because sidebar was dissapearing. This reverts commit c921747c11deb3fbe6c69025a7952e5ecf00961d.
diff --git a/app/models/spree/product_decorator.rb b/app/models/spree/product_decorator.rb index abc1234..def5678 100644 --- a/app/models/spree/product_decorator.rb +++ b/app/models/spree/product_decorator.rb @@ -18,5 +18,9 @@ end end end + + def sale_off? + !(sale_date.nil? || sale_date.fut...
Add sale off to product scope
diff --git a/test/test_simplecov-console.rb b/test/test_simplecov-console.rb index abc1234..def5678 100644 --- a/test/test_simplecov-console.rb +++ b/test/test_simplecov-console.rb @@ -2,7 +2,17 @@ class TestSimplecovConsole < MiniTest::Test - Source = Struct.new(:line_number) + # mock for SimpleCov::SourceFile::...
Add tests for 'table_output', 'block_output' methods
diff --git a/IssueReporter.podspec b/IssueReporter.podspec index abc1234..def5678 100644 --- a/IssueReporter.podspec +++ b/IssueReporter.podspec @@ -18,6 +18,4 @@ s.resource_bundles = { 'IssueReporterResources' => ['Pod/Assets/*.{png,strings,storyboard}'] } - - s.public_header_files = 'Pod/Classes/**/*.h' e...
Remove public header files specifier as we do not have any header files any more.
diff --git a/fpm-cookery.gemspec b/fpm-cookery.gemspec index abc1234..def5678 100644 --- a/fpm-cookery.gemspec +++ b/fpm-cookery.gemspec @@ -20,7 +20,7 @@ s.add_development_dependency "minitest", "~> 5.0" s.add_development_dependency "rake" - s.add_runtime_dependency "fpm", "~> 0.4" + s.add_runtime_dependency ...
Add support for FPM 1.0.x
diff --git a/calculators/bsa/bsa.rb b/calculators/bsa/bsa.rb index abc1234..def5678 100644 --- a/calculators/bsa/bsa.rb +++ b/calculators/bsa/bsa.rb @@ -1,11 +1,9 @@ name :bsa +require_helpers :get_field_as_float execute do - raise FieldError.new("weight", "weight must be a number") if !field_weight.is_float? -...
Use helper methods for converting fields to floats
diff --git a/0_code_wars/terminal_game_2.rb b/0_code_wars/terminal_game_2.rb index abc1234..def5678 100644 --- a/0_code_wars/terminal_game_2.rb +++ b/0_code_wars/terminal_game_2.rb @@ -0,0 +1,32 @@+# http://www.codewars.com/kata/55e8beb4e8fc5b7697000036/ +# --- iteration 1 --- +class Hero + def initialize + @positi...
Add code wars (7) terminal game 2
diff --git a/webhook-receiver-SUSE_Cloud.rb b/webhook-receiver-SUSE_Cloud.rb index abc1234..def5678 100644 --- a/webhook-receiver-SUSE_Cloud.rb +++ b/webhook-receiver-SUSE_Cloud.rb @@ -0,0 +1,79 @@+#!/usr/bin/ruby +# +# Simple Sinatra (http://www.sinatrarb.com) script that handles Webhooks +# notification from SUSE Stu...
Add first version of the SUSE Cloud / OpenStack webhook receiver
diff --git a/config/initializers/ar_native_database_types.rb b/config/initializers/ar_native_database_types.rb index abc1234..def5678 100644 --- a/config/initializers/ar_native_database_types.rb +++ b/config/initializers/ar_native_database_types.rb @@ -0,0 +1,11 @@+require 'active_record/connection_adapters/abstract_my...
Add bigserial as a native database type for MySQL adapter
diff --git a/lib/arena/connectable.rb b/lib/arena/connectable.rb index abc1234..def5678 100644 --- a/lib/arena/connectable.rb +++ b/lib/arena/connectable.rb @@ -0,0 +1,57 @@+require 'time' + +module Arena + module Connectable + + %w(position selected connection_id).each do |method| + define_method method do + ...
Fix typo for :has_embed? method
diff --git a/lib/tinytable.rb b/lib/tinytable.rb index abc1234..def5678 100644 --- a/lib/tinytable.rb +++ b/lib/tinytable.rb @@ -1,7 +1,7 @@-require "tinytable/version" -require "tinytable/table" -require "tinytable/text_formatter" -require "tinytable/layout" +require 'tinytable/version' +require 'tinytable/table' +req...
Use single instead of double quotes for require paths
diff --git a/import/get_object.rb b/import/get_object.rb index abc1234..def5678 100644 --- a/import/get_object.rb +++ b/import/get_object.rb @@ -20,7 +20,13 @@ rescue OpenURI::HTTPError return nil end - return JSON.parse(object.read, :symbolize_names => true) + + begin + hash = JSON.parse(object.read, :symbolize...
Break if the site begins returning bad data
diff --git a/models/helper.rb b/models/helper.rb index abc1234..def5678 100644 --- a/models/helper.rb +++ b/models/helper.rb @@ -15,7 +15,9 @@ def self.available request=nil, limit=5 request_id = request.present? ? request.id : nil contacted_helpers = HelperRequest.where(:request_id => request_id).fields(:h...
Select only users that have a valid login token
diff --git a/yahoo.gemspec b/yahoo.gemspec index abc1234..def5678 100644 --- a/yahoo.gemspec +++ b/yahoo.gemspec @@ -0,0 +1,38 @@+# -*- encoding: utf-8 -*- + +Gem::Specification.new do |s| + s.name = %q{yahoo} + s.version = "2.0.0" + + s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :requ...
Put the gemspec under revision control.
diff --git a/lib/liner/inspectable.rb b/lib/liner/inspectable.rb index abc1234..def5678 100644 --- a/lib/liner/inspectable.rb +++ b/lib/liner/inspectable.rb @@ -4,9 +4,16 @@ # @return [String] # @api public def inspect - attribute_string = liner.map{|k,v| "#{k}=#{v.inspect}"}.join(', ') "#<#{s...
Move attribute string into it's own method.
diff --git a/config/schedule.rb b/config/schedule.rb index abc1234..def5678 100644 --- a/config/schedule.rb +++ b/config/schedule.rb @@ -19,7 +19,7 @@ # Learn more: http://github.com/javan/whenever -every :weekday, at: '8:00 am' do +every :weekday, at: '9:30 am' do runner 'DailyMenu.gather' end
Gather daily menu data at 9:30
diff --git a/SRMModalViewController.podspec b/SRMModalViewController.podspec index abc1234..def5678 100644 --- a/SRMModalViewController.podspec +++ b/SRMModalViewController.podspec @@ -1,12 +1,12 @@ Pod::Spec.new do |s| s.name = "SRMModalViewController" - s.version = "0.0.2.1" + s.version = "0....
Update .podspec file for version 0.0.2.2
diff --git a/Casks/fourk-video-downloader.rb b/Casks/fourk-video-downloader.rb index abc1234..def5678 100644 --- a/Casks/fourk-video-downloader.rb +++ b/Casks/fourk-video-downloader.rb @@ -0,0 +1,7 @@+class FourkVideoDownloader < Cask + url 'http://4kdownload.googlecode.com/files/4kvideodownloader_2.8.dmg' + homepage...
Add 4K Video Downloader cask
diff --git a/Snaps.podspec b/Snaps.podspec index abc1234..def5678 100644 --- a/Snaps.podspec +++ b/Snaps.podspec @@ -4,7 +4,7 @@ s.description = <<-DESC Snaps combines [Dials](https://github.com/aleffert/dials) and [SnapKit](https://github.com/SnapKit/SnapKit) to let you make changes to your autola...
Tweak summary to pass linter
diff --git a/app/admin/source_suggestion.rb b/app/admin/source_suggestion.rb index abc1234..def5678 100644 --- a/app/admin/source_suggestion.rb +++ b/app/admin/source_suggestion.rb @@ -0,0 +1,57 @@+ActiveAdmin.register SourceSuggestion do + permit_params :source_id, :user_id, :gene_name, :disease_name, :variant_name, ...
Add SourceSuggestions tab to admin interface Closes #266
diff --git a/app/helpers/editable_helper.rb b/app/helpers/editable_helper.rb index abc1234..def5678 100644 --- a/app/helpers/editable_helper.rb +++ b/app/helpers/editable_helper.rb @@ -2,7 +2,7 @@ def editable(object, attribute, options = {}) object_name = ActiveModel::Naming.singular(object) - if optio...
Allow value to be set to blank
diff --git a/app/helpers/tiny_mce_helper.rb b/app/helpers/tiny_mce_helper.rb index abc1234..def5678 100644 --- a/app/helpers/tiny_mce_helper.rb +++ b/app/helpers/tiny_mce_helper.rb @@ -15,7 +15,7 @@ theme_advanced_resizing : true, theme_advanced_resizing_use_cookie : true, theme_advanced_toolbar_location ...
Fix justification to justify-left and select all show up.
diff --git a/spec/support/login.rb b/spec/support/login.rb index abc1234..def5678 100644 --- a/spec/support/login.rb +++ b/spec/support/login.rb @@ -6,7 +6,7 @@ end def current_user - Person.where(email: 'test.user@digital.moj.gov.uk').first + Peoplefinder::Person.where(email: 'test.user@digital.mo...
Use Peoplefinder namespace for mock logged in user
diff --git a/clamp.gemspec b/clamp.gemspec index abc1234..def5678 100644 --- a/clamp.gemspec +++ b/clamp.gemspec @@ -8,7 +8,7 @@ s.platform = Gem::Platform::RUBY s.authors = ["Mike Williams"] s.email = "mdub@dogbiscuit.org" - s.homepage = "http://github.com/mdub/clamp" + s.homepage ...
Use HTTPS in the website gemspec
diff --git a/ApplePayStubs.podspec b/ApplePayStubs.podspec index abc1234..def5678 100644 --- a/ApplePayStubs.podspec +++ b/ApplePayStubs.podspec @@ -8,7 +8,7 @@ s.homepage = "https://github.com/stripe/ApplePayStubs" s.license = { :type => "MIT", :file => "LICENSE.txt" } s.author = { "Stripe" => "...
Make the podspec only require iOS 6.0.
diff --git a/MagicalRecord.podspec b/MagicalRecord.podspec index abc1234..def5678 100644 --- a/MagicalRecord.podspec +++ b/MagicalRecord.podspec @@ -1,11 +1,11 @@ Pod::Spec.new do |s| s.name = 'MagicalRecord' - s.version = '2.2' + s.version = '2.3.0-beta.1' s.license = 'MIT' s.summary = 'Super Awesom...
Update podspec for MR 2.3.0-beta.1