File size: 16,912 Bytes
afa0cbf | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 463 464 465 466 467 468 469 470 471 472 473 474 475 476 477 478 479 480 481 482 483 484 485 486 487 488 489 490 491 492 493 494 495 496 497 498 499 500 501 502 503 504 505 | use super::CodexClient;
use super::loopback_responses_server::LoopbackResponsesServer;
use anyhow::Context;
use anyhow::Result;
use anyhow::bail;
use codex_app_server_protocol::ClientRequest;
use codex_app_server_protocol::ConfigValueWriteParams;
use codex_app_server_protocol::ConfigWriteResponse;
use codex_app_server_protocol::MergeStrategy;
use codex_app_server_protocol::PluginAvailability;
use codex_app_server_protocol::PluginInstalledParams;
use codex_app_server_protocol::PluginInstalledResponse;
use codex_app_server_protocol::ThreadStartParams;
use codex_app_server_protocol::TurnStartParams;
use codex_app_server_protocol::TurnStatus;
use codex_app_server_protocol::UserInput;
use codex_app_server_protocol::WriteStatus;
use serde_json::Value;
use serde_json::json;
use std::ffi::OsString;
use std::fs;
use std::io;
use std::path::Path;
use std::path::PathBuf;
use std::process;
use std::thread;
use std::time::Duration;
use std::time::Instant;
pub(super) const ANALYTICS_CAPTURE_ENV_VAR: &str = "CODEX_ANALYTICS_EVENTS_CAPTURE_FILE";
const TEST_USER_CONFIG_ENV_VAR: &str = "CODEX_APP_SERVER_TEST_USER_CONFIG_FILE";
const CAPTURE_READY_TIMEOUT: Duration = Duration::from_secs(5);
const CAPTURE_TIMEOUT: Duration = Duration::from_secs(10);
const CAPTURE_POLL_INTERVAL: Duration = Duration::from_millis(50);
const PLUGIN_READY_TIMEOUT: Duration = Duration::from_secs(30);
const PLUGIN_READY_RETRY_INTERVAL: Duration = Duration::from_millis(250);
const MOCK_MODEL_SLUG: &str = "plugin-analytics-smoke";
const MOCK_PROVIDER_ID: &str = "plugin_analytics_smoke";
pub(super) fn run(
codex_bin: &Path,
config_overrides: &[String],
plugin_id: &str,
capture_file: Option<PathBuf>,
) -> Result<()> {
let capture_path = capture_file.unwrap_or_else(|| {
std::env::temp_dir().join(format!("codex-plugin-analytics-{}.jsonl", process::id()))
});
prepare_capture_file(&capture_path)?;
let temporary_config = TemporaryConfigFile::create()?;
let responses_server = LoopbackResponsesServer::start()?;
let mut overrides = config_overrides.to_vec();
overrides.extend(smoke_config_overrides(responses_server.base_url())?);
let child_environment = vec![
(
OsString::from(ANALYTICS_CAPTURE_ENV_VAR),
capture_path.as_os_str().to_os_string(),
),
(
OsString::from(TEST_USER_CONFIG_ENV_VAR),
temporary_config.path().as_os_str().to_os_string(),
),
];
let mut client = CodexClient::spawn_stdio_with_env(codex_bin, &overrides, &child_environment)?;
wait_until_capture_is_ready(&capture_path)?;
client.initialize()?;
let installed = plugin_installed(&mut client)?;
let expected = expected_plugin(&installed, plugin_id)?;
write_plugin_enabled(
&mut client,
temporary_config.path(),
plugin_id,
/*enabled*/ false,
)?;
write_plugin_enabled(
&mut client,
temporary_config.path(),
plugin_id,
/*enabled*/ true,
)?;
wait_for_plugin_usage(&mut client, &capture_path, &expected)?;
let events = wait_for_plugin_events(&capture_path, plugin_id)?;
let validated = validate_plugin_events(events, &expected)?;
println!(
"\n[plugin analytics smoke validated]\n{}",
serde_json::to_string_pretty(&validated)?
);
println!("capture file: {}", capture_path.display());
Ok(())
}
fn run_plugin_turn(client: &mut CodexClient, expected: &ExpectedPlugin) -> Result<String> {
let thread = client.thread_start(ThreadStartParams {
model: Some(MOCK_MODEL_SLUG.to_string()),
model_provider: Some(MOCK_PROVIDER_ID.to_string()),
base_instructions: Some(String::new()),
developer_instructions: Some(String::new()),
ephemeral: Some(true),
..Default::default()
})?;
let turn = client.turn_start(TurnStartParams {
thread_id: thread.thread.id.clone(),
client_user_message_id: None,
input: vec![UserInput::Mention {
name: expected.plugin_name.clone(),
path: format!("plugin://{}", expected.plugin_id),
}],
..Default::default()
})?;
client.stream_turn(&thread.thread.id, &turn.turn.id)?;
if client.last_turn_status != Some(TurnStatus::Completed) {
bail!(
"plugin analytics smoke turn did not complete: status={:?}, error={:?}",
client.last_turn_status,
client.last_turn_error_message
);
}
Ok(turn.turn.id)
}
fn wait_for_plugin_usage(
client: &mut CodexClient,
capture_path: &Path,
expected: &ExpectedPlugin,
) -> Result<()> {
let deadline = Instant::now() + PLUGIN_READY_TIMEOUT;
let mut attempts = 0;
loop {
attempts += 1;
let turn_id = run_plugin_turn(client, expected)?;
// Turn completion is queued after plugin usage, so its captured event is the
// barrier that tells us whether this attempt resolved the plugin.
let events = wait_for_turn_analytics(capture_path, &turn_id)?;
if events.iter().any(|event| {
event["event_type"] == "codex_plugin_used"
&& event["event_params"]["turn_id"].as_str() == Some(turn_id.as_str())
&& event["event_params"]["plugin_id"].as_str() == Some(expected.plugin_id.as_str())
}) {
if attempts > 1 {
println!("remote plugin bundle became ready after {attempts} turn attempts");
}
return Ok(());
}
if Instant::now() >= deadline {
bail!(
"timed out waiting for remote plugin bundle `{}` to become usable after {attempts} turn attempts",
expected.plugin_id
);
}
thread::sleep(PLUGIN_READY_RETRY_INTERVAL);
}
}
#[derive(Debug)]
struct ExpectedPlugin {
plugin_id: String,
remote_plugin_id: String,
plugin_name: String,
marketplace_name: String,
}
fn plugin_installed(client: &mut CodexClient) -> Result<PluginInstalledResponse> {
let request_id = client.request_id();
client.send_request(
ClientRequest::PluginInstalled {
request_id: request_id.clone(),
params: PluginInstalledParams {
cwds: None,
install_suggestion_plugin_names: None,
},
},
request_id,
"plugin/installed",
)
}
fn expected_plugin(response: &PluginInstalledResponse, plugin_id: &str) -> Result<ExpectedPlugin> {
let matches = response
.marketplaces
.iter()
.flat_map(|marketplace| {
marketplace
.plugins
.iter()
.filter(move |plugin| plugin.id == plugin_id)
.map(move |plugin| (marketplace, plugin))
})
.collect::<Vec<_>>();
let [(marketplace, plugin)] = matches.as_slice() else {
bail!(
"expected exactly one installed plugin with local id `{plugin_id}`, found {}",
matches.len()
);
};
if !plugin.installed {
bail!("plugin `{plugin_id}` is not installed");
}
if !plugin.enabled {
bail!("plugin `{plugin_id}` is installed remotely but disabled");
}
if plugin.availability != PluginAvailability::Available {
bail!(
"plugin `{plugin_id}` is not available: {:?}",
plugin.availability
);
}
let remote_plugin_id = plugin
.remote_plugin_id
.as_ref()
.with_context(|| format!("plugin `{plugin_id}` does not have a remote plugin id"))?
.clone();
Ok(ExpectedPlugin {
plugin_id: plugin.id.clone(),
remote_plugin_id,
plugin_name: plugin.name.clone(),
marketplace_name: marketplace.name.clone(),
})
}
fn write_plugin_enabled(
client: &mut CodexClient,
config_path: &Path,
plugin_id: &str,
enabled: bool,
) -> Result<()> {
let request_id = client.request_id();
let response: ConfigWriteResponse = client.send_request(
ClientRequest::ConfigValueWrite {
request_id: request_id.clone(),
params: ConfigValueWriteParams {
key_path: format!("plugins.{plugin_id}.enabled"),
value: json!(enabled),
merge_strategy: MergeStrategy::Replace,
file_path: Some(config_path.display().to_string()),
expected_version: None,
},
},
request_id,
"config/value/write",
)?;
println!(
"< config/value/write plugin={plugin_id} enabled={enabled} status={:?}",
response.status
);
if response.status != WriteStatus::Ok {
bail!(
"config/value/write for plugin `{plugin_id}` enabled={enabled} was overridden: {:?}",
response.overridden_metadata
);
}
Ok(())
}
fn smoke_config_overrides(responses_base_url: &str) -> Result<Vec<String>> {
let provider_base_url = serde_json::to_string(&format!("{responses_base_url}/v1"))
.context("serialize mock provider base URL")?;
Ok(vec![
"analytics.enabled=true".to_string(),
"features.plugins=true".to_string(),
format!("model={}", quoted(MOCK_MODEL_SLUG)?),
format!("model_provider={}", quoted(MOCK_PROVIDER_ID)?),
format!(
"model_providers.{MOCK_PROVIDER_ID}.name={}",
quoted("Plugin analytics smoke mock provider")?
),
format!("model_providers.{MOCK_PROVIDER_ID}.base_url={provider_base_url}"),
format!(
"model_providers.{MOCK_PROVIDER_ID}.wire_api={}",
quoted("responses")?
),
format!("model_providers.{MOCK_PROVIDER_ID}.requires_openai_auth=false"),
format!("model_providers.{MOCK_PROVIDER_ID}.request_max_retries=0"),
format!("model_providers.{MOCK_PROVIDER_ID}.stream_max_retries=0"),
])
}
fn quoted(value: &str) -> Result<String> {
serde_json::to_string(value).context("serialize config string")
}
pub(super) fn prepare_capture_file(path: &Path) -> Result<()> {
let parent = path
.parent()
.context("capture file must have a parent directory")?;
if !parent.is_dir() {
bail!(
"capture file parent directory does not exist: {}",
parent.display()
);
}
match fs::remove_file(path) {
Ok(()) => {}
Err(err) if err.kind() == io::ErrorKind::NotFound => {}
Err(err) => {
return Err(err)
.with_context(|| format!("remove previous capture file {}", path.display()));
}
}
Ok(())
}
pub(super) fn wait_until_capture_is_ready(path: &Path) -> Result<()> {
let deadline = Instant::now() + CAPTURE_READY_TIMEOUT;
loop {
match fs::metadata(path) {
Ok(_) => return Ok(()),
Err(err) if err.kind() == io::ErrorKind::NotFound => {}
Err(err) => {
return Err(err)
.with_context(|| format!("inspect capture file {}", path.display()));
}
}
if Instant::now() >= deadline {
bail!(
"analytics capture did not become ready at {}; use a debug Codex binary",
path.display()
);
}
thread::sleep(CAPTURE_POLL_INTERVAL);
}
}
fn wait_for_plugin_events(path: &Path, plugin_id: &str) -> Result<Vec<Value>> {
let deadline = Instant::now() + CAPTURE_TIMEOUT;
loop {
let events = read_plugin_events(path, plugin_id)?;
if required_event_types()
.iter()
.all(|event_type| event_count(&events, event_type) >= 1)
{
return Ok(events);
}
if Instant::now() >= deadline {
bail!(
"timed out waiting for plugin analytics events in {}: found {:?}",
path.display(),
events
.iter()
.filter_map(|event| event["event_type"].as_str())
.collect::<Vec<_>>()
);
}
thread::sleep(CAPTURE_POLL_INTERVAL);
}
}
fn wait_for_turn_analytics(path: &Path, turn_id: &str) -> Result<Vec<Value>> {
let deadline = Instant::now() + CAPTURE_TIMEOUT;
loop {
let events = read_capture_events(path)?;
if events.iter().any(|event| {
event["event_type"] == "codex_turn_event"
&& event["event_params"]["turn_id"].as_str() == Some(turn_id)
}) {
return Ok(events);
}
if Instant::now() >= deadline {
bail!(
"timed out waiting for turn analytics for `{turn_id}` in {}",
path.display()
);
}
thread::sleep(CAPTURE_POLL_INTERVAL);
}
}
fn read_plugin_events(path: &Path, plugin_id: &str) -> Result<Vec<Value>> {
Ok(read_capture_events(path)?
.into_iter()
.filter(|event| event["event_params"]["plugin_id"] == plugin_id)
.collect())
}
fn read_capture_events(path: &Path) -> Result<Vec<Value>> {
let contents = match fs::read_to_string(path) {
Ok(contents) => contents,
Err(err) if err.kind() == io::ErrorKind::NotFound => return Ok(Vec::new()),
Err(err) => {
return Err(err).with_context(|| format!("read capture file {}", path.display()));
}
};
let mut captured = Vec::new();
for (index, line) in contents.lines().enumerate() {
if line.trim().is_empty() {
continue;
}
let payload: Value = serde_json::from_str(line).with_context(|| {
format!(
"parse analytics capture line {} from {}",
index + 1,
path.display()
)
})?;
let events = payload["events"]
.as_array()
.context("analytics capture payload is missing events")?;
captured.extend(events.iter().cloned());
}
Ok(captured)
}
fn validate_plugin_events(events: Vec<Value>, expected: &ExpectedPlugin) -> Result<Vec<Value>> {
let mut validated = Vec::new();
for event_type in required_event_types() {
let matching = events
.iter()
.filter(|event| event["event_type"] == event_type)
.collect::<Vec<_>>();
let [event] = matching.as_slice() else {
bail!(
"expected exactly one `{event_type}` event for `{}`, found {}",
expected.plugin_id,
matching.len()
);
};
validate_identity(event, expected)?;
if event_type == "codex_plugin_used" {
validate_used_metadata(event)?;
}
validated.push((*event).clone());
}
Ok(validated)
}
fn required_event_types() -> [&'static str; 3] {
[
"codex_plugin_disabled",
"codex_plugin_enabled",
"codex_plugin_used",
]
}
fn event_count(events: &[Value], event_type: &str) -> usize {
events
.iter()
.filter(|event| event["event_type"] == event_type)
.count()
}
fn validate_identity(event: &Value, expected: &ExpectedPlugin) -> Result<()> {
let params = &event["event_params"];
require_string(params, "plugin_id", &expected.plugin_id)?;
require_string(params, "remote_plugin_id", &expected.remote_plugin_id)?;
require_string(params, "plugin_name", &expected.plugin_name)?;
require_string(params, "marketplace_name", &expected.marketplace_name)
}
fn validate_used_metadata(event: &Value) -> Result<()> {
let params = &event["event_params"];
for field in [
"has_skills",
"mcp_server_count",
"connector_ids",
"mcp_server_names",
"thread_id",
"turn_id",
"model_slug",
] {
if params.get(field).is_none_or(Value::is_null) {
bail!("codex_plugin_used event has null or missing `{field}`");
}
}
require_string(params, "model_slug", MOCK_MODEL_SLUG)
}
fn require_string(params: &Value, field: &str, expected: &str) -> Result<()> {
let actual = params.get(field).and_then(Value::as_str);
if actual != Some(expected) {
bail!("expected `{field}` to be `{expected}`, got {actual:?}");
}
Ok(())
}
struct TemporaryConfigFile {
path: PathBuf,
}
impl TemporaryConfigFile {
fn create() -> Result<Self> {
let path = std::env::temp_dir().join(format!(
"codex-plugin-analytics-config-{}.toml",
process::id()
));
fs::write(&path, "")
.with_context(|| format!("create temporary config file {}", path.display()))?;
Ok(Self { path })
}
fn path(&self) -> &Path {
&self.path
}
}
impl Drop for TemporaryConfigFile {
fn drop(&mut self) {
let _ = fs::remove_file(&self.path);
}
}
|