File size: 15,072 Bytes
afa0cbf | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 | use std::process::Stdio;
use std::time::Duration;
use anyhow::Context;
use anyhow::Result;
use app_test_support::MockResponsesConfig;
use app_test_support::TestAppServer;
use codex_app_server_protocol::ThreadDecrementElicitationParams;
use codex_app_server_protocol::ThreadDecrementElicitationResponse;
use codex_app_server_protocol::ThreadGoalSetResponse;
use codex_app_server_protocol::ThreadGoalStatus;
use codex_app_server_protocol::ThreadGoalUpdatedNotification;
use codex_app_server_protocol::ThreadIncrementElicitationParams;
use codex_app_server_protocol::ThreadIncrementElicitationResponse;
use codex_app_server_protocol::ThreadStartParams;
use codex_app_server_protocol::TurnCompletedNotification;
use codex_app_server_protocol::TurnStartParams;
use codex_app_server_protocol::TurnStartResponse;
use codex_app_server_protocol::TurnStatus;
use codex_app_server_protocol::UserInput;
use codex_features::Feature;
use core_test_support::responses;
use pretty_assertions::assert_eq;
use serde_json::json;
use tempfile::TempDir;
use test_case::test_case;
use tokio::io::AsyncBufReadExt;
use tokio::io::BufReader;
use tokio::process::Command;
use tokio::time::timeout;
#[cfg(any(target_os = "macos", windows))]
const DEFAULT_READ_TIMEOUT: Duration = Duration::from_secs(/*secs*/ 60);
#[cfg(not(any(target_os = "macos", windows)))]
const DEFAULT_READ_TIMEOUT: Duration = Duration::from_secs(/*secs*/ 10);
/// Model output and the structured timing consumed by Bridge describe the same
/// host operation over either transport, including missing-cell responses.
#[test_case("exec", "grpc"; "exec_grpc")]
#[test_case("wait", "grpc"; "wait_grpc")]
#[test_case("exec", "stdio"; "exec_stdio")]
#[test_case("wait", "stdio"; "wait_stdio")]
#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
async fn code_mode_model_output_uses_structured_host_timing(
tool_name: &str,
transport: &str,
) -> Result<()> {
let mut host = match transport {
"grpc" => Some(
Command::new(codex_utils_cargo_bin::cargo_bin("codex-code-mode-host")?)
.args(["--listen", "grpc://127.0.0.1:0"])
.stdin(Stdio::null())
.stdout(Stdio::piped())
.stderr(Stdio::inherit())
.kill_on_drop(/*kill_on_drop*/ true)
.spawn()?,
),
"stdio" => None,
_ => anyhow::bail!("unknown host transport: {transport}"),
};
let host_url = if let Some(host) = host.as_mut() {
let stdout = host.stdout.take().context("host stdout unavailable")?;
Some(
timeout(
DEFAULT_READ_TIMEOUT,
BufReader::new(stdout).lines().next_line(),
)
.await??
.context("host exited before publishing its URL")?,
)
} else {
None
};
let model_server = responses::start_mock_server().await;
let invocation = if tool_name == "exec" {
responses::ev_custom_tool_call(
"timed-call",
"exec",
"await new Promise(resolve => setTimeout(resolve, 100)); text('timed');",
)
} else {
responses::ev_function_call("timed-call", "wait", r#"{"cell_id":"missing"}"#)
};
responses::mount_sse_once(
&model_server,
responses::sse(vec![
responses::ev_response_created("resp-1"),
invocation,
responses::ev_completed("resp-1"),
]),
)
.await;
let follow_up = responses::mount_sse_once(
&model_server,
responses::sse(vec![
responses::ev_assistant_message("msg-1", "Done"),
responses::ev_completed("resp-2"),
]),
)
.await;
let codex_home = TempDir::new()?;
MockResponsesConfig::new(&model_server.uri())
.enable_feature(Feature::CodeModeOnly)
.write(codex_home.path())?;
let mut builder = TestAppServer::builder()
.with_codex_home(codex_home.path())
.with_json_logging("codex_code_mode::timing=info,codex_core::tools::parallel=info");
if let Some(host_url) = host_url.as_deref() {
builder = builder.with_args(&["--code-mode-host", host_url]);
}
let mut app_server = builder.build_initialized().await?;
let thread = app_server
.start_thread(ThreadStartParams::default())
.await?;
let increment_id = app_server
.send_request(
"thread/increment_elicitation",
Some(serde_json::to_value(ThreadIncrementElicitationParams {
thread_id: thread.thread.id.clone(),
})?),
)
.await?;
let _: ThreadIncrementElicitationResponse = app_server.read_response(increment_id).await?;
let start_id = app_server
.send_turn_start_request(TurnStartParams {
thread_id: thread.thread.id.clone(),
input: vec![UserInput::Text {
text: "run the timed operation".to_string(),
text_elements: Vec::new(),
}],
..Default::default()
})
.await?;
let _: TurnStartResponse = app_server.read_response(start_id).await?;
let timing = app_server
.wait_for_json_log_event("codex.code_mode.host_timing")
.await?;
// Hold only the app-server after the host outcome, so local elapsed time
// cannot round to the same displayed duration as the host measurement.
tokio::time::sleep(Duration::from_millis(/*millis*/ 300)).await;
let decrement_id = app_server
.send_request(
"thread/decrement_elicitation",
Some(serde_json::to_value(ThreadDecrementElicitationParams {
thread_id: thread.thread.id.clone(),
})?),
)
.await?;
let _: ThreadDecrementElicitationResponse = app_server.read_response(decrement_id).await?;
let completed: TurnCompletedNotification =
app_server.read_notification("turn/completed").await?;
assert_eq!(completed.turn.status, TurnStatus::Completed);
let fields = &timing["fields"];
let code_mode_host_duration_ns = fields["code_mode_host_duration_ns"]
.as_u64()
.context("missing host timing")?;
assert_eq!(fields["conversation_id"], thread.thread.id);
assert_eq!(fields["turn_id"], completed.turn.id);
assert_eq!(fields["call_id"], "timed-call");
assert_eq!(fields["tool_name"], tool_name);
let request = follow_up.single_request();
let output = if tool_name == "exec" {
request.custom_tool_call_output("timed-call")
} else {
request.function_call_output("timed-call")
};
let status = if tool_name == "exec" {
"Script completed"
} else {
"Script failed"
};
let seconds = Duration::from_nanos(code_mode_host_duration_ns).as_secs_f32();
let seconds = (seconds * 10.0).round() / 10.0;
assert_eq!(
output["output"][0]["text"],
format!("{status}\nWall time {seconds:.1} seconds\nOutput:\n")
);
Ok(())
}
#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
async fn app_server_shares_flag_selected_grpc_code_mode_host_across_threads() -> Result<()> {
let host_program = codex_utils_cargo_bin::cargo_bin("codex-code-mode-host")?;
let mut code_mode_host = Command::new(host_program)
.args(["--listen", "grpc://127.0.0.1:0"])
.stdin(Stdio::null())
.stdout(Stdio::piped())
.stderr(Stdio::inherit())
.kill_on_drop(true)
.spawn()
.context("failed to start remote code-mode host")?;
let stdout = code_mode_host
.stdout
.take()
.context("remote code-mode host stdout was not captured")?;
let mut lines = BufReader::new(stdout).lines();
let host_url = timeout(DEFAULT_READ_TIMEOUT, lines.next_line())
.await
.context("timed out waiting for remote code-mode host URL")??
.context("remote code-mode host exited before publishing its URL")?;
let model_server = responses::start_mock_server().await;
let response_mock = responses::mount_sse_sequence(
&model_server,
vec![
responses::sse(vec![
responses::ev_response_created("resp-1"),
responses::ev_custom_tool_call(
"first-remote-cell",
"exec",
"text('remote app-server host')",
),
responses::ev_completed("resp-1"),
]),
responses::sse(vec![
responses::ev_assistant_message("msg-1", "Done"),
responses::ev_completed("resp-2"),
]),
responses::sse(vec![
responses::ev_response_created("resp-3"),
responses::ev_custom_tool_call(
"second-remote-cell",
"exec",
"text('remote app-server host')",
),
responses::ev_completed("resp-3"),
]),
responses::sse(vec![
responses::ev_assistant_message("msg-2", "Done"),
responses::ev_completed("resp-4"),
]),
],
)
.await;
let codex_home = TempDir::new()?;
MockResponsesConfig::new(&model_server.uri())
.enable_feature(Feature::CodeModeOnly)
.enable_feature(Feature::CodeModePrewarm)
.write(codex_home.path())?;
let original_config = std::fs::read_to_string(codex_home.path().join("config.toml"))?;
let mut app_server = TestAppServer::builder()
.with_codex_home(codex_home.path())
.with_args(&["--code-mode-host", &host_url])
.build_initialized_with_timeout(DEFAULT_READ_TIMEOUT)
.await?;
for prompt in ["run the first remote cell", "run the second remote cell"] {
let thread = app_server
.start_thread(ThreadStartParams::default())
.await?;
let completed = timeout(
DEFAULT_READ_TIMEOUT,
app_server.start_turn_and_wait_for_completion(TurnStartParams {
thread_id: thread.thread.id,
input: vec![UserInput::Text {
text: prompt.to_string(),
text_elements: Vec::new(),
}],
..Default::default()
}),
)
.await??;
assert_eq!(completed.turn.status, TurnStatus::Completed);
}
let requests = response_mock.requests();
assert_eq!(requests.len(), 4);
for (request, call_id) in [
(&requests[1], "first-remote-cell"),
(&requests[3], "second-remote-cell"),
] {
let output = request.custom_tool_call_output(call_id);
assert_eq!(
output["output"]
.as_array()
.and_then(|items| items.last())
.cloned(),
Some(json!({
"type": "input_text",
"text": "remote app-server host",
}))
);
}
assert_eq!(
std::fs::read_to_string(codex_home.path().join("config.toml"))?,
original_config
);
Ok(())
}
#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
async fn app_server_prewarms_flag_selected_grpc_code_mode_host_before_first_turn() -> Result<()> {
let model_server = responses::start_mock_server().await;
let codex_home = TempDir::new()?;
MockResponsesConfig::new(&model_server.uri())
.enable_feature(Feature::CodeModePrewarm)
.write(codex_home.path())?;
let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await?;
let host_url = format!("http://{}", listener.local_addr()?);
let mut app_server = TestAppServer::builder()
.with_codex_home(codex_home.path())
.with_args(&["--code-mode-host", &host_url])
.build_initialized_with_timeout(DEFAULT_READ_TIMEOUT)
.await?;
app_server
.start_thread(ThreadStartParams::default())
.await?;
let (_stalled_connection, _) = timeout(DEFAULT_READ_TIMEOUT, listener.accept())
.await
.context("code-mode host was not contacted before the first turn")??;
let status = timeout(Duration::from_secs(5), app_server.shutdown_gracefully())
.await
.context("stalled code-mode prewarm blocked thread shutdown")??;
assert!(status.success(), "app-server did not exit successfully");
Ok(())
}
#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
async fn app_server_blocks_goal_after_repeated_code_mode_host_failures() -> Result<()> {
let model_server = responses::start_mock_server().await;
let mut model_responses = Vec::new();
for turn in 1..=3 {
model_responses.push(responses::sse(vec![
responses::ev_response_created(&format!("resp-{turn}-exec")),
responses::ev_custom_tool_call(
&format!("call-exec-{turn}"),
"exec",
"text('unreachable')",
),
responses::ev_completed(&format!("resp-{turn}-exec")),
]));
model_responses.push(responses::sse(vec![
responses::ev_assistant_message(
&format!("msg-{turn}"),
"The execution host is unavailable.",
),
responses::ev_completed(&format!("resp-{turn}-done")),
]));
}
let response_mock = responses::mount_sse_sequence(&model_server, model_responses).await;
let codex_home = TempDir::new()?;
MockResponsesConfig::new(&model_server.uri())
.enable_feature(Feature::CodeModeOnly)
.enable_feature(Feature::Goals)
.enable_feature(Feature::Sqlite)
.write(codex_home.path())?;
let listener = tokio::net::TcpListener::bind("127.0.0.1:0").await?;
let host_url = format!("http://{}", listener.local_addr()?);
drop(listener);
let mut app_server = TestAppServer::builder()
.with_codex_home(codex_home.path())
.with_args(&["--code-mode-host", &host_url])
.build_initialized_with_timeout(DEFAULT_READ_TIMEOUT)
.await?;
let thread = app_server
.start_thread(ThreadStartParams::default())
.await?;
let goal_request = app_server
.send_raw_request(
"thread/goal/set",
Some(json!({
"threadId": thread.thread.id,
"objective": "finish the task",
"status": "active",
})),
)
.await?;
let _: ThreadGoalSetResponse =
timeout(DEFAULT_READ_TIMEOUT, app_server.read_response(goal_request)).await??;
let goal = timeout(DEFAULT_READ_TIMEOUT, async {
loop {
let notification: ThreadGoalUpdatedNotification =
app_server.read_notification("thread/goal/updated").await?;
if notification.goal.status == ThreadGoalStatus::Blocked {
return Ok::<_, anyhow::Error>(notification.goal);
}
}
})
.await??;
assert_eq!(goal.status, ThreadGoalStatus::Blocked);
assert_eq!(response_mock.requests().len(), 6);
Ok(())
}
|