File size: 14,513 Bytes
afa0cbf | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 | use super::GrpcCodeModeHost;
use super::GrpcStream;
use codex_code_mode_protocol::grpc as proto;
use codex_code_mode_protocol::grpc::code_mode_host_server::CodeModeHost;
use futures::FutureExt;
use futures::StreamExt;
use pretty_assertions::assert_eq;
use tonic::Code;
use tonic::Request;
pub(super) async fn open_session(
host: &GrpcCodeModeHost,
) -> (String, GrpcStream<proto::SessionEvent>) {
let mut stream = host
.open_session(Request::new(proto::OpenSessionRequest {
cell_execution_limits: None,
}))
.await
.expect("open code-mode session")
.into_inner();
let event = stream
.next()
.await
.expect("session opened event")
.expect("session event");
let Some(proto::session_event::Event::Opened(opened)) = event.event else {
panic!("expected the first session event to open its lease");
};
(opened.session_id, stream)
}
pub(super) fn execute_request(
session_id: &str,
execution_id: &str,
source: &str,
) -> proto::ExecuteRequest {
proto::ExecuteRequest {
session_id: session_id.to_string(),
execution_id: execution_id.to_string(),
tool_call_id: "outer-call".to_string(),
source: source.to_string(),
enabled_tools: Vec::new(),
yield_time_ms: Some(1),
max_output_tokens: None,
}
}
pub(super) fn tool(name: &str) -> proto::ToolDefinition {
proto::ToolDefinition {
name: name.to_string(),
tool_name: Some(proto::ToolName {
name: name.to_string(),
namespace: None,
}),
description: String::new(),
kind: proto::ToolKind::Function as i32,
input_schema_json: None,
output_schema_json: None,
}
}
pub(super) async fn execute_events(
host: &GrpcCodeModeHost,
request: proto::ExecuteRequest,
) -> (String, GrpcStream<proto::ExecuteEvent>) {
let mut stream = host
.execute(Request::new(request))
.await
.expect("execute cell")
.into_inner();
let event = stream
.next()
.await
.expect("execution started event")
.expect("execution event");
let Some(proto::execute_event::Event::Started(started)) = event.event else {
panic!("expected execution admission before its outcome");
};
(started.cell_id, stream)
}
#[tokio::test]
async fn execute_stream_starts_immediately_and_wait_preserves_missing_cells() {
let host = GrpcCodeModeHost::new();
let (session_id, mut session_events) = open_session(&host).await;
let mut request = execute_request(
&session_id,
"execution-1",
r#"text("before"); yield_control(); text("after");"#,
);
request.yield_time_ms = Some(60_000);
let (cell_id, mut execution) = execute_events(&host, request).await;
let yielded = execution.next().await.unwrap().unwrap();
let Some(proto::execute_event::Event::Outcome(yielded_outcome)) = &yielded.event else {
panic!("expected execution outcome");
};
assert_eq!(
yielded,
proto::ExecuteEvent {
event: Some(proto::execute_event::Event::Outcome(
proto::ExecutionOutcome {
code_mode_host_duration_ns: yielded_outcome.code_mode_host_duration_ns,
cell_id: cell_id.clone(),
content_items: vec![proto::ContentItem {
item: Some(proto::content_item::Item::Text(proto::TextContent {
text: "before".to_string(),
})),
}],
outcome: Some(proto::execution_outcome::Outcome::Yielded(
proto::ExecutionYielded {},
)),
}
)),
}
);
let completed = host
.wait(Request::new(proto::WaitRequest {
session_id: session_id.clone(),
cell_id: cell_id.clone(),
wait_id: "wait-1".to_string(),
yield_time_ms: 60_000,
}))
.await
.expect("wait for completion")
.into_inner();
let Some(proto::wait_response::State::LiveCell(completed_outcome)) = &completed.state else {
panic!("expected live-cell wait outcome");
};
assert_eq!(
completed,
proto::WaitResponse {
state: Some(proto::wait_response::State::LiveCell(
proto::ExecutionOutcome {
code_mode_host_duration_ns: completed_outcome.code_mode_host_duration_ns,
cell_id: cell_id.clone(),
content_items: vec![proto::ContentItem {
item: Some(proto::content_item::Item::Text(proto::TextContent {
text: "after".to_string(),
})),
}],
outcome: Some(proto::execution_outcome::Outcome::Completed(
proto::ExecutionCompleted { error_text: None },
)),
}
)),
}
);
assert_eq!(
session_events.next().await.unwrap().unwrap(),
proto::SessionEvent {
event: Some(proto::session_event::Event::CellClosed(proto::CellClosed {
execution_id: "execution-1".to_string(),
cell_id: cell_id.clone(),
final_tool_call_sequence: 0,
})),
}
);
let missing = host
.wait(Request::new(proto::WaitRequest {
session_id,
cell_id: "missing-cell".to_string(),
wait_id: "wait-missing".to_string(),
yield_time_ms: 1,
}))
.await
.expect("missing cells remain successful wait outcomes")
.into_inner();
assert!(matches!(
missing.state,
Some(proto::wait_response::State::MissingCell(_))
));
}
/// Missing, empty, and explicit default namespaces identify the same subscribed tool.
#[tokio::test]
async fn filtered_subscriptions_match_default_namespace_aliases() {
let aliases = [
(None, Some("functions".to_string())),
(Some(String::new()), None),
(Some("functions".to_string()), Some(String::new())),
];
for (tool_namespace, filter_namespace) in aliases {
let host = GrpcCodeModeHost::new();
let (session_id, _events) = open_session(&host).await;
let mut subscription = host
.subscribe_to_tool_calls(Request::new(proto::SubscribeToToolCallsRequest {
session_id: session_id.clone(),
tool_names: vec![proto::ToolName {
name: "echo".to_string(),
namespace: filter_namespace,
}],
}))
.await
.expect("subscribe with a default-namespace alias")
.into_inner();
let mut request = execute_request(
&session_id,
"default-namespace",
"text(await tools.echo({}));",
);
request.yield_time_ms = Some(/*value*/ 60_000);
let mut enabled_tool = tool("echo");
enabled_tool.tool_name = Some(proto::ToolName {
name: "echo".to_string(),
namespace: tool_namespace.clone(),
});
request.enabled_tools = vec![enabled_tool];
let (_cell_id, mut execution) = execute_events(&host, request).await;
let invocation = subscription
.next()
.await
.expect("matching default-namespace invocation")
.expect("tool invocation");
assert_eq!(
invocation.tool_name,
Some(proto::ToolName {
name: "echo".to_string(),
namespace: tool_namespace,
})
);
host.complete_tool_call(Request::new(proto::CompleteToolCallRequest {
session_id,
invocation_id: invocation.invocation_id,
outcome: Some(proto::complete_tool_call_request::Outcome::Succeeded(
proto::ToolCallSucceeded {
output_json: br#""done""#.to_vec(),
},
)),
}))
.await
.expect("complete the matching tool call");
assert!(matches!(
execution.next().await,
Some(Ok(proto::ExecuteEvent {
event: Some(proto::execute_event::Event::Outcome(
proto::ExecutionOutcome {
outcome: Some(proto::execution_outcome::Outcome::Completed(_)),
..
}
)),
}))
));
}
}
#[tokio::test]
async fn filtered_subscriptions_receive_ordered_calls_and_unary_completions() {
let host = GrpcCodeModeHost::new();
let (session_id, mut session_events) = open_session(&host).await;
let mut matching = host
.subscribe_to_tool_calls(Request::new(proto::SubscribeToToolCallsRequest {
session_id: session_id.clone(),
tool_names: vec![proto::ToolName {
name: "echo".to_string(),
namespace: None,
}],
}))
.await
.unwrap()
.into_inner();
let mut unrelated = host
.subscribe_to_tool_calls(Request::new(proto::SubscribeToToolCallsRequest {
session_id: session_id.clone(),
tool_names: vec![proto::ToolName {
name: "other".to_string(),
namespace: None,
}],
}))
.await
.unwrap()
.into_inner();
let mut request = execute_request(
&session_id,
"execution-tools",
r#"text(await tools.echo({value: 1})); text(await tools.echo({value: 2}));"#,
);
request.yield_time_ms = Some(60_000);
request.enabled_tools = vec![tool("echo")];
let (cell_id, mut execution) = execute_events(&host, request).await;
for sequence in [1, 2] {
let invocation = matching.next().await.unwrap().unwrap();
assert_eq!(invocation.session_id, session_id);
assert_eq!(invocation.execution_id, "execution-tools");
assert_eq!(invocation.cell_id, cell_id);
assert_eq!(invocation.sequence, sequence);
assert_eq!(
invocation.input_json,
Some(format!(r#"{{"value":{sequence}}}"#).into_bytes())
);
assert!(unrelated.next().now_or_never().is_none());
host.complete_tool_call(Request::new(proto::CompleteToolCallRequest {
session_id: session_id.clone(),
invocation_id: invocation.invocation_id,
outcome: Some(proto::complete_tool_call_request::Outcome::Succeeded(
proto::ToolCallSucceeded {
output_json: format!(r#""result-{sequence}""#).into_bytes(),
},
)),
}))
.await
.expect("complete delegated tool");
}
let outcome = execution.next().await.unwrap().unwrap();
assert!(matches!(
outcome.event,
Some(proto::execute_event::Event::Outcome(
proto::ExecutionOutcome {
outcome: Some(proto::execution_outcome::Outcome::Completed(_)),
..
}
))
));
assert_eq!(
session_events.next().await.unwrap().unwrap(),
proto::SessionEvent {
event: Some(proto::session_event::Event::CellClosed(proto::CellClosed {
execution_id: "execution-tools".to_string(),
cell_id,
final_tool_call_sequence: 2,
})),
}
);
}
#[tokio::test]
async fn cancellation_before_wait_admission_is_preserved() {
let host = GrpcCodeModeHost::new();
let (session_id, _events) = open_session(&host).await;
let (cell_id, mut execution) = execute_events(
&host,
execute_request(
&session_id,
"execution-wait",
"await new Promise(() => {});",
),
)
.await;
execution.next().await.unwrap().unwrap();
host.cancel_wait(Request::new(proto::CancelWaitRequest {
session_id: session_id.clone(),
wait_id: "pre-cancelled".to_string(),
}))
.await
.expect("record cancellation before wait admission");
let cancelled = host
.wait(Request::new(proto::WaitRequest {
session_id: session_id.clone(),
cell_id: cell_id.clone(),
wait_id: "pre-cancelled".to_string(),
yield_time_ms: 60_000,
}))
.await
.unwrap_err();
assert_eq!(cancelled.code(), Code::Cancelled);
host.terminate(Request::new(proto::TerminateRequest {
session_id,
cell_id,
}))
.await
.unwrap();
}
#[tokio::test]
async fn notifications_do_not_delay_cell_completion() {
let host = GrpcCodeModeHost::new();
let (session_id, mut session_events) = open_session(&host).await;
let mut request = execute_request(
&session_id,
"execution-notify",
r#"notify("pending"); text("done");"#,
);
request.yield_time_ms = Some(60_000);
let (cell_id, mut execution) = execute_events(&host, request).await;
let event = session_events.next().await.unwrap().unwrap();
let Some(proto::session_event::Event::Notification(notification)) = event.event else {
panic!("expected pending notification");
};
assert_eq!(notification.execution_id, "execution-notify");
assert_eq!(notification.cell_id, cell_id);
assert_eq!(notification.call_id, "outer-call");
assert_eq!(notification.text, "pending");
assert!(matches!(
execution.next().await.unwrap().unwrap().event,
Some(proto::execute_event::Event::Outcome(
proto::ExecutionOutcome {
outcome: Some(proto::execution_outcome::Outcome::Completed(_)),
..
}
))
));
assert_eq!(
session_events.next().await.unwrap().unwrap(),
proto::SessionEvent {
event: Some(proto::session_event::Event::CellClosed(proto::CellClosed {
execution_id: "execution-notify".to_string(),
cell_id,
final_tool_call_sequence: 0,
})),
}
);
host.acknowledge_notification(Request::new(proto::AcknowledgeNotificationRequest {
session_id,
notification_id: notification.notification_id,
}))
.await
.expect("legacy notification acknowledgments remain accepted");
}
|