File size: 10,117 Bytes
767452b | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 | use std::collections::HashSet;
use async_trait::async_trait;
use forge_domain::{
ContextMessage, Conversation, EndPayload, EventData, EventHandle, Template, TodoStatus,
};
use forge_template::Element;
use serde::Serialize;
use crate::TemplateEngine;
/// A single todo item prepared for template rendering.
#[derive(Serialize)]
struct TodoReminderItem {
status: &'static str,
content: String,
}
/// Template context for the pending-todos reminder.
#[derive(Serialize)]
struct PendingTodosContext {
todos: Vec<TodoReminderItem>,
}
/// Detects when the LLM signals task completion while there are still
/// pending or in-progress todo items.
///
/// When triggered, it injects a formatted reminder listing all
/// outstanding todos into the conversation context, preventing the
/// orchestrator from yielding prematurely.
#[derive(Debug, Clone, Default)]
pub struct PendingTodosHandler;
impl PendingTodosHandler {
/// Creates a new pending-todos handler
pub fn new() -> Self {
Self
}
}
#[async_trait]
impl EventHandle<EventData<EndPayload>> for PendingTodosHandler {
async fn handle(
&self,
_event: &EventData<EndPayload>,
conversation: &mut Conversation,
) -> anyhow::Result<()> {
let pending_todos = conversation.metrics.get_active_todos();
if pending_todos.is_empty() {
return Ok(());
}
// Build a set of current pending todo contents for comparison
let current_todo_set: HashSet<String> = pending_todos
.iter()
.map(|todo| todo.content.clone())
.collect();
// Check if we already have a reminder with the exact same set of todos
// This prevents duplicate reminders while still allowing new reminders
// when todos change (e.g., some completed but others still pending)
let should_add_reminder = if let Some(context) = &conversation.context {
// Find the most recent reminder message by looking for the template content
// pattern
let last_reminder_todos: Option<HashSet<String>> = context
.messages
.iter()
.rev()
.filter_map(|entry| {
let content = entry.message.content()?;
// Check if this is a pending todos reminder
if content.contains("You have pending todo items") {
// Extract todo items from the reminder message
// Format: "- [STATUS] Content"
let todos: HashSet<String> = content
.lines()
.filter(|line| line.starts_with("- ["))
.map(|line| {
// Extract content after "- [STATUS] "
line.split_once("] ")
.map(|x| x.1)
.map(|s| s.to_string())
.unwrap_or_default()
})
.collect();
Some(todos)
} else {
None
}
})
.next();
match last_reminder_todos {
Some(last_todos) => last_todos != current_todo_set,
None => true, // No previous reminder found, should add
}
} else {
true // No context, should add reminder
};
if !should_add_reminder {
return Ok(());
}
let todo_items: Vec<TodoReminderItem> = pending_todos
.iter()
.filter_map(|todo| {
let status = match todo.status {
TodoStatus::Pending => "PENDING",
TodoStatus::InProgress => "IN_PROGRESS",
_ => return None,
};
Some(TodoReminderItem { status, content: todo.content.clone() })
})
.collect();
let ctx = PendingTodosContext { todos: todo_items };
let reminder = TemplateEngine::default().render(
Template::<PendingTodosContext>::new("forge-pending-todos-reminder.md"),
&ctx,
)?;
if let Some(context) = conversation.context.as_mut() {
let content = Element::new("system_reminder").text(reminder);
context
.messages
.push(ContextMessage::user(content, None).into());
}
Ok(())
}
}
#[cfg(test)]
mod tests {
use forge_domain::{
Agent, Context, Conversation, EndPayload, EventData, EventHandle, Metrics, ModelId, Todo,
TodoStatus,
};
use pretty_assertions::assert_eq;
use super::*;
fn fixture_agent() -> Agent {
Agent::new(
"test-agent",
"test-provider".to_string().into(),
ModelId::new("test-model"),
)
}
fn fixture_conversation(todos: Vec<Todo>) -> Conversation {
let mut conversation = Conversation::generate();
conversation.context = Some(Context::default());
conversation.metrics = Metrics::default().todos(todos);
conversation
}
fn fixture_event() -> EventData<EndPayload> {
EventData::new(fixture_agent(), ModelId::new("test-model"), EndPayload)
}
#[tokio::test]
async fn test_no_pending_todos_does_nothing() {
let handler = PendingTodosHandler::new();
let event = fixture_event();
let mut conversation = fixture_conversation(vec![]);
let initial_msg_count = conversation.context.as_ref().unwrap().messages.len();
handler.handle(&event, &mut conversation).await.unwrap();
let actual = conversation.context.as_ref().unwrap().messages.len();
let expected = initial_msg_count;
assert_eq!(actual, expected);
}
#[tokio::test]
async fn test_pending_todos_injects_reminder() {
let handler = PendingTodosHandler::new();
let event = fixture_event();
let mut conversation = fixture_conversation(vec![
Todo::new("Fix the build").status(TodoStatus::Pending),
Todo::new("Write tests").status(TodoStatus::InProgress),
]);
handler.handle(&event, &mut conversation).await.unwrap();
let actual = conversation.context.as_ref().unwrap().messages.len();
let expected = 1;
assert_eq!(actual, expected);
}
#[tokio::test]
async fn test_reminder_contains_formatted_list() {
let handler = PendingTodosHandler::new();
let event = fixture_event();
let mut conversation = fixture_conversation(vec![
Todo::new("Fix the build").status(TodoStatus::Pending),
Todo::new("Write tests").status(TodoStatus::InProgress),
]);
handler.handle(&event, &mut conversation).await.unwrap();
let entry = &conversation.context.as_ref().unwrap().messages[0];
let actual = entry.message.content().unwrap();
assert!(actual.contains("- [PENDING] Fix the build"));
assert!(actual.contains("- [IN_PROGRESS] Write tests"));
}
#[tokio::test]
async fn test_completed_todos_not_included() {
let handler = PendingTodosHandler::new();
let event = fixture_event();
let mut conversation = fixture_conversation(vec![
Todo::new("Completed task").status(TodoStatus::Completed),
Todo::new("Cancelled task").status(TodoStatus::Cancelled),
]);
let initial_msg_count = conversation.context.as_ref().unwrap().messages.len();
handler.handle(&event, &mut conversation).await.unwrap();
let actual = conversation.context.as_ref().unwrap().messages.len();
let expected = initial_msg_count;
assert_eq!(actual, expected);
}
#[tokio::test]
async fn test_reminder_not_duplicated_for_same_todos() {
let handler = PendingTodosHandler::new();
let event = fixture_event();
let mut conversation =
fixture_conversation(vec![Todo::new("Fix the build").status(TodoStatus::Pending)]);
// First call should inject a reminder
handler.handle(&event, &mut conversation).await.unwrap();
let after_first = conversation.context.as_ref().unwrap().messages.len();
assert_eq!(after_first, 1);
// Second call with the same pending todos should NOT add another reminder
handler.handle(&event, &mut conversation).await.unwrap();
let after_second = conversation.context.as_ref().unwrap().messages.len();
assert_eq!(after_second, 1); // Still 1, no duplicate
}
#[tokio::test]
async fn test_reminder_added_when_todos_change() {
let handler = PendingTodosHandler::new();
let event = fixture_event();
let mut conversation = fixture_conversation(vec![
Todo::new("Fix the build").status(TodoStatus::Pending),
Todo::new("Write tests").status(TodoStatus::InProgress),
]);
// First call should inject a reminder
handler.handle(&event, &mut conversation).await.unwrap();
let after_first = conversation.context.as_ref().unwrap().messages.len();
assert_eq!(after_first, 1);
// Simulate LLM completing one todo but leaving another pending
// Update the conversation metrics with different todos
conversation.metrics = conversation.metrics.clone().todos(vec![
Todo::new("Fix the build").status(TodoStatus::Completed),
Todo::new("Write tests").status(TodoStatus::InProgress),
Todo::new("Add documentation").status(TodoStatus::Pending),
]);
// Second call with different pending todos should add a new reminder
handler.handle(&event, &mut conversation).await.unwrap();
let after_second = conversation.context.as_ref().unwrap().messages.len();
assert_eq!(after_second, 2); // New reminder added because todos changed
}
}
|