File size: 17,148 Bytes
d90101d | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 305 306 307 308 309 310 311 312 313 314 315 316 317 318 319 320 321 322 323 324 325 326 327 328 329 330 331 332 333 334 335 336 337 338 339 340 341 342 343 344 345 346 347 348 349 350 351 352 353 354 355 356 357 358 359 360 361 362 363 364 365 366 367 368 369 370 371 372 373 374 375 376 377 378 379 380 381 382 383 384 385 386 387 388 389 390 391 392 393 394 395 396 397 398 399 400 401 402 403 404 405 406 407 408 409 410 411 412 413 414 415 416 417 418 419 420 421 422 423 424 425 426 427 428 429 430 431 432 433 434 435 436 437 438 439 440 441 442 443 444 445 446 447 448 449 450 451 452 453 454 455 456 457 458 459 460 461 462 | use std::sync::Arc;
use forge_app::{AppConfigService, EnvironmentInfra};
use forge_domain::{ConfigOperation, Effort, ModelConfig, ModelId, ProviderId, ProviderRepository};
use tracing::debug;
/// Service for managing user preferences for default providers and models.
///
/// All reads go through `infra.get_config()` so they always reflect the latest
/// on-disk state after any `update_environment` call.
pub struct ForgeAppConfigService<F> {
infra: Arc<F>,
}
impl<F> ForgeAppConfigService<F> {
/// Creates a new provider preferences service.
pub fn new(infra: Arc<F>) -> Self {
Self { infra }
}
}
#[async_trait::async_trait]
impl<F: ProviderRepository + EnvironmentInfra<Config = forge_config::ForgeConfig> + Send + Sync>
AppConfigService for ForgeAppConfigService<F>
{
async fn get_session_config(&self) -> Option<ModelConfig> {
let config = self.infra.get_config().ok()?;
let session = config.session.as_ref()?;
Some(ModelConfig {
provider: ProviderId::from(session.provider_id.clone()),
model: ModelId::new(session.model_id.clone()),
})
}
async fn get_commit_config(&self) -> anyhow::Result<Option<forge_domain::ModelConfig>> {
let config = self.infra.get_config()?;
Ok(config.commit.clone().map(|mc| ModelConfig {
provider: ProviderId::from(mc.provider_id),
model: ModelId::new(mc.model_id),
}))
}
async fn get_suggest_config(&self) -> anyhow::Result<Option<forge_domain::ModelConfig>> {
let config = self.infra.get_config()?;
Ok(config.suggest.clone().map(|mc| ModelConfig {
provider: ProviderId::from(mc.provider_id),
model: ModelId::new(mc.model_id),
}))
}
async fn get_reasoning_effort(&self) -> anyhow::Result<Option<Effort>> {
let config = self.infra.get_config()?;
Ok(config
.reasoning
.clone()
.and_then(|r| r.effort)
.map(|e| match e {
forge_config::Effort::None => Effort::None,
forge_config::Effort::Minimal => Effort::Minimal,
forge_config::Effort::Low => Effort::Low,
forge_config::Effort::Medium => Effort::Medium,
forge_config::Effort::High => Effort::High,
forge_config::Effort::XHigh => Effort::XHigh,
forge_config::Effort::Max => Effort::Max,
}))
}
async fn update_config(&self, ops: Vec<ConfigOperation>) -> anyhow::Result<()> {
debug!(ops = ?ops, "Updating app config");
self.infra.update_environment(ops).await
}
}
#[cfg(test)]
mod tests {
use std::collections::HashMap;
use std::path::PathBuf;
use std::sync::Mutex;
use forge_config::{ForgeConfig, ModelConfig};
// Alias to avoid collision with forge_config::ModelConfig used in test fixtures
use forge_domain::ModelConfig as DomainModelConfig;
use forge_domain::{
AnyProvider, ChatRepository, ConfigOperation, Environment, InputModality, MigrationResult,
Model, ModelId, ModelSource, Provider, ProviderId, ProviderResponse, ProviderTemplate,
};
use pretty_assertions::assert_eq;
use url::Url;
use super::*;
#[derive(Clone)]
struct MockInfra {
config: Arc<Mutex<ForgeConfig>>,
providers: Vec<Provider<Url>>,
}
impl MockInfra {
fn new() -> Self {
Self {
config: Arc::new(Mutex::new(ForgeConfig::default())),
providers: vec![
Provider {
id: ProviderId::OPENAI,
provider_type: Default::default(),
response: Some(ProviderResponse::OpenAI),
url: Url::parse("https://api.openai.com").unwrap(),
credential: Some(forge_domain::AuthCredential {
id: ProviderId::OPENAI,
auth_details: forge_domain::AuthDetails::ApiKey(
forge_domain::ApiKey::from("test-key".to_string()),
),
url_params: HashMap::new(),
}),
auth_methods: vec![forge_domain::AuthMethod::ApiKey],
url_params: vec![],
models: Some(ModelSource::Hardcoded(vec![Model {
id: "gpt-4".to_string().into(),
name: Some("GPT-4".to_string()),
description: None,
context_length: Some(8192),
tools_supported: Some(true),
supports_parallel_tool_calls: Some(true),
supports_reasoning: Some(false),
input_modalities: vec![InputModality::Text],
}])),
custom_headers: None,
},
Provider {
id: ProviderId::ANTHROPIC,
provider_type: Default::default(),
response: Some(ProviderResponse::Anthropic),
url: Url::parse("https://api.anthropic.com").unwrap(),
auth_methods: vec![forge_domain::AuthMethod::ApiKey],
url_params: vec![],
credential: Some(forge_domain::AuthCredential {
id: ProviderId::ANTHROPIC,
auth_details: forge_domain::AuthDetails::ApiKey(
forge_domain::ApiKey::from("test-key".to_string()),
),
url_params: HashMap::new(),
}),
models: Some(ModelSource::Hardcoded(vec![Model {
id: "claude-3".to_string().into(),
name: Some("Claude 3".to_string()),
description: None,
context_length: Some(200000),
tools_supported: Some(true),
supports_parallel_tool_calls: Some(true),
supports_reasoning: Some(true),
input_modalities: vec![InputModality::Text],
}])),
custom_headers: None,
},
],
}
}
}
impl EnvironmentInfra for MockInfra {
type Config = ForgeConfig;
fn get_environment(&self) -> Environment {
Environment {
os: "test".to_string(),
cwd: PathBuf::new(),
home: None,
shell: "bash".to_string(),
base_path: PathBuf::new(),
}
}
fn update_environment(
&self,
ops: Vec<ConfigOperation>,
) -> impl std::future::Future<Output = anyhow::Result<()>> + Send {
let config = self.config.clone();
async move {
let mut config = config.lock().unwrap();
for op in ops {
match op {
ConfigOperation::SetSessionConfig(mc) => {
let pid_str = mc.provider.as_ref().to_string();
let mid_str = mc.model.to_string();
config.session = Some(ModelConfig::new(pid_str, mid_str));
}
ConfigOperation::SetCommitConfig(mc) => {
config.commit = mc.map(|m| {
ModelConfig::new(
m.provider.as_ref().to_string(),
m.model.to_string(),
)
});
}
ConfigOperation::SetSuggestConfig(mc) => {
config.suggest = Some(ModelConfig::new(
mc.provider.as_ref().to_string(),
mc.model.to_string(),
));
}
ConfigOperation::SetReasoningEffort(_) => {
// No-op in tests
}
}
}
Ok(())
}
}
fn get_config(&self) -> anyhow::Result<ForgeConfig> {
Ok(self.config.lock().unwrap().clone())
}
fn get_env_var(&self, _key: &str) -> Option<String> {
None
}
fn get_env_vars(&self) -> std::collections::BTreeMap<String, String> {
std::collections::BTreeMap::new()
}
}
#[async_trait::async_trait]
impl ChatRepository for MockInfra {
async fn chat(
&self,
_model_id: &forge_app::domain::ModelId,
_context: forge_app::domain::Context,
_provider: Provider<Url>,
) -> forge_app::domain::ResultStream<forge_app::domain::ChatCompletionMessage, anyhow::Error>
{
Ok(Box::pin(tokio_stream::iter(vec![])))
}
async fn models(
&self,
_provider: Provider<Url>,
) -> anyhow::Result<Vec<forge_app::domain::Model>> {
Ok(vec![])
}
}
#[async_trait::async_trait]
impl ProviderRepository for MockInfra {
async fn get_all_providers(&self) -> anyhow::Result<Vec<AnyProvider>> {
Ok(self
.providers
.iter()
.map(|p| AnyProvider::Url(p.clone()))
.collect())
}
async fn get_provider(&self, id: ProviderId) -> anyhow::Result<ProviderTemplate> {
// Convert Provider<Url> to Provider<Template<...>> for testing
self.providers
.iter()
.find(|p| p.id == id)
.map(|p| Provider {
id: p.id.clone(),
provider_type: p.provider_type,
response: p.response.clone(),
url: forge_domain::Template::<forge_domain::URLParameters>::new(p.url.as_str()),
models: p.models.as_ref().map(|m| match m {
ModelSource::Url(url) => ModelSource::Url(forge_domain::Template::<
forge_domain::URLParameters,
>::new(
url.as_str()
)),
ModelSource::Hardcoded(list) => ModelSource::Hardcoded(list.clone()),
}),
auth_methods: p.auth_methods.clone(),
url_params: p.url_params.clone(),
credential: p.credential.clone(),
custom_headers: None,
})
.ok_or_else(|| anyhow::anyhow!("Provider not found"))
}
async fn upsert_credential(
&self,
_credential: forge_domain::AuthCredential,
) -> anyhow::Result<()> {
Ok(())
}
async fn get_credential(
&self,
_id: &ProviderId,
) -> anyhow::Result<Option<forge_domain::AuthCredential>> {
Ok(None)
}
async fn remove_credential(&self, _id: &ProviderId) -> anyhow::Result<()> {
Ok(())
}
async fn migrate_env_credentials(&self) -> anyhow::Result<Option<MigrationResult>> {
Ok(None)
}
}
#[tokio::test]
async fn test_get_session_config_when_none_set() -> anyhow::Result<()> {
let fixture = MockInfra::new();
let service = ForgeAppConfigService::new(Arc::new(fixture));
let result = service.get_session_config().await;
assert!(result.is_none());
Ok(())
}
#[tokio::test]
async fn test_get_session_config_when_set() -> anyhow::Result<()> {
let fixture = MockInfra::new();
let service = ForgeAppConfigService::new(Arc::new(fixture.clone()));
service
.update_config(vec![ConfigOperation::SetSessionConfig(
DomainModelConfig::new(ProviderId::ANTHROPIC, ModelId::new("claude-3")),
)])
.await?;
let actual = service.get_session_config().await;
let expected = Some(DomainModelConfig::new(
ProviderId::ANTHROPIC,
ModelId::new("claude-3"),
));
assert_eq!(actual, expected);
Ok(())
}
#[tokio::test]
async fn test_get_session_config_when_provider_not_available() -> anyhow::Result<()> {
let mut fixture = MockInfra::new();
// Remove OpenAI from available providers but keep it in config
fixture.providers.retain(|p| p.id != ProviderId::OPENAI);
let service = ForgeAppConfigService::new(Arc::new(fixture.clone()));
// Set OpenAI as the default provider in config (with a model)
service
.update_config(vec![ConfigOperation::SetSessionConfig(
DomainModelConfig::new(ProviderId::OPENAI, ModelId::new("gpt-4")),
)])
.await?;
// Should return the config even if provider is not available
// Validation happens when getting the actual provider via ProviderService
let result = service.get_session_config().await;
assert_eq!(
result,
Some(DomainModelConfig::new(
ProviderId::OPENAI,
ModelId::new("gpt-4")
))
);
Ok(())
}
#[tokio::test]
async fn test_set_session_config() -> anyhow::Result<()> {
let fixture = MockInfra::new();
let service = ForgeAppConfigService::new(Arc::new(fixture.clone()));
service
.update_config(vec![ConfigOperation::SetSessionConfig(
DomainModelConfig::new(ProviderId::ANTHROPIC, ModelId::new("claude-3")),
)])
.await?;
let actual = service.get_session_config().await;
let expected = Some(DomainModelConfig::new(
ProviderId::ANTHROPIC,
ModelId::new("claude-3"),
));
assert_eq!(actual, expected);
Ok(())
}
#[tokio::test]
async fn test_get_session_config_model_when_none_set() -> anyhow::Result<()> {
let fixture = MockInfra::new();
let service = ForgeAppConfigService::new(Arc::new(fixture));
let result = service.get_session_config().await;
assert!(result.is_none());
Ok(())
}
#[tokio::test]
async fn test_get_session_config_model_when_set() -> anyhow::Result<()> {
let fixture = MockInfra::new();
let service = ForgeAppConfigService::new(Arc::new(fixture.clone()));
service
.update_config(vec![ConfigOperation::SetSessionConfig(
DomainModelConfig::new(ProviderId::OPENAI, ModelId::new("gpt-4")),
)])
.await?;
let actual = service.get_session_config().await.map(|c| c.model);
let expected = Some(ModelId::new("gpt-4"));
assert_eq!(actual, expected);
Ok(())
}
#[tokio::test]
async fn test_set_session_config_model() -> anyhow::Result<()> {
let fixture = MockInfra::new();
let service = ForgeAppConfigService::new(Arc::new(fixture.clone()));
service
.update_config(vec![ConfigOperation::SetSessionConfig(
DomainModelConfig::new(ProviderId::OPENAI, ModelId::from("gpt-4".to_string())),
)])
.await?;
let actual = service.get_session_config().await.map(|c| c.model);
let expected = Some(ModelId::from("gpt-4".to_string()));
assert_eq!(actual, expected);
Ok(())
}
#[tokio::test]
async fn test_set_multiple_default_models() -> anyhow::Result<()> {
let fixture = MockInfra::new();
let service = ForgeAppConfigService::new(Arc::new(fixture.clone()));
// Set model for OpenAI first
service
.update_config(vec![ConfigOperation::SetSessionConfig(
DomainModelConfig::new(ProviderId::OPENAI, ModelId::from("gpt-4".to_string())),
)])
.await?;
// Then switch to Anthropic with its model
service
.update_config(vec![ConfigOperation::SetSessionConfig(
DomainModelConfig::new(
ProviderId::ANTHROPIC,
ModelId::from("claude-3".to_string()),
),
)])
.await?;
// ForgeConfig only tracks a single active session, so the last
// provider/model pair wins
let actual = service.get_session_config().await;
let expected = Some(DomainModelConfig::new(
ProviderId::ANTHROPIC,
ModelId::new("claude-3"),
));
assert_eq!(actual, expected);
Ok(())
}
}
|