File size: 9,400 Bytes
84aa3bf
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
/**
 * @license
 * Copyright 2026 Google LLC
 * SPDX-License-Identifier: Apache-2.0
 */

import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';
import * as fs from 'node:fs';
import * as path from 'node:path';
import * as os from 'node:os';
import { ExtensionManager } from './extension-manager.js';
import {
  debugLogger,
  coreEvents,
  type CommandHookConfig,
} from '@google/gemini-cli-core';
import { createTestMergedSettings } from './settings.js';
import { createExtension } from '../test-utils/createExtension.js';
import { EXTENSIONS_DIRECTORY_NAME } from './extensions/variables.js';

const mockHomedir = vi.hoisted(() => vi.fn(() => '/tmp/mock-home'));

vi.mock('node:os', async (importOriginal) => {
  const actual = await importOriginal<typeof import('node:os')>();
  return {
    ...actual,
    homedir: mockHomedir,
  };
});

// Mock @google/gemini-cli-core
vi.mock('@google/gemini-cli-core', async (importOriginal) => {
  const actual =
    await importOriginal<typeof import('@google/gemini-cli-core')>();
  return {
    ...actual,
    homedir: mockHomedir,
    // Use actual implementations for loading skills and agents to test hydration
    loadAgentsFromDirectory: actual.loadAgentsFromDirectory,
    loadSkillsFromDir: actual.loadSkillsFromDir,
  };
});

describe('ExtensionManager hydration', () => {
  let extensionManager: ExtensionManager;
  let tempDir: string;
  let extensionsDir: string;

  beforeEach(() => {
    vi.clearAllMocks();
    vi.stubEnv('ANTIGRAVITY_CLI_ALIAS', '');
    vi.spyOn(coreEvents, 'emitFeedback');
    vi.spyOn(debugLogger, 'debug').mockImplementation(() => {});

    tempDir = fs.mkdtempSync(path.join(os.tmpdir(), 'gemini-test-'));
    mockHomedir.mockReturnValue(tempDir);
    vi.stubEnv('GEMINI_CLI_HOME', tempDir);

    // Create the extensions directory that ExtensionManager expects
    extensionsDir = path.join(tempDir, '.gemini', EXTENSIONS_DIRECTORY_NAME);
    fs.mkdirSync(extensionsDir, { recursive: true });

    extensionManager = new ExtensionManager({
      settings: createTestMergedSettings({
        telemetry: { enabled: false },
        experimental: { extensionConfig: true },
      }),
      requestConsent: vi.fn().mockResolvedValue(true),
      requestSetting: vi.fn(),
      workspaceDir: tempDir,
    });
  });

  afterEach(() => {
    try {
      fs.rmSync(tempDir, { recursive: true, force: true });
    } catch {
      // ignore
    }
  });

  it('should hydrate skill body with extension settings', async () => {
    const sourceDir = path.join(tempDir, 'source-ext-skill');
    const extensionName = 'skill-hydration-ext';
    createExtension({
      extensionsDir: sourceDir,
      name: extensionName,
      version: '1.0.0',
      settings: [
        {
          name: 'API Key',
          description: 'API Key',
          envVar: 'MY_API_KEY',
        },
      ],
      installMetadata: {
        type: 'local',
        source: path.join(sourceDir, extensionName),
      },
    });
    const extensionPath = path.join(sourceDir, extensionName);

    // Create skill with variable
    const skillsDir = path.join(extensionPath, 'skills');
    const skillSubdir = path.join(skillsDir, 'my-skill');
    fs.mkdirSync(skillSubdir, { recursive: true });
    fs.writeFileSync(
      path.join(skillSubdir, 'SKILL.md'),
      `---
name: my-skill
description: test
---
Use key: \${MY_API_KEY}
`,
    );

    await extensionManager.loadExtensions();

    extensionManager.setRequestSetting(async (setting) => {
      if (setting.envVar === 'MY_API_KEY') return 'secret-123';
      return '';
    });

    const extension = await extensionManager.installOrUpdateExtension({
      type: 'local',
      source: extensionPath,
    });

    expect(extension.skills).toHaveLength(1);
    expect(extension.skills![0].body).toContain('Use key: secret-123');
  });

  it('should hydrate agent system prompt with extension settings', async () => {
    const sourceDir = path.join(tempDir, 'source-ext-agent');
    const extensionName = 'agent-hydration-ext';
    createExtension({
      extensionsDir: sourceDir,
      name: extensionName,
      version: '1.0.0',
      settings: [
        {
          name: 'Model Name',
          description: 'Model',
          envVar: 'MODEL_NAME',
        },
      ],
      installMetadata: {
        type: 'local',
        source: path.join(sourceDir, extensionName),
      },
    });
    const extensionPath = path.join(sourceDir, extensionName);

    // Create agent with variable
    const agentsDir = path.join(extensionPath, 'agents');
    fs.mkdirSync(agentsDir, { recursive: true });
    fs.writeFileSync(
      path.join(agentsDir, 'my-agent.md'),
      `---
name: my-agent
description: test
---
System using model: \${MODEL_NAME}
`,
    );

    await extensionManager.loadExtensions();

    extensionManager.setRequestSetting(async (setting) => {
      if (setting.envVar === 'MODEL_NAME') return 'gemini-pro';
      return '';
    });

    const extension = await extensionManager.installOrUpdateExtension({
      type: 'local',
      source: extensionPath,
    });

    expect(extension.agents).toHaveLength(1);
    const agent = extension.agents![0];
    if (agent.kind === 'local') {
      expect(agent.promptConfig.systemPrompt).toContain(
        'System using model: gemini-pro',
      );
    } else {
      throw new Error('Expected local agent');
    }
  });

  it('should hydrate hooks with extension settings', async () => {
    const sourceDir = path.join(tempDir, 'source-ext-hooks');
    const extensionName = 'hooks-hydration-ext';
    createExtension({
      extensionsDir: sourceDir,
      name: extensionName,
      version: '1.0.0',
      settings: [
        {
          name: 'Hook Command',
          description: 'Cmd',
          envVar: 'HOOK_CMD',
        },
      ],
      installMetadata: {
        type: 'local',
        source: path.join(sourceDir, extensionName),
      },
    });
    const extensionPath = path.join(sourceDir, extensionName);

    const hooksDir = path.join(extensionPath, 'hooks');
    fs.mkdirSync(hooksDir, { recursive: true });
    fs.writeFileSync(
      path.join(hooksDir, 'hooks.json'),
      JSON.stringify({
        hooks: {
          BeforeTool: [
            {
              hooks: [
                {
                  type: 'command',
                  command: 'echo $HOOK_CMD',
                },
              ],
            },
          ],
        },
      }),
    );

    // Enable hooks in settings
    extensionManager = new ExtensionManager({
      settings: createTestMergedSettings({
        telemetry: { enabled: false },
        experimental: { extensionConfig: true },
        hooksConfig: { enabled: true },
      }),
      requestConsent: vi.fn().mockResolvedValue(true),
      requestSetting: vi.fn(),
      workspaceDir: tempDir,
    });

    await extensionManager.loadExtensions();

    extensionManager.setRequestSetting(async (setting) => {
      if (setting.envVar === 'HOOK_CMD') return 'hello-world';
      return '';
    });

    const extension = await extensionManager.installOrUpdateExtension({
      type: 'local',
      source: extensionPath,
    });

    expect(extension.hooks).toBeDefined();
    expect(extension.hooks?.BeforeTool).toHaveLength(1);
    expect(
      (extension.hooks?.BeforeTool![0].hooks[0] as CommandHookConfig).env?.[
        'HOOK_CMD'
      ],
    ).toBe('hello-world');
  });

  it('should pick up new settings after restartExtension', async () => {
    const sourceDir = path.join(tempDir, 'source-ext-restart');
    const extensionName = 'restart-hydration-ext';
    createExtension({
      extensionsDir: sourceDir,
      name: extensionName,
      version: '1.0.0',
      settings: [
        {
          name: 'Value',
          description: 'Val',
          envVar: 'MY_VALUE',
        },
      ],
      installMetadata: {
        type: 'local',
        source: path.join(sourceDir, extensionName),
      },
    });
    const extensionPath = path.join(sourceDir, extensionName);

    const skillsDir = path.join(extensionPath, 'skills');
    const skillSubdir = path.join(skillsDir, 'my-skill');
    fs.mkdirSync(skillSubdir, { recursive: true });
    fs.writeFileSync(
      path.join(skillSubdir, 'SKILL.md'),
      '---\nname: my-skill\ndescription: test\n---\nValue is: ${MY_VALUE}',
    );

    await extensionManager.loadExtensions();

    // Initial setting
    extensionManager.setRequestSetting(async () => 'first');
    const extension = await extensionManager.installOrUpdateExtension({
      type: 'local',
      source: extensionPath,
    });
    expect(extension.skills![0].body).toContain('Value is: first');

    const { updateSetting, ExtensionSettingScope } = await import(
      './extensions/extensionSettings.js'
    );
    const extensionConfig =
      await extensionManager.loadExtensionConfig(extensionPath);

    const mockRequestSetting = vi.fn().mockResolvedValue('second');
    await updateSetting(
      extensionConfig,
      extension.id,
      'MY_VALUE',
      mockRequestSetting,
      ExtensionSettingScope.USER,
      process.cwd(),
    );

    await extensionManager.restartExtension(extension);

    const reloadedExtension = extensionManager
      .getExtensions()
      .find((e) => e.name === extensionName)!;
    expect(reloadedExtension.skills![0].body).toContain('Value is: second');
  });
});