File size: 8,833 Bytes
84aa3bf
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
/**
 * @license
 * Copyright 2026 Google LLC
 * SPDX-License-Identifier: Apache-2.0
 */

import {
  describe,
  it,
  expect,
  vi,
  beforeEach,
  afterEach,
  type Mock,
} from 'vitest';
import * as fs from 'node:fs/promises';
import {
  ExtensionRegistryClient,
  type RegistryExtension,
} from './extensionRegistryClient.js';
import { fetchWithTimeout, resolveToRealPath } from '@google/gemini-cli-core';

vi.mock('@google/gemini-cli-core', async (importOriginal) => {
  const actual =
    await importOriginal<typeof import('@google/gemini-cli-core')>();
  return {
    ...actual,
    fetchWithTimeout: vi.fn(),
  };
});

vi.mock('node:fs/promises', () => ({
  readFile: vi.fn(),
}));

const mockExtensions: RegistryExtension[] = [
  {
    id: 'ext1',
    rank: 1,
    url: 'https://github.com/test/ext1',
    fullName: 'test/ext1',
    repoDescription: 'Test extension 1',
    stars: 100,
    lastUpdated: '2025-01-01T00:00:00Z',
    extensionName: 'extension-one',
    extensionVersion: '1.0.0',
    extensionDescription: 'First test extension',
    avatarUrl: 'https://example.com/avatar1.png',
    hasMCP: true,
    hasContext: false,
    isGoogleOwned: false,
    licenseKey: 'mit',
    hasHooks: false,
    hasCustomCommands: false,
    hasSkills: false,
  },
  {
    id: 'ext2',
    rank: 2,
    url: 'https://github.com/test/ext2',
    fullName: 'test/ext2',
    repoDescription: 'Test extension 2',
    stars: 50,
    lastUpdated: '2025-01-02T00:00:00Z',
    extensionName: 'extension-two',
    extensionVersion: '0.5.0',
    extensionDescription: 'Second test extension',
    avatarUrl: 'https://example.com/avatar2.png',
    hasMCP: false,
    hasContext: true,
    isGoogleOwned: true,
    licenseKey: 'apache-2.0',
    hasHooks: false,
    hasCustomCommands: false,
    hasSkills: false,
  },
  {
    id: 'ext3',
    rank: 3,
    url: 'https://github.com/test/ext3',
    fullName: 'test/ext3',
    repoDescription: 'Test extension 3',
    stars: 10,
    lastUpdated: '2025-01-03T00:00:00Z',
    extensionName: 'extension-three',
    extensionVersion: '0.1.0',
    extensionDescription: 'Third test extension',
    avatarUrl: 'https://example.com/avatar3.png',
    hasMCP: true,
    hasContext: true,
    isGoogleOwned: false,
    licenseKey: 'gpl-3.0',
    hasHooks: false,
    hasCustomCommands: false,
    hasSkills: false,
  },
];

describe('ExtensionRegistryClient', () => {
  let client: ExtensionRegistryClient;
  let fetchMock: Mock;

  beforeEach(() => {
    ExtensionRegistryClient.resetCache();
    client = new ExtensionRegistryClient();
    fetchMock = fetchWithTimeout as Mock;
    fetchMock.mockReset();
  });

  afterEach(() => {
    vi.restoreAllMocks();
  });

  it('should fetch and return extensions with pagination (default ranking)', async () => {
    fetchMock.mockResolvedValue({
      ok: true,
      json: async () => mockExtensions,
    });

    const result = await client.getExtensions(1, 2);
    expect(result.extensions).toHaveLength(2);
    expect(result.extensions[0].id).toBe('ext1'); // rank 1
    expect(result.extensions[1].id).toBe('ext2'); // rank 2
    expect(result.total).toBe(3);
    expect(fetchMock).toHaveBeenCalledTimes(1);
    expect(fetchMock).toHaveBeenCalledWith(
      'https://geminicli.com/extensions.json',
      10000,
    );
  });

  it('should return extensions sorted alphabetically', async () => {
    fetchMock.mockResolvedValue({
      ok: true,
      json: async () => mockExtensions,
    });

    const result = await client.getExtensions(1, 3, 'alphabetical');
    expect(result.extensions).toHaveLength(3);
    expect(result.extensions[0].id).toBe('ext1');
    expect(result.extensions[1].id).toBe('ext3');
    expect(result.extensions[2].id).toBe('ext2');
  });

  it('should return the second page of extensions', async () => {
    fetchMock.mockResolvedValue({
      ok: true,
      json: async () => mockExtensions,
    });

    const result = await client.getExtensions(2, 2);
    expect(result.extensions).toHaveLength(1);
    expect(result.extensions[0].id).toBe('ext3');
    expect(result.total).toBe(3);
  });

  it('should search extensions by name', async () => {
    fetchMock.mockResolvedValue({
      ok: true,
      json: async () => mockExtensions,
    });

    const results = await client.searchExtensions('one');
    expect(results.length).toBeGreaterThanOrEqual(1);
    expect(results[0].id).toBe('ext1');
  });

  it('should search extensions by description', async () => {
    fetchMock.mockResolvedValue({
      ok: true,
      json: async () => mockExtensions,
    });

    const results = await client.searchExtensions('Second');
    expect(results.length).toBeGreaterThanOrEqual(1);
    expect(results[0].id).toBe('ext2');
  });

  it('should get an extension by ID', async () => {
    fetchMock.mockResolvedValue({
      ok: true,
      json: async () => mockExtensions,
    });

    const result = await client.getExtension('ext2');
    expect(result).toBeDefined();
    expect(result?.id).toBe('ext2');
  });

  it('should return undefined if extension not found', async () => {
    fetchMock.mockResolvedValue({
      ok: true,
      json: async () => mockExtensions,
    });

    const result = await client.getExtension('non-existent');
    expect(result).toBeUndefined();
  });

  it('should cache the fetch result', async () => {
    fetchMock.mockResolvedValue({
      ok: true,
      json: async () => mockExtensions,
    });

    await client.getExtensions();
    await client.getExtensions();

    expect(fetchMock).toHaveBeenCalledTimes(1);
  });

  it('should share the fetch result across instances', async () => {
    fetchMock.mockResolvedValue({
      ok: true,
      json: async () => mockExtensions,
    });

    const client1 = new ExtensionRegistryClient();
    const client2 = new ExtensionRegistryClient();

    await client1.getExtensions();
    await client2.getExtensions();

    expect(fetchMock).toHaveBeenCalledTimes(1);
  });

  it('should throw an error if fetch fails', async () => {
    fetchMock.mockResolvedValue({
      ok: false,
      statusText: 'Not Found',
    });

    await expect(client.getExtensions()).rejects.toThrow(
      'Failed to fetch extensions: Not Found',
    );
  });

  it('should not return irrelevant results', async () => {
    fetchMock.mockResolvedValue({
      ok: true,
      json: async () => [
        ...mockExtensions,
        {
          id: 'dataplex',
          extensionName: 'dataplex',
          extensionDescription: 'Connect to Dataplex Universal Catalog...',
          fullName: 'google-cloud/dataplex',
          rank: 6,
          stars: 6,
          url: '',
          repoDescription: '',
          lastUpdated: '',
          extensionVersion: '1.0.0',
          avatarUrl: '',
          hasMCP: false,
          hasContext: false,
          isGoogleOwned: true,
          licenseKey: '',
          hasHooks: false,
          hasCustomCommands: false,
          hasSkills: false,
        },
        {
          id: 'conductor',
          extensionName: 'conductor',
          extensionDescription: 'A conductor extension that actually matches.',
          fullName: 'someone/conductor',
          rank: 100,
          stars: 100,
          url: '',
          repoDescription: '',
          lastUpdated: '',
          extensionVersion: '1.0.0',
          avatarUrl: '',
          hasMCP: false,
          hasContext: false,
          isGoogleOwned: false,
          licenseKey: '',
          hasHooks: false,
          hasCustomCommands: false,
          hasSkills: false,
        },
      ],
    });

    const results = await client.searchExtensions('conductor');
    const ids = results.map((r) => r.id);

    expect(ids).not.toContain('dataplex');
    expect(ids).toContain('conductor');
  });

  it('should fetch extensions from a local file path', async () => {
    const filePath = '/path/to/extensions.json';
    const clientWithFile = new ExtensionRegistryClient(filePath);
    const mockReadFile = vi.mocked(fs.readFile);
    mockReadFile.mockResolvedValue(JSON.stringify(mockExtensions));

    const result = await clientWithFile.getExtensions();
    expect(result.extensions).toHaveLength(3);
    expect(mockReadFile).toHaveBeenCalledWith(
      resolveToRealPath(filePath),
      'utf-8',
    );
  });

  it('should fetch extensions from a file:// URL', async () => {
    const fileUrl = 'file:///path/to/extensions.json';
    const clientWithFileUrl = new ExtensionRegistryClient(fileUrl);
    const mockReadFile = vi.mocked(fs.readFile);
    mockReadFile.mockResolvedValue(JSON.stringify(mockExtensions));

    const result = await clientWithFileUrl.getExtensions();
    expect(result.extensions).toHaveLength(3);
    expect(mockReadFile).toHaveBeenCalledWith(
      resolveToRealPath(fileUrl),
      'utf-8',
    );
  });
});