File size: 4,784 Bytes
52efc7b
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
/**
 * @license
 * Copyright 2026 Google LLC
 * SPDX-License-Identifier: Apache-2.0
 */

import { renderWithProviders } from '../../../test-utils/render.js';
import { describe, it, expect } from 'vitest';
import { ToolGroupMessage } from './ToolGroupMessage.js';
import {
  makeFakeConfig,
  CoreToolCallStatus,
  ApprovalMode,
  WRITE_FILE_DISPLAY_NAME,
  Kind,
  SubagentState,
} from '@google/gemini-cli-core';
import os from 'node:os';
import { createMockSettings } from '../../../test-utils/settings.js';
import type { IndividualToolCallDisplay } from '../../types.js';

describe('ToolGroupMessage Regression Tests', () => {
  const baseMockConfig = makeFakeConfig({
    model: 'gemini-pro',
    targetDir: os.tmpdir(),
  });
  const fullVerbositySettings = createMockSettings({
    ui: { errorVerbosity: 'full' },
  });

  const createToolCall = (
    overrides: Partial<IndividualToolCallDisplay> = {},
  ): IndividualToolCallDisplay =>
    ({
      callId: 'tool-123',
      name: 'test-tool',
      status: CoreToolCallStatus.Success,
      ...overrides,
    }) as IndividualToolCallDisplay;

  const createItem = (tools: IndividualToolCallDisplay[]) => ({
    id: 1,
    type: 'tool_group' as const,
    tools,
  });

  it('Plan Mode: suppresses phantom tool group (hidden tools)', async () => {
    const toolCalls = [
      createToolCall({
        name: WRITE_FILE_DISPLAY_NAME,
        approvalMode: ApprovalMode.PLAN,
        status: CoreToolCallStatus.Success,
      }),
    ];
    const item = createItem(toolCalls);

    const { lastFrame, unmount } = await renderWithProviders(
      <ToolGroupMessage
        terminalWidth={80}
        item={item}
        toolCalls={toolCalls}
        borderBottom={true}
      />,
      { config: baseMockConfig, settings: fullVerbositySettings },
    );

    expect(lastFrame({ allowEmpty: true })).toBe('');
    unmount();
  });

  it('Agent Case: suppresses the bottom border box for ongoing agents (no vertical ticks)', async () => {
    const toolCalls = [
      createToolCall({
        name: 'agent',
        kind: Kind.Agent,
        status: CoreToolCallStatus.Executing,
        resultDisplay: {
          isSubagentProgress: true,
          agentName: 'TestAgent',
          state: SubagentState.RUNNING,
          recentActivity: [],
        },
      }),
    ];
    const item = createItem(toolCalls);

    const { lastFrame, unmount } = await renderWithProviders(
      <ToolGroupMessage
        terminalWidth={80}
        item={item}
        toolCalls={toolCalls}
        borderBottom={false} // Ongoing
      />,
      { config: baseMockConfig, settings: fullVerbositySettings },
    );

    const output = lastFrame();
    expect(output).toContain('Running Agent...');
    // It should render side borders from the content
    expect(output).toContain('β”‚');
    // It should NOT render the bottom border box (no corners β•° β•―)
    expect(output).not.toContain('β•°');
    expect(output).not.toContain('β•―');
    unmount();
  });

  it('Agent Case: renders a bottom border horizontal line for completed agents', async () => {
    const toolCalls = [
      createToolCall({
        name: 'agent',
        kind: Kind.Agent,
        status: CoreToolCallStatus.Success,
        resultDisplay: {
          isSubagentProgress: true,
          agentName: 'TestAgent',
          state: SubagentState.COMPLETED,
          recentActivity: [],
        },
      }),
    ];
    const item = createItem(toolCalls);

    const { lastFrame, unmount } = await renderWithProviders(
      <ToolGroupMessage
        terminalWidth={80}
        item={item}
        toolCalls={toolCalls}
        borderBottom={true} // Completed
      />,
      { config: baseMockConfig, settings: fullVerbositySettings },
    );

    const output = lastFrame();
    // Verify it rendered subagent content
    expect(output).toContain('Agent');
    // It should render the bottom horizontal line
    expect(output).toContain(
      '╰──────────────────────────────────────────────────────────────────────────╯',
    );
    unmount();
  });

  it('Bridges: still renders a bridge if it has a top border', async () => {
    const toolCalls: IndividualToolCallDisplay[] = [];
    const item = createItem(toolCalls);

    const { lastFrame, unmount } = await renderWithProviders(
      <ToolGroupMessage
        terminalWidth={80}
        item={item}
        toolCalls={toolCalls}
        borderTop={true}
        borderBottom={true}
      />,
      { config: baseMockConfig, settings: fullVerbositySettings },
    );

    expect(lastFrame({ allowEmpty: true })).not.toBe('');
    unmount();
  });
});