File size: 5,538 Bytes
7a1ad33 | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 | /**
* @license
* Copyright 2025 Google LLC
* SPDX-License-Identifier: Apache-2.0
*/
import { describe, it, expect, vi, beforeEach } from 'vitest';
import * as fs from 'node:fs';
import { TrustedHooksManager } from './trustedHooks.js';
import { Storage } from '../config/storage.js';
import { HookEventName, HookType, type HookDefinition } from './types.js';
vi.mock('node:fs');
vi.mock('../config/storage.js');
vi.mock('../utils/debugLogger.js', () => ({
debugLogger: {
warn: vi.fn(),
error: vi.fn(),
log: vi.fn(),
debug: vi.fn(),
},
}));
describe('TrustedHooksManager', () => {
beforeEach(() => {
vi.resetAllMocks();
vi.mocked(Storage.getGlobalGeminiDir).mockReturnValue('/mock/home/.gemini');
});
describe('initialization', () => {
it('should load existing trusted hooks', () => {
const existingData = {
'/project/a': ['hook1:cmd1'],
};
vi.mocked(fs.existsSync).mockReturnValue(true);
vi.mocked(fs.readFileSync).mockReturnValue(JSON.stringify(existingData));
const manager = new TrustedHooksManager();
const untrusted = manager.getUntrustedHooks('/project/a', {
[HookEventName.BeforeTool]: [
{
hooks: [{ type: HookType.Command, command: 'cmd1', name: 'hook1' }],
},
],
});
expect(untrusted).toHaveLength(0);
});
it('should handle missing config file', () => {
vi.mocked(fs.existsSync).mockReturnValue(false);
const manager = new TrustedHooksManager();
const untrusted = manager.getUntrustedHooks('/project/a', {
[HookEventName.BeforeTool]: [
{
hooks: [{ type: HookType.Command, command: 'cmd1', name: 'hook1' }],
},
],
});
expect(untrusted).toEqual(['hook1']);
});
});
describe('getUntrustedHooks', () => {
it('should return names of untrusted hooks', () => {
vi.mocked(fs.existsSync).mockReturnValue(false);
const manager = new TrustedHooksManager();
const projectHooks = {
[HookEventName.BeforeTool]: [
{
hooks: [
{
name: 'trusted-hook',
type: HookType.Command,
command: 'cmd1',
} as const,
{
name: 'new-hook',
type: HookType.Command,
command: 'cmd2',
} as const,
],
},
],
};
// Initially both are untrusted
expect(manager.getUntrustedHooks('/project', projectHooks)).toEqual([
'trusted-hook',
'new-hook',
]);
// Trust one
manager.trustHooks('/project', {
[HookEventName.BeforeTool]: [
{
hooks: [
{
name: 'trusted-hook',
type: HookType.Command,
command: 'cmd1',
} as const,
],
},
],
});
// Only the other one is untrusted
expect(manager.getUntrustedHooks('/project', projectHooks)).toEqual([
'new-hook',
]);
});
it('should use command if name is missing', () => {
vi.mocked(fs.existsSync).mockReturnValue(false);
const manager = new TrustedHooksManager();
const projectHooks = {
[HookEventName.BeforeTool]: [
{
hooks: [{ type: HookType.Command, command: './script.sh' }],
},
],
};
expect(
manager.getUntrustedHooks(
'/project',
projectHooks as Partial<Record<HookEventName, HookDefinition[]>>,
),
).toEqual(['./script.sh']);
});
it('should detect change in command as untrusted', () => {
vi.mocked(fs.existsSync).mockReturnValue(false);
const manager = new TrustedHooksManager();
const originalHook = {
[HookEventName.BeforeTool]: [
{
hooks: [
{ name: 'my-hook', type: HookType.Command, command: 'old-cmd' },
],
},
],
};
const updatedHook = {
[HookEventName.BeforeTool]: [
{
hooks: [
{ name: 'my-hook', type: HookType.Command, command: 'new-cmd' },
],
},
],
};
manager.trustHooks(
'/project',
originalHook as Partial<Record<HookEventName, HookDefinition[]>>,
);
expect(
manager.getUntrustedHooks(
'/project',
updatedHook as Partial<Record<HookEventName, HookDefinition[]>>,
),
).toEqual(['my-hook']);
});
});
describe('persistence', () => {
it('should save to file when trusting hooks', () => {
vi.mocked(fs.existsSync).mockReturnValue(false);
const manager = new TrustedHooksManager();
manager.trustHooks('/project', {
[HookEventName.BeforeTool]: [
{
hooks: [{ name: 'hook1', type: HookType.Command, command: 'cmd1' }],
},
],
});
expect(fs.writeFileSync).toHaveBeenCalledWith(
expect.stringContaining('trusted_hooks.json'),
expect.stringContaining('hook1:cmd1'),
);
});
it('should create directory if missing on save', () => {
vi.mocked(fs.existsSync).mockReturnValue(false);
const manager = new TrustedHooksManager();
manager.trustHooks('/project', {});
expect(fs.mkdirSync).toHaveBeenCalledWith(expect.any(String), {
recursive: true,
});
});
});
});
|