File size: 9,395 Bytes
7a1ad33 | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 | /**
* @license
* Copyright 2025 Google LLC
* SPDX-License-Identifier: Apache-2.0
*/
import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest';
import * as fs from 'node:fs/promises';
import * as os from 'node:os';
import * as path from 'node:path';
import { loadSkillsFromDir } from './skillLoader.js';
import { coreEvents } from '../utils/events.js';
import { debugLogger } from '../utils/debugLogger.js';
describe('skillLoader', () => {
let testRootDir: string;
beforeEach(async () => {
testRootDir = await fs.mkdtemp(
path.join(os.tmpdir(), 'skill-loader-test-'),
);
vi.spyOn(coreEvents, 'emitFeedback');
vi.spyOn(debugLogger, 'debug').mockImplementation(() => {});
});
afterEach(async () => {
await fs.rm(testRootDir, { recursive: true, force: true });
vi.restoreAllMocks();
});
it('should load skills from a directory with valid SKILL.md', async () => {
const skillDir = path.join(testRootDir, 'my-skill');
await fs.mkdir(skillDir, { recursive: true });
const skillFile = path.join(skillDir, 'SKILL.md');
await fs.writeFile(
skillFile,
`---\nname: my-skill\ndescription: A test skill\n---\n# Instructions\nDo something.\n`,
);
const skills = await loadSkillsFromDir(testRootDir);
expect(skills).toHaveLength(1);
expect(skills[0].name).toBe('my-skill');
expect(skills[0].description).toBe('A test skill');
expect(skills[0].location).toBe(skillFile);
expect(skills[0].body).toBe('# Instructions\nDo something.');
expect(coreEvents.emitFeedback).not.toHaveBeenCalled();
});
it('should emit feedback when no valid skills are found in a non-empty directory', async () => {
const notASkillDir = path.join(testRootDir, 'not-a-skill');
await fs.mkdir(notASkillDir, { recursive: true });
await fs.writeFile(path.join(notASkillDir, 'some-file.txt'), 'hello');
const skills = await loadSkillsFromDir(testRootDir);
expect(skills).toHaveLength(0);
expect(debugLogger.debug).toHaveBeenCalledWith(
expect.stringContaining('Failed to load skills from'),
);
});
it('should ignore empty directories and not emit feedback', async () => {
const skills = await loadSkillsFromDir(testRootDir);
expect(skills).toHaveLength(0);
expect(coreEvents.emitFeedback).not.toHaveBeenCalled();
});
it('should ignore directories without SKILL.md', async () => {
const notASkillDir = path.join(testRootDir, 'not-a-skill');
await fs.mkdir(notASkillDir, { recursive: true });
// With a subdirectory, even if empty, it might still trigger readdir
// But my current logic is if discoveredSkills.length === 0, then check readdir
// If readdir is empty, it's fine.
const skills = await loadSkillsFromDir(testRootDir);
expect(skills).toHaveLength(0);
// If notASkillDir is empty, no warning.
});
it('should ignore SKILL.md without valid frontmatter and emit warning if directory is not empty', async () => {
const skillDir = path.join(testRootDir, 'invalid-skill');
await fs.mkdir(skillDir, { recursive: true });
const skillFile = path.join(skillDir, 'SKILL.md');
await fs.writeFile(skillFile, '# No frontmatter here');
const skills = await loadSkillsFromDir(testRootDir);
expect(skills).toHaveLength(0);
expect(debugLogger.debug).toHaveBeenCalledWith(
expect.stringContaining('Failed to load skills from'),
);
});
it('should return empty array for non-existent directory', async () => {
const skills = await loadSkillsFromDir('/non/existent/path');
expect(skills).toEqual([]);
expect(coreEvents.emitFeedback).not.toHaveBeenCalled();
});
it('should parse skill with colon in description (issue #16323)', async () => {
const skillDir = path.join(testRootDir, 'colon-skill');
await fs.mkdir(skillDir, { recursive: true });
const skillFile = path.join(skillDir, 'SKILL.md');
await fs.writeFile(
skillFile,
`---
name: foo
description: Simple story generation assistant for fiction writing. Use for creating characters, scenes, storylines, and prose. Trigger words: character, scene, storyline, story, prose, fiction, writing.
---
# Instructions
Do something.
`,
);
const skills = await loadSkillsFromDir(testRootDir);
expect(skills).toHaveLength(1);
expect(skills[0].name).toBe('foo');
expect(skills[0].description).toContain('Trigger words:');
});
it('should parse skill with multiple colons in description', async () => {
const skillDir = path.join(testRootDir, 'multi-colon-skill');
await fs.mkdir(skillDir, { recursive: true });
const skillFile = path.join(skillDir, 'SKILL.md');
await fs.writeFile(
skillFile,
`---
name: multi-colon
description: Use this for tasks like: coding, reviewing, testing. Keywords: async, await, promise.
---
# Instructions
Do something.
`,
);
const skills = await loadSkillsFromDir(testRootDir);
expect(skills).toHaveLength(1);
expect(skills[0].name).toBe('multi-colon');
expect(skills[0].description).toContain('tasks like:');
expect(skills[0].description).toContain('Keywords:');
});
it('should parse skill with quoted YAML description (backward compatibility)', async () => {
const skillDir = path.join(testRootDir, 'quoted-skill');
await fs.mkdir(skillDir, { recursive: true });
const skillFile = path.join(skillDir, 'SKILL.md');
await fs.writeFile(
skillFile,
`---
name: quoted-skill
description: "A skill with colons: like this one: and another."
---
# Instructions
Do something.
`,
);
const skills = await loadSkillsFromDir(testRootDir);
expect(skills).toHaveLength(1);
expect(skills[0].name).toBe('quoted-skill');
expect(skills[0].description).toBe(
'A skill with colons: like this one: and another.',
);
});
it('should parse skill with multi-line YAML description', async () => {
const skillDir = path.join(testRootDir, 'multiline-skill');
await fs.mkdir(skillDir, { recursive: true });
const skillFile = path.join(skillDir, 'SKILL.md');
await fs.writeFile(
skillFile,
`---
name: multiline-skill
description:
Expertise in reviewing code for style, security, and performance. Use when the
user asks for "feedback," a "review," or to "check" their changes.
---
# Instructions
Do something.
`,
);
const skills = await loadSkillsFromDir(testRootDir);
expect(skills).toHaveLength(1);
expect(skills[0].name).toBe('multiline-skill');
expect(skills[0].description).toContain('Expertise in reviewing code');
expect(skills[0].description).toContain('check');
});
it('should handle empty name or description', async () => {
const skillDir = path.join(testRootDir, 'empty-skill');
await fs.mkdir(skillDir, { recursive: true });
const skillFile = path.join(skillDir, 'SKILL.md');
await fs.writeFile(
skillFile,
`---
name:
description:
---
`,
);
const skills = await loadSkillsFromDir(testRootDir);
expect(skills).toHaveLength(1);
expect(skills[0].name).toBe('');
expect(skills[0].description).toBe('');
});
it('should handle indented name and description fields', async () => {
const skillDir = path.join(testRootDir, 'indented-fields');
await fs.mkdir(skillDir, { recursive: true });
const skillFile = path.join(skillDir, 'SKILL.md');
await fs.writeFile(
skillFile,
`---
name: indented-name
description: indented-desc
---
`,
);
const skills = await loadSkillsFromDir(testRootDir);
expect(skills).toHaveLength(1);
expect(skills[0].name).toBe('indented-name');
expect(skills[0].description).toBe('indented-desc');
});
it('should handle missing space after colon', async () => {
const skillDir = path.join(testRootDir, 'no-space');
await fs.mkdir(skillDir, { recursive: true });
const skillFile = path.join(skillDir, 'SKILL.md');
await fs.writeFile(
skillFile,
`---
name:no-space-name
description:no-space-desc
---
`,
);
const skills = await loadSkillsFromDir(testRootDir);
expect(skills).toHaveLength(1);
expect(skills[0].name).toBe('no-space-name');
expect(skills[0].description).toBe('no-space-desc');
});
it('should sanitize skill names containing invalid filename characters', async () => {
const skillFile = path.join(testRootDir, 'SKILL.md');
await fs.writeFile(
skillFile,
`---
name: gke:prs-troubleshooter
description: Test sanitization
---
`,
);
const skills = await loadSkillsFromDir(testRootDir);
expect(skills).toHaveLength(1);
expect(skills[0].name).toBe('gke-prs-troubleshooter');
});
it('should load real built-in antigravity-support skill successfully', async () => {
const { fileURLToPath } = await import('node:url');
const __dirname = path.dirname(fileURLToPath(import.meta.url));
const builtinDir = path.resolve(__dirname, 'builtin');
const skills = await loadSkillsFromDir(builtinDir);
const antigravitySkill = skills.find(
(s) => s.name === 'antigravity-support',
);
expect(antigravitySkill).toBeDefined();
expect(antigravitySkill!.description).toContain('Antigravity CLI');
expect(antigravitySkill!.body).toContain(
'https://antigravity.google/docs/cli-getting-started',
);
});
});
|