File size: 5,240 Bytes
7a1ad33 | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 | /**
* @license
* Copyright 2025 Google LLC
* SPDX-License-Identifier: Apache-2.0
*/
import { describe, it, expect, beforeEach, afterEach, vi } from 'vitest';
import * as fs from 'node:fs/promises';
import * as os from 'node:os';
import * as path from 'node:path';
import { SkillManager } from './skillManager.js';
import { Storage } from '../config/storage.js';
import { loadSkillsFromDir } from './skillLoader.js';
vi.mock('./skillLoader.js', async (importOriginal) => {
const actual = await importOriginal<typeof import('./skillLoader.js')>();
return {
...actual,
loadSkillsFromDir: vi.fn(actual.loadSkillsFromDir),
};
});
describe('SkillManager Alias', () => {
let testRootDir: string;
beforeEach(async () => {
testRootDir = await fs.mkdtemp(
path.join(os.tmpdir(), 'skill-manager-alias-test-'),
);
});
afterEach(async () => {
await fs.rm(testRootDir, { recursive: true, force: true });
vi.restoreAllMocks();
});
it('should discover skills from .agents/skills directory', async () => {
const userGeminiDir = path.join(testRootDir, 'user', '.gemini', 'skills');
const userAgentDir = path.join(testRootDir, 'user', '.agents', 'skills');
const projectGeminiDir = path.join(
testRootDir,
'workspace',
'.gemini',
'skills',
);
const projectAgentDir = path.join(
testRootDir,
'workspace',
'.agents',
'skills',
);
await fs.mkdir(userGeminiDir, { recursive: true });
await fs.mkdir(userAgentDir, { recursive: true });
await fs.mkdir(projectGeminiDir, { recursive: true });
await fs.mkdir(projectAgentDir, { recursive: true });
vi.mocked(loadSkillsFromDir).mockImplementation(async (dir) => {
if (dir === userGeminiDir) {
return [
{
name: 'user-gemini',
description: 'desc',
location: 'loc',
body: '',
},
];
}
if (dir === userAgentDir) {
return [
{
name: 'user-agent',
description: 'desc',
location: 'loc',
body: '',
},
];
}
if (dir === projectGeminiDir) {
return [
{
name: 'project-gemini',
description: 'desc',
location: 'loc',
body: '',
},
];
}
if (dir === projectAgentDir) {
return [
{
name: 'project-agent',
description: 'desc',
location: 'loc',
body: '',
},
];
}
return [];
});
vi.spyOn(Storage, 'getUserSkillsDir').mockReturnValue(userGeminiDir);
vi.spyOn(Storage, 'getUserAgentSkillsDir').mockReturnValue(userAgentDir);
const storage = new Storage(path.join(testRootDir, 'workspace'));
vi.spyOn(storage, 'getProjectSkillsDir').mockReturnValue(projectGeminiDir);
vi.spyOn(storage, 'getProjectAgentSkillsDir').mockReturnValue(
projectAgentDir,
);
const service = new SkillManager();
// @ts-expect-error accessing private method for testing
vi.spyOn(service, 'discoverBuiltinSkills').mockResolvedValue(undefined);
await service.discoverSkills(storage, [], true);
const skills = service.getSkills();
expect(skills).toHaveLength(4);
const names = skills.map((s) => s.name);
expect(names).toContain('user-gemini');
expect(names).toContain('user-agent');
expect(names).toContain('project-gemini');
expect(names).toContain('project-agent');
});
it('should give .agents precedence over .gemini when in the same tier', async () => {
const userGeminiDir = path.join(testRootDir, 'user', '.gemini', 'skills');
const userAgentDir = path.join(testRootDir, 'user', '.agents', 'skills');
await fs.mkdir(userGeminiDir, { recursive: true });
await fs.mkdir(userAgentDir, { recursive: true });
vi.mocked(loadSkillsFromDir).mockImplementation(async (dir) => {
if (dir === userGeminiDir) {
return [
{
name: 'same-skill',
description: 'gemini-desc',
location: 'loc-gemini',
body: '',
},
];
}
if (dir === userAgentDir) {
return [
{
name: 'same-skill',
description: 'agent-desc',
location: 'loc-agent',
body: '',
},
];
}
return [];
});
vi.spyOn(Storage, 'getUserSkillsDir').mockReturnValue(userGeminiDir);
vi.spyOn(Storage, 'getUserAgentSkillsDir').mockReturnValue(userAgentDir);
const storage = new Storage('/dummy');
vi.spyOn(storage, 'getProjectSkillsDir').mockReturnValue(
'/non-existent-gemini',
);
vi.spyOn(storage, 'getProjectAgentSkillsDir').mockReturnValue(
'/non-existent-agent',
);
const service = new SkillManager();
// @ts-expect-error accessing private method for testing
vi.spyOn(service, 'discoverBuiltinSkills').mockResolvedValue(undefined);
await service.discoverSkills(storage, [], true);
const skills = service.getSkills();
expect(skills).toHaveLength(1);
expect(skills[0].description).toBe('agent-desc');
});
});
|