File size: 2,890 Bytes
a1b6014 | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 | import { act, cleanup, render } from '@testing-library/react'
import { afterEach, describe, expect, it, vi } from 'vitest'
// Regression coverage for #93479: a failed dynamic import of the lazily-loaded
// Shiki diff module (packaged asar/asar.unpacked path mismatch, or any other
// fetch failure) rejects the `React.lazy()` promise. React.Suspense only
// covers the *pending* state, so the rejection throws past it to the nearest
// error boundary — which in production is the whole workspace `ContribBoundary`
// — and blanks the transcript instead of degrading to the plain colored diff.
//
// The mock resolves to a component that throws the fetch error during render —
// the same way React surfaces a rejected lazy payload (a rejected import
// re-throws at render time). Do NOT throw inside the factory itself: a
// throwing factory leaves rejected promises in the vitest mocker registry,
// and under CI load one escapes as an "unhandled error during the test run"
// attributed to whichever sibling test file the worker is running (#94415).
vi.mock('./syntax-diff', () => ({
default: () => {
throw new Error(
'Failed to fetch dynamically imported module: file:///Hermes.app/Contents/Resources/app.asar/dist/assets/syntax-diff-Bo0962zh.js'
)
}
}))
import { ErrorBoundary } from '@/components/error-boundary'
import { FileDiffPanel } from './diff-lines'
afterEach(cleanup)
const DIFF = [
'diff --git a/file.ts b/file.ts',
'--- a/file.ts',
'+++ b/file.ts',
'@@ -1,2 +1,2 @@',
' const a = 1',
'-const b = 2',
'+const b = 3'
].join('\n')
const WORKSPACE_FALLBACK_TEXT = 'workspace failed to render'
// The failure surfaces only from console.error noise, not from the assertion.
function renderQuietly(node: Parameters<typeof render>[0]) {
const spy = vi.spyOn(console, 'error').mockImplementation(() => undefined)
try {
return render(node)
} finally {
spy.mockRestore()
}
}
describe('FileDiffPanel survives a failed lazy syntax-diff chunk', () => {
it('degrades to the plain colored diff instead of taking down the surrounding boundary', async () => {
const { container } = renderQuietly(
<ErrorBoundary fallback={() => <div>{WORKSPACE_FALLBACK_TEXT}</div>} label="workspace">
<FileDiffPanel diff={DIFF} path="file.ts" />
</ErrorBoundary>
)
// The rejection settles a tick after the initial Suspense-pending render
// (which coincidentally shows the same plain text already) — give it
// real time to propagate before asserting nothing regressed.
await act(() => new Promise(resolve => setTimeout(resolve, 300)))
expect(container.textContent).toContain('const a = 1')
expect(container.textContent).toContain('const b = 2')
expect(container.textContent).toContain('const b = 3')
expect(container.textContent).not.toContain(WORKSPACE_FALLBACK_TEXT)
})
})
|