File size: 3,510 Bytes
f0634fb | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 | import { afterEach, beforeEach, describe, expect, it } from 'vitest';
import { IAgentContextMemoryService } from '#/agent/contextMemory/contextMemory';
import type { ContextMessage } from '#/agent/contextMemory/types';
import { IAgentLoopService } from '#/agent/loop/loop';
import { IAgentToolRegistryService } from '#/agent/toolRegistry/toolRegistry';
import { IFlagService } from '#/app/flag/flag';
import { FlagService } from '#/app/flag/flagService';
import { NOTIFY_USER_FLAG_ID } from '#/features/notify/flag';
import { NOTIFY_USER_NUDGE_VARIANT } from '#/features/notify/notifyUserNudge';
import { NOTIFY_USER_TOOL_NAME } from '#/features/notify/tools/notify-user/notify-user';
import type { ExecutableTool } from '#/tool/toolContract';
import { runWillBeginStepHooks } from '../../agent/loop/stubs';
import { createTestAgent, type TestAgentContext } from '../../harness';
const notifyToolStub: ExecutableTool = {
name: NOTIFY_USER_TOOL_NAME,
description: 'stub',
parameters: { type: 'object', properties: {}, additionalProperties: false },
resolveExecution: () => ({
approvalRule: NOTIFY_USER_TOOL_NAME,
execute: async () => ({ output: 'ok' }),
}),
};
function messageText(message: ContextMessage): string {
return message.content.map((part) => (part.type === 'text' ? part.text : '')).join('');
}
describe('AgentNotifyUserNudgeService', () => {
let ctx: TestAgentContext;
let context: IAgentContextMemoryService;
let loop: IAgentLoopService;
let flags: FlagService;
function nudgeInjections(): readonly ContextMessage[] {
return context
.get()
.filter(
(message) =>
message.origin?.kind === 'injection' && message.origin.variant === NOTIFY_USER_NUDGE_VARIANT,
);
}
function appendSilentToolCalls(count: number): void {
for (let index = 0; index < count; index += 1) {
context.append({
role: 'assistant',
content: [],
toolCalls: [
{ type: 'function', id: `call_${String(index)}`, name: 'Bash', arguments: '{}' },
],
});
}
}
beforeEach(async () => {
ctx = createTestAgent({ autoConfigure: false });
context = ctx.get(IAgentContextMemoryService);
loop = ctx.get(IAgentLoopService);
flags = ctx.get(IFlagService) as FlagService;
flags.setConfigOverrides({ [NOTIFY_USER_FLAG_ID]: true });
const registry = ctx.get(IAgentToolRegistryService);
if (registry.resolve(NOTIFY_USER_TOOL_NAME) === undefined) registry.register(notifyToolStub);
await ctx.restorePersisted();
context.append({
role: 'user',
content: [{ type: 'text', text: 'do the thing' }],
toolCalls: [],
origin: { kind: 'user' },
});
ctx.configure();
});
afterEach(async () => {
try {
await ctx.expectResumeMatches();
} finally {
await ctx.dispose();
}
});
it('stops injecting nudges when the flag is disabled mid-session', async () => {
appendSilentToolCalls(8);
await runWillBeginStepHooks(loop);
expect(nudgeInjections()).toHaveLength(1);
expect(messageText(nudgeInjections()[0]!)).toContain('NotifyUser');
flags.setConfigOverrides({ [NOTIFY_USER_FLAG_ID]: false });
appendSilentToolCalls(8);
await runWillBeginStepHooks(loop);
expect(nudgeInjections()).toHaveLength(1);
flags.setConfigOverrides({ [NOTIFY_USER_FLAG_ID]: true });
appendSilentToolCalls(8);
await runWillBeginStepHooks(loop);
expect(nudgeInjections()).toHaveLength(2);
});
});
|