File size: 12,028 Bytes
f0634fb | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 293 294 295 296 297 298 299 300 301 302 303 304 | import { mkdirSync, writeFileSync } from 'node:fs';
import { join } from 'node:path';
import { stringify as stringifyToml } from 'smol-toml';
import { afterEach, beforeEach, describe, expect, it } from 'vitest';
import { type CollectionToken, type CollectionView } from '#/_base/di/collection';
import { SyncDescriptor } from '#/_base/di/descriptors';
import { DisposableStore } from '#/_base/di/lifecycle';
import { ScopeActivation } from '#/_base/di/instantiation';
import { type InstantiationService } from '#/_base/di/instantiationService';
import {
_clearScopedRegistryForTests,
registerScopedService,
type Scope,
} from '#/_base/di/scope';
import { TestInstantiationService, createScopedTestHost } from '#/_base/di/test';
import { ILogService } from '#/_base/log/log';
import { AgentProfileContribution } from '#/app/agentProfileCatalog/agentProfileContribution';
import { IBootstrapService } from '#/app/bootstrap/bootstrap';
import { IConfigRegistry, IConfigService } from '#/app/config/config';
import { ConfigRegistry, ConfigService } from '#/app/config/configService';
import { IFeatureManager } from '#/app/feature/featureManager';
import { FeatureManagerService } from '#/app/feature/featureManagerService';
import { EXPERIMENTAL_SECTION, IFlagService } from '#/app/flag/flag';
import { IFlagRegistry } from '#/app/flag/flagRegistry';
import { FlagRegistryService } from '#/app/flag/flagRegistryService';
import { FlagService, MASTER_ENV } from '#/app/flag/flagService';
import { LifecycleScope } from '#/app/scopes';
import { AgentToolContribution } from '#/agent/toolRegistry/toolContribution';
import { IFeatureAssemblyService } from '#/features/featureAssembly';
import { FeatureAssemblyService } from '#/features/featureAssemblyService';
import {
_clearFeatureRecipesForTests,
registerFeature,
} from '#/features/featureRegistry';
import { TOWER_FLAG_ENV } from '#/features/tower/flag';
import { TOWER_FLAG_ID } from '#/features/tower/tower';
import { ITowerRateLimitService } from '#/features/tower/towerRateLimit';
import {
TowerFeature,
isTowerFeatureAssembled,
} from '#/features/tower/towerFeature';
import { InMemoryStorageService } from '#/persistence/backends/memory/inMemoryStorageService';
import { TomlAtomicDocumentStore } from '#/persistence/backends/node-fs/atomicDocumentStore';
import { IAtomicTomlDocumentStore } from '#/persistence/interface/atomicDocumentStore';
import { IFileSystemStorageService } from '#/persistence/interface/storage';
import { stubFlag } from '../../app/flag/stubs';
import { stubBootstrap } from '../../app/bootstrap/stubs';
import { stubLog } from '../../_base/log/stubs';
function collectionViewOf<T>(scope: Scope, token: CollectionToken<T>): CollectionView<T> {
return (scope.instantiation as InstantiationService).fiberHost.collectionView(token);
}
describe('TowerFeature — experimental flag gating', () => {
beforeEach(() => {
_clearScopedRegistryForTests();
_clearFeatureRecipesForTests();
registerScopedService(
LifecycleScope.App,
IFeatureManager,
FeatureManagerService,
ScopeActivation.OnScopeCreated,
'feature',
);
registerScopedService(
LifecycleScope.App,
IFeatureAssemblyService,
FeatureAssemblyService,
ScopeActivation.OnScopeCreated,
'features',
);
registerFeature(TowerFeature);
});
it('assembles an empty unit when the tower flag is off', () => {
const host = createScopedTestHost([[IFlagService, stubFlag(false)]]);
const manager = host.app.accessor.get(IFeatureManager);
expect(manager.units().map((unit) => unit.name)).toEqual(['tower']);
expect(manager.contributedServices()).toHaveLength(0);
expect(collectionViewOf(host.app, AgentProfileContribution).items).toHaveLength(0);
const agent = host.child(LifecycleScope.Agent, 'agent-1');
expect(collectionViewOf(agent, AgentToolContribution).items).toHaveLength(0);
host.dispose();
});
it('contributes tools, profile, and rate-limit service when the tower flag is on', () => {
const host = createScopedTestHost([
[IFlagService, stubFlag((id) => id === TOWER_FLAG_ID)],
]);
const manager = host.app.accessor.get(IFeatureManager);
expect(
manager
.contributedServices()
.filter(
(entry) => entry.scope === LifecycleScope.App && entry.id === ITowerRateLimitService,
),
).toHaveLength(1);
const profiles = collectionViewOf(host.app, AgentProfileContribution).items;
expect(profiles).toHaveLength(1);
expect(profiles[0]!.sourceId).toBe('feature:tower');
const agent = host.child(LifecycleScope.Agent, 'agent-1');
const tools = collectionViewOf(agent, AgentToolContribution).items.map((record) =>
record.options.name,
);
expect(tools.toSorted()).toEqual(
[
'TowerFinding',
'TowerInbox',
'TowerInit',
'TowerMerge',
'TowerMission',
'TowerPlan',
'TowerReview',
'TowerSend',
'TowerSpawn',
'TowerStatus',
'TowerTeardown',
].toSorted(),
);
host.dispose();
});
it('clears the assembly marker when the feature unit unloads', async () => {
const flags = stubFlag((id) => id === TOWER_FLAG_ID);
const host = createScopedTestHost([[IFlagService, flags]]);
const manager = host.app.accessor.get(IFeatureManager);
expect(isTowerFeatureAssembled(flags)).toBe(true);
await manager.unprovideUnit('tower');
expect(isTowerFeatureAssembled(flags)).toBe(false);
host.dispose();
});
});
describe('TowerFeature — config-sourced flag assembly', () => {
let disposables: DisposableStore;
let homeDir: string;
beforeEach(() => {
disposables = new DisposableStore();
homeDir = `/tmp/kimi-code-tower-assembly-${process.pid}-${Date.now()}-${Math.random().toString(36).slice(2)}`;
_clearScopedRegistryForTests();
_clearFeatureRecipesForTests();
registerScopedService(
LifecycleScope.App,
IFeatureManager,
FeatureManagerService,
ScopeActivation.OnScopeCreated,
'feature',
);
registerScopedService(
LifecycleScope.App,
IFeatureAssemblyService,
FeatureAssemblyService,
ScopeActivation.OnScopeCreated,
'features',
);
registerFeature(TowerFeature);
});
afterEach(() => disposables.dispose());
async function makeRealFlags(preseed?: Record<string, unknown>) {
const ix = disposables.add(new TestInstantiationService());
ix.stub(IBootstrapService, stubBootstrap(homeDir));
ix.stub(ILogService, stubLog());
ix.stub(IFileSystemStorageService, new InMemoryStorageService());
ix.set(IAtomicTomlDocumentStore, new SyncDescriptor(TomlAtomicDocumentStore));
ix.set(IConfigRegistry, new SyncDescriptor(ConfigRegistry));
ix.set(IConfigService, new SyncDescriptor(ConfigService));
ix.set(IFlagRegistry, new SyncDescriptor(FlagRegistryService));
ix.set(IFlagService, new SyncDescriptor(FlagService));
if (preseed !== undefined) {
mkdirSync(homeDir, { recursive: true });
writeFileSync(join(homeDir, 'config.toml'), `${stringifyToml(preseed)}\n`);
await ix.get(IAtomicTomlDocumentStore).set('', 'config.toml', preseed);
}
return { config: ix.get(IConfigService), flags: ix.get(IFlagService) };
}
it('assembles a config-sourced flag at startup', async () => {
const { flags } = await makeRealFlags({ experimental: { [TOWER_FLAG_ID]: true } });
const host = createScopedTestHost([[IFlagService, flags]]);
expect(isTowerFeatureAssembled(flags)).toBe(true);
expect(flags.explain(TOWER_FLAG_ID)).toMatchObject({ enabled: true, source: 'config' });
const manager = host.app.accessor.get(IFeatureManager);
expect(
manager
.contributedServices()
.filter(
(entry) => entry.scope === LifecycleScope.App && entry.id === ITowerRateLimitService,
),
).toHaveLength(1);
const agent = host.child(LifecycleScope.Agent, 'agent-1');
expect(collectionViewOf(agent, AgentToolContribution).items).toHaveLength(11);
host.dispose();
});
it('does not assemble on a config flip after startup — a restart is required', async () => {
const { config, flags } = await makeRealFlags();
const host = createScopedTestHost([[IFlagService, flags]]);
const manager = host.app.accessor.get(IFeatureManager);
expect(manager.units().map((unit) => unit.name)).toEqual(['tower']);
expect(isTowerFeatureAssembled(flags)).toBe(false);
await config.set(EXPERIMENTAL_SECTION, { [TOWER_FLAG_ID]: true });
await new Promise((resolve) => setTimeout(resolve, 0));
expect(flags.enabled(TOWER_FLAG_ID)).toBe(true);
expect(isTowerFeatureAssembled(flags)).toBe(false);
expect(manager.contributedServices()).toHaveLength(0);
const agent = host.child(LifecycleScope.Agent, 'agent-1');
expect(collectionViewOf(agent, AgentToolContribution).items).toHaveLength(0);
host.dispose();
});
});
describe('tower flag — resolution', () => {
let disposables: DisposableStore;
let homeDir: string;
beforeEach(() => {
disposables = new DisposableStore();
homeDir = `/tmp/kimi-code-tower-flag-${process.pid}-${Date.now()}-${Math.random().toString(36).slice(2)}`;
});
afterEach(() => disposables.dispose());
function makeFlags(env: Readonly<Record<string, string | undefined>> = {}) {
const ix = disposables.add(new TestInstantiationService());
ix.stub(IBootstrapService, stubBootstrap(homeDir, env));
ix.stub(ILogService, stubLog());
ix.stub(IFileSystemStorageService, new InMemoryStorageService());
ix.set(IAtomicTomlDocumentStore, new SyncDescriptor(TomlAtomicDocumentStore));
ix.set(IConfigRegistry, new SyncDescriptor(ConfigRegistry));
ix.set(IConfigService, new SyncDescriptor(ConfigService));
ix.set(IFlagRegistry, new SyncDescriptor(FlagRegistryService));
ix.set(IFlagService, new SyncDescriptor(FlagService));
return { config: ix.get(IConfigService), flags: ix.get(IFlagService) };
}
it('is registered and disabled by default', () => {
const { flags } = makeFlags();
expect(flags.explain(TOWER_FLAG_ID)).toMatchObject({
id: TOWER_FLAG_ID,
env: TOWER_FLAG_ENV,
defaultEnabled: false,
enabled: false,
source: 'default',
});
});
it('is enabled by the dedicated env', () => {
const { flags } = makeFlags({ [TOWER_FLAG_ENV]: '1' });
expect(flags.explain(TOWER_FLAG_ID)).toMatchObject({
enabled: true,
source: 'env',
});
});
it('uses config unless the dedicated env overrides it', async () => {
const configured = makeFlags();
await configured.config.set(EXPERIMENTAL_SECTION, { [TOWER_FLAG_ID]: true });
expect(configured.flags.explain(TOWER_FLAG_ID)).toMatchObject({
enabled: true,
source: 'config',
configValue: true,
});
const overridden = makeFlags({ [TOWER_FLAG_ENV]: 'false' });
await overridden.config.set(EXPERIMENTAL_SECTION, { [TOWER_FLAG_ID]: true });
expect(overridden.flags.explain(TOWER_FLAG_ID)).toMatchObject({
enabled: false,
source: 'env',
configValue: true,
});
});
it('lets the master env turn the flag on only when env and config are unset', async () => {
const masterOnly = makeFlags({ [MASTER_ENV]: 'true' });
expect(masterOnly.flags.explain(TOWER_FLAG_ID)).toMatchObject({
enabled: true,
source: 'master-env',
});
const configured = makeFlags({ [MASTER_ENV]: 'true' });
await configured.config.set(EXPERIMENTAL_SECTION, { [TOWER_FLAG_ID]: false });
expect(configured.flags.explain(TOWER_FLAG_ID)).toMatchObject({
enabled: false,
source: 'config',
configValue: false,
});
const overridden = makeFlags({ [TOWER_FLAG_ENV]: 'false', [MASTER_ENV]: 'true' });
expect(overridden.flags.explain(TOWER_FLAG_ID)).toMatchObject({
enabled: false,
source: 'env',
});
});
});
|