File size: 4,953 Bytes
f778c12 | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 | /** Tests ACP manager session initialization and persisted runtime options. */
import { describe, expect, it } from "vitest";
import {
AcpSessionManager,
baseCfg,
createRuntime,
expectRecordFields,
extractRuntimeOptionsFromUpserts,
hoisted,
installAcpSessionManagerTestLifecycle,
mockCallArg,
readySessionMeta,
} from "./manager.test-helpers.js";
describe("AcpSessionManager initializeSession", () => {
installAcpSessionManagerTestLifecycle();
it("persists runtime options provided during initializeSession", async () => {
const runtimeState = createRuntime();
hoisted.requireAcpRuntimeBackendMock.mockReturnValue({
id: "acpx",
runtime: runtimeState.runtime,
});
hoisted.upsertAcpSessionMetaMock.mockResolvedValue({
sessionKey: "agent:codex:acp:session-a",
storeSessionKey: "agent:codex:acp:session-a",
acp: readySessionMeta({
runtimeOptions: {
model: "openai/gpt-5.4",
thinking: "high",
},
}),
});
const manager = new AcpSessionManager();
await manager.initializeSession({
cfg: baseCfg,
sessionKey: "agent:codex:acp:session-a",
agent: "codex",
mode: "persistent",
runtimeOptions: {
model: "openai/gpt-5.4",
thinking: "high",
},
});
expect(extractRuntimeOptionsFromUpserts()).toEqual([
{
model: "openai/gpt-5.4",
thinking: "high",
},
]);
expectRecordFields(mockCallArg(runtimeState.ensureSession), {
sessionKey: "agent:codex:acp:session-a",
model: "openai/gpt-5.4",
thinking: "high",
});
});
it("forwards inherited thinking provenance and omits thinking dropped by the backend", async () => {
const runtimeState = createRuntime();
runtimeState.ensureSession.mockResolvedValueOnce({
sessionKey: "agent:codex:acp:session-inherited-max",
backend: "acpx",
runtimeSessionName: "codex",
appliedThinking: { kind: "dropped" },
});
hoisted.requireAcpRuntimeBackendMock.mockReturnValue({
id: "acpx",
runtime: runtimeState.runtime,
});
hoisted.upsertAcpSessionMetaMock.mockResolvedValue({
sessionKey: "agent:codex:acp:session-inherited-max",
storeSessionKey: "agent:codex:acp:session-inherited-max",
acp: readySessionMeta(),
});
const manager = new AcpSessionManager();
await manager.initializeSession({
cfg: baseCfg,
sessionKey: "agent:codex:acp:session-inherited-max",
agent: "codex",
mode: "persistent",
runtimeOptions: { thinking: "max" },
thinkingExplicit: false,
});
expectRecordFields(mockCallArg(runtimeState.ensureSession), {
thinking: "max",
thinkingExplicit: false,
});
expect(extractRuntimeOptionsFromUpserts()).toEqual([undefined]);
});
it("preserves runtimeOptions cwd when initializeSession cwd is omitted", async () => {
const runtimeState = createRuntime();
hoisted.requireAcpRuntimeBackendMock.mockReturnValue({
id: "acpx",
runtime: runtimeState.runtime,
});
hoisted.upsertAcpSessionMetaMock.mockResolvedValue({
sessionKey: "agent:codex:acp:session-cwd-runtime-options",
storeSessionKey: "agent:codex:acp:session-cwd-runtime-options",
acp: readySessionMeta({
runtimeOptions: {
cwd: "/workspace/from-runtime-options",
},
cwd: "/workspace/from-runtime-options",
}),
});
const manager = new AcpSessionManager();
await manager.initializeSession({
cfg: baseCfg,
sessionKey: "agent:codex:acp:session-cwd-runtime-options",
agent: "codex",
mode: "persistent",
runtimeOptions: {
cwd: "/workspace/from-runtime-options",
},
});
expectRecordFields(mockCallArg(runtimeState.ensureSession), {
sessionKey: "agent:codex:acp:session-cwd-runtime-options",
cwd: "/workspace/from-runtime-options",
});
expect(extractRuntimeOptionsFromUpserts()).toEqual([
{
cwd: "/workspace/from-runtime-options",
},
]);
});
it("rolls back ensured runtime sessions when metadata persistence fails", async () => {
const runtimeState = createRuntime();
hoisted.requireAcpRuntimeBackendMock.mockReturnValue({
id: "acpx",
runtime: runtimeState.runtime,
});
hoisted.upsertAcpSessionMetaMock.mockRejectedValueOnce(new Error("disk full"));
const manager = new AcpSessionManager();
await expect(
manager.initializeSession({
cfg: baseCfg,
sessionKey: "agent:codex:acp:session-1",
agent: "codex",
mode: "persistent",
}),
).rejects.toThrow("disk full");
const closeInput = mockCallArg(runtimeState.close);
expectRecordFields(closeInput, {
reason: "init-meta-failed",
});
expectRecordFields(closeInput.handle, {
sessionKey: "agent:codex:acp:session-1",
});
});
});
|