File size: 4,263 Bytes
e249c6d | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 | // Covers assistant error formatting for streaming, sandbox, and context errors.
import type { AssistantMessage } from "openclaw/plugin-sdk/llm";
import { beforeEach, describe, expect, it, vi } from "vitest";
import type { OpenClawConfig } from "../../config/types.openclaw.js";
import { MALFORMED_STREAMING_FRAGMENT_ERROR_MESSAGE } from "../../shared/assistant-error-format.js";
import { makeAssistantMessageFixture } from "../test-helpers/assistant-message-fixtures.js";
import { formatAssistantErrorText, formatUserFacingAssistantErrorText } from "./error-text.js";
const { toolPolicyAuditInfo } = vi.hoisted(() => ({
toolPolicyAuditInfo: vi.fn(),
}));
vi.mock("../../logging/subsystem.js", () => ({
createSubsystemLogger: () => ({
debug: vi.fn(),
error: vi.fn(),
info: toolPolicyAuditInfo,
warn: vi.fn(),
}),
}));
describe("formatAssistantErrorText streaming JSON parse classification", () => {
beforeEach(() => {
toolPolicyAuditInfo.mockClear();
});
const makeAssistantError = (errorMessage: string): AssistantMessage =>
makeAssistantMessageFixture({
errorMessage,
content: [{ type: "text", text: errorMessage }],
});
it("suppresses transport-classified malformed streaming fragments", () => {
// Transport JSON fragmentation is not user-authored content and should get
// stable retry copy instead of raw parser text.
const msg = makeAssistantError(MALFORMED_STREAMING_FRAGMENT_ERROR_MESSAGE);
expect(formatAssistantErrorText(msg)).toBe(
"LLM streaming response contained a malformed fragment. Please try again.",
);
});
it("does not suppress unclassified JSON.parse text", () => {
const msg = makeAssistantError(
"Expected ',' or '}' after property value in JSON at position 334 (line 1 column 335)",
);
expect(formatAssistantErrorText(msg)).toBe(
"Expected ',' or '}' after property value in JSON at position 334 (line 1 column 335)",
);
});
it.each(["request timed out", "LLM request timed out."])(
"preserves safe user-facing timeout copy for provider error %j",
(errorMessage) => {
expect(formatUserFacingAssistantErrorText(makeAssistantError(errorMessage))).toBe(
"LLM request timed out.",
);
},
);
it("keeps non-streaming provider request-validation syntax diagnostics", () => {
const msg = makeAssistantError(
'{"type":"error","error":{"type":"invalid_request_error","message":"Expected value in JSON at position 12 for messages.0.content"}}',
);
expect(formatAssistantErrorText(msg)).toBe(
"LLM request rejected: Expected value in JSON at position 12 for messages.0.content",
);
});
it.each([
{ sessionKey: "agent:main:mobilechat:g1", agentId: "main", mode: "non-main" as const },
{ sessionKey: "global", agentId: "worker", mode: "all" as const },
])(
"audits a sandbox tool-policy block once per assistant error for $sessionKey",
({ sessionKey, agentId, mode }) => {
// Formatting may be called multiple times for the same error; audit logs
// should stay deduplicated per blocked assistant error.
const cfg: OpenClawConfig = {
agents: {
defaults: {
sandbox: { mode, scope: "agent" },
},
entries: { main: {}, worker: {} },
},
tools: {
sandbox: {
tools: {
deny: ["browser"],
},
},
},
};
const msg = makeAssistantError("unknown tool: browser");
expect(formatAssistantErrorText(msg, { cfg, sessionKey, agentId })).toContain(
`--agent ${agentId}`,
);
expect(formatAssistantErrorText(msg, { cfg, sessionKey, agentId })).toContain(
'Tool "browser" blocked by sandbox tool policy',
);
expect(toolPolicyAuditInfo).toHaveBeenCalledTimes(1);
expect(toolPolicyAuditInfo).toHaveBeenCalledWith(
"sandbox tool policy blocked browser via tools.sandbox.tools.deny; matched browser",
{
tool: "browser",
ruleKind: "deny",
ruleSource: "global",
configKey: "tools.sandbox.tools.deny",
matchedRule: "browser",
sandboxMode: mode,
},
);
},
);
});
|