File size: 4,742 Bytes
4c76b0d | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 | import { describe, expect, it, vi } from "vitest";
import { withPluginRuntimeGatewayRequestScope } from "../../../plugins/runtime/gateway-request-scope.js";
import {
cleanupProvisionalSession,
terminateAcceptedCollectorRun,
} from "./subagent-spawn-cleanup.js";
function sessionChangedError(): Error {
return Object.assign(new Error("session changed"), {
name: "GatewayClientRequestError",
gatewayCode: "INVALID_REQUEST",
details: { reason: "session-changed" },
});
}
describe("subagent spawn cleanup identity", () => {
it("requires both frozen session identities before deletion", async () => {
const callGateway = vi.fn();
await expect(
cleanupProvisionalSession("agent:main:subagent:child", {
expectedSessionId: "session-id",
callGateway,
}),
).resolves.toBe(false);
expect(callGateway).not.toHaveBeenCalled();
});
it("accepts chat.abort only when it confirms the exact run", async () => {
const callGateway = vi
.fn()
.mockResolvedValueOnce({ ok: true, aborted: false, runIds: [] })
.mockResolvedValueOnce({ deleted: true });
await terminateAcceptedCollectorRun({
childSessionKey: "agent:main:subagent:child",
gatewayRunId: "gateway-run",
expectedSessionId: "session-id",
expectedLifecycleRevision: "session-revision",
callGateway,
});
expect(callGateway).toHaveBeenNthCalledWith(2, {
method: "sessions.delete",
params: {
key: "agent:main:subagent:child",
emitLifecycleHooks: false,
deleteTranscript: true,
expectedSessionId: "session-id",
expectedLifecycleRevision: "session-revision",
},
timeoutMs: 60_000,
});
});
it("does not delete after chat.abort confirms the matching run", async () => {
const callGateway = vi.fn(async () => ({
ok: true,
aborted: true,
runIds: ["gateway-run"],
}));
await terminateAcceptedCollectorRun({
childSessionKey: "agent:main:subagent:child",
gatewayRunId: "gateway-run",
expectedSessionId: "session-id",
expectedLifecycleRevision: "session-revision",
callGateway,
});
expect(callGateway).toHaveBeenCalledOnce();
});
it("stops without deleting a durable session when the accepted run already ended", async () => {
const callGateway = vi.fn(async () => ({
ok: true,
aborted: false,
runIds: [],
}));
await terminateAcceptedCollectorRun({
childSessionKey: "agent:main:subagent:child",
gatewayRunId: "gateway-run",
sessionCleanup: "preserve",
callGateway,
});
expect(callGateway).toHaveBeenCalledOnce();
});
it("retries abort without deleting a durable session after a gateway error", async () => {
const callGateway = vi
.fn()
.mockRejectedValueOnce(new Error("gateway unavailable"))
.mockResolvedValueOnce({ ok: true, aborted: false, runIds: [] });
await terminateAcceptedCollectorRun({
childSessionKey: "agent:main:subagent:child",
gatewayRunId: "gateway-run",
sessionCleanup: "preserve",
callGateway,
});
expect(callGateway).toHaveBeenCalledTimes(2);
expect(callGateway).toHaveBeenNthCalledWith(2, {
method: "chat.abort",
params: {
sessionKey: "agent:main:subagent:child",
runId: "gateway-run",
},
timeoutMs: 60_000,
});
});
it("stops accepted-run cleanup when its Gateway request owner is retired", async () => {
const callGateway = vi
.fn()
.mockRejectedValueOnce(new Error("Gateway request owner is retired"))
.mockResolvedValue({ aborted: false, runIds: [] });
await withPluginRuntimeGatewayRequestScope(
{ resolveGatewayContext: () => undefined, isWebchatConnect: () => false },
() =>
terminateAcceptedCollectorRun({
childSessionKey: "agent:main:subagent:child",
gatewayRunId: "gateway-run",
sessionCleanup: "preserve",
callGateway,
}),
);
expect(callGateway).toHaveBeenCalledOnce();
});
it("stops cleanup when guarded deletion observes a successor lifecycle", async () => {
const callGateway = vi
.fn()
.mockResolvedValueOnce({ ok: true, aborted: true, runIds: ["different-run"] })
.mockRejectedValueOnce(sessionChangedError());
await expect(
terminateAcceptedCollectorRun({
childSessionKey: "agent:main:subagent:child",
gatewayRunId: "gateway-run",
expectedSessionId: "session-id",
expectedLifecycleRevision: "session-revision",
callGateway,
}),
).resolves.toBeUndefined();
expect(callGateway).toHaveBeenCalledTimes(2);
});
});
|