File size: 10,587 Bytes
4c76b0d | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 | // Subagent spawn depth-limit tests cover max depth, per-parent child limits,
// inherited tool policy, and preflight failures before gateway dispatch.
import { beforeAll, beforeEach, describe, expect, it, vi } from "vitest";
import {
createSubagentSpawnTestConfig,
installSessionStoreCaptureMock,
loadSubagentSpawnModuleForTest,
setupAcceptedSubagentGatewayMock,
} from "./subagent-spawn.test-helpers.js";
const hoisted = vi.hoisted(() => ({
activeChildrenBySession: new Map<string, number>(),
callGatewayMock: vi.fn(),
configOverride: {} as Record<string, unknown>,
depthBySession: new Map<string, number>(),
updateSessionStoreMock: vi.fn(),
loadSessionStoreMock: vi.fn(),
registerSubagentRunMock: vi.fn(),
}));
let spawnSubagentDirect: typeof import("./subagent-spawn.js").spawnSubagentDirect;
let persistedStore: Record<string, Record<string, unknown>> | undefined;
type SpawnResult = Awaited<ReturnType<typeof spawnSubagentDirect>>;
type AcceptedSpawnResult = SpawnResult & {
childSessionKey: string;
runId: string;
status: "accepted";
};
function createDepthLimitConfig(subagents?: Record<string, unknown>) {
return createSubagentSpawnTestConfig("/tmp/workspace-main", {
agents: {
defaults: {
workspace: "/tmp/workspace-main",
subagents: {
maxSpawnDepth: 1,
...subagents,
},
},
},
});
}
async function spawnFrom(sessionKey: string, params?: Record<string, unknown>) {
return await spawnSubagentDirect(
{
task: "hello",
...params,
},
{
agentSessionKey: sessionKey,
workspaceDir: "/tmp/workspace-main",
},
);
}
function expectForbidden(result: SpawnResult, error: string) {
expect(result.status).toBe("forbidden");
if (result.status !== "forbidden") {
throw new Error(`Expected forbidden spawn result, received ${result.status}`);
}
expect(result.error).toBe(error);
}
function expectAccepted(result: SpawnResult, runId: string): AcceptedSpawnResult {
expect(result.status).toBe("accepted");
if (result.status !== "accepted") {
throw new Error(`Expected accepted spawn result, received ${result.status}`);
}
expect(result.runId).toBe(runId);
expect(typeof result.childSessionKey).toBe("string");
return result as AcceptedSpawnResult;
}
describe("subagent spawn depth + child limits", () => {
beforeAll(async () => {
({ spawnSubagentDirect } = await loadSubagentSpawnModuleForTest({
callGatewayMock: hoisted.callGatewayMock,
getRuntimeConfig: () => hoisted.configOverride,
registerSubagentRunMock: hoisted.registerSubagentRunMock,
updateSessionStoreMock: hoisted.updateSessionStoreMock,
loadSessionStoreMock: hoisted.loadSessionStoreMock,
getSubagentDepthFromSessionStore: (sessionKey) => hoisted.depthBySession.get(sessionKey) ?? 0,
countActiveRunsForSession: (sessionKey) =>
hoisted.activeChildrenBySession.get(sessionKey) ?? 0,
resetModules: false,
}));
});
beforeEach(() => {
hoisted.activeChildrenBySession.clear();
hoisted.depthBySession.clear();
hoisted.callGatewayMock.mockClear();
hoisted.registerSubagentRunMock.mockClear();
hoisted.updateSessionStoreMock.mockReset();
hoisted.loadSessionStoreMock.mockReturnValue({
"agent:main:subagent:parent": { sessionId: "nested-parent", updatedAt: 1 },
});
persistedStore = undefined;
installSessionStoreCaptureMock(hoisted.updateSessionStoreMock, {
onStore: (store) => {
persistedStore = store;
},
});
hoisted.configOverride = createDepthLimitConfig();
setupAcceptedSubagentGatewayMock(hoisted.callGatewayMock);
});
it.each([undefined, "parent"] as const)(
"rejects spawning at max depth (completionTarget=%s)",
async (completionTarget) => {
hoisted.depthBySession.set("agent:main:subagent:parent", 1);
const result = await spawnFrom("agent:main:subagent:parent", { completionTarget });
expectForbidden(
result,
"sessions_spawn is not allowed at this depth (current depth: 1, max: 1; agents.defaults.subagents.maxSpawnDepth).",
);
expect(hoisted.registerSubagentRunMock).not.toHaveBeenCalled();
expect(hoisted.updateSessionStoreMock).not.toHaveBeenCalled();
},
);
it("checks depth before collector group validation", async () => {
hoisted.configOverride = {
...createDepthLimitConfig(),
tools: { swarm: { enabled: true } },
};
hoisted.depthBySession.set("agent:main:subagent:parent", 1);
const result = await spawnFrom("agent:main:subagent:parent", { collect: true });
expectForbidden(
result,
"sessions_spawn is not allowed at this depth (current depth: 1, max: 1; agents.defaults.subagents.maxSpawnDepth).",
);
});
it.each([undefined, "parent"] as const)(
"allows depth-1 callers below max depth (completionTarget=%s)",
async (completionTarget) => {
hoisted.configOverride = createDepthLimitConfig({ maxSpawnDepth: 2 });
hoisted.depthBySession.set("agent:main:subagent:parent", 1);
const result = await spawnFrom("agent:main:subagent:parent", { completionTarget });
const accepted = expectAccepted(result, "run-1");
expect(accepted.childSessionKey).toMatch(/^agent:main:subagent:/);
expect(accepted.completionTarget).toBe(completionTarget);
expect(hoisted.registerSubagentRunMock).toHaveBeenCalledWith(
expect.objectContaining({
completionTarget,
completionRequesterSessionId: completionTarget ? "nested-parent" : undefined,
}),
);
// Child capability flags are stored on the session entry so later control
// tools can enforce leaf behavior without recalculating spawn depth.
const childSession = persistedStore?.[accepted.childSessionKey];
if (!childSession) {
throw new Error("Expected persisted child session");
}
expect(childSession.spawnedBy).toBe("agent:main:subagent:parent");
expect(childSession.spawnDepth).toBe(2);
expect(childSession.subagentRole).toBe("leaf");
expect(childSession.subagentControlScope).toBe("none");
expect(typeof childSession?.spawnedWorkspaceDir).toBe("string");
},
);
it("allows recursive callers below the default depth boundary", async () => {
hoisted.configOverride = createSubagentSpawnTestConfig("/tmp/workspace-main", {
agents: { defaults: { workspace: "/tmp/workspace-main" } },
});
hoisted.depthBySession.set("agent:main:subagent:deep-parent", 3);
const result = await spawnFrom("agent:main:subagent:deep-parent");
const accepted = expectAccepted(result, "run-1");
const childSession = persistedStore?.[accepted.childSessionKey];
if (!childSession) {
throw new Error("Expected persisted child session");
}
expect(childSession.spawnDepth).toBe(4);
expect(childSession.subagentRole).toBe("orchestrator");
expect(childSession.subagentControlScope).toBe("children");
});
it("persists inherited tool denies on spawned child sessions", async () => {
hoisted.configOverride = createDepthLimitConfig({ maxSpawnDepth: 2 });
const result = await spawnSubagentDirect(
{
task: "hello",
},
{
agentSessionKey: "agent:main:main",
workspaceDir: "/tmp/workspace-main",
inheritedToolAllowlist: ["sessions_spawn", "read", ""],
inheritedToolDenylist: ["bash", "exec", "read", ""],
},
);
const accepted = expectAccepted(result, "run-1");
const childSession = persistedStore?.[accepted.childSessionKey];
if (!childSession) {
throw new Error("Expected persisted child session");
}
expect(childSession.inheritedToolAllow).toEqual(["sessions_spawn", "read"]);
expect(childSession.inheritedToolDeny).toEqual(["exec", "read"]);
expect(childSession.inheritedToolPolicyVersion).toBe(1);
});
it("rejects callers when stored spawn depth is already at the configured max", async () => {
hoisted.configOverride = createDepthLimitConfig({ maxSpawnDepth: 2 });
hoisted.depthBySession.set("agent:main:subagent:flat-depth-2", 2);
const result = await spawnFrom("agent:main:subagent:flat-depth-2");
expectForbidden(
result,
"sessions_spawn is not allowed at this depth (current depth: 2, max: 2; agents.defaults.subagents.maxSpawnDepth).",
);
});
it.each([undefined, "parent"] as const)(
"rejects at the child cap (completionTarget=%s)",
async (completionTarget) => {
hoisted.configOverride = createDepthLimitConfig({
maxSpawnDepth: 2,
maxChildrenPerAgent: 1,
});
hoisted.depthBySession.set("agent:main:subagent:parent", 1);
hoisted.activeChildrenBySession.set("agent:main:subagent:parent", 1);
const result = await spawnFrom("agent:main:subagent:parent", { completionTarget });
expectForbidden(
result,
"sessions_spawn has reached max active children for this session (1/1; agents.defaults.subagents.maxChildrenPerAgent).",
);
expect(hoisted.registerSubagentRunMock).not.toHaveBeenCalled();
expect(hoisted.updateSessionStoreMock).not.toHaveBeenCalled();
},
);
it("does not use subagent maxConcurrent as a per-parent spawn gate", async () => {
hoisted.configOverride = createDepthLimitConfig({
maxSpawnDepth: 2,
maxChildrenPerAgent: 5,
maxConcurrent: 1,
});
hoisted.depthBySession.set("agent:main:subagent:parent", 1);
hoisted.activeChildrenBySession.set("agent:main:subagent:parent", 1);
const result = await spawnFrom("agent:main:subagent:parent");
expectAccepted(result, "run-1");
});
it("fails spawn when the initial child session patch rejects the model", async () => {
hoisted.configOverride = createDepthLimitConfig({ maxSpawnDepth: 2 });
hoisted.callGatewayMock.mockImplementation(
async (opts: { method?: string; params?: { model?: string } }) => {
if (opts.method === "agent") {
return { runId: "run-depth" };
}
return {};
},
);
hoisted.updateSessionStoreMock.mockRejectedValueOnce(new Error("invalid model: bad-model"));
const result = await spawnFrom("main", { model: "bad-model" });
expect(result.status).toBe("error");
expect(result.error ?? "").toContain("invalid model");
expect(
hoisted.callGatewayMock.mock.calls.some(
(call) => (call[0] as { method?: string }).method === "agent",
),
).toBe(false);
});
});
|