File size: 6,097 Bytes
78d0c37 | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 | import { expectDefined } from "@openclaw/normalization-core";
import { beforeEach, describe, expect, it, vi } from "vitest";
import { ErrorCodes } from "../../../packages/gateway-protocol/src/index.js";
import { agentHandlers } from "./agent.js";
import {
mockDeletedAgentSession,
resetDeletedAgentSessionMocks,
} from "./deleted-agent-guard.test-helpers.js";
import type { RespondFn } from "./types.js";
const agentCommandFromIngressMock = vi.hoisted(() => vi.fn());
const performGatewaySessionResetMock = vi.hoisted(() => vi.fn());
const parseMessageWithAttachmentsMock = vi.hoisted(() => vi.fn());
vi.mock("../../commands/agent.js", () => ({
agentCommandFromGatewayIngress: agentCommandFromIngressMock,
agentCommandFromIngress: agentCommandFromIngressMock,
}));
vi.mock("../session-reset-service.js", () => ({
performGatewaySessionReset: performGatewaySessionResetMock,
emitGatewaySessionEndPluginHook: vi.fn(),
emitGatewaySessionStartPluginHook: vi.fn(),
}));
vi.mock("../chat-attachments.js", async () => {
const actual =
await vi.importActual<typeof import("../chat-attachments.js")>("../chat-attachments.js");
return {
...actual,
parseMessageWithAttachments: parseMessageWithAttachmentsMock,
};
});
describe("agent RPC deleted-agent guard", () => {
beforeEach(() => {
resetDeletedAgentSessionMocks();
agentCommandFromIngressMock.mockReset();
performGatewaySessionResetMock.mockReset();
parseMessageWithAttachmentsMock.mockReset();
});
it("rejects keys belonging to a deleted agent", async () => {
const orphanKey = mockDeletedAgentSession();
const respond = vi.fn() as unknown as RespondFn;
await expectDefined(agentHandlers.agent, "agentHandlers.agent test invariant").call(
agentHandlers,
{
req: { id: "req-1" } as never,
params: {
sessionKey: orphanKey,
message: "hi",
idempotencyKey: "run-1",
},
respond,
context: {
dedupe: new Map(),
chatAbortControllers: new Map(),
getRuntimeConfig: () => ({}),
} as never,
client: null,
isWebchatConnect: () => false,
},
);
expect(respond).toHaveBeenCalledWith(false, undefined, {
code: ErrorCodes.INVALID_REQUEST,
message: 'Agent "deleted-agent" no longer exists in configuration',
});
expect(agentCommandFromIngressMock).not.toHaveBeenCalled();
});
it("rejects deleted-agent sessions before media offload or dedupe reservation", async () => {
const orphanKey = mockDeletedAgentSession();
const respond = vi.fn() as unknown as RespondFn;
const dedupe = new Map();
await expectDefined(agentHandlers.agent, "agentHandlers.agent test invariant").call(
agentHandlers,
{
req: { id: "req-attach" } as never,
params: {
sessionKey: orphanKey,
message: "see attachment",
idempotencyKey: "run-attach",
attachments: [
{ type: "file", mimeType: "application/pdf", fileName: "doc.pdf", content: "aGVsbG8=" },
],
},
respond,
context: {
dedupe,
chatAbortControllers: new Map(),
getRuntimeConfig: () => ({}),
} as never,
client: null,
isWebchatConnect: () => false,
},
);
expect(respond).toHaveBeenCalledWith(false, undefined, {
code: ErrorCodes.INVALID_REQUEST,
message: 'Agent "deleted-agent" no longer exists in configuration',
});
expect(parseMessageWithAttachmentsMock).not.toHaveBeenCalled();
expect(dedupe.size).toBe(0);
expect(agentCommandFromIngressMock).not.toHaveBeenCalled();
});
it.each(["/reset", "/reset follow up"])(
"rejects deleted-agent session keys before %s handling",
async (message) => {
const orphanKey = mockDeletedAgentSession();
const respond = vi.fn() as unknown as RespondFn;
await expectDefined(agentHandlers.agent, "agentHandlers.agent test invariant").call(
agentHandlers,
{
req: { id: "req-reset" } as never,
params: {
sessionKey: orphanKey,
message,
idempotencyKey: `run-reset-${message}`,
},
respond,
context: {
dedupe: new Map(),
chatAbortControllers: new Map(),
getRuntimeConfig: () => ({}),
} as never,
client: { connect: { scopes: ["operator.admin"] } } as never,
isWebchatConnect: () => false,
},
);
expect(respond).toHaveBeenCalledWith(false, undefined, {
code: ErrorCodes.INVALID_REQUEST,
message: 'Agent "deleted-agent" no longer exists in configuration',
});
expect(performGatewaySessionResetMock).not.toHaveBeenCalled();
expect(agentCommandFromIngressMock).not.toHaveBeenCalled();
},
);
it("rejects deleted-agent sessions before stale exec followup dedupe", async () => {
const orphanKey = mockDeletedAgentSession();
const respond = vi.fn() as unknown as RespondFn;
const dedupe = new Map();
await expectDefined(agentHandlers.agent, "agentHandlers.agent test invariant").call(
agentHandlers,
{
req: { id: "req-followup" } as never,
params: {
sessionKey: orphanKey,
message: "approval followup",
idempotencyKey: "exec-approval-followup:req-followup",
execApprovalFollowupExpectedSessionId: "old-session",
},
respond,
context: {
dedupe,
chatAbortControllers: new Map(),
getRuntimeConfig: () => ({}),
} as never,
client: { connect: { client: { mode: "backend" } } } as never,
isWebchatConnect: () => false,
},
);
expect(respond).toHaveBeenCalledWith(false, undefined, {
code: ErrorCodes.INVALID_REQUEST,
message: 'Agent "deleted-agent" no longer exists in configuration',
});
expect(dedupe.size).toBe(0);
expect(agentCommandFromIngressMock).not.toHaveBeenCalled();
});
});
|