File size: 24,635 Bytes
d197cf3
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
513
514
515
516
517
518
519
520
521
522
523
524
525
526
527
528
529
530
531
532
533
534
535
536
537
538
539
540
541
542
543
544
545
546
547
548
549
550
551
552
553
554
555
556
557
558
559
560
561
562
563
564
565
566
567
568
569
570
571
572
573
574
575
576
577
578
579
580
581
582
583
584
585
586
587
588
589
590
591
592
593
594
595
596
597
598
599
600
601
602
603
604
605
606
607
608
609
610
611
612
613
614
615
616
617
618
619
620
621
622
623
624
625
626
627
628
629
630
631
632
633
634
635
636
637
638
639
640
641
642
643
644
645
646
647
648
649
650
651
652
653
654
655
656
657
658
659
660
661
662
663
664
665
666
667
668
669
670
671
672
673
674
675
676
677
678
679
680
681
682
683
684
685
686
687
688
689
690
691
692
693
694
695
696
697
698
699
700
701
702
703
704
705
706
707
708
709
710
711
712
713
714
715
716
717
718
719
720
721
722
723
724
725
726
727
728
729
730
731
732
733
734
735
736
// Hook install service installs hook packages from archives and local sources.

import path from "node:path";
import { normalizeTrimmedStringList } from "@openclaw/normalization-core/string-normalization";
import { MANIFEST_KEY } from "../compat/legacy-names.js";
import {
  copyPackageDirInstallTransactionRequest,
  hasPackageRuntimeDependencies,
} from "../infra/install-package-dir.js";
import { resolveSafeInstallDir, unscopedPackageName } from "../infra/install-safe-path.js";
import type { NpmIntegrityDrift, NpmSpecResolution } from "../infra/install-source-utils.js";
import { readRegularFile } from "../infra/regular-file.js";
import { detectBundleManifestFormat } from "../plugins/bundle-manifest.js";
import {
  scanPackageInstallSource,
  scanInstalledPackageDependencyTree,
  type InstallSafetyOverrides,
} from "../plugins/install-security-scan.js";
import { PLUGIN_MANIFEST_FILENAME } from "../plugins/manifest.js";
import type { InstallPolicySource } from "../security/install-policy.js";
import { createLazyRuntimeModule } from "../shared/lazy-runtime.js";
import { CONFIG_DIR, resolveUserPath } from "../utils.js";
import { parseHookFrontmatter } from "./frontmatter.js";

// HOOK.md is only parsed for frontmatter; a small cap prevents a malicious or
// malformed hook package from OOMing the install path.
const HOOK_MD_MAX_BYTES = 1024 * 1024;

const loadHookInstallRuntime = createLazyRuntimeModule(() => import("./install.runtime.js"));

/** Logger contract used by hook install and update operations. */
type HookInstallLogger = {
  info?: (message: string) => void;
  warn?: (message: string) => void;
};

type HookPackageManifest = {
  name?: string;
  version?: string;
  dependencies?: Record<string, string>;
  optionalDependencies?: Record<string, string>;
} & Partial<Record<typeof MANIFEST_KEY, { extensions?: string[]; hooks?: string[] }>>;

export type InstallHooksResult =
  | {
      ok: true;
      hookPackId: string;
      hooks: string[];
      packageKind?: "hook-only" | "plugin-capable";
      targetDir: string;
      version?: string;
      npmResolution?: NpmSpecResolution;
      integrityDrift?: NpmIntegrityDrift;
    }
  | {
      ok: false;
      error: string;
      code?: string;
    };

export const HOOK_INSTALL_ERROR_CODE = {
  MISSING_OPENCLAW_HOOKS: "missing_openclaw_hooks",
  EMPTY_OPENCLAW_HOOKS: "empty_openclaw_hooks",
} as const;

type HookInstallErrorCode = (typeof HOOK_INSTALL_ERROR_CODE)[keyof typeof HOOK_INSTALL_ERROR_CODE];

/** Integrity drift payload surfaced when npm metadata no longer matches an install record. */
export type HookNpmIntegrityDriftParams = {
  spec: string;
  expectedIntegrity: string;
  actualIntegrity: string;
  resolution: NpmSpecResolution;
};

const defaultLogger: HookInstallLogger = {};

type HookInstallForwardParams = InstallSafetyOverrides & {
  hooksDir?: string;
  timeoutMs?: number;
  logger?: HookInstallLogger;
  mode?: "install" | "update";
  dryRun?: boolean;
  expectedHookPackId?: string;
  expectedPackageKind?: "hook-only";
  inspection?: "package-kind";
  beforePersistentApply?: () => void;
  installPolicyRequest?: {
    kind: "plugin-archive" | "plugin-dir" | "plugin-npm";
    requestedSpecifier: string;
    source: InstallPolicySource;
  };
};

type HookPackageInstallParams = { packageDir: string } & HookInstallForwardParams;
type HookArchiveInstallParams = { archivePath: string } & HookInstallForwardParams;
type HookPathInstallParams = { path: string } & HookInstallForwardParams;

function buildHookInstallForwardParams(params: HookInstallForwardParams): HookInstallForwardParams {
  return copyPackageDirInstallTransactionRequest(params, {
    config: params.config,
    onInstallPolicyWarning: params.onInstallPolicyWarning,
    trustedSourceLinkedOfficialInstall: params.trustedSourceLinkedOfficialInstall,
    hooksDir: params.hooksDir,
    timeoutMs: params.timeoutMs,
    logger: params.logger,
    mode: params.mode,
    dryRun: params.dryRun,
    expectedHookPackId: params.expectedHookPackId,
    expectedPackageKind: params.expectedPackageKind,
    inspection: params.inspection,
    beforePersistentApply: params.beforePersistentApply,
    installPolicyRequest: params.installPolicyRequest,
  });
}

function localHookInstallPolicySource(kind: "plugin-archive" | "plugin-dir"): InstallPolicySource {
  return kind === "plugin-archive"
    ? { kind: "archive", authority: "user", mutable: true, network: false }
    : { kind: "local-path", authority: "user", mutable: true, network: false };
}

async function runHookInstallScan(params: {
  hookPackId: string;
  scan: () => ReturnType<typeof scanPackageInstallSource>;
}): Promise<Extract<InstallHooksResult, { ok: false }> | null> {
  try {
    const result = await params.scan();
    if (!result?.blocked) {
      return null;
    }
    return {
      ok: false,
      error: result.blocked.reason,
      ...(result.blocked.code ? { code: result.blocked.code } : {}),
    };
  } catch (error) {
    return {
      ok: false,
      error: `Hook pack "${params.hookPackId}" installation blocked: install policy failed (${String(error)})`,
      code: "security_scan_failed",
    };
  }
}

async function runHookInstallPolicy(params: {
  hookPackId: string;
  hookEntries: string[];
  packageName?: string;
  version?: string;
  packageDir: string;
  forward: HookInstallForwardParams;
  logger: HookInstallLogger;
  mode: "install" | "update";
}): Promise<Extract<InstallHooksResult, { ok: false }> | null> {
  const request = params.forward.installPolicyRequest;
  if (!request) {
    return null;
  }
  return await runHookInstallScan({
    hookPackId: params.hookPackId,
    scan: async () =>
      await scanPackageInstallSource({
        config: params.forward.config,
        onInstallPolicyWarning: params.forward.onInstallPolicyWarning,
        trustedSourceLinkedOfficialInstall: params.forward.trustedSourceLinkedOfficialInstall,
        packageDir: params.packageDir,
        pluginId: params.hookPackId,
        extensions: params.hookEntries,
        ...(params.packageName ? { packageName: params.packageName } : {}),
        ...(params.version ? { version: params.version } : {}),
        logger: params.logger,
        requestKind: request.kind,
        requestedSpecifier: request.requestedSpecifier,
        source: request.source,
        mode: params.mode,
      }),
  });
}

async function runHookInstalledDependencyPolicy(params: {
  hookPackId: string;
  installedDir: string;
  forward: HookInstallForwardParams;
  logger: HookInstallLogger;
  mode: "install" | "update";
}): Promise<Extract<InstallHooksResult, { ok: false }> | null> {
  const request = params.forward.installPolicyRequest;
  if (!request) {
    return null;
  }
  return await runHookInstallScan({
    hookPackId: params.hookPackId,
    scan: async () =>
      await scanInstalledPackageDependencyTree({
        config: params.forward.config,
        onInstallPolicyWarning: params.forward.onInstallPolicyWarning,
        trustedSourceLinkedOfficialInstall: params.forward.trustedSourceLinkedOfficialInstall,
        packageDir: params.installedDir,
        pluginId: params.hookPackId,
        logger: params.logger,
        requestKind: request.kind,
        requestedSpecifier: request.requestedSpecifier,
        source: request.source,
        mode: params.mode,
      }),
  });
}

function validateHookId(hookId: string): string | null {
  if (!hookId) {
    return "invalid hook name: missing";
  }
  if (hookId === "." || hookId === "..") {
    return "invalid hook name: reserved path segment";
  }
  if (hookId.includes("/") || hookId.includes("\\")) {
    return "invalid hook name: path separators not allowed";
  }
  return null;
}

/** Resolve the canonical local install directory for one hook pack id. */
export function resolveHookInstallDir(hookId: string, hooksDir?: string): string {
  const hooksBase = hooksDir ? resolveUserPath(hooksDir) : path.join(CONFIG_DIR, "hooks");
  const hookIdError = validateHookId(hookId);
  if (hookIdError) {
    throw new Error(hookIdError);
  }
  const targetDirResult = resolveSafeInstallDir({
    baseDir: hooksBase,
    id: hookId,
    invalidNameMessage: "invalid hook name: path traversal detected",
  });
  if (!targetDirResult.ok) {
    throw new Error(targetDirResult.error);
  }
  return targetDirResult.path;
}

function resolveOpenClawHooks(
  manifest: HookPackageManifest,
): { ok: true; entries: string[] } | { ok: false; error: string; code: HookInstallErrorCode } {
  const hooks = manifest[MANIFEST_KEY]?.hooks;
  if (!Array.isArray(hooks)) {
    return {
      ok: false,
      error: "package.json missing openclaw.hooks",
      code: HOOK_INSTALL_ERROR_CODE.MISSING_OPENCLAW_HOOKS,
    };
  }
  const list = normalizeTrimmedStringList(hooks);
  if (list.length === 0) {
    return {
      ok: false,
      error: "package.json openclaw.hooks is empty",
      code: HOOK_INSTALL_ERROR_CODE.EMPTY_OPENCLAW_HOOKS,
    };
  }
  return { ok: true, entries: list };
}

function resolveHookPackageKind(
  manifest: HookPackageManifest,
  packageKind: "plugin-capable" | undefined,
): "hook-only" | "plugin-capable" {
  if (packageKind) {
    return packageKind;
  }
  const extensions = manifest[MANIFEST_KEY]?.extensions;
  if (extensions === undefined) {
    return "hook-only";
  }
  return Array.isArray(extensions) && normalizeTrimmedStringList(extensions).length === 0
    ? "hook-only"
    : "plugin-capable";
}

function resolveHookInstallTargetPath(
  id: string,
  hooksDir?: string,
): { ok: true; targetDir: string } | { ok: false; error: string } {
  const baseHooksDir = hooksDir ? resolveUserPath(hooksDir) : path.join(CONFIG_DIR, "hooks");
  const result = resolveSafeInstallDir({
    baseDir: baseHooksDir,
    id,
    invalidNameMessage: "invalid hook name: path traversal detected",
  });
  return result.ok ? { ok: true, targetDir: result.path } : result;
}

async function resolveInstallTargetDir(
  id: string,
  hooksDir?: string,
): Promise<{ ok: true; targetDir: string } | { ok: false; error: string }> {
  const runtime = await loadHookInstallRuntime();
  const baseHooksDir = hooksDir ? resolveUserPath(hooksDir) : path.join(CONFIG_DIR, "hooks");
  return await runtime.resolveCanonicalInstallTarget({
    baseDir: baseHooksDir,
    id,
    invalidNameMessage: "invalid hook name: path traversal detected",
    boundaryLabel: "hooks directory",
  });
}

type PreparedHookInstallTarget = {
  targetDir: string;
  effectiveMode: "install" | "update";
};

async function resolvePreparedHookInstallTarget(params: {
  id: string;
  hooksDir?: string;
  requestedMode: "install" | "update";
  alreadyExistsError: (targetDir: string) => string;
}): Promise<{ ok: true; target: PreparedHookInstallTarget } | { ok: false; error: string }> {
  const runtime = await loadHookInstallRuntime();
  const targetDirResult = await resolveInstallTargetDir(params.id, params.hooksDir);
  if (!targetDirResult.ok) {
    return targetDirResult;
  }
  const targetDir = targetDirResult.targetDir;
  const effectiveMode =
    params.requestedMode === "update" && (await runtime.fileExists(targetDir))
      ? "update"
      : "install";
  const availability = await runtime.ensureInstallTargetAvailable({
    mode: effectiveMode,
    targetDir,
    alreadyExistsError: params.alreadyExistsError(targetDir),
  });
  if (!availability.ok) {
    return availability;
  }
  return { ok: true, target: { targetDir, effectiveMode } };
}

async function installFromResolvedHookDir(
  resolvedDir: string,
  params: HookInstallForwardParams,
): Promise<InstallHooksResult> {
  const runtime = await loadHookInstallRuntime();
  const manifestPath = path.join(resolvedDir, "package.json");
  const hasPluginManifest = await runtime.fileExists(
    path.join(resolvedDir, PLUGIN_MANIFEST_FILENAME),
  );
  const packageKind =
    hasPluginManifest || detectBundleManifestFormat(resolvedDir) !== null
      ? "plugin-capable"
      : undefined;
  // A directory with package.json is a hook pack. A bare hook directory must
  // contain HOOK.md plus a handler file and installs as a single hook.
  if (await runtime.fileExists(manifestPath)) {
    return await installHookPackageFromDir({
      packageDir: resolvedDir,
      ...(packageKind ? { packageKind } : {}),
      ...buildHookInstallForwardParams(params),
    });
  }
  return await installHookFromDir({
    hookDir: resolvedDir,
    ...(packageKind ? { packageKind } : {}),
    ...buildHookInstallForwardParams(params),
  });
}

async function resolveHookNameFromDir(hookDir: string): Promise<string> {
  const runtime = await loadHookInstallRuntime();
  const hookMdPath = path.join(hookDir, "HOOK.md");
  if (!(await runtime.fileExists(hookMdPath))) {
    throw new Error(`HOOK.md missing in ${hookDir}`);
  }
  const { buffer } = await readRegularFile({ filePath: hookMdPath, maxBytes: HOOK_MD_MAX_BYTES });
  const frontmatter = parseHookFrontmatter(buffer.toString("utf-8"));
  return frontmatter.name || path.basename(hookDir);
}

async function validateHookDir(hookDir: string): Promise<{ handlerEntry: string }> {
  const runtime = await loadHookInstallRuntime();
  const hookMdPath = path.join(hookDir, "HOOK.md");
  if (!(await runtime.fileExists(hookMdPath))) {
    throw new Error(`HOOK.md missing in ${hookDir}`);
  }

  const handlerCandidates = ["handler.ts", "handler.js", "index.ts", "index.js"];
  const handlerExists = await Promise.all(
    handlerCandidates.map(async (candidate) => runtime.fileExists(path.join(hookDir, candidate))),
  );
  const handlerEntry = handlerCandidates[handlerExists.findIndex(Boolean)];

  if (!handlerEntry) {
    throw new Error(`handler.ts/handler.js/index.ts/index.js missing in ${hookDir}`);
  }
  return { handlerEntry };
}

async function installValidatedHookDirectory(
  params: HookInstallForwardParams,
  source: {
    directory: string;
    label: "hook" | "hook pack";
    hookEntries: string[];
    packageName?: string;
    manifest?: HookPackageManifest;
    options: {
      logger: HookInstallLogger;
      mode: "install" | "update";
      dryRun: boolean;
      timeoutMs: number;
    };
    metadata: Pick<
      Extract<InstallHooksResult, { ok: true }>,
      "hookPackId" | "hooks" | "packageKind" | "version"
    >;
  },
): Promise<InstallHooksResult> {
  const runtime = await loadHookInstallRuntime();
  const { logger, mode, dryRun, timeoutMs } = source.options;
  const { hookPackId, version } = source.metadata;
  if (params.inspection === "package-kind") {
    const target = resolveHookInstallTargetPath(hookPackId, params.hooksDir);
    return target.ok ? { ...target, ...source.metadata } : target;
  }

  const preparedTarget = await resolvePreparedHookInstallTarget({
    id: hookPackId,
    hooksDir: params.hooksDir,
    requestedMode: mode,
    alreadyExistsError: (targetDir) =>
      `${source.label} already exists: ${targetDir} (delete it first)`,
  });
  if (!preparedTarget.ok) {
    return preparedTarget;
  }
  const { targetDir, effectiveMode } = preparedTarget.target;

  const policyFailure = await runHookInstallPolicy({
    hookPackId,
    hookEntries: source.hookEntries,
    packageName: source.packageName,
    version,
    packageDir: source.directory,
    forward: params,
    logger,
    mode: effectiveMode,
  });
  if (policyFailure) {
    return policyFailure;
  }
  if (dryRun) {
    return { ok: true, ...source.metadata, targetDir };
  }

  const hasDeps = source.manifest ? hasPackageRuntimeDependencies(source.manifest) : false;
  const installRes = await runtime.installPackageDir(
    copyPackageDirInstallTransactionRequest(params, {
      sourceDir: source.directory,
      targetDir,
      mode: effectiveMode,
      timeoutMs,
      logger,
      copyErrorPrefix: `failed to copy ${source.label}`,
      depsLogMessage: `Installing ${source.label} dependencies…`,
      hasDeps,
      sourceHardlinks: hasDeps ? "package-manager" : "reject",
      beforePersistentApply: params.beforePersistentApply,
      afterInstall: async (installedDir) => {
        const failure = await runHookInstalledDependencyPolicy({
          hookPackId,
          installedDir,
          forward: params,
          logger,
          mode: effectiveMode,
        });
        return failure ?? { ok: true };
      },
    }),
  );
  // Preserve the attached transaction so the caller can settle payload and config together.
  return installRes.ok ? { ...installRes, ...source.metadata, targetDir } : installRes;
}

async function installHookPackageFromDir(
  params: HookPackageInstallParams & { packageKind?: "plugin-capable" },
): Promise<InstallHooksResult> {
  const runtime = await loadHookInstallRuntime();
  const options = runtime.resolveTimedInstallModeOptions(params, defaultLogger);

  const manifestPath = path.join(params.packageDir, "package.json");
  if (!(await runtime.fileExists(manifestPath))) {
    return { ok: false, error: "package.json missing" };
  }

  let manifest: HookPackageManifest;
  try {
    manifest = await runtime.readJsonFile<HookPackageManifest>(manifestPath);
  } catch (err) {
    return { ok: false, error: `invalid package.json: ${String(err)}` };
  }

  const hookManifest = resolveOpenClawHooks(manifest);
  if (!hookManifest.ok) {
    return hookManifest;
  }
  const hookEntries = hookManifest.entries;

  const pkgName = typeof manifest.name === "string" ? manifest.name : "";
  const hookPackId = pkgName ? unscopedPackageName(pkgName) : path.basename(params.packageDir);
  const packageKind = resolveHookPackageKind(manifest, params.packageKind);
  if (params.expectedPackageKind && packageKind !== params.expectedPackageKind) {
    return {
      ok: false,
      error: `hook package kind mismatch: expected ${params.expectedPackageKind}, got ${packageKind}`,
    };
  }
  const hookIdError = validateHookId(hookPackId);
  if (hookIdError) {
    return { ok: false, error: hookIdError };
  }
  if (params.expectedHookPackId && params.expectedHookPackId !== hookPackId) {
    return {
      ok: false,
      error: `hook pack id mismatch: expected ${params.expectedHookPackId}, got ${hookPackId}`,
    };
  }

  const resolvedHooks = new Set<string>();
  for (const entry of hookEntries) {
    const hookDir = path.resolve(params.packageDir, entry);
    // Validate both lexical containment and realpath containment so archive
    // symlinks cannot make package hook entries escape after extraction.
    if (!runtime.isPathInside(params.packageDir, hookDir)) {
      return {
        ok: false,
        error: `openclaw.hooks entry escapes package directory: ${entry}`,
      };
    }
    await validateHookDir(hookDir);
    if (
      !runtime.isPathInsideWithRealpath(params.packageDir, hookDir, {
        requireRealpath: true,
      })
    ) {
      return {
        ok: false,
        error: `openclaw.hooks entry resolves outside package directory: ${entry}`,
      };
    }
    const hookName = await resolveHookNameFromDir(hookDir);
    if (resolvedHooks.has(hookName)) {
      return { ok: false, error: `duplicate hook name "${hookName}" in hook package` };
    }
    resolvedHooks.add(hookName);
  }
  const hookNames = [...resolvedHooks];
  return await installValidatedHookDirectory(params, {
    directory: params.packageDir,
    label: "hook pack",
    hookEntries,
    packageName: pkgName,
    manifest,
    options,
    metadata: {
      hookPackId,
      hooks: hookNames,
      packageKind,
      version: typeof manifest.version === "string" ? manifest.version : undefined,
    },
  });
}

async function installHookFromDir(
  params: {
    hookDir: string;
    packageKind?: "plugin-capable";
  } & HookInstallForwardParams,
): Promise<InstallHooksResult> {
  const runtime = await loadHookInstallRuntime();
  const options = {
    ...runtime.resolveInstallModeOptions(params, defaultLogger),
    timeoutMs: 120_000,
  };
  const { handlerEntry } = await validateHookDir(params.hookDir);
  const hookName = await resolveHookNameFromDir(params.hookDir);
  const packageKind = params.packageKind ?? "hook-only";
  if (params.expectedPackageKind && packageKind !== params.expectedPackageKind) {
    return {
      ok: false,
      error: `hook package kind mismatch: expected ${params.expectedPackageKind}, got ${packageKind}`,
    };
  }
  const hookIdError = validateHookId(hookName);
  if (hookIdError) {
    return { ok: false, error: hookIdError };
  }

  if (params.expectedHookPackId && params.expectedHookPackId !== hookName) {
    return {
      ok: false,
      error: `hook id mismatch: expected ${params.expectedHookPackId}, got ${hookName}`,
    };
  }

  return await installValidatedHookDirectory(params, {
    directory: params.hookDir,
    label: "hook",
    hookEntries: [handlerEntry],
    options,
    metadata: {
      hookPackId: hookName,
      hooks: [hookName],
      packageKind,
    },
  });
}

/** Install hooks from an archive after extracting and validating the archive root. */
async function installHooksFromArchive(
  params: HookArchiveInstallParams,
): Promise<InstallHooksResult> {
  const runtime = await loadHookInstallRuntime();
  const logger = params.logger ?? defaultLogger;
  const timeoutMs = params.timeoutMs ?? 120_000;
  const archivePathResult = await runtime.resolveArchiveSourcePath(params.archivePath);
  if (!archivePathResult.ok) {
    return archivePathResult;
  }
  const archivePath = archivePathResult.path;
  const installPolicyRequest = params.installPolicyRequest ?? {
    kind: "plugin-archive",
    requestedSpecifier: params.archivePath,
    source: localHookInstallPolicySource("plugin-archive"),
  };

  return await runtime.withExtractedArchiveRoot({
    archivePath,
    tempDirPrefix: "openclaw-hook-",
    timeoutMs,
    logger,
    onExtracted: async (rootDir) =>
      await installFromResolvedHookDir(
        rootDir,
        buildHookInstallForwardParams({
          ...params,
          timeoutMs,
          logger,
          installPolicyRequest,
        }),
      ),
  });
}

/** Download, verify, and install an npm hook pack tarball. */
export async function installHooksFromNpmSpec(
  params: {
    spec: string;
    hooksDir?: string;
    timeoutMs?: number;
    logger?: HookInstallLogger;
    mode?: "install" | "update";
    dryRun?: boolean;
    expectedHookPackId?: string;
    expectedPackageKind?: "hook-only";
    inspection?: "package-kind";
    beforePersistentApply?: () => void;
    expectedIntegrity?: string;
    onIntegrityDrift?: (params: HookNpmIntegrityDriftParams) => boolean | Promise<boolean>;
  } & InstallSafetyOverrides,
): Promise<InstallHooksResult> {
  const runtime = await loadHookInstallRuntime();
  const { logger, timeoutMs, mode, dryRun } = runtime.resolveTimedInstallModeOptions(
    params,
    defaultLogger,
  );
  const spec = params.spec;

  logger.info?.(`Downloading ${spec.trim()}…`);
  return await runtime.installFromValidatedNpmSpecArchive({
    tempDirPrefix: "openclaw-hook-pack-",
    spec,
    timeoutMs,
    expectedIntegrity: params.expectedIntegrity,
    onIntegrityDrift: params.onIntegrityDrift,
    warn: (message) => {
      logger.warn?.(message);
    },
    installFromArchive: installHooksFromArchive,
    archiveInstallParams: buildHookInstallForwardParams({
      ...params,
      timeoutMs,
      logger,
      mode,
      dryRun,
      installPolicyRequest: {
        kind: "plugin-npm",
        requestedSpecifier: spec,
        source: { kind: "npm", authority: "third-party", mutable: false, network: true },
      },
    }),
  });
}

/** Install a hook pack or single hook from a local directory/archive path. */
export async function installHooksFromPath(
  params: HookPathInstallParams,
): Promise<InstallHooksResult> {
  const runtime = await loadHookInstallRuntime();
  const pathResult = await runtime.resolveExistingInstallPath(params.path);
  if (!pathResult.ok) {
    return pathResult;
  }
  const { resolvedPath: resolved, stat } = pathResult;
  const installPolicyKind = stat.isDirectory() ? "plugin-dir" : "plugin-archive";
  const forwardParams = buildHookInstallForwardParams({
    ...params,
    installPolicyRequest: {
      kind: installPolicyKind,
      requestedSpecifier: params.path,
      source: localHookInstallPolicySource(installPolicyKind),
    },
  });

  if (stat.isDirectory()) {
    return await installFromResolvedHookDir(resolved, forwardParams);
  }

  if (!runtime.resolveArchiveKind(resolved)) {
    return { ok: false, error: `unsupported hook file: ${resolved}` };
  }

  return await installHooksFromArchive({
    archivePath: resolved,
    ...forwardParams,
  });
}