VBoussot commited on
Commit
fc7e61a
·
verified ·
1 Parent(s): ee3e448

Drop the mask key from Patch, which konfai never binds

Browse files

konfai binds a config by walking the callable's signature and does not check for
unknown keys, so 'mask' was silently dropped -- Patch takes patch_size, overlap,
pad_value and extend_slice, and nothing else. The key promised masked patching
and configured nothing.

It cannot be honoured as written either: the blend weights each patch by its
share of a total summed over the WHOLE grid, so a skipped patch leaves its
neighbours' shares summing to less than one and the overlap band decays smoothly
to zero -- measured, a constant displacement falling 1.0 to 0 across the band.
Skipping requires renormalising over the live set, which means the volume-sized
weight buffer and the final division this design exists to avoid.

CBCT_CT_HeadNeck/Prediction.yml CHANGED
@@ -140,7 +140,6 @@ Predictor:
140
  Patch:
141
  patch_size: None
142
  overlap: None
143
- mask: None
144
  pad_value: None
145
  extend_slice: 0
146
  subset: None
 
140
  Patch:
141
  patch_size: None
142
  overlap: None
 
143
  pad_value: None
144
  extend_slice: 0
145
  subset: None
CBCT_CT_MRSeg/Prediction.yml CHANGED
@@ -173,7 +173,6 @@ Predictor:
173
  Patch:
174
  patch_size: None
175
  overlap: None
176
- mask: None
177
  pad_value: None
178
  extend_slice: 0
179
  subset: None
 
173
  Patch:
174
  patch_size: None
175
  overlap: None
 
176
  pad_value: None
177
  extend_slice: 0
178
  subset: None
ConvexAdam_Coarse/Prediction.yml CHANGED
@@ -80,7 +80,6 @@ Predictor:
80
  Patch:
81
  patch_size: None
82
  overlap: None
83
- mask: None
84
  pad_value: None
85
  extend_slice: 0
86
  subset: None
 
80
  Patch:
81
  patch_size: None
82
  overlap: None
 
83
  pad_value: None
84
  extend_slice: 0
85
  subset: None
ConvexAdam_Composite/Prediction.yml CHANGED
@@ -81,7 +81,6 @@ Predictor:
81
  Patch:
82
  patch_size: None
83
  overlap: None
84
- mask: None
85
  pad_value: None
86
  extend_slice: 0
87
  subset: None
 
81
  Patch:
82
  patch_size: None
83
  overlap: None
 
84
  pad_value: None
85
  extend_slice: 0
86
  subset: None
ConvexAdam_Fine/Prediction.yml CHANGED
@@ -80,7 +80,6 @@ Predictor:
80
  Patch:
81
  patch_size: None
82
  overlap: None
83
- mask: None
84
  pad_value: None
85
  extend_slice: 0
86
  subset: None
 
80
  Patch:
81
  patch_size: None
82
  overlap: None
 
83
  pad_value: None
84
  extend_slice: 0
85
  subset: None
FireANTs_Affine/Prediction.yml CHANGED
@@ -77,7 +77,6 @@ Predictor:
77
  Patch:
78
  patch_size: None
79
  overlap: None
80
- mask: None
81
  pad_value: None
82
  extend_slice: 0
83
  subset: None
 
77
  Patch:
78
  patch_size: None
79
  overlap: None
 
80
  pad_value: None
81
  extend_slice: 0
82
  subset: None
FireANTs_IMPACT/Prediction.yml CHANGED
@@ -84,7 +84,6 @@ Predictor:
84
  Patch:
85
  patch_size: None
86
  overlap: None
87
- mask: None
88
  pad_value: None
89
  extend_slice: 0
90
  subset: None
 
84
  Patch:
85
  patch_size: None
86
  overlap: None
 
87
  pad_value: None
88
  extend_slice: 0
89
  subset: None
FireANTs_SyN/Prediction.yml CHANGED
@@ -77,7 +77,6 @@ Predictor:
77
  Patch:
78
  patch_size: None
79
  overlap: None
80
- mask: None
81
  pad_value: None
82
  extend_slice: 0
83
  subset: None
 
77
  Patch:
78
  patch_size: None
79
  overlap: None
 
80
  pad_value: None
81
  extend_slice: 0
82
  subset: None
Generic_Rigid/Prediction.yml CHANGED
@@ -61,7 +61,6 @@ Predictor:
61
  Patch:
62
  patch_size: None
63
  overlap: None
64
- mask: None
65
  pad_value: None
66
  extend_slice: 0
67
  subset: None
 
61
  Patch:
62
  patch_size: None
63
  overlap: None
 
64
  pad_value: None
65
  extend_slice: 0
66
  subset: None
Generic_Rigid_BSpline/Prediction.yml CHANGED
@@ -63,7 +63,6 @@ Predictor:
63
  Patch:
64
  patch_size: None
65
  overlap: None
66
- mask: None
67
  pad_value: None
68
  extend_slice: 0
69
  subset: None
 
63
  Patch:
64
  patch_size: None
65
  overlap: None
 
66
  pad_value: None
67
  extend_slice: 0
68
  subset: None
MR_CT_HeadNeck/Prediction.yml CHANGED
@@ -125,7 +125,6 @@ Predictor:
125
  Patch:
126
  patch_size: None
127
  overlap: None
128
- mask: None
129
  pad_value: None
130
  extend_slice: 0
131
  subset: None
 
125
  Patch:
126
  patch_size: None
127
  overlap: None
 
128
  pad_value: None
129
  extend_slice: 0
130
  subset: None
MR_CT_MRSeg/Prediction.yml CHANGED
@@ -173,7 +173,6 @@ Predictor:
173
  Patch:
174
  patch_size: None
175
  overlap: None
176
- mask: None
177
  pad_value: None
178
  extend_slice: 0
179
  subset: None
 
173
  Patch:
174
  patch_size: None
175
  overlap: None
 
176
  pad_value: None
177
  extend_slice: 0
178
  subset: None
MR_CT_TS/Prediction.yml CHANGED
@@ -173,7 +173,6 @@ Predictor:
173
  Patch:
174
  patch_size: None
175
  overlap: None
176
- mask: None
177
  pad_value: None
178
  extend_slice: 0
179
  subset: None
 
173
  Patch:
174
  patch_size: None
175
  overlap: None
 
176
  pad_value: None
177
  extend_slice: 0
178
  subset: None