ViuAI commited on
Commit
fb9d88c
·
verified ·
1 Parent(s): ba6e1da

Speed optimization: set DDP find_unused_parameters=False

Browse files
Files changed (1) hide show
  1. model/scripts/train.py +3 -3
model/scripts/train.py CHANGED
@@ -1476,10 +1476,10 @@ def main():
1476
  str(C("compile_mode", "reduce-overhead")), args.smoke, R0,
1477
  device=device, vocab_size=margs.vocab_size)
1478
  if use_dist and not args.smoke:
1479
- # MoE top-2 routing me kuch experts kabhi-kabhi empty rehte hain -> find_unused_parameters=True (safe)
1480
- model = torch.nn.parallel.DistributedDataParallel(model, device_ids=[device.index], find_unused_parameters=True)
1481
  if R0:
1482
- print(f"[dist] DDP wrapped (find_unused=True, micro={batch} accum={accum} synced)")
1483
  ckpt_model = model.module if (use_dist and not args.smoke) else model # ckpt bina module. prefix ke (resume-safe)
1484
  total, active = ckpt_model.param_counts()
1485
  if R0:
 
1476
  str(C("compile_mode", "reduce-overhead")), args.smoke, R0,
1477
  device=device, vocab_size=margs.vocab_size)
1478
  if use_dist and not args.smoke:
1479
+ # All 242M parameters are 100% active in vectorized MoE -> find_unused_parameters=False (maximum throughput)
1480
+ model = torch.nn.parallel.DistributedDataParallel(model, device_ids=[device.index], find_unused_parameters=False)
1481
  if R0:
1482
+ print(f"[dist] DDP wrapped (find_unused=False, micro={batch} accum={accum} synced)")
1483
  ckpt_model = model.module if (use_dist and not args.smoke) else model # ckpt bina module. prefix ke (resume-safe)
1484
  total, active = ckpt_model.param_counts()
1485
  if R0: