Scanning /tmp/.X11-unix for a free number races when several sessions
start at once (parallel agents each running make test): two can pick
the same display. Xvfb/Xephyr -displayfd allocates atomically.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Add quality gates: make lint/test/boot/check and headless smoke test
- t/bin/with-x11: runs a command in a private X11 session (own Xvfb,
or Xephyr with VISIBLE=1, plus its own D-Bus session) with the host
Wayland environment stripped. Without this, Gtk opens windows on the
host desktop and Shutter routes captures via xdg-desktop-portal.
- make test: full suite in that session. SHUTTER_SMOKE_REQUIRED makes a
missing window manager fail loudly instead of skipping.
- t/smoke/01_full_capture.t: launches the real bin/shutter in an
isolated HOME under openbox, takes a full-screen capture with -f -e -o
and checks a PNG of the screen's size is written. Exercises STARTUP,
settings, session setup, capture and save end to end.
- make boot: 15s startup, fails on Perl runtime errors (undefined subs,
missing modules) that perl -c cannot see.
- make lint: perltidy (.perltidyrc) + perlcritic severity 4, applied
only to files added since the fork point. Legacy code (231 critic
violations, 26/35 files untidy) is not blocked; new code is.
Co-Authored…