Add files using upload-large-folder tool

Aam-Digital_ndb-core_3265__human_agent_2/issues/Aam-Digital_ndb-core_3103.json

@@ -0,0 +1 @@
+{"number": 3103, "title": "Link2Mail bulk action for multiple addressees", "body": "## User Flow\n1. User filters the list of people based on any categorization.\n   -~ a. Or: User retrieves a report that takes complex conditions into account, including details of linked sponsorships and notes, to define a dynamic recipient group (e.g., people who \"have a sponsorship record with a specific location\" and/or \"are linked in the note for an information evening next month,\" etc.).~\n2. User clicks \"Send email to group.\"\n3. Using the same procedure as for the supported individual email sending: The user's email program (e.g., Outlook) opens, and all of the people's email addresses are preselected (in the BCC?).\n4. The user personalizes the email text if necessary and then sends the email from\ntheir personal email address.\n5. Codo displays a form containing a note with the subject \"Mass mail sent.\"\nThe user adds additional comments for documentation in codo if necessary and then saves the note.\n6. The process is documented in the codo record, visible to all users, as a note\nin the list of all interactions with these contacts.\n\nRestrictions:\n- No unsubscribe links, \"double opt-in\" (confirmation of the address after initial registration), or other mailing functions.\n- No delivery statistics, percentage of emails opened, etc.", "state": "CLOSED", "created_at": "2025-06-26T09:53:17Z", "closed_at": "2025-09-03T09:40:42Z", "author_login": "sleidig", "comment_rounds": [{"comments": [{"id": "IC_kwDOA0GdQM7Ar3ih", "body": "@sleidig  one question regarding the \"Send email to group\" option/button\nI guess this is added under the bulk actions submenu (so when someone clicks on bulk actions, this option appears alongside others like bulk edit).\nOr \nare you thinking of placing it somewhere else, for example, under the \"Send email\" action, where users can paste comma-separated emails?", "createdAt": "2025-08-28T09:33:02Z", "updatedAt": "2025-08-28T09:33:02Z", "author": {"login": "Abhinegi2"}}, {"id": "IC_kwDOA0GdQM7Ar61z", "body": "Yes, I see this as one of the \"bulk actions\" from the list view \ud83d\udc4d ", "createdAt": "2025-08-28T09:37:06Z", "updatedAt": "2025-08-28T09:37:06Z", "author": {"login": "sleidig"}}]}, {"comments": [{"id": "IC_kwDOA0GdQM7BoD6p", "body": ":tada: This issue has been resolved in version 3.60.0-master.9 :tada:\n\nThe release is available on [GitHub release](https://github.com/Aam-Digital/ndb-core/releases/tag/3.60.0-master.9)\n\nYour **[semantic-release](https://github.com/semantic-release/semantic-release)** bot :package::rocket:", "createdAt": "2025-09-03T09:43:52Z", "updatedAt": "2025-09-03T09:43:52Z", "author": {"login": "aam-digital-ci"}}]}, {"comments": [{"id": "IC_kwDOA0GdQM7C-xIU", "body": ":tada: This issue has been resolved in version 3.60.0 :tada:\n\nThe release is available on [GitHub release](https://github.com/Aam-Digital/ndb-core/releases/tag/3.60.0)\n\nYour **[semantic-release](https://github.com/semantic-release/semantic-release)** bot :package::rocket:", "createdAt": "2025-09-09T15:27:55Z", "updatedAt": "2025-09-09T15:27:55Z", "author": {"login": "aam-digital-ci"}}, {"id": "IC_kwDOA0GdQM7DJJh2", "body": ":tada: This issue has been resolved in version 3.60.0 :tada:\n\nThe release is available on [GitHub release](https://github.com/Aam-Digital/ndb-core/releases/tag/3.60.0)\n\nYour **[semantic-release](https://github.com/semantic-release/semantic-release)** bot :package::rocket:", "createdAt": "2025-09-10T08:46:36Z", "updatedAt": "2025-09-10T08:46:36Z", "author": {"login": "aam-digital-ci"}}]}], "resolution": "closed_by_pr", "closed_by_pr": 3265, "link_type": "closing_keyword", "will_close": true, "comment_count": 5, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["released on @master", "released", "Client: _codo"], "milestone": null, "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

BBMRI-ERIC_negotiator_875/issues/BBMRI-ERIC_negotiator_874.json

@@ -0,0 +1 @@
+{"number": 874, "title": "[BUG] Representative tab not visible", "body": "**Describe the bug**\nEven if a person represents multiple resources, they might not see the Your Biobank tab in the navigation bar.", "state": "CLOSED", "created_at": "2025-09-03T09:36:05Z", "closed_at": "2025-09-08T13:53:17Z", "author_login": "RadovanTomik", "comment_rounds": [], "resolution": "closed_by_pr", "closed_by_pr": 875, "link_type": "closing_keyword", "will_close": true, "comment_count": 0, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["bug"], "milestone": null, "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

Card-Forge_forge_8976/issues/Card-Forge_forge_8975.json

@@ -0,0 +1 @@
+{"number": 8975, "title": "New Android version 2.0.07-10.27 hangs on checking for update", "body": "**Describe the bug**\nGame doesn't start, stuck on \"Checking for updates\" screen.  swiping back displays animated logo, and game shuts down.\n\n**To Reproduce**\n1. Update\n2. run, \n3. download assets\n4. restart\n5. gets stuck there.\n\nTried closing and clearing cache, same problem.\nTried re downloading and installing(update)\n\n**Expected behavior**\nShould automatically bring the main menu\n\n<img width=\"1080\" height=\"2400\" alt=\"Image\" src=\"https://github.com/user-attachments/assets/338e6d5e-fdce-487a-b4c4-236b75a43817\" />\n\n**Smartphone (please complete the following information):**\n - Device: Moto G stylus 5G 2023\n - OS: Android\n - Version 14\n\n\n", "state": "CLOSED", "created_at": "2025-10-21T21:49:02Z", "closed_at": "2025-10-22T15:24:43Z", "author_login": "Life-Saver666", "comment_rounds": [{"comments": [{"id": "IC_kwDOHJqLYM7Mb97U", "body": "Also experiencing this bug.\nDevice: pixel pro 11 pro\nOs: android\nVersion: latest", "createdAt": "2025-10-21T23:09:37Z", "updatedAt": "2025-10-21T23:09:37Z", "author": {"login": "TheNaturalCauses"}}, {"id": "IC_kwDOHJqLYM7MgfnW", "body": "Known issue:\nhttps://github.com/Card-Forge/forge/pull/8849#issuecomment-3430841392\n\n@Jetz72 is probably working on it", "createdAt": "2025-10-22T08:28:54Z", "updatedAt": "2025-10-22T08:28:54Z", "author": {"login": "Hanmac"}}, {"id": "IC_kwDOHJqLYM7MmjCH", "body": "Issue still persist, same with 10.22", "createdAt": "2025-10-22T14:27:45Z", "updatedAt": "2025-10-22T14:27:45Z", "author": {"login": "Life-Saver666"}}, {"id": "IC_kwDOHJqLYM7MmuOk", "body": "Also, it's possible It was caused in an earlier version, I didn't update for a few days.", "createdAt": "2025-10-22T14:37:07Z", "updatedAt": "2025-10-22T14:37:07Z", "author": {"login": "Life-Saver666"}}, {"id": "IC_kwDOHJqLYM7MnAn0", "body": "@Life-Saver666 update new forge.log to fix the issue", "createdAt": "2025-10-22T14:52:33Z", "updatedAt": "2025-10-22T14:52:33Z", "author": {"login": "Hanmac"}}, {"id": "IC_kwDOHJqLYM7Mn2Nk", "body": "Should be fixed for real this time by #8978.", "createdAt": "2025-10-22T15:24:43Z", "updatedAt": "2025-10-22T15:24:43Z", "author": {"login": "Jetz72"}}, {"id": "IC_kwDOHJqLYM7Mn6iS", "body": "@Jetz72 i still get some issue, but i need to debug that at home", "createdAt": "2025-10-22T15:28:53Z", "updatedAt": "2025-10-22T15:28:53Z", "author": {"login": "Hanmac"}}, {"id": "IC_kwDOHJqLYM7Mt83P", "body": "> [@Life-Saver666](https://github.com/Life-Saver666) update new forge.log to fix the issue\n\nHow do I do that? I just download the APK file, my phone isn't rooted, I can't access the installed folder.", "createdAt": "2025-10-23T00:01:59Z", "updatedAt": "2025-10-23T00:01:59Z", "author": {"login": "Life-Saver666"}}, {"id": "IC_kwDOHJqLYM7MuRRv", "body": "I think he meant to say Forge snapshot rather than forge.log. Updating to the latest snapshot should resolve things now.", "createdAt": "2025-10-23T00:40:31Z", "updatedAt": "2025-10-23T00:41:13Z", "author": {"login": "Jetz72"}}, {"id": "IC_kwDOHJqLYM7MuUEg", "body": "> I think he meant to say Forge snapshot rather than forge.log. Updating to the latest snapshot should resolve things now.\n\nThanks, I didn't notice it was updated as it was still the same version.   It's working now!   Thanks for the dedication to this great game app.", "createdAt": "2025-10-23T00:43:47Z", "updatedAt": "2025-10-23T00:44:01Z", "author": {"login": "Life-Saver666"}}]}], "resolution": "closed_by_pr", "closed_by_pr": 8976, "link_type": "closing_keyword", "will_close": true, "comment_count": 10, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["Android"], "milestone": null, "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

Chocobozzz_PeerTube_6648/issues/Chocobozzz_PeerTube_6570.json

@@ -0,0 +1 @@
+{"number": 6570, "title": "Use case insensitive email for reset password", "body": "### Describe the current behavior\n\nWe get a lot of emails from users that says that they've requested a password reset, but they don't receive any email. When I search for their email, user id and username in the logs and audit log I can't find anything.\r\n\r\nRelevant config:\r\n\r\n```\r\nlog:\r\n  level: 'info' # 'debug' | 'info' | 'warn' | 'error'\r\n\r\nsmtp:\r\n  # smtp or sendmail\r\n  transport: smtp\r\n  # Path to sendmail command. Required if you use sendmail transport\r\n  sendmail: null\r\n  hostname: 'smtp.eu.mailgun.org'\r\n  port: 587 # If you use StartTLS: 587\r\n```\r\n\r\nWhilst I know it works for other users. Possible causes:\r\n* Handling errors by the users / bad UX\r\n* Peertube fails to create the email job\r\n* Mailgun issue\r\n\r\nTo investigate this further we may need to add more logging to determine what's going wrong. As far as I can see there's no audit logs for password resets, can we add that? Also we could add some info log here to tell that an email is being prepared. https://github.com/Chocobozzz/PeerTube/blob/a06c2ea020a353cdf773708832d3fa7c20f47999/server/core/lib/job-queue/job-queue.ts#L355\n\n### Steps to reproduce\n\n1.\r\n2.\r\n3.\r\n\n\n### Describe the expected behavior\n\n_No response_\n\n### Additional information\n\n* PeerTube instance:\r\n  * URL:\r\n  * Version: 6.2.1\r\n  * NodeJS version:\r\n  * Ffmpeg version:\r\n\r\n* Browser name, version and platforms on which you could reproduce the bug:\r\n* Link to browser console log if relevant:\r\n* Link to server log if relevant (`journalctl` or `/var/www/peertube/storage/logs/`):\r\n", "state": "CLOSED", "created_at": "2024-09-03T07:02:14Z", "closed_at": "2025-01-28T13:16:44Z", "author_login": "kontrollanten", "comment_rounds": [{"comments": [{"id": "IC_kwDOArHn486K_Fjj", "body": "Hi,\r\n\r\nCan you check your local jobs of type `email` to see if there are errors?\r\nWe should also display errors in logs.\r\n\r\nBut I improved email logging in https://github.com/Chocobozzz/PeerTube/commit/99091da7c5505b6ad7806091b632969ab330cfb6", "createdAt": "2024-09-05T14:12:36Z", "updatedAt": "2024-09-05T14:12:36Z", "author": {"login": "Chocobozzz"}}]}, {"comments": [{"id": "IC_kwDOArHn486LWEQy", "body": "There's no failed jobs and I couldn't find any relevant information in the logs either.\r\n\r\nI can't see that there's any email jobs created for the users who's reporting that they haven't got any email. So either Peertube fails to create the job or the users fails to reset their password.", "createdAt": "2024-09-09T11:07:30Z", "updatedAt": "2024-09-09T11:08:40Z", "author": {"login": "kontrollanten"}}, {"id": "IC_kwDOArHn486LfAp5", "body": "> I can't see that there's any email jobs created for the users who's reporting that they haven't got any email. So either Peertube fails to create the job or the users fails to reset their password.\r\n\r\nCan you ask him/her to try again and check in your peertube or nginx logs if the `/ask-reset-password` endpoint is called? If yes, a subsequent `email` job type should be created with a `Reset your account password` email subject.", "createdAt": "2024-09-10T09:36:12Z", "updatedAt": "2024-09-10T09:36:12Z", "author": {"login": "Chocobozzz"}}]}, {"comments": [{"id": "IC_kwDOArHn486L9w6h", "body": "We need to redesign the audit log but in the meantime I added more \"classic\" logs in https://github.com/Chocobozzz/PeerTube/commit/fc771a63e108b011be0b21ea5c590b0a9cae63eb\r\n\r\nYou can filter log entries using [Parse logs](https://docs.joinpeertube.org/maintain/tools#parse-logs):\r\n\r\n```\r\nsudo -u peertube NODE_CONFIG_DIR=/var/www/peertube/config NODE_ENV=production npm run parse-log -- --level info --tags users --tags api\r\n```\r\n\r\nOr by username (for example `chocobozzz`):\r\n\r\n```\r\nsudo -u peertube NODE_CONFIG_DIR=/var/www/peertube/config NODE_ENV=production npm run parse-log -- --level info --tags chocobozzz\r\n```", "createdAt": "2024-09-13T07:25:34Z", "updatedAt": "2024-09-13T07:25:34Z", "author": {"login": "Chocobozzz"}}, {"id": "IC_kwDOArHn486MA4AX", "body": "Thanks. We'll upgrade to Peertube 6.3 as soon as it's released and see if we can debug further what happens.", "createdAt": "2024-09-13T14:02:07Z", "updatedAt": "2024-09-13T14:02:07Z", "author": {"login": "kontrollanten"}}]}, {"comments": [{"id": "IC_kwDOArHn486NMQid", "body": "It seems email stopped working for us in 6.2.1. No errors to be found in the logs. Will also upgrade to 6.3 see if it makes a difference.", "createdAt": "2024-09-23T16:34:24Z", "updatedAt": "2024-09-23T16:34:24Z", "author": {"login": "Sakrecoer"}}, {"id": "IC_kwDOArHn486Nc5ef", "body": "> It seems email stopped working for us in 6.2.1. No errors to be found in the logs. Will also upgrade to 6.3 see if it makes a difference.\r\n\r\nPlease create a dedicated issue with server debug logs enabled\r\n\r\n@kontrollanten Do you have news?", "createdAt": "2024-09-25T06:40:27Z", "updatedAt": "2024-09-25T06:40:27Z", "author": {"login": "Chocobozzz"}}, {"id": "IC_kwDOArHn486NeghG", "body": "No, we haven't updated yet", "createdAt": "2024-09-25T09:41:39Z", "updatedAt": "2024-09-25T09:41:39Z", "author": {"login": "kontrollanten"}}]}, {"comments": [{"id": "IC_kwDOArHn486OKlEi", "body": "I may have found the reason causing this issue. We just had a user who tried to reset his email but it failed due to the registered email was capitalized, whilst he typed his email in lower case. Related to https://github.com/Chocobozzz/PeerTube/issues/6383", "createdAt": "2024-10-01T08:35:21Z", "updatedAt": "2024-10-01T08:35:21Z", "author": {"login": "kontrollanten"}}]}, {"comments": [{"id": "IC_kwDOArHn486YVg9Y", "body": "This is a huge accessibility issue for our users. Every week we've multiple users contacting us that they can't access their account, and in 9 cases of 10 it's solved by sending them their email address in the format they typed it in when they registered. Probably there's also a lot of users just giving up without contacting us.", "createdAt": "2024-12-19T21:08:08Z", "updatedAt": "2024-12-19T21:08:08Z", "author": {"login": "kontrollanten"}}, {"id": "IC_kwDOArHn486YXtja", "body": "Will review and include your PR in 7.1 :pray:", "createdAt": "2024-12-20T06:06:48Z", "updatedAt": "2024-12-20T06:06:53Z", "author": {"login": "Chocobozzz"}}]}], "resolution": "closed_by_pr", "closed_by_pr": 6648, "link_type": "closing_keyword", "will_close": true, "comment_count": 11, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["Type: Feature Request :sparkles:", "Component: Email"], "milestone": null, "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

Comfy-Org_ComfyUI_frontend_12041/issues/Comfy-Org_ComfyUI_frontend_11688.json

@@ -0,0 +1 @@
+{"number": 11688, "title": "Native ComfyUI prompt dialogs should have a max-width set", "body": "### What problem are you experiencing?\n\nThe native ComfyUI prompt/confirmation dialog becomes **too wide** on large monitors and ends up stretching across most of the screen. That makes longer messages much harder to read comfortably, because each line becomes excessively long. (see screenshot)\n\nThis is especially noticeable when extensions need to show explanatory confirmation messages to the user. I recently ran into this while implementing a native prompt in [ComfyUI-OpenPose-Studio](https://github.com/andreszs/ComfyUI-OpenPose-Studio), where the dialog is used to explain an optional cross-extension feature and offer the user a follow-up action. The prompt works, but on wide displays the text layout becomes awkward and inconvenient to read.\n\n<img width=\"1558\" height=\"243\" alt=\"Image\" src=\"https://github.com/user-attachments/assets/2bdd8d09-740b-49df-86a0-8a24808648d0\" />\n\n### When does this problem occur?\n\nIt happens when a native ComfyUI prompt contains a paragraph or two of explanatory text and the app is being used on a wide desktop display. The wider the screen, the worse the reading experience becomes, because the dialog keeps expanding horizontally instead of keeping a comfortable readable width.\n\n### How often do you encounter this problem?\n\nOccasionally\n\n### How much does this problem affect your workflow?\n\nMinor annoyance\n\n### Current workarounds\n\n_No response_\n\n### Ideas for solutions (Optional)\n\nA reasonable fix would be to give native dialogs/prompts a `max-width` so they stop growing after a certain point, while still remaining responsive on smaller screens. That way, long messages would wrap into a more readable text block instead of becoming a single very wide paragraph.\n\n### Additional context\n\nThis would improve readability for both core ComfyUI messages and extension-generated prompts that rely on the native frontend dialog system.\n\n<img width=\"1920\" height=\"955\" alt=\"Image\" src=\"https://github.com/user-attachments/assets/f2a33123-9661-4e9b-9e3f-386e8184c421\" />\n\n\u2506Issue is synchronized with this [Notion page](https://www.notion.so/Issue-11688-Native-ComfyUI-prompt-dialogs-should-have-a-max-width-set-34f6d73d365081709d3dea4d1a6e3091) by [Unito](https://www.unito.io)\n", "state": "CLOSED", "created_at": "2026-04-27T15:15:58Z", "closed_at": "2026-05-06T12:19:07Z", "author_login": "andreszs", "comment_rounds": [], "resolution": "closed_by_pr", "closed_by_pr": 11719, "link_type": "closing_keyword", "will_close": true, "comment_count": 0, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["enhancement", "area:ui"], "milestone": null, "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

DarkflameUniverse_DarkflameServer_1719/issues/DarkflameUniverse_DarkflameServer_1710.json

@@ -0,0 +1 @@
+{"number": 1710, "title": "BUG: Cannon Cove score counter doesn't show personal/friends best scores to beat", "body": "### Make sure you've done the following:\n\n- [X] I have checked that this issue has not already been reported.\n\n- [X] I have validated that this issue is not a syntax error of either MySQL or SQLite.\n\n- [X] I have pulled the latest version of the main branch of DarkflameServer and have confirmed that the issue exists there.\n\n\n### DarkflameServer Version\n\nlatest\n\n### Issue Description\n\nIn live the game would seemingly pick between your own best score or a friend's best score as a target to beat instead of just showing progress towards Hearty Score forever.\r\n\r\nThe logic for this seems similar to how it's handled in AGS though it may be different?\r\n\r\nhttps://youtu.be/xilmSHk8oq8?si=U_1l09NYFQ1jnqDA&t=470\n\n### Reproduction Steps\n\nPlay Cannon cove at least once to establish a personal best\r\nReplay Cannon cove\r\nNote that the goal shown is still for Hearty Score 1/2/3/4\n\n### Expected Behavior\n\nEither a personal best or friend's score should be shown\n\n### Environment\n\nEnvironment (Environment (Environment (Environment (Environment (Environment (Environment (Environment (Environment (Environment (Environment (Environment (Environment (Environment (Environment (Environment (Environment (Environment (Environment (Environment)))))))))))))))))))", "state": "CLOSED", "created_at": "2025-01-01T12:47:52Z", "closed_at": "2025-05-02T23:35:20Z", "author_login": "BrieFlory", "comment_rounds": [{"comments": [{"id": "IC_kwDOGe1hM86ZAtdt", "body": "because the person who wrote the leaderboard checkgm mistook leaderboard _type_ for leaderboard _size_", "createdAt": "2025-01-01T18:15:37Z", "updatedAt": "2025-01-01T18:15:37Z", "author": {"login": "EmosewaMC"}}]}, {"comments": [{"id": "IC_kwDOGe1hM86pxUF_", "body": "This is intentional by live, no fix planned.", "createdAt": "2025-05-02T23:35:20Z", "updatedAt": "2025-05-02T23:35:20Z", "author": {"login": "EmosewaMC"}}]}], "resolution": "closed_manually", "closed_by_pr": null, "link_type": "closing_keyword", "will_close": true, "comment_count": 2, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["bug", "P-wontfix"], "milestone": null, "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

GCTC-NTGC_gc-digital-talent_14202__human_human_2/issues/GCTC-NTGC_gc-digital-talent_14108.json

@@ -0,0 +1 @@
+{"number": 14108, "title": "\ud83e\uddea Test for regressions in docx exports", "body": "### \ud83e\uddea Tests\n\nWe've had some regression bugs in the docx exports.  It would get good to get some testing on them to catch these.\n\n### \ud83d\udd75\ufe0f Details\n\n_No response_\n\n### \ud83d\ude4b\u200d\u2640\ufe0f Proposed Solution\n\nThe first trick is getting testable data out of the document.  Our existing PHPWord library [exports pretty clean HTML](https://github.com/PHPOffice/PHPWord?tab=readme-ov-file#getting-started).  This could be a spot to start.\n\nNext, we'll need to do testing.  A snapshot test, like we do to catch language duplicates, could work to highlight unexpected changes.  [Spatie has phpunit plugin](https://github.com/spatie/phpunit-snapshot-assertions) for snapshots and [Pest has it built-in](https://pestphp.com/docs/snapshot-testing).\n\n### \u2705 Acceptance Criteria\n\n- [ ] Regression tests for DOCX exports", "state": "CLOSED", "created_at": "2025-07-08T17:57:15Z", "closed_at": "2025-07-25T18:28:46Z", "author_login": "petertgiles", "comment_rounds": [], "resolution": "closed_by_pr", "closed_by_pr": 14202, "link_type": "closing_keyword", "will_close": true, "comment_count": 0, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": [], "milestone": null, "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

GCTC-NTGC_gc-digital-talent_6382__human_human_2/issues/GCTC-NTGC_gc-digital-talent_6245.json

@@ -0,0 +1 @@
+{"number": 6245, "title": "\u2728 Screening question responses required to submit application", "body": "## \u2728 Feature\r\n\r\nScreening question responses must exist for the pool candidate in order to submit through SubmitApplicationValidator.php\r\n\r\n## \ud83d\udd75\ufe0f Details\r\n\r\nCan't quite get added yet with the addition of screening question responses to the back end, as with no UI to actually answer questions it will break our ability to test. And with no way to edit questions for pool yet it also makes things trickier. Must complete the UI first. \r\n\r\n## \ud83d\ude4b\u200d\u2640\ufe0f Proposed Implementation\r\n\r\n- grab screening questions applicable to a pool by\r\npoolCandidate->pool->screeningQuestions()\r\n\r\n- grab responses for a pool candidate by\r\npoolCandidate->screeningQuestionResponses()\r\n\r\nAssert the former is addressed in the latter\r\n\r\n## \u2705 Acceptance Criteria\r\n\r\n- [ ] Validator updated\r\n- [ ] Testing \r\n\r\n## \ud83d\uded1 Blockers\r\n\r\nBlocked by #6059, #6068 \r\n", "state": "CLOSED", "created_at": "2023-04-11T18:25:04Z", "closed_at": "2023-05-03T16:13:30Z", "author_login": "vd1992", "comment_rounds": [{"comments": [{"id": "IC_kwDOFbwAwM5Zo3Eq", "body": "# Status: Blocked :x:\n### Issues blocking this PR: \n- #6059 :x:\n- #6068 :x:\n----\nThis comment was automatically written by the [Blocking Issues](https://github.com/Levi-Lesches/blocking-issues) bot, and this PR will be monitored for further progress.", "createdAt": "2023-04-11T18:25:18Z", "updatedAt": "2023-04-11T18:25:18Z", "author": {"login": "github-actions"}}]}], "resolution": "closed_by_pr", "closed_by_pr": 6382, "link_type": "closing_keyword", "will_close": true, "comment_count": 1, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["blocked: copy"], "milestone": null, "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

GenSpectrum_LAPIS-SILO_1262/issues/GenSpectrum_LAPIS-SILO_1259.json

@@ -0,0 +1 @@
+{"number": 1259, "title": "Query plan column narrowing", "body": "Often, we do not need all columns of an operator for subsequent calculations, this should be detected and the output columns of operators narrowed when possible", "state": "CLOSED", "created_at": "2026-05-19T14:48:37Z", "closed_at": "2026-05-29T12:12:46Z", "author_login": "taepper", "comment_rounds": [], "resolution": "closed_by_pr", "closed_by_pr": 1262, "link_type": "closing_keyword", "will_close": true, "comment_count": 0, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": [], "milestone": null, "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

MetricsHub_metricshub-community_1112/issues/MetricsHub_metricshub-community_1108.json

@@ -0,0 +1 @@
+{"number": 1108, "title": "Optimize troubleshooting tool responses for the AI assistant", "body": "## Problem\n\nWhen the AI assistant runs troubleshooting tools (`CollectMetricsForHost`, `GetMetricsFromCacheForHost`, `TestAvailableConnectorsForHost`), the response can be extremely large \u2014 for example, a server with 200 disks and 64 CPUs produces a massive JSON payload. This causes two issues:\n\n1. **Wasted bandwidth and tokens**: The response includes internal/debug keys (prefixed with `__`), null values, and empty fields that are useless to the AI assistant.\n2. **Exceeds OpenAI size limits**: When the payload is too large, the entire response is uploaded as a file, and the assistant gets no inline data. It must use Code Interpreter for even simple questions like *\"Is the server healthy?\"*, making interactions slow and expensive.\n\n## Proposed Solution\n\n### Part 1 \u2014 Enrich Metrics with Type Information and Automatic Rate Computation for Counters\n\nMetricsHub collects raw metric values but **does not track what kind of metric each value represents** (Gauge, Counter, UpDownCounter, etc.). This means Counter metrics like `hw.network.io` (cumulative bytes) are exported as raw ever-increasing numbers. AI Assistants then need to independently compute per-second rates \u2014 leading to duplicated logic and long response times.\n\nThis part will add:\n1. A **`metricType`** property on every collected metric\n2. An automatic **`rate`** computation (value per second) for Counter metrics\n3. A **unified resolution mechanism** that determines the metric type from connector definitions or host-level definitions \u2014 never hardcoded.\n-----------------------------------------------\n### Part 2  \u2014  Implementing Compressed MonitorsVo Structure in TroubleshootHostService\n\n\nThe telemetry data returned by the MCP troubleshooting tools currently sends raw, flat monitor lists with cumulative counter values that are difficult for AI assistants to interpret. This issue covers two improvements:\n\n1. **Compress and structure the telemetry payload** \u2014 group monitors by type (disk, cpu, fan, etc.) and append per-type summary statistics, reducing response size and enabling the AI assistant to answer aggregate questions (e.g., \"how many disks are degraded?\") without scanning every monitor.\n\n2. **Replace raw Counter values with human-readable rates** \u2014 cumulative counters like energy consumption (in Joules) are meaningless to an AI assistant or end user without additional context. They must be converted to per-second rates (e.g., Watts) before being sent to the client.\n\n#### Solution\n\n##### Grouped, type-indexed response format\n\nMonitors are grouped by their type (`disk`, `cpu`, `enclosure`, `fan`, etc.). Each group contains:\n\n- **Individual monitors** \u2014 with their attributes, metrics, and text parameters (empty/null values and internal fields are stripped)\n- **A summary object** (always the last item in the group) containing:\n  - **Total monitor count** for that type\n  - **Numeric metric statistics**: average, minimum, maximum, and sum across all monitors\n  - **State distribution**: count of monitors per state (e.g., `hw.status`: 195 ok, 3 degraded, 2 failed)\n\n##### Counter-to-rate conversion\n\nAll Counter-type metrics are automatically converted:\n\n- The raw cumulative value is **never exposed** to the client\n- Instead, the computed **rate** (units per second) is sent \u2014 e.g., energy in Joules becomes power in Watts\n- The metric key is clearly labeled: `hw.enclosure.energy` \u2192 `rate(hw.enclosure.energy)` so the consumer knows this is a rate, not a raw value\n- On the very first collection cycle (when no previous data point exists to compute a rate), the counter metric is **omitted entirely** rather than sending a misleading zero or null\n\n#### Example response\n\n```json\n{\n  \"telemetry\": {\n    \"monitors\": {\n      \"disk\": [\n        {\n          \"type\": \"monitor\",\n          \"attributes\": { \"device\": \"/dev/sda1\", \"mountpoint\": \"/\" },\n          \"metrics\": { \"hw.status\": \"degraded\", \"disk.utilization\": 45.5, \"rate(disk.io.read)\": 17.07 }\n        },\n        {\n          \"type\": \"monitor\",\n          \"attributes\": { \"device\": \"/dev/sdb1\", \"mountpoint\": \"/data\" },\n          \"metrics\": { \"hw.status\": \"ok\", \"disk.utilization\": 78.2, \"rate(disk.io.read)\": 34.13 }\n        },\n        {\n          \"type\": \"summary\",\n          \"totalMonitors\": 200,\n          \"numericMetrics\": {\n            \"disk.utilization\": { \"avg\": 45.2, \"min\": 2.1, \"max\": 98.7, \"sum\": 9040.0 },\n            \"rate(disk.io.read)\": { \"avg\": 25.6, \"min\": 2.13, \"max\": 136.53, \"sum\": 5120.0 }\n          },\n          \"stateSetMetrics\": {\n            \"hw.status\": [\n              { \"value\": \"ok\", \"count\": 195 },\n              { \"value\": \"degraded\", \"count\": 3 },\n              { \"value\": \"failed\", \"count\": 2 }\n            ]\n          }\n        }\n      ]\n    }\n  }\n}\n```\n\n\n#### Affected Tools\n\n| MCP Tool | Description |\n|---|---|\n| **Collect Metrics** | Triggers a full discovery + collect cycle and returns results |\n| **Get Cached Metrics** | Returns the most recent cached telemetry data |\n| **Test Available Connectors** | Runs detection + discovery to evaluate which connectors work |\n\n#### Benefits\n\n- **Reduced AI token consumption**: structured groups with summaries eliminate the need for the AI to scan every monitor\n- **Faster AI reasoning**: the summary enables instant answers to aggregate questions without iteration\n- **Accurate Counter interpretation**: rates (e.g., Watts) are immediately meaningful; cumulative counters (e.g., Joules) are not\n- **Cleaner payloads**: null values, empty fields, and internal keys are stripped, further reducing response size\n-------------\n\n\n### Part 3 \u2014 Smart progressive truncation of large troubleshooting tool responses\n\nWhen monitoring tools collect metrics from hosts with hundreds of resources (e.g., 200 disks,\n64 CPUs), the response can exceed the OpenAI tool output size limit. Today, oversized responses\nare uploaded to a file and only a generic \"file uploaded\" message is returned to the assistant \u2014\nforcing it to use Code Interpreter for every question, even simple ones like\n\"how many disks does server1 have?\".\n\n#### Solution\n\nInstead of discarding the inline data entirely, we now **intelligently shrink** the response\nso it fits within the size limit while keeping as much useful information as possible:\n\n1. **Largest-first progressive halving** \u2014 we identify the resource category with the most\n   entries (e.g., 200 disks), cut it in half, check if it fits, and repeat. This naturally\n   focuses reduction on the biggest contributors while preserving smaller categories in full.\n\n2. **Summaries always preserved** \u2014 each resource category includes an aggregated summary\n   (total count, averages, min/max, state distributions). These are never removed, so the\n   assistant always has high-level stats even when individual entries are trimmed.\n\n3. **Full data always available** \u2014 the complete untruncated response is always uploaded to\n   the file storage. The assistant can access it via Code Interpreter for deep analysis.\n\n4. **Clear truncation reporting** \u2014 the response includes a summary showing exactly what was\n   trimmed (e.g., \"disk: 200 \u2192 25\") so the assistant knows what's inline vs. what requires\n   the full file.\n\n5. **Final size guarantee** \u2014 after truncation, the complete response envelope (not just the\n   data portion) is verified against the size limit. If it still doesn't fit, the system\n   retries with a tighter budget or falls back to the file-only approach.\n\n#### Example\n\nFor a host with 200 disks, 64 CPUs, 48 temperature sensors, and 12 fans \u2014 where disks and\nCPUs are too large to fit:\n\n```\nHost 'server1.example.com':\n  - disk: 200 resources (showing first 25 + summary)\n  - cpu: 64 resources (showing first 32 + summary)\n  - temperature: 48 resources (full)\n  - fan: 12 resources (full)\n  - enclosure: 1 resource (full)\n\nTruncated: disk 200 \u2192 25, cpu 64 \u2192 32\n```\n\nTemperature, fan, and enclosure data are returned in full because trimming the larger\ncategories was sufficient.\n\n#### Behavior summary\n\n| Scenario | What the assistant receives |\n|----------|---------------------------|\n| Response under size limit | Full data inline + file reference |\n| Troubleshooting response over limit | Truncated data inline + truncation summary + file reference |\n| Other tool response over limit (Unlikely) | File reference only (no inline data) |\n", "state": "CLOSED", "created_at": "2026-02-18T19:03:23Z", "closed_at": "2026-02-27T16:51:58Z", "author_login": "NassimBtk", "comment_rounds": [], "resolution": "closed_by_pr", "closed_by_pr": 1112, "link_type": "closing_keyword", "will_close": true, "comment_count": 0, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": [], "milestone": "3.9.01", "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

MudBlazor_TryMudBlazor_192/issues/MudBlazor_TryMudBlazor_198.json

@@ -0,0 +1 @@
+{"number": 198, "title": "Can't use System.Linq Queryable extension methods", "body": "Trying to use `IEnumerable.AsQueryable` causes a compilation error, even after adding `@using System.Linq`. \n\nReproduction: \n - Snippet: https://try.mudblazor.com/snippet/wYmKEnGwLAhKlUnI\n - Code:\n   ```razor\n   @using System.Linq \n   <MudText Typo=\"Typo.h6\">MudBlazor is @Text</MudText>\n   <MudButton Variant=\"Variant.Filled\" Color=\"Color.Primary\" OnClick=\"ButtonOnClick\">@ButtonText</MudButton>\n    \n   @code {\n       public string Text { get; set; } = \"????\";\n       public string ButtonText { get; set; } = \"Click Me\";\n       public int ButtonClicked { get; set; }\n    \n       void ButtonOnClick()\n       {\n           IEnumerable<string> data = new List<string>() { \"a\", \"b\", \"c\" };\n           data = data.Select(x => x.ToUpper()).ToArray(); // This works\n           data = data.AsQueryable().Select(x => x.ToUpper()).ToArray(); // this doesn't\n           ButtonClicked += 1;\n           Text = $\"Awesome x {ButtonClicked} ({string.Join(\",\", data)})\";\n           ButtonText = \"Click Me Again\";\n       }\n   }\n   ```\n- Expected: Adding `@using System.Linq` should fix the compilation error\n- What actually happens: It doesn't.\n- Browser: Firefox 148.0.2 (64-bit), on windows, normal mode (not incognito/private)\n- DotNET version: 10.0.3\n- MudBlazor version: v9.1.0\n", "state": "CLOSED", "created_at": "2026-03-22T21:27:36Z", "closed_at": "2026-04-10T20:36:08Z", "author_login": "tonnydourado", "comment_rounds": [], "resolution": "closed_by_pr", "closed_by_pr": 192, "link_type": "closing_keyword", "will_close": true, "comment_count": 0, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": [], "milestone": null, "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

Open-Source-Legal_OpenContracts_1255__unreviewed/issues/Open-Source-Legal_OpenContracts_1242.json

@@ -0,0 +1 @@
+{"number": 1242, "title": "Prune dead utility/hook exports across annotator, threads, widgets", "body": "## \u26a0\ufe0f Scope corrected after re-analysis\n\nThe original analysis only walked `frontend/src/`, missing `frontend/tests/` (Playwright `.ct.tsx` component tests and Vitest unit tests under `frontend/tests/`). After re-running with `frontend/tests/` included as additional entry points, several listed exports turned out to have real test coverage and have been removed from scope.\n\n**Removed from scope (have real test coverage):**\n- `flattenMessageTree` (`components/threads/utils.ts`) \u2014 tested in `frontend/tests/threads/utils.test.ts`\n- `findMessageInTree` (`components/threads/utils.ts`) \u2014 tested in `frontend/tests/threads/utils.test.ts`\n- `EditMode` (`components/types.ts`) \u2014 imported by `frontend/tests/CRUDModalTestWrapper.tsx`\n\n**Kept in scope but worth re-verifying manually before deleting** (none of these had test references in the corrected scan, but the audit was conservative):\n- All other listed exports still appear dead\n\n## Confirmed-still-dead exports\n\n### `components/annotator/utils.ts` (7/11 dead)\n- `unwrap`, `getRelationImageHref`, `isSuperset`, `union`, `intersection`, `symmetricDifference`, `usePrevious`\n\n### `components/annotator/renderers/txt/utils.ts` (4/5 dead)\n- `blendColors` (note: a different function with the same name lives in `src/utils/colorUtils.ts` \u2014 that one is alive, this one isn't)\n- `mapTokensWithAnnotations`\n- `selectionIsBackwards`\n- `selectionIsEmpty`\n\n### `components/threads/utils.ts` (2/6 dead \u2014 corrected from 4/6)\n- `calculateThreadUpvotes`\n- `getLastActivityTime`\n\n### `components/annotator/hooks/AnnotationHooks.tsx` (4/16 dead hooks)\n- `useAnnotationObjs`\n- `useDocTypeAnnotations`\n- `useCreateRelationship`\n- `useUpdateRelations`\n\n### `components/annotator/sidebar/common.tsx` (5/10 dead)\n- `HorizontallyJustifiedStartDiv`\n- `HorizontallyJustifiedStartFluidDiv`\n- `HorizontallyJustifiedEndDiv`\n- `VerticallyJustifiedStartFluidDiv`\n- `VerticallyJustifiedEndFluidDiv`\n- (`FullWidthHorizontallyCenteredDiv` had a same-name match in `Wrappers.tsx` but is a different component \u2014 verify manually if deleting)\n\n### `components/widgets/ModernLoadingDisplay.tsx` (3/4 dead \u2014 never-adopted skeleton variants)\n- `SkeletonLoader`\n- `CardSkeleton`\n- `DocumentCardSkeleton`\n\n### `components/knowledge_base/document/StickyNotes.tsx` (3/4 dead)\n- `NotesGrid`\n- `NoteModalWrapper`\n- `NotesHeader`\n\n### `components/knowledge_base/document/ChatContainers.tsx` (7/30 dead \u2014 old conversation-list UI)\n- `AnimatedCard`\n- `ConversationCardSkeleton`\n- `ConversationCount`\n- `ConversationItem`\n- `ConversationList`\n- `ConversationSelector`\n- `InputActions`\n\n### `utils/navigationUtils.ts` (10/38 dead)\n- `clearAnnotationSelection`, `navigateToCorpusThread`, `navigateToDocumentThread`, `navigateToExtract`, `LocationLike`, `NavigateFn`, `ParsedRoute`, `RelationshipDocumentInfo`, plus 2 more\n\n### `components/types.ts` (10/29 dead \u2014 corrected from 11/29)\n- `OCUser`, `PaperStatus`, `PaperStatusRequestOutputs`, `LabelOptionProps`, `LabelsetOptionProps`, `ActionDropdownItem`, `PropertyWidgetComponent`, `PropertyWidgetProps`, plus 2 more\n\n### Type-only dead exports in alive hooks (delete the unused interfaces, keep the hook)\n- `hooks/useNetworkStatus.ts`: `NetworkStatus`, `UseNetworkStatusOptions`, `UseNetworkStatusReturn`\n- `hooks/useNotificationWebSocket.ts`: `ConnectionState`, `NotificationActor`, `NotificationMessageType`, `NotificationUpdateMessage`, `UseNotificationWebSocketOptions`, `UseNotificationWebSocketReturn`\n\n## Known false positive \u2014 DO NOT touch\n`components/admin/PipelineIcons.tsx` looks like 10/11 dead but the icon components are referenced internally by `getComponentIcon()` via string-lookup. **Leave that file alone.**\n\n## Acceptance criteria\n- [ ] Each listed export removed\n- [ ] `yarn build`, `yarn test:unit`, `yarn test:ct --reporter=list` pass\n- [ ] No new TS errors\n- [ ] `PipelineIcons.tsx` left untouched\n- [ ] `flattenMessageTree`, `findMessageInTree`, `EditMode` left untouched (tested)\n\nPart of frontend dead-code cleanup effort. See #1240 for the methodology gap that affected this issue.", "state": "CLOSED", "created_at": "2026-04-13T03:03:08Z", "closed_at": "2026-04-15T03:27:43Z", "author_login": "JSv4", "comment_rounds": [], "resolution": "closed_by_pr", "closed_by_pr": 1255, "link_type": "closing_keyword", "will_close": true, "comment_count": 0, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": [], "milestone": null, "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

OptimistikSAS_OIBus_4558/issues/OptimistikSAS_OIBus_4557.json

@@ -0,0 +1 @@
+{"number": 4557, "title": "Improve display of items with transformers", "body": "On north and history transformers associated with items, as below:\n<img width=\"961\" height=\"185\" alt=\"Image\" src=\"https://github.com/user-attachments/assets/47510d40-df31-43f6-8281-e4f1d32c64ea\" />\n\n- when only one item: display the item name with ellipsis. On hover, display an overlay with full item name\n- when several item: display the number of items, and an ellipsis. On hover, display an overlay with list of the five first full item names, and `... (x more)` at the end of the list ", "state": "CLOSED", "created_at": "2026-04-20T10:18:28Z", "closed_at": "2026-04-20T13:51:15Z", "author_login": "burgerni10", "comment_rounds": [], "resolution": "closed_by_pr", "closed_by_pr": 4558, "link_type": "closing_keyword", "will_close": true, "comment_count": 0, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["transformers"], "milestone": "3.8.0", "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

Picorims_wav2bar-reborn_148/issues/Picorims_wav2bar-reborn_29.json

@@ -0,0 +1 @@
+{"number": 29, "title": "[DEV] Project settings popup", "body": "", "state": "CLOSED", "created_at": "2024-06-14T21:13:36Z", "closed_at": "2025-12-02T14:18:35Z", "author_login": "Picorims", "comment_rounds": [], "resolution": "closed_by_pr", "closed_by_pr": 148, "link_type": "closing_keyword", "will_close": true, "comment_count": 0, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["task"], "milestone": "1.0.0-beta.1", "sub_issues": [], "sub_issue_count": 0, "parent_issues": [], "body_backfilled": true}

SR5-FoundryVTT_SR5-FoundryVTT_1776/issues/SR5-FoundryVTT_SR5-FoundryVTT_1760.json

@@ -0,0 +1 @@
+{"number": 1760, "title": "[BUG] Item quantities cannot be changed in edit mode.", "body": "**Describe the bug**\nItem quantities cannot be changed in edit mode.\n\n**Modules**\nNo modules\n\n**To Reproduce**\nSteps to reproduce the behavior:\n1. Select Inventory from the Character Sheet\n2. Toggle edit mode\n3. Item Quantity Change\n4. The quantity remains unchanged and reverts to the original quantity.\n\n**Screenshots**\n\n<img width=\"692\" height=\"76\" alt=\"Image\" src=\"https://github.com/user-attachments/assets/6971ba4f-2887-4298-a350-738402c9e586\" />\n\n<img width=\"689\" height=\"60\" alt=\"Image\" src=\"https://github.com/user-attachments/assets/b124d4c5-175f-41b9-9a4f-c92358322492\" />\n\n**Versions (please complete the following information):**\n - FoundryVTT Version v13 build 351\n - System Version 0.32.3\n", "state": "CLOSED", "created_at": "2026-01-18T01:10:47Z", "closed_at": "2026-01-24T15:08:53Z", "author_login": "stevejew", "comment_rounds": [], "resolution": "closed_by_pr", "closed_by_pr": 1776, "link_type": "closing_keyword", "will_close": true, "comment_count": 0, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["bug"], "milestone": null, "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

SSC-ICT-Innovatie_nl-kat-coordination_3511/issues/SSC-ICT-Innovatie_nl-kat-coordination_3397.json

@@ -0,0 +1 @@
+{"number": 3397, "title": "Produce JSON-line output when JSON logging is configured", "body": "## About this feature\r\n\r\n### Detailed description\r\n\r\nThis feature introduces pure JSON-lines log output for OpenKAT log records when the `LOGGING_FORMAT` option is set to `json`. This change allows all log entries to be formatted as single-line JSON objects, which should lead to easier parsing and integration with log aggregation tools. Currently the JSON log record is also printed, but with a fixed preamble that in most cases isn't relevant for machine processing.\r\n\r\n### Feature benefit/User story\r\n\r\nAs a developer/ administrator, I want to configure OpenKAT to enable pure JSON line logging so that log aggregation and analysis become more efficient and easier.\r\n\r\n### Specifications\r\n\r\nThe implementation should include:\r\n\r\n- [ ] When `json` is set for the `[*_]LOGGING_FORMAT` variables, OpenKAT should log JSON lines without preamble that contains the complete log record (event message, log level, timestamp, context variables)\r\n\r\n### Additional information\r\n\r\nCertain log lines that come from external dependencies (or plugins) may introduce some noise in the logging because of different log record formats. Failures due to parsing errors or parsing specific external packages logging should be handled by the log aggregator. This feature will focus only on the log records produced by our own applications for now.\r\n\r\n## Implementation\r\n\r\nImplement the correct log format for JSON lines for each service.\r\n\r\n### Possible solution\r\n\r\nThere are a few ways to deal with this:\r\n- Configure the default formatter for console loggin to use this format `\"%(message)s\"`\r\n- See [this](https://www.structlog.org/en/stable/standard-library.html#suggested-configurations) for more ideas using structlog\r\n  - Most of the suggestions involve overriding the root logger with structlog's JSON formatter\r\n- Use [python-json-logger](https://github.com/madzak/python-json-logger)\r\n  - This also involves overriding the root logger's format\r\n  - Can also be used in conjunction with structlog\r\n\r\n### Alternatives considered\r\n\r\nAn alternative would be to not implement this feature and instead rely on a log aggregator to parse the logs. Since the structure of the preamble is fixed, extracting the JSON log record should be doable. However, implementing this on the application side would improve overall performance and reduce reliance on potentially complex configurations in log aggregators.\r\n", "state": "CLOSED", "created_at": "2024-08-22T08:22:33Z", "closed_at": "2024-09-17T08:50:49Z", "author_login": "ammar92", "comment_rounds": [], "resolution": "closed_by_pr", "closed_by_pr": 3511, "link_type": "closing_keyword", "will_close": true, "comment_count": 0, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["python"], "milestone": null, "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

SSC-ICT-Innovatie_nl-kat-coordination_3521/issues/SSC-ICT-Innovatie_nl-kat-coordination_3468.json

@@ -0,0 +1 @@
+{"number": 3468, "title": "Create Boefjes - Edit Boefje", "body": "## About this feature\n\n### Detailed description\nIt should be possible to edit the details/settings of the created Boefjes.\n\n### Feature benefit/User story\nAs a user, I want to edit my Boefje, so that I can quickly make changes.\n\n### Specifications\nThe implementation should include\u2026\n\n- [ ] \"Edit variant\" button\n- [ ] Filled in 'Edit \"Boefje -name-\"' page\n\n\n## Design\n\n\n### Screenshots\n\n_Include screenshots of the proposed design changes here._\n\n### Figma link\nhttps://www.figma.com/design/D48Pf9lLpxET1jp0Wsjzw5/%E2%9C%85-KAT-%7C-Approved-%7C-Boefjes?node-id=2301-14505&node-type=CANVAS&t=FjlhjSWyTlHzn3Kd-0\n\n## Implementation\n\n_This part should only be filled in by the developers._\n\n### Possible solution\n\n_Outline your proposed solution for implementing the feature. You can include any specific ideas, designs, or functionalities here._\n\n### Alternatives considered\n\n_Describe any alternative approaches or solutions you've considered, and why you believe the proposed solution is superior._\n", "state": "CLOSED", "created_at": "2024-09-05T07:56:30Z", "closed_at": "2024-09-26T11:47:49Z", "author_login": "madelondohmen", "comment_rounds": [], "resolution": "closed_by_pr", "closed_by_pr": 3521, "link_type": "closing_keyword", "will_close": true, "comment_count": 0, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["frontend", "boefjes", "approved for implementation"], "milestone": null, "sub_issues": [], "sub_issue_count": 0, "parent_issues": [{"number": 2736, "title": "Multiple boefjes on one image", "state": "CLOSED"}]}

SubnauticaNitrox_Nitrox_2196/issues/SubnauticaNitrox_Nitrox_2186.json

@@ -0,0 +1 @@
+{"number": 2186, "title": "Equipped items are unequipped when rejoining the server", "body": "### Are you on the latest version of Nitrox?\n\nYes, I'm on the latest release of Nitrox.\n\n### Which OS are you playing on?\n\nWindows\n\n### On which platform did you buy Subnautica?\n\nSteam\n\n### Describe the issue.\n\nWhen my friends and I are reconnecting to the server, our players are being unequipped every time.\r\nAlso the batteries in the charging station are disappearing\r\n\r\nThis happens on MSStore version, as well as the Steam version \n\n### Describe the steps you took to encounter the bug.\n\n1. Join server\r\n2. Equip stuff / place batteries in charger\r\n3. Disconnect\r\n4. Stop server\r\n5. Start server\r\n6. Connect again\n\n### Relevant log output\n\nGame: https://pastebin.com/RGf2Hpw5\r\nServer: https://pastebin.com/shaiUdUX\r\n", "state": "CLOSED", "created_at": "2024-10-20T14:33:45Z", "closed_at": "2024-12-22T08:17:45Z", "author_login": "RedStylzZ", "comment_rounds": [], "resolution": "closed_by_pr", "closed_by_pr": 2196, "link_type": "closing_keyword", "will_close": true, "comment_count": 0, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["Complexity: easy", "Status: verified"], "milestone": "1.8", "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

TeamNewPipe_NewPipe_12471/issues/TeamNewPipe_NewPipe_12553.json

@@ -0,0 +1 @@
+{"number": 12553, "title": "Unable to create service", "body": "### Checklist\n\n- [x] I am able to reproduce the bug with the latest version given here: [CLICK THIS LINK](https://github.com/TeamNewPipe/NewPipe/releases/latest).\n- [x] I made sure that there are *no existing issues* - [open](https://github.com/TeamNewPipe/NewPipe/issues) or [closed](https://github.com/TeamNewPipe/NewPipe/issues?q=is%3Aissue+is%3Aclosed) - which I could contribute my information to.\n- [x] I have read the [FAQ](https://newpipe.net/FAQ/) and my problem isn't listed.\n- [x] I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.\n- [x] This issue contains only one bug.\n- [x] I have read and understood the [contribution guidelines](https://github.com/TeamNewPipe/NewPipe/blob/dev/.github/CONTRIBUTING.md).\n\n### Affected version\n\n0.28.0-25-202508180153\n\n### Steps to reproduce the bug\n\n1. Click on the link : [notify](https://youtu.be/OZRG7Og61mw?utm_campaign=2025-08-19-youtube-first-launch-teaser%20%2801K318CDH30KCJ5KNDG94SBWPE%29&utm_medium=email&utm_source=Newsletter&_kx=a1m7o-dnv-0MpzU_3UTqUwQmwFH84-rmErkoTiMc53DPD2-WmiAd9TicS7DiGipJ.LNYsuiLNYsui) \n2. That's all\n\n### Expected behavior\n\nGo to a Youtube video\n\n### Actual behavior\n\nCrash : Unable to create service \n\n### Screenshots/Screen recordings\n\n_No response_\n\n### Logs\n\n## Exception\n* __User Action:__ ui error\n* __Request:__ ACRA report\n* __Content Country:__ FR\n* __Content Language:__ fr-FR\n* __App Language:__ fr_FR\n* __Service:__ none\n* __Timestamp:__ 2025-08-19T22:46:52.098+02:00\n* __Package:__ org.schabi.newpipe.refactor.nightly\n* __Service:__ none\n* __Version:__ 0.28.0-25-202508180153\n* __OS:__ Linux Android 15 - 35\n<details><summary><b>Crash log </b></summary><p>\n\n```\njava.lang.RuntimeException: Unable to create service org.schabi.newpipe.RouterActivity$FetcherService: android.app.MissingForegroundServiceTypeException: Starting FGS without a type  callerApp=ProcessRecord{9749d2 20930:org.schabi.newpipe.refactor.nightly/u0a202} targetSDK=35\n\tat android.app.ActivityThread.handleCreateService(ActivityThread.java:5148)\n\tat android.app.ActivityThread.-$$Nest$mhandleCreateService(Unknown Source:0)\n\tat android.app.ActivityThread$H.handleMessage(ActivityThread.java:2547)\n\tat android.os.Handler.dispatchMessage(Handler.java:109)\n\tat android.os.Looper.loopOnce(Looper.java:232)\n\tat android.os.Looper.loop(Looper.java:317)\n\tat android.app.ActivityThread.main(ActivityThread.java:8934)\n\tat java.lang.reflect.Method.invoke(Native Method)\n\tat com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:591)\n\tat com.android.internal.os.ZygoteInit.main(ZygoteInit.java:911)\nCaused by: android.app.MissingForegroundServiceTypeException: Starting FGS without a type  callerApp=ProcessRecord{9749d2 20930:org.schabi.newpipe.refactor.nightly/u0a202} targetSDK=35\n\tat android.app.MissingForegroundServiceTypeException$1.createFromParcel(MissingForegroundServiceTypeException.java:53)\n\tat android.app.MissingForegroundServiceTypeException$1.createFromParcel(MissingForegroundServiceTypeException.java:49)\n\tat android.os.Parcel.readParcelableInternal(Parcel.java:5094)\n\tat android.os.Parcel.readParcelable(Parcel.java:5076)\n\tat android.os.Parcel.createExceptionOrNull(Parcel.java:3256)\n\tat android.os.Parcel.createException(Parcel.java:3245)\n\tat android.os.Parcel.readException(Parcel.java:3228)\n\tat android.os.Parcel.readException(Parcel.java:3170)\n\tat android.app.IActivityManager$Stub$Proxy.setServiceForeground(IActivityManager.java:7268)\n\tat android.app.Service.startForeground(Service.java:776)\n\tat org.schabi.newpipe.RouterActivity$FetcherService.onCreate(RouterActivity.java:949)\n\tat android.app.ActivityThread.handleCreateService(ActivityThread.java:5135)\n\t... 9 more\n\n```\n</details>\n<hr>\n\n\n### Affected Android/Custom ROM version\n\n_No response_\n\n### Affected device model\n\n_No response_\n\n### Additional information\n\n_No response_", "state": "CLOSED", "created_at": "2025-08-19T21:19:15Z", "closed_at": "2025-08-31T23:35:48Z", "author_login": "A-Nicoladie", "comment_rounds": [{"comments": [{"id": "IC_kwDOAn8tB86_1tFe", "body": "Thanks for the report. I did a fix for this issue here: https://github.com/TeamNewPipe/NewPipe/pull/12471", "createdAt": "2025-08-25T00:58:31Z", "updatedAt": "2025-08-25T00:58:31Z", "author": {"login": "Isira-Seneviratne"}}]}], "resolution": "closed_by_pr", "closed_by_pr": 12471, "link_type": "closing_keyword", "will_close": true, "comment_count": 1, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["bug", "new stream notification"], "milestone": null, "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

TeamNewPipe_NewPipe_12471/issues/TeamNewPipe_NewPipe_12564.json

@@ -0,0 +1 @@
+{"number": 12564, "title": "Crash on toggle the notification option in Settings Screen", "body": "### Checklist\n\n- [x] I am able to reproduce the bug with the latest version given here: [CLICK THIS LINK](https://github.com/TeamNewPipe/NewPipe/releases/latest).\n- [x] I made sure that there are *no existing issues* - [open](https://github.com/TeamNewPipe/NewPipe/issues) or [closed](https://github.com/TeamNewPipe/NewPipe/issues?q=is%3Aissue+is%3Aclosed) - which I could contribute my information to.\n- [x] I have read the [FAQ](https://newpipe.net/FAQ/) and my problem isn't listed.\n- [x] I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.\n- [x] This issue contains only one bug.\n- [x] I have read and understood the [contribution guidelines](https://github.com/TeamNewPipe/NewPipe/blob/dev/.github/CONTRIBUTING.md).\n\n### Affected version\n\n~0.28.0~ NewPipe-refactor-nightly-25\n\n### Steps to reproduce the bug\n\n1. Hamburger icon\n2. Goto Settings\n3. Click on Notifications                                                                            \n\n### Expected behavior\n\n_No response_\n\n### Actual behavior\n\n_No response_\n\n### Screenshots/Screen recordings\n\nhttps://github.com/user-attachments/assets/6c34f3c3-fc9b-45e9-8061-e2d9363b1133\n\n### Logs\n\n2025-08-22 13:18:55.654  4557-4557  AndroidRuntime          org.schabi.newpipe.debug.refactor    E  FATAL EXCEPTION: main (Ask Gemini)\n                                                                                                    Process: org.schabi.newpipe.debug.refactor, PID: 4557\n                                                                                                    java.lang.RuntimeException: Unable to start service androidx.work.impl.foreground.SystemForegroundService@a5fb237 with Intent { act=ACTION_START_FOREGROUND cmp=org.schabi.newpipe.debug.refactor/androidx.work.impl.foreground.SystemForegroundService (has extras) mCallingUid=11321 }: android.app.InvalidForegroundServiceTypeException: Starting FGS with type none callerApp=ProcessRecord{d20f224 4557:org.schabi.newpipe.debug.refactor/u0a1321} targetSDK=35 has been prohibited\n                                                                                                    \tat android.app.ActivityThread.handleServiceArgs(ActivityThread.java:5134)\n                                                                                                    \tat android.app.ActivityThread.-$$Nest$mhandleServiceArgs(Unknown Source:0)\n                                                                                                    \tat android.app.ActivityThread$H.handleMessage(ActivityThread.java:2481)\n                                                                                                    \tat android.os.Handler.dispatchMessage(Handler.java:106)\n                                                                                                    \tat android.os.Looper.loopOnce(Looper.java:257)\n                                                                                                    \tat android.os.Looper.loop(Looper.java:368)\n                                                                                                    \tat android.app.ActivityThread.main(ActivityThread.java:8839)\n                                                                                                    \tat java.lang.reflect.Method.invoke(Native Method)\n                                                                                                    \tat com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:572)\n                                                                                                    \tat com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1049)\n                                                                                                    Caused by: android.app.InvalidForegroundServiceTypeException: Starting FGS with type none callerApp=ProcessRecord{d20f224 4557:org.schabi.newpipe.debug.refactor/u0a1321} targetSDK=35 has been prohibited\n                                                                                                    \tat android.app.InvalidForegroundServiceTypeException$1.createFromParcel(InvalidForegroundServiceTypeException.java:53)\n                                                                                                    \tat android.app.InvalidForegroundServiceTypeException$1.createFromParcel(InvalidForegroundServiceTypeException.java:49)\n                                                                                                    \tat android.os.Parcel.readParcelableInternal(Parcel.java:4922)\n                                                                                                    \tat android.os.Parcel.readParcelable(Parcel.java:4904)\n                                                                                                    \tat android.os.Parcel.createExceptionOrNull(Parcel.java:3104)\n                                                                                                    \tat android.os.Parcel.createException(Parcel.java:3093)\n                                                                                                    \tat android.os.Parcel.readException(Parcel.java:3076)\n                                                                                                    \tat android.os.Parcel.readException(Parcel.java:3018)\n                                                                                                    \tat android.app.IActivityManager$Stub$Proxy.setServiceForeground(IActivityManager.java:6761)\n                                                                                                    \tat java.lang.reflect.Method.invoke(Native Method)\n                                                                                                    \tat leakcanary.ServiceWatcher$install$4$2.invoke(ServiceWatcher.kt:93)\n                                                                                                    \tat java.lang.reflect.Proxy.invoke(Proxy.java:1006)\n                                                                                                    \tat $Proxy6.setServiceForeground(Unknown Source)\n                                                                                                    \tat android.app.Service.startForeground(Service.java:862)\n                                                                                                    \tat androidx.work.impl.foreground.SystemForegroundService$Api31Impl.startForeground(SystemForegroundService.java:190)\n                                                                                                    \tat androidx.work.impl.foreground.SystemForegroundService.startForeground(SystemForegroundService.java:138)\n                                                                                                    \tat androidx.work.impl.foreground.SystemForegroundDispatcher.handleNotify(SystemForegroundDispatcher.java:332)\n                                                                                                    \tat androidx.work.impl.foreground.SystemForegroundDispatcher.onStartCommand(SystemForegroundDispatcher.java:221)\n                                                                                                    \tat androidx.work.impl.foreground.SystemForegroundService.onStartCommand(SystemForegroundService.java:80)\n                                                                                                    \tat android.app.ActivityThread.handleServiceArgs(ActivityThread.java:5116)\n                                                                                                    \tat android.app.ActivityThread.-$$Nest$mhandleServiceArgs(Unknown Source:0)\u00a0\n                                                                                                    \tat android.app.ActivityThread$H.handleMessage(ActivityThread.java:2481)\u00a0\n                                                                                                    \tat android.os.Handler.dispatchMessage(Handler.java:106)\u00a0\n                                                                                                    \tat android.os.Looper.loopOnce(Looper.java:257)\u00a0\n                                                                                                    \tat android.os.Looper.loop(Looper.java:368)\u00a0\n                                                                                                    \tat android.app.ActivityThread.main(ActivityThread.java:8839)\u00a0\n                                                                                                    \tat java.lang.reflect.Method.invoke(Native Method)\u00a0\n                                                                                                    \tat com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:572)\u00a0\n                                                                                                    \tat com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1049)\u00a0\n--------- beginning of main\n\n### Affected Android/Custom ROM version\n\nAndroid 14\n\n### Affected device model\n\nOnePlus Nord\n\n### Additional information\n\n_No response_", "state": "CLOSED", "created_at": "2025-08-22T07:55:06Z", "closed_at": "2025-08-31T23:35:48Z", "author_login": "venkatchalapathi", "comment_rounds": [{"comments": [{"id": "IC_kwDOAn8tB86_nyx9", "body": "Thank you for report!\n\n> `org.schabi.newpipe.debug.refactor`\n\nPlease precise you're on the refactor nightlies the next time you open a related issue, so we can differentiate between releases and nightlies :) It will be fixed by #12471.", "createdAt": "2025-08-22T16:02:31Z", "updatedAt": "2025-08-22T16:02:31Z", "author": {"login": "AudricV"}}]}], "resolution": "closed_by_pr", "closed_by_pr": 12471, "link_type": "closing_keyword", "will_close": true, "comment_count": 1, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["bug", "new stream notification"], "milestone": null, "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

WordPress_wordpress-playground_596__human_human/issues/WordPress_wordpress-playground_594.json

@@ -0,0 +1 @@
+{"number": 594, "title": "PHP: Support proc_open", "body": "PHPUnit and wp-cli both use `proc_open` and will only work correctly in WordPress Playground if that function is supported.\r\n\r\nToday `proc_open` does not work becuse [internally it calls `fork()`](https://github.com/php/php-src/blob/0de8bc270db6c2ffbe34a18393a74b996a010f50/ext/standard/proc_open.c#L1031) which is not supported in Emscripten and [doesn't seem possible to polyfill](https://github.com/WordPress/wordpress-playground/issues/595). \r\n\r\nTherefore, the only way to support `proc_open` is to shim it using `require('child_process').spawn()` similarly to how we shim `popen()`:\r\n\r\nhttps://github.com/WordPress/wordpress-playground/blob/cd4062de74f7f18058d3f962e124d0fdff78b5a7/packages/php-wasm/compile/build-assets/phpwasm-emscripten-library.js#L346\r\nhttps://github.com/WordPress/wordpress-playground/blob/cd4062de74f7f18058d3f962e124d0fdff78b5a7/packages/php-wasm/compile/build-assets/phpwasm-emscripten-library.js#L372-L384\r\n\r\n`proc_open` has the following signature in PHP:\r\n\r\n```php\r\nproc_open(\r\n    array|string $command,\r\n    array $descriptor_spec,\r\n    array &$pipes,\r\n    ?string $cwd = null,\r\n    ?array $env_vars = null,\r\n    ?array $options = null\r\n): resource|false\r\n```\r\n\r\nHandling `$pipes` is the most challenging bit here. Emscripten documentation doesn't explain how to create pipes \u2013 the easiest way should be reading the code and looking up examples.\r\n\r\nIf we can find a way to open Emscripten pipes and pass the data from/to the child process, that's great \u2013 that would probably involve custom Emscripten streams or devices. Otherwise, we could fake pipes by opening three temporary files in Emscripten (for stdin, stdout, stderr) and creating `$pipes` using those file descriptor.\r\n\r\ncc @wojtekn @sejas @danielbachhuber @schlessera", "state": "CLOSED", "created_at": "2023-06-25T08:09:47Z", "closed_at": "2023-10-24T20:03:32Z", "author_login": "adamziel", "comment_rounds": [{"comments": [{"id": "IC_kwDOH4hSRc5fvNxO", "body": "PHPUnit uses `proc_open` to support process isolation (which WordPress relies on):\r\n\r\n[TestCase::run()](https://github.com/sebastianbergmann/phpunit/blob/ae36aca08f9df9128c3a308b5801b0e36e6623dc/src/Framework/TestCase.php#L493):\r\n\r\n```php\r\n        if (!$this->shouldRunInSeparateProcess()) {\r\n            (new TestRunner)->run($this);\r\n        } else {\r\n            (new TestRunner)->runInSeparateProcess(\r\n                $this,\r\n                $this->runClassInSeparateProcess && !$this->runTestInSeparateProcess,\r\n                $this->preserveGlobalState,\r\n            );\r\n        }\r\n    }\r\n```\r\n\r\n[TestRunner::runInSeparateProcess](https://github.com/sebastianbergmann/phpunit/blob/ae36aca08f9df9128c3a308b5801b0e36e6623dc/src/Framework/TestRunner.php#L338-L339):\r\n\r\n```php\r\n$php = AbstractPhpProcess::factory();\r\n$php->runTestJob($template->render(), $test);\r\n```\r\n\r\n[DefaultPhpProcess::runProcess()](https://github.com/sebastianbergmann/phpunit/blob/ae36aca08f9df9128c3a308b5801b0e36e6623dc/src/Util/PHP/DefaultPhpProcess.php#L102-L108):\r\n\r\n```php\r\n        $process = proc_open(\r\n            $this->getCommand($settings, $this->tempFile),\r\n            $pipeSpec,\r\n            $pipes,\r\n            null,\r\n            $env,\r\n        );\r\n```", "createdAt": "2023-06-25T18:34:11Z", "updatedAt": "2023-06-25T18:34:18Z", "author": {"login": "adamziel"}}, {"id": "IC_kwDOH4hSRc5fvOag", "body": "[wp-cli proc_open usages](https://github.com/search?q=repo%3Awp-cli%2Fwp-cli+proc_open_compat&type=code)\r\n", "createdAt": "2023-06-25T18:47:32Z", "updatedAt": "2023-06-25T18:47:32Z", "author": {"login": "adamziel"}}]}], "resolution": "closed_by_pr", "closed_by_pr": 596, "link_type": "closing_keyword", "will_close": true, "comment_count": 2, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["[Type] Enhancement", "[Feature] PHP.wasm"], "milestone": null, "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

WordPress_wordpress-playground_596__human_human/issues/WordPress_wordpress-playground_710.json

@@ -0,0 +1 @@
+{"number": 710, "title": "Support system(), exec(), passthrough() functions", "body": "`popen` is already supported and `proc_open` support is [nearing in](https://github.com/WordPress/wordpress-playground/issues/594).\r\n\r\nLet's support system(), exec(), passthrough() too.\r\n\r\nTechnically, we'd have to provide a custom implementation for [php_exec](https://github.com/php/php-src/blob/7d551a89e5e0b95706ad7b37f5f25381bcc4bab0/ext/standard/exec.c#L114) in a similar way as we do for [popen](https://github.com/WordPress/wordpress-playground/blob/9065025043209ce06c9540886567ca5bc0ccfb11/packages/php-wasm/compile/Dockerfile#L545) (see [wasm_popen](https://github.com/WordPress/wordpress-playground/blob/9065025043209ce06c9540886567ca5bc0ccfb11/packages/php-wasm/compile/build-assets/php_wasm.c#L44))", "state": "CLOSED", "created_at": "2023-10-18T20:01:59Z", "closed_at": "2023-10-24T20:03:33Z", "author_login": "adamziel", "comment_rounds": [], "resolution": "closed_by_pr", "closed_by_pr": 596, "link_type": "closing_keyword", "will_close": true, "comment_count": 0, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["[Type] Enhancement", "[Feature] PHP.wasm"], "milestone": null, "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

ae-utbm_sith_1143/issues/ae-utbm_sith_1142.json

@@ -0,0 +1 @@
+{"number": 1142, "title": "Probl\u00e8me de s\u00e9curit\u00e9 exposant le username li\u00e9 \u00e0 un mail lors d'une connexion \u00e9chou\u00e9e", "body": "Salut,\n\nJ'ai voulu me connecter aujourd'hui en saisissant mon email et mon mdp et j'ai saisi un mot de passe incorrect.\n\nLors du refresh de la page avec le message \"Mot de passe incorrect\", il y a \u00e0 la place de l'email le nom d'utilisateur qui est pr\u00e9-rempli.\n\nCa signifie qu'on peut potentiellement parcourir une liste d'email pour y r\u00e9cup\u00e9rer le nom d'utilisateur qui n'est pas forc\u00e9ment public.", "state": "CLOSED", "created_at": "2025-06-25T08:32:38Z", "closed_at": "2025-10-08T09:47:10Z", "author_login": "theoraim", "comment_rounds": [{"comments": [{"id": "IC_kwDOH0Ifns6zD5yw", "body": "Le probl\u00e8me il viens d'ici https://github.com/Juknum/sith/blob/f474edc84f2cde7a742feab5f91091a0af5b33a9/core/views/forms.py#L135\nC'est la mani\u00e8re dont on g\u00e8re notre formulaire de login o\u00f9 on transforme l'email si il match en username.\nFaut qu'on revoie le process de login et partout o\u00f9 on l'utilise.\n\nJe m'en occupe quand j'ai le temps", "createdAt": "2025-06-25T09:50:09Z", "updatedAt": "2025-06-25T09:50:09Z", "author": {"login": "klmp200"}}, {"id": "IC_kwDOH0Ifns6zF0YR", "body": "Ca devrait r\u00e9soudre le probl\u00e8me", "createdAt": "2025-06-25T12:46:45Z", "updatedAt": "2025-06-25T12:46:45Z", "author": {"login": "imperosol"}}, {"id": "IC_kwDOH0Ifns6zRCzr", "body": "C'est possible de tester \u00e7a sur l'environnement de pr\u00e9prod ? C'est quoi l'URL ?", "createdAt": "2025-06-26T08:09:15Z", "updatedAt": "2025-06-26T08:09:15Z", "author": {"login": "theoraim"}}, {"id": "IC_kwDOH0Ifns6zSIGY", "body": "> C'est possible de tester \u00e7a sur l'environnement de pr\u00e9prod ? C'est quoi l'URL ?\n\nJe t'envoie le moyen d'acc\u00e9der \u00e0 \u00e7a en priv\u00e9.", "createdAt": "2025-06-26T09:45:38Z", "updatedAt": "2025-06-26T09:45:38Z", "author": {"login": "imperosol"}}]}, {"comments": [{"id": "IC_kwDOH0Ifns7JgZf3", "body": "fixed in #1143 ", "createdAt": "2025-10-08T09:47:10Z", "updatedAt": "2025-10-08T09:47:10Z", "author": {"login": "imperosol"}}]}], "resolution": "closed_manually", "closed_by_pr": null, "link_type": "closing_keyword", "will_close": true, "comment_count": 5, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": [], "milestone": null, "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

axelixlabs_axelix_36/issues/axelixlabs_axelix_34.json

@@ -0,0 +1 @@
+{"number": 34, "title": "Incorporate NullAway tool into our build pipleline", "body": "We're currently using the Jspecify in order to guard against nullability problems. It would be great to have a tool that checks our code at build time for being compliant with nullability.\n\nFor that, I think, we need to incorporate the NullAway tool.\n\n**DOD:**\n\nWe have the NullAway tool incorporated into our build pipeline for all Java services (Axile Master, Axile SBS etc). \n\nThe tool runs also on every commit into `master` branch and every PR and fails the build in case the nullability issues are detected. ", "state": "CLOSED", "created_at": "2025-08-20T15:44:39Z", "closed_at": "2025-08-28T07:20:04Z", "author_login": "mipo256", "comment_rounds": [], "resolution": "closed_by_pr", "closed_by_pr": 36, "link_type": "closing_keyword", "will_close": true, "comment_count": 0, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["enhancement", "ci-cd"], "milestone": null, "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

axelixlabs_axelix_923/issues/axelixlabs_axelix_844.json

@@ -0,0 +1 @@
+{"number": 844, "title": "[Feature] Allow self-registration and auto discovery modes to co-exist", "body": "This might be needed, for example, in case some services need to be managed by Axelix, but they are deployed from outside this K8S cluster.\n\n**TBD:**\n\nMake sure that Axelix Master can handle both modes at the same time.\n\nWe'll also need to introduce the field `latestHearthBeat` in `Instance`. It will never be `null` in the case of self-registered instances, and it will always be `null` in the case of auto-discovered instances. This field must be updated on every received heartbeat.\n", "state": "CLOSED", "created_at": "2026-03-20T11:28:44Z", "closed_at": "2026-04-21T10:41:52Z", "author_login": "mipo256", "comment_rounds": [], "resolution": "closed_by_pr", "closed_by_pr": 923, "link_type": "closing_keyword", "will_close": true, "comment_count": 0, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["enhancement", "master"], "milestone": "EA-Builds", "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

b-editor_beutl_1810/issues/b-editor_beutl_1807.json

@@ -0,0 +1 @@
+{"number": 1807, "title": "[Bug] JsonHelper.JsonRestore \u304c JsonException \u672a\u30ad\u30e3\u30c3\u30c1\u3067\u8a2d\u5b9a\u30d5\u30a1\u30a4\u30eb\u7834\u640d\u6642\u306b\u8d77\u52d5\u4e0d\u80fd", "body": "## \u6982\u8981 (Bug)\n`JsonHelper.JsonRestore` \u304c `JsonException` \u3092 catch \u305b\u305a\u3001\u8d77\u52d5\u6642\u306e\u5fc5\u9808\u8a2d\u5b9a\u30d5\u30a1\u30a4\u30eb\uff08`extensionsSettings.json` / `keymap.json`\uff09\u304c\u7834\u640d\u3057\u3066\u3044\u308b\u3068 BeutlApiApplication \u304c\u8d77\u52d5\u4e0d\u80fd\u306b\u306a\u308b\u3002\n\n## \u8a72\u5f53\u7b87\u6240\n- `src/Beutl.Core/JsonHelper.cs:132-137`\n- \u547c\u3073\u51fa\u3057\u5074: `ExtensionSettingsStore.RestoreAll` (line 26), `ContextCommandSettingsStore.RestoreAll` (line 345)\n\n## \u8a73\u7d30\n`JsonRestore(string filename)` \u306f `File.Exists` \u3092\u30c1\u30a7\u30c3\u30af\u3059\u308b\u304c\u3001`JsonNode.Parse(stream)` \u3092 try \u306a\u3057\u3067\u547c\u3076\u3002\u547c\u3073\u51fa\u3057\u5074\u306f\u3044\u305a\u308c\u3082\u30b3\u30f3\u30b9\u30c8\u30e9\u30af\u30bf\u3067\u547c\u3070\u308c\u3001\u30b3\u30f3\u30b9\u30c8\u30e9\u30af\u30bf\u306b\u3082 try/catch \u304c\u7121\u3044\u3002\n\n\u3053\u308c\u3089\u306f DI \u30b3\u30f3\u30c6\u30ca\u521d\u671f\u5316\u6642\u306e\u5fc5\u9808\u30ea\u30bd\u30fc\u30b9\u306a\u306e\u3067\u3001`extensionsSettings.json` \u307e\u305f\u306f `keymap.json` \u304c\u4e2d\u9014\u534a\u7aef\u306b\u66f8\u304b\u308c\u305f\u72b6\u614b\uff08\u30a2\u30d7\u30ea\u5f37\u5236\u7d42\u4e86\u76f4\u5f8c\u306a\u3069\uff09\u3067\u6b8b\u3063\u3066\u3044\u308b\u3068\u3001\u8d77\u52d5\u6642 `JsonException` \u3067 BeutlApiApplication \u304c\u5d29\u58ca\u3057\u3001\u30a8\u30f3\u30c9\u30e6\u30fc\u30b6\u30fc\u306f\u8a2d\u5b9a\u30d5\u30a1\u30a4\u30eb\u3092\u624b\u52d5\u524a\u9664\u3057\u306a\u3044\u3068\u8d77\u52d5\u3067\u304d\u306a\u3044\u3002\n\n`ViewConfig` \u306e\u540c\u7a2e\u554f\u984c\uff08PR #1759, commit `44c48846e`\uff09\u306f\u4fee\u6b63\u6e08\u307f\u3060\u304c\u3001\u3053\u3061\u3089\u306f\u672a\u5bfe\u51e6\u3002\n\n## \u5f71\u97ff\n\u8d77\u52d5\u6642\u30af\u30e9\u30c3\u30b7\u30e5\u3002\u4e00\u822c\u30e6\u30fc\u30b6\u30fc\u306f\u539f\u56e0\u3092\u7279\u5b9a\u3067\u304d\u305a\u3001\u30b5\u30dd\u30fc\u30c8\u306b\u983c\u3089\u3056\u308b\u3092\u5f97\u306a\u3044\u3002\n\n## \u4fee\u6b63\u6848\n- `JsonRestore` \u5185\u3067 `try { return JsonNode.Parse(stream); } catch (JsonException ex) { \u30ed\u30b0\u3092\u51fa\u3057\u3066 return null; }` \u3068\u3059\u308b\n- \u7834\u640d\u30d5\u30a1\u30a4\u30eb\u306f\u30d0\u30c3\u30af\u30a2\u30c3\u30d7\uff08`.corrupt-{timestamp}`\uff09\u3068\u3057\u3066\u9000\u907f\u3057\u3066\u304b\u3089 `null` \u3092\u8fd4\u3059\n- \u307e\u305f\u306f\u5404\u547c\u3073\u51fa\u3057\u5074 (`RestoreAll`) \u3067 try/catch \u3092\u8ffd\u52a0\n\n\u30ab\u30c6\u30b4\u30ea: null/\u4f8b\u5916\u51e6\u7406", "state": "CLOSED", "created_at": "2026-05-14T01:39:24Z", "closed_at": "2026-05-16T09:08:50Z", "author_login": "yuto-trd", "comment_rounds": [], "resolution": "closed_by_pr", "closed_by_pr": 1810, "link_type": "closing_keyword", "will_close": true, "comment_count": 0, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": [], "milestone": null, "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}

b-editor_beutl_1810/pr.json

@@ -0,0 +1 @@
+{"repo": "b-editor/beutl", "pr_number": 1810, "pr_title": "fix: catch JsonException in JsonRestore for corrupt config files (#1807)", "pr_state": "merged", "pr_author": "yuto-trd", "base_branch": "main", "head_branch": "yuto-trd/fix-1807", "created_at": "2026-05-14T03:32:38Z", "merged_at": "2026-05-16T09:08:49Z", "base_ref_oid": "22c490094f92d47e71a32f14f5c6e54520017ab7", "head_ref_oid": "dcc570923d3c55193f0535062e787b4892ca7c07", "base_commit": {"oid": "22c490094f92d47e71a32f14f5c6e54520017ab7", "message": "Bump Microsoft.Extensions.DependencyModel from 10.0.7 to 10.0.8 (#1801)", "authoredDate": "2026-05-13T23:25:33Z", "author": {"name": "dependabot[bot]", "email": "49699333+dependabot[bot]@users.noreply.github.com", "user": {"login": "dependabot[bot]"}}}, "rounds": [{"round_index": 0, "review_state": "COMMENTED", "review_author": "copilot-pull-request-reviewer", "submitted_at": "2026-05-14T03:35:34Z", "feedback_type": "mixed", "review_author_association": "CONTRIBUTOR", "inline_comments": [{"id": "PRRC_kwDOElVNoM7BDbom", "body": "`s_logger` is initialized at type-load time via `Log.CreateLogger(typeof(JsonHelper))`. In Release builds, `Beutl.Logging.Log.CreateLogger(...)` dereferences `Log.LoggerFactory` (null-forgiving) and will throw if logging hasn\u2019t been initialized yet. The app calls `GlobalConfiguration.Restore(...)` (which uses `JsonHelper.JsonRestore`) before `Telemetry.GetDisposable()` sets up `Logging.Log.LoggerFactory` (see `src/Beutl/Program.cs:17-24`), so this can introduce a startup crash even for valid JSON files. Consider making logger acquisition lazy and failure-tolerant (e.g., create the logger inside the catch block behind a try/catch and skip logging if `LoggerFactory` isn\u2019t ready, or use a null/no-op logger until logging is initialized).\n", "path": "src/Beutl.Core/JsonHelper.cs", "originalLine": 18, "line": null, "originalStartLine": 17, "startLine": null, "position": 1, "originalPosition": 14, "outdated": true, "subjectType": "LINE", "authorAssociation": "CONTRIBUTOR", "originalCommit": {"oid": "c54d44061536b60f4801eb748e156a1516ec0a9c"}, "diffHunk": "@@ -5,13 +5,16 @@\n using System.Text.Json.Nodes;\n using System.Text.Json.Serialization;\n using Beutl.JsonConverters;\n+using Beutl.Logging;\n using Beutl.Serialization;\n+using Microsoft.Extensions.Logging;\n \n namespace Beutl;\n \n public static class JsonHelper\n {\n     private static readonly ConditionalWeakTable<Type, JsonConverter> s_converters = [];\n+    private static readonly ILogger s_logger = Log.CreateLogger(typeof(JsonHelper));\n ", "replyTo": null, "createdAt": "2026-05-14T03:35:34Z", "author": {"login": "copilot-pull-request-reviewer"}, "reactions": {"totalCount": 0, "nodes": []}, "in_reply_to_id": null, "suggested_changes": [], "extended_context": "using Beutl.Serialization;\n\nnamespace Beutl;\n\npublic static class JsonHelper\n{\n    private static readonly ConditionalWeakTable<Type, JsonConverter> s_converters = [];\n\n    public static JsonWriterOptions WriterOptions { get; } = new()\n    {\n        Encoder = JavaScriptEncoder.UnsafeRelaxedJsonEscaping,\n        Indented = true,\n    };\n\n    public static JsonSerializerOptions SerializerOptions { get; } = new()\n    {\n        WriteIndented = true,\n        Encoder = JavaScriptEncoder.UnsafeRelaxedJsonEscaping,\n        TypeInfoResolver = null,\n        NumberHandling = JsonNumberHandling.AllowNamedFloatingPointLiterals | JsonNumberHandling.AllowReadingFromString,\n        Converters =", "referenced_paths": []}], "body_comments": [{"body": "## Pull request overview\n\nThis PR hardens startup config loading by making `JsonHelper.JsonRestore` resilient to corrupted JSON files (e.g., half-written config after abrupt termination), so callers treat corrupt configs as \u201cmissing\u201d instead of crashing the application.\n\n**Changes:**\n- Catch `JsonException` in `JsonHelper.JsonRestore`, log the failure (including path), and return `null`.\n- Add unit tests asserting `JsonRestore` returns `null` for invalid JSON and does not modify/delete the corrupt file.\n\n### Reviewed changes\n\nCopilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.\n\n| File | Description |\n| ---- | ----------- |\n| tests/Beutl.UnitTests/Core/JsonHelperTests.cs | Adds coverage for invalid JSON restore behavior and ensures corrupt files are left untouched. |\n| src/Beutl.Core/JsonHelper.cs | Adds centralized `JsonException` handling and logging for JSON restore. |\n\n\n\n\n\n---\n\n\ud83d\udca1 <a href=\"/b-editor/beutl/new/main?filename=.github/instructions/*.instructions.md\" class=\"Link--inTextBlock\" target=\"_blank\" rel=\"noopener noreferrer\">Add Copilot custom instructions</a> for smarter, more guided reviews. <a href=\"https://docs.github.com/en/copilot/customizing-copilot/adding-repository-custom-instructions-for-github-copilot\" class=\"Link--inTextBlock\" target=\"_blank\" rel=\"noopener noreferrer\">Learn how to get started</a>.", "referenced_paths": ["tests/Beutl.UnitTests/Core/JsonHelperTests.cs", "src/Beutl.Core/JsonHelper.cs"], "reactions": []}], "response_commits": [{"oid": "28e24af2681bea210f3ce236b7f6e09c7a883754", "message": "fix: defer JsonHelper logger init to avoid startup NRE in Release\n\nGlobalConfiguration.Restore runs before Telemetry sets Log.LoggerFactory,\nso the eager s_logger initializer threw TypeInitializationException on\nRelease builds. Make logger acquisition lazy and fall back to NullLogger\nwhen the factory is not yet available.", "authoredDate": "2026-05-16T08:20:16Z", "author": {"user": {"login": "yuto-trd"}, "name": "Yuto Terada"}, "statusCheckRollup": {"state": "SUCCESS", "contexts": {"nodes": [{"__typename": "CheckRun", "name": "claude", "conclusion": "SKIPPED", "startedAt": "2026-05-16T08:29:48Z", "completedAt": "2026-05-16T08:29:48Z"}, {"__typename": "CheckRun", "name": "build", "conclusion": "SUCCESS", "startedAt": "2026-05-16T08:26:02Z", "completedAt": "2026-05-16T08:29:24Z"}, {"__typename": "CheckRun", "name": "find-todo-comments", "conclusion": "SUCCESS", "startedAt": "2026-05-16T08:26:01Z", "completedAt": "2026-05-16T08:26:14Z"}, {"__typename": "CheckRun", "name": "Analyze (csharp)", "conclusion": "SUCCESS", "startedAt": "2026-05-16T08:26:00Z", "completedAt": "2026-05-16T08:37:27Z"}, {"__typename": "CheckRun", "name": "dotnet-format", "conclusion": "SUCCESS", "startedAt": "2026-05-16T08:26:00Z", "completedAt": "2026-05-16T08:28:25Z"}, {"__typename": "CheckRun", "name": "CodeQL", "conclusion": "SUCCESS", "startedAt": "2026-05-16T08:37:18Z", "completedAt": "2026-05-16T08:37:19Z"}]}}, "author_type": "agent", "agent_commit_signals": ["conventional_prefix:fix"], "ci_state": "SUCCESS", "ci_contexts": [{"__typename": "CheckRun", "name": "claude", "conclusion": "SKIPPED", "startedAt": "2026-05-16T08:29:48Z", "completedAt": "2026-05-16T08:29:48Z"}, {"__typename": "CheckRun", "name": "build", "conclusion": "SUCCESS", "startedAt": "2026-05-16T08:26:02Z", "completedAt": "2026-05-16T08:29:24Z"}, {"__typename": "CheckRun", "name": "find-todo-comments", "conclusion": "SUCCESS", "startedAt": "2026-05-16T08:26:01Z", "completedAt": "2026-05-16T08:26:14Z"}, {"__typename": "CheckRun", "name": "Analyze (csharp)", "conclusion": "SUCCESS", "startedAt": "2026-05-16T08:26:00Z", "completedAt": "2026-05-16T08:37:27Z"}, {"__typename": "CheckRun", "name": "dotnet-format", "conclusion": "SUCCESS", "startedAt": "2026-05-16T08:26:00Z", "completedAt": "2026-05-16T08:28:25Z"}, {"__typename": "CheckRun", "name": "CodeQL", "conclusion": "SUCCESS", "startedAt": "2026-05-16T08:37:18Z", "completedAt": "2026-05-16T08:37:19Z"}], "ci_failed_checks": [], "ci_test_check_failed": false}], "force_pushes": [], "builds_on_rounds": [], "references_repo_structure": true, "ci_state_at_review": "SUCCESS", "ci_state_after_response": "SUCCESS", "ci_transition": "pass_to_pass", "response_commit_diffs": {"28e24af2681bea210f3ce236b7f6e09c7a883754": {"src/Beutl.Core/JsonHelper.cs": [[8, 39], [163, 169]]}}, "has_code_backing": false, "head_commit_at_review": "c54d44061536b60f4801eb748e156a1516ec0a9c", "file_contents_at_review": {"src/Beutl.Core/JsonHelper.cs": "\ufeffusing System.Diagnostics.CodeAnalysis;\nusing System.Runtime.CompilerServices;\nusing System.Text.Encodings.Web;\nusing System.Text.Json;\nusing System.Text.Json.Nodes;\nusing System.Text.Json.Serialization;\nusing Beutl.JsonConverters;\nusing Beutl.Logging;\nusing Beutl.Serialization;\nusing Microsoft.Extensions.Logging;\n\nnamespace Beutl;\n\npublic static class JsonHelper\n{\n    private static readonly ConditionalWeakTable<Type, JsonConverter> s_converters = [];\n    private static readonly ILogger s_logger = Log.CreateLogger(typeof(JsonHelper));\n\n    public static JsonWriterOptions WriterOptions { get; } = new()\n    {\n        Encoder = JavaScriptEncoder.UnsafeRelaxedJsonEscaping,\n        Indented = true,\n    };\n\n    public static JsonSerializerOptions SerializerOptions { get; } = new()\n    {\n        WriteIndented = true,\n        Encoder = JavaScriptEncoder.UnsafeRelaxedJsonEscaping,\n        TypeInfoResolver = null,\n        NumberHandling = JsonNumberHandling.AllowNamedFloatingPointLiterals | JsonNumberHandling.AllowReadingFromString,\n        Converters =\n        {\n            new OptionalJsonConverter(),\n            new CultureInfoConverter(),\n            new DirectoryInfoConverter(),\n            new FileInfoConverter(),\n            new CoreSerializableJsonConverter(),\n            new Vector3JsonConverter(),\n            new QuaternionJsonConverter()\n            //new CoreObjectJsonConverter()\n        }\n    };\n\n    public static JsonConverter GetOrCreateConverterInstance(Type converterType)\n    {\n        if (s_converters.TryGetValue(converterType, out JsonConverter? converter))\n        {\n            return converter;\n        }\n        else\n        {\n            converter = (JsonConverter)Activator.CreateInstance(converterType)!;\n            s_converters.Add(converterType, converter);\n            return converter;\n        }\n    }\n\n    public static void JsonSave(this IJsonSerializable serializable, string filename)\n    {\n        var json = new JsonObject();\n\n        serializable.WriteToJson(json);\n\n        json.JsonSave(filename);\n    }\n\n    public static void JsonRestore(this IJsonSerializable serializable, string filename)\n    {\n        if (JsonRestore(filename) is JsonObject obj)\n        {\n            serializable.ReadFromJson(obj);\n        }\n    }\n\n    public static void JsonSave2(this ICoreSerializable serializable, string filename)\n    {\n        var context = new JsonSerializationContext(serializable.GetType());\n        using (ThreadLocalSerializationContext.Enter(context))\n        {\n            serializable.Serialize(context);\n\n            context.GetJsonObject().JsonSave(filename);\n        }\n    }\n\n    public static void JsonRestore2(this ICoreSerializable serializable, string filename)\n    {\n        if (JsonRestore(filename) is JsonObject obj)\n        {\n            var context = new JsonSerializationContext(\n                serializable.GetType(), json: obj);\n            using (ThreadLocalSerializationContext.Enter(context))\n            {\n                serializable.Deserialize(context);\n                context.AfterDeserialized(serializable);\n            }\n        }\n    }\n\n    public static void JsonSave(this JsonNode node, string filename)\n    {\n        // tmp \u306b\u66f8\u3044\u3066\u304b\u3089 rename \u3059\u308b\u3053\u3068\u3067\u3001\u66f8\u304d\u8fbc\u307f\u4e2d\u306e\u30af\u30e9\u30c3\u30b7\u30e5\u30fb\u96fb\u6e90\u65ad\u30fb\n        // \u30c7\u30a3\u30b9\u30af\u30d5\u30eb\u3067\u30bf\u30fc\u30b2\u30c3\u30c8\u30d5\u30a1\u30a4\u30eb\u304c\u30bc\u30ed\u30d0\u30a4\u30c8\u3067\u6b8b\u308b\u306e\u3092\u9632\u3050\u3002\n        // \u65e2\u5b58\u30d5\u30a1\u30a4\u30eb\u306f rename \u6210\u529f\u6642\u306e\u307f\u7f6e\u304d\u63db\u308f\u308b\u305f\u3081\u3001\u30e6\u30fc\u30b6\u30fc\u306e\u30d7\u30ed\u30b8\u30a7\u30af\u30c8\u3084\n        // \u8a2d\u5b9a\u30d5\u30a1\u30a4\u30eb\u304c\u7834\u640d\u3057\u306a\u3044\u3002\n        // \u56fa\u5b9a\u306e `.tmp` \u30b5\u30d5\u30a3\u30c3\u30af\u30b9\u3060\u3068\u30e6\u30fc\u30b6\u30fc\u3084\u4ed6\u30c4\u30fc\u30eb\u304c\u65e2\u306b\u6301\u3064\u540c\u540d\u30d5\u30a1\u30a4\u30eb\u3092\n        // \u4e0a\u66f8\u304d\u3057\u3066\u3057\u307e\u3046\u305f\u3081\u3001\u30e9\u30f3\u30c0\u30e0\u30b5\u30d5\u30a3\u30c3\u30af\u30b9\u3092\u4ed8\u4e0e\u3057\u3066\u885d\u7a81\u3092\u907f\u3051\u308b\u3002\n        string tmp = $\"{filename}.{Guid.NewGuid():N}.tmp\";\n        try\n        {\n            using (var stream = new FileStream(tmp, FileMode.CreateNew, FileAccess.Write, FileShare.None))\n            using (var writer = new Utf8JsonWriter(stream, WriterOptions))\n            {\n                node.WriteTo(writer, SerializerOptions);\n                writer.Flush();\n                stream.Flush(flushToDisk: true);\n            }\n\n            File.Move(tmp, filename, overwrite: true);\n        }\n        catch\n        {\n            try\n            {\n                if (File.Exists(tmp)) File.Delete(tmp);\n            }\n            catch\n            {\n                // \u5931\u6557\u3057\u3066\u3082\u5143\u306e\u4f8b\u5916\u306f\u6295\u3052\u308b\n            }\n            throw;\n        }\n    }\n\n    public static JsonNode? JsonRestore(string filename)\n    {\n        if (!File.Exists(filename)) return null;\n        using var stream = new FileStream(filename, FileMode.Open, FileAccess.Read, FileShare.Read);\n        try\n        {\n            return JsonNode.Parse(stream);\n        }\n        catch (JsonException ex)\n        {\n            // \u7834\u640d\u30d5\u30a1\u30a4\u30eb\u306f\u6b21\u56de\u4fdd\u5b58\u6642\u306b\u30a2\u30c8\u30df\u30c3\u30af\u66f8\u304d\u8fbc\u307f\u3067\u4e0a\u66f8\u304d\u3055\u308c\u308b\u305f\u3081\u305d\u306e\u307e\u307e\u653e\u7f6e\u3002\n            // \u30d5\u30a1\u30a4\u30eb\u3092\u6d88\u3059\u3068\u8abf\u67fb\u7528\u306e\u8a3c\u62e0\u3092\u5931\u3046\u306e\u3067\u89e6\u3089\u306a\u3044\u3002\n            s_logger.LogError(ex, \"Failed to parse JSON file {Path}; treating as missing.\", filename);\n            return null;\n        }\n    }\n\n    public static Type? GetDiscriminator(this JsonNode node)\n    {\n        return node.TryGetDiscriminator(out Type? type) ? type : null;\n    }\n\n    public static Type? GetDiscriminator(this JsonNode node, Type baseType)\n    {\n        if (node.TryGetDiscriminator(out Type? type))\n        {\n            return type;\n        }\n        else\n        {\n            if (Attribute.GetCustomAttribute(baseType, typeof(FallbackTypeAttribute)) is FallbackTypeAttribute att)\n            {\n                return att.FallbackType;\n            }\n            else\n            {\n                return null;\n            }\n        }\n    }\n\n    public static bool TryGetDiscriminator(this JsonNode node, [NotNullWhen(true)] out Type? type)\n    {\n        type = null;\n        if (node is JsonObject obj)\n        {\n            JsonNode? typeNode = obj.TryGetPropertyValue(\"$type\", out JsonNode? typeNode1) ? typeNode1\n                               : obj.TryGetPropertyValue(\"@type\", out JsonNode? typeNode2) ? typeNode2\n                               : null;\n\n            if (typeNode is JsonValue typeValue\n                && typeValue.TryGetValue(out string? typeStr)\n                && !string.IsNullOrWhiteSpace(typeStr))\n            {\n                type = TypeFormat.ToType(typeStr);\n            }\n        }\n\n        return type != null;\n    }\n\n    public static bool TryGetDiscriminator(this JsonNode node, [NotNullWhen(true)] out string? result)\n    {\n        result = null;\n        if (node is JsonObject obj)\n        {\n            JsonNode? typeNode = obj.TryGetPropertyValue(\"$type\", out JsonNode? typeNode1) ? typeNode1\n                               : obj.TryGetPropertyValue(\"@type\", out JsonNode? typeNode2) ? typeNode2\n                               : null;\n\n            if (typeNode is JsonValue typeValue\n                && typeValue.TryGetValue(out string? typeStr)\n                && !string.IsNullOrWhiteSpace(typeStr))\n            {\n                result = typeStr;\n            }\n        }\n\n        return result != null;\n    }\n\n    public static void WriteDiscriminator(this JsonNode obj, Type type)\n    {\n        obj[\"$type\"] = TypeFormat.ToString(type);\n    }\n\n    private static Dictionary<string, object> ParseJson(string json)\n    {\n        Dictionary<string, JsonElement> dic = JsonSerializer.Deserialize<Dictionary<string, JsonElement>>(json)!;\n\n        return dic.ToDictionary(x => x.Key, x => ParseJsonElement(x.Value)!);\n    }\n\n    private static object? ParseJsonElement(JsonElement elem)\n    {\n        return elem.ValueKind switch\n        {\n            JsonValueKind.String => elem.GetString(),\n            JsonValueKind.Number => elem.GetDouble(),\n            JsonValueKind.False => false,\n            JsonValueKind.True => true,\n            JsonValueKind.Array => elem.EnumerateArray().Select(e => ParseJsonElement(e)).ToArray(),\n            JsonValueKind.Null => null,\n            JsonValueKind.Object => ParseJson(elem.GetRawText()),\n            _ => throw new NotSupportedException(),\n        };\n    }\n\n    public static Dictionary<string, object> ToDictionary(this JsonNode json)\n    {\n        Dictionary<string, JsonElement> dic = JsonSerializer.Deserialize<Dictionary<string, JsonElement>>(json)!;\n\n        return dic.ToDictionary(x => x.Key, x => ParseJsonElement(x.Value)!);\n    }\n\n    public static bool TryGetPropertyValueAsJsonValue<T>(this JsonObject obj, string propertyName, [NotNullWhen(true)] out T? value)\n    {\n        value = default;\n        return obj.TryGetPropertyValue(propertyName, out JsonNode? node)\n            && node is JsonValue val\n            && val.TryGetValue(out value);\n    }\n}\n"}}, {"round_index": 1, "review_state": "COMMENTED", "review_author": "chatgpt-codex-connector", "submitted_at": "2026-05-16T08:29:44Z", "feedback_type": "mixed", "review_author_association": "NONE", "inline_comments": [{"id": "PRRC_kwDOElVNoM7B3ZGC", "body": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub>  Avoid caching NullLogger after early logger init failure**\n\nWhen `JsonRestore` hits a corrupt file before `Log.LoggerFactory` is initialized, `CreateLoggerSafe()` returns `NullLogger.Instance`, and `s_logger ??=` permanently caches that value for the rest of the process. In that startup path, all later `JsonHelper` parse failures in the same run are silently dropped even after telemetry initializes logging, which defeats the new diagnostic behavior for exactly the recovery scenario this change targets.\n\nUseful? React with \ud83d\udc4d\u00a0/ \ud83d\udc4e.", "path": "src/Beutl.Core/JsonHelper.cs", "originalLine": 24, "line": null, "originalStartLine": null, "startLine": null, "position": 1, "originalPosition": 20, "outdated": true, "subjectType": "LINE", "authorAssociation": "NONE", "originalCommit": {"oid": "28e24af2681bea210f3ce236b7f6e09c7a883754"}, "diffHunk": "@@ -5,13 +5,35 @@\n using System.Text.Json.Nodes;\n using System.Text.Json.Serialization;\n using Beutl.JsonConverters;\n+using Beutl.Logging;\n using Beutl.Serialization;\n+using Microsoft.Extensions.Logging;\n+using Microsoft.Extensions.Logging.Abstractions;\n \n namespace Beutl;\n \n public static class JsonHelper\n {\n     private static readonly ConditionalWeakTable<Type, JsonConverter> s_converters = [];\n+    private static ILogger? s_logger;\n+\n+    // Program.Main \u306f GlobalConfiguration.Restore (JsonHelper \u3092\u7d4c\u7531) \u3092 Telemetry \u304c\n+    // Log.LoggerFactory \u3092\u30bb\u30c3\u30c8\u3059\u308b\u3088\u308a\u524d\u306b\u547c\u3076\u3002Release \u30d3\u30eb\u30c9\u3067\u306f LoggerFactory \u304c\n+    // null \u306e\u307e\u307e CreateLogger \u3092\u547c\u3076\u3068 TypeInitializationException \u3067\u8d77\u52d5\u304c\u843d\u3061\u308b\u305f\u3081\u3001\n+    // \u9045\u5ef6\u53d6\u5f97 + \u5931\u6557\u6642\u306f NullLogger \u306b\u30d5\u30a9\u30fc\u30eb\u30d0\u30c3\u30af\u3059\u308b\u3002\n+    private static ILogger Logger => s_logger ??= CreateLoggerSafe();", "replyTo": null, "createdAt": "2026-05-16T08:29:44Z", "author": {"login": "chatgpt-codex-connector"}, "reactions": {"totalCount": 0, "nodes": []}, "in_reply_to_id": null, "suggested_changes": [], "extended_context": "    private static readonly ConditionalWeakTable<Type, JsonConverter> s_converters = [];\n\n    public static JsonWriterOptions WriterOptions { get; } = new()\n    {\n        Encoder = JavaScriptEncoder.UnsafeRelaxedJsonEscaping,\n        Indented = true,\n    };\n\n    public static JsonSerializerOptions SerializerOptions { get; } = new()\n    {\n        WriteIndented = true,\n        Encoder = JavaScriptEncoder.UnsafeRelaxedJsonEscaping,\n        TypeInfoResolver = null,\n        NumberHandling = JsonNumberHandling.AllowNamedFloatingPointLiterals | JsonNumberHandling.AllowReadingFromString,\n        Converters =\n        {\n            new OptionalJsonConverter(),\n            new CultureInfoConverter(),\n            new DirectoryInfoConverter(),\n            new FileInfoConverter(),\n            new CoreSerializableJsonConverter(),", "referenced_paths": []}], "body_comments": [{"body": "\n### \ud83d\udca1 Codex Review\n\nHere are some automated review suggestions for this pull request.\n\n**Reviewed commit:** `28e24af268`\n    \n\n<details> <summary>\u2139\ufe0f About Codex in GitHub</summary>\n<br/>\n\n[Your team has set up Codex to review pull requests in this repo](https://chatgpt.com/codex/cloud/settings/general). Reviews are triggered when you\n- Open a pull request for review\n- Mark a draft as ready\n- Comment \"@codex review\".\n\nIf Codex has suggestions, it will comment; otherwise it will react with \ud83d\udc4d.\n\n\n\n\nCodex can also answer questions or update the PR. Try commenting \"@codex address that feedback\".\n            \n</details>", "referenced_paths": [], "reactions": []}], "response_commits": [{"oid": "dcc570923d3c55193f0535062e787b4892ca7c07", "message": "fix: only cache JsonHelper logger on success\n\nWhen the first JsonRestore runs before Log.LoggerFactory is initialized,\ncaching the NullLogger fallback permanently silenced later parse-failure\nlogs even after telemetry came up. Cache s_logger only when CreateLogger\nsucceeds so subsequent calls can pick up the real logger.", "authoredDate": "2026-05-16T08:49:24Z", "author": {"user": {"login": "yuto-trd"}, "name": "Yuto Terada"}, "statusCheckRollup": {"state": "SUCCESS", "contexts": {"nodes": [{"__typename": "CheckRun", "name": "build", "conclusion": "SUCCESS", "startedAt": "2026-05-16T08:49:54Z", "completedAt": "2026-05-16T08:53:11Z"}, {"__typename": "CheckRun", "name": "find-todo-comments", "conclusion": "SUCCESS", "startedAt": "2026-05-16T08:49:54Z", "completedAt": "2026-05-16T08:50:04Z"}, {"__typename": "CheckRun", "name": "Analyze (csharp)", "conclusion": "SUCCESS", "startedAt": "2026-05-16T08:49:54Z", "completedAt": "2026-05-16T09:01:02Z"}, {"__typename": "CheckRun", "name": "dotnet-format", "conclusion": "SUCCESS", "startedAt": "2026-05-16T08:49:55Z", "completedAt": "2026-05-16T08:52:39Z"}, {"__typename": "CheckRun", "name": "CodeQL", "conclusion": "SUCCESS", "startedAt": "2026-05-16T09:00:52Z", "completedAt": "2026-05-16T09:00:53Z"}]}}, "author_type": "agent", "agent_commit_signals": ["conventional_prefix:fix"], "ci_state": "SUCCESS", "ci_contexts": [{"__typename": "CheckRun", "name": "build", "conclusion": "SUCCESS", "startedAt": "2026-05-16T08:49:54Z", "completedAt": "2026-05-16T08:53:11Z"}, {"__typename": "CheckRun", "name": "find-todo-comments", "conclusion": "SUCCESS", "startedAt": "2026-05-16T08:49:54Z", "completedAt": "2026-05-16T08:50:04Z"}, {"__typename": "CheckRun", "name": "Analyze (csharp)", "conclusion": "SUCCESS", "startedAt": "2026-05-16T08:49:54Z", "completedAt": "2026-05-16T09:01:02Z"}, {"__typename": "CheckRun", "name": "dotnet-format", "conclusion": "SUCCESS", "startedAt": "2026-05-16T08:49:55Z", "completedAt": "2026-05-16T08:52:39Z"}, {"__typename": "CheckRun", "name": "CodeQL", "conclusion": "SUCCESS", "startedAt": "2026-05-16T09:00:52Z", "completedAt": "2026-05-16T09:00:53Z"}], "ci_failed_checks": [], "ci_test_check_failed": false}], "force_pushes": [], "builds_on_rounds": [], "references_repo_structure": false, "ci_state_at_review": "SUCCESS", "ci_state_after_response": "SUCCESS", "ci_transition": "pass_to_pass", "response_commit_diffs": {"dcc570923d3c55193f0535062e787b4892ca7c07": {"src/Beutl.Core/JsonHelper.cs": [[19, 40]]}}, "has_code_backing": false, "head_commit_at_review": "28e24af2681bea210f3ce236b7f6e09c7a883754", "file_contents_at_review": {"src/Beutl.Core/JsonHelper.cs": "\ufeffusing System.Diagnostics.CodeAnalysis;\nusing System.Runtime.CompilerServices;\nusing System.Text.Encodings.Web;\nusing System.Text.Json;\nusing System.Text.Json.Nodes;\nusing System.Text.Json.Serialization;\nusing Beutl.JsonConverters;\nusing Beutl.Logging;\nusing Beutl.Serialization;\nusing Microsoft.Extensions.Logging;\nusing Microsoft.Extensions.Logging.Abstractions;\n\nnamespace Beutl;\n\npublic static class JsonHelper\n{\n    private static readonly ConditionalWeakTable<Type, JsonConverter> s_converters = [];\n    private static ILogger? s_logger;\n\n    // Program.Main \u306f GlobalConfiguration.Restore (JsonHelper \u3092\u7d4c\u7531) \u3092 Telemetry \u304c\n    // Log.LoggerFactory \u3092\u30bb\u30c3\u30c8\u3059\u308b\u3088\u308a\u524d\u306b\u547c\u3076\u3002Release \u30d3\u30eb\u30c9\u3067\u306f LoggerFactory \u304c\n    // null \u306e\u307e\u307e CreateLogger \u3092\u547c\u3076\u3068 TypeInitializationException \u3067\u8d77\u52d5\u304c\u843d\u3061\u308b\u305f\u3081\u3001\n    // \u9045\u5ef6\u53d6\u5f97 + \u5931\u6557\u6642\u306f NullLogger \u306b\u30d5\u30a9\u30fc\u30eb\u30d0\u30c3\u30af\u3059\u308b\u3002\n    private static ILogger Logger => s_logger ??= CreateLoggerSafe();\n\n    private static ILogger CreateLoggerSafe()\n    {\n        try\n        {\n            return Log.CreateLogger(typeof(JsonHelper));\n        }\n        catch\n        {\n            return NullLogger.Instance;\n        }\n    }\n\n    public static JsonWriterOptions WriterOptions { get; } = new()\n    {\n        Encoder = JavaScriptEncoder.UnsafeRelaxedJsonEscaping,\n        Indented = true,\n    };\n\n    public static JsonSerializerOptions SerializerOptions { get; } = new()\n    {\n        WriteIndented = true,\n        Encoder = JavaScriptEncoder.UnsafeRelaxedJsonEscaping,\n        TypeInfoResolver = null,\n        NumberHandling = JsonNumberHandling.AllowNamedFloatingPointLiterals | JsonNumberHandling.AllowReadingFromString,\n        Converters =\n        {\n            new OptionalJsonConverter(),\n            new CultureInfoConverter(),\n            new DirectoryInfoConverter(),\n            new FileInfoConverter(),\n            new CoreSerializableJsonConverter(),\n            new Vector3JsonConverter(),\n            new QuaternionJsonConverter()\n            //new CoreObjectJsonConverter()\n        }\n    };\n\n    public static JsonConverter GetOrCreateConverterInstance(Type converterType)\n    {\n        if (s_converters.TryGetValue(converterType, out JsonConverter? converter))\n        {\n            return converter;\n        }\n        else\n        {\n            converter = (JsonConverter)Activator.CreateInstance(converterType)!;\n            s_converters.Add(converterType, converter);\n            return converter;\n        }\n    }\n\n    public static void JsonSave(this IJsonSerializable serializable, string filename)\n    {\n        var json = new JsonObject();\n\n        serializable.WriteToJson(json);\n\n        json.JsonSave(filename);\n    }\n\n    public static void JsonRestore(this IJsonSerializable serializable, string filename)\n    {\n        if (JsonRestore(filename) is JsonObject obj)\n        {\n            serializable.ReadFromJson(obj);\n        }\n    }\n\n    public static void JsonSave2(this ICoreSerializable serializable, string filename)\n    {\n        var context = new JsonSerializationContext(serializable.GetType());\n        using (ThreadLocalSerializationContext.Enter(context))\n        {\n            serializable.Serialize(context);\n\n            context.GetJsonObject().JsonSave(filename);\n        }\n    }\n\n    public static void JsonRestore2(this ICoreSerializable serializable, string filename)\n    {\n        if (JsonRestore(filename) is JsonObject obj)\n        {\n            var context = new JsonSerializationContext(\n                serializable.GetType(), json: obj);\n            using (ThreadLocalSerializationContext.Enter(context))\n            {\n                serializable.Deserialize(context);\n                context.AfterDeserialized(serializable);\n            }\n        }\n    }\n\n    public static void JsonSave(this JsonNode node, string filename)\n    {\n        // tmp \u306b\u66f8\u3044\u3066\u304b\u3089 rename \u3059\u308b\u3053\u3068\u3067\u3001\u66f8\u304d\u8fbc\u307f\u4e2d\u306e\u30af\u30e9\u30c3\u30b7\u30e5\u30fb\u96fb\u6e90\u65ad\u30fb\n        // \u30c7\u30a3\u30b9\u30af\u30d5\u30eb\u3067\u30bf\u30fc\u30b2\u30c3\u30c8\u30d5\u30a1\u30a4\u30eb\u304c\u30bc\u30ed\u30d0\u30a4\u30c8\u3067\u6b8b\u308b\u306e\u3092\u9632\u3050\u3002\n        // \u65e2\u5b58\u30d5\u30a1\u30a4\u30eb\u306f rename \u6210\u529f\u6642\u306e\u307f\u7f6e\u304d\u63db\u308f\u308b\u305f\u3081\u3001\u30e6\u30fc\u30b6\u30fc\u306e\u30d7\u30ed\u30b8\u30a7\u30af\u30c8\u3084\n        // \u8a2d\u5b9a\u30d5\u30a1\u30a4\u30eb\u304c\u7834\u640d\u3057\u306a\u3044\u3002\n        // \u56fa\u5b9a\u306e `.tmp` \u30b5\u30d5\u30a3\u30c3\u30af\u30b9\u3060\u3068\u30e6\u30fc\u30b6\u30fc\u3084\u4ed6\u30c4\u30fc\u30eb\u304c\u65e2\u306b\u6301\u3064\u540c\u540d\u30d5\u30a1\u30a4\u30eb\u3092\n        // \u4e0a\u66f8\u304d\u3057\u3066\u3057\u307e\u3046\u305f\u3081\u3001\u30e9\u30f3\u30c0\u30e0\u30b5\u30d5\u30a3\u30c3\u30af\u30b9\u3092\u4ed8\u4e0e\u3057\u3066\u885d\u7a81\u3092\u907f\u3051\u308b\u3002\n        string tmp = $\"{filename}.{Guid.NewGuid():N}.tmp\";\n        try\n        {\n            using (var stream = new FileStream(tmp, FileMode.CreateNew, FileAccess.Write, FileShare.None))\n            using (var writer = new Utf8JsonWriter(stream, WriterOptions))\n            {\n                node.WriteTo(writer, SerializerOptions);\n                writer.Flush();\n                stream.Flush(flushToDisk: true);\n            }\n\n            File.Move(tmp, filename, overwrite: true);\n        }\n        catch\n        {\n            try\n            {\n                if (File.Exists(tmp)) File.Delete(tmp);\n            }\n            catch\n            {\n                // \u5931\u6557\u3057\u3066\u3082\u5143\u306e\u4f8b\u5916\u306f\u6295\u3052\u308b\n            }\n            throw;\n        }\n    }\n\n    public static JsonNode? JsonRestore(string filename)\n    {\n        if (!File.Exists(filename)) return null;\n        using var stream = new FileStream(filename, FileMode.Open, FileAccess.Read, FileShare.Read);\n        try\n        {\n            return JsonNode.Parse(stream);\n        }\n        catch (JsonException ex)\n        {\n            // \u7834\u640d\u30d5\u30a1\u30a4\u30eb\u306f\u6b21\u56de\u4fdd\u5b58\u6642\u306b\u30a2\u30c8\u30df\u30c3\u30af\u66f8\u304d\u8fbc\u307f\u3067\u4e0a\u66f8\u304d\u3055\u308c\u308b\u305f\u3081\u305d\u306e\u307e\u307e\u653e\u7f6e\u3002\n            // \u30d5\u30a1\u30a4\u30eb\u3092\u6d88\u3059\u3068\u8abf\u67fb\u7528\u306e\u8a3c\u62e0\u3092\u5931\u3046\u306e\u3067\u89e6\u3089\u306a\u3044\u3002\n            Logger.LogError(ex, \"Failed to parse JSON file {Path}; treating as missing.\", filename);\n            return null;\n        }\n    }\n\n    public static Type? GetDiscriminator(this JsonNode node)\n    {\n        return node.TryGetDiscriminator(out Type? type) ? type : null;\n    }\n\n    public static Type? GetDiscriminator(this JsonNode node, Type baseType)\n    {\n        if (node.TryGetDiscriminator(out Type? type))\n        {\n            return type;\n        }\n        else\n        {\n            if (Attribute.GetCustomAttribute(baseType, typeof(FallbackTypeAttribute)) is FallbackTypeAttribute att)\n            {\n                return att.FallbackType;\n            }\n            else\n            {\n                return null;\n            }\n        }\n    }\n\n    public static bool TryGetDiscriminator(this JsonNode node, [NotNullWhen(true)] out Type? type)\n    {\n        type = null;\n        if (node is JsonObject obj)\n        {\n            JsonNode? typeNode = obj.TryGetPropertyValue(\"$type\", out JsonNode? typeNode1) ? typeNode1\n                               : obj.TryGetPropertyValue(\"@type\", out JsonNode? typeNode2) ? typeNode2\n                               : null;\n\n            if (typeNode is JsonValue typeValue\n                && typeValue.TryGetValue(out string? typeStr)\n                && !string.IsNullOrWhiteSpace(typeStr))\n            {\n                type = TypeFormat.ToType(typeStr);\n            }\n        }\n\n        return type != null;\n    }\n\n    public static bool TryGetDiscriminator(this JsonNode node, [NotNullWhen(true)] out string? result)\n    {\n        result = null;\n        if (node is JsonObject obj)\n        {\n            JsonNode? typeNode = obj.TryGetPropertyValue(\"$type\", out JsonNode? typeNode1) ? typeNode1\n                               : obj.TryGetPropertyValue(\"@type\", out JsonNode? typeNode2) ? typeNode2\n                               : null;\n\n            if (typeNode is JsonValue typeValue\n                && typeValue.TryGetValue(out string? typeStr)\n                && !string.IsNullOrWhiteSpace(typeStr))\n            {\n                result = typeStr;\n            }\n        }\n\n        return result != null;\n    }\n\n    public static void WriteDiscriminator(this JsonNode obj, Type type)\n    {\n        obj[\"$type\"] = TypeFormat.ToString(type);\n    }\n\n    private static Dictionary<string, object> ParseJson(string json)\n    {\n        Dictionary<string, JsonElement> dic = JsonSerializer.Deserialize<Dictionary<string, JsonElement>>(json)!;\n\n        return dic.ToDictionary(x => x.Key, x => ParseJsonElement(x.Value)!);\n    }\n\n    private static object? ParseJsonElement(JsonElement elem)\n    {\n        return elem.ValueKind switch\n        {\n            JsonValueKind.String => elem.GetString(),\n            JsonValueKind.Number => elem.GetDouble(),\n            JsonValueKind.False => false,\n            JsonValueKind.True => true,\n            JsonValueKind.Array => elem.EnumerateArray().Select(e => ParseJsonElement(e)).ToArray(),\n            JsonValueKind.Null => null,\n            JsonValueKind.Object => ParseJson(elem.GetRawText()),\n            _ => throw new NotSupportedException(),\n        };\n    }\n\n    public static Dictionary<string, object> ToDictionary(this JsonNode json)\n    {\n        Dictionary<string, JsonElement> dic = JsonSerializer.Deserialize<Dictionary<string, JsonElement>>(json)!;\n\n        return dic.ToDictionary(x => x.Key, x => ParseJsonElement(x.Value)!);\n    }\n\n    public static bool TryGetPropertyValueAsJsonValue<T>(this JsonObject obj, string propertyName, [NotNullWhen(true)] out T? value)\n    {\n        value = default;\n        return obj.TryGetPropertyValue(propertyName, out JsonNode? node)\n            && node is JsonValue val\n            && val.TryGetValue(out value);\n    }\n}\n"}}], "threads": [], "agent_threads": [], "pr_review_class": "commented", "compliance": {"total_threads": 0, "resolved": 0, "unresolved": 0, "compliance_rate": 0.0, "compliance_class": "approved_no_threads", "inline_threads": 0, "body_only_threads": 0, "compliance_band": "none", "n_agent_threads": 0}, "linked_issues": [{"number": 1807, "title": "[Bug] JsonHelper.JsonRestore \u304c JsonException \u672a\u30ad\u30e3\u30c3\u30c1\u3067\u8a2d\u5b9a\u30d5\u30a1\u30a4\u30eb\u7834\u640d\u6642\u306b\u8d77\u52d5\u4e0d\u80fd", "body": "## \u6982\u8981 (Bug)\n`JsonHelper.JsonRestore` \u304c `JsonException` \u3092 catch \u305b\u305a\u3001\u8d77\u52d5\u6642\u306e\u5fc5\u9808\u8a2d\u5b9a\u30d5\u30a1\u30a4\u30eb\uff08`extensionsSettings.json` / `keymap.json`\uff09\u304c\u7834\u640d\u3057\u3066\u3044\u308b\u3068 BeutlApiApplication \u304c\u8d77\u52d5\u4e0d\u80fd\u306b\u306a\u308b\u3002\n\n## \u8a72\u5f53\u7b87\u6240\n- `src/Beutl.Core/JsonHelper.cs:132-137`\n- \u547c\u3073\u51fa\u3057\u5074: `ExtensionSettingsStore.RestoreAll` (line 26), `ContextCommandSettingsStore.RestoreAll` (line 345)\n\n## \u8a73\u7d30\n`JsonRestore(string filename)` \u306f `File.Exists` \u3092\u30c1\u30a7\u30c3\u30af\u3059\u308b\u304c\u3001`JsonNode.Parse(stream)` \u3092 try \u306a\u3057\u3067\u547c\u3076\u3002\u547c\u3073\u51fa\u3057\u5074\u306f\u3044\u305a\u308c\u3082\u30b3\u30f3\u30b9\u30c8\u30e9\u30af\u30bf\u3067\u547c\u3070\u308c\u3001\u30b3\u30f3\u30b9\u30c8\u30e9\u30af\u30bf\u306b\u3082 try/catch \u304c\u7121\u3044\u3002\n\n\u3053\u308c\u3089\u306f DI \u30b3\u30f3\u30c6\u30ca\u521d\u671f\u5316\u6642\u306e\u5fc5\u9808\u30ea\u30bd\u30fc\u30b9\u306a\u306e\u3067\u3001`extensionsSettings.json` \u307e\u305f\u306f `keymap.json` \u304c\u4e2d\u9014\u534a\u7aef\u306b\u66f8\u304b\u308c\u305f\u72b6\u614b\uff08\u30a2\u30d7\u30ea\u5f37\u5236\u7d42\u4e86\u76f4\u5f8c\u306a\u3069\uff09\u3067\u6b8b\u3063\u3066\u3044\u308b\u3068\u3001\u8d77\u52d5\u6642 `JsonException` \u3067 BeutlApiApplication \u304c\u5d29\u58ca\u3057\u3001\u30a8\u30f3\u30c9\u30e6\u30fc\u30b6\u30fc\u306f\u8a2d\u5b9a\u30d5\u30a1\u30a4\u30eb\u3092\u624b\u52d5\u524a\u9664\u3057\u306a\u3044\u3068\u8d77\u52d5\u3067\u304d\u306a\u3044\u3002\n\n`ViewConfig` \u306e\u540c\u7a2e\u554f\u984c\uff08PR #1759, commit `44c48846e`\uff09\u306f\u4fee\u6b63\u6e08\u307f\u3060\u304c\u3001\u3053\u3061\u3089\u306f\u672a\u5bfe\u51e6\u3002\n\n## \u5f71\u97ff\n\u8d77\u52d5\u6642\u30af\u30e9\u30c3\u30b7\u30e5\u3002\u4e00\u822c\u30e6\u30fc\u30b6\u30fc\u306f\u539f\u56e0\u3092\u7279\u5b9a\u3067\u304d\u305a\u3001\u30b5\u30dd\u30fc\u30c8\u306b\u983c\u3089\u3056\u308b\u3092\u5f97\u306a\u3044\u3002\n\n## \u4fee\u6b63\u6848\n- `JsonRestore` \u5185\u3067 `try { return JsonNode.Parse(stream); } catch (JsonException ex) { \u30ed\u30b0\u3092\u51fa\u3057\u3066 return null; }` \u3068\u3059\u308b\n- \u7834\u640d\u30d5\u30a1\u30a4\u30eb\u306f\u30d0\u30c3\u30af\u30a2\u30c3\u30d7\uff08`.corrupt-{timestamp}`\uff09\u3068\u3057\u3066\u9000\u907f\u3057\u3066\u304b\u3089 `null` \u3092\u8fd4\u3059\n- \u307e\u305f\u306f\u5404\u547c\u3073\u51fa\u3057\u5074 (`RestoreAll`) \u3067 try/catch \u3092\u8ffd\u52a0\n\n\u30ab\u30c6\u30b4\u30ea: null/\u4f8b\u5916\u51e6\u7406", "state": "CLOSED", "created_at": "2026-05-14T01:39:24Z", "closed_at": "2026-05-16T09:08:50Z", "author_login": "yuto-trd", "comment_rounds": [], "resolution": "closed_by_pr", "closed_by_pr": 1810, "link_type": "closing_keyword", "will_close": true, "comment_count": 0, "issue_age_at_pr_days": 0.07863425925925926, "issue_was_open_at_pr": false, "labels": [], "milestone": null, "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}], "has_inline_feedback": true, "feedback_track": "inline", "changed_files": 2, "additions": 74, "deletions": 1, "author_association": "MEMBER", "is_cross_repository": false, "files": [{"path": "src/Beutl.Core/JsonHelper.cs", "additions": 36, "deletions": 1, "changeType": "MODIFIED", "base_content": "\ufeffusing System.Diagnostics.CodeAnalysis;\nusing System.Runtime.CompilerServices;\nusing System.Text.Encodings.Web;\nusing System.Text.Json;\nusing System.Text.Json.Nodes;\nusing System.Text.Json.Serialization;\nusing Beutl.JsonConverters;\nusing Beutl.Serialization;\n\nnamespace Beutl;\n\npublic static class JsonHelper\n{\n    private static readonly ConditionalWeakTable<Type, JsonConverter> s_converters = [];\n\n    public static JsonWriterOptions WriterOptions { get; } = new()\n    {\n        Encoder = JavaScriptEncoder.UnsafeRelaxedJsonEscaping,\n        Indented = true,\n    };\n\n    public static JsonSerializerOptions SerializerOptions { get; } = new()\n    {\n        WriteIndented = true,\n        Encoder = JavaScriptEncoder.UnsafeRelaxedJsonEscaping,\n        TypeInfoResolver = null,\n        NumberHandling = JsonNumberHandling.AllowNamedFloatingPointLiterals | JsonNumberHandling.AllowReadingFromString,\n        Converters =\n        {\n            new OptionalJsonConverter(),\n            new CultureInfoConverter(),\n            new DirectoryInfoConverter(),\n            new FileInfoConverter(),\n            new CoreSerializableJsonConverter(),\n            new Vector3JsonConverter(),\n            new QuaternionJsonConverter()\n            //new CoreObjectJsonConverter()\n        }\n    };\n\n    public static JsonConverter GetOrCreateConverterInstance(Type converterType)\n    {\n        if (s_converters.TryGetValue(converterType, out JsonConverter? converter))\n        {\n            return converter;\n        }\n        else\n        {\n            converter = (JsonConverter)Activator.CreateInstance(converterType)!;\n            s_converters.Add(converterType, converter);\n            return converter;\n        }\n    }\n\n    public static void JsonSave(this IJsonSerializable serializable, string filename)\n    {\n        var json = new JsonObject();\n\n        serializable.WriteToJson(json);\n\n        json.JsonSave(filename);\n    }\n\n    public static void JsonRestore(this IJsonSerializable serializable, string filename)\n    {\n        if (JsonRestore(filename) is JsonObject obj)\n        {\n            serializable.ReadFromJson(obj);\n        }\n    }\n\n    public static void JsonSave2(this ICoreSerializable serializable, string filename)\n    {\n        var context = new JsonSerializationContext(serializable.GetType());\n        using (ThreadLocalSerializationContext.Enter(context))\n        {\n            serializable.Serialize(context);\n\n            context.GetJsonObject().JsonSave(filename);\n        }\n    }\n\n    public static void JsonRestore2(this ICoreSerializable serializable, string filename)\n    {\n        if (JsonRestore(filename) is JsonObject obj)\n        {\n            var context = new JsonSerializationContext(\n                serializable.GetType(), json: obj);\n            using (ThreadLocalSerializationContext.Enter(context))\n            {\n                serializable.Deserialize(context);\n                context.AfterDeserialized(serializable);\n            }\n        }\n    }\n\n    public static void JsonSave(this JsonNode node, string filename)\n    {\n        // tmp \u306b\u66f8\u3044\u3066\u304b\u3089 rename \u3059\u308b\u3053\u3068\u3067\u3001\u66f8\u304d\u8fbc\u307f\u4e2d\u306e\u30af\u30e9\u30c3\u30b7\u30e5\u30fb\u96fb\u6e90\u65ad\u30fb\n        // \u30c7\u30a3\u30b9\u30af\u30d5\u30eb\u3067\u30bf\u30fc\u30b2\u30c3\u30c8\u30d5\u30a1\u30a4\u30eb\u304c\u30bc\u30ed\u30d0\u30a4\u30c8\u3067\u6b8b\u308b\u306e\u3092\u9632\u3050\u3002\n        // \u65e2\u5b58\u30d5\u30a1\u30a4\u30eb\u306f rename \u6210\u529f\u6642\u306e\u307f\u7f6e\u304d\u63db\u308f\u308b\u305f\u3081\u3001\u30e6\u30fc\u30b6\u30fc\u306e\u30d7\u30ed\u30b8\u30a7\u30af\u30c8\u3084\n        // \u8a2d\u5b9a\u30d5\u30a1\u30a4\u30eb\u304c\u7834\u640d\u3057\u306a\u3044\u3002\n        // \u56fa\u5b9a\u306e `.tmp` \u30b5\u30d5\u30a3\u30c3\u30af\u30b9\u3060\u3068\u30e6\u30fc\u30b6\u30fc\u3084\u4ed6\u30c4\u30fc\u30eb\u304c\u65e2\u306b\u6301\u3064\u540c\u540d\u30d5\u30a1\u30a4\u30eb\u3092\n        // \u4e0a\u66f8\u304d\u3057\u3066\u3057\u307e\u3046\u305f\u3081\u3001\u30e9\u30f3\u30c0\u30e0\u30b5\u30d5\u30a3\u30c3\u30af\u30b9\u3092\u4ed8\u4e0e\u3057\u3066\u885d\u7a81\u3092\u907f\u3051\u308b\u3002\n        string tmp = $\"{filename}.{Guid.NewGuid():N}.tmp\";\n        try\n        {\n            using (var stream = new FileStream(tmp, FileMode.CreateNew, FileAccess.Write, FileShare.None))\n            using (var writer = new Utf8JsonWriter(stream, WriterOptions))\n            {\n                node.WriteTo(writer, SerializerOptions);\n                writer.Flush();\n                stream.Flush(flushToDisk: true);\n            }\n\n            File.Move(tmp, filename, overwrite: true);\n        }\n        catch\n        {\n            try\n            {\n                if (File.Exists(tmp)) File.Delete(tmp);\n            }\n            catch\n            {\n                // \u5931\u6557\u3057\u3066\u3082\u5143\u306e\u4f8b\u5916\u306f\u6295\u3052\u308b\n            }\n            throw;\n        }\n    }\n\n    public static JsonNode? JsonRestore(string filename)\n    {\n        if (!File.Exists(filename)) return null;\n        using var stream = new FileStream(filename, FileMode.Open, FileAccess.Read, FileShare.Read);\n        return JsonNode.Parse(stream);\n    }\n\n    public static Type? GetDiscriminator(this JsonNode node)\n    {\n        return node.TryGetDiscriminator(out Type? type) ? type : null;\n    }\n\n    public static Type? GetDiscriminator(this JsonNode node, Type baseType)\n    {\n        if (node.TryGetDiscriminator(out Type? type))\n        {\n            return type;\n        }\n        else\n        {\n            if (Attribute.GetCustomAttribute(baseType, typeof(FallbackTypeAttribute)) is FallbackTypeAttribute att)\n            {\n                return att.FallbackType;\n            }\n            else\n            {\n                return null;\n            }\n        }\n    }\n\n    public static bool TryGetDiscriminator(this JsonNode node, [NotNullWhen(true)] out Type? type)\n    {\n        type = null;\n        if (node is JsonObject obj)\n        {\n            JsonNode? typeNode = obj.TryGetPropertyValue(\"$type\", out JsonNode? typeNode1) ? typeNode1\n                               : obj.TryGetPropertyValue(\"@type\", out JsonNode? typeNode2) ? typeNode2\n                               : null;\n\n            if (typeNode is JsonValue typeValue\n                && typeValue.TryGetValue(out string? typeStr)\n                && !string.IsNullOrWhiteSpace(typeStr))\n            {\n                type = TypeFormat.ToType(typeStr);\n            }\n        }\n\n        return type != null;\n    }\n\n    public static bool TryGetDiscriminator(this JsonNode node, [NotNullWhen(true)] out string? result)\n    {\n        result = null;\n        if (node is JsonObject obj)\n        {\n            JsonNode? typeNode = obj.TryGetPropertyValue(\"$type\", out JsonNode? typeNode1) ? typeNode1\n                               : obj.TryGetPropertyValue(\"@type\", out JsonNode? typeNode2) ? typeNode2\n                               : null;\n\n            if (typeNode is JsonValue typeValue\n                && typeValue.TryGetValue(out string? typeStr)\n                && !string.IsNullOrWhiteSpace(typeStr))\n            {\n                result = typeStr;\n            }\n        }\n\n        return result != null;\n    }\n\n    public static void WriteDiscriminator(this JsonNode obj, Type type)\n    {\n        obj[\"$type\"] = TypeFormat.ToString(type);\n    }\n\n    private static Dictionary<string, object> ParseJson(string json)\n    {\n        Dictionary<string, JsonElement> dic = JsonSerializer.Deserialize<Dictionary<string, JsonElement>>(json)!;\n\n        return dic.ToDictionary(x => x.Key, x => ParseJsonElement(x.Value)!);\n    }\n\n    private static object? ParseJsonElement(JsonElement elem)\n    {\n        return elem.ValueKind switch\n        {\n            JsonValueKind.String => elem.GetString(),\n            JsonValueKind.Number => elem.GetDouble(),\n            JsonValueKind.False => false,\n            JsonValueKind.True => true,\n            JsonValueKind.Array => elem.EnumerateArray().Select(e => ParseJsonElement(e)).ToArray(),\n            JsonValueKind.Null => null,\n            JsonValueKind.Object => ParseJson(elem.GetRawText()),\n            _ => throw new NotSupportedException(),\n        };\n    }\n\n    public static Dictionary<string, object> ToDictionary(this JsonNode json)\n    {\n        Dictionary<string, JsonElement> dic = JsonSerializer.Deserialize<Dictionary<string, JsonElement>>(json)!;\n\n        return dic.ToDictionary(x => x.Key, x => ParseJsonElement(x.Value)!);\n    }\n\n    public static bool TryGetPropertyValueAsJsonValue<T>(this JsonObject obj, string propertyName, [NotNullWhen(true)] out T? value)\n    {\n        value = default;\n        return obj.TryGetPropertyValue(propertyName, out JsonNode? node)\n            && node is JsonValue val\n            && val.TryGetValue(out value);\n    }\n}\n", "head_content": "\ufeffusing System.Diagnostics.CodeAnalysis;\nusing System.Runtime.CompilerServices;\nusing System.Text.Encodings.Web;\nusing System.Text.Json;\nusing System.Text.Json.Nodes;\nusing System.Text.Json.Serialization;\nusing Beutl.JsonConverters;\nusing Beutl.Logging;\nusing Beutl.Serialization;\nusing Microsoft.Extensions.Logging;\nusing Microsoft.Extensions.Logging.Abstractions;\n\nnamespace Beutl;\n\npublic static class JsonHelper\n{\n    private static readonly ConditionalWeakTable<Type, JsonConverter> s_converters = [];\n    private static ILogger? s_logger;\n\n    // Program.Main \u306f GlobalConfiguration.Restore (JsonHelper \u3092\u7d4c\u7531) \u3092 Telemetry \u304c\n    // Log.LoggerFactory \u3092\u30bb\u30c3\u30c8\u3059\u308b\u3088\u308a\u524d\u306b\u547c\u3076\u3002Release \u30d3\u30eb\u30c9\u3067\u306f LoggerFactory \u304c\n    // null \u306e\u307e\u307e CreateLogger \u3092\u547c\u3076\u3068 TypeInitializationException \u3067\u8d77\u52d5\u304c\u843d\u3061\u308b\u3002\n    // \u5931\u6557\u6642\u306f NullLogger \u3092\u8fd4\u3059\u304c\u3001\u305d\u306e\u5024\u306f\u30ad\u30e3\u30c3\u30b7\u30e5\u3057\u306a\u3044\u3002\u3053\u308c\u306b\u3088\u308a\n    // LoggerFactory \u521d\u671f\u5316\u5f8c\u306e\u547c\u3073\u51fa\u3057\u3067\u306f\u672c\u7269\u306e\u30ed\u30ac\u30fc\u3092\u53d6\u5f97\u3057\u76f4\u305b\u308b\u3002\n    private static ILogger Logger\n    {\n        get\n        {\n            if (s_logger is not null) return s_logger;\n            try\n            {\n                return s_logger = Log.CreateLogger(typeof(JsonHelper));\n            }\n            catch\n            {\n                return NullLogger.Instance;\n            }\n        }\n    }\n\n    public static JsonWriterOptions WriterOptions { get; } = new()\n    {\n        Encoder = JavaScriptEncoder.UnsafeRelaxedJsonEscaping,\n        Indented = true,\n    };\n\n    public static JsonSerializerOptions SerializerOptions { get; } = new()\n    {\n        WriteIndented = true,\n        Encoder = JavaScriptEncoder.UnsafeRelaxedJsonEscaping,\n        TypeInfoResolver = null,\n        NumberHandling = JsonNumberHandling.AllowNamedFloatingPointLiterals | JsonNumberHandling.AllowReadingFromString,\n        Converters =\n        {\n            new OptionalJsonConverter(),\n            new CultureInfoConverter(),\n            new DirectoryInfoConverter(),\n            new FileInfoConverter(),\n            new CoreSerializableJsonConverter(),\n            new Vector3JsonConverter(),\n            new QuaternionJsonConverter()\n            //new CoreObjectJsonConverter()\n        }\n    };\n\n    public static JsonConverter GetOrCreateConverterInstance(Type converterType)\n    {\n        if (s_converters.TryGetValue(converterType, out JsonConverter? converter))\n        {\n            return converter;\n        }\n        else\n        {\n            converter = (JsonConverter)Activator.CreateInstance(converterType)!;\n            s_converters.Add(converterType, converter);\n            return converter;\n        }\n    }\n\n    public static void JsonSave(this IJsonSerializable serializable, string filename)\n    {\n        var json = new JsonObject();\n\n        serializable.WriteToJson(json);\n\n        json.JsonSave(filename);\n    }\n\n    public static void JsonRestore(this IJsonSerializable serializable, string filename)\n    {\n        if (JsonRestore(filename) is JsonObject obj)\n        {\n            serializable.ReadFromJson(obj);\n        }\n    }\n\n    public static void JsonSave2(this ICoreSerializable serializable, string filename)\n    {\n        var context = new JsonSerializationContext(serializable.GetType());\n        using (ThreadLocalSerializationContext.Enter(context))\n        {\n            serializable.Serialize(context);\n\n            context.GetJsonObject().JsonSave(filename);\n        }\n    }\n\n    public static void JsonRestore2(this ICoreSerializable serializable, string filename)\n    {\n        if (JsonRestore(filename) is JsonObject obj)\n        {\n            var context = new JsonSerializationContext(\n                serializable.GetType(), json: obj);\n            using (ThreadLocalSerializationContext.Enter(context))\n            {\n                serializable.Deserialize(context);\n                context.AfterDeserialized(serializable);\n            }\n        }\n    }\n\n    public static void JsonSave(this JsonNode node, string filename)\n    {\n        // tmp \u306b\u66f8\u3044\u3066\u304b\u3089 rename \u3059\u308b\u3053\u3068\u3067\u3001\u66f8\u304d\u8fbc\u307f\u4e2d\u306e\u30af\u30e9\u30c3\u30b7\u30e5\u30fb\u96fb\u6e90\u65ad\u30fb\n        // \u30c7\u30a3\u30b9\u30af\u30d5\u30eb\u3067\u30bf\u30fc\u30b2\u30c3\u30c8\u30d5\u30a1\u30a4\u30eb\u304c\u30bc\u30ed\u30d0\u30a4\u30c8\u3067\u6b8b\u308b\u306e\u3092\u9632\u3050\u3002\n        // \u65e2\u5b58\u30d5\u30a1\u30a4\u30eb\u306f rename \u6210\u529f\u6642\u306e\u307f\u7f6e\u304d\u63db\u308f\u308b\u305f\u3081\u3001\u30e6\u30fc\u30b6\u30fc\u306e\u30d7\u30ed\u30b8\u30a7\u30af\u30c8\u3084\n        // \u8a2d\u5b9a\u30d5\u30a1\u30a4\u30eb\u304c\u7834\u640d\u3057\u306a\u3044\u3002\n        // \u56fa\u5b9a\u306e `.tmp` \u30b5\u30d5\u30a3\u30c3\u30af\u30b9\u3060\u3068\u30e6\u30fc\u30b6\u30fc\u3084\u4ed6\u30c4\u30fc\u30eb\u304c\u65e2\u306b\u6301\u3064\u540c\u540d\u30d5\u30a1\u30a4\u30eb\u3092\n        // \u4e0a\u66f8\u304d\u3057\u3066\u3057\u307e\u3046\u305f\u3081\u3001\u30e9\u30f3\u30c0\u30e0\u30b5\u30d5\u30a3\u30c3\u30af\u30b9\u3092\u4ed8\u4e0e\u3057\u3066\u885d\u7a81\u3092\u907f\u3051\u308b\u3002\n        string tmp = $\"{filename}.{Guid.NewGuid():N}.tmp\";\n        try\n        {\n            using (var stream = new FileStream(tmp, FileMode.CreateNew, FileAccess.Write, FileShare.None))\n            using (var writer = new Utf8JsonWriter(stream, WriterOptions))\n            {\n                node.WriteTo(writer, SerializerOptions);\n                writer.Flush();\n                stream.Flush(flushToDisk: true);\n            }\n\n            File.Move(tmp, filename, overwrite: true);\n        }\n        catch\n        {\n            try\n            {\n                if (File.Exists(tmp)) File.Delete(tmp);\n            }\n            catch\n            {\n                // \u5931\u6557\u3057\u3066\u3082\u5143\u306e\u4f8b\u5916\u306f\u6295\u3052\u308b\n            }\n            throw;\n        }\n    }\n\n    public static JsonNode? JsonRestore(string filename)\n    {\n        if (!File.Exists(filename)) return null;\n        using var stream = new FileStream(filename, FileMode.Open, FileAccess.Read, FileShare.Read);\n        try\n        {\n            return JsonNode.Parse(stream);\n        }\n        catch (JsonException ex)\n        {\n            // \u7834\u640d\u30d5\u30a1\u30a4\u30eb\u306f\u6b21\u56de\u4fdd\u5b58\u6642\u306b\u30a2\u30c8\u30df\u30c3\u30af\u66f8\u304d\u8fbc\u307f\u3067\u4e0a\u66f8\u304d\u3055\u308c\u308b\u305f\u3081\u305d\u306e\u307e\u307e\u653e\u7f6e\u3002\n            // \u30d5\u30a1\u30a4\u30eb\u3092\u6d88\u3059\u3068\u8abf\u67fb\u7528\u306e\u8a3c\u62e0\u3092\u5931\u3046\u306e\u3067\u89e6\u3089\u306a\u3044\u3002\n            Logger.LogError(ex, \"Failed to parse JSON file {Path}; treating as missing.\", filename);\n            return null;\n        }\n    }\n\n    public static Type? GetDiscriminator(this JsonNode node)\n    {\n        return node.TryGetDiscriminator(out Type? type) ? type : null;\n    }\n\n    public static Type? GetDiscriminator(this JsonNode node, Type baseType)\n    {\n        if (node.TryGetDiscriminator(out Type? type))\n        {\n            return type;\n        }\n        else\n        {\n            if (Attribute.GetCustomAttribute(baseType, typeof(FallbackTypeAttribute)) is FallbackTypeAttribute att)\n            {\n                return att.FallbackType;\n            }\n            else\n            {\n                return null;\n            }\n        }\n    }\n\n    public static bool TryGetDiscriminator(this JsonNode node, [NotNullWhen(true)] out Type? type)\n    {\n        type = null;\n        if (node is JsonObject obj)\n        {\n            JsonNode? typeNode = obj.TryGetPropertyValue(\"$type\", out JsonNode? typeNode1) ? typeNode1\n                               : obj.TryGetPropertyValue(\"@type\", out JsonNode? typeNode2) ? typeNode2\n                               : null;\n\n            if (typeNode is JsonValue typeValue\n                && typeValue.TryGetValue(out string? typeStr)\n                && !string.IsNullOrWhiteSpace(typeStr))\n            {\n                type = TypeFormat.ToType(typeStr);\n            }\n        }\n\n        return type != null;\n    }\n\n    public static bool TryGetDiscriminator(this JsonNode node, [NotNullWhen(true)] out string? result)\n    {\n        result = null;\n        if (node is JsonObject obj)\n        {\n            JsonNode? typeNode = obj.TryGetPropertyValue(\"$type\", out JsonNode? typeNode1) ? typeNode1\n                               : obj.TryGetPropertyValue(\"@type\", out JsonNode? typeNode2) ? typeNode2\n                               : null;\n\n            if (typeNode is JsonValue typeValue\n                && typeValue.TryGetValue(out string? typeStr)\n                && !string.IsNullOrWhiteSpace(typeStr))\n            {\n                result = typeStr;\n            }\n        }\n\n        return result != null;\n    }\n\n    public static void WriteDiscriminator(this JsonNode obj, Type type)\n    {\n        obj[\"$type\"] = TypeFormat.ToString(type);\n    }\n\n    private static Dictionary<string, object> ParseJson(string json)\n    {\n        Dictionary<string, JsonElement> dic = JsonSerializer.Deserialize<Dictionary<string, JsonElement>>(json)!;\n\n        return dic.ToDictionary(x => x.Key, x => ParseJsonElement(x.Value)!);\n    }\n\n    private static object? ParseJsonElement(JsonElement elem)\n    {\n        return elem.ValueKind switch\n        {\n            JsonValueKind.String => elem.GetString(),\n            JsonValueKind.Number => elem.GetDouble(),\n            JsonValueKind.False => false,\n            JsonValueKind.True => true,\n            JsonValueKind.Array => elem.EnumerateArray().Select(e => ParseJsonElement(e)).ToArray(),\n            JsonValueKind.Null => null,\n            JsonValueKind.Object => ParseJson(elem.GetRawText()),\n            _ => throw new NotSupportedException(),\n        };\n    }\n\n    public static Dictionary<string, object> ToDictionary(this JsonNode json)\n    {\n        Dictionary<string, JsonElement> dic = JsonSerializer.Deserialize<Dictionary<string, JsonElement>>(json)!;\n\n        return dic.ToDictionary(x => x.Key, x => ParseJsonElement(x.Value)!);\n    }\n\n    public static bool TryGetPropertyValueAsJsonValue<T>(this JsonObject obj, string propertyName, [NotNullWhen(true)] out T? value)\n    {\n        value = default;\n        return obj.TryGetPropertyValue(propertyName, out JsonNode? node)\n            && node is JsonValue val\n            && val.TryGetValue(out value);\n    }\n}\n", "patch": "--- a/src/Beutl.Core/JsonHelper.cs\n+++ b/src/Beutl.Core/JsonHelper.cs\n@@ -5,13 +5,38 @@\n using System.Text.Json.Nodes;\n using System.Text.Json.Serialization;\n using Beutl.JsonConverters;\n+using Beutl.Logging;\n using Beutl.Serialization;\n+using Microsoft.Extensions.Logging;\n+using Microsoft.Extensions.Logging.Abstractions;\n \n namespace Beutl;\n \n public static class JsonHelper\n {\n     private static readonly ConditionalWeakTable<Type, JsonConverter> s_converters = [];\n+    private static ILogger? s_logger;\n+\n+    // Program.Main \u306f GlobalConfiguration.Restore (JsonHelper \u3092\u7d4c\u7531) \u3092 Telemetry \u304c\n+    // Log.LoggerFactory \u3092\u30bb\u30c3\u30c8\u3059\u308b\u3088\u308a\u524d\u306b\u547c\u3076\u3002Release \u30d3\u30eb\u30c9\u3067\u306f LoggerFactory \u304c\n+    // null \u306e\u307e\u307e CreateLogger \u3092\u547c\u3076\u3068 TypeInitializationException \u3067\u8d77\u52d5\u304c\u843d\u3061\u308b\u3002\n+    // \u5931\u6557\u6642\u306f NullLogger \u3092\u8fd4\u3059\u304c\u3001\u305d\u306e\u5024\u306f\u30ad\u30e3\u30c3\u30b7\u30e5\u3057\u306a\u3044\u3002\u3053\u308c\u306b\u3088\u308a\n+    // LoggerFactory \u521d\u671f\u5316\u5f8c\u306e\u547c\u3073\u51fa\u3057\u3067\u306f\u672c\u7269\u306e\u30ed\u30ac\u30fc\u3092\u53d6\u5f97\u3057\u76f4\u305b\u308b\u3002\n+    private static ILogger Logger\n+    {\n+        get\n+        {\n+            if (s_logger is not null) return s_logger;\n+            try\n+            {\n+                return s_logger = Log.CreateLogger(typeof(JsonHelper));\n+            }\n+            catch\n+            {\n+                return NullLogger.Instance;\n+            }\n+        }\n+    }\n \n     public static JsonWriterOptions WriterOptions { get; } = new()\n     {\n@@ -133,7 +158,17 @@\n     {\n         if (!File.Exists(filename)) return null;\n         using var stream = new FileStream(filename, FileMode.Open, FileAccess.Read, FileShare.Read);\n-        return JsonNode.Parse(stream);\n+        try\n+        {\n+            return JsonNode.Parse(stream);\n+        }\n+        catch (JsonException ex)\n+        {\n+            // \u7834\u640d\u30d5\u30a1\u30a4\u30eb\u306f\u6b21\u56de\u4fdd\u5b58\u6642\u306b\u30a2\u30c8\u30df\u30c3\u30af\u66f8\u304d\u8fbc\u307f\u3067\u4e0a\u66f8\u304d\u3055\u308c\u308b\u305f\u3081\u305d\u306e\u307e\u307e\u653e\u7f6e\u3002\n+            // \u30d5\u30a1\u30a4\u30eb\u3092\u6d88\u3059\u3068\u8abf\u67fb\u7528\u306e\u8a3c\u62e0\u3092\u5931\u3046\u306e\u3067\u89e6\u3089\u306a\u3044\u3002\n+            Logger.LogError(ex, \"Failed to parse JSON file {Path}; treating as missing.\", filename);\n+            return null;\n+        }\n     }\n \n     public static Type? GetDiscriminator(this JsonNode node)\n"}, {"path": "tests/Beutl.UnitTests/Core/JsonHelperTests.cs", "additions": 38, "deletions": 0, "changeType": "MODIFIED", "base_content": "\ufeffusing System.Text.Json.Nodes;\nusing Beutl.Serialization;\n\nnamespace Beutl.UnitTests.Core;\n\npublic class JsonHelperTests\n{\n    [Test]\n    public void JsonSave_AndRestore_RoundTripsContent()\n    {\n        var json = new JsonObject { [\"x\"] = 1, [\"s\"] = \"hello\" };\n        string path = Path.GetTempFileName();\n        try\n        {\n            json.JsonSave(path);\n\n            JsonNode? restored = JsonHelper.JsonRestore(path);\n            Assert.That(restored, Is.Not.Null);\n            Assert.That((int)restored![\"x\"]!, Is.EqualTo(1));\n            Assert.That((string?)restored[\"s\"], Is.EqualTo(\"hello\"));\n        }\n        finally\n        {\n            if (File.Exists(path)) File.Delete(path);\n        }\n    }\n\n    [Test]\n    public void JsonSave_DoesNotLeaveTempFile()\n    {\n        var json = new JsonObject { [\"v\"] = 1 };\n        string path = Path.GetTempFileName();\n        string dir = Path.GetDirectoryName(path)!;\n        string baseName = Path.GetFileName(path);\n        try\n        {\n            json.JsonSave(path);\n\n            string[] tmps = Directory.GetFiles(dir, $\"{baseName}.*.tmp\");\n            Assert.That(tmps, Is.Empty);\n        }\n        finally\n        {\n            if (File.Exists(path)) File.Delete(path);\n        }\n    }\n\n    [Test]\n    public void JsonRestore_FileNotFound_ReturnsNull()\n    {\n        string path = Path.Combine(Path.GetTempPath(), Guid.NewGuid().ToString(\"N\"));\n\n        JsonNode? result = JsonHelper.JsonRestore(path);\n\n        Assert.That(result, Is.Null);\n    }\n\n    [Test]\n    public void TryGetDiscriminator_Type_ReturnsTypeForKnownEntries()\n    {\n        var node = new JsonObject { [\"$type\"] = TypeFormat.ToString(typeof(Optional<int>)) };\n\n        bool ok = node.TryGetDiscriminator(out Type? type);\n\n        Assert.That(ok, Is.True);\n        Assert.That(type, Is.EqualTo(typeof(Optional<int>)));\n    }\n\n    [Test]\n    public void TryGetDiscriminator_String_ReturnsRawValue()\n    {\n        var node = new JsonObject { [\"@type\"] = \"[Some.Asm]:Some.Type\" };\n\n        bool ok = node.TryGetDiscriminator(out string? text);\n\n        Assert.That(ok, Is.True);\n        Assert.That(text, Is.EqualTo(\"[Some.Asm]:Some.Type\"));\n    }\n\n    [Test]\n    public void TryGetDiscriminator_NoTypeProperty_ReturnsFalse()\n    {\n        var node = new JsonObject { [\"foo\"] = 1 };\n\n        bool ok = node.TryGetDiscriminator(out Type? type);\n\n        Assert.That(ok, Is.False);\n        Assert.That(type, Is.Null);\n    }\n\n    [Test]\n    public void GetDiscriminator_FallsBackToFallbackTypeAttribute()\n    {\n        // No discriminator on node, BaseType has FallbackTypeAttribute -> uses fallback.\n        var node = new JsonObject();\n\n        Type? type = node.GetDiscriminator(typeof(BaseWithFallback));\n\n        Assert.That(type, Is.EqualTo(typeof(FallbackImpl)));\n    }\n\n    [Test]\n    public void GetDiscriminator_PrefersExplicitTypeOverFallback()\n    {\n        var node = new JsonObject { [\"$type\"] = TypeFormat.ToString(typeof(Optional<int>)) };\n\n        Type? type = node.GetDiscriminator(typeof(BaseWithFallback));\n\n        Assert.That(type, Is.EqualTo(typeof(Optional<int>)));\n    }\n\n    [Test]\n    public void WriteDiscriminator_WritesTypeFormatString()\n    {\n        var node = new JsonObject();\n\n        node.WriteDiscriminator(typeof(Optional<int>));\n\n        Assert.That((string?)node[\"$type\"], Is.EqualTo(TypeFormat.ToString(typeof(Optional<int>))));\n    }\n\n    [Test]\n    public void TryGetPropertyValueAsJsonValue_TypedAccessSucceeds()\n    {\n        var node = new JsonObject { [\"v\"] = 42 };\n\n        bool ok = node.TryGetPropertyValueAsJsonValue<int>(\"v\", out int value);\n\n        Assert.That(ok, Is.True);\n        Assert.That(value, Is.EqualTo(42));\n    }\n\n    [Test]\n    public void TryGetPropertyValueAsJsonValue_MissingProperty_ReturnsFalse()\n    {\n        var node = new JsonObject();\n\n        bool ok = node.TryGetPropertyValueAsJsonValue<int>(\"v\", out int value);\n\n        Assert.That(ok, Is.False);\n        Assert.That(value, Is.EqualTo(0));\n    }\n\n    [Test]\n    public void ToDictionary_FlattensJsonStructure()\n    {\n        var node = new JsonObject\n        {\n            [\"i\"] = 1,\n            [\"s\"] = \"x\",\n            [\"b\"] = true,\n            [\"arr\"] = new JsonArray(1, 2, 3),\n            [\"nested\"] = new JsonObject { [\"a\"] = 1 },\n        };\n\n        Dictionary<string, object> dict = node.ToDictionary();\n\n        Assert.That(dict[\"s\"], Is.EqualTo(\"x\"));\n        Assert.That(dict[\"b\"], Is.EqualTo(true));\n        Assert.That(dict[\"arr\"], Is.InstanceOf<object[]>());\n        Assert.That(dict[\"nested\"], Is.InstanceOf<Dictionary<string, object>>());\n    }\n\n    [Test]\n    public void GetOrCreateConverterInstance_ReturnsSameInstanceForSameType()\n    {\n        var c1 = JsonHelper.GetOrCreateConverterInstance(typeof(OptionalJsonConverter));\n        var c2 = JsonHelper.GetOrCreateConverterInstance(typeof(OptionalJsonConverter));\n\n        Assert.That(c1, Is.SameAs(c2));\n        Assert.That(c1, Is.InstanceOf<OptionalJsonConverter>());\n    }\n\n    [FallbackType(typeof(FallbackImpl))]\n    private abstract class BaseWithFallback\n    {\n    }\n\n    private sealed class FallbackImpl : BaseWithFallback\n    {\n    }\n}\n", "head_content": "\ufeffusing System.Text.Json.Nodes;\nusing Beutl.Serialization;\n\nnamespace Beutl.UnitTests.Core;\n\npublic class JsonHelperTests\n{\n    [Test]\n    public void JsonSave_AndRestore_RoundTripsContent()\n    {\n        var json = new JsonObject { [\"x\"] = 1, [\"s\"] = \"hello\" };\n        string path = Path.GetTempFileName();\n        try\n        {\n            json.JsonSave(path);\n\n            JsonNode? restored = JsonHelper.JsonRestore(path);\n            Assert.That(restored, Is.Not.Null);\n            Assert.That((int)restored![\"x\"]!, Is.EqualTo(1));\n            Assert.That((string?)restored[\"s\"], Is.EqualTo(\"hello\"));\n        }\n        finally\n        {\n            if (File.Exists(path)) File.Delete(path);\n        }\n    }\n\n    [Test]\n    public void JsonSave_DoesNotLeaveTempFile()\n    {\n        var json = new JsonObject { [\"v\"] = 1 };\n        string path = Path.GetTempFileName();\n        string dir = Path.GetDirectoryName(path)!;\n        string baseName = Path.GetFileName(path);\n        try\n        {\n            json.JsonSave(path);\n\n            string[] tmps = Directory.GetFiles(dir, $\"{baseName}.*.tmp\");\n            Assert.That(tmps, Is.Empty);\n        }\n        finally\n        {\n            if (File.Exists(path)) File.Delete(path);\n        }\n    }\n\n    [Test]\n    public void JsonRestore_FileNotFound_ReturnsNull()\n    {\n        string path = Path.Combine(Path.GetTempPath(), Guid.NewGuid().ToString(\"N\"));\n\n        JsonNode? result = JsonHelper.JsonRestore(path);\n\n        Assert.That(result, Is.Null);\n    }\n\n    [Test]\n    public void JsonRestore_InvalidJson_ReturnsNull()\n    {\n        string path = Path.GetTempFileName();\n        try\n        {\n            File.WriteAllText(path, \"{ this is not valid json\");\n\n            JsonNode? result = JsonHelper.JsonRestore(path);\n\n            Assert.That(result, Is.Null);\n        }\n        finally\n        {\n            if (File.Exists(path)) File.Delete(path);\n        }\n    }\n\n    [Test]\n    public void JsonRestore_InvalidJson_LeavesFileUntouched()\n    {\n        string path = Path.GetTempFileName();\n        const string corrupt = \"{ this is not valid json\";\n        try\n        {\n            File.WriteAllText(path, corrupt);\n\n            _ = JsonHelper.JsonRestore(path);\n\n            Assert.That(File.Exists(path), Is.True);\n            Assert.That(File.ReadAllText(path), Is.EqualTo(corrupt));\n        }\n        finally\n        {\n            if (File.Exists(path)) File.Delete(path);\n        }\n    }\n\n    [Test]\n    public void TryGetDiscriminator_Type_ReturnsTypeForKnownEntries()\n    {\n        var node = new JsonObject { [\"$type\"] = TypeFormat.ToString(typeof(Optional<int>)) };\n\n        bool ok = node.TryGetDiscriminator(out Type? type);\n\n        Assert.That(ok, Is.True);\n        Assert.That(type, Is.EqualTo(typeof(Optional<int>)));\n    }\n\n    [Test]\n    public void TryGetDiscriminator_String_ReturnsRawValue()\n    {\n        var node = new JsonObject { [\"@type\"] = \"[Some.Asm]:Some.Type\" };\n\n        bool ok = node.TryGetDiscriminator(out string? text);\n\n        Assert.That(ok, Is.True);\n        Assert.That(text, Is.EqualTo(\"[Some.Asm]:Some.Type\"));\n    }\n\n    [Test]\n    public void TryGetDiscriminator_NoTypeProperty_ReturnsFalse()\n    {\n        var node = new JsonObject { [\"foo\"] = 1 };\n\n        bool ok = node.TryGetDiscriminator(out Type? type);\n\n        Assert.That(ok, Is.False);\n        Assert.That(type, Is.Null);\n    }\n\n    [Test]\n    public void GetDiscriminator_FallsBackToFallbackTypeAttribute()\n    {\n        // No discriminator on node, BaseType has FallbackTypeAttribute -> uses fallback.\n        var node = new JsonObject();\n\n        Type? type = node.GetDiscriminator(typeof(BaseWithFallback));\n\n        Assert.That(type, Is.EqualTo(typeof(FallbackImpl)));\n    }\n\n    [Test]\n    public void GetDiscriminator_PrefersExplicitTypeOverFallback()\n    {\n        var node = new JsonObject { [\"$type\"] = TypeFormat.ToString(typeof(Optional<int>)) };\n\n        Type? type = node.GetDiscriminator(typeof(BaseWithFallback));\n\n        Assert.That(type, Is.EqualTo(typeof(Optional<int>)));\n    }\n\n    [Test]\n    public void WriteDiscriminator_WritesTypeFormatString()\n    {\n        var node = new JsonObject();\n\n        node.WriteDiscriminator(typeof(Optional<int>));\n\n        Assert.That((string?)node[\"$type\"], Is.EqualTo(TypeFormat.ToString(typeof(Optional<int>))));\n    }\n\n    [Test]\n    public void TryGetPropertyValueAsJsonValue_TypedAccessSucceeds()\n    {\n        var node = new JsonObject { [\"v\"] = 42 };\n\n        bool ok = node.TryGetPropertyValueAsJsonValue<int>(\"v\", out int value);\n\n        Assert.That(ok, Is.True);\n        Assert.That(value, Is.EqualTo(42));\n    }\n\n    [Test]\n    public void TryGetPropertyValueAsJsonValue_MissingProperty_ReturnsFalse()\n    {\n        var node = new JsonObject();\n\n        bool ok = node.TryGetPropertyValueAsJsonValue<int>(\"v\", out int value);\n\n        Assert.That(ok, Is.False);\n        Assert.That(value, Is.EqualTo(0));\n    }\n\n    [Test]\n    public void ToDictionary_FlattensJsonStructure()\n    {\n        var node = new JsonObject\n        {\n            [\"i\"] = 1,\n            [\"s\"] = \"x\",\n            [\"b\"] = true,\n            [\"arr\"] = new JsonArray(1, 2, 3),\n            [\"nested\"] = new JsonObject { [\"a\"] = 1 },\n        };\n\n        Dictionary<string, object> dict = node.ToDictionary();\n\n        Assert.That(dict[\"s\"], Is.EqualTo(\"x\"));\n        Assert.That(dict[\"b\"], Is.EqualTo(true));\n        Assert.That(dict[\"arr\"], Is.InstanceOf<object[]>());\n        Assert.That(dict[\"nested\"], Is.InstanceOf<Dictionary<string, object>>());\n    }\n\n    [Test]\n    public void GetOrCreateConverterInstance_ReturnsSameInstanceForSameType()\n    {\n        var c1 = JsonHelper.GetOrCreateConverterInstance(typeof(OptionalJsonConverter));\n        var c2 = JsonHelper.GetOrCreateConverterInstance(typeof(OptionalJsonConverter));\n\n        Assert.That(c1, Is.SameAs(c2));\n        Assert.That(c1, Is.InstanceOf<OptionalJsonConverter>());\n    }\n\n    [FallbackType(typeof(FallbackImpl))]\n    private abstract class BaseWithFallback\n    {\n    }\n\n    private sealed class FallbackImpl : BaseWithFallback\n    {\n    }\n}\n", "patch": "--- a/tests/Beutl.UnitTests/Core/JsonHelperTests.cs\n+++ b/tests/Beutl.UnitTests/Core/JsonHelperTests.cs\n@@ -53,6 +53,44 @@\n         JsonNode? result = JsonHelper.JsonRestore(path);\n \n         Assert.That(result, Is.Null);\n+    }\n+\n+    [Test]\n+    public void JsonRestore_InvalidJson_ReturnsNull()\n+    {\n+        string path = Path.GetTempFileName();\n+        try\n+        {\n+            File.WriteAllText(path, \"{ this is not valid json\");\n+\n+            JsonNode? result = JsonHelper.JsonRestore(path);\n+\n+            Assert.That(result, Is.Null);\n+        }\n+        finally\n+        {\n+            if (File.Exists(path)) File.Delete(path);\n+        }\n+    }\n+\n+    [Test]\n+    public void JsonRestore_InvalidJson_LeavesFileUntouched()\n+    {\n+        string path = Path.GetTempFileName();\n+        const string corrupt = \"{ this is not valid json\";\n+        try\n+        {\n+            File.WriteAllText(path, corrupt);\n+\n+            _ = JsonHelper.JsonRestore(path);\n+\n+            Assert.That(File.Exists(path), Is.True);\n+            Assert.That(File.ReadAllText(path), Is.EqualTo(corrupt));\n+        }\n+        finally\n+        {\n+            if (File.Exists(path)) File.Delete(path);\n+        }\n     }\n \n     [Test]\n"}], "agent_initiated": false, "agent_signals": null, "author_type": "human", "reviewer_types": ["agent", "agent"], "interaction_type": "human_agent", "takeover_events": [], "first_human_takeover_ts": null, "merged_with_unresolved": false, "candidate_issues": [], "link_confidence": "explicit", "thread_chains": [], "author_self_reviewed": false, "fully_agent_authored": false, "requested_reviewers": [{"login_or_team": "", "kind": "unknown", "created_at": "2026-05-14T03:32:38Z"}], "review_request_removed": [], "reviewer_was_requested": false, "merged_by": "yuto-trd", "merge_commit_oid": "aae9b56083b29179fdf113832d0768df767514e7", "merged_by_is_author": true, "maintainer_override": false, "referenced_file_contents": {}, "repo_is_fork": null, "repo_parent": null, "repo_collaborator_count": null, "hours_to_first_review": 0.04888888888888889, "median_response_latency_hours": null, "reviewer_count": 2, "merged_by_association": null, "n_commits": 3, "n_human_commits": 0, "n_agent_commits": 3, "n_bot_commits": 0, "agent_commit_ratio": 1.0, "repo_metadata": {"full_name": "b-editor/beutl", "owner": "b-editor", "name": "beutl", "stars": 1166, "language": "C#", "license": "gpl-3.0", "topics": [], "description": "Cross-platform video editing (compositing) software.", "url": "https://github.com/b-editor/beutl", "default_branch": "main", "open_issues": 54, "forks": 55, "discovered_via": "license:gpl-3.0 language:C# stars:1001..5000 created:2008-01-01..2026-02-01 archived:false", "created_at": "2020-10-27T03:58:00Z", "pr_total_count": 1295, "issue_total_count": 388, "primary_language": "C#", "language_bytes": {}}, "conversation_comments": [{"id": "rest_4466382610", "body": "No TODO comments were found.\n<!-- Sticky Pull Request Commenttodo-cooments -->", "createdAt": "2026-05-16T08:50:03Z", "author": {"login": "github-actions[bot]"}}, {"id": "rest_4466388538", "body": "![Code Coverage](https://img.shields.io/badge/Code%20Coverage-38%25-yellow?style=flat)\n\nPackage | Line Rate | Branch Rate | Complexity | Health\n-------- | --------- | ----------- | ---------- | ------\nBeutl.Language | 1% | 50% | 1267 | \u2796\nBeutl.Configuration | 40% | 19% | 324 | \u2796\nBeutl.ProjectSystem | 36% | 25% | 961 | \u2796\nBeutl.Threading | 100% | 93% | 122 | \u2714\nBeutl.Engine | 36% | 35% | 17927 | \u2796\nBeutl.Editor | 72% | 66% | 1076 | \u2796\nBeutl.NodeGraph | 6% | 2% | 2490 | \u2796\nBeutl.Extensibility | 34% | 59% | 115 | \u2796\nBeutl.Core | 61% | 57% | 3081 | \u2796\nBeutl.Utilities | 94% | 90% | 358 | \u2714\n**Summary** | **38%** (24700 / 65288) | **36%** (7071 / 19480) | **27721** | \u2796\n\n_Minimum allowed line rate is `0%`_\n\n<!-- Sticky Pull Request Comment -->", "createdAt": "2026-05-16T08:53:04Z", "author": {"login": "github-actions[bot]"}}]}

bigbluebutton_bigbluebutton_24574/issues/bigbluebutton_bigbluebutton_24552.json

@@ -0,0 +1 @@
+{"number": 24552, "title": "[3.0] Unified layout - missing avatar user(s) in non-grid mode", "body": "<!--PLEASE DO NOT FILE ISSUES FOR GENERAL SUPPORT QUESTIONS.\nThis issue tracker is only for bbb development related issues.-->\n\n**Describe the bug**\nUnified layout enabled.\n\nRather than **preference** for webcam users, we **only** display the webcam users when a presentation is visible.\n\n\n**To Reproduce**\nSteps to reproduce the behavior:\n\n1. Start a session in UnifiedLayout `meetingLayout=UNIFIED_LAYOUT` on CREATE\n2. Join a session as Presenter who is moderator, no webcam\n3. join as viewer User A and share webcam\n4.  then User B and share webcam\n5.  User C with `avatarURL=https://www.publicdomainpictures.net/pictures/50000/velka/sunset-5-1369039079YoH.jpg` on JOIN\n6.  User D\n7. Switch to Presenter and observe the user tiles.\n\n\n**Expected behavior**\nWith the presentation minimized I see:\nPresenter\nUser A who has webcam\nUser B who has webcam\nUser C who has a custom avatar\nUser D who has the default avatar \"Us\"\n\n<img width=\"1560\" height=\"862\" alt=\"Image\" src=\"https://github.com/user-attachments/assets/60934945-2a53-4bdc-bec9-e7937e266acc\" />\n\nWith the presentation visible, I am expected to see (because there's enough space above the presentation for 5 users)\nPresenter\nUser A who has webcam\nUser B who has webcam\nUser C who has a custom avatar\nUser D who has the default avatar \"Us\"\n\n\n\n**Actual behavior**\nWith the presentation minimized I see: (GOOD)\nPresenter\nUser A who has webcam\nUser B who has webcam\nUser C who has a custom avatar\nUser D who has the default avatar \"Us\"\n<img width=\"1560\" height=\"862\" alt=\"Image\" src=\"https://github.com/user-attachments/assets/60934945-2a53-4bdc-bec9-e7937e266acc\" />\n\nWhen the presentation is visible though: (avatar users missing)\nPresenter\nUser A who has webcam\nUser B who has webcam\n\n<img width=\"1563\" height=\"845\" alt=\"Image\" src=\"https://github.com/user-attachments/assets/358e7dd1-bfbb-45ce-a36f-0fcb596f5db3\" />\n\n\n**User C was supposed to be listed above the presentation**\n\n\n**BBB version:**\nBigBlueButton 3.0.19.", "state": "CLOSED", "created_at": "2026-01-26T15:51:29Z", "closed_at": "2026-02-09T14:35:59Z", "author_login": "antobinary", "comment_rounds": [{"comments": [{"id": "IC_kwDOAApxXs7it0ZA", "body": "@antobinary Please review my PR - https://github.com/bigbluebutton/bigbluebutton/pull/24553", "createdAt": "2026-01-27T07:55:43Z", "updatedAt": "2026-01-27T07:55:43Z", "author": {"login": "smartcoder0777"}}]}], "resolution": "closed_by_pr", "closed_by_pr": 24574, "link_type": "closing_keyword", "will_close": true, "comment_count": 1, "issue_age_at_pr_days": null, "issue_was_open_at_pr": null, "labels": ["module: client", "component: layout", "status: verify"], "milestone": "Release 3.0", "sub_issues": [], "sub_issue_count": 0, "parent_issues": []}