Benchanything's picture
Add 300 CheckerBench tasks, dataset card, and restoration tools (part 2)
62cfde8 verified
Raw History Blame Contribute Delete
2.03 kB
diff --git a/src/main/java/io/airlift/compress/v3/snappy/SnappyRawDecompressor.java b/src/main/java/io/airlift/compress/v3/snappy/SnappyRawDecompressor.java
index 00728c2..246ee7e 100644
--- a/src/main/java/io/airlift/compress/v3/snappy/SnappyRawDecompressor.java
+++ b/src/main/java/io/airlift/compress/v3/snappy/SnappyRawDecompressor.java
@@ -150,7 +150,7 @@ final class SnappyRawDecompressor
// bit 8).
int matchOffset = entry & 0x700;
matchOffset += trailer;
- if (matchOffset < 0) {
+ if (matchOffset <= 0) {
throw new MalformedInputException(input - inputAddress);
}
diff --git a/src/test/java/io/airlift/compress/v3/snappy/TestSnappyJava.java b/src/test/java/io/airlift/compress/v3/snappy/TestSnappyJava.java
index 22713a3..3dbd553 100644
--- a/src/test/java/io/airlift/compress/v3/snappy/TestSnappyJava.java
+++ b/src/test/java/io/airlift/compress/v3/snappy/TestSnappyJava.java
@@ -15,8 +15,12 @@ package io.airlift.compress.v3.snappy;
import io.airlift.compress.v3.Compressor;
import io.airlift.compress.v3.Decompressor;
+import io.airlift.compress.v3.MalformedInputException;
import io.airlift.compress.v3.thirdparty.XerialSnappyCompressor;
import io.airlift.compress.v3.thirdparty.XerialSnappyDecompressor;
+import org.junit.jupiter.api.Test;
+
+import static org.assertj.core.api.Assertions.assertThatThrownBy;
class TestSnappyJava
extends AbstractTestSnappy
@@ -44,4 +48,13 @@ class TestSnappyJava
{
return new XerialSnappyDecompressor();
}
+
+ @Test
+ void testZeroMatchOffsetFails()
+ {
+ byte[] zeroMatchOffset = new byte[] {16, 1, 0, 1, 0, 1, 0, 1, 0};
+ assertThatThrownBy(() -> new SnappyJavaDecompressor().decompress(zeroMatchOffset, 0, zeroMatchOffset.length, new byte[64], 0, 64))
+ .isInstanceOf(MalformedInputException.class)
+ .hasMessageContaining("Malformed input: offset=2");
+ }
}