repo_name stringlengths 1 62 | dataset stringclasses 1
value | lang stringclasses 11
values | pr_id int64 1 20.1k | owner stringlengths 2 34 | reviewer stringlengths 2 39 | diff_hunk stringlengths 15 262k | code_review_comment stringlengths 1 99.6k |
|---|---|---|---|---|---|---|---|
bridge-manager | github_2023 | others | 17 | beeper | tulir | @@ -153,7 +153,7 @@ bridge:
# Maximum number of messages to backfill for new portal rooms.
initial_limit: 100
# Maximum age of chats to sync in days.
- initial_sync_max_age: 0.5
+ initial_sync_max_age: 14 | Not sure if it should be that high by default, might be better to just add a way to override config fields with `bbctl run` arguments |
sbomqs | github_2023 | others | 331 | interlynk-io | lpanni | @@ -1,86 +1,134 @@
# Compliance Reports
-sbomqs now helps generating compliance reports for your SBOMs. We support industry standard requirements
-like NTIA minimum elements, BSI TR-03183-2 v1.1 and OWASP SCVS.
-
-The goal of compliance reports is to verify if the sbom file adheres to these standard, before they are... | the guideline specified SHA-512 for "hash value of the deployable component" |
sbomqs | github_2023 | go | 351 | interlynk-io | riteshnoronha | @@ -27,7 +27,7 @@ import (
)
var (
- validBsiSpdxVersions = []string{"SPDX-2.3"} | This is incorrect for BSI 1.1 its SPDX-2.3 only. |
sbomqs | github_2023 | go | 339 | interlynk-io | riteshnoronha | @@ -97,9 +98,12 @@ func init() {
complianceCmd.Flags().BoolP("debug", "D", false, "debug logging")
// Output control
- complianceCmd.Flags().BoolP("json", "j", false, "json format")
- complianceCmd.Flags().BoolP("basic", "b", false, "basic format")
- complianceCmd.Flags().BoolP("detailed", "d", false, "detailed f... | `color mode on` |
sbomqs | github_2023 | others | 327 | interlynk-io | surendrapathak | @@ -30,6 +30,10 @@ brew install sbomqs
Other [installation options](#installation).
+# SBOM Platform - Free Tier
+
+Our new free tier provides a comprehensive solution to manage SBOMs (Software Bill of Materials) effortlessly, from centralized storage to vulnerability scanning, all while ensuring compliance and en... | Our SBOM Automation Platform has a new free tier that provides a comprehensive solution to manage SBOMs (Software Bill of Materials) effortlessly. From centralized SBOM storage, built-in SBOM editor, continuous vulnerability mapping and assessment, and support for organizational policies, all while ensuring compliance ... |
sbomqs | github_2023 | others | 286 | interlynk-io | riteshnoronha | @@ -66,3 +66,21 @@ The [OpenChain Telco](https://github.com/OpenChain-Project/Reference-Material/bl
| Timing of SBOM delivery | 3.6 | `SBOM delivery time` | delivery time | |
| Method of SBOM delivery | 3.7 | `SBOM delivery method` | delivery method | |
| SBOM Scope | 3.8 | `SBOM scope` | sbom scope | |
+
+## NTIA m... | For SPDX it should be creator->Person, creator->organization or creator->tool |
sbomqs | github_2023 | others | 286 | interlynk-io | riteshnoronha | @@ -66,3 +66,21 @@ The [OpenChain Telco](https://github.com/OpenChain-Project/Reference-Material/bl
| Timing of SBOM delivery | 3.6 | `SBOM delivery time` | delivery time | |
| Method of SBOM delivery | 3.7 | `SBOM delivery method` | delivery method | |
| SBOM Scope | 3.8 | `SBOM scope` | sbom scope | |
+
+## NTIA m... | remove this |
sbomqs | github_2023 | others | 286 | interlynk-io | riteshnoronha | @@ -66,3 +66,21 @@ The [OpenChain Telco](https://github.com/OpenChain-Project/Reference-Material/bl
| Timing of SBOM delivery | 3.6 | `SBOM delivery time` | delivery time | |
| Method of SBOM delivery | 3.7 | `SBOM delivery method` | delivery method | |
| SBOM Scope | 3.8 | `SBOM scope` | sbom scope | |
+
+## NTIA m... | Just dependencies here, composition is for depth. |
sbomqs | github_2023 | others | 286 | interlynk-io | riteshnoronha | @@ -66,3 +66,21 @@ The [OpenChain Telco](https://github.com/OpenChain-Project/Reference-Material/bl
| Timing of SBOM delivery | 3.6 | `SBOM delivery time` | delivery time | |
| Method of SBOM delivery | 3.7 | `SBOM delivery method` | delivery method | |
| SBOM Scope | 3.8 | `SBOM scope` | sbom scope | |
+
+## NTIA m... | For SPDX it should also be cpe/purl |
sbomqs | github_2023 | others | 286 | interlynk-io | riteshnoronha | @@ -66,3 +66,21 @@ The [OpenChain Telco](https://github.com/OpenChain-Project/Reference-Material/bl
| Timing of SBOM delivery | 3.6 | `SBOM delivery time` | delivery time | |
| Method of SBOM delivery | 3.7 | `SBOM delivery method` | delivery method | |
| SBOM Scope | 3.8 | `SBOM scope` | sbom scope | |
+
+## NTIA m... | We should also denotes field which are mandatory vs optional with an * |
sbomqs | github_2023 | go | 280 | interlynk-io | riteshnoronha | @@ -0,0 +1,223 @@
+package source | We should not limit ourselves to only GitHub urls. An SBOM could be on any URL, we should just check if this path is a url and download the file and run sbomqs on it. This is adding too much complexity. |
sbomqs | github_2023 | others | 261 | interlynk-io | riteshnoronha | @@ -30,3 +32,38 @@ The [BSI TR-03183-2 v1.1](https://www.bsi.bund.de/SharedDocs/Downloads/EN/BSI/Pu
| | `URI of the executable form`| component->externalReferences->type (distribution/distribution-intake) | PackageDownloadLocation | |
| | `hash of source code`| no-deterministic-field | package->PackageVerificationCod... | Remove all the details in () not required. e.g DataLicense(SBOM_LICENSE) we don't require (SBOM_LICENSE) |
sbomqs | github_2023 | go | 261 | interlynk-io | riteshnoronha | @@ -57,5 +61,13 @@ func ComplianceResult(ctx context.Context, doc sbom.Document, reportType, fileNa
ntiaResult(ctx, doc, fileName, outFormat)
}
+ if reportType == OCT_TELCO {
+ if doc.Spec().GetSpecType() != "spdx" {
+ fmt.Println("The Provided SBOM spec is other than SPDX. Open Chain Telco only support SPDX ... | 👍 |
sbomqs | github_2023 | others | 239 | interlynk-io | rutger-gerritsen | @@ -14,8 +14,17 @@ LABEL org.opencontainers.image.source="https://github.com/interlynk-io/sbomqs"
LABEL org.opencontainers.image.description="Quality metrics for your sboms"
LABEL org.opencontainers.image.licenses=Apache-2.0
+# Copy the certs from the builder image
+COPY --from=builder /bin/bash /bin/bash
+COPY --f... | `/usr` from `golang:1.22.2-alpine` increases the image size considerably about 71 MiB. Maybe copy the `/usr` folder from `alpine:3.19` or use `alpine:3.19` as a base image instead of `scratch`?
```
FROM alpine:3.19 AS alpine
FROM scratch
...
COPY --from=alpine /usr /usr
...
``` |
sbomqs | github_2023 | others | 239 | interlynk-io | rutger-gerritsen | @@ -14,8 +14,17 @@ LABEL org.opencontainers.image.source="https://github.com/interlynk-io/sbomqs"
LABEL org.opencontainers.image.description="Quality metrics for your sboms"
LABEL org.opencontainers.image.licenses=Apache-2.0
+# Copy the certs from the builder image | Certs? |
sbomqs | github_2023 | go | 134 | interlynk-io | surendrapathak | @@ -190,6 +190,7 @@ func handlePath(ctx context.Context, ep *Params, criterias []string) error {
func processFile(ctx context.Context, path, category string, criterias []string) (sbom.Document, scorer.Scores, error) {
log := logger.FromContext(ctx)
log.Debugf("Processing file :%s\n", path)
+ //fmt.Printf("Processi... | Remove this? |
sbomqs | github_2023 | go | 134 | interlynk-io | surendrapathak | @@ -178,63 +179,81 @@ func (c *cdxDoc) requiredFields() bool {
return true
}
+func copyC(cdxc *cydx.Component, c *cdxDoc) *component {
+ if cdxc == nil {
+ return nil
+ }
+
+ nc := newComponent()
+ nc.version = cdxc.Version
+ nc.name = cdxc.Name
+ nc.supplierName = c.addSupplierName(cdxc)
+ nc.purpose = string(cd... | Does this affect the Quality Score (specifically unique ID checks) |
sbomqs | github_2023 | others | 52 | interlynk-io | surendrapathak | @@ -0,0 +1,194 @@
+<!--
+ Copyright 2023 Interlynk.io
+
+ Licensed under the Apache License, Version 2.0 (the "License");
+ you may not use this file except in compliance with the License.
+ You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable l... | Thoughts on removing 'your' - "Quality metrics for SBOMs" |
sbomqs | github_2023 | others | 52 | interlynk-io | surendrapathak | @@ -0,0 +1,194 @@
+<!--
+ Copyright 2023 Interlynk.io
+
+ Licensed under the Apache License, Version 2.0 (the "License");
+ you may not use this file except in compliance with the License.
+ You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable l... | a ~good~ high quality |
sbomqs | github_2023 | others | 52 | interlynk-io | surendrapathak | @@ -0,0 +1,194 @@
+<!--
+ Copyright 2023 Interlynk.io
+
+ Licensed under the Apache License, Version 2.0 (the "License");
+ you may not use this file except in compliance with the License.
+ You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable l... | it ~was~ has been generated at, and, we belive closer to the build is the ideal time. |
sbomqs | github_2023 | others | 52 | interlynk-io | surendrapathak | @@ -0,0 +1,194 @@
+<!--
+ Copyright 2023 Interlynk.io
+
+ Licensed under the Apache License, Version 2.0 (the "License");
+ you may not use this file except in compliance with the License.
+ You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable l... | ~Prebuild~ Prebuilt |
sbomqs | github_2023 | others | 52 | interlynk-io | surendrapathak | @@ -0,0 +1,194 @@
+<!--
+ Copyright 2023 Interlynk.io
+
+ Licensed under the Apache License, Version 2.0 (the "License");
+ you may not use this file except in compliance with the License.
+ You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable l... | remove comma after ] for valid JSON |
sbomqs | github_2023 | others | 52 | interlynk-io | surendrapathak | @@ -0,0 +1,194 @@
+<!--
+ Copyright 2023 Interlynk.io
+
+ Licensed under the Apache License, Version 2.0 (the "License");
+ you may not use this file except in compliance with the License.
+ You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable l... | remove , after } for valid JSON |
sbomqs | github_2023 | go | 84 | interlynk-io | surendrapathak | @@ -37,6 +37,7 @@ type file struct {
SpecVersion string `json:"spec_version"`
Format string `json:"file_format"`
AvgScore float64 `json:"avg_score"`
+ Components int `json:"no_components"` | Name - `no_components` can be confused with components' availability. How about `num_components`? |
sbomqs | github_2023 | go | 103 | interlynk-io | surendrapathak | @@ -18,17 +28,16 @@ import (
// shareCmd represents the share command
var shareCmd = &cobra.Command{
- Use: "share",
+ Use: "share <sbom file>",
Short: "share your sbom quality score with others",
Long: `We need an easy way to communicate with sbom creators/generators
- about the quality of their sboms. sbo... | My suggestion -
Long: `share command creates a permanent link to the score result from an easy-to-understand web page.
Due to privacy considerations, the SBOM never leaves your environment, and only
the score report (includes filename) is sent to https://sbombenchmark.dev (exact JSON form is used).
For more... |
sbomqs | github_2023 | others | 3 | interlynk-io | surendrapathak | @@ -1,20 +1,171 @@
## Overview
### What is SBOM quality score
+A quality SBOM is one that is accurate, complete, and up-to-date. It should accurately reflect the components and dependencies used in the software application, including their version numbers and optionally any known vulnerabilities. In addition, it sh... | 1. including their ~version numbers~ versions
2. accessible *to* and understandable by
|
sbomqs | github_2023 | others | 3 | interlynk-io | surendrapathak | @@ -1,20 +1,171 @@
## Overview
### What is SBOM quality score
+A quality SBOM is one that is accurate, complete, and up-to-date. It should accurately reflect the components and dependencies used in the software application, including their version numbers and optionally any known vulnerabilities. In addition, it sh... | 1. Cyclonedx sbom ~formats~ *standards* |
sbomqs | github_2023 | others | 3 | interlynk-io | surendrapathak | @@ -1,20 +1,171 @@
## Overview
### What is SBOM quality score
+A quality SBOM is one that is accurate, complete, and up-to-date. It should accurately reflect the components and dependencies used in the software application, including their version numbers and optionally any known vulnerabilities. In addition, it sh... | find *sample sboms* ~to play around with.~ |
sbomqs | github_2023 | others | 3 | interlynk-io | surendrapathak | @@ -1,20 +1,171 @@
## Overview
### What is SBOM quality score
+A quality SBOM is one that is accurate, complete, and up-to-date. It should accurately reflect the components and dependencies used in the software application, including their version numbers and optionally any known vulnerabilities. In addition, it sh... | ~Chainguard has created aa repo called~
Another public repository for SBOMs in the wild is here |
sbomqs | github_2023 | others | 3 | interlynk-io | surendrapathak | @@ -1,20 +1,171 @@
## Overview
### What is SBOM quality score
+A quality SBOM is one that is accurate, complete, and up-to-date. It should accurately reflect the components and dependencies used in the software application, including their version numbers and optionally any known vulnerabilities. In addition, it sh... | the more accurate, complete and up-to-date SBOM is |
sbomqs | github_2023 | others | 3 | interlynk-io | surendrapathak | @@ -1,20 +1,171 @@
## Overview
### What is SBOM quality score
+A quality SBOM is one that is accurate, complete, and up-to-date. It should accurately reflect the components and dependencies used in the software application, including their version numbers and optionally any known vulnerabilities. In addition, it sh... | Extra space between data and in |
sbomqs | github_2023 | others | 3 | interlynk-io | surendrapathak | @@ -1,20 +1,171 @@
## Overview
### What is SBOM quality score
+A quality SBOM is one that is accurate, complete, and up-to-date. It should accurately reflect the components and dependencies used in the software application, including their version numbers and optionally any known vulnerabilities. In addition, it sh... | can be shared with someone else. |
sbomqs | github_2023 | go | 2 | interlynk-io | surendrapathak | @@ -1,10 +1,11 @@
/*
Copyright © 2023 NAME HERE <EMAIL ADDRESS> | Fix NAME HERE <EMAIL ADDRESS> |
sbomqs | github_2023 | go | 32 | interlynk-io | riteshnoronha | @@ -328,11 +329,21 @@ func (s *spdxDoc) cpes(index int) []string {
for _, p := range pkg.PackageExternalReferences {
if strings.ToLower(p.RefType) == spdx_common.TypeSecurityCPE23Type {
- urls = append(urls, p.Locator)
+ cpeValidae := cpe.NewCPE(p.Locator)
+ if cpeValidae.Valid() {
+ urls = append(urls,... | I believe this package only checks for valid 2.3 cpe not 2.2 can u clarify ? |
sbomqs | github_2023 | go | 32 | interlynk-io | riteshnoronha | @@ -328,11 +329,21 @@ func (s *spdxDoc) cpes(index int) []string {
for _, p := range pkg.PackageExternalReferences {
if strings.ToLower(p.RefType) == spdx_common.TypeSecurityCPE23Type { | We need to add test cases for these functions. |
sbomqs | github_2023 | go | 32 | interlynk-io | riteshnoronha | @@ -186,7 +187,12 @@ func (c *cdxDoc) parseComps() {
nc.purpose = string(sc.Type)
nc.isReqFieldsPresent = c.pkgRequiredFields(index)
nc.purls = []string{sc.PackageURL}
- nc.cpes = []string{sc.CPE}
+ ncpe := cpe.NewCPE(sc.CPE) | Need to add test cases |
sbomqs | github_2023 | go | 32 | interlynk-io | riteshnoronha | @@ -0,0 +1,47 @@
+// Copyright 2023 Interlynk.io
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicab... | Need 2.3 & 2.2 support |
sbomqs | github_2023 | go | 32 | interlynk-io | riteshnoronha | @@ -0,0 +1,40 @@
+// Copyright 2023 Interlynk.io
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicab... | There is no reason for interface. |
sbomqs | github_2023 | go | 33 | interlynk-io | riteshnoronha | @@ -0,0 +1,39 @@
+// Copyright 2023 Interlynk.io
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicab... | Why do we need this ? |
sbomqs | github_2023 | go | 33 | interlynk-io | riteshnoronha | @@ -185,7 +186,12 @@ func (c *cdxDoc) parseComps() {
}
nc.purpose = string(sc.Type)
nc.isReqFieldsPresent = c.pkgRequiredFields(index)
- nc.purls = []string{sc.PackageURL}
+ npurl := purl.NewPURL(sc.PackageURL) | Add test for this |
sbomqs | github_2023 | go | 34 | interlynk-io | riteshnoronha | @@ -40,6 +40,9 @@ var scoreCmd = &cobra.Command{
err = processFile(ctx, inFile, false)
} else if len(inDirPath) > 0 {
err = processDir(ctx, inDirPath)
+ } else if len(args) > 0 { | This logic does not seem correct.
```
./sbomqs score --reportFormat basic will now fail
``` |
sbomqs | github_2023 | others | 128 | interlynk-io | riteshnoronha | @@ -14,27 +14,308 @@
limitations under the License.
-->
-Name | Description |
------------ | ----------------------------------------- |
-SBOM Specification | Checks if the sbom is in one of the currently supported formats : <br>- [**CycloneDX**](https://cyclonedx.org/),<br>-... | @surendrapathak eventually weights are going to be added which are user customizable. Should we indicate this.. or when its ready |
sbomqs | github_2023 | others | 128 | interlynk-io | riteshnoronha | @@ -14,27 +14,308 @@
limitations under the License.
-->
-Name | Description |
------------ | ----------------------------------------- |
-SBOM Specification | Checks if the sbom is in one of the currently supported formats : <br>- [**CycloneDX**](https://cyclonedx.org/),<br>-... | Quality Check Sets - Interlynk (Default) |
sbomqs | github_2023 | others | 128 | interlynk-io | riteshnoronha | @@ -14,27 +14,308 @@
limitations under the License.
-->
-Name | Description |
------------ | ----------------------------------------- |
-SBOM Specification | Checks if the sbom is in one of the currently supported formats : <br>- [**CycloneDX**](https://cyclonedx.org/),<br>-... | Duplicate of the above? |
sbomqs | github_2023 | others | 128 | interlynk-io | riteshnoronha | @@ -14,27 +14,308 @@
limitations under the License.
-->
-Name | Description |
------------ | ----------------------------------------- |
-SBOM Specification | Checks if the sbom is in one of the currently supported formats : <br>- [**CycloneDX**](https://cyclonedx.org/),<br>-... | We should ack, there is ongoing dicusssions in the open-source ecosystem, about open-source maintainers being classified as suppliers ? |
sbomqs | github_2023 | others | 128 | interlynk-io | riteshnoronha | @@ -14,27 +14,308 @@
limitations under the License.
-->
-Name | Description |
------------ | ----------------------------------------- |
-SBOM Specification | Checks if the sbom is in one of the currently supported formats : <br>- [**CycloneDX**](https://cyclonedx.org/),<br>-... | at this point we only check metadata and components, in future we will expand it to files, etc |
sbomqs | github_2023 | go | 75 | interlynk-io | riteshnoronha | @@ -0,0 +1,77 @@
+/*
+Copyright © 2023 NAME HERE <EMAIL ADDRESS>
+*/
+package cmd
+
+import (
+ "context"
+ "os"
+
+ "github.com/interlynk-io/sbomqs/pkg/logger"
+ "github.com/interlynk-io/sbomqs/pkg/scorer"
+ "github.com/samber/lo"
+ "github.com/spf13/cobra"
+ "gopkg.in/yaml.v3"
+)
+
+const config_file_name = "config.y... | rename to features.yaml |
sbomqs | github_2023 | others | 75 | interlynk-io | surendrapathak | @@ -0,0 +1,78 @@
+category:
+ - name: NTIA-minimum-elements
+ enabled: true
+ weight: 100 | Please remove weights for this version because it has no impact |
sbomqs | github_2023 | go | 75 | interlynk-io | surendrapathak | @@ -0,0 +1,77 @@
+/*
+Copyright © 2023 NAME HERE <EMAIL ADDRESS>
+*/
+package cmd
+
+import (
+ "context"
+ "os"
+
+ "github.com/interlynk-io/sbomqs/pkg/logger"
+ "github.com/interlynk-io/sbomqs/pkg/scorer"
+ "github.com/samber/lo"
+ "github.com/spf13/cobra"
+ "gopkg.in/yaml.v3"
+)
+
+const config_file_name = "config.y... | Let's call it
```sbomqs generate features ```
instead of
```sbomqs generate```
|
sbomqs | github_2023 | others | 75 | interlynk-io | riteshnoronha | @@ -0,0 +1,73 @@
+category: | @kchetans please remove this file. |
sbomqs | github_2023 | go | 75 | interlynk-io | riteshnoronha | @@ -66,13 +67,25 @@ func (s *Scorer) Score() Scores {
}
scores := newScores()
- for _, cr := range criteria {
- score := cr(s.doc)
- if s.category != "" && s.category == score.Category() {
- scores.addScore(score)
- } else if s.category == "" {
- scores.addScore(score)
+ for key, cr := range criteria { | This logic needs to be simplified, maybe split out the common functionality . |
sbomqs | github_2023 | go | 75 | interlynk-io | surendrapathak | @@ -0,0 +1,85 @@
+/*
+Copyright © 2023 NAME HERE <EMAIL ADDRESS> | Fix Copyright for Interlynk |
godot-open-rts | github_2023 | others | 89 | lampe-games | Scony | @@ -8,12 +8,11 @@ const MATERIAL_ALBEDO_TO_REPLACE_EPSILON = 0.05
resource_a = max(0, value)
if resource_a == 0:
queue_free()
-
+@export var color = Constants.Match.Resources.A.COLOR | IMO we can drop `@export` in the case of both resource files - that variable should be as read-only as possible to avoid situations where the color is being changed in runtime |
bussin | github_2023 | others | 55 | face-hh | tovade | @@ -15,14 +15,12 @@ We, at Bussin, believe everyone should be entertained while coding. Meet our alt
Inside **Bussin X**, you *can* use BS syntax, however, it's recommended to use the **BSX** syntax described below.
### New!
-- More math. `math.e`, `math.toString(5)`, `math.toNumber("5")`
+- Updated fetch. `fetch(... | comments aren't new in this version, maybe update the string function thing to your string keynames feature, idk |
sd-dynamic-thresholding | github_2023 | python | 87 | mcmonkeyprojects | mcmonkey4eva | @@ -68,8 +68,8 @@ def sampler_dyn_thresh(args):
cond = input - args["cond"]
uncond = input - args["uncond"]
cond_scale = args["cond_scale"]
- time_step = args["timestep"]
- dynamic_thresh.step = 999 - time_step[0]
+ time_step = model.model.model_sa... | Accidentally over-deletion here? |
sd-dynamic-thresholding | github_2023 | python | 58 | mcmonkeyprojects | mcmonkey4eva | @@ -88,9 +88,12 @@ def process_batch(self, p, enabled, mimic_scale, threshold_percentile, mimic_mod
if not enabled:
return
orig_sampler_name = p.sampler_name
+ orig_latent_sampler_name = getattr(p, 'latent_sampler', None)
if orig_sampler_name in ["DDIM", "PLMS"]:
... | This... just ignores the original sampler? |
sd-dynamic-thresholding | github_2023 | python | 9 | mcmonkeyprojects | mcmonkey4eva | @@ -0,0 +1,70 @@
+from pathlib import Path
+
+from modules import scripts
+from scripts.dynamic_thresholding import VALID_MODES as scheduler_list
+
+
+def find_module(name_list):
+ if isinstance(name_list, str):
+ name_list = [s.strip() for s in name_list.split(",")]
+
+ for data in scripts.scrip... | This seems overcomplicated? xyz_grid is built in to the webui and guaranteed to be there |
sd-dynamic-thresholding | github_2023 | python | 9 | mcmonkeyprojects | mcmonkey4eva | @@ -0,0 +1,70 @@
+from pathlib import Path
+
+from modules import scripts
+from scripts.dynamic_thresholding import VALID_MODES as scheduler_list
+
+
+def find_module(name_list):
+ if isinstance(name_list, str):
+ name_list = [s.strip() for s in name_list.split(",")]
+
+ for data in scripts.scrip... | I'd also say this is overcomplicated - probably better for extension settings to be at the bottom of the list rather than up at the top crowding the space around CFG Scale.
While you're working with it actively, it's convenient sure, but when you're not it feels like that'd get in the way |
sd-dynamic-thresholding | github_2023 | python | 9 | mcmonkeyprojects | mcmonkey4eva | @@ -0,0 +1,70 @@
+from pathlib import Path
+
+from modules import scripts
+from scripts.dynamic_thresholding import VALID_MODES as scheduler_list
+
+
+def find_module(name_list):
+ if isinstance(name_list, str):
+ name_list = [s.strip() for s in name_list.split(",")]
+
+ for data in scripts.scrip... | probably shouldn't have experiment mode in the standard grid script, it's in <https://github.com/mcmonkeyprojects/sd-infinity-grid-generator-script> pretty much just for my personal use, it's explicitly as the name suggests, an experiment mode. |
iAPS | github_2023 | others | 1,124 | Artificial-Pancreas | Jon-b-m | @@ -703,19 +701,25 @@ extension OverrideProfilesConfig {
label: "SMB IOB: "
)
- if ((aisf.smbDeliveryRatioMin ?? 0.5) as Decimal) != standard
- .smbDeliveryRatioMin || ((aisf.smbDeliveryRatioMax ?? ... | No, because ”over” can mean several things. Better to be precise here. |
iAPS | github_2023 | others | 1,124 | Artificial-Pancreas | Jon-b-m | @@ -689,10 +689,8 @@ extension OverrideProfilesConfig {
bool(bool: aisf.ketoProtect, setting: standard.ketoProtect, label: "Keto: ")
bool(bool: aisf.use_B30, setting: standard.use_B30, label: "B30: ")
- LazyHStack(spacing: 5) {
- ... | No need to make more complex, as everyone knows what min and max means. It’s clear and precise already imo. |
iAPS | github_2023 | others | 384 | Artificial-Pancreas | Jon-b-m | @@ -3,11 +3,11 @@
<plist version="1.0"> | I'm not sure, but I remember when it was needed to add this file, hence I would suggest not to delete it. Speaking of translations, you didn't add the English source strings for the localization. |
iAPS | github_2023 | others | 530 | Artificial-Pancreas | lifeguardz | @@ -214,8 +214,8 @@ public final class G7Sensor: G7BluetoothManagerDelegate {
return .ignore
}
- /// The Dexcom G7 advertises a peripheral name of "DXCMxx", and later reports a full name of "Dexcomxx"
- if name.hasPrefix("DXCM") {
+ /// The Dexcom G7 advertises "DXCMxx" & te... | typo?
```suggestion
if name.hasPrefix("DXCM") || name.hasPrefix("DX02") {
``` |
iAPS | github_2023 | others | 473 | Artificial-Pancreas | dnzxy | @@ -1,5 +1,5 @@
APP_DISPLAY_NAME = iAPS
-APP_VERSION = 2.3.2
+APP_VERSION = 2.3.3 | This PR adds new, non-breaking changes. Subsequently it should be a minor release, not a patch-release, i.e. 2.x.0 |
iAPS | github_2023 | others | 473 | Artificial-Pancreas | dnzxy | @@ -70,6 +72,8 @@
<string>Bluetooth is used to communicate with insulin pump and continuous glucose monitor devices</string>
<key>NSBluetoothPeripheralUsageDescription</key>
<string>Bluetooth is used to communicate with insulin pump and continuous glucose monitor devices</string>
+ <key>NSCalendarsFullAccessUsage... | Typo here.
„a new glucose events“ |
iAPS | github_2023 | others | 400 | Artificial-Pancreas | dnzxy | @@ -72,6 +82,240 @@ extension NightscoutConfig {
.store(in: &lifetime)
}
+ private var nightscoutAPI: NightscoutAPI? {
+ guard let urlString = keychain.getValue(String.self, forKey: NightscoutConfig.Config.urlKey),
+ let url = URL(string: urlString),
+ ... | small typo here, `save` -> `saved` |
iAPS | github_2023 | others | 234 | Artificial-Pancreas | dnzxy | @@ -32,17 +32,55 @@ final class BaseCalendarManager: CalendarManager, Injectable {
let status = EKEventStore.authorizationStatus(for: .event)
switch status {
case .notDetermined:
- EKEventStore().requestAccess(to: .event) { granted, error in
- if ... | Typo, it’s `granted` |
iAPS | github_2023 | others | 234 | Artificial-Pancreas | dnzxy | @@ -32,17 +32,55 @@ final class BaseCalendarManager: CalendarManager, Injectable {
let status = EKEventStore.authorizationStatus(for: .event)
switch status {
case .notDetermined:
- EKEventStore().requestAccess(to: .event) { granted, error in
- if ... | remove testing print |
iAPS | github_2023 | others | 234 | Artificial-Pancreas | dnzxy | @@ -32,17 +32,55 @@ final class BaseCalendarManager: CalendarManager, Injectable {
let status = EKEventStore.authorizationStatus(for: .event)
switch status {
case .notDetermined:
- EKEventStore().requestAccess(to: .event) { granted, error in
- if ... | Typo, `granted` |
iAPS | github_2023 | others | 234 | Artificial-Pancreas | dnzxy | @@ -32,17 +32,55 @@ final class BaseCalendarManager: CalendarManager, Injectable {
let status = EKEventStore.authorizationStatus(for: .event)
switch status {
case .notDetermined:
- EKEventStore().requestAccess(to: .event) { granted, error in
- if ... | Typo, `granted` |
WatchAlert | github_2023 | go | 116 | opsre | Cairry | @@ -44,6 +48,44 @@ func Sender(ctx *ctx.Context, alert models.AlertCurEvent, notice models.AlertNot
global.Logger.Sugar().Errorf("Hook 类型报警发送失败 code: %d data: %s", res.StatusCode, n.CardContentMsg)
return err
}
+ case "PhoneCall":
+ setting, err := ctx.DB.Setting().Get() | 这里有个问题哈。setting里存放的是通用配置，认证相关应该放到通知对象里的。它是和通知目的（PhoneNumber）一同创建。 |
WatchAlert | github_2023 | go | 116 | opsre | Cairry | @@ -13,6 +13,7 @@ type AlertNotice struct {
NoticeTmplId string `json:"noticeTmplId"`
Hook string `json:"hook"`
Email Email `json:"email" gorm:"email;serializer:json"`
+ PhoneNumber string `json:"phoneNumber"` | 这里可以改成 []string 类型，前端计划是分多个输入框，而不是一个。数据结构如下：
phoneNumbers: [
"123",
"456",
] |
FileExplorer | github_2023 | others | 45 | conaticus | LeoCatsune | @@ -11,6 +15,25 @@ pub const fn bytes_to_gb(bytes: u64) -> u16 {
(bytes / (1e+9 as u64)) as u16
}
+/// Opens a file at the given path. Returns a string if there was an error.
+// NOTE(conaticus): I tried handling the errors nicely here but Tauri was mega cringe and wouldn't let me nest results in async function... | You probably don't need to spawn an async task in an already Async command.
Also, if this can return a failure, you should handle that with the `Err` result.
This means invocation on the client side will likely need a `.catch()` block. |
FileExplorer | github_2023 | others | 45 | conaticus | LeoCatsune | @@ -11,6 +15,25 @@ pub const fn bytes_to_gb(bytes: u64) -> u16 {
(bytes / (1e+9 as u64)) as u16
}
+/// Opens a file at the given path. Returns a string if there was an error.
+// NOTE(conaticus): I tried handling the errors nicely here but Tauri was mega cringe and wouldn't let me nest results in async function... | See below, this should probably be `Result<String, String>` |
ConPLex | github_2023 | python | 23 | samsledje | samsledje | @@ -0,0 +1,108 @@
+from argparse import ArgumentParser
+
+import numpy as np
+import pandas as pd
+import torch
+from torch.utils.data import DataLoader
+
+from conplex_dti.featurizer import MorganFeaturizer, ProtBertFeaturizer | Would prefer to use relative imports here
`from ..featurizer import MorganFeaturizer...`
`from ..architectures import SimpleCoembedding...`
etc. |
ConPLex | github_2023 | python | 23 | samsledje | samsledje | @@ -0,0 +1,108 @@
+from argparse import ArgumentParser
+
+import numpy as np
+import pandas as pd
+import torch
+from torch.utils.data import DataLoader
+
+from conplex_dti.featurizer import MorganFeaturizer, ProtBertFeaturizer
+from conplex_dti.model.architectures import SimpleCoembeddingNoSigmoid
+from conplex_dti.ut... | Please update to just `--outfile` |
ConPLex | github_2023 | python | 23 | samsledje | samsledje | @@ -0,0 +1,108 @@
+from argparse import ArgumentParser
+
+import numpy as np
+import pandas as pd
+import torch
+from torch.utils.data import DataLoader
+
+from conplex_dti.featurizer import MorganFeaturizer, ProtBertFeaturizer
+from conplex_dti.model.architectures import SimpleCoembeddingNoSigmoid
+from conplex_dti.ut... | `--data-dir` |
ConPLex | github_2023 | python | 23 | samsledje | samsledje | @@ -0,0 +1,108 @@
+from argparse import ArgumentParser
+
+import numpy as np
+import pandas as pd
+import torch
+from torch.utils.data import DataLoader
+
+from conplex_dti.featurizer import MorganFeaturizer, ProtBertFeaturizer
+from conplex_dti.model.architectures import SimpleCoembeddingNoSigmoid
+from conplex_dti.ut... | Please replace print statements with `logg.info` -- see `cli/` train.py` for examples (including `from ..utils import config_logger`, etc. |
ConPLex | github_2023 | python | 23 | samsledje | samsledje | @@ -0,0 +1,108 @@
+from argparse import ArgumentParser
+
+import numpy as np
+import pandas as pd
+import torch
+from torch.utils.data import DataLoader
+
+from conplex_dti.featurizer import MorganFeaturizer, ProtBertFeaturizer
+from conplex_dti.model.architectures import SimpleCoembeddingNoSigmoid
+from conplex_dti.ut... | Can we add `batch_size` as a non-required parameter with default ~128 or 256? Should allow people to adapt to larger or smaller GPU memory. |
ConPLex | github_2023 | python | 23 | samsledje | samsledje | @@ -0,0 +1,108 @@
+from argparse import ArgumentParser
+
+import numpy as np
+import pandas as pd
+import torch
+from torch.utils.data import DataLoader
+
+from conplex_dti.featurizer import MorganFeaturizer, ProtBertFeaturizer
+from conplex_dti.model.architectures import SimpleCoembeddingNoSigmoid
+from conplex_dti.ut... | Device should also be a user-set argument |
BingChat | github_2023 | csharp | 41 | bsdayo | neon-sunset | @@ -107,11 +115,15 @@ public async Task<BingChatConversation> CreateConversation()
throw new BingChatException(message);
}
+ var encryptedConversationSignature = rawResponse.Headers.GetValues("X-Sydney-EncryptedConversationSignature").FirstOrDefault(); | If this doesn't work without `encryptedConversationSignature`, shouldn't it be `First()` instead of `FirstOrDefault()`? |
BingChat | github_2023 | csharp | 41 | bsdayo | neon-sunset | @@ -18,35 +21,23 @@ namespace BingChat;
/// </summary>
public sealed class BingChatConversation : IBingChattable
{
- private static readonly HttpConnectionFactory ConnectionFactory = new(Options.Create(
- new HttpConnectionOptions
- {
- DefaultTransferFormat = TransferFormat.Text,
- ... | ```suggestion
_cookies = cookies;
``` |
BingChat | github_2023 | csharp | 41 | bsdayo | neon-sunset | @@ -169,16 +167,54 @@ public async Task<string> AskAsync(string message, CancellationToken ct = defaul
return messages.Count > 0 ? string.Join("\n\n", messages) : null;
}
- private static async Task<HubConnection> Connect(CancellationToken ct)
+ private HttpConnectionFactory CreateConnectionFactor... | You need to cache this property instead of creating it on each request. |
BingChat | github_2023 | csharp | 41 | bsdayo | neon-sunset | @@ -8,9 +8,12 @@ internal static class Utils
public static BingChatClient GetClient(BingChatTone tone)
{
var cookie = Environment.GetEnvironmentVariable("BING_COOKIE");
+ var cookieFile = Environment.GetEnvironmentVariable("BING_COOKIES_FILE");
+
return new BingChatClient(new ... | ```suggestion
CookieFilePath = string.IsNullOrEmpty(cookieFile) ? null : cookieFile,
``` |
BingChat | github_2023 | csharp | 41 | bsdayo | neon-sunset | @@ -169,16 +167,54 @@ public async Task<string> AskAsync(string message, CancellationToken ct = defaul
return messages.Count > 0 ? string.Join("\n\n", messages) : null;
}
- private static async Task<HubConnection> Connect(CancellationToken ct)
+ private HttpConnectionFactory CreateConnectionFactor... | You must never use `Thread.Sleep(...)` in `async` methods or methods that can be called from async. The correct way to do it is to use `Task.Delay(...)` instead. |
BingChat | github_2023 | csharp | 23 | bsdayo | neon-sunset | @@ -32,4 +34,9 @@ public sealed class BingChatClientOptions
/// Tone used for conversation (Default: Balanced)
/// </summary>
public BingChatTone Tone { get; set; }
+
+ /// <summary>
+ /// Optional Proxy used for requests
+ /// </summary>
+ public WebProxy? Proxy { get; set; } = new WebPr... | Property initializer seems to be invalid here because it contradicts the logic in handler creation `UseProxy = _options.Proxy != null`. |
BingChat | github_2023 | csharp | 23 | bsdayo | neon-sunset | @@ -68,7 +68,8 @@ public async Task<BingChatConversation> CreateConversation()
if (cookies.Count == 0)
cookies.Add(new Uri("https://www.bing.com"), new Cookie("_U", Utils.GenerateRandomHexString()));
- using var handler = new HttpClientHandler { CookieContainer = cookies };
+ using... | By the way, according to documentation, you do not need to set `UseProxy` property because it is true by default and this change would alter the behavior.
Ref: https://learn.microsoft.com/en-us/dotnet/api/system.net.http.httpclienthandler.useproxy |
EvilAppleJuice-ESP32 | github_2023 | cpp | 35 | ckcr4lyf | ckcr4lyf | @@ -7,6 +7,8 @@
#include <BLEUtils.h>
#include <BLEServer.h>
+#include <esp_gap_ble_api.h> | Any reason for this include? I am able to compile fine without it. |
EvilAppleJuice-ESP32 | github_2023 | cpp | 34 | ckcr4lyf | ckcr4lyf | @@ -1,114 +1,136 @@
-// This example takes heavy inpsiration from the ESP32 example by ronaldstoner
-// Based on the previous work of chipik / _hexway / ECTO-1A & SAY-10
-// See the README for more info
-#include <Arduino.h>
-
-#include <BLEDevice.h>
-#include <BLEUtils.h>
-#include <BLEServer.h>
-
-#include "devices.h... | Please keep comments in English |
EvilAppleJuice-ESP32 | github_2023 | others | 32 | ckcr4lyf | ckcr4lyf | @@ -16,9 +16,10 @@ Confirmed on:
* iPhone 15 (running iOS 17.1.2)
* iPhone 14 Pro Max (running iOS 17.2 b3) (See #19)
* iPhone 14 Pro (running iOS 16.6.1)
-* iPhone 13 Pro (TBD which iOS)
+* iPhone 13 Pro (running iOS 17.4 (21E5184k))
* iPhone 11 (running iOS 16.6.1)
* iPhone X (running iOS 14.8 (18H17)) - only "A... | ```suggestion
* iPad Pro 11 (running iPadOS 17.3 (21D50))
``` |
EvilAppleJuice-ESP32 | github_2023 | others | 29 | ckcr4lyf | ckcr4lyf | @@ -89,6 +89,11 @@ void setup() {
BLEDevice::init("AirPods 69");
+ // Increase BLE Power to 9dBm (MAX)
+ esp_ble_tx_power_set(ESP_BLE_PWR_TYPE_DEFAULT, ESP_PWR_LVL_P9);
+ esp_ble_tx_power_set(ESP_BLE_PWR_TYPE_ADV, ESP_PWR_LVL_P9);
+ esp_ble_tx_power_set(ESP_BLE_PWR_TYPE_SCAN ,ESP_PWR_LVL_P9); | Only need to set the power for advertising.
```suggestion
esp_ble_tx_power_set(ESP_BLE_PWR_TYPE_ADV, ESP_PWR_LVL_P9);
```
|
EvilAppleJuice-ESP32 | github_2023 | cpp | 29 | ckcr4lyf | ckcr4lyf | @@ -23,6 +23,11 @@ void setup() {
BLEDevice::init("AirPods 69");
+ // Increase the BLE Power to 9dBm (MAX)
+ esp_ble_tx_power_set(ESP_BLE_PWR_TYPE_DEFAULT, ESP_PWR_LVL_P9);
+ esp_ble_tx_power_set(ESP_BLE_PWR_TYPE_ADV, ESP_PWR_LVL_P9);
+ esp_ble_tx_power_set(ESP_BLE_PWR_TYPE_SCAN ,ESP_PWR_LVL_P9); | Only need to set the power for advertising.
```suggestion
esp_ble_tx_power_set(ESP_BLE_PWR_TYPE_ADV, ESP_PWR_LVL_P9);
```
|
EvilAppleJuice-ESP32 | github_2023 | others | 29 | ckcr4lyf | ckcr4lyf | @@ -10,7 +10,7 @@ Based off of the work of [ronaldstoner](https://github.com/ronaldstoner) in the
Also thanks to [simondankelmann](https://github.com/simondankelmann) for their discoveries in new advertising messages to pop-up new notifications in iOS devices [source](https://github.com/simondankelmann/Bluetooth-LE-... | No RPi support in this repository
```suggestion
With the randomization optimizations it can render an iPhone almost useless with a single ESP32 (a new notification as soon as you close the old one).
``` |
runtime-compat | github_2023 | typescript | 110 | unjs | ascorbic | @@ -1,6 +1,11 @@
-import { runTests } from "../../shared/test.ts";
+import { runTests, formatResults } from "../../shared/test.ts";
import tests from "../../../vendor/tests.json" assert { type: "json" };
import { gpu } from "../../shared/features.ts";
-const data = await runTests(tests, gpu);
+const results = await... | ```suggestion
{ name: "deno", version: Deno.version.deno },
``` |
runtime-compat | github_2023 | others | 110 | unjs | ascorbic | @@ -1,14 +0,0 @@
-#!/bin/sh
-echo "versions<<EOF" | The new script needs to either echo this, or update the GH action to do it. This is why the action is failing |
runtime-compat | github_2023 | others | 110 | unjs | ascorbic | @@ -1,14 +0,0 @@
-#!/bin/sh
-echo "versions<<EOF"
-echo
-echo "- bun: `bun -v`"
-echo "- deno: `deno --version | head -n 1`"
-echo "- edge-light: `pnpm run --filter edge-light-runtime version | tail -n 1`"
-echo "- fastly: `fastly version | head -n 1`"
-echo "- llrt: `llrt -v`"
-echo "- netlify: `netlify -v`"
-echo "- ... | It also needs the "EOF" at the end |
runtime-compat | github_2023 | others | 71 | unjs | pi0 | @@ -86,7 +88,7 @@ const { default: data } = await import(
## Data format
-The data follows the same format as MDN's [`browser-compat-data`](https://github.com/mdn/browser-compat-data), but only includes the `javascript` and `api` keys. Instead of the browser keys in MDN's data, this project uses the runtime keys f... | ```suggestion
The data follows the same format as MDN's [`browser-compat-data`](https://github.com/mdn/browser-compat-data), but only includes the `javascript`, `webassembly` and `api` keys. Instead of the browser keys in MDN's data, this project uses the runtime keys from the [WinterCG runtime key proposal](https://r... |
runtime-compat | github_2023 | others | 71 | unjs | pi0 | @@ -38,27 +40,29 @@ If you want to run the tests for an individual runtime, run `pnpm start` in the
## Limitations
-The tests are only run against the latest stable version of each runtime, so the data only shows whether the feature is supported now. This is because the goal of the project is to track the current ... | Did you find any public docs that links vercel edge to workerd? 😅
BTW i agree and already confirm this differences in reporting which is really important to note 👍 |
runtime-compat | github_2023 | others | 64 | unjs | QuiiBz | @@ -8,6 +8,9 @@
Display APIs compatibility across different JavaScript runtimes. The data is automatically generated, based on MDN [`browser-compat-data`](https://github.com/mdn/browser-compat-data) format using the runtime tests from [`mdn-bcd-collector`](https://github.com/openwebdocs/mdn-bcd-collector). Runtimes ... | ```suggestion
Display APIs compatibility across different JavaScript runtimes. The data is automatically generated, based on MDN [`browser-compat-data`](https://github.com/mdn/browser-compat-data) format using the runtime tests from [`mdn-bcd-collector`](https://github.com/openwebdocs/mdn-bcd-collector).
``` |
runtime-compat | github_2023 | others | 59 | unjs | pi0 | @@ -6,7 +6,7 @@
</h2>
<p class="text-md text-slate-600 max-w-4xl">
Display APIs compatibility across different JavaScript runtimes. The data is retrieved from <ExternalLink
- href="https://github.com/unjs/runtime-compat-data">
+ href="https://github.com/unjs/runtime-compat/tree/... | Do we want to directly link to a specific package if gen scripts are outside? @ascorbic |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.