Datasets:
File size: 3,767 Bytes
45721da | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 | Fix bug preventing full map from rendering when viewport is < 512px <!-- Hello! Thanks for contributing. To help us diagnose your problem quickly, please: - Include a link to a minimal demonstration of the bug. We recommend using https://jsbin.com - Ensure you can reproduce the bug using the latest release. - Check the console for relevant errors and warnings - Only post to report a bug or request a feature. Direct all other questions to https://stackoverflow.com/questions/tagged/mapbox-gl-js --> **mapbox-gl-js version**: master ### Steps to Trigger Behavior 1. Create a map using, e.g., Mapbox Streets, in a div that is smaller than 512x512. 2. Zoom 'all the way out' (i.e. initialize the map to `center: [0, 0], zoom: 0` ### Expected Behavior The whole world is shown. ### Actual Behavior The whole world is not shown. Repro: https://bl.ocks.org/anandthakker/raw/0e9afc1d09356f87449b5ffa3e49bd82/ ## Relevant pre-fix discussion ### Issue #3055 #### Comment at 2019-04-11T02:32:58Z Is preventing the entire world from appearing on small screens expected behavior? I want to show clusters which span the entire world. It's a confusing UX to not have all the pins / clusters appear at once. This is how my map currently looks:  For reference, this is how mapbox.js + Leaflet handled this case:  There are some downsides to showing the full world. Specifically, the grey area above and below the map look strange. I think the ideal option is to add a configuration value for disabling this behavior. #### Comment at 2019-11-15T20:54:20Z @supersteves That's correct. The 512 tile size is an internal architectural detail of GL JS. It is possible to have raster tiles of a different size (the Mapbox Satellite style uses 256 tiles for example) but we effectively scale them up by one so that at `0/0/0` you actually see 4 tiles that form a 512px view of the entire world, as shown below. GL JS isn't set up to display 256x256 tiles that display the entire world.  #### Comment at 2019-11-27T04:20:54Z @supersteves @charliemcgrady @krispy-visokio @juho-hanhimaki @eddydg Thanks for providing your feedback on this issue! We have a proposal up that renders maps with the camera at a negative zoom levels (up to `-2`) in containers <512px when zoomed out all the way: https://github.com/mapbox/mapbox-gl-js/pull/9028 With this change, much more of the world is rendered, but the behavior does not exactly match what's possible on mapbox.js + Leaflet, in part due to the limitations @ryanhamley outlined [here](https://github.com/mapbox/mapbox-gl-js/issues/3055#issuecomment-554152535). I've pasted a few visual examples below. ### Questions: - Would you consider this change to solve enough of your use case such that you don't feel the need to implement additional workarounds? - If not, would you still consider this change to be an improvement from the current behavior? ### Examples: With https://github.com/mapbox/mapbox-gl-js/pull/9028, the amount of the world that's shown depends on the aspect ratio of the viewport in containers <512px. Even when zoomed out all the way, the map will still fill the vertical space of the container. For example:   This would be instead of the following behavior, which was originally requested above:  |