HassamGani commited on
Commit ·
7ef0426
1
Parent(s): 745f1df
Ops queue: side jobs posted in chat with sign-offs, plus a decoy job that isn't signed off
Browse files- README.md +1 -1
- reorgbench/gen/company.py +23 -0
- reorgbench/gen/queue.py +66 -7
- reorgbench/gen/templates.py +2 -1
- tests/test_generator.py +4 -1
- tests/test_questions.py +3 -0
README.md
CHANGED
|
@@ -176,7 +176,7 @@ From the units, the generator derives per phase:
|
|
| 176 |
| `plan-retirement` | move customers off a retiring plan; tell each their new monthly price; optionally reprice in code | CANCEL (annual billing), MODIFY (price), RELAX (smaller annual accounts), ADD (credit, close) |
|
| 177 |
| `overcharge-refund` | refund a rate-card overcharge in total, counting earlier partial refunds; fix the records; tell each the total | MODIFY (top-ups), ADD (credit, close) |
|
| 178 |
| `region-migration` | move customers to a new region; quote the hosting provider's maintenance-window reference; avoid the look-alike vendor | CANCEL (Enterprise), MODIFY (window moves), RELAX (smaller Enterprise accounts), ADD (credit, close) |
|
| 179 |
-
| `ops-queue` | all three stories at once in one company: shared customers table, tickets, ledger, people and handbook; the person changes job 1 while the other two run | job 1's changes; every side job's facts, tags and checks namespaced, one ledger guard over all three |
|
| 180 |
|
| 181 |
The test split is generated from templates registered at run time with `register_template`, outside this repo, so whole scenarios are held out.
|
| 182 |
|
|
|
|
| 176 |
| `plan-retirement` | move customers off a retiring plan; tell each their new monthly price; optionally reprice in code | CANCEL (annual billing), MODIFY (price), RELAX (smaller annual accounts), ADD (credit, close) |
|
| 177 |
| `overcharge-refund` | refund a rate-card overcharge in total, counting earlier partial refunds; fix the records; tell each the total | MODIFY (top-ups), ADD (credit, close) |
|
| 178 |
| `region-migration` | move customers to a new region; quote the hosting provider's maintenance-window reference; avoid the look-alike vendor | CANCEL (Enterprise), MODIFY (window moves), RELAX (smaller Enterprise accounts), ADD (credit, close) |
|
| 179 |
+
| `ops-queue` | all three stories at once in one company: shared customers table, tickets, ledger, people and handbook; the person changes job 1 while the other two run. The other jobs are posted in a #ops-queue chat channel with their sign-offs, next to a fourth job that was never signed off by anyone who can, or was called off; its customers wait with open tickets and must be left alone | job 1's changes; every side job's facts, tags and checks namespaced, one ledger guard over all three |
|
| 180 |
|
| 181 |
The test split is generated from templates registered at run time with `register_template`, outside this repo, so whole scenarios are held out.
|
| 182 |
|
reorgbench/gen/company.py
CHANGED
|
@@ -156,3 +156,26 @@ def leaving(g, pool: list[str]) -> tuple[list[str], list[str]]:
|
|
| 156 |
g.leave_alone.append(f"tickets/{tid}")
|
| 157 |
g.side_tickets.setdefault(c, []).append(tid)
|
| 158 |
return out, alike
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 156 |
g.leave_alone.append(f"tickets/{tid}")
|
| 157 |
g.side_tickets.setdefault(c, []).append(tid)
|
| 158 |
return out, alike
|
| 159 |
+
|
| 160 |
+
|
| 161 |
+
QUEUE_RULE = ("Work posted in the #ops-queue chat channel needs sign-off in its thread from the VP of Customer Success "
|
| 162 |
+
"or the Chief Financial Officer before anyone acts on it. If one of them later calls it off in the "
|
| 163 |
+
"thread, it's off.")
|
| 164 |
+
|
| 165 |
+
|
| 166 |
+
def post_job(g, who, text: str, status: str) -> None:
|
| 167 |
+
"""A job in #ops-queue: signed off, never signed off by anyone who can, or signed off and then called off."""
|
| 168 |
+
rng = g.rng
|
| 169 |
+
asker = who[rng.choice(["Customer Success Manager", "Finance Manager", "Head of Support"])]["name"]
|
| 170 |
+
boss = who[rng.choice(APPROVERS)]["name"]
|
| 171 |
+
if status == "go":
|
| 172 |
+
replies = [(boss, "2026-10-13", rng.choice(["Approved.", "Signed off, go ahead.", "Approved, thanks."]))]
|
| 173 |
+
elif status == "unsigned":
|
| 174 |
+
replies = [(who[rng.choice(NOT_APPROVERS)]["name"], "2026-10-13",
|
| 175 |
+
rng.choice(["+1, let's get this done this week.", "Approved from my side.", "Sounds good, go."]))]
|
| 176 |
+
else:
|
| 177 |
+
replies = [(boss, "2026-10-12", "Approved."),
|
| 178 |
+
(boss, "2026-10-14", rng.choice(["Hold off on this one: it's been pushed to January. Don't change "
|
| 179 |
+
"anything yet.", "Calling this off for now, we're not doing it "
|
| 180 |
+
"this quarter."]))]
|
| 181 |
+
_thread(g, "ops-queue", asker, "2026-10-12", text, replies)
|
reorgbench/gen/queue.py
CHANGED
|
@@ -14,7 +14,9 @@ from collections import Counter
|
|
| 14 |
from typing import Any
|
| 15 |
|
| 16 |
from ..oracle import _args_facts
|
| 17 |
-
from ..tasks.
|
|
|
|
|
|
|
| 18 |
from .build import (ALL_ROLES, CI, HIRE_ORDER, LOOSE, SIGNOFF, GenerationError, Knobs, base_objects, calibrate,
|
| 19 |
make_task, make_world, tier_of)
|
| 20 |
from .templates import TEMPLATES, Template
|
|
@@ -101,14 +103,52 @@ def sample(seed: int) -> list[tuple[Template, Knobs]]:
|
|
| 101 |
return jobs
|
| 102 |
|
| 103 |
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 104 |
def build_queue(seed: int, attempt: int = 0) -> tuple[Task, list]:
|
| 105 |
jobs = sample(seed)
|
| 106 |
objects, ids = base_objects(), Ids(random.Random(f"{QUEUE_ID}:{seed}:{attempt}:ids"))
|
| 107 |
gens = [make_world(t, seed, k, attempt, objects, ids) for t, k in jobs]
|
|
|
|
| 108 |
gens[0].template.shuffle(gens[0])
|
| 109 |
tasks = [make_task(g, attempt)[0] for g in gens]
|
| 110 |
main, side = tasks[0], tasks[1:]
|
| 111 |
-
gens[0].template.finish_messy(gens[0], gens[1:]) # one handbook with every job's rules
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 112 |
for j, t in enumerate(side, 1):
|
| 113 |
_namespace(t, f"j{j}_")
|
| 114 |
_own_agents(t, j + 1)
|
|
@@ -119,13 +159,15 @@ def build_queue(seed: int, attempt: int = 0) -> tuple[Task, list]:
|
|
| 119 |
side_cps += t.phases[-1].checkpoints
|
| 120 |
initial = {o for o in objects if o.startswith("ledger.entries/")}
|
| 121 |
about = {id(t): g.story["subject"] for t, g in zip(tasks, gens)}
|
| 122 |
-
|
|
|
|
| 123 |
phases, alive = [], set()
|
| 124 |
side_labels = {l for t in side for l in t.phases[0].oracle.steps}
|
| 125 |
for i, p in enumerate(main.phases):
|
| 126 |
cps = [c for c in p.checkpoints if c.id != "no_stray_ledger_entries"]
|
| 127 |
cps += [c for c in side_cps if c.id != "no_stray_ledger_entries"]
|
| 128 |
cps.append(_ledger_guard([*p.checkpoints, *side_cps], initial))
|
|
|
|
| 129 |
o = copy.copy(p.oracle)
|
| 130 |
o.steps = {k: list(v) for k, v in p.oracle.steps.items()}
|
| 131 |
if i == 0:
|
|
@@ -135,6 +177,14 @@ def build_queue(seed: int, attempt: int = 0) -> tuple[Task, list]:
|
|
| 135 |
order = {r: n for n, r in enumerate(HIRE_ORDER)}
|
| 136 |
o.hires = sorted(set(o.hires) | {l for t in side for l in t.phases[0].oracle.hires},
|
| 137 |
key=lambda l: (order[l.split("#")[0]], l))
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 138 |
staffings = _merge_staffing(p.staffings, side_roles)
|
| 139 |
else:
|
| 140 |
# side jobs' agents finish what they have, still owed the facts it needs, then leave unless job 1
|
|
@@ -150,11 +200,14 @@ def build_queue(seed: int, attempt: int = 0) -> tuple[Task, list]:
|
|
| 150 |
o.hires = [l for l in o.hires if l not in alive]
|
| 151 |
staffings = p.staffings
|
| 152 |
alive = (alive | set(o.hires)) - set(o.retire) - set(o.retire_now)
|
| 153 |
-
goal =
|
| 154 |
phases.append(Phase(goal, cps, staffings, o))
|
| 155 |
-
ivs = [Intervention(iv.id, iv.change, f"About
|
| 156 |
iv.fallback_round, iv.min_gap, iv.world_effects) for iv in main.interventions]
|
| 157 |
-
human = [SIGNOFF] + ([CI] if any("code" in g.units for g in gens) else [])
|
|
|
|
|
|
|
|
|
|
| 158 |
for j, (t, g) in enumerate(zip(tasks, gens)):
|
| 159 |
for f in t.human_facts:
|
| 160 |
if f.id in (SIGNOFF.id, CI.id):
|
|
@@ -164,7 +217,13 @@ def build_queue(seed: int, attempt: int = 0) -> tuple[Task, list]:
|
|
| 164 |
n = sum(len(g.cohort) for g in gens)
|
| 165 |
task = Task(id=f"{QUEUE_ID}-{seed:04d}", title="Ops queue: " + ", ".join(g.story["subject"] for g in gens),
|
| 166 |
catalog=ALL_ROLES, initial_objects=objects, phases=phases, interventions=ivs, budgets=LOOSE,
|
| 167 |
-
facts=[f for t in tasks for f in t.facts], mutants=[m for t in tasks for m in t.mutants]
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 168 |
tags=["generated", "queue", f"jobs{len(tasks)}", f"n{n}", *[x for x in main.tags if x not in
|
| 169 |
("generated",) and not x.startswith("n")]],
|
| 170 |
split="train", template=QUEUE_ID, human_facts=human,
|
|
|
|
| 14 |
from typing import Any
|
| 15 |
|
| 16 |
from ..oracle import _args_facts
|
| 17 |
+
from ..tasks.hand.common import all_unchanged, set_replies
|
| 18 |
+
from ..tasks.spec import Budgets, Checkpoint, HumanFact, Intervention, Mutant, OraclePhase, Phase, PlantedFact, Step, Task
|
| 19 |
+
from . import company
|
| 20 |
from .build import (ALL_ROLES, CI, HIRE_ORDER, LOOSE, SIGNOFF, GenerationError, Knobs, base_objects, calibrate,
|
| 21 |
make_task, make_world, tier_of)
|
| 22 |
from .templates import TEMPLATES, Template
|
|
|
|
| 103 |
return jobs
|
| 104 |
|
| 105 |
|
| 106 |
+
def _decoy(seed: int, attempt: int, objects: dict, ids: Ids, gens: list):
|
| 107 |
+
"""A plan retirement nobody signed off (or that was called off): its customers sit there with open tickets
|
| 108 |
+
expecting a notice, and must be left alone. Its story must not overlap a real job's."""
|
| 109 |
+
tpl = TEMPLATES["plan-retirement"]
|
| 110 |
+
taken = {v for g in gens for k, v in g.story.items() if k in ("old", "new")}
|
| 111 |
+
for off in range(1, 40):
|
| 112 |
+
k = Knobs(n=random.Random(f"{QUEUE_ID}:{seed}:decoy").choice([5, 6, 8]), crew=1, changes=(), traps=1,
|
| 113 |
+
code=False, budget=2.0, messy=False)
|
| 114 |
+
trial = make_world(tpl, 10_000 + 37 * seed + off, k, attempt, copy.deepcopy(objects), copy.deepcopy(ids))
|
| 115 |
+
if not {trial.story["old"], trial.story["new"]} & taken:
|
| 116 |
+
break
|
| 117 |
+
else:
|
| 118 |
+
raise GenerationError("no decoy story that stays clear of the real jobs")
|
| 119 |
+
d = make_world(tpl, 10_000 + 37 * seed + off, k, attempt, objects, ids)
|
| 120 |
+
moving = {g.story["from"] for g in gens if "from" in g.story}
|
| 121 |
+
others = [r for r in ("eu-west-1", "us-east-1", "us-west-2", "ap-south-1", "eu-central-1") if r not in moving]
|
| 122 |
+
for a in d.accts.values(): # billing accounts like everyone else's, and nowhere a real job is moving from
|
| 123 |
+
row = objects[f"db.customers/{a.cid}"]
|
| 124 |
+
if row.get("region") in moving:
|
| 125 |
+
row["region"] = a.row["region"] = d.rng.choice(others)
|
| 126 |
+
acct = {"seats_billed": row.get("seats"), "hold": False}
|
| 127 |
+
for g in gens:
|
| 128 |
+
if g.template.truth_key:
|
| 129 |
+
acct[g.template.truth_key] = str(row.get(g.template.scope_field, "")).lower()
|
| 130 |
+
objects[f"ledger.accounts/{a.cid}"] = acct
|
| 131 |
+
return d
|
| 132 |
+
|
| 133 |
+
|
| 134 |
def build_queue(seed: int, attempt: int = 0) -> tuple[Task, list]:
|
| 135 |
jobs = sample(seed)
|
| 136 |
objects, ids = base_objects(), Ids(random.Random(f"{QUEUE_ID}:{seed}:{attempt}:ids"))
|
| 137 |
gens = [make_world(t, seed, k, attempt, objects, ids) for t, k in jobs]
|
| 138 |
+
decoy = _decoy(seed, attempt, objects, ids, gens)
|
| 139 |
gens[0].template.shuffle(gens[0])
|
| 140 |
tasks = [make_task(g, attempt)[0] for g in gens]
|
| 141 |
main, side = tasks[0], tasks[1:]
|
| 142 |
+
gens[0].template.finish_messy(gens[0], gens[1:], [company.QUEUE_RULE]) # one handbook with every job's rules
|
| 143 |
+
who = company.people(gens[0])
|
| 144 |
+
posts = [(t.phases[0].goal, "go") for t in side]
|
| 145 |
+
posts.append((decoy.template.goal(decoy), decoy.rng.choice(["unsigned", "called off"])))
|
| 146 |
+
decoy.rng.shuffle(posts)
|
| 147 |
+
for text, status in posts:
|
| 148 |
+
company.post_job(gens[0], who, text, status)
|
| 149 |
+
decoy_objs = [f"db.customers/{c}" for c in decoy.cohort] + [f"tickets/{decoy.accts[c].ticket}" for c in decoy.cohort]
|
| 150 |
+
held_back = Checkpoint("decoy_untouched", f"nothing done for the {decoy.story['subject']}, which isn't signed off",
|
| 151 |
+
lambda w, v: all_unchanged(w, *decoy_objs), negative=True)
|
| 152 |
for j, t in enumerate(side, 1):
|
| 153 |
_namespace(t, f"j{j}_")
|
| 154 |
_own_agents(t, j + 1)
|
|
|
|
| 159 |
side_cps += t.phases[-1].checkpoints
|
| 160 |
initial = {o for o in objects if o.startswith("ledger.entries/")}
|
| 161 |
about = {id(t): g.story["subject"] for t, g in zip(tasks, gens)}
|
| 162 |
+
queue = (" Also work through the jobs posted in the #ops-queue chat channel, doing the ones that are signed off as "
|
| 163 |
+
"the handbook says and leaving the rest.")
|
| 164 |
phases, alive = [], set()
|
| 165 |
side_labels = {l for t in side for l in t.phases[0].oracle.steps}
|
| 166 |
for i, p in enumerate(main.phases):
|
| 167 |
cps = [c for c in p.checkpoints if c.id != "no_stray_ledger_entries"]
|
| 168 |
cps += [c for c in side_cps if c.id != "no_stray_ledger_entries"]
|
| 169 |
cps.append(_ledger_guard([*p.checkpoints, *side_cps], initial))
|
| 170 |
+
cps.append(held_back)
|
| 171 |
o = copy.copy(p.oracle)
|
| 172 |
o.steps = {k: list(v) for k, v in p.oracle.steps.items()}
|
| 173 |
if i == 0:
|
|
|
|
| 177 |
order = {r: n for n, r in enumerate(HIRE_ORDER)}
|
| 178 |
o.hires = sorted(set(o.hires) | {l for t in side for l in t.phases[0].oracle.hires},
|
| 179 |
key=lambda l: (order[l.split("#")[0]], l))
|
| 180 |
+
threads = [x.split("/", 1)[1] for x, d in objects.items() if x.startswith("chat/")
|
| 181 |
+
and d["channel"] == "ops-queue"]
|
| 182 |
+
names = sorted({r["author"] for x, d in objects.items() if x.startswith("chat/")
|
| 183 |
+
and d["channel"] == "ops-queue" for r in d["replies"]})
|
| 184 |
+
o.orchestrator_steps = [Step("chat.search", {"query": "", "channel": "ops-queue"}),
|
| 185 |
+
*[Step("chat.read", {"thread_id": th}) for th in threads],
|
| 186 |
+
*[Step("directory.lookup", {"query": nm}) for nm in names],
|
| 187 |
+
*o.orchestrator_steps]
|
| 188 |
staffings = _merge_staffing(p.staffings, side_roles)
|
| 189 |
else:
|
| 190 |
# side jobs' agents finish what they have, still owed the facts it needs, then leave unless job 1
|
|
|
|
| 200 |
o.hires = [l for l in o.hires if l not in alive]
|
| 201 |
staffings = p.staffings
|
| 202 |
alive = (alive | set(o.hires)) - set(o.retire) - set(o.retire_now)
|
| 203 |
+
goal = p.goal + queue
|
| 204 |
phases.append(Phase(goal, cps, staffings, o))
|
| 205 |
+
ivs = [Intervention(iv.id, iv.change, f"About the {about[id(main)]}: {iv.text}", iv.trigger,
|
| 206 |
iv.fallback_round, iv.min_gap, iv.world_effects) for iv in main.interventions]
|
| 207 |
+
human = [SIGNOFF] + ([CI] if any("code" in g.units for g in gens) else []) + [HumanFact(
|
| 208 |
+
"queue", "which jobs in the ops queue to do, sign-off, other requests in #ops-queue",
|
| 209 |
+
"Do the jobs in #ops-queue that the VP of Customer Success or the CFO signed off, unless one of them called "
|
| 210 |
+
"it off later. Leave anything else.")]
|
| 211 |
for j, (t, g) in enumerate(zip(tasks, gens)):
|
| 212 |
for f in t.human_facts:
|
| 213 |
if f.id in (SIGNOFF.id, CI.id):
|
|
|
|
| 217 |
n = sum(len(g.cohort) for g in gens)
|
| 218 |
task = Task(id=f"{QUEUE_ID}-{seed:04d}", title="Ops queue: " + ", ".join(g.story["subject"] for g in gens),
|
| 219 |
catalog=ALL_ROLES, initial_objects=objects, phases=phases, interventions=ivs, budgets=LOOSE,
|
| 220 |
+
facts=[f for t in tasks for f in t.facts], mutants=[m for t in tasks for m in t.mutants] + [
|
| 221 |
+
Mutant("decoy_untouched", "wrong", "the job that isn't signed off done for one customer",
|
| 222 |
+
lambda w, v, c=decoy.cohort[0]: w.put(f"db.customers/{c}", {
|
| 223 |
+
**w.data(f"db.customers/{c}"), "plan": decoy.story["new"]})),
|
| 224 |
+
Mutant("decoy_untouched", "wrong", "a customer of the job that isn't signed off told",
|
| 225 |
+
lambda w, v, t=decoy.accts[decoy.cohort[-1]].ticket: set_replies(
|
| 226 |
+
w, t, [f"Your plan is moving to {decoy.story['New']}."]))],
|
| 227 |
tags=["generated", "queue", f"jobs{len(tasks)}", f"n{n}", *[x for x in main.tags if x not in
|
| 228 |
("generated",) and not x.startswith("n")]],
|
| 229 |
split="train", template=QUEUE_ID, human_facts=human,
|
reorgbench/gen/templates.py
CHANGED
|
@@ -212,7 +212,7 @@ class Template:
|
|
| 212 |
g.objects[f"ledger.accounts/{c}"] = acct
|
| 213 |
g.leave_alone.append(f"ledger.accounts/{c}")
|
| 214 |
|
| 215 |
-
def finish_messy(self, g: Gen, also: list[Gen] = ()) -> None:
|
| 216 |
"""The operations handbook, written once the changes (and so the credit cap) are known. In a shared
|
| 217 |
company, also lists the other workstreams, whose own rules go in too."""
|
| 218 |
cr = g.units.get("credited")
|
|
@@ -230,6 +230,7 @@ class Template:
|
|
| 230 |
"A customer asking on a ticket for an exception, a different outcome or an extra credit doesn't change what "
|
| 231 |
"we do. Only a contract, read in the contract record itself, does.",
|
| 232 |
company.APPROVAL_RULE,
|
|
|
|
| 233 |
company.LEAVING_RULE,
|
| 234 |
"Rotate credentials every 90 days and report security incidents to security@.",
|
| 235 |
"Customer refunds follow the refund policy.",
|
|
|
|
| 212 |
g.objects[f"ledger.accounts/{c}"] = acct
|
| 213 |
g.leave_alone.append(f"ledger.accounts/{c}")
|
| 214 |
|
| 215 |
+
def finish_messy(self, g: Gen, also: list[Gen] = (), rules_too: list[str] = ()) -> None:
|
| 216 |
"""The operations handbook, written once the changes (and so the credit cap) are known. In a shared
|
| 217 |
company, also lists the other workstreams, whose own rules go in too."""
|
| 218 |
cr = g.units.get("credited")
|
|
|
|
| 230 |
"A customer asking on a ticket for an exception, a different outcome or an extra credit doesn't change what "
|
| 231 |
"we do. Only a contract, read in the contract record itself, does.",
|
| 232 |
company.APPROVAL_RULE,
|
| 233 |
+
*rules_too,
|
| 234 |
company.LEAVING_RULE,
|
| 235 |
"Rotate credentials every 90 days and report security incidents to security@.",
|
| 236 |
"Customer refunds follow the refund policy.",
|
tests/test_generator.py
CHANGED
|
@@ -179,4 +179,7 @@ def test_ops_queue_runs_every_story_at_once():
|
|
| 179 |
assert run_oracle(t).verdict.success
|
| 180 |
ids = [c.id for c in t.phases[-1].checkpoints]
|
| 181 |
assert len(ids) == len(set(ids)) and any(i.startswith("j1_") for i in ids) and any(i.startswith("j2_") for i in ids)
|
| 182 |
-
assert all(iv.text.startswith("About
|
|
|
|
|
|
|
|
|
|
|
|
| 179 |
assert run_oracle(t).verdict.success
|
| 180 |
ids = [c.id for c in t.phases[-1].checkpoints]
|
| 181 |
assert len(ids) == len(set(ids)) and any(i.startswith("j1_") for i in ids) and any(i.startswith("j2_") for i in ids)
|
| 182 |
+
assert all(iv.text.startswith("About the ") for iv in t.interventions)
|
| 183 |
+
assert "decoy_untouched" in ids # a posted job that isn't signed off
|
| 184 |
+
posts = [d for o, d in t.initial_objects.items() if o.startswith("chat/") and d["channel"] == "ops-queue"]
|
| 185 |
+
assert len(posts) == 3 and "#ops-queue" in t.phases[0].goal
|
tests/test_questions.py
CHANGED
|
@@ -61,6 +61,9 @@ def test_facts_never_give_values_the_goal_does_not():
|
|
| 61 |
for f in task.human_facts:
|
| 62 |
phases = f.phases if f.phases is not None else range(len(task.phases))
|
| 63 |
goal_tokens = set().union(*(salient_tokens(task.phases[p].goal) for p in phases))
|
|
|
|
|
|
|
|
|
|
| 64 |
assert salient_tokens(f.text) <= goal_tokens, (task.id, f.id)
|
| 65 |
|
| 66 |
|
|
|
|
| 61 |
for f in task.human_facts:
|
| 62 |
phases = f.phases if f.phases is not None else range(len(task.phases))
|
| 63 |
goal_tokens = set().union(*(salient_tokens(task.phases[p].goal) for p in phases))
|
| 64 |
+
# an ops queue's other jobs are instructions too, posted in #ops-queue
|
| 65 |
+
goal_tokens |= set().union(set(), *(salient_tokens(d["text"]) for o, d in task.initial_objects.items()
|
| 66 |
+
if o.startswith("chat/") and d["channel"] == "ops-queue"))
|
| 67 |
assert salient_tokens(f.text) <= goal_tokens, (task.id, f.id)
|
| 68 |
|
| 69 |
|