M5: install permission prompt UI; M6: runtime tracking-protection policy

app/src/main/java/dev/nova/browser/BrowserActivity.kt

@@ -19,8 +19,10 @@ import androidx.compose.ui.unit.dp
 import androidx.compose.ui.viewinterop.AndroidView
 import org.mozilla.geckoview.GeckoResult
 import org.mozilla.geckoview.GeckoRuntime
+import org.mozilla.geckoview.GeckoRuntimeSettings
 import org.mozilla.geckoview.GeckoView
 import org.mozilla.geckoview.WebExtension
+import org.mozilla.geckoview.WebExtensionController
 
 class BrowserActivity : ComponentActivity() {
 
@@ -35,11 +37,46 @@ class BrowserActivity : ComponentActivity() {
         super.onCreate(savedInstanceState)
 
         if (runtime == null) {
-            runtime = GeckoRuntime.create(this)
+            // M6: strict-ish tracking protection at the runtime level; sessions
+            // additionally opt in via GeckoSessionSettings.useTrackingProtection.
+            runtime = GeckoRuntime.create(
+                this,
+                GeckoRuntimeSettings.Builder()
+                    .trackingProtectionPolicy(GeckoSession.TrackingProtectionPolicy.RECOMMENDED)
+                    .build()
+            )
             // Layer 2 of the dev console: desktop Firefox DevTools can attach
             // via about:debugging over USB / Wi-Fi. GV 147 API:
             // GeckoRuntimeSettings.setRemoteDebuggingEnabled(boolean).
             runtime!!.settings.setRemoteDebuggingEnabled(true)
+
+            // M5: installs REQUIRE a prompt delegate (GV refuses otherwise).
+            // The user decision is surfaced as a Compose dialog through
+            // TabManager.pendingInstall.
+            runtime!!.webExtensionController.setPromptDelegate(
+                object : WebExtensionController.PromptDelegate {
+                    override fun onInstallPromptRequest(
+                        extension: WebExtension,
+                        permissions: Array<out String>,
+                        origins: Array<out String>,
+                        dataCollectionPermissions: Array<out String>,
+                    ): GeckoResult<WebExtension.PermissionPromptResponse> {
+                        val result = GeckoResult<WebExtension.PermissionPromptResponse>()
+                        val name = extension.metaData?.name ?: extension.id
+                        tabManager.pendingInstall.value = TabManager.InstallPrompt(
+                            name = name,
+                            permissions = permissions.toList(),
+                            origins = origins.toList(),
+                        ) { allow ->
+                            tabManager.pendingInstall.value = null
+                            result.complete(
+                                WebExtension.PermissionPromptResponse(allow, false, false)
+                            )
+                        }
+                        return result
+                    }
+                }
+            )
         }
         tabManager = TabManager(runtime!!, this)
 
@@ -129,10 +166,40 @@ class BrowserActivity : ComponentActivity() {
         // M3 add-ons manager state
         var extensions by remember { mutableStateOf<List<TabManager.ExtInfo>>(emptyList()) }
         var addonsLoading by remember { mutableStateOf(false) }
+        var installMessage by remember { mutableStateOf("") }
 
         val loading = activeId != null && tabManager.loadingStates[activeId!!] == true
         val progress = activeId?.let { tabManager.progressStates[it] } ?: 0
 
+        // M5: install permission prompt — visible over every screen.
+        val pendingInstall by tabManager.pendingInstall
+        pendingInstall?.let { prompt ->
+            AlertDialog(
+                onDismissRequest = { prompt.respond(false) },
+                title = { Text("Install \"${prompt.name}\"?") },
+                text = {
+                    Column {
+                        if (prompt.permissions.isEmpty()) {
+                            Text("This add-on requests no special permissions.")
+                        } else {
+                            Text("It requests access to:")
+                            prompt.permissions.forEach { Text("• $it") }
+                        }
+                        if (prompt.origins.isNotEmpty()) {
+                            Text("Site access:")
+                            prompt.origins.forEach { Text("• $it") }
+                        }
+                    }
+                },
+                confirmButton = {
+                    TextButton(onClick = { prompt.respond(true) }) { Text("Install") }
+                },
+                dismissButton = {
+                    TextButton(onClick = { prompt.respond(false) }) { Text("Cancel") }
+                },
+            )
+        }
+
         // Re-attach the active session whenever we come back from any overlay.
         LaunchedEffect(activeId, trayOpen, addonsOpen, consoleOpen) {
             val id = activeId ?: return@LaunchedEffect
@@ -175,7 +242,13 @@ class BrowserActivity : ComponentActivity() {
                 extensions = extensions,
                 enabledStates = tabManager.extensionStates,
                 loading = addonsLoading,
+                installMessage = installMessage,
+                onInstall = { input ->
+                    installMessage = "Installing…"
+                    tabManager.installFromAmo(input) { ok, msg -> installMessage = msg }
+                },
                 onToggle = { id, enabled -> tabManager.setExtensionEnabled(id, enabled) {} },
+                onUninstall = { id -> tabManager.uninstallExtension(id) {} },
                 onDismiss = { addonsOpen = false },
             )
             return