Add files using upload-large-folder tool
Browse filesThis view is limited to 50 files because it contains too many changes. See raw diff
- issues/AsFigo_pyslint_pr166 +42 -0
- issues/FPGA-MAFIA_fpga_mafia_pr451 +58 -0
- issues/FPGA-MAFIA_fpga_mafia_pr655 +30 -0
- issues/HiSA-Team_Simply-V_pr102 +27 -0
- issues/HiSA-Team_Simply-V_pr166 +24 -0
- issues/MiSTer-devel_Saturn_MiSTer_pr249 +40 -0
- issues/MiSTer-devel_ao486_MiSTer_pr172 +21 -0
- issues/MiSTle-Dev_MiSTeryNano_pr99 +46 -0
- issues/Panda-Cores_PandaZero_pr7 +34 -0
- issues/SpiNNakerManchester_spif_pr8 +39 -0
- issues/StanfordVLSI_dragonphy2_pr141 +36 -0
- issues/UTOSS_risc-v_pr107 +35 -0
- issues/UTOSS_risc-v_pr59 +41 -0
- issues/UTOSS_risc-v_pr80 +37 -0
- issues/UTOSS_risc-v_pr81 +36 -0
- issues/UTOSS_risc-v_pr85 +30 -0
- issues/YosysHQ_picorv32_pr9 +40 -0
- issues/aolofsson_oh_pr110 +19 -0
- issues/aolofsson_oh_pr58 +38 -0
- issues/apfaudio_eurorack-pmod_pr36 +25 -0
- issues/bensampson5_libsv_pr109 +57 -0
- issues/bespoke-silicon-group_basejump_stl_pr392 +21 -0
- issues/bespoke-silicon-group_basejump_stl_pr735 +28 -0
- issues/black-parrot_black-parrot_pr1089 +32 -0
- issues/chili-chips-ba_openeye-CamSI_pr15 +20 -0
- issues/chili-chips-ba_openeye-CamSI_pr26 +23 -0
- issues/chili-chips-ba_openeye-CamSI_pr30 +37 -0
- issues/chipsalliance_Cores-VeeR-EL2_pr363 +27 -0
- issues/chipsalliance_caliptra-ss_pr838 +23 -0
- issues/darklife_darkriscv_pr95 +28 -0
- issues/dawsonjon_fpu_pr16 +36 -0
- issues/gtaylormb_opl3_fpga_pr51 +24 -0
- issues/hdl-util_hdmi_pr16 +33 -0
- issues/hdl-util_hdmi_pr21 +37 -0
- issues/hdl-util_hdmi_pr29 +25 -0
- issues/jotego_jt12_pr64 +23 -0
- issues/jotego_jtcores_pr1111 +22 -0
- issues/jotego_jtcores_pr1169 +25 -0
- issues/jotego_jtcores_pr1279 +22 -0
- issues/jotego_jtcores_pr634 +25 -0
- issues/jotego_jtcores_pr960 +22 -0
- issues/lowRISC_ibex_pr2269 +31 -0
- issues/merledu_azadi-soc_pr14 +19 -0
- issues/merledu_azadi-soc_pr2 +25 -0
- issues/muneeb-mbytes_pulpino__spi_master__ip_verification_pr39 +52 -0
- issues/nand2mario_nestang_pr75 +36 -0
- issues/olofk_serv_pr107 +33 -0
- issues/openhwgroup_core-v-verif_pr2585 +34 -0
- issues/openhwgroup_core-v-xif_pr139 +25 -0
- issues/openhwgroup_cv-hpdcache_pr48 +26 -0
issues/AsFigo_pyslint_pr166
ADDED
|
@@ -0,0 +1,42 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# VLT: no clocking blocks in interface
|
| 2 |
+
|
| 3 |
+
- Source URL: https://github.com/AsFigo/pyslint/issues/165
|
| 4 |
+
|
| 5 |
+
Verilator does not support clocking block based driving (as of today). Add a rule to check.
|
| 6 |
+
|
| 7 |
+
## PR Content from GitHub
|
| 8 |
+
|
| 9 |
+
# PR Summary
|
| 10 |
+
|
| 11 |
+
**PR Title:** Added rule for CB check for Verilator issue 165
|
| 12 |
+
|
| 13 |
+
**PR Number:** #166
|
| 14 |
+
|
| 15 |
+
**Status:** Merged
|
| 16 |
+
|
| 17 |
+
**Author:** svenka3
|
| 18 |
+
|
| 19 |
+
**Merge Date:** December 6, 2023
|
| 20 |
+
|
| 21 |
+
---
|
| 22 |
+
|
| 23 |
+
## PR Description Body
|
| 24 |
+
|
| 25 |
+
The PR description was not fully visible in the provided content. Only a reference appears:
|
| 26 |
+
|
| 27 |
+
**Comment by svenka3:**
|
| 28 |
+
"Fixes #165"
|
| 29 |
+
|
| 30 |
+
---
|
| 31 |
+
|
| 32 |
+
## Linked Issue
|
| 33 |
+
|
| 34 |
+
**Issue #165 Title:** VLT: no clocking blocks in interface
|
| 35 |
+
|
| 36 |
+
The issue details were not included in the available content, but the PR was designed to address this specific Verilator-related constraint.
|
| 37 |
+
|
| 38 |
+
---
|
| 39 |
+
|
| 40 |
+
## Additional Context
|
| 41 |
+
|
| 42 |
+
The pull request contained 1 commit (ea905ff) that was merged into the main branch. The change implements a rule to check for clocking blocks within interfaces, addressing a Verilator linting requirement.
|
issues/FPGA-MAFIA_fpga_mafia_pr451
ADDED
|
@@ -0,0 +1,58 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# Remove the Parameter override from the build.
|
| 2 |
+
|
| 3 |
+
- Source URL: https://github.com/FPGA-MAFIA/fpga_mafia/issues/441
|
| 4 |
+
|
| 5 |
+
https://github.com/FPGA-MAFIA/fpga_mafia/blob/931deaa13c92a1fe5d29dee95ba23c76531a68f2/build.py#L241C16-L241C16
|
| 6 |
+
|
| 7 |
+
I think there is room for creating a script that can override the parameter value by name - both in source (AKA rtl) and in verif
|
| 8 |
+
|
| 9 |
+
The way it should work is as following:
|
| 10 |
+
In the cfg file add a field that is called "parameter_override"
|
| 11 |
+
``` json
|
| 12 |
+
{
|
| 13 |
+
"I_MEM_OFFSET": 0,
|
| 14 |
+
"I_MEM_LENGTH": 65536,
|
| 15 |
+
"D_MEM_OFFSET": 65536,
|
| 16 |
+
"D_MEM_LENGTH": 61440,
|
| 17 |
+
"crt0_file" : "crt0_mini_rv32e.S",
|
| 18 |
+
"rv32_gcc" : "rv32e -mabi=ilp32e",
|
| 19 |
+
"name" : "rv32e",
|
| 20 |
+
"rtl_parameter_override" : {
|
| 21 |
+
"RF_NUM_MSB" : 31,
|
| 22 |
+
"RF_NUM_LSB" : 0,
|
| 23 |
+
"OTHER_EXAMPLE" : 31
|
| 24 |
+
},
|
| 25 |
+
"verif_pkg_parameter_override" : {
|
| 26 |
+
"TIMEOUT" : 1000000,
|
| 27 |
+
"OTHER_EXAMPLE" : 65403540
|
| 28 |
+
}
|
| 29 |
+
}
|
| 30 |
+
```
|
| 31 |
+
|
| 32 |
+
Then in the "build" call a new script that you need to create that accepts the list of parameters you need to change.
|
| 33 |
+
Make sure use correct regular expression so it overrides only the "parameter <name> = value" instances
|
| 34 |
+
|
| 35 |
+
The scipt will search, find and replace the values that are mentioned in the cfg json file.
|
| 36 |
+
The scipt will also log the info by printing to the screen what he found, where, and what he has changed.
|
| 37 |
+
|
| 38 |
+
During the find replace - add a comment in the line of parameter
|
| 39 |
+
Example:
|
| 40 |
+
```systemverilog
|
| 41 |
+
parameter EXAMPLE = 15; // Note: This line was inserted using parameter override script
|
| 42 |
+
```
|
| 43 |
+
|
| 44 |
+
*Note:*
|
| 45 |
+
This Parameter change will actually change the value of the RTL!!
|
| 46 |
+
This is fine - as long as we test correctly the different parameter variations in the workflow.
|
| 47 |
+
|
| 48 |
+
This is not the best solution because this may cause many redundant commit changes in the git. (the Change in Value is tracked in the git add/commit flow)
|
| 49 |
+
But i think for us - this is a good solution.
|
| 50 |
+
(We are not really expected to manually change the RTL parameters very often. but we want to make sure they are correct)
|
| 51 |
+
|
| 52 |
+
|
| 53 |
+
I will note that the alternative is override the parameter value in the command line (simular to what i just added) but i have some trouble with overriding specific values in the param_pkg.
|
| 54 |
+
Another good alternative is to pass the parameter in the instance of each module -> but this also can get annoying.
|
| 55 |
+
I think will need to this to the most common parameter overrides so we can simply intergrade different version of the same module in the same system. (similar to what we did with the RF_NUM_MSB which is getting override in the module instance)
|
| 56 |
+
|
| 57 |
+
I think you can do this fairly simple
|
| 58 |
+
Let me know if you have any questions
|
issues/FPGA-MAFIA_fpga_mafia_pr655
ADDED
|
@@ -0,0 +1,30 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# Cache - support partiol read/write (byte enable)
|
| 2 |
+
|
| 3 |
+
- Source URL: https://github.com/FPGA-MAFIA/fpga_mafia/issues/583
|
| 4 |
+
|
| 5 |
+
Cache - support partial read/write (byte enable)
|
| 6 |
+
LHU, LBU, LW,LH,LB SW,SH,SB
|
| 7 |
+
Also, support signed and unsigned extends for the memory load request.
|
| 8 |
+
|
| 9 |
+
PR Title: modify chach_tasks.vh to support random partial reads and writes
|
| 10 |
+
PR Number: #655
|
| 11 |
+
Status: Merged
|
| 12 |
+
Repository: FPGA-MAFIA/fpga_mafia
|
| 13 |
+
|
| 14 |
+
Description:
|
| 15 |
+
No formal description was provided by the author.
|
| 16 |
+
|
| 17 |
+
Comments:
|
| 18 |
+
amichai-bd (May 28, 2024):
|
| 19 |
+
"Small refactor into a single 'Case'"
|
| 20 |
+
The reviewer noted a code consolidation effort with an accompanying image reference.
|
| 21 |
+
|
| 22 |
+
amichai-bd (May 28, 2024):
|
| 23 |
+
"I will also note that the verification env for this Cache is not really good.. It takes a long time to build and simulate - i suspect its due to something wring we did here.. Also a lot of code is duplicated - we should be able to use parameters to have different flavors of similar tasks."
|
| 24 |
+
The reviewer raised concerns about verification environment performance and code duplication, suggesting future refactoring opportunities.
|
| 25 |
+
|
| 26 |
+
Linked Issue:
|
| 27 |
+
#583 - "Cache - support partiol read/write (byte enable)" (Closed by this PR)
|
| 28 |
+
|
| 29 |
+
Commits Overview:
|
| 30 |
+
13 commits were merged, including initial test additions, byte offset support for D_CACHE, partial read/write handling, and byte enable offset fixes across fill requests.
|
issues/HiSA-Team_Simply-V_pr102
ADDED
|
@@ -0,0 +1,27 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# [bugfix/sync_pbus_interrupts] Add synchronizers for PBUS interrupts
|
| 2 |
+
|
| 3 |
+
- Source URL: https://github.com/HiSA-Team/Simply-V/issues/101
|
| 4 |
+
|
| 5 |
+
## Issue Title
|
| 6 |
+
[bugfix/sync_pbus_interrupts] Add synchronizers for PBUS interrupts
|
| 7 |
+
|
| 8 |
+
## Issue Description
|
| 9 |
+
During CDC (#91) we forgot to re-synchronize PBUS outgoing interrupts to the MAIN_CLOCK_DOMAIN.
|
| 10 |
+
|
| 11 |
+
This could be fixed by adding a NUM_IRQ-wide xpm_cdc_async_rst in pbus between int_o and each peripheral interrupt, instead of just assigning them as in the prior implementation.
|
| 12 |
+
|
| 13 |
+
Additionally, here we could also fix unassigned int_o bits.
|
| 14 |
+
|
| 15 |
+
## Issue Comments
|
| 16 |
+
None visible.
|
| 17 |
+
|
| 18 |
+
## Issue Metadata
|
| 19 |
+
- Status: Closed (via PR #102)
|
| 20 |
+
- Assignee: DOTTORM5
|
| 21 |
+
- Milestone: MCU release
|
| 22 |
+
- Author: MaistoV
|
| 23 |
+
- Date Opened: April 8, 2025
|
| 24 |
+
|
| 25 |
+
## Linked Issues / PRs
|
| 26 |
+
- PR #102 — fix
|
| 27 |
+
- Refers back to #91 (prior CDC work)
|
issues/HiSA-Team_Simply-V_pr166
ADDED
|
@@ -0,0 +1,24 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# [feature/rvv/ara] Integrate PULP Ara for RVV support
|
| 2 |
+
|
| 3 |
+
- Source URL: https://github.com/HiSA-Team/Simply-V/issues/119
|
| 4 |
+
|
| 5 |
+
## Issue Title
|
| 6 |
+
[feature/rvv/ara] Integrate PULP Ara for RVV support
|
| 7 |
+
|
| 8 |
+
## Issue Description
|
| 9 |
+
- Need finalized CVA6 support
|
| 10 |
+
- Integrate CVA6 + Ara as a single custom IP (different than standalone cv64a6)
|
| 11 |
+
- Use Ara 2-lanes, matching CVA6 data width, e.g. 64-bits
|
| 12 |
+
|
| 13 |
+
TODO (move to another issue):
|
| 14 |
+
- Ara 4- and 8-lanes: Attach Ara AXI master to HBUS
|
| 15 |
+
|
| 16 |
+
## Issue Comments
|
| 17 |
+
None visible.
|
| 18 |
+
|
| 19 |
+
## Issue Metadata
|
| 20 |
+
- Status: Closed (with associated PR #166)
|
| 21 |
+
- Assignee: MaistoV
|
| 22 |
+
|
| 23 |
+
## Linked Issues / PRs
|
| 24 |
+
- PR #166 — addresses this feature request
|
issues/MiSTer-devel_Saturn_MiSTer_pr249
ADDED
|
@@ -0,0 +1,40 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# [FEATURE REQUEST] (Shuttle) Mouse support
|
| 2 |
+
|
| 3 |
+
- Source URL: https://github.com/MiSTer-devel/Saturn_MiSTer/issues/146
|
| 4 |
+
|
| 5 |
+
Some users have asked on the Discord if it would be possible to support the Shuttle mouse (or even just a more basic mouse) on the core in the future.
|
| 6 |
+
|
| 7 |
+
---
|
| 8 |
+
|
| 9 |
+
## Pull Request
|
| 10 |
+
|
| 11 |
+
**PR Title:** Shuttle mouse support
|
| 12 |
+
|
| 13 |
+
**PR Number:** #249
|
| 14 |
+
|
| 15 |
+
**Status:** Merged
|
| 16 |
+
|
| 17 |
+
**Merged by:** srg320 on Sep 18, 2024
|
| 18 |
+
|
| 19 |
+
### Description
|
| 20 |
+
|
| 21 |
+
The pull request implements mouse support for Saturn games. Key features include:
|
| 22 |
+
|
| 23 |
+
- Maps USB mice to player 1/player 2 Saturn Shuttle mouse functionality
|
| 24 |
+
- Fixes joypad analog stick behavior when used as a mouse
|
| 25 |
+
- Enables input merging between USB mouse and joypad, allowing seamless switching during gameplay
|
| 26 |
+
- Maps left/middle/right USB mouse buttons to corresponding Shuttle Mouse buttons
|
| 27 |
+
- Routes additional USB mouse buttons (side buttons, etc.) to function as the 4th button/Start
|
| 28 |
+
- Scales joypad analog sensitivity to 37.5% to prevent oversensitivity
|
| 29 |
+
|
| 30 |
+
This addresses issue #146, a feature request for Shuttle Mouse support.
|
| 31 |
+
|
| 32 |
+
### Comments
|
| 33 |
+
|
| 34 |
+
**Zet-sensei** (Sep 17, 2024): Confirmed working functionality across multiple titles including Virtua Cop series, Tokimeki Memorial, Sakura Taisen series, Dokyuusei variants, and Policenauts.
|
| 35 |
+
|
| 36 |
+
**rattboi** (Sep 18, 2024): Provided compiled RBF file link for easy access.
|
| 37 |
+
|
| 38 |
+
### Linked Issue
|
| 39 |
+
|
| 40 |
+
**#146:** "[FEATURE REQUEST] (Shuttle) Mouse support" — Successfully closed by this merge.
|
issues/MiSTer-devel_ao486_MiSTer_pr172
ADDED
|
@@ -0,0 +1,21 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# BOOM and Allegro freeze
|
| 2 |
+
|
| 3 |
+
- Source URL: https://github.com/MiSTer-devel/ao486_MiSTer/issues/128
|
| 4 |
+
|
| 5 |
+
Tested in working DOS 6.22 and FreeDOS environments. All versions of BOOM and Allegro (ASETUP, the setup EXE) freeze when I try to run them. It locks at a blinking cursor, I've waited for 10 minutes or so.
|
| 6 |
+
|
| 7 |
+
(DOOM and DOOM2 all work in FreeDOS just fine.)
|
| 8 |
+
|
| 9 |
+
This is the version that comes packaged with other versions of FreeDOS, plus I have tried the classic version of BOOM available online.
|
| 10 |
+
|
| 11 |
+
## Fetched Issue/PR Details
|
| 12 |
+
|
| 13 |
+
Title: BOOM and Allegro freeze (#128)
|
| 14 |
+
|
| 15 |
+
Description: The reporter tested BOOM and Allegro (including the ASETUP setup executable) in working DOS 6.22 and FreeDOS environments. When attempting to run these applications, they "freeze when I try to run them. It locks at a blinking cursor, I've waited for 10 minutes or so." The user notes that DOOM and DOOM2 work fine in FreeDOS. They tested both the version packaged with FreeDOS and the classic BOOM version available online, with the same freezing behavior occurring.
|
| 16 |
+
|
| 17 |
+
Status: Closed (linked to PR #172)
|
| 18 |
+
|
| 19 |
+
Comments: None visible on the page.
|
| 20 |
+
|
| 21 |
+
Linked Issues: Resolving PR #172.
|
issues/MiSTle-Dev_MiSTeryNano_pr99
ADDED
|
@@ -0,0 +1,46 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# Does second hid joystick work?
|
| 2 |
+
|
| 3 |
+
- Source URL: https://github.com/MiSTle-Dev/MiSTeryNano/issues/97
|
| 4 |
+
|
| 5 |
+
I've connected two USB gamepads via raspberry pico and I see in logs JOY0 and JOY1 that send command to FPGA, but when I wanted to test two joysticks in a game. Second one never works, so I tried to understand if second joystick port is supported on FPGA, so started reading Verilog (I'm beginner) and I found in misterynano.sv this:
|
| 6 |
+
|
| 7 |
+
.joystick0(hid_joy),
|
| 8 |
+
.joystick1()
|
| 9 |
+
|
| 10 |
+
Does it means that joystick1 (second joy) is not wired to hid data, which means second joy is not implemented?
|
| 11 |
+
|
| 12 |
+
If my analysis is correct, do you plan to implement second hid joy support?
|
| 13 |
+
|
| 14 |
+
---
|
| 15 |
+
|
| 16 |
+
## Pull Request
|
| 17 |
+
|
| 18 |
+
**PR Title:** Add support for second usb joy and auto switch between joystick and mouse #99
|
| 19 |
+
|
| 20 |
+
**PR Number:** #99
|
| 21 |
+
|
| 22 |
+
**Status:** Merged
|
| 23 |
+
|
| 24 |
+
### Description
|
| 25 |
+
|
| 26 |
+
The contributor's opening statement explains: "Please find changes adding support for second HID joystick. I also added possibility in menu to switch between mapping HID joy to ports."
|
| 27 |
+
|
| 28 |
+
The implementation addresses several goals:
|
| 29 |
+
|
| 30 |
+
1. **Dual joystick support** – Enables configuration where a DB9 joystick operates on port 2 while an HID joystick functions on port 1, allowing two-player gameplay.
|
| 31 |
+
|
| 32 |
+
2. **Input switching mechanism** – Since joystick and mouse cannot operate simultaneously on port 1, the solution activates either device when its button is pressed, disabling the alternate input method.
|
| 33 |
+
|
| 34 |
+
3. **Testing validation** – The author confirmed functionality "works great and tested on Bubble bobble."
|
| 35 |
+
|
| 36 |
+
### Comments
|
| 37 |
+
|
| 38 |
+
**harbaum (Collaborator)** merged the PR and noted: "Again, thanks a lot. And yes, switching between mouse and joystick via the buttons is how those auto-switchers back in the day also worked."
|
| 39 |
+
|
| 40 |
+
**pawelka (Author)** responded: "I haven't know that there where any auto switchers in a past, I switched manually in my Atari."
|
| 41 |
+
|
| 42 |
+
**harbaum** later added: "A fixed a small issue where the register with was 2 bit instead of 1."
|
| 43 |
+
|
| 44 |
+
### Linked Issue
|
| 45 |
+
|
| 46 |
+
This PR closes **Issue #97:** "Does second hid joystick work?"
|
issues/Panda-Cores_PandaZero_pr7
ADDED
|
@@ -0,0 +1,34 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# Dbg module
|
| 2 |
+
|
| 3 |
+
Instance: Panda-Cores_PandaZero_pr7
|
| 4 |
+
Source: https://github.com/Panda-Cores/PandaZero/pull/7
|
| 5 |
+
Fetched: 2026-05-03
|
| 6 |
+
Repository: Panda-Cores/PandaZero
|
| 7 |
+
Pull request: #7
|
| 8 |
+
Author: GorgeousWalrus
|
| 9 |
+
State: closed
|
| 10 |
+
Base branch: master
|
| 11 |
+
Head branch: dbg_module
|
| 12 |
+
Created: 2020-08-02
|
| 13 |
+
Updated: 2020-08-02
|
| 14 |
+
Closed: 2020-08-02
|
| 15 |
+
Merged: 2020-08-02
|
| 16 |
+
|
| 17 |
+
## PR Title
|
| 18 |
+
Dbg module
|
| 19 |
+
|
| 20 |
+
## PR Description
|
| 21 |
+
Debug module improved, wishbone on newest state.
|
| 22 |
+
|
| 23 |
+
## PR Comments
|
| 24 |
+
|
| 25 |
+
**GorgeousWalrus** (Aug 2, 2020):
|
| 26 |
+
"Debug module improved, wishbone on newest state"
|
| 27 |
+
|
| 28 |
+
## Linked Issues
|
| 29 |
+
|
| 30 |
+
**Issue #5: Upgrade Wishbone**
|
| 31 |
+
common repo has new wishbone interfaces, upgrade time!
|
| 32 |
+
|
| 33 |
+
**Issue #6: upgrade debug module**
|
| 34 |
+
(Closed by this PR; body not available.)
|
issues/SpiNNakerManchester_spif_pr8
ADDED
|
@@ -0,0 +1,39 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# SpiNNaker peripheral output support
|
| 2 |
+
|
| 3 |
+
- Source URL: https://github.com/SpiNNakerManchester/spif/issues/4
|
| 4 |
+
|
| 5 |
+
spif does __not__ currently support SpiNNaker peripheral output.
|
| 6 |
+
|
| 7 |
+
Some of the hardware is already in place:
|
| 8 |
+
|
| 9 |
+
- The SpiNNaker FPGAs __do__ support peripheral output. The routing is done using peripheral routing key and mask registers.
|
| 10 |
+
|
| 11 |
+
- spif demultiplexes SpiNNaker packets into _configuration_ and _peripheral_ streams. Configuration packets are handled by the spif register bank while peripheral packets are simply dumped.
|
| 12 |
+
|
| 13 |
+
|
| 14 |
+
**Where should peripheral output be sent to?**
|
| 15 |
+
|
| 16 |
+
The best option seems to be to send them over Ethernet to a peripheral device at a specified IP address/UDP port. There should be registers to hold these values. These registers should be accessible from SpiNNaker and should also be accessible from the peripheral. SpiNNaker should use the existing spif configuration route. Peripheral devices should send a UDP frame to spif directed at a known UDP port and spif will write the sender IP address and UDP port into these registers.
|
| 17 |
+
|
| 18 |
+
|
| 19 |
+
**When should peripheral output be sent?**
|
| 20 |
+
|
| 21 |
+
A UDP frame sholud be triggered when one of two conditions arises:
|
| 22 |
+
1. the memory buffer holding events fills above a high watermark,
|
| 23 |
+
2. a periodic timer triggers. The timer period should be configurable through a spif register. A default of 2ms seems adequate.
|
| 24 |
+
|
| 25 |
+
|
| 26 |
+
**SpiNNaker packet to peripheral event mapping**
|
| 27 |
+
|
| 28 |
+
It is not clear how spif should map SpiNNaker packet MC keys into peripheral events. Events may even need some form of data value that is carried as SpiNNaker packet payload. Simply reversing the input mapping does __not__ appear to be a good solution.
|
| 29 |
+
|
| 30 |
+
|
| 31 |
+
**spif output pipeline microarchitecture**
|
| 32 |
+
|
| 33 |
+
- spif HW should receive SpiNNaker packets, map them to peripheral events and store them in a memory buffer previously reserved for this purpose by the spif kernel module. The kernel module currently reserves memory for peripheral input only.
|
| 34 |
+
|
| 35 |
+
- spif HW should interrupt spif SW when a UDP frame should be triggered, _i.e._, when one of the conditions listed above is met.
|
| 36 |
+
|
| 37 |
+
- when interrupted, spif SW reads peripheral events from the memory buffer and sends them over Ethernet to the registered IP address and UDP port. It may need to send several UDP frames if the number of events exceeds the frame maximum size.
|
| 38 |
+
|
| 39 |
+
- spif SW for peripheral output could be incorporated into spiffer as an additional thread.
|
issues/StanfordVLSI_dragonphy2_pr141
ADDED
|
@@ -0,0 +1,36 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# Remove combo logic loop in qr_4t1_mux_top
|
| 2 |
+
|
| 3 |
+
- Source URL: https://github.com/StanfordVLSI/dragonphy2/issues/140
|
| 4 |
+
|
| 5 |
+
There is currently a combo logic loop in ``qr_4t1_mux_top``, where ``data`` appears on both the ``RHS`` and ``LHS`` of an ``assign`` statement:
|
| 6 |
+
https://github.com/StanfordVLSI/dragonphy2/blob/1f1c97ba5f52445fe06aa39ac60585e053916806/vlog/chip_src/tx_16t1/qr_4t1_mux_top.sv#L47
|
| 7 |
+
|
| 8 |
+
I believe this was added to prevent glitches if clocks are non-overlapping, but there may be other ways to deal with this, for example given the 4-bit select signal ``{Q, I, QB, IB}``:
|
| 9 |
+
* ``4'b1100`` or ``4'b0100``: choose ``D1MQ``
|
| 10 |
+
* ``4'b0110`` or ``4'b0010``: choose ``D1MI``
|
| 11 |
+
* ``4'b0011`` or ``4'b0001``: choose ``D2MQB``
|
| 12 |
+
* ``4'b1001`` or ``4'b1000``: choose ``D2MIB``
|
| 13 |
+
|
| 14 |
+
However, because this is such a critical block, it would be helpful to think about what the intended digital circuit is, so that we can make sure that is what will be produced by the Verilog.
|
| 15 |
+
|
| 16 |
+
PR title: Combinational loop removed
|
| 17 |
+
|
| 18 |
+
Source: https://github.com/StanfordVLSI/dragonphy2/pull/141
|
| 19 |
+
|
| 20 |
+
PR description:
|
| 21 |
+
No description was provided by the pull request author.
|
| 22 |
+
|
| 23 |
+
Comments:
|
| 24 |
+
- CansWang (October 27, 2020): No additional context provided beyond the PR title.
|
| 25 |
+
- sgherbst (October 28, 2020): "just noticed that the branch was out-of-date so I updated it. If the tests are still passing (will find out in ~1hr), then I'll merge the changes."
|
| 26 |
+
- sgherbst (Approval, October 28, 2020): "LGTM, thanks!"
|
| 27 |
+
|
| 28 |
+
Linked issue:
|
| 29 |
+
- #140 "Remove combo logic loop in qr_4t1_mux_top"
|
| 30 |
+
|
| 31 |
+
Key details:
|
| 32 |
+
- Status: Merged
|
| 33 |
+
- Merge date: October 28, 2020
|
| 34 |
+
- Commits: 2 commits merged
|
| 35 |
+
- Reviewers: sgherbst (approved)
|
| 36 |
+
- Participants: CansWang, sgherbst
|
issues/UTOSS_risc-v_pr107
ADDED
|
@@ -0,0 +1,35 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# Set up basic execution environment for running on DE1-SoC
|
| 2 |
+
|
| 3 |
+
Instance: UTOSS_risc-v_pr107
|
| 4 |
+
Source: https://github.com/UTOSS/risc-v/pull/107
|
| 5 |
+
Fetched: 2026-05-03
|
| 6 |
+
Repository: UTOSS/risc-v
|
| 7 |
+
Pull request: #107
|
| 8 |
+
Author: TheDeepestSpace
|
| 9 |
+
State: closed
|
| 10 |
+
Base branch: main
|
| 11 |
+
Head branch: boris/basic-execution-environment
|
| 12 |
+
Created: 2025-10-31
|
| 13 |
+
Updated: 2025-11-30
|
| 14 |
+
Closed: 2025-11-30
|
| 15 |
+
Merged: 2025-11-30
|
| 16 |
+
|
| 17 |
+
## PR Title
|
| 18 |
+
Set up basic execution environment for running on DE1-SoC
|
| 19 |
+
|
| 20 |
+
## PR Description
|
| 21 |
+
Addresses issues #103 and #104 by establishing two separate execution environments for the project: one for simulation (used by testbenches and RISCOF) and one for the DE1-SoC FPGA deployment target. The core architectural change is extracting the memory (MA) out of the processor core, treating it as a peripheral rather than an internal component. The PR also lays down a basic memory map for the DE1-SoC platform with LEDR MMIO, demonstrating buildable and loadable code as a proof-of-concept. Memory currently infers as general logic; future work targets on-chip SRAM. Pending follow-ups: documentation for building/running on DE1-SoC and overall README/repository organization.
|
| 22 |
+
|
| 23 |
+
## PR Comments
|
| 24 |
+
**TheDeepestSpace** (Oct 31, 2025): Initial submission with the description above. Multiple loading errors prevented some early comments from rendering when the page was fetched.
|
| 25 |
+
|
| 26 |
+
**TheDeepestSpace** (Oct 31, 2025, code review): On the memory-map implementation - "This line breaks the RAM inference when Quartus is synthesizing." Recommended a more advanced memory map with a separated canonical RAM module in a follow-up issue.
|
| 27 |
+
|
| 28 |
+
**TheDeepestSpace** (Nov 25, 2025): "note to self: need to figure out whats up with the ugly stack trace in the silently failing riscof task"
|
| 29 |
+
|
| 30 |
+
The PR contains 32 commits and modifies multiple environment-configuration and source files.
|
| 31 |
+
|
| 32 |
+
## Linked Issues
|
| 33 |
+
- **Issue #103 - "Set up Quartus project"** (closed by this PR)
|
| 34 |
+
Body: "Use Quartus ecosystem to set up a basic project that will compile top module for deployment onto DE1-SoC. Fix any issues stoping synthesis from succeeding."
|
| 35 |
+
- **Issue #104 - "Set up execution environment with basic peripheral"** (also closed by this PR; body not fetched).
|
issues/UTOSS_risc-v_pr59
ADDED
|
@@ -0,0 +1,41 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# lui tb and auipc tb and related FSM changes
|
| 2 |
+
|
| 3 |
+
Instance: UTOSS_risc-v_pr59
|
| 4 |
+
Source: https://github.com/UTOSS/risc-v/pull/59
|
| 5 |
+
Fetched: 2026-05-03
|
| 6 |
+
Repository: UTOSS/risc-v
|
| 7 |
+
Pull request: #59
|
| 8 |
+
Author: houjingl
|
| 9 |
+
State: closed
|
| 10 |
+
Base branch: main
|
| 11 |
+
Head branch: JerryHou/lui
|
| 12 |
+
Created: 2025-09-06
|
| 13 |
+
Updated: 2025-09-07
|
| 14 |
+
Closed: 2025-09-07
|
| 15 |
+
Merged: 2025-09-07
|
| 16 |
+
|
| 17 |
+
## PR Title
|
| 18 |
+
lui tb and auipc tb and related FSM changes
|
| 19 |
+
|
| 20 |
+
## PR Description
|
| 21 |
+
The PR introduces testbenches for the `lui` and `auipc` instructions, alongside modifications to the finite state machine, the instruction decoder, and the datapath needed to support these new instructions.
|
| 22 |
+
|
| 23 |
+
## PR Comments
|
| 24 |
+
**houjingl** (Sep 6, 2025): "Added tb for lui and auipc instructions. Modified the FSM, instruction decoder and datapath to adapt new instructions"
|
| 25 |
+
|
| 26 |
+
**TheDeepestSpace** (Sep 6, 2025): Questioned whether the new instructions should route through the EXECUTEI state for potential pipelining benefits, noting an original similar approach was taken.
|
| 27 |
+
|
| 28 |
+
16 commits in total covered testbench additions, FSM parameter updates, instruction-decoder modifications, and various bug fixes and naming corrections.
|
| 29 |
+
|
| 30 |
+
## Linked Issues
|
| 31 |
+
**Issue #45 - "Implement starter-pack instructions for RISCOF framework"** (this PR contributes `lui` and `auipc`).
|
| 32 |
+
|
| 33 |
+
Issue body (verbatim from the source URL):
|
| 34 |
+
"We need a couple of instructions before we can run the RISCOF arch-test quite, specifically:
|
| 35 |
+
|
| 36 |
+
- [x] `addi` @DanielTaoHuang123 (#50)
|
| 37 |
+
- [x] `auipc` @DanielTaoHuang123 / @houjingl (#59)
|
| 38 |
+
- [x] `lui` @houjingl / @TheDeepestSpace (#56, #59)
|
| 39 |
+
- [x] `srli` @MM871 / @DanielTaoHuang123 (#54)
|
| 40 |
+
- [x] `nop` @MM871 / @TheDeepestSpace / @joon2022park (#63)
|
| 41 |
+
- [x] `or` @TheDeepestSpace (#48)"
|
issues/UTOSS_risc-v_pr80
ADDED
|
@@ -0,0 +1,37 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# Fix some test cases of lb, lbu, lh, lhu
|
| 2 |
+
|
| 3 |
+
Instance: UTOSS_risc-v_pr80
|
| 4 |
+
Source: https://github.com/UTOSS/risc-v/pull/80
|
| 5 |
+
Fetched: 2026-05-03
|
| 6 |
+
Repository: UTOSS/risc-v
|
| 7 |
+
Pull request: #80
|
| 8 |
+
Author: Invisipac
|
| 9 |
+
State: closed
|
| 10 |
+
Base branch: main
|
| 11 |
+
Head branch: load-fixes
|
| 12 |
+
Created: 2025-10-19
|
| 13 |
+
Updated: 2025-10-26
|
| 14 |
+
Closed: 2025-10-26
|
| 15 |
+
Merged: 2025-10-26
|
| 16 |
+
|
| 17 |
+
## PR Title
|
| 18 |
+
Fix some test cases of lb, lbu, lh, lhu
|
| 19 |
+
|
| 20 |
+
## PR Description
|
| 21 |
+
No description provided. Across 5 commits this PR adds explicit `funct3` cases in `top` for the byte/half-word load instructions and corrects the data path so that `lb`, `lbu`, `lh`, and `lhu` produce the expected results.
|
| 22 |
+
|
| 23 |
+
## PR Comments
|
| 24 |
+
No conversation comments were posted on the PR. Commits:
|
| 25 |
+
1. "fix a few of the test cases for the load instructions by adding cases for funct3 in top" (6c33fa5)
|
| 26 |
+
2. "add some comments for funct3" (816b7f7)
|
| 27 |
+
3. "made all load commands work" (8b318ef)
|
| 28 |
+
4. "add some comments" (3d01d6b)
|
| 29 |
+
5. "fixed small typo" (7c697bf)
|
| 30 |
+
|
| 31 |
+
Participants: Invisipac (author), DanielTaoHuang123 (reviewer/merger).
|
| 32 |
+
|
| 33 |
+
## Linked Issues
|
| 34 |
+
**Issue #71 - "Review RISCOF's `RV32I` failures"** (this PR contributes load-instruction fixes).
|
| 35 |
+
|
| 36 |
+
Issue body (verbatim from the source URL):
|
| 37 |
+
"Review latest RISCOF report (see artifacts of `main` branch's CI run) and fix issues individually as you find them."
|
issues/UTOSS_risc-v_pr81
ADDED
|
@@ -0,0 +1,36 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# Fix testcases for sb, sh
|
| 2 |
+
|
| 3 |
+
Instance: UTOSS_risc-v_pr81
|
| 4 |
+
Source: https://github.com/UTOSS/risc-v/pull/81
|
| 5 |
+
Fetched: 2026-05-03
|
| 6 |
+
Repository: UTOSS/risc-v
|
| 7 |
+
Pull request: #81
|
| 8 |
+
Author: DanielTaoHuang123
|
| 9 |
+
State: closed
|
| 10 |
+
Base branch: main
|
| 11 |
+
Head branch: daniel-sb-sh-fix
|
| 12 |
+
Created: 2025-10-26
|
| 13 |
+
Updated: 2025-11-03
|
| 14 |
+
Closed: 2025-11-03
|
| 15 |
+
Merged: 2025-11-03
|
| 16 |
+
|
| 17 |
+
## PR Title
|
| 18 |
+
Fix testcases for sb, sh
|
| 19 |
+
|
| 20 |
+
## PR Description
|
| 21 |
+
"change the WE in MA from 1 bit to 4 bits to support byte level write; change the WE of FSM accordingly; fix sb and sh (fix WD)"
|
| 22 |
+
|
| 23 |
+
This is the follow-up to PR #80 (which fixed `lb`/`lh`/`lhu`). The Memory-Access Write Enable signal is widened from 1 bit to 4 bits to support byte-granularity writes; the FSM is updated accordingly; the `sb` and `sh` store instructions are corrected (including the write-data path). The MemoryLoader module is also enhanced to prepare data for storing into memory, where dataB is the raw word from the CPU and `__tmp_MemData` together with `MemWriteByteAddress` selects which byte to write.
|
| 24 |
+
|
| 25 |
+
## PR Comments
|
| 26 |
+
**TheDeepestSpace** (Nov 2, 2025): Clarified the architectural intent: "MemoryLoader now also prepares the data for storing it into memory...dataB is essentially the raw word from the CPU to write to memory, and `__tmp_MemData` together with `MemWriteByteAddress` tell us exactly which byte to write."
|
| 27 |
+
|
| 28 |
+
**DanielTaoHuang123** (Nov 9, 2025): "yes" (confirming the explanation).
|
| 29 |
+
|
| 30 |
+
Merged by TheDeepestSpace on Nov 3, 2025.
|
| 31 |
+
|
| 32 |
+
## Linked Issues
|
| 33 |
+
**Issue #71 - "Review RISCOF's `RV32I` failures"** (this PR fixes the `sb`/`sh` failures).
|
| 34 |
+
|
| 35 |
+
Issue body (verbatim from the source URL):
|
| 36 |
+
"Review latest RISCOF report (see artifacts of `main` branch's CI run) and fix issues individually as you find them."
|
issues/UTOSS_risc-v_pr85
ADDED
|
@@ -0,0 +1,30 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# Add jalr feature, fix tb issues and add more tb for jal and jalr
|
| 2 |
+
|
| 3 |
+
Instance: UTOSS_risc-v_pr85
|
| 4 |
+
Source: https://github.com/UTOSS/risc-v/pull/85
|
| 5 |
+
Fetched: 2026-05-03
|
| 6 |
+
Repository: UTOSS/risc-v
|
| 7 |
+
Pull request: #85
|
| 8 |
+
Author: RunzeZhu28
|
| 9 |
+
State: closed
|
| 10 |
+
Base branch: main
|
| 11 |
+
Head branch: tony_jalr
|
| 12 |
+
Created: 2025-10-27
|
| 13 |
+
Updated: 2025-10-28
|
| 14 |
+
Closed: 2025-10-28
|
| 15 |
+
Merged: 2025-10-28
|
| 16 |
+
|
| 17 |
+
## PR Title
|
| 18 |
+
Add jalr feature, fix tb issues and add more tb for jal and jalr
|
| 19 |
+
|
| 20 |
+
## PR Description
|
| 21 |
+
No description was provided. The PR adds support for `jalr`, fixes existing testbench issues, and expands tests for both `jal` and `jalr`. Two commits: 9828b2f and 5fef62b.
|
| 22 |
+
|
| 23 |
+
## PR Comments
|
| 24 |
+
**TheDeepestSpace** (Oct 28, 2025): Suggested minimising FSM states to reduce flip-flops. Noted that `JALR_CALC` duplicates `MEMADR` functionality and recommended renaming `JALR_STEP2` to `JALRWB` for consistency. Approved with "Looks great, thanks Tony!"
|
| 25 |
+
|
| 26 |
+
## Linked Issues
|
| 27 |
+
**Issue #71 - "Review RISCOF's `RV32I` failures"** (this PR contributes `jal`/`jalr` fixes).
|
| 28 |
+
|
| 29 |
+
Issue body (verbatim from the source URL):
|
| 30 |
+
"Review latest RISCOF report (see artifacts of `main` branch's CI run) and fix issues individually as you find them."
|
issues/YosysHQ_picorv32_pr9
ADDED
|
@@ -0,0 +1,40 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# Deassert pcpi_valid upon asserting sbreak IRQ
|
| 2 |
+
|
| 3 |
+
Instance: YosysHQ_picorv32_pr9
|
| 4 |
+
Source: https://github.com/YosysHQ/picorv32/pull/9
|
| 5 |
+
Fetched: 2026-05-03
|
| 6 |
+
Repository: YosysHQ/picorv32
|
| 7 |
+
Pull request: #9
|
| 8 |
+
Author: stevekerrison
|
| 9 |
+
State: closed
|
| 10 |
+
Base branch: master
|
| 11 |
+
Head branch: master (stevekerrison/picorv32 fork)
|
| 12 |
+
Created: 2016-05-31
|
| 13 |
+
Updated: 2016-06-01
|
| 14 |
+
Closed: 2016-06-01
|
| 15 |
+
Merged: 2016-06-01
|
| 16 |
+
|
| 17 |
+
## PR Title
|
| 18 |
+
Deassert pcpi_valid upon asserting sbreak IRQ
|
| 19 |
+
|
| 20 |
+
## PR Description
|
| 21 |
+
Addresses issue #8 (incorrect handling of SBREAK / illegal instructions when PCPI is enabled): on `sbreak` / illegal instruction the core now deasserts `pcpi_valid` when raising the SBREAK IRQ, so the next valid PCPI instruction is not mis-flagged as another `sbreak`.
|
| 22 |
+
|
| 23 |
+
The author notes two remaining considerations:
|
| 24 |
+
1. Instructions like `sbreak` take roughly 16 cycles to trigger an IRQ because of PCPI timeout delays; immediate IRQ triggering for these instructions could be useful, though external PCPI modules might handle it differently.
|
| 25 |
+
2. The behaviour of `sbreak` or illegal instructions inside ISRs is not examined here, although trapping seems like the natural answer.
|
| 26 |
+
|
| 27 |
+
## PR Comments
|
| 28 |
+
**stevekerrison** (May 31, 2016): "This fixes #8" along with the two unresolved follow-up considerations described above.
|
| 29 |
+
|
| 30 |
+
The PR was merged on Jun 1, 2016.
|
| 31 |
+
|
| 32 |
+
## Linked Issues
|
| 33 |
+
**Issue #8 - "Incorrect handling of SBREAK/ILLNSN with PCPI"** (closed by this PR).
|
| 34 |
+
|
| 35 |
+
Issue body (verbatim from the source URL):
|
| 36 |
+
"I'm trying to put a minimal example of this together (or a patch if I get there quicker), but won't get a chance until tomorrow. I leave this here for now as a test of my own sanity.
|
| 37 |
+
|
| 38 |
+
If PCPI is enabled and an illegal instruction or `sbreak` occur, upon `retirq`, the signal `pcpi_valid` remains asserted. The eventual effect of this is that when the next valid PCPI instruction comes along, it causes another `SBREAK` IRQ to occur, presumably because the PCPI timeout never got reset.
|
| 39 |
+
|
| 40 |
+
I actually want to handle `ecall`, and I guess I could do it with another PCPI extension, but that seems like a less graceful solution."
|
issues/aolofsson_oh_pr110
ADDED
|
@@ -0,0 +1,19 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# Add "tech config" pass-through for technology-specific GPIO configuration
|
| 2 |
+
|
| 3 |
+
Instance: aolofsson_oh_pr110
|
| 4 |
+
Source: https://github.com/aolofsson/oh/pull/110
|
| 5 |
+
Fetched: 2026-04-26
|
| 6 |
+
Repository: aolofsson/oh
|
| 7 |
+
Pull request: #110
|
| 8 |
+
Author: nmoroze
|
| 9 |
+
State: closed
|
| 10 |
+
Base branch: master
|
| 11 |
+
Head branch: master
|
| 12 |
+
Created: 2021-08-10T14:36:30Z
|
| 13 |
+
Updated: 2021-08-16T02:49:10Z
|
| 14 |
+
Closed: 2021-08-16T02:49:10Z
|
| 15 |
+
Merged: 2021-08-16T02:49:10Z
|
| 16 |
+
|
| 17 |
+
Sorry for the large diff, oh_padring.v had something going on with a mix of tabs and spaces that was screwing up my editor, so I fixed that up.
|
| 18 |
+
|
| 19 |
+
Also, I'm not 100% sold on the name tech_cfg, so happy to take suggestions there.
|
issues/aolofsson_oh_pr58
ADDED
|
@@ -0,0 +1,38 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# Initial Commit of 8b10b Encoder and Decoder
|
| 2 |
+
|
| 3 |
+
Instance: aolofsson_oh_pr58
|
| 4 |
+
Source: https://github.com/aolofsson/oh/pull/58
|
| 5 |
+
Fetched: 2026-04-26
|
| 6 |
+
Repository: aolofsson/oh
|
| 7 |
+
Pull request: #58
|
| 8 |
+
Author: prasadp4009
|
| 9 |
+
State: closed
|
| 10 |
+
Base branch: master
|
| 11 |
+
Head branch: master
|
| 12 |
+
Created: 2016-03-25T23:08:19Z
|
| 13 |
+
Updated: 2016-03-25T23:19:44Z
|
| 14 |
+
Closed: 2016-03-25T23:19:44Z
|
| 15 |
+
Merged: 2016-03-25T23:19:44Z
|
| 16 |
+
|
| 17 |
+
## PR Title
|
| 18 |
+
Initial Commit of 8b10b Encoder and Decoder
|
| 19 |
+
|
| 20 |
+
## PR Description
|
| 21 |
+
Signed-off-by: Prasad Pandit <prasadp4009@gmail.com>
|
| 22 |
+
|
| 23 |
+
## PR Comments
|
| 24 |
+
|
| 25 |
+
**prasadp4009** (Mar 25, 2016):
|
| 26 |
+
"Both 8b10b Encoder and Decoder use K-map optimized logic. Further improvements are on way with pipeline to improve performance. Current synthesis report explains the both modules perform at 385MHz on Virtex II. Suggestions and improvements are welcome."
|
| 27 |
+
|
| 28 |
+
**aolofsson** (Mar 25, 2016):
|
| 29 |
+
"Awesome!"
|
| 30 |
+
|
| 31 |
+
## Merge Information
|
| 32 |
+
- Merged by: aolofsson
|
| 33 |
+
- Merge commit: 0142315
|
| 34 |
+
- Source branch: prasadp4009:master
|
| 35 |
+
- Target branch: aolofsson:master
|
| 36 |
+
|
| 37 |
+
## Linked Issues
|
| 38 |
+
None identified in the pull request content.
|
issues/apfaudio_eurorack-pmod_pr36
ADDED
|
@@ -0,0 +1,25 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# VCO example seems broken after clocking rewrite
|
| 2 |
+
|
| 3 |
+
All the examples seem to work fine after switching to 48kHz all round and rewriting the clocking architecture -- except for the VCO example. It smells like a timing issue and this deserves investigation.
|
| 4 |
+
|
| 5 |
+
- Actually this example still seems to work on the ECP5, it's only broken on ICE40
|
| 6 |
+
|
| 7 |
+
## PR Content from GitHub
|
| 8 |
+
|
| 9 |
+
# Pull Request #36: cores/vco - Fix and Modularize VCO Example
|
| 10 |
+
|
| 11 |
+
## PR Title
|
| 12 |
+
"cores/vco: fix and modularize vco example"
|
| 13 |
+
|
| 14 |
+
## PR Description
|
| 15 |
+
The PR description is not fully visible in the provided content, but the PR appears to address issues with the VCO (Voltage Controlled Oscillator) example implementation.
|
| 16 |
+
|
| 17 |
+
## Comments
|
| 18 |
+
**vk2seb** (Sep 17, 2023):
|
| 19 |
+
"Seems to fix #35"
|
| 20 |
+
|
| 21 |
+
## Linked Issue
|
| 22 |
+
**Issue #35 Title:** "VCO example seems broken after clocking rewrite"
|
| 23 |
+
|
| 24 |
+
## Status
|
| 25 |
+
The pull request was merged on September 17, 2023. However, it was subsequently reverted on September 19, 2023 (commit 7a3af8c) due to place-and-route dependency issues on the icebreaker platform. The changes were later reapplied in October 2023 (commits 20a6b1e and d497970).
|
issues/bensampson5_libsv_pr109
ADDED
|
@@ -0,0 +1,57 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# 8b/10b decoder improvements
|
| 2 |
+
|
| 3 |
+
- Source URL: https://github.com/bensampson5/libsv/issues/107
|
| 4 |
+
|
| 5 |
+
Feature list
|
| 6 |
+
- Add input clock, reset, and move running disparity to an internal calculation
|
| 7 |
+
- Add enable input ``i_en``
|
| 8 |
+
- Register outputs
|
| 9 |
+
|
| 10 |
+
Additional TODO
|
| 11 |
+
- Fix testbench
|
| 12 |
+
- Update docs for 8b10b decoder (take a look at 8b10b encoder)
|
| 13 |
+
|
| 14 |
+
## PR Content from GitHub
|
| 15 |
+
|
| 16 |
+
# PR Summary: 8b/10b Decoder Improvements
|
| 17 |
+
|
| 18 |
+
**PR Title:** 8b/10b decoder improvements #109
|
| 19 |
+
|
| 20 |
+
**Status:** Merged (November 28, 2021)
|
| 21 |
+
|
| 22 |
+
---
|
| 23 |
+
|
| 24 |
+
## PR Description
|
| 25 |
+
|
| 26 |
+
This pull request addresses issue #107 and implements several enhancements to the 8b/10b decoder module:
|
| 27 |
+
|
| 28 |
+
**Features Added:**
|
| 29 |
+
- Input clock, reset signals, with running disparity moved to internal calculation
|
| 30 |
+
- Enable input (`i_en`)
|
| 31 |
+
- Registered outputs
|
| 32 |
+
|
| 33 |
+
**Pending Tasks:**
|
| 34 |
+
- Fix testbench
|
| 35 |
+
- Update documentation (referencing the 8b10b encoder documentation as a model)
|
| 36 |
+
|
| 37 |
+
---
|
| 38 |
+
|
| 39 |
+
## PR Activity Timeline
|
| 40 |
+
|
| 41 |
+
**Commits:** 4 commits were merged
|
| 42 |
+
- Implementation of new 8b/10b decoder features
|
| 43 |
+
- Format fixes
|
| 44 |
+
- Linting corrections
|
| 45 |
+
- Documentation updates
|
| 46 |
+
|
| 47 |
+
**Labels:** enhancement (New feature or request)
|
| 48 |
+
|
| 49 |
+
**Assignee:** bensampson5 (repository owner)
|
| 50 |
+
|
| 51 |
+
**Linked Issue:** Successfully closes issue #107 regarding 8b/10b decoder improvements
|
| 52 |
+
|
| 53 |
+
---
|
| 54 |
+
|
| 55 |
+
## Discussion
|
| 56 |
+
|
| 57 |
+
The PR shows standard GitHub workflow activity with commit additions, label application, and self-assignment by the author. No reviewer comments or additional discussion beyond the initial feature list was documented.
|
issues/bespoke-silicon-group_basejump_stl_pr392
ADDED
|
@@ -0,0 +1,21 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# [bsg_tag_client] is widht_p=1 supported?
|
| 2 |
+
|
| 3 |
+
https://github.com/bespoke-silicon-group/basejump_stl/blob/1862705e8bbb59c84dc9d942a8b1b31874f60406/bsg_tag/bsg_tag_client.v#L94
|
| 4 |
+
|
| 5 |
+
when width_p=1,
|
| 6 |
+
```
|
| 7 |
+
|
| 8 |
+
Error-[IRIPS] Illegal range in part select
|
| 9 |
+
/mnt/users/ssd1/homes/dcjung/bsg/basejump_stl/bsg_tag/bsg_tag_client.v, 94
|
| 10 |
+
The range of the part select is illegal:
|
| 11 |
+
tag_data_r[(width_p - 1):1]
|
| 12 |
+
|
| 13 |
+
|
| 14 |
+
Lint-[CAWM-L] Width mismatch
|
| 15 |
+
/mnt/users/ssd1/homes/dcjung/bsg/basejump_stl/bsg_tag/bsg_tag_client.v, 94
|
| 16 |
+
Continuous assignment width mismatch
|
| 17 |
+
1 bits (lhs) versus 3 bits (rhs).
|
| 18 |
+
Source info: assign tag_data_shift = {param_r, tag_data_r[(width_p - 1):1]};
|
| 19 |
+
|
| 20 |
+
|
| 21 |
+
```
|
issues/bespoke-silicon-group_basejump_stl_pr735
ADDED
|
@@ -0,0 +1,28 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# Define BSG_HIDE_FROM_SYNTHESIS_EXPR macro
|
| 2 |
+
|
| 3 |
+
Instance: bespoke-silicon-group_basejump_stl_pr735
|
| 4 |
+
Source: https://github.com/bespoke-silicon-group/basejump_stl/pull/735
|
| 5 |
+
Fetched: 2026-04-26
|
| 6 |
+
Repository: bespoke-silicon-group/basejump_stl
|
| 7 |
+
Pull request: #735
|
| 8 |
+
Author: taylor-bsg
|
| 9 |
+
State: closed
|
| 10 |
+
Base branch: master
|
| 11 |
+
Head branch: taylor-bsg-patch-4
|
| 12 |
+
Created: 2025-09-23T17:48:57Z
|
| 13 |
+
Updated: 2025-09-23T17:49:24Z
|
| 14 |
+
Closed: 2025-09-23T17:49:24Z
|
| 15 |
+
Merged: 2025-09-23T17:49:24Z
|
| 16 |
+
|
| 17 |
+
PR Title: Define BSG_HIDE_FROM_SYNTHESIS_EXPR macro
|
| 18 |
+
|
| 19 |
+
PR Description:
|
| 20 |
+
Add macro for conditional synthesis hiding expression
|
| 21 |
+
|
| 22 |
+
PR Comments:
|
| 23 |
+
(No additional discussion comments beyond the commit message.)
|
| 24 |
+
|
| 25 |
+
Linked Issues:
|
| 26 |
+
The PR indicates "Successfully merging this pull request may close these issues," but no specific issue titles or bodies are visible.
|
| 27 |
+
|
| 28 |
+
Status: Merged on Sep 23, 2025 by taylor-bsg.
|
issues/black-parrot_black-parrot_pr1089
ADDED
|
@@ -0,0 +1,32 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
PR Title: Fix nonsynth cache UC store hit bug
|
| 2 |
+
|
| 3 |
+
PR Description:
|
| 4 |
+
The PR fixes issue #1086. According to the description: "Root cause was implementation of the nonsynth cache used in the ME testbench. Uncached stores targeting valid cache blocks were not self-invalidating the block, causing the store to get lost if targeted by following cacheable load. Bug is only present in the ME testbench, not in a real BP system."
|
| 5 |
+
|
| 6 |
+
PR Comments:
|
| 7 |
+
- dpetrisko (May 4, 2022): "Great find!"
|
| 8 |
+
|
| 9 |
+
Linked Issue #1086: Referenced as fixed by this PR (issue body not provided in the page content).
|
| 10 |
+
|
| 11 |
+
Metadata:
|
| 12 |
+
- Author: muwyse
|
| 13 |
+
- Reviewer/Approver: dpetrisko
|
| 14 |
+
- Labels: bug, testing
|
| 15 |
+
- Merged: May 4, 2022
|
| 16 |
+
|
| 17 |
+
Original local content (issue body context):
|
| 18 |
+
Area
|
| 19 |
+
me_regress testing, ucode
|
| 20 |
+
|
| 21 |
+
Current behavior
|
| 22 |
+
me_regress fails under current CI for:
|
| 23 |
+
bp_cce.e_bp_test_multicore_half_cce_ucode_cfg.msi.set_test.mixed.sim.cce.none.err
|
| 24 |
+
bp_cce.e_bp_test_multicore_half_cce_ucode_cfg.msi-nonspec.set_test.mixed.sim.cce.none.err
|
| 25 |
+
|
| 26 |
+
I've tried to rewind SDK/ucode and RTL and no combination seems to pass within reasonable scope
|
| 27 |
+
|
| 28 |
+
Verification
|
| 29 |
+
me_regress passing
|
| 30 |
+
|
| 31 |
+
Additional Context
|
| 32 |
+
https://gitlab.com/black-parrot/black-parrot/-/jobs/2343047561/artifacts/browse/bp_me/syn/reports/vcs/
|
issues/chili-chips-ba_openeye-CamSI_pr15
ADDED
|
@@ -0,0 +1,20 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# issue#2 - Testbench for I2C subsystem
|
| 2 |
+
|
| 3 |
+
## Writing Testbench for I2C Part of Our Camera
|
| 4 |
+
|
| 5 |
+
We need to write a testbench for the I2C part of our camera. For this purpose, we have utilized the `cocotbext-i2c` library. Specifically, we used only the `I2CDevice.py` module from this library, which emulates the slave device. The master part, however, was implemented directly in RTL.
|
| 6 |
+
|
| 7 |
+
### Challenges Encountered:
|
| 8 |
+
1. **SDA/SCL Bidirectional Signals**:
|
| 9 |
+
- The primary challenge was handling the bidirectional (inout) nature of the SDA and SCL lines.
|
| 10 |
+
- To resolve this, we had to define these lines as follows in our RTL code:
|
| 11 |
+
```verilog
|
| 12 |
+
inout tri1 i2c_sda,
|
| 13 |
+
inout tri1 i2c_scl,
|
| 14 |
+
```
|
| 15 |
+
- This specific declaration was necessary for cocotb to properly drive these signals.
|
| 16 |
+
|
| 17 |
+
2. **Simulator Selection**:
|
| 18 |
+
- Another significant issue was choosing the appropriate simulator.
|
| 19 |
+
- Verilator, which is commonly used, does not support 'Z (high impedance) and 'X (unknown) values, supporting only log0 and log1.
|
| 20 |
+
- This limitation made it unsuitable for our testbench, requiring us to explore alternative simulators that can handle these signal states.
|
issues/chili-chips-ba_openeye-CamSI_pr26
ADDED
|
@@ -0,0 +1,23 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# issue#7 - Enable HiRez Sony camera
|
| 2 |
+
|
| 3 |
+
# Add support for the 4-lane "OneInch" camera (Sony IMX283)
|
| 4 |
+
## Description:
|
| 5 |
+
|
| 6 |
+
The next project milestone is to expand the existing 2-lane CSI to 4-lane, and establish video datapath for this particular high-end camera. This milestone encompasses the following tasks:
|
| 7 |
+
|
| 8 |
+
### 1. Upgrade simulation environment to allow both 2 and 4-lane data paths, with 4 video formats: RAW8, RAW10, RAW12, RAW14
|
| 9 |
+
- [x] CSI BFM
|
| 10 |
+
- [x] Testbench and relevant sim scripts
|
| 11 |
+
- [ ] Time permitting, also add 1-lane option
|
| 12 |
+
|
| 13 |
+
### 2. Extend RTL from only RAW8 to also support RAW10, RAW12, and RAW14 image formats
|
| 14 |
+
- [x] RAW2RGB block -- If it's too messy to support all 4 formats in one file, implement it in 4 separate files
|
| 15 |
+
- [x] Integration
|
| 16 |
+
|
| 17 |
+
### 3. End-to-end simulations
|
| 18 |
+
- [x] Verify old and new data path options in functional simulation through the entirety of video processing chain
|
| 19 |
+
|
| 20 |
+
### 4. Validate OneInch sensor and new data path on the real hardware
|
| 21 |
+
- [x] Work out I2C configurations for the camera (as our sim setup does not cover that part)
|
| 22 |
+
- [x] Check video pipeline stages from CSI all the way to HDMI. If needed, use Chipscope ILA for debug
|
| 23 |
+
- [x] Crate a new demo, similar to the earlier for 2-lane RPi camera, but now with higher resolution Sony IMX294 camera
|
issues/chili-chips-ba_openeye-CamSI_pr30
ADDED
|
@@ -0,0 +1,37 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
PR Title: Updated i2c part according to issue#30
|
| 2 |
+
|
| 3 |
+
PR Description:
|
| 4 |
+
(No description was provided by the author.)
|
| 5 |
+
|
| 6 |
+
PR Comments:
|
| 7 |
+
- Juninho99 (Oct 29, 2024): No comment text provided.
|
| 8 |
+
- Juninho99: Requested review from chili-chips-ba and self-assigned the PR.
|
| 9 |
+
- chili-chips-ba (Nov 6, 2024): Merged the pull request into main.
|
| 10 |
+
|
| 11 |
+
Linked Issue Title: "Implementing Variable Pauses After I2C Register Writes in i2c_ctrl Module #29"
|
| 12 |
+
Status: Closed (by this PR)
|
| 13 |
+
|
| 14 |
+
Linked Issue body (issue#9):
|
| 15 |
+
# issue#9 - Implementing Variable Pauses After I2C Register Writes in i2c_ctrl Module
|
| 16 |
+
|
| 17 |
+
## Description:
|
| 18 |
+
According to the camera's specification (**Sony IMX283**), after certain registers are written, there needs to be a pause of a few milliseconds before proceeding to the next set of registers.
|
| 19 |
+
|
| 20 |
+
## Objective:
|
| 21 |
+
Modify the existing `i2c_ctrl` module and `i2c_top` module to implement variable pauses after specific I2C register writes, as specified by the camera's requirements.
|
| 22 |
+
|
| 23 |
+
## Problem Statement:
|
| 24 |
+
The challenge is to introduce variable pauses after writing certain registers, as required by the camera's specification. These pauses are not periodic and occur only after specific registers. The pauses need to be controlled dynamically, allowing for different durations specified in milliseconds.
|
| 25 |
+
|
| 26 |
+
## Proposed Solution:
|
| 27 |
+
- Modify the `i2c_init.mem` file to include the pause duration for each register write.
|
| 28 |
+
- Update the `i2c_data_init` array in the `i2c_top` module to read the pause durations along with register addresses and data.
|
| 29 |
+
- Adjust the `i2c_ctrl` module to implement a **WAIT** state that counts the required pause duration using nested counters, avoiding resource-intensive multiplication.
|
| 30 |
+
- Ensure that pauses are dynamically controlled based on the data read from i2c_init.mem.
|
| 31 |
+
|
| 32 |
+
Key Details:
|
| 33 |
+
The PR contains 2 commits:
|
| 34 |
+
1. "Updated i2c part according to issue" (d6b71f5)
|
| 35 |
+
2. "Changed names of .mem files" (3c69f4b)
|
| 36 |
+
|
| 37 |
+
The changes were merged from the `issue#9` branch into `main` on November 6, 2024.
|
issues/chipsalliance_Cores-VeeR-EL2_pr363
ADDED
|
@@ -0,0 +1,27 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# Request to review Lint Issues in Veer RTL
|
| 2 |
+
|
| 3 |
+
- Source URL: https://github.com/chipsalliance/Cores-VeeR-EL2/issues/166
|
| 4 |
+
|
| 5 |
+
Hi, I am filling this issue to review couple of Lint issues inside Veer RTL.
|
| 6 |
+
|
| 7 |
+
1. In **el2_veer.sv** file, below highlighted signals are read but never set.
|
| 8 |
+
|
| 9 |
+
assign ifu_axi_bready_int = pt.BUILD_AHB_LITE ? **ifu_axi_bready_ahb** : ifu_axi_bready;
|
| 10 |
+
assign lsu_axi_bready_int = pt.BUILD_AHB_LITE ? **lsu_axi_bready_ahb** : lsu_axi_bready;
|
| 11 |
+
assign sb_axi_bready_int = pt.BUILD_AHB_LITE ? **sb_axi_bready_ahb** : sb_axi_bready;
|
| 12 |
+
|
| 13 |
+
|
| 14 |
+
2. Output signal highlighted below is never set.
|
| 15 |
+
|
| 16 |
+
Output '**ifu_bp_fa_index_f**' is never set. (veer_el2/rtl/ifu/el2_ifu_bp_ctl.sv)
|
| 17 |
+
Output '**exu_mp_pkt.br_start_error**' is never set. (veer_el2/rtl/exu/el2_exu.sv)
|
| 18 |
+
Output '**exu_mp_pkt.br_error**' is never set. (veer_el2/rtl/exu/el2_exu.sv)
|
| 19 |
+
Output '**exu_mp_pkt.prett[31:1]**' is never set. (veer_el2/rtl/exu/el2_exu.sv)
|
| 20 |
+
Output '**lsu_ld_data_r[31:0]**' is never set. (veer_el2/rtl/lsu/el2_lsu_dccm_ctl.sv)
|
| 21 |
+
Output '**dccm_rdata_lo_r[31:0]**' is never set. (veer_el2/rtl/lsu/el2_lsu_dccm_ctl.sv)
|
| 22 |
+
Output '**dccm_rdata_hi_r[31:0]**' is never set. (veer_el2/rtl/lsu/el2_lsu_dccm_ctl.sv)
|
| 23 |
+
Output '**dccm_data_ecc_lo_r[6:0]**' is never set. (veer_el2/rtl/lsu/el2_lsu_dccm_ctl.sv)
|
| 24 |
+
Output '**dccm_data_ecc_hi_r[6:0]**' is never set. (veer_el2/rtl/lsu/el2_lsu_dccm_ctl.sv)
|
| 25 |
+
Output '**ic_parerr[1:0]**' is never set. (veer_el2/rtl/el2_mem.sv)
|
| 26 |
+
|
| 27 |
+
Request to clean up the code to keep Lint happy.
|
issues/chipsalliance_caliptra-ss_pr838
ADDED
|
@@ -0,0 +1,23 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# [Question] Regarding FcAxiFilterDaiAccessError_A assertion
|
| 2 |
+
|
| 3 |
+
- Source URL: https://github.com/chipsalliance/caliptra-ss/issues/833
|
| 4 |
+
|
| 5 |
+
Hello calipra team,
|
| 6 |
+
|
| 7 |
+
I have found FcAxiFilterDaiAccessError_A assertion error during caliptra_ss_fuse_ctrl_axi_id test when a valid write follows a discard write.
|
| 8 |
+
|
| 9 |
+
https://github.com/chipsalliance/caliptra-ss/blob/28ef1cefb5bfcf22e258419cd5db8f836527042f/src/integration/asserts/caliptra_ss_top_sva.sv#L75-L78
|
| 10 |
+
|
| 11 |
+
I think that discard_fuse_write signal remains asserted for two more cycles after otp_operation_done toggles, so the assertion impacts on the next valid write as well.
|
| 12 |
+
Therefore, I’ve just tried it as below.
|
| 13 |
+
I’d appreciate your feedback on these changes.
|
| 14 |
+
|
| 15 |
+
```
|
| 16 |
+
`CALIPTRA_ASSERT(FcAxiFilterDaiAccessError_A,
|
| 17 |
+
dai_write_req ##1 // <=== add
|
| 18 |
+
`FC_PATH.discard_fuse_write ##1
|
| 19 |
+
`FC_PATH.otp_operation_done[->1] |=>
|
| 20 |
+
`FC_PATH.u_otp_ctrl_dai.error_o == {AccessError})
|
| 21 |
+
|
| 22 |
+
```
|
| 23 |
+
Regards,
|
issues/darklife_darkriscv_pr95
ADDED
|
@@ -0,0 +1,28 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# Add cycle and instret counters ("Zicntr" extension)
|
| 2 |
+
|
| 3 |
+
- Source URL: https://github.com/darklife/darkriscv/issues/94
|
| 4 |
+
|
| 5 |
+
Hello,
|
| 6 |
+
|
| 7 |
+
The ISA suggests it should be implemented, as it serves basic performance analysis. I need it too for Dhrystone benchmark.
|
| 8 |
+
I can see that clocks and instructions are being counted with `__PERFMETER__` enabled. Why not make them accessible via CSRs?
|
| 9 |
+
|
| 10 |
+
|
| 11 |
+
|
| 12 |
+
|
| 13 |
+
|
| 14 |
+
|
| 15 |
+
|
| 16 |
+
# GitHub Issue #94: Add cycle and instret counters ("Zicntr" extension)
|
| 17 |
+
|
| 18 |
+
## Issue Body
|
| 19 |
+
The reporter notes that the RISC-V ISA suggests implementing cycle and instruction counters for basic performance analysis. They mention that clock and instruction counting already exist when `__PERFMETER__` is enabled, but these metrics should be made accessible through Control and Status Registers (CSRs). The requester needs this functionality for Dhrystone benchmark testing.
|
| 20 |
+
|
| 21 |
+
## Status
|
| 22 |
+
Closed (with associated PR #95)
|
| 23 |
+
|
| 24 |
+
## Assignees
|
| 25 |
+
samsoniuk, MrJake222
|
| 26 |
+
|
| 27 |
+
## Notes
|
| 28 |
+
The webpage content provided does not include visible comments from other users or additional linked issue details beyond the issue title and description shown.
|
issues/dawsonjon_fpu_pr16
ADDED
|
@@ -0,0 +1,36 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# Fix sign bug
|
| 2 |
+
|
| 3 |
+
Instance: dawsonjon_fpu_pr16
|
| 4 |
+
Source: https://github.com/dawsonjon/fpu/pull/16
|
| 5 |
+
Fetched: 2026-04-26
|
| 6 |
+
Repository: dawsonjon/fpu
|
| 7 |
+
Pull request: #16
|
| 8 |
+
Author: andreast271
|
| 9 |
+
State: closed
|
| 10 |
+
Base branch: master
|
| 11 |
+
Head branch: master
|
| 12 |
+
Created: 2019-01-21T16:34:51Z
|
| 13 |
+
Updated: 2019-01-21T18:26:12Z
|
| 14 |
+
Closed: 2019-01-21T18:26:12Z
|
| 15 |
+
Merged: 2019-01-21T18:26:12Z
|
| 16 |
+
|
| 17 |
+
The result of -a + a should be +0 (positive zero). Without this fix, the module returns -0 (negative zero).
|
| 18 |
+
|
| 19 |
+
# PR #16: Fix sign bug
|
| 20 |
+
|
| 21 |
+
## Title
|
| 22 |
+
Fix sign bug
|
| 23 |
+
|
| 24 |
+
## Description
|
| 25 |
+
The result of -a + a should be +0 (positive zero). Without this fix, the module returns -0 (negative zero).
|
| 26 |
+
|
| 27 |
+
## Comment by andreast271 (Jan 21, 2019)
|
| 28 |
+
"The result of -a + a should be +0 (positive zero). Without this fix, the module returns -0 (negative zero)."
|
| 29 |
+
|
| 30 |
+
## Merge Status
|
| 31 |
+
Merged by dawsonjon on Jan 21, 2019
|
| 32 |
+
|
| 33 |
+
## Commit
|
| 34 |
+
c75ffcf92183c1777e84a87170e6759eaff70d17
|
| 35 |
+
|
| 36 |
+
No linked issues or additional comments were present in the pull request.
|
issues/gtaylormb_opl3_fpga_pr51
ADDED
|
@@ -0,0 +1,24 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# Linting for boosting RTL quality and QA consistency
|
| 2 |
+
|
| 3 |
+
- Source URL: https://github.com/gtaylormb/opl3_fpga/issues/48
|
| 4 |
+
|
| 5 |
+
## Issue Title
|
| 6 |
+
Linting for boosting RTL quality and QA consistency
|
| 7 |
+
|
| 8 |
+
## Issue Description
|
| 9 |
+
The issue body referenced a related discussion from the openCologne project (https://github.com/chili-chips-ba/openCologne/issues/16). The issue is focused on implementing linting tools and processes to improve the quality and consistency of the RTL (Register Transfer Level) code within this FPGA design project.
|
| 10 |
+
|
| 11 |
+
## Issue Comments
|
| 12 |
+
None visible.
|
| 13 |
+
|
| 14 |
+
## Issue Metadata
|
| 15 |
+
- Status: Closed (resolved via PR #51)
|
| 16 |
+
- Author: chili-chips-ba
|
| 17 |
+
- Created: June 12, 2024
|
| 18 |
+
- Assignees: None
|
| 19 |
+
- Labels: None
|
| 20 |
+
- Milestone: None
|
| 21 |
+
|
| 22 |
+
## Linked Issues / PRs
|
| 23 |
+
- PR #51 — resolves this issue
|
| 24 |
+
- Related discussion: openCologne #16
|
issues/hdl-util_hdmi_pr16
ADDED
|
@@ -0,0 +1,33 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# Switch to GH action
|
| 2 |
+
|
| 3 |
+
Instance: hdl-util_hdmi_pr16
|
| 4 |
+
Source: https://github.com/hdl-util/hdmi/pull/16
|
| 5 |
+
Fetched: 2026-04-26
|
| 6 |
+
Repository: hdl-util/hdmi
|
| 7 |
+
Pull request: #16
|
| 8 |
+
Author: sameer
|
| 9 |
+
State: closed
|
| 10 |
+
Base branch: master
|
| 11 |
+
Head branch: github-action
|
| 12 |
+
Created: 2021-02-07T00:33:51Z
|
| 13 |
+
Updated: 2021-02-07T01:23:04Z
|
| 14 |
+
Closed: 2021-02-07T01:23:01Z
|
| 15 |
+
Merged: 2021-02-07T01:23:01Z
|
| 16 |
+
|
| 17 |
+
## PR Title
|
| 18 |
+
Switch to GH action
|
| 19 |
+
|
| 20 |
+
## PR Description
|
| 21 |
+
No description provided.
|
| 22 |
+
|
| 23 |
+
## PR Comments
|
| 24 |
+
No substantive comments were recorded in the conversation thread beyond the automated merge notification.
|
| 25 |
+
|
| 26 |
+
## PR Metadata
|
| 27 |
+
- Status: Merged
|
| 28 |
+
- Author force-pushed the github-action branch multiple times before merging
|
| 29 |
+
- Purpose: transition the project's CI/CD infrastructure from Travis CI to GitHub Actions and update ModelSim dependencies
|
| 30 |
+
- Branch deleted after merge: github-action
|
| 31 |
+
|
| 32 |
+
## Linked Issues
|
| 33 |
+
No linked issues are referenced in this pull request.
|
issues/hdl-util_hdmi_pr21
ADDED
|
@@ -0,0 +1,37 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# move screen to upper left corner in frame
|
| 2 |
+
|
| 3 |
+
Instance: hdl-util_hdmi_pr21
|
| 4 |
+
Source: https://github.com/hdl-util/hdmi/pull/21
|
| 5 |
+
Fetched: 2026-04-26
|
| 6 |
+
Repository: hdl-util/hdmi
|
| 7 |
+
Pull request: #21
|
| 8 |
+
Author: sameer
|
| 9 |
+
State: closed
|
| 10 |
+
Base branch: master
|
| 11 |
+
Head branch: origin_is_screen_origin
|
| 12 |
+
Created: 2021-03-06T05:28:53Z
|
| 13 |
+
Updated: 2021-03-07T16:55:16Z
|
| 14 |
+
Closed: 2021-03-07T16:55:13Z
|
| 15 |
+
Merged: 2021-03-07T16:55:13Z
|
| 16 |
+
|
| 17 |
+
## PR Title
|
| 18 |
+
move screen to upper left corner in frame
|
| 19 |
+
|
| 20 |
+
## PR Description
|
| 21 |
+
this way, origin = screen origin
|
| 22 |
+
|
| 23 |
+
## PR Comments
|
| 24 |
+
|
| 25 |
+
**sameer** (Mar 6, 2021):
|
| 26 |
+
"this way, origin = screen origin"
|
| 27 |
+
|
| 28 |
+
## PR Metadata
|
| 29 |
+
- Status: Merged
|
| 30 |
+
- Commit: c003eba
|
| 31 |
+
- Reviewers: None
|
| 32 |
+
- Assignees: None
|
| 33 |
+
- Labels: None
|
| 34 |
+
- Branch deleted after merge: origin_is_screen_origin
|
| 35 |
+
|
| 36 |
+
## Linked Issues
|
| 37 |
+
No linked issues are referenced in this pull request.
|
issues/hdl-util_hdmi_pr29
ADDED
|
@@ -0,0 +1,25 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# hdmi: allow setting start x/y with parameters
|
| 2 |
+
|
| 3 |
+
Instance: hdl-util_hdmi_pr29
|
| 4 |
+
Source: https://github.com/hdl-util/hdmi/pull/29
|
| 5 |
+
Fetched: 2026-04-26
|
| 6 |
+
Repository: hdl-util/hdmi
|
| 7 |
+
Pull request: #29
|
| 8 |
+
Author: bkoropoff
|
| 9 |
+
State: closed
|
| 10 |
+
Base branch: master
|
| 11 |
+
Head branch: start-coord
|
| 12 |
+
Created: 2022-01-23T00:08:30Z
|
| 13 |
+
Updated: 2022-01-27T01:22:16Z
|
| 14 |
+
Closed: 2022-01-27T01:22:16Z
|
| 15 |
+
Merged: 2022-01-27T01:22:16Z
|
| 16 |
+
|
| 17 |
+
gbaHD needs this synchronize the hdmi output with the start of a GBA
|
| 18 |
+
frame, with the GBA image centered within the HDMI frame instead of
|
| 19 |
+
starting at 0,0.
|
| 20 |
+
|
| 21 |
+
It's easier and uses fewer FPGA resources to start the hdmi block in the
|
| 22 |
+
middle of a frame than to count off the right number of cycles from GBA
|
| 23 |
+
vsync to achieve the same phase relationship. Receivers need to be able
|
| 24 |
+
to synchronize from mid-stream anyway, so this doesn't cause any
|
| 25 |
+
problems.
|
issues/jotego_jt12_pr64
ADDED
|
@@ -0,0 +1,23 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# Genesis Regression: Bimini Run audio playing too fast
|
| 2 |
+
|
| 3 |
+
- Source URL: https://github.com/jotego/jt12/issues/62
|
| 4 |
+
|
| 5 |
+
## Issue Title
|
| 6 |
+
Genesis Regression: Bimini Run audio playing too fast
|
| 7 |
+
|
| 8 |
+
## Issue Description
|
| 9 |
+
https://github.com/MiSTer-devel/Genesis_MiSTer/issues/26#issuecomment-1117934103 — as confirmed by gyurco, Bimini Run has a regression that points to this commit: https://github.com/jotego/jt12/commit/66eb9ee162e1b1cd3f31f7549af969c7bc191951
|
| 10 |
+
|
| 11 |
+
The issue reports a regression in the Bimini Run game where audio plays at an increased speed.
|
| 12 |
+
|
| 13 |
+
## Issue Comments
|
| 14 |
+
None visible.
|
| 15 |
+
|
| 16 |
+
## Issue Metadata
|
| 17 |
+
- Status: Closed (resolved via PR #64)
|
| 18 |
+
- Project: JTCores
|
| 19 |
+
|
| 20 |
+
## Linked Issues / PRs
|
| 21 |
+
- PR #64 — resolution
|
| 22 |
+
- References Genesis_MiSTer #26
|
| 23 |
+
- Points to commit 66eb9ee162e1b1cd3f31f7549af969c7bc191951
|
issues/jotego_jtcores_pr1111
ADDED
|
@@ -0,0 +1,22 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# ngp/ngpc: brown line appearing at the bottom of the screen
|
| 2 |
+
|
| 3 |
+
- Source URL: https://github.com/jotego/jtcores/issues/994
|
| 4 |
+
|
| 5 |
+
## Issue Title
|
| 6 |
+
ngp/ngpc: brown line appearing at the bottom of the screen
|
| 7 |
+
|
| 8 |
+
## Issue Description
|
| 9 |
+
Tested for commit 31abc75893f2108052617b8c119cc2f7d7731b3f on Analogue Pocket.
|
| 10 |
+
|
| 11 |
+
(Issue body details beyond the test commit reference were not fully captured.)
|
| 12 |
+
|
| 13 |
+
## Issue Comments
|
| 14 |
+
None visible.
|
| 15 |
+
|
| 16 |
+
## Issue Metadata
|
| 17 |
+
- Status: Closed (marked Done in JTCores project)
|
| 18 |
+
- Assignee: rp-jt
|
| 19 |
+
|
| 20 |
+
## Linked Issues / PRs
|
| 21 |
+
- PR #1111
|
| 22 |
+
- PR #1069
|
issues/jotego_jtcores_pr1169
ADDED
|
@@ -0,0 +1,25 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# suratk: sprite on sprite shade
|
| 2 |
+
|
| 3 |
+
- Source URL: https://github.com/jotego/jtcores/issues/1160
|
| 4 |
+
|
| 5 |
+
## Issue Title
|
| 6 |
+
suratk: sprite on sprite shade
|
| 7 |
+
|
| 8 |
+
## Issue Description
|
| 9 |
+
Sprites can currently cast a shadow on the background but not on other sprites. This feature is missing on master.
|
| 10 |
+
|
| 11 |
+
It works on the suratk-1160 branch but the change may be not be backwards compatible.
|
| 12 |
+
|
| 13 |
+
(Two screenshot images were provided showing the visual difference between the current state and the desired implementation with sprite-on-sprite shadowing.)
|
| 14 |
+
|
| 15 |
+
## Issue Comments
|
| 16 |
+
None visible.
|
| 17 |
+
|
| 18 |
+
## Issue Metadata
|
| 19 |
+
- Status: Closed (linked to PR #1169)
|
| 20 |
+
- Assignee: rp-jt
|
| 21 |
+
- Labels: core bug, new core
|
| 22 |
+
- Project: JTCores (Status: Done)
|
| 23 |
+
|
| 24 |
+
## Linked Issues / PRs
|
| 25 |
+
- PR #1169 — resolution
|
issues/jotego_jtcores_pr1279
ADDED
|
@@ -0,0 +1,22 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# kiwi: Dr Toppel's Adventure Graphical Issue
|
| 2 |
+
|
| 3 |
+
- Source URL: https://github.com/jotego/jtcores/issues/1276
|
| 4 |
+
|
| 5 |
+
Copying from here: https://github.com/jotego/jtcores_mister/issues/13
|
| 6 |
+
|
| 7 |
+
> https://youtu.be/UEeqoD7jRxc?t=56 timestamp - please notice the orange issues where background graphics are not drawing in properly - I am not sure when this started, I utilized update_all on 11/22/2025 prior to testing.
|
| 8 |
+
Note - I tried all 3 MRAs and all have this issue (World, USA, and Japan).
|
| 9 |
+
I also noticed sound seems a little off but I am not as well versed to know if this is inaccurate or an issue.
|
| 10 |
+
|
| 11 |
+
## Fetched Issue/PR Details
|
| 12 |
+
|
| 13 |
+
Title: kiwi: Dr Toppel's Adventure Graphical Issue (#1276)
|
| 14 |
+
|
| 15 |
+
Description: The issue references a graphical problem in Dr. Toppel's Adventure where there are "orange issues where background graphics are not drawing in properly." The reporter tested all three MRAs (World, USA, and Japan) and experienced the same graphical glitch after running an update on November 22, 2025. They also noted potential sound anomalies but were uncertain whether these represent actual bugs.
|
| 16 |
+
|
| 17 |
+
Status: Closed (linked to PR #1279)
|
| 18 |
+
Project: JTCores
|
| 19 |
+
|
| 20 |
+
Comments: No comments were visible beyond the initial issue description.
|
| 21 |
+
|
| 22 |
+
Linked Issues: References https://github.com/jotego/jtcores_mister/issues/13 (the original report copied into this issue).
|
issues/jotego_jtcores_pr634
ADDED
|
@@ -0,0 +1,25 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# toki: latches
|
| 2 |
+
|
| 3 |
+
- Source URL: https://github.com/jotego/jtcores/issues/606
|
| 4 |
+
|
| 5 |
+
Hi @vertrex
|
| 6 |
+
|
| 7 |
+
There are some latches in the current design. You will get a latch warning when using `jtcore` to compile. Latches tend to cause obscure bugs so it is better to have a fully synchronous design without them.
|
| 8 |
+
|
| 9 |
+
Please try to remove them.
|
| 10 |
+
|
| 11 |
+
Thanks
|
| 12 |
+
|
| 13 |
+
## Fetched Issue/PR Details
|
| 14 |
+
|
| 15 |
+
Title: toki: latches (#606)
|
| 16 |
+
|
| 17 |
+
Description: jotego opened the issue on April 8, 2024, asking vertrex to remove latches from the design. The message states: "There are some latches in the current design. You will get a latch warning when using `jtcore` to compile. Latches tend to cause obscure bugs so it is better to have a fully synchronous design without them."
|
| 18 |
+
|
| 19 |
+
Status: Closed (resolved via PR #634)
|
| 20 |
+
Assignees: vertrex, jotego
|
| 21 |
+
Project: JTCores
|
| 22 |
+
|
| 23 |
+
Comments: No comments from other users were included in the page content.
|
| 24 |
+
|
| 25 |
+
Linked Issues: None beyond the resolving PR #634.
|
issues/jotego_jtcores_pr960
ADDED
|
@@ -0,0 +1,22 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# Adjusting Volume using keyboard does not work on pocket.
|
| 2 |
+
|
| 3 |
+
- Source URL: https://github.com/jotego/jtcores/issues/935
|
| 4 |
+
|
| 5 |
+
On Mister it is possible to adjust the volume using F4 and F5 but this does not work on Analogue Pocket.
|
| 6 |
+
Since it is not possible to adjust the volume on Analogue Pocket while in dock It would be useful if this was working.
|
| 7 |
+
|
| 8 |
+
## Fetched Issue/PR Details
|
| 9 |
+
|
| 10 |
+
Title: Adjusting Volume using keyboard does not work on pocket. (#935)
|
| 11 |
+
|
| 12 |
+
Description: The reporter notes that on Mister, volume adjustment via F4 and F5 keyboard keys functions properly, but this capability is absent on Analogue Pocket. They request implementation of this feature, particularly since manual volume adjustment isn't possible while the Pocket is docked.
|
| 13 |
+
|
| 14 |
+
Status: Closed (resolved via PR #960)
|
| 15 |
+
Assignee: rp-jt
|
| 16 |
+
Label: Enhancement
|
| 17 |
+
Project: JTCores
|
| 18 |
+
Created: January 17, 2025
|
| 19 |
+
|
| 20 |
+
Comments: None visible on the page.
|
| 21 |
+
|
| 22 |
+
Linked Issues: Resolving PR #960.
|
issues/lowRISC_ibex_pr2269
ADDED
|
@@ -0,0 +1,31 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# [bug][ibex_decoder] Report a bug in Ibex
|
| 2 |
+
|
| 3 |
+
- Source URL: https://github.com/lowRISC/ibex/pull/2269
|
| 4 |
+
|
| 5 |
+
Hi all!
|
| 6 |
+
|
| 7 |
+
I am using a static analysis to found a various bugs in open source RTL designs.
|
| 8 |
+
|
| 9 |
+
It was founded that in `ibex_decoder.sv` RTL file dead code is exists [here](https://github.com/lowRISC/ibex/blob/master/rtl/ibex_decoder.sv#L439).
|
| 10 |
+
|
| 11 |
+
This assignment under `else` statement is never executed due to [this](https://github.com/lowRISC/ibex/blob/master/rtl/ibex_decoder.sv#L406) external `else` branch with `!instr[26]` condition.
|
| 12 |
+
|
| 13 |
+
## Fetched Issue/PR Details
|
| 14 |
+
|
| 15 |
+
Title: [rtl] Minor tweak to decoder to avoid dead code (PR #2269)
|
| 16 |
+
|
| 17 |
+
Description: The PR addresses dead code in the instruction decoder. According to the submitter, an else branch was unreachable because the surrounding condition already established that instr[26] was zero, making a redundant check impossible to execute.
|
| 18 |
+
|
| 19 |
+
Status: Merged
|
| 20 |
+
Merged by: andreaskurth
|
| 21 |
+
Merge date: April 25, 2025
|
| 22 |
+
Reviewers: marnovandermaas, andreaskurth, vogelpi (awaiting)
|
| 23 |
+
Checks passed: 11
|
| 24 |
+
|
| 25 |
+
Comments:
|
| 26 |
+
- rswarbrick (Apr 23, 2025): "The 'else' part of the if/else check here wasn't possible because the surrounding else branch...is already in the case where instr[26] is zero."
|
| 27 |
+
- marnovandermaas (Apr 24, 2025): Suggested adding an assertion to clarify the constraint.
|
| 28 |
+
- rswarbrick (response): Noted that the project lacks procedural assertions in RTL code and the constraint is syntactically visible.
|
| 29 |
+
- andreaskurth (Apr 25, 2025): Approved with "LGTM, thx @rswarbrick".
|
| 30 |
+
|
| 31 |
+
Linked Issues: Fixes issue #2268 ("[bug][ibex_decoder] Report a bug in Ibex").
|
issues/merledu_azadi-soc_pr14
ADDED
|
@@ -0,0 +1,19 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# Need a coverage plan for ibex core!
|
| 2 |
+
|
| 3 |
+
- Source URL: https://github.com/merledu/azadi-soc/issues/13
|
| 4 |
+
|
| 5 |
+
|
| 6 |
+
## Fetched Issue/PR Details
|
| 7 |
+
|
| 8 |
+
Title: Need a coverage plan for ibex core! (#13)
|
| 9 |
+
|
| 10 |
+
Description: No description provided in the original issue body. The issue appears to be a request for establishing test coverage documentation or strategy for the Ibex core component within the Azadi SoC project.
|
| 11 |
+
|
| 12 |
+
Repository: merledu/azadi-soc
|
| 13 |
+
Status: Closed (linked to PR #14)
|
| 14 |
+
Author: za1nrkhan
|
| 15 |
+
Created: November 19, 2021
|
| 16 |
+
|
| 17 |
+
Comments: None visible.
|
| 18 |
+
|
| 19 |
+
Linked Issues: Resolving PR #14.
|
issues/merledu_azadi-soc_pr2
ADDED
|
@@ -0,0 +1,25 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# Input signal declared as output
|
| 2 |
+
|
| 3 |
+
- Source URL: https://github.com/merledu/azadi-soc/issues/1
|
| 4 |
+
|
| 5 |
+
When simulating with Xcelium, these warnings appear:
|
| 6 |
+
|
| 7 |
+
```
|
| 8 |
+
xmelab: *W,DSEMEL: This SystemVerilog design will be simulated as per IEEE 1800-2009 SystemVerilog simulation semantics. Use -disable_sem2009 option for turning off SV 2009 simulation semantics.
|
| 9 |
+
.rd_data_o (frm_q),
|
| 10 |
+
|
|
| 11 |
+
xmelab: *W,ENUMERR (/home/zrkhan/Desktop/uvm-runs/azadi-new/hw/vendor/lowrisc_ibex/rtl/ibex_cs_registers.sv,849|21): This assignment is a violation of SystemVerilog strong typing rules for enumeration datatypes.
|
| 12 |
+
.tag_i ( 1 ),
|
| 13 |
+
|
|
| 14 |
+
xmelab: *W,CUVMPW (/home/zrkhan/Desktop/uvm-runs/azadi-new/hw/vendor/lowrisc_ibex/rtl/ibex_core.sv,1205|22): port sizes differ in port connection(32/1) for the instance(core_ibex_tb_top.dut.u_ibex_core) .
|
| 15 |
+
.fp_load_o ( fp_load )
|
| 16 |
+
|
|
| 17 |
+
```
|
| 18 |
+
Followed by this error message
|
| 19 |
+
```
|
| 20 |
+
xmelab: *E,MULDRN (/home/zrkhan/Desktop/uvm-runs/azadi-new/hw/vendor/lowrisc_ibex/rtl/ibex_core.sv,712|15): Variable 'core_ibex_tb_top.dut.u_ibex_core.fp_load' has multiple conflicting drivers and the indicated output port connection in scope 'core_ibex_tb_top.dut.u_ibex_core' is contributing to this conflict set.
|
| 21 |
+
.fp_load_i ( fp_load )
|
| 22 |
+
|
|
| 23 |
+
```
|
| 24 |
+
|
| 25 |
+
The issue points out to the invalid port direction of `ibex_wb_write` module.
|
issues/muneeb-mbytes_pulpino__spi_master__ip_verification_pr39
ADDED
|
@@ -0,0 +1,52 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# Integrate RTL and VIPs
|
| 2 |
+
|
| 3 |
+
- Source URL: https://github.com/muneeb-mbytes/pulpino__spi_master__ip_verification/issues/9
|
| 4 |
+
|
| 5 |
+
Title: Integrate RTL and VIPs
|
| 6 |
+
|
| 7 |
+
Body: Integrate the RTL design and VIPs by developing the top module
|
| 8 |
+
|
| 9 |
+
Comments: None
|
| 10 |
+
|
| 11 |
+
Linked PR: #39 (closed)
|
| 12 |
+
|
| 13 |
+
Metadata:
|
| 14 |
+
- Assignee: Nadeem-Ahmed-S
|
| 15 |
+
- Milestone: 💻 Development
|
| 16 |
+
- Status: Closed
|
| 17 |
+
- Created: February 5, 2022
|
| 18 |
+
|
| 19 |
+
---
|
| 20 |
+
|
| 21 |
+
## Pull Request
|
| 22 |
+
|
| 23 |
+
**PR Title:** Integration of RTL and VIPs done as in TB Architecture
|
| 24 |
+
|
| 25 |
+
**PR Number:** #39
|
| 26 |
+
|
| 27 |
+
**Status:** Merged on February 18, 2022
|
| 28 |
+
|
| 29 |
+
**Branch:** `rtl_vips_integration` → `development_branch_v1`
|
| 30 |
+
|
| 31 |
+
### Description
|
| 32 |
+
|
| 33 |
+
The initial PR description outlined several key objectives:
|
| 34 |
+
|
| 35 |
+
- "Created two tops hvl_top and hdl_top inside dv folder"
|
| 36 |
+
- "Added the bfm sides of both apb_master and spi_slave in hdl_top.sv file"
|
| 37 |
+
- "Mapped the apb_master interface and spi_slave interface to rtl"
|
| 38 |
+
- "Printing the topology as in the architecture diagram"
|
| 39 |
+
|
| 40 |
+
The PR addressed issues #9 (Integrate RTL and VIPs) and #11 (Develop TB components).
|
| 41 |
+
|
| 42 |
+
### Comments
|
| 43 |
+
|
| 44 |
+
**Nadeem-Ahmed-S** (February 17, 2022) provided an update describing additional work:
|
| 45 |
+
|
| 46 |
+
Added comparisons for write data and MOSI data. Developed check and report phases within the scoreboard through separate commits addressing run_phase, check_phase, and report_phase implementations.
|
| 47 |
+
|
| 48 |
+
### Review & Merge
|
| 49 |
+
|
| 50 |
+
**muneebullashariff** approved the changes on February 18, 2022, with the comment: "Merging the changes." The branch was subsequently deleted on March 1, 2022.
|
| 51 |
+
|
| 52 |
+
**Participants:** 5 contributors including Nadeem-Ahmed-S, muneebullashariff, sahanapalesh, sivareddykostam, and Shwetapatil05.
|
issues/nand2mario_nestang_pr75
ADDED
|
@@ -0,0 +1,36 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# NES controller connection issue
|
| 2 |
+
|
| 3 |
+
- Source URL: https://github.com/nand2mario/nestang/pull/75
|
| 4 |
+
|
| 5 |
+
Title: Fix NES controllers
|
| 6 |
+
|
| 7 |
+
Body: Fixes #74
|
| 8 |
+
|
| 9 |
+
Comments:
|
| 10 |
+
- nikitalita (May 23, 2024): "Fixes #74"
|
| 11 |
+
- nand2mario (May 23, 2024): Merged commit 705d9c1 into master
|
| 12 |
+
|
| 13 |
+
Linked Issue: NES controller connection issue (#74)
|
| 14 |
+
Linked Issue Body: I see you recently added support for them; which pins do they connect to? I'm going to make my own connector with a breadboard and a voltage logic level converter.
|
| 15 |
+
|
| 16 |
+
Status: Merged on May 23, 2024
|
| 17 |
+
|
| 18 |
+
## PR Title
|
| 19 |
+
Fix NES controllers
|
| 20 |
+
|
| 21 |
+
## PR Description
|
| 22 |
+
Fixes #74
|
| 23 |
+
|
| 24 |
+
## PR Comments
|
| 25 |
+
No substantive comments are documented in the conversation thread beyond the PR description referencing the issue.
|
| 26 |
+
|
| 27 |
+
## Linked Issue
|
| 28 |
+
#74: NES controller connection issue
|
| 29 |
+
Body: I see you recently added support for them; which pins do they connect to? I'm going to make my own connector with a breadboard and a voltage logic level converter.
|
| 30 |
+
|
| 31 |
+
## PR Metadata
|
| 32 |
+
- Author: nikitalita
|
| 33 |
+
- Repository: nand2mario/nestang
|
| 34 |
+
- Merge commit: 705d9c14f0be84c54476b1f54e463fa971530bfb
|
| 35 |
+
- Status: Merged on May 23, 2024 by nand2mario into master
|
| 36 |
+
- Participants: nikitalita, nand2mario
|
issues/olofk_serv_pr107
ADDED
|
@@ -0,0 +1,33 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# support for W=4
|
| 2 |
+
|
| 3 |
+
Instance: olofk_serv_pr107
|
| 4 |
+
Source: https://github.com/olofk/serv/pull/107
|
| 5 |
+
Fetched: 2026-04-26
|
| 6 |
+
Repository: olofk/serv
|
| 7 |
+
Pull request: #107
|
| 8 |
+
Author: uhit332
|
| 9 |
+
State: closed
|
| 10 |
+
Base branch: main
|
| 11 |
+
Head branch: incremental
|
| 12 |
+
Created: 2023-10-31T12:34:06Z
|
| 13 |
+
Updated: 2023-10-31T14:54:12Z
|
| 14 |
+
Closed: 2023-10-31T14:53:37Z
|
| 15 |
+
Merged: 2023-10-31T14:53:37Z
|
| 16 |
+
|
| 17 |
+
## PR Title
|
| 18 |
+
support for W=4
|
| 19 |
+
|
| 20 |
+
## PR Description
|
| 21 |
+
No description provided.
|
| 22 |
+
|
| 23 |
+
## PR Comments
|
| 24 |
+
|
| 25 |
+
**olofk** (October 31, 2023):
|
| 26 |
+
"Perfect! Picked and pushed!"
|
| 27 |
+
|
| 28 |
+
## Linked Issues
|
| 29 |
+
No linked issues.
|
| 30 |
+
|
| 31 |
+
## PR Metadata
|
| 32 |
+
- Participants: uhit332 (contributor), olofk (owner)
|
| 33 |
+
- Status: Merged into olofk:main on October 31, 2023
|
issues/openhwgroup_core-v-verif_pr2585
ADDED
|
@@ -0,0 +1,34 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
Minimal fail-to-pass extraction for openhwgroup/core-v-verif PR 2585, "Restore
|
| 2 |
+
Verilator compile/simulation".
|
| 3 |
+
|
| 4 |
+
The reduced testbench wrapper models the real Verilator compile fix where the
|
| 5 |
+
CV32E40P wrapper module was renamed to `cv32e40p_core_tb_wrapper` and the
|
| 6 |
+
Verilator top instantiates the renamed wrapper. The buggy snapshot has the
|
| 7 |
+
renamed file/top reference but the old module declaration, reproducing the
|
| 8 |
+
missing-module compile failure. The patch renames the module so the Verilator
|
| 9 |
+
testbench can build and drive `fetch_enable_i`.
|
| 10 |
+
|
| 11 |
+
## PR Title
|
| 12 |
+
Restore Verilator compile/simulation
|
| 13 |
+
|
| 14 |
+
## PR Description
|
| 15 |
+
Resolves #2584, and cleans up DSim compiles as well.
|
| 16 |
+
|
| 17 |
+
## PR Comments
|
| 18 |
+
|
| 19 |
+
**cairo-caplan** (Feb 11, 2025):
|
| 20 |
+
Suggested that the "-std=gnu++11" compiler flag removal was necessary because recent Verilator versions no longer require it. They also recommended applying similar changes to cv32e40s and cv32e40x Makefiles and noted the filename should match the module name for consistency.
|
| 21 |
+
|
| 22 |
+
**MikeOpenHWGroup** (Feb 11, 2025):
|
| 23 |
+
Referenced Verilator Issue #4898, which recommends removing "-std=c++11". They acknowledged that cv32e40s and cv32e40x should receive similar updates on their respective development branches and confirmed they had updated the filename to match the renamed module.
|
| 24 |
+
|
| 25 |
+
**cairo-caplan** (Feb 11, 2025):
|
| 26 |
+
Approval. Confirmed testing on Verilator 5.033 and validated the changes resolved the original issue.
|
| 27 |
+
|
| 28 |
+
## Linked Issue
|
| 29 |
+
#2584: Followed the quick start for cv32e40p but got hit with 7 warnings (Status: Closed)
|
| 30 |
+
|
| 31 |
+
## PR Metadata
|
| 32 |
+
- Author: MikeOpenHWGroup
|
| 33 |
+
- Target Branch: openhwgroup:cv32e40p/dev
|
| 34 |
+
- Status: Merged (April 1, 2025)
|
issues/openhwgroup_core-v-xif_pr139
ADDED
|
@@ -0,0 +1,25 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# CV-X-IF vs. CORE-V-XIF
|
| 2 |
+
|
| 3 |
+
In https://github.com/openhwgroup/core-v-xif/pull/124/commits/8d7a432ceaca51b62af772b449af29e26120ad02 the term `CORE-V-XIF` is replaced by `CV-X-IF` in `README.md` and `intro.rst` files.
|
| 4 |
+
|
| 5 |
+
Is there any reason to keep `CORE-V-XIF` in `x_ext.rst` file? For the sake of consistency, it would be preferable to use only one acronym.
|
| 6 |
+
|
| 7 |
+
## PR Title
|
| 8 |
+
Replacing CORE-V-XIF with CV-X-IF
|
| 9 |
+
|
| 10 |
+
## PR Description
|
| 11 |
+
No description provided.
|
| 12 |
+
|
| 13 |
+
## PR Comments
|
| 14 |
+
Christian Herber (contributor) requested a review from ASintzoff on February 6, 2024 at 08:37 AM.
|
| 15 |
+
|
| 16 |
+
## Linked Issue
|
| 17 |
+
#138: CV-X-IF vs. CORE-V-XIF
|
| 18 |
+
|
| 19 |
+
## PR Metadata
|
| 20 |
+
- Submitter: christian-herber-nxp
|
| 21 |
+
- Reviewer/Merger: ASintzoff
|
| 22 |
+
- Source Branch: 138-cv-x-if-vs-core-v-xif
|
| 23 |
+
- Target Branch: main
|
| 24 |
+
- Status: Merged (February 6, 2024)
|
| 25 |
+
- Participants: christian-herber-nxp, ASintzoff
|
issues/openhwgroup_cv-hpdcache_pr48
ADDED
|
@@ -0,0 +1,26 @@
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
| 1 |
+
# Incorrect flagging of write request event
|
| 2 |
+
|
| 3 |
+
Hi, I have noticed that the write request event (`evt_write_req_o`) is not flagged when there is a write request with a write-back policy and the memory produces a response with the error bit set.
|
| 4 |
+
|
| 5 |
+
## How to reproduce the issue
|
| 6 |
+
|
| 7 |
+
Using the verilator testbench, run the following command:
|
| 8 |
+
|
| 9 |
+
```
|
| 10 |
+
make run SEQUENCE=random LOG_LEVEL=3 NTRANSACTIONS=69 SEED=42
|
| 11 |
+
```
|
| 12 |
+
|
| 13 |
+
The faulting transaction will be the last one.
|
| 14 |
+
|
| 15 |
+
## Issue description
|
| 16 |
+
|
| 17 |
+
The core makes a store request, using a write-back policy. This request causes a miss, causing the cache to issue a load request to memory due to the write-allocate policy. The write miss event (`evt_cache_write_miss_o`) is flagged, but the write request event (`evt_write_req_o`) is not. The request is put in the RTAB while the cache waits for the memory response.
|
| 18 |
+
|
| 19 |
+
Once the response arrives, it has the error bit set. The original request is then replayed from the RTAB. Because it has been flagged with the error bit, it only sends a response to the core with this flag set. However, it does not flag any event and does not proceed any further.
|
| 20 |
+
|
| 21 |
+
Under normal circumstances, when the error bit is not set, the directory would be updated and the replayed request would hit the cache. It is under this logic when the write request event is flagged (see [hpdcache_ctrl_pe.sv:881](https://github.com/openhwgroup/cv-hpdcache/blob/master/rtl/src/hpdcache_ctrl_pe.sv#L881)).
|
| 22 |
+
|
| 23 |
+
## Possible solutions
|
| 24 |
+
|
| 25 |
+
- When replaying a request with the error bit set, check if it's a store with the write-back policy, and flag the event then (inside hpdcache_ctrl_pe.sv:404).
|
| 26 |
+
- When there is a write-back store making a hit in the cache, check if it's a core request or a replay from the RTAB. Emit the write request event both when there is a miss and when the core (and not a replay due to a miss) makes a hit.
|