PV-Bench / experiments /t2 /tests /test_validity.py
cielseven's picture
regenerate groundtruth with qcp 2.1.4, update the experiment harnesses
2504377
Raw History Blame Contribute Delete
6.24 kB
"""Run validity classes (PROVENANCE, ISOLATION, COMPLETION, API_ERROR, INTEGRITY)."""
import json
import unittest
from unittest.mock import patch
from helpers import IMAGE_ID, Fixture, record_run
from pvbench_common import manifest as manifest_module
from t2 import validity
from t2.config import Case
class ValidityTests(Fixture):
def setUp(self):
super().setUp()
self.prepared()
def classes(self, **kw):
valid, lines, failures = validity.check(self.cfg, self.case, write=False, **kw)
return valid, sorted({f["class"] for f in failures}), lines
def edit(self, change):
path = self.case.evidence / "manifest.json"
data = manifest_module.read(path); change(data); manifest_module.write(path, data)
def test_clean_run_is_valid_and_writes_report(self):
record_run(self.cfg, self.case)
self.assertEqual(self.classes()[:2], (True, []))
valid, _, _ = validity.check(self.cfg, self.case)
self.assertTrue(valid)
self.assertTrue((self.case.root / "run-validity.txt").read_text().endswith("valid: YES\n"))
def test_missing_manifest(self):
self.assertEqual(self.classes()[:2], (False, ["PROVENANCE"]))
def test_provenance_harness_task_and_image(self):
record_run(self.cfg, self.case)
self.edit(lambda d: d["harness"].update({"t2/feedback.py": "changed"}))
self.assertEqual(self.classes()[1], ["PROVENANCE"])
record_run(self.cfg, self.case)
self.edit(lambda d: (d["harness"].update({"task.toml": "changed"}), d["task"].update(fingerprint="old")))
self.assertEqual(self.classes()[1], ["PROVENANCE"])
valid, classes, lines = self.classes(allow_env_mismatch=True)
self.assertTrue(valid, lines)
self.assertTrue(any(line.startswith("WARN [ENV]") for line in lines))
record_run(self.cfg, self.case)
with patch("pvbench_common.container.image_id", return_value="sha256:" + "c" * 64):
self.assertEqual(self.classes()[1], ["PROVENANCE"])
self.assertTrue(self.classes(allow_env_mismatch=True)[0])
def test_evaluation_only_harness_files_are_waived_with_a_record(self):
record_run(self.cfg, self.case)
self.edit(lambda d: d["harness"].update({"t2/evaluate.py": "0123456789abcdef"}))
self.assertEqual(self.classes()[1], ["PROVENANCE"]) # a hard failure without the flag
valid, classes, lines = self.classes(allow_env_mismatch=True)
self.assertTrue(valid, lines)
self.assertTrue(any(line.startswith("WARN [ENV] evaluation-only harness file changed since the run")
and "t2/evaluate.py: 0123456789abcdef -> " in line for line in lines), lines)
record_run(self.cfg, self.case)
self.edit(lambda d: d["harness"].update({"t2/feedback.py": "changed"})) # the session read this file
self.assertEqual(self.classes(allow_env_mismatch=True)[1], ["PROVENANCE"])
self.assertTrue(set(validity.eval_files(self.cfg)) < set(validity.harness_files(self.cfg)))
def test_isolation_hardening_network_and_mounts(self):
record_run(self.cfg, self.case)
self.edit(lambda d: d["docker_args"].remove("--read-only"))
self.assertEqual(self.classes()[1], ["ISOLATION"])
record_run(self.cfg, self.case)
def network(d):
args = d["docker_args"]; args[args.index("--network") + 1] = "bridge"
self.edit(network)
self.assertEqual(self.classes()[1], ["ISOLATION"])
record_run(self.cfg, self.case)
def writable_tool(d):
for mount in d["mounts"]:
if mount[1] == "/work/symexec.sh": mount[2] = "rw"
self.edit(writable_tool)
valid, classes, lines = self.classes()
self.assertEqual(classes, ["ISOLATION"])
self.assertIn("/work/symexec.sh", "\n".join(lines))
def test_completion_and_api_errors(self):
record_run(self.cfg, self.case, events=[{"type": "item.completed", "item": {}}])
self.assertEqual(self.classes()[1], ["COMPLETION"])
record_run(self.cfg, self.case, events=[{"type": "item.completed", "item": {}}], timed_out=True, exit_code=137)
self.assertEqual(self.classes()[1], [])
record_run(self.cfg, self.case, events=[{"type": "turn.failed", "error": "auth"}, {"type": "turn.completed"}])
self.assertEqual(self.classes()[1], ["API_ERROR"])
record_run(self.cfg, self.case, exit_code=2)
self.assertEqual(self.classes()[1], ["COMPLETION"])
def test_integrity_of_mounted_fixed_inputs(self):
record_run(self.cfg, self.case)
(self.case.workspace / "symexec.sh").write_text("exit 0\n")
valid, classes, lines = self.classes()
self.assertEqual(classes, ["INTEGRITY"])
self.assertIn("symexec.sh", "\n".join(lines))
def test_oracle_needs_no_attempt_container(self):
case = Case.create(self.cfg, "Toy", "_oracle", "oracle")
self.case = case
from t2.workspace import prepare
prepare(self.cfg, case)
record_run(self.cfg, case, role="oracle")
valid, classes, lines = self.classes()
self.assertTrue(valid, lines)
self.assertIn("PASS [ISOLATION] no agent container (oracle run)", lines)
self.assertEqual(manifest_module.read(case.evidence / "manifest.json")["image"]["id"], IMAGE_ID)
def test_harness_fingerprint_covers_the_listed_files(self):
names = set(validity.harness_fingerprint(self.cfg))
for name in ("PROMPT.md", "ANNOTATION_GUIDE.md", "JUDGE_GUIDE.md", "JUDGE_PROMPT.md", "task.toml",
"eval_sets/v1.txt", "examples/bundle.json", "t2/config.py", "t2/workspace.py",
"t2/runners.py", "t2/feedback.py", "t2/evaluate.py", "t2/judge_tools.py",
"../docker/egress/proxy.py", "coqc_sha256", "symexec_sha256"):
self.assertIn(name, names)
self.assertEqual(validity.fixed_files(self.cfg)[-1], "symexec.sh")
self.assertIn("symexec.sh", validity.fixed_inputs(self.cfg, self.case.workspace))
json.dumps(validity.harness_fingerprint(self.cfg))
if __name__ == "__main__":
unittest.main()