yhl826459 commited on
Commit
5299fdd
·
verified ·
1 Parent(s): 8b6ab09

Fix the validator findings from review on ARCTIC/shared-v1.1

Browse files

5 files rewritten, 0 added; the release's file set is unchanged (55417 paths).

ARCTIC/shared-v1.1/doc/FULL_MIGRATION_SUMMARY.json CHANGED
@@ -1,7 +1,7 @@
1
  {
2
  "phase": "local_finalized_not_uploaded",
3
  "completed_views": 3051,
4
- "created_utc": "2026-10-14T13:33:02.127894+00:00",
5
  "dataset_id": "ARCTIC",
6
  "final_root": "/data1/yanghonglei/Datasets/hand-warehouse/ARCTIC/shared-v1.1",
7
  "source_revision": "d4e2bb40cd30071e4f6483877889c1857b41b707",
@@ -36,7 +36,7 @@
36
  "source_files": 91713,
37
  "source_bytes": 791999867773,
38
  "target_files": 55416,
39
- "target_bytes": 792210999386,
40
  "tree_totals_scope": "target_files counts every release file except this one, and target_bytes their bytes, with bytecode caches (__pycache__/) excluded exactly as the release manifest excludes them -- so the manifest lists one more entry than target_files, and its byte total exceeds target_bytes by this file plus the size deltas of the two files rewritten after it (doc/*.md in step 7, doc/validation/validate_report.json in step 8, both before the manifest, which is built last so that it covers them). The review pages are rendered in step 5, before this file, so they are on both sides of that comparison. The manifest itself is outside the release tree (tmp/arctic-tools/PUBLISH_MANIFEST.json), so it appears on neither side of this comparison: the tree's own totals are what that manifest records. source_* describe v1.0, which nothing writes after the pull",
41
  "elapsed_seconds": 1041.0,
42
  "elapsed_scope": "sum of 7 incremental migrate runs' own wall time; the pull-driven gaps between them are not migration time, and runs before the loop started are not in this log",
 
1
  {
2
  "phase": "local_finalized_not_uploaded",
3
  "completed_views": 3051,
4
+ "created_utc": "2026-10-16T07:29:09.348304+00:00",
5
  "dataset_id": "ARCTIC",
6
  "final_root": "/data1/yanghonglei/Datasets/hand-warehouse/ARCTIC/shared-v1.1",
7
  "source_revision": "d4e2bb40cd30071e4f6483877889c1857b41b707",
 
36
  "source_files": 91713,
37
  "source_bytes": 791999867773,
38
  "target_files": 55416,
39
+ "target_bytes": 792211007511,
40
  "tree_totals_scope": "target_files counts every release file except this one, and target_bytes their bytes, with bytecode caches (__pycache__/) excluded exactly as the release manifest excludes them -- so the manifest lists one more entry than target_files, and its byte total exceeds target_bytes by this file plus the size deltas of the two files rewritten after it (doc/*.md in step 7, doc/validation/validate_report.json in step 8, both before the manifest, which is built last so that it covers them). The review pages are rendered in step 5, before this file, so they are on both sides of that comparison. The manifest itself is outside the release tree (tmp/arctic-tools/PUBLISH_MANIFEST.json), so it appears on neither side of this comparison: the tree's own totals are what that manifest records. source_* describe v1.0, which nothing writes after the pull",
41
  "elapsed_seconds": 1041.0,
42
  "elapsed_scope": "sum of 7 incremental migrate runs' own wall time; the pull-driven gaps between them are not migration time, and runs before the loop started are not in this log",
ARCTIC/shared-v1.1/doc/validation/validate_report.json CHANGED
@@ -1,5 +1,6 @@
1
  {
2
  "passed": true,
 
3
  "dataset_id": "ARCTIC",
4
  "schema_version": "hand-warehouse/1.1",
5
  "release_id": "shared-v1.1",
 
1
  {
2
  "passed": true,
3
+ "coverage": "full release",
4
  "dataset_id": "ARCTIC",
5
  "schema_version": "hand-warehouse/1.1",
6
  "release_id": "shared-v1.1",
ARCTIC/shared-v1.1/script/arctic_v1_1/README.md CHANGED
@@ -10,7 +10,7 @@ script/arctic_v1_1/
10
  ├── arctic_common.py ARCTIC 适配:路径、形状符号解析、逐组件结构校验、畸变规则、游离文件检测
11
  ├── migrate.py v1.0 → v1.1 迁移(可断点续跑)
12
  ├── verify.py 验收:逐视图对 v1.0 源做字节级比对(CONTRACT §6)
13
- ├── validate.py 全量结构校验 + 重新生成 release manifest
14
  ├── read_sequence.py 读取器路径验收:整条序列、全部相机(CONTRACT §6.5)
15
  ├── render.py 全量后抽样的人工复核页:54 个视图的 HTML + QC 报告 + index
16
  ├── spec/ 本版规范原文:CONTRACT.md、MIGRATION.md、schema.json
@@ -54,8 +54,26 @@ python shared-v1.1/script/arctic_v1_1/read_sequence.py s01_box_grab_01 \
54
 
55
  # 全量结构校验(只读发布树,不需要 v1.0 源;重建树外发布清单 tmp/arctic-tools/PUBLISH_MANIFEST.json)
56
  python shared-v1.1/script/arctic_v1_1/validate.py --expect-views 3051 --rewrite-check 2
 
 
 
57
  ```
58
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
59
  ### 收尾验收顺序
60
 
61
  发布清单**不在发布树里**。它记录发布树每个文件的 sha256,而树内的副本描述不了自己写下去之后的树——
 
10
  ├── arctic_common.py ARCTIC 适配:路径、形状符号解析、逐组件结构校验、畸变规则、游离文件检测
11
  ├── migrate.py v1.0 → v1.1 迁移(可断点续跑)
12
  ├── verify.py 验收:逐视图对 v1.0 源做字节级比对(CONTRACT §6)
13
+ ├── validate.py 全量结构校验 + 重新生成 release manifest(--views/--limit 为子集模式)
14
  ├── read_sequence.py 读取器路径验收:整条序列、全部相机(CONTRACT §6.5)
15
  ├── render.py 全量后抽样的人工复核页:54 个视图的 HTML + QC 报告 + index
16
  ├── spec/ 本版规范原文:CONTRACT.md、MIGRATION.md、schema.json
 
54
 
55
  # 全量结构校验(只读发布树,不需要 v1.0 源;重建树外发布清单 tmp/arctic-tools/PUBLISH_MANIFEST.json)
56
  python shared-v1.1/script/arctic_v1_1/validate.py --expect-views 3051 --rewrite-check 2
57
+
58
+ # 干活时只想看一段:--views/--limit 是子集运行,报告写 tmp、不碰清单
59
+ python shared-v1.1/script/arctic_v1_1/validate.py --views s01_box_grab_01
60
  ```
61
 
62
+ **子集运行与验收运行是两件事。** `--views`/`--limit` 一旦用上,这一次就是**子集运行**:它只断言自己
63
+ 选中的视图能支持的东西,报告标 `coverage: "partial subset"`、scope 里写明「不是全量验收那一次」,写到
64
+ 树外的 `tmp/arctic-tools/validate-partial.json`,并且**不重建发布清单**——清单是一句关于整棵树的话
65
+ (它哈希每个文件),子集运行重建它只会让清单与报告对不上。所以「57 个视图都通过」不会被读成
66
+ 「发布通过」。三条边界是硬的:
67
+
68
+ * `--views` 里写了发布树里不存在的序列名,直接报错(`no such view`),不会退化成「0 个视图、通过」;
69
+ * 子集运行**不允许**把报告写到 `doc/validation/validate_report.json`,即使显式 `--report` 指名它——
70
+ 那份报告描述整个发布,`FULL_MIGRATION_SUMMARY.json` 引用它,子集的数字是它的一个零头;
71
+ * 不带任何选择的那一次才是**验收运行**:断言 3051 个视图、339 条序列、每序列九机位就位,并最后重建
72
+ 清单(`--expect-views` 在不带选择时默认就是 3051;子集运行则默认断言自己选中的数量)。
73
+
74
+ `verify.py` 的 `--views` 同样拒绝不存在的序列名——同一类「选择落到空集、却报通过」的洞,两个工具都堵上。
75
+ 它的名字是拿**v1.0 源树**校对的,所以「源里有、还没迁」是合法选择,会被记成 absent,这正是增量运行要的。
76
+
77
  ### 收尾验收顺序
78
 
79
  发布清单**不在发布树里**。它记录发布树每个文件的 sha256,而树内的副本描述不了自己写下去之后的树——
ARCTIC/shared-v1.1/script/arctic_v1_1/validate.py CHANGED
@@ -19,6 +19,17 @@ on top:
19
 
20
  Scope: this checks the released content and layout. It does not independently prove
21
  official source correctness, and it is not human visual acceptance (CONTRACT 6).
 
 
 
 
 
 
 
 
 
 
 
22
  """
23
 
24
  from __future__ import annotations
@@ -55,6 +66,23 @@ CAMERA_IDS = {str(index) for index in range(9)}
55
  EGO_CAMERA = "0"
56
  FRAMES_REF = "camera/frames.jsonl"
57
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
58
 
59
  def release_files():
60
  """Every file of the release, in path order -- one definition, used twice.
@@ -284,28 +312,68 @@ def rewrite_check(view_dir, meta, tmp):
284
 
285
  def main(argv=None):
286
  parser = argparse.ArgumentParser(description=__doc__.splitlines()[0])
287
- parser.add_argument("--views", nargs="*", default=None, help="restrict to these sequences")
288
- parser.add_argument("--limit", type=int, default=None, help="validate at most N views")
 
 
 
 
289
  parser.add_argument("--expect-views", type=int, default=None, metavar="N",
290
- help="fail unless exactly N views are released")
 
 
 
 
291
  parser.add_argument("--rewrite-check", type=int, default=0, metavar="N",
292
  help="also re-serialise N views with the adapted writer and compare field bytes")
293
- parser.add_argument("--report", type=Path, default=RELEASE_ROOT / "doc/validation/validate_report.json")
 
 
 
 
294
  parser.add_argument("--no-manifest", action="store_true",
295
  help=f"do not rebuild the release manifest ({MANIFEST_PATH}). It "
296
  "hashes the whole release tree whatever --views says, so an "
297
  "incremental check would pay minutes for a manifest the final "
298
- "run overwrites anyway. The accepting run must not pass this "
 
299
  "(CONTRACT 6.4).")
300
  args = parser.parse_args(argv)
301
 
302
- views = sorted((RELEASE_ROOT / "data").glob("*/*/metainfo.json"))
303
- if args.views:
304
- wanted = set(args.views)
305
- views = [view for view in views if view.parent.parent.name in wanted]
 
 
 
 
 
 
 
306
  if args.limit:
307
  views = views[: args.limit]
308
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
309
  counts, sequences, flags, gaps, assets = {}, {}, {}, {}, {"dependencies": {}, "unreferenced": {}}
310
  models, uncalibrated = {}, []
311
  frames_total, files_total = 0, 0
@@ -364,11 +432,15 @@ def main(argv=None):
364
  if len(rewrites) < args.rewrite_check:
365
  rewrites.append(rewrite_check(view_dir, meta, TMP_ROOT / "rewrite-check"))
366
 
367
- if not (args.views or args.limit):
 
 
 
 
368
  for sequence, cameras in sorted(sequences.items()):
369
  assert cameras == CAMERA_IDS, (sequence, sorted(cameras))
370
- if args.expect_views is not None:
371
- assert len(views) == args.expect_views, (len(views), args.expect_views)
372
  #: ARCTIC's status flags are per-view claims and the release is NOT uniform:
373
  #: ``media_validation_policy`` is null on some sequences and a policy string on
374
  #: others, and that is the v1.0 content, not a migration defect. That each view
@@ -383,6 +455,10 @@ def main(argv=None):
383
 
384
  result = {
385
  "passed": True,
 
 
 
 
386
  "dataset_id": DATASET_ID,
387
  "schema_version": REGISTRY.schema["view_metadata"]["schema_version"],
388
  "release_id": REGISTRY.schema["view_metadata"]["release_id"],
@@ -404,8 +480,7 @@ def main(argv=None):
404
  "unreferenced_files": sorted(assets["unreferenced"]),
405
  "unreferenced_file_views": assets["unreferenced"],
406
  "rewrite_check": rewrites,
407
- "scope": "released content and layout; does not independently prove official source "
408
- "correctness or visual quality",
409
  }
410
  #: The tmp copy is a convenience for the migration loop, and its *name* is load
411
  #: bearing. It must not be "acceptance.json": the documented chain writes
@@ -414,15 +489,25 @@ def main(argv=None):
414
  #: FULL_MIGRATION_SUMMARY.json is built from -- which is exactly what happened
415
  #: once, and cost a re-run of the whole acceptance to recover.
416
  save(TMP_ROOT / "validate-latest.json", result)
417
- save(args.report, result)
418
 
 
419
  if args.no_manifest:
420
  #: reported as skipped rather than as a manifest of 0 files, which would
421
  #: read like an empty release
422
- result["release_manifest"] = {"skipped": "incremental check; not an acceptance run",
423
- "path": str(MANIFEST_PATH)}
 
 
 
 
 
 
 
 
 
424
  save(TMP_ROOT / "validate-latest.json", result)
425
- save(args.report, result)
426
  print(json.dumps(result, ensure_ascii=False, indent=2))
427
  return 0 if result["passed"] else 1
428
 
@@ -439,7 +524,7 @@ def main(argv=None):
439
  "inside it cannot hash itself",
440
  }
441
  save(TMP_ROOT / "validate-latest.json", result)
442
- save(args.report, result)
443
 
444
  manifest = []
445
  for path in release_files():
 
19
 
20
  Scope: this checks the released content and layout. It does not independently prove
21
  official source correctness, and it is not human visual acceptance (CONTRACT 6).
22
+
23
+ Run: python shared-v1.1/script/arctic_v1_1/validate.py --expect-views 3051 \
24
+ --rewrite-check 2
25
+
26
+ ``--views``/``--limit`` are for checking a corner of the tree while working on it, and a
27
+ run that uses either is a *subset* run: it asserts only what its selected views can
28
+ support, marks its report partial, writes that report to ``tmp`` rather than over the
29
+ acceptance report, and leaves the release manifest alone. A name passed to ``--views``
30
+ that matches no released sequence is an error, not an empty selection. The acceptance
31
+ pass is the run with no selection: that is the one that checks the 3,051-view /
32
+ 339-sequence census and rebuilds the manifest.
33
  """
34
 
35
  from __future__ import annotations
 
66
  EGO_CAMERA = "0"
67
  FRAMES_REF = "camera/frames.jsonl"
68
 
69
+ #: The full release's view and sequence counts. Both are claims about the *whole*
70
+ #: release, so they are asserted on a full run only: a --views/--limit run validates the
71
+ #: views it selected and reports itself as partial, because nine sound views say nothing
72
+ #: about whether the other 3,042 exist. The two scopes below keep that distinction in
73
+ #: the report the manifest is built from.
74
+ EXPECTED_VIEWS = 3051
75
+ EXPECTED_SEQUENCES = 339
76
+ SCOPE = ("released content and layout; does not independently prove official source "
77
+ "correctness or visual quality")
78
+ PARTIAL_SCOPE = (SCOPE + "; this run covered a selected subset of the release, so it is "
79
+ "not the release-wide acceptance run")
80
+ #: where a subset run writes instead of the release's own report path. The name is load
81
+ #: bearing: it must not be the acceptance report, which describes the whole release and is
82
+ #: what FULL_MIGRATION_SUMMARY.json cites.
83
+ PARTIAL_REPORT = TMP_ROOT / "validate-partial.json"
84
+ ACCEPTANCE_REPORT = RELEASE_ROOT / "doc/validation/validate_report.json"
85
+
86
 
87
  def release_files():
88
  """Every file of the release, in path order -- one definition, used twice.
 
312
 
313
  def main(argv=None):
314
  parser = argparse.ArgumentParser(description=__doc__.splitlines()[0])
315
+ parser.add_argument("--views", nargs="*", default=None,
316
+ help="restrict to these sequences. A name that matches no released "
317
+ "sequence is an error, and a run that uses this or --limit is a "
318
+ "subset run: partial report, no manifest")
319
+ parser.add_argument("--limit", type=int, default=None,
320
+ help="validate at most N views (a subset run, as --views is)")
321
  parser.add_argument("--expect-views", type=int, default=None, metavar="N",
322
+ help=f"fail unless exactly N views are released (default: "
323
+ f"{EXPECTED_VIEWS}, the full ARCTIC release, for a run with no "
324
+ "--views/--limit; a subset run defaults to the number of views "
325
+ "it selected). Without it a run that silently covered a "
326
+ "fraction of the tree would still report a pass.")
327
  parser.add_argument("--rewrite-check", type=int, default=0, metavar="N",
328
  help="also re-serialise N views with the adapted writer and compare field bytes")
329
+ parser.add_argument("--report", type=Path, default=None,
330
+ help="where the structural report is written (default: the release's "
331
+ "doc/validation/validate_report.json for a full run, "
332
+ f"{PARTIAL_REPORT} for a subset run, which must not overwrite "
333
+ "the acceptance report)")
334
  parser.add_argument("--no-manifest", action="store_true",
335
  help=f"do not rebuild the release manifest ({MANIFEST_PATH}). It "
336
  "hashes the whole release tree whatever --views says, so an "
337
  "incremental check would pay minutes for a manifest the final "
338
+ "run rebuilds anyway; a subset run skips it for the same reason "
339
+ "without being asked. The accepting run must not pass this "
340
  "(CONTRACT 6.4).")
341
  args = parser.parse_args(argv)
342
 
343
+ all_views = sorted((RELEASE_ROOT / "data").glob("*/*/metainfo.json"))
344
+ wanted = set(args.views) if args.views else None
345
+ if wanted is not None:
346
+ #: a name that matches nothing is a typo, and silently checking the views that are
347
+ #: left would let it pass as a green run over the wrong set -- which is how a
348
+ #: sequence that is not in the release at all once read as "passed, 0 views"
349
+ known = {view.parent.parent.name for view in all_views}
350
+ assert wanted <= known, ("no such view", sorted(wanted - known))
351
+ views = [view for view in all_views if view.parent.parent.name in wanted]
352
+ else:
353
+ views = all_views
354
  if args.limit:
355
  views = views[: args.limit]
356
 
357
+ #: "is this release complete?" and "is this view sound?" are different questions. The
358
+ #: sequence/view census is a claim about the whole tree, so a run with --views/--limit
359
+ #: checks its own selection instead and says so everywhere its result is reported (see
360
+ #: SCOPE/PARTIAL_SCOPE, the report's ``coverage``, and the manifest it deliberately
361
+ #: does not rebuild).
362
+ full = wanted is None and not args.limit
363
+ expect_views = args.expect_views if args.expect_views is not None else (
364
+ EXPECTED_VIEWS if full else len(views))
365
+ report_path = args.report or (ACCEPTANCE_REPORT if full else PARTIAL_REPORT)
366
+ #: Naming the acceptance report explicitly does not make a subset run an acceptance
367
+ #: run: that report describes the whole release and is what FULL_MIGRATION_SUMMARY.json
368
+ #: cites, while a subset's counts are a fraction of it by construction, and the release
369
+ #: manifest is built from its ``scope``. So the mistake is refused before anything is
370
+ #: read or written rather than honoured.
371
+ assert full or report_path.resolve() != ACCEPTANCE_REPORT.resolve(), (
372
+ f"--report names the release's acceptance report ({ACCEPTANCE_REPORT}), but "
373
+ "--views/--limit makes this a subset run; drop --report to write "
374
+ f"{PARTIAL_REPORT} instead, or drop the selection to run the acceptance pass"
375
+ )
376
+
377
  counts, sequences, flags, gaps, assets = {}, {}, {}, {}, {"dependencies": {}, "unreferenced": {}}
378
  models, uncalibrated = {}, []
379
  frames_total, files_total = 0, 0
 
432
  if len(rewrites) < args.rewrite_check:
433
  rewrites.append(rewrite_check(view_dir, meta, TMP_ROOT / "rewrite-check"))
434
 
435
+ if full:
436
+ #: the release-wide census, asserted only where it can hold: a subset's counts are
437
+ #: a fraction of these by construction, and comparing them would fail a working
438
+ #: check for a reason that has nothing to do with the views it read. Every
439
+ #: sequence carries all nine cameras, and the release carries 339 of them.
440
  for sequence, cameras in sorted(sequences.items()):
441
  assert cameras == CAMERA_IDS, (sequence, sorted(cameras))
442
+ assert len(sequences) == EXPECTED_SEQUENCES, (len(sequences), EXPECTED_SEQUENCES)
443
+ assert len(views) == expect_views, (len(views), expect_views)
444
  #: ARCTIC's status flags are per-view claims and the release is NOT uniform:
445
  #: ``media_validation_policy`` is null on some sequences and a policy string on
446
  #: others, and that is the v1.0 content, not a migration defect. That each view
 
455
 
456
  result = {
457
  "passed": True,
458
+ #: read by the reader before any number in here: a subset run's "views": 9 is not a
459
+ #: smaller release, it is a smaller *check*, and the release manifest carries this
460
+ #: same word as its own scope
461
+ "coverage": "full release" if full else "partial subset",
462
  "dataset_id": DATASET_ID,
463
  "schema_version": REGISTRY.schema["view_metadata"]["schema_version"],
464
  "release_id": REGISTRY.schema["view_metadata"]["release_id"],
 
480
  "unreferenced_files": sorted(assets["unreferenced"]),
481
  "unreferenced_file_views": assets["unreferenced"],
482
  "rewrite_check": rewrites,
483
+ "scope": SCOPE if full else PARTIAL_SCOPE,
 
484
  }
485
  #: The tmp copy is a convenience for the migration loop, and its *name* is load
486
  #: bearing. It must not be "acceptance.json": the documented chain writes
 
489
  #: FULL_MIGRATION_SUMMARY.json is built from -- which is exactly what happened
490
  #: once, and cost a re-run of the whole acceptance to recover.
491
  save(TMP_ROOT / "validate-latest.json", result)
492
+ save(report_path, result)
493
 
494
+ skip_manifest = None
495
  if args.no_manifest:
496
  #: reported as skipped rather than as a manifest of 0 files, which would
497
  #: read like an empty release
498
+ skip_manifest = "incremental check; not an acceptance run"
499
+ elif not full:
500
+ #: The manifest is a claim about the whole release -- it hashes every file -- and
501
+ #: the documented chain reads it together with the acceptance report. A subset run
502
+ #: must not leave the two disagreeing about what was accepted, so it reports the
503
+ #: manifest as skipped instead of rebuilding one to sit beside a partial report.
504
+ #: This is also what keeps a one-sequence check from paying an hour of hashing for
505
+ #: a manifest the acceptance run rebuilds anyway.
506
+ skip_manifest = "partial run; the release manifest is rebuilt by the full acceptance run"
507
+ if skip_manifest:
508
+ result["release_manifest"] = {"skipped": skip_manifest, "path": str(MANIFEST_PATH)}
509
  save(TMP_ROOT / "validate-latest.json", result)
510
+ save(report_path, result)
511
  print(json.dumps(result, ensure_ascii=False, indent=2))
512
  return 0 if result["passed"] else 1
513
 
 
524
  "inside it cannot hash itself",
525
  }
526
  save(TMP_ROOT / "validate-latest.json", result)
527
+ save(report_path, result)
528
 
529
  manifest = []
530
  for path in release_files():
ARCTIC/shared-v1.1/script/arctic_v1_1/verify.py CHANGED
@@ -364,7 +364,9 @@ def main(argv=None):
364
  parser.add_argument("--sample", type=int, default=None,
365
  help="verify at most N views (default: all migrated)")
366
  parser.add_argument("--views", nargs="*", default=None,
367
- help="restrict to these sequence ids")
 
 
368
  parser.add_argument("--complete", action="store_true",
369
  help="fail when a source view has no migrated counterpart")
370
  parser.add_argument("--no-manifest", action="store_true",
@@ -392,6 +394,13 @@ def main(argv=None):
392
  (migrated if (target_data / relative / "metainfo.json").is_file() else absent).append(view)
393
  if args.views:
394
  wanted = set(args.views)
 
 
 
 
 
 
 
395
  migrated = [v for v in migrated if v.parent.name in wanted]
396
  if args.sample:
397
  migrated = migrated[:args.sample]
 
364
  parser.add_argument("--sample", type=int, default=None,
365
  help="verify at most N views (default: all migrated)")
366
  parser.add_argument("--views", nargs="*", default=None,
367
+ help="restrict to these sequence ids. A name that matches no "
368
+ "sequence of the v1.0 source is an error: an empty selection "
369
+ "would report a pass over no views at all")
370
  parser.add_argument("--complete", action="store_true",
371
  help="fail when a source view has no migrated counterpart")
372
  parser.add_argument("--no-manifest", action="store_true",
 
394
  (migrated if (target_data / relative / "metainfo.json").is_file() else absent).append(view)
395
  if args.views:
396
  wanted = set(args.views)
397
+ #: A name that matches nothing is a typo, and an empty selection would produce a
398
+ #: report with no views and no failures -- a green run over nothing. The names are
399
+ #: checked against the *source* tree, so a sequence that exists there but has not
400
+ #: been migrated yet is still a valid selection: it is reported as absent, which is
401
+ #: what an incremental run is for.
402
+ known = {view.parent.name for view in source_views}
403
+ assert wanted <= known, ("no such view", sorted(wanted - known))
404
  migrated = [v for v in migrated if v.parent.name in wanted]
405
  if args.sample:
406
  migrated = migrated[:args.sample]