repo
stringlengths
5
53
pr_number
int32
1
321k
task_type
stringclasses
2 values
issue_text
stringlengths
0
81.2k
pr_title
stringlengths
1
319
pr_body
stringlengths
0
105k
base_sha
stringlengths
40
40
head_sha
stringlengths
40
40
gold_diff
stringlengths
0
202M
changed_files
listlengths
0
100
review_threads
listlengths
0
100
test_patch
stringlengths
0
23.4M
merged
bool
1 class
SaturnFramework/Saturn
260
issue_to_patch
fix broken links in docs
Some pages are linking to `.md` files that do not exist outside of the source repository, giving 404 errors.
143179cbd74e1bd9e1a9b5226d722c44f092cd88
2219fc43be0cbff922b628345cad5324d39c97a5
diff --git a/docs/content/explanations/routing.fsx b/docs/content/explanations/routing.fsx index 3a89d9ea..6db9e3ac 100644 --- a/docs/content/explanations/routing.fsx +++ b/docs/content/explanations/routing.fsx @@ -209,7 +209,7 @@ get "/3" (getApplication 3) ... ``` -But this is impracticle because there can be a l...
[ "docs/content/explanations/routing.fsx", "docs/content/tutorials/adding-pages.md", "docs/content/tutorials/how-to-start.md" ]
[]
true
SaturnFramework/Saturn
113
issue_to_patch
Add sample tests
472b700df7251c33c3333ccfbe8a32e571da0ae7
425bc5194c4766622db28fbb4df3231801a455f4
diff --git a/Saturn.sln b/Saturn.sln index 1f1f129b..57a06ea6 100644 --- a/Saturn.sln +++ b/Saturn.sln @@ -23,6 +23,10 @@ Project("{F2A71F9B-5D33-465A-A702-920D77279786}") = "Saturn.Extensions.Authoriza EndProject Project("{F2A71F9B-5D33-465A-A702-920D77279786}") = "CsrfSample", "sample\CsrfSample\CsrfSample.fsproj",...
[ "Saturn.sln", "build.fsx", "paket.dependencies", "paket.lock", "tests/Saturn.UnitTests/Helpers.fs", "tests/Saturn.UnitTests/Program.fs", "tests/Saturn.UnitTests/SampleTests.fs", "tests/Saturn.UnitTests/Saturn.UnitTests.fsproj", "tests/Saturn.UnitTests/paket.references" ]
[]
diff --git a/tests/Saturn.UnitTests/Helpers.fs b/tests/Saturn.UnitTests/Helpers.fs new file mode 100644 index 00000000..f5b3435f --- /dev/null +++ b/tests/Saturn.UnitTests/Helpers.fs @@ -0,0 +1,50 @@ +[<AutoOpen>] +module Helpers + +open System.Threading.Tasks +open Giraffe +open Microsoft.AspNetCore.Http +open System....
true
SaturnFramework/Saturn
121
issue_to_patch
Add abstraction for hosting Saturn on Azure Functions
dfd299d86c0034d35bfbbc93ec4c54ff8fc09970
3a677f56d5e92aa1a490bf9d48c1f51075b58484
diff --git a/.gitignore b/.gitignore index 6592c78c..29a6378e 100644 --- a/.gitignore +++ b/.gitignore @@ -391,4 +391,5 @@ packages .idea/ *.sln.iml -release.cmd \ No newline at end of file +release.cmd +.ionide/ \ No newline at end of file diff --git a/.paket/Paket.Restore.targets b/.paket/Paket.Restore.targets in...
[ ".gitignore", ".paket/Paket.Restore.targets", "Saturn.sln", "paket.dependencies", "paket.lock", "sample/FunctionsSample/Saturn.Func.fsproj", "sample/FunctionsSample/SaturnFunc.fs", "sample/FunctionsSample/host.json", "sample/FunctionsSample/paket.references", "sample/FunctionsSample/run.cmd", "s...
[ { "comment": "Minor: actual member name here mentions XML vs Negotiation", "path": "src/Saturn.AzureFunctions/AzureFunctions.fs", "hunk": "@@ -83,4 +99,30 @@ module AzureFunctions =\n member __.HostPrefix(state : FunctionState, prefix) =\n {state with HostPrefix = prefix}\n \n+ ///Confi...
true
SaturnFramework/Saturn
128
issue_to_patch
Small refactoring
d91da51120a2147bd7e042ee4f6e76cb4d58ef97
17c1488ca3896e8237e150f28b31d31d75952e75
diff --git a/Saturn.sln b/Saturn.sln index 390b877b..87a3c561 100644 --- a/Saturn.sln +++ b/Saturn.sln @@ -15,7 +15,7 @@ Project("{F2A71F9B-5D33-465A-A702-920D77279786}") = "JWTSample", "sample\JWTSamp EndProject Project("{F2A71F9B-5D33-465A-A702-920D77279786}") = "Controller.Sample", "sample\Controller.Sample\Contro...
[ "Saturn.sln", "src/Saturn.AzureFunctions/Saturn.AzureFunctions.fsproj", "src/Saturn.Extensions.Authorization/Saturn.Extensions.Authorization.fsproj", "src/Saturn.Extensions.HttpSys/AssemblyInfo.fs", "src/Saturn.Extensions.HttpSys/Saturn.Extensions.HttpSys.fsproj", "src/Saturn.Extensions.HttpSys/Saturn.Htt...
[]
true
SaturnFramework/Saturn
130
issue_to_patch
Add extension for turbolinks
5c37f2699bea76bb477b5c77145d32d35d5b5687
05fd7a814b1008ff33c1d10501ca6de318ad7ea9
diff --git a/Saturn.sln b/Saturn.sln index 87a3c561..156b0817 100644 --- a/Saturn.sln +++ b/Saturn.sln @@ -29,6 +29,10 @@ Project("{F2A71F9B-5D33-465A-A702-920D77279786}") = "Saturn.UnitTests", "tests\S EndProject Project("{F2A71F9B-5D33-465A-A702-920D77279786}") = "Saturn.AzureFunctions", "src\Saturn.AzureFunctions\...
[ "Saturn.sln", "sample/TurbolinksSample/TurbolinksSample.fs", "sample/TurbolinksSample/TurbolinksSample.fsproj", "sample/TurbolinksSample/Views/App.fs", "sample/TurbolinksSample/Views/Index.fs", "sample/TurbolinksSample/Views/OtherView.fs", "sample/TurbolinksSample/paket.references", "src/Saturn.Extens...
[ { "comment": "Tiny typo here: Turnolinks -> Turbolinks", "path": "src/Saturn.Extensions.Turbolinks/Turbolinks.fs", "hunk": "@@ -0,0 +1,76 @@\n+module Saturn\n+\n+open System\n+open Saturn\n+open Microsoft.AspNetCore.Builder\n+open Microsoft.AspNetCore.Http\n+open System.IO\n+open FSharp.Control.Tasks.Co...
true
SaturnFramework/Saturn
156
issue_to_patch
Case insensitive support
Fix https://github.com/SaturnFramework/Saturn/issues/145 Adds `case_insensitive` operation to `router` and `controller` that toggles case insensitive routing for this particular component.
b8a1ed58bbce315265308fad91696faedb72b095
35183e327d4f411265a602e600c4a596ae4de90d
diff --git a/src/Saturn/Common.fs b/src/Saturn/Common.fs index 44b049b8..09f3c617 100644 --- a/src/Saturn/Common.fs +++ b/src/Saturn/Common.fs @@ -61,14 +61,14 @@ module Common = | Some p when ctx.Request.Path.Value.Contains p -> ctx.Request.Path.Value.[p.Length..] | _ -> ctx.Request.Path.Value - let rou...
[ "src/Saturn/Common.fs", "src/Saturn/Controller.fs", "src/Saturn/Router.fs", "tests/Saturn.UnitTests/RouterTests.fs", "tests/Saturn.UnitTests/Saturn.UnitTests.fsproj" ]
[]
diff --git a/tests/Saturn.UnitTests/SampleTests.fs b/tests/Saturn.UnitTests/RouterTests.fs similarity index 50% rename from tests/Saturn.UnitTests/SampleTests.fs rename to tests/Saturn.UnitTests/RouterTests.fs index baadee95..35a2110d 100644 --- a/tests/Saturn.UnitTests/SampleTests.fs +++ b/tests/Saturn.UnitTests/Route...
true
SaturnFramework/Saturn
157
issue_to_patch
Change `use_config` to accept `IConfiguration -> 'a`
Fix #151
c5269cd9a92b2f44e1035b41d7e4ed05478acdc2
59cb081dd8876a691c0c55ba82f1ff5fb8f3e077
diff --git a/src/Saturn/Application.fs b/src/Saturn/Application.fs index ecdb00d4..874a086b 100644 --- a/src/Saturn/Application.fs +++ b/src/Saturn/Application.fs @@ -17,6 +17,7 @@ open Microsoft.AspNetCore.Authentication.Cookies open Microsoft.AspNetCore.Http open Microsoft.AspNetCore.Authorization open Microsoft.A...
[ "src/Saturn/Application.fs" ]
[]
true
SaturnFramework/Saturn
155
issue_to_patch
OAuth refactoring
This is proof of concept for the suggestions discussed in https://github.com/SaturnFramework/Saturn/issues/96. CC: @rmunn * Marks `use_custom_oauth` as obsolete * Adds `use_oauth_with_config` instead. It's following naming conventions from other authentication methods (`use_cookies_authentication_with_config` and `...
d4506da6721a592b4601a27f40eae870e7e59e15
0fb46ad9f5055cf9eec15db80fa13042d5b574fd
diff --git a/src/Saturn/Application.fs b/src/Saturn/Application.fs index 874a086b..d9be6b60 100644 --- a/src/Saturn/Application.fs +++ b/src/Saturn/Application.fs @@ -18,6 +18,12 @@ open Microsoft.AspNetCore.Http open Microsoft.AspNetCore.Authorization open Microsoft.AspNetCore.StaticFiles open Microsoft.Extensions....
[ "src/Saturn/Application.fs", "src/Saturn/Authentication.fs", "src/Saturn/Router.fs", "src/Saturn/Saturn.fsproj" ]
[]
true
ScottArbeit/Grace
398
issue_to_patch
Improve auth status text and JSON output Objective: - Improve `grace auth status` so human output starts with a localized authentication summary and structured output gives agents a useful status object instead of only the active-source string. Context and evidence: - Current human output starts with `GRACE_TOKEN: Fa...
Improve auth status text and JSON output
Closes #397 ## Summary - Updates `grace auth status` human output so the first line is the authentication summary, followed by a blank line and the emphasized active source before the remaining details. - Replaces the JSON `ReturnValue` string with a structured auth-status object containing authentication state,...
9889bb321668c35244eaa13fa9c43d1c391a09d4
7ffdcd80e5a9b5c41b6830bc82b1fb76b53e1ed2
diff --git a/scripts/validate.ps1 b/scripts/validate.ps1 index 5f47dd96..15e74b38 100644 --- a/scripts/validate.ps1 +++ b/scripts/validate.ps1 @@ -275,7 +275,7 @@ try { Write-Host "Skipped (temporarily disabled pending full repo formatting)." } elseif (-not $SkipFormat) { Write-Section "Format" -...
[ "scripts/validate.ps1", "src/Grace.CLI.LocalStateDb.Worker/Grace.CLI.LocalStateDb.Worker.fsproj", "src/Grace.CLI.Tests/Auth.Tests.fs", "src/Grace.CLI/Command/Auth.CLI.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Use active-source data for top-level auth fields**\n\nWhen a user has an active `GRACE_TOKEN` or M2M configuration but also has an old interactive cache, these top-level fields are still copied from `interactiv...
true
ScottArbeit/Grace
398
comment_to_fix
Improve auth status text and JSON output
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Use active-source data for top-level auth fields** When a user has an active `GRACE_TOKEN` or M2M configuration but also has an old interactive cache, these top-level fields are still copied from `interactiveExpiresAt`/`interactive...
9889bb321668c35244eaa13fa9c43d1c391a09d4
7ffdcd80e5a9b5c41b6830bc82b1fb76b53e1ed2
diff --git a/src/Grace.CLI/Command/Auth.CLI.fs b/src/Grace.CLI/Command/Auth.CLI.fs index b3b8e852..32f05ea9 100644 --- a/src/Grace.CLI/Command/Auth.CLI.fs +++ b/src/Grace.CLI/Command/Auth.CLI.fs @@ -13,9 +13,11 @@ open Grace.Types.Common open Microsoft.Identity.Client.Extensions.Msal open Spectre.Console open NodaTi...
[ "src/Grace.CLI/Command/Auth.CLI.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Use active-source data for top-level auth fields**\n\nWhen a user has an active `GRACE_TOKEN` or M2M configuration but also has an old interactive cache, these top-level fields are still copied from `interactiv...
true
ScottArbeit/Grace
398
comment_to_fix
Improve auth status text and JSON output
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Emit JSON expirations in an invariant format** For a cached interactive token, this conversion sends `AccessTokenExpiresAt` through `formatInstantOption`, which uses the local short date/time format via `instantToLocalTime`. In `--...
9889bb321668c35244eaa13fa9c43d1c391a09d4
7ffdcd80e5a9b5c41b6830bc82b1fb76b53e1ed2
diff --git a/src/Grace.CLI/Command/Auth.CLI.fs b/src/Grace.CLI/Command/Auth.CLI.fs index b3b8e852..32f05ea9 100644 --- a/src/Grace.CLI/Command/Auth.CLI.fs +++ b/src/Grace.CLI/Command/Auth.CLI.fs @@ -13,9 +13,11 @@ open Grace.Types.Common open Microsoft.Identity.Client.Extensions.Msal open Spectre.Console open NodaTi...
[ "src/Grace.CLI/Command/Auth.CLI.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Emit JSON expirations in an invariant format**\n\nFor a cached interactive token, this conversion sends `AccessTokenExpiresAt` through `formatInstantOption`, which uses the local short date/time format via `ins...
true
ScottArbeit/Grace
398
comment_to_fix
Improve auth status text and JSON output
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Avoid marking unverified sources authenticated** This makes `auth status` print and serialize `Authenticated` whenever M2M env vars are merely present, or whenever any interactive token bundle exists. In environments with a bad M2M...
9889bb321668c35244eaa13fa9c43d1c391a09d4
7ffdcd80e5a9b5c41b6830bc82b1fb76b53e1ed2
diff --git a/src/Grace.CLI/Command/Auth.CLI.fs b/src/Grace.CLI/Command/Auth.CLI.fs index b3b8e852..32f05ea9 100644 --- a/src/Grace.CLI/Command/Auth.CLI.fs +++ b/src/Grace.CLI/Command/Auth.CLI.fs @@ -13,9 +13,11 @@ open Grace.Types.Common open Microsoft.Identity.Client.Extensions.Msal open Spectre.Console open NodaTi...
[ "src/Grace.CLI/Command/Auth.CLI.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Avoid marking unverified sources authenticated**\n\nThis makes `auth status` print and serialize `Authenticated` whenever M2M env vars are merely present, or whenever any interactive token bundle exists. In env...
true
ScottArbeit/Grace
398
comment_to_fix
Improve auth status text and JSON output
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Preserve false auth status booleans in JSON** With Grace's shared JSON options using `JsonIgnoreCondition.WhenWritingDefault`, non-nullable `false` values are omitted from `--output Json`. In the no-source or invalid-token cases th...
9889bb321668c35244eaa13fa9c43d1c391a09d4
7ffdcd80e5a9b5c41b6830bc82b1fb76b53e1ed2
diff --git a/src/Grace.CLI/Command/Auth.CLI.fs b/src/Grace.CLI/Command/Auth.CLI.fs index b3b8e852..32f05ea9 100644 --- a/src/Grace.CLI/Command/Auth.CLI.fs +++ b/src/Grace.CLI/Command/Auth.CLI.fs @@ -13,9 +13,11 @@ open Grace.Types.Common open Microsoft.Identity.Client.Extensions.Msal open Spectre.Console open NodaTi...
[ "src/Grace.CLI/Command/Auth.CLI.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Preserve false auth status booleans in JSON**\n\nWith Grace's shared JSON options using `JsonIgnoreCondition.WhenWritingDefault`, non-nullable `false` values are omitted from `--output Json`. In the no-source o...
true
ScottArbeit/Grace
398
comment_to_fix
Improve auth status text and JSON output
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Report secure storage only after checking it** When no interactive CLI config exists, this still sets `SecureStoreAvailable` to `true` simply because no secure-store check ran and no error was recorded. In an unauthenticated enviro...
9889bb321668c35244eaa13fa9c43d1c391a09d4
7ffdcd80e5a9b5c41b6830bc82b1fb76b53e1ed2
diff --git a/src/Grace.CLI/Command/Auth.CLI.fs b/src/Grace.CLI/Command/Auth.CLI.fs index b3b8e852..32f05ea9 100644 --- a/src/Grace.CLI/Command/Auth.CLI.fs +++ b/src/Grace.CLI/Command/Auth.CLI.fs @@ -13,9 +13,11 @@ open Grace.Types.Common open Microsoft.Identity.Client.Extensions.Msal open Spectre.Console open NodaTi...
[ "src/Grace.CLI/Command/Auth.CLI.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Report secure storage only after checking it**\n\nWhen no interactive CLI config exists, this still sets `SecureStoreAvailable` to `true` simply because no secure-store check ran and no error was recorded. In a...
true
ScottArbeit/Grace
393
issue_to_patch
I21 final BLAKE3 SHA-256 audit
## Summary - Adds the final BLAKE3/SHA-256 version-hash epic audit document. - Refreshes hash, ADR, data-type, README, and glossary docs from planned/future wording to current branch behavior. - Records two final-audit follow-ups discovered by Codex Code Review Bot: #394 for CLI root-hash output parity and #395 for br...
ce480d3a451d463ba2abc869984d26d35b59c7b9
026d8280ddf3eb1ae0b55f68eead096278da6734
diff --git a/CONTEXT.md b/CONTEXT.md index bd26747a..a7986d97 100644 --- a/CONTEXT.md +++ b/CONTEXT.md @@ -15,11 +15,12 @@ hexadecimal string. A FileContentHash identifies the whole logical file, while C _Avoid_: FileVersion hash, path hash, directory hash **Version Hash**: -In ADR 0006's target model, the graph id...
[ "CONTEXT.md", "README.md", "docs/BLAKE3 SHA-256 version hash final audit.md", "docs/Data types in Grace.md", "docs/How Grace computes the SHA-256 value.md", "docs/adr/0006-blake3-and-sha256-version-hashes.md" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Correct the directory preimage recipe**\n\nFor external clients following this page to reproduce Grace hashes, this recipe does not match `Services.directoryVersionPreimage`: the implementation sorts entries by...
true
ScottArbeit/Grace
393
comment_to_fix
I21 final BLAKE3 SHA-256 audit
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Correct the directory preimage recipe** For external clients following this page to reproduce Grace hashes, this recipe does not match `Services.directoryVersionPreimage`: the implementation sorts entries by normalized path first a...
ce480d3a451d463ba2abc869984d26d35b59c7b9
026d8280ddf3eb1ae0b55f68eead096278da6734
diff --git a/docs/How Grace computes the SHA-256 value.md b/docs/How Grace computes the SHA-256 value.md index 938fe85a..30185b3b 100644 --- a/docs/How Grace computes the SHA-256 value.md +++ b/docs/How Grace computes the SHA-256 value.md @@ -2,18 +2,16 @@ ## Introduction -Grace currently uses SHA-256 values in fi...
[ "docs/How Grace computes the SHA-256 value.md" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Correct the directory preimage recipe**\n\nFor external clients following this page to reproduce Grace hashes, this recipe does not match `Services.directoryVersionPreimage`: the implementation sorts entries by...
true
ScottArbeit/Grace
393
comment_to_fix
I21 final BLAKE3 SHA-256 audit
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Don't describe reference hashes as object identity** In the current implementation, `ReferenceDto.Sha256Hash` and `ReferenceDto.Blake3Hash` are the referenced root `DirectoryVersion` hashes: `validateReferenceRootDirectoryVersionHa...
ce480d3a451d463ba2abc869984d26d35b59c7b9
026d8280ddf3eb1ae0b55f68eead096278da6734
diff --git a/CONTEXT.md b/CONTEXT.md index bd26747a..a7986d97 100644 --- a/CONTEXT.md +++ b/CONTEXT.md @@ -15,11 +15,12 @@ hexadecimal string. A FileContentHash identifies the whole logical file, while C _Avoid_: FileVersion hash, path hash, directory hash **Version Hash**: -In ADR 0006's target model, the graph id...
[ "CONTEXT.md" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Don't describe reference hashes as object identity**\n\nIn the current implementation, `ReferenceDto.Sha256Hash` and `ReferenceDto.Blake3Hash` are the referenced root `DirectoryVersion` hashes: `validateReferen...
true
ScottArbeit/Grace
393
comment_to_fix
I21 final BLAKE3 SHA-256 audit
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Don't call byte-only file hashes FileVersion identity** This ADR now says `FileVersion` version-hash calculations use BLAKE3 by default, but the implemented file BLAKE3/SHA-256 values are byte-only (`computeHashesForFile` hashes on...
ce480d3a451d463ba2abc869984d26d35b59c7b9
026d8280ddf3eb1ae0b55f68eead096278da6734
diff --git a/docs/adr/0006-blake3-and-sha256-version-hashes.md b/docs/adr/0006-blake3-and-sha256-version-hashes.md index 11e12252..a8133f67 100644 --- a/docs/adr/0006-blake3-and-sha256-version-hashes.md +++ b/docs/adr/0006-blake3-and-sha256-version-hashes.md @@ -9,18 +9,22 @@ consulted: # Use BLAKE3 and SHA-256 vers...
[ "docs/adr/0006-blake3-and-sha256-version-hashes.md" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Don't call byte-only file hashes FileVersion identity**\n\nThis ADR now says `FileVersion` version-hash calculations use BLAKE3 by default, but the implemented file BLAKE3/SHA-256 values are byte-only (`compute...
true
ScottArbeit/Grace
393
comment_to_fix
I21 final BLAKE3 SHA-256 audit
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Document the full directory preimage** For non-.NET clients, this directory algorithm is the shipped guidance for reproducing hashes, but the actual `Services.directoryVersionPreimage` also serializes the algorithm discriminator, b...
ce480d3a451d463ba2abc869984d26d35b59c7b9
026d8280ddf3eb1ae0b55f68eead096278da6734
diff --git a/docs/How Grace computes the SHA-256 value.md b/docs/How Grace computes the SHA-256 value.md index 938fe85a..30185b3b 100644 --- a/docs/How Grace computes the SHA-256 value.md +++ b/docs/How Grace computes the SHA-256 value.md @@ -2,18 +2,16 @@ ## Introduction -Grace currently uses SHA-256 values in fi...
[ "docs/How Grace computes the SHA-256 value.md" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Document the full directory preimage**\n\nFor non-.NET clients, this directory algorithm is the shipped guidance for reproducing hashes, but the actual `Services.directoryVersionPreimage` also serializes the al...
true
ScottArbeit/Grace
393
comment_to_fix
I21 final BLAKE3 SHA-256 audit
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Recheck CLI output before marking dual-hash acceptance satisfied** This acceptance entry is still contradicted by shipped CLI paths: `grace repository init` prints `Root SHA-256 hash` in human output and its `LocalOutputDto.Reposit...
ce480d3a451d463ba2abc869984d26d35b59c7b9
026d8280ddf3eb1ae0b55f68eead096278da6734
diff --git a/docs/BLAKE3 SHA-256 version hash final audit.md b/docs/BLAKE3 SHA-256 version hash final audit.md new file mode 100644 index 00000000..a3dd502d --- /dev/null +++ b/docs/BLAKE3 SHA-256 version hash final audit.md @@ -0,0 +1,204 @@ +# BLAKE3 and SHA-256 Version Hash Final Audit + +Issue #364 performed the fi...
[ "docs/BLAKE3 SHA-256 version hash final audit.md" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Recheck CLI output before marking dual-hash acceptance satisfied**\n\nThis acceptance entry is still contradicted by shipped CLI paths: `grace repository init` prints `Root SHA-256 hash` in human output and its...
true
ScottArbeit/Grace
393
comment_to_fix
I21 final BLAKE3 SHA-256 audit
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Recheck SHA-only branch query schemas before closing lookup parity** This row marks branch/OpenAPI lookup parity satisfied, but the branch query schemas still expose SHA-256-only locator shapes: `GetBranchParameters` and `GetRefere...
ce480d3a451d463ba2abc869984d26d35b59c7b9
026d8280ddf3eb1ae0b55f68eead096278da6734
diff --git a/docs/BLAKE3 SHA-256 version hash final audit.md b/docs/BLAKE3 SHA-256 version hash final audit.md new file mode 100644 index 00000000..a3dd502d --- /dev/null +++ b/docs/BLAKE3 SHA-256 version hash final audit.md @@ -0,0 +1,204 @@ +# BLAKE3 and SHA-256 Version Hash Final Audit + +Issue #364 performed the fi...
[ "docs/BLAKE3 SHA-256 version hash final audit.md" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Recheck SHA-only branch query schemas before closing lookup parity**\n\nThis row marks branch/OpenAPI lookup parity satisfied, but the branch query schemas still expose SHA-256-only locator shapes: `GetBranchPa...
true
ScottArbeit/Grace
393
comment_to_fix
I21 final BLAKE3 SHA-256 audit
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Do not mark incomplete epic as implemented** This ADR now says epic #343 is implemented, but the new final-audit doc still lists release-contract gaps as deferred follow-ups: branch/reference OpenAPI lookup schemas still inherit SH...
ce480d3a451d463ba2abc869984d26d35b59c7b9
026d8280ddf3eb1ae0b55f68eead096278da6734
diff --git a/docs/adr/0006-blake3-and-sha256-version-hashes.md b/docs/adr/0006-blake3-and-sha256-version-hashes.md index 11e12252..a8133f67 100644 --- a/docs/adr/0006-blake3-and-sha256-version-hashes.md +++ b/docs/adr/0006-blake3-and-sha256-version-hashes.md @@ -9,18 +9,22 @@ consulted: # Use BLAKE3 and SHA-256 vers...
[ "docs/adr/0006-blake3-and-sha256-version-hashes.md" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Do not mark incomplete epic as implemented**\n\nThis ADR now says epic #343 is implemented, but the new final-audit doc still lists release-contract gaps as deferred follow-ups: branch/reference OpenAPI lookup ...
true
ScottArbeit/Grace
393
comment_to_fix
I21 final BLAKE3 SHA-256 audit
**<sub><sub>![P3 Badge](https://img.shields.io/badge/P3-lightgrey?style=flat)</sub></sub> Remove the phantom branch endpoint from the audit** The audit says static OpenAPI still models `/branch/getByName`, but a repo-wide search for `branch/getByName|getByName|GetByName` only finds this new audit line, not an OpenAPI...
ce480d3a451d463ba2abc869984d26d35b59c7b9
026d8280ddf3eb1ae0b55f68eead096278da6734
diff --git a/docs/BLAKE3 SHA-256 version hash final audit.md b/docs/BLAKE3 SHA-256 version hash final audit.md new file mode 100644 index 00000000..a3dd502d --- /dev/null +++ b/docs/BLAKE3 SHA-256 version hash final audit.md @@ -0,0 +1,204 @@ +# BLAKE3 and SHA-256 Version Hash Final Audit + +Issue #364 performed the fi...
[ "docs/BLAKE3 SHA-256 version hash final audit.md" ]
[ { "comment": "**<sub><sub>![P3 Badge](https://img.shields.io/badge/P3-lightgrey?style=flat)</sub></sub> Remove the phantom branch endpoint from the audit**\n\nThe audit says static OpenAPI still models `/branch/getByName`, but a repo-wide search for `branch/getByName|getByName|GetByName` only finds this new au...
true
ScottArbeit/Grace
393
comment_to_fix
I21 final BLAKE3 SHA-256 audit
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Wrap the audit table for markdownlint** The root `AGENTS.md` says MarkdownLint must be followed with MD013 capped at 120 characters, but the new acceptance matrix is written as single-line table rows; this row alone is over 600 cha...
ce480d3a451d463ba2abc869984d26d35b59c7b9
026d8280ddf3eb1ae0b55f68eead096278da6734
diff --git a/docs/BLAKE3 SHA-256 version hash final audit.md b/docs/BLAKE3 SHA-256 version hash final audit.md new file mode 100644 index 00000000..a3dd502d --- /dev/null +++ b/docs/BLAKE3 SHA-256 version hash final audit.md @@ -0,0 +1,204 @@ +# BLAKE3 and SHA-256 Version Hash Final Audit + +Issue #364 performed the fi...
[ "docs/BLAKE3 SHA-256 version hash final audit.md" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Wrap the audit table for markdownlint**\n\nThe root `AGENTS.md` says MarkdownLint must be followed with MD013 capped at 120 characters, but the new acceptance matrix is written as single-line table rows; this r...
true
ScottArbeit/Grace
392
issue_to_patch
I20 end-to-end dual-hash workflow proof
## Summary - Proves the end-to-end CLI current-state/save/reference workflow carries BLAKE3 alongside SHA-256 through local state and reference resolution. - Tightens branch/reference reuse so the root directory id, SHA-256, and BLAKE3 must all match; same SHA-256 with different BLAKE3 no longer reuses a stale referen...
02b9bdb8cd0ceeb5766bd5027dbc2d85f1c4202d
4b5672ed9bdabbf96e8fa7ca46937ee63060fffe
diff --git a/src/Grace.CLI.Tests/Branch.CLI.Tests.fs b/src/Grace.CLI.Tests/Branch.CLI.Tests.fs index 0ac71cb7..ab9f65d7 100644 --- a/src/Grace.CLI.Tests/Branch.CLI.Tests.fs +++ b/src/Grace.CLI.Tests/Branch.CLI.Tests.fs @@ -68,6 +68,7 @@ module BranchCommandTests = TargetReferenceId = targetReferenceId ...
[ "src/Grace.CLI.Tests/Branch.CLI.Tests.fs", "src/Grace.CLI.Tests/CurrentStateCapture.CLI.Tests.fs", "src/Grace.CLI/Command/Services.CLI.fs", "src/Grace.Server.Tests/Branch.Server.Tests.fs" ]
[ { "comment": "**<sub><sub>![P1 Badge](https://img.shields.io/badge/P1-orange?style=flat)</sub></sub> Preserve manifest references for missing BLAKE3 locals**\n\nWhen an unchanged manifest-backed file comes from local state that still has an empty/missing `Blake3Hash`, this dual-hash lookup cannot match the sav...
true
ScottArbeit/Grace
392
comment_to_fix
I20 end-to-end dual-hash workflow proof
**<sub><sub>![P1 Badge](https://img.shields.io/badge/P1-orange?style=flat)</sub></sub> Preserve manifest references for missing BLAKE3 locals** When an unchanged manifest-backed file comes from local state that still has an empty/missing `Blake3Hash`, this dual-hash lookup cannot match the saved manifest-backed `File...
02b9bdb8cd0ceeb5766bd5027dbc2d85f1c4202d
4b5672ed9bdabbf96e8fa7ca46937ee63060fffe
diff --git a/src/Grace.CLI/Command/Services.CLI.fs b/src/Grace.CLI/Command/Services.CLI.fs index d1669887..47cebd51 100644 --- a/src/Grace.CLI/Command/Services.CLI.fs +++ b/src/Grace.CLI/Command/Services.CLI.fs @@ -154,7 +154,7 @@ module Services = /// Gets a DirectoryInfo instance for the parent directory of ...
[ "src/Grace.CLI/Command/Services.CLI.fs" ]
[ { "comment": "**<sub><sub>![P1 Badge](https://img.shields.io/badge/P1-orange?style=flat)</sub></sub> Preserve manifest references for missing BLAKE3 locals**\n\nWhen an unchanged manifest-backed file comes from local state that still has an empty/missing `Blake3Hash`, this dual-hash lookup cannot match the sav...
true
ScottArbeit/Grace
392
comment_to_fix
I20 end-to-end dual-hash workflow proof
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Treat unknown root BLAKE3 as a match** When the local root identity still has an empty `RootDirectoryBlake3Hash` but the branch DTO has the same `DirectoryId`/SHA-256 with a populated reference BLAKE3, this exact comparison no long...
02b9bdb8cd0ceeb5766bd5027dbc2d85f1c4202d
4b5672ed9bdabbf96e8fa7ca46937ee63060fffe
diff --git a/src/Grace.CLI/Command/Services.CLI.fs b/src/Grace.CLI/Command/Services.CLI.fs index d1669887..47cebd51 100644 --- a/src/Grace.CLI/Command/Services.CLI.fs +++ b/src/Grace.CLI/Command/Services.CLI.fs @@ -154,7 +154,7 @@ module Services = /// Gets a DirectoryInfo instance for the parent directory of ...
[ "src/Grace.CLI/Command/Services.CLI.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Treat unknown root BLAKE3 as a match**\n\nWhen the local root identity still has an empty `RootDirectoryBlake3Hash` but the branch DTO has the same `DirectoryId`/SHA-256 with a populated reference BLAKE3, this ...
true
ScottArbeit/Grace
391
issue_to_patch
I19 non-version SHA-256 regression proof
## Summary - Adds focused regression proof that protected non-version SHA-256 surfaces did not move during the BLAKE3 version-hash rollout. - Proves webhook payload/signature SHA-256/HMAC behavior, dedupe protected-label preimage, PAT token format, and CAS-vs-version hash boundaries. - Keeps the slice test-only: no pr...
4b466c09451b8d4b516a576f40c2e2b342ff4646
61a49b7e3e44fc09586e9f957df931500de359ff
diff --git a/src/Grace.Authorization.Tests/PersonalAccessToken.Tests.fs b/src/Grace.Authorization.Tests/PersonalAccessToken.Tests.fs index 99d39a5b..eff74409 100644 --- a/src/Grace.Authorization.Tests/PersonalAccessToken.Tests.fs +++ b/src/Grace.Authorization.Tests/PersonalAccessToken.Tests.fs @@ -16,9 +16,11 @@ type P...
[ "src/Grace.Authorization.Tests/PersonalAccessToken.Tests.fs", "src/Grace.Server.Unit.Tests/DedupeIndex.Server.Tests.fs", "src/Grace.Server.Unit.Tests/WebhookDispatch.Server.Tests.fs", "src/Grace.Types.Tests/ContentAddress.Types.Tests.fs" ]
[]
true
ScottArbeit/Grace
390
issue_to_patch
I18 OpenAPI and SDK dual-hash contract refresh
## Summary - Refreshes static OpenAPI contract surfaces so `FileVersion` and `DirectoryVersion` expose both `Sha256Hash` and `Blake3Hash` while preserving SHA-256 compatibility. - Adds `DirectoryVersionId`, `OwnerId`, `OrganizationId`, `HashesValidated`, and `ContentReference` to public OpenAPI version DTO schemas whe...
25143503027d51abd2fe2cd0bfdf9ca542656ff6
0aff20447a0bb241d215ac3a03a5577d77c64bf4
diff --git a/sdk/dotnet/Grace.Sdk.Harness/Internal/Generated/GraceRawClientMetadata.cs b/sdk/dotnet/Grace.Sdk.Harness/Internal/Generated/GraceRawClientMetadata.cs index 4abf6348..996b2a7d 100644 --- a/sdk/dotnet/Grace.Sdk.Harness/Internal/Generated/GraceRawClientMetadata.cs +++ b/sdk/dotnet/Grace.Sdk.Harness/Internal/G...
[ "sdk/dotnet/Grace.Sdk.Harness/Internal/Generated/GraceRawClientMetadata.cs", "sdk/generated/generator-report.json", "sdk/generated/matrix/generator-matrix-evidence.json", "sdk/generated/matrix/openapi-generator/python/.openapi-generator/FILES", "sdk/generated/matrix/openapi-generator/python/README.md", "s...
[ { "comment": "**<sub><sub>![P1 Badge](https://img.shields.io/badge/P1-orange?style=flat)</sub></sub> Allow BLAKE3 prefixes in hash parameters**\n\nThis global `Blake3Hash` pattern is reused by `/directory/getByBlake3Hash` and `/diff/getDiffByBlake3Hash`, but those handlers deliberately accept unique BLAKE3 pre...
diff --git a/sdk/generated/matrix/openapi-generator/python/test/test_branch_api_dto.py b/sdk/generated/matrix/openapi-generator/python/test/test_branch_api_dto.py index e93a5cd1..0d24100b 100644 --- a/sdk/generated/matrix/openapi-generator/python/test/test_branch_api_dto.py +++ b/sdk/generated/matrix/openapi-generator/...
true
ScottArbeit/Grace
390
comment_to_fix
I18 OpenAPI and SDK dual-hash contract refresh
**<sub><sub>![P1 Badge](https://img.shields.io/badge/P1-orange?style=flat)</sub></sub> Allow BLAKE3 prefixes in hash parameters** This global `Blake3Hash` pattern is reused by `/directory/getByBlake3Hash` and `/diff/getDiffByBlake3Hash`, but those handlers deliberately accept unique BLAKE3 prefixes: `DirectoryVersion...
25143503027d51abd2fe2cd0bfdf9ca542656ff6
0aff20447a0bb241d215ac3a03a5577d77c64bf4
diff --git a/src/OpenAPI/Shared.Components.OpenAPI.yaml b/src/OpenAPI/Shared.Components.OpenAPI.yaml index b0e5ba8d..4d68660c 100644 --- a/src/OpenAPI/Shared.Components.OpenAPI.yaml +++ b/src/OpenAPI/Shared.Components.OpenAPI.yaml @@ -47,6 +47,10 @@ components: type: string format: uuid example: 33...
[ "src/OpenAPI/Shared.Components.OpenAPI.yaml" ]
[ { "comment": "**<sub><sub>![P1 Badge](https://img.shields.io/badge/P1-orange?style=flat)</sub></sub> Allow BLAKE3 prefixes in hash parameters**\n\nThis global `Blake3Hash` pattern is reused by `/directory/getByBlake3Hash` and `/diff/getDiffByBlake3Hash`, but those handlers deliberately accept unique BLAKE3 pre...
true
ScottArbeit/Grace
390
comment_to_fix
I18 OpenAPI and SDK dual-hash contract refresh
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Fix the FileContentReference example shape** This newly added example does not match the referenced `FileContentReference` schema or the F# contract: the schema requires `Class`, `ReferenceType`, and `Manifest`, while the example o...
25143503027d51abd2fe2cd0bfdf9ca542656ff6
0aff20447a0bb241d215ac3a03a5577d77c64bf4
diff --git a/src/OpenAPI/Shared.Components.OpenAPI.yaml b/src/OpenAPI/Shared.Components.OpenAPI.yaml index b0e5ba8d..4d68660c 100644 --- a/src/OpenAPI/Shared.Components.OpenAPI.yaml +++ b/src/OpenAPI/Shared.Components.OpenAPI.yaml @@ -47,6 +47,10 @@ components: type: string format: uuid example: 33...
[ "src/OpenAPI/Shared.Components.OpenAPI.yaml" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Fix the FileContentReference example shape**\n\nThis newly added example does not match the referenced `FileContentReference` schema or the F# contract: the schema requires `Class`, `ReferenceType`, and `Manife...
true
ScottArbeit/Grace
390
comment_to_fix
I18 OpenAPI and SDK dual-hash contract refresh
**<sub><sub>![P1 Badge](https://img.shields.io/badge/P1-orange?style=flat)</sub></sub> Allow SHA-256 prefixes in branch hash parameters** This global `Sha256Hash` pattern is also reused by branch locator fields such as `BranchQueryParameters` and `CreateReferenceParameters`, but the branch handlers intentionally acce...
25143503027d51abd2fe2cd0bfdf9ca542656ff6
0aff20447a0bb241d215ac3a03a5577d77c64bf4
diff --git a/src/OpenAPI/Shared.Components.OpenAPI.yaml b/src/OpenAPI/Shared.Components.OpenAPI.yaml index b0e5ba8d..4d68660c 100644 --- a/src/OpenAPI/Shared.Components.OpenAPI.yaml +++ b/src/OpenAPI/Shared.Components.OpenAPI.yaml @@ -47,6 +47,10 @@ components: type: string format: uuid example: 33...
[ "src/OpenAPI/Shared.Components.OpenAPI.yaml" ]
[ { "comment": "**<sub><sub>![P1 Badge](https://img.shields.io/badge/P1-orange?style=flat)</sub></sub> Allow SHA-256 prefixes in branch hash parameters**\n\nThis global `Sha256Hash` pattern is also reused by branch locator fields such as `BranchQueryParameters` and `CreateReferenceParameters`, but the branch han...
true
ScottArbeit/Grace
390
comment_to_fix
I18 OpenAPI and SDK dual-hash contract refresh
**<sub><sub>![P1 Badge](https://img.shields.io/badge/P1-orange?style=flat)</sub></sub> Make nullable content references generate nullable manifests** Adding `ContentReference` to `FileVersion` exposes `FileContentReference` through directory/file-version responses, but the referenced schema still uses a required `Man...
25143503027d51abd2fe2cd0bfdf9ca542656ff6
0aff20447a0bb241d215ac3a03a5577d77c64bf4
diff --git a/src/OpenAPI/Shared.Components.OpenAPI.yaml b/src/OpenAPI/Shared.Components.OpenAPI.yaml index b0e5ba8d..4d68660c 100644 --- a/src/OpenAPI/Shared.Components.OpenAPI.yaml +++ b/src/OpenAPI/Shared.Components.OpenAPI.yaml @@ -47,6 +47,10 @@ components: type: string format: uuid example: 33...
[ "src/OpenAPI/Shared.Components.OpenAPI.yaml" ]
[ { "comment": "**<sub><sub>![P1 Badge](https://img.shields.io/badge/P1-orange?style=flat)</sub></sub> Make nullable content references generate nullable manifests**\n\nAdding `ContentReference` to `FileVersion` exposes `FileContentReference` through directory/file-version responses, but the referenced schema st...
true
ScottArbeit/Grace
390
comment_to_fix
I18 OpenAPI and SDK dual-hash contract refresh
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Allow empty Blake3Hash on FileVersion payloads** This newly exposes `FileVersion.Blake3Hash` through the full-hash schema, so generated validators reject `Blake3Hash: ""`; however the storage compatibility endpoints still accept le...
25143503027d51abd2fe2cd0bfdf9ca542656ff6
0aff20447a0bb241d215ac3a03a5577d77c64bf4
diff --git a/src/OpenAPI/Shared.Components.OpenAPI.yaml b/src/OpenAPI/Shared.Components.OpenAPI.yaml index b0e5ba8d..4d68660c 100644 --- a/src/OpenAPI/Shared.Components.OpenAPI.yaml +++ b/src/OpenAPI/Shared.Components.OpenAPI.yaml @@ -47,6 +47,10 @@ components: type: string format: uuid example: 33...
[ "src/OpenAPI/Shared.Components.OpenAPI.yaml" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Allow empty Blake3Hash on FileVersion payloads**\n\nThis newly exposes `FileVersion.Blake3Hash` through the full-hash schema, so generated validators reject `Blake3Hash: \"\"`; however the storage compatibility...
true
ScottArbeit/Grace
390
comment_to_fix
I18 OpenAPI and SDK dual-hash contract refresh
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Allow legacy directory versions without BLAKE3** This maps `DirectoryVersion.Blake3Hash` to the full-hash schema, so generated clients that validate responses reject persisted legacy directory versions whose `Blake3Hash` is still e...
25143503027d51abd2fe2cd0bfdf9ca542656ff6
0aff20447a0bb241d215ac3a03a5577d77c64bf4
diff --git a/src/OpenAPI/Shared.Components.OpenAPI.yaml b/src/OpenAPI/Shared.Components.OpenAPI.yaml index b0e5ba8d..4d68660c 100644 --- a/src/OpenAPI/Shared.Components.OpenAPI.yaml +++ b/src/OpenAPI/Shared.Components.OpenAPI.yaml @@ -47,6 +47,10 @@ components: type: string format: uuid example: 33...
[ "src/OpenAPI/Shared.Components.OpenAPI.yaml" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Allow legacy directory versions without BLAKE3**\n\nThis maps `DirectoryVersion.Blake3Hash` to the full-hash schema, so generated clients that validate responses reject persisted legacy directory versions whose...
true
ScottArbeit/Grace
390
comment_to_fix
I18 OpenAPI and SDK dual-hash contract refresh
**<sub><sub>![P1 Badge](https://img.shields.io/badge/P1-orange?style=flat)</sub></sub> Use SHA-256 prefix schema for hash lookups** This tightened 64-character `Sha256Hash` pattern is still referenced by `/directory/getBySha256Hash` and `/diff/getDiffBySha256Hash`, even though those server paths support unique SHA-25...
25143503027d51abd2fe2cd0bfdf9ca542656ff6
0aff20447a0bb241d215ac3a03a5577d77c64bf4
diff --git a/src/OpenAPI/Shared.Components.OpenAPI.yaml b/src/OpenAPI/Shared.Components.OpenAPI.yaml index b0e5ba8d..4d68660c 100644 --- a/src/OpenAPI/Shared.Components.OpenAPI.yaml +++ b/src/OpenAPI/Shared.Components.OpenAPI.yaml @@ -47,6 +47,10 @@ components: type: string format: uuid example: 33...
[ "src/OpenAPI/Shared.Components.OpenAPI.yaml" ]
[ { "comment": "**<sub><sub>![P1 Badge](https://img.shields.io/badge/P1-orange?style=flat)</sub></sub> Use SHA-256 prefix schema for hash lookups**\n\nThis tightened 64-character `Sha256Hash` pattern is still referenced by `/directory/getBySha256Hash` and `/diff/getDiffBySha256Hash`, even though those server pat...
true
ScottArbeit/Grace
390
comment_to_fix
I18 OpenAPI and SDK dual-hash contract refresh
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Keep persisted BLAKE3 hashes lowercase** This compatibility schema is used for `FileVersion.Blake3Hash` and `DirectoryVersion.Blake3Hash`, but it now allows uppercase full hashes, so generated validators and the new examples accept...
25143503027d51abd2fe2cd0bfdf9ca542656ff6
0aff20447a0bb241d215ac3a03a5577d77c64bf4
diff --git a/src/OpenAPI/Shared.Components.OpenAPI.yaml b/src/OpenAPI/Shared.Components.OpenAPI.yaml index b0e5ba8d..4d68660c 100644 --- a/src/OpenAPI/Shared.Components.OpenAPI.yaml +++ b/src/OpenAPI/Shared.Components.OpenAPI.yaml @@ -47,6 +47,10 @@ components: type: string format: uuid example: 33...
[ "src/OpenAPI/Shared.Components.OpenAPI.yaml" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Keep persisted BLAKE3 hashes lowercase**\n\nThis compatibility schema is used for `FileVersion.Blake3Hash` and `DirectoryVersion.Blake3Hash`, but it now allows uppercase full hashes, so generated validators and...
true
ScottArbeit/Grace
390
comment_to_fix
I18 OpenAPI and SDK dual-hash contract refresh
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Keep persisted SHA-256 hashes lowercase** The full `Sha256Hash` schema is also used by persisted `FileVersion` and `DirectoryVersion` payloads, but the new pattern/description accepts uppercase hashes even though save validation co...
25143503027d51abd2fe2cd0bfdf9ca542656ff6
0aff20447a0bb241d215ac3a03a5577d77c64bf4
diff --git a/src/OpenAPI/Shared.Components.OpenAPI.yaml b/src/OpenAPI/Shared.Components.OpenAPI.yaml index b0e5ba8d..4d68660c 100644 --- a/src/OpenAPI/Shared.Components.OpenAPI.yaml +++ b/src/OpenAPI/Shared.Components.OpenAPI.yaml @@ -47,6 +47,10 @@ components: type: string format: uuid example: 33...
[ "src/OpenAPI/Shared.Components.OpenAPI.yaml" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Keep persisted SHA-256 hashes lowercase**\n\nThe full `Sha256Hash` schema is also used by persisted `FileVersion` and `DirectoryVersion` payloads, but the new pattern/description accepts uppercase hashes even t...
true
ScottArbeit/Grace
390
comment_to_fix
I18 OpenAPI and SDK dual-hash contract refresh
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Allow legacy ReferenceDto BLAKE3 hashes** When this tightened full-hash schema is reused by `ReferenceDto.Blake3Hash` (`src/OpenAPI/Dto.Components.OpenAPI.yaml`), generated clients now reject `Blake3Hash: ""`. The server still has ...
25143503027d51abd2fe2cd0bfdf9ca542656ff6
0aff20447a0bb241d215ac3a03a5577d77c64bf4
diff --git a/src/OpenAPI/Shared.Components.OpenAPI.yaml b/src/OpenAPI/Shared.Components.OpenAPI.yaml index b0e5ba8d..4d68660c 100644 --- a/src/OpenAPI/Shared.Components.OpenAPI.yaml +++ b/src/OpenAPI/Shared.Components.OpenAPI.yaml @@ -47,6 +47,10 @@ components: type: string format: uuid example: 33...
[ "src/OpenAPI/Shared.Components.OpenAPI.yaml" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Allow legacy ReferenceDto BLAKE3 hashes**\n\nWhen this tightened full-hash schema is reused by `ReferenceDto.Blake3Hash` (`src/OpenAPI/Dto.Components.OpenAPI.yaml`), generated clients now reject `Blake3Hash: \"...
true
ScottArbeit/Grace
390
comment_to_fix
I18 OpenAPI and SDK dual-hash contract refresh
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Allow default ReferenceDto SHA values** This strict full-hash schema is also reused by `ReferenceDto.Sha256Hash`, but `/repository/getReferencesByReferenceId` can deliberately return `ReferenceDto.Default` when the request includes...
25143503027d51abd2fe2cd0bfdf9ca542656ff6
0aff20447a0bb241d215ac3a03a5577d77c64bf4
diff --git a/src/OpenAPI/Shared.Components.OpenAPI.yaml b/src/OpenAPI/Shared.Components.OpenAPI.yaml index b0e5ba8d..4d68660c 100644 --- a/src/OpenAPI/Shared.Components.OpenAPI.yaml +++ b/src/OpenAPI/Shared.Components.OpenAPI.yaml @@ -47,6 +47,10 @@ components: type: string format: uuid example: 33...
[ "src/OpenAPI/Shared.Components.OpenAPI.yaml" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Allow default ReferenceDto SHA values**\n\nThis strict full-hash schema is also reused by `ReferenceDto.Sha256Hash`, but `/repository/getReferencesByReferenceId` can deliberately return `ReferenceDto.Default` w...
true
ScottArbeit/Grace
390
comment_to_fix
I18 OpenAPI and SDK dual-hash contract refresh
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Expose BLAKE3 upload metadata** This regenerated `UploadMetadata` model still exposes only `Sha256Hash`, but `/storage/getUploadMetadataForFiles` now builds `StorageParameterContracts.UploadMetadata` with both `Sha256Hash` and `Bla...
25143503027d51abd2fe2cd0bfdf9ca542656ff6
0aff20447a0bb241d215ac3a03a5577d77c64bf4
diff --git a/sdk/generated/matrix/openapi-generator/python/grace_generated_openapi_probe/models/upload_metadata.py b/sdk/generated/matrix/openapi-generator/python/grace_generated_openapi_probe/models/upload_metadata.py index 41cfc853..eb85ddbf 100644 --- a/sdk/generated/matrix/openapi-generator/python/grace_generated_o...
[ "sdk/generated/matrix/openapi-generator/python/grace_generated_openapi_probe/models/upload_metadata.py" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Expose BLAKE3 upload metadata**\n\nThis regenerated `UploadMetadata` model still exposes only `Sha256Hash`, but `/storage/getUploadMetadataForFiles` now builds `StorageParameterContracts.UploadMetadata` with bo...
true
ScottArbeit/Grace
390
comment_to_fix
I18 OpenAPI and SDK dual-hash contract refresh
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Allow legacy upload metadata without BLAKE3** When `/storage/getUploadMetadataForFiles` is called with a legacy `FileVersion` whose `Blake3Hash` is empty, the server copies that empty value into `StorageParameterContracts.UploadMet...
25143503027d51abd2fe2cd0bfdf9ca542656ff6
0aff20447a0bb241d215ac3a03a5577d77c64bf4
diff --git a/src/OpenAPI/Storage.Components.OpenAPI.yaml b/src/OpenAPI/Storage.Components.OpenAPI.yaml index eaed4256..5be21915 100644 --- a/src/OpenAPI/Storage.Components.OpenAPI.yaml +++ b/src/OpenAPI/Storage.Components.OpenAPI.yaml @@ -384,12 +384,15 @@ UploadMetadata: format: uri Sha256Hash: $ref...
[ "src/OpenAPI/Storage.Components.OpenAPI.yaml" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Allow legacy upload metadata without BLAKE3**\n\nWhen `/storage/getUploadMetadataForFiles` is called with a legacy `FileVersion` whose `Blake3Hash` is empty, the server copies that empty value into `StoragePara...
true
ScottArbeit/Grace
390
comment_to_fix
I18 OpenAPI and SDK dual-hash contract refresh
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Permit default SHA values in SHA lookup responses** For `/directory/getBySha256Hash`, the server still returns `DirectoryVersion.Default` with `Sha256Hash = ""` when the prefix lookup has no unique match (`DirectoryVersion.Server.f...
25143503027d51abd2fe2cd0bfdf9ca542656ff6
0aff20447a0bb241d215ac3a03a5577d77c64bf4
diff --git a/src/OpenAPI/Shared.Components.OpenAPI.yaml b/src/OpenAPI/Shared.Components.OpenAPI.yaml index b0e5ba8d..4d68660c 100644 --- a/src/OpenAPI/Shared.Components.OpenAPI.yaml +++ b/src/OpenAPI/Shared.Components.OpenAPI.yaml @@ -47,6 +47,10 @@ components: type: string format: uuid example: 33...
[ "src/OpenAPI/Shared.Components.OpenAPI.yaml" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Permit default SHA values in SHA lookup responses**\n\nFor `/directory/getBySha256Hash`, the server still returns `DirectoryVersion.Default` with `Sha256Hash = \"\"` when the prefix lookup has no unique match (...
true
ScottArbeit/Grace
390
comment_to_fix
I18 OpenAPI and SDK dual-hash contract refresh
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Reject unresolved SHA diff prefixes before querying** Because these fields now accept unique SHA-256 prefixes, `/diff/getDiffBySha256Hash` needs the same no-match/ambiguous handling as the BLAKE3 path. The current handler calls `ge...
25143503027d51abd2fe2cd0bfdf9ca542656ff6
0aff20447a0bb241d215ac3a03a5577d77c64bf4
diff --git a/src/OpenAPI/Diff.Components.OpenAPI.yaml b/src/OpenAPI/Diff.Components.OpenAPI.yaml index 172ef961..9565eb59 100644 --- a/src/OpenAPI/Diff.Components.OpenAPI.yaml +++ b/src/OpenAPI/Diff.Components.OpenAPI.yaml @@ -43,15 +43,15 @@ BranchName: $ref: 'Shared.Components.OpenAPI.yaml...
[ "src/OpenAPI/Diff.Components.OpenAPI.yaml" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Reject unresolved SHA diff prefixes before querying**\n\nBecause these fields now accept unique SHA-256 prefixes, `/diff/getDiffBySha256Hash` needs the same no-match/ambiguous handling as the BLAKE3 path. The c...
true
ScottArbeit/Grace
389
issue_to_patch
I17 CLI JSON dual-hash contract
## Summary - Adds `Blake3Hash` beside existing `Sha256Hash` in CLI-local maintenance JSON DTOs for list-contents files/directories and scan directory versions. - Adds `RootBlake3Hash` beside existing `RootSha256Hash` in maintenance summary/stats JSON, including metadata fallback when the root directory row is absent. ...
4ec2c55972c0bee72f044224f81d3630f8f134e9
30ffe7cc2b7df27045f2a2b7d7c8ab4cd84f00ec
diff --git a/src/Grace.CLI.Tests/Branch.CLI.Tests.fs b/src/Grace.CLI.Tests/Branch.CLI.Tests.fs index 72e6f987..0ac71cb7 100644 --- a/src/Grace.CLI.Tests/Branch.CLI.Tests.fs +++ b/src/Grace.CLI.Tests/Branch.CLI.Tests.fs @@ -505,6 +505,54 @@ module BranchCommandTests = .GetString() |> should equal "...
[ "src/Grace.CLI.Tests/Branch.CLI.Tests.fs", "src/Grace.CLI.Tests/CommandOutputContract.CLI.Tests.fs", "src/Grace.CLI.Tests/Maintenance.CLI.Tests.fs", "src/Grace.CLI/Command/Common.CLI.fs", "src/Grace.CLI/Command/Maintenance.CLI.fs", "src/Grace.CLI/Command/Services.CLI.fs", "src/Grace.CLI/CommandOutputCon...
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Include BLAKE3 in the maintenance summary DTO**\n\nWhen `grace maintenance list-contents --output Json --list-directories false` is used, or when consumers call `maintenance stats`/`maintenance update-index`, t...
true
ScottArbeit/Grace
389
comment_to_fix
I17 CLI JSON dual-hash contract
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Include BLAKE3 in the maintenance summary DTO** When `grace maintenance list-contents --output Json --list-directories false` is used, or when consumers call `maintenance stats`/`maintenance update-index`, the summary remains the o...
4ec2c55972c0bee72f044224f81d3630f8f134e9
30ffe7cc2b7df27045f2a2b7d7c8ab4cd84f00ec
diff --git a/src/Grace.CLI/Command/Maintenance.CLI.fs b/src/Grace.CLI/Command/Maintenance.CLI.fs index 874e0e7c..b442b12d 100644 --- a/src/Grace.CLI/Command/Maintenance.CLI.fs +++ b/src/Grace.CLI/Command/Maintenance.CLI.fs @@ -125,6 +125,21 @@ module Maintenance = rootHashFromIndex |> Option.orElse ro...
[ "src/Grace.CLI/Command/Maintenance.CLI.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Include BLAKE3 in the maintenance summary DTO**\n\nWhen `grace maintenance list-contents --output Json --list-directories false` is used, or when consumers call `maintenance stats`/`maintenance update-index`, t...
true
ScottArbeit/Grace
388
issue_to_patch
I16 CLI human BLAKE3 output defaults
## Summary - Adds shared human version-hash display helpers for BLAKE3-first CLI output. - Updates branch `list-contents` and branch reference tables so human output defaults to BLAKE3 version hashes. - Keeps SHA-256 visible by explicit `--show-sha256` opt-in, and keeps `--full-hashes` controlling abbreviated versus f...
763ba45348c2439fc3b200d473be28411afb9356
6964c26859bfdb1bfa4563d2808d308b9b742250
diff --git a/src/Grace.CLI.Tests/Branch.CLI.Tests.fs b/src/Grace.CLI.Tests/Branch.CLI.Tests.fs index a5742332..72e6f987 100644 --- a/src/Grace.CLI.Tests/Branch.CLI.Tests.fs +++ b/src/Grace.CLI.Tests/Branch.CLI.Tests.fs @@ -130,40 +130,46 @@ module BranchCommandTests = let private directorySha256Hash = Sha256Hash...
[ "src/Grace.CLI.Tests/Branch.CLI.Tests.fs", "src/Grace.CLI/Command/Branch.CLI.fs", "src/Grace.CLI/Command/Common.CLI.fs", "src/Grace.CLI/Command/Reference.CLI.fs" ]
[]
true
ScottArbeit/Grace
387
issue_to_patch
I15 CLI hash option parsing and mode binding
## Summary - Adds shared CLI hash option and mode binding in `Common.HashOptions`. - Adds `--full-hashes` and `--show-sha256` option names while keeping `--full-sha` as a deprecated compatibility display path. - Binds explicit lookup modes for no hash, BLAKE3, SHA-256 compatibility, and paired SHA-256+BLAKE3 locators....
bd128edd1fc8537a56303cd2bb965e1c18f299da
81656cdf0efa564d7ff0b14cf8752ab6c27307da
diff --git a/src/Grace.CLI.Tests/Branch.CLI.Parsing.Tests.fs b/src/Grace.CLI.Tests/Branch.CLI.Parsing.Tests.fs index a0f468cf..f1eb6535 100644 --- a/src/Grace.CLI.Tests/Branch.CLI.Parsing.Tests.fs +++ b/src/Grace.CLI.Tests/Branch.CLI.Parsing.Tests.fs @@ -16,6 +16,9 @@ module BranchCommandParsingTests = let private...
[ "src/Grace.CLI.Tests/Branch.CLI.Parsing.Tests.fs", "src/Grace.CLI.Tests/Branch.CLI.Tests.fs", "src/Grace.CLI.Tests/CommandOutputContract.CLI.Tests.fs", "src/Grace.CLI/Command/Branch.CLI.fs", "src/Grace.CLI/Command/Common.CLI.fs", "src/Grace.CLI/Command/Diff.CLI.fs", "src/Grace.CLI/Command/DirectoryVersi...
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Honor --full-hashes for list-contents**\n\nWhen `branch list-contents --full-hashes` (or deprecated `--full-sha`) is accepted here, the list-contents renderer still unconditionally formats the root hash and eac...
true
ScottArbeit/Grace
387
comment_to_fix
I15 CLI hash option parsing and mode binding
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Honor --full-hashes for list-contents** When `branch list-contents --full-hashes` (or deprecated `--full-sha`) is accepted here, the list-contents renderer still unconditionally formats the root hash and each directory entry with `...
bd128edd1fc8537a56303cd2bb965e1c18f299da
81656cdf0efa564d7ff0b14cf8752ab6c27307da
diff --git a/src/Grace.CLI/Command/Branch.CLI.fs b/src/Grace.CLI/Command/Branch.CLI.fs index fbfc813e..678a7be2 100644 --- a/src/Grace.CLI/Command/Branch.CLI.fs +++ b/src/Grace.CLI/Command/Branch.CLI.fs @@ -186,14 +186,11 @@ module Branch = Arity = ArgumentArity.ZeroOrOne ) - let ...
[ "src/Grace.CLI/Command/Branch.CLI.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Honor --full-hashes for list-contents**\n\nWhen `branch list-contents --full-hashes` (or deprecated `--full-sha`) is accepted here, the list-contents renderer still unconditionally formats the root hash and eac...
true
ScottArbeit/Grace
387
comment_to_fix
I15 CLI hash option parsing and mode binding
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Allow server-valid short hash prefixes** When a repository has a unique 2- to 7-character version hash prefix, the server-side validators still accept those prefixes (`^[0-9a-fA-F]{2,64}$`) and the server integration tests exercise...
bd128edd1fc8537a56303cd2bb965e1c18f299da
81656cdf0efa564d7ff0b14cf8752ab6c27307da
diff --git a/src/Grace.CLI/Command/Common.CLI.fs b/src/Grace.CLI/Command/Common.CLI.fs index 90ff7087..71a0312f 100644 --- a/src/Grace.CLI/Command/Common.CLI.fs +++ b/src/Grace.CLI/Command/Common.CLI.fs @@ -221,6 +221,144 @@ module Common = Recursive = true ) + module HashOptions = + ...
[ "src/Grace.CLI/Command/Common.CLI.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Allow server-valid short hash prefixes**\n\nWhen a repository has a unique 2- to 7-character version hash prefix, the server-side validators still accept those prefixes (`^[0-9a-fA-F]{2,64}$`) and the server in...
true
ScottArbeit/Grace
386
issue_to_patch
I14 Reference BLAKE3 locator semantics
## Summary - Adds source-only `--blake3-hash` support to `reference assign` parsing while preserving SHA-256 locator evidence. - Threads root DirectoryVersion BLAKE3 through reference assign parameter construction for the source-only reference command path. - Keeps the stale `Reference.Build` command tree unrouted fro...
fb5fd8196c5a6c83bbce72b3de8e7421ef3b0064
c09f5abbd2a096ff8931b79937e925481c55a3dc
diff --git a/src/Grace.CLI.Tests/Branch.CLI.Parsing.Tests.fs b/src/Grace.CLI.Tests/Branch.CLI.Parsing.Tests.fs index da22e5e2..a0f468cf 100644 --- a/src/Grace.CLI.Tests/Branch.CLI.Parsing.Tests.fs +++ b/src/Grace.CLI.Tests/Branch.CLI.Parsing.Tests.fs @@ -5,6 +5,7 @@ open Grace.CLI open Grace.CLI.Command open NUnit.Fr...
[ "src/Grace.CLI.Tests/Branch.CLI.Parsing.Tests.fs", "src/Grace.CLI.Tests/CommandOutputContract.CLI.Tests.fs", "src/Grace.CLI/Command/Reference.CLI.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Preserve the assign reference message**\n\nNow that `reference assign` is registered as a root command, `--message` is exposed on a user-reachable path, but this parameter object never sets `Message`, so the se...
true
ScottArbeit/Grace
386
comment_to_fix
I14 Reference BLAKE3 locator semantics
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Preserve the assign reference message** Now that `reference assign` is registered as a root command, `--message` is exposed on a user-reachable path, but this parameter object never sets `Message`, so the server receives the defaul...
fb5fd8196c5a6c83bbce72b3de8e7421ef3b0064
c09f5abbd2a096ff8931b79937e925481c55a3dc
diff --git a/src/Grace.CLI/Command/Reference.CLI.fs b/src/Grace.CLI/Command/Reference.CLI.fs index 163830cb..a4bf6df8 100644 --- a/src/Grace.CLI/Command/Reference.CLI.fs +++ b/src/Grace.CLI/Command/Reference.CLI.fs @@ -184,6 +184,15 @@ module Reference = Arity = ArgumentArity.ExactlyOne ) ...
[ "src/Grace.CLI/Command/Reference.CLI.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Preserve the assign reference message**\n\nNow that `reference assign` is registered as a root command, `--message` is exposed on a user-reachable path, but this parameter object never sets `Message`, so the se...
true
ScottArbeit/Grace
386
comment_to_fix
I14 Reference BLAKE3 locator semantics
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Register live reference commands as routed contracts** This test now compares discovered live commands against all registry entries, but `CommandOutputContract.entries` still marks the newly-routed `reference.*` commands as `Source...
fb5fd8196c5a6c83bbce72b3de8e7421ef3b0064
c09f5abbd2a096ff8931b79937e925481c55a3dc
diff --git a/src/Grace.CLI.Tests/CommandOutputContract.CLI.Tests.fs b/src/Grace.CLI.Tests/CommandOutputContract.CLI.Tests.fs index d974e5e8..ab5d59b7 100644 --- a/src/Grace.CLI.Tests/CommandOutputContract.CLI.Tests.fs +++ b/src/Grace.CLI.Tests/CommandOutputContract.CLI.Tests.fs @@ -276,7 +276,7 @@ module CommandOutputC...
[ "src/Grace.CLI.Tests/CommandOutputContract.CLI.Tests.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Register live reference commands as routed contracts**\n\nThis test now compares discovered live commands against all registry entries, but `CommandOutputContract.entries` still marks the newly-routed `referenc...
true
ScottArbeit/Grace
385
issue_to_patch
Add Branch BLAKE3 locator semantics
Related to #356 Part of #343 ## Summary - Adds branch BLAKE3 root locator support across shared branch parameter contracts, server branch routes, SDK parameter DTO usage, and CLI branch commands. - Resolves BLAKE3 prefixes through authorized root `DirectoryVersion` version graph scope, preserving branch identity/name...
e70e43b8195709d816dba4ad2f6a87c64c78b77c
a4f0f29b57ef6db78fcc5ce57589db0aa2a66be0
diff --git a/sdk/generated/matrix/generator-matrix-evidence.json b/sdk/generated/matrix/generator-matrix-evidence.json index 2cb78497..905831e2 100644 --- a/sdk/generated/matrix/generator-matrix-evidence.json +++ b/sdk/generated/matrix/generator-matrix-evidence.json @@ -2,14 +2,14 @@ "schemaVersion": 1, "issue": ...
[ "sdk/generated/matrix/generator-matrix-evidence.json", "sdk/generated/matrix/openapi-generator/python/.openapi-generator/FILES", "sdk/generated/matrix/openapi-generator/python/README.md", "sdk/generated/matrix/openapi-generator/python/docs/BranchHashQueryParameters.md", "sdk/generated/matrix/openapi-generat...
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Reject inconsistent hash locators**\n\nWhen `DirectoryVersionId` is empty and a request supplies both `Sha256Hash` and `Blake3Hash`, this branch resolves solely by `Blake3Hash` and ignores the SHA locator. A ca...
diff --git a/sdk/generated/matrix/openapi-generator/python/test/test_branch_hash_query_parameters.py b/sdk/generated/matrix/openapi-generator/python/test/test_branch_hash_query_parameters.py new file mode 100644 index 00000000..3254e657 --- /dev/null +++ b/sdk/generated/matrix/openapi-generator/python/test/test_branch_...
true
ScottArbeit/Grace
385
comment_to_fix
Add Branch BLAKE3 locator semantics
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Reject inconsistent hash locators** When `DirectoryVersionId` is empty and a request supplies both `Sha256Hash` and `Blake3Hash`, this branch resolves solely by `Blake3Hash` and ignores the SHA locator. A caller can therefore send ...
e70e43b8195709d816dba4ad2f6a87c64c78b77c
a4f0f29b57ef6db78fcc5ce57589db0aa2a66be0
diff --git a/src/Grace.Server/Branch.Server.fs b/src/Grace.Server/Branch.Server.fs index ed6d388b..80c31b91 100644 --- a/src/Grace.Server/Branch.Server.fs +++ b/src/Grace.Server/Branch.Server.fs @@ -567,13 +567,14 @@ module Branch = return! context |> result500ServerError graceError } - l...
[ "src/Grace.Server/Branch.Server.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Reject inconsistent hash locators**\n\nWhen `DirectoryVersionId` is empty and a request supplies both `Sha256Hash` and `Blake3Hash`, this branch resolves solely by `Blake3Hash` and ignores the SHA locator. A ca...
true
ScottArbeit/Grace
385
comment_to_fix
Add Branch BLAKE3 locator semantics
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Validate BLAKE3 assign input before resolving** For `/branch/assign`, this resolver is invoked before `processCommand` runs the validations that now include `InvalidBlake3Hash`. When a caller supplies only a malformed `Blake3Hash` ...
e70e43b8195709d816dba4ad2f6a87c64c78b77c
a4f0f29b57ef6db78fcc5ce57589db0aa2a66be0
diff --git a/src/Grace.Server/Branch.Server.fs b/src/Grace.Server/Branch.Server.fs index ed6d388b..80c31b91 100644 --- a/src/Grace.Server/Branch.Server.fs +++ b/src/Grace.Server/Branch.Server.fs @@ -567,13 +567,14 @@ module Branch = return! context |> result500ServerError graceError } - l...
[ "src/Grace.Server/Branch.Server.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Validate BLAKE3 assign input before resolving**\n\nFor `/branch/assign`, this resolver is invoked before `processCommand` runs the validations that now include `InvalidBlake3Hash`. When a caller supplies only a...
true
ScottArbeit/Grace
385
comment_to_fix
Add Branch BLAKE3 locator semantics
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Don't expose BLAKE3 on unsupported query DTOs** Adding `Blake3Hash` to `BranchQueryParameters` also adds it to `GetReferenceParameters` and `GetBranchParameters`, but those handlers do not consume it. In particular, `/branch/getRef...
e70e43b8195709d816dba4ad2f6a87c64c78b77c
a4f0f29b57ef6db78fcc5ce57589db0aa2a66be0
diff --git a/src/Grace.Shared/Parameters/Branch.Parameters.fs b/src/Grace.Shared/Parameters/Branch.Parameters.fs index 460073fc..0a4794d2 100644 --- a/src/Grace.Shared/Parameters/Branch.Parameters.fs +++ b/src/Grace.Shared/Parameters/Branch.Parameters.fs @@ -26,6 +26,11 @@ module Branch = member val public Sha...
[ "src/Grace.Shared/Parameters/Branch.Parameters.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Don't expose BLAKE3 on unsupported query DTOs**\n\nAdding `Blake3Hash` to `BranchQueryParameters` also adds it to `GetReferenceParameters` and `GetBranchParameters`, but those handlers do not consume it. In par...
true
ScottArbeit/Grace
385
comment_to_fix
Add Branch BLAKE3 locator semantics
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Resolve recursive-size BLAKE3 lookups for any directory** In `/branch/getRecursiveSize`, the new BLAKE3 path only searches root directory versions, while the existing SHA path in the same handler uses `Services.getDirectoryVersionB...
e70e43b8195709d816dba4ad2f6a87c64c78b77c
a4f0f29b57ef6db78fcc5ce57589db0aa2a66be0
diff --git a/src/Grace.Server/Branch.Server.fs b/src/Grace.Server/Branch.Server.fs index ed6d388b..80c31b91 100644 --- a/src/Grace.Server/Branch.Server.fs +++ b/src/Grace.Server/Branch.Server.fs @@ -567,13 +567,14 @@ module Branch = return! context |> result500ServerError graceError } - l...
[ "src/Grace.Server/Branch.Server.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Resolve recursive-size BLAKE3 lookups for any directory**\n\nIn `/branch/getRecursiveSize`, the new BLAKE3 path only searches root directory versions, while the existing SHA path in the same handler uses `Servi...
true
ScottArbeit/Grace
385
comment_to_fix
Add Branch BLAKE3 locator semantics
**<sub><sub>![P1 Badge](https://img.shields.io/badge/P1-orange?style=flat)</sub></sub> Preserve BLAKE3 when using Grace Watch** When `grace watch` is running, this branch skips the local status scan and seeds the reference command from `graceWatchStatus`, but it now hard-codes an empty `Blake3Hash`. The server-side r...
e70e43b8195709d816dba4ad2f6a87c64c78b77c
a4f0f29b57ef6db78fcc5ce57589db0aa2a66be0
diff --git a/src/Grace.CLI/Command/Branch.CLI.fs b/src/Grace.CLI/Command/Branch.CLI.fs index c9840ac0..fbfc813e 100644 --- a/src/Grace.CLI/Command/Branch.CLI.fs +++ b/src/Grace.CLI/Command/Branch.CLI.fs @@ -279,6 +279,15 @@ module Branch = Arity = ArgumentArity.ExactlyOne ) + let ...
[ "src/Grace.CLI/Command/Branch.CLI.fs" ]
[ { "comment": "**<sub><sub>![P1 Badge](https://img.shields.io/badge/P1-orange?style=flat)</sub></sub> Preserve BLAKE3 when using Grace Watch**\n\nWhen `grace watch` is running, this branch skips the local status scan and seeds the reference command from `graceWatchStatus`, but it now hard-codes an empty `Blake3...
true
ScottArbeit/Grace
385
comment_to_fix
Add Branch BLAKE3 locator semantics
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Require a root locator for reference commands** After changing the SHA validation to `isEmptyOrValid...` and adding an also-optional BLAKE3 check, `/branch/commit` (and the sibling promote/checkpoint/save/tag/external handlers with...
e70e43b8195709d816dba4ad2f6a87c64c78b77c
a4f0f29b57ef6db78fcc5ce57589db0aa2a66be0
diff --git a/src/Grace.Server/Branch.Server.fs b/src/Grace.Server/Branch.Server.fs index ed6d388b..80c31b91 100644 --- a/src/Grace.Server/Branch.Server.fs +++ b/src/Grace.Server/Branch.Server.fs @@ -567,13 +567,14 @@ module Branch = return! context |> result500ServerError graceError } - l...
[ "src/Grace.Server/Branch.Server.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Require a root locator for reference commands**\n\nAfter changing the SHA validation to `isEmptyOrValid...` and adding an also-optional BLAKE3 check, `/branch/commit` (and the sibling promote/checkpoint/save/ta...
true
ScottArbeit/Grace
385
comment_to_fix
Add Branch BLAKE3 locator semantics
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Reject inconsistent hashes in branch content lookups** When a client supplies both `Sha256Hash` and `Blake3Hash` through the new hash-query DTOs, this branch resolves solely by BLAKE3 and never checks that the SHA prefix matches th...
e70e43b8195709d816dba4ad2f6a87c64c78b77c
a4f0f29b57ef6db78fcc5ce57589db0aa2a66be0
diff --git a/src/Grace.Server/Branch.Server.fs b/src/Grace.Server/Branch.Server.fs index ed6d388b..80c31b91 100644 --- a/src/Grace.Server/Branch.Server.fs +++ b/src/Grace.Server/Branch.Server.fs @@ -567,13 +567,14 @@ module Branch = return! context |> result500ServerError graceError } - l...
[ "src/Grace.Server/Branch.Server.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Reject inconsistent hashes in branch content lookups**\n\nWhen a client supplies both `Sha256Hash` and `Blake3Hash` through the new hash-query DTOs, this branch resolves solely by BLAKE3 and never checks that t...
true
ScottArbeit/Grace
385
comment_to_fix
Add Branch BLAKE3 locator semantics
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Validate SHA assign input before resolving** This preflight now catches malformed BLAKE3 before the `/branch/assign` resolver runs, but malformed `Sha256Hash` still reaches `tryResolveRootDirectoryVersionForReferenceCommand` first....
e70e43b8195709d816dba4ad2f6a87c64c78b77c
a4f0f29b57ef6db78fcc5ce57589db0aa2a66be0
diff --git a/src/Grace.Server/Branch.Server.fs b/src/Grace.Server/Branch.Server.fs index ed6d388b..80c31b91 100644 --- a/src/Grace.Server/Branch.Server.fs +++ b/src/Grace.Server/Branch.Server.fs @@ -567,13 +567,14 @@ module Branch = return! context |> result500ServerError graceError } - l...
[ "src/Grace.Server/Branch.Server.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Validate SHA assign input before resolving**\n\nThis preflight now catches malformed BLAKE3 before the `/branch/assign` resolver runs, but malformed `Sha256Hash` still reaches `tryResolveRootDirectoryVersionFor...
true
ScottArbeit/Grace
385
comment_to_fix
Add Branch BLAKE3 locator semantics
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Preserve BLAKE3 evidence during switch** When `grace branch switch` is invoked with both `--sha256-hash` and the newly added `--blake3-hash` but no branch/reference target, this branch takes the SHA path first and passes `String.Em...
e70e43b8195709d816dba4ad2f6a87c64c78b77c
a4f0f29b57ef6db78fcc5ce57589db0aa2a66be0
diff --git a/src/Grace.CLI/Command/Branch.CLI.fs b/src/Grace.CLI/Command/Branch.CLI.fs index c9840ac0..fbfc813e 100644 --- a/src/Grace.CLI/Command/Branch.CLI.fs +++ b/src/Grace.CLI/Command/Branch.CLI.fs @@ -279,6 +279,15 @@ module Branch = Arity = ArgumentArity.ExactlyOne ) + let ...
[ "src/Grace.CLI/Command/Branch.CLI.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Preserve BLAKE3 evidence during switch**\n\nWhen `grace branch switch` is invoked with both `--sha256-hash` and the newly added `--blake3-hash` but no branch/reference target, this branch takes the SHA path fir...
true
ScottArbeit/Grace
384
issue_to_patch
Add Diff BLAKE3 lookup
Related to #355 Part of #343 ## Summary - Adds BLAKE3-based diff lookup with `POST /diff/getDiffByBlake3Hash`, SDK support, and `grace diff blake3 --blake3-hash-1/--b1 --blake3-hash-2/--b2`. - Resolves both diff sides independently through scoped version graph BLAKE3 lookup before creating the Diff actor. - Preserves...
fb2b4c1b86a98c1e5eaaed1b84cd01cce2da9073
c81202a0fa15b9301ed9bbd81455570ec6350ab8
diff --git a/docs/Machine-readable CLI output.md b/docs/Machine-readable CLI output.md index 87a38c15..40732cae 100644 --- a/docs/Machine-readable CLI output.md +++ b/docs/Machine-readable CLI output.md @@ -129,8 +129,8 @@ Rejected selectors return a JSON error envelope. They do not produce partial out The final reg...
[ "docs/Machine-readable CLI output.md", "sdk/generated/matrix/generator-matrix-evidence.json", "sdk/generated/matrix/openapi-generator/python/.openapi-generator/FILES", "sdk/generated/matrix/openapi-generator/python/README.md", "sdk/generated/matrix/openapi-generator/python/docs/DiffsApi.md", "sdk/generate...
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Preserve old diff reminder actor IDs**\n\nWhen a Diff reminder was created before this change, its persisted `ActorId` still uses the old `guid-with-hyphens*guid-with-hyphens` key format, but this parser now al...
diff --git a/sdk/generated/matrix/openapi-generator/python/test/test_diffs_api.py b/sdk/generated/matrix/openapi-generator/python/test/test_diffs_api.py index 48a92908..00760968 100644 --- a/sdk/generated/matrix/openapi-generator/python/test/test_diffs_api.py +++ b/sdk/generated/matrix/openapi-generator/python/test/tes...
true
ScottArbeit/Grace
384
comment_to_fix
Add Diff BLAKE3 lookup
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Preserve old diff reminder actor IDs** When a Diff reminder was created before this change, its persisted `ActorId` still uses the old `guid-with-hyphens*guid-with-hyphens` key format, but this parser now always slices the first 64...
fb2b4c1b86a98c1e5eaaed1b84cd01cce2da9073
c81202a0fa15b9301ed9bbd81455570ec6350ab8
diff --git a/src/Grace.Actors/Reminder.Actor.fs b/src/Grace.Actors/Reminder.Actor.fs index a3de2ac3..71f4a8da 100644 --- a/src/Grace.Actors/Reminder.Actor.fs +++ b/src/Grace.Actors/Reminder.Actor.fs @@ -142,7 +142,7 @@ module Reminder = // Parse the Guid from the ActorId. Example: "referenceact...
[ "src/Grace.Actors/Reminder.Actor.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Preserve old diff reminder actor IDs**\n\nWhen a Diff reminder was created before this change, its persisted `ActorId` still uses the old `guid-with-hyphens*guid-with-hyphens` key format, but this parser now al...
true
ScottArbeit/Grace
384
comment_to_fix
Add Diff BLAKE3 lookup
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Include all repository hashes when choosing the prefix** This helper only compares `rootWithChild` against the two hashes passed in `others`, but `/diff/getDiffByBlake3Hash` resolves prefixes across every `DirectoryVersion` in the ...
fb2b4c1b86a98c1e5eaaed1b84cd01cce2da9073
c81202a0fa15b9301ed9bbd81455570ec6350ab8
diff --git a/src/Grace.Server.Tests/Diff.Server.Tests.fs b/src/Grace.Server.Tests/Diff.Server.Tests.fs index 39322eec..8aa86a67 100644 --- a/src/Grace.Server.Tests/Diff.Server.Tests.fs +++ b/src/Grace.Server.Tests/Diff.Server.Tests.fs @@ -5,6 +5,7 @@ open Grace.Shared open Grace.Shared.Utilities open Grace.Shared.Val...
[ "src/Grace.Server.Tests/Diff.Server.Tests.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Include all repository hashes when choosing the prefix**\n\nThis helper only compares `rootWithChild` against the two hashes passed in `others`, but `/diff/getDiffByBlake3Hash` resolves prefixes across every `D...
true
ScottArbeit/Grace
384
comment_to_fix
Add Diff BLAKE3 lookup
**<sub><sub>![P1 Badge](https://img.shields.io/badge/P1-orange?style=flat)</sub></sub> Keep large diff payloads out of Cosmos storage** Diff actors persist the entire `DiffDto`, including inline and side-by-side file diffs, so changing this state from the dedicated blob-backed `GraceDiffStorage` (still configured as ...
fb2b4c1b86a98c1e5eaaed1b84cd01cce2da9073
c81202a0fa15b9301ed9bbd81455570ec6350ab8
diff --git a/src/Grace.Actors/Diff.Actor.fs b/src/Grace.Actors/Diff.Actor.fs index ab726ad5..f40bbb5a 100644 --- a/src/Grace.Actors/Diff.Actor.fs +++ b/src/Grace.Actors/Diff.Actor.fs @@ -101,10 +101,8 @@ module Diff = return differences } - /// Deconstructs an ActorId of the form ...
[ "src/Grace.Actors/Diff.Actor.fs" ]
[ { "comment": "**<sub><sub>![P1 Badge](https://img.shields.io/badge/P1-orange?style=flat)</sub></sub> Keep large diff payloads out of Cosmos storage**\n\nDiff actors persist the entire `DiffDto`, including inline and side-by-side file diffs, so changing this state from the dedicated blob-backed `GraceDiffStorag...
true
ScottArbeit/Grace
384
comment_to_fix
Add Diff BLAKE3 lookup
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Migrate legacy diff blobs before applying their ETag** When a diff state already exists only under the legacy blob name, `ReadStateAsync` can load that legacy blob and store its ETag on `grainState`, but `WriteStateAsync` always ta...
fb2b4c1b86a98c1e5eaaed1b84cd01cce2da9073
c81202a0fa15b9301ed9bbd81455570ec6350ab8
diff --git a/src/Grace.Server/DiffBlobGrainStorage.Server.fs b/src/Grace.Server/DiffBlobGrainStorage.Server.fs new file mode 100644 index 00000000..11f6b986 --- /dev/null +++ b/src/Grace.Server/DiffBlobGrainStorage.Server.fs @@ -0,0 +1,133 @@ +namespace Grace.Server + +open Azure +open Azure.Storage.Blobs +open Azure.S...
[ "src/Grace.Server/DiffBlobGrainStorage.Server.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Migrate legacy diff blobs before applying their ETag**\n\nWhen a diff state already exists only under the legacy blob name, `ReadStateAsync` can load that legacy blob and store its ETag on `grainState`, but `Wr...
true
ScottArbeit/Grace
384
comment_to_fix
Add Diff BLAKE3 lookup
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Return JSON for diff blake3 JSON mode** When the new command is invoked as `grace --output Json diff blake3 ...`, `hasOutput` is false because it only covers Normal/Verbose output, so this branch is skipped and the handler returns ...
fb2b4c1b86a98c1e5eaaed1b84cd01cce2da9073
c81202a0fa15b9301ed9bbd81455570ec6350ab8
diff --git a/src/Grace.CLI/Command/Diff.CLI.fs b/src/Grace.CLI/Command/Diff.CLI.fs index 3c320fb5..a3cf5b73 100644 --- a/src/Grace.CLI/Command/Diff.CLI.fs +++ b/src/Grace.CLI/Command/Diff.CLI.fs @@ -146,6 +146,24 @@ module Diff = Arity = ArgumentArity.ExactlyOne ) + let blake3Hash...
[ "src/Grace.CLI/Command/Diff.CLI.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Return JSON for diff blake3 JSON mode**\n\nWhen the new command is invoked as `grace --output Json diff blake3 ...`, `hasOutput` is false because it only covers Normal/Verbose output, so this branch is skipped ...
true
ScottArbeit/Grace
383
issue_to_patch
Add DirectoryVersion BLAKE3 lookup
Related to #354 Part of #343 ## Summary - Adds the public DirectoryVersion BLAKE3 lookup surface with `POST /directory/getByBlake3Hash` and `DirectoryVersion.GetByBlake3Hash` in the SDK. - Backs BLAKE3 lookup with the scoped I10 zero/one/many resolver instead of SHA-only first-match behavior. - Adds route validation,...
cabd9cc8432f3a3f3b0cc0c9f7baf80d86c2d7ba
95a2e4a389bb214f7f06d8a74f54fc57dc3bd3aa
diff --git a/sdk/generated/matrix/generator-matrix-evidence.json b/sdk/generated/matrix/generator-matrix-evidence.json index 52841819..9dfd36ba 100644 --- a/sdk/generated/matrix/generator-matrix-evidence.json +++ b/sdk/generated/matrix/generator-matrix-evidence.json @@ -2,7 +2,7 @@ "schemaVersion": 1, "issue": 22...
[ "sdk/generated/matrix/generator-matrix-evidence.json", "sdk/generated/matrix/openapi-generator/python/.openapi-generator/FILES", "sdk/generated/matrix/openapi-generator/python/README.md", "sdk/generated/matrix/openapi-generator/python/docs/DirectoriesApi.md", "sdk/generated/matrix/openapi-generator/python/d...
[ { "comment": "**<sub><sub>![P1 Badge](https://img.shields.io/badge/P1-orange?style=flat)</sub></sub> Bind SDK lookups to the domain DirectoryVersion**\n\nIn this `Grace.SDK.DirectoryVersion` type, the unqualified generic argument `DirectoryVersion` resolves to the SDK facade itself, not the payload type return...
diff --git a/sdk/generated/matrix/openapi-generator/python/test/test_branch_api_dto.py b/sdk/generated/matrix/openapi-generator/python/test/test_branch_api_dto.py index b0ef5352..e93a5cd1 100644 --- a/sdk/generated/matrix/openapi-generator/python/test/test_branch_api_dto.py +++ b/sdk/generated/matrix/openapi-generator/...
true
ScottArbeit/Grace
383
comment_to_fix
Add DirectoryVersion BLAKE3 lookup
**<sub><sub>![P1 Badge](https://img.shields.io/badge/P1-orange?style=flat)</sub></sub> Bind SDK lookups to the domain DirectoryVersion** In this `Grace.SDK.DirectoryVersion` type, the unqualified generic argument `DirectoryVersion` resolves to the SDK facade itself, not the payload type returned by the server (`Grace...
cabd9cc8432f3a3f3b0cc0c9f7baf80d86c2d7ba
95a2e4a389bb214f7f06d8a74f54fc57dc3bd3aa
diff --git a/src/Grace.SDK/DirectoryVersion.SDK.fs b/src/Grace.SDK/DirectoryVersion.SDK.fs index b3753318..9bd4ae7b 100644 --- a/src/Grace.SDK/DirectoryVersion.SDK.fs +++ b/src/Grace.SDK/DirectoryVersion.SDK.fs @@ -24,7 +24,17 @@ type DirectoryVersion() = /// Retrieves a DirectoryVersion instance. static me...
[ "src/Grace.SDK/DirectoryVersion.SDK.fs" ]
[ { "comment": "**<sub><sub>![P1 Badge](https://img.shields.io/badge/P1-orange?style=flat)</sub></sub> Bind SDK lookups to the domain DirectoryVersion**\n\nIn this `Grace.SDK.DirectoryVersion` type, the unqualified generic argument `DirectoryVersion` resolves to the SDK facade itself, not the payload type return...
true
ScottArbeit/Grace
383
comment_to_fix
Add DirectoryVersion BLAKE3 lookup
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Match the BLAKE3 response schema to the handler payload** For the new `/directory/getByBlake3Hash` operation, this 200 response points generated clients at `DirectoryVersionResponse`, whose `ReturnValue` is a `DirectoryVersionApiDt...
cabd9cc8432f3a3f3b0cc0c9f7baf80d86c2d7ba
95a2e4a389bb214f7f06d8a74f54fc57dc3bd3aa
diff --git a/src/OpenAPI/Directory.Paths.OpenAPI.yaml b/src/OpenAPI/Directory.Paths.OpenAPI.yaml index f610c15a..0012f216 100644 --- a/src/OpenAPI/Directory.Paths.OpenAPI.yaml +++ b/src/OpenAPI/Directory.Paths.OpenAPI.yaml @@ -147,7 +147,34 @@ Sha256Hash: 805331A98813206270E35564769E8BB59EEA02AEB7B27...
[ "src/OpenAPI/Directory.Paths.OpenAPI.yaml" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Match the BLAKE3 response schema to the handler payload**\n\nFor the new `/directory/getByBlake3Hash` operation, this 200 response points generated clients at `DirectoryVersionResponse`, whose `ReturnValue` is ...
true
ScottArbeit/Grace
382
issue_to_patch
Add scoped version hash prefix resolver
Related to #353 Part of #343 ## Summary - Adds an explicit zero/one/many result type for scoped version hash prefix resolution. - Replaces SHA-256 first-match lookup internals for references, directory versions, and root directory versions so legacy option wrappers only return a value when resolution is unique. - Cap...
2dcaf22d9e0f4dbdfcb505b1a0f5b400a0d0fbc2
301f6738879b9cb7c6e0786de6740955388207b3
diff --git a/src/Grace.Actors/Services.Actor.fs b/src/Grace.Actors/Services.Actor.fs index 0ffc9390..416308fd 100644 --- a/src/Grace.Actors/Services.Actor.fs +++ b/src/Grace.Actors/Services.Actor.fs @@ -141,6 +141,41 @@ module Services = /// Logger instance for the Services.Actor module. let private log = log...
[ "src/Grace.Actors/Services.Actor.fs", "src/Grace.Server.Unit.Tests/Grace.Server.Unit.Tests.fsproj", "src/Grace.Server.Unit.Tests/Services.VersionHashPrefixResolution.Tests.fs" ]
[]
true
ScottArbeit/Grace
381
issue_to_patch
I09: Persist local SQLite dual-hash state
Related to #352 Part of #343 ## Summary - Bumps the local SQLite state schema to v4 and persists root `DirectoryVersion` BLAKE3 in `status_meta` alongside root SHA-256. - Keeps local status, object-cache, worker, and Doctor schema expectations aligned with dual-hash state. - Rejects incompatible legacy or partial loc...
2b098c57bd0da03f13b577dae95c7e9dabae39e6
00e0a25917c1c5ee4a34d01ed7ad4f980e3de16b
diff --git a/src/Grace.Actors/DirectoryVersion.Actor.fs b/src/Grace.Actors/DirectoryVersion.Actor.fs index 91daf361..4f3dd82d 100644 --- a/src/Grace.Actors/DirectoryVersion.Actor.fs +++ b/src/Grace.Actors/DirectoryVersion.Actor.fs @@ -66,7 +66,7 @@ module DirectoryVersion = let stopwatch = Stopwatch.StartN...
[ "src/Grace.Actors/DirectoryVersion.Actor.fs", "src/Grace.Actors/Services.Actor.fs", "src/Grace.CLI.LocalStateDb.Worker/Program.fs", "src/Grace.CLI.Tests/Connect.CLI.Tests.fs", "src/Grace.CLI.Tests/CurrentStateCapture.CLI.Tests.fs", "src/Grace.CLI.Tests/Doctor.CLI.Tests.fs", "src/Grace.CLI.Tests/LocalSta...
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Preserve root BLAKE3 when writing meta-only status**\n\nWhen the caller passes a `GraceStatus` whose `Index` does not contain the root, this fallback writes an empty `root_directory_blake3_hash`. That scenario ...
true
ScottArbeit/Grace
381
comment_to_fix
I09: Persist local SQLite dual-hash state
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Preserve root BLAKE3 when writing meta-only status** When the caller passes a `GraceStatus` whose `Index` does not contain the root, this fallback writes an empty `root_directory_blake3_hash`. That scenario already exists in `Watch...
2b098c57bd0da03f13b577dae95c7e9dabae39e6
00e0a25917c1c5ee4a34d01ed7ad4f980e3de16b
diff --git a/src/Grace.CLI/LocalStateDb.CLI.fs b/src/Grace.CLI/LocalStateDb.CLI.fs index 6330dcd2..fe965b04 100644 --- a/src/Grace.CLI/LocalStateDb.CLI.fs +++ b/src/Grace.CLI/LocalStateDb.CLI.fs @@ -17,7 +17,7 @@ open SQLitePCL module LocalStateDb = [<Literal>] - let private SchemaVersion = "3" + let priv...
[ "src/Grace.CLI/LocalStateDb.CLI.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Preserve root BLAKE3 when writing meta-only status**\n\nWhen the caller passes a `GraceStatus` whose `Index` does not contain the root, this fallback writes an empty `root_directory_blake3_hash`. That scenario ...
true
ScottArbeit/Grace
381
comment_to_fix
I09: Persist local SQLite dual-hash state
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Reset partial v4 DBs before inserting root BLAKE3** For a local DB whose `meta.schema_version` already says `4` but whose `status_meta` table was created without the new `root_directory_blake3_hash` column, `ensureDbInitialized` do...
2b098c57bd0da03f13b577dae95c7e9dabae39e6
00e0a25917c1c5ee4a34d01ed7ad4f980e3de16b
diff --git a/src/Grace.CLI/LocalStateDb.CLI.fs b/src/Grace.CLI/LocalStateDb.CLI.fs index 6330dcd2..fe965b04 100644 --- a/src/Grace.CLI/LocalStateDb.CLI.fs +++ b/src/Grace.CLI/LocalStateDb.CLI.fs @@ -17,7 +17,7 @@ open SQLitePCL module LocalStateDb = [<Literal>] - let private SchemaVersion = "3" + let priv...
[ "src/Grace.CLI/LocalStateDb.CLI.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Reset partial v4 DBs before inserting root BLAKE3**\n\nFor a local DB whose `meta.schema_version` already says `4` but whose `status_meta` table was created without the new `root_directory_blake3_hash` column, ...
true
ScottArbeit/Grace
381
comment_to_fix
I09: Persist local SQLite dual-hash state
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Update working files when BLAKE3 changes** When this branch accepts a same-SHA/different-BLAKE3 object and replaces the cache file, downstream `updateWorkingDirectory` still decides whether to copy from the cache using only length ...
2b098c57bd0da03f13b577dae95c7e9dabae39e6
00e0a25917c1c5ee4a34d01ed7ad4f980e3de16b
diff --git a/src/Grace.CLI/Command/Services.CLI.fs b/src/Grace.CLI/Command/Services.CLI.fs index 203d002f..d8910bda 100644 --- a/src/Grace.CLI/Command/Services.CLI.fs +++ b/src/Grace.CLI/Command/Services.CLI.fs @@ -152,6 +152,14 @@ module Services = /// Gets a DirectoryInfo instance for the parent directory of...
[ "src/Grace.CLI/Command/Services.CLI.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Update working files when BLAKE3 changes**\n\nWhen this branch accepts a same-SHA/different-BLAKE3 object and replaces the cache file, downstream `updateWorkingDirectory` still decides whether to copy from the ...
true
ScottArbeit/Grace
381
comment_to_fix
I09: Persist local SQLite dual-hash state
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Avoid overwriting SHA-keyed cache variants** When a same-relative-path SHA-256 collision has a different BLAKE3, this overwrite replaces the only cache file name, which is still derived from the SHA-256 hash. Any existing status or...
2b098c57bd0da03f13b577dae95c7e9dabae39e6
00e0a25917c1c5ee4a34d01ed7ad4f980e3de16b
diff --git a/src/Grace.CLI/Command/Services.CLI.fs b/src/Grace.CLI/Command/Services.CLI.fs index 203d002f..d8910bda 100644 --- a/src/Grace.CLI/Command/Services.CLI.fs +++ b/src/Grace.CLI/Command/Services.CLI.fs @@ -152,6 +152,14 @@ module Services = /// Gets a DirectoryInfo instance for the parent directory of...
[ "src/Grace.CLI/Command/Services.CLI.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Avoid overwriting SHA-keyed cache variants**\n\nWhen a same-relative-path SHA-256 collision has a different BLAKE3, this overwrite replaces the only cache file name, which is still derived from the SHA-256 hash...
true
ScottArbeit/Grace
381
comment_to_fix
I09: Persist local SQLite dual-hash state
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Make empty-BLAKE3 reset guidance actionable** When a v4 database contains empty BLAKE3 values, this read-only path tells the user that running a normal Grace command will reset the local state database, but `ensureDbInitialized` on...
2b098c57bd0da03f13b577dae95c7e9dabae39e6
00e0a25917c1c5ee4a34d01ed7ad4f980e3de16b
diff --git a/src/Grace.CLI/LocalStateDb.CLI.fs b/src/Grace.CLI/LocalStateDb.CLI.fs index 6330dcd2..fe965b04 100644 --- a/src/Grace.CLI/LocalStateDb.CLI.fs +++ b/src/Grace.CLI/LocalStateDb.CLI.fs @@ -17,7 +17,7 @@ open SQLitePCL module LocalStateDb = [<Literal>] - let private SchemaVersion = "3" + let priv...
[ "src/Grace.CLI/LocalStateDb.CLI.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Make empty-BLAKE3 reset guidance actionable**\n\nWhen a v4 database contains empty BLAKE3 values, this read-only path tells the user that running a normal Grace command will reset the local state database, but ...
true
ScottArbeit/Grace
381
comment_to_fix
I09: Persist local SQLite dual-hash state
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Preserve BLAKE3 only for the same root** If a caller writes a status with a new `RootDirectoryId`/SHA but without the root entry in `Index`, this fallback reuses the previous row's BLAKE3 without checking that the previous meta row...
2b098c57bd0da03f13b577dae95c7e9dabae39e6
00e0a25917c1c5ee4a34d01ed7ad4f980e3de16b
diff --git a/src/Grace.CLI/LocalStateDb.CLI.fs b/src/Grace.CLI/LocalStateDb.CLI.fs index 6330dcd2..fe965b04 100644 --- a/src/Grace.CLI/LocalStateDb.CLI.fs +++ b/src/Grace.CLI/LocalStateDb.CLI.fs @@ -17,7 +17,7 @@ open SQLitePCL module LocalStateDb = [<Literal>] - let private SchemaVersion = "3" + let priv...
[ "src/Grace.CLI/LocalStateDb.CLI.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Preserve BLAKE3 only for the same root**\n\nIf a caller writes a status with a new `RootDirectoryId`/SHA but without the root entry in `Index`, this fallback reuses the previous row's BLAKE3 without checking th...
true
ScottArbeit/Grace
381
comment_to_fix
I09: Persist local SQLite dual-hash state
**<sub><sub>![P1 Badge](https://img.shields.io/badge/P1-orange?style=flat)</sub></sub> Keep direct storage transfers on the dual-hash cache path** When `Blake3Hash` is populated this stores cache files under the new dual-hash name, but the whole-file storage paths still use the SHA-only `fileVersion.GetObjectFileName...
2b098c57bd0da03f13b577dae95c7e9dabae39e6
00e0a25917c1c5ee4a34d01ed7ad4f980e3de16b
diff --git a/src/Grace.CLI/Command/Services.CLI.fs b/src/Grace.CLI/Command/Services.CLI.fs index 203d002f..d8910bda 100644 --- a/src/Grace.CLI/Command/Services.CLI.fs +++ b/src/Grace.CLI/Command/Services.CLI.fs @@ -152,6 +152,14 @@ module Services = /// Gets a DirectoryInfo instance for the parent directory of...
[ "src/Grace.CLI/Command/Services.CLI.fs" ]
[ { "comment": "**<sub><sub>![P1 Badge](https://img.shields.io/badge/P1-orange?style=flat)</sub></sub> Keep direct storage transfers on the dual-hash cache path**\n\nWhen `Blake3Hash` is populated this stores cache files under the new dual-hash name, but the whole-file storage paths still use the SHA-only `fileV...
true
ScottArbeit/Grace
381
comment_to_fix
I09: Persist local SQLite dual-hash state
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Include object-cache BLAKE3 columns in read-only validation** For a partial v4 local-state DB that has the new `status_*` BLAKE3 columns but is missing `object_cache_directories.blake3_hash` or `object_cache_directory_files.blake3_...
2b098c57bd0da03f13b577dae95c7e9dabae39e6
00e0a25917c1c5ee4a34d01ed7ad4f980e3de16b
diff --git a/src/Grace.CLI/LocalStateDb.CLI.fs b/src/Grace.CLI/LocalStateDb.CLI.fs index 6330dcd2..fe965b04 100644 --- a/src/Grace.CLI/LocalStateDb.CLI.fs +++ b/src/Grace.CLI/LocalStateDb.CLI.fs @@ -17,7 +17,7 @@ open SQLitePCL module LocalStateDb = [<Literal>] - let private SchemaVersion = "3" + let priv...
[ "src/Grace.CLI/LocalStateDb.CLI.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Include object-cache BLAKE3 columns in read-only validation**\n\nFor a partial v4 local-state DB that has the new `status_*` BLAKE3 columns but is missing `object_cache_directories.blake3_hash` or `object_cache...
true
ScottArbeit/Grace
381
comment_to_fix
I09: Persist local SQLite dual-hash state
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Compare BLAKE3 before skipping connect writes** When `grace connect` downloads a remote file whose SHA-256 matches an existing local file but whose BLAKE3 differs, `collectFileConflicts` still puts that path in `filesToSkip` based ...
2b098c57bd0da03f13b577dae95c7e9dabae39e6
00e0a25917c1c5ee4a34d01ed7ad4f980e3de16b
diff --git a/src/Grace.CLI/Command/Connect.CLI.fs b/src/Grace.CLI/Command/Connect.CLI.fs index 3f370238..18f77aee 100644 --- a/src/Grace.CLI/Command/Connect.CLI.fs +++ b/src/Grace.CLI/Command/Connect.CLI.fs @@ -403,6 +403,11 @@ module Connect = | None -> return Error(GraceError.Create "No downloadable ...
[ "src/Grace.CLI/Command/Connect.CLI.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Compare BLAKE3 before skipping connect writes**\n\nWhen `grace connect` downloads a remote file whose SHA-256 matches an existing local file but whose BLAKE3 differs, `collectFileConflicts` still puts that path...
true
ScottArbeit/Grace
381
comment_to_fix
I09: Persist local SQLite dual-hash state
**<sub><sub>![P1 Badge](https://img.shields.io/badge/P1-orange?style=flat)</sub></sub> Handle extensionless dual-hash cache names** For any dual-hash `FileVersion` whose `RelativePath` has no extension, such as `Dockerfile` or `LICENSE`, `file.Extension` is `""` and this `Replace` call throws `ArgumentException` befo...
2b098c57bd0da03f13b577dae95c7e9dabae39e6
00e0a25917c1c5ee4a34d01ed7ad4f980e3de16b
diff --git a/src/Grace.SDK/Storage.SDK.fs b/src/Grace.SDK/Storage.SDK.fs index bf4ac433..796b9f9b 100644 --- a/src/Grace.SDK/Storage.SDK.fs +++ b/src/Grace.SDK/Storage.SDK.fs @@ -42,6 +42,17 @@ module Storage = let private contentBlockPlacement contentBlockAddress etag = { ObjectKey = StorageKeys.contentBlockObj...
[ "src/Grace.SDK/Storage.SDK.fs" ]
[ { "comment": "**<sub><sub>![P1 Badge](https://img.shields.io/badge/P1-orange?style=flat)</sub></sub> Handle extensionless dual-hash cache names**\n\nFor any dual-hash `FileVersion` whose `RelativePath` has no extension, such as `Dockerfile` or `LICENSE`, `file.Extension` is `\"\"` and this `Replace` call throw...
true
ScottArbeit/Grace
381
comment_to_fix
I09: Persist local SQLite dual-hash state
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Keep whole-file blob keys BLAKE3-specific** When this reads the dual-hash cache file for upload, the SAS URI was still obtained from `/storage/getUploadMetadataForFiles`, whose server path builds `StorageKeys.wholeFileContentObject...
2b098c57bd0da03f13b577dae95c7e9dabae39e6
00e0a25917c1c5ee4a34d01ed7ad4f980e3de16b
diff --git a/src/Grace.SDK/Storage.SDK.fs b/src/Grace.SDK/Storage.SDK.fs index bf4ac433..796b9f9b 100644 --- a/src/Grace.SDK/Storage.SDK.fs +++ b/src/Grace.SDK/Storage.SDK.fs @@ -42,6 +42,17 @@ module Storage = let private contentBlockPlacement contentBlockAddress etag = { ObjectKey = StorageKeys.contentBlockObj...
[ "src/Grace.SDK/Storage.SDK.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Keep whole-file blob keys BLAKE3-specific**\n\nWhen this reads the dual-hash cache file for upload, the SAS URI was still obtained from `/storage/getUploadMetadataForFiles`, whose server path builds `StorageKey...
true
ScottArbeit/Grace
381
comment_to_fix
I09: Persist local SQLite dual-hash state
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Include BLAKE3 in upload metadata matching** Once the whole-file blob key becomes BLAKE3-specific, a single `/storage/getUploadMetadataForFiles` request can legitimately return two SAS URIs for the same `RelativePath`/`Sha256Hash` ...
2b098c57bd0da03f13b577dae95c7e9dabae39e6
00e0a25917c1c5ee4a34d01ed7ad4f980e3de16b
diff --git a/src/Grace.Shared/StorageKeys.Shared.fs b/src/Grace.Shared/StorageKeys.Shared.fs index 6ba57611..2f6e656b 100644 --- a/src/Grace.Shared/StorageKeys.Shared.fs +++ b/src/Grace.Shared/StorageKeys.Shared.fs @@ -1,5 +1,6 @@ namespace Grace.Shared +open System open Grace.Types.Common module StorageKeys = @...
[ "src/Grace.Shared/StorageKeys.Shared.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Include BLAKE3 in upload metadata matching**\n\nOnce the whole-file blob key becomes BLAKE3-specific, a single `/storage/getUploadMetadataForFiles` request can legitimately return two SAS URIs for the same `Rel...
true
ScottArbeit/Grace
381
comment_to_fix
I09: Persist local SQLite dual-hash state
**<sub><sub>![P1 Badge](https://img.shields.io/badge/P1-orange?style=flat)</sub></sub> Read dual-hash whole-file blobs in actors** This changes whole-file upload/download SAS keys to include BLAKE3 when present, but the actor-side whole-file reader still builds blob names as `relativePath/GetObjectFileName` in `src/G...
2b098c57bd0da03f13b577dae95c7e9dabae39e6
00e0a25917c1c5ee4a34d01ed7ad4f980e3de16b
diff --git a/src/Grace.Shared/StorageKeys.Shared.fs b/src/Grace.Shared/StorageKeys.Shared.fs index 6ba57611..2f6e656b 100644 --- a/src/Grace.Shared/StorageKeys.Shared.fs +++ b/src/Grace.Shared/StorageKeys.Shared.fs @@ -1,5 +1,6 @@ namespace Grace.Shared +open System open Grace.Types.Common module StorageKeys = @...
[ "src/Grace.Shared/StorageKeys.Shared.fs" ]
[ { "comment": "**<sub><sub>![P1 Badge](https://img.shields.io/badge/P1-orange?style=flat)</sub></sub> Read dual-hash whole-file blobs in actors**\n\nThis changes whole-file upload/download SAS keys to include BLAKE3 when present, but the actor-side whole-file reader still builds blob names as `relativePath/GetO...
true
ScottArbeit/Grace
381
comment_to_fix
I09: Persist local SQLite dual-hash state
**<sub><sub>![P1 Badge](https://img.shields.io/badge/P1-orange?style=flat)</sub></sub> Preserve access to existing SHA-only blobs** For whole-file content uploaded before this change, the blob was stored under the SHA-only `GetObjectFileName` key even though `FileVersion.Blake3Hash` was already populated by the local...
2b098c57bd0da03f13b577dae95c7e9dabae39e6
00e0a25917c1c5ee4a34d01ed7ad4f980e3de16b
diff --git a/src/Grace.Shared/StorageKeys.Shared.fs b/src/Grace.Shared/StorageKeys.Shared.fs index 6ba57611..2f6e656b 100644 --- a/src/Grace.Shared/StorageKeys.Shared.fs +++ b/src/Grace.Shared/StorageKeys.Shared.fs @@ -1,5 +1,6 @@ namespace Grace.Shared +open System open Grace.Types.Common module StorageKeys = @...
[ "src/Grace.Shared/StorageKeys.Shared.fs" ]
[ { "comment": "**<sub><sub>![P1 Badge](https://img.shields.io/badge/P1-orange?style=flat)</sub></sub> Preserve access to existing SHA-only blobs**\n\nFor whole-file content uploaded before this change, the blob was stored under the SHA-only `GetObjectFileName` key even though `FileVersion.Blake3Hash` was alread...
true
ScottArbeit/Grace
380
issue_to_patch
I08: Carry root hashes through reference and branch events
Related to #351 Part of #343 ## Summary - Carries root `DirectoryVersion` BLAKE3 alongside SHA-256 through Reference and Branch command/event contracts, DTO replay, branch reference-producing paths, reminder state, event consumers, and focused tests. - Adds root hash validation before reference event append, sa...
055f76af2c3291bd4fc49baa6a31b0edccbcaa29
b741f5d43faca41bbda2b1f896b7212ee0dfee0f
diff --git a/src/Grace.Actors/Branch.Actor.fs b/src/Grace.Actors/Branch.Actor.fs index 4c2bc47b..c6322c7e 100644 --- a/src/Grace.Actors/Branch.Actor.fs +++ b/src/Grace.Actors/Branch.Actor.fs @@ -159,13 +159,13 @@ module Branch = match branchEvent.Event with // Don't save thes...
[ "src/Grace.Actors/Branch.Actor.fs", "src/Grace.Actors/PromotionSet.Actor.fs", "src/Grace.Actors/Reference.Actor.fs", "src/Grace.Actors/Repository.Actor.fs", "src/Grace.Actors/Services.Actor.fs", "src/Grace.Server.Tests/Branch.Server.Tests.fs", "src/Grace.Server.Tests/Eventing.Integration.Server.Tests.fs...
[ { "comment": "**<sub><sub>![P1 Badge](https://img.shields.io/badge/P1-orange?style=flat)</sub></sub> Add a migration path for persisted Created events**\n\nReference actors persist and replay `List<ReferenceEvent>` from Orleans state on activation, so changing the `Created` union case shape without a legacy ca...
true
ScottArbeit/Grace
380
comment_to_fix
I08: Carry root hashes through reference and branch events
**<sub><sub>![P1 Badge](https://img.shields.io/badge/P1-orange?style=flat)</sub></sub> Add a migration path for persisted Created events** Reference actors persist and replay `List<ReferenceEvent>` from Orleans state on activation, so changing the `Created` union case shape without a legacy case/converter leaves ever...
055f76af2c3291bd4fc49baa6a31b0edccbcaa29
b741f5d43faca41bbda2b1f896b7212ee0dfee0f
diff --git a/src/Grace.Types/Reference.Types.fs b/src/Grace.Types/Reference.Types.fs index 990f25d9..3787f565 100644 --- a/src/Grace.Types/Reference.Types.fs +++ b/src/Grace.Types/Reference.Types.fs @@ -18,6 +18,7 @@ module Reference = BranchId: BranchId DirectoryVersionId: DirectoryVersionId ...
[ "src/Grace.Types/Reference.Types.fs" ]
[ { "comment": "**<sub><sub>![P1 Badge](https://img.shields.io/badge/P1-orange?style=flat)</sub></sub> Add a migration path for persisted Created events**\n\nReference actors persist and replay `List<ReferenceEvent>` from Orleans state on activation, so changing the `Created` union case shape without a legacy ca...
true
ScottArbeit/Grace
380
comment_to_fix
I08: Carry root hashes through reference and branch events
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Preserve SHA-prefix matches when hydrating Blake3** When callers include both `DirectoryVersionId` and a valid abbreviated SHA (the endpoint validator accepts 2-64 hex chars), this exact equality treats the matching directory versi...
055f76af2c3291bd4fc49baa6a31b0edccbcaa29
b741f5d43faca41bbda2b1f896b7212ee0dfee0f
diff --git a/src/Grace.Server/Branch.Server.fs b/src/Grace.Server/Branch.Server.fs index 71e8b975..ed6d388b 100644 --- a/src/Grace.Server/Branch.Server.fs +++ b/src/Grace.Server/Branch.Server.fs @@ -567,6 +567,51 @@ module Branch = return! context |> result500ServerError graceError } + le...
[ "src/Grace.Server/Branch.Server.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Preserve SHA-prefix matches when hydrating Blake3**\n\nWhen callers include both `DirectoryVersionId` and a valid abbreviated SHA (the endpoint validator accepts 2-64 hex chars), this exact equality treats the ...
true
ScottArbeit/Grace
380
comment_to_fix
I08: Carry root hashes through reference and branch events
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Resolve SHA-only references against root directories** For SHA-only Promote/Commit/Checkpoint/Save/Tag/CreateExternal requests, this falls back to `getDirectoryVersionBySha256Hash`, which searches any DirectoryVersion; because SHA ...
055f76af2c3291bd4fc49baa6a31b0edccbcaa29
b741f5d43faca41bbda2b1f896b7212ee0dfee0f
diff --git a/src/Grace.Server/Branch.Server.fs b/src/Grace.Server/Branch.Server.fs index 71e8b975..ed6d388b 100644 --- a/src/Grace.Server/Branch.Server.fs +++ b/src/Grace.Server/Branch.Server.fs @@ -567,6 +567,51 @@ module Branch = return! context |> result500ServerError graceError } + le...
[ "src/Grace.Server/Branch.Server.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Resolve SHA-only references against root directories**\n\nFor SHA-only Promote/Commit/Checkpoint/Save/Tag/CreateExternal requests, this falls back to `getDirectoryVersionBySha256Hash`, which searches any Direct...
true
ScottArbeit/Grace
380
comment_to_fix
I08: Carry root hashes through reference and branch events
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Enforce root path when hydrating by directory id** When a save/commit/tag/etc. request supplies a child `DirectoryVersionId` together with that child’s SHA (or prefix), this branch hydrates the child’s full SHA and Blake3 and retur...
055f76af2c3291bd4fc49baa6a31b0edccbcaa29
b741f5d43faca41bbda2b1f896b7212ee0dfee0f
diff --git a/src/Grace.Server/Branch.Server.fs b/src/Grace.Server/Branch.Server.fs index 71e8b975..ed6d388b 100644 --- a/src/Grace.Server/Branch.Server.fs +++ b/src/Grace.Server/Branch.Server.fs @@ -567,6 +567,51 @@ module Branch = return! context |> result500ServerError graceError } + le...
[ "src/Grace.Server/Branch.Server.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Enforce root path when hydrating by directory id**\n\nWhen a save/commit/tag/etc. request supplies a child `DirectoryVersionId` together with that child’s SHA (or prefix), this branch hydrates the child’s full ...
true
ScottArbeit/Grace
380
comment_to_fix
I08: Carry root hashes through reference and branch events
**<sub><sub>![P1 Badge](https://img.shields.io/badge/P1-orange?style=flat)</sub></sub> Migrate legacy directory versions before rejecting Blake3** On upgraded repositories with root `DirectoryVersion` records written before `Blake3Hash` was populated, the server now hydrates an empty command Blake3 from that persiste...
055f76af2c3291bd4fc49baa6a31b0edccbcaa29
b741f5d43faca41bbda2b1f896b7212ee0dfee0f
diff --git a/src/Grace.Actors/Reference.Actor.fs b/src/Grace.Actors/Reference.Actor.fs index 0ed23ff4..ef11b1fc 100644 --- a/src/Grace.Actors/Reference.Actor.fs +++ b/src/Grace.Actors/Reference.Actor.fs @@ -113,6 +113,101 @@ module Reference = referenceDto.ReferenceId <> ReferenceId.Empty && reference...
[ "src/Grace.Actors/Reference.Actor.fs" ]
[ { "comment": "**<sub><sub>![P1 Badge](https://img.shields.io/badge/P1-orange?style=flat)</sub></sub> Migrate legacy directory versions before rejecting Blake3**\n\nOn upgraded repositories with root `DirectoryVersion` records written before `Blake3Hash` was populated, the server now hydrates an empty command B...
true
ScottArbeit/Grace
380
comment_to_fix
I08: Carry root hashes through reference and branch events
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Handle slash-root hashes in SHA-only references** For SHA-only save/commit/tag/etc. requests against a root `DirectoryVersion` whose `RelativePath` is `"/"`, this new path now calls `getRootDirectoryVersionBySha256Hash`, but that h...
055f76af2c3291bd4fc49baa6a31b0edccbcaa29
b741f5d43faca41bbda2b1f896b7212ee0dfee0f
diff --git a/src/Grace.Server/Branch.Server.fs b/src/Grace.Server/Branch.Server.fs index 71e8b975..ed6d388b 100644 --- a/src/Grace.Server/Branch.Server.fs +++ b/src/Grace.Server/Branch.Server.fs @@ -567,6 +567,51 @@ module Branch = return! context |> result500ServerError graceError } + le...
[ "src/Grace.Server/Branch.Server.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Handle slash-root hashes in SHA-only references**\n\nFor SHA-only save/commit/tag/etc. requests against a root `DirectoryVersion` whose `RelativePath` is `\"/\"`, this new path now calls `getRootDirectoryVersio...
true
ScottArbeit/Grace
380
comment_to_fix
I08: Carry root hashes through reference and branch events
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Resolve Assign SHA prefixes against root directories** For the `/branch/assign` SHA-only path, this still hydrates from `getDirectoryVersionBySha256Hash`, which searches all directory versions; if a valid root SHA prefix also match...
055f76af2c3291bd4fc49baa6a31b0edccbcaa29
b741f5d43faca41bbda2b1f896b7212ee0dfee0f
diff --git a/src/Grace.Server/Branch.Server.fs b/src/Grace.Server/Branch.Server.fs index 71e8b975..ed6d388b 100644 --- a/src/Grace.Server/Branch.Server.fs +++ b/src/Grace.Server/Branch.Server.fs @@ -567,6 +567,51 @@ module Branch = return! context |> result500ServerError graceError } + le...
[ "src/Grace.Server/Branch.Server.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Resolve Assign SHA prefixes against root directories**\n\nFor the `/branch/assign` SHA-only path, this still hydrates from `getDirectoryVersionBySha256Hash`, which searches all directory versions; if a valid ro...
true
ScottArbeit/Grace
380
comment_to_fix
I08: Carry root hashes through reference and branch events
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Hydrate Blake3 for direct reference projections** In upgraded repositories with persisted `ReferenceEventType.Created` records that predate `Blake3Hash`, this projection still copies the empty/default value into `ReferenceDto`. The...
055f76af2c3291bd4fc49baa6a31b0edccbcaa29
b741f5d43faca41bbda2b1f896b7212ee0dfee0f
diff --git a/src/Grace.Types/Reference.Types.fs b/src/Grace.Types/Reference.Types.fs index 990f25d9..3787f565 100644 --- a/src/Grace.Types/Reference.Types.fs +++ b/src/Grace.Types/Reference.Types.fs @@ -18,6 +18,7 @@ module Reference = BranchId: BranchId DirectoryVersionId: DirectoryVersionId ...
[ "src/Grace.Types/Reference.Types.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Hydrate Blake3 for direct reference projections**\n\nIn upgraded repositories with persisted `ReferenceEventType.Created` records that predate `Blake3Hash`, this projection still copies the empty/default value ...
true
ScottArbeit/Grace
380
comment_to_fix
I08: Carry root hashes through reference and branch events
**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Repair legacy prefix references before replay** For legacy references that were created with a `DirectoryVersionId` plus an abbreviated SHA prefix (accepted by the endpoint validators), the persisted `Created` event can contain tha...
055f76af2c3291bd4fc49baa6a31b0edccbcaa29
b741f5d43faca41bbda2b1f896b7212ee0dfee0f
diff --git a/src/Grace.Actors/Reference.Actor.fs b/src/Grace.Actors/Reference.Actor.fs index 0ed23ff4..ef11b1fc 100644 --- a/src/Grace.Actors/Reference.Actor.fs +++ b/src/Grace.Actors/Reference.Actor.fs @@ -113,6 +113,101 @@ module Reference = referenceDto.ReferenceId <> ReferenceId.Empty && reference...
[ "src/Grace.Actors/Reference.Actor.fs" ]
[ { "comment": "**<sub><sub>![P2 Badge](https://img.shields.io/badge/P2-yellow?style=flat)</sub></sub> Repair legacy prefix references before replay**\n\nFor legacy references that were created with a `DirectoryVersionId` plus an abbreviated SHA prefix (accepted by the endpoint validators), the persisted `Create...
true
ScottArbeit/Grace
379
issue_to_patch
I07: Propagate DirectoryVersion BLAKE3 hashes
Related to #350 Part of #343 ## Summary - Propagates DirectoryVersion BLAKE3 and the updated SHA-256 preimage through CLI local recompute, save overlays, repository empty-root creation, promotion recompute, server save ordering, and actor validation. - Rejects missing or mismatched DirectoryVersion SHA-256/BLAK...
9b6f6bfe819afdb9f0b8e48fc13a4cb7ee569223
70572c156d6fa428750c990b576f8c21412b614a
diff --git a/src/Grace.Actors/DirectoryVersion.Actor.fs b/src/Grace.Actors/DirectoryVersion.Actor.fs index c7a9fcee..91daf361 100644 --- a/src/Grace.Actors/DirectoryVersion.Actor.fs +++ b/src/Grace.Actors/DirectoryVersion.Actor.fs @@ -150,6 +150,219 @@ module DirectoryVersion = getFilesToValidate newFiles prev...
[ "src/Grace.Actors/DirectoryVersion.Actor.fs", "src/Grace.Actors/PromotionSet.Actor.fs", "src/Grace.Actors/Repository.Actor.fs", "src/Grace.CLI.Tests/CurrentStateCapture.CLI.Tests.fs", "src/Grace.CLI/Command/Branch.CLI.fs", "src/Grace.CLI/Command/Diff.CLI.fs", "src/Grace.CLI/Command/Reference.CLI.fs", ...
[ { "comment": "**<sub><sub>![P1 Badge](https://img.shields.io/badge/P1-orange?style=flat)</sub></sub> Preserve legacy manifest BLAKE3 during save validation**\n\nWhen a directory contains a manifest-backed file from legacy state with `FileVersion.Blake3Hash = \"\"`, this blanket child-file check rejects the dir...
true
ScottArbeit/Grace
379
comment_to_fix
I07: Propagate DirectoryVersion BLAKE3 hashes
**<sub><sub>![P1 Badge](https://img.shields.io/badge/P1-orange?style=flat)</sub></sub> Preserve legacy manifest BLAKE3 during save validation** When a directory contains a manifest-backed file from legacy state with `FileVersion.Blake3Hash = ""`, this blanket child-file check rejects the directory before save, even t...
9b6f6bfe819afdb9f0b8e48fc13a4cb7ee569223
70572c156d6fa428750c990b576f8c21412b614a
diff --git a/src/Grace.Actors/DirectoryVersion.Actor.fs b/src/Grace.Actors/DirectoryVersion.Actor.fs index c7a9fcee..91daf361 100644 --- a/src/Grace.Actors/DirectoryVersion.Actor.fs +++ b/src/Grace.Actors/DirectoryVersion.Actor.fs @@ -150,6 +150,219 @@ module DirectoryVersion = getFilesToValidate newFiles prev...
[ "src/Grace.Actors/DirectoryVersion.Actor.fs" ]
[ { "comment": "**<sub><sub>![P1 Badge](https://img.shields.io/badge/P1-orange?style=flat)</sub></sub> Preserve legacy manifest BLAKE3 during save validation**\n\nWhen a directory contains a manifest-backed file from legacy state with `FileVersion.Blake3Hash = \"\"`, this blanket child-file check rejects the dir...
true