repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
ytdl-org/youtube-dl | 10,556 | issue_to_patch | [miaopai] Add new extractor | ## Please follow the guide below
- You will be asked some questions, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your _pull request_ (like that [x])
- Use _Preview_ tab to see how your _pull request_ will actually look like
---
### Before submitting a _pull reques... | 340e31ca7449197450e0a50c925cf9ebd95a76d4 | a493f1020888e87a464ab8a948c797c18fc3aca3 | diff --git a/youtube_dl/extractor/extractors.py b/youtube_dl/extractor/extractors.py
index 8c6ee0503a9..d511b04bcee 100644
--- a/youtube_dl/extractor/extractors.py
+++ b/youtube_dl/extractor/extractors.py
@@ -471,6 +471,7 @@
from .metacritic import MetacriticIE
from .mgoon import MgoonIE
from .mgtv import MGTVIE
+fr... | [
"youtube_dl/extractor/extractors.py",
"youtube_dl/extractor/miaopai.py"
] | [
{
"comment": "Use `self._parse_html5_media_entries` instead.\n",
"path": "youtube_dl/extractor/miaopai.py",
"hunk": "@@ -0,0 +1,44 @@\n+# coding: utf-8\n+from __future__ import unicode_literals\n+\n+from .common import InfoExtractor\n+from ..utils import sanitized_Request\n+\n+\n+class MiaoPaiIE(InfoExt... | true | ||
ytdl-org/youtube-dl | 31,303 | issue_to_patch | Netease music throws error if downloading geo-restriction song (without handling it)
<!--
######################################################################
WARNING!
IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
#################################################################... | [netease] Add warnings for users outside of China | ## Please follow the guide below
- You will be asked some questions, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your *pull request* (like that [x])
- Use *Preview* tab to see how your *pull request* will actually look like
---
### Before submitting a *p... | 0faa45d6c08f518b73d20e341944ea7292f9f2b2 | 58a57949484c837965ba91ad26f28200ced416de | diff --git a/youtube_dl/extractor/neteasemusic.py b/youtube_dl/extractor/neteasemusic.py
index fad22a2cd0b..2bbfc78585f 100644
--- a/youtube_dl/extractor/neteasemusic.py
+++ b/youtube_dl/extractor/neteasemusic.py
@@ -20,6 +20,7 @@
from ..utils import (
ExtractorError,
bytes_to_intlist,
+ error_to_compat_s... | [
"youtube_dl/extractor/neteasemusic.py"
] | [
{
"comment": "We have a method that tells people this, that can be called later.\r\n```suggestion\r\n msg = 'empty result'\r\n```",
"path": "youtube_dl/extractor/neteasemusic.py",
"hunk": "@@ -94,14 +95,19 @@ def _call_player_api(self, song_id, bitrate):\n url = 'https://interface3.mu... | true | |
ytdl-org/youtube-dl | 31,303 | comment_to_fix | [netease] Add warnings for users outside of China | We have a method that tells people this, that can be called later.
```suggestion
msg = 'empty result'
``` | 0faa45d6c08f518b73d20e341944ea7292f9f2b2 | 58a57949484c837965ba91ad26f28200ced416de | diff --git a/youtube_dl/extractor/neteasemusic.py b/youtube_dl/extractor/neteasemusic.py
index fad22a2cd0b..2bbfc78585f 100644
--- a/youtube_dl/extractor/neteasemusic.py
+++ b/youtube_dl/extractor/neteasemusic.py
@@ -20,6 +20,7 @@
from ..utils import (
ExtractorError,
bytes_to_intlist,
+ error_to_compat_s... | [
"youtube_dl/extractor/neteasemusic.py"
] | [
{
"comment": "We have a method that tells people this, that can be called later.\r\n```suggestion\r\n msg = 'empty result'\r\n```",
"path": "youtube_dl/extractor/neteasemusic.py",
"hunk": "@@ -94,14 +95,19 @@ def _call_player_api(self, song_id, bitrate):\n url = 'https://interface3.mu... | true | ||
ytdl-org/youtube-dl | 31,303 | comment_to_fix | [netease] Add warnings for users outside of China | Actually `url` is always the same, and other messages put the video/song ID first.
```suggestion
msg = error_to_compat_str(e)
self.report_warning('%s API call (%s) failed: %s' % (
song_id, bitrate, msg))
``` | 0faa45d6c08f518b73d20e341944ea7292f9f2b2 | 58a57949484c837965ba91ad26f28200ced416de | diff --git a/youtube_dl/extractor/neteasemusic.py b/youtube_dl/extractor/neteasemusic.py
index fad22a2cd0b..2bbfc78585f 100644
--- a/youtube_dl/extractor/neteasemusic.py
+++ b/youtube_dl/extractor/neteasemusic.py
@@ -20,6 +20,7 @@
from ..utils import (
ExtractorError,
bytes_to_intlist,
+ error_to_compat_s... | [
"youtube_dl/extractor/neteasemusic.py"
] | [
{
"comment": "Actually `url` is always the same, and other messages put the video/song ID first.\r\n```suggestion\r\n msg = error_to_compat_str(e)\r\n self.report_warning('%s API call (%s) failed: %s' % (\r\n song_id, bitrate, msg))\r\n```",
"path": "youtube_dl/extractor... | true | ||
ytdl-org/youtube-dl | 31,303 | comment_to_fix | [netease] Add warnings for users outside of China | ```suggestion
def extract_formats(self, info):
err = 0
``` | 0faa45d6c08f518b73d20e341944ea7292f9f2b2 | 58a57949484c837965ba91ad26f28200ced416de | diff --git a/youtube_dl/extractor/neteasemusic.py b/youtube_dl/extractor/neteasemusic.py
index fad22a2cd0b..2bbfc78585f 100644
--- a/youtube_dl/extractor/neteasemusic.py
+++ b/youtube_dl/extractor/neteasemusic.py
@@ -20,6 +20,7 @@
from ..utils import (
ExtractorError,
bytes_to_intlist,
+ error_to_compat_s... | [
"youtube_dl/extractor/neteasemusic.py"
] | [
{
"comment": "```suggestion\r\n def extract_formats(self, info):\r\n err = 0\r\n```",
"path": "youtube_dl/extractor/neteasemusic.py",
"hunk": "@@ -94,14 +95,19 @@ def _call_player_api(self, song_id, bitrate):\n url = 'https://interface3.music.163.com/eapi/song/enhance/player/url'\n ... | true | ||
ytdl-org/youtube-dl | 31,303 | comment_to_fix | [netease] Add warnings for users outside of China | If the site returns an error code (assume semantics like HTTP codes) and no formats, tell the user.
If no code and no formats, assume geo-blocking. The diagnostic will look like this:
```
ERROR: No media links found: probably this video is not available from your location due to geo restriction
This video is avai... | 0faa45d6c08f518b73d20e341944ea7292f9f2b2 | 58a57949484c837965ba91ad26f28200ced416de | diff --git a/youtube_dl/extractor/neteasemusic.py b/youtube_dl/extractor/neteasemusic.py
index fad22a2cd0b..2bbfc78585f 100644
--- a/youtube_dl/extractor/neteasemusic.py
+++ b/youtube_dl/extractor/neteasemusic.py
@@ -20,6 +20,7 @@
from ..utils import (
ExtractorError,
bytes_to_intlist,
+ error_to_compat_s... | [
"youtube_dl/extractor/neteasemusic.py"
] | [
{
"comment": "If the site returns an error code (assume semantics like HTTP codes) and no formats, tell the user.\r\n\r\nIf no code and no formats, assume geo-blocking. The diagnostic will look like this:\r\n```\r\nERROR: No media links found: probably this video is not available from your location due to geo r... | true | ||
ytdl-org/youtube-dl | 31,304 | issue_to_patch | [netease] Support urls shared from mobile app | ## Please follow the guide below
- You will be asked some questions, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your *pull request* (like that [x])
- Use *Preview* tab to see how your *pull request* will actually look like
---
### Before submitting a *p... | 0faa45d6c08f518b73d20e341944ea7292f9f2b2 | dd7994e6db8c1bbdff6d7b35acf389178b2de6ae | diff --git a/youtube_dl/extractor/neteasemusic.py b/youtube_dl/extractor/neteasemusic.py
index fad22a2cd0b..6413b4aba9f 100644
--- a/youtube_dl/extractor/neteasemusic.py
+++ b/youtube_dl/extractor/neteasemusic.py
@@ -140,7 +140,7 @@ def query_api(self, endpoint, video_id, note):
class NetEaseMusicIE(NetEaseMusicBaseIE... | [
"youtube_dl/extractor/neteasemusic.py"
] | [
{
"comment": "Make pattern group anonymous since not referenced:\r\n```suggestion\r\n _VALID_URL = r'https?://(y\\.)?music\\.163\\.com/(?:[#m]/)?song\\?.*?\\bid=(?P<id>[0-9]+)'\r\n```",
"path": "youtube_dl/extractor/neteasemusic.py",
"hunk": "@@ -140,7 +140,7 @@ def query_api(self, endpoint, video_id... | true | ||
ytdl-org/youtube-dl | 31,304 | comment_to_fix | [netease] Support urls shared from mobile app | Make pattern group anonymous since not referenced:
```suggestion
_VALID_URL = r'https?://(y\.)?music\.163\.com/(?:[#m]/)?song\?.*?\bid=(?P<id>[0-9]+)'
``` | 0faa45d6c08f518b73d20e341944ea7292f9f2b2 | dd7994e6db8c1bbdff6d7b35acf389178b2de6ae | diff --git a/youtube_dl/extractor/neteasemusic.py b/youtube_dl/extractor/neteasemusic.py
index fad22a2cd0b..6413b4aba9f 100644
--- a/youtube_dl/extractor/neteasemusic.py
+++ b/youtube_dl/extractor/neteasemusic.py
@@ -140,7 +140,7 @@ def query_api(self, endpoint, video_id, note):
class NetEaseMusicIE(NetEaseMusicBaseIE... | [
"youtube_dl/extractor/neteasemusic.py"
] | [
{
"comment": "Make pattern group anonymous since not referenced:\r\n```suggestion\r\n _VALID_URL = r'https?://(y\\.)?music\\.163\\.com/(?:[#m]/)?song\\?.*?\\bid=(?P<id>[0-9]+)'\r\n```",
"path": "youtube_dl/extractor/neteasemusic.py",
"hunk": "@@ -140,7 +140,7 @@ def query_api(self, endpoint, video_id... | true | ||
ytdl-org/youtube-dl | 32,891 | issue_to_patch | New Player 20dfca59 has broken YouTube extractor
<!--
######################################################################
WARNING!
IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################
-->
## Checklist
<!... | applied @dirkf's patches for nsig extraction on youtube | ## Please follow the guide below
- You will be asked some questions, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your *pull request* (like that [x])
- Use *Preview* tab to see how your *pull request* will actually look like
---
### Before submitting a *p... | e1b3fa242cb94eb9dc949ab3f2cace91c46f11bf | 8765808cd22c712b0dc22f8ccffa2e9c0b365e85 | diff --git a/youtube_dl/extractor/youtube.py b/youtube_dl/extractor/youtube.py
index 84371ff063d..509e374a4d7 100644
--- a/youtube_dl/extractor/youtube.py
+++ b/youtube_dl/extractor/youtube.py
@@ -1659,18 +1659,38 @@ def _decrypt_nsig(self, n, video_id, player_url):
def _extract_n_function_name(self, jscode):
... | [
"test/test_youtube_signature.py",
"youtube_dl/extractor/youtube.py"
] | [
{
"comment": "```suggestion\r\n ''', jscode, 'Initial JS player n function name', group=('nfunc', 'idx'),\r\n default=(None, None))\r\n # thx bashonly: yt-dlp/yt-dlp/pull/10611\r\n if not func_name:\r\n self.report_warning('Falling back to generic n function search... | diff --git a/test/test_youtube_signature.py b/test/test_youtube_signature.py
index 5b4aa3aa05b..1c5f667f57a 100644
--- a/test/test_youtube_signature.py
+++ b/test/test_youtube_signature.py
@@ -174,6 +174,10 @@
'https://www.youtube.com/s/player/5604538d/player_ias.vflset/en_US/base.js',
'7X-he4jjvMx7BC... | true |
ytdl-org/youtube-dl | 32,891 | comment_to_fix | applied @dirkf's patches for nsig extraction on youtube | ```suggestion
''', jscode, 'Initial JS player n function name', group=('nfunc', 'idx'),
default=(None, None))
# thx bashonly: yt-dlp/yt-dlp/pull/10611
if not func_name:
self.report_warning('Falling back to generic n function search')
return self._sea... | e1b3fa242cb94eb9dc949ab3f2cace91c46f11bf | 8765808cd22c712b0dc22f8ccffa2e9c0b365e85 | diff --git a/youtube_dl/extractor/youtube.py b/youtube_dl/extractor/youtube.py
index 84371ff063d..509e374a4d7 100644
--- a/youtube_dl/extractor/youtube.py
+++ b/youtube_dl/extractor/youtube.py
@@ -1659,18 +1659,38 @@ def _decrypt_nsig(self, n, video_id, player_url):
def _extract_n_function_name(self, jscode):
... | [
"youtube_dl/extractor/youtube.py"
] | [
{
"comment": "```suggestion\r\n ''', jscode, 'Initial JS player n function name', group=('nfunc', 'idx'),\r\n default=(None, None))\r\n # thx bashonly: yt-dlp/yt-dlp/pull/10611\r\n if not func_name:\r\n self.report_warning('Falling back to generic n function search... | true | ||
ytdl-org/youtube-dl | 32,891 | comment_to_fix | applied @dirkf's patches for nsig extraction on youtube | ```suggestion
'https://www.youtube.com/s/player/20dfca59/player_ias.vflset/en_US/base.js',
'-fLCxedkAk4LUTK2', 'O8kfRq1y1eyHGw',
``` | e1b3fa242cb94eb9dc949ab3f2cace91c46f11bf | 8765808cd22c712b0dc22f8ccffa2e9c0b365e85 | diff --git a/test/test_youtube_signature.py b/test/test_youtube_signature.py
index 5b4aa3aa05b..1c5f667f57a 100644
--- a/test/test_youtube_signature.py
+++ b/test/test_youtube_signature.py
@@ -174,6 +174,10 @@
'https://www.youtube.com/s/player/5604538d/player_ias.vflset/en_US/base.js',
'7X-he4jjvMx7BC... | [
"test/test_youtube_signature.py"
] | [
{
"comment": "```suggestion\r\n 'https://www.youtube.com/s/player/20dfca59/player_ias.vflset/en_US/base.js',\r\n '-fLCxedkAk4LUTK2', 'O8kfRq1y1eyHGw',\r\n```",
"path": "test/test_youtube_signature.py",
"hunk": "@@ -174,6 +174,10 @@\n 'https://www.youtube.com/s/player/5604538d/playe... | true | ||
ytdl-org/youtube-dl | 32,891 | comment_to_fix | applied @dirkf's patches for nsig extraction on youtube | ```suggestion
)\s*=\s*
``` | e1b3fa242cb94eb9dc949ab3f2cace91c46f11bf | 8765808cd22c712b0dc22f8ccffa2e9c0b365e85 | diff --git a/youtube_dl/extractor/youtube.py b/youtube_dl/extractor/youtube.py
index 84371ff063d..509e374a4d7 100644
--- a/youtube_dl/extractor/youtube.py
+++ b/youtube_dl/extractor/youtube.py
@@ -1659,18 +1659,38 @@ def _decrypt_nsig(self, n, video_id, player_url):
def _extract_n_function_name(self, jscode):
... | [
"youtube_dl/extractor/youtube.py"
] | [
{
"comment": "```suggestion\r\n )\\s*=\\s*\r\n```",
"path": "youtube_dl/extractor/youtube.py",
"hunk": "@@ -1659,18 +1659,38 @@ def _decrypt_nsig(self, n, video_id, player_url):\n def _extract_n_function_name(self, jscode):\n func_name, idx = self._search_regex(\n ... | true | ||
ytdl-org/youtube-dl | 32,802 | issue_to_patch | ORF Radiothek has changed the URLs
youtube-dl version 2021.06.06
ORF has changed the URLs for Radiothek.
I have tested the URLs in the file "orf.py.new" and the downloads are working now without problems.
But how these URLs can be changed in the official youtube-dl version?
**diff orf.py orf.py.new**
**191c19... | [ORF] Extractor overhaul | <details><summary>Boilerplate: own/yt-dlp code, fix/new extractor</summary>
## Please follow the guide below
- You will be asked some questions, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your *pull request* (like that [x])
- Use *Preview* tab to see how y... | 21924742f79ccbd62d16ef4120518c6a5da8614e | fc03c3bb3e16efad9fd75500afce6b3c3d97290b | diff --git a/youtube_dl/YoutubeDL.py b/youtube_dl/YoutubeDL.py
index 6f2aba5ac8e..dad44435f0a 100755
--- a/youtube_dl/YoutubeDL.py
+++ b/youtube_dl/YoutubeDL.py
@@ -1039,8 +1039,8 @@ def process_ie_result(self, ie_result, download=True, extra_info={}):
elif result_type in ('playlist', 'multi_video'):
... | [
"test/helper.py",
"test/test_download.py",
"youtube_dl/YoutubeDL.py",
"youtube_dl/extractor/extractors.py",
"youtube_dl/extractor/orf.py"
] | [] | diff --git a/test/helper.py b/test/helper.py
index 5b7e3dfe20b..6f2129efff3 100644
--- a/test/helper.py
+++ b/test/helper.py
@@ -5,9 +5,9 @@
import json
import os.path
import re
-import types
import ssl
import sys
+import types
import unittest
import youtube_dl.extractor
@@ -181,18 +181,18 @@ def expect_value(... | true |
ytdl-org/youtube-dl | 32,841 | issue_to_patch | Breaking change no allowing saving output with no extension
- [ ] I'm reporting a broken site support issue
- [x] I've verified that I'm running youtube-dl version **2021.12.17**
- [x] I've checked that all provided URLs are alive and playable in a browser
- [x] I've checked that all URLs and arguments with special... | [core] Fix PR #32830 for fixed extensionless output template | <details><summary>Boilerplate: own/yt-dlp code, fix</summary>
## Please follow the guide below
- You will be asked some questions, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your *pull request* (like that [x])
- Use *Preview* tab to see how your *pull requ... | 36801c62df733cfa4f74b607532e012900d8c77f | d08b5e31d19c825616ee3221751fa4c96b54d92b | diff --git a/youtube_dl/YoutubeDL.py b/youtube_dl/YoutubeDL.py
index c19501915e4..9e5620eefa1 100755
--- a/youtube_dl/YoutubeDL.py
+++ b/youtube_dl/YoutubeDL.py
@@ -139,8 +139,8 @@ def wrapper(self, *args, **kwargs):
except _UnsafeExtensionError as error:
self.report_error(
'{0} f... | [
"youtube_dl/YoutubeDL.py"
] | [] | true | |
ytdl-org/youtube-dl | 32,837 | issue_to_patch | [YandexMusic] Save track version in the title field | ### Before submitting a *pull request* make sure you have:
- [x] [Searched](https://github.com/ytdl-org/youtube-dl/search?q=is%3Apr&type=Issues) the bugtracker for similar pull requests
- [x] Read [adding new extractor tutorial](https://github.com/ytdl-org/youtube-dl#adding-support-for-a-new-site)
- [x] Read [youtub... | 37cea84f775129ad715b9bcd617251c831fcc980 | 6bbbcaa00086dc0afd0d9212fe0afab586d4d6c8 | diff --git a/youtube_dl/extractor/yandexmusic.py b/youtube_dl/extractor/yandexmusic.py
index 84969f8e114..8da5b430f7c 100644
--- a/youtube_dl/extractor/yandexmusic.py
+++ b/youtube_dl/extractor/yandexmusic.py
@@ -106,6 +106,25 @@ class YandexMusicTrackIE(YandexMusicBaseIE):
}, {
'url': 'http://music.yande... | [
"youtube_dl/extractor/yandexmusic.py"
] | [] | true | ||
ytdl-org/youtube-dl | 31,159 | issue_to_patch | [YandexMusic] downloads music in High Quality (320 Kbit/s) | ### Before submitting a *pull request* make sure you have:
- [x] [Searched](https://github.com/ytdl-org/youtube-dl/search?q=is%3Apr&type=Issues) the bugtracker for similar pull requests
- [x] Read [adding new extractor tutorial](https://github.com/ytdl-org/youtube-dl#adding-support-for-a-new-site)
- [x] Read [youtub... | b7fca0fab36c71fee02d6ecf81acbbaa46942be4 | 4b519d9a924ca7bd81d8838324375f33cb8cb314 | diff --git a/youtube_dl/extractor/yandexmusic.py b/youtube_dl/extractor/yandexmusic.py
index 84969f8e114..55d4fb5a01a 100644
--- a/youtube_dl/extractor/yandexmusic.py
+++ b/youtube_dl/extractor/yandexmusic.py
@@ -120,6 +120,7 @@ def _real_extract(self, url):
download_data = self._download_json(
'h... | [
"youtube_dl/extractor/yandexmusic.py"
] | [] | true | ||
ytdl-org/youtube-dl | 32,830 | issue_to_patch | [core] Validate proposed file extensions | <details><summary>Boilerplate: yt-dlp/own code, fix</summary>
## Please follow the guide below
- You will be asked some questions, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your *pull request* (like that [x])
- Use *Preview* tab to see how your *pull reques... | 4d05f84325070c3f6fe2ed6096138757675469a4 | e15101cb9970aa683d8e7e3e3f492869e4844e5b | diff --git a/youtube_dl/YoutubeDL.py b/youtube_dl/YoutubeDL.py
index dad44435f0a..c19501915e4 100755
--- a/youtube_dl/YoutubeDL.py
+++ b/youtube_dl/YoutubeDL.py
@@ -7,6 +7,7 @@
import copy
import datetime
import errno
+import functools
import io
import itertools
import json
@@ -53,6 +54,7 @@
compat_urllib_re... | [
"test/test_utils.py",
"youtube_dl/YoutubeDL.py",
"youtube_dl/__init__.py",
"youtube_dl/options.py",
"youtube_dl/utils.py"
] | [] | diff --git a/test/test_utils.py b/test/test_utils.py
index de7fe80b8b6..2947cce7eb3 100644
--- a/test/test_utils.py
+++ b/test/test_utils.py
@@ -14,9 +14,11 @@
import io
import itertools
import json
+import types
import xml.etree.ElementTree
from youtube_dl.utils import (
+ _UnsafeExtensionError,
age_res... | true | |
ytdl-org/youtube-dl | 30,664 | issue_to_patch | Unrecognized option 'x'
Two issues going on the first for a long time:
- `youtube-dl`, not able to download youtube stories anymore (a couple of months now)
- website Crunchyroll when listing with `youtube-dl -F`, `ffmpeg 5.0` throw two errors:
- `Unrecognized option 'x'.` (which I have none in my scripts, I ... | [core] Ignore --external-downloader-args if --external-downloader was rejected | ## Please follow the guide below
---
### Before submitting a *pull request* make sure you have:
- [x] [Searched](https://github.com/ytdl-org/youtube-dl/search?q=is%3Apr&type=Issues) the bugtracker for similar pull requests
- [x] Read [adding new extractor tutorial](https://github.com/ytdl-org/youtube-dl#adding-su... | 34722270741fb9c06f978861c1e5f503291070d8 | 8db78afe671ec15774fdf71756ae471405203586 | diff --git a/youtube_dl/YoutubeDL.py b/youtube_dl/YoutubeDL.py
index fe30758ef9c..82412baf49d 100755
--- a/youtube_dl/YoutubeDL.py
+++ b/youtube_dl/YoutubeDL.py
@@ -1906,8 +1906,17 @@ def ensure_dir_exists(path):
if not self.params.get('skip_download', False):
try:
+ def checked_g... | [
"youtube_dl/YoutubeDL.py",
"youtube_dl/downloader/__init__.py"
] | [] | true | |
ytdl-org/youtube-dl | 28,774 | issue_to_patch | [bbc] Extract more metadata for window.__INITIAL_DATA__ pages | ## Please follow the guide below
- You will be asked some questions, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your *pull request* (like that [x])
- Use *Preview* tab to see how your *pull request* will actually look like
---
### Before submitting a *p... | 9f6c03a00602eb1119e43a522cf50682f6d6a6dd | 5ffb321d019c90d89d7e58a46b5b5494a6a1614f | diff --git a/youtube_dl/extractor/bbc.py b/youtube_dl/extractor/bbc.py
index e8d000bbb51..71ea25881c9 100644
--- a/youtube_dl/extractor/bbc.py
+++ b/youtube_dl/extractor/bbc.py
@@ -11,6 +11,7 @@
compat_etree_Element,
compat_HTTPError,
compat_parse_qs,
+ compat_str,
compat_urllib_parse_urlparse,
... | [
"youtube_dl/extractor/bbc.py"
] | [
{
"comment": "`strip_or_none`.",
"path": "youtube_dl/extractor/bbc.py",
"hunk": "@@ -1164,12 +1170,20 @@ def parse_media(media):\n continue\n formats, subtitles = self._download_media_selector(item_id)\n self._sort_formats(formats)\n+ ... | true | ||
ytdl-org/youtube-dl | 28,774 | comment_to_fix | [bbc] Extract more metadata for window.__INITIAL_DATA__ pages | `strip_or_none`. | 9f6c03a00602eb1119e43a522cf50682f6d6a6dd | 5ffb321d019c90d89d7e58a46b5b5494a6a1614f | diff --git a/youtube_dl/extractor/bbc.py b/youtube_dl/extractor/bbc.py
index e8d000bbb51..71ea25881c9 100644
--- a/youtube_dl/extractor/bbc.py
+++ b/youtube_dl/extractor/bbc.py
@@ -11,6 +11,7 @@
compat_etree_Element,
compat_HTTPError,
compat_parse_qs,
+ compat_str,
compat_urllib_parse_urlparse,
... | [
"youtube_dl/extractor/bbc.py"
] | [
{
"comment": "`strip_or_none`.",
"path": "youtube_dl/extractor/bbc.py",
"hunk": "@@ -1164,12 +1170,20 @@ def parse_media(media):\n continue\n formats, subtitles = self._download_media_selector(item_id)\n self._sort_formats(formats)\n+ ... | true | ||
ytdl-org/youtube-dl | 28,774 | comment_to_fix | [bbc] Extract more metadata for window.__INITIAL_DATA__ pages | `unified_timestamp`. | 9f6c03a00602eb1119e43a522cf50682f6d6a6dd | 5ffb321d019c90d89d7e58a46b5b5494a6a1614f | diff --git a/youtube_dl/extractor/bbc.py b/youtube_dl/extractor/bbc.py
index e8d000bbb51..71ea25881c9 100644
--- a/youtube_dl/extractor/bbc.py
+++ b/youtube_dl/extractor/bbc.py
@@ -11,6 +11,7 @@
compat_etree_Element,
compat_HTTPError,
compat_parse_qs,
+ compat_str,
compat_urllib_parse_urlparse,
... | [
"youtube_dl/extractor/bbc.py"
] | [
{
"comment": "`unified_timestamp`.",
"path": "youtube_dl/extractor/bbc.py",
"hunk": "@@ -1164,12 +1170,20 @@ def parse_media(media):\n continue\n formats, subtitles = self._download_media_selector(item_id)\n self._sort_formats(formats)\n+ ... | true | ||
ytdl-org/youtube-dl | 28,774 | comment_to_fix | [bbc] Extract more metadata for window.__INITIAL_DATA__ pages | Use outer double quotes instead of escaping single inner quotes. | 9f6c03a00602eb1119e43a522cf50682f6d6a6dd | 5ffb321d019c90d89d7e58a46b5b5494a6a1614f | diff --git a/youtube_dl/extractor/bbc.py b/youtube_dl/extractor/bbc.py
index e8d000bbb51..71ea25881c9 100644
--- a/youtube_dl/extractor/bbc.py
+++ b/youtube_dl/extractor/bbc.py
@@ -11,6 +11,7 @@
compat_etree_Element,
compat_HTTPError,
compat_parse_qs,
+ compat_str,
compat_urllib_parse_urlparse,
... | [
"youtube_dl/extractor/bbc.py"
] | [
{
"comment": "Use outer double quotes instead of escaping single inner quotes.",
"path": "youtube_dl/extractor/bbc.py",
"hunk": "@@ -761,8 +762,13 @@ class BBCIE(BBCCoUkIE):\n 'only_matching': True,\n }, {\n # custom redirection to www.bbc.com\n+ # video with window.__INITIAL_... | true | ||
ytdl-org/youtube-dl | 28,774 | comment_to_fix | [bbc] Extract more metadata for window.__INITIAL_DATA__ pages | Do not use exact URLs in tests. | 9f6c03a00602eb1119e43a522cf50682f6d6a6dd | 5ffb321d019c90d89d7e58a46b5b5494a6a1614f | diff --git a/youtube_dl/extractor/bbc.py b/youtube_dl/extractor/bbc.py
index e8d000bbb51..71ea25881c9 100644
--- a/youtube_dl/extractor/bbc.py
+++ b/youtube_dl/extractor/bbc.py
@@ -11,6 +11,7 @@
compat_etree_Element,
compat_HTTPError,
compat_parse_qs,
+ compat_str,
compat_urllib_parse_urlparse,
... | [
"youtube_dl/extractor/bbc.py"
] | [
{
"comment": "Do not use exact URLs in tests.",
"path": "youtube_dl/extractor/bbc.py",
"hunk": "@@ -761,8 +762,13 @@ class BBCIE(BBCCoUkIE):\n 'only_matching': True,\n }, {\n # custom redirection to www.bbc.com\n+ # video with window.__INITIAL_DATA__\n 'url': 'http://w... | true | ||
ytdl-org/youtube-dl | 28,774 | comment_to_fix | [bbc] Extract more metadata for window.__INITIAL_DATA__ pages | This must be inside a dict corresponding to `info_dict` key. `python -W error .\test\test_download.py TestDownload.test_BBC_13` must succeed. | 9f6c03a00602eb1119e43a522cf50682f6d6a6dd | 5ffb321d019c90d89d7e58a46b5b5494a6a1614f | diff --git a/youtube_dl/extractor/bbc.py b/youtube_dl/extractor/bbc.py
index e8d000bbb51..71ea25881c9 100644
--- a/youtube_dl/extractor/bbc.py
+++ b/youtube_dl/extractor/bbc.py
@@ -11,6 +11,7 @@
compat_etree_Element,
compat_HTTPError,
compat_parse_qs,
+ compat_str,
compat_urllib_parse_urlparse,
... | [
"youtube_dl/extractor/bbc.py"
] | [
{
"comment": "This must be inside a dict corresponding to `info_dict` key. `python -W error .\\test\\test_download.py TestDownload.test_BBC_13` must succeed.",
"path": "youtube_dl/extractor/bbc.py",
"hunk": "@@ -761,8 +764,13 @@ class BBCIE(BBCCoUkIE):\n 'only_matching': True,\n }, {\n ... | true | ||
ytdl-org/youtube-dl | 30,329 | issue_to_patch | [niconico] Downloading long videos requires heartbeat signals
## Please follow the guide below
- You will be asked some questions and requested to provide some information, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your *issue* (like this: `[x]`)
- Use the ... | [Niconico] Back-port extractor and add new search extractors from yt-dlp | ## Please follow the guide below
- You will be asked some questions, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your *pull request* (like that [x])
- Use *Preview* tab to see how your *pull request* will actually look like
---
### Before submitting a *p... | af9e72507ea38e5ab3fa2751ed09ec88021260cb | c74716d92f1cd8a56717ea389336973f4d2cde11 | diff --git a/youtube_dl/downloader/__init__.py b/youtube_dl/downloader/__init__.py
index 2e485df9dac..d8f2fa34226 100644
--- a/youtube_dl/downloader/__init__.py
+++ b/youtube_dl/downloader/__init__.py
@@ -1,22 +1,31 @@
from __future__ import unicode_literals
+from ..utils import (
+ determine_protocol,
+)
+
+
+de... | [
"test/parameters.json",
"test/test_download.py",
"youtube_dl/downloader/__init__.py",
"youtube_dl/downloader/niconico.py",
"youtube_dl/extractor/extractors.py",
"youtube_dl/extractor/niconico.py"
] | [] | diff --git a/test/parameters.json b/test/parameters.json
index 65fd5442860..864c9d13044 100644
--- a/test/parameters.json
+++ b/test/parameters.json
@@ -18,7 +18,6 @@
"noprogress": false,
"outtmpl": "%(id)s.%(ext)s",
"password": null,
- "playlistend": -1,
"playliststart": 1,
"prefer_fre... | true |
ytdl-org/youtube-dl | 30,556 | issue_to_patch | Sendung mit der Maus
## Please follow the guide below
---
### Make sure you are using the *latest* version: run `youtube-dl --version` and ensure your version is *2018.05.09*. If it's not, read [this FAQ entry](https://github.com/rg3/youtube-dl/blob/master/README.md#how-do-i-update-youtube-dl) and update. Issues... | [WDR] Fix WDRMaus and update tests | ## Please follow the guide below
---
### Before submitting a *pull request* make sure you have:
- [x] [Searched](https://github.com/ytdl-org/youtube-dl/search?q=is%3Apr&type=Issues) the bugtracker for similar pull requests
- [x] Read [adding new extractor tutorial](https://github.com/ytdl-org/youtube-dl#adding-... | af9e72507ea38e5ab3fa2751ed09ec88021260cb | b7d943b1c1a51515c488a25c911baadda25a8adf | diff --git a/youtube_dl/extractor/wdr.py b/youtube_dl/extractor/wdr.py
index 2903d189ea3..10db7314825 100644
--- a/youtube_dl/extractor/wdr.py
+++ b/youtube_dl/extractor/wdr.py
@@ -10,6 +10,7 @@
)
from ..utils import (
determine_ext,
+ dict_get,
ExtractorError,
js_to_json,
strip_jsonp,
@@ -22,9... | [
"youtube_dl/extractor/wdr.py"
] | [] | true | |
ytdl-org/youtube-dl | 30,577 | issue_to_patch | youtube shorts URL causes "unable to recognize tab page" error
<!--
######################################################################
WARNING!
IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################
-->
## C... | [Youtube] Support Shorts URL format | ## Please follow the guide below
---
### Before submitting a *pull request* make sure you have:
- [x] [Searched](https://github.com/ytdl-org/youtube-dl/search?q=is%3Apr&type=Issues) the bugtracker for similar pull requests
- [x] Read [adding new extractor tutorial](https://github.com/ytdl-org/youtube-dl#adding-su... | af9e72507ea38e5ab3fa2751ed09ec88021260cb | d6f6fd47938dd1f79a3c056f9bcf2de0dd7b576b | diff --git a/youtube_dl/extractor/youtube.py b/youtube_dl/extractor/youtube.py
index 63918924df8..e001ea2e62c 100644
--- a/youtube_dl/extractor/youtube.py
+++ b/youtube_dl/extractor/youtube.py
@@ -416,6 +416,7 @@ class YoutubeIE(YoutubeBaseInfoExtractor):
(?:.*?\#/)? ... | [
"youtube_dl/extractor/youtube.py"
] | [] | true | |
ytdl-org/youtube-dl | 30,582 | issue_to_patch | Youtube download speed still slow
<!--
######################################################################
WARNING!
IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################
-->
## Checklist
<!--
Carefully r... | [YouTube] Fix n-sig for player e06dea74 | ## Please follow the guide below
- You will be asked some questions, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your *pull request* (like that [x])
- Use *Preview* tab to see how your *pull request* will actually look like
---
### Before submitting a *p... | af9e72507ea38e5ab3fa2751ed09ec88021260cb | f2ebd5263bb183effa32d1fd3060bbefdfa62c8d | diff --git a/youtube_dl/extractor/youtube.py b/youtube_dl/extractor/youtube.py
index 63918924df8..7943b94f9d5 100644
--- a/youtube_dl/extractor/youtube.py
+++ b/youtube_dl/extractor/youtube.py
@@ -28,6 +28,7 @@
dict_get,
float_or_none,
int_or_none,
+ js_to_json,
mimetype2ext,
parse_codecs,
... | [
"test/test_youtube_signature.py",
"youtube_dl/extractor/youtube.py"
] | [] | diff --git a/test/test_youtube_signature.py b/test/test_youtube_signature.py
index c8e85b5005a..fc5e9828e2c 100644
--- a/test/test_youtube_signature.py
+++ b/test/test_youtube_signature.py
@@ -82,6 +82,14 @@
'https://www.youtube.com/s/player/f1ca6900/player_ias.vflset/en_US/base.js',
'cu3wyu6LQn2hse',... | true |
ytdl-org/youtube-dl | 31,043 | issue_to_patch | Extract age-gated player URLs
Currently, for videos with age gate, we don't get the player URL. Look in the /embed version of the video for it.
Wrong error message for yt videos that are both age-gated and private
Getting this error when trying to download this video: https://youtu.be/N-aDHKKRdso
```
[youtube] N-a... | [YouTube] Revive age-gate bypass | <details>
<summary>Boilerplate: mixed code, improvement</summary>
## Please follow the guide below
- You will be asked some questions, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your *pull request* (like that [x])
- Use *Preview* tab to see how your *pull r... | 384f632e8a9b61e864a26678d85b2b39933b9bae | 09761f0e86e0bb57c985af68ad9264f6003e6ab5 | diff --git a/devscripts/make_lazy_extractors.py b/devscripts/make_lazy_extractors.py
index 878ae72b132..edc19183da5 100644
--- a/devscripts/make_lazy_extractors.py
+++ b/devscripts/make_lazy_extractors.py
@@ -13,6 +13,11 @@
lazy_extractors_filename = sys.argv[1]
if os.path.exists(lazy_extractors_filename):
os.re... | [
"devscripts/make_lazy_extractors.py",
"test/test_age_restriction.py",
"test/test_compat.py",
"test/test_execution.py",
"youtube_dl/compat.py",
"youtube_dl/extractor/youtube.py",
"youtube_dl/utils.py"
] | [
{
"comment": "```suggestion\r\n returns: compat_str\r\n \"\"\"\r\n```",
"path": "youtube_dl/utils.py",
"hunk": "@@ -3957,6 +3957,17 @@ def update_url_query(url, query):\n query=compat_urllib_parse_urlencode(qs, True)))\n \n \n+def update_url(url, **kwargs):\n+ \"\"\"Replace URL compon... | diff --git a/test/test_age_restriction.py b/test/test_age_restriction.py
index 6f5513faa2c..db98494ab85 100644
--- a/test/test_age_restriction.py
+++ b/test/test_age_restriction.py
@@ -11,6 +11,7 @@
from youtube_dl import YoutubeDL
+from youtube_dl.utils import DownloadError
def _download_restricted(url, file... | true |
ytdl-org/youtube-dl | 31,043 | comment_to_fix | [YouTube] Revive age-gate bypass | ```suggestion
returns: compat_str
"""
``` | 384f632e8a9b61e864a26678d85b2b39933b9bae | 09761f0e86e0bb57c985af68ad9264f6003e6ab5 | diff --git a/youtube_dl/utils.py b/youtube_dl/utils.py
index e3c3ccff904..4edbfa27ba6 100644
--- a/youtube_dl/utils.py
+++ b/youtube_dl/utils.py
@@ -42,6 +42,7 @@
compat_HTMLParser,
compat_HTTPError,
compat_basestring,
+ compat_casefold,
compat_chr,
compat_collections_abc,
compat_cookie... | [
"youtube_dl/utils.py"
] | [
{
"comment": "```suggestion\r\n returns: compat_str\r\n \"\"\"\r\n```",
"path": "youtube_dl/utils.py",
"hunk": "@@ -3957,6 +3957,17 @@ def update_url_query(url, query):\n query=compat_urllib_parse_urlencode(qs, True)))\n \n \n+def update_url(url, **kwargs):\n+ \"\"\"Replace URL compon... | true | ||
ytdl-org/youtube-dl | 32,820 | issue_to_patch | [YouTube] Error 403 when downloading, with "Unable to decode n-parameter", not solved by new cookies
<!--
######################################################################
WARNING!
IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
#################################################... | [jsinterp] Support YT player 590f65a6 | <details><summary>Boilerplate: own/yt-dlp code, fix/improvement</summary>
## Please follow the guide below
- You will be asked some questions, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your *pull request* (like that [x])
- Use *Preview* tab to see how you... | 0153b387e57e0bb8e580f1869f85596d2767fb0d | 9edcf8c67e4a67366b029d202913f94ecc410530 | diff --git a/youtube_dl/extractor/common.py b/youtube_dl/extractor/common.py
index b10e844168c..9b0016d07ec 100644
--- a/youtube_dl/extractor/common.py
+++ b/youtube_dl/extractor/common.py
@@ -3033,7 +3033,6 @@ def _find_jwplayer_data(self, webpage, video_id=None, transform_source=js_to_jso
transform_sourc... | [
"test/test_jsinterp.py",
"test/test_youtube_signature.py",
"youtube_dl/extractor/common.py",
"youtube_dl/extractor/palcomp3.py",
"youtube_dl/jsinterp.py",
"youtube_dl/utils.py"
] | [] | diff --git a/test/test_jsinterp.py b/test/test_jsinterp.py
index 91b12f5441b..da8e980207a 100644
--- a/test/test_jsinterp.py
+++ b/test/test_jsinterp.py
@@ -577,9 +577,11 @@ def test_32066(self):
def test_unary_operators(self):
jsi = JSInterpreter('function f(){return 2 - - - 2;}')
self.assertE... | true |
ytdl-org/youtube-dl | 30,924 | issue_to_patch | [VidLii] Add 720p support (yt-dlp backport-ish) | ## Please follow the guide below
- You will be asked some questions, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your *pull request* (like that [x])
- Use *Preview* tab to see how your *pull request* will actually look like
---
### Before submitting a *p... | b7fca0fab36c71fee02d6ecf81acbbaa46942be4 | d687b6afd8671f3c729d7b93972a9e95e0386904 | diff --git a/youtube_dl/extractor/vidlii.py b/youtube_dl/extractor/vidlii.py
index f4774256bd5..47f328e8743 100644
--- a/youtube_dl/extractor/vidlii.py
+++ b/youtube_dl/extractor/vidlii.py
@@ -4,6 +4,7 @@
import re
from .common import InfoExtractor
+
from ..utils import (
float_or_none,
get_element_by_id... | [
"youtube_dl/extractor/vidlii.py"
] | [
{
"comment": "I suppose these are available, but are they meaningful? That may not be an issue for this PR, though. If the `tags` don't matter, the test could have:\r\n```suggestion\r\n 'tags': list,\r\n```\r\n\r\n",
"path": "youtube_dl/extractor/vidlii.py",
"hunk": "@@ -35,6 +37,25 @@ class ... | true | ||
ytdl-org/youtube-dl | 30,924 | comment_to_fix | [VidLii] Add 720p support (yt-dlp backport-ish) | I suppose these are available, but are they meaningful? That may not be an issue for this PR, though. If the `tags` don't matter, the test could have:
```suggestion
'tags': list,
```
| b7fca0fab36c71fee02d6ecf81acbbaa46942be4 | d687b6afd8671f3c729d7b93972a9e95e0386904 | diff --git a/youtube_dl/extractor/vidlii.py b/youtube_dl/extractor/vidlii.py
index f4774256bd5..47f328e8743 100644
--- a/youtube_dl/extractor/vidlii.py
+++ b/youtube_dl/extractor/vidlii.py
@@ -4,6 +4,7 @@
import re
from .common import InfoExtractor
+
from ..utils import (
float_or_none,
get_element_by_id... | [
"youtube_dl/extractor/vidlii.py"
] | [
{
"comment": "I suppose these are available, but are they meaningful? That may not be an issue for this PR, though. If the `tags` don't matter, the test could have:\r\n```suggestion\r\n 'tags': list,\r\n```\r\n\r\n",
"path": "youtube_dl/extractor/vidlii.py",
"hunk": "@@ -35,6 +37,25 @@ class ... | true | ||
ytdl-org/youtube-dl | 30,924 | comment_to_fix | [VidLii] Add 720p support (yt-dlp backport-ish) | Consistency, and `.` is a regex character:
```suggestion
height = int(self._search_regex(r'(\d+)\.mp4',
format_url, 'height', default=360))
```
The default is a different type from the successful method return, but in the context it doesn't matter. | b7fca0fab36c71fee02d6ecf81acbbaa46942be4 | d687b6afd8671f3c729d7b93972a9e95e0386904 | diff --git a/youtube_dl/extractor/vidlii.py b/youtube_dl/extractor/vidlii.py
index f4774256bd5..47f328e8743 100644
--- a/youtube_dl/extractor/vidlii.py
+++ b/youtube_dl/extractor/vidlii.py
@@ -4,6 +4,7 @@
import re
from .common import InfoExtractor
+
from ..utils import (
float_or_none,
get_element_by_id... | [
"youtube_dl/extractor/vidlii.py"
] | [
{
"comment": "Consistency, and `.` is a regex character:\r\n```suggestion\r\n height = int(self._search_regex(r'(\\d+)\\.mp4',\r\n format_url, 'height', default=360))\r\n```\r\nThe default is a different type from the successful method return, but in the context it doesn't mat... | true | ||
ytdl-org/youtube-dl | 30,924 | comment_to_fix | [VidLii] Add 720p support (yt-dlp backport-ish) | If the attribute names are all `src` and not `xxxsrc`:
```suggestion
r'\bsrc\s*:\s*(["\'])(?P<url>(?:https?://)?(?:(?!\1).)+)\1',
``` | b7fca0fab36c71fee02d6ecf81acbbaa46942be4 | d687b6afd8671f3c729d7b93972a9e95e0386904 | diff --git a/youtube_dl/extractor/vidlii.py b/youtube_dl/extractor/vidlii.py
index f4774256bd5..47f328e8743 100644
--- a/youtube_dl/extractor/vidlii.py
+++ b/youtube_dl/extractor/vidlii.py
@@ -4,6 +4,7 @@
import re
from .common import InfoExtractor
+
from ..utils import (
float_or_none,
get_element_by_id... | [
"youtube_dl/extractor/vidlii.py"
] | [
{
"comment": "If the attribute names are all `src` and not `xxxsrc`:\r\n```suggestion\r\n r'\\bsrc\\s*:\\s*([\"\\'])(?P<url>(?:https?://)?(?:(?!\\1).)+)\\1',\r\n```",
"path": "youtube_dl/extractor/vidlii.py",
"hunk": "@@ -46,9 +67,31 @@ def _real_extract(self, url):\n webpage = self._... | true | ||
ytdl-org/youtube-dl | 30,924 | comment_to_fix | [VidLii] Add 720p support (yt-dlp backport-ish) | There's a `_check_formats()` method for this:
```suggestion
formats = []
if len(sources) > 1:
formats = [sources[1][1]]
self._check_formats(formats, video_id)
if len(sources) > 0:
formats.append(sources[0][1])
map(add_format, formats)
``` | b7fca0fab36c71fee02d6ecf81acbbaa46942be4 | d687b6afd8671f3c729d7b93972a9e95e0386904 | diff --git a/youtube_dl/extractor/vidlii.py b/youtube_dl/extractor/vidlii.py
index f4774256bd5..47f328e8743 100644
--- a/youtube_dl/extractor/vidlii.py
+++ b/youtube_dl/extractor/vidlii.py
@@ -4,6 +4,7 @@
import re
from .common import InfoExtractor
+
from ..utils import (
float_or_none,
get_element_by_id... | [
"youtube_dl/extractor/vidlii.py"
] | [
{
"comment": "There's a `_check_formats()` method for this:\r\n```suggestion\r\n formats = []\r\n if len(sources) > 1:\r\n formats = [sources[1][1]]\r\n self._check_formats(formats, video_id)\r\n if len(sources) > 0:\r\n formats.append(sources[0][1])\r\n ... | true | ||
ytdl-org/youtube-dl | 30,924 | comment_to_fix | [VidLii] Add 720p support (yt-dlp backport-ish) | Not part of your PR, but should convert HTML-encoding to text, also strip surrounding spaces:
```suggestion
title = self._html_search_regex(
``` | b7fca0fab36c71fee02d6ecf81acbbaa46942be4 | d687b6afd8671f3c729d7b93972a9e95e0386904 | diff --git a/youtube_dl/extractor/vidlii.py b/youtube_dl/extractor/vidlii.py
index f4774256bd5..47f328e8743 100644
--- a/youtube_dl/extractor/vidlii.py
+++ b/youtube_dl/extractor/vidlii.py
@@ -4,6 +4,7 @@
import re
from .common import InfoExtractor
+
from ..utils import (
float_or_none,
get_element_by_id... | [
"youtube_dl/extractor/vidlii.py"
] | [
{
"comment": "Not part of your PR, but should convert HTML-encoding to text, also strip surrounding spaces:\r\n```suggestion\r\n title = self._html_search_regex(\r\n```",
"path": "youtube_dl/extractor/vidlii.py",
"hunk": "@@ -46,9 +67,31 @@ def _real_extract(self, url):\n webpage = self._... | true | ||
ytdl-org/youtube-dl | 30,924 | comment_to_fix | [VidLii] Add 720p support (yt-dlp backport-ish) | If these `,`s are thousands separators, might they be `.`s for some locales (plainly not a decimal point for a count)?
```suggestion
view_count = str_to_int(self._html_search_regex(
(r'<strong>([\d,.]+)</strong> views',
r'Views\s*:\s*<strong>([\d,.]+)</strong>'),
webpag... | b7fca0fab36c71fee02d6ecf81acbbaa46942be4 | d687b6afd8671f3c729d7b93972a9e95e0386904 | diff --git a/youtube_dl/extractor/vidlii.py b/youtube_dl/extractor/vidlii.py
index f4774256bd5..47f328e8743 100644
--- a/youtube_dl/extractor/vidlii.py
+++ b/youtube_dl/extractor/vidlii.py
@@ -4,6 +4,7 @@
import re
from .common import InfoExtractor
+
from ..utils import (
float_or_none,
get_element_by_id... | [
"youtube_dl/extractor/vidlii.py"
] | [
{
"comment": "If these `,`s are thousands separators, might they be `.`s for some locales (plainly not a decimal point for a count)?\r\n```suggestion\r\n view_count = str_to_int(self._html_search_regex(\r\n (r'<strong>([\\d,.]+)</strong> views',\r\n r'Views\\s*:\\s*<strong>([\\d,.]... | true | ||
ytdl-org/youtube-dl | 30,924 | comment_to_fix | [VidLii] Add 720p support (yt-dlp backport-ish) | ```suggestion
}, {
# HD
``` | b7fca0fab36c71fee02d6ecf81acbbaa46942be4 | d687b6afd8671f3c729d7b93972a9e95e0386904 | diff --git a/youtube_dl/extractor/vidlii.py b/youtube_dl/extractor/vidlii.py
index f4774256bd5..47f328e8743 100644
--- a/youtube_dl/extractor/vidlii.py
+++ b/youtube_dl/extractor/vidlii.py
@@ -4,6 +4,7 @@
import re
from .common import InfoExtractor
+
from ..utils import (
float_or_none,
get_element_by_id... | [
"youtube_dl/extractor/vidlii.py"
] | [
{
"comment": "```suggestion\r\n }, {\r\n # HD\r\n```",
"path": "youtube_dl/extractor/vidlii.py",
"hunk": "@@ -35,6 +38,25 @@ class VidLiiIE(InfoExtractor):\n 'categories': ['News & Politics'],\n 'tags': ['Vidlii', 'Jan', 'Videogames'],\n }\n+ }, { # HD",
... | true | ||
ytdl-org/youtube-dl | 30,924 | comment_to_fix | [VidLii] Add 720p support (yt-dlp backport-ish) | Revert unused import
```suggestion
``` | b7fca0fab36c71fee02d6ecf81acbbaa46942be4 | d687b6afd8671f3c729d7b93972a9e95e0386904 | diff --git a/youtube_dl/extractor/vidlii.py b/youtube_dl/extractor/vidlii.py
index f4774256bd5..47f328e8743 100644
--- a/youtube_dl/extractor/vidlii.py
+++ b/youtube_dl/extractor/vidlii.py
@@ -4,6 +4,7 @@
import re
from .common import InfoExtractor
+
from ..utils import (
float_or_none,
get_element_by_id... | [
"youtube_dl/extractor/vidlii.py"
] | [
{
"comment": "Revert unused import\r\n```suggestion\r\n```",
"path": "youtube_dl/extractor/vidlii.py",
"hunk": "@@ -4,13 +4,16 @@\n import re\n \n from .common import InfoExtractor\n+\n from ..utils import (\n+ ExtractorError,",
"resolving_sha": "d687b6afd8671f3c729d7b93972a9e95e0386904",
"re... | true | ||
ytdl-org/youtube-dl | 32,557 | issue_to_patch | Mixcloud failing for below mentioned artist while working for many others tested
<!--
######################################################################
WARNING!
IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
#####################################################################... | [mixcloud] updated mixcloud API server address | ## Please follow the guide below
- You will be asked some questions, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your *pull request* (like that [x])
- Use *Preview* tab to see how your *pull request* will actually look like
---
### Before submitting a *p... | b7fca0fab36c71fee02d6ecf81acbbaa46942be4 | ec46d543b4304f17a5169cd92338bbd32af10c71 | diff --git a/youtube_dl/extractor/mixcloud.py b/youtube_dl/extractor/mixcloud.py
index 69319857dfb..2b5e2c15c5b 100644
--- a/youtube_dl/extractor/mixcloud.py
+++ b/youtube_dl/extractor/mixcloud.py
@@ -1,3 +1,4 @@
+# coding: utf-8
from __future__ import unicode_literals
import itertools
@@ -10,7 +11,7 @@
compat... | [
"youtube_dl/extractor/mixcloud.py"
] | [] | true | |
ytdl-org/youtube-dl | 32,799 | issue_to_patch | [utils,ie] Misc yt-dlp back-ports, etc | <details><summary>Own/yt-dlp code, Improvement</summary>
## Please follow the guide below
- You will be asked some questions, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your *pull request* (like that [x])
- Use *Preview* tab to see how your *pull request* ... | a08f2b7e4567cdc50c0614ee0a4ffdff49b8b6e6 | 42f60fe3c22f8d8f6f70c4aa08880fe0ab21f1f6 | diff --git a/youtube_dl/compat.py b/youtube_dl/compat.py
index 53ff2a892af..ed1a33cf2fb 100644
--- a/youtube_dl/compat.py
+++ b/youtube_dl/compat.py
@@ -2719,8 +2719,222 @@ def compat_xpath(xpath):
if isinstance(xpath, compat_str):
xpath = xpath.encode('ascii')
return xpath
+
+ # furth... | [
"test/test_InfoExtractor.py",
"test/test_traversal.py",
"test/test_utils.py",
"youtube_dl/compat.py",
"youtube_dl/extractor/common.py",
"youtube_dl/traversal.py",
"youtube_dl/utils.py"
] | [] | diff --git a/test/test_InfoExtractor.py b/test/test_InfoExtractor.py
index d55d6ad5428..09100a1d667 100644
--- a/test/test_InfoExtractor.py
+++ b/test/test_InfoExtractor.py
@@ -153,6 +153,9 @@ def test_search_nextjs_data(self):
'''
search = self.ie._search_nextjs_data(html, 'testID')
self.assertEqual... | true | |
ytdl-org/youtube-dl | 32,740 | issue_to_patch | [YouPorn] Fix and improve extraction; add playlist extraction | <details><summary>Boilerplate: own/yt-dlp code, bug fix/improvement</summary>
## Please follow the guide below
- You will be asked some questions, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your *pull request* (like that [x])
- Use *Preview* tab to see how... | e0727e4ab61b6e45f7792546b8b5ff52a0ea22b5 | f66e450bfd8c3c5e4a0048fdd0240d5b8b1f3ba3 | diff --git a/youtube_dl/extractor/extractors.py b/youtube_dl/extractor/extractors.py
index a56a7c52f37..03d035a275d 100644
--- a/youtube_dl/extractor/extractors.py
+++ b/youtube_dl/extractor/extractors.py
@@ -1653,7 +1653,15 @@
YouNowChannelIE,
YouNowMomentIE,
)
-from .youporn import YouPornIE
+from .youporn... | [
"test/test_download.py",
"youtube_dl/extractor/extractors.py",
"youtube_dl/extractor/youporn.py"
] | [
{
"comment": "This gets an/the internal video ID that is not revealed in the URL or displayed page content. I used this since it appears to index the actual media items on the site (ie, there could be two pages with different URL IDs but identical media content), but still have doubts.",
"path": "youtube_dl... | diff --git a/test/test_download.py b/test/test_download.py
index e0bc8cb9542..df8b370cfdc 100644
--- a/test/test_download.py
+++ b/test/test_download.py
@@ -10,6 +10,7 @@
from test.helper import (
assertGreaterEqual,
+ assertLessEqual,
expect_warnings,
get_params,
gettestcases,
@@ -122,7 +123,... | true | |
ytdl-org/youtube-dl | 32,740 | comment_to_fix | [YouPorn] Fix and improve extraction; add playlist extraction | This gets an/the internal video ID that is not revealed in the URL or displayed page content. I used this since it appears to index the actual media items on the site (ie, there could be two pages with different URL IDs but identical media content), but still have doubts. | e0727e4ab61b6e45f7792546b8b5ff52a0ea22b5 | f66e450bfd8c3c5e4a0048fdd0240d5b8b1f3ba3 | diff --git a/youtube_dl/extractor/youporn.py b/youtube_dl/extractor/youporn.py
index 31e8abb7298..ec6125a79cb 100644
--- a/youtube_dl/extractor/youporn.py
+++ b/youtube_dl/extractor/youporn.py
@@ -1,20 +1,38 @@
# coding: utf-8
from __future__ import unicode_literals
+import itertools
import re
+from time import sl... | [
"youtube_dl/extractor/youporn.py"
] | [
{
"comment": "This gets an/the internal video ID that is not revealed in the URL or displayed page content. I used this since it appears to index the actual media items on the site (ie, there could be two pages with different URL IDs but identical media content), but still have doubts.",
"path": "youtube_dl... | true | ||
ytdl-org/youtube-dl | 32,762 | issue_to_patch | [extractor/common] Fix crash in _report_ignoring_subs | ### Before submitting a *pull request* make sure you have:
- [x] [Searched](https://github.com/ytdl-org/youtube-dl/search?q=is%3Apr&type=Issues) the bugtracker for similar pull requests
- [x] Read [adding new extractor tutorial](https://github.com/ytdl-org/youtube-dl#adding-support-for-a-new-site)
- [x] Read [youtub... | 21792b88b791b16e3ab0a0fb2e26e5bb8a4e2ff3 | 6c9912e83453098dd7a46a5eef6728dc0cafb9ac | diff --git a/youtube_dl/utils.py b/youtube_dl/utils.py
index 083446342b0..e1b05b30729 100644
--- a/youtube_dl/utils.py
+++ b/youtube_dl/utils.py
@@ -2371,15 +2371,24 @@ def set_alpn_protocols(ctx):
return YoutubeDLHTTPSHandler(params, context=context, **kwargs)
-def bug_reports_message():
+def bug_reports_... | [
"youtube_dl/utils.py"
] | [
{
"comment": "Revert and fix `utils.bug_reports_message()` (1a):\r\n```suggestion\r\n self.report_warning(bug_reports_message(\r\n```",
"path": "youtube_dl/extractor/common.py",
"hunk": "@@ -1812,10 +1812,10 @@ def _m3u8_meta_format(self, m3u8_url, ext=None, preference=None, m3u8_id=None):\n ... | true | ||
ytdl-org/youtube-dl | 32,762 | comment_to_fix | [extractor/common] Fix crash in _report_ignoring_subs | Revert and fix `utils.bug_reports_message()` (2a):
```suggestion
update_cmd = 'see https://github.com/ytdl-org/youtube-dl/#user-content-installation on how to update'
``` | 21792b88b791b16e3ab0a0fb2e26e5bb8a4e2ff3 | 6c9912e83453098dd7a46a5eef6728dc0cafb9ac | diff --git a/youtube_dl/utils.py b/youtube_dl/utils.py
index 083446342b0..e1b05b30729 100644
--- a/youtube_dl/utils.py
+++ b/youtube_dl/utils.py
@@ -2371,15 +2371,24 @@ def set_alpn_protocols(ctx):
return YoutubeDLHTTPSHandler(params, context=context, **kwargs)
-def bug_reports_message():
+def bug_reports_... | [
"youtube_dl/utils.py"
] | [
{
"comment": "Revert and fix `utils.bug_reports_message()` (2a):\r\n```suggestion\r\n update_cmd = 'see https://github.com/ytdl-org/youtube-dl/#user-content-installation on how to update'\r\n```",
"path": "youtube_dl/utils.py",
"hunk": "@@ -2371,15 +2371,12 @@ def set_alpn_protocols(ctx):\n ... | true | ||
ytdl-org/youtube-dl | 32,762 | comment_to_fix | [extractor/common] Fix crash in _report_ignoring_subs | Revert and fix `utils.bug_reports_message()` (2b):
```suggestion
msg = (
' please report this issue on https://github.com/ytdl-org/youtube-dl/issues ,'
' using the appropriate issue template.'
' Make sure you are using the latest version; %s.'
' Be sure to call youtube-dl wit... | 21792b88b791b16e3ab0a0fb2e26e5bb8a4e2ff3 | 6c9912e83453098dd7a46a5eef6728dc0cafb9ac | diff --git a/youtube_dl/utils.py b/youtube_dl/utils.py
index 083446342b0..e1b05b30729 100644
--- a/youtube_dl/utils.py
+++ b/youtube_dl/utils.py
@@ -2371,15 +2371,24 @@ def set_alpn_protocols(ctx):
return YoutubeDLHTTPSHandler(params, context=context, **kwargs)
-def bug_reports_message():
+def bug_reports_... | [
"youtube_dl/utils.py"
] | [
{
"comment": "Revert and fix `utils.bug_reports_message()` (2b):\r\n```suggestion\r\n\r\n msg = (\r\n ' please report this issue on https://github.com/ytdl-org/youtube-dl/issues ,'\r\n ' using the appropriate issue template.'\r\n ' Make sure you are using the latest version; %s.'\r\n ... | true | ||
ytdl-org/youtube-dl | 32,762 | comment_to_fix | [extractor/common] Fix crash in _report_ignoring_subs | Remove initial space that is added in l.2391 if needed.
```suggestion
'please report this issue on https://github.com/ytdl-org/youtube-dl/issues ,'
``` | 21792b88b791b16e3ab0a0fb2e26e5bb8a4e2ff3 | 6c9912e83453098dd7a46a5eef6728dc0cafb9ac | diff --git a/youtube_dl/utils.py b/youtube_dl/utils.py
index 083446342b0..e1b05b30729 100644
--- a/youtube_dl/utils.py
+++ b/youtube_dl/utils.py
@@ -2371,15 +2371,24 @@ def set_alpn_protocols(ctx):
return YoutubeDLHTTPSHandler(params, context=context, **kwargs)
-def bug_reports_message():
+def bug_reports_... | [
"youtube_dl/utils.py"
] | [
{
"comment": "Remove initial space that is added in l.2391 if needed.\r\n```suggestion\r\n 'please report this issue on https://github.com/ytdl-org/youtube-dl/issues ,'\r\n```",
"path": "youtube_dl/utils.py",
"hunk": "@@ -2371,15 +2371,24 @@ def set_alpn_protocols(ctx):\n return YoutubeDL... | true | ||
ytdl-org/youtube-dl | 32,741 | issue_to_patch | External-downloader "ffmpeg" does not understand ffmpeg-location parameter
YoutubeDownloader does not use `ffmpeg-location` path for an `external-downloader` argument I think? Full folder value did not work in an external args.
```
youtube-dl.exe --verbose ^
--ffmpeg-location "c:/apps/ffmpeg" ^
--format "(bes... | [external/FFmpegFD] Fix ffmpeg detection with `--ffmpeg-location ...` (etc) | <details><summary>Boilerplate: own code/bug fix</summary>
## Please follow the guide below
- You will be asked some questions, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your *pull request* (like that [x])
- Use *Preview* tab to see how your *pull request*... | 820fae3b3a8587a6f57afbe803b4f91de7d4e086 | 26a5f1ba1c5221e2b6aca7308736603b2efc745e | diff --git a/youtube_dl/compat.py b/youtube_dl/compat.py
index 818ccebd0a6..53ff2a892af 100644
--- a/youtube_dl/compat.py
+++ b/youtube_dl/compat.py
@@ -2421,29 +2421,26 @@ def load(self, rawdata):
compat_urllib_request_urlretrieve = compat_urlretrieve
try:
+ from HTMLParser import (
+ HTMLParser as compa... | [
"test/test_downloader_external.py",
"youtube_dl/compat.py",
"youtube_dl/downloader/external.py",
"youtube_dl/postprocessor/ffmpeg.py",
"youtube_dl/utils.py"
] | [] | diff --git a/test/test_downloader_external.py b/test/test_downloader_external.py
index 029f9b05f64..4491bd9dee6 100644
--- a/test/test_downloader_external.py
+++ b/test/test_downloader_external.py
@@ -18,6 +18,7 @@
)
from youtube_dl import YoutubeDL
from youtube_dl.compat import (
+ compat_contextlib_suppress,
... | true |
ytdl-org/youtube-dl | 32,752 | issue_to_patch | [Youtube] Fix AttributeError no attribute '_YoutubeIE__ie_msg' if unable to decode n-parameter | ### Before submitting a *pull request* make sure you have:
- [x] [Searched](https://github.com/ytdl-org/youtube-dl/search?q=is%3Apr&type=Issues) the bugtracker for similar pull requests
- [ ] Read [adding new extractor tutorial](https://github.com/ytdl-org/youtube-dl#adding-support-for-a-new-site)
- [x] Read [youtub... | a96a45b2cdcfa5f20ae4264bed268cce93fbc521 | d3d52fc7f8554eb4d605077d0fe3bb3e0c6dba0d | diff --git a/youtube_dl/extractor/youtube.py b/youtube_dl/extractor/youtube.py
index db840fc4556..90c16e172bd 100644
--- a/youtube_dl/extractor/youtube.py
+++ b/youtube_dl/extractor/youtube.py
@@ -1647,10 +1647,10 @@ def _decrypt_nsig(self, n, video_id, player_url):
except JSInterpreter.Exception as e:
... | [
"youtube_dl/extractor/youtube.py"
] | [] | true | ||
ytdl-org/youtube-dl | 32,742 | issue_to_patch | [Vimeo] fix config parser regex | ## Please follow the guide below
- You will be asked some questions, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your *pull request* (like that [x])
- Use *Preview* tab to see how your *pull request* will actually look like
---
### Before submitting a *p... | 820fae3b3a8587a6f57afbe803b4f91de7d4e086 | 7b8cb3ea12da8c2f0db5ea67855ed66d23b5f01c | diff --git a/youtube_dl/extractor/vimeo.py b/youtube_dl/extractor/vimeo.py
index 8e1a805f640..47ec0a9b449 100644
--- a/youtube_dl/extractor/vimeo.py
+++ b/youtube_dl/extractor/vimeo.py
@@ -673,8 +673,8 @@ def _real_extract(self, url):
raise
if '//player.vimeo.com/video/' in url:
- con... | [
"youtube_dl/extractor/vimeo.py"
] | [
{
"comment": "Since 7216fa2ac4706e099ea2ad9a04fe7bf4300bc745, there is a better and (externally) simpler solution that shouldn't need to be tweaked when the site changes JS layout like this.\r\n```suggestion\r\n config = self._search_json(\r\n r'\\b(?:playerC|c)onfig\\s*=', webpage, 'info ... | true | ||
ytdl-org/youtube-dl | 32,742 | comment_to_fix | [Vimeo] fix config parser regex | Since 7216fa2ac4706e099ea2ad9a04fe7bf4300bc745, there is a better and (externally) simpler solution that shouldn't need to be tweaked when the site changes JS layout like this.
```suggestion
config = self._search_json(
r'\b(?:playerC|c)onfig\s*=', webpage, 'info section', video_id)
``` | 820fae3b3a8587a6f57afbe803b4f91de7d4e086 | 7b8cb3ea12da8c2f0db5ea67855ed66d23b5f01c | diff --git a/youtube_dl/extractor/vimeo.py b/youtube_dl/extractor/vimeo.py
index 8e1a805f640..47ec0a9b449 100644
--- a/youtube_dl/extractor/vimeo.py
+++ b/youtube_dl/extractor/vimeo.py
@@ -673,8 +673,8 @@ def _real_extract(self, url):
raise
if '//player.vimeo.com/video/' in url:
- con... | [
"youtube_dl/extractor/vimeo.py"
] | [
{
"comment": "Since 7216fa2ac4706e099ea2ad9a04fe7bf4300bc745, there is a better and (externally) simpler solution that shouldn't need to be tweaked when the site changes JS layout like this.\r\n```suggestion\r\n config = self._search_json(\r\n r'\\b(?:playerC|c)onfig\\s*=', webpage, 'info ... | true | ||
ytdl-org/youtube-dl | 32,725 | issue_to_patch | filemoon.sx jwplayer error
<!--
######################################################################
WARNING!
IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################
-->
## Checklist
<!--
Carefully read and... | [XFileShare] Update for 2024 with new InfoExtractor features | <details><summary>Boilerplate: improvement/own code</summary>
## Please follow the guide below
- You will be asked some questions, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your *pull request* (like that [x])
- Use *Preview* tab to see how your *pull requ... | f0812d784836d18fd25ea32f9b5a0c9c6e92425b | 132fb777dc78121c0cd123ce254f79602fe9c537 | diff --git a/youtube_dl/extractor/common.py b/youtube_dl/extractor/common.py
index 0e5dfd8fa99..7fae9e57bab 100644
--- a/youtube_dl/extractor/common.py
+++ b/youtube_dl/extractor/common.py
@@ -25,6 +25,7 @@
compat_getpass,
compat_integer_types,
compat_http_client,
+ compat_kwargs,
compat_map as m... | [
"test/test_utils.py",
"youtube_dl/extractor/common.py",
"youtube_dl/extractor/extractors.py",
"youtube_dl/extractor/filemoon.py",
"youtube_dl/extractor/xfileshare.py",
"youtube_dl/utils.py"
] | [
{
"comment": "```suggestion\r\n transform_source=transform_source, default=None)\r\n```",
"path": "youtube_dl/extractor/common.py",
"hunk": "@@ -2966,25 +3021,22 @@ def manifest_url(manifest):\n return formats\n \n def _find_jwplayer_data(self, webpage, video_id=None, transform_so... | diff --git a/test/test_utils.py b/test/test_utils.py
index 102420fcb88..d1d9ca1b24e 100644
--- a/test/test_utils.py
+++ b/test/test_utils.py
@@ -512,11 +512,14 @@ def test_float_or_none(self):
self.assertEqual(float_or_none(set()), None)
def test_int_or_none(self):
+ self.assertEqual(int_or_none(... | true |
ytdl-org/youtube-dl | 32,725 | comment_to_fix | [XFileShare] Update for 2024 with new InfoExtractor features | ```suggestion
transform_source=transform_source, default=None)
``` | f0812d784836d18fd25ea32f9b5a0c9c6e92425b | 132fb777dc78121c0cd123ce254f79602fe9c537 | diff --git a/youtube_dl/extractor/common.py b/youtube_dl/extractor/common.py
index 0e5dfd8fa99..7fae9e57bab 100644
--- a/youtube_dl/extractor/common.py
+++ b/youtube_dl/extractor/common.py
@@ -25,6 +25,7 @@
compat_getpass,
compat_integer_types,
compat_http_client,
+ compat_kwargs,
compat_map as m... | [
"youtube_dl/extractor/common.py"
] | [
{
"comment": "```suggestion\r\n transform_source=transform_source, default=None)\r\n```",
"path": "youtube_dl/extractor/common.py",
"hunk": "@@ -2966,25 +3021,22 @@ def manifest_url(manifest):\n return formats\n \n def _find_jwplayer_data(self, webpage, video_id=None, transform_so... | true | ||
ytdl-org/youtube-dl | 32,725 | comment_to_fix | [XFileShare] Update for 2024 with new InfoExtractor features | ```suggestion
def yield_urls():
for regex in cls._EMBED_REGEX:
for mobj in re.finditer(regex, webpage):
yield mobj.group('url')
``` | f0812d784836d18fd25ea32f9b5a0c9c6e92425b | 132fb777dc78121c0cd123ce254f79602fe9c537 | diff --git a/youtube_dl/extractor/xfileshare.py b/youtube_dl/extractor/xfileshare.py
index df9efa9faed..4dc3032e7e0 100644
--- a/youtube_dl/extractor/xfileshare.py
+++ b/youtube_dl/extractor/xfileshare.py
@@ -4,20 +4,28 @@
import re
from .common import InfoExtractor
-from ..compat import compat_chr
+from ..compat i... | [
"youtube_dl/extractor/xfileshare.py"
] | [
{
"comment": "```suggestion\r\n\r\n def yield_urls():\r\n for regex in cls._EMBED_REGEX:\r\n for mobj in re.finditer(regex, webpage):\r\n yield mobj.group('url')\r\n\r\n```",
"path": "youtube_dl/extractor/xfileshare.py",
"hunk": "@@ -26,84 +32,150 @@ d... | true | ||
ytdl-org/youtube-dl | 32,725 | comment_to_fix | [XFileShare] Update for 2024 with new InfoExtractor features | ```suggestion
return list(yield_urls())
``` | f0812d784836d18fd25ea32f9b5a0c9c6e92425b | 132fb777dc78121c0cd123ce254f79602fe9c537 | diff --git a/youtube_dl/extractor/xfileshare.py b/youtube_dl/extractor/xfileshare.py
index df9efa9faed..4dc3032e7e0 100644
--- a/youtube_dl/extractor/xfileshare.py
+++ b/youtube_dl/extractor/xfileshare.py
@@ -4,20 +4,28 @@
import re
from .common import InfoExtractor
-from ..compat import compat_chr
+from ..compat i... | [
"youtube_dl/extractor/xfileshare.py"
] | [
{
"comment": "```suggestion\r\n return list(yield_urls())\r\n```",
"path": "youtube_dl/extractor/xfileshare.py",
"hunk": "@@ -26,84 +32,150 @@ def aa_decode(aa_code):\n ('3', '(o^_^o)'),\n ('1', '(ﾟΘﾟ)'),\n ('0', '(c^_^o)'),\n- ]\n+ ('+', ''),\n+ )\n delim... | true | ||
ytdl-org/youtube-dl | 32,725 | comment_to_fix | [XFileShare] Update for 2024 with new InfoExtractor features | ```suggestion
jwplayer_data = self._find_jwplayer_data(
webpage.replace(r'\'', '\''), video_id)
result = self._parse_jwplayer_data(
jwplayer_data, video_id, require_title=False,
m3u8_id='hls', mpd_id='dash')
``` | f0812d784836d18fd25ea32f9b5a0c9c6e92425b | 132fb777dc78121c0cd123ce254f79602fe9c537 | diff --git a/youtube_dl/extractor/xfileshare.py b/youtube_dl/extractor/xfileshare.py
index df9efa9faed..4dc3032e7e0 100644
--- a/youtube_dl/extractor/xfileshare.py
+++ b/youtube_dl/extractor/xfileshare.py
@@ -4,20 +4,28 @@
import re
from .common import InfoExtractor
-from ..compat import compat_chr
+from ..compat i... | [
"youtube_dl/extractor/xfileshare.py"
] | [
{
"comment": "```suggestion\r\n jwplayer_data = self._find_jwplayer_data(\r\n webpage.replace(r'\\'', '\\''), video_id)\r\n result = self._parse_jwplayer_data(\r\n jwplayer_data, video_id, require_title=False,\r\n m3u8_id='hls', mpd_id='dash')\r\n```",
"path": ... | true | ||
ytdl-org/youtube-dl | 32,725 | comment_to_fix | [XFileShare] Update for 2024 with new InfoExtractor features | ```suggestion
default = kwargs.pop('default', NO_DEFAULT)
``` | f0812d784836d18fd25ea32f9b5a0c9c6e92425b | 132fb777dc78121c0cd123ce254f79602fe9c537 | diff --git a/youtube_dl/extractor/common.py b/youtube_dl/extractor/common.py
index 0e5dfd8fa99..7fae9e57bab 100644
--- a/youtube_dl/extractor/common.py
+++ b/youtube_dl/extractor/common.py
@@ -25,6 +25,7 @@
compat_getpass,
compat_integer_types,
compat_http_client,
+ compat_kwargs,
compat_map as m... | [
"youtube_dl/extractor/common.py"
] | [
{
"comment": "```suggestion\r\n default = kwargs.pop('default', NO_DEFAULT)\r\n```",
"path": "youtube_dl/extractor/common.py",
"hunk": "@@ -1102,6 +1103,60 @@ def _search_regex(self, pattern, string, name, default=NO_DEFAULT, fatal=True, f\n self._downloader.report_warning('unable to ... | true | ||
ytdl-org/youtube-dl | 28,801 | issue_to_patch | Vimeo embed-only video behind basic auth
## Please follow the guide below
- You will be asked some questions and requested to provide some information, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your *issue* (like this: `[x]`)
- Use the *Preview* tab to see ... | [utils] Handle user:pass in URLs | ## Please follow the guide below
- You will be asked some questions, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your *pull request* (like that [x])
- Use *Preview* tab to see how your *pull request* will actually look like
---
### Before submitting a *p... | 40bd5c18153afe765caa6726302ee1dd8a9a2ce6 | bcd12630e1b322609f4682eda94c98d8b9dbe925 | diff --git a/youtube_dl/utils.py b/youtube_dl/utils.py
index 61b94d84c44..c249e71681d 100644
--- a/youtube_dl/utils.py
+++ b/youtube_dl/utils.py
@@ -2182,8 +2182,28 @@ def sanitize_url(url):
return url
+def extract_basic_auth(url):
+ parts = compat_urllib_parse.urlsplit(url)
+ if parts.username is None:
... | [
"test/test_utils.py",
"youtube_dl/utils.py"
] | [
{
"comment": "Align with yt-dlp:\r\n```suggestion\r\n url, auth_header = extract_basic_auth(escape_url(sanitize_url(url)))\r\n if auth_header is not None:\r\n headers = args[1] if len(args) > 1 else kwargs.get'headers')\r\n headers = headers or {}\r\n headers['Authorization'] = auth_h... | diff --git a/test/test_utils.py b/test/test_utils.py
index 102420fcb88..90d64b5811e 100644
--- a/test/test_utils.py
+++ b/test/test_utils.py
@@ -81,6 +81,7 @@
sanitize_filename,
sanitize_path,
sanitize_url,
+ sanitized_Request,
shell_quote,
smuggle_url,
str_or_none,
@@ -255,6 +256,18 @@... | true |
ytdl-org/youtube-dl | 28,801 | comment_to_fix | [utils] Handle user:pass in URLs | Align with yt-dlp:
```suggestion
def extract_basic_auth(url):
parts = compat_urllib_parse.urlsplit(url)
if parts.username is None:
return url, None
url = compat_urllib_parse.urlunsplit(parts._replace(netloc=(
parts.hostname if parts.port is None
else '%s:%d' % (parts.hostname... | 40bd5c18153afe765caa6726302ee1dd8a9a2ce6 | bcd12630e1b322609f4682eda94c98d8b9dbe925 | diff --git a/youtube_dl/utils.py b/youtube_dl/utils.py
index 61b94d84c44..c249e71681d 100644
--- a/youtube_dl/utils.py
+++ b/youtube_dl/utils.py
@@ -2182,8 +2182,28 @@ def sanitize_url(url):
return url
+def extract_basic_auth(url):
+ parts = compat_urllib_parse.urlsplit(url)
+ if parts.username is None:
... | [
"youtube_dl/utils.py"
] | [
{
"comment": "Align with yt-dlp:\r\n```suggestion\r\ndef extract_basic_auth(url):\r\n parts = compat_urllib_parse.urlsplit(url)\r\n if parts.username is None:\r\n return url, None\r\n url = compat_urllib_parse.urlunsplit(parts._replace(netloc=(\r\n parts.hostname if parts.port is None\r\n... | true | ||
ytdl-org/youtube-dl | 28,801 | comment_to_fix | [utils] Handle user:pass in URLs | Align with yt-dlp:
```suggestion
``` | 40bd5c18153afe765caa6726302ee1dd8a9a2ce6 | bcd12630e1b322609f4682eda94c98d8b9dbe925 | diff --git a/test/test_utils.py b/test/test_utils.py
index 102420fcb88..90d64b5811e 100644
--- a/test/test_utils.py
+++ b/test/test_utils.py
@@ -81,6 +81,7 @@
sanitize_filename,
sanitize_path,
sanitize_url,
+ sanitized_Request,
shell_quote,
smuggle_url,
str_or_none,
@@ -255,6 +256,18 @@... | [
"test/test_utils.py"
] | [
{
"comment": "Align with yt-dlp:\r\n```suggestion\r\n```",
"path": "test/test_utils.py",
"hunk": "@@ -237,6 +239,26 @@ def test_sanitize_url(self):\n self.assertEqual(sanitize_url('rmtps://foo.bar'), 'rtmps://foo.bar')\n self.assertEqual(sanitize_url('https://foo.bar'), 'https://foo.bar'... | true | ||
ytdl-org/youtube-dl | 28,801 | comment_to_fix | [utils] Handle user:pass in URLs | Move after `rot47`. | 40bd5c18153afe765caa6726302ee1dd8a9a2ce6 | bcd12630e1b322609f4682eda94c98d8b9dbe925 | diff --git a/test/test_utils.py b/test/test_utils.py
index 102420fcb88..90d64b5811e 100644
--- a/test/test_utils.py
+++ b/test/test_utils.py
@@ -81,6 +81,7 @@
sanitize_filename,
sanitize_path,
sanitize_url,
+ sanitized_Request,
shell_quote,
smuggle_url,
str_or_none,
@@ -255,6 +256,18 @@... | [
"test/test_utils.py"
] | [
{
"comment": "Move after `rot47`.",
"path": "test/test_utils.py",
"hunk": "@@ -65,6 +65,8 @@\n sanitize_filename,\n sanitize_path,\n sanitize_url,\n+ extract_user_pass,\n+ sanitized_Request,",
"resolving_sha": "bcd12630e1b322609f4682eda94c98d8b9dbe925",
"resolving_diff": "diff ... | true | ||
ytdl-org/youtube-dl | 28,801 | comment_to_fix | [utils] Handle user:pass in URLs | ```suggestion
url, auth_header = extract_basic_auth(escape_url(sanitize_url(url)))
if auth_header is not None:
headers = args[1] if len(args) > 1 else kwargs.get('headers')
headers = headers or {}
headers['Authorization'] = auth_header
if len(args) <= 1 and kwargs.get('head... | 40bd5c18153afe765caa6726302ee1dd8a9a2ce6 | bcd12630e1b322609f4682eda94c98d8b9dbe925 | diff --git a/youtube_dl/utils.py b/youtube_dl/utils.py
index 61b94d84c44..c249e71681d 100644
--- a/youtube_dl/utils.py
+++ b/youtube_dl/utils.py
@@ -2182,8 +2182,28 @@ def sanitize_url(url):
return url
+def extract_basic_auth(url):
+ parts = compat_urllib_parse.urlsplit(url)
+ if parts.username is None:
... | [
"youtube_dl/utils.py"
] | [
{
"comment": "```suggestion\r\n url, auth_header = extract_basic_auth(escape_url(sanitize_url(url)))\r\n if auth_header is not None:\r\n headers = args[1] if len(args) > 1 else kwargs.get('headers')\r\n headers = headers or {}\r\n headers['Authorization'] = auth_header\r\n if l... | true | ||
ytdl-org/youtube-dl | 32,514 | issue_to_patch | Caffeine support
<!--
######################################################################
WARNING!
IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################
-->
## Checklist
<!--
Carefully read and work thro... | [caffeine.tv] Add new extractor | ## Please follow the guide below
- You will be asked some questions, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your *pull request* (like that [x])
- Use *Preview* tab to see how your *pull request* will actually look like
---
### Before submitting a *p... | b7fca0fab36c71fee02d6ecf81acbbaa46942be4 | a6754081fd639d1fee65b557a6e5e9d02938779a | diff --git a/youtube_dl/extractor/caffeine.py b/youtube_dl/extractor/caffeine.py
new file mode 100644
index 00000000000..bffedb9a736
--- /dev/null
+++ b/youtube_dl/extractor/caffeine.py
@@ -0,0 +1,79 @@
+# coding: utf-8
+from __future__ import unicode_literals
+
+from .common import InfoExtractor
+from ..utils import (... | [
"youtube_dl/extractor/caffeine.py",
"youtube_dl/extractor/extractors.py"
] | [
{
"comment": "For \"reasons\", the list is preferred:\r\n```suggestion\r\n _TESTS = [{\r\n 'url': 'https://www.caffeine.tv/TsuSurf/video/cffc0a00-e73f-11ec-8080-80017d29f26e',\r\n 'info_dict': {\r\n 'id': 'cffc0a00-e73f-11ec-8080-80017d29f26e',\r\n 'ext': 'mp4',\r\n ... | true | |
ytdl-org/youtube-dl | 32,514 | comment_to_fix | [caffeine.tv] Add new extractor | For "reasons", the list is preferred:
```suggestion
_TESTS = [{
'url': 'https://www.caffeine.tv/TsuSurf/video/cffc0a00-e73f-11ec-8080-80017d29f26e',
'info_dict': {
'id': 'cffc0a00-e73f-11ec-8080-80017d29f26e',
'ext': 'mp4',
'title': 'GOOOOD MORNINNNNN #high... | b7fca0fab36c71fee02d6ecf81acbbaa46942be4 | a6754081fd639d1fee65b557a6e5e9d02938779a | diff --git a/youtube_dl/extractor/caffeine.py b/youtube_dl/extractor/caffeine.py
new file mode 100644
index 00000000000..bffedb9a736
--- /dev/null
+++ b/youtube_dl/extractor/caffeine.py
@@ -0,0 +1,79 @@
+# coding: utf-8
+from __future__ import unicode_literals
+
+from .common import InfoExtractor
+from ..utils import (... | [
"youtube_dl/extractor/caffeine.py"
] | [
{
"comment": "For \"reasons\", the list is preferred:\r\n```suggestion\r\n _TESTS = [{\r\n 'url': 'https://www.caffeine.tv/TsuSurf/video/cffc0a00-e73f-11ec-8080-80017d29f26e',\r\n 'info_dict': {\r\n 'id': 'cffc0a00-e73f-11ec-8080-80017d29f26e',\r\n 'ext': 'mp4',\r\n ... | true | ||
ytdl-org/youtube-dl | 32,514 | comment_to_fix | [caffeine.tv] Add new extractor | Conventionally, call the named group `id` (you can use a standard method later):
```suggestion
_VALID_URL = r'https?://(?:www\.)?caffeine\.tv/.+/video/(?P<id>[0-9a-f-]+)'
```
Or if there's only one level of path component before `/video`:
```suggestion
_VALID_URL = r'https?://(?:www\.)?caffeine\.tv/[^/]+/... | b7fca0fab36c71fee02d6ecf81acbbaa46942be4 | a6754081fd639d1fee65b557a6e5e9d02938779a | diff --git a/youtube_dl/extractor/caffeine.py b/youtube_dl/extractor/caffeine.py
new file mode 100644
index 00000000000..bffedb9a736
--- /dev/null
+++ b/youtube_dl/extractor/caffeine.py
@@ -0,0 +1,79 @@
+# coding: utf-8
+from __future__ import unicode_literals
+
+from .common import InfoExtractor
+from ..utils import (... | [
"youtube_dl/extractor/caffeine.py"
] | [
{
"comment": "Conventionally, call the named group `id` (you can use a standard method later):\r\n```suggestion\r\n _VALID_URL = r'https?://(?:www\\.)?caffeine\\.tv/.+/video/(?P<id>[0-9a-f-]+)'\r\n```\r\nOr if there's only one level of path component before `/video`:\r\n```suggestion\r\n _VALID_URL = r'ht... | true | ||
ytdl-org/youtube-dl | 32,514 | comment_to_fix | [caffeine.tv] Add new extractor | With the modified `_VALID_URL`:
```suggestion
video_id = self._match_id(url)
``` | b7fca0fab36c71fee02d6ecf81acbbaa46942be4 | a6754081fd639d1fee65b557a6e5e9d02938779a | diff --git a/youtube_dl/extractor/caffeine.py b/youtube_dl/extractor/caffeine.py
new file mode 100644
index 00000000000..bffedb9a736
--- /dev/null
+++ b/youtube_dl/extractor/caffeine.py
@@ -0,0 +1,79 @@
+# coding: utf-8
+from __future__ import unicode_literals
+
+from .common import InfoExtractor
+from ..utils import (... | [
"youtube_dl/extractor/caffeine.py"
] | [
{
"comment": "With the modified `_VALID_URL`:\r\n```suggestion\r\n video_id = self._match_id(url)\r\n```",
"path": "youtube_dl/extractor/caffeine.py",
"hunk": "@@ -0,0 +1,43 @@\n+# coding: utf-8\n+from __future__ import unicode_literals\n+\n+from .common import InfoExtractor\n+from ..utils import... | true | ||
ytdl-org/youtube-dl | 32,514 | comment_to_fix | [caffeine.tv] Add new extractor | Is it certain that `video_url` is a manifest? If raw `.mp4` URLs might also be served, s/t like this would be appropriate (plenty of examples in existing extractors:
```suggestion
ext = determine_ext(video_url)
if ext == 'm3u8':
formats = self._extract_m3u8_formats(
vide... | b7fca0fab36c71fee02d6ecf81acbbaa46942be4 | a6754081fd639d1fee65b557a6e5e9d02938779a | diff --git a/youtube_dl/extractor/caffeine.py b/youtube_dl/extractor/caffeine.py
new file mode 100644
index 00000000000..bffedb9a736
--- /dev/null
+++ b/youtube_dl/extractor/caffeine.py
@@ -0,0 +1,79 @@
+# coding: utf-8
+from __future__ import unicode_literals
+
+from .common import InfoExtractor
+from ..utils import (... | [
"youtube_dl/extractor/caffeine.py"
] | [
{
"comment": "Is it certain that `video_url` is a manifest? If raw `.mp4` URLs might also be served, s/t like this would be appropriate (plenty of examples in existing extractors:\r\n```suggestion\r\n ext = determine_ext(video_url)\r\n if ext == 'm3u8':\r\n formats = self._extract_m3u8_... | true | ||
ytdl-org/youtube-dl | 32,514 | comment_to_fix | [caffeine.tv] Add new extractor | In case this API call goes wrong, let's make it fail in the simplest way (`traverse_obj()`, `T()` imported from `..utils`):
```suggestion
broadcast_info = traverse_obj(json_data, ('broadcast_info', T(dict))) or {}
title = broadcast_info['broadcast_title']
video_url = broadcast_info['video_ur... | b7fca0fab36c71fee02d6ecf81acbbaa46942be4 | a6754081fd639d1fee65b557a6e5e9d02938779a | diff --git a/youtube_dl/extractor/caffeine.py b/youtube_dl/extractor/caffeine.py
new file mode 100644
index 00000000000..bffedb9a736
--- /dev/null
+++ b/youtube_dl/extractor/caffeine.py
@@ -0,0 +1,79 @@
+# coding: utf-8
+from __future__ import unicode_literals
+
+from .common import InfoExtractor
+from ..utils import (... | [
"youtube_dl/extractor/caffeine.py"
] | [
{
"comment": "In case this API call goes wrong, let's make it fail in the simplest way (`traverse_obj()`, `T()` imported from `..utils`):\r\n```suggestion\r\n broadcast_info = traverse_obj(json_data, ('broadcast_info', T(dict))) or {}\r\n title = broadcast_info['broadcast_title']\r\n video_... | true | ||
ytdl-org/youtube-dl | 32,514 | comment_to_fix | [caffeine.tv] Add new extractor | The optional metadata items shouldn't crash the extraction; also, the test video's JSON indicates that other standard attributes can be extracted:
```suggestion
info = {
'id': video_id,
'title': title,
'formats': formats,
}
info.update(traverse_obj(json... | b7fca0fab36c71fee02d6ecf81acbbaa46942be4 | a6754081fd639d1fee65b557a6e5e9d02938779a | diff --git a/youtube_dl/extractor/caffeine.py b/youtube_dl/extractor/caffeine.py
new file mode 100644
index 00000000000..bffedb9a736
--- /dev/null
+++ b/youtube_dl/extractor/caffeine.py
@@ -0,0 +1,79 @@
+# coding: utf-8
+from __future__ import unicode_literals
+
+from .common import InfoExtractor
+from ..utils import (... | [
"youtube_dl/extractor/caffeine.py"
] | [
{
"comment": "The optional metadata items shouldn't crash the extraction; also, the test video's JSON indicates that other standard attributes can be extracted:\r\n```suggestion\r\n info = {\r\n 'id': video_id,\r\n 'title': title,\r\n 'formats': formats,\r\n }\r\n ... | true | ||
ytdl-org/youtube-dl | 32,514 | comment_to_fix | [caffeine.tv] Add new extractor | Roll up suggestions in a new version that passes its test:
```suggestion
# coding: utf-8
from __future__ import unicode_literals
from .common import InfoExtractor
from ..utils import (
determine_ext,
int_or_none,
merge_dicts,
parse_iso8601,
T,
traverse_obj,
txt_or_none,
ur... | b7fca0fab36c71fee02d6ecf81acbbaa46942be4 | a6754081fd639d1fee65b557a6e5e9d02938779a | diff --git a/youtube_dl/extractor/caffeine.py b/youtube_dl/extractor/caffeine.py
new file mode 100644
index 00000000000..bffedb9a736
--- /dev/null
+++ b/youtube_dl/extractor/caffeine.py
@@ -0,0 +1,79 @@
+# coding: utf-8
+from __future__ import unicode_literals
+
+from .common import InfoExtractor
+from ..utils import (... | [
"youtube_dl/extractor/caffeine.py"
] | [
{
"comment": "Roll up suggestions in a new version that passes its test:\r\n```suggestion\r\n# coding: utf-8\r\nfrom __future__ import unicode_literals\r\n\r\nfrom .common import InfoExtractor\r\nfrom ..utils import (\r\n determine_ext,\r\n int_or_none,\r\n merge_dicts,\r\n parse_iso8601,\r\n T,\... | true | ||
ytdl-org/youtube-dl | 32,514 | comment_to_fix | [caffeine.tv] Add new extractor | ```suggestion
from .caffeine import CaffeineTVIE
``` | b7fca0fab36c71fee02d6ecf81acbbaa46942be4 | a6754081fd639d1fee65b557a6e5e9d02938779a | diff --git a/youtube_dl/extractor/extractors.py b/youtube_dl/extractor/extractors.py
index cb39876c279..c2eb0a57c5b 100644
--- a/youtube_dl/extractor/extractors.py
+++ b/youtube_dl/extractor/extractors.py
@@ -159,6 +159,7 @@
from .buzzfeed import BuzzFeedIE
from .byutv import BYUtvIE
from .c56 import C56IE
+from .ca... | [
"youtube_dl/extractor/extractors.py"
] | [
{
"comment": "```suggestion\r\nfrom .caffeine import CaffeineTVIE\r\n```",
"path": "youtube_dl/extractor/extractors.py",
"hunk": "@@ -159,6 +159,7 @@\n from .buzzfeed import BuzzFeedIE\n from .byutv import BYUtvIE\n from .c56 import C56IE\n+from .caffeine import CaffeineIE",
"resolving_sha": "a67540... | true | ||
ytdl-org/youtube-dl | 32,710 | issue_to_patch | [common] _parse_mpd_formats doesn't handle range-based segment lists
this site has changed streaming procedure at 2007/7/31
>youtube-dl.exe http://www.thisav.com/video/300708/99-06-0776.html --verbose
[debug] System config: []
[debug] User config: []
[debug] Custom config: []
[debug] Command-line args: ['http://... | [Vbox7,DASH] Fix and improve extraction with DASH manifests using range and base URL | <details><summary>Boilerplate (own/yt-dl/yt-dlp code, bug fix/improvement)</summary>
## Please follow the guide below
- You will be asked some questions, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your *pull request* (like that [x])
- Use *Preview* tab to se... | dc512e3a8a26a8e3fc7f1f67e5ee5e7699db8659 | 630da9eb76152a6fdbfc015aa171149c1d86a646 | diff --git a/youtube_dl/downloader/dash.py b/youtube_dl/downloader/dash.py
index 2800d42609e..f3c058879fb 100644
--- a/youtube_dl/downloader/dash.py
+++ b/youtube_dl/downloader/dash.py
@@ -35,6 +35,7 @@ def real_download(self, filename, info_dict):
for frag_index, fragment in enumerate(fragments, 1):
... | [
"test/test_InfoExtractor.py",
"test/testdata/mpd/range_only.mpd",
"test/testdata/mpd/subtitles.mpd",
"test/testdata/mpd/url_and_range.mpd",
"youtube_dl/downloader/dash.py",
"youtube_dl/extractor/common.py",
"youtube_dl/extractor/vbox7.py"
] | [] | diff --git a/test/test_InfoExtractor.py b/test/test_InfoExtractor.py
index 3f96645de02..d55d6ad5428 100644
--- a/test/test_InfoExtractor.py
+++ b/test/test_InfoExtractor.py
@@ -993,7 +993,8 @@ def test_parse_mpd_formats(self):
'tbr': 5997.485,
'width': 1920,
... | true |
ytdl-org/youtube-dl | 32,695 | issue_to_patch | [YouTube] Realign `n-sig` processing with yt-dlp | ## Please follow the guide below
- You will be asked some questions, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your *pull request* (like that [x])
- Use *Preview* tab to see how your *pull request* will actually look like
---
### Before submitting a *p... | be008e657d79832642e2158557c899249c9e31cd | e1db71781ea35789d8146904eb8513ef6e348470 | diff --git a/youtube_dl/compat.py b/youtube_dl/compat.py
index 3c526a78dc5..818ccebd0a6 100644
--- a/youtube_dl/compat.py
+++ b/youtube_dl/compat.py
@@ -58,19 +58,26 @@
# Also fix up lack of method arg in old Pythons
try:
- _req = compat_urllib_request.Request
- _req('http://127.0.0.1', method='GET')
+ typ... | [
"test/test_compat.py",
"test/test_subtitles.py",
"youtube_dl/compat.py",
"youtube_dl/extractor/common.py",
"youtube_dl/extractor/youtube.py"
] | [] | diff --git a/test/test_compat.py b/test/test_compat.py
index e233b1ae1b7..b83c8cb4100 100644
--- a/test/test_compat.py
+++ b/test/test_compat.py
@@ -23,6 +23,7 @@
compat_urllib_parse_unquote,
compat_urllib_parse_unquote_plus,
compat_urllib_parse_urlencode,
+ compat_urllib_request,
)
@@ -135,6 +13... | true | |
ytdl-org/youtube-dl | 32,559 | issue_to_patch | Option --write-info-json for video with percent sign in title causes TypeError "not enough arguments for format string"
## Checklist
- [x] I'm reporting a broken site support issue
- [x] I've verified that I'm running youtube-dl version **2021.12.17**
- [x] I've checked that all provided URLs are alive and playab... | Fix format string injection when using option --write-info-json for video with percent sign in title. (Caused TypeError "not enough arguments for format string") | ### Before submitting a *pull request* make sure you have:
- [x] [Searched](https://github.com/ytdl-org/youtube-dl/search?q=is%3Apr&type=Issues) the bugtracker for similar pull requests
- [ ] Read [adding new extractor tutorial](https://github.com/ytdl-org/youtube-dl#adding-support-for-a-new-site)
- It is not a ne... | c62936a5f20d941e67d566e74a7c3fc8d8188f7a | b858f8217943d78d178685319d4a3de900d7e839 | diff --git a/youtube_dl/YoutubeDL.py b/youtube_dl/YoutubeDL.py
index 13a41928f2c..6f2aba5ac8e 100755
--- a/youtube_dl/YoutubeDL.py
+++ b/youtube_dl/YoutubeDL.py
@@ -2635,12 +2635,12 @@ def msg(fmt, lbl):
self.to_screen(msg('[info] %s is already present', label.title()))
return 'exists'
... | [
"youtube_dl/YoutubeDL.py"
] | [] | true | |
ytdl-org/youtube-dl | 32,638 | issue_to_patch | ERROR: Unable to extract yt initial data on playlist
<!--
######################################################################
WARNING!
IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################
-->
## Checklist
... | fix(youtube): update extractor handling consent | ## Please follow the guide below
- You will be asked some questions, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your *pull request* (like that [x])
- Use *Preview* tab to see how your *pull request* will actually look like
---
### Before submitting a *p... | 00ef748cc0e35ee60efd0f7a00e373ab8d1af86b | 1a6b0ab5fc6116597d6a1094a0aa23a2cffc9217 | diff --git a/youtube_dl/extractor/youtube.py b/youtube_dl/extractor/youtube.py
index 9c419c00222..3bf483c1c8a 100644
--- a/youtube_dl/extractor/youtube.py
+++ b/youtube_dl/extractor/youtube.py
@@ -260,16 +260,10 @@ def _initialize_consent(self):
cookies = self._get_cookies('https://www.youtube.com/')
... | [
"youtube_dl/extractor/youtube.py"
] | [] | true | |
ytdl-org/youtube-dl | 32,634 | issue_to_patch | [telewebion] fix extraction | ## Please follow the guide below
- You will be asked some questions, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your *pull request* (like that [x])
- Use *Preview* tab to see how your *pull request* will actually look like
---
### Before submitting a *p... | b7fca0fab36c71fee02d6ecf81acbbaa46942be4 | 1fcdc82b922ed342fa70348bb3a5270bd88e4a14 | diff --git a/youtube_dl/extractor/telewebion.py b/youtube_dl/extractor/telewebion.py
index 1207b1a1b8c..30192d74e17 100644
--- a/youtube_dl/extractor/telewebion.py
+++ b/youtube_dl/extractor/telewebion.py
@@ -3,17 +3,23 @@
from .common import InfoExtractor
+from ..utils import (
+ float_or_none,
+ int_or_non... | [
"youtube_dl/extractor/telewebion.py"
] | [
{
"comment": "```suggestion\r\n 'thumbnail': r're:^https?://static\\.telewebion\\.com/episodeImages/.*/default',\r\n```",
"path": "youtube_dl/extractor/telewebion.py",
"hunk": "@@ -5,15 +5,15 @@\n \n \n class TelewebionIE(InfoExtractor):\n- _VALID_URL = r'https?://(?:www\\.)?telewebion\\.c... | true | ||
ytdl-org/youtube-dl | 32,634 | comment_to_fix | [telewebion] fix extraction | ```suggestion
'thumbnail': r're:^https?://static\.telewebion\.com/episodeImages/.*/default',
``` | b7fca0fab36c71fee02d6ecf81acbbaa46942be4 | 1fcdc82b922ed342fa70348bb3a5270bd88e4a14 | diff --git a/youtube_dl/extractor/telewebion.py b/youtube_dl/extractor/telewebion.py
index 1207b1a1b8c..30192d74e17 100644
--- a/youtube_dl/extractor/telewebion.py
+++ b/youtube_dl/extractor/telewebion.py
@@ -3,17 +3,23 @@
from .common import InfoExtractor
+from ..utils import (
+ float_or_none,
+ int_or_non... | [
"youtube_dl/extractor/telewebion.py"
] | [
{
"comment": "```suggestion\r\n 'thumbnail': r're:^https?://static\\.telewebion\\.com/episodeImages/.*/default',\r\n```",
"path": "youtube_dl/extractor/telewebion.py",
"hunk": "@@ -5,15 +5,15 @@\n \n \n class TelewebionIE(InfoExtractor):\n- _VALID_URL = r'https?://(?:www\\.)?telewebion\\.c... | true | ||
ytdl-org/youtube-dl | 32,634 | comment_to_fix | [telewebion] fix extraction | This is less repetitive:
```suggestion
m3u8_url = 'https://cdna.telewebion.com/{0}/episode/{1}/playlist.m3u8'.format(channel_id, video_id)
``` | b7fca0fab36c71fee02d6ecf81acbbaa46942be4 | 1fcdc82b922ed342fa70348bb3a5270bd88e4a14 | diff --git a/youtube_dl/extractor/telewebion.py b/youtube_dl/extractor/telewebion.py
index 1207b1a1b8c..30192d74e17 100644
--- a/youtube_dl/extractor/telewebion.py
+++ b/youtube_dl/extractor/telewebion.py
@@ -3,17 +3,23 @@
from .common import InfoExtractor
+from ..utils import (
+ float_or_none,
+ int_or_non... | [
"youtube_dl/extractor/telewebion.py"
] | [
{
"comment": "This is less repetitive:\r\n```suggestion\r\n m3u8_url = 'https://cdna.telewebion.com/{0}/episode/{1}/playlist.m3u8'.format(channel_id, video_id)\r\n```",
"path": "youtube_dl/extractor/telewebion.py",
"hunk": "@@ -25,31 +25,26 @@ class TelewebionIE(InfoExtractor):\n def _real_ex... | true | ||
ytdl-org/youtube-dl | 32,634 | comment_to_fix | [telewebion] fix extraction | Currently we require a`title` so this could be reverted. | b7fca0fab36c71fee02d6ecf81acbbaa46942be4 | 1fcdc82b922ed342fa70348bb3a5270bd88e4a14 | diff --git a/youtube_dl/extractor/telewebion.py b/youtube_dl/extractor/telewebion.py
index 1207b1a1b8c..30192d74e17 100644
--- a/youtube_dl/extractor/telewebion.py
+++ b/youtube_dl/extractor/telewebion.py
@@ -3,17 +3,23 @@
from .common import InfoExtractor
+from ..utils import (
+ float_or_none,
+ int_or_non... | [
"youtube_dl/extractor/telewebion.py"
] | [
{
"comment": "Currently we require a`title` so this could be reverted.",
"path": "youtube_dl/extractor/telewebion.py",
"hunk": "@@ -25,31 +25,26 @@ class TelewebionIE(InfoExtractor):\n def _real_extract(self, url):\n video_id = self._match_id(url)\n \n- secure_token = self._download_w... | true | ||
ytdl-org/youtube-dl | 32,634 | comment_to_fix | [telewebion] fix extraction | ```suggestion
'view_count': int_or_none(episode_details.get('view_count')),
'duration': float_or_none(episode_details.get('duration')),
```
Import the `..._or_none()` functions from `..utils`. | b7fca0fab36c71fee02d6ecf81acbbaa46942be4 | 1fcdc82b922ed342fa70348bb3a5270bd88e4a14 | diff --git a/youtube_dl/extractor/telewebion.py b/youtube_dl/extractor/telewebion.py
index 1207b1a1b8c..30192d74e17 100644
--- a/youtube_dl/extractor/telewebion.py
+++ b/youtube_dl/extractor/telewebion.py
@@ -3,17 +3,23 @@
from .common import InfoExtractor
+from ..utils import (
+ float_or_none,
+ int_or_non... | [
"youtube_dl/extractor/telewebion.py"
] | [
{
"comment": "```suggestion\r\n 'view_count': int_or_none(episode_details.get('view_count')),\r\n 'duration': float_or_none(episode_details.get('duration')),\r\n```\r\nImport the `..._or_none()` functions from `..utils`. ",
"path": "youtube_dl/extractor/telewebion.py",
"hunk": "@@ ... | true | ||
ytdl-org/youtube-dl | 32,634 | comment_to_fix | [telewebion] fix extraction | Scrap the `thumbnails` stuff and replace the returned value with a single `thumbnail`
```py
'thumbnail': url_or_none(episode_image),
```
(we expect it will pass the `url_or_none` -- import from `..utils` -- test since it was constructed earlier, but that might change) | b7fca0fab36c71fee02d6ecf81acbbaa46942be4 | 1fcdc82b922ed342fa70348bb3a5270bd88e4a14 | diff --git a/youtube_dl/extractor/telewebion.py b/youtube_dl/extractor/telewebion.py
index 1207b1a1b8c..30192d74e17 100644
--- a/youtube_dl/extractor/telewebion.py
+++ b/youtube_dl/extractor/telewebion.py
@@ -3,17 +3,23 @@
from .common import InfoExtractor
+from ..utils import (
+ float_or_none,
+ int_or_non... | [
"youtube_dl/extractor/telewebion.py"
] | [
{
"comment": "Scrap the `thumbnails` stuff and replace the returned value with a single `thumbnail`\r\n```py\r\n 'thumbnail': url_or_none(episode_image),\r\n```\r\n(we expect it will pass the `url_or_none` -- import from `..utils` -- test since it was constructed earlier, but that might change)",
... | true | ||
ytdl-org/youtube-dl | 32,634 | comment_to_fix | [telewebion] fix extraction | 1. "" -> '' here too
2. Don't crash if no `episode_image_id`
3. Ancient Pythons can't count here either
```suggestion
channel_id = episode_details['channel']['descriptor']
episode_image_id = episode_details.get('image')
episode_image = 'https://static.telewebion.com/episodeImages/{0}/defau... | b7fca0fab36c71fee02d6ecf81acbbaa46942be4 | 1fcdc82b922ed342fa70348bb3a5270bd88e4a14 | diff --git a/youtube_dl/extractor/telewebion.py b/youtube_dl/extractor/telewebion.py
index 1207b1a1b8c..30192d74e17 100644
--- a/youtube_dl/extractor/telewebion.py
+++ b/youtube_dl/extractor/telewebion.py
@@ -3,17 +3,23 @@
from .common import InfoExtractor
+from ..utils import (
+ float_or_none,
+ int_or_non... | [
"youtube_dl/extractor/telewebion.py"
] | [
{
"comment": "1. \"\" -> '' here too\r\n2. Don't crash if no `episode_image_id`\r\n3. Ancient Pythons can't count here either\r\n```suggestion\r\n channel_id = episode_details['channel']['descriptor']\r\n episode_image_id = episode_details.get('image')\r\n episode_image = 'https://static.te... | true | ||
ytdl-org/youtube-dl | 32,634 | comment_to_fix | [telewebion] fix extraction | 1. Project convention: "" -> ''
2. Ancient Pythons can't count and need a number or keyword name inside {}
```suggestion
episode_details = self._download_json('https://gateway.telewebion.ir/kandoo/episode/getEpisodeDetail/?EpisodeId={0}'.format(video_id), video_id)
episode_details = episode_details[... | b7fca0fab36c71fee02d6ecf81acbbaa46942be4 | 1fcdc82b922ed342fa70348bb3a5270bd88e4a14 | diff --git a/youtube_dl/extractor/telewebion.py b/youtube_dl/extractor/telewebion.py
index 1207b1a1b8c..30192d74e17 100644
--- a/youtube_dl/extractor/telewebion.py
+++ b/youtube_dl/extractor/telewebion.py
@@ -3,17 +3,23 @@
from .common import InfoExtractor
+from ..utils import (
+ float_or_none,
+ int_or_non... | [
"youtube_dl/extractor/telewebion.py"
] | [
{
"comment": "1. Project convention: \"\" -> ''\r\n2. Ancient Pythons can't count and need a number or keyword name inside {}\r\n```suggestion\r\n episode_details = self._download_json('https://gateway.telewebion.ir/kandoo/episode/getEpisodeDetail/?EpisodeId={0}'.format(video_id), video_id)\r\n ep... | true | ||
ytdl-org/youtube-dl | 32,634 | comment_to_fix | [telewebion] fix extraction | The manifests don't need _ffmpeg_ (this is the _yt-dlp_ default but not yet here).
```suggestion
m3u8_url, video_id, ext='mp4', m3u8_id='hls',
entry_protocol='m3u8_native')
``` | b7fca0fab36c71fee02d6ecf81acbbaa46942be4 | 1fcdc82b922ed342fa70348bb3a5270bd88e4a14 | diff --git a/youtube_dl/extractor/telewebion.py b/youtube_dl/extractor/telewebion.py
index 1207b1a1b8c..30192d74e17 100644
--- a/youtube_dl/extractor/telewebion.py
+++ b/youtube_dl/extractor/telewebion.py
@@ -3,17 +3,23 @@
from .common import InfoExtractor
+from ..utils import (
+ float_or_none,
+ int_or_non... | [
"youtube_dl/extractor/telewebion.py"
] | [
{
"comment": "The manifests don't need _ffmpeg_ (this is the _yt-dlp_ default but not yet here).\r\n```suggestion\r\n m3u8_url, video_id, ext='mp4', m3u8_id='hls',\r\n entry_protocol='m3u8_native')\r\n```",
"path": "youtube_dl/extractor/telewebion.py",
"hunk": "@@ -25,31 +31,22 @@ ... | true | ||
ytdl-org/youtube-dl | 32,634 | comment_to_fix | [telewebion] fix extraction | And we need this too, since more than one format may be returned:
```suggestion
m3u8_url = 'https://cdna.telewebion.com/{0}/episode/{1}/playlist.m3u8'.format(channel_id, video_id)
formats = self._extract_m3u8_formats(
m3u8_url, video_id, ext='mp4', m3u8_id='hls',
entry_proto... | b7fca0fab36c71fee02d6ecf81acbbaa46942be4 | 1fcdc82b922ed342fa70348bb3a5270bd88e4a14 | diff --git a/youtube_dl/extractor/telewebion.py b/youtube_dl/extractor/telewebion.py
index 1207b1a1b8c..30192d74e17 100644
--- a/youtube_dl/extractor/telewebion.py
+++ b/youtube_dl/extractor/telewebion.py
@@ -3,17 +3,23 @@
from .common import InfoExtractor
+from ..utils import (
+ float_or_none,
+ int_or_non... | [
"youtube_dl/extractor/telewebion.py"
] | [
{
"comment": "And we need this too, since more than one format may be returned:\r\n```suggestion\r\n m3u8_url = 'https://cdna.telewebion.com/{0}/episode/{1}/playlist.m3u8'.format(channel_id, video_id)\r\n formats = self._extract_m3u8_formats(\r\n m3u8_url, video_id, ext='mp4', m3u8_id='... | true | ||
ytdl-org/youtube-dl | 32,628 | issue_to_patch | Epidemic Sound
<!--
######################################################################
WARNING!
IGNORING THE FOLLOWING TEMPLATE WILL RESULT IN ISSUE CLOSED AS INCOMPLETE
######################################################################
-->
## Checklist
<!--
Carefully read and work throug... | [Epidemic Sound] Add new extractor | ## Please follow the guide below
- You will be asked some questions, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your *pull request* (like that [x])
- Use *Preview* tab to see how your *pull request* will actually look like
---
### Before submitting a *p... | b7fca0fab36c71fee02d6ecf81acbbaa46942be4 | 4a49a2f498bdb1dc9851436f64a519cd96dd4dd8 | diff --git a/youtube_dl/extractor/epidemicsound.py b/youtube_dl/extractor/epidemicsound.py
new file mode 100644
index 00000000000..1a52738aa6e
--- /dev/null
+++ b/youtube_dl/extractor/epidemicsound.py
@@ -0,0 +1,101 @@
+# coding: utf-8
+from __future__ import unicode_literals
+
+from .common import InfoExtractor
+from ... | [
"youtube_dl/extractor/epidemicsound.py",
"youtube_dl/extractor/extractors.py"
] | [
{
"comment": "The returned info_dict must have a valid format URL and by convention also a title.\r\n\r\nGenerally, the data can be type-checked/coerced too.\r\n```suggestion\r\n info = traverse_obj(json_data, {\r\n 'url': ('stems', 'full', 'lqMp3Url', T(url_or_none)),\r\n 'tags': (... | true | |
ytdl-org/youtube-dl | 32,628 | comment_to_fix | [Epidemic Sound] Add new extractor | The returned info_dict must have a valid format URL and by convention also a title.
Generally, the data can be type-checked/coerced too.
```suggestion
info = traverse_obj(json_data, {
'url': ('stems', 'full', 'lqMp3Url', T(url_or_none)),
'tags': ('metadataTags', Ellipis, T(txt_or_... | b7fca0fab36c71fee02d6ecf81acbbaa46942be4 | 4a49a2f498bdb1dc9851436f64a519cd96dd4dd8 | diff --git a/youtube_dl/extractor/epidemicsound.py b/youtube_dl/extractor/epidemicsound.py
new file mode 100644
index 00000000000..1a52738aa6e
--- /dev/null
+++ b/youtube_dl/extractor/epidemicsound.py
@@ -0,0 +1,101 @@
+# coding: utf-8
+from __future__ import unicode_literals
+
+from .common import InfoExtractor
+from ... | [
"youtube_dl/extractor/epidemicsound.py"
] | [
{
"comment": "The returned info_dict must have a valid format URL and by convention also a title.\r\n\r\nGenerally, the data can be type-checked/coerced too.\r\n```suggestion\r\n info = traverse_obj(json_data, {\r\n 'url': ('stems', 'full', 'lqMp3Url', T(url_or_none)),\r\n 'tags': (... | true | ||
ytdl-org/youtube-dl | 32,628 | comment_to_fix | [Epidemic Sound] Add new extractor | To match the other suggestion:
```suggestion
from ..utils import (
ExtractorError,
float_or_none,
txt_or_none,
unified_timestamp,
url_or_none,
) | b7fca0fab36c71fee02d6ecf81acbbaa46942be4 | 4a49a2f498bdb1dc9851436f64a519cd96dd4dd8 | diff --git a/youtube_dl/extractor/epidemicsound.py b/youtube_dl/extractor/epidemicsound.py
new file mode 100644
index 00000000000..1a52738aa6e
--- /dev/null
+++ b/youtube_dl/extractor/epidemicsound.py
@@ -0,0 +1,101 @@
+# coding: utf-8
+from __future__ import unicode_literals
+
+from .common import InfoExtractor
+from ... | [
"youtube_dl/extractor/epidemicsound.py"
] | [
{
"comment": "To match the other suggestion:\r\n```suggestion\r\nfrom ..utils import (\r\n ExtractorError,\r\n float_or_none,\r\n txt_or_none,\r\n unified_timestamp,\r\n url_or_none,\r\n)",
"path": "youtube_dl/extractor/epidemicsound.py",
"hunk": "@@ -0,0 +1,37 @@\n+# coding: utf-8\n+from... | true | ||
ytdl-org/youtube-dl | 32,628 | comment_to_fix | [Epidemic Sound] Add new extractor | ```suggestion
},
}, {
'url': 'https://www.epidemicsound.com/track/mj8GTTwsZd/',
'md5': 'c82b745890f9baf18dc2f8d568ee3830',
'info_dict': {
'id': 'mj8GTTwsZd',
'ext': 'mp3',
'tags': ['liquid drum n bass', 'energetic'],
'title': '... | b7fca0fab36c71fee02d6ecf81acbbaa46942be4 | 4a49a2f498bdb1dc9851436f64a519cd96dd4dd8 | diff --git a/youtube_dl/extractor/epidemicsound.py b/youtube_dl/extractor/epidemicsound.py
new file mode 100644
index 00000000000..1a52738aa6e
--- /dev/null
+++ b/youtube_dl/extractor/epidemicsound.py
@@ -0,0 +1,101 @@
+# coding: utf-8
+from __future__ import unicode_literals
+
+from .common import InfoExtractor
+from ... | [
"youtube_dl/extractor/epidemicsound.py"
] | [
{
"comment": "```suggestion\r\n },\r\n }, {\r\n 'url': 'https://www.epidemicsound.com/track/mj8GTTwsZd/',\r\n 'md5': 'c82b745890f9baf18dc2f8d568ee3830',\r\n 'info_dict': {\r\n 'id': 'mj8GTTwsZd',\r\n 'ext': 'mp3',\r\n 'tags': ['liquid drum n bass',... | true | ||
ytdl-org/youtube-dl | 32,628 | comment_to_fix | [Epidemic Sound] Add new extractor | For the additional metadata:
```suggestion
'thumbnail': (('imageUrl', 'cover'), T(url_or_none)),
'age_limit': ('isExplicit', T(lambda b: 18 if b else None)),
'release_timestamp': ('releaseDate', T(unified_timestamp)),
}, get_all=False)
```
`parse_iso8601()` could be us... | b7fca0fab36c71fee02d6ecf81acbbaa46942be4 | 4a49a2f498bdb1dc9851436f64a519cd96dd4dd8 | diff --git a/youtube_dl/extractor/epidemicsound.py b/youtube_dl/extractor/epidemicsound.py
new file mode 100644
index 00000000000..1a52738aa6e
--- /dev/null
+++ b/youtube_dl/extractor/epidemicsound.py
@@ -0,0 +1,101 @@
+# coding: utf-8
+from __future__ import unicode_literals
+
+from .common import InfoExtractor
+from ... | [
"youtube_dl/extractor/epidemicsound.py"
] | [
{
"comment": "For the additional metadata:\r\n```suggestion\r\n 'thumbnail': (('imageUrl', 'cover'), T(url_or_none)),\r\n 'age_limit': ('isExplicit', T(lambda b: 18 if b else None)),\r\n 'release_timestamp': ('releaseDate', T(unified_timestamp)),\r\n }, get_all=False)\r\n... | true | ||
ytdl-org/youtube-dl | 32,628 | comment_to_fix | [Epidemic Sound] Add new extractor | ```suggestion
'id': ('id', T(txt_or_none)),
'tags': ('metadataTags', Ellipsis, T(txt_or_none)),
``` | b7fca0fab36c71fee02d6ecf81acbbaa46942be4 | 4a49a2f498bdb1dc9851436f64a519cd96dd4dd8 | diff --git a/youtube_dl/extractor/epidemicsound.py b/youtube_dl/extractor/epidemicsound.py
new file mode 100644
index 00000000000..1a52738aa6e
--- /dev/null
+++ b/youtube_dl/extractor/epidemicsound.py
@@ -0,0 +1,101 @@
+# coding: utf-8
+from __future__ import unicode_literals
+
+from .common import InfoExtractor
+from ... | [
"youtube_dl/extractor/epidemicsound.py"
] | [
{
"comment": "```suggestion\r\n 'id': ('id', T(txt_or_none)),\r\n 'tags': ('metadataTags', Ellipsis, T(txt_or_none)),\r\n```",
"path": "youtube_dl/extractor/epidemicsound.py",
"hunk": "@@ -0,0 +1,85 @@\n+# coding: utf-8\n+from __future__ import unicode_literals\n+\n+from .common im... | true | ||
ytdl-org/youtube-dl | 32,628 | comment_to_fix | [Epidemic Sound] Add new extractor | The test harness only compares the first 10kB of the downloaded file, which happens to be less than the MP3 header shared by all formats! So we can't judge from this whether `full` or some other format was fetched. And changing the tested length would invalidate the maybe 30% or so of existing tests with MD5 checks th... | b7fca0fab36c71fee02d6ecf81acbbaa46942be4 | 4a49a2f498bdb1dc9851436f64a519cd96dd4dd8 | diff --git a/youtube_dl/extractor/epidemicsound.py b/youtube_dl/extractor/epidemicsound.py
new file mode 100644
index 00000000000..1a52738aa6e
--- /dev/null
+++ b/youtube_dl/extractor/epidemicsound.py
@@ -0,0 +1,101 @@
+# coding: utf-8
+from __future__ import unicode_literals
+
+from .common import InfoExtractor
+from ... | [
"youtube_dl/extractor/epidemicsound.py"
] | [
{
"comment": "The test harness only compares the first 10kB of the downloaded file, which happens to be less than the MP3 header shared by all formats! So we can't judge from this whether `full` or some other format was fetched. And changing the tested length would invalidate the maybe 30% or so of existing tes... | true | ||
ytdl-org/youtube-dl | 32,628 | comment_to_fix | [Epidemic Sound] Add new extractor | As the format extraction traverses `json_data` it could be combined with the metadata extraction at l.69. However it's better to get the formats first. An auxiliary function forces each returned format to have the required structure, so avoiding a subsequent pass. They send this `s3TrackId`, so we could report it. Sinc... | b7fca0fab36c71fee02d6ecf81acbbaa46942be4 | 4a49a2f498bdb1dc9851436f64a519cd96dd4dd8 | diff --git a/youtube_dl/extractor/epidemicsound.py b/youtube_dl/extractor/epidemicsound.py
new file mode 100644
index 00000000000..1a52738aa6e
--- /dev/null
+++ b/youtube_dl/extractor/epidemicsound.py
@@ -0,0 +1,101 @@
+# coding: utf-8
+from __future__ import unicode_literals
+
+from .common import InfoExtractor
+from ... | [
"youtube_dl/extractor/epidemicsound.py"
] | [
{
"comment": "As the format extraction traverses `json_data` it could be combined with the metadata extraction at l.69. However it's better to get the formats first. An auxiliary function forces each returned format to have the required structure, so avoiding a subsequent pass. They send this `s3TrackId`, so we... | true | ||
ytdl-org/youtube-dl | 32,628 | comment_to_fix | [Epidemic Sound] Add new extractor | Also if getting the additional metadata:
```suggestion
info.update(traverse_obj(json_data, {
'categories': ('genres', Ellipsis, 'tag', T(txt_or_none)),
'tags': ('metadataTags', Ellipsis, T(txt_or_none)),
}))
info.update({
'display_id': video_id,
... | b7fca0fab36c71fee02d6ecf81acbbaa46942be4 | 4a49a2f498bdb1dc9851436f64a519cd96dd4dd8 | diff --git a/youtube_dl/extractor/epidemicsound.py b/youtube_dl/extractor/epidemicsound.py
new file mode 100644
index 00000000000..1a52738aa6e
--- /dev/null
+++ b/youtube_dl/extractor/epidemicsound.py
@@ -0,0 +1,101 @@
+# coding: utf-8
+from __future__ import unicode_literals
+
+from .common import InfoExtractor
+from ... | [
"youtube_dl/extractor/epidemicsound.py"
] | [
{
"comment": "Also if getting the additional metadata:\r\n```suggestion\r\n info.update(traverse_obj(json_data, {\r\n 'categories': ('genres', Ellipsis, 'tag', T(txt_or_none)),\r\n 'tags': ('metadataTags', Ellipsis, T(txt_or_none)),\r\n }))\r\n\r\n info.update({\r\n ... | true | ||
ytdl-org/youtube-dl | 32,628 | comment_to_fix | [Epidemic Sound] Add new extractor | We can't rely on the MD5, so check the `format`:
```suggestion
'upload_date': '20230911',
'format': 'full',
``` | b7fca0fab36c71fee02d6ecf81acbbaa46942be4 | 4a49a2f498bdb1dc9851436f64a519cd96dd4dd8 | diff --git a/youtube_dl/extractor/epidemicsound.py b/youtube_dl/extractor/epidemicsound.py
new file mode 100644
index 00000000000..1a52738aa6e
--- /dev/null
+++ b/youtube_dl/extractor/epidemicsound.py
@@ -0,0 +1,101 @@
+# coding: utf-8
+from __future__ import unicode_literals
+
+from .common import InfoExtractor
+from ... | [
"youtube_dl/extractor/epidemicsound.py"
] | [
{
"comment": "We can't rely on the MD5, so check the `format`:\r\n```suggestion\r\n 'upload_date': '20230911',\r\n 'format': 'full',\r\n```",
"path": "youtube_dl/extractor/epidemicsound.py",
"hunk": "@@ -0,0 +1,85 @@\n+# coding: utf-8\n+from __future__ import unicode_literals\n+\n+... | true | ||
ytdl-org/youtube-dl | 32,628 | comment_to_fix | [Epidemic Sound] Add new extractor | Sort the imports (case-insensitive, an implicit convention):
```suggestion
T,
traverse_obj,
txt_or_none,
unified_timestamp,
url_or_none,
``` | b7fca0fab36c71fee02d6ecf81acbbaa46942be4 | 4a49a2f498bdb1dc9851436f64a519cd96dd4dd8 | diff --git a/youtube_dl/extractor/epidemicsound.py b/youtube_dl/extractor/epidemicsound.py
new file mode 100644
index 00000000000..1a52738aa6e
--- /dev/null
+++ b/youtube_dl/extractor/epidemicsound.py
@@ -0,0 +1,101 @@
+# coding: utf-8
+from __future__ import unicode_literals
+
+from .common import InfoExtractor
+from ... | [
"youtube_dl/extractor/epidemicsound.py"
] | [
{
"comment": "Sort the imports (case-insensitive, an implicit convention):\r\n```suggestion\r\n T,\r\n traverse_obj,\r\n txt_or_none,\r\n unified_timestamp,\r\n url_or_none,\r\n```",
"path": "youtube_dl/extractor/epidemicsound.py",
"hunk": "@@ -0,0 +1,96 @@\n+# coding: utf-8\n+from __futu... | true | ||
ytdl-org/youtube-dl | 32,628 | comment_to_fix | [Epidemic Sound] Add new extractor | Document the issue that I mentioned since it's unusual to match `format`:
```suggestion
# check that the "best" format was found, since test file MD5 doesn't
# distinguish the formats
'format': 'full',
``` | b7fca0fab36c71fee02d6ecf81acbbaa46942be4 | 4a49a2f498bdb1dc9851436f64a519cd96dd4dd8 | diff --git a/youtube_dl/extractor/epidemicsound.py b/youtube_dl/extractor/epidemicsound.py
new file mode 100644
index 00000000000..1a52738aa6e
--- /dev/null
+++ b/youtube_dl/extractor/epidemicsound.py
@@ -0,0 +1,101 @@
+# coding: utf-8
+from __future__ import unicode_literals
+
+from .common import InfoExtractor
+from ... | [
"youtube_dl/extractor/epidemicsound.py"
] | [
{
"comment": "Document the issue that I mentioned since it's unusual to match `format`:\r\n```suggestion\r\n # check that the \"best\" format was found, since test file MD5 doesn't\r\n # distinguish the formats\r\n 'format': 'full',\r\n```",
"path": "youtube_dl/extractor... | true | ||
ytdl-org/youtube-dl | 32,612 | issue_to_patch | Imgur albums fail to find metadata
## Checklist
- [x] I'm reporting a broken site support
- [x] I've verified that I'm running youtube-dl version **2020.05.08**
- [x] I've checked that all provided URLs are alive and playable in a browser
- [x] I've checked that all URLs and arguments with special characters are p... | [Imgur] Overhaul extractor module | <details><summary>Boilerplate: own code, bug fix+improvement</summary>
## Please follow the guide below
- You will be asked some questions, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your *pull request* (like that [x])
- Use *Preview* tab to see how your *pu... | b7fca0fab36c71fee02d6ecf81acbbaa46942be4 | 2ef163b40d163e3d1f2a1ae97bbca5821e1e2529 | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 7fb8f9f8394..f00fd0c6bb8 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -121,6 +121,12 @@ jobs:
ytdl-test-set: ${{ contains(needs.select.outputs.test-set, 'download') && 'download' || 'nodownload' }}
r... | [
".github/workflows/ci.yml",
"youtube_dl/extractor/imgur.py"
] | [] | true | |
ytdl-org/youtube-dl | 32,649 | issue_to_patch | [CI/cleanup/restrict_strip_Marks] | <details>
<summary>Boilerplate: own code/#36238, bug fix/improvement</summary>
## Please follow the guide below
- You will be asked some questions, please read them **carefully** and answer honestly
- Put an `x` into all the boxes [ ] relevant to your *pull request* (like that [x])
- Use *Preview* tab to see how... | b7fca0fab36c71fee02d6ecf81acbbaa46942be4 | 9296c1433683475d304c056bef5e7ccab8fda4ea | diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
index 7fb8f9f8394..93562afd782 100644
--- a/.github/workflows/ci.yml
+++ b/.github/workflows/ci.yml
@@ -6,9 +6,13 @@ env:
pypy-versions: pypy-2.7, pypy-3.6, pypy-3.7
cpython-versions: main
test-set: core
+ # Python beta version to be built using... | [
".github/workflows/ci.yml",
"youtube_dl/extractor/youtube.py",
"youtube_dl/utils.py"
] | [] | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.