repo stringlengths 5 53 | pr_number int32 1 321k | task_type stringclasses 2
values | issue_text stringlengths 0 81.2k | pr_title stringlengths 1 319 | pr_body stringlengths 0 105k | base_sha stringlengths 40 40 | head_sha stringlengths 40 40 | gold_diff stringlengths 0 202M | changed_files listlengths 0 100 | review_threads listlengths 0 100 | test_patch stringlengths 0 23.4M | merged bool 1
class |
|---|---|---|---|---|---|---|---|---|---|---|---|---|
zen-browser/desktop | 14,077 | comment_to_fix | gh-13747: Fixed space icons overflow being inaccessible | What does this change exactly? | 11a977e5334393e4f77dce6b732821cb92ff5275 | c7f5634bd1c899b65209d06db4deefab0b8f2de5 | diff --git a/src/zen/spaces/zen-workspaces.css b/src/zen/spaces/zen-workspaces.css
index d9fa560af46..f5d7e91a9f9 100644
--- a/src/zen/spaces/zen-workspaces.css
+++ b/src/zen/spaces/zen-workspaces.css
@@ -20,7 +20,6 @@
display: none !important;
}
- border-radius: var(--button-border-radius) !important;
ba... | [
"src/zen/spaces/zen-workspaces.css"
] | [
{
"comment": "What does this change exactly?",
"path": "src/zen/spaces/zen-workspaces.css",
"hunk": "@@ -41,6 +41,7 @@\n fill-opacity: 0.6;\n -moz-context-properties: fill-opacity, fill;\n fill: currentColor;\n+ scroll-margin: 0 20px;",
"resolving_sha": "c7f5634bd1c899b65209d06db4deef... | true | ||
zen-browser/desktop | 14,077 | comment_to_fix | gh-13747: Fixed space icons overflow being inaccessible | `mouseover` bubbles and can fire repeatedly while moving between descendants inside the same toolbarbutton (e.g., icon/label), which will restart the smooth `scrollIntoView` animation and can make scrolling feel jittery. Use `relatedTarget` (or tracked state) to only call `scrollIntoView` when entering a *different* wo... | 11a977e5334393e4f77dce6b732821cb92ff5275 | c7f5634bd1c899b65209d06db4deefab0b8f2de5 | diff --git a/src/zen/spaces/ZenSpaceIcons.mjs b/src/zen/spaces/ZenSpaceIcons.mjs
index a15bcc083eb..b8bfb67440e 100644
--- a/src/zen/spaces/ZenSpaceIcons.mjs
+++ b/src/zen/spaces/ZenSpaceIcons.mjs
@@ -15,12 +15,12 @@ class nsZenWorkspaceIcons extends MozXULElement {
this.initDragAndDrop();
this.addEventList... | [
"src/zen/spaces/ZenSpaceIcons.mjs"
] | [
{
"comment": "`mouseover` bubbles and can fire repeatedly while moving between descendants inside the same toolbarbutton (e.g., icon/label), which will restart the smooth `scrollIntoView` animation and can make scrolling feel jittery. Use `relatedTarget` (or tracked state) to only call `scrollIntoView` when ent... | true | ||
zen-browser/desktop | 14,077 | comment_to_fix | gh-13747: Fixed space icons overflow being inaccessible | `scrollIntoView` defaults `block` to "start"; setting `block: "nearest"` avoids unexpected vertical scrolling if this component is ever placed inside a vertically scrollable container (e.g., customization UI). | 11a977e5334393e4f77dce6b732821cb92ff5275 | c7f5634bd1c899b65209d06db4deefab0b8f2de5 | diff --git a/src/zen/spaces/ZenSpaceIcons.mjs b/src/zen/spaces/ZenSpaceIcons.mjs
index a15bcc083eb..b8bfb67440e 100644
--- a/src/zen/spaces/ZenSpaceIcons.mjs
+++ b/src/zen/spaces/ZenSpaceIcons.mjs
@@ -15,12 +15,12 @@ class nsZenWorkspaceIcons extends MozXULElement {
this.initDragAndDrop();
this.addEventList... | [
"src/zen/spaces/ZenSpaceIcons.mjs"
] | [
{
"comment": "`scrollIntoView` defaults `block` to \"start\"; setting `block: \"nearest\"` avoids unexpected vertical scrolling if this component is ever placed inside a vertically scrollable container (e.g., customization UI).",
"path": "src/zen/spaces/ZenSpaceIcons.mjs",
"hunk": "@@ -178,7 +178,7 @@ c... | true | ||
zen-browser/desktop | 14,089 | issue_to_patch | no-bug: Sync upstream Firefox to version `151.0.4` | This PR syncs the upstream Firefox to version 151.0.4.
* ✅ All patches applied cleanly.
@mr-cheffy please review and merge this PR. | acc5837c138a131ebc5d062f06534c932900df90 | 442ea54faca95640e44dd1292201a9f13f3b914d | diff --git a/README.md b/README.md
index f2655b75a6f..af0a6a3ca23 100644
--- a/README.md
+++ b/README.md
@@ -34,8 +34,8 @@ Zen is a firefox-based browser with the aim of pushing your productivity to a ne
### Firefox Versions
-- [`Release`](https://zen-browser.app/download) - Is currently built using Firefox versio... | [
"README.md",
"build/firefox-cache/l10n-last-commit-hash",
"src/zen/tests/manifest.toml",
"src/zen/tests/mochitests/moz.build",
"src/zen/tests/mochitests/sandbox/browser.toml",
"src/zen/tests/mochitests/sandbox/browser_bug1393259.js",
"src/zen/tests/mochitests/sandbox/browser_bug1717599_XDG-CONFIG-DIRS.t... | [
{
"comment": "This change removes the `[sandbox]` external-test import mapping entirely, which means Zen will no longer pull in any upstream sandbox tests. If this is intentional (upstream removal/deprecation), consider documenting the rationale (here or in the PR description); otherwise, the mapping likely nee... | diff --git a/src/zen/tests/manifest.toml b/src/zen/tests/manifest.toml
index fa3d7c84ff1..c3f44415712 100644
--- a/src/zen/tests/manifest.toml
+++ b/src/zen/tests/manifest.toml
@@ -17,16 +17,6 @@ disable = [
source = "browser/components/safebrowsing/content/test"
is_direct_path = true
-[sandbox]
-source = "security... | true | |
zen-browser/desktop | 14,089 | comment_to_fix | no-bug: Sync upstream Firefox to version `151.0.4` | This change removes the `[sandbox]` external-test import mapping entirely, which means Zen will no longer pull in any upstream sandbox tests. If this is intentional (upstream removal/deprecation), consider documenting the rationale (here or in the PR description); otherwise, the mapping likely needs to be updated to th... | acc5837c138a131ebc5d062f06534c932900df90 | 442ea54faca95640e44dd1292201a9f13f3b914d | diff --git a/src/zen/tests/manifest.toml b/src/zen/tests/manifest.toml
index fa3d7c84ff1..c3f44415712 100644
--- a/src/zen/tests/manifest.toml
+++ b/src/zen/tests/manifest.toml
@@ -17,16 +17,6 @@ disable = [
source = "browser/components/safebrowsing/content/test"
is_direct_path = true
-[sandbox]
-source = "security... | [
"src/zen/tests/manifest.toml"
] | [
{
"comment": "This change removes the `[sandbox]` external-test import mapping entirely, which means Zen will no longer pull in any upstream sandbox tests. If this is intentional (upstream removal/deprecation), consider documenting the rationale (here or in the PR description); otherwise, the mapping likely nee... | true | ||
zen-browser/desktop | 14,089 | comment_to_fix | no-bug: Sync upstream Firefox to version `151.0.4` | The sandbox mochitest suite is being dropped (the sandbox manifest entry is removed here and the entire `src/zen/tests/mochitests/sandbox/` directory is deleted). This is a substantial reduction in test coverage and isn’t mentioned in the PR description; please confirm it’s intentional as part of the upstream sync (e.g... | acc5837c138a131ebc5d062f06534c932900df90 | 442ea54faca95640e44dd1292201a9f13f3b914d | diff --git a/src/zen/tests/mochitests/moz.build b/src/zen/tests/mochitests/moz.build
index 9aed50afd40..bbf85269c1e 100644
--- a/src/zen/tests/mochitests/moz.build
+++ b/src/zen/tests/mochitests/moz.build
@@ -10,7 +10,6 @@
BROWSER_CHROME_MANIFESTS += [
"readermode/browser.toml",
"safebrowsing/browser.toml",
- "san... | [
"src/zen/tests/mochitests/moz.build"
] | [
{
"comment": "The sandbox mochitest suite is being dropped (the sandbox manifest entry is removed here and the entire `src/zen/tests/mochitests/sandbox/` directory is deleted). This is a substantial reduction in test coverage and isn’t mentioned in the PR description; please confirm it’s intentional as part of ... | true | ||
zen-browser/desktop | 14,088 | issue_to_patch | [META]: Space routing | gh-14044: Fix Space-Routing CSS, Filter Out Empty Routes | 6bde408c799edd6189d1676f0311bf61f5f422ce | 5a09d0c1980daa6e6897b7e1ed590466cbdd4f3a | diff --git a/src/zen/common/sys/ui/ZenSpaceRoutingNavigation.sys.mjs b/src/zen/common/sys/ui/ZenSpaceRoutingNavigation.sys.mjs
index fcf85bb1968..ce0fef43752 100644
--- a/src/zen/common/sys/ui/ZenSpaceRoutingNavigation.sys.mjs
+++ b/src/zen/common/sys/ui/ZenSpaceRoutingNavigation.sys.mjs
@@ -29,7 +29,8 @@ export class ... | [
"src/zen/common/sys/ui/ZenSpaceRoutingNavigation.sys.mjs",
"src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs",
"src/zen/space-routing/zen-space-routing.css"
] | [
{
"comment": "`saveRoutes()` now assumes every entry in `this.#file.data.routes` has a string `reference`. If a user has a corrupted/legacy routes file where a route is missing `reference` (or is non-object), `route.reference.trim()` will throw and prevent saving/closing the dialog. This should be hardened to m... | true | ||
zen-browser/desktop | 14,088 | comment_to_fix | gh-14044: Fix Space-Routing CSS, Filter Out Empty Routes | `saveRoutes()` now assumes every entry in `this.#file.data.routes` has a string `reference`. If a user has a corrupted/legacy routes file where a route is missing `reference` (or is non-object), `route.reference.trim()` will throw and prevent saving/closing the dialog. This should be hardened to match the defensive che... | 6bde408c799edd6189d1676f0311bf61f5f422ce | 5a09d0c1980daa6e6897b7e1ed590466cbdd4f3a | diff --git a/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs
index e9cf24438eb..8454fb48887 100644
--- a/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs
+++ b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs
@@ -389,9 +389,14 @@ class nsZenSpaceRoutin... | [
"src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs"
] | [
{
"comment": "`saveRoutes()` now assumes every entry in `this.#file.data.routes` has a string `reference`. If a user has a corrupted/legacy routes file where a route is missing `reference` (or is non-object), `route.reference.trim()` will throw and prevent saving/closing the dialog. This should be hardened to m... | true | ||
zen-browser/desktop | 14,088 | comment_to_fix | gh-14044: Fix Space-Routing CSS, Filter Out Empty Routes | This PR changes persistence semantics by stripping empty/whitespace-only routes before saving, but there’s no automated test asserting that behavior. Given the existing `src/zen/tests/space_routing/*` coverage for the routing manager/dialog, adding a test that verifies an empty route is removed on `saveRoutes()` would ... | 6bde408c799edd6189d1676f0311bf61f5f422ce | 5a09d0c1980daa6e6897b7e1ed590466cbdd4f3a | diff --git a/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs
index e9cf24438eb..8454fb48887 100644
--- a/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs
+++ b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs
@@ -389,9 +389,14 @@ class nsZenSpaceRoutin... | [
"src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs"
] | [
{
"comment": "This PR changes persistence semantics by stripping empty/whitespace-only routes before saving, but there’s no automated test asserting that behavior. Given the existing `src/zen/tests/space_routing/*` coverage for the routing manager/dialog, adding a test that verifies an empty route is removed on... | true | ||
zen-browser/desktop | 14,072 | issue_to_patch | Settings search bar stops accepting keyboard input after cancelling a conflicting shortcut assignment with Escape.
### Preliminary Checks
- [x] I have read and understood the important section above.
- [x] I have searched existing issues and avoided creating duplicates.
- [x] I am not filing an enhancement request.
-... | gh-14070: clear shortcut editing state on blur | ## Summary
Fixes keyboard input being swallowed after cancelling a conflicting shortcut assignment with Escape.
When leaving a shortcut input, the visual editing state was removed, but the internal `_currentActionID` state could remain set. This meant later keyboard events, such as typing in the Settings search b... | 7844e04df225117be243fa3f0eb5840fd89981da | d83572ac6b33dca2795a654dd5cc5ec9179f126f | diff --git a/src/browser/components/preferences/zen-settings.js b/src/browser/components/preferences/zen-settings.js
index 288b342d63e..c048ecffaf7 100644
--- a/src/browser/components/preferences/zen-settings.js
+++ b/src/browser/components/preferences/zen-settings.js
@@ -945,6 +945,7 @@ var gZenCKSSettings = {
... | [
"src/browser/components/preferences/zen-settings.js"
] | [
{
"comment": "In the Tab-cancel path, `_latestModifier` and `_hasSafed` are left as-is. If the user has already typed a combo (setting `_hasSafed = false` and `_latestModifier`), then presses Tab, the editor state is cleared but subsequent blur will still be treated as “unsaved”, and `_latestModifier` can leak ... | true | |
zen-browser/desktop | 14,072 | comment_to_fix | gh-14070: clear shortcut editing state on blur | In the Tab-cancel path, `_latestModifier` and `_hasSafed` are left as-is. If the user has already typed a combo (setting `_hasSafed = false` and `_latestModifier`), then presses Tab, the editor state is cleared but subsequent blur will still be treated as “unsaved”, and `_latestModifier` can leak into later Escape/conf... | 7844e04df225117be243fa3f0eb5840fd89981da | d83572ac6b33dca2795a654dd5cc5ec9179f126f | diff --git a/src/browser/components/preferences/zen-settings.js b/src/browser/components/preferences/zen-settings.js
index 288b342d63e..c048ecffaf7 100644
--- a/src/browser/components/preferences/zen-settings.js
+++ b/src/browser/components/preferences/zen-settings.js
@@ -945,6 +945,7 @@ var gZenCKSSettings = {
... | [
"src/browser/components/preferences/zen-settings.js"
] | [
{
"comment": "In the Tab-cancel path, `_latestModifier` and `_hasSafed` are left as-is. If the user has already typed a combo (setting `_hasSafed = false` and `_latestModifier`), then presses Tab, the editor state is cleared but subsequent blur will still be treated as “unsaved”, and `_latestModifier` can leak ... | true | ||
zen-browser/desktop | 14,048 | issue_to_patch | Glance closes pinned tab if no other tabs open
### Preliminary Checks
- [x] I have read and understood the important section above.
- [x] I have searched existing issues and avoided creating duplicates.
- [x] I am not filing an enhancement request.
- [x] I have checked that this issue cannot be reproduced on Mozilla ... | gh-14049: Fix restore to pinned tab from glance | This happens when there are only pinned tabs open | 5db8780f5d730b94fa83048840e1c5538621aa6c | 9da0f4595dab54066b24e1e20e5f5e2d98bf8f5f | diff --git a/src/zen/spaces/ZenSpaceManager.mjs b/src/zen/spaces/ZenSpaceManager.mjs
index 43dcb6dda6a..caeee405fc0 100644
--- a/src/zen/spaces/ZenSpaceManager.mjs
+++ b/src/zen/spaces/ZenSpaceManager.mjs
@@ -1010,6 +1010,14 @@ class nsZenWorkspaces {
return null;
}
+ // Closing a glance tab tears down... | [
"src/zen/spaces/ZenSpaceManager.mjs",
"src/zen/tests/glance/browser.toml",
"src/zen/tests/glance/browser_issue_14049.js"
] | [
{
"comment": "Are these not getting cleaned up? ",
"path": "src/zen/tests/glance/browser_glance_close_pinned.js",
"hunk": "@@ -0,0 +1,75 @@\n+/* Any copyright is dedicated to the Public Domain.\n+ https://creativecommons.org/publicdomain/zero/1.0/ */\n+\n+\"use strict\";\n+\n+// Regression test: closi... | diff --git a/src/zen/tests/glance/browser.toml b/src/zen/tests/glance/browser.toml
index 4e27371a221..9fcf639cb81 100644
--- a/src/zen/tests/glance/browser.toml
+++ b/src/zen/tests/glance/browser.toml
@@ -20,3 +20,5 @@ support-files = [
["browser_glance_prev_tab.js"]
["browser_glance_select_parent.js"]
+
+["browser... | true |
zen-browser/desktop | 14,048 | comment_to_fix | gh-14049: Fix restore to pinned tab from glance | The guard meant to skip last-unpinned-tab handling when closing a *glance child* currently checks `glance-id`, which is also set on the parent tab. That makes `handleTabBeforeClose` bail out for parent-tab closes while a glance is open as well, which is broader than the comment describes and could change close/selectio... | 5db8780f5d730b94fa83048840e1c5538621aa6c | 9da0f4595dab54066b24e1e20e5f5e2d98bf8f5f | diff --git a/src/zen/spaces/ZenSpaceManager.mjs b/src/zen/spaces/ZenSpaceManager.mjs
index 43dcb6dda6a..caeee405fc0 100644
--- a/src/zen/spaces/ZenSpaceManager.mjs
+++ b/src/zen/spaces/ZenSpaceManager.mjs
@@ -1010,6 +1010,14 @@ class nsZenWorkspaces {
return null;
}
+ // Closing a glance tab tears down... | [
"src/zen/spaces/ZenSpaceManager.mjs"
] | [
{
"comment": "The guard meant to skip last-unpinned-tab handling when closing a *glance child* currently checks `glance-id`, which is also set on the parent tab. That makes `handleTabBeforeClose` bail out for parent-tab closes while a glance is open as well, which is broader than the comment describes and could... | true | ||
zen-browser/desktop | 14,069 | issue_to_patch | [META]: Space routing | gh-14044: Finish implementation for space routing | 965bb9391da5ca543b9ab79125c7bbab8f645e7a | 3692a5047f9fcc46b6051d738be3587c15e82747 | diff --git a/prefs/firefox/browser.yaml b/prefs/firefox/browser.yaml
index 341577cac76..4545795c628 100644
--- a/prefs/firefox/browser.yaml
+++ b/prefs/firefox/browser.yaml
@@ -94,3 +94,8 @@
# See gh-12985 for details on the following preferences
- name: browser.search.widget.new
value: true
+
+# Disabled from htt... | [
"prefs/firefox/browser.yaml",
"src/browser/components/tabbrowser/content/tabbrowser-js.patch",
"src/zen/common/modules/ZenStartup.mjs",
"src/zen/common/moz.build",
"src/zen/common/sys/ui/ZenSpaceRoutingNavigation.sys.mjs",
"src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs",
"src/zen/spaces/ZenGradie... | [
{
"comment": "## Unused variable, import, function or class\n\nUnused function makeFakeWindow.\n\n---\n\n<p>Remove the unused <code>makeFakeWindow</code> helper function from <code>src/zen/tests/space_routing/head.js</code>.</p>\n<p>Best fix without changing functionality:</p>\n<ul>\n<li>Delete the entire <code... | diff --git a/src/zen/tests/space_routing/browser.toml b/src/zen/tests/space_routing/browser.toml
index 27847330051..f81904fa2c4 100644
--- a/src/zen/tests/space_routing/browser.toml
+++ b/src/zen/tests/space_routing/browser.toml
@@ -11,8 +11,12 @@ support-files = [
["browser_space_routing_dialog.js"]
+["browser_sp... | true | |
zen-browser/desktop | 14,069 | comment_to_fix | gh-14044: Finish implementation for space routing | onBeforeTabSelect() can call changeWorkspaceWithID() with a zen-workspace-id that doesn't correspond to any known workspace. In that case changeWorkspace() later dereferences workspace.uuid and throws (caught/logged), which is avoidable noise and can interfere with other logic. Guard on workspaceEnabled and verify the ... | 965bb9391da5ca543b9ab79125c7bbab8f645e7a | 3692a5047f9fcc46b6051d738be3587c15e82747 | diff --git a/src/zen/spaces/ZenSpaceManager.mjs b/src/zen/spaces/ZenSpaceManager.mjs
index b75733b8109..43dcb6dda6a 100644
--- a/src/zen/spaces/ZenSpaceManager.mjs
+++ b/src/zen/spaces/ZenSpaceManager.mjs
@@ -1498,7 +1498,6 @@ class nsZenWorkspaces {
continue;
}
- tab.owner = null;
if (con... | [
"src/zen/spaces/ZenSpaceManager.mjs"
] | [
{
"comment": "onBeforeTabSelect() can call changeWorkspaceWithID() with a zen-workspace-id that doesn't correspond to any known workspace. In that case changeWorkspace() later dereferences workspace.uuid and throws (caught/logged), which is avoidable noise and can interfere with other logic. Guard on workspaceE... | true | ||
zen-browser/desktop | 14,069 | comment_to_fix | gh-14044: Finish implementation for space routing | The added comment line contains a non-breaking space after '#', and the wording/capitalization is a bit inconsistent. Using regular ASCII whitespace avoids hidden-diff churn and potential linting/formatting issues. | 965bb9391da5ca543b9ab79125c7bbab8f645e7a | 3692a5047f9fcc46b6051d738be3587c15e82747 | diff --git a/prefs/firefox/browser.yaml b/prefs/firefox/browser.yaml
index 341577cac76..4545795c628 100644
--- a/prefs/firefox/browser.yaml
+++ b/prefs/firefox/browser.yaml
@@ -94,3 +94,8 @@
# See gh-12985 for details on the following preferences
- name: browser.search.widget.new
value: true
+
+# Disabled from htt... | [
"prefs/firefox/browser.yaml"
] | [
{
"comment": "The added comment line contains a non-breaking space after '#', and the wording/capitalization is a bit inconsistent. Using regular ASCII whitespace avoids hidden-diff churn and potential linting/formatting issues.",
"path": "prefs/firefox/browser.yaml",
"hunk": "@@ -94,3 +94,8 @@\n # See ... | true | ||
zen-browser/desktop | 14,069 | comment_to_fix | gh-14044: Finish implementation for space routing | Shouldn't it be `activeWorkspace` with an e at the end? | 965bb9391da5ca543b9ab79125c7bbab8f645e7a | 3692a5047f9fcc46b6051d738be3587c15e82747 | diff --git a/src/zen/spaces/ZenSpaceManager.mjs b/src/zen/spaces/ZenSpaceManager.mjs
index b75733b8109..43dcb6dda6a 100644
--- a/src/zen/spaces/ZenSpaceManager.mjs
+++ b/src/zen/spaces/ZenSpaceManager.mjs
@@ -1498,7 +1498,6 @@ class nsZenWorkspaces {
continue;
}
- tab.owner = null;
if (con... | [
"src/zen/spaces/ZenSpaceManager.mjs"
] | [
{
"comment": "Shouldn't it be `activeWorkspace` with an e at the end?",
"path": "src/zen/spaces/ZenSpaceManager.mjs",
"hunk": "@@ -2282,6 +2281,18 @@ class nsZenWorkspaces {\n );\n }\n \n+ onBeforeTabSelect(aTab) {\n+ const tabSpace = aTab?.getAttribute(\"zen-workspace-id\");\n+ if (\n+ ... | true | ||
zen-browser/desktop | 14,069 | comment_to_fix | gh-14044: Finish implementation for space routing | `fakeTab()` does not implement `hasAttribute()`, but `gZenWorkspaces.onBeforeTabSelect()` calls `aTab.hasAttribute(...)` when a workspace id is present. This makes the test throw a TypeError instead of asserting behavior. | 965bb9391da5ca543b9ab79125c7bbab8f645e7a | 3692a5047f9fcc46b6051d738be3587c15e82747 | diff --git a/src/zen/tests/spaces/browser_select_tab_switches_space.js b/src/zen/tests/spaces/browser_select_tab_switches_space.js
new file mode 100644
index 00000000000..4fd738f1721
--- /dev/null
+++ b/src/zen/tests/spaces/browser_select_tab_switches_space.js
@@ -0,0 +1,69 @@
+/* Any copyright is dedicated to the Publ... | [
"src/zen/tests/spaces/browser_select_tab_switches_space.js"
] | [
{
"comment": "`fakeTab()` does not implement `hasAttribute()`, but `gZenWorkspaces.onBeforeTabSelect()` calls `aTab.hasAttribute(...)` when a workspace id is present. This makes the test throw a TypeError instead of asserting behavior.",
"path": "src/zen/tests/spaces/browser_select_tab_switches_space.js",
... | true | ||
zen-browser/desktop | 14,069 | comment_to_fix | gh-14044: Finish implementation for space routing | `shouldRedirectNavigation()` is passed `tab.getAttribute("zen-workspace-id")`, which can be `null` when the tab has no workspace id. The JSDoc currently declares `currentWorkspaceId` as `{string}`, which is inaccurate and can mislead callers/maintainers. | 965bb9391da5ca543b9ab79125c7bbab8f645e7a | 3692a5047f9fcc46b6051d738be3587c15e82747 | diff --git a/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs
index b5d07c7a3e8..e9cf24438eb 100644
--- a/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs
+++ b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs
@@ -82,6 +82,40 @@ class nsZenSpaceRoutingM... | [
"src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs"
] | [
{
"comment": "`shouldRedirectNavigation()` is passed `tab.getAttribute(\"zen-workspace-id\")`, which can be `null` when the tab has no workspace id. The JSDoc currently declares `currentWorkspaceId` as `{string}`, which is inaccurate and can mislead callers/maintainers.",
"path": "src/zen/space-routing/ZenS... | true | ||
zen-browser/desktop | 14,069 | comment_to_fix | gh-14044: Finish implementation for space routing | This comment line contains a non-breaking space after `#` ("# Only enabled..."). Non-ASCII whitespace in config files is easy to miss in reviews and can trip some linters/formatters; prefer a normal ASCII space. | 965bb9391da5ca543b9ab79125c7bbab8f645e7a | 3692a5047f9fcc46b6051d738be3587c15e82747 | diff --git a/prefs/firefox/browser.yaml b/prefs/firefox/browser.yaml
index 341577cac76..4545795c628 100644
--- a/prefs/firefox/browser.yaml
+++ b/prefs/firefox/browser.yaml
@@ -94,3 +94,8 @@
# See gh-12985 for details on the following preferences
- name: browser.search.widget.new
value: true
+
+# Disabled from htt... | [
"prefs/firefox/browser.yaml"
] | [
{
"comment": "This comment line contains a non-breaking space after `#` (\"# Only enabled...\"). Non-ASCII whitespace in config files is easy to miss in reviews and can trip some linters/formatters; prefer a normal ASCII space.",
"path": "prefs/firefox/browser.yaml",
"hunk": "@@ -94,3 +94,8 @@\n # See g... | true | ||
zen-browser/desktop | 14,054 | issue_to_patch | [META]: Space routing | gh-14044: Change to use gDialogBox instead of openDialog | e7e4c5a452289a62df45462ec1bc88f8a86760e6 | 42b7713f57011c1a174ba4a8533e25ed99771758 | diff --git a/src/browser/base/content/zen-panels/popups.inc b/src/browser/base/content/zen-panels/popups.inc
index bc9abc04e3a..2ff92383d49 100644
--- a/src/browser/base/content/zen-panels/popups.inc
+++ b/src/browser/base/content/zen-panels/popups.inc
@@ -30,10 +30,11 @@
<menuitem id="context_zenReorderWorkspaces" ... | [
"src/browser/base/content/zen-panels/popups.inc",
"src/zen/boosts/ZenBoostsEditor.mjs",
"src/zen/space-routing/ZenSpaceRoutingDialog.mjs",
"src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs",
"src/zen/space-routing/zen-space-routing.css",
"src/zen/space-routing/zen-space-routing.inc.xhtml"
] | [
{
"comment": "`@namespace xul ...` is declared but no default namespace is set. In a XUL document (`zen-space-routing.inc.xhtml` has `xmlns=\"...xul\"`), unprefixed type selectors like `window`, `menulist`, `button`, `h3`, `p`, etc. will no longer match, so large parts of this stylesheet won’t apply.",
"pat... | true | ||
zen-browser/desktop | 14,054 | comment_to_fix | gh-14044: Change to use gDialogBox instead of openDialog | `@namespace xul ...` is declared but no default namespace is set. In a XUL document (`zen-space-routing.inc.xhtml` has `xmlns="...xul"`), unprefixed type selectors like `window`, `menulist`, `button`, `h3`, `p`, etc. will no longer match, so large parts of this stylesheet won’t apply. | e7e4c5a452289a62df45462ec1bc88f8a86760e6 | 42b7713f57011c1a174ba4a8533e25ed99771758 | diff --git a/src/zen/space-routing/zen-space-routing.css b/src/zen/space-routing/zen-space-routing.css
index 31aea297e67..172263809fc 100644
--- a/src/zen/space-routing/zen-space-routing.css
+++ b/src/zen/space-routing/zen-space-routing.css
@@ -1,17 +1,13 @@
-/*
- * This Source Code Form is subject to the terms of the ... | [
"src/zen/space-routing/zen-space-routing.css"
] | [
{
"comment": "`@namespace xul ...` is declared but no default namespace is set. In a XUL document (`zen-space-routing.inc.xhtml` has `xmlns=\"...xul\"`), unprefixed type selectors like `window`, `menulist`, `button`, `h3`, `p`, etc. will no longer match, so large parts of this stylesheet won’t apply.",
"pat... | true | ||
zen-browser/desktop | 14,054 | comment_to_fix | gh-14044: Change to use gDialogBox instead of openDialog | The route row is hidden (`display: none`) until the next flush/rAF, but `input.focus()` is still called immediately afterwards. Focusing a hidden element may fail, leaving the newly-added route without focus once it becomes visible. | e7e4c5a452289a62df45462ec1bc88f8a86760e6 | 42b7713f57011c1a174ba4a8533e25ed99771758 | diff --git a/src/zen/space-routing/ZenSpaceRoutingDialog.mjs b/src/zen/space-routing/ZenSpaceRoutingDialog.mjs
index 3bdb6324f9f..786a4fc0151 100644
--- a/src/zen/space-routing/ZenSpaceRoutingDialog.mjs
+++ b/src/zen/space-routing/ZenSpaceRoutingDialog.mjs
@@ -196,8 +196,18 @@ export class nsZenSpaceRoutingDialog {
... | [
"src/zen/space-routing/ZenSpaceRoutingDialog.mjs"
] | [
{
"comment": "The route row is hidden (`display: none`) until the next flush/rAF, but `input.focus()` is still called immediately afterwards. Focusing a hidden element may fail, leaving the newly-added route without focus once it becomes visible.",
"path": "src/zen/space-routing/ZenSpaceRoutingDialog.mjs",
... | true | ||
zen-browser/desktop | 14,054 | comment_to_fix | gh-14044: Change to use gDialogBox instead of openDialog | `openSpaceRoutingDialog` no longer returns the opened window (and is now async), but the JSDoc still says it opens a popup window and returns `Window|null`. This is now misleading for callers and for type checking. | e7e4c5a452289a62df45462ec1bc88f8a86760e6 | 42b7713f57011c1a174ba4a8533e25ed99771758 | diff --git a/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs
index 9109e89245a..b5d07c7a3e8 100644
--- a/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs
+++ b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs
@@ -254,16 +254,16 @@ class nsZenSpaceRouti... | [
"src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs"
] | [
{
"comment": "`openSpaceRoutingDialog` no longer returns the opened window (and is now async), but the JSDoc still says it opens a popup window and returns `Window|null`. This is now misleading for callers and for type checking.",
"path": "src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs",
"hunk": "... | true | ||
zen-browser/desktop | 14,054 | comment_to_fix | gh-14044: Change to use gDialogBox instead of openDialog | This switches from `openDialog()` (new top-level window) to `gDialogBox.open()` (in-window dialog in most cases). The existing Space Routing browser tests currently wait for a new window (`BrowserTestUtils.domWindowOpenedAndLoaded` in `src/zen/tests/space_routing/head.js`), which will likely stop working with `gDialogB... | e7e4c5a452289a62df45462ec1bc88f8a86760e6 | 42b7713f57011c1a174ba4a8533e25ed99771758 | diff --git a/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs
index 9109e89245a..b5d07c7a3e8 100644
--- a/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs
+++ b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs
@@ -254,16 +254,16 @@ class nsZenSpaceRouti... | [
"src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs"
] | [
{
"comment": "This switches from `openDialog()` (new top-level window) to `gDialogBox.open()` (in-window dialog in most cases). The existing Space Routing browser tests currently wait for a new window (`BrowserTestUtils.domWindowOpenedAndLoaded` in `src/zen/tests/space_routing/head.js`), which will likely stop ... | true | ||
zen-browser/desktop | 14,054 | comment_to_fix | gh-14044: Change to use gDialogBox instead of openDialog | The JSDoc says this returns a Window (or null), but the updated implementation is `async` and does not return anything (it awaits `gDialogBox.open` and then returns `undefined`). This makes the API contract misleading and also discards any return value from `gDialogBox.open` (if it has one). | e7e4c5a452289a62df45462ec1bc88f8a86760e6 | 42b7713f57011c1a174ba4a8533e25ed99771758 | diff --git a/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs
index 9109e89245a..b5d07c7a3e8 100644
--- a/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs
+++ b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs
@@ -254,16 +254,16 @@ class nsZenSpaceRouti... | [
"src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs"
] | [
{
"comment": "The JSDoc says this returns a Window (or null), but the updated implementation is `async` and does not return anything (it awaits `gDialogBox.open` and then returns `undefined`). This makes the API contract misleading and also discards any return value from `gDialogBox.open` (if it has one).",
... | true | ||
zen-browser/desktop | 14,054 | comment_to_fix | gh-14044: Change to use gDialogBox instead of openDialog | This stylesheet defines `@namespace xul ...` but uses an unprefixed type selector `window`. Elsewhere in the codebase, XUL element selectors are consistently namespaced (e.g. `xul|button` in `src/zen/common/styles/zen-buttons.css:13`), and leaving `window` unprefixed can cause the rule not to match depending on the def... | e7e4c5a452289a62df45462ec1bc88f8a86760e6 | 42b7713f57011c1a174ba4a8533e25ed99771758 | diff --git a/src/zen/space-routing/zen-space-routing.css b/src/zen/space-routing/zen-space-routing.css
index 31aea297e67..172263809fc 100644
--- a/src/zen/space-routing/zen-space-routing.css
+++ b/src/zen/space-routing/zen-space-routing.css
@@ -1,17 +1,13 @@
-/*
- * This Source Code Form is subject to the terms of the ... | [
"src/zen/space-routing/zen-space-routing.css"
] | [
{
"comment": "This stylesheet defines `@namespace xul ...` but uses an unprefixed type selector `window`. Elsewhere in the codebase, XUL element selectors are consistently namespaced (e.g. `xul|button` in `src/zen/common/styles/zen-buttons.css:13`), and leaving `window` unprefixed can cause the rule not to matc... | true | ||
zen-browser/desktop | 13,981 | issue_to_patch | [META]: Space routing | gh-14044: Implement Space Routing (gh-13981) | This PR aims to implement a version of Arc's Air Traffic Control feature natively into Zen.
> [!NOTE]
> This PR is based on #9042
> Thanks for providing the necessary pointers in your PR.
---
### Structure
| Area | File | Purpose |
|---|---|---|
| Core | `src/zen/air-traffic/ZenAirTrafficManager.sys.mjs`... | b1be664f4d82e72bf34da8a0b4ed95e2b81f74ca | 97768c3c7a3d40bdc9eccf5223421d9adf5451d1 | diff --git a/crowdin.yml b/crowdin.yml
index 469c8a1cddb..964f52d44df 100644
--- a/crowdin.yml
+++ b/crowdin.yml
@@ -22,3 +22,5 @@ files:
translation: browser/browser/zen-folders.ftl
- source: en-US/browser/browser/zen-boosts.ftl
translation: browser/browser/zen-boosts.ftl
+ - source: en-US/browser/browse... | [
"crowdin.yml",
"locales/en-US/browser/browser/zen-space-routing.ftl",
"src/browser/base/content/zen-assets.jar.inc.mn",
"src/browser/base/content/zen-commands.inc.xhtml",
"src/browser/base/content/zen-locales.inc.xhtml",
"src/browser/base/content/zen-panels/popups.inc",
"src/browser/components/tabbrowse... | [
{
"comment": "Swap out with Nucleo file later",
"path": "src/browser/themes/shared/zen-icons/nucleo/arrow-corner-down-right.svg",
"hunk": "",
"resolving_sha": "97768c3c7a3d40bdc9eccf5223421d9adf5451d1",
"resolving_diff": "diff --git a/src/browser/themes/shared/zen-icons/nucleo/arrow-corner-down-... | diff --git a/src/zen/tests/moz.build b/src/zen/tests/moz.build
index a79f5a7f42b..fbbf132a87f 100644
--- a/src/zen/tests/moz.build
+++ b/src/zen/tests/moz.build
@@ -13,6 +13,7 @@ BROWSER_CHROME_MANIFESTS += [
"pinned/browser.toml",
"popover/browser.toml",
"site_control/browser.toml",
+ "space_routing/... | true |
zen-browser/desktop | 13,981 | comment_to_fix | gh-14044: Implement Space Routing (gh-13981) | Swap out with Nucleo file later | b1be664f4d82e72bf34da8a0b4ed95e2b81f74ca | 97768c3c7a3d40bdc9eccf5223421d9adf5451d1 | diff --git a/src/browser/themes/shared/zen-icons/nucleo/arrow-corner-down-right.svg b/src/browser/themes/shared/zen-icons/nucleo/arrow-corner-down-right.svg
new file mode 100644
index 00000000000..18b9d18df5a
--- /dev/null
+++ b/src/browser/themes/shared/zen-icons/nucleo/arrow-corner-down-right.svg
@@ -0,0 +1,5 @@
+#fi... | [
"src/browser/themes/shared/zen-icons/nucleo/arrow-corner-down-right.svg"
] | [
{
"comment": "Swap out with Nucleo file later",
"path": "src/browser/themes/shared/zen-icons/nucleo/arrow-corner-down-right.svg",
"hunk": "",
"resolving_sha": "97768c3c7a3d40bdc9eccf5223421d9adf5451d1",
"resolving_diff": "diff --git a/src/browser/themes/shared/zen-icons/nucleo/arrow-corner-down-... | true | ||
zen-browser/desktop | 13,981 | comment_to_fix | gh-14044: Implement Space Routing (gh-13981) | Use a minus icon instead of the close icon | b1be664f4d82e72bf34da8a0b4ed95e2b81f74ca | 97768c3c7a3d40bdc9eccf5223421d9adf5451d1 | diff --git a/src/browser/themes/shared/zen-icons/icons.css b/src/browser/themes/shared/zen-icons/icons.css
index 918a36ec107..513683d2c9e 100644
--- a/src/browser/themes/shared/zen-icons/icons.css
+++ b/src/browser/themes/shared/zen-icons/icons.css
@@ -51,7 +51,8 @@
}
#PanelUI-zen-gradient-generator-color-remove,
-... | [
"src/browser/themes/shared/zen-icons/icons.css"
] | [
{
"comment": "Use a minus icon instead of the close icon",
"path": "src/browser/themes/shared/zen-icons/icons.css",
"hunk": "@@ -40,6 +40,7 @@\n .close-icon,\n .zen-glance-sidebar-close,\n .zen-theme-picker-custom-list-item-remove,\n+.at-remove,",
"resolving_sha": "97768c3c7a3d40bdc9eccf5223421d9adf... | true | ||
zen-browser/desktop | 13,981 | comment_to_fix | gh-14044: Implement Space Routing (gh-13981) | The class `.at-remove` hasn't been updated. I'll take care of that tho | b1be664f4d82e72bf34da8a0b4ed95e2b81f74ca | 97768c3c7a3d40bdc9eccf5223421d9adf5451d1 | diff --git a/src/browser/themes/shared/zen-icons/icons.css b/src/browser/themes/shared/zen-icons/icons.css
index 918a36ec107..513683d2c9e 100644
--- a/src/browser/themes/shared/zen-icons/icons.css
+++ b/src/browser/themes/shared/zen-icons/icons.css
@@ -51,7 +51,8 @@
}
#PanelUI-zen-gradient-generator-color-remove,
-... | [
"src/browser/themes/shared/zen-icons/icons.css"
] | [
{
"comment": "The class `.at-remove` hasn't been updated. I'll take care of that tho",
"path": "src/browser/themes/shared/zen-icons/icons.css",
"hunk": "",
"resolving_sha": "97768c3c7a3d40bdc9eccf5223421d9adf5451d1",
"resolving_diff": "diff --git a/src/browser/themes/shared/zen-icons/icons.css b... | true | ||
zen-browser/desktop | 13,981 | comment_to_fix | gh-14044: Implement Space Routing (gh-13981) | Not needed, ZenSmartRoutingManager is already a lazy global iirc | b1be664f4d82e72bf34da8a0b4ed95e2b81f74ca | 97768c3c7a3d40bdc9eccf5223421d9adf5451d1 | diff --git a/src/zen/common/zen-sets.js b/src/zen/common/zen-sets.js
index 1a1acb72854..289dbe9eb71 100644
--- a/src/zen/common/zen-sets.js
+++ b/src/zen/common/zen-sets.js
@@ -133,6 +133,10 @@ document.addEventListener(
gZenWorkspaces.unloadAllOtherWorkspaces();
break;
}
+ ... | [
"src/zen/common/zen-sets.js"
] | [
{
"comment": "Not needed, ZenSmartRoutingManager is already a lazy global iirc",
"path": "src/zen/common/zen-sets.js",
"hunk": "@@ -133,6 +133,13 @@ document.addEventListener(\n gZenWorkspaces.unloadAllOtherWorkspaces();\n break;\n }\n+ case \"cmd_zenOpenSmartR... | true | ||
zen-browser/desktop | 13,981 | comment_to_fix | gh-14044: Implement Space Routing (gh-13981) | Space Routing is invoked with only `{ skipRoute }`, but the manager uses other options (notably `fromExternal`, `pinned`, and `tabGroup`) to decide whether to skip and how to route. As-is, default routing for external links won’t be applied during `onBeforeAddTab`, and pinned/tab-group tabs may be routed unexpectedly. | b1be664f4d82e72bf34da8a0b4ed95e2b81f74ca | 97768c3c7a3d40bdc9eccf5223421d9adf5451d1 | diff --git a/src/browser/components/tabbrowser/content/tabbrowser-js.patch b/src/browser/components/tabbrowser/content/tabbrowser-js.patch
index 95bf58cee77..ef96e759e45 100644
--- a/src/browser/components/tabbrowser/content/tabbrowser-js.patch
+++ b/src/browser/components/tabbrowser/content/tabbrowser-js.patch
@@ -1,5... | [
"src/browser/components/tabbrowser/content/tabbrowser-js.patch"
] | [
{
"comment": "Space Routing is invoked with only `{ skipRoute }`, but the manager uses other options (notably `fromExternal`, `pinned`, and `tabGroup`) to decide whether to skip and how to route. As-is, default routing for external links won’t be applied during `onBeforeAddTab`, and pinned/tab-group tabs may be... | true | ||
zen-browser/desktop | 13,981 | comment_to_fix | gh-14044: Implement Space Routing (gh-13981) | `onAfterAddTab` also passes an incomplete options object (`{ skipRoute, fromExternal }`). This means the manager’s `#shouldSkipProcessing()` can’t detect pinned/tab-group tabs, and routing may run when it should be skipped. | b1be664f4d82e72bf34da8a0b4ed95e2b81f74ca | 97768c3c7a3d40bdc9eccf5223421d9adf5451d1 | diff --git a/src/browser/components/tabbrowser/content/tabbrowser-js.patch b/src/browser/components/tabbrowser/content/tabbrowser-js.patch
index 95bf58cee77..ef96e759e45 100644
--- a/src/browser/components/tabbrowser/content/tabbrowser-js.patch
+++ b/src/browser/components/tabbrowser/content/tabbrowser-js.patch
@@ -1,5... | [
"src/browser/components/tabbrowser/content/tabbrowser-js.patch"
] | [
{
"comment": "`onAfterAddTab` also passes an incomplete options object (`{ skipRoute, fromExternal }`). This means the manager’s `#shouldSkipProcessing()` can’t detect pinned/tab-group tabs, and routing may run when it should be skipped.",
"path": "src/browser/components/tabbrowser/content/tabbrowser-js.pat... | true | ||
zen-browser/desktop | 13,981 | comment_to_fix | gh-14044: Implement Space Routing (gh-13981) | `getRoute()`, `updateRoute()`, and `removeRoute()` don’t handle unknown IDs. `findIndex()` can return -1, which currently causes `removeRoute()` to delete the last route and `updateRoute()` to write to a non-index array property. This can corrupt the routes list if stale IDs are used (e.g., UI races, manual file edits)... | b1be664f4d82e72bf34da8a0b4ed95e2b81f74ca | 97768c3c7a3d40bdc9eccf5223421d9adf5451d1 | diff --git a/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs
new file mode 100644
index 00000000000..9109e89245a
--- /dev/null
+++ b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs
@@ -0,0 +1,413 @@
+/* This Source Code Form is subject to the terms of the... | [
"src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs"
] | [
{
"comment": "`getRoute()`, `updateRoute()`, and `removeRoute()` don’t handle unknown IDs. `findIndex()` can return -1, which currently causes `removeRoute()` to delete the last route and `updateRoute()` to write to a non-index array property. This can corrupt the routes list if stale IDs are used (e.g., UI rac... | true | ||
zen-browser/desktop | 13,981 | comment_to_fix | gh-14044: Implement Space Routing (gh-13981) | `isRouteMatching()` assumes `route.reference` is always a string and calls `.toLowerCase()` unconditionally. If the on-disk JSON is corrupted or a route object is malformed, this will throw and break routing for all tabs. | b1be664f4d82e72bf34da8a0b4ed95e2b81f74ca | 97768c3c7a3d40bdc9eccf5223421d9adf5451d1 | diff --git a/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs
new file mode 100644
index 00000000000..9109e89245a
--- /dev/null
+++ b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs
@@ -0,0 +1,413 @@
+/* This Source Code Form is subject to the terms of the... | [
"src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs"
] | [
{
"comment": "`isRouteMatching()` assumes `route.reference` is always a string and calls `.toLowerCase()` unconditionally. If the on-disk JSON is corrupted or a route object is malformed, this will throw and break routing for all tabs.",
"path": "src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs",
"h... | true | ||
zen-browser/desktop | 13,981 | comment_to_fix | gh-14044: Implement Space Routing (gh-13981) | Observers registered in the constructor (`Services.obs.addObserver(this, ...)`) are never removed because `uninit()` is never called. This risks leaking the dialog instance / window via the observer service after close, and could also cause `observe()` to run on a closed window. | b1be664f4d82e72bf34da8a0b4ed95e2b81f74ca | 97768c3c7a3d40bdc9eccf5223421d9adf5451d1 | diff --git a/src/zen/space-routing/ZenSpaceRoutingDialog.mjs b/src/zen/space-routing/ZenSpaceRoutingDialog.mjs
new file mode 100644
index 00000000000..3bdb6324f9f
--- /dev/null
+++ b/src/zen/space-routing/ZenSpaceRoutingDialog.mjs
@@ -0,0 +1,454 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public... | [
"src/zen/space-routing/ZenSpaceRoutingDialog.mjs"
] | [
{
"comment": "Observers registered in the constructor (`Services.obs.addObserver(this, ...)`) are never removed because `uninit()` is never called. This risks leaking the dialog instance / window via the observer service after close, and could also cause `observe()` to run on a closed window.",
"path": "src... | true | ||
zen-browser/desktop | 13,981 | comment_to_fix | gh-14044: Implement Space Routing (gh-13981) | `--sr-border-radius` is referenced later (`border-radius: var(--sr-border-radius)`) but never defined in this stylesheet. When the variable is unset, `border-radius` becomes invalid and falls back to the initial value, which may unintentionally remove rounding. | b1be664f4d82e72bf34da8a0b4ed95e2b81f74ca | 97768c3c7a3d40bdc9eccf5223421d9adf5451d1 | diff --git a/src/zen/space-routing/zen-space-routing.css b/src/zen/space-routing/zen-space-routing.css
new file mode 100644
index 00000000000..31aea297e67
--- /dev/null
+++ b/src/zen/space-routing/zen-space-routing.css
@@ -0,0 +1,315 @@
+/*
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * Lic... | [
"src/zen/space-routing/zen-space-routing.css"
] | [
{
"comment": "`--sr-border-radius` is referenced later (`border-radius: var(--sr-border-radius)`) but never defined in this stylesheet. When the variable is unset, `border-radius` becomes invalid and falls back to the initial value, which may unintentionally remove rounding.",
"path": "src/zen/space-routing... | true | ||
zen-browser/desktop | 13,981 | comment_to_fix | gh-14044: Implement Space Routing (gh-13981) | `min-height: none;` and `min-width: none;` are invalid CSS values (they’ll be ignored). If the goal is to remove minimum sizing constraints, use `0` (or omit the properties). | b1be664f4d82e72bf34da8a0b4ed95e2b81f74ca | 97768c3c7a3d40bdc9eccf5223421d9adf5451d1 | diff --git a/src/zen/space-routing/zen-space-routing.css b/src/zen/space-routing/zen-space-routing.css
new file mode 100644
index 00000000000..31aea297e67
--- /dev/null
+++ b/src/zen/space-routing/zen-space-routing.css
@@ -0,0 +1,315 @@
+/*
+ * This Source Code Form is subject to the terms of the Mozilla Public
+ * Lic... | [
"src/zen/space-routing/zen-space-routing.css"
] | [
{
"comment": "`min-height: none;` and `min-width: none;` are invalid CSS values (they’ll be ignored). If the goal is to remove minimum sizing constraints, use `0` (or omit the properties).",
"path": "src/zen/space-routing/zen-space-routing.css",
"hunk": "@@ -0,0 +1,313 @@\n+/*\n+ * This Source Code Form... | true | ||
zen-browser/desktop | 13,981 | comment_to_fix | gh-14044: Implement Space Routing (gh-13981) | `createRouteElement()` uses `document.createElement("vbox"/"hbox")` inside a XUL document. Elsewhere in the codebase XUL nodes are created with `document.createXULElement(...)` (e.g. `src/zen/common/modules/ZenUIManager.mjs:737-740`). Using `createElement()` here can create elements in the wrong namespace, leading to s... | b1be664f4d82e72bf34da8a0b4ed95e2b81f74ca | 97768c3c7a3d40bdc9eccf5223421d9adf5451d1 | diff --git a/src/zen/space-routing/ZenSpaceRoutingDialog.mjs b/src/zen/space-routing/ZenSpaceRoutingDialog.mjs
new file mode 100644
index 00000000000..3bdb6324f9f
--- /dev/null
+++ b/src/zen/space-routing/ZenSpaceRoutingDialog.mjs
@@ -0,0 +1,454 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public... | [
"src/zen/space-routing/ZenSpaceRoutingDialog.mjs"
] | [
{
"comment": "`createRouteElement()` uses `document.createElement(\"vbox\"/\"hbox\")` inside a XUL document. Elsewhere in the codebase XUL nodes are created with `document.createXULElement(...)` (e.g. `src/zen/common/modules/ZenUIManager.mjs:737-740`). Using `createElement()` here can create elements in the wro... | true | ||
zen-browser/desktop | 13,981 | comment_to_fix | gh-14044: Implement Space Routing (gh-13981) | Multiple route rows assign the same IDs (`sr-rule-top`, `sr-rule-bottom`, `match-type-select`, `open-in-select`). IDs must be unique within a document; duplicates can cause CSS/JS selectors (including `getElementById`) to behave unpredictably as soon as there is more than one rule. | b1be664f4d82e72bf34da8a0b4ed95e2b81f74ca | 97768c3c7a3d40bdc9eccf5223421d9adf5451d1 | diff --git a/src/zen/space-routing/ZenSpaceRoutingDialog.mjs b/src/zen/space-routing/ZenSpaceRoutingDialog.mjs
new file mode 100644
index 00000000000..3bdb6324f9f
--- /dev/null
+++ b/src/zen/space-routing/ZenSpaceRoutingDialog.mjs
@@ -0,0 +1,454 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public... | [
"src/zen/space-routing/ZenSpaceRoutingDialog.mjs"
] | [
{
"comment": "Multiple route rows assign the same IDs (`sr-rule-top`, `sr-rule-bottom`, `match-type-select`, `open-in-select`). IDs must be unique within a document; duplicates can cause CSS/JS selectors (including `getElementById`) to behave unpredictably as soon as there is more than one rule.",
"path": "... | true | ||
zen-browser/desktop | 13,981 | comment_to_fix | gh-14044: Implement Space Routing (gh-13981) | The document uses the same `id="sr-left"` twice (header and footer). Duplicate IDs are invalid and can break `getElementById` usage and CSS assumptions. If the intent is shared styling, prefer a class (e.g. `class="sr-left"`) and update the stylesheet accordingly. | b1be664f4d82e72bf34da8a0b4ed95e2b81f74ca | 97768c3c7a3d40bdc9eccf5223421d9adf5451d1 | diff --git a/src/zen/space-routing/zen-space-routing.inc.xhtml b/src/zen/space-routing/zen-space-routing.inc.xhtml
new file mode 100644
index 00000000000..dfda3422981
--- /dev/null
+++ b/src/zen/space-routing/zen-space-routing.inc.xhtml
@@ -0,0 +1,108 @@
+#filter substitution
+<?xml version="1.0"?>
+
+# -*- Mode: HTML ... | [
"src/zen/space-routing/zen-space-routing.inc.xhtml"
] | [
{
"comment": "The document uses the same `id=\"sr-left\"` twice (header and footer). Duplicate IDs are invalid and can break `getElementById` usage and CSS assumptions. If the intent is shared styling, prefer a class (e.g. `class=\"sr-left\"`) and update the stylesheet accordingly.",
"path": "src/zen/space-... | true | ||
zen-browser/desktop | 13,981 | comment_to_fix | gh-14044: Implement Space Routing (gh-13981) | getRoute() assumes this.#file.data.routes is always initialized. Because #readFromDisk() is async and not awaited in the constructor, this can throw a TypeError early (e.g. immediately after module import) when #file.data is still null/undefined. | b1be664f4d82e72bf34da8a0b4ed95e2b81f74ca | 97768c3c7a3d40bdc9eccf5223421d9adf5451d1 | diff --git a/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs
new file mode 100644
index 00000000000..9109e89245a
--- /dev/null
+++ b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs
@@ -0,0 +1,413 @@
+/* This Source Code Form is subject to the terms of the... | [
"src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs"
] | [
{
"comment": "getRoute() assumes this.#file.data.routes is always initialized. Because #readFromDisk() is async and not awaited in the constructor, this can throw a TypeError early (e.g. immediately after module import) when #file.data is still null/undefined.",
"path": "src/zen/space-routing/ZenSpaceRoutin... | true | ||
zen-browser/desktop | 13,981 | comment_to_fix | gh-14044: Implement Space Routing (gh-13981) | createNewRoute() also assumes this.#file.data.routes is initialized. If called before the JSONFile finishes loading, this will throw and can break the Space Routing UI/tests. | b1be664f4d82e72bf34da8a0b4ed95e2b81f74ca | 97768c3c7a3d40bdc9eccf5223421d9adf5451d1 | diff --git a/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs
new file mode 100644
index 00000000000..9109e89245a
--- /dev/null
+++ b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs
@@ -0,0 +1,413 @@
+/* This Source Code Form is subject to the terms of the... | [
"src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs"
] | [
{
"comment": "createNewRoute() also assumes this.#file.data.routes is initialized. If called before the JSONFile finishes loading, this will throw and can break the Space Routing UI/tests.",
"path": "src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs",
"hunk": "@@ -0,0 +1,404 @@\n+/* This Source Code ... | true | ||
zen-browser/desktop | 13,981 | comment_to_fix | gh-14044: Implement Space Routing (gh-13981) | setDefaultExternalRoute() writes to this.#file.data unconditionally. Like other mutators, this can throw if the backing JSONFile hasn't finished loading yet. | b1be664f4d82e72bf34da8a0b4ed95e2b81f74ca | 97768c3c7a3d40bdc9eccf5223421d9adf5451d1 | diff --git a/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs
new file mode 100644
index 00000000000..9109e89245a
--- /dev/null
+++ b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs
@@ -0,0 +1,413 @@
+/* This Source Code Form is subject to the terms of the... | [
"src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs"
] | [
{
"comment": "setDefaultExternalRoute() writes to this.#file.data unconditionally. Like other mutators, this can throw if the backing JSONFile hasn't finished loading yet.",
"path": "src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs",
"hunk": "@@ -0,0 +1,404 @@\n+/* This Source Code Form is subject t... | true | ||
zen-browser/desktop | 13,981 | comment_to_fix | gh-14044: Implement Space Routing (gh-13981) | isRouteMatching() recompiles user-provided regexes on every match attempt. With many rules or frequent tab opens, repeatedly constructing RegExp objects can become a noticeable hotspot; consider caching compiled regexes per route id and invalidating on updateRoute/removeRoute. | b1be664f4d82e72bf34da8a0b4ed95e2b81f74ca | 97768c3c7a3d40bdc9eccf5223421d9adf5451d1 | diff --git a/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs
new file mode 100644
index 00000000000..9109e89245a
--- /dev/null
+++ b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs
@@ -0,0 +1,413 @@
+/* This Source Code Form is subject to the terms of the... | [
"src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs"
] | [
{
"comment": "isRouteMatching() recompiles user-provided regexes on every match attempt. With many rules or frequent tab opens, repeatedly constructing RegExp objects can become a noticeable hotspot; consider caching compiled regexes per route id and invalidating on updateRoute/removeRoute.",
"path": "src/z... | true | ||
zen-browser/desktop | 13,981 | comment_to_fix | gh-14044: Implement Space Routing (gh-13981) | createOpenInList() is async, but the returned promise is neither awaited nor handled. If localization formatting or workspace enumeration throws/rejects, this becomes an unhandled promise rejection and can leave the select empty without a clear error path. | b1be664f4d82e72bf34da8a0b4ed95e2b81f74ca | 97768c3c7a3d40bdc9eccf5223421d9adf5451d1 | diff --git a/src/zen/space-routing/ZenSpaceRoutingDialog.mjs b/src/zen/space-routing/ZenSpaceRoutingDialog.mjs
new file mode 100644
index 00000000000..3bdb6324f9f
--- /dev/null
+++ b/src/zen/space-routing/ZenSpaceRoutingDialog.mjs
@@ -0,0 +1,454 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public... | [
"src/zen/space-routing/ZenSpaceRoutingDialog.mjs"
] | [
{
"comment": "createOpenInList() is async, but the returned promise is neither awaited nor handled. If localization formatting or workspace enumeration throws/rejects, this becomes an unhandled promise rejection and can leave the select empty without a clear error path.",
"path": "src/zen/space-routing/ZenS... | true | ||
zen-browser/desktop | 13,981 | comment_to_fix | gh-14044: Implement Space Routing (gh-13981) | This constructor docstring appears copy/pasted from Boosts ("boost share instance") and no longer describes what this class actually does. Updating it will make future maintenance much less error-prone. | b1be664f4d82e72bf34da8a0b4ed95e2b81f74ca | 97768c3c7a3d40bdc9eccf5223421d9adf5451d1 | diff --git a/src/zen/space-routing/ZenSpaceRoutingDialog.mjs b/src/zen/space-routing/ZenSpaceRoutingDialog.mjs
new file mode 100644
index 00000000000..3bdb6324f9f
--- /dev/null
+++ b/src/zen/space-routing/ZenSpaceRoutingDialog.mjs
@@ -0,0 +1,454 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public... | [
"src/zen/space-routing/ZenSpaceRoutingDialog.mjs"
] | [
{
"comment": "This constructor docstring appears copy/pasted from Boosts (\"boost share instance\") and no longer describes what this class actually does. Updating it will make future maintenance much less error-prone.",
"path": "src/zen/space-routing/ZenSpaceRoutingDialog.mjs",
"hunk": "@@ -0,0 +1,454 ... | true | ||
zen-browser/desktop | 13,981 | comment_to_fix | gh-14044: Implement Space Routing (gh-13981) | These visible UI strings (e.g. "URL") are hard-coded rather than localized. Since the rest of the dialog is already wired to Fluent, these should also use l10n to avoid partially untranslated UI. | b1be664f4d82e72bf34da8a0b4ed95e2b81f74ca | 97768c3c7a3d40bdc9eccf5223421d9adf5451d1 | diff --git a/src/zen/space-routing/ZenSpaceRoutingDialog.mjs b/src/zen/space-routing/ZenSpaceRoutingDialog.mjs
new file mode 100644
index 00000000000..3bdb6324f9f
--- /dev/null
+++ b/src/zen/space-routing/ZenSpaceRoutingDialog.mjs
@@ -0,0 +1,454 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public... | [
"src/zen/space-routing/ZenSpaceRoutingDialog.mjs"
] | [
{
"comment": "These visible UI strings (e.g. \"URL\") are hard-coded rather than localized. Since the rest of the dialog is already wired to Fluent, these should also use l10n to avoid partially untranslated UI.",
"path": "src/zen/space-routing/ZenSpaceRoutingDialog.mjs",
"hunk": "@@ -0,0 +1,454 @@\n+/*... | true | ||
zen-browser/desktop | 13,981 | comment_to_fix | gh-14044: Implement Space Routing (gh-13981) | The close button is icon-only and has no accessible name (label/title/aria-label). Add a localized accessible label so screen readers announce it correctly. | b1be664f4d82e72bf34da8a0b4ed95e2b81f74ca | 97768c3c7a3d40bdc9eccf5223421d9adf5451d1 | diff --git a/src/zen/space-routing/zen-space-routing.inc.xhtml b/src/zen/space-routing/zen-space-routing.inc.xhtml
new file mode 100644
index 00000000000..dfda3422981
--- /dev/null
+++ b/src/zen/space-routing/zen-space-routing.inc.xhtml
@@ -0,0 +1,108 @@
+#filter substitution
+<?xml version="1.0"?>
+
+# -*- Mode: HTML ... | [
"src/zen/space-routing/zen-space-routing.inc.xhtml"
] | [
{
"comment": "The close button is icon-only and has no accessible name (label/title/aria-label). Add a localized accessible label so screen readers announce it correctly.",
"path": "src/zen/space-routing/zen-space-routing.inc.xhtml",
"hunk": "@@ -0,0 +1,108 @@\n+#filter substitution\n+<?xml version=\"1.... | true | ||
zen-browser/desktop | 13,981 | comment_to_fix | gh-14044: Implement Space Routing (gh-13981) | If shouldEarlyExit becomes true, addTab currently returns undefined. addTab has call sites that expect a Tab or null, so returning null is safer and consistent with other early-exit paths. | b1be664f4d82e72bf34da8a0b4ed95e2b81f74ca | 97768c3c7a3d40bdc9eccf5223421d9adf5451d1 | diff --git a/src/browser/components/tabbrowser/content/tabbrowser-js.patch b/src/browser/components/tabbrowser/content/tabbrowser-js.patch
index 95bf58cee77..ef96e759e45 100644
--- a/src/browser/components/tabbrowser/content/tabbrowser-js.patch
+++ b/src/browser/components/tabbrowser/content/tabbrowser-js.patch
@@ -1,5... | [
"src/browser/components/tabbrowser/content/tabbrowser-js.patch"
] | [
{
"comment": "If shouldEarlyExit becomes true, addTab currently returns undefined. addTab has call sites that expect a Tab or null, so returning null is safer and consistent with other early-exit paths.",
"path": "src/browser/components/tabbrowser/content/tabbrowser-js.patch",
"hunk": "@@ -264,23 +264,3... | true | ||
zen-browser/desktop | 13,981 | comment_to_fix | gh-14044: Implement Space Routing (gh-13981) | The userContextId check uses a truthiness test. If a valid userContextId can ever be 0, this would incorrectly skip applying it. Using an explicit null/undefined check is safer, and also fixes spacing/style in this block. | b1be664f4d82e72bf34da8a0b4ed95e2b81f74ca | 97768c3c7a3d40bdc9eccf5223421d9adf5451d1 | diff --git a/src/browser/components/tabbrowser/content/tabbrowser-js.patch b/src/browser/components/tabbrowser/content/tabbrowser-js.patch
index 95bf58cee77..ef96e759e45 100644
--- a/src/browser/components/tabbrowser/content/tabbrowser-js.patch
+++ b/src/browser/components/tabbrowser/content/tabbrowser-js.patch
@@ -1,5... | [
"src/browser/components/tabbrowser/content/tabbrowser-js.patch"
] | [
{
"comment": "The userContextId check uses a truthiness test. If a valid userContextId can ever be 0, this would incorrectly skip applying it. Using an explicit null/undefined check is safer, and also fixes spacing/style in this block.",
"path": "src/browser/components/tabbrowser/content/tabbrowser-js.patch... | true | ||
zen-browser/desktop | 13,981 | comment_to_fix | gh-14044: Implement Space Routing (gh-13981) | Maybe tooltip text as well? | b1be664f4d82e72bf34da8a0b4ed95e2b81f74ca | 97768c3c7a3d40bdc9eccf5223421d9adf5451d1 | diff --git a/locales/en-US/browser/browser/zen-space-routing.ftl b/locales/en-US/browser/browser/zen-space-routing.ftl
new file mode 100644
index 00000000000..b8f063fb7aa
--- /dev/null
+++ b/locales/en-US/browser/browser/zen-space-routing.ftl
@@ -0,0 +1,25 @@
+# This Source Code Form is subject to the terms of the Mozi... | [
"locales/en-US/browser/browser/zen-space-routing.ftl"
] | [
{
"comment": "Maybe tooltip text as well?",
"path": "locales/en-US/browser/browser/zen-space-routing.ftl",
"hunk": "@@ -10,6 +10,8 @@ zen-space-routing-external-default = Default route for external links\n zen-space-routing-new-route = New Route\n zen-space-routing-open-in-space = Open in Space\n zen-sp... | true | ||
zen-browser/desktop | 13,981 | comment_to_fix | gh-14044: Implement Space Routing (gh-13981) | #readFromDisk() initializes `this.#file`, but methods like `createNewRoute()`, `updateRoute()`, `removeRoute()`, and `setDefaultExternalRoute()` access `this.#file.data.*` without guarding. Because the constructor calls `this.#readFromDisk()` without awaiting it, `this.#file.data` can still be unset when these methods ... | b1be664f4d82e72bf34da8a0b4ed95e2b81f74ca | 97768c3c7a3d40bdc9eccf5223421d9adf5451d1 | diff --git a/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs
new file mode 100644
index 00000000000..9109e89245a
--- /dev/null
+++ b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs
@@ -0,0 +1,413 @@
+/* This Source Code Form is subject to the terms of the... | [
"src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs"
] | [
{
"comment": "#readFromDisk() initializes `this.#file`, but methods like `createNewRoute()`, `updateRoute()`, `removeRoute()`, and `setDefaultExternalRoute()` access `this.#file.data.*` without guarding. Because the constructor calls `this.#readFromDisk()` without awaiting it, `this.#file.data` can still be uns... | true | ||
zen-browser/desktop | 13,981 | comment_to_fix | gh-14044: Implement Space Routing (gh-13981) | `onBeforeAddTab()` assumes `win.gZenWorkspaces` is always available, but other parts of the codebase explicitly guard `gZenWorkspaces` as optional. If `gZenWorkspaces` is undefined (or not initialized yet), this will throw when a route matches and tries to call `getWorkspaceFromId()`. | b1be664f4d82e72bf34da8a0b4ed95e2b81f74ca | 97768c3c7a3d40bdc9eccf5223421d9adf5451d1 | diff --git a/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs
new file mode 100644
index 00000000000..9109e89245a
--- /dev/null
+++ b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs
@@ -0,0 +1,413 @@
+/* This Source Code Form is subject to the terms of the... | [
"src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs"
] | [
{
"comment": "`onBeforeAddTab()` assumes `win.gZenWorkspaces` is always available, but other parts of the codebase explicitly guard `gZenWorkspaces` as optional. If `gZenWorkspaces` is undefined (or not initialized yet), this will throw when a route matches and tries to call `getWorkspaceFromId()`.",
"path"... | true | ||
zen-browser/desktop | 13,981 | comment_to_fix | gh-14044: Implement Space Routing (gh-13981) | Same issue as `onBeforeAddTab()`: `#routeToWorkspace()` unconditionally dereferences `win.gZenWorkspaces`. If spaces are disabled/unavailable for a given window, routing a matched URL will throw (and get caught/logged), but the tab will never be moved and you'll get noisy console errors. | b1be664f4d82e72bf34da8a0b4ed95e2b81f74ca | 97768c3c7a3d40bdc9eccf5223421d9adf5451d1 | diff --git a/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs
new file mode 100644
index 00000000000..9109e89245a
--- /dev/null
+++ b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs
@@ -0,0 +1,413 @@
+/* This Source Code Form is subject to the terms of the... | [
"src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs"
] | [
{
"comment": "Same issue as `onBeforeAddTab()`: `#routeToWorkspace()` unconditionally dereferences `win.gZenWorkspaces`. If spaces are disabled/unavailable for a given window, routing a matched URL will throw (and get caught/logged), but the tab will never be moved and you'll get noisy console errors.",
"pa... | true | ||
zen-browser/desktop | 13,981 | comment_to_fix | gh-14044: Implement Space Routing (gh-13981) | When a regex fails to compile, the logged error message omits both the exception and the invalid pattern, making diagnosis difficult (and potentially spamming a generic message on every match attempt for a corrupted on-disk route). Include the caught error and reference in the log. | b1be664f4d82e72bf34da8a0b4ed95e2b81f74ca | 97768c3c7a3d40bdc9eccf5223421d9adf5451d1 | diff --git a/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs
new file mode 100644
index 00000000000..9109e89245a
--- /dev/null
+++ b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs
@@ -0,0 +1,413 @@
+/* This Source Code Form is subject to the terms of the... | [
"src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs"
] | [
{
"comment": "When a regex fails to compile, the logged error message omits both the exception and the invalid pattern, making diagnosis difficult (and potentially spamming a generic message on every match attempt for a corrupted on-disk route). Include the caught error and reference in the log.",
"path": "... | true | ||
zen-browser/desktop | 13,981 | comment_to_fix | gh-14044: Implement Space Routing (gh-13981) | The header JSDoc is copy/pasted from another feature (“boost share instance”), so it no longer describes what this dialog class does or what the parameters represent. This makes the module misleading for future maintainers. | b1be664f4d82e72bf34da8a0b4ed95e2b81f74ca | 97768c3c7a3d40bdc9eccf5223421d9adf5451d1 | diff --git a/src/zen/space-routing/ZenSpaceRoutingDialog.mjs b/src/zen/space-routing/ZenSpaceRoutingDialog.mjs
new file mode 100644
index 00000000000..3bdb6324f9f
--- /dev/null
+++ b/src/zen/space-routing/ZenSpaceRoutingDialog.mjs
@@ -0,0 +1,454 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public... | [
"src/zen/space-routing/ZenSpaceRoutingDialog.mjs"
] | [
{
"comment": "The header JSDoc is copy/pasted from another feature (“boost share instance”), so it no longer describes what this dialog class does or what the parameters represent. This makes the module misleading for future maintainers.",
"path": "src/zen/space-routing/ZenSpaceRoutingDialog.mjs",
"hunk... | true | ||
zen-browser/desktop | 13,981 | comment_to_fix | gh-14044: Implement Space Routing (gh-13981) | Typo in method name: `onRotueReferenceChange` should be `onRouteReferenceChange` (spelling), to keep the API/searchability consistent. | b1be664f4d82e72bf34da8a0b4ed95e2b81f74ca | 97768c3c7a3d40bdc9eccf5223421d9adf5451d1 | diff --git a/src/zen/space-routing/ZenSpaceRoutingDialog.mjs b/src/zen/space-routing/ZenSpaceRoutingDialog.mjs
new file mode 100644
index 00000000000..3bdb6324f9f
--- /dev/null
+++ b/src/zen/space-routing/ZenSpaceRoutingDialog.mjs
@@ -0,0 +1,454 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public... | [
"src/zen/space-routing/ZenSpaceRoutingDialog.mjs"
] | [
{
"comment": "Typo in method name: `onRotueReferenceChange` should be `onRouteReferenceChange` (spelling), to keep the API/searchability consistent.",
"path": "src/zen/space-routing/ZenSpaceRoutingDialog.mjs",
"hunk": "@@ -0,0 +1,454 @@\n+/* This Source Code Form is subject to the terms of the Mozilla P... | true | ||
zen-browser/desktop | 13,981 | comment_to_fix | gh-14044: Implement Space Routing (gh-13981) | Typo in method name: rename `onRotueReferenceChange` to `onRouteReferenceChange` to match the call site and avoid perpetuating the misspelling. | b1be664f4d82e72bf34da8a0b4ed95e2b81f74ca | 97768c3c7a3d40bdc9eccf5223421d9adf5451d1 | diff --git a/src/zen/space-routing/ZenSpaceRoutingDialog.mjs b/src/zen/space-routing/ZenSpaceRoutingDialog.mjs
new file mode 100644
index 00000000000..3bdb6324f9f
--- /dev/null
+++ b/src/zen/space-routing/ZenSpaceRoutingDialog.mjs
@@ -0,0 +1,454 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public... | [
"src/zen/space-routing/ZenSpaceRoutingDialog.mjs"
] | [
{
"comment": "Typo in method name: rename `onRotueReferenceChange` to `onRouteReferenceChange` to match the call site and avoid perpetuating the misspelling.",
"path": "src/zen/space-routing/ZenSpaceRoutingDialog.mjs",
"hunk": "@@ -0,0 +1,454 @@\n+/* This Source Code Form is subject to the terms of the ... | true | ||
zen-browser/desktop | 13,981 | comment_to_fix | gh-14044: Implement Space Routing (gh-13981) | Missing semicolons after `setAttribute(...)` here will violate the project’s usual JS style and can trip ESLint if `semi: ["error", "always"]` is enabled. | b1be664f4d82e72bf34da8a0b4ed95e2b81f74ca | 97768c3c7a3d40bdc9eccf5223421d9adf5451d1 | diff --git a/src/zen/space-routing/ZenSpaceRoutingDialog.mjs b/src/zen/space-routing/ZenSpaceRoutingDialog.mjs
new file mode 100644
index 00000000000..3bdb6324f9f
--- /dev/null
+++ b/src/zen/space-routing/ZenSpaceRoutingDialog.mjs
@@ -0,0 +1,454 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public... | [
"src/zen/space-routing/ZenSpaceRoutingDialog.mjs"
] | [
{
"comment": "Missing semicolons after `setAttribute(...)` here will violate the project’s usual JS style and can trip ESLint if `semi: [\"error\", \"always\"]` is enabled.",
"path": "src/zen/space-routing/ZenSpaceRoutingDialog.mjs",
"hunk": "@@ -0,0 +1,454 @@\n+/* This Source Code Form is subject to th... | true | ||
zen-browser/desktop | 13,981 | comment_to_fix | gh-14044: Implement Space Routing (gh-13981) | Missing semicolons after `setAttribute(...)` here will violate the project’s usual JS style and can trip ESLint if `semi: ["error", "always"]` is enabled. | b1be664f4d82e72bf34da8a0b4ed95e2b81f74ca | 97768c3c7a3d40bdc9eccf5223421d9adf5451d1 | diff --git a/src/zen/space-routing/ZenSpaceRoutingDialog.mjs b/src/zen/space-routing/ZenSpaceRoutingDialog.mjs
new file mode 100644
index 00000000000..3bdb6324f9f
--- /dev/null
+++ b/src/zen/space-routing/ZenSpaceRoutingDialog.mjs
@@ -0,0 +1,454 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public... | [
"src/zen/space-routing/ZenSpaceRoutingDialog.mjs"
] | [
{
"comment": "Missing semicolons after `setAttribute(...)` here will violate the project’s usual JS style and can trip ESLint if `semi: [\"error\", \"always\"]` is enabled.",
"path": "src/zen/space-routing/ZenSpaceRoutingDialog.mjs",
"hunk": "@@ -0,0 +1,454 @@\n+/* This Source Code Form is subject to th... | true | ||
zen-browser/desktop | 13,981 | comment_to_fix | gh-14044: Implement Space Routing (gh-13981) | The `equal-to` match compares a normalized URL against the *raw* `reference` string. If a user enters `https://github.com` or `www.github.com` as the reference, it will never match because only the URI is normalized. Normalize the reference too so the semantics described in tests/docs (“ignores protocol and www”) apply... | b1be664f4d82e72bf34da8a0b4ed95e2b81f74ca | 97768c3c7a3d40bdc9eccf5223421d9adf5451d1 | diff --git a/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs
new file mode 100644
index 00000000000..9109e89245a
--- /dev/null
+++ b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs
@@ -0,0 +1,413 @@
+/* This Source Code Form is subject to the terms of the... | [
"src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs"
] | [
{
"comment": "The `equal-to` match compares a normalized URL against the *raw* `reference` string. If a user enters `https://github.com` or `www.github.com` as the reference, it will never match because only the URI is normalized. Normalize the reference too so the semantics described in tests/docs (“ignores pr... | true | ||
zen-browser/desktop | 13,981 | comment_to_fix | gh-14044: Implement Space Routing (gh-13981) | The `routeUri` docstring claims it can return "lil-zen", but the implementation and UI never return/offer that value. This makes the public contract misleading for callers. | b1be664f4d82e72bf34da8a0b4ed95e2b81f74ca | 97768c3c7a3d40bdc9eccf5223421d9adf5451d1 | diff --git a/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs
new file mode 100644
index 00000000000..9109e89245a
--- /dev/null
+++ b/src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs
@@ -0,0 +1,413 @@
+/* This Source Code Form is subject to the terms of the... | [
"src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs"
] | [
{
"comment": "The `routeUri` docstring claims it can return \"lil-zen\", but the implementation and UI never return/offer that value. This makes the public contract misleading for callers.",
"path": "src/zen/space-routing/ZenSpaceRoutingManager.sys.mjs",
"hunk": "@@ -0,0 +1,409 @@\n+/* This Source Code ... | true | ||
zen-browser/desktop | 13,981 | comment_to_fix | gh-14044: Implement Space Routing (gh-13981) | If a route was previously in `regex` mode with an invalid pattern, the input gets the `invalid` class, but that class is never cleared when switching to a non-regex match type. This can leave the UI permanently marked invalid even though the current match type doesn’t require regex validation. | b1be664f4d82e72bf34da8a0b4ed95e2b81f74ca | 97768c3c7a3d40bdc9eccf5223421d9adf5451d1 | diff --git a/src/zen/space-routing/ZenSpaceRoutingDialog.mjs b/src/zen/space-routing/ZenSpaceRoutingDialog.mjs
new file mode 100644
index 00000000000..3bdb6324f9f
--- /dev/null
+++ b/src/zen/space-routing/ZenSpaceRoutingDialog.mjs
@@ -0,0 +1,454 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public... | [
"src/zen/space-routing/ZenSpaceRoutingDialog.mjs"
] | [
{
"comment": "If a route was previously in `regex` mode with an invalid pattern, the input gets the `invalid` class, but that class is never cleared when switching to a non-regex match type. This can leave the UI permanently marked invalid even though the current match type doesn’t require regex validation.",
... | true | ||
zen-browser/desktop | 13,981 | comment_to_fix | gh-14044: Implement Space Routing (gh-13981) | Switching *to* a non-regex match type should also clear any prior `invalid` state from the input. Right now `invalid` only gets removed by `onCheckRegexValid`, which is only called for `regex` routes. | b1be664f4d82e72bf34da8a0b4ed95e2b81f74ca | 97768c3c7a3d40bdc9eccf5223421d9adf5451d1 | diff --git a/src/zen/space-routing/ZenSpaceRoutingDialog.mjs b/src/zen/space-routing/ZenSpaceRoutingDialog.mjs
new file mode 100644
index 00000000000..3bdb6324f9f
--- /dev/null
+++ b/src/zen/space-routing/ZenSpaceRoutingDialog.mjs
@@ -0,0 +1,454 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public... | [
"src/zen/space-routing/ZenSpaceRoutingDialog.mjs"
] | [
{
"comment": "Switching *to* a non-regex match type should also clear any prior `invalid` state from the input. Right now `invalid` only gets removed by `onCheckRegexValid`, which is only called for `regex` routes.",
"path": "src/zen/space-routing/ZenSpaceRoutingDialog.mjs",
"hunk": "@@ -0,0 +1,454 @@\n... | true | ||
zen-browser/desktop | 13,981 | comment_to_fix | gh-14044: Implement Space Routing (gh-13981) | Routing runs for `_forZenEmptyTab` tabs because the manager only sees `skipRoute`. That can cause special Zen empty tabs (e.g. workspace placeholders) to be created in a routed container/workspace if a broad rule matches. Treat `_forZenEmptyTab` as an unconditional routing skip when calling `onBeforeAddTab`. | b1be664f4d82e72bf34da8a0b4ed95e2b81f74ca | 97768c3c7a3d40bdc9eccf5223421d9adf5451d1 | diff --git a/src/browser/components/tabbrowser/content/tabbrowser-js.patch b/src/browser/components/tabbrowser/content/tabbrowser-js.patch
index 95bf58cee77..ef96e759e45 100644
--- a/src/browser/components/tabbrowser/content/tabbrowser-js.patch
+++ b/src/browser/components/tabbrowser/content/tabbrowser-js.patch
@@ -1,5... | [
"src/browser/components/tabbrowser/content/tabbrowser-js.patch"
] | [
{
"comment": "Routing runs for `_forZenEmptyTab` tabs because the manager only sees `skipRoute`. That can cause special Zen empty tabs (e.g. workspace placeholders) to be created in a routed container/workspace if a broad rule matches. Treat `_forZenEmptyTab` as an unconditional routing skip when calling `onBef... | true | ||
zen-browser/desktop | 13,981 | comment_to_fix | gh-14044: Implement Space Routing (gh-13981) | `onAfterAddTab` should use the same effective skip condition as `onBeforeAddTab`. Otherwise `_forZenEmptyTab` tabs could still be post-routed even if you skip them in the pre-hook. | b1be664f4d82e72bf34da8a0b4ed95e2b81f74ca | 97768c3c7a3d40bdc9eccf5223421d9adf5451d1 | diff --git a/src/browser/components/tabbrowser/content/tabbrowser-js.patch b/src/browser/components/tabbrowser/content/tabbrowser-js.patch
index 95bf58cee77..ef96e759e45 100644
--- a/src/browser/components/tabbrowser/content/tabbrowser-js.patch
+++ b/src/browser/components/tabbrowser/content/tabbrowser-js.patch
@@ -1,5... | [
"src/browser/components/tabbrowser/content/tabbrowser-js.patch"
] | [
{
"comment": "`onAfterAddTab` should use the same effective skip condition as `onBeforeAddTab`. Otherwise `_forZenEmptyTab` tabs could still be post-routed even if you skip them in the pre-hook.",
"path": "src/browser/components/tabbrowser/content/tabbrowser-js.patch",
"hunk": "@@ -352,15 +361,25 @@ ind... | true | ||
zen-browser/desktop | 13,598 | issue_to_patch | Add space and container sync | - Created sync engine for syncing workspaces and containers
- patched `ContextualIdentityService` to allow creating containers with specific IDs | 818c448dfc3ed7507e9055c538fa2a05ecb6a6aa | 1ac926bea21e0ea1482583196d427fb08ef8d73c | diff --git a/src/browser/components/preferences/sync-js.patch b/src/browser/components/preferences/sync-js.patch
new file mode 100644
index 00000000000..5fcabf4c424
--- /dev/null
+++ b/src/browser/components/preferences/sync-js.patch
@@ -0,0 +1,20 @@
+diff --git a/browser/components/preferences/sync.js b/browser/compon... | [
"src/browser/components/preferences/sync-js.patch",
"src/services/sync/modules/service-sys-mjs.patch",
"src/toolkit/components/contextualidentity/ContextualIdentityService-sys-mjs.patch",
"src/zen/moz.build",
"src/zen/sessionstore/ZenSessionManager.sys.mjs",
"src/zen/spaces/ZenSpaceManager.mjs",
"src/ze... | [
{
"comment": "For container tombstones, `parsed.key` is always a string (from `id.slice(...)`), but `ContextualIdentityService.remove/update/create` expect a numeric `userContextId`. This will cause container deletions from Sync to be skipped (remove will likely throw and is ignored in `ZenSyncManager`). Coerce... | true | ||
zen-browser/desktop | 13,598 | comment_to_fix | Add space and container sync | The new `id` parameter treats any value other than `null` as an explicit ID. If callers pass `undefined` (e.g., a missing `userContextId` from sync data), this will set `userContextId = undefined` and update `_lastUserContextId` with `Math.max(..., undefined)`, producing `NaN` and breaking future ID allocation. Conside... | 818c448dfc3ed7507e9055c538fa2a05ecb6a6aa | 1ac926bea21e0ea1482583196d427fb08ef8d73c | diff --git a/src/toolkit/components/contextualidentity/ContextualIdentityService-sys-mjs.patch b/src/toolkit/components/contextualidentity/ContextualIdentityService-sys-mjs.patch
new file mode 100644
index 00000000000..1b108254d1f
--- /dev/null
+++ b/src/toolkit/components/contextualidentity/ContextualIdentityService-s... | [
"src/toolkit/components/contextualidentity/ContextualIdentityService-sys-mjs.patch"
] | [
{
"comment": "The new `id` parameter treats any value other than `null` as an explicit ID. If callers pass `undefined` (e.g., a missing `userContextId` from sync data), this will set `userContextId = undefined` and update `_lastUserContextId` with `Math.max(..., undefined)`, producing `NaN` and breaking future ... | true | ||
zen-browser/desktop | 13,598 | comment_to_fix | Add space and container sync | `_applySyncChanges` merges `pulled.spaces` into a Map without checking `space.uuid`. If an incoming record is malformed (missing `uuid`), this will insert an `undefined` key and can later break `propagateWorkspaces`/UI assumptions. Mirror the guard used in `ZenSyncManager.#mergeIncomingItems` by skipping pulled items w... | 818c448dfc3ed7507e9055c538fa2a05ecb6a6aa | 1ac926bea21e0ea1482583196d427fb08ef8d73c | diff --git a/src/zen/spaces/ZenSpaceManager.mjs b/src/zen/spaces/ZenSpaceManager.mjs
index a97dd097814..54e1e2d1dd0 100644
--- a/src/zen/spaces/ZenSpaceManager.mjs
+++ b/src/zen/spaces/ZenSpaceManager.mjs
@@ -11,6 +11,7 @@ const lazy = {};
ChromeUtils.defineESModuleGetters(lazy, {
ZenSessionStore: "resource:///mo... | [
"src/zen/spaces/ZenSpaceManager.mjs"
] | [
{
"comment": "`_applySyncChanges` merges `pulled.spaces` into a Map without checking `space.uuid`. If an incoming record is malformed (missing `uuid`), this will insert an `undefined` key and can later break `propagateWorkspaces`/UI assumptions. Mirror the guard used in `ZenSyncManager.#mergeIncomingItems` by s... | true | ||
zen-browser/desktop | 13,598 | comment_to_fix | Add space and container sync | `applyIncomingBatch` catches and logs all errors, then returns normally. Because the Sync store treats the batch as applied, this can turn transient failures (or schema issues) into silent divergence with no retry. Consider letting the error propagate (or returning per-record failures) so Sync can retry/back off approp... | 818c448dfc3ed7507e9055c538fa2a05ecb6a6aa | 1ac926bea21e0ea1482583196d427fb08ef8d73c | diff --git a/src/zen/sync/ZenSyncManager.sys.mjs b/src/zen/sync/ZenSyncManager.sys.mjs
new file mode 100644
index 00000000000..1b454da8166
--- /dev/null
+++ b/src/zen/sync/ZenSyncManager.sys.mjs
@@ -0,0 +1,160 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of t... | [
"src/zen/sync/ZenSyncManager.sys.mjs"
] | [
{
"comment": "`applyIncomingBatch` catches and logs all errors, then returns normally. Because the Sync store treats the batch as applied, this can turn transient failures (or schema issues) into silent divergence with no retry. Consider letting the error propagate (or returning per-record failures) so Sync can... | true | ||
zen-browser/desktop | 13,598 | comment_to_fix | Add space and container sync | Sidebar can't be null | 818c448dfc3ed7507e9055c538fa2a05ecb6a6aa | 1ac926bea21e0ea1482583196d427fb08ef8d73c | diff --git a/src/zen/sessionstore/ZenSessionManager.sys.mjs b/src/zen/sessionstore/ZenSessionManager.sys.mjs
index 39f2d0eb269..bccec81c60a 100644
--- a/src/zen/sessionstore/ZenSessionManager.sys.mjs
+++ b/src/zen/sessionstore/ZenSessionManager.sys.mjs
@@ -10,6 +10,7 @@ const lazy = {};
ChromeUtils.defineESModuleGette... | [
"src/zen/sessionstore/ZenSessionManager.sys.mjs"
] | [
{
"comment": "Sidebar can't be null",
"path": "src/zen/sessionstore/ZenSessionManager.sys.mjs",
"hunk": "@@ -622,6 +625,24 @@ export class nsZenSessionManager {\n this.log(`Saving Zen session data with ${sidebar.tabs?.length || 0} tabs`);\n }\n \n+ getSidebarData() {\n+ const sidebar = this.#s... | true | ||
zen-browser/desktop | 13,598 | comment_to_fix | Add space and container sync | YOu can just call "save()", no? | 818c448dfc3ed7507e9055c538fa2a05ecb6a6aa | 1ac926bea21e0ea1482583196d427fb08ef8d73c | diff --git a/src/zen/sessionstore/ZenSessionManager.sys.mjs b/src/zen/sessionstore/ZenSessionManager.sys.mjs
index 39f2d0eb269..bccec81c60a 100644
--- a/src/zen/sessionstore/ZenSessionManager.sys.mjs
+++ b/src/zen/sessionstore/ZenSessionManager.sys.mjs
@@ -10,6 +10,7 @@ const lazy = {};
ChromeUtils.defineESModuleGette... | [
"src/zen/sessionstore/ZenSessionManager.sys.mjs"
] | [
{
"comment": "YOu can just call \"save()\", no?",
"path": "src/zen/sessionstore/ZenSessionManager.sys.mjs",
"hunk": "@@ -622,6 +625,24 @@ export class nsZenSessionManager {\n this.log(`Saving Zen session data with ${sidebar.tabs?.length || 0} tabs`);\n }\n \n+ getSidebarData() {\n+ const sideb... | true | ||
zen-browser/desktop | 13,598 | comment_to_fix | Add space and container sync | Uneeded comments imo, should better just add doc comments to the classes | 818c448dfc3ed7507e9055c538fa2a05ecb6a6aa | 1ac926bea21e0ea1482583196d427fb08ef8d73c | diff --git a/src/zen/sync/ZenWorkspacesSync.sys.mjs b/src/zen/sync/ZenWorkspacesSync.sys.mjs
new file mode 100644
index 00000000000..175319169aa
--- /dev/null
+++ b/src/zen/sync/ZenWorkspacesSync.sys.mjs
@@ -0,0 +1,404 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a ... | [
"src/zen/sync/ZenWorkspacesSync.sys.mjs"
] | [
{
"comment": "Uneeded comments imo, should better just add doc comments to the classes",
"path": "src/zen/sync/ZenWorkspacesSync.sys.mjs",
"hunk": "@@ -0,0 +1,366 @@\n+/* This Source Code Form is subject to the terms of the Mozilla Public\n+ * License, v. 2.0. If a copy of the MPL was not distributed wi... | true | ||
zen-browser/desktop | 13,598 | comment_to_fix | Add space and container sync | ```suggestion
#lastSnapshot = null;
``` | 818c448dfc3ed7507e9055c538fa2a05ecb6a6aa | 1ac926bea21e0ea1482583196d427fb08ef8d73c | diff --git a/src/zen/sync/ZenSyncManager.sys.mjs b/src/zen/sync/ZenSyncManager.sys.mjs
new file mode 100644
index 00000000000..1b454da8166
--- /dev/null
+++ b/src/zen/sync/ZenSyncManager.sys.mjs
@@ -0,0 +1,160 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of t... | [
"src/zen/sync/ZenSyncManager.sys.mjs"
] | [
{
"comment": "```suggestion\n #lastSnapshot = null;\n```",
"path": "src/zen/sync/ZenSyncManager.sys.mjs",
"hunk": "@@ -0,0 +1,171 @@\n+/* This Source Code Form is subject to the terms of the Mozilla Public\n+ * License, v. 2.0. If a copy of the MPL was not distributed with this\n+ * file, You can obtai... | true | ||
zen-browser/desktop | 13,598 | comment_to_fix | Add space and container sync | What are snapshots used for btw? I dont see any references for them | 818c448dfc3ed7507e9055c538fa2a05ecb6a6aa | 1ac926bea21e0ea1482583196d427fb08ef8d73c | diff --git a/src/zen/sync/ZenSyncManager.sys.mjs b/src/zen/sync/ZenSyncManager.sys.mjs
new file mode 100644
index 00000000000..1b454da8166
--- /dev/null
+++ b/src/zen/sync/ZenSyncManager.sys.mjs
@@ -0,0 +1,160 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of t... | [
"src/zen/sync/ZenSyncManager.sys.mjs"
] | [
{
"comment": "What are snapshots used for btw? I dont see any references for them",
"path": "src/zen/sync/ZenSyncManager.sys.mjs",
"hunk": "@@ -0,0 +1,171 @@\n+/* This Source Code Form is subject to the terms of the Mozilla Public\n+ * License, v. 2.0. If a copy of the MPL was not distributed with this\... | true | ||
zen-browser/desktop | 13,598 | comment_to_fix | Add space and container sync | No need for "null", its an optional argument | 818c448dfc3ed7507e9055c538fa2a05ecb6a6aa | 1ac926bea21e0ea1482583196d427fb08ef8d73c | diff --git a/src/zen/sync/ZenSyncManager.sys.mjs b/src/zen/sync/ZenSyncManager.sys.mjs
new file mode 100644
index 00000000000..1b454da8166
--- /dev/null
+++ b/src/zen/sync/ZenSyncManager.sys.mjs
@@ -0,0 +1,160 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of t... | [
"src/zen/sync/ZenSyncManager.sys.mjs"
] | [
{
"comment": "No need for \"null\", its an optional argument",
"path": "src/zen/sync/ZenSyncManager.sys.mjs",
"hunk": "@@ -29,19 +29,19 @@ class ZenSyncManager {\n for (const [uuid, hash] of snapshot.spaces) {\n if (prev.spaces.get(uuid) !== hash) {\n Services.obs.notifyObservers... | true | ||
zen-browser/desktop | 13,598 | comment_to_fix | Add space and container sync | prefix with # instead | 818c448dfc3ed7507e9055c538fa2a05ecb6a6aa | 1ac926bea21e0ea1482583196d427fb08ef8d73c | diff --git a/src/zen/sync/ZenWorkspacesSync.sys.mjs b/src/zen/sync/ZenWorkspacesSync.sys.mjs
new file mode 100644
index 00000000000..175319169aa
--- /dev/null
+++ b/src/zen/sync/ZenWorkspacesSync.sys.mjs
@@ -0,0 +1,404 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a ... | [
"src/zen/sync/ZenWorkspacesSync.sys.mjs"
] | [
{
"comment": "prefix with # instead",
"path": "src/zen/sync/ZenWorkspacesSync.sys.mjs",
"hunk": "@@ -0,0 +1,369 @@\n+/* This Source Code Form is subject to the terms of the Mozilla Public\n+ * License, v. 2.0. If a copy of the MPL was not distributed with this\n+ * file, You can obtain one at http://moz... | true | ||
zen-browser/desktop | 13,598 | comment_to_fix | Add space and container sync | If we are going to go around with the weird string prefixes, at least make them be used from an object, as so that it can be type-checked and find errors early if we need to change them | 818c448dfc3ed7507e9055c538fa2a05ecb6a6aa | 1ac926bea21e0ea1482583196d427fb08ef8d73c | diff --git a/src/zen/sync/ZenWorkspacesSync.sys.mjs b/src/zen/sync/ZenWorkspacesSync.sys.mjs
new file mode 100644
index 00000000000..175319169aa
--- /dev/null
+++ b/src/zen/sync/ZenWorkspacesSync.sys.mjs
@@ -0,0 +1,404 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a ... | [
"src/zen/sync/ZenWorkspacesSync.sys.mjs"
] | [
{
"comment": "If we are going to go around with the weird string prefixes, at least make them be used from an object, as so that it can be type-checked and find errors early if we need to change them",
"path": "src/zen/sync/ZenWorkspacesSync.sys.mjs",
"hunk": "@@ -0,0 +1,369 @@\n+/* This Source Code For... | true | ||
zen-browser/desktop | 13,598 | comment_to_fix | Add space and container sync | `itemExists` assumes `spaces` is always an array, but `win?.gZenWorkspaces?.getWorkspaces()` can be `undefined` (e.g., no browser window yet / workspaces disabled). Calling `spaces.some(...)` would throw and can break the Sync engine. Default `spaces` to an empty array before using array methods. | 818c448dfc3ed7507e9055c538fa2a05ecb6a6aa | 1ac926bea21e0ea1482583196d427fb08ef8d73c | diff --git a/src/zen/sync/ZenWorkspacesSync.sys.mjs b/src/zen/sync/ZenWorkspacesSync.sys.mjs
new file mode 100644
index 00000000000..175319169aa
--- /dev/null
+++ b/src/zen/sync/ZenWorkspacesSync.sys.mjs
@@ -0,0 +1,404 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a ... | [
"src/zen/sync/ZenWorkspacesSync.sys.mjs"
] | [
{
"comment": "`itemExists` assumes `spaces` is always an array, but `win?.gZenWorkspaces?.getWorkspaces()` can be `undefined` (e.g., no browser window yet / workspaces disabled). Calling `spaces.some(...)` would throw and can break the Sync engine. Default `spaces` to an empty array before using array methods."... | true | ||
zen-browser/desktop | 13,598 | comment_to_fix | Add space and container sync | `createRecord` also assumes `spaces` is always an array; if `win` or `gZenWorkspaces` is missing, `spaces.findIndex(...)` will throw and turn an otherwise recoverable condition into a hard sync failure. Use `const spaces = ... || []` (or early-return `record.deleted = true`). | 818c448dfc3ed7507e9055c538fa2a05ecb6a6aa | 1ac926bea21e0ea1482583196d427fb08ef8d73c | diff --git a/src/zen/sync/ZenWorkspacesSync.sys.mjs b/src/zen/sync/ZenWorkspacesSync.sys.mjs
new file mode 100644
index 00000000000..175319169aa
--- /dev/null
+++ b/src/zen/sync/ZenWorkspacesSync.sys.mjs
@@ -0,0 +1,404 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a ... | [
"src/zen/sync/ZenWorkspacesSync.sys.mjs"
] | [
{
"comment": "`createRecord` also assumes `spaces` is always an array; if `win` or `gZenWorkspaces` is missing, `spaces.findIndex(...)` will throw and turn an otherwise recoverable condition into a hard sync failure. Use `const spaces = ... || []` (or early-return `record.deleted = true`).",
"path": "src/ze... | true | ||
zen-browser/desktop | 13,598 | comment_to_fix | Add space and container sync | Container tombstones store `userContextId` as a string (`parsed.key`). `ContextualIdentityService.remove/update/create` expect a numeric ID; passing a string can make deletes/updates fail (and deletes are currently swallowed). Coerce to a finite integer when building `removals.containers` (and/or in the consumer) and s... | 818c448dfc3ed7507e9055c538fa2a05ecb6a6aa | 1ac926bea21e0ea1482583196d427fb08ef8d73c | diff --git a/src/zen/sync/ZenWorkspacesSync.sys.mjs b/src/zen/sync/ZenWorkspacesSync.sys.mjs
new file mode 100644
index 00000000000..175319169aa
--- /dev/null
+++ b/src/zen/sync/ZenWorkspacesSync.sys.mjs
@@ -0,0 +1,404 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a ... | [
"src/zen/sync/ZenWorkspacesSync.sys.mjs"
] | [
{
"comment": "Container tombstones store `userContextId` as a string (`parsed.key`). `ContextualIdentityService.remove/update/create` expect a numeric ID; passing a string can make deletes/updates fail (and deletes are currently swallowed). Coerce to a finite integer when building `removals.containers` (and/or ... | true | ||
zen-browser/desktop | 13,598 | comment_to_fix | Add space and container sync | Incoming container records use `container.userContextId` directly for `ContextualIdentityService.update(...)` without validating/coercing it to a finite integer. If Sync data provides a string/NaN/missing ID, this can throw or corrupt state. Normalize and validate `userContextId` before calling `update` (and apply the ... | 818c448dfc3ed7507e9055c538fa2a05ecb6a6aa | 1ac926bea21e0ea1482583196d427fb08ef8d73c | diff --git a/src/zen/sync/ZenSyncManager.sys.mjs b/src/zen/sync/ZenSyncManager.sys.mjs
new file mode 100644
index 00000000000..1b454da8166
--- /dev/null
+++ b/src/zen/sync/ZenSyncManager.sys.mjs
@@ -0,0 +1,160 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of t... | [
"src/zen/sync/ZenSyncManager.sys.mjs"
] | [
{
"comment": "Incoming container records use `container.userContextId` directly for `ContextualIdentityService.update(...)` without validating/coercing it to a finite integer. If Sync data provides a string/NaN/missing ID, this can throw or corrupt state. Normalize and validate `userContextId` before calling `u... | true | ||
zen-browser/desktop | 13,598 | comment_to_fix | Add space and container sync | The comment says this tracking is to "notify observers for only the reordered workspace", but the loop notifies for every workspace whose position changed (which can be multiple items). Update the comment to match the actual behavior (or adjust the logic if only one notification is intended). | 818c448dfc3ed7507e9055c538fa2a05ecb6a6aa | 1ac926bea21e0ea1482583196d427fb08ef8d73c | diff --git a/src/zen/spaces/ZenSpaceManager.mjs b/src/zen/spaces/ZenSpaceManager.mjs
index a97dd097814..54e1e2d1dd0 100644
--- a/src/zen/spaces/ZenSpaceManager.mjs
+++ b/src/zen/spaces/ZenSpaceManager.mjs
@@ -11,6 +11,7 @@ const lazy = {};
ChromeUtils.defineESModuleGetters(lazy, {
ZenSessionStore: "resource:///mo... | [
"src/zen/spaces/ZenSpaceManager.mjs"
] | [
{
"comment": "The comment says this tracking is to \"notify observers for only the reordered workspace\", but the loop notifies for every workspace whose position changed (which can be multiple items). Update the comment to match the actual behavior (or adjust the logic if only one notification is intended).",
... | true | ||
zen-browser/desktop | 13,598 | comment_to_fix | Add space and container sync | `ContextualIdentityService.create(..., id)` uses the provided `id` as-is once it’s non-null/undefined. If callers pass a string, NaN, or a non-integer, this can create identities with a non-numeric `userContextId` and/or poison `_lastUserContextId` via `Math.max`. Coerce `id` to a finite integer and enforce the valid r... | 818c448dfc3ed7507e9055c538fa2a05ecb6a6aa | 1ac926bea21e0ea1482583196d427fb08ef8d73c | diff --git a/src/toolkit/components/contextualidentity/ContextualIdentityService-sys-mjs.patch b/src/toolkit/components/contextualidentity/ContextualIdentityService-sys-mjs.patch
new file mode 100644
index 00000000000..1b108254d1f
--- /dev/null
+++ b/src/toolkit/components/contextualidentity/ContextualIdentityService-s... | [
"src/toolkit/components/contextualidentity/ContextualIdentityService-sys-mjs.patch"
] | [
{
"comment": "`ContextualIdentityService.create(..., id)` uses the provided `id` as-is once it’s non-null/undefined. If callers pass a string, NaN, or a non-integer, this can create identities with a non-numeric `userContextId` and/or poison `_lastUserContextId` via `Math.max`. Coerce `id` to a finite integer a... | true | ||
zen-browser/desktop | 13,598 | comment_to_fix | Add space and container sync | What if the most recent window is private or blank?
you could use `lazy.ZenWindowSync.firstSyncedWindow` | 818c448dfc3ed7507e9055c538fa2a05ecb6a6aa | 1ac926bea21e0ea1482583196d427fb08ef8d73c | diff --git a/src/zen/sync/ZenSyncManager.sys.mjs b/src/zen/sync/ZenSyncManager.sys.mjs
new file mode 100644
index 00000000000..1b454da8166
--- /dev/null
+++ b/src/zen/sync/ZenSyncManager.sys.mjs
@@ -0,0 +1,160 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of t... | [
"src/zen/sync/ZenSyncManager.sys.mjs"
] | [
{
"comment": "What if the most recent window is private or blank?\n\nyou could use `lazy.ZenWindowSync.firstSyncedWindow`",
"path": "src/zen/sync/ZenSyncManager.sys.mjs",
"hunk": "@@ -0,0 +1,146 @@\n+/* This Source Code Form is subject to the terms of the Mozilla Public\n+ * License, v. 2.0. If a copy o... | true | ||
zen-browser/desktop | 13,598 | comment_to_fix | Add space and container sync | Note that this create a new copy each time | 818c448dfc3ed7507e9055c538fa2a05ecb6a6aa | 1ac926bea21e0ea1482583196d427fb08ef8d73c | diff --git a/src/zen/sessionstore/ZenSessionManager.sys.mjs b/src/zen/sessionstore/ZenSessionManager.sys.mjs
index 39f2d0eb269..bccec81c60a 100644
--- a/src/zen/sessionstore/ZenSessionManager.sys.mjs
+++ b/src/zen/sessionstore/ZenSessionManager.sys.mjs
@@ -10,6 +10,7 @@ const lazy = {};
ChromeUtils.defineESModuleGette... | [
"src/zen/sessionstore/ZenSessionManager.sys.mjs"
] | [
{
"comment": "Note that this create a new copy each time",
"path": "src/zen/sessionstore/ZenSessionManager.sys.mjs",
"hunk": "@@ -622,6 +624,14 @@ export class nsZenSessionManager {\n this.log(`Saving Zen session data with ${sidebar.tabs?.length || 0} tabs`);\n }\n \n+ /**\n+ * Returns the side... | true | ||
zen-browser/desktop | 13,598 | comment_to_fix | Add space and container sync | Why not make it just a map? `{id: type}` | 818c448dfc3ed7507e9055c538fa2a05ecb6a6aa | 1ac926bea21e0ea1482583196d427fb08ef8d73c | diff --git a/src/zen/sync/ZenSyncManager.sys.mjs b/src/zen/sync/ZenSyncManager.sys.mjs
new file mode 100644
index 00000000000..1b454da8166
--- /dev/null
+++ b/src/zen/sync/ZenSyncManager.sys.mjs
@@ -0,0 +1,160 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of t... | [
"src/zen/sync/ZenSyncManager.sys.mjs"
] | [
{
"comment": "Why not make it just a map? `{id: type}`",
"path": "src/zen/sync/ZenSyncManager.sys.mjs",
"hunk": "@@ -0,0 +1,163 @@\n+/* This Source Code Form is subject to the terms of the Mozilla Public\n+ * License, v. 2.0. If a copy of the MPL was not distributed with this\n+ * file, You can obtain o... | true | ||
zen-browser/desktop | 13,598 | comment_to_fix | Add space and container sync | Incoming sync changes are only applied to the most recently focused browser window via `Services.wm.getMostRecentWindow("navigator:browser")`. Other open browser windows will not have their workspace UI updated until they are refocused/reopened, leaving their `_workspaceCache` and DOM in a stale, inconsistent state rel... | 818c448dfc3ed7507e9055c538fa2a05ecb6a6aa | 1ac926bea21e0ea1482583196d427fb08ef8d73c | diff --git a/src/zen/sync/ZenSyncManager.sys.mjs b/src/zen/sync/ZenSyncManager.sys.mjs
new file mode 100644
index 00000000000..1b454da8166
--- /dev/null
+++ b/src/zen/sync/ZenSyncManager.sys.mjs
@@ -0,0 +1,160 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of t... | [
"src/zen/sync/ZenSyncManager.sys.mjs"
] | [
{
"comment": "Incoming sync changes are only applied to the most recently focused browser window via `Services.wm.getMostRecentWindow(\"navigator:browser\")`. Other open browser windows will not have their workspace UI updated until they are refocused/reopened, leaving their `_workspaceCache` and DOM in a stale... | true | ||
zen-browser/desktop | 13,598 | comment_to_fix | Add space and container sync | `parseRecordId` falls back to using the raw prefix string as the `type` when the prefix is not in `RECORD_TYPE_BY_PREFIX` (`RECORD_TYPE_BY_PREFIX[prefix] || prefix`). For unknown/future record types this produces a misleading record where `type` is, e.g., `"x"` rather than something clearly invalid. Downstream `switch`... | 818c448dfc3ed7507e9055c538fa2a05ecb6a6aa | 1ac926bea21e0ea1482583196d427fb08ef8d73c | diff --git a/src/zen/sync/ZenWorkspacesSync.sys.mjs b/src/zen/sync/ZenWorkspacesSync.sys.mjs
new file mode 100644
index 00000000000..175319169aa
--- /dev/null
+++ b/src/zen/sync/ZenWorkspacesSync.sys.mjs
@@ -0,0 +1,404 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a ... | [
"src/zen/sync/ZenWorkspacesSync.sys.mjs"
] | [
{
"comment": "`parseRecordId` falls back to using the raw prefix string as the `type` when the prefix is not in `RECORD_TYPE_BY_PREFIX` (`RECORD_TYPE_BY_PREFIX[prefix] || prefix`). For unknown/future record types this produces a misleading record where `type` is, e.g., `\"x\"` rather than something clearly inva... | true | ||
zen-browser/desktop | 13,598 | comment_to_fix | Add space and container sync | The container observer relies on `subject?.wrappedJSObject?.userContextId`, but the `contextual-identity-deleted` notification in `ContextualIdentityService` passes the removed identity wrapped as a property-bag; in practice the deleted topic is fired after `remove`, and the subject may be a different shape than create... | 818c448dfc3ed7507e9055c538fa2a05ecb6a6aa | 1ac926bea21e0ea1482583196d427fb08ef8d73c | diff --git a/src/zen/sync/ZenWorkspacesSync.sys.mjs b/src/zen/sync/ZenWorkspacesSync.sys.mjs
new file mode 100644
index 00000000000..175319169aa
--- /dev/null
+++ b/src/zen/sync/ZenWorkspacesSync.sys.mjs
@@ -0,0 +1,404 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a ... | [
"src/zen/sync/ZenWorkspacesSync.sys.mjs"
] | [
{
"comment": "The container observer relies on `subject?.wrappedJSObject?.userContextId`, but the `contextual-identity-deleted` notification in `ContextualIdentityService` passes the removed identity wrapped as a property-bag; in practice the deleted topic is fired after `remove`, and the subject may be a diffe... | true | ||
zen-browser/desktop | 13,598 | comment_to_fix | Add space and container sync | When `firstSyncedWindow` is null (e.g., during early startup, when all windows are closed/private, or while no browser window has finished initializing) incoming space `pulled`/`removals` are silently dropped — `_applySyncChanges` is never invoked and nothing else in this path persists the workspace data to the session... | 818c448dfc3ed7507e9055c538fa2a05ecb6a6aa | 1ac926bea21e0ea1482583196d427fb08ef8d73c | diff --git a/src/zen/sync/ZenSyncManager.sys.mjs b/src/zen/sync/ZenSyncManager.sys.mjs
new file mode 100644
index 00000000000..1b454da8166
--- /dev/null
+++ b/src/zen/sync/ZenSyncManager.sys.mjs
@@ -0,0 +1,160 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of t... | [
"src/zen/sync/ZenSyncManager.sys.mjs"
] | [
{
"comment": "When `firstSyncedWindow` is null (e.g., during early startup, when all windows are closed/private, or while no browser window has finished initializing) incoming space `pulled`/`removals` are silently dropped — `_applySyncChanges` is never invoked and nothing else in this path persists the workspa... | true | ||
zen-browser/desktop | 13,598 | comment_to_fix | Add space and container sync | The patched `create(name, icon, color, id = null)` still uses `id` directly as `userContextId` once the existence check passes, without validating that it is a finite integer within the allowed range (e.g., `< MAX_USER_CONTEXT_ID`, integer, positive). While the current in-tree callers in `ZenSyncManager` normalize via ... | 818c448dfc3ed7507e9055c538fa2a05ecb6a6aa | 1ac926bea21e0ea1482583196d427fb08ef8d73c | diff --git a/src/toolkit/components/contextualidentity/ContextualIdentityService-sys-mjs.patch b/src/toolkit/components/contextualidentity/ContextualIdentityService-sys-mjs.patch
new file mode 100644
index 00000000000..1b108254d1f
--- /dev/null
+++ b/src/toolkit/components/contextualidentity/ContextualIdentityService-s... | [
"src/toolkit/components/contextualidentity/ContextualIdentityService-sys-mjs.patch"
] | [
{
"comment": "The patched `create(name, icon, color, id = null)` still uses `id` directly as `userContextId` once the existence check passes, without validating that it is a finite integer within the allowed range (e.g., `< MAX_USER_CONTEXT_ID`, integer, positive). While the current in-tree callers in `ZenSyncM... | true | ||
zen-browser/desktop | 13,598 | comment_to_fix | Add space and container sync | ```suggestion
this.getWorkspaces()
``` | 818c448dfc3ed7507e9055c538fa2a05ecb6a6aa | 1ac926bea21e0ea1482583196d427fb08ef8d73c | diff --git a/src/zen/spaces/ZenSpaceManager.mjs b/src/zen/spaces/ZenSpaceManager.mjs
index a97dd097814..54e1e2d1dd0 100644
--- a/src/zen/spaces/ZenSpaceManager.mjs
+++ b/src/zen/spaces/ZenSpaceManager.mjs
@@ -11,6 +11,7 @@ const lazy = {};
ChromeUtils.defineESModuleGetters(lazy, {
ZenSessionStore: "resource:///mo... | [
"src/zen/spaces/ZenSpaceManager.mjs"
] | [
{
"comment": "```suggestion\n this.getWorkspaces()\n```",
"path": "src/zen/spaces/ZenSpaceManager.mjs",
"hunk": "@@ -170,6 +171,63 @@ class nsZenWorkspaces {\n }\n }\n \n+ /**\n+ * Applies live sync changes: updates workspace cache, removes deleted items,\n+ * then creates/updates pull... | true | ||
zen-browser/desktop | 13,598 | comment_to_fix | Add space and container sync | I remember we planned on removing the return statement completly? | 818c448dfc3ed7507e9055c538fa2a05ecb6a6aa | 1ac926bea21e0ea1482583196d427fb08ef8d73c | diff --git a/src/zen/spaces/ZenSpaceManager.mjs b/src/zen/spaces/ZenSpaceManager.mjs
index a97dd097814..54e1e2d1dd0 100644
--- a/src/zen/spaces/ZenSpaceManager.mjs
+++ b/src/zen/spaces/ZenSpaceManager.mjs
@@ -11,6 +11,7 @@ const lazy = {};
ChromeUtils.defineESModuleGetters(lazy, {
ZenSessionStore: "resource:///mo... | [
"src/zen/spaces/ZenSpaceManager.mjs"
] | [
{
"comment": "I remember we planned on removing the return statement completly?",
"path": "src/zen/spaces/ZenSpaceManager.mjs",
"hunk": "@@ -722,8 +780,7 @@ class nsZenWorkspaces {\n ]);\n \n this._workspaceBookmarksCache = { bookmarks, lastChangeTimestamp };\n-\n- return this._workspaceCache... | true | ||
zen-browser/desktop | 13,598 | comment_to_fix | Add space and container sync | ```suggestion
const workspaces = this.getWorkspaces();
``` | 818c448dfc3ed7507e9055c538fa2a05ecb6a6aa | 1ac926bea21e0ea1482583196d427fb08ef8d73c | diff --git a/src/zen/spaces/ZenSpaceManager.mjs b/src/zen/spaces/ZenSpaceManager.mjs
index a97dd097814..54e1e2d1dd0 100644
--- a/src/zen/spaces/ZenSpaceManager.mjs
+++ b/src/zen/spaces/ZenSpaceManager.mjs
@@ -11,6 +11,7 @@ const lazy = {};
ChromeUtils.defineESModuleGetters(lazy, {
ZenSessionStore: "resource:///mo... | [
"src/zen/spaces/ZenSpaceManager.mjs"
] | [
{
"comment": "```suggestion\n const workspaces = this.getWorkspaces();\n```",
"path": "src/zen/spaces/ZenSpaceManager.mjs",
"hunk": "@@ -1367,30 +1434,51 @@ class nsZenWorkspaces {\n if (this.privateWindowOrDisabled) {\n return;\n }\n- const workspaces = this._workspaceCache;\n+\n+ ... | true | ||
zen-browser/desktop | 13,598 | comment_to_fix | Add space and container sync | Why wouldn't the element exist? | 818c448dfc3ed7507e9055c538fa2a05ecb6a6aa | 1ac926bea21e0ea1482583196d427fb08ef8d73c | diff --git a/src/zen/spaces/ZenSpaceManager.mjs b/src/zen/spaces/ZenSpaceManager.mjs
index a97dd097814..54e1e2d1dd0 100644
--- a/src/zen/spaces/ZenSpaceManager.mjs
+++ b/src/zen/spaces/ZenSpaceManager.mjs
@@ -11,6 +11,7 @@ const lazy = {};
ChromeUtils.defineESModuleGetters(lazy, {
ZenSessionStore: "resource:///mo... | [
"src/zen/spaces/ZenSpaceManager.mjs"
] | [
{
"comment": "Why wouldn't the element exist?",
"path": "src/zen/spaces/ZenSpaceManager.mjs",
"hunk": "@@ -1767,9 +1855,11 @@ class nsZenWorkspaces {\n workspaces[workspaceIndex + (offsetPixels > 0 ? -1 : 1)]?.containerTabId;\n for (const otherWorkspace of workspaces) {\n const element =... | true | ||
zen-browser/desktop | 13,598 | comment_to_fix | Add space and container sync | formatting | 818c448dfc3ed7507e9055c538fa2a05ecb6a6aa | 1ac926bea21e0ea1482583196d427fb08ef8d73c | diff --git a/src/zen/sync/ZenSyncManager.sys.mjs b/src/zen/sync/ZenSyncManager.sys.mjs
new file mode 100644
index 00000000000..1b454da8166
--- /dev/null
+++ b/src/zen/sync/ZenSyncManager.sys.mjs
@@ -0,0 +1,160 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of t... | [
"src/zen/sync/ZenSyncManager.sys.mjs"
] | [
{
"comment": "formatting",
"path": "src/zen/sync/ZenSyncManager.sys.mjs",
"hunk": "@@ -0,0 +1,159 @@\n+/* This Source Code Form is subject to the terms of the Mozilla Public\n+ * License, v. 2.0. If a copy of the MPL was not distributed with this\n+ * file, You can obtain one at http://mozilla.org/MPL/2... | true | ||
zen-browser/desktop | 13,598 | comment_to_fix | Add space and container sync | Pretty sure firstSyncedWindow already checks for privateWindowOrDisabled | 818c448dfc3ed7507e9055c538fa2a05ecb6a6aa | 1ac926bea21e0ea1482583196d427fb08ef8d73c | diff --git a/src/zen/sync/ZenSyncManager.sys.mjs b/src/zen/sync/ZenSyncManager.sys.mjs
new file mode 100644
index 00000000000..1b454da8166
--- /dev/null
+++ b/src/zen/sync/ZenSyncManager.sys.mjs
@@ -0,0 +1,160 @@
+/* This Source Code Form is subject to the terms of the Mozilla Public
+ * License, v. 2.0. If a copy of t... | [
"src/zen/sync/ZenSyncManager.sys.mjs"
] | [
{
"comment": "Pretty sure firstSyncedWindow already checks for privateWindowOrDisabled",
"path": "src/zen/sync/ZenSyncManager.sys.mjs",
"hunk": "@@ -0,0 +1,159 @@\n+/* This Source Code Form is subject to the terms of the Mozilla Public\n+ * License, v. 2.0. If a copy of the MPL was not distributed with ... | true |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.