title stringlengths 1 185 | diff stringlengths 0 32.2M | body stringlengths 0 123k ⌀ | url stringlengths 57 58 | created_at stringlengths 20 20 | closed_at stringlengths 20 20 | merged_at stringlengths 20 20 ⌀ | updated_at stringlengths 20 20 |
|---|---|---|---|---|---|---|---|
Backport PR #29010 on branch 0.25.x (Setuptools CI fixup) | diff --git a/ci/setup_env.sh b/ci/setup_env.sh
index 02e48f6cb9af1..1834b9674d898 100755
--- a/ci/setup_env.sh
+++ b/ci/setup_env.sh
@@ -55,6 +55,7 @@ echo
echo "update conda"
conda config --set ssl_verify false
conda config --set quiet true --set always_yes true --set changeps1 false
+conda install pip # create co... | Backport PR #29010: Setuptools CI fixup | https://api.github.com/repos/pandas-dev/pandas/pulls/29015 | 2019-10-15T21:38:04Z | 2019-10-16T12:37:34Z | 2019-10-16T12:37:34Z | 2019-10-16T12:37:35Z |
CLN: Fix typing in pandas\tests\arrays\test_datetimelike.py (#28926) | diff --git a/pandas/tests/arrays/test_datetimelike.py b/pandas/tests/arrays/test_datetimelike.py
index 7c482664bca48..117a19acbfc3a 100644
--- a/pandas/tests/arrays/test_datetimelike.py
+++ b/pandas/tests/arrays/test_datetimelike.py
@@ -1,3 +1,5 @@
+from typing import Type, Union
+
import numpy as np
import pytest
... | - [x] partially adresses #28926
- [x] passes `black pandas`
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
| https://api.github.com/repos/pandas-dev/pandas/pulls/29014 | 2019-10-15T21:32:37Z | 2019-10-23T00:52:51Z | 2019-10-23T00:52:51Z | 2019-10-23T06:01:37Z |
TST: restore xfail for test_apply | diff --git a/pandas/tests/groupby/test_categorical.py b/pandas/tests/groupby/test_categorical.py
index 2831c07cb21d3..5391cb5ce821f 100644
--- a/pandas/tests/groupby/test_categorical.py
+++ b/pandas/tests/groupby/test_categorical.py
@@ -4,7 +4,7 @@
import numpy as np
import pytest
-from pandas.compat import PY37, i... | xref https://github.com/MacPython/pandas-wheels/pull/64 | https://api.github.com/repos/pandas-dev/pandas/pulls/29013 | 2019-10-15T20:57:05Z | 2019-10-16T12:25:42Z | 2019-10-16T12:25:41Z | 2019-10-16T15:23:34Z |
Remove to original callable | diff --git a/scripts/validate_docstrings.py b/scripts/validate_docstrings.py
index 1d0f4b583bd0c..95f3392011d3f 100755
--- a/scripts/validate_docstrings.py
+++ b/scripts/validate_docstrings.py
@@ -17,7 +17,6 @@
import ast
import collections
import doctest
-import functools
import glob
import importlib
import insp... | - [x] tests passed
- [x] passes `black pandas`
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
@datapythonista This is the pull request for replacing to_original_callable | https://api.github.com/repos/pandas-dev/pandas/pulls/29012 | 2019-10-15T20:49:20Z | 2019-11-07T23:22:50Z | null | 2019-11-07T23:22:50Z |
Setuptools CI fixup | diff --git a/ci/setup_env.sh b/ci/setup_env.sh
index be8c3645691fe..794130355fd74 100755
--- a/ci/setup_env.sh
+++ b/ci/setup_env.sh
@@ -55,6 +55,7 @@ echo
echo "update conda"
conda config --set ssl_verify false
conda config --set quiet true --set always_yes true --set changeps1 false
+conda install pip # create co... | Closes https://github.com/pandas-dev/pandas/issues/29008 | https://api.github.com/repos/pandas-dev/pandas/pulls/29010 | 2019-10-15T20:08:49Z | 2019-10-15T21:37:41Z | 2019-10-15T21:37:40Z | 2019-10-15T21:37:45Z |
CI: troubleshoot RemoveError: 'setuptools' is a dependency of conda | diff --git a/ci/deps/azure-35-compat.yaml b/ci/deps/azure-35-compat.yaml
index dd54001984ec7..db616fc6e9421 100644
--- a/ci/deps/azure-35-compat.yaml
+++ b/ci/deps/azure-35-compat.yaml
@@ -22,7 +22,7 @@ dependencies:
- pytest-xdist
- pytest-mock
- pytest-azurepipelines
- - pip
+ - pip=19.2.3
- pip:
#... | - [ ] closes #29008
- [ ] tests added / passed
- [ ] passes `black pandas`
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry
| https://api.github.com/repos/pandas-dev/pandas/pulls/29009 | 2019-10-15T19:36:00Z | 2019-10-15T19:54:33Z | null | 2019-10-15T19:54:33Z |
CLN: Fix mypy error in 'pandas/tests/computation/test_eval.py' | diff --git a/pandas/tests/computation/test_eval.py b/pandas/tests/computation/test_eval.py
index b6ffd8a83e409..4d40cd3a2d4ca 100644
--- a/pandas/tests/computation/test_eval.py
+++ b/pandas/tests/computation/test_eval.py
@@ -2,6 +2,7 @@
from functools import reduce
from itertools import product
import operator
+from... | Added explicit typing annotation for _parsers: Dict[str, Type[BaseExprVisitor]]
Also added some import for Dict, Type and BaseExprVisitor
- [x] relates to #28926
- [x] tests added / passed
- [x] passes `black pandas`
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry
| https://api.github.com/repos/pandas-dev/pandas/pulls/29007 | 2019-10-15T17:15:07Z | 2019-10-16T18:43:33Z | 2019-10-16T18:43:32Z | 2019-10-16T18:43:39Z |
CLN: Fix mypy errors in pandas/tests/io/test_sql.py Reverted and added type changes | diff --git a/pandas/tests/io/test_sql.py b/pandas/tests/io/test_sql.py
index 7491cef17ebfc..183a47c6039ec 100644
--- a/pandas/tests/io/test_sql.py
+++ b/pandas/tests/io/test_sql.py
@@ -583,7 +583,7 @@ class _TestSQLApi(PandasSQLTest):
"""
flavor = "sqlite"
- mode = None
+ mode = None # type: str
... | - [ ] tests added / passed
- [x] passes `black pandas`
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
ref closed PR #28979 | https://api.github.com/repos/pandas-dev/pandas/pulls/29006 | 2019-10-15T16:13:25Z | 2019-10-16T03:47:07Z | 2019-10-16T03:47:07Z | 2019-10-16T03:47:16Z |
Backport PR #29000 on branch 0.25.x | diff --git a/doc/source/whatsnew/v0.25.2.rst b/doc/source/whatsnew/v0.25.2.rst
index 59aedd2c5e8e6..35229591ecfae 100644
--- a/doc/source/whatsnew/v0.25.2.rst
+++ b/doc/source/whatsnew/v0.25.2.rst
@@ -1,6 +1,6 @@
.. _whatsnew_0252:
-What's new in 0.25.2 (October XX, 2019)
+What's new in 0.25.2 (October 15, 2019)
--... | https://api.github.com/repos/pandas-dev/pandas/pulls/29005 | 2019-10-15T13:54:10Z | 2019-10-15T15:21:34Z | 2019-10-15T15:21:34Z | 2019-10-15T15:22:50Z | |
fix is_scalar documentation (#28998) | diff --git a/pandas/_libs/lib.pyx b/pandas/_libs/lib.pyx
index 1c2f80b832201..5761f1ffb0c0a 100644
--- a/pandas/_libs/lib.pyx
+++ b/pandas/_libs/lib.pyx
@@ -137,8 +137,8 @@ def is_scalar(val: object) -> bool:
Examples
--------
- >>> dt = pd.datetime.datetime(2018, 10, 3)
- >>> pd.is_scalar(dt)
+ >>... | - [x] closes #28998
- [ ] tests added / passed
- [x] passes `black pandas`
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry
is_scalar documentation was wrong, see #28998 | https://api.github.com/repos/pandas-dev/pandas/pulls/29004 | 2019-10-15T12:20:19Z | 2019-10-15T15:21:59Z | 2019-10-15T15:21:58Z | 2019-10-15T15:25:22Z |
Backport PR #28730 on branch 0.25.x (CI: 3.8 build) | diff --git a/.travis.yml b/.travis.yml
index 8335a6ee92bef..6465abb317c01 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -31,6 +31,12 @@ matrix:
- python: 3.5
include:
+ - dist: bionic
+ # 18.04
+ python: 3.8-dev
+ env:
+ - JOB="3.8-dev" PATTERN="(not slow and not network)"
+
... | Backport PR #28730: CI: 3.8 build | https://api.github.com/repos/pandas-dev/pandas/pulls/29002 | 2019-10-15T11:39:03Z | 2019-10-15T13:51:37Z | 2019-10-15T13:51:37Z | 2019-10-15T13:51:38Z |
DOC: 0.25.2 whatsnew cleanup | diff --git a/doc/source/whatsnew/v0.25.2.rst b/doc/source/whatsnew/v0.25.2.rst
index 73a5ac5f840be..a99751f9bab9f 100644
--- a/doc/source/whatsnew/v0.25.2.rst
+++ b/doc/source/whatsnew/v0.25.2.rst
@@ -1,6 +1,6 @@
.. _whatsnew_0252:
-What's new in 0.25.2 (October XX, 2019)
+What's new in 0.25.2 (October 15, 2019)
--... | https://api.github.com/repos/pandas-dev/pandas/pulls/29000 | 2019-10-15T11:36:22Z | 2019-10-15T13:51:07Z | 2019-10-15T13:51:07Z | 2019-10-15T13:51:58Z | |
Backport PR #28982 on branch 0.25.x (Document 3.8 compatibility) | diff --git a/ci/deps/azure-36-32bit.yaml b/ci/deps/azure-36-32bit.yaml
index 321cc203961d5..1e2e6c33e8c15 100644
--- a/ci/deps/azure-36-32bit.yaml
+++ b/ci/deps/azure-36-32bit.yaml
@@ -3,6 +3,7 @@ channels:
- defaults
- conda-forge
dependencies:
+ - attrs=19.1.0
- gcc_linux-32
- gcc_linux-32
- gxx_linu... | Backport PR #28982: Document 3.8 compatibility | https://api.github.com/repos/pandas-dev/pandas/pulls/28999 | 2019-10-15T11:32:17Z | 2019-10-15T13:50:33Z | 2019-10-15T13:50:33Z | 2019-10-15T13:50:33Z |
CLN: Type error fix in tests\tseries\offsets\test_yqm_offsets.py | diff --git a/pandas/tests/tseries/offsets/test_offsets.py b/pandas/tests/tseries/offsets/test_offsets.py
index ddf2c6e65b474..5cc10bf00203d 100644
--- a/pandas/tests/tseries/offsets/test_offsets.py
+++ b/pandas/tests/tseries/offsets/test_offsets.py
@@ -1,4 +1,5 @@
from datetime import date, datetime, time as dt_time, ... | - [ ] xref #28926
- [ ] tests added / passed
- [ ] passes `black pandas`
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry
| https://api.github.com/repos/pandas-dev/pandas/pulls/28996 | 2019-10-15T09:47:22Z | 2019-10-22T00:36:48Z | 2019-10-22T00:36:48Z | 2019-10-22T00:36:55Z |
CLN: tests/extension/json/test_json.py typefix | diff --git a/pandas/tests/extension/base/base.py b/pandas/tests/extension/base/base.py
index 2f808d20acd31..0a8628b8ef705 100644
--- a/pandas/tests/extension/base/base.py
+++ b/pandas/tests/extension/base/base.py
@@ -2,8 +2,10 @@
class BaseExtensionTests:
+ @staticmethod
+ def assert_series_equal(left, right... | The error is due to the fact that the builtins.staticmethod type defined in extension.base.base.BaseExtensionTests does not match the function type in extension.json.test_json.BaseJSON. I don't see a possibility for a proper type hint fix without changing the structure of the code. One way would be to replace the call ... | https://api.github.com/repos/pandas-dev/pandas/pulls/28994 | 2019-10-15T09:24:51Z | 2020-02-09T18:08:29Z | null | 2020-02-09T18:08:30Z |
ENH: Informative dtype message for for assert_series_equal | diff --git a/pandas/tests/util/test_assert_frame_equal.py b/pandas/tests/util/test_assert_frame_equal.py
index 9571e8027ccf7..86e5d506e0779 100644
--- a/pandas/tests/util/test_assert_frame_equal.py
+++ b/pandas/tests/util/test_assert_frame_equal.py
@@ -141,7 +141,7 @@ def test_empty_dtypes(check_dtype):
df1["col1"... | Pass obj to assert_attr_equal in assert_series_equal.
- [ ] closes #28991
- [x] tests added / passed
- [x] passes `black pandas`
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry
- [x] Fix example in `assert_frame_equal` docstring | https://api.github.com/repos/pandas-dev/pandas/pulls/28993 | 2019-10-15T09:18:26Z | 2019-10-18T17:28:58Z | 2019-10-18T17:28:58Z | 2021-03-08T11:19:23Z |
tests/indexing/test_coercion.py typefix | diff --git a/pandas/tests/indexing/test_coercion.py b/pandas/tests/indexing/test_coercion.py
index 05b58b0eca9b8..4f38d7beb9c0b 100644
--- a/pandas/tests/indexing/test_coercion.py
+++ b/pandas/tests/indexing/test_coercion.py
@@ -1,4 +1,5 @@
import itertools
+from typing import Dict, List
import numpy as np
import ... | - [ ] xref #28926
- [ ] tests added / passed
- [ ] passes `black pandas`
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry
| https://api.github.com/repos/pandas-dev/pandas/pulls/28990 | 2019-10-15T08:10:48Z | 2019-10-16T23:52:14Z | 2019-10-16T23:52:14Z | 2019-10-16T23:52:20Z |
pandas-dev#28926 Mypy fix/extension json array | diff --git a/pandas/tests/extension/json/array.py b/pandas/tests/extension/json/array.py
index b64ddbd6ac84d..94bef0617df3c 100644
--- a/pandas/tests/extension/json/array.py
+++ b/pandas/tests/extension/json/array.py
@@ -16,6 +16,7 @@
import random
import string
import sys
+from typing import Mapping
import numpy... | ref: #28926
- [ ] tests added / passed
- [x] passes `black pandas`
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
| https://api.github.com/repos/pandas-dev/pandas/pulls/28989 | 2019-10-15T06:50:16Z | 2019-12-17T17:56:22Z | null | 2019-12-17T17:56:22Z |
mypy typing issues for decimal pandas/tests/extension/decimal/test_decimal.py | diff --git a/pandas/tests/extension/decimal/test_decimal.py b/pandas/tests/extension/decimal/test_decimal.py
index 3ac9d37ccf4f3..6d06ae61c5310 100644
--- a/pandas/tests/extension/decimal/test_decimal.py
+++ b/pandas/tests/extension/decimal/test_decimal.py
@@ -110,27 +110,27 @@ def assert_frame_equal(self, left, right,... | - [ ] xref #28926
- [ ] tests added / passed
- [x] passes `black pandas`
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry
| https://api.github.com/repos/pandas-dev/pandas/pulls/28988 | 2019-10-15T06:01:31Z | 2019-12-27T19:51:36Z | null | 2019-12-27T19:51:36Z |
Backport PR #28841: BUG: use EA.astype in ExtensionBlock.to_native_types (#28841) | diff --git a/doc/source/whatsnew/v0.25.2.rst b/doc/source/whatsnew/v0.25.2.rst
index 0fea95710d638..49e87b34482b8 100644
--- a/doc/source/whatsnew/v0.25.2.rst
+++ b/doc/source/whatsnew/v0.25.2.rst
@@ -65,7 +65,7 @@ I/O
- Fix regression in notebook display where <th> tags not used for :attr:`DataFrame.index` (:issue:... | https://api.github.com/repos/pandas-dev/pandas/pulls/28985 | 2019-10-15T02:38:13Z | 2019-10-15T13:17:18Z | 2019-10-15T13:17:18Z | 2019-10-15T13:17:18Z | |
CLN: Add type hinting to base classes (#28926) | diff --git a/pandas/tests/io/test_sql.py b/pandas/tests/io/test_sql.py
index 7491cef17ebfc..e7f10f1b5ab07 100644
--- a/pandas/tests/io/test_sql.py
+++ b/pandas/tests/io/test_sql.py
@@ -21,6 +21,7 @@
from datetime import date, datetime, time
from io import StringIO
import sqlite3
+from typing import Optional
import ... | - [x] partially addresses #28926
- [ ] tests added / passed
- [x] passes `black pandas`
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [N/A] whatsnew entry
| https://api.github.com/repos/pandas-dev/pandas/pulls/28983 | 2019-10-14T23:08:47Z | 2019-10-15T13:45:41Z | null | 2019-10-15T13:45:41Z |
Document 3.8 compatibility | diff --git a/doc/source/getting_started/install.rst b/doc/source/getting_started/install.rst
index fc99b458fa0af..7d1150c2f65fa 100644
--- a/doc/source/getting_started/install.rst
+++ b/doc/source/getting_started/install.rst
@@ -18,7 +18,7 @@ Instructions for installing from source,
Python version support
-----------... | Closes #28147 | https://api.github.com/repos/pandas-dev/pandas/pulls/28982 | 2019-10-14T21:46:18Z | 2019-10-15T11:31:52Z | 2019-10-15T11:31:52Z | 2019-10-15T11:31:55Z |
Mypy fix/io sql | - [ ] tests added / passed
- [x] passes `black pandas`
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
As part of this PR, did the following:
* Variable typing.
* Code cleanup and reformatting the imports.
* Internal class `_TestSQLAlchemyConn` behaves like an abstract class.
* To solve ... | https://api.github.com/repos/pandas-dev/pandas/pulls/28979 | 2019-10-14T18:38:42Z | 2019-10-15T15:51:20Z | null | 2019-10-15T16:14:25Z | |
CLN: declare types in rank_1d_, rank_2d | diff --git a/pandas/_libs/algos_rank_helper.pxi.in b/pandas/_libs/algos_rank_helper.pxi.in
index 5dac94394c7ed..1ba1667b687be 100644
--- a/pandas/_libs/algos_rank_helper.pxi.in
+++ b/pandas/_libs/algos_rank_helper.pxi.in
@@ -24,7 +24,7 @@ dtypes = [('object', 'object', 'Infinity()', 'NegInfinity()'),
@cython.wraparo... | This is necessary before we can move these functions to use fused types. | https://api.github.com/repos/pandas-dev/pandas/pulls/28978 | 2019-10-14T18:37:15Z | 2019-10-15T12:09:06Z | 2019-10-15T12:09:06Z | 2019-10-15T15:23:58Z |
CLN: remove unnecessary get_value_at calls | diff --git a/pandas/_libs/index.pyx b/pandas/_libs/index.pyx
index 979dad6db0838..22f7104debf10 100644
--- a/pandas/_libs/index.pyx
+++ b/pandas/_libs/index.pyx
@@ -41,11 +41,13 @@ cdef inline bint is_definitely_invalid_key(object val):
cpdef get_value_at(ndarray arr, object loc, object tz=None):
+ obj = util.g... | I found in another branch that these calls didn't play nicely with `nogil`, so went through and removed the ones that are unnecessary. Turns out we really only need the one in libindex.get_value_at, since that is the only place where we _arent_ assured that `loc` is intlike. | https://api.github.com/repos/pandas-dev/pandas/pulls/28977 | 2019-10-14T18:13:36Z | 2019-10-15T12:08:42Z | 2019-10-15T12:08:42Z | 2019-10-15T15:26:44Z |
Fix mypy error message in `pandas/tests/indexes/test_numeric.py` … | diff --git a/pandas/tests/indexes/common.py b/pandas/tests/indexes/common.py
index b657d8d16df81..1ac6370860ba6 100644
--- a/pandas/tests/indexes/common.py
+++ b/pandas/tests/indexes/common.py
@@ -1,4 +1,5 @@
import gc
+from typing import Optional, Type
import numpy as np
import pytest
@@ -30,7 +31,7 @@
class Bas... | Use Optional to signal that the value may be either an `Index` or `None`.
- [X] Relates to #28926
- [X] tests added / passed
- [X] passes `black pandas`
- [X] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry
| https://api.github.com/repos/pandas-dev/pandas/pulls/28976 | 2019-10-14T15:55:50Z | 2019-10-16T08:32:27Z | null | 2019-10-16T08:32:28Z |
PERF: Benchmark merge with non-int64 and tolerance (#28922) | diff --git a/asv_bench/benchmarks/join_merge.py b/asv_bench/benchmarks/join_merge.py
index 6aa82a43a4d6a..5cf9f6336ba0c 100644
--- a/asv_bench/benchmarks/join_merge.py
+++ b/asv_bench/benchmarks/join_merge.py
@@ -273,10 +273,10 @@ def time_merge_ordered(self):
class MergeAsof:
- params = [["backward", "forward"... | - [X] closes #28922
- [ ] tests added / passed
- [X] passes `black pandas`
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry | https://api.github.com/repos/pandas-dev/pandas/pulls/28974 | 2019-10-14T14:46:30Z | 2019-10-22T00:41:22Z | 2019-10-22T00:41:22Z | 2019-10-22T06:57:15Z |
CLN: pandas-dev#28926 Fix mypy errors in pandas/tests/io/parser/conftest.py | diff --git a/pandas/tests/io/parser/conftest.py b/pandas/tests/io/parser/conftest.py
index 2c347a096006a..183ad500b15f3 100644
--- a/pandas/tests/io/parser/conftest.py
+++ b/pandas/tests/io/parser/conftest.py
@@ -1,4 +1,5 @@
import os
+from typing import List, Optional
import pytest
@@ -6,9 +7,9 @@
class Bas... | - [ ] tests added / passed
- [x] passes `black pandas`
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
| https://api.github.com/repos/pandas-dev/pandas/pulls/28973 | 2019-10-14T12:08:20Z | 2019-10-15T12:30:28Z | 2019-10-15T12:30:28Z | 2019-10-15T12:34:01Z |
CLN: pandas-dev#28926 Fix pandas/tests/tseries/offsets/test_offsets_properties | diff --git a/pandas/tests/tseries/offsets/test_offsets_properties.py b/pandas/tests/tseries/offsets/test_offsets_properties.py
index 880ff1f137520..a05de78e299f7 100644
--- a/pandas/tests/tseries/offsets/test_offsets_properties.py
+++ b/pandas/tests/tseries/offsets/test_offsets_properties.py
@@ -36,8 +36,8 @@
with w... | …/teset_offsets_properties.py
- [ ] tests added / passed
- [x] passes `black pandas`
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
| https://api.github.com/repos/pandas-dev/pandas/pulls/28972 | 2019-10-14T11:01:31Z | 2019-10-15T12:20:16Z | 2019-10-15T12:20:15Z | 2019-10-15T12:33:28Z |
Fix mypy error messages in pandas/test/tseries/offsets/test_offsets.py | diff --git a/pandas/tests/tseries/offsets/test_offsets.py b/pandas/tests/tseries/offsets/test_offsets.py
index ddf2c6e65b474..e435a6846a77e 100644
--- a/pandas/tests/tseries/offsets/test_offsets.py
+++ b/pandas/tests/tseries/offsets/test_offsets.py
@@ -1,4 +1,5 @@
from datetime import date, datetime, time as dt_time, ... | - [ ] xref #28926
- [x] passes `black pandas`
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
| https://api.github.com/repos/pandas-dev/pandas/pulls/28971 | 2019-10-14T09:56:19Z | 2019-10-27T02:33:38Z | null | 2019-10-27T02:33:48Z |
fix #28926 mypy error in pandas\tests\arrays\test_array.py | diff --git a/pandas/core/arrays/period.py b/pandas/core/arrays/period.py
index a21d9e67e49e5..78cc54db4b1b8 100644
--- a/pandas/core/arrays/period.py
+++ b/pandas/core/arrays/period.py
@@ -831,7 +831,9 @@ def _raise_on_incompatible(left, right):
def period_array(
- data: Sequence[Optional[Period]], freq: Option... | - [ ] xref #28926
- [ ] tests added / passed
- [x] passes `black pandas`
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry
| https://api.github.com/repos/pandas-dev/pandas/pulls/28970 | 2019-10-14T08:52:52Z | 2019-10-21T11:57:29Z | 2019-10-21T11:57:28Z | 2019-10-21T11:57:40Z |
CLN: Exception in _libs | diff --git a/pandas/_libs/intervaltree.pxi.in b/pandas/_libs/intervaltree.pxi.in
index ac713a928973f..08bfaf21db9fb 100644
--- a/pandas/_libs/intervaltree.pxi.in
+++ b/pandas/_libs/intervaltree.pxi.in
@@ -158,7 +158,7 @@ cdef class IntervalTree(IntervalMixin):
# TODO: write get_indexer_intervals
cde... | I think this is the last of the ones in _libs.
Also fix some build warnings in interval.pyx | https://api.github.com/repos/pandas-dev/pandas/pulls/28967 | 2019-10-14T03:43:25Z | 2019-10-15T12:18:37Z | 2019-10-15T12:18:36Z | 2019-10-15T15:22:32Z |
TST: Add tests for num-bool coercion | diff --git a/pandas/tests/arithmetic/test_numeric.py b/pandas/tests/arithmetic/test_numeric.py
index 584e22f8488f5..bafd93fd67a9e 100644
--- a/pandas/tests/arithmetic/test_numeric.py
+++ b/pandas/tests/arithmetic/test_numeric.py
@@ -11,6 +11,7 @@
import pandas as pd
from pandas import Index, Series, Timedelta, Time... | Boolean dtypes in both Series and DataFrames should be coerced
to the other operand's dtype.
- [x] closes #18549
- [x] tests added / passed
- [x] passes `black pandas`
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry
| https://api.github.com/repos/pandas-dev/pandas/pulls/28966 | 2019-10-14T03:22:03Z | 2019-12-17T17:24:14Z | null | 2019-12-17T17:24:14Z |
Fix mypy errors for pandas\tests\*: test_convert_to.py | diff --git a/pandas/tests/frame/test_convert_to.py b/pandas/tests/frame/test_convert_to.py
index 3f0768ad5bdac..c9a7507969f5b 100644
--- a/pandas/tests/frame/test_convert_to.py
+++ b/pandas/tests/frame/test_convert_to.py
@@ -575,9 +575,9 @@ def test_frame_to_dict_tz(self):
),
),
... | - [x ] xref #28926
- [x ] tests added / passed
- [x ] passes `black pandas`
- [x ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [N/A ] whatsnew entry
| https://api.github.com/repos/pandas-dev/pandas/pulls/28965 | 2019-10-14T03:09:49Z | 2019-10-18T17:56:07Z | 2019-10-18T17:56:07Z | 2019-10-18T17:56:18Z |
TST: added test for df.loc modify datetime columns | diff --git a/pandas/tests/indexing/test_loc.py b/pandas/tests/indexing/test_loc.py
index 35291efecd1ac..5e517d556a095 100644
--- a/pandas/tests/indexing/test_loc.py
+++ b/pandas/tests/indexing/test_loc.py
@@ -712,6 +712,32 @@ def test_loc_assign_non_ns_datetime(self, unit):
expected = Series(df.loc[:, "expecte... | relevant GitHub issue #28837
- [x] closes #28837
- [x] tests added / passed
- [x] passes `black pandas`
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry
| https://api.github.com/repos/pandas-dev/pandas/pulls/28964 | 2019-10-14T02:48:18Z | 2019-10-29T06:02:28Z | 2019-10-29T06:02:28Z | 2019-10-29T06:02:44Z |
TST: added test for df.loc modify datetime columns | diff --git a/pandas/tests/indexing/test_loc.py b/pandas/tests/indexing/test_loc.py
index 35291efecd1ac..22997a29341b2 100644
--- a/pandas/tests/indexing/test_loc.py
+++ b/pandas/tests/indexing/test_loc.py
@@ -712,6 +712,17 @@ def test_loc_assign_non_ns_datetime(self, unit):
expected = Series(df.loc[:, "expecte... | relevant GitHub issue #28837
- [x] closes #28837
- [x] tests added / passed
- [x] passes `black pandas`
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry
| https://api.github.com/repos/pandas-dev/pandas/pulls/28963 | 2019-10-14T02:43:03Z | 2019-10-14T02:46:15Z | null | 2019-10-14T02:46:15Z |
CLN: move small bits outside of try/excepts | diff --git a/pandas/_libs/algos_take_helper.pxi.in b/pandas/_libs/algos_take_helper.pxi.in
index 3a3adc71875ed..f10061a417c03 100644
--- a/pandas/_libs/algos_take_helper.pxi.in
+++ b/pandas/_libs/algos_take_helper.pxi.in
@@ -276,7 +276,6 @@ cdef _take_2d(ndarray[take_t, ndim=2] values, object idx):
Py_ssize_t ... | https://api.github.com/repos/pandas-dev/pandas/pulls/28962 | 2019-10-14T02:15:28Z | 2019-10-16T12:21:57Z | 2019-10-16T12:21:56Z | 2019-10-16T15:25:52Z | |
CLN: fix mypy errors in pandas\tests\indexes\interval\test_base.py #28926 | diff --git a/pandas/tests/indexes/common.py b/pandas/tests/indexes/common.py
index b657d8d16df81..1ac6370860ba6 100644
--- a/pandas/tests/indexes/common.py
+++ b/pandas/tests/indexes/common.py
@@ -1,4 +1,5 @@
import gc
+from typing import Optional, Type
import numpy as np
import pytest
@@ -30,7 +31,7 @@
class Bas... | - [ ] xref #28926
- [ ] tests added / passed
- [ ] passes `black pandas`
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry
Hi! I based this change on what I saw in #28947. However, when I test this with `mypy pandas/tests/indexes/interval/test_base.py`, I get this error, w... | https://api.github.com/repos/pandas-dev/pandas/pulls/28961 | 2019-10-14T00:16:53Z | 2019-10-28T19:56:53Z | 2019-10-28T19:56:53Z | 2019-10-28T19:57:01Z |
Fix mypy errors for pandas\tests\* #28926 (test_algos.py) | diff --git a/pandas/tests/test_algos.py b/pandas/tests/test_algos.py
index a5706d8baa614..6df2c8faf7aee 100644
--- a/pandas/tests/test_algos.py
+++ b/pandas/tests/test_algos.py
@@ -767,7 +767,7 @@ def test_same_object_is_in(self):
# with similar behavior, then we at least should
# fall back to usual p... | - [x] xref #28926
- [x] tests added / passed (verified that tests still pass)
- [x] passes `black pandas`
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [N/A] whatsnew entry
| https://api.github.com/repos/pandas-dev/pandas/pulls/28960 | 2019-10-13T23:14:56Z | 2019-10-14T00:28:49Z | 2019-10-14T00:28:49Z | 2019-10-14T00:28:58Z |
REF: re-raise AssertionError unchanged | diff --git a/pandas/_libs/groupby.pyx b/pandas/_libs/groupby.pyx
index 3069bbbf34bb7..3f741f08d1363 100644
--- a/pandas/_libs/groupby.pyx
+++ b/pandas/_libs/groupby.pyx
@@ -441,7 +441,7 @@ def _group_add(floating[:, :] out,
floating[:, :] sumx, nobs
if len(values) != len(labels):
- raise Assertio... | This should be all the remaining places where we catch `Exception` in groupby/apply/resample code. This should make debugging much easier going forward.
cc @jreback @WillAyd | https://api.github.com/repos/pandas-dev/pandas/pulls/28959 | 2019-10-13T22:49:30Z | 2019-10-16T23:37:30Z | 2019-10-16T23:37:30Z | 2019-10-16T23:41:59Z |
CLN: Consistent and Annotated Return Type of _iterate_slices | diff --git a/pandas/core/frame.py b/pandas/core/frame.py
index 79e941f262931..c82d8a25fedba 100644
--- a/pandas/core/frame.py
+++ b/pandas/core/frame.py
@@ -14,7 +14,18 @@
import itertools
import sys
from textwrap import dedent
-from typing import FrozenSet, List, Optional, Sequence, Set, Tuple, Type, Union
+from ty... | General pre-cursor to getting block management out of groupby. This is also a pre-cursor to fixing #21668 but needs to be coupled with a few more changes as a follow up
On master calls to _iterate_slices look up by label, potentially yielding a DataFrame if there were duplicated columns. This takes the surprise out ... | https://api.github.com/repos/pandas-dev/pandas/pulls/28958 | 2019-10-13T21:47:03Z | 2019-10-16T12:24:47Z | 2019-10-16T12:24:47Z | 2020-01-16T00:33:45Z |
CLN: Clean DirNameMixin._deprecated | diff --git a/pandas/core/accessor.py b/pandas/core/accessor.py
index 2d4ded9e2e6ba..b863e7ef3d580 100644
--- a/pandas/core/accessor.py
+++ b/pandas/core/accessor.py
@@ -4,7 +4,7 @@
that can be mixed into or pinned onto other pandas classes.
"""
-from typing import Set
+from typing import FrozenSet, Set
import warn... | This moves the content of ``DirNameMixin._deprecations`` to more appropriate locations, typically ``IndexOpsMixIn._deprecations``, as that is a common subclass of ``Index`` and ``Series``. The names in ``DirNameMixin._deprecations`` belonged to those two classes, so having the deprecated names located all the way up in... | https://api.github.com/repos/pandas-dev/pandas/pulls/28957 | 2019-10-13T20:57:12Z | 2019-10-16T18:53:42Z | 2019-10-16T18:53:42Z | 2019-10-16T19:07:10Z |
To string with encoding | diff --git a/doc/source/whatsnew/v1.0.0.rst b/doc/source/whatsnew/v1.0.0.rst
index 7c86ad0f029ed..511e85929f352 100644
--- a/doc/source/whatsnew/v1.0.0.rst
+++ b/doc/source/whatsnew/v1.0.0.rst
@@ -109,6 +109,7 @@ Other enhancements
(:issue:`28368`)
- :meth:`DataFrame.to_json` now accepts an ``indent`` integer argum... | - [x] close #28766
- [x] tests added / passed
- [x] passes `black pandas`
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry
| https://api.github.com/repos/pandas-dev/pandas/pulls/28951 | 2019-10-13T06:12:47Z | 2019-10-23T17:48:08Z | 2019-10-23T17:48:08Z | 2019-10-23T17:50:48Z |
Change width of specific columns using col_space param in df.to_html | diff --git a/pandas/io/formats/format.py b/pandas/io/formats/format.py
index ad62c56a337b6..b5c95a0465340 100644
--- a/pandas/io/formats/format.py
+++ b/pandas/io/formats/format.py
@@ -532,7 +532,7 @@ def __init__(
self,
frame: "DataFrame",
columns: Optional[Sequence[str]] = None,
- co... | DataFrame.to_html col_space parameter to change width of a specific column only
- [ ] closes #28917
- [ ] tests added / passed
- [ ] passes `black pandas`
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry
| https://api.github.com/repos/pandas-dev/pandas/pulls/28950 | 2019-10-13T04:14:24Z | 2019-10-13T12:13:59Z | null | 2019-10-13T12:13:59Z |
WEB: Adding new pandas logo | diff --git a/web/pandas/_templates/layout.html b/web/pandas/_templates/layout.html
index fe3e4d1245d93..120058afd1190 100644
--- a/web/pandas/_templates/layout.html
+++ b/web/pandas/_templates/layout.html
@@ -12,6 +12,7 @@
<title>pandas - Python Data Analysis Library</title>
<meta charset="utf-8">
... | - [X] closes #21376, xref #28521
- [ ] tests added / passed
- [ ] passes `black pandas`
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry
| https://api.github.com/repos/pandas-dev/pandas/pulls/28948 | 2019-10-12T23:40:15Z | 2019-10-22T04:07:21Z | 2019-10-22T04:07:21Z | 2019-10-22T04:07:21Z |
CLN: fix mypy errors in pandas/tests/extension/test_numpy.py #28926 | diff --git a/pandas/tests/extension/base/ops.py b/pandas/tests/extension/base/ops.py
index e35464964f432..e968962caf0b7 100644
--- a/pandas/tests/extension/base/ops.py
+++ b/pandas/tests/extension/base/ops.py
@@ -1,4 +1,5 @@
import operator
+from typing import Optional, Type
import pytest
@@ -61,10 +62,10 @@ clas... | - [ ] xref #28926
- [ ] tests added / passed
- [ ] passes `black pandas`
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry
| https://api.github.com/repos/pandas-dev/pandas/pulls/28947 | 2019-10-12T22:12:36Z | 2019-10-13T15:58:58Z | 2019-10-13T15:58:58Z | 2019-10-13T15:59:05Z |
PR06 doc string fixes | diff --git a/pandas/core/computation/eval.py b/pandas/core/computation/eval.py
index 8614230c4811f..63344af63470f 100644
--- a/pandas/core/computation/eval.py
+++ b/pandas/core/computation/eval.py
@@ -198,14 +198,14 @@ def eval(
<https://docs.python.org/3/reference/simple_stmts.html#simple-statements>`__,
... | This PR contains doctrine PR06 fixes mostly doing the conversion below(not that many left to fix :)):
boolean to bool
string to str
integer to int
Tests unchanged
black pandas ran successfully | https://api.github.com/repos/pandas-dev/pandas/pulls/28946 | 2019-10-12T22:07:20Z | 2019-10-13T19:07:57Z | 2019-10-13T19:07:57Z | 2019-10-13T19:08:21Z |
BUG: Fix comparison between nullable int and string | diff --git a/doc/source/whatsnew/v1.0.0.rst b/doc/source/whatsnew/v1.0.0.rst
index 38051e9772ae9..08253c160d408 100644
--- a/doc/source/whatsnew/v1.0.0.rst
+++ b/doc/source/whatsnew/v1.0.0.rst
@@ -838,6 +838,7 @@ ExtensionArray
^^^^^^^^^^^^^^
- Bug in :class:`arrays.PandasArray` when setting a scalar string (:issue... | - [x] closes #28930
- [x] tests added / passed
- [x] passes `black pandas`
- [x] whatsnew entry | https://api.github.com/repos/pandas-dev/pandas/pulls/28945 | 2019-10-12T21:09:02Z | 2019-12-10T13:27:19Z | 2019-12-10T13:27:18Z | 2019-12-11T09:32:51Z |
TST: add test_series_any_timedelta for GH17667 | diff --git a/pandas/tests/test_multilevel.py b/pandas/tests/test_multilevel.py
index dc4db6e7902a8..9acf9e21b9775 100644
--- a/pandas/tests/test_multilevel.py
+++ b/pandas/tests/test_multilevel.py
@@ -1065,6 +1065,23 @@ def test_frame_any_all_group(self):
ex = DataFrame({"data": [False, False]}, index=["one", ... | Test case example is the same as the one given in the issue #17667
- [x] closes #17667
- [x] tests added / passed
- [x] passes `black pandas`
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry
| https://api.github.com/repos/pandas-dev/pandas/pulls/28942 | 2019-10-12T17:51:22Z | 2019-10-13T16:44:43Z | 2019-10-13T16:44:42Z | 2020-10-24T14:10:17Z |
DOC: disable nbsphinx including requirejs | diff --git a/doc/source/conf.py b/doc/source/conf.py
index 34faf183db1c2..86f78d9c0f0ae 100644
--- a/doc/source/conf.py
+++ b/doc/source/conf.py
@@ -120,6 +120,9 @@
plot_pre_code = """import numpy as np
import pandas as pd"""
+# nbsphinx do not use requirejs (breaks bootstrap)
+nbsphinx_requirejs_path = ""
+
# Add... | To fix https://github.com/pandas-dev/pandas-sphinx-theme/issues/25. With their latest release, `nbsphinx` started including require.js by default, which doesn't play nice with the bootstrap.js (and as a result, no javascript at all works).
This is using an option of `nbsphinx` to not include requirejs (which we don't... | https://api.github.com/repos/pandas-dev/pandas/pulls/28940 | 2019-10-12T16:40:49Z | 2019-10-12T18:03:58Z | 2019-10-12T18:03:58Z | 2019-10-12T18:04:01Z |
CLN: try/except cleanups | diff --git a/pandas/core/apply.py b/pandas/core/apply.py
index 605d179e7c652..91f3e878c3807 100644
--- a/pandas/core/apply.py
+++ b/pandas/core/apply.py
@@ -396,15 +396,11 @@ def wrap_results_for_axis(self):
result = self.obj._constructor(data=results)
if not isinstance(results[0], ABCSeries):
- ... | Move non-raising stuff out of try/except to narrow down the failure modes.
| https://api.github.com/repos/pandas-dev/pandas/pulls/28939 | 2019-10-12T16:26:24Z | 2019-10-12T17:00:19Z | 2019-10-12T17:00:19Z | 2019-10-12T18:32:07Z |
fix #28926 pandas\api\test_api.py mypy errors | diff --git a/pandas/tests/api/test_api.py b/pandas/tests/api/test_api.py
index 6c50159663574..0af8ed0ebf8d5 100644
--- a/pandas/tests/api/test_api.py
+++ b/pandas/tests/api/test_api.py
@@ -1,3 +1,5 @@
+from typing import List
+
import pandas as pd
from pandas import api, compat
from pandas.util import testing as tm
... | - [ ] xref #28926
- [ ] tests added / passed
- [x] passes `black pandas`
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry
| https://api.github.com/repos/pandas-dev/pandas/pulls/28935 | 2019-10-11T21:35:29Z | 2019-10-13T19:23:37Z | 2019-10-13T19:23:37Z | 2019-10-13T19:23:53Z |
REF: de-duplicate groupby_helper code | diff --git a/pandas/_libs/groupby.pyx b/pandas/_libs/groupby.pyx
index 3069bbbf34bb7..c9994812462b1 100644
--- a/pandas/_libs/groupby.pyx
+++ b/pandas/_libs/groupby.pyx
@@ -372,7 +372,8 @@ def group_any_all(uint8_t[:] out,
const uint8_t[:] mask,
object val_test,
... | There's one other piece of de-duplication I think should be feasible but cython is still raising compilation errors for, so will do separately.
Orthogonal to #28931, but I expect it will cause merge conflicts. 28931 should be a higher priority. | https://api.github.com/repos/pandas-dev/pandas/pulls/28934 | 2019-10-11T19:10:49Z | 2019-10-16T19:09:04Z | 2019-10-16T19:09:04Z | 2019-10-16T19:15:52Z |
BUG: Preserve key order when using loc on MultiIndex DataFrame | diff --git a/doc/source/whatsnew/v1.1.0.rst b/doc/source/whatsnew/v1.1.0.rst
index 607a2c02944b4..7071289ef3243 100644
--- a/doc/source/whatsnew/v1.1.0.rst
+++ b/doc/source/whatsnew/v1.1.0.rst
@@ -161,8 +161,14 @@ Missing
MultiIndex
^^^^^^^^^^
+- Bug in :meth:`Dataframe.loc` when used with a :class:`MultiIndex`. Th... | ## Description
closes #22797
As described in #22797, the key order given to loc for a MultiIndex DataFrame was not respected:
```
import pandas as pd
import numpy as np
df = pd.DataFrame(np.arange(12).reshape((4, 3)),
index=[['a', 'a', 'b', 'b'], [1, 2, 1, 2]],
columns=[['Ohio', 'Ohio', 'Colorado'],
... | https://api.github.com/repos/pandas-dev/pandas/pulls/28933 | 2019-10-11T18:52:53Z | 2020-02-02T22:20:57Z | 2020-02-02T22:20:56Z | 2020-03-16T19:31:39Z |
TYPING: Module 'pytz' has no attribute 'FixedOffset' | diff --git a/pandas/tests/indexes/datetimes/test_tools.py b/pandas/tests/indexes/datetimes/test_tools.py
index b6f25d45f136a..ff88c614cabd0 100644
--- a/pandas/tests/indexes/datetimes/test_tools.py
+++ b/pandas/tests/indexes/datetimes/test_tools.py
@@ -4,11 +4,14 @@
from datetime import datetime, time
import locale
... | xref https://github.com/pandas-dev/pandas/pull/28914#issuecomment-541064775
@WillAyd we _could_ use `from pytz import FixedOffset, ...` so that only a single `type: ignores` is required.
| https://api.github.com/repos/pandas-dev/pandas/pulls/28932 | 2019-10-11T17:27:06Z | 2019-10-12T17:14:45Z | null | 2019-10-12T17:14:45Z |
add uint64 support for some libgroupby funcs | diff --git a/pandas/_libs/groupby_helper.pxi.in b/pandas/_libs/groupby_helper.pxi.in
index 6b434b6470581..f052feea0bbf3 100644
--- a/pandas/_libs/groupby_helper.pxi.in
+++ b/pandas/_libs/groupby_helper.pxi.in
@@ -16,6 +16,7 @@ ctypedef fused rank_t:
float64_t
float32_t
int64_t
+ uint64_t
object
... | cc @WillAyd I hope you agree the runtime_error thing here is easier to implement/review with fused type than it would be with tempita. | https://api.github.com/repos/pandas-dev/pandas/pulls/28931 | 2019-10-11T17:19:03Z | 2019-10-16T12:42:48Z | 2019-10-16T12:42:48Z | 2019-10-16T15:25:04Z |
ENH: Support for specifying col names for col_space | diff --git a/pandas/core/frame.py b/pandas/core/frame.py
index 5200ad0ba0d23..e9878692784d9 100644
--- a/pandas/core/frame.py
+++ b/pandas/core/frame.py
@@ -2188,6 +2188,7 @@ def to_html(
buf=None,
columns=None,
col_space=None,
+ col_space_cols=None,
header=True,
inde... | **TO UPDATE FOLLOWING THINGS**
- [ ] closes #28917
- [ ] tests added / passed
- [ ] passes `black pandas`
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry
| https://api.github.com/repos/pandas-dev/pandas/pulls/28929 | 2019-10-11T16:22:35Z | 2019-12-04T09:03:32Z | null | 2019-12-04T09:03:32Z |
ENH: pd.MultiIndex.get_loc(np.nan) | diff --git a/doc/source/whatsnew/v1.0.0.rst b/doc/source/whatsnew/v1.0.0.rst
index 5b4761c3bc6c5..09d9a1d7ef322 100755
--- a/doc/source/whatsnew/v1.0.0.rst
+++ b/doc/source/whatsnew/v1.0.0.rst
@@ -903,6 +903,7 @@ Indexing
- Bug when indexing with ``.loc`` where the index was a :class:`CategoricalIndex` with non-string... | MultiIndex.get_loc could not find nan with values including missing
values as a input.
Background: In `MultiIndex`, missing value is denoted by -1 in codes and doesn't exist in `self.levels`
So, could not find NA value in `self.levels`.
Before PR xref #28783
- [x] closes #19132
- [x] tests added / passed
... | https://api.github.com/repos/pandas-dev/pandas/pulls/28919 | 2019-10-11T07:35:50Z | 2020-01-09T03:11:43Z | 2020-01-09T03:11:42Z | 2020-01-09T10:18:40Z |
BUG: Avoid undefined behaviour when converting from float to timedelta | diff --git a/pandas/core/nanops.py b/pandas/core/nanops.py
index eb442e8bf3486..09b80d1b3a9ac 100644
--- a/pandas/core/nanops.py
+++ b/pandas/core/nanops.py
@@ -360,7 +360,7 @@ def _wrap_results(result, dtype, fill_value=None):
result = tslibs.Timedelta(result, unit="ns")
else:
- resu... | Summation of timedelta series with NaTs in them result in undefined
behaviour because the final wrapping step of the summation ends up
converting the NaNs in the sum through a direct cast to int64. This
cast is undefined for NaN and just happens to work on x86_64 because
of the way `cvttd2si` works. On Aarch64, t... | https://api.github.com/repos/pandas-dev/pandas/pulls/28918 | 2019-10-11T06:28:40Z | 2019-10-12T17:08:43Z | 2019-10-12T17:08:43Z | 2019-10-12T17:09:10Z |
TYPES: add types in core.util.hashing | diff --git a/pandas/core/util/hashing.py b/pandas/core/util/hashing.py
index ca5279e93f678..b503c6a7c3e21 100644
--- a/pandas/core/util/hashing.py
+++ b/pandas/core/util/hashing.py
@@ -5,8 +5,8 @@
import numpy as np
+from pandas._libs import Timestamp
import pandas._libs.hashing as hashing
-import pandas._libs.ts... | cc @simonjayhawkins | https://api.github.com/repos/pandas-dev/pandas/pulls/28916 | 2019-10-11T03:32:30Z | 2019-10-12T15:54:45Z | null | 2019-11-21T20:00:23Z |
DOC: Fix typos in docstrings | diff --git a/pandas/core/indexes/multi.py b/pandas/core/indexes/multi.py
index 2da74012de968..b49bb856a2e2b 100644
--- a/pandas/core/indexes/multi.py
+++ b/pandas/core/indexes/multi.py
@@ -638,7 +638,7 @@ def levels(self):
@property
def _values(self):
- # We override here, since our parent uses _data... | Fixed three typos in docstrings. | https://api.github.com/repos/pandas-dev/pandas/pulls/28915 | 2019-10-11T02:49:50Z | 2019-10-11T03:53:58Z | 2019-10-11T03:53:58Z | 2019-10-11T04:11:56Z |
TYPING: lockdown test modules passing mypy | diff --git a/setup.cfg b/setup.cfg
index 43dbac15f5cfe..9c841b76761f5 100644
--- a/setup.cfg
+++ b/setup.cfg
@@ -130,5 +130,116 @@ skip = pandas/__init__.py,pandas/core/api.py
ignore_missing_imports=True
no_implicit_optional=True
-[mypy-pandas.conftest,pandas.tests.*]
+[mypy-pandas.conftest]
+ignore_errors=True
+
+... | xref https://github.com/pandas-dev/pandas/pull/28904#discussion_r333740051 and https://github.com/pandas-dev/pandas/pull/28746#discussion_r330499267 | https://api.github.com/repos/pandas-dev/pandas/pulls/28914 | 2019-10-11T00:02:00Z | 2019-10-11T11:56:58Z | 2019-10-11T11:56:58Z | 2019-10-11T13:43:35Z |
CLN: simplify maybe_promote in float and complex cases | diff --git a/pandas/core/dtypes/cast.py b/pandas/core/dtypes/cast.py
index 1e353c97be754..40db53016fb62 100644
--- a/pandas/core/dtypes/cast.py
+++ b/pandas/core/dtypes/cast.py
@@ -405,11 +405,8 @@ def maybe_promote(dtype, fill_value=np.nan):
dtype = np.min_scalar_type(fill_value)
elif dtype... | Analogous to #28899 (orthogonal) for complex and float dtypes. I'm pretty sure that after the current crop of maybe_promote PRs goes through we can do another round of consolidating code. | https://api.github.com/repos/pandas-dev/pandas/pulls/28913 | 2019-10-10T22:13:45Z | 2019-10-11T11:57:37Z | 2019-10-11T11:57:37Z | 2019-10-11T15:29:11Z |
Maintain Timezone Awareness with to_json and date_format="iso" | diff --git a/asv_bench/benchmarks/io/json.py b/asv_bench/benchmarks/io/json.py
index 5c1d39776b91c..4b7a8bfd103b3 100644
--- a/asv_bench/benchmarks/io/json.py
+++ b/asv_bench/benchmarks/io/json.py
@@ -67,10 +67,11 @@ class ToJSON(BaseIO):
params = [
["split", "columns", "index", "values", "records"],
... | - [X] closes #12997
- [X] tests added / passed
- [X] passes `black pandas`
- [X] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [X] whatsnew entry
This vendors updates from numpy that allow for tz-aware ISO date formatting. Note this does slightly change the behavior of UTC dates. Previously th... | https://api.github.com/repos/pandas-dev/pandas/pulls/28912 | 2019-10-10T22:11:53Z | 2019-10-30T17:09:37Z | null | 2020-01-16T00:33:47Z |
TYPING: errors reported by mypy 0.730 | diff --git a/pandas/compat/pickle_compat.py b/pandas/compat/pickle_compat.py
index b3c7b8a7c8b9f..3a36713ccdbda 100644
--- a/pandas/compat/pickle_compat.py
+++ b/pandas/compat/pickle_compat.py
@@ -68,7 +68,11 @@ def load_reduce(self):
class _LoadSparseSeries:
# To load a SparseSeries as a Series[Sparse]
- de... | errors reported by mypy 0.730 on master.
```
pandas\compat\pickle_compat.py:71: error: Incompatible return type for "__new__" (returns "Series", but must return a subtype of "_LoadSparseSeries")
pandas\compat\pickle_compat.py:85: error: Incompatible return type for "__new__" (returns "DataFrame", but must return a... | https://api.github.com/repos/pandas-dev/pandas/pulls/28910 | 2019-10-10T21:51:14Z | 2019-10-11T11:58:25Z | 2019-10-11T11:58:24Z | 2019-10-11T13:44:44Z |
TYPING: fix type annotation for pandas.io.formats.format._binify | diff --git a/pandas/io/formats/format.py b/pandas/io/formats/format.py
index 15f21814b072d..ad62c56a337b6 100644
--- a/pandas/io/formats/format.py
+++ b/pandas/io/formats/format.py
@@ -868,6 +868,8 @@ def _join_multiline(self, *args) -> str:
np.array([self.adj.len(x) for x in col]).max() if len(col) > 0 el... | - [ ] closes #28843
- [n/a ] tests added / passed
- [ ] passes `black pandas`
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [n/a ] whatsnew entry
| https://api.github.com/repos/pandas-dev/pandas/pulls/28908 | 2019-10-10T21:33:51Z | 2019-10-11T12:41:20Z | 2019-10-11T12:41:20Z | 2019-10-11T12:41:24Z |
Added note to 'contributing.rst file', telling users to append GH Issue… | diff --git a/doc/source/development/contributing.rst b/doc/source/development/contributing.rst
index dc6fa3d100212..949b6bd475319 100644
--- a/doc/source/development/contributing.rst
+++ b/doc/source/development/contributing.rst
@@ -949,6 +949,9 @@ the expected correct result::
assert_frame_equal(pivoted, ex... | … Number to new tests.
- [ X ] closes #28703
| https://api.github.com/repos/pandas-dev/pandas/pulls/28907 | 2019-10-10T20:28:37Z | 2019-10-12T17:09:57Z | 2019-10-12T17:09:57Z | 2019-10-12T17:10:03Z |
clean tests/indexing/common.py | diff --git a/pandas/tests/indexing/common.py b/pandas/tests/indexing/common.py
index 78764e6763e95..812d84261eb46 100644
--- a/pandas/tests/indexing/common.py
+++ b/pandas/tests/indexing/common.py
@@ -1,5 +1,4 @@
""" common utilities """
-
import itertools
from warnings import catch_warnings, filterwarnings
@@ -29... | clean-up of tests/indexing/common.py. | https://api.github.com/repos/pandas-dev/pandas/pulls/28904 | 2019-10-10T19:40:09Z | 2019-10-11T12:00:15Z | 2019-10-11T12:00:15Z | 2019-10-11T16:07:25Z |
REF: simplify maybe_promote integer cases | diff --git a/pandas/core/dtypes/cast.py b/pandas/core/dtypes/cast.py
index 1e353c97be754..1e62527f95bc7 100644
--- a/pandas/core/dtypes/cast.py
+++ b/pandas/core/dtypes/cast.py
@@ -423,57 +423,14 @@ def maybe_promote(dtype, fill_value=np.nan):
if issubclass(dtype.type, np.bool_):
dtype = np.dtype(... | @jreback its a little absurd how much this can be simplified after all the trouble I went through to on the last round
Let's hope the float cases simplify as nicely (separate branch/PR) | https://api.github.com/repos/pandas-dev/pandas/pulls/28899 | 2019-10-10T16:47:28Z | 2019-10-10T22:53:02Z | 2019-10-10T22:53:02Z | 2019-10-10T22:58:04Z |
REF: maybe_promote refactor/cleanup | diff --git a/pandas/core/dtypes/cast.py b/pandas/core/dtypes/cast.py
index 328c7566d8e8d..90c2638be5eec 100644
--- a/pandas/core/dtypes/cast.py
+++ b/pandas/core/dtypes/cast.py
@@ -393,32 +393,29 @@ def maybe_promote(dtype, fill_value=np.nan):
elif is_float(fill_value):
if issubclass(dtype.type, np.bool... | There is some casting we currently do in many places in this function. Instead this PR implements `_ensure_dtype_type` and calls it once at the end of the function.
Removes _check_lossless_cast which can be replaced with np.can_cast | https://api.github.com/repos/pandas-dev/pandas/pulls/28897 | 2019-10-10T15:48:17Z | 2019-10-12T17:14:22Z | 2019-10-12T17:14:22Z | 2019-10-12T18:27:57Z |
def item( was broken | diff --git a/pandas/core/base.py b/pandas/core/base.py
index 4d5b20c56df5a..afac290ce5a16 100644
--- a/pandas/core/base.py
+++ b/pandas/core/base.py
@@ -715,7 +715,7 @@ def item(self):
FutureWarning,
stacklevel=2,
)
- return self.values.item()
+ return self.values.item(0... | `pd.DataFrame({"a":[1,2,3]}).a.item() ` -- breaks!
`pd.DataFrame({"a":[1,2,3]}).a.values.item(0)` --- this is actual expected behaviour
- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] passes `black pandas`
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry
| https://api.github.com/repos/pandas-dev/pandas/pulls/28894 | 2019-10-10T09:45:53Z | 2019-10-22T01:04:18Z | null | 2019-10-22T01:04:18Z |
DOC: Fix commpiler typo in contributing.rst | diff --git a/doc/source/development/contributing.rst b/doc/source/development/contributing.rst
index 10d702808606a..dc6fa3d100212 100644
--- a/doc/source/development/contributing.rst
+++ b/doc/source/development/contributing.rst
@@ -172,7 +172,7 @@ installed (or you wish to install a newer version) you can install a co... | Corrects the spelling of compiler in contributing.rst.
- [ ] closes #xxxx
- [ ] tests added / passed
- [ ] passes `black pandas`
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry
| https://api.github.com/repos/pandas-dev/pandas/pulls/28891 | 2019-10-10T07:23:42Z | 2019-10-10T09:20:23Z | 2019-10-10T09:20:23Z | 2019-10-10T12:43:43Z |
DOC: Update performance comparison section of io docs | diff --git a/doc/source/user_guide/io.rst b/doc/source/user_guide/io.rst
index ef87b6c57b1b9..f8e174abfd193 100644
--- a/doc/source/user_guide/io.rst
+++ b/doc/source/user_guide/io.rst
@@ -5576,7 +5576,7 @@ Performance considerations
--------------------------
This is an informal comparison of various IO methods, u... | xref https://github.com/python-sprints/pandas-mentoring/issues/163
| https://api.github.com/repos/pandas-dev/pandas/pulls/28890 | 2019-10-10T07:04:29Z | 2019-11-09T00:59:55Z | 2019-11-09T00:59:55Z | 2019-11-09T01:00:05Z |
DOC: Fixed PR06 error in pandas.Categorical.from_codes | diff --git a/pandas/core/arrays/categorical.py b/pandas/core/arrays/categorical.py
index bab1127e6e539..8e5a58877e81b 100644
--- a/pandas/core/arrays/categorical.py
+++ b/pandas/core/arrays/categorical.py
@@ -636,7 +636,7 @@ def from_codes(cls, codes, categories=None, ordered=None, dtype=None):
Parameters
... | - [x] xref #28724
- [ ] tests added / passed
- [x] passes `black pandas`
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry
| https://api.github.com/repos/pandas-dev/pandas/pulls/28888 | 2019-10-10T04:02:46Z | 2019-10-10T15:57:24Z | null | 2019-10-10T16:05:52Z |
DOC: Fixed PR06 error in pandas.io.formats.style.Styler.set_table_attributes | diff --git a/pandas/io/formats/style.py b/pandas/io/formats/style.py
index 6bac3fe426f2d..6b98eaca9dacc 100644
--- a/pandas/io/formats/style.py
+++ b/pandas/io/formats/style.py
@@ -780,7 +780,7 @@ def set_table_attributes(self, attributes):
Parameters
----------
- attributes : string
+ ... | - [x] xref #28724
- [ ] tests added / passed
- [x] passes `black pandas`
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry
| https://api.github.com/repos/pandas-dev/pandas/pulls/28887 | 2019-10-10T03:54:24Z | 2019-10-10T15:53:58Z | 2019-10-10T15:53:58Z | 2019-10-10T16:03:57Z |
REF: use fused types for groupby_helper | diff --git a/pandas/_libs/groupby_helper.pxi.in b/pandas/_libs/groupby_helper.pxi.in
index 000689f634545..6b434b6470581 100644
--- a/pandas/_libs/groupby_helper.pxi.in
+++ b/pandas/_libs/groupby_helper.pxi.in
@@ -12,39 +12,27 @@ _int64_max = np.iinfo(np.int64).max
# group_nth, group_last, group_rank
# ---------------... | There will be some nice cleanups we can do after we bump cython to 0.30 (which hasnt come out yet).
Also I think there is some na-checking code that we can share between the various fused-types functions after this. | https://api.github.com/repos/pandas-dev/pandas/pulls/28886 | 2019-10-10T03:47:10Z | 2019-10-11T12:01:31Z | 2019-10-11T12:01:31Z | 2019-10-11T15:25:48Z |
DOC: Fixed PR06 errors in pandas.api.extensions.ExtensionArray | diff --git a/pandas/core/arrays/base.py b/pandas/core/arrays/base.py
index 0778b6726d104..7a16c3f6a35b6 100644
--- a/pandas/core/arrays/base.py
+++ b/pandas/core/arrays/base.py
@@ -177,7 +177,7 @@ def _from_sequence(cls, scalars, dtype=None, copy=False):
dtype : dtype, optional
Construct for this ... | - [x] xref #28724
- [ ] tests added / passed
- [x] passes `black pandas`
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry
| https://api.github.com/repos/pandas-dev/pandas/pulls/28885 | 2019-10-10T03:45:40Z | 2019-10-10T16:00:24Z | 2019-10-10T16:00:24Z | 2019-10-10T16:04:28Z |
Remove ix, part 1 | diff --git a/pandas/tests/frame/test_indexing.py b/pandas/tests/frame/test_indexing.py
index 6d239e96cd167..4d8b3e3e24ac7 100644
--- a/pandas/tests/frame/test_indexing.py
+++ b/pandas/tests/frame/test_indexing.py
@@ -393,85 +393,6 @@ def test_boolean_index_empty_corner(self):
blah[k]
blah[k] = 0
- ... | - [ ] xref #15113 and #26438
First part of removal od ``NDFrame.ix``. There's still alot of tests for this, so I'll do this removal in 2-3 steps. This PR removes pandas/tests/indexing/test_ix.py and tests for ix in a few more places. | https://api.github.com/repos/pandas-dev/pandas/pulls/28884 | 2019-10-10T01:12:37Z | 2019-10-10T01:53:18Z | null | 2019-10-10T16:41:48Z |
CLN: dont catch Exception in groupby var | diff --git a/pandas/core/groupby/groupby.py b/pandas/core/groupby/groupby.py
index 4e0dd65042196..d477b173b95f0 100644
--- a/pandas/core/groupby/groupby.py
+++ b/pandas/core/groupby/groupby.py
@@ -41,6 +41,7 @@ class providing the base-class of operations.
)
from pandas.core.dtypes.missing import isna, notna
+from ... | Between this, #28878, and #28873, I'm finding that the outside-in approach to cleaning this up is proving easier the earlier inside-out approach. | https://api.github.com/repos/pandas-dev/pandas/pulls/28883 | 2019-10-09T22:40:33Z | 2019-10-10T01:25:29Z | 2019-10-10T01:25:29Z | 2019-10-10T01:55:47Z |
TST: Fix maybe_promote floating non-boxed tests | diff --git a/pandas/core/dtypes/cast.py b/pandas/core/dtypes/cast.py
index 5b13e13bb20ba..098f42b1a8c5c 100644
--- a/pandas/core/dtypes/cast.py
+++ b/pandas/core/dtypes/cast.py
@@ -398,6 +398,22 @@ def maybe_promote(dtype, fill_value=np.nan):
dtype = np.dtype(np.float64)
if not isna(fill_value... | Like #28864, this involves changing the underlying function. Some of this can be de-duplicated once these are in.
I think that this is the last of the xfails for non-boxed test cases. Really looking forward to having this done with,. | https://api.github.com/repos/pandas-dev/pandas/pulls/28880 | 2019-10-09T20:43:50Z | 2019-10-10T12:50:18Z | 2019-10-10T12:50:18Z | 2019-10-10T13:33:32Z |
CLN: assorted cleanups, remove unicode checks in cython | diff --git a/pandas/_libs/hashing.pyx b/pandas/_libs/hashing.pyx
index c0aa661266d29..6b27b2204e75e 100644
--- a/pandas/_libs/hashing.pyx
+++ b/pandas/_libs/hashing.pyx
@@ -60,7 +60,7 @@ def hash_object_array(object[:] arr, object key, object encoding='utf8'):
val = arr[i]
if isinstance(val, bytes):
... | https://api.github.com/repos/pandas-dev/pandas/pulls/28879 | 2019-10-09T20:10:44Z | 2019-10-10T01:30:55Z | 2019-10-10T01:30:55Z | 2019-10-10T01:43:10Z | |
CLN: dont catch on groupby.mean | diff --git a/pandas/core/groupby/generic.py b/pandas/core/groupby/generic.py
index 41a5195008f0c..5200d33c6a1fb 100644
--- a/pandas/core/groupby/generic.py
+++ b/pandas/core/groupby/generic.py
@@ -971,6 +971,18 @@ def _cython_agg_blocks(self, how, alt=None, numeric_only=True, min_count=-1):
if result i... | The new casting in cython_agg_blocks is specific to a single IntegerArray test case. We could pretty reasonably move that into maybe_downcast_numeric. For the moment id rather hold off since I expect other EA cases to show up here.
cc @WillAyd | https://api.github.com/repos/pandas-dev/pandas/pulls/28878 | 2019-10-09T19:58:12Z | 2019-10-10T01:27:38Z | 2019-10-10T01:27:38Z | 2019-10-10T01:51:09Z |
ENH: show numbers on .info() with verbose flag | diff --git a/doc/source/whatsnew/v1.0.0.rst b/doc/source/whatsnew/v1.0.0.rst
index 051d64ee87711..8c59ed0dd9388 100755
--- a/doc/source/whatsnew/v1.0.0.rst
+++ b/doc/source/whatsnew/v1.0.0.rst
@@ -290,13 +290,42 @@ New repr for :class:`~pandas.arrays.IntervalArray`
closed='right',
dt... | - [x] closes #17304
- [x] tests added / passed
- [x] passes `black pandas`
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry
| https://api.github.com/repos/pandas-dev/pandas/pulls/28876 | 2019-10-09T19:38:52Z | 2020-01-03T01:18:53Z | 2020-01-03T01:18:53Z | 2020-01-03T08:54:26Z |
BUG: Allow all int types for merge (GH28870) | diff --git a/doc/source/whatsnew/v1.0.0.rst b/doc/source/whatsnew/v1.0.0.rst
index fd1c1271a5e37..dd96c6b594cea 100644
--- a/doc/source/whatsnew/v1.0.0.rst
+++ b/doc/source/whatsnew/v1.0.0.rst
@@ -344,6 +344,7 @@ Reshaping
- Bug :func:`merge_asof` could not use :class:`datetime.timedelta` for ``tolerance`` kwarg (:iss... | - [x] closes #28870
- [x] tests added / passed
- [x] passes `black pandas`
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [x] whatsnew entry | https://api.github.com/repos/pandas-dev/pandas/pulls/28875 | 2019-10-09T18:58:32Z | 2019-10-11T12:09:34Z | 2019-10-11T12:09:34Z | 2019-10-12T15:49:35Z |
use requests when it is installed | diff --git a/doc/source/getting_started/install.rst b/doc/source/getting_started/install.rst
index fc99b458fa0af..b3402345f8c1a 100644
--- a/doc/source/getting_started/install.rst
+++ b/doc/source/getting_started/install.rst
@@ -263,6 +263,7 @@ pymysql 0.7.11 MySQL engine for sqlalchemy
p... | closes #16716
closes #28825
closes #28826
solves https://github.com/pandas-dev/pandas/pull/16910
- [ ] tests added / passed
- [X] passes `black pandas`
- [X] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry
Continuation of https://github.com/pandas-dev/pandas/pull/21504 an... | https://api.github.com/repos/pandas-dev/pandas/pulls/28874 | 2019-10-09T18:31:52Z | 2020-02-06T23:59:52Z | null | 2020-02-06T23:59:52Z |
CLN: No catching needed for groupby median | diff --git a/pandas/core/groupby/groupby.py b/pandas/core/groupby/groupby.py
index 4e0dd65042196..3df99e330fe4a 100644
--- a/pandas/core/groupby/groupby.py
+++ b/pandas/core/groupby/groupby.py
@@ -1236,23 +1236,11 @@ def median(self, **kwargs):
Series or DataFrame
Median of values within each grou... | https://api.github.com/repos/pandas-dev/pandas/pulls/28873 | 2019-10-09T16:57:29Z | 2019-10-10T01:50:32Z | 2019-10-10T01:50:32Z | 2019-10-10T04:39:24Z | |
TST: Use fixtures instead of setup_method for index tests | diff --git a/pandas/tests/indexes/common.py b/pandas/tests/indexes/common.py
index 793992d311502..b657d8d16df81 100644
--- a/pandas/tests/indexes/common.py
+++ b/pandas/tests/indexes/common.py
@@ -33,10 +33,6 @@ class Base:
_holder = None
_compat_props = ["shape", "ndim", "size", "nbytes"]
- def setup_in... | The common index tests use `setup_method` to create a `dict` of indexes to test against:
https://github.com/pandas-dev/pandas/blob/df2e0813e053cc5bc924b2292ea8918a6b27f0e2/pandas/tests/indexes/test_range.py#L25-L30
This `dict` of indexes is then iterated over within the tests:
https://github.com/pandas-dev/pan... | https://api.github.com/repos/pandas-dev/pandas/pulls/28865 | 2019-10-09T04:50:28Z | 2019-10-11T15:14:07Z | 2019-10-11T15:14:07Z | 2019-12-20T01:03:29Z |
TST: Fix xfails for non-box maybe_promote on integer dtypes | diff --git a/pandas/core/dtypes/cast.py b/pandas/core/dtypes/cast.py
index 5b13e13bb20ba..a7fdd6759ba95 100644
--- a/pandas/core/dtypes/cast.py
+++ b/pandas/core/dtypes/cast.py
@@ -408,9 +408,58 @@ def maybe_promote(dtype, fill_value=np.nan):
dtype = np.object_
elif issubclass(dtype.type, np.integ... | Orthogonal to other outstanding maybe_promote PRs.
This one required pretty significant changes to the code. Using `np.min_scalar_type` and `np.can_cast` cleans this up a bit, but it is still pretty verbose. AFAICT there is no clear way to make it shorter without significantly sacrificing clarity.
In a follow-u... | https://api.github.com/repos/pandas-dev/pandas/pulls/28864 | 2019-10-09T03:35:04Z | 2019-10-10T12:51:18Z | 2019-10-10T12:51:18Z | 2019-10-10T13:34:20Z |
Vectorized ISO Format | diff --git a/pandas/_libs/tslibs/fields.pyx b/pandas/_libs/tslibs/fields.pyx
index 2ed85595f7e3a..1693a2e936a1f 100644
--- a/pandas/_libs/tslibs/fields.pyx
+++ b/pandas/_libs/tslibs/fields.pyx
@@ -18,10 +18,15 @@ from pandas._libs.tslibs.ccalendar cimport (
get_day_of_year)
from pandas._libs.tslibs.np_datetime ci... | - [ ] closes #28180
- [ ] tests added / passed
- [ ] passes `black pandas`
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry
Needs work but could certainly use some guidance from @jbrockmendel
This uses the dt -> ISO string formatting that is deeply nested in the JSON ... | https://api.github.com/repos/pandas-dev/pandas/pulls/28863 | 2019-10-09T00:00:43Z | 2019-10-11T12:53:48Z | null | 2020-01-16T00:33:48Z |
CLN: catch less in pd.io | diff --git a/pandas/io/html.py b/pandas/io/html.py
index 490c574463b9b..715f0c08546a3 100644
--- a/pandas/io/html.py
+++ b/pandas/io/html.py
@@ -897,7 +897,7 @@ def _parse(flavor, io, match, attrs, encoding, displayed_only, **kwargs):
try:
tables = p.parse_tables()
- except Exception as c... | @bashtage (only tangentially related to this PR) there is an `except Exception` in pandas.io.stata that I'd like to make more specific. Any suggestions? | https://api.github.com/repos/pandas-dev/pandas/pulls/28862 | 2019-10-08T23:22:12Z | 2019-11-12T18:00:24Z | null | 2019-11-21T23:07:48Z |
TST: Fix 36 maybe_promote xfails wanting np.bytes_ instead of np.object_ | diff --git a/pandas/tests/dtypes/cast/test_promote.py b/pandas/tests/dtypes/cast/test_promote.py
index e4e5a22ea6ca0..b498d589119d2 100644
--- a/pandas/tests/dtypes/cast/test_promote.py
+++ b/pandas/tests/dtypes/cast/test_promote.py
@@ -506,25 +506,13 @@ def test_maybe_promote_bytes_with_any(bytes_dtype, any_numpy_dtyp... | @jreback less trivial than some of the others. These changes are based on my understanding that maybe_promote should _never_ be returning np.bytes_ dtype; those cases all become np.object_. That is what maybe_promote currently does, and this updates the tests to expect that behavior. | https://api.github.com/repos/pandas-dev/pandas/pulls/28861 | 2019-10-08T22:57:01Z | 2019-10-11T12:24:27Z | 2019-10-11T12:24:27Z | 2019-10-11T15:30:07Z |
ENH: Add optional argument keep_index to dataframe melt method (merged master onto old PR) | diff --git a/pandas/core/frame.py b/pandas/core/frame.py
index 5200ad0ba0d23..4946ce4e13eae 100644
--- a/pandas/core/frame.py
+++ b/pandas/core/frame.py
@@ -6312,6 +6312,10 @@ def unstack(self, level=-1, fill_value=None):
Name to use for the 'value' column.
col_level : int or str, optional
If col... | This PR merges master onto @NiklasKeck's PR branch (#17440) to add an optional argument to keep_index to `pd.melt`. There is quite a bit of discussion between the following 2 PRs and issues:
Index gets lost when DataFrame melt method is used #17440
ENH: Add optional argument keep_index to dataframe melt method #174... | https://api.github.com/repos/pandas-dev/pandas/pulls/28859 | 2019-10-08T21:42:43Z | 2019-12-09T18:05:32Z | null | 2019-12-09T18:05:32Z |
DOC: Fix missing periods and non capitalized summary beginnings (#27977) | diff --git a/pandas/_libs/tslibs/period.pyx b/pandas/_libs/tslibs/period.pyx
index 697e97e518b13..32dcc86faa7e8 100644
--- a/pandas/_libs/tslibs/period.pyx
+++ b/pandas/_libs/tslibs/period.pyx
@@ -1710,7 +1710,7 @@ cdef class _Period:
def asfreq(self, freq, how='E'):
"""
Convert Period to desired... | - [ ] closes #27977
- [ ] tests added / passed
- [x] passes `black pandas`
- [x] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry
Fixed for the following functions
`pandas.io.formats.style.Styler.set_caption
pandas.plotting.table
pandas.plotting.register_matplotlib_converte... | https://api.github.com/repos/pandas-dev/pandas/pulls/28858 | 2019-10-08T21:26:02Z | 2019-10-09T07:37:50Z | 2019-10-09T07:37:50Z | 2019-10-09T07:38:05Z |
CLN: assorted cleanups, mostly post-black fixups | diff --git a/asv_bench/benchmarks/ctors.py b/asv_bench/benchmarks/ctors.py
index ec3dd7a48a89f..a9e45cad22d27 100644
--- a/asv_bench/benchmarks/ctors.py
+++ b/asv_bench/benchmarks/ctors.py
@@ -67,7 +67,7 @@ class SeriesConstructors:
def setup(self, data_fmt, with_index, dtype):
if data_fmt in (gen_of_str,... | Mostly fixing extra " " introduced by black (will take a look at the issue tracker there to see if that can be fixed once and for all).
Also change `except Foo as e:` to `except Foo as err` and remove one `except Exception` in a docs file. Clarified a whatsnew note that @jorisvandenbossche asked for a while back. | https://api.github.com/repos/pandas-dev/pandas/pulls/28857 | 2019-10-08T20:40:03Z | 2019-10-11T18:15:35Z | 2019-10-11T18:15:35Z | 2019-10-11T18:35:24Z |
TST: un-xfail 22 maybe_promote tests | diff --git a/pandas/tests/dtypes/cast/test_promote.py b/pandas/tests/dtypes/cast/test_promote.py
index da2b4c28a02a5..5fd1ceb7b0027 100644
--- a/pandas/tests/dtypes/cast/test_promote.py
+++ b/pandas/tests/dtypes/cast/test_promote.py
@@ -515,14 +515,6 @@ def test_maybe_promote_bytes_with_any(bytes_dtype, any_numpy_dtype... | orthogonal to other outstanding PRs in this file | https://api.github.com/repos/pandas-dev/pandas/pulls/28856 | 2019-10-08T18:48:11Z | 2019-10-08T20:58:00Z | 2019-10-08T20:58:00Z | 2019-10-08T21:07:44Z |
remove doc note about apply applying a function to the first element … | diff --git a/pandas/core/frame.py b/pandas/core/frame.py
index 1a19910a0957c..5200ad0ba0d23 100644
--- a/pandas/core/frame.py
+++ b/pandas/core/frame.py
@@ -6729,14 +6729,6 @@ def apply(
DataFrame.aggregate: Only perform aggregating type operations.
DataFrame.transform: Only perform transforming type ... | …twice
- [x] closes #28827
- [ ] tests added / passed
- [ ] passes `black pandas`
- [ ] passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
- [ ] whatsnew entry
| https://api.github.com/repos/pandas-dev/pandas/pulls/28854 | 2019-10-08T18:35:16Z | 2019-10-08T20:56:32Z | 2019-10-08T20:56:32Z | 2019-10-08T20:56:40Z |
CLN: dont catch Exception on reindex_multi | diff --git a/pandas/core/generic.py b/pandas/core/generic.py
index a135f567fe6f4..f77d543193e74 100644
--- a/pandas/core/generic.py
+++ b/pandas/core/generic.py
@@ -4555,10 +4555,7 @@ def reindex(self, *args, **kwargs):
# check if we are a multi reindex
if self._needs_reindex_multi(axes, method, lev... | @toobaz any guesses what this might have been intended to catch? | https://api.github.com/repos/pandas-dev/pandas/pulls/28853 | 2019-10-08T18:20:00Z | 2019-10-11T15:50:18Z | 2019-10-11T15:50:18Z | 2019-10-11T15:54:38Z |
TST: Fix not-boxed maybe_promote test | diff --git a/pandas/core/dtypes/cast.py b/pandas/core/dtypes/cast.py
index 4435b2518e90b..b439a3e2dfbc8 100644
--- a/pandas/core/dtypes/cast.py
+++ b/pandas/core/dtypes/cast.py
@@ -359,6 +359,8 @@ def maybe_promote(dtype, fill_value=np.nan):
if isinstance(fill_value, datetime) and fill_value.tzinfo is not None... | Along with #28833 this gets close to finishing off the not-boxed cases | https://api.github.com/repos/pandas-dev/pandas/pulls/28852 | 2019-10-08T17:56:04Z | 2019-10-08T21:21:13Z | 2019-10-08T21:21:13Z | 2019-10-08T21:33:31Z |
TST: un-xfail 1 passing maybe_promote test | diff --git a/pandas/tests/dtypes/cast/test_promote.py b/pandas/tests/dtypes/cast/test_promote.py
index da2b4c28a02a5..45dbdf72209b6 100644
--- a/pandas/tests/dtypes/cast/test_promote.py
+++ b/pandas/tests/dtypes/cast/test_promote.py
@@ -1038,14 +1038,7 @@ def test_maybe_promote_any_numpy_dtype_with_na(
dtype = np.... | https://api.github.com/repos/pandas-dev/pandas/pulls/28850 | 2019-10-08T17:05:03Z | 2019-10-08T20:55:02Z | 2019-10-08T20:55:02Z | 2019-10-08T21:06:02Z | |
[MINOR] Fix formatting string in _ODFReader.get_sheet_by_name | diff --git a/pandas/io/excel/_odfreader.py b/pandas/io/excel/_odfreader.py
index 3be36663bac79..1b22ac953a2a8 100644
--- a/pandas/io/excel/_odfreader.py
+++ b/pandas/io/excel/_odfreader.py
@@ -60,7 +60,7 @@ def get_sheet_by_name(self, name: str):
if table.getAttribute("name") == name:
retu... | This PR fixes minor problem with `_ODFReader.get_sheet_by_name` method.
If `name` is not found, it attempts to raise a `ValueError` with formatted string that expects keyword argument `name`, however `names` is passed as a positional argument. In effect it will throw unexpected `KeyError`.
Steps to reproduce th... | https://api.github.com/repos/pandas-dev/pandas/pulls/28849 | 2019-10-08T16:41:00Z | 2019-10-08T16:49:33Z | null | 2019-10-08T17:51:40Z |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.