Sync ctx 8e56add (part 3)

GitHub commit: 8e56add2dad3382f9427395b1433f8845134d7ae

src/tests/test_bug_smoke_tracker.py

@@ -18,6 +18,7 @@ STATUSES = {
     "False Positive",
 }
 FIX_STATUSES = {"Fixed", "Blocked", "Not Started", "N/A"}
+CLOSED_NEXT_ACTION_PREFIX = "Closed;"
 
 
 def _tracker_rows() -> list[dict[str, str]]:
@@ -62,6 +63,9 @@ def test_bug_smoke_tracker_has_valid_rows() -> None:
         if row["status"] == "Retested Pass":
             assert row["fix_status"] == "Fixed"
             assert row["retest_evidence"].startswith("PASS:")
+            assert row["next_action"].startswith(CLOSED_NEXT_ACTION_PREFIX), (
+                f"{row['finding_id']} has non-closed next_action"
+            )
         if row["status"] == "Blocked/Human Decision":
             assert row["owner"] == "Human Owner"
             assert row["fix_status"] == "Blocked"

src/tests/test_ci_preflight.py

@@ -1,9 +1,13 @@
 from __future__ import annotations
 
+import shlex
 from pathlib import Path
 
+import yaml  # type: ignore[import-untyped]
+
 from scripts.ci_preflight import _run_no_test_policy_for_files
 from scripts.ci_preflight import Check
+from scripts.ci_preflight import PUBLIC_DOCS_TRACKER_TESTS
 from scripts.ci_preflight import select_checks
 
 
@@ -22,6 +26,23 @@ def _names_for(files: list[str], *, profile: str = "pr") -> list[str]:
     return [check.name for check in checks]
 
 
+def _workflow_docs_tracker_tests() -> tuple[str, ...]:
+    workflow = yaml.safe_load(Path(".github/workflows/test.yml").read_text(encoding="utf-8"))
+    steps = workflow["jobs"]["docs-check"]["steps"]
+    run = next(
+        step["run"] for step in steps if step.get("name") == "Run public docs tracker checks"
+    )
+    command = " ".join(line.rstrip("\\").strip() for line in run.splitlines() if line.strip())
+    argv = shlex.split(command)
+
+    assert argv[:5] == ["python", "-m", "pytest", "-q", "--no-cov"]
+    return tuple(argv[5:])
+
+
+def test_pr_docs_workflow_tracker_tests_match_preflight() -> None:
+    assert _workflow_docs_tracker_tests() == PUBLIC_DOCS_TRACKER_TESTS
+
+
 def test_preflight_runs_docs_gate_for_docs_changes() -> None:
     names = _names_for(["docs/index.md"])
     tracker_checks = _checks_for(["qa/bug_smoke_status.csv"])
@@ -37,6 +58,7 @@ def test_preflight_runs_docs_gate_for_docs_changes() -> None:
     assert "docs strict build" in tracker_names
     assert "unit-linux equivalent" not in tracker_names
     assert "src/tests/test_bug_smoke_tracker.py" in public_docs_tracker.argv
+    assert "src/tests/test_dashboard_user_story_tracker.py" in public_docs_tracker.argv
 
 
 def test_preflight_runs_source_gates_for_source_changes() -> None:
@@ -89,6 +111,10 @@ def test_internal_no_test_policy_accepts_dirty_contract_with_tests() -> None:
     )
 
 
+def test_internal_no_test_policy_rejects_metadata_without_diff_context() -> None:
+    assert _run_no_test_policy_for_files(["pyproject.toml"], diffs_by_file={}) == 1
+
+
 def test_preflight_pr_profile_runs_package_build_for_source_prs() -> None:
     checks, _notes = select_checks(
         base_ref="origin/main",

src/tests/test_ctx_monitor.py

@@ -3959,6 +3959,8 @@ def test_entity_subgraph_wrapper_matches_extracted_wiki_renderer() -> None:
 
     assert wrapper_html == direct_html
     assert "/wiki/github-api?type=mcp-server" in wrapper_html
+    assert '[data-testid="entity-subgraph-node"]' in wrapper_html
+    assert "[data-3d-node-id]" not in wrapper_html
     assert "mcp-server" in wrapper_html
 
 

src/tests/test_ctx_monitor_3type.py

@@ -32,7 +32,7 @@ import pytest
 sys.path.insert(0, str(Path(__file__).parents[1]))
 
 from ctx.core import entity_types as _entity_types
-from ctx.core.wiki.wiki_packs import write_wiki_base_pack
+from ctx.core.wiki.wiki_packs import write_wiki_base_pack, write_wiki_overlay_pack
 from ctx.monitor import testing as _mt
 from ctx.monitor.services import wiki as _wiki_service
 
@@ -182,7 +182,7 @@ class TestWikiIndexEntries:
         path = _mt.wiki_entity_path("langgraph", entity_type="harness")
         assert path == wiki_3type / "entities" / "harnesses" / "langgraph.md"
 
-    def test_wiki_pack_pages_override_physical_entity_pages(
+    def test_wiki_pack_pages_override_physical_pages_and_include_local_only_pages(
         self,
         wiki_3type: Path,
         monkeypatch: pytest.MonkeyPatch,
@@ -199,6 +199,17 @@ class TestWikiIndexEntries:
             "# Stale Physical Page\n",
             encoding="utf-8",
         )
+        (wiki_3type / "entities" / "skills" / "manage-created.md").write_text(
+            "---\n"
+            "title: Manage Created\n"
+            "type: skill\n"
+            "tags: [local]\n"
+            "description: local manage page\n"
+            "---\n"
+            "# Manage Created\n\n"
+            "Local-only Manage-created body.\n",
+            encoding="utf-8",
+        )
         write_wiki_base_pack(
             pack_dir=wiki_3type / "wiki-packs" / "base-export-1",
             pack_id="base-export-1",
@@ -225,6 +236,14 @@ class TestWikiIndexEntries:
                 ),
             },
         )
+        write_wiki_overlay_pack(
+            pack_dir=wiki_3type / "wiki-packs" / "overlay-delete-security-basics",
+            pack_id="overlay-delete-security-basics",
+            base_export_id="export-1",
+            parent_export_id="export-1",
+            pages={},
+            tombstones=["entities/skills/security-basics.md"],
+        )
 
         entries = _mt.wiki_index_entries(limit_per_type=None)
         slugs = {entry["slug"] for entry in entries}
@@ -235,10 +254,24 @@ class TestWikiIndexEntries:
         )
         detail = _mt.wiki_entity_detail("python-patterns", entity_type="skill")
         search = _mt.search_wiki_entities("merged body", entity_type="skill")
+        local_detail = _mt.wiki_entity_detail("manage-created", entity_type="skill")
+        local_search = _mt.search_wiki_entities("local-only manage", entity_type="skill")
+        local_html = _mt.render_wiki_entity("manage-created", entity_type="skill")
+        tombstoned_detail = _mt.wiki_entity_detail("security-basics", entity_type="skill")
+        tombstoned_search = _mt.search_wiki_entities("security-basics", entity_type="skill")
         html = _mt.render_wiki_entity("python-patterns", entity_type="skill")
         stats = _mt.wiki_stats()
 
-        assert slugs == {"python-patterns", "github"}
+        assert slugs == {
+            "anthropic-python-sdk",
+            "atlassian-cloud",
+            "code-reviewer",
+            "github",
+            "langgraph",
+            "manage-created",
+            "pulsemcp-meta",
+            "python-patterns",
+        }
         assert service_detail is not None
         assert service_detail["frontmatter"]["title"] == "Fresh Pack Page"
         assert "Merged wiki pack body" in service_detail["body"]
@@ -246,17 +279,100 @@ class TestWikiIndexEntries:
         assert detail["frontmatter"]["title"] == "Fresh Pack Page"
         assert "Merged wiki pack body" in detail["body"]
         assert [row["slug"] for row in search] == ["python-patterns"]
+        assert local_detail is not None
+        assert local_detail["frontmatter"]["title"] == "Manage Created"
+        assert "Local-only Manage-created body" in local_detail["body"]
+        assert [row["slug"] for row in local_search] == ["manage-created"]
+        assert "Manage Created" in local_html
+        assert _mt.wiki_entity_path("security-basics", entity_type="skill") is None
+        assert tombstoned_detail is None
+        assert tombstoned_search == []
         assert "Fresh Pack Page" in html
         assert "Stale Physical Page" not in html
         assert stats == {
-            "skills": 1,
-            "agents": 0,
-            "mcps": 1,
-            "harnesses": 0,
-            "total": 2,
+            "skills": 2,
+            "agents": 1,
+            "mcps": 4,
+            "harnesses": 1,
+            "total": 8,
             "split_known": True,
         }
 
+    def test_untyped_pack_read_uses_resolved_local_entity_path(
+        self,
+        wiki_3type: Path,
+    ) -> None:
+        _wiki_service.reset_caches()
+        (wiki_3type / "entities" / "skills" / "shared-slug.md").write_text(
+            "---\n"
+            "title: Local Skill\n"
+            "type: skill\n"
+            "tags: [local]\n"
+            "---\n"
+            "# Local Skill\n\n"
+            "Local skill body.\n",
+            encoding="utf-8",
+        )
+        write_wiki_base_pack(
+            pack_dir=wiki_3type / "wiki-packs" / "base-export-1",
+            pack_id="base-export-1",
+            base_export_id="export-1",
+            pages={
+                "entities/agents/shared-slug.md": (
+                    "---\n"
+                    "title: Packed Agent\n"
+                    "type: agent\n"
+                    "tags: [pack]\n"
+                    "---\n"
+                    "# Packed Agent\n\n"
+                    "Packed agent body.\n"
+                ),
+            },
+        )
+
+        detail = _mt.wiki_entity_detail("shared-slug")
+        agent_detail = _mt.wiki_entity_detail("shared-slug", entity_type="agent")
+
+        assert detail is not None
+        assert detail["type"] == "skill"
+        assert detail["frontmatter"]["title"] == "Local Skill"
+        assert "Local skill body" in detail["body"]
+        assert "Packed agent body" not in detail["body"]
+        assert agent_detail is not None
+        assert agent_detail["type"] == "agent"
+        assert agent_detail["frontmatter"]["title"] == "Packed Agent"
+
+    def test_wiki_entity_page_resolves_type_from_path_for_untyped_non_skill(
+        self,
+        wiki_3type: Path,
+        monkeypatch: pytest.MonkeyPatch,
+    ) -> None:
+        calls: dict[str, list[tuple[str, str | None]]] = {"sidecar": [], "subgraph": []}
+        (wiki_3type / "entities" / "agents" / "untyped-agent.md").write_text(
+            "---\ntitle: Untyped Agent\n---\n# Untyped Agent\n\nBody.\n",
+            encoding="utf-8",
+        )
+
+        def fake_sidecar(slug: str, entity_type: str | None = None) -> dict[str, Any]:
+            calls["sidecar"].append((slug, entity_type))
+            return {"grade": "A", "raw_score": 0.91}
+
+        def fake_subgraph(slug: str, entity_type: str | None = None) -> str:
+            calls["subgraph"].append((slug, entity_type))
+            return "<div>subgraph</div>"
+
+        monkeypatch.setattr(_mt, "load_sidecar", fake_sidecar)
+        monkeypatch.setattr(_mt, "render_entity_subgraph", fake_subgraph)
+
+        html = _mt.render_wiki_entity("untyped-agent")
+
+        assert calls == {
+            "sidecar": [("untyped-agent", "agent")],
+            "subgraph": [("untyped-agent", "agent")],
+        }
+        assert "/skill/untyped-agent?type=agent" in html
+        assert "/graph?slug=untyped-agent&amp;type=agent" in html
+
     def test_wiki_search_indexes_tags_beyond_preview_limit(self, wiki_3type):
         page = wiki_3type / "entities" / "skills" / "many-tags.md"
         page.write_text(

src/tests/test_quality_hook.py

@@ -137,7 +137,10 @@ def test_hook_mains_exit_zero_and_dispatch_expected_work(
     # Point everything at tmp so no real state is touched.
     monkeypatch.setenv("HOME", str(tmp_path))
     events = tmp_path / "skill-events.jsonl"
-    _write_events(events, [{"event": "load", "skill": "demo", "timestamp": _iso(NOW)}])
+    _write_events(
+        events,
+        [{"event": "load", "skill": "demo", "timestamp": _iso(datetime.now(timezone.utc))}],
+    )
     monkeypatch.setattr(qh, "_EVENTS_PATH", events, raising=True)
     monkeypatch.setattr(qh, "_STATE_PATH", tmp_path / "state.json", raising=True)
 
@@ -149,6 +152,7 @@ def test_hook_mains_exit_zero_and_dispatch_expected_work(
     monkeypatch.setattr("sys.stdin", _StdinStub(""))
     rc = qh.main()
     assert rc == 0  # hook never propagates errors
+    assert not (tmp_path / "state.json").exists()
 
     current = datetime.now(timezone.utc)
     (tmp_path / "state.json").write_text(