Fix error catching failures

fix_stuck_failed_entries_downloader.py

@@ -0,0 +1,72 @@
+"""
+One-off fix for downloader.py progress files affected by the
+_CapturingLogger traceback bug.
+
+Some videos ended up status="failed" with attempts >= max_video_attempts,
+where last_error is actually just a raw traceback (e.g. starts with
+'  File "...') instead of the real yt-dlp message. That happened because,
+with verbose=True, yt-dlp's logger.error() was called twice per failure and
+the traceback call overwrote the real error message before it could be
+classified -- so these videos may really be permanently unavailable
+(private/removed/etc.) but got stuck labeled "failed" instead, and
+should_retry_video() will never look at them again.
+
+This resets `attempts` to 0 for exactly those entries so the *next* run
+(with the fix applied) gives them one more attempt and classifies them
+correctly. It does NOT touch anything already "uploaded" or "unavailable",
+or "failed" entries whose last_error looks like a normal (non-traceback)
+message -- those were classified correctly the first time.
+
+Usage:
+    python fix_stuck_failed_entries_downloader.py progress/download_progress_6_0.json
+"""
+import json
+import sys
+
+
+def looks_like_traceback(msg):
+    if not msg:
+        return False
+    stripped = msg.lstrip()
+    return stripped.startswith('File "') or stripped.startswith('Traceback')
+
+
+def main(path):
+    with open(path, encoding='utf-8') as f:
+        data = json.load(f)
+
+    completed = data.get('completed', {})
+    reset_count = 0
+    total_videos = 0
+
+    for spk, speaker_state in completed.items():
+        videos = speaker_state.get('videos', {}) if isinstance(speaker_state, dict) else {}
+        for video_id, state in videos.items():
+            total_videos += 1
+            if state.get('status') != 'failed':
+                continue
+            if not looks_like_traceback(state.get('last_error')):
+                continue
+            state['attempts'] = 0
+            state['last_error'] = None
+            reset_count += 1
+
+    print(f'Reset {reset_count} stuck "failed" video entries out of {total_videos} total.')
+
+    backup_path = path + '.bak'
+    with open(path, encoding='utf-8') as f:
+        original = f.read()
+    with open(backup_path, 'w', encoding='utf-8') as f:
+        f.write(original)
+    print(f'Backed up original to {backup_path}')
+
+    with open(path, 'w', encoding='utf-8') as f:
+        json.dump(data, f, indent=2)
+    print(f'Wrote updated progress to {path}')
+
+
+if __name__ == '__main__':
+    if len(sys.argv) != 2:
+        print('Usage: python fix_stuck_failed_entries_downloader.py <path-to-progress-file>')
+        sys.exit(1)
+    main(sys.argv[1])

progress/download_progress_6_0.json

@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:e52a86bc7f702e99692b173f4e30475a703127142ba61a55b90188a98b717c5c
-size 98846915
+oid sha256:1fae1c129c80896f405419832d6a401b14a72fcb10d9c0f006e49f5a8c10aaf6
+size 81430556

progress/download_progress_6_1.json

@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:7a664927b583f8574056b53447b24f322f6245f527d0dd737f91db15b3f3c277
-size 96903963
+oid sha256:6cd297a741b6d06ae9330016503bae6ea2e3bfd1eb3b973aab01859bca68ed4b
+size 80606794

progress/download_progress_6_2.json

@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:559150eb826646805aee6658adcdccccebf1086e269bd6501c4222338b878b99
-size 97649261
+oid sha256:0a0e3e89630d0982357faf1c3f5ffa60837b4359b1a8479e0e323fcb57ace3b7
+size 80958875

progress/download_progress_6_3.json

@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:81dceb94e67f3d210c8f22542ea6c2a9efc45b67d69ea5faf8de897a0bf7b206
-size 98348512
+oid sha256:7d53bd6ff598d29a5df7b4a19632ce6815e71bcc54dcff436072a5e35bbeb3e1
+size 81171985

progress/download_progress_6_4.json

@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:209dafc19f15f983a59278d4d3709444a32bcbd31eafff6b4d4ce37284968af6
-size 99830856
+oid sha256:26c1ba1f0bf61eae92abded14773cf7590c38cc1e1df23d734a725bbd0c2a8b8
+size 81501353

progress/download_progress_6_5.json

@@ -1,3 +1,3 @@
 version https://git-lfs.github.com/spec/v1
-oid sha256:110adb16bdab0b6800f71659a67fd6e59a8acf83f864c19626e85842c15a9800
-size 98389010
+oid sha256:20fe8b5865ac05792eb6a07df6f11f571fdb2a78441cbe05e036378227aae6da
+size 81245127