patch stringlengths 18 160k | callgraph stringlengths 4 179k | summary stringlengths 4 947 | msg stringlengths 6 3.42k |
|---|---|---|---|
@@ -91,8 +91,13 @@ struct ossl_provider_st {
size_t operation_bits_sz;
CRYPTO_RWLOCK *opbits_lock;
+ /* Whether this provider is the child of some other provider */
+ const OSSL_CORE_HANDLE *handle;
+ unsigned int ischild:1;
+
/* Provider side data */
void *provctx;
+ const OSSL_DISPAT... | [No CFG could be retrieved] | The OSSL provider implementation. The object is not in use. | Might this be better conditioned out under FIPS_MODULE. |
@@ -1385,6 +1385,9 @@ def parse_options(args: List[str]) -> Options:
parser.add_argument('--include-private', action='store_true',
help="generate stubs for objects and members considered private "
"(single leading underscore and no trailing underscores)")
+ ... | [get_qualified_name->[get_qualified_name],find_module_paths_using_imports->[StubSource],ImportTracker->[reexport->[require_name]],generate_stubs->[generate_stub_from_ast,generate_asts_for_modules,collect_docs_signatures,mypy_options,collect_build_targets],main->[generate_stubs,parse_options],find_self_initializers->[Se... | Parse command line options. Options for generating a single . | Maybe update the docs with the new flag? (In a separate PR if you prefer.) |
@@ -20,12 +20,11 @@ public class GameDataUtils {
*/
public static GameData cloneGameData(final GameData data, final boolean copyDelegates) {
try {
- ByteArrayOutputStream sink = new ByteArrayOutputStream(10000);
- GameDataManager.saveGame(sink, data, copyDelegates);
- sink.close();
- fin... | [GameDataUtils->[cloneGameData->[saveGame,toByteArray,logQuietly,loadGame,ByteArrayOutputStream,close,ByteArrayInputStream,cloneGameData],translateIntoOtherGameData->[create,RuntimeException,writeObject,toByteArray,GameObjectStreamFactory,readObject,ByteArrayOutputStream,ByteArrayInputStream,GameObjectOutputStream]]] | Clone a GameData. | Would you mind merging the try-with-resource block with the outer try block? |
@@ -857,7 +857,6 @@ func (display *ProgressDisplay) processNormalEvent(event engine.Event) {
// once we start hearing about actual resource events.
payload := event.Payload.(engine.PreludeEventPayload)
- display.isPreview = payload.IsPreview
display.writeSimpleMessage(renderPreludeEvent(payload, display.opt... | [filterOutUnnecessaryNodesAndSetDisplayTimes->[filterOutUnnecessaryNodesAndSetDisplayTimes],processEvents->[processNormalEvent,processEndSteps,processTick],processEndSteps->[refreshAllRowsIfInTerminal,writeSimpleMessage,refreshSingleRow,writeBlankLine],handleSystemEvent->[refreshAllRowsIfInTerminal,writeSimpleMessage],... | processNormalEvent processes a normal event and renders it to the console. This function is called to display a single row of metadata. getNodeNode - Get node node from network. | this previous form meant you could observe a column header changing from "Status" to "Plan". There's no need for this given that all callers into the display know if we're in preview mode or not. |
@@ -403,12 +403,7 @@ public class ExpressionAnalyzer
}
break;
case TIMESTAMP:
- if (node.getPrecision() != null) {
- type = createTimestampWithTimeZoneType(node.getPrecision());
- }
- ... | [ExpressionAnalyzer->[analyzeExpressions->[getTypeOnlyCoercions,getSubqueryInPredicates,getScalarSubqueries,getWindowFunctions,analyze,getExpressionTypes,getExpressionCoercions,getExistsSubqueries,getQuantifiedComparisons,getColumnReferences],Context->[getFunctionInputTypes->[isExpectingLambda],notInLambda->[Context],i... | Visits the current time node and returns the type of the node. | Static import firstNonNull |
@@ -119,6 +119,10 @@ class Conv2D(layers.Layer):
act (str): Activation type, if it is set to None, activation is not appended.
Default: None
+ Parameters:
+ filter (Parameter): the learnable weights of filters of this layer.
+ bias (Parameter|None): the learnable bias of this la... | [Conv3D->[_build_once->[_get_default_param_initializer]],NCE->[__init__->[_init_by_numpy_array]],Conv2D->[_build_once->[_get_default_param_initializer]]] | The dilation size of the input layer. Create a random object from the n - tuple of the n - tuple of the n -. | looks like it should not be call as Parameters, call them Attributes or Members maybe better |
@@ -32,10 +32,13 @@ class Libxsmm(Package):
and small convolutions.'''
homepage = 'https://github.com/hfp/libxsmm'
- url = 'https://github.com/hfp/libxsmm/archive/1.7.1.tar.gz'
+ url = 'https://github.com/hfp/libxsmm/archive/1.8.2.tar.gz'
version('develop', git='https://github.com/hfp... | [Libxsmm->[install->[InstallError,make,manual_install],manual_install->[install,glob,mkdirp,install_tree],patch->[FileFilter,filter],variant,version]] | Creates an object with all of the fields available in the System. Create a list of all possible sequence numbers. | This package should probably be converted to a `MakefilePackage`. Then `install` would become `build`, `manual_install` would become `install`, and `patch` would become `edit`. |
@@ -113,7 +113,10 @@ module.exports = webpackMerge(commonConfig({ env: ENV }), {
parallel: true,
cache: true,
terserOptions: {
+ ecma: 6,
ie8: false,
+ toplevel: true,
+ module: true,
... | [No CFG could be retrieved] | Configures the plugin to use the given filter for missing dependencies. Plugins for the module. | why are we adding those two options ? |
@@ -259,9 +259,6 @@ int RSA_padding_check_PKCS1_OAEP_mgf1(unsigned char *to, int tlen,
* To avoid chosen ciphertext attacks, the error message should not
* reveal which kind of decoding error happened.
*/
- RSAerr(RSA_F_RSA_PADDING_CHECK_PKCS1_OAEP_MGF1,
- RSA_R_OAEP_DECODING_ERROR);
- ... | [RSA_padding_add_PKCS1_OAEP_mgf1->[EVP_sha1,OPENSSL_cleanse,EVP_Digest,memcpy,memset,RAND_bytes,EVP_MD_size,OPENSSL_malloc,OPENSSL_clear_free,PKCS1_MGF1,RSAerr],RSA_padding_add_PKCS1_OAEP->[RSA_padding_add_PKCS1_OAEP_mgf1],RSA_padding_check_PKCS1_OAEP_mgf1->[constant_time_select_8,EVP_sha1,constant_time_eq,constant_tim... | RSA_padding_check_PKCS1_OAEP_mgf1 - O private helper functions in - memory cache is not constant time. read - only version of the next non - zero value in the message. | This will break error-reporting for legitimate uses of RSA OAEP. Unlike PKCS1 v1.5 padding, OAEP does not need this fanfare to begin with. The padding check internally needs to be constant-time, but it's fine to report an error after that's all done. |
@@ -102,6 +102,7 @@ public abstract class AbstractNioByteChannel extends AbstractNioChannel {
try {
int byteBufCapacity = allocHandle.guess();
int totalReadAmount = 0;
+ boolean pendingReset = false;
do {
byteBuf = alloc... | [AbstractNioByteChannel->[NioByteUnsafe->[read->[closeOnRead,handleReadException],handleReadException->[closeOnRead]]]] | read. Read bytes until read is complete. Check if there is a race condition that can happen when reading from the socket. | `readPendingReset` might be a better name? |
@@ -174,5 +174,16 @@ namespace PythonNodeModelsWpf
{
dynamoViewModel.OpenDocumentationLinkCommand.Execute(new OpenDocumentationLinkEventArgs(new Uri(PythonNodeModels.Properties.Resources.PythonMigrationWarningUriString, UriKind.Relative)));
}
+
+ private void OnEngineChanged(object... | [ScriptEditorWindow->[OnRunClicked->[UpdateScript]]] | OnMoreInfoClicked - More info clicked. | So this is always 1 because the selection changing implies "removing" the previous item from the selection, right? |
@@ -1,9 +1,6 @@
from mypy.ordered_dict import OrderedDict
from typing import List, Optional, Tuple, Callable
-from mypy.join import (
- is_similar_callables, combine_similar_callables, join_type_list, unpack_callback_protocol
-)
from mypy.types import (
Type, AnyType, TypeVisitor, UnboundType, NoneType, Ty... | [is_overlapping_erased_types->[is_overlapping_types],is_overlapping_types->[_is_overlapping_types->[is_overlapping_types],_type_object_overlap->[_is_overlapping_types],_is_overlapping_types,is_none_typevar_overlap,get_possible_variants,_type_object_overlap],meet_type_list->[meet_types],are_tuples_overlapping->[is_overl... | Get the most specific type of a tuple or a subtype of a type. Return the declared type narrowed down to another type. | This had to be replaced with `from mypy import join`, to prevent recursive import error. |
@@ -162,6 +162,17 @@ class MetricsTest(unittest.TestCase):
outputs_counter.key.metric.name, 'metrics_user_counter_element')
self.assertEqual(outputs_counter.committed, 4)
+ # Verify user distribution counter.
+ metric_results = res.metrics().query()
+ namespace = 'apache_beam.metrics.metric_tes... | [MetricsTest->[test_user_counter_using_pardo->[SomeDoFn]]] | Test that the user counter is using the Pardo DoFn. Checks if the object with the given name has a cumulative value. | not all runners support attempted metrics, please only compare against committed metrics for now |
@@ -104,11 +104,8 @@ class ExportTask(IvyTaskMixin, PythonTask):
help='Causes libraries with javadocs to be output.')
register('--sources', type=bool,
help='Causes sources to be output.')
- # Required by IvyTaskMixin.
- # TODO: Remove this once IvyTaskMixin registers an --ivy-jvm-... | [Export->[console_output->[generate_targets_map]],ExportTask->[generate_targets_map->[process_target->[iter_transitive_jars,process_target,_exclude_id,_jar_id,get_target_type],process_target,get_preferred_distribution,resolve_jars],_resolve_jars_info->[_jar_id]]] | Register options for export task. | Coursier should probably have such an option on its subsystem (and not on the Tasks that consume it). |
@@ -61,14 +61,11 @@ class Elpa(AutotoolsPackage):
hlist.directories = [incdir]
return hlist
- build_directory = 'spack-build'
-
def configure_args(self):
spec = self.spec
options = []
- # TODO: add --enable-gpu, --disable-sse-assembly, --enable-sparc64
- # a... | [Elpa->[configure_args->[any,append,spec,extend,format],url_for_version->[str,Version,format],headers->[format,find_all_headers,join,satisfies],libs->[find_libraries],variant,depends_on,version]] | Returns a list of header names that can be used to generate a sequence of headers. | Am I getting this wrong or are we now building in-source? Why was this necessary? |
@@ -54,7 +54,7 @@ final class ApiPlatformExtension extends Extension implements PrependExtensionIn
$configuration = new Configuration();
$config = $this->processConfiguration($configuration, $configs);
- $container->setAlias('api_platform.naming.resource_path_naming_strategy', $config['naming... | [ApiPlatformExtension->[registerFileLoaders->[replaceArgument,getFileName,getParameter,getRealPath,getExtension,name],registerAnnotationLoaders->[addResource,addArgument,getParameter,getFileName],prepend->[prependExtensionConfig,getExtensionConfig],load->[setParameter,registerFileLoaders,getFormats,processConfiguration... | Loads the configuration for the API platform. This method is called when the collection is not configured to be paginated. | @Ener-Getick: > It would be weird to decorate a service defined by the user in case he uses its own path resolver, don't you think ? Isn't this what you're doing here? |
@@ -0,0 +1,11 @@
+'use strict';
+
+module.exports = {
+ 'extends': 'cesium',
+ 'env': {
+ 'browser': true
+ },
+ 'plugins': [
+ 'html'
+ ]
+};
| [No CFG could be retrieved] | No Summary Found. | none of the properties here need quotes, just the values. Please do a once over of this PR and make that change everywhere. |
@@ -14,6 +14,8 @@ class RateLimitChecker
user.articles.published.where("created_at > ?", 30.seconds.ago).size > 9
when "image_upload"
Rails.cache.read("#{user.id}_image_upload").to_i > 9
+ when "notification_subscriptions"
+ Rails.cache.read("#{use... | [RateLimitChecker->[limit_by_email_recipient_address->[size],track_image_uploads->[id,to_i,write,seconds],ping_admins_without_delay->[id,perform_now],ping_admins->[id,perform_later],limit_by_situation->[to_i,size],attr_accessor]] | Returns the limit for the given user s criticalness. | This strikes me as a pretty odd implementation. Any reason not to query for the number of notification subscriptions in the past x minutes here instead of this cache write/read situation? It seems like we have all the info to not need to rely on this. |
@@ -15,6 +15,7 @@ import (
"github.com/go-check/check"
shellwords "github.com/mattn/go-shellwords"
+ "bufio"
checker "github.com/vdemeester/shakers"
)
| [TestAccessLog->[Printf,ReadFile,HasPrefix,Sprintf,Split,MatchString,MustCompile,Kill,Remove,Start,Close,Parse,Assert,Get,Sleep,Command],Fprintf,Listen,Sprintf,HandlerFunc,Start] | TestAccessLog imports an access log and tests it Verify that the access. log output is as expected. | Please group with stdlib imports. |
@@ -29,9 +29,12 @@ namespace Pulumi
/// continuously, asynchronously loop, waiting for these tasks to complete, and only
/// exiting once the set becomes empty.
/// </summary>
- private readonly Dictionary<Task, List<string>> _inFlightTasks = new Dictionary<Task, List<s... | [Deployment->[Runner->[WhileRunningAsync->[LoggedErrors,Clear,TrySetCanceled,ForEach,Count,RunContinuationsAsynchronously,LogDebug,TrySetResult,Remove,Keys,TrySetException,ConfigureAwait,AddRange,Decrement],RunAsync->[stackFactory,GetService,nameof,RegisterPropertyOutputs,WhileRunningAsync,RegisterTask,FullName,HandleE... | Creates a class that runs a single type of task that is part of the application. RunAsync - Async method that creates a new stack. | Curious if this list I put here and the `_exceptions` list are still necessary or if they can be lifted into your `TaskExceptionTracker` since that also contains a list of exceptions? I guess this immutable list might still be necessary on the `IRunner` interface but maybe the `_exceptions` one can be lifted and the `T... |
@@ -244,6 +244,14 @@ func (c Config) MinimumServiceDuration() models.Duration {
return c.getDuration("MinimumServiceDuration")
}
+// EthBalanceMonitorBlockDelay is the number of blocks that the balance monitor
+// trails behind head. This is required e.g. for Infura because they will often
+// announce a new head,... | [DefaultHTTPTimeout->[getDuration],Set->[Set],Generate->[RootDir],DatabaseTimeout->[getDuration],tlsDir->[RootDir],CreateProductionLogger->[LogLevel,RootDir,CreateProductionLogger,LogToDisk,JSONConsole],KeyFile->[TLSKeyPath,tlsDir],MinimumServiceDuration->[getDuration],SessionOptions->[SecureCookies],SessionTimeout->[g... | MinimumServiceDuration returns the minimum service duration for the service. | As a node operator, how do I decide what value to set this env var at? |
@@ -190,7 +190,7 @@ function get_user($user_id)
{
foreach (get_userlist() as $users) {
if ($users['user_id'] === $user_id) {
- return $users['username'];
+ return $users;
}
}
return 0;
| [No CFG could be retrieved] | get_user - get username of user. | Same here, are you breaking other get_user() calls? |
@@ -468,7 +468,17 @@ public class CopySource extends AbstractSource<String, FileAwareInputStream> {
weight = ((CopyableFile) copyEntity).getOrigin().getLen();
}
weight = Math.max(weight, minWeight);
- workUnit.setProp(WORK_UNIT_WEIGHT, Long.toString(weight));
+ workUnit.setProp(ConfigurationKeys.... | [CopySource->[createRequestAllocator->[createRequestAllocator],submitUnfulfilledRequestEvents->[submitUnfulfilledRequestEventsHelper]]] | Compute and set the work unit weight. | We should think about where the correct location is for adding block locations. The approach you have would work, but is very Distcp-specific. Can we have the logic of fetching block locations inside the GobblinWorkUnitsInputFormat, so that other sources can benefit from it ? |
@@ -507,7 +507,7 @@ public class Jenkins extends AbstractCIBase implements DirectlyModifiableTopLeve
/**
* The holder of the set of installed cluster nodes.
*
- * @since 1.FIXME
+ * @since 1.607
*/
private transient final Nodes nodes = new Nodes(this);
| [Jenkins->[getAllItems->[getAllItems],getUser->[get],setNumExecutors->[updateComputerList],getPlugin->[getPlugin],getViewActions->[getActions],getJDK->[getJDKs],getCloud->[getByName],getStaplerFallback->[getPrimaryView],getViews->[getViews],doDoFingerprintCheck->[cleanUp,isUseCrumbs],checkJobName->[getItem,checkGoodNam... | Creates a list of all active and active clouds. A viewMixIn that is a mix - in of the main view. | Or just delete the tag, since this is not part of the API. |
@@ -10,6 +10,8 @@ import {
refreshSnippetEditor,
} from "./redux/actions/snippetEditor";
import "./helpers/babel-polyfill";
+import { isGutenbergDataAvailable } from "./helpers/isGutenbergAvailable";
+import {debounce} from "lodash";
( function() {
var modifiableFields = [
| [No CFG could be retrieved] | Creates a YoastReplaceVarPlugin that replaces all the placeholders and their replacements. add replacements for all the tokens in the system. | Add spaces inside curly braces. |
@@ -11,6 +11,11 @@
<%= favicon_link_tag SiteConfig.favicon_url %>
<title><%= controller_name.titleize %></title>
+ <!-- StimulusJS -->
+ <%= javascript_pack_tag "manifest", defer: true %>
+ <%= javascript_pack_tag "vendor", defer: true %>
+ <%= javascript_pack_tag "internal", defer: true %>
+
<script src... | [No CFG could be retrieved] | Return a list of all components of a n - item object. Displays a navbar with a list of all messages in the system. | how big is vendor? I wonder if we could have a `internal-vendor` separated from the general `vendor`, not for this PR, but as a general idea |
@@ -124,6 +124,7 @@ ini_config_types: Final[Dict[str, _INI_PARSER_CALLABLE]] = {
'cache_dir': expand_path,
'python_executable': expand_path,
'strict': bool,
+ 'exclude': lambda s: [p.strip() for p in s.split('\n') if p.strip()],
}
# Reuse the ini_config_types and overwrite the diff
| [split_and_match_files_list->[expand_path],split_and_match_files->[split_and_match_files_list],get_config_module_names->[is_toml],mypy_comments_to_config_map->[split_directive],parse_mypy_comments->[parse_section,mypy_comments_to_config_map],split_and_match_files_list,expand_path,parse_version,check_follow_imports,try_... | Initialize the types for values that are initialized to None or container types. Parse a config file into a configuration object. | Possible root cause for #11825? |
@@ -128,12 +128,18 @@ namespace PInvokeTests
[DllImport("LayoutClassNative")]
private static extern bool SimpleSeqLayoutClassByRef(SeqClass p);
+ [DllImport("LayoutClassNative")]
+ private static extern bool SimpleSeqLayoutClassByRefNull([In, Out] Blittable p);
+
[DllImport("L... | [StructureTests->[BlittableClassByInAttr->[ValidateBlittableClassInOut],SealedBlittableClassByInAttr->[ValidateSealedBlittableClassInOut],ExplicitClass->[SimpleExpLayoutClassByRef],Main->[BlittableClassByInAttr,SealedBlittableClassByInAttr,ExplicitClass,SealedBlittableClassByOutAttr,SequentialClass,SealedBlittableClass... | Returns true if a layout class with the given name has a sequence or expression that has a. | `SeqClass` instead of `Blittable`? |
@@ -480,7 +480,16 @@ class TestConan(ConanFile):
self.assertIn("set(CONAN_LIBS_HELLO1 mycoollib)", cmakeinfo)
self.assertIn("set(CONAN_LIBS mycoollib ${CONAN_LIBS})", cmakeinfo)
- def export_pkg_json_test(self):
+ def test_export_pkg_json(self):
+
+ def _check_json_output_no_folder():
+... | [ExportPkgTest->[export_pkg_json_test->[_check_json_output],test_new->[_consume],json_with_dependencies_test->[_check_json_output]]] | Test with dependencies. Checks if the user has installed a specific and if it is exports it to a JSON Check if the missing package folder or package folder is present in the json output. | When the build folder is absent and json output is required, now, it will provide only an empty json file with error=True. |
@@ -267,7 +267,9 @@ class CarInterface(CarInterfaceBase):
# intercepting the DSU is a community feature since it requires unofficial hardware
ret.communityFeature = ret.enableGasInterceptor or ret.enableDsu or smartDsu
- if ret.enableGasInterceptor:
+ if ret.enableGasInterceptor and candidate in NO_AU... | [CarInterface->[apply->[update],update->[update]]] | Get the standard parameters for a specific candidate. This function returns the sensitivity parameter of a single node. 15. 8 is spec end - to - end Demonstration of the algorithm for the missing parameters. | why was this added? |
@@ -42,9 +42,8 @@ func init() {
// interface methods except for Fetch.
type MetricSet struct {
mb.BaseMetricSet
- log *logp.Logger
- fetcher *mssql.Fetcher
- db *sql.DB
+ log *logp.Logger
+ db *sql.DB
}
// New creates a new instance of the MetricSet. New is responsible for unpacking
| [Close->[Close],Fetch->[Wrapf,Error,Sprintf,Debug,Next,Apply,Close,Wrap,Event,Scan,TrimSpace,Query],DefaultMetricSet,Beta,NewLogger,MustAddMetricSet,NewConnection,Wrap,HostData,WithHostParser,With] | New creates a new instance of the given metric set. Fetch returns the event which is then forward to the output. | This was the reference that needed to be removed after deleting `fetcher.go` |
@@ -56,11 +56,13 @@ public abstract class LookupResult {
@Nullable
public abstract Map<Object, Object> multiValue();
+
+ @JsonProperty("has_error")
+ public abstract boolean hasError();
+
/**
* The time to live (in milliseconds) for a LookupResult instance. Prevents repeated lookups for the... | [LookupResult->[withoutTTL->[cacheTTL],isEmpty->[multiValue,singleValue],withDefaults->[multiValue,single],Builder->[multiSingleton->[multiValue],single->[singleValue]]]] | Returns a map of all items in the cache that are not a . | I was wondering if we might want to use an error message (or a list of error messages) instead of a simple flag. That way consumers of the lookup table API would be able to better communicate issues to the user. (e.g. showing the error message in the frontend for debugging) What do you think? |
@@ -0,0 +1,12 @@
+from spack import *
+
+
+class PyZcBuildout(PythonPackage):
+ """System for managing development buildouts"""
+
+ homepage = "http://buildout.org/"
+ url = "https://pypi.io/packages/source/z/zc.buildout/zc.buildout-2.13.1.tar.gz"
+
+ version('2.13.1', sha256='3d14d07226963a517295dfad5... | [No CFG could be retrieved] | No Summary Found. | You accidentally deleted the license |
@@ -48,7 +48,13 @@ namespace Content.Server.Medical.Components
return true;
}
- EntitySystem.Get<DamageableSystem>().TryChangeDamage(eventArgs.Target.Uid, Damage, true);
+ var scale = 1;
+ if (eventArgs.User.GetComponent<InventoryComponent>().TryGetSlotIt... | [HealingComponent->[AfterInteract->[Use,TryChangeDamage,InRangeUnobstructed,User,Target,Uid,Owner,CanInteract],ReadWrite]] | Checks if a DamageableComponent can be changed to Damage and if so. | don't assume the user has an inventory |
@@ -177,8 +177,8 @@ RSpec.describe Homepage::ArticlesQuery, type: :query do
article1.update_columns(comments_count: 1)
article2.update_columns(comments_count: 2)
- result = described_class.call(sort_by: :comments_count, sort_direction: :desc).ids
- expect(result).not_to eq([article2.id... | [to,create,include,ids,be_a,let,describe,match_array,save,update_columns,not_to,stub_const,eq,create_list,add,it,require,id] | Updates the article columns. | Rubocop rightly warned me that this is horrible style. |
@@ -42,6 +42,7 @@ class LatControlPID():
output_steer = self.pid.update(angle_steers_des, CS.steeringAngleDeg, check_saturation=check_saturation, override=CS.steeringPressed,
feedforward=steer_feedforward, speed=CS.vEgo, deadzone=deadzone)
pid_log.active = True
+ ... | [LatControlPID->[reset->[reset],update->[reset,update]]] | Update the state of the object based on the given parameters. Returns the values of the Nested Nested Nested Nested Nested Nested Nested Nested Nested Nested Nested Nested Nested. | Think we can always set the value, even when the controller is not active. Just move this line to above the if statement. |
@@ -27,6 +27,11 @@ buildscript {
apply plugin: com.google.cloud.tools.jib.gradle.JibPlugin
+task copyWwwIntoStatic (type: Copy) {
+ from 'build/www/'
+ into 'build/resources/main/static'
+}
+
jib {
from {
image = '<%= DOCKER_JAVA_JRE %>'
| [No CFG could be retrieved] | Produces a list of all packages that are referenced by a specific object. | I think this can be guarded by `<%_ if (!skipClient) { _%>` as we don't need to do that when there is no client. Also it should be `'<%= CLIENT_DIST_DIR %>'` instead of hard coded `build/www` I think. |
@@ -610,6 +610,18 @@ public final class JCache<K, V> implements Cache<K, V> {
return ReflectionUtil.unwrap(this, clazz);
}
+ @Override
+ public void registerCacheEntryListener(CacheEntryListenerConfiguration<K, V> listenerCfg) {
+ notifier.addListener(listenerCfg, this, notifier, cache);
+ ad... | [JCache->[checkNotClosed->[isClosed],getAndPut->[call],getName->[getName],setCacheLoader->[setCacheLoader],WithProcessorLock->[call->[acquiredProcessorLock,call,releaseProcessorLock]],get->[call],remove->[call->[remove],call,remove,lockRequired],doGet->[get],removeAll->[call->[remove],call,get,remove,lockRequired],Itr-... | Unwraps the cache object. | Kinda nitpicking here but if you have addCacheEntryListenerConfiguration then add removeCacheEntryListenerConfiguration just to be nice and symmetric... |
@@ -74,7 +74,7 @@ abstract class SuluTestCase extends BaseTestCase
/**
* Create an authenticated client
*
- * @return Symfony\Bundle\FrameworkBundle\Client
+ * @return \Symfony\Bundle\FrameworkBundle\Client
*/
protected function createAuthenticatedClient()
{
| [SuluTestCase->[createAuthenticatedClient->[createClient],createWebsiteClient->[createClient],purgeDatabase->[getOm,executeUpdate,purge,setReferenceRepository,getConnection,getDriver],getTestUserId->[findOneByUsername,getId],tearDown->[close],initPhpcr->[getPhpcrSession,addMixin,get,getKey,setProperty,getStructures,add... | Creates a authenticated client if it doesn t exist. | If you already worked on it anyway, don't you want to use this class as well? |
@@ -52,7 +52,7 @@ func newConfigCmd() *cobra.Command {
cmd.PersistentFlags().StringVarP(
&stack, "stack", "s", "",
- "Choose an stack other than the currently selected one")
+ "Target a specific stack instead of all stacks")
cmd.PersistentFlags().BoolVar(
&unset, "unset", false,
"Unset a configuration ... | [Strings,Printf,Sprintf,Contains,RunFunc,StringVarP,String,Errorf,ParseModuleMember,ModuleMember,Assert,Wrap,HasPrefix,PersistentFlags,BoolVar] | newConfigCmd returns a new command that can be used to set or delete a configuration value prettyKey returns the name of the last known node in the stack or an error if the. | `... instead of all of this project's stacks`? |
@@ -44,7 +44,6 @@ def register_macros():
'callback' in dir(sys.modules[m]) and
not m.endswith('_test')
and not m.startswith('__')]
- print(macro_modules)
for macro_module in macro_modules:
register(name=macro_module.name,
| [register->[register],MacroRegister->[__iter__->[load_macros],find->[load_macros],__contains__->[load_macros]],MacroRegister] | Register all macros. | There was a hack introduced long time back to solve the problem where macros were not getting loaded for celery jobs. I am not sure if `print` was the hack or not. But it would be worth checking if the macro functionality works fine with celery jobs or not? |
@@ -1868,9 +1868,9 @@ function $ParseProvider() {
if (isFunction(listener)) {
listener(value, old, scope);
}
- if (isDefined(value)) {
+ if (doneCriteria(value)) {
scope.$$postDigest(function() {
- if (isDefined(lastValue)) {
+ if (doneCriteria... | [No CFG could be retrieved] | Creates a watch delegates object equality and input values. A function to unwatch a constant. | Nit: Not directly related to this PR, but I think it makes sense to exit early once an undefined value is found. |
@@ -194,6 +194,8 @@ def _create_logger(name: str) -> logging.Logger:
Returns:
- logging.Logger: a configured logging object
"""
+ with Path("/tmp/logging-trace.txt").open("at") as fh:
+ fh.write(f"_create_logger: {name}\n")
logging.setLogRecordFactory(_log_record_context_injector)
... | [RedirectToLog->[flush->[flush],__init__->[get_logger]],CloudHandler->[_monitor->[batch_upload],emit->[put],start->[start],__del__->[flush],put->[put]],_create_logger->[CloudHandler],configure_logging->[_create_logger],configure_extra_loggers->[_create_logger],configure_logging,configure_extra_loggers] | Creates a logger with a StreamHandler that has level and formatting set from prefect. | Consider removing this |
@@ -374,6 +374,12 @@ describes.sandboxed('UrlReplacements', {}, () => {
});
});
+ it('should replace TIMESTAMP_FORMATTED', () => {
+ return expandAsync('?tsf=TIMESTAMP_FORMATTED').then(res => {
+ expect(res).to.match(/tsf=\d+/);
+ });
+ });
+
it('should replace TIMEZONE', () => {
return e... | [No CFG could be retrieved] | This function is used to test if the given parameters are identical to the given parameter. Find all possible window - related options and replace them with the correct values. | please fake a time and test with real numbers. |
@@ -8,14 +8,16 @@ type FakeConfigurator struct {
PrometheusScraping bool
ZipkinTracing bool
MeshCIDRRanges []string
+ useHTTPSIngress bool
}
// NewFakeConfigurator create a new fake Configurator
-func NewFakeConfigurator() Configurator {
+func NewFakeConfigurato... | [No CFG could be retrieved] | GetConfigMap returns a Configurator that returns the data stored in the configMap. GetMeshCIDRRanges returns a list of mesh CIDR ranges that are not yet tracked. | any reason to make this configurable only for ingress? (is it worth it considering everything else is not?) |
@@ -88,10 +88,15 @@ public class AddAclBucketHandler extends Handler {
OzoneObj.StoreType.valueOf(storeType))
.build();
- boolean result = client.getObjectStore().addAcl(obj,
+ boolean aclExisted = client.getObjectStore().checkAclExist(obj,
OzoneAcl.parseAcl(acl));
-
- System.o... | [AddAclBucketHandler->[call->[OzoneAddress,createClient,addAcl,build,createOzoneConfiguration,close,getBucketName,isVerbose,requireNonNull,ensureBucketAddress,parseAcl,printf,getVolumeName]]] | This method adds the new acl to the object store. | I think we don't need a checkAclExist addAcl semantic true, acl is added successfully, false means acl already exist that is why we cannot add it. So, no need of checkAclExist() |
@@ -33,7 +33,7 @@ class Notify extends BaseRepository
/** @var BaseURL */
protected $baseUrl;
- /** @var IConfig */
+ /** @var \Friendica\Core\Config\Capability\IManageConfigValues */
protected $config;
/** @var Emailer */
| [Notify->[selectAllForUser->[selectForUser],createFromNotification->[storeAndSend,existsForUser],selectOneById->[selectOne],save->[selectOneById],selectForUser->[select],storeAndSend->[save]]] | Constructor for a single node of a system. Select one from the database. | You can use the shorthand since there is a `use` statement. |
@@ -60,8 +60,8 @@ public final class SslContextFactory {
} else {
trustStore = null;
}
- final TrustManagerFactory trustManagerFactory = TrustManagerFactory.getInstance(TrustManagerFactory.getDefaultAlgorithm());
- trustManagerFactory.init(trustStore);
+
... | [SslContextFactory->[createSslContext->[hasKeystoreProperties,FileInputStream,getProperty,init,getKeyManagers,isNotBlank,hasTruststoreProperties,getTrustManagers,setNeedClientAuth,getTrustStore,getInstance,SslContextCreationException,getKeyStore,toCharArray,getDefaultAlgorithm,load],hasKeystoreProperties->[isNotBlank,g... | Creates an SSL context based on the given properties. Returns a new SSL context. | The behavior implemented in this PR is that if OCSP is configured, it is configured and used universally across the application. Is there any plan for or expected need for `SSLContext` instances which _do not_ use OCSP in this case? |
@@ -515,6 +515,11 @@ func PrepareWebhooks(repo *Repository, event HookEventType, p api.Payloader) err
if err != nil {
return fmt.Errorf("GetSlackPayload: %v", err)
}
+ case DISCORD:
+ payloader, err = GetDiscordPayload(p, event, w.Meta)
+ if err != nil {
+ return fmt.Errorf("GetSlackPayload: %v", e... | [EventsArray->[HasPushEvent,HasCreateEvent,HasPullRequestEvent],deliver,HasPushEvent,HasCreateEvent,HasPullRequestEvent] | GetActiveWebhooksByRepoID returns the last hook that is active on the given repo Record delivery information. | Discord, not Slack |
@@ -1114,7 +1114,7 @@ namespace System.Reflection.Emit
#endregion
#region IL Macros
- public virtual void ThrowException(Type excType)
+ public virtual void ThrowException([DynamicallyAccessedMembers(DynamicallyAccessedMemberTypes.PublicConstructors)] Type excType)
{
... | [__ExceptionInfo->[MarkFaultAddr->[MarkHelper],MarkCatchAddr->[MarkHelper],MarkHelper->[EnlargeArray],MarkFinallyAddr->[MarkHelper],MarkFilterAddr->[MarkHelper],IsInner->[GetEndAddress]],ILGenerator->[EnlargeArray->[EnlargeArray],AddFixup->[EnlargeArray],EmitCall->[GetMethodToken,PutInteger4,EnsureCapacity,UpdateStackS... | Throw an exception of the specified type. | Shouldn't this be `DynamicallyAccessedMemberTypes.DefaultConstructor`? The code is calling `excType.GetConstructor(Type.EmptyTypes)`, which will only pick the default constructor. |
@@ -135,12 +135,6 @@ class GlobalOptionsRegistrar(Optionable):
help='Enables use of the v2 engine.')
# These facilitate configuring the native engine.
- register('--native-engine-version', advanced=True,
- default=pkg_resources.resource_string('pants.engine', 'native_engine_version')... | [GlobalOptionsRegistrar->[register_options->[register_bootstrap_options]]] | Register bootstrap options. Register options that require a specific cache. Returns a sequence number that can be used to track the current state of a pants node Options that can be used by the command line. | I suppose since these are largely obscured from users in general it's fine to yank these without a deprecation cycle. |
@@ -216,7 +216,10 @@ func rawTest(t *testing.T, ctx *APITestContext, little, big, littleLFS, bigLFS s
req = NewRequest(t, "GET", path.Join("/", username, reponame, "/raw/branch/master/", littleLFS))
resp = session.MakeRequest(t, req, http.StatusOK)
assert.NotEqual(t, littleSize, resp.Body.Len())
- assert.... | [RemoveAll,CommitChangesWithArgs,QueryEscape,PathEscape,MakeRequestNilResponseRecorder,TempFile,Now,False,TempDir,Close,UserPassword,AddChanges,Short,AddChangesWithArgs,NotNil,Len,Skip,NotEqual,EqualValues,Join,Equal,Contains,Name,GitPath,NewCommand,NoError,RunInDir,Read,Base,GetUserByName,Write,AddArguments,Sprintf,Fo... | rawTest tests if the user has the necessary permissions to access the branch s meta file identifier mediaTest tests if the response body contains a LFSMetaFileIdentifier. | This condition is already asserted above, right? Can't we check for the exact expected length? Are there tests for small and large files? |
@@ -274,7 +274,7 @@
xi = location.x_index; // Just to shrink the next few lines and make them easier to understand
yi = location.y_index;
- if (g26_debug_flag) {
+ if (g26_Debug_flag) {
SERIAL_ECHOPGM(" Doing circle at: (xi=");
SERIAL_ECHO(xi);
SERIA... | [No CFG could be retrieved] | Find the closest circle to print. The angle of the edge in the cirlce is the angle of the top - side. | Sorry about the volume of variable renames. They're all lowercase now. |
@@ -65,7 +65,7 @@ class Binance(Exchange):
rate = self.price_to_precision(pair, rate)
- order = self._api.create_order(symbol=pair, type=ordertype, side='sell',
+ order = self._api.create_order(symbol=pair, type=ordertype, side=side,
amo... | [Binance->[stoploss->[InvalidOrderException,amount_to_precision,create_dry_run_order,price_to_precision,get,update,create_order,copy,_log_exchange_response,DDosProtection,TemporaryError,OperationalException,info,InsufficientFundsError],stoploss_adjust->[float],retrier],getLogger] | Create a stoploss limit order. Tries to place a new order on market pair. | I know i'm picky ... but (for futures, at least) you'll need to call `set_leverage` before this call (also in FTX)... |
@@ -499,7 +499,6 @@ collisionMoveResult collisionMoveSimple(Environment *env, IGameDef *gamedef,
info.type = COLLISION_NODE;
info.node_p = nearest_info.position;
- info.bouncy = bouncy;
info.old_speed = *speed_f;
// Set the speed component that caused the collision to zero
| [No CFG could be retrieved] | Get the nearest node info from the collider. Special case for the N - point case where the N - point is not a collision. | there are affected but never used since 2012 it's why i removed them from code |
@@ -255,10 +255,14 @@ namespace System.Runtime.CompilerServices
[DebuggerStepThrough]
private static object? IsInstanceOfClass(void* toTypeHnd, object? obj)
{
- if (obj == null || RuntimeHelpers.GetMethodTable(obj) == toTypeHnd)
+ if (obj == null)
+ return... | [CastHelpers->[IsInstanceOfAny->[IsInstanceOfAny_NoCacheLookup],ChkCastClassSpecial->[ChkCast_Helper],IsInstance_Helper->[IsInstanceOfAny_NoCacheLookup],ChkCast_Helper->[ChkCastAny_NoCacheLookup],ChkCastInterface->[ChkCast_Helper],LdelemaRef->[ThrowArrayMismatchException],StelemRef_Helper_NoCacheLookup->[WriteBarrier,I... | Checks if obj is an instance of type - equivalent to object. | Any numbers for this change? |
@@ -65,5 +65,10 @@ class ConsumerTrackingPipelineVisitor(PipelineVisitor):
self.root_transforms.add(applied_ptransform)
self.step_names[applied_ptransform] = 's%d' % (self._num_transforms)
self._num_transforms += 1
+
for side_input in applied_ptransform.side_inputs:
- self.views.append(side_i... | [ConsumerTrackingPipelineVisitor->[visit_transform->[list,append,value_to_consumers,isinstance,add],__init__->[set]]] | Visit a applied_ptransform. | Here we may want to only append rather than rebuild all of `self.views`? An idea is that we may want to keep `self._views = set()`, add views to the set, and add a `@property` that returns the set as a list? (no need to implement this way, but we do want to make sure that we are not dropping elements from 'views' that ... |
@@ -17,10 +17,12 @@ classes = ['field monospace usa-input one-time-code-input']
classes << local_assigns.delete(:class) if local_assigns[:class]
%>
+
<%= text_field_tag(
name,
nil,
'aria-invalid': 'false',
+ 'aria-label': 'code',
'data-transport': transport,
pattern: numeric ? '[0-9]*' : '[a-zA-Z0-... | [No CFG could be retrieved] | Generalized version of the standard one - time code input tag. | This will override the `<label>One-time security code</label>` label. Do we want that? If we do, we should translate this too, since it's announced to assistive technology. |
@@ -102,10 +102,15 @@ func NewMemcachedClient(cfg MemcachedClientConfig, name string, r prometheus.Reg
serverList: selector,
hostname: cfg.Host,
service: cfg.Service,
- provider: dns.NewProvider(util.Logger, dnsProviderRegisterer, dns.GolangResolverType),
+ logger: logger,
+ provider: dns.NewPr... | [Set->[Set],updateMemcacheServers->[Set],updateLoop->[Stop]] | NewMemcachedClient creates a new instance of a memcached client. Set - sets an item in memcached. | Constant label here as well. |
@@ -542,7 +542,7 @@ func RenderCrossReferenceIssueIndexPattern(rawBytes []byte, urlPrefix string, me
func renderSha1CurrentPattern(rawBytes []byte, urlPrefix string) []byte {
ms := Sha1CurrentPattern.FindAllSubmatch(rawBytes, -1)
for _, m := range ms {
- all := m[0]
+ all := m[1]
if com.StrTo(all).MustInt() >... | [Image->[Image],Link->[Link],ListItem->[ListItem]] | RenderCrossReferenceIssueIndexPattern renders issue indexes from other repositories to corresponding links. renders issue index pattern cross reference issue pattern full sha1 current pattern full sha1 current. | I think we should not call it `all` now that it right fully catch only the commitId/sha1. |
@@ -252,6 +252,12 @@ function determineBuildTargets(fileName = 'build-targets.js') {
.join(', ')
)
);
+ if (isTravisBuild() && buildTargets.has('PACKAGE_UPGRADE')) {
+ console.log(
+ `${fileLogPrefix} Since this PR contains package upgrade(s), running all checks...`
+ );
+ ALL_TARGETS.fo... | [No CFG could be retrieved] | This function exports the build targets that are not in the build targets list. | Can we move this to the beginning of `determineBuildTargets` for an earlier return? |
@@ -60,6 +60,9 @@ class Trainer(TrainerBase):
should_log_learning_rate: bool = False,
log_batch_size_period: Optional[int] = None,
moving_average: Optional[MovingAverage] = None,
+ distributed: bool = False,
+ rank: int = 0,
+ world_size: int = 1,
) -> None:
... | [Trainer->[rescale_gradients->[rescale_gradients],train->[_validation_loss,_train_epoch],_validation_loss->[batch_loss],_train_epoch->[rescale_gradients,batch_loss],from_params->[from_params]]] | Initialize a new object with a base base for all of the base classes. A Pytorch Optimizer that can optimize the last n - tuple of the last n This function is used to initialize a checkpointer and serialize the models at the end of every Initialize a new object. | Please could you add these arguments to the docstring below :) Also it would be nice to mention that the cuda_device parameter will have been modified to be equal to the rank if we're doing distributed training. |
@@ -200,9 +200,9 @@ static inline int millisec_to_samplecount( int millisec )
return (int) (millisec * ((double)TZX_WAV_FREQUENCY / 1000.0));
}
-static inline int tcycles_to_samplecount( int tcycles )
+static inline int tcycles_to_samplecount( int tcycles, double t_scale )
{
- return (int) ((0.5 + (((double)TZX_W... | [No CFG could be retrieved] | This function assumes that the wave data has already been read. This function handles the input of a TZX - CAS block. | The cast is unnecessary if `t_scale` is a `double`. |
@@ -597,7 +597,7 @@ int EVP_EncryptUpdate(EVP_CIPHER_CTX *ctx, unsigned char *out, int *outl,
return ret;
- /* TODO(3.0): Remove legacy code below */
+ /* Code below to remove when legacy support is dropped. */
legacy:
return evp_EncryptDecryptUpdate(ctx, out, outl, in, inl);
| [No CFG could be retrieved] | This function is called to update the contents of the buffer with the contents of the buffer. This function is called from the extended version of EVP_EncryptFinal. It checks the. | to **be removed** |
@@ -47,7 +47,8 @@ describe('Static Template', () => {
expect(p.nextSibling).to.be.null;
});
- it('creates tree with last ownerDocument', () => {
+ // TODO(alanorozco): Unsure about what to do with this test.
+ it.skip('creates tree with last ownerDocument', () => {
// Setup
const if... | [No CFG could be retrieved] | Package that contains a list of conditions that can be used to generate a static html tree. Requires that the first element in the DOM is present. | Delete it now that it's a service. |
@@ -34,13 +34,11 @@ logger = logging.getLogger(__name__)
def extract_params(query, names):
findall = re.findall('([\w]+):\(([\w\s]+)\)', query)
params = {name: value for (name, value) in findall if name in names}
- result = re.search('^\(([\w\s]+)\)', query)
- if result:
- params['text'] = resul... | [PaImgDatalayer->[find->[extract_params],_parse_hits->[_parse_doc],find_one_raw->[_parse_doc]]] | Extract params from query. | Not used anymore, can be deleted |
@@ -377,4 +377,17 @@ public class KsqlEngineTest {
verify(mockKsqlSerde);
}
+
+ @Test
+ public void shouldSetPropertyInRunScript() {
+ final Map<String, Object> overriddenProperties = new HashMap<>();
+ final List<QueryMetadata> queries
+ = ksqlEngine.buildMultipleQueries(
+ "SET 'auto.o... | [KsqlEngineTest->[shouldCleanUpInternalTopicSchemasFromSchemaRegistry->[endRecord,terminateQuery,equalTo,QueryId,register,emptyMap,contains,assertThat,buildMultipleQueries],shouldUpdateReferentialIntegrityTableCorrectly->[createQueries,getQueriesWithSink,equalTo,mkSet,getMetaStore,assertThat,getQueriesWithSource],shoul... | Should use a serializer supplier to build queries. | nit: don't need this as the next line will fail |
@@ -322,7 +322,7 @@ public class JoinNodeTest {
setupStream(right, rightSchemaKStream);
final JoinNode joinNode =
- new JoinNode(nodeId, OUTER, joinKey, true, left, right, WITHIN_EXPRESSION, "KAFKA");
+ new JoinNode(nodeId, OUTER, joinKey, true, left, right, WITHIN_EXPRESSION, "KAFKA"... | [JoinNodeTest->[buildJoin->[buildJoin,buildStream,build,buildJoinNode,KSPlanBuilder],shouldReturnCorrectSchema->[build,getSchema,JoinNode,is,assertThat],shouldResolveUnaliasedSelectStarByCallingAllSourcesWithValueOnlyFalse->[of,assertThat,thenReturn,toList,JoinNode,empty,contains,collect,resolveSelectStar],shouldPerfor... | Test if stream should perform outer join. | nit: white space changes in this file. |
@@ -175,7 +175,7 @@ class AdSenseNetworkConfig {
*/
isResponsiveEnabled(win) {
const branch = getAdSenseAmpAutoAdsResponsiveExperimentBranch(win);
- return branch != AdSenseAmpAutoAdsResponsiveBranches.CONTROL;
+ return branch != AdSenseAmpAutoAdsResponsiveBranches.EXPERIMENT;
}
/** @override ... | [No CFG could be retrieved] | Get the attributes of an AMP network. The default ad constraints for the doubleclick network. | Perhaps I'm reading this wrong but looks to me like previously isResponsiveEnabled would have returned true for all of the traffic that was not in either the experiment or control, no? |
@@ -756,6 +756,11 @@ int EC_POINT_get_affine_coordinates_GFp(const EC_GROUP *group,
EC_R_INCOMPATIBLE_OBJECTS);
return 0;
}
+ if (EC_POINT_is_at_infinity(group, point)) {
+ ECerr(EC_F_EC_POINT_GET_AFFINE_COORDINATES_GFP,
+ EC_R_POINT_AT_INFINITY);
+ return 0;
+... | [EC_POINT_dup->[EC_POINT_new,EC_POINT_free,EC_POINT_copy],EC_POINT_mul->[EC_POINTs_mul],EC_GROUP_cmp->[EC_GROUP_get_curve_name,EC_METHOD_get_field_type],EC_GROUP_clear_free->[EC_pre_comp_free],EC_GROUP_free->[EC_pre_comp_free],EC_GROUP_dup->[EC_GROUP_new,EC_GROUP_free,EC_GROUP_copy]] | EC_POINT_GET_AFFINE_COORDINATES_GFp. | Does returning an error where it didn't previously constitute a change in API? |
@@ -66,12 +66,11 @@ void WbFieldDoubleSpinBox::stepBy(int steps) {
value += pow(10, -mDecimals) * steps;
break;
case RADIANS: {
- // angle in radians: change by pi/24 and snap to pi/24 if close by 1%
+ // angle in radians: change by pi/24 and snap to the nearest multiple of PI
value ... | [No CFG could be retrieved] | Sets the value of the double - precision double - precision double - precision double - precision double find the last decimal position in the text and change it to the last decimal position in the. | Don't worry about this, periodically we sync master and develop branches. |
@@ -22,7 +22,7 @@
if (timeToBeReceivedMappings.TryGetTimeToBeReceived(context.Message.MessageType, out timeToBeReceived))
{
context.AddDeliveryConstraint(new DiscardIfNotReceivedBefore(timeToBeReceived));
- context.SetHeader(Headers.TimeToBeReceived, timeToBeRec... | [ApplyTimeToBeReceivedBehavior->[Task->[MessageType,AddDeliveryConstraint,SetHeader,TryGetTimeToBeReceived,ToString,TimeToBeReceived,next],timeToBeReceivedMappings]] | This method is overridden to add a time - to - received constraint to the message. | Is this safe? Shouldn't we use a well defined format? It would use the culture.. |
@@ -25,6 +25,7 @@ import static io.netty.buffer.SizeClasses.LOG2_QUANTUM;
final class PoolSubpage<T> implements PoolSubpageMetric {
final PoolChunk<T> chunk;
+ final int elemSize;
private final int pageShifts;
private final int runOffset;
private final int runSize;
| [PoolSubpage->[free->[removeFromPool,addToPool,setNextAvail],findNextAvail->[findNextAvail0],getNextAvail->[findNextAvail],allocate->[toHandle,removeFromPool,getNextAvail],destroy->[destroy],addToPool]] | Creates a new instance of the pool subpage metric class. Private methods for the pool subpage. | strictly speaking this is not required by this change but while I did debug I noticed this can be final so I changed it within this PR |
@@ -165,6 +165,17 @@ int EVP_PKEY_gen(EVP_PKEY_CTX *ctx, EVP_PKEY **ppkey)
if (ctx->op.keymgmt.genctx == NULL)
goto legacy;
+ /*
+ * Asssigning gentmp to ctx->keygen_info is something our legacy
+ * implementations do. Because the provider implementations aren't
+ * allowed to reach into... | [No CFG could be retrieved] | This function is called by the OSSL engine to generate a new key. Check if a key is a legacy key and if so save it. | Maybe also add `ctx->keygen_info_count = 2` ? |
@@ -85,5 +85,7 @@ urlpatterns = patterns('',
url(r'^v2/roles/(?P<role_id>[^/]+)/users/$', RoleUsersView.as_view(), name='role_users'),
url(r'^v2/roles/(?P<role_id>[^/]+)/users/(?P<login>[^/]+)/$', RoleUserView.as_view(), name='role_user'),
url(r'^v2/tasks/$', TaskCollectionView.as_view(), name='task_coll... | [url,patterns,as_view] | Returns a url for the role users and tasks. | no change necessary, but i think we should put commas even on the last line. This way will have smaller diffs when moving things around. |
@@ -106,14 +106,14 @@ class SwimmingDEMSolver(PythonSolver):
1,
self.pp.CFD_DEM["basset_force_type"].GetInt())
- def AdvanceInTime(self, step, time):
- self.step, self.time = self.dem_solver.AdvanceInTime(step, time)
+ def AdvanceInTime(self, time):
+ self.time = self.dem... | [SwimmingDEMSolver->[SolveFluid->[SolveSolutionStep],AssessStationarity->[Say],_GetProjectionModule->[_ConstructProjectionModule],Predict->[CannotIgnoreFluidNow,Predict],__init__->[_ValidateSettings],SolveDEM->[ApplyForwardCouplingOfVelocityToSlipVelocityOnly,SolveSolutionStep,ApplyForwardCoupling],AdvanceInTime->[Adva... | Returns a counter for a force quadrature. | @farrufat-cimne , every time we change the name of a method or the arguments, we should leave the old method with a warning. I think it's the way to go if we don't want an angry Kratos DEM community. |
@@ -78,6 +78,7 @@
"html-loader": "0.5.0",
"html-webpack-plugin": "3.0.0",
"husky": "0.14.3",
+ "istanbul-instrumenter-loader": "3.0.0",
"jasmine-core": "2.7.0",
<%_ if (protractorTests) { _%>
"jasmine-reporters": "2.2.1",
| [No CFG could be retrieved] | The version of the compiler is not the same as the version of the compiler. The version of the library that is used by the compiler. 1. 0. 0 - beta. 5. | `3.0.0` doesn't support webpack 4 right ? |
@@ -239,6 +239,14 @@ def make_dics(info, forward, csd, reg=0.05, label=None, pick_ori=None,
(freq, i + 1, n_freqs))
Cm = csd.get_data(index=i)
+ if noise_csd is not None:
+ noise_csd_freq = noise_csd.get_data(index=i, as_cov=True)
+ else:
+ noise_c... | [tf_dics->[make_dics,apply_dics_csd],apply_dics_epochs->[_apply_dics],apply_dics->[_apply_dics]] | Dynamic Imaging of Coherent Sources. Returns a sequence of Beamformer objects that can be used to compute a single - rank Returns a dictionary of all the properties of a object. A list of all possible values of . | Does this really need to be done per frequency now? It was outside the loop before if I see it right. |
@@ -2,7 +2,7 @@
# Copyright (c) Microsoft Corporation.
# Licensed under the MIT License.
# ------------------------------------
-from ._abstract_span import AbstractSpan, SpanKind, HttpSpanMixin
+from azure.core.tracing._abstract_span import AbstractSpan, SpanKind, HttpSpanMixin
__all__ = [
"AbstractSpan", "... | [No CFG could be retrieved] | Missing object in the list of objects. | Why make this change? |
@@ -355,7 +355,7 @@ class WPSEO_Sitemaps {
$query = $wpdb->prepare( "SELECT COUNT(ID) FROM $wpdb->posts {$join_filter} WHERE post_status IN ('publish','inherit') AND post_password = '' AND post_date != '0000-00-00 00:00:00' AND post_type = %s " . $where_filter, $post_type );
$count = $wpdb->get_var( $query ... | [WPSEO_Sitemaps->[build_post_type_map->[filter_frequency],parse_attachments->[image_url],redirect->[set_n,sitemap_close],output->[http_protocol],build_tax_map->[filter_frequency],build_user_map->[filter_frequency],xsl_output->[http_protocol]]] | Build the root map This function is used to generate the sitemaps. This function is used to retrieve all the taxonomy and terms from the database and add them to This function will iterate over all taxonomies and add them to the sitemap Generate the sitemaps. | Strict comparison `$count === 0` |
@@ -369,7 +369,7 @@ def test_stc_to_label():
"""
with warnings.catch_warnings(record=True) as w:
warnings.simplefilter('always')
- src = read_source_spaces(src_fname)
+ src = read_source_spaces(fwd_fname)
src_bad = read_source_spaces(src_bad_fname)
stc = read_source_estimate(s... | [test_write_annot->[assert_labels_equal],test_read_annot->[_assert_labels_equal],test_stc_to_label->[assert_labels_equal],test_split_label->[assert_labels_equal],test_label_io->[assert_labels_equal],test_read_annot_annot2labels->[_assert_labels_equal,_mne_annot2labels],test_label_addition->[assert_labels_equal]] | Test that the standard standard standard standard standard standard standard standard standard standard standard standard standard standard standard. | Why was this needed? |
@@ -905,8 +905,7 @@ def get_fitting_dig(info, dig_kinds='auto', verbose=None):
.. versionadded:: 0.14
"""
- if not isinstance(info, Info):
- raise TypeError('info must be an instance of Info not %s' % type(info))
+ _validate_type(info, Info, "info", "Info")
if info['dig'] is None:
... | [make_sphere_model->[ConductorModel,_fwd_eeg_fit_berg_scherg],_lin_pot_coeff->[_calc_beta],_check_surfaces->[_assert_complete_surface,_assert_inside],_fwd_bem_homog_solution->[_fwd_bem_multi_solution],_fwd_eeg_fit_berg_scherg->[_compute_linear_parameters,_fwd_eeg_get_multi_sphere_model_coeffs],make_bem_model->[_surface... | Get digitization points suitable for sphere fitting. get head digitization points of the specified kind. | This is going to be common, should we special-case `Info` so we can omit the last two args here if the second is passed as `"info"` (i.e., `_validate_type(info, "info")`? |
@@ -211,6 +211,14 @@ func (node *Node) transactionMessageHandler(msgPayload []byte) {
}
func (node *Node) stakingMessageHandler(msgPayload []byte) {
+ if len(msgPayload) >= types.MaxEncodedPoolTransactionSize {
+ utils.Logger().Warn().Err(core.ErrOversizedData).Msgf("encoded tx size: %d", len(msgPayload))
+ retur... | [PostConsensusProcessing->[BroadcastNewBlock,BroadcastCrossLinkHeader]] | stakingMessageHandler is a message handler for the staking transaction list message. It adds. | Len equal to 0 check is better as uint |
@@ -113,7 +113,6 @@ public class TestResourceGroups
assertEquals(query3a.getState(), QUEUED);
query1a.complete();
- root.updateGroupsAndProcessQueuedQueries();
// 2a and not 1b should have started, as group1 was not eligible to start a second query
assertEquals(query1b.getSt... | [TestResourceGroups->[fillGroupTo->[fillGroupTo]]] | This test method checks if the managed query executions are in the aireligibility state. should have started. | Note that these are not needed. query1a.complete() will automatically trigger finding and running the next query. |
@@ -1604,9 +1604,7 @@ public abstract class PluginManager extends AbstractModelObject implements OnMas
element("dependencies", dependencies);
new UpdateSite(UpdateCenter.ID_UPLOAD, null).new Plugin(UpdateCenter.ID_UPLOAD, cfg).deploy(true);
return new HttpRedirect("../upda... | [PluginManager->[createDefault->[create],doPlugins->[getDisplayName],install->[install,getPlugin],dynamicLoad->[run,dynamicLoad],getPlugin->[getPlugin,getPlugins],PluginUpdateMonitor->[ifPluginOlderThenReport->[getPlugin]],addDependencies->[addDependencies],loadDetachedPlugins->[loadPluginsFromWar],getPluginVersion->[g... | Upload a plugin. Checks if there is a node in the update center and if so updates it. | It may impact RuntimeExceptions if they somehow happen within the code |
@@ -49,6 +49,7 @@ import java.util.function.Supplier;
*/
public class NettyEventSenderFactory<T> extends EventLoopGroupFactory implements EventSenderFactory<T> {
private static final int MAX_PENDING_ACQUIRES = 1024;
+ private final static int FRAME_SIZE = 40000;
private final String address;
| [NettyEventSenderFactory->[setTimeout->[requireNonNull],getChannelInitializer->[setWriteTimeout],getChannelPool->[getChannelInitializer,FixedChannelPool,InitializingChannelPoolHandler,toMillis],getEventSender->[group,remoteAddress,equals,Bootstrap,getConfiguredEventSender,setChannelOptions,getEventLoopGroup,InetSocketA... | Imports the Netty Event Sender Factory. Sets the Supplier of the list of ChannelHandlers for the . | Is there a particular reason for this specific frame size? It seems like it should be a configurable `Integer` property that could be checked for null and used to set the Send and Receive Buffer sizes when found. |
@@ -863,7 +863,7 @@ class dba {
*
* @return boolean|array was the delete successful? When $in_process is set: deletion data
*/
- public static function delete($table, array $conditions, $in_process = false, array &$callstack = [])
+ public static function delete($table, array $conditions, array $options = [], ... | [dba->[close->[close],fetch->[fetch],lastInsertId->[lastInsertId],columnCount->[columnCount]]] | Delete all records in a table that match the given conditions. This function deletes all records that match the given conditions. This function is used to remove all the records in the table that match the given conditions. | Please add the `$options` parameter to the doxygen header |
@@ -482,10 +482,13 @@ public interface IndexMerger
@Override
public void close()
{
+ long mergeBufferTotalSize = 0;
for (Pair<ByteBuffer, Integer> bufferAllocation : directBufferAllocations) {
- log.info("Freeing dictionary merging direct buffer with size[%,d]", bufferAllocation.rhs);
... | [DictionaryMergeIterator->[writeTranslate->[next,hasNext]]] | Closes all direct buffers that are not yet allocated. | Typo, should be `%,d` |
@@ -27,8 +27,8 @@ func main() {
}
opt0 := true
ami, err := aws.GetAmi(ctx, &GetAmiArgs{
- Filters: []GetAmiFilter{
- GetAmiFilter{
+ Filters: []GetAmiFilterArgs{
+ &GetAmiFilterArgs{
Name: "name",
Values: []string{
"amzn-ami-hvm-*-x86_64-ebs",
| [GetAmi,Int,Sprintf,Export,NewSecurityGroup,NewInstance,String,Run] | main import imports the given object and imports it into the context. export publicIp publicHostName. | This is a regression I am introducing... Patch likely needs a little more work. |
@@ -101,6 +101,9 @@ func NewKubernetesSecretsKeystore(keystoreNamespace string, ks8client k8s.Interf
func (k *KubernetesSecretsKeystore) Retrieve(key string) (*keystore.SecureString, error) {
// key = "kubernetes.somenamespace.somesecret.value"
tokens := strings.Split(key, ".")
+ if len(tokens) > 0 && tokens[0] !=... | [Retrieve->[NewSecureString,CoreV1,Secrets,List,Errorf,Get,Split,TODO,Debugf],GetKeystore->[GetValue,Debugf]] | Retrieve retrieves a secret from the Kubernetes secrets keystore return nil if the secret is not found. | Does this fix need a changelog entry? Should it be done in a different PR? |
@@ -13,8 +13,8 @@ class CmdRemove(CmdBase):
for target in self.args.targets:
try:
self.repo.remove(target, outs=self.args.outs)
- except DvcException:
- logger.exception(f"failed to remove '{target}'")
+ except DvcException as exc:
+ ... | [add_parser->[add_argument,add_parser,set_defaults,append_doc_link],CmdRemove->[run->[remove,exception]],getLogger] | Run the remove command. | Forgot that this hides the `__cause__`. Will update. |
@@ -88,6 +88,8 @@ func ValidateMasterConfig(config *api.MasterConfig) fielderrors.ValidationErrorL
allErrs = append(allErrs, ValidateOAuthConfig(config.OAuthConfig).Prefix("oauthConfig")...)
}
+ allErrs = append(allErrs, ValidateProjectNodeSelector(config.ProjectNodeSelector)...)
+
allErrs = append(allErrs, Va... | [Sprintf,TrimSpace,Parse,ParseCIDR,Prefix,Split,NewFieldInvalid,HasSuffix,NewFieldRequired] | ValidateEtcdStorageConfig validates a etcd storage configuration. ValidateAssetConfig validates an AssetConfig object. | I am a little confused by this option. Are we saying that there is a default node selector that gets applied on all project creation requests unless the user provides a different value? |
@@ -656,6 +656,14 @@ angular.module('ngResource', ['ng']).
if (!isInstanceCall && cancellable) {
timeoutDeferred = $q.defer();
httpConfig.timeout = timeoutDeferred.promise;
+
+ if(simulatedTimeout) {
+ simulatedTimeoutPromise = $timeout(function() {... | [No CFG could be retrieved] | Creates a resource object from the given action object. Checks if the data is array or not and if so creates a Resource object. | This could be just `simulatedTimeoutPromise = $timeout(timeoutDeferred.resolve, simulatedTimeout);`. |
@@ -265,6 +265,7 @@ def _build(sources: List[BuildSource],
fscache=fscache)
try:
+ TypeState.reset_all()
graph = dispatch(sources, manager)
return BuildResult(manager, graph)
finally:
| [FindModuleCache->[_find_module->[_get_site_packages_dirs,find_lib_path_dirs],find_modules_recursive->[BuildSource,find_module,find_modules_recursive],clear->[clear]],process_graph->[add_stats,trace,log],_build->[BuildSourceSet,BuildResult],process_fine_grained_cache_graph->[log],BuildManager->[all_imported_modules_in_... | Builds a single node with a specific . Construct a build result object that represents a single build result object. | If we aren't running a fine-grained incremental build, I think that we can reset the state after the build (before returning the build results), since it won't be useful any more at than point but it will consume some memory. We should also reset the cache when shutting down the daemon, maybe in `reset()`. It's good ma... |
@@ -127,6 +127,11 @@ namespace Microsoft.Xna.Framework.Content.Pipeline.Serialization.Intermediate
}
}
+ public override bool CanDeserializeIntoExistingObject
+ {
+ get { return TargetType.IsClass && TargetType.BaseType != null; }
+ }
+
protected internal... | [ReflectiveSerializer->[Serialize->[Serialize],ObjectIsEmpty->[ObjectIsEmpty],ScanChildren->[ScanChildren],Initialize->[GetElementInfo],Deserialize->[Deserialize]]] | Initialize the object. Reads object from input stream if it is missing return null. | This is a bit of a guess - it makes all our tests pass, but we might just be missing test cases. |
@@ -167,7 +167,7 @@ public class MovePerformer implements Serializable {
change.add(Route.getFuelChanges(units, route, id, data));
markTransportsMovement(arrived, transporting, route);
- if (route.anyMatch(mustFightThrough) && arrived.size() != 0) {
+ if (route.anyMatch... | [MovePerformer->[getBattleTracker->[getBattleTracker],fireAa->[fireAa,initialize],populateStack->[execute],getRemotePlayer->[getRemotePlayer],initialize->[initialize],hasConqueredNonBlitzed->[getBattleTracker],markTransportsMovement->[getBattleTracker]]] | Populates the stack with a sequence of units that can be handled by the given execution stack. Method that is invoked when a new dependency is added to the list of dependent units. Checks if there is a bombing raid unit and if it s a bomb This method is called when a bombing is done to the end of the batt This method i... | Consider simplifying this complex logical expression. |
@@ -451,6 +451,11 @@ describe GroupsController do
it "should return the right response" do
sign_in(user)
+ group.update!(
+ mentionable_level: Group::ALIAS_LEVELS[:owners_mods_and_admins],
+ visibility_level: Group.visibility_levels[:logged_on_users]
+ )
+
get "/groups/#{gro... | [expect_type_to_return_right_groups->[contain_exactly,to,parse,count,get,body,eq,map],find,let,new,to_not,describe,topic,log_change_group_settings,freeze_time,first,reason,it,name,put,map,contain_exactly,to,enable_group_directory,before,body,merge!,expect_type_to_return_right_groups,log_add_user_to_group,post,let!,t,re... | This is a helper method that returns the list of members in the group. It also returns should return the right response. | For this feature, I was expecting more like an integration test that would 1. create a public group that can't be mentioned (with at least one member) 2. create a post with an @mention to that group 3. ensure no mention notifications were sent to members of the group 4. ensure the mention gets wrapped in the cooked ver... |
@@ -17,7 +17,7 @@
<% if @current_user.admin? %>
<%= link_to I18n.t("collect_submissions.collect_all"),
collect_all_submissions_assignment_submissions_path(
- @assignment.id),
+ @assignment.id),
:confirm => I18n.t("collect_submissions.results_loss_wa... | [No CFG could be retrieved] | Displays a list of all submission numbers in the system. Renders a template for the n - node sub - submission. | Can you remove unwanted space :) ? Thank you |
@@ -85,6 +85,8 @@ public abstract class AbstractHttpRequestExecutingMessageHandler extends Abstrac
private static final List<HttpMethod> NO_BODY_HTTP_METHODS =
Arrays.asList(HttpMethod.GET, HttpMethod.HEAD, HttpMethod.TRACE);
+ DefaultUriBuilderFactory uriFactory = new DefaultUriBuilderFactory();
+
private fi... | [AbstractHttpRequestExecutingMessageHandler->[getIntegrationPatternType->[getIntegrationPatternType]]] | Creates a message handler which will handle the HTTP request. The URI Expression for this object. | Why package visibility? Why not `UriBuilderFactory`? |
@@ -252,7 +252,14 @@ class Pad(object):
Returns:
PIL.Image: Padded image.
"""
- return ImageOps.expand(img, border=self.padding, fill=self.fill)
+ if self.type == "constant":
+ return ImageOps.expand(img, border=self.padding, fill=self.fill)
+ elif self.typ... | [Normalize->[__call__->[zip,sub_]],Compose->[__call__->[t]],CenterCrop->[__call__->[round,int,crop],__init__->[int,isinstance]],RandomSizedCrop->[__call__->[round,randint,int,CenterCrop,Scale,scale,resize,sqrt,random,uniform,crop,range]],Scale->[__call__->[resize,int,isinstance],__init__->[isinstance,len]],RandomHorizo... | Expand the image with padding and fill. | Can't you have a single function `_expand` that accepts the `type` as argument, and passes it directly to the original `np.pad`? I don't see why we need the 3 functions with the same code |
Subsets and Splits
No community queries yet
The top public SQL queries from the community will appear here once available.