instance_id stringlengths 17 39 | repo stringclasses 8
values | issue_id stringlengths 14 34 | pr_id stringlengths 14 34 | linking_methods listlengths 1 3 | base_commit stringlengths 40 40 | merge_commit stringlengths 0 40 ⌀ | hints_text listlengths 0 106 | resolved_comments listlengths 0 119 | created_at timestamp[ns, tz=UTC] | labeled_as listlengths 0 7 | problem_title stringlengths 7 174 | problem_statement stringlengths 0 55.4k | gold_files listlengths 0 10 | gold_files_postpatch listlengths 1 10 | test_files listlengths 0 60 | gold_patch stringlengths 220 5.83M | test_patch stringlengths 386 194k ⌀ | split_random stringclasses 3
values | split_time stringclasses 3
values | issue_start_time timestamp[ns] | issue_created_at timestamp[ns, tz=UTC] | issue_by_user stringlengths 3 21 | split_repo stringclasses 3
values |
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
iluwatar/java-design-patterns/2333_2461 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2333 | iluwatar/java-design-patterns/2461 | [
"keyword_pr_to_issue"
] | 08682962b5f941caebbae863ab309a69779c0dc7 | 0eb976394bab5d58acb2d246160adad4d072f314 | [
"Hello ! I am new in opensource and I am also familiar with java I want to use this skill in real-world project. can anyone help me too start this project or how can I solve this .\r\n ",
"There is just a broken link in the mentioned document @Pawank06 I suppose it should be an easy fix.",
"> Hello ! I am new i... | [] | 2023-01-24T15:02:13Z | [
"type: bug",
"info: help wanted",
"info: good first issue",
"epic: documentation"
] | Broken linkage on Chinese localization document | Broken linkage [Java CI with Maven](https://github.com/iluwatar/java-design-patterns/workflows/Java%20CI%20with%20Maven/badge.svg) on the following Chinese localization README file.
https://github.com/iluwatar/java-design-patterns/blob/master/localization/zh/README.md
| [
"localization/zh/README.md"
] | [
"localization/zh/README.md"
] | [] | diff --git a/localization/zh/README.md b/localization/zh/README.md
index dcf8571b5764..6b810cd48e9a 100644
--- a/localization/zh/README.md
+++ b/localization/zh/README.md
@@ -4,7 +4,7 @@
# 设计模式Java版
-![Java CI with Maven](https://github.com/iluwatar/java-design-patterns/workflows/Java%20CI%20with%20Maven/badge.svg... | null | test | test | 2023-01-21T19:21:06 | 2022-11-13T17:00:25Z | limingho456 | train |
iluwatar/java-design-patterns/2459_2467 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2459 | iluwatar/java-design-patterns/2467 | [
"keyword_pr_to_issue"
] | c741814b367f004787ef2f87665cc00b5f07b35e | 4e8cdc7c960ce991fce94cfb0143466e9526a6a6 | [
"It's called **Double-Checked Locking**. [REFER](https://en.wikipedia.org/wiki/Double-checked_locking#Usage_in_Java) \r\nHope your doubt is resolved after reading the above article!\r\n",
"Hi @bharathkalyans thank you for reference.\r\nMy doubt is actually if we already have a `volatile` instance, any thread will... | [] | 2023-02-02T07:12:00Z | [
"type: bug",
"type: support",
"epic: pattern"
] | Why are we using synchronized twice in com.iluwatar.singleton.ThreadSafeLazyLoadedIvoryTower? | `/**
* The instance doesn't get created until the method is called for the first time.
*/
public static synchronized ThreadSafeLazyLoadedIvoryTower getInstance() {
if (instance == null) {
synchronized (ThreadSafeLazyLoadedIvoryTower.class) {
if (instance == null) {
instance = ... | [
"singleton/src/main/java/com/iluwatar/singleton/ThreadSafeLazyLoadedIvoryTower.java"
] | [
"singleton/src/main/java/com/iluwatar/singleton/ThreadSafeLazyLoadedIvoryTower.java"
] | [] | diff --git a/singleton/src/main/java/com/iluwatar/singleton/ThreadSafeLazyLoadedIvoryTower.java b/singleton/src/main/java/com/iluwatar/singleton/ThreadSafeLazyLoadedIvoryTower.java
index 58d6e53b9729..fcafba3611c5 100644
--- a/singleton/src/main/java/com/iluwatar/singleton/ThreadSafeLazyLoadedIvoryTower.java
+++ b/sing... | null | train | test | 2023-02-04T18:37:34 | 2023-01-23T12:38:34Z | hmittal657 | train |
iluwatar/java-design-patterns/1965_2470 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/1965 | iluwatar/java-design-patterns/2470 | [
"keyword_pr_to_issue"
] | c741814b367f004787ef2f87665cc00b5f07b35e | 18b1d5195f5ced99a4dc9cb12157aac97b6e2ffc | [
"Can you give more specific info about this bug or sth. ?",
"\r\n",
"This issue is free for taking again.",
"Can you specify more about this.!",
"@nairpranav331 It is a Chinese translation error.",... | [] | 2023-02-07T17:40:04Z | [
"type: bug",
"epic: pattern",
"epic: web site",
"info: good first issue"
] | Translation error | 
| [
"localization/zh/abstract-factory/README.md"
] | [
"localization/zh/abstract-factory/README.md"
] | [] | diff --git a/localization/zh/abstract-factory/README.md b/localization/zh/abstract-factory/README.md
index 5241e31c7ba5..092d87624132 100644
--- a/localization/zh/abstract-factory/README.md
+++ b/localization/zh/abstract-factory/README.md
@@ -18,7 +18,7 @@ tag:
真实世界例子
-> 要创建一个王国，我们需要具有共同主题的对象。 精灵王国需要精灵王，精灵城堡和精灵军队，... | null | train | test | 2023-02-04T18:37:34 | 2022-02-17T09:14:57Z | liuyangyudaxia | train |
iluwatar/java-design-patterns/2472_2474 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2472 | iluwatar/java-design-patterns/2474 | [
"keyword_pr_to_issue",
"timestamp(timedelta=6.0, similarity=0.9391483888332116)"
] | 1fa80eb74cd9d69aae394c4e730db82bb1f2d904 | 188f35aafc99c40523e3f154f1fe04a558a679c0 | [
"Part of #2277 "
] | [] | 2023-02-16T19:48:46Z | [
"type: feature",
"epic: translation"
] | Translate the api-gateway readme to Spanish. | Hello, I will continue with the spanish translations for readme files [here](https://github.com/iluwatar/java-design-patterns/issues/2277), next one is api-gateway, I will place it under localization.es.api-gateway | [] | [
"localization/es/api-gateway/README.md"
] | [] | diff --git a/localization/es/api-gateway/README.md b/localization/es/api-gateway/README.md
new file mode 100644
index 000000000000..b2336313fded
--- /dev/null
+++ b/localization/es/api-gateway/README.md
@@ -0,0 +1,168 @@
+---
+title: API Gateway
+category: Architectural
+language: es
+tag:
+ - Cloud distributed
+ - D... | null | train | test | 2023-02-11T18:09:51 | 2023-02-14T04:03:49Z | TheClerici | train |
iluwatar/java-design-patterns/2476_2477 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2476 | iluwatar/java-design-patterns/2477 | [
"keyword_pr_to_issue"
] | c34ad292e3de91e2aa3ede878a9d929e3a6b7477 | 207cf60bc6b7e4b2e912c51ea564e4eaf3f851cd | [] | [] | 2023-02-19T07:09:54Z | [
"type: bug",
"info: help wanted",
"info: good first issue",
"epic: translation"
] | Typo in README in Russian | ускорить процесс разработк`у` -> ускорить процесс разработк`и` | [
"localization/ru/README.md"
] | [
"localization/ru/README.md"
] | [] | diff --git a/localization/ru/README.md b/localization/ru/README.md
index a52020200830..89e4ddffc317 100644
--- a/localization/ru/README.md
+++ b/localization/ru/README.md
@@ -17,7 +17,7 @@
Шаблоны проектирования - лучший метод для решения проблем, возникающих
во время разработки приложения или системы.
-Шаблоны про... | null | train | test | 2023-02-18T19:56:22 | 2023-02-19T07:08:46Z | ramilS | train |
iluwatar/java-design-patterns/2479_2480 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2479 | iluwatar/java-design-patterns/2480 | [
"keyword_pr_to_issue"
] | 91321c83778adfa40f449ad18008c33c5e6237ca | 84f7ab8006f4ba0f193e02362297ff8ba2701542 | [
"Subtask of https://github.com/iluwatar/java-design-patterns/issues/2277"
] | [] | 2023-02-24T22:51:32Z | [
"type: feature",
"epic: translation"
] | Translate arrange-act-assert to spanish (Task of issue #2277) | Translation of [arrange-act-assert/README.md](https://github.com/iluwatar/java-design-patterns/blob/master/arrange-act-assert/README.md) to [java-design-patterns/localization/es/arrange-act-assert/](https://github.com/iluwatar/java-design-patterns/tree/master/localization/es/) folder
Task of issue #2277 | [] | [
"localization/es/arrange-act-assert/README.md",
"localization/es/async-method-invocation/README.md"
] | [] | diff --git a/localization/es/arrange-act-assert/README.md b/localization/es/arrange-act-assert/README.md
new file mode 100644
index 000000000000..d5411e63b7ad
--- /dev/null
+++ b/localization/es/arrange-act-assert/README.md
@@ -0,0 +1,140 @@
+---
+title: Arrange/Act/Assert
+category: Idiom
+language: es
+tag:
+ - Testi... | null | train | test | 2023-02-28T08:33:40 | 2023-02-24T21:10:12Z | KarmaTashiCat | train |
iluwatar/java-design-patterns/2462_2484 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2462 | iluwatar/java-design-patterns/2484 | [
"keyword_pr_to_issue"
] | 4bea173e642ce550d84075af0e43efa7f61be359 | b0cc0943f986af20fd7632423d8786fb82ad6dfb | [
"can you assign me this issue?\r\n\r\nI am interest in solve this issue?",
"I'm new to open-sourcing and I have no clue about what I should be doing. Can anyone guide me? I have basic knowledge of java \r\nlet me know in which way I can help you.",
"@jaswanthg76 https://github.com/iluwatar/java-design-patterns... | [] | 2023-03-01T15:26:21Z | [
"type: bug",
"info: help wanted",
"epic: documentation"
] | Wrong generic type for deques in command README | Hi, inside the README.md for the command pattern the Wizard class presents these two instance variables:
```java
private final Deque<Command> undoStack = new LinkedList<>();
private final Deque<Command> redoStack = new LinkedList<>();
```
The generic type for these deques should be ```Runnable``` as it is in the... | [
"command/README.md",
"localization/zh/command/README.md"
] | [
"command/README.md",
"localization/zh/command/README.md"
] | [] | diff --git a/command/README.md b/command/README.md
index 476edc47af39..a3b863b78cbe 100644
--- a/command/README.md
+++ b/command/README.md
@@ -40,8 +40,8 @@ Here's the sample code with wizard and goblin. Let's start from the `Wizard` cla
@Slf4j
public class Wizard {
- private final Deque<Command> undoStack = new L... | null | train | test | 2023-04-01T16:53:32 | 2023-01-25T14:18:26Z | AddeusExMachina | train |
iluwatar/java-design-patterns/2445_2518 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2445 | iluwatar/java-design-patterns/2518 | [
"keyword_pr_to_issue"
] | cf64d6ae9a2196b0b9f190922c68e789484592eb | 4808865c0bb91c5f6a8842e77551a244945d66c3 | [
"This issue has been automatically marked as stale because it has not had recent activity. The issue will be unassigned if no further activity occurs. Thank you for your contributions.\n",
"Hey, seeing as this issue hasn't been solved I would like to give a try if it's ok.",
"This issue has been automatically m... | [
"<picture><img alt=\"6% of developers fix this issue\" src=\"https://lift.sonatype.com/api/commentimage/fixrate/6/display.svg\"></picture>\n\n<b>*[UnnecessarilyFullyQualified](https://errorprone.info/bugpattern/UnnecessarilyFullyQualified):</b>* This fully qualified name is unambiguous to the compiler if imported.... | 2023-05-08T12:19:51Z | [
"type: refactoring",
"epic: code quality",
"status: stale"
] | Refactor event sourcing | I'll refactor some codes of event sourcing pattern. The specific tasks I suggest are listed below.
- [ ] remove the use of deprecated `JsonParser`
- [ ] use jackson `ObjectMapper` instead of `Gson`
- [ ] fix some warnings checked by sonarlint | [
"event-sourcing/pom.xml",
"event-sourcing/src/main/java/com/iluwatar/event/sourcing/app/App.java",
"event-sourcing/src/main/java/com/iluwatar/event/sourcing/event/AccountCreateEvent.java",
"event-sourcing/src/main/java/com/iluwatar/event/sourcing/event/MoneyDepositEvent.java",
"event-sourcing/src/main/java/... | [
"event-sourcing/pom.xml",
"event-sourcing/src/main/java/com/iluwatar/event/sourcing/app/App.java",
"event-sourcing/src/main/java/com/iluwatar/event/sourcing/event/AccountCreateEvent.java",
"event-sourcing/src/main/java/com/iluwatar/event/sourcing/event/MoneyDepositEvent.java",
"event-sourcing/src/main/java/... | [
"event-sourcing/src/test/java/IntegrationTest.java"
] | diff --git a/event-sourcing/pom.xml b/event-sourcing/pom.xml
index ae609d67e76b..569a5fceebd8 100644
--- a/event-sourcing/pom.xml
+++ b/event-sourcing/pom.xml
@@ -40,8 +40,8 @@
<scope>test</scope>
</dependency>
<dependency>
- <groupId>com.google.code.gson</groupId>
- <artifactId>gson</artifac... | diff --git a/event-sourcing/src/test/java/IntegrationTest.java b/event-sourcing/src/test/java/IntegrationTest.java
index 9e15a2163bcc..c737bd0da43d 100644
--- a/event-sourcing/src/test/java/IntegrationTest.java
+++ b/event-sourcing/src/test/java/IntegrationTest.java
@@ -22,6 +22,7 @@
* OUT OF OR IN CONNECTION WITH TH... | test | test | 2023-05-06T11:10:06 | 2023-01-09T14:06:20Z | hwan33 | train |
iluwatar/java-design-patterns/2286_2533 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2286 | iluwatar/java-design-patterns/2533 | [
"timestamp(timedelta=5.0, similarity=0.8479848449633892)",
"keyword_pr_to_issue"
] | cf64d6ae9a2196b0b9f190922c68e789484592eb | 376cd215274d7f9ecb8bc90b1d35e36d567b1654 | [
"I want to participate."
] | [
"should be Creational"
] | 2023-06-04T11:22:13Z | [
"info: help wanted",
"type: feature",
"epic: documentation"
] | Translation to Russian | This task tracks the translation of the patterns. More information about the translation process is available at https://github.com/iluwatar/java-design-patterns/wiki/15.-Support-for-multiple-languages
Acceptance criteria
- The patterns have been translated
- The patterns can be browsed in Github and on the website h... | [] | [
"localization/ru/abstract-factory/README.md"
] | [] | diff --git a/localization/ru/abstract-factory/README.md b/localization/ru/abstract-factory/README.md
new file mode 100644
index 000000000000..044e03c53c5c
--- /dev/null
+++ b/localization/ru/abstract-factory/README.md
@@ -0,0 +1,237 @@
+---
+title: Abstract Factory
+category: Creational
+language: ru
+tag:
+ - Gang of ... | null | train | test | 2023-05-06T11:10:06 | 2022-10-30T08:12:16Z | iluwatar | train |
iluwatar/java-design-patterns/187_2538 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/187 | iluwatar/java-design-patterns/2538 | [
"keyword_pr_to_issue"
] | 72f7fcab0ea5677e39a8cc064e1c69527a0c309c | 1894fcf175a227028cdff4f359e2dbabe0ec36ff | [
"@iluwatar There is an issue #188 where concern regarding lazy loading of Singleton is raised. I was going through the singleton documentation yesterday and found that the disadvantages of approaches are not discussed. We should document that the lazy loading example with `synchronized` keyword is ok for small appl... | [
"<picture><img alt=\"6% of developers fix this issue\" src=\"https://lift.sonatype.com/api/commentimage/fixrate/6/display.svg\"></picture>\n\n<b>*[ObjectToString](https://errorprone.info/bugpattern/ObjectToString):</b>* BillPughImplementation is final and does not override Object.toString, so converting it to a st... | 2023-06-18T08:34:09Z | [
"type: enhancement",
"info: good first issue",
"epic: design",
"status: stale"
] | More Singleton wisdom | Analyze the following article from Oracle: https://community.oracle.com/docs/DOC-918906
Improve Singleton examples and their documentation where necessary.
| [
"singleton/src/main/java/com/iluwatar/singleton/App.java",
"singleton/src/main/java/com/iluwatar/singleton/EnumIvoryTower.java",
"singleton/src/main/java/com/iluwatar/singleton/InitializingOnDemandHolderIdiom.java",
"singleton/src/main/java/com/iluwatar/singleton/ThreadSafeDoubleCheckLocking.java",
"singlet... | [
"singleton/src/main/java/com/iluwatar/singleton/App.java",
"singleton/src/main/java/com/iluwatar/singleton/BillPughImplementation.java",
"singleton/src/main/java/com/iluwatar/singleton/EnumIvoryTower.java",
"singleton/src/main/java/com/iluwatar/singleton/InitializingOnDemandHolderIdiom.java",
"singleton/src... | [
"singleton/src/test/java/com/iluwatar/singleton/BillPughImplementationTest.java"
] | diff --git a/singleton/src/main/java/com/iluwatar/singleton/App.java b/singleton/src/main/java/com/iluwatar/singleton/App.java
index af09a7ec6828..8d7946cae95d 100644
--- a/singleton/src/main/java/com/iluwatar/singleton/App.java
+++ b/singleton/src/main/java/com/iluwatar/singleton/App.java
@@ -100,5 +100,11 @@ public s... | diff --git a/singleton/src/test/java/com/iluwatar/singleton/BillPughImplementationTest.java b/singleton/src/test/java/com/iluwatar/singleton/BillPughImplementationTest.java
new file mode 100644
index 000000000000..90a3424e412c
--- /dev/null
+++ b/singleton/src/test/java/com/iluwatar/singleton/BillPughImplementationTest... | val | test | 2023-07-11T12:04:10 | 2015-08-04T16:25:38Z | iluwatar | train |
iluwatar/java-design-patterns/2544_2545 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2544 | iluwatar/java-design-patterns/2545 | [
"timestamp(timedelta=639.0, similarity=0.9117834642299325)"
] | 72f7fcab0ea5677e39a8cc064e1c69527a0c309c | 2154e777b6a7d992058197cfea823e969bb64f9c | [
"I'm working on it",
"1: at line no 66(var bubblesToCheck = bubbles.values();) and at ln :70 you are iterating it (bubbles.forEach) and inside handleCollision() method you are updating the same map(bubbles,inside pop() allBubbles.remove(this.id);) . \r\nThats why once you get the iterator from a collection y... | [] | 2023-06-27T15:23:01Z | [
"type: bug",
"epic: pattern"
] | [Spatial Partition] Error when run App.java | When run [App.java](https://github.com/iluwatar/java-design-patterns/blob/5b147b00367a500e8dfeac882d4b0d6a0540c6b9/spatial-partition/src/main/java/com/iluwatar/spatialpartition/App.java), there are some problems:
- `ConcurrentModificationException` happen:
```
Exception in thread "main" java.util.ConcurrentModificat... | [
"spatial-partition/src/main/java/com/iluwatar/spatialpartition/App.java",
"spatial-partition/src/main/java/com/iluwatar/spatialpartition/Bubble.java",
"spatial-partition/src/main/java/com/iluwatar/spatialpartition/Point.java",
"spatial-partition/src/main/java/com/iluwatar/spatialpartition/QuadTree.java",
"s... | [
"spatial-partition/src/main/java/com/iluwatar/spatialpartition/App.java",
"spatial-partition/src/main/java/com/iluwatar/spatialpartition/Bubble.java",
"spatial-partition/src/main/java/com/iluwatar/spatialpartition/Point.java",
"spatial-partition/src/main/java/com/iluwatar/spatialpartition/QuadTree.java",
"s... | [] | diff --git a/spatial-partition/src/main/java/com/iluwatar/spatialpartition/App.java b/spatial-partition/src/main/java/com/iluwatar/spatialpartition/App.java
index 47dcd7eb7560..e7b14249a732 100644
--- a/spatial-partition/src/main/java/com/iluwatar/spatialpartition/App.java
+++ b/spatial-partition/src/main/java/com/iluw... | null | test | test | 2023-07-11T12:04:10 | 2023-06-27T15:18:54Z | tiennm99 | train |
iluwatar/java-design-patterns/1306_2551 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/1306 | iluwatar/java-design-patterns/2551 | [
"timestamp(timedelta=134.0, similarity=0.8928222473875641)"
] | e40923d938cc94c096e1f3c19bc83b0caa85245a | 8b11e76f460667caf014e6731be9bc105031444d | [
"I would like to tackle this issue. ",
"Hey @iluwatar, I would like to help with this issue.",
"Thanks @MathewJaniec, please go ahead",
"This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.\... | [
"<picture><img alt=\"5% of developers fix this issue\" src=\"https://lift.sonatype.com/api/commentimage/fixrate/5/display.svg\"></picture>\n\n<b>*[UnnecessarilyFullyQualified](https://errorprone.info/bugpattern/UnnecessarilyFullyQualified):</b>* This fully qualified name is unambiguous to the compiler if imported.... | 2023-07-08T19:46:23Z | [
"epic: pattern",
"type: feature"
] | Optimistic Offline Lock pattern | https://books.google.fi/books?id=vqTfNFDzzdIC&pg=PA416#v=onepage&q&f=false | [
"pom.xml"
] | [
"optimistic-offline-lock/README.md",
"optimistic-offline-lock/pom.xml",
"optimistic-offline-lock/src/main/java/com/iluwatar/api/UpdateService.java",
"optimistic-offline-lock/src/main/java/com/iluwatar/exception/ApplicationException.java",
"optimistic-offline-lock/src/main/java/com/iluwatar/model/Card.java",... | [
"optimistic-offline-lock/src/test/java/com/iluwatar/OptimisticLockTest.java"
] | diff --git a/optimistic-offline-lock/README.md b/optimistic-offline-lock/README.md
new file mode 100644
index 000000000000..7447a30503c7
--- /dev/null
+++ b/optimistic-offline-lock/README.md
@@ -0,0 +1,147 @@
+---
+title: Optimistic Offline Lock
+category: Concurrency
+language: en
+tag:
+- Data access
+---
+
+## Inten... | diff --git a/optimistic-offline-lock/src/test/java/com/iluwatar/OptimisticLockTest.java b/optimistic-offline-lock/src/test/java/com/iluwatar/OptimisticLockTest.java
new file mode 100644
index 000000000000..479b5807838e
--- /dev/null
+++ b/optimistic-offline-lock/src/test/java/com/iluwatar/OptimisticLockTest.java
@@ -0,... | test | test | 2023-07-04T17:23:11 | 2020-07-07T17:51:56Z | iluwatar | train |
iluwatar/java-design-patterns/2241_2583 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2241 | iluwatar/java-design-patterns/2583 | [
"timestamp(timedelta=61.0, similarity=0.9398683357371884)"
] | cb2d794cf85ed7bb4c251decf36fef0e0655d820 | ae597f259622c3f6c646cf0099fd103089aa1327 | [
"hi @iluwatar , can I take this up? Thanks",
"hi @iluwatar , have opened this PR: https://github.com/iluwatar/java-design-patterns/pull/2583\r\nThanks"
] | [] | 2023-09-09T04:28:09Z | [
"type: feature",
"epic: documentation"
] | Explanation for Master-Worker | In this issue, let's add a proper explanation for the pattern.
Acceptance criteria
- The pattern's README.md has been amended with an explanation
- The explanation consists of
- Real world example
- In plain words
- Wikipedia says
- Programmatic example
| [
"master-worker-pattern/README.md"
] | [
"master-worker-pattern/README.md"
] | [] | diff --git a/master-worker-pattern/README.md b/master-worker-pattern/README.md
index fc4e111ae412..32f239078517 100644
--- a/master-worker-pattern/README.md
+++ b/master-worker-pattern/README.md
@@ -17,6 +17,83 @@ tag:
## Class diagram
![alt text](./etc/master-worker-pattern.urm.png "Master-Worker pattern class diagr... | null | train | test | 2023-08-27T13:40:17 | 2022-10-29T19:59:47Z | iluwatar | train |
iluwatar/java-design-patterns/2260_2586 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2260 | iluwatar/java-design-patterns/2586 | [
"keyword_pr_to_issue"
] | cb2d794cf85ed7bb4c251decf36fef0e0655d820 | 9561722bb5770d82d781536b359b65595791e4d7 | [
"Hello. I want to nominate myself for writing explanation about Servant design pattern.",
"Hi @iluwatar, I would like to take care of the above feature. Please assign it to me."
] | [] | 2023-09-15T12:21:26Z | [
"type: feature",
"epic: documentation"
] | Explanation for Servant | In this issue, let's add a proper explanation for the pattern.
Acceptance criteria
- The pattern's README.md has been amended with an explanation
- The explanation consists of
- Real world example
- In plain words
- Wikipedia says
- Programmatic example
| [
"servant/README.md"
] | [
"servant/README.md"
] | [] | diff --git a/servant/README.md b/servant/README.md
index bfd06e2bc37a..c6aaf414873d 100644
--- a/servant/README.md
+++ b/servant/README.md
@@ -3,7 +3,7 @@ title: Servant
category: Behavioral
language: en
tag:
- - Decoupling
+- Decoupling
---
## Intent
@@ -11,6 +11,217 @@ Servant is used for providing some behavi... | null | train | test | 2023-08-27T13:40:17 | 2022-10-29T20:04:48Z | iluwatar | train |
iluwatar/java-design-patterns/2266_2596 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2266 | iluwatar/java-design-patterns/2596 | [
"keyword_pr_to_issue"
] | cb2d794cf85ed7bb4c251decf36fef0e0655d820 | ffbcbdcb33bcd739fbfb58b70faab5cc26a44954 | [] | [] | 2023-10-02T12:56:07Z | [
"info: help wanted",
"type: feature",
"epic: documentation"
] | Explanation for Type-Object | In this issue, let's add a proper explanation for the pattern.
Acceptance criteria
- The pattern's README.md has been amended with an explanation
- The explanation consists of
- Real world example
- In plain words
- Wikipedia says
- Programmatic example
| [
"typeobjectpattern/README.md"
] | [
"typeobjectpattern/README.md"
] | [] | diff --git a/typeobjectpattern/README.md b/typeobjectpattern/README.md
index f75e217d2616..742792a8f423 100644
--- a/typeobjectpattern/README.md
+++ b/typeobjectpattern/README.md
@@ -7,17 +7,63 @@ tag:
- Extensibility
---
+# Type-Object Pattern in Java
+
+## Explanation
+
+In Java, the Type-Object pattern is a des... | null | test | test | 2023-08-27T13:40:17 | 2022-10-29T20:05:06Z | iluwatar | train |
iluwatar/java-design-patterns/2250_2597 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2250 | iluwatar/java-design-patterns/2597 | [
"timestamp(timedelta=1.0, similarity=0.8431716746288775)",
"keyword_pr_to_issue"
] | cb2d794cf85ed7bb4c251decf36fef0e0655d820 | b75c7c1041aa56a837a35b6c41b04a5d9680a6e4 | [
"Hey @iluwatar I can work on this. "
] | [] | 2023-10-02T13:35:33Z | [
"type: feature",
"epic: documentation"
] | Explanation for Page Object | In this issue, let's add a proper explanation for the pattern.
Acceptance criteria
- The pattern's README.md has been amended with an explanation
- The explanation consists of
- Real world example
- In plain words
- Wikipedia says
- Programmatic example
| [
"page-object/README.md"
] | [
"page-object/README.md"
] | [] | diff --git a/page-object/README.md b/page-object/README.md
index 87046a85d917..93777ad2e032 100644
--- a/page-object/README.md
+++ b/page-object/README.md
@@ -6,13 +6,69 @@ tag:
- Decoupling
---
+# Page Object Pattern in Java
+
+## Real World Example
+
+Consider a web automation scenario where you need to interact ... | null | train | test | 2023-08-27T13:40:17 | 2022-10-29T20:00:13Z | iluwatar | train |
iluwatar/java-design-patterns/2263_2614 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2263 | iluwatar/java-design-patterns/2614 | [
"keyword_pr_to_issue"
] | cb2d794cf85ed7bb4c251decf36fef0e0655d820 | b71eea4b4e4849e593b8d7e23bb0cbbb6404955c | [
"can you assign it to me?",
"This issue has been automatically marked as stale because it has not had recent activity. The issue will be unassigned if no further activity occurs. Thank you for your contributions.\n",
"Please assign this to me.\r\n"
] | [] | 2023-10-05T12:07:29Z | [
"type: feature",
"epic: documentation"
] | Explanation for Step Builder | In this issue, let's add a proper explanation for the pattern.
Acceptance criteria
- The pattern's README.md has been amended with an explanation
- The explanation consists of
- Real world example
- In plain words
- Wikipedia says
- Programmatic example
| [
"step-builder/README.md"
] | [
"step-builder/README.md"
] | [] | diff --git a/step-builder/README.md b/step-builder/README.md
index 659da6e31968..a1e98b237611 100644
--- a/step-builder/README.md
+++ b/step-builder/README.md
@@ -6,16 +6,100 @@ tag:
- Instantiation
---
+# Step Builder Pattern
+
+## Explanation
+
+The Step Builder pattern is a creational design pattern used to con... | null | train | test | 2023-08-27T13:40:17 | 2022-10-29T20:04:58Z | iluwatar | train |
iluwatar/java-design-patterns/2230_2622 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2230 | iluwatar/java-design-patterns/2622 | [
"timestamp(timedelta=66.0, similarity=0.8982657430650325)"
] | 72da91e561421d9fc9e6a15fd8190ad4d16c00c8 | f9ae5961e6cc3dbb3c3cee16d56fb1f39c8e5b0f | [
"Hi! Could I please be assigned to this issue?",
"Hey Iluwatar! I've finished my addition, please let me know if you need me to change anything!"
] | [] | 2023-10-08T06:22:32Z | [
"type: feature",
"epic: documentation"
] | Explanation for Feature Toggle | In this issue, let's add a proper explanation for the pattern.
Acceptance criteria
- The pattern's README.md has been amended with an explanation
- The explanation consists of
- Real world example
- In plain words
- Wikipedia says
- Programmatic example
| [
"feature-toggle/README.md"
] | [
"feature-toggle/README.md"
] | [] | diff --git a/feature-toggle/README.md b/feature-toggle/README.md
index 915a255690da..982108bc7440 100644
--- a/feature-toggle/README.md
+++ b/feature-toggle/README.md
@@ -10,10 +10,53 @@ tag:
Feature Flag
## Intent
-Used to switch code execution paths based on properties or groupings. Allowing new features to be re... | null | val | test | 2023-10-08T11:09:28 | 2022-10-29T19:59:15Z | iluwatar | train |
iluwatar/java-design-patterns/2249_2634 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2249 | iluwatar/java-design-patterns/2634 | [
"timestamp(timedelta=77.0, similarity=0.9156512772325784)",
"keyword_pr_to_issue"
] | b86f2357b0546f346a889d57a56f0c42346b2fcb | 4d9b8b4d0fa34dd31deb3f273d50c56806a25cbb | [] | [] | 2023-10-11T05:31:13Z | [
"info: help wanted",
"type: feature",
"epic: documentation"
] | Explanation for Object Mother | In this issue, let's add a proper explanation for the pattern.
Acceptance criteria
- The pattern's README.md has been amended with an explanation
- The explanation consists of
- Real world example
- In plain words
- Wikipedia says
- Programmatic example
| [
"object-mother/README.md"
] | [
"object-mother/README.md"
] | [] | diff --git a/object-mother/README.md b/object-mother/README.md
index 99d49af4b04d..4f2a6664cd48 100644
--- a/object-mother/README.md
+++ b/object-mother/README.md
@@ -7,7 +7,7 @@ tag:
---
## Object Mother
-Define a factory of immutable content with separated builder and factory interfaces.
+It is used to define a f... | null | train | test | 2023-10-11T08:17:56 | 2022-10-29T20:00:10Z | iluwatar | train |
iluwatar/java-design-patterns/2631_2641 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2631 | iluwatar/java-design-patterns/2641 | [
"timestamp(timedelta=40.0, similarity=0.8452084574676992)"
] | 54d628032245b1f6b00ecc6261b96b278440a7a6 | 09b9ee2f5f1d0c957421fbf18b09f0eccaa16502 | [
"Subtask of https://github.com/iluwatar/java-design-patterns/issues/2282",
"Pls assign it to me i will do it",
"This issue has been automatically marked as stale because it has not had recent activity. The issue will be unassigned if no further activity occurs. Thank you for your contributions.\n"
] | [] | 2023-10-13T00:01:53Z | [
"type: feature",
"status: stale",
"epic: translation"
] | Translate the README file of the callback pattern to Korean & Place it under localization/ko/callback | ### #2282 Translate the README file of the callback pattern to Korean & Place it under localization/ko/callback | [] | [
"localization/ko/callback/README.md"
] | [] | diff --git a/localization/ko/callback/README.md b/localization/ko/callback/README.md
new file mode 100644
index 000000000000..b11c6dea68e7
--- /dev/null
+++ b/localization/ko/callback/README.md
@@ -0,0 +1,71 @@
+---
+title: Callback
+category: Idiom
+language: ko
+tag:
+- Reactive
+---
+
+## 의도
+
+콜백은 다른 코드에 ... | null | train | test | 2024-02-25T13:47:19 | 2023-10-10T14:49:25Z | Nickolodeon98 | train |
iluwatar/java-design-patterns/2229_2645 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2229 | iluwatar/java-design-patterns/2645 | [
"timestamp(timedelta=1.0, similarity=0.9117714487460985)"
] | b86f2357b0546f346a889d57a56f0c42346b2fcb | d3cc529f6cbcb826d816e20d253ed1b618b7fad6 | [
"Hi @iluwatar,\r\n\r\nI was wondering if you could assign this issue to me as I would like to work on it.\r\n\r\nRegards,\r\nJerry"
] | [] | 2023-10-14T04:05:21Z | [
"type: feature",
"epic: documentation"
] | Explanation for Extension Objects | In this issue, let's add a proper explanation for the pattern.
Acceptance criteria
- The pattern's README.md has been amended with an explanation
- The explanation consists of
- Real world example
- In plain words
- Wikipedia says
- Programmatic example
| [
"extension-objects/README.md"
] | [
"extension-objects/README.md"
] | [] | diff --git a/extension-objects/README.md b/extension-objects/README.md
index fa00d3d5319d..5ecc08efb394 100644
--- a/extension-objects/README.md
+++ b/extension-objects/README.md
@@ -6,10 +6,120 @@ tag:
- Extensibility
---
+# Extention Objects Pattern
+
## Intent
Anticipate that an object’s interface needs to be... | null | val | test | 2023-10-11T08:17:56 | 2022-10-29T19:59:12Z | iluwatar | train |
iluwatar/java-design-patterns/2248_2706 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2248 | iluwatar/java-design-patterns/2706 | [
"keyword_pr_to_issue"
] | f63c5dd46ddaaeaa6c2844dd7db6192fafce616a | 7fdd5742a229c6c19be3284224f68804515bc3b5 | [
"hey, I want to work on this issue can you assign me this please . "
] | [] | 2023-10-17T14:39:44Z | [
"type: feature",
"epic: documentation"
] | Explanation for Naked Objects | In this issue, let's add a proper explanation for the pattern.
Acceptance criteria
- The pattern's README.md has been amended with an explanation
- The explanation consists of
- Real world example
- In plain words
- Wikipedia says
- Programmatic example
| [
"naked-objects/README.md"
] | [
"naked-objects/README.md"
] | [] | diff --git a/naked-objects/README.md b/naked-objects/README.md
index b091c55d0414..8ed8210de4d2 100644
--- a/naked-objects/README.md
+++ b/naked-objects/README.md
@@ -3,40 +3,142 @@ title: Naked Objects
category: Architectural
language: en
tag:
-- Decoupling
-- Extensibility
-- Presentation
+ - Decoupling
+ - Exte... | null | test | test | 2023-10-15T15:45:17 | 2022-10-29T20:00:07Z | iluwatar | train |
iluwatar/java-design-patterns/2255_2707 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2255 | iluwatar/java-design-patterns/2707 | [
"keyword_pr_to_issue"
] | f63c5dd46ddaaeaa6c2844dd7db6192fafce616a | b186ff5e731fa3c1654ccfa812533b6aa61bf354 | [
"I want to contribute on this. Could you please assign me?"
] | [] | 2023-10-17T19:46:37Z | [
"type: feature",
"epic: documentation"
] | Explanation for Queue-Based Load Leveling | In this issue, let's add a proper explanation for the pattern.
Acceptance criteria
- The pattern's README.md has been amended with an explanation
- The explanation consists of
- Real world example
- In plain words
- Wikipedia says
- Programmatic example
| [
"queue-load-leveling/README.md"
] | [
"queue-load-leveling/README.md"
] | [] | diff --git a/queue-load-leveling/README.md b/queue-load-leveling/README.md
index 5bffdcb2958c..49c37e6238dc 100644
--- a/queue-load-leveling/README.md
+++ b/queue-load-leveling/README.md
@@ -14,6 +14,281 @@ intermittent heavy loads that may otherwise cause the service to fail or the tas
This pattern can help to minimi... | null | train | test | 2023-10-15T15:45:17 | 2022-10-29T20:04:32Z | iluwatar | train |
iluwatar/java-design-patterns/2247_2716 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2247 | iluwatar/java-design-patterns/2716 | [
"keyword_pr_to_issue"
] | f63c5dd46ddaaeaa6c2844dd7db6192fafce616a | bb8de8701588261c5c6b0a0bdf3b4b1e122e4263 | [
"Hi @iluwatar, I would like to contribute to this issue. Could you please assign this to me?"
] | [] | 2023-10-21T04:13:32Z | [
"type: feature",
"epic: documentation"
] | Explanation for Mute Idiom | In this issue, let's add a proper explanation for the pattern.
Acceptance criteria
- The pattern's README.md has been amended with an explanation
- The explanation consists of
- Real world example
- In plain words
- Wikipedia says
- Programmatic example
| [
"mute-idiom/README.md"
] | [
"mute-idiom/README.md"
] | [] | diff --git a/mute-idiom/README.md b/mute-idiom/README.md
index 6e94ce4d989f..1b25e95fcaf5 100644
--- a/mute-idiom/README.md
+++ b/mute-idiom/README.md
@@ -2,23 +2,94 @@
title: Mute Idiom
category: Idiom
language: en
-tag:
- - Decoupling
+tag:
+- Decoupling
---
+
## Intent
Provide a template to suppress any exc... | null | train | test | 2023-10-15T15:45:17 | 2022-10-29T20:00:05Z | iluwatar | train |
iluwatar/java-design-patterns/2245_2717 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2245 | iluwatar/java-design-patterns/2717 | [
"keyword_pr_to_issue"
] | f63c5dd46ddaaeaa6c2844dd7db6192fafce616a | fb507110442bc2a132704c45bdc6364197c0119d | [
"Hi @iluwatar I would like to contribute to this issue. If you give me the opportunity, I will try my best to solve it. Thank you!",
"This issue has been automatically marked as stale because it has not had recent activity. The issue will be unassigned if no further activity occurs. Thank you for your contributio... | [
"Avoid removing spaces. They are meant for indentation",
"I'm sorry, I have added the space back"
] | 2023-10-21T04:22:06Z | [
"type: feature",
"status: stale",
"epic: documentation"
] | Explanation for Monad | In this issue, let's add a proper explanation for the pattern.
Acceptance criteria
- The pattern's README.md has been amended with an explanation
- The explanation consists of
- Real world example
- In plain words
- Wikipedia says
- Programmatic example
| [
"monad/README.md"
] | [
"monad/README.md"
] | [] | diff --git a/monad/README.md b/monad/README.md
index f53632faee70..9ccaaebb98ce 100644
--- a/monad/README.md
+++ b/monad/README.md
@@ -15,6 +15,107 @@ operations:
bind - that takes monadic object and a function from plain object to monadic value and returns monadic value
return - that takes plain type object and retu... | null | test | test | 2023-10-15T15:45:17 | 2022-10-29T19:59:58Z | iluwatar | train |
iluwatar/java-design-patterns/2238_2770 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2238 | iluwatar/java-design-patterns/2770 | [
"keyword_pr_to_issue"
] | 163c3017bb356937d876cd9a05905c012f3b0af6 | 2c35b34c41e14affe08179150b9e66b361ef6851 | [
"I want to contribute on this. Could you please assign me."
] | [] | 2023-11-04T17:03:05Z | [
"type: feature",
"epic: documentation"
] | Explanation for Leader Election | In this issue, let's add a proper explanation for the pattern.
Acceptance criteria
- The pattern's README.md has been amended with an explanation
- The explanation consists of
- Real world example
- In plain words
- Wikipedia says
- Programmatic example
| [
"leader-election/README.md"
] | [
"leader-election/README.md"
] | [] | diff --git a/leader-election/README.md b/leader-election/README.md
index d2a6ff473e3f..ec57487a9c03 100644
--- a/leader-election/README.md
+++ b/leader-election/README.md
@@ -7,7 +7,821 @@ tag:
---
## Intent
-Leader Election pattern is commonly used in cloud system design. It can help to ensure that task instances ... | null | train | test | 2023-10-28T10:41:41 | 2022-10-29T19:59:39Z | iluwatar | train |
iluwatar/java-design-patterns/2223_2771 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2223 | iluwatar/java-design-patterns/2771 | [
"keyword_pr_to_issue"
] | 163c3017bb356937d876cd9a05905c012f3b0af6 | 83986c794bdd27755ab3504113eedd1fdac36f69 | [
"Could you please assign me?"
] | [] | 2023-11-06T03:57:50Z | [
"type: feature",
"epic: documentation"
] | Explanation for Double Buffer | In this issue, let's add a proper explanation for the pattern.
Acceptance criteria
- The pattern's README.md has been amended with an explanation
- The explanation consists of
- Real world example
- In plain words
- Wikipedia says
- Programmatic example
| [
"double-buffer/README.md"
] | [
"double-buffer/README.md"
] | [] | diff --git a/double-buffer/README.md b/double-buffer/README.md
index 089e30e6d3d2..04b47ad97f7e 100644
--- a/double-buffer/README.md
+++ b/double-buffer/README.md
@@ -1,14 +1,243 @@
----
+---
title: Double Buffer
category: Behavioral
language: en
tag:
- Performance
- Game programming
----
+---
## ... | null | val | test | 2023-10-28T10:41:41 | 2022-10-29T19:58:54Z | iluwatar | train |
iluwatar/java-design-patterns/2366_2776 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2366 | iluwatar/java-design-patterns/2776 | [
"keyword_pr_to_issue"
] | 163c3017bb356937d876cd9a05905c012f3b0af6 | 0f39267a197e1e6ba08dfffa2d9df774fe25c6fe | [
"@iluwatar Can I work on this issue?\r\n",
"I would like to work on this issue, can I join?",
"This issue has been automatically marked as stale because it has not had recent activity. The issue will be unassigned if no further activity occurs. Thank you for your contributions.\n",
"Hello, I don't see any PR ... | [] | 2023-11-26T10:30:53Z | [
"epic: architecture",
"type: refactoring",
"status: stale"
] | Uniform handling for H2 databases | At the moment, many of the patterns utilize H2 databases to demonstrate data access (search for `jdbc:h2`). The problem is that we don't have a unified approach. Some of the patterns use file-based database written somewhere under the home directory and some use in-memory databases. Perhaps we could use in-memory datab... | [
"dao/src/main/java/com/iluwatar/dao/App.java",
"domain-model/src/main/java/com/iluwatar/domainmodel/App.java",
"layers/src/main/resources/application.properties",
"repository/src/main/java/com/iluwatar/repository/AppConfig.java",
"repository/src/main/resources/applicationContext.xml",
"serialized-entity/R... | [
"dao/src/main/java/com/iluwatar/dao/App.java",
"domain-model/src/main/java/com/iluwatar/domainmodel/App.java",
"layers/src/main/resources/application.properties",
"repository/src/main/java/com/iluwatar/repository/AppConfig.java",
"repository/src/main/resources/applicationContext.xml",
"serialized-entity/R... | [
"dao/src/test/java/com/iluwatar/dao/DbCustomerDaoTest.java",
"serialized-entity/src/test/java/com/iluwatar/serializedentity/AppTest.java",
"table-module/src/test/java/com/iluwatar/tablemodule/UserTableModuleTest.java",
"transaction-script/src/test/java/com/iluwatar/transactionscript/HotelDaoImplTest.java",
... | diff --git a/dao/src/main/java/com/iluwatar/dao/App.java b/dao/src/main/java/com/iluwatar/dao/App.java
index 20d1db0633dd..f0d19749c64b 100644
--- a/dao/src/main/java/com/iluwatar/dao/App.java
+++ b/dao/src/main/java/com/iluwatar/dao/App.java
@@ -44,7 +44,7 @@
*/
@Slf4j
public class App {
- private static final St... | diff --git a/dao/src/test/java/com/iluwatar/dao/DbCustomerDaoTest.java b/dao/src/test/java/com/iluwatar/dao/DbCustomerDaoTest.java
index 666c7634c158..cfa7e9882981 100644
--- a/dao/src/test/java/com/iluwatar/dao/DbCustomerDaoTest.java
+++ b/dao/src/test/java/com/iluwatar/dao/DbCustomerDaoTest.java
@@ -49,7 +49,7 @@
*... | train | test | 2023-10-28T10:41:41 | 2022-11-29T19:07:58Z | iluwatar | train |
iluwatar/java-design-patterns/1297_2818 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/1297 | iluwatar/java-design-patterns/2818 | [
"keyword_pr_to_issue"
] | e340f4f3f8c33efa63e10041b490516f3f892db5 | 98505c61dde1b91f730543fdf42c2ded9ee85630 | [
"Hi @iluwatar! can I work on this issue?",
"Please go ahead @kelumsampath ",
"Hello @iluwatar , I can work on this pattern if there are no takers :-)\r\n",
"All right, it's yours @shibicr93 ",
"This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no ... | [] | 2024-03-10T09:03:54Z | [
"epic: pattern",
"type: feature",
"status: stale"
] | Gateway pattern | https://stackoverflow.com/questions/4422211/what-is-the-difference-between-facade-and-gateway-design-patterns | [
"gateway/README.md",
"pom.xml"
] | [
"gateway/README.md",
"pom.xml"
] | [] | diff --git a/gateway/README.md b/gateway/README.md
index f1152ec6cfb4..9307b5d1d0f9 100644
--- a/gateway/README.md
+++ b/gateway/README.md
@@ -3,7 +3,6 @@ title: Gateway
category: Structural
language: en
tag:
-- Gang of Four
- Decoupling
---
@@ -38,7 +37,7 @@ The main class in our example is the `ExternalService... | null | train | test | 2024-03-10T09:56:02 | 2020-07-07T17:36:34Z | iluwatar | train |
iluwatar/java-design-patterns/2215_2875 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2215 | iluwatar/java-design-patterns/2875 | [
"keyword_pr_to_issue"
] | 7c1889b8e5800b60013a96d567b64df51dd62ae1 | 9538c7820c34e879443078d9614fb570a00b4911 | [
"@iluwatar, I am interested to work on this issue.Will you assign this to me?",
"@iluwatar ,Can I know should I add about collection pipeline in existing folder, or should I create new folder and add the explanation ?",
"We need to provide a better explanation for the pattern in https://github.com/iluwatar/java... | [] | 2024-03-30T11:21:24Z | [
"type: feature",
"epic: documentation"
] | Explanation for Collection Pipeline | In this issue, let's add a proper explanation for the pattern.
Acceptance criteria
- The pattern's README.md has been amended with an explanation
- The explanation consists of
- Real world example
- In plain words
- Wikipedia says
- Programmatic example
| [
"collection-pipeline/README.md",
"collection-pipeline/src/main/java/com/iluwatar/collectionpipeline/Car.java",
"collection-pipeline/src/main/java/com/iluwatar/collectionpipeline/FunctionalProgramming.java",
"collection-pipeline/src/main/java/com/iluwatar/collectionpipeline/ImperativeProgramming.java",
"coll... | [
"collection-pipeline/README.md",
"collection-pipeline/src/main/java/com/iluwatar/collectionpipeline/Car.java",
"collection-pipeline/src/main/java/com/iluwatar/collectionpipeline/FunctionalProgramming.java",
"collection-pipeline/src/main/java/com/iluwatar/collectionpipeline/ImperativeProgramming.java",
"coll... | [] | diff --git a/collection-pipeline/README.md b/collection-pipeline/README.md
index 3ae285accb69..aab323e0ec14 100644
--- a/collection-pipeline/README.md
+++ b/collection-pipeline/README.md
@@ -3,25 +3,145 @@ title: Collection Pipeline
category: Functional
language: en
tag:
- - Reactive
+ - Reactive
+ - Data proc... | null | train | test | 2024-03-30T07:34:54 | 2022-10-29T19:58:23Z | iluwatar | train |
iluwatar/java-design-patterns/2876_2877 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2876 | iluwatar/java-design-patterns/2877 | [
"keyword_pr_to_issue"
] | 8471c93035b643528455cbba3957a0922d17e4de | 2228212c2361c3ed54babe2b3778f386f5aac9d5 | [] | [] | 2024-03-30T12:32:56Z | [
"info: help wanted",
"type: feature",
"epic: documentation"
] | Explanation for Combinator pattern | In this issue, let's add a proper explanation for the pattern.
Acceptance criteria
- The pattern's README.md has been amended with an explanation
- The explanation consists of
- Real world example
- In plain words
- Wikipedia says
- Programmatic example | [
"combinator/README.md"
] | [
"combinator/README.md"
] | [
"combinator/src/test/java/com/iluwatar/combinator/FinderTest.java",
"combinator/src/test/java/com/iluwatar/combinator/FindersTest.java"
] | diff --git a/combinator/README.md b/combinator/README.md
index 15ec1ea59019..70b6a82f7942 100644
--- a/combinator/README.md
+++ b/combinator/README.md
@@ -1,132 +1,136 @@
---
title: Combinator
-category: Idiom
+category: Functional
language: en
tag:
- - Reactive
+ - Idiom
+ - Reactive
---
## Also known as... | diff --git a/combinator/src/test/java/com/iluwatar/combinator/FinderTest.java b/combinator/src/test/java/com/iluwatar/combinator/FinderTest.java
index 4f0d42258d62..c4a505df075d 100644
--- a/combinator/src/test/java/com/iluwatar/combinator/FinderTest.java
+++ b/combinator/src/test/java/com/iluwatar/combinator/FinderTes... | train | test | 2024-03-30T12:58:18 | 2024-03-30T12:12:35Z | iluwatar | train |
iluwatar/java-design-patterns/2216_2878 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2216 | iluwatar/java-design-patterns/2878 | [
"keyword_pr_to_issue"
] | 2228212c2361c3ed54babe2b3778f386f5aac9d5 | 81ebcf0a791adb28175186332038922f5087c82d | [
"Could you please assign me? I want to nominate myself for this.",
"This issue has been automatically marked as stale because it has not had recent activity. The issue will be unassigned if no further activity occurs. Thank you for your contributions.\n"
] | [] | 2024-03-30T15:35:53Z | [
"info: help wanted",
"type: feature",
"epic: documentation"
] | Explanation for Commander | In this issue, let's add a proper explanation for the pattern.
Acceptance criteria
- The pattern's README.md has been amended with an explanation
- The explanation consists of
- Real world example
- In plain words
- Wikipedia says
- Programmatic example
| [
"commander/README.md",
"commander/src/main/java/com/iluwatar/commander/Commander.java",
"commander/src/main/java/com/iluwatar/commander/Retry.java",
"commander/src/main/java/com/iluwatar/commander/employeehandle/EmployeeHandle.java",
"commander/src/main/java/com/iluwatar/commander/messagingservice/Messaging... | [
"commander/README.md",
"commander/src/main/java/com/iluwatar/commander/Commander.java",
"commander/src/main/java/com/iluwatar/commander/Retry.java",
"commander/src/main/java/com/iluwatar/commander/employeehandle/EmployeeHandle.java",
"commander/src/main/java/com/iluwatar/commander/messagingservice/Messaging... | [
"commander/src/test/java/com/iluwatar/commander/RetryTest.java"
] | diff --git a/commander/README.md b/commander/README.md
index 472370f4bbe1..f6cacd243f76 100644
--- a/commander/README.md
+++ b/commander/README.md
@@ -1,25 +1,162 @@
---
title: Commander
-category: Concurrency
+category: Behavioral
language: en
tag:
- - Cloud distributed
+ - Cloud distributed
+ - Microservice... | diff --git a/commander/src/test/java/com/iluwatar/commander/RetryTest.java b/commander/src/test/java/com/iluwatar/commander/RetryTest.java
index 2276b340efc7..c74fb94d0f9d 100644
--- a/commander/src/test/java/com/iluwatar/commander/RetryTest.java
+++ b/commander/src/test/java/com/iluwatar/commander/RetryTest.java
@@ -3... | val | test | 2024-03-30T13:44:43 | 2022-10-29T19:58:28Z | iluwatar | train |
iluwatar/java-design-patterns/2870_2885 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2870 | iluwatar/java-design-patterns/2885 | [
"keyword_pr_to_issue"
] | 74cce87c70385a629d3eb929c2767aec503ff0db | 9f97c1505d8985d7b0f6d4cea3f91c23a0b54bdd | [
"Hi @iluwatar ,\r\nUpgrading version of `jackson-databind` to 2.17.0 incompatible with current versions of `jackson-core` in the project which I have found 2.13.4 and 2.15.4. So we also have to upgrade the `jackson-core`.\r\nI have seen that only upgrading `jackson-databind` to 2.17.0 internally using 2.13.4.\r\n\r... | [] | 2024-04-01T15:14:46Z | [
"info: good first issue",
"epic: dependencies"
] | Upgrade jackson-databind | The version bump of jackson-databind seems to need some work. See https://github.com/iluwatar/java-design-patterns/pull/2867
Acceptance criteria
- jackson-databind successfully upgraded to the latest version
| [
"dynamic-proxy/pom.xml",
"event-sourcing/pom.xml"
] | [
"dynamic-proxy/pom.xml",
"event-sourcing/pom.xml"
] | [] | diff --git a/dynamic-proxy/pom.xml b/dynamic-proxy/pom.xml
index 0ec69f0bcc6e..d308c7885993 100644
--- a/dynamic-proxy/pom.xml
+++ b/dynamic-proxy/pom.xml
@@ -35,10 +35,15 @@
</parent>
<artifactId>dynamic-proxy</artifactId>
<dependencies>
+ <dependency>
+ <groupId>com.fasterxml.jackson.core</groupId>... | null | train | test | 2024-04-01T16:54:49 | 2024-03-29T11:09:17Z | iluwatar | train |
iluwatar/java-design-patterns/2853_2886 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2853 | iluwatar/java-design-patterns/2886 | [
"keyword_pr_to_issue"
] | 74cce87c70385a629d3eb929c2767aec503ff0db | 3ac7cc326898429855246d2a9578cf59553b3153 | [
"assign it to me!! I resolved it locally",
"Hi @iluwatar I have made the pr. ps review it. #2886 "
] | [] | 2024-04-01T15:51:21Z | [
"info: good first issue",
"type: refactoring"
] | Composite View refactoring needed | Servlets are components in Java web development, responsible for processing HTTP requests and generating responses. In this context, exceptions are used to handle and manage unexpected errors or exceptional conditions that may occur during the execution of a servlet.
Exceptions should not be thrown from servlet method... | [
"composite-view/src/main/java/com/iluwatar/compositeview/AppServlet.java"
] | [
"composite-view/src/main/java/com/iluwatar/compositeview/AppServlet.java"
] | [] | diff --git a/composite-view/src/main/java/com/iluwatar/compositeview/AppServlet.java b/composite-view/src/main/java/com/iluwatar/compositeview/AppServlet.java
index 0cef25d2dd22..d2ec90675eb5 100644
--- a/composite-view/src/main/java/com/iluwatar/compositeview/AppServlet.java
+++ b/composite-view/src/main/java/com/iluw... | null | train | test | 2024-04-01T16:54:49 | 2024-03-27T14:38:51Z | iluwatar | train |
iluwatar/java-design-patterns/2217_2896 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2217 | iluwatar/java-design-patterns/2896 | [
"keyword_pr_to_issue"
] | 8f777cdc981877545194e513ac87f336f2e6fc00 | faac96b21b3074cc7196713ab029810b68db4961 | [
" I'm excited to contribute to this project, and I'd like to start by working on this issue as my first contribution. Could you please assign this issue to me? I would greatly appreciate it if you could provide some guidance on how to get started with addressing this issue. \r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n\r\n",
... | [] | 2024-04-06T09:56:49Z | [
"type: feature",
"epic: documentation"
] | Explanation for Command Query Responsibility Segregation (CQRS) | In this issue, let's add a proper explanation for the pattern.
Acceptance criteria
- The pattern's README.md has been amended with an explanation
- The explanation consists of
- Real world example
- In plain words
- Wikipedia says
- Programmatic example
| [
"cqrs/README.md",
"cqrs/pom.xml"
] | [
"cqrs/README.md",
"cqrs/pom.xml"
] | [] | diff --git a/cqrs/README.md b/cqrs/README.md
index 6ac6061ef70e..e4af36bc3c51 100644
--- a/cqrs/README.md
+++ b/cqrs/README.md
@@ -3,25 +3,89 @@ title: CQRS
category: Architectural
language: en
tag:
- - Performance
- - Cloud distributed
+ - Event-driven
+ - Performance
+ - Scalability
---
## Intent
-C... | null | test | test | 2024-04-06T09:43:40 | 2022-10-29T19:58:33Z | iluwatar | train |
iluwatar/java-design-patterns/2219_2899 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2219 | iluwatar/java-design-patterns/2899 | [
"keyword_pr_to_issue"
] | 356ba272720da7eb9cf3d622a4768c0957fa0e87 | ea55eb4e58dc7c0b3517dfb92c3a9b7cec1f6954 | [
"@iluwatar I can try this as well!",
"This issue has been automatically marked as stale because it has not had recent activity. The issue will be unassigned if no further activity occurs. Thank you for your contributions.\n"
] | [] | 2024-04-07T09:14:40Z | [
"type: feature",
"epic: documentation"
] | Explanation for Data Locality | In this issue, let's add a proper explanation for the pattern.
Acceptance criteria
- The pattern's README.md has been amended with an explanation
- The explanation consists of
- Real world example
- In plain words
- Wikipedia says
- Programmatic example
| [
"data-locality/README.md"
] | [
"data-locality/README.md"
] | [
"data-locality/src/test/java/com/iluwatar/data/locality/ApplicationTest.java"
] | diff --git a/data-locality/README.md b/data-locality/README.md
index 212bd663a08d..c44ba1a34fa5 100644
--- a/data-locality/README.md
+++ b/data-locality/README.md
@@ -1,29 +1,135 @@
---
title: Data Locality
-category: Behavioral
+category: Performance optimization
language: en
tag:
- - Game programming
- - Performa... | diff --git a/data-locality/src/test/java/com/iluwatar/data/locality/ApplicationTest.java b/data-locality/src/test/java/com/iluwatar/data/locality/ApplicationTest.java
index 1f5986c9f2bc..1f1689425f41 100644
--- a/data-locality/src/test/java/com/iluwatar/data/locality/ApplicationTest.java
+++ b/data-locality/src/test/ja... | train | test | 2024-04-07T10:29:35 | 2022-10-29T19:58:41Z | iluwatar | train |
iluwatar/java-design-patterns/2220_2900 | iluwatar/java-design-patterns | iluwatar/java-design-patterns/2220 | iluwatar/java-design-patterns/2900 | [
"keyword_pr_to_issue"
] | ea55eb4e58dc7c0b3517dfb92c3a9b7cec1f6954 | 39acd1d0fb3ba2d70acde009de52bfd3d356e189 | [
"Hi, I want to take this issue(I have taken this issue before but was closed)",
"Sorry to bother you, but I accidentally removed myself as the issue assignee, can you assign this issue to me again. Thank you so much!"
] | [] | 2024-04-07T10:58:48Z | [
"type: feature",
"epic: documentation"
] | Explanation for Data Mapper | In this issue, let's add a proper explanation for the pattern.
Acceptance criteria
- The pattern's README.md has been amended with an explanation
- The explanation consists of
- Real world example
- In plain words
- Wikipedia says
- Programmatic example
| [
"data-mapper/README.md",
"data-mapper/src/main/java/com/iluwatar/datamapper/DataMapperException.java",
"data-mapper/src/main/java/com/iluwatar/datamapper/Student.java",
"data-mapper/src/main/java/com/iluwatar/datamapper/StudentDataMapperImpl.java"
] | [
"data-mapper/README.md",
"data-mapper/src/main/java/com/iluwatar/datamapper/DataMapperException.java",
"data-mapper/src/main/java/com/iluwatar/datamapper/Student.java",
"data-mapper/src/main/java/com/iluwatar/datamapper/StudentDataMapperImpl.java"
] | [
"data-mapper/src/test/java/com/iluwatar/datamapper/AppTest.java",
"data-mapper/src/test/java/com/iluwatar/datamapper/StudentTest.java"
] | diff --git a/data-mapper/README.md b/data-mapper/README.md
index 7f8b141ee71e..9bf3f1d5124e 100644
--- a/data-mapper/README.md
+++ b/data-mapper/README.md
@@ -1,183 +1,132 @@
---
title: Data Mapper
-category: Architectural
+category: Behavioral
language: en
tag:
-- Decoupling
+ - Data access
+ - Decou... | diff --git a/data-mapper/src/test/java/com/iluwatar/datamapper/AppTest.java b/data-mapper/src/test/java/com/iluwatar/datamapper/AppTest.java
index 1f954ff811c8..f45f6cc3266e 100644
--- a/data-mapper/src/test/java/com/iluwatar/datamapper/AppTest.java
+++ b/data-mapper/src/test/java/com/iluwatar/datamapper/AppTest.java
@... | val | test | 2024-04-07T11:15:09 | 2022-10-29T19:58:44Z | iluwatar | train |
mockito/mockito/134_141 | mockito/mockito | mockito/mockito/134 | mockito/mockito/141 | [
"timestamp(timedelta=4237.0, similarity=0.8425201201576538)"
] | fb455b94118bf03faff3baf665cdb0b8f67d6968 | a2e731bb416949b7e2e4ce096b3454bed310e6eb | [
"Let's fix it in Mockito 2.0\n",
"I'm currently looking at fixing this.\n\nJust to confirm: the current anyX() behaviour is to just accept anything of any type at all (i.e. anyString()/anyInteger()/etc are all the same as anyObject()), and we'd prefer to instead make all of these methods (except anyObject) actual... | [] | 2014-12-16T01:02:41Z | [
"bug",
"1.* incompatible"
] | Argument matcher anyXxx() (i.e. anyString(), anyList()) should not match nulls | This is a bug I'm seeing in 1.10.8 version (older version has the same issue - tested with 1.9.0).
Given:
``` java
Function<Object, Integer> function = Mockito.mock(Function.class);
when(function.apply(Mockito.anyString())).thenReturn(1);
Integer result = function.apply(2);
```
Expected behavior:
``` java
result ==... | [
"src/org/mockito/Matchers.java",
"src/org/mockito/internal/matchers/Any.java",
"version.properties"
] | [
"src/org/mockito/Matchers.java",
"src/org/mockito/internal/matchers/Any.java",
"version.properties"
] | [
"test/org/mockitousage/IMethods.java",
"test/org/mockitousage/MethodsImpl.java",
"test/org/mockitousage/matchers/AnyXMatchersAcceptNullsTest.java",
"test/org/mockitousage/matchers/MatchersTest.java",
"test/org/mockitousage/matchers/NewMatchersTest.java",
"test/org/mockitousage/verification/DescriptiveMess... | diff --git a/src/org/mockito/Matchers.java b/src/org/mockito/Matchers.java
index 789d598bb4..a8b71dc79e 100644
--- a/src/org/mockito/Matchers.java
+++ b/src/org/mockito/Matchers.java
@@ -50,13 +50,6 @@
* This implementation is due static type safety imposed by java compiler.
* The consequence is that you cannot us... | diff --git a/test/org/mockitousage/IMethods.java b/test/org/mockitousage/IMethods.java
index 557e7c5e14..8c9a1b3359 100644
--- a/test/org/mockitousage/IMethods.java
+++ b/test/org/mockitousage/IMethods.java
@@ -219,4 +219,6 @@ public interface IMethods {
int toIntPrimitive(Integer i);
Integer toIntWrapper... | train | train | 2014-12-16T00:25:31 | 2014-12-12T10:20:31Z | alexo | train |
mockito/mockito/157_158 | mockito/mockito | mockito/mockito/157 | mockito/mockito/158 | [
"timestamp(timedelta=75.0, similarity=0.9395389559265163)"
] | fff76563d9e0ed412dc828c53cfdc7d142997a31 | d645862386143a8ae7d6bd122d0fcfa71c02e339 | [
"Duplicate of #28\nThough the team thought it was better for project that don't rely on maven like source repositories.\ncc @szczepiq \n"
] | [] | 2015-01-15T12:36:35Z | [] | Source files should not be put in binary JAR | Source files (`*.java`) should not be put into binary `mockito-core.jar`. It stupefies Idea to show decompiled file even when source jar is available.
| [
"build.gradle"
] | [
"build.gradle"
] | [] | diff --git a/build.gradle b/build.gradle
index 94ebdaf3cc..3ed8f310c0 100644
--- a/build.gradle
+++ b/build.gradle
@@ -71,7 +71,7 @@ def licenseFiles = copySpec {
jar {
baseName = 'mockito-core'
- from(sourceSets.main.allSource)
+ from(sourceSets.main.output)
from(zipTree("lib/repackaged/cglib-and-as... | null | train | train | 2015-01-04T13:44:24 | 2015-01-15T12:36:02Z | szpak | train |
mockito/mockito/172_175 | mockito/mockito | mockito/mockito/172 | mockito/mockito/175 | [
"timestamp(timedelta=2984.0, similarity=0.9343794448096776)"
] | 44fbd4985cb7448b727df60df398c1b7705b7602 | 9943c7c00d1480f3d778c6ca8b990c039d5c533c | [
"I agree.\nIt would be nice to depend on a version of hamcrest-core that is not eight years old...\n",
"Hi thanks for your interest. I think your comment are indeed just right, yet compatibility has always been the primary concern here.\n\nNevertheless mockito 2.0.x will probably ditch the hamcrest dependency. We... | [] | 2015-02-22T19:22:34Z | [] | Update hamcrest-core to version 1.3 | Hi there,
It would be nice if mockito-core would depend on hamcrest-core 1.3 instead of 1.1 so that both mockito and junit [latest versions] would depend on the same 3rd party library.
Thanks in advance!
| [
"build.gradle",
"src/org/mockito/internal/matchers/LocalizedMatcher.java"
] | [
"build.gradle",
"src/org/mockito/internal/matchers/LocalizedMatcher.java"
] | [
"test/org/mockito/internal/runners/RunnerFactoryTest.java",
"test/org/mockitousage/basicapi/MocksCreationTest.java",
"test/org/mockitoutil/ExtraMatchers.java"
] | diff --git a/build.gradle b/build.gradle
index 66145a4d0e..0ec718a1a5 100644
--- a/build.gradle
+++ b/build.gradle
@@ -61,7 +61,7 @@ tasks.withType(JavaCompile) {
//TODO we should remove all dependencies to checked-in jars
dependencies {
provided "junit:junit:4.10"
- compile "org.hamcrest:hamcrest-core:1.1", ... | diff --git a/test/org/mockito/internal/runners/RunnerFactoryTest.java b/test/org/mockito/internal/runners/RunnerFactoryTest.java
index 02c7abdd3b..e012bbdeef 100644
--- a/test/org/mockito/internal/runners/RunnerFactoryTest.java
+++ b/test/org/mockito/internal/runners/RunnerFactoryTest.java
@@ -1,7 +1,7 @@
-/*
- * Copyr... | val | train | 2015-02-16T02:17:52 | 2015-02-17T11:52:22Z | ghost | train |
mockito/mockito/200_201 | mockito/mockito | mockito/mockito/200 | mockito/mockito/201 | [
"timestamp(timedelta=1.0, similarity=0.8791892604278365)",
"keyword_pr_to_issue"
] | d3fd493288ccbdf1bf54d7d1ea0bb6c96ddc6d57 | 4a34cbe64cf93f2a275559e3613c5b2f074b235d | [
"PR #201\n"
] | [] | 2015-04-16T16:46:50Z | [
"enhancement"
] | ArgumentCaptor.fromClass's return type should match a parameterized type | `ArgumentCaptor.fromClass`'s return type should match a parameterized type. I.e. the expression `ArgumentCaptor.fromClass(Class<S>)` should be of type `ArgumentCaptor<U>` where `S` is a subtype of `U`.
For example:
```
ArgumentCaptor<Consumer<String>> captor = ArgumentCaptor.fromClass(Consumer.class)
```
does no... | [
"src/org/mockito/ArgumentCaptor.java"
] | [
"src/org/mockito/ArgumentCaptor.java"
] | [
"test/org/mockitousage/matchers/CapturingArgumentsTest.java"
] | diff --git a/src/org/mockito/ArgumentCaptor.java b/src/org/mockito/ArgumentCaptor.java
index 0efe061cf7..78c41c89f9 100644
--- a/src/org/mockito/ArgumentCaptor.java
+++ b/src/org/mockito/ArgumentCaptor.java
@@ -65,7 +65,7 @@ public class ArgumentCaptor<T> {
HandyReturnValues handyReturnValues = new HandyReturnValu... | diff --git a/test/org/mockitousage/matchers/CapturingArgumentsTest.java b/test/org/mockitousage/matchers/CapturingArgumentsTest.java
index 44c8d87b50..d833e681e2 100644
--- a/test/org/mockitousage/matchers/CapturingArgumentsTest.java
+++ b/test/org/mockitousage/matchers/CapturingArgumentsTest.java
@@ -14,6 +14,7 @@
im... | train | train | 2015-04-16T19:22:45 | 2015-04-16T16:42:19Z | bruceeddy | train |
mockito/mockito/187_202 | mockito/mockito | mockito/mockito/187 | mockito/mockito/202 | [
"keyword_pr_to_issue"
] | 4b5a03d1516778084e669f2f74ffbb9f9fc086f1 | 85fcbcb773ef8fd48105f18349d289b99591ba76 | [
"Hi,\n\nDo you have a JUnit test so that we could reproduce.\nAlso please see the [contributing guide](https://github.com/mockito/mockito/blob/master/CONTRIBUTING.md).\n",
"``` java\npublic class MockitoTest extends Mockito {\n public interface TestMock {\n public boolean m1();\n };\n\n @Test\n ... | [] | 2015-04-19T18:42:31Z | [
"bug"
] | java.lang.ClassCastException: java.lang.Class cannot be cast to java.lang.String | Exception throws on verifyZeroInteractions when using mock with default answer.
checked on versions 1.10.5-2.0.5
all ok on 1.9.5
| [
"src/org/mockito/exceptions/Reporter.java",
"src/org/mockito/internal/handler/MockHandlerImpl.java",
"src/org/mockito/internal/invocation/InvocationImpl.java",
"src/org/mockito/internal/stubbing/answers/AnswersValidator.java",
"src/org/mockito/invocation/Invocation.java"
] | [
"src/org/mockito/exceptions/Reporter.java",
"src/org/mockito/internal/handler/MockHandlerImpl.java",
"src/org/mockito/internal/invocation/InvocationImpl.java",
"src/org/mockito/internal/stubbing/answers/AnswersValidator.java",
"src/org/mockito/invocation/Invocation.java"
] | [
"test/org/mockito/exceptions/ReporterTest.java",
"test/org/mockito/internal/handler/MockHandlerImplTest.java",
"test/org/mockito/internal/stubbing/answers/AnswersValidatorTest.java",
"test/org/mockito/internal/verification/NoMoreInteractionsTest.java",
"test/org/mockitousage/bugs/ClassCastExOnVerifyZeroInte... | diff --git a/src/org/mockito/exceptions/Reporter.java b/src/org/mockito/exceptions/Reporter.java
index 7ae75886c0..e0b1105daf 100644
--- a/src/org/mockito/exceptions/Reporter.java
+++ b/src/org/mockito/exceptions/Reporter.java
@@ -8,7 +8,13 @@
import org.mockito.exceptions.base.MockitoAssertionError;
import org.mocki... | diff --git a/test/org/mockito/exceptions/ReporterTest.java b/test/org/mockito/exceptions/ReporterTest.java
index e006852784..3253ad819d 100644
--- a/test/org/mockito/exceptions/ReporterTest.java
+++ b/test/org/mockito/exceptions/ReporterTest.java
@@ -6,21 +6,81 @@
package org.mockito.exceptions;
import org.junit.Te... | train | train | 2015-04-17T11:55:17 | 2015-03-24T13:14:54Z | mktitov | train |
mockito/mockito/197_207 | mockito/mockito | mockito/mockito/197 | mockito/mockito/207 | [
"keyword_pr_to_issue"
] | d30450fa1172d79cc051b2fe8064744c2ac7a003 | 45aa5bf2c266268d209aabf17053e975e2634da1 | [
"Well spotted, thx\n",
"I can try to fix that, but need to know what exactly is the issue here:\nShould negative values in after method be forbidden and trigger exception to be thrown? or maybe negatives are allowed here (negative value means - immediately, pretty much it should behave like after(0) )?\n",
"I w... | [] | 2015-05-08T19:15:59Z | [
"bug"
] | Mockito.after() method accepts negative timeperiods and subsequent verifications always pass | e.g.
```
Runnable runnable = Mockito.mock(Runnable.class);
Mockito.verify(runnable, Mockito.never()).run(); // passes as expected
Mockito.verify(runnable, Mockito.after(1000).never()).run(); // passes as expected
Mockito.verify(runnable, Mockito.after(-1000).atLeastOnce()).run(); // passes incorrectly
```
| [
"src/org/mockito/exceptions/Reporter.java",
"src/org/mockito/internal/util/Timer.java",
"src/org/mockito/internal/verification/VerificationOverTimeImpl.java",
"src/org/mockito/verification/After.java",
"src/org/mockito/verification/Timeout.java"
] | [
"src/org/mockito/exceptions/Reporter.java",
"src/org/mockito/internal/util/Timer.java",
"src/org/mockito/internal/verification/VerificationOverTimeImpl.java",
"src/org/mockito/verification/After.java",
"src/org/mockito/verification/Timeout.java"
] | [
"test/org/mockito/internal/util/TimerTest.java",
"test/org/mockito/verification/NegativeDurationTest.java",
"test/org/mockito/verification/TimeoutTest.java"
] | diff --git a/src/org/mockito/exceptions/Reporter.java b/src/org/mockito/exceptions/Reporter.java
index e0b1105daf..6e0b3bd157 100644
--- a/src/org/mockito/exceptions/Reporter.java
+++ b/src/org/mockito/exceptions/Reporter.java
@@ -816,6 +816,15 @@ public void usingConstructorWithFancySerializable(SerializableMode mode)... | diff --git a/test/org/mockito/internal/util/TimerTest.java b/test/org/mockito/internal/util/TimerTest.java
index 5e5f0f7841..e1156688c1 100644
--- a/test/org/mockito/internal/util/TimerTest.java
+++ b/test/org/mockito/internal/util/TimerTest.java
@@ -1,6 +1,8 @@
package org.mockito.internal.util;
+import org.junit.A... | train | train | 2015-04-19T20:47:19 | 2015-04-13T14:33:49Z | nathanmbrown | train |
mockito/mockito/188_211 | mockito/mockito | mockito/mockito/188 | mockito/mockito/211 | [
"keyword_issue_to_pr",
"timestamp(timedelta=0.0, similarity=1.0)",
"keyword_pr_to_issue"
] | 0cd01b9d9719ef952035a426eef8272561f35d54 | 30e16ddddae1710ad096356f5a421fe22596c4de | [
"Hi sorry for the late reply.\nI reproduced the issue, not sure when I will be able to fix though.\n",
"fixed by #211 \n"
] | [] | 2015-05-20T19:14:50Z | [
"bug"
] | ArgumentCaptor no longer working for varargs | I ran into the issue described here: http://stackoverflow.com/questions/27303562/why-does-upgrading-mockito-from-1-9-5-to-1-10-8-break-this-captor
| [
"src/org/mockito/internal/invocation/CapturesArgumensFromInvocation.java",
"src/org/mockito/internal/invocation/InvocationMarker.java",
"src/org/mockito/internal/invocation/InvocationMatcher.java"
] | [
"src/org/mockito/internal/invocation/CapturesArgumentsFromInvocation.java",
"src/org/mockito/internal/invocation/InvocationMarker.java",
"src/org/mockito/internal/invocation/InvocationMatcher.java"
] | [
"test/org/mockito/internal/invocation/InvocationMarkerTest.java",
"test/org/mockito/internal/verification/checkers/AtLeastXNumberOfInvocationsCheckerTest.java",
"test/org/mockitousage/matchers/CapturingArgumentsTest.java"
] | diff --git a/src/org/mockito/internal/invocation/CapturesArgumensFromInvocation.java b/src/org/mockito/internal/invocation/CapturesArgumentsFromInvocation.java
similarity index 83%
rename from src/org/mockito/internal/invocation/CapturesArgumensFromInvocation.java
rename to src/org/mockito/internal/invocation/CapturesA... | diff --git a/test/org/mockito/internal/invocation/InvocationMarkerTest.java b/test/org/mockito/internal/invocation/InvocationMarkerTest.java
index 085b9a808b..d85320c485 100644
--- a/test/org/mockito/internal/invocation/InvocationMarkerTest.java
+++ b/test/org/mockito/internal/invocation/InvocationMarkerTest.java
@@ -3... | train | train | 2015-06-04T08:58:29 | 2015-04-01T00:16:10Z | vadims | train |
mockito/mockito/205_215 | mockito/mockito | mockito/mockito/205 | mockito/mockito/215 | [
"timestamp(timedelta=0.0, similarity=0.87539028548778)"
] | 03028f0095d527ff9bd84bc929fc4931f17abf13 | 32ceae5e361a96641785a7c75d87e49c50505663 | [
"@SimenB Maybe txtNextStep TextView Class Mocking the aneunge not work properly?\nA bug or would not even be on @InjectMocks features?\n",
"I have answered a similar question on Stackoverflow and you can find my investigations at http://stackoverflow.com/a/29954211/2761676\n",
"@JeremybellEU Yeah, that seems to... | [] | 2015-06-02T22:55:10Z | [] | InjectMocks injects mock into wrong field | Using `1.10.19`.
When using `@InjectMocks` on some Android `TextView`s, the mock is injected into the wrong field.
We have two fields, `txtGateView` & `txtNextStep` in a class, and our test mocks out `txtNextStep`, then tried to inject. This field is injected wrong, see screenshot.
![image](https://cloud.githubuserc... | [
"src/org/mockito/internal/configuration/injection/PropertyAndSetterInjection.java",
"src/org/mockito/internal/configuration/injection/filter/FinalMockCandidateFilter.java",
"src/org/mockito/internal/configuration/injection/filter/MockCandidateFilter.java",
"src/org/mockito/internal/configuration/injection/fil... | [
"src/org/mockito/internal/configuration/injection/PropertyAndSetterInjection.java",
"src/org/mockito/internal/configuration/injection/filter/FinalMockCandidateFilter.java",
"src/org/mockito/internal/configuration/injection/filter/MockCandidateFilter.java",
"src/org/mockito/internal/configuration/injection/fil... | [
"test/org/mockitousage/annotation/MockInjectionUsingSetterOrPropertyTest.java"
] | diff --git a/src/org/mockito/internal/configuration/injection/PropertyAndSetterInjection.java b/src/org/mockito/internal/configuration/injection/PropertyAndSetterInjection.java
index 67126afd95..c17f961c5a 100644
--- a/src/org/mockito/internal/configuration/injection/PropertyAndSetterInjection.java
+++ b/src/org/mockit... | diff --git a/test/org/mockitousage/annotation/MockInjectionUsingSetterOrPropertyTest.java b/test/org/mockitousage/annotation/MockInjectionUsingSetterOrPropertyTest.java
index bd49f3adee..c6eb915851 100644
--- a/test/org/mockitousage/annotation/MockInjectionUsingSetterOrPropertyTest.java
+++ b/test/org/mockitousage/anno... | train | train | 2015-06-02T21:54:46 | 2015-04-30T09:25:09Z | SimenB | train |
mockito/mockito/212_221 | mockito/mockito | mockito/mockito/212 | mockito/mockito/221 | [
"keyword_pr_to_issue",
"timestamp(timedelta=2.0, similarity=0.8905683933467733)"
] | 0cd01b9d9719ef952035a426eef8272561f35d54 | 01b0100e3cd3de6baa3359a8175c24b245067393 | [
"OK, are you ready for a PR ?\n",
"@bric3, please see #221\n"
] | [] | 2015-06-04T16:51:45Z | [
"enhancement",
"BDD"
] | Add BDD version of verifyZeroInteractions() | Right now my tests look like:
``` java
then(file).should().moveTo(directory);
then(log).should().warn("Moved file"));
verifyZeroInteractions(otherFile);
```
Would be great to have BDD replacement for `verifyZeroInteractions()`. Then the test would be even nicer:
``` java
then(file).should().moveTo(directory);
then(l... | [
"src/org/mockito/BDDMockito.java"
] | [
"src/org/mockito/BDDMockito.java"
] | [
"test/org/mockitousage/customization/BDDMockitoTest.java"
] | diff --git a/src/org/mockito/BDDMockito.java b/src/org/mockito/BDDMockito.java
index 3d008b5516..d0e280c665 100644
--- a/src/org/mockito/BDDMockito.java
+++ b/src/org/mockito/BDDMockito.java
@@ -57,6 +57,7 @@
* person.ride(bike);
*
* then(person).should(times(2)).ride(bike);
+ * then(police).shouldHaveZeroI... | diff --git a/test/org/mockitousage/customization/BDDMockitoTest.java b/test/org/mockitousage/customization/BDDMockitoTest.java
index 8211338b43..71b50196bc 100644
--- a/test/org/mockitousage/customization/BDDMockitoTest.java
+++ b/test/org/mockitousage/customization/BDDMockitoTest.java
@@ -7,6 +7,7 @@
import org.junit... | train | train | 2015-06-04T08:58:29 | 2015-05-22T05:48:18Z | mkordas | train |
mockito/mockito/203_222 | mockito/mockito | mockito/mockito/203 | mockito/mockito/222 | [
"keyword_pr_to_issue",
"timestamp(timedelta=0.0, similarity=0.9299964359171426)"
] | 1ccd0e7bacfbc56e4e796cbde2ff3a896f71c1ad | 61477c40e15480e5f00f3ea4cbffa23b34d2b1b8 | [
"It seems like a nice idea, let's introduce ordered BDD. I'd favor proposition 2, it reads better imho.\n\nSince we are in a beta phase, we can try and see if the API works with this proposition. Also it should probably be easier to implement.\n",
"Also sorry for this late reply\n",
"@bric3, I've implemented th... | [] | 2015-06-04T18:03:08Z | [
"enhancement",
"BDD"
] | Introduce BDD InOrder verification | Follow-up to the [discussion](https://groups.google.com/forum/#!topic/mockito/wr1As1fg_-U).
[BDDMockito](http://site.mockito.org/mockito/docs/current/org/mockito/BDDMockito.html) is great, but right now it doesn't support InOrder verification. Here is my proposition:
##### Initialization and invocations:
``` java
Lis... | [
"src/org/mockito/BDDMockito.java"
] | [
"src/org/mockito/BDDMockito.java"
] | [
"test/org/mockitousage/customization/BDDMockitoTest.java"
] | diff --git a/src/org/mockito/BDDMockito.java b/src/org/mockito/BDDMockito.java
index d0e280c665..4ab46397d2 100644
--- a/src/org/mockito/BDDMockito.java
+++ b/src/org/mockito/BDDMockito.java
@@ -59,7 +59,19 @@
* then(person).should(times(2)).ride(bike);
* then(police).shouldHaveZeroInteractions();
* </code></... | diff --git a/test/org/mockitousage/customization/BDDMockitoTest.java b/test/org/mockitousage/customization/BDDMockitoTest.java
index 71b50196bc..8b9324cfdd 100644
--- a/test/org/mockitousage/customization/BDDMockitoTest.java
+++ b/test/org/mockitousage/customization/BDDMockitoTest.java
@@ -5,9 +5,11 @@
package org.moc... | test | train | 2015-06-04T19:01:12 | 2015-04-25T21:50:45Z | mkordas | train |
mockito/mockito/228_229 | mockito/mockito | mockito/mockito/228 | mockito/mockito/229 | [
"timestamp(timedelta=1.0, similarity=0.8770086465478265)"
] | 2a686ff33684ba12cd3d82e17bd6882588ae6a7f | b561284b7d52ed187127b89d8715ce173878e859 | [
"Cool thanks :)\n"
] | [] | 2015-06-11T07:29:49Z | [] | @Captor javadoc contains a wrong call example | In the javadoc of `@Captor`:
```
verify(mock.doStuff(captor.capture()));
```
which is incorrect.
| [
"src/org/mockito/Captor.java"
] | [
"src/org/mockito/Captor.java"
] | [] | diff --git a/src/org/mockito/Captor.java b/src/org/mockito/Captor.java
index 1a081a2513..225bf700f2 100644
--- a/src/org/mockito/Captor.java
+++ b/src/org/mockito/Captor.java
@@ -22,7 +22,7 @@
*
* @Test public void shouldDoSomethingUseful() {
* //...
- * verify(mock.doStuff(captor.capture()));
... | null | test | train | 2015-06-06T21:43:00 | 2015-06-11T07:23:56Z | eugene-ivakhno | train |
mockito/mockito/231_232 | mockito/mockito | mockito/mockito/231 | mockito/mockito/232 | [
"timestamp(timedelta=169247.0, similarity=0.9113863832886153)"
] | 6b5424acebc1bc4ebaca97d6592ade901d1fb838 | 3359a126b5e0a45f084820c615ae007736367121 | [
"Hi @durron597, no actualluy the plan is to not make hamcrest as required dependency at all, just like JUnit is a not a required dependency.\n",
"I understand that's the plan, I'm just saying, as a temporary change, in between now and the time you have hamcrest not be a required dependency at all, advancing the h... | [] | 2015-06-15T14:13:09Z | [] | Upgrade to Hamcrest 1.3 in pom | I know this may be a meaningless case because of #154, but if you're going to [continue to release versions of Mockito that include hamcrest as a required dependency in the pom](http://central.maven.org/maven2/org/mockito/mockito-core/2.0.13-beta/mockito-core-2.0.13-beta.pom), could you at least upgrade it to 1.3? JUni... | [
"build.gradle",
"src/org/mockito/internal/matchers/LocalizedMatcher.java"
] | [
"build.gradle",
"src/org/mockito/internal/matchers/LocalizedMatcher.java"
] | [
"test/org/mockito/internal/runners/RunnerFactoryTest.java",
"test/org/mockitousage/basicapi/MocksCreationTest.java",
"test/org/mockitoutil/ExtraMatchers.java"
] | diff --git a/build.gradle b/build.gradle
index 8f7c9ac72f..d78688fc05 100644
--- a/build.gradle
+++ b/build.gradle
@@ -62,8 +62,8 @@ tasks.withType(JavaCompile) {
dependencies {
compile 'net.bytebuddy:byte-buddy:0.6.8'
- provided "junit:junit:4.10"
- compile "org.hamcrest:hamcrest-core:1.1", "org.objenesi... | diff --git a/test/org/mockito/internal/runners/RunnerFactoryTest.java b/test/org/mockito/internal/runners/RunnerFactoryTest.java
index 7620ed7197..4b8ba78074 100644
--- a/test/org/mockito/internal/runners/RunnerFactoryTest.java
+++ b/test/org/mockito/internal/runners/RunnerFactoryTest.java
@@ -37,7 +37,7 @@ public bool... | val | train | 2015-06-15T05:19:47 | 2015-06-12T18:54:50Z | durron597 | train |
mockito/mockito/154_232 | mockito/mockito | mockito/mockito/154 | mockito/mockito/232 | [
"timestamp(timedelta=169205.0, similarity=0.8423210559979228)"
] | 6b5424acebc1bc4ebaca97d6592ade901d1fb838 | 3359a126b5e0a45f084820c615ae007736367121 | [
"What's the progress on this? I'd like to use Mockito with my unit tests and I'm running JUnit 4.11 that is bundled with Eclipse 4.4 that I'm using.\n",
"Is Hamcrest dependency a blocker for using Mockito with Eclipse 4.4 ?\n\n-- Brice\n\nOn Tue, Jan 27, 2015 at 10:10 AM, Tobias Eriksson notifications@github.com\... | [] | 2015-06-15T14:13:09Z | [
"enhancement",
"1.* incompatible"
] | stop depending on hamcrest internally | In order to avoid compatibility/upgrade problems we will stop depending on hamcrest internally. Hamcrest will be an optional dependency of Mockito.
| [
"build.gradle",
"src/org/mockito/internal/matchers/LocalizedMatcher.java"
] | [
"build.gradle",
"src/org/mockito/internal/matchers/LocalizedMatcher.java"
] | [
"test/org/mockito/internal/runners/RunnerFactoryTest.java",
"test/org/mockitousage/basicapi/MocksCreationTest.java",
"test/org/mockitoutil/ExtraMatchers.java"
] | diff --git a/build.gradle b/build.gradle
index 8f7c9ac72f..d78688fc05 100644
--- a/build.gradle
+++ b/build.gradle
@@ -62,8 +62,8 @@ tasks.withType(JavaCompile) {
dependencies {
compile 'net.bytebuddy:byte-buddy:0.6.8'
- provided "junit:junit:4.10"
- compile "org.hamcrest:hamcrest-core:1.1", "org.objenesi... | diff --git a/test/org/mockito/internal/runners/RunnerFactoryTest.java b/test/org/mockito/internal/runners/RunnerFactoryTest.java
index 7620ed7197..4b8ba78074 100644
--- a/test/org/mockito/internal/runners/RunnerFactoryTest.java
+++ b/test/org/mockito/internal/runners/RunnerFactoryTest.java
@@ -37,7 +37,7 @@ public bool... | val | train | 2015-06-15T05:19:47 | 2015-01-04T17:53:45Z | mockitoguy | train |
mockito/mockito/233_234 | mockito/mockito | mockito/mockito/233 | mockito/mockito/234 | [
"keyword_pr_to_issue"
] | 6b5424acebc1bc4ebaca97d6592ade901d1fb838 | b2de99b33959b6e49dadaaae5f627ead2a20f34f | [
"Is this an OSGI package ?\n",
"Also a general principle when mocking is _to not mock types you don't own_, there's several reasons for that see that [wiki page](https://github.com/mockito/mockito/wiki/How-to-write-good-tests).\n\nHowever the issue is probably true. But I cannot reproduce locally, do you have add... | [] | 2015-06-18T13:31:46Z | [
"bug"
] | mockito 2.0.14 fails to mock jetty httpclient | this fails:
<pre>
import org.eclipse.jetty.client.HttpClient;
HttpClient httpClient = mock(HttpClient.class);
</pre>
(jetty 9.2.10.v20150310)
with mockito 2.0.2-beta i can mock that class without a problem.
stacktrace:
<pre>
java.lang.IllegalAccessError: tried to access class org.eclipse.jetty.util.compo... | [
"build.gradle",
"gradle/javadoc.gradle",
"mockmaker/bytebuddy/main/java/org/mockito/internal/creation/bytebuddy/MockBytecodeGenerator.java"
] | [
"build.gradle",
"gradle/javadoc.gradle",
"mockmaker/bytebuddy/main/java/org/mockito/internal/creation/bytebuddy/MockBytecodeGenerator.java"
] | [
"test/org/mockitousage/bugs/creation/PublicMethodInParentWithNonPublicTypeInSignatureTest.java",
"test/org/mockitousage/bugs/creation/api/PublicClass.java",
"test/org/mockitousage/bugs/creation/otherpackage/PublicParentClass.java"
] | diff --git a/build.gradle b/build.gradle
index 8f7c9ac72f..939764ee4f 100644
--- a/build.gradle
+++ b/build.gradle
@@ -60,7 +60,7 @@ tasks.withType(JavaCompile) {
//TODO we should remove all dependencies to checked-in jars
dependencies {
- compile 'net.bytebuddy:byte-buddy:0.6.8'
+ compile 'net.bytebuddy:byte... | diff --git a/test/org/mockitousage/bugs/creation/PublicMethodInParentWithNonPublicTypeInSignatureTest.java b/test/org/mockitousage/bugs/creation/PublicMethodInParentWithNonPublicTypeInSignatureTest.java
new file mode 100644
index 0000000000..9d4e340bf3
--- /dev/null
+++ b/test/org/mockitousage/bugs/creation/PublicMetho... | val | train | 2015-06-15T05:19:47 | 2015-06-18T06:24:45Z | christophsturm | train |
mockito/mockito/220_235 | mockito/mockito | mockito/mockito/220 | mockito/mockito/235 | [
"keyword_pr_to_issue"
] | ad0b7e88056eb662ead86885667be6055708e67d | e696f60bcfc5bbcffb59f68f4981f1ef9e8574e3 | [
"Can you try with 2.0.11-beta ?\n",
"Same problem with 2.0.11-beta (in fact, I started with that version, and then decremented one by one till the problem was gone).\n",
"If I had to make a (somewhat) educated guess I would say it is most likely related to 3b445aa057ada4e64b096634b011eab399f03f56\n",
"It's no... | [] | 2015-06-19T23:51:30Z | [
"bug"
] | 2.0.8-beta -> 2.0.9-beta 'Unable to initialize @Spy annotated field | No test failures when using 2.0.8-beta, but when incrementing to 2.0.9-beta, the following error occurs:
```
org.mockito.exceptions.base.MockitoException: Unable to initialize @Spy annotated field 'monitorTaskScheduler'.
Unable to create mock instance of type 'MonitorTaskScheduler'
at net.project.dash.monitor.Moni... | [
"gradle/javadoc.gradle",
"mockmaker/bytebuddy/main/java/org/mockito/internal/creation/bytebuddy/ByteBuddyMockMaker.java",
"mockmaker/bytebuddy/main/java/org/mockito/internal/creation/bytebuddy/MockBytecodeGenerator.java",
"mockmaker/bytebuddy/main/java/org/mockito/internal/creation/bytebuddy/MockMethodInterce... | [
"gradle/javadoc.gradle",
"mockmaker/bytebuddy/main/java/org/mockito/internal/creation/bytebuddy/ByteBuddyMockMaker.java",
"mockmaker/bytebuddy/main/java/org/mockito/internal/creation/bytebuddy/MockBytecodeGenerator.java",
"mockmaker/bytebuddy/main/java/org/mockito/internal/creation/bytebuddy/MockMethodInterce... | [
"test/org/mockitousage/bugs/ConstructorInvokingMethodShouldNotRaiseExceptionTest.java"
] | diff --git a/gradle/javadoc.gradle b/gradle/javadoc.gradle
index c221c6277b..716fb6a102 100644
--- a/gradle/javadoc.gradle
+++ b/gradle/javadoc.gradle
@@ -35,8 +35,8 @@ task mockitoJavadoc(type: Javadoc) {
<script type="text/javascript">
var usingOldIE = \$.browser.msie && parseInt(\$.browser.versio... | diff --git a/test/org/mockitousage/bugs/ConstructorInvokingMethodShouldNotRaiseExceptionTest.java b/test/org/mockitousage/bugs/ConstructorInvokingMethodShouldNotRaiseExceptionTest.java
new file mode 100644
index 0000000000..af85e88f15
--- /dev/null
+++ b/test/org/mockitousage/bugs/ConstructorInvokingMethodShouldNotRais... | train | train | 2015-06-18T18:49:16 | 2015-06-04T07:29:05Z | brcolow | train |
mockito/mockito/244_247 | mockito/mockito | mockito/mockito/244 | mockito/mockito/247 | [
"timestamp(timedelta=18.0, similarity=0.9288212853466791)"
] | dba9d50911870431ba891be8b9438ec326811482 | 4486887c02c436f12223e198818faa2544a16f9b | [
"Well spotted. We'll fix it. Any chance for PR?\n",
"Sorry I should really have sent a PR with the bug report.\n\nI'm recently pretty swamped. Spent a day and an evening trying to upgrade Mockito (thought it was a low-hanging fruit) but then had to draw the line because fixing all the breakage in Google's codebas... | [] | 2015-07-07T22:20:02Z | [
"bug"
] | StackOverflowError in MockitoSerializationIssue.java | In MockitoSerializationIssue.filterStackTrace(), it calls `filter.filter(this)`, which then calls getStackTrace() again, causing an infinite recursion.
| [
"src/org/mockito/exceptions/base/MockitoSerializationIssue.java"
] | [
"src/org/mockito/exceptions/base/MockitoSerializationIssue.java"
] | [
"test/org/mockito/exceptions/base/MockitoSerializationIssueTest.java"
] | diff --git a/src/org/mockito/exceptions/base/MockitoSerializationIssue.java b/src/org/mockito/exceptions/base/MockitoSerializationIssue.java
index 67a7387016..458b56dcc6 100644
--- a/src/org/mockito/exceptions/base/MockitoSerializationIssue.java
+++ b/src/org/mockito/exceptions/base/MockitoSerializationIssue.java
@@ -3... | diff --git a/test/org/mockito/exceptions/base/MockitoSerializationIssueTest.java b/test/org/mockito/exceptions/base/MockitoSerializationIssueTest.java
new file mode 100644
index 0000000000..8e81b00939
--- /dev/null
+++ b/test/org/mockito/exceptions/base/MockitoSerializationIssueTest.java
@@ -0,0 +1,41 @@
+/*
+ * Copyri... | test | train | 2015-06-30T07:20:28 | 2015-06-26T19:20:58Z | fluentfuture | train |
mockito/mockito/251_252 | mockito/mockito | mockito/mockito/251 | mockito/mockito/252 | [
"timestamp(timedelta=0.0, similarity=0.9095102005639756)"
] | 037b0dbc2097f0d5aee0200d22bd46a79f8a34d3 | 5f4dbe782093df70566ff0ee1bacc3baf5aa1158 | [] | [] | 2015-07-08T15:20:46Z | [
"refactoring"
] | Unit tests improvements: migrate from legacy FEST Assert code to AssertJ | Triggered by #250.
| [
"build.gradle"
] | [
"build.gradle"
] | [
"subprojects/testng/src/test/java/org/mockitousage/testng/AnnotatedFieldsShouldBeInitializedByMockitoTestNGListenerTest.java",
"subprojects/testng/src/test/java/org/mockitousage/testng/CaptorAnnotatedFieldShouldBeClearedTest.java",
"subprojects/testng/src/test/java/org/mockitousage/testng/ConfigurationMethodTes... | diff --git a/build.gradle b/build.gradle
index 635663b403..6bbc7b7efd 100644
--- a/build.gradle
+++ b/build.gradle
@@ -63,8 +63,7 @@ dependencies {
testCompile 'org.ow2.asm:asm:5.0.4'
- testCompile "org.easytesting:fest-assert:1.3"
- testCompile "org.easytesting:fest-util:1.1.4"
+ testCompile 'org.ass... | diff --git a/subprojects/testng/src/test/java/org/mockitousage/testng/AnnotatedFieldsShouldBeInitializedByMockitoTestNGListenerTest.java b/subprojects/testng/src/test/java/org/mockitousage/testng/AnnotatedFieldsShouldBeInitializedByMockitoTestNGListenerTest.java
index 06ad4c6ed9..640142a15a 100644
--- a/subprojects/tes... | test | train | 2015-07-08T16:31:14 | 2015-07-08T15:20:18Z | szpak | train |
mockito/mockito/260_261 | mockito/mockito | mockito/mockito/260 | mockito/mockito/261 | [
"timestamp(timedelta=2.0, similarity=0.9121201880561255)"
] | 817b04b82ee802f0cf9009952521d1d7496c69d7 | 298330658c63b36a154470f742e829bdf713c921 | [] | [] | 2015-07-11T14:36:16Z | [] | Typo in documentation | Very minor thing, there's an extra "at" (@) in the documentation.
If you go to http://site.mockito.org/mockito/docs/current/org/mockito/Mockito.html#33
| [
"src/main/java/org/mockito/Mockito.java"
] | [
"src/main/java/org/mockito/Mockito.java"
] | [] | diff --git a/src/main/java/org/mockito/Mockito.java b/src/main/java/org/mockito/Mockito.java
index 1e833596a2..72e4b28c08 100644
--- a/src/main/java/org/mockito/Mockito.java
+++ b/src/main/java/org/mockito/Mockito.java
@@ -1051,7 +1051,7 @@
* such as <code>@{@link Mock}</code>, <code>@{@link Spy}</code>, <c... | null | train | train | 2015-07-10T21:03:51 | 2015-07-11T14:34:41Z | carlos-aguayo | train |
mockito/mockito/243_280 | mockito/mockito | mockito/mockito/243 | mockito/mockito/280 | [
"keyword_pr_to_issue",
"timestamp(timedelta=0.0, similarity=0.9144901177873329)"
] | 2f88f06d6b0e851ff8ed2125085d3faac3f4ee1b | 27e074066ecec55ed086f7430246ef1c8818819f | [
"thanks for reporting this one !\n",
"ByteBuddyMockMaker.getHandler(Object mock) method checks for null using instanceof operator\n`if (!(mock instanceof MockAccess)) {\n return null;\n}`\n\nI presume it is not a bug. \n",
"> I presume it is not a bug.\n\nNope\n",
"How about we document the change in the b... | [] | 2015-08-06T11:39:38Z | [
"bug"
] | MockUtil.isMock() no longer checks null | In version 1.9.5, MockUtil.isMock() is defined as:
```
return instance != null && isMockitoMock(instance);
```
In v1.10.19 and HEAD, the `instance != null` check is gone.
This method is called by MockScanner when injecting mock instances on fields, where field values can be null.
Is this a bug? Or it's up to MockMa... | [
"src/main/java/org/mockito/internal/util/MockUtil.java"
] | [
"src/main/java/org/mockito/internal/util/MockUtil.java"
] | [] | diff --git a/src/main/java/org/mockito/internal/util/MockUtil.java b/src/main/java/org/mockito/internal/util/MockUtil.java
index 96b47a73bf..3ea20cded9 100644
--- a/src/main/java/org/mockito/internal/util/MockUtil.java
+++ b/src/main/java/org/mockito/internal/util/MockUtil.java
@@ -70,7 +70,7 @@ public boolean isSpy(Ob... | null | test | train | 2015-07-28T13:00:51 | 2015-06-26T18:57:40Z | fluentfuture | train |
mockito/mockito/183_286 | mockito/mockito | mockito/mockito/183 | mockito/mockito/286 | [
"keyword_pr_to_issue",
"timestamp(timedelta=0.0, similarity=0.8811629453447426)"
] | 971be4d8184ec916a5ebc2395050804da22b5b33 | 318d92fe4effc1ff23c62b4909538307239b7e7c | [
"Hi, in your use case could you be interested to stubbing only i.e. not interested by verifications ?\n\nIn this case there's this setting may prove useful : `withSettings().stubOnly()`\n",
"No, that would not solve my problem.\n\nMy current issue is that I have a large number of permutations (x \\* y) of input d... | [
"I like the notion of _clearing_, I propose the pull this word up to the `Mockito` class facade. instead of using 3 different words (reset, clear, remove).\n"
] | 2015-08-22T22:19:30Z | [
"enhancement"
] | Feature request: Method to reset mock interactions/invocations without resetting stubs | I'm still missing the ability to reset the invocations on a mock, while keeping all the stubbing, so this is a GitHub equivalent of https://code.google.com/p/mockito/issues/detail?id=316
Some background discussion exists in a [thread](https://groups.google.com/forum/#!topic/mockito/5G-XnpIhP3s) that also refers to [is... | [
"src/main/java/org/mockito/Mockito.java",
"src/main/java/org/mockito/internal/MockitoCore.java",
"src/main/java/org/mockito/internal/stubbing/InvocationContainer.java",
"src/main/java/org/mockito/internal/stubbing/InvocationContainerImpl.java",
"src/main/java/org/mockito/internal/verification/DefaultRegiste... | [
"src/main/java/org/mockito/Mockito.java",
"src/main/java/org/mockito/internal/MockitoCore.java",
"src/main/java/org/mockito/internal/stubbing/InvocationContainer.java",
"src/main/java/org/mockito/internal/stubbing/InvocationContainerImpl.java",
"src/main/java/org/mockito/internal/verification/DefaultRegiste... | [
"src/test/java/org/mockitousage/basicapi/ResetInvocationsTest.java"
] | diff --git a/src/main/java/org/mockito/Mockito.java b/src/main/java/org/mockito/Mockito.java
index 25db83abee..302bd6cce6 100644
--- a/src/main/java/org/mockito/Mockito.java
+++ b/src/main/java/org/mockito/Mockito.java
@@ -1703,6 +1703,21 @@ public static <T> void reset(T ... mocks) {
MOCKITO_CORE.reset(mocks)... | diff --git a/src/test/java/org/mockitousage/basicapi/ResetInvocationsTest.java b/src/test/java/org/mockitousage/basicapi/ResetInvocationsTest.java
new file mode 100644
index 0000000000..3f18478086
--- /dev/null
+++ b/src/test/java/org/mockitousage/basicapi/ResetInvocationsTest.java
@@ -0,0 +1,48 @@
+package org.mockito... | test | train | 2015-12-08T12:52:28 | 2015-03-19T19:16:34Z | mjiderhamn | train |
mockito/mockito/124_287 | mockito/mockito | mockito/mockito/124 | mockito/mockito/287 | [
"keyword_pr_to_issue"
] | 495406554354a23980ac40fb991c1dae8f4105aa | 08b0daeea01e17a63b0c817ff3139ab918aec710 | [
"As a possible example of the way to handle it, maybe it could be modeled after the same way that AssertJ added deferred composite assertion handling through [their own JUnit @Rule](http://joel-costigliola.github.io/assertj/assertj-core-features-highlight.html#soft-assertions):\n"
] | [
"I think this rule should be instantiated this way (Also the method should only expose an interface for example `VerificationCollector`) :\n\n``` java\n@Rule VerificationCollector collector = MockitoJUnit.collector();\n```\n",
"Since it is JUnit specific, this whole PR should live within the package `org.mockito.... | 2015-08-23T14:42:07Z | [] | Concise way to collect multiple verify failures, ideally with JUnitCollector or derivative | If you are using more than one verify statement as test post-conditions, it would be nice to be able to collect each failure and continue with the remaining verify statements or asserts that follow. JUnit provides the ErrorCollector @Rule to facilitate this kid of thing, but the current [ErrorCollector API](http://jun... | [
"src/main/java/org/mockito/junit/MockitoJUnit.java"
] | [
"src/main/java/org/mockito/junit/MockitoJUnit.java",
"src/main/java/org/mockito/junit/VerificationCollector.java",
"src/main/java/org/mockito/junit/VerificationCollectorImpl.java"
] | [
"src/test/java/org/mockitousage/junitrule/VerificationCollectorImplTest.java"
] | diff --git a/src/main/java/org/mockito/junit/MockitoJUnit.java b/src/main/java/org/mockito/junit/MockitoJUnit.java
index f13b667796..b680079e80 100644
--- a/src/main/java/org/mockito/junit/MockitoJUnit.java
+++ b/src/main/java/org/mockito/junit/MockitoJUnit.java
@@ -16,4 +16,14 @@ public class MockitoJUnit {
publi... | diff --git a/src/test/java/org/mockitousage/junitrule/VerificationCollectorImplTest.java b/src/test/java/org/mockitousage/junitrule/VerificationCollectorImplTest.java
new file mode 100644
index 0000000000..4749304fee
--- /dev/null
+++ b/src/test/java/org/mockitousage/junitrule/VerificationCollectorImplTest.java
@@ -0,0... | train | train | 2015-11-26T18:56:50 | 2014-11-25T17:28:12Z | welkman | train |
mockito/mockito/273_294 | mockito/mockito | mockito/mockito/273 | mockito/mockito/294 | [
"keyword_issue_to_pr",
"timestamp(timedelta=67.0, similarity=0.8910939217609104)"
] | a821f7b0ec47f3214bf6f0361df5deb211fa2214 | 39e732869eef5d6b54af4a6890b895fba430171d | [
"Fixed by #294\n"
] | [] | 2015-09-21T18:29:41Z | [
"1.* incompatible"
] | Get rid of ReturnValues | `org.mockito.ReturnValues` has been deprecated for years, it should be removed in mockito 2.0
| [
"src/main/java/org/mockito/Mockito.java",
"src/main/java/org/mockito/ReturnValues.java",
"src/main/java/org/mockito/configuration/DefaultMockitoConfiguration.java",
"src/main/java/org/mockito/configuration/IMockitoConfiguration.java",
"src/main/java/org/mockito/internal/configuration/GlobalConfiguration.jav... | [
"src/main/java/org/mockito/Mockito.java",
"src/main/java/org/mockito/configuration/DefaultMockitoConfiguration.java",
"src/main/java/org/mockito/configuration/IMockitoConfiguration.java",
"src/main/java/org/mockito/internal/configuration/GlobalConfiguration.java",
"src/main/java/org/mockito/internal/stubbin... | [] | diff --git a/src/main/java/org/mockito/Mockito.java b/src/main/java/org/mockito/Mockito.java
index 04f4a9e69e..e2eca63a6d 100644
--- a/src/main/java/org/mockito/Mockito.java
+++ b/src/main/java/org/mockito/Mockito.java
@@ -1327,41 +1327,6 @@ public static MockingDetails mockingDetails(Object toInspect) {
retur... | null | train | train | 2015-08-11T14:53:30 | 2015-07-27T14:20:16Z | bric3 | train |
mockito/mockito/311_314 | mockito/mockito | mockito/mockito/311 | mockito/mockito/314 | [
"timestamp(timedelta=0.0, similarity=0.8877391757752712)",
"keyword_pr_to_issue"
] | e8640baba7eeaf4d333696492b6868feb115094f | 7bd8cb501439886a31d787cc708d0c77101a3fde | [] | [] | 2015-10-31T16:46:56Z | [
"BDD"
] | Add BDD version of verifyNoMoreInteractions() | Current state:
``` java
then(file).should().moveTo(directory);
verifyNoMoreInteractions(file);
```
Would be great to have BDD replacement for `verifyNoMoreInteractions()`. Then the test would be even nicer:
``` java
then(file).should().moveTo(directory);
then(file).shouldHaveNoMoreInteractions();
```
If you agree, ... | [
"src/main/java/org/mockito/BDDMockito.java"
] | [
"src/main/java/org/mockito/BDDMockito.java"
] | [
"src/test/java/org/mockitousage/customization/BDDMockitoTest.java"
] | diff --git a/src/main/java/org/mockito/BDDMockito.java b/src/main/java/org/mockito/BDDMockito.java
index 560cdf8bd7..7bb8f4679f 100644
--- a/src/main/java/org/mockito/BDDMockito.java
+++ b/src/main/java/org/mockito/BDDMockito.java
@@ -57,6 +57,7 @@
* person.ride(bike);
*
* then(person).should(times(2)).ride(b... | diff --git a/src/test/java/org/mockitousage/customization/BDDMockitoTest.java b/src/test/java/org/mockitousage/customization/BDDMockitoTest.java
index c207361c9d..b74487ef04 100644
--- a/src/test/java/org/mockitousage/customization/BDDMockitoTest.java
+++ b/src/test/java/org/mockitousage/customization/BDDMockitoTest.ja... | train | train | 2015-10-21T22:46:49 | 2015-10-29T22:05:44Z | mkordas | train |
mockito/mockito/316_317 | mockito/mockito | mockito/mockito/316 | mockito/mockito/317 | [
"timestamp(timedelta=0.0, similarity=0.9396315082112713)",
"keyword_pr_to_issue"
] | 971be4d8184ec916a5ebc2395050804da22b5b33 | 8017ee1ff766b96725a64d0a2fff79e26300a19b | [] | [] | 2015-11-10T12:21:38Z | [
"enhancement"
] | modify StackTraceFilter to not strip away "good" elements from the middle | according to javadoc of org.mockito.internal.exceptions.stacktrace.StackTraceFilter, filter works like this:
[a+, b+, c-, d+, e+, f-, g+] -> [a+, b+, g+]
it would be better to not strip away "good" d and e elements:
[a+, b+, c-, d+, e+, f-, g+] -> [a+, b+, d+, e+, g+]
What do you think about this? For me current behavi... | [
"src/main/java/org/mockito/internal/exceptions/stacktrace/StackTraceFilter.java"
] | [
"src/main/java/org/mockito/internal/exceptions/stacktrace/StackTraceFilter.java"
] | [
"src/test/java/org/mockito/internal/exceptions/stacktrace/StackTraceFilterTest.java"
] | diff --git a/src/main/java/org/mockito/internal/exceptions/stacktrace/StackTraceFilter.java b/src/main/java/org/mockito/internal/exceptions/stacktrace/StackTraceFilter.java
index cd462dcee1..2b5bb658cc 100644
--- a/src/main/java/org/mockito/internal/exceptions/stacktrace/StackTraceFilter.java
+++ b/src/main/java/org/mo... | diff --git a/src/test/java/org/mockito/internal/exceptions/stacktrace/StackTraceFilterTest.java b/src/test/java/org/mockito/internal/exceptions/stacktrace/StackTraceFilterTest.java
index 3d4185e7c9..0b1e588d86 100644
--- a/src/test/java/org/mockito/internal/exceptions/stacktrace/StackTraceFilterTest.java
+++ b/src/test... | train | train | 2015-12-08T12:52:28 | 2015-11-06T05:47:44Z | astafev | train |
mockito/mockito/256_342 | mockito/mockito | mockito/mockito/256 | mockito/mockito/342 | [
"keyword_pr_to_issue"
] | 7b62390fec00c46fa8924354c27686a1a44fe2ab | b3648078d7adeb4277bbaf75a87b2a272335d5bf | [
"I think most of us work on Linux/OSX, it probably has to do with the JDK\nversion and windows line endings.\n\nSo minifying this javascript code may work ?\n\n-- Brice\n\nOn Fri, Jul 10, 2015 at 8:19 AM, Meang Akira Tanaka <\nnotifications@github.com> wrote:\n\n> When compiling the mockito project using gradle in ... | [
"Good idea !\n"
] | 2016-01-20T00:39:52Z | [] | task mockitoJavadoc fails when compiling in windows | When compiling the mockito project using gradle in a command line in Windows following compile error occurs:
javadoc: error - Illegal package name: "<script"
javadoc: error - Illegal package name: "type="
javadoc: error - Illegal package name: "text/javascript"
javadoc: error - Illegal package name: "src="
javadoc: er... | [
"gradle/javadoc.gradle"
] | [
"gradle/javadoc.gradle"
] | [] | diff --git a/gradle/javadoc.gradle b/gradle/javadoc.gradle
index 55052e9f3e..4d5daa5d43 100644
--- a/gradle/javadoc.gradle
+++ b/gradle/javadoc.gradle
@@ -40,8 +40,8 @@ task mockitoJavadoc(type: Javadoc) {
<script type="text/javascript">
var usingOldIE = \$.browser.msie && parseInt(\$.browser.versio... | null | test | train | 2016-01-18T21:57:55 | 2015-07-10T06:19:17Z | mat013 | train |
mockito/mockito/345_349 | mockito/mockito | mockito/mockito/345 | mockito/mockito/349 | [
"keyword_pr_to_issue"
] | c18bf2a94e2e8d95a78cbd5fe18252d39acee8c4 | 455eb2f4737b4f15bd4472cce675d24398975439 | [
"Issue #345 resolves this for atMost verification. What about other verification modes (i.e. times, atLeast)? Are you working on that, @tarnowskijan? Was the issue only for the atMost case? Because in the code from the description you used times instead of atMost.\n",
"@thesnowgoose, unfortunately you're right, t... | [] | 2016-02-04T14:45:47Z | [
"ready"
] | Verification using After and ArgumentCaptor returns unexpected size of captured values list | Hi, I found weird behavior of Mockito (ver. 1.10.19) when verifying method invocation with after() and ArgumentCaptor. The list of captured values returned by ArgumentCaptor has size much bigger than I expect. Moreover this behavior in connection with long timeout leads to exceeding memory limit. Example below. Is it e... | [
"src/main/java/org/mockito/internal/verification/AtMost.java"
] | [
"src/main/java/org/mockito/internal/verification/AtMost.java"
] | [
"src/test/java/org/mockitousage/verification/VerificationAfterDelayTest.java"
] | diff --git a/src/main/java/org/mockito/internal/verification/AtMost.java b/src/main/java/org/mockito/internal/verification/AtMost.java
index 54a5285c47..25a7fc59d1 100644
--- a/src/main/java/org/mockito/internal/verification/AtMost.java
+++ b/src/main/java/org/mockito/internal/verification/AtMost.java
@@ -5,6 +5,7 @@
... | diff --git a/src/test/java/org/mockitousage/verification/VerificationAfterDelayTest.java b/src/test/java/org/mockitousage/verification/VerificationAfterDelayTest.java
index d20c39d8ba..e0d4f76c71 100644
--- a/src/test/java/org/mockitousage/verification/VerificationAfterDelayTest.java
+++ b/src/test/java/org/mockitousag... | test | train | 2016-01-26T23:52:50 | 2016-01-26T22:23:46Z | tarnowskijan | train |
mockito/mockito/365_373 | mockito/mockito | mockito/mockito/365 | mockito/mockito/373 | [
"keyword_pr_to_issue"
] | 196ff979da156caa07e19f57e4849637d8bede1a | f2ec9da14192fa98f534dd8e01d4921fcc5c8c14 | [
"I would like to mention that sometimes class argument can be useful.\r\n\r\nIn my case I would like to catch object passed to mock and write to mongo database.\r\nThe code I would like to have is:\r\n\r\n```\r\n// test setup\r\ndoAnswer(invocation -> mongoTemplate.insert(invocation.getArgument(0, Person.class)))\r... | [] | 2016-03-11T20:56:56Z | [
"1.* incompatible"
] | Simplify the InvocationOnMock-API to get a casted argument | The 2nd argument of `InvocationOnMock.getArgumentAt(int,Class<T>)` can be removed cause it is not neccessary.
Intuitively on would write this to get a "auto casted" argument:
`String text = invocation.getArgumentAt(1,String.class)`
The type can be ommited without side effects (the implementation of InvocationOnMock ... | [
"src/main/java/org/mockito/internal/creation/bytebuddy/InterceptedInvocation.java",
"src/main/java/org/mockito/internal/invocation/InvocationImpl.java",
"src/main/java/org/mockito/internal/invocation/InvocationMatcher.java",
"src/main/java/org/mockito/internal/stubbing/answers/ReturnsArgumentAt.java",
"src/... | [
"src/main/java/org/mockito/internal/creation/bytebuddy/InterceptedInvocation.java",
"src/main/java/org/mockito/internal/invocation/InvocationImpl.java",
"src/main/java/org/mockito/internal/invocation/InvocationMatcher.java",
"src/main/java/org/mockito/internal/stubbing/answers/ReturnsArgumentAt.java",
"src/... | [
"src/test/java/org/mockito/internal/AllInvocationsFinderTest.java",
"src/test/java/org/mockito/internal/invocation/InvocationImplTest.java",
"src/test/java/org/mockitousage/PlaygroundWithDemoOfUnclonedParametersProblemTest.java",
"src/test/java/org/mockitousage/customization/BDDMockitoTest.java",
"src/test/... | diff --git a/src/main/java/org/mockito/internal/creation/bytebuddy/InterceptedInvocation.java b/src/main/java/org/mockito/internal/creation/bytebuddy/InterceptedInvocation.java
index b0687142e3..8445e4b70b 100644
--- a/src/main/java/org/mockito/internal/creation/bytebuddy/InterceptedInvocation.java
+++ b/src/main/java/... | diff --git a/src/test/java/org/mockito/internal/AllInvocationsFinderTest.java b/src/test/java/org/mockito/internal/AllInvocationsFinderTest.java
index c5230db380..8eea369948 100644
--- a/src/test/java/org/mockito/internal/AllInvocationsFinderTest.java
+++ b/src/test/java/org/mockito/internal/AllInvocationsFinderTest.ja... | val | train | 2016-03-09T16:56:37 | 2016-03-01T12:19:49Z | ChristianSchwarz | train |
mockito/mockito/379_380 | mockito/mockito | mockito/mockito/379 | mockito/mockito/380 | [
"keyword_issue_to_pr",
"keyword_pr_to_issue"
] | 196ff979da156caa07e19f57e4849637d8bede1a | 31c7876f0693a1335c8e41b340e8580aa9a510ae | [
"@thesnowgoose \nThat a bug in VerificationOverTimeImpl#verify(VerificationData). The passed `VerificationData` contains all invocations, in your case \"0\",\"1\" and \"2\". During the specified 200ms these invocations are verified in a loop without delay. That means if your CPU is able to verify the VerificationDa... | [
"Since this method is duplicate from the method added in the class below, maybe we can extract an superclass `InvocationsChecker`. This class abstracts away all the logic regarding obtaining and reporting the failures, the constructor as well as this new method.\n"
] | 2016-03-25T01:04:42Z | [
"enhancement"
] | Verification using After and ArgumentCaptor with Times or AtLeast methods returns unexpected size of captured values list. | Hi!
I was looking issue #345 and found that the test "shouldReturnListOfArgumentsWithSameSizeAsGivenInAtMostVerification" (located in VerificationAfterDelayTest.java) fails if you use atLeast() or times() instead of atMost().
I created these tests:
![screenshot from 2016-03-24 16 50 29](https://cloud.githubusercontent... | [
"src/main/java/org/mockito/internal/verification/Times.java",
"src/main/java/org/mockito/internal/verification/checkers/AtLeastXNumberOfInvocationsChecker.java",
"src/main/java/org/mockito/internal/verification/checkers/NumberOfInvocationsChecker.java"
] | [
"src/main/java/org/mockito/internal/verification/Times.java",
"src/main/java/org/mockito/internal/verification/checkers/AtLeastXNumberOfInvocationsChecker.java",
"src/main/java/org/mockito/internal/verification/checkers/NumberOfInvocationsChecker.java"
] | [
"src/test/java/org/mockitousage/verification/VerificationAfterDelayTest.java"
] | diff --git a/src/main/java/org/mockito/internal/verification/Times.java b/src/main/java/org/mockito/internal/verification/Times.java
index 62a7ed753f..f43ce4286c 100644
--- a/src/main/java/org/mockito/internal/verification/Times.java
+++ b/src/main/java/org/mockito/internal/verification/Times.java
@@ -31,12 +31,16 @@ p... | diff --git a/src/test/java/org/mockitousage/verification/VerificationAfterDelayTest.java b/src/test/java/org/mockitousage/verification/VerificationAfterDelayTest.java
index e0d4f76c71..2462f28e45 100644
--- a/src/test/java/org/mockitousage/verification/VerificationAfterDelayTest.java
+++ b/src/test/java/org/mockitousag... | train | train | 2016-03-09T16:56:37 | 2016-03-24T23:42:00Z | thesnowgoose | train |
mockito/mockito/374_386 | mockito/mockito | mockito/mockito/374 | mockito/mockito/386 | [
"keyword_pr_to_issue"
] | 196ff979da156caa07e19f57e4849637d8bede1a | 66a7205945d201e01aa6043d5cfe1aa0ae08e622 | [] | [] | 2016-04-09T19:47:00Z | [] | Remove deprecated API from Mockito 2 | # This is a reminder to remove all deprecated API's from the upcoming mockito 2.
This issue blocks #123 [Release Mockito 2.0](123)
Relates to
- #273 [Get rid of ReturnValues](273)
| [
"src/main/java/org/mockito/Answers.java",
"src/main/java/org/mockito/ArgumentCaptor.java",
"src/main/java/org/mockito/exceptions/Discrepancy.java",
"src/main/java/org/mockito/exceptions/Pluralizer.java",
"src/main/java/org/mockito/exceptions/PrintableInvocation.java",
"src/main/java/org/mockito/exceptions... | [
"src/main/java/org/mockito/Answers.java",
"src/main/java/org/mockito/ArgumentCaptor.java",
"src/main/java/org/mockito/invocation/DescribedInvocation.java",
"src/main/java/org/mockito/listeners/MethodInvocationReport.java"
] | [
"src/test/java/org/mockito/runners/RunnersValidateFrameworkUsageTest.java",
"src/test/java/org/mockitousage/matchers/CapturingArgumentsTest.java",
"src/test/java/org/mockitousage/stacktrace/PointingStackTraceToActualInvocationTest.java",
"src/test/java/org/mockitousage/stubbing/StubbingWithExtraAnswersTest.ja... | diff --git a/src/main/java/org/mockito/Answers.java b/src/main/java/org/mockito/Answers.java
index db3f5723ad..ff89b4b482 100644
--- a/src/main/java/org/mockito/Answers.java
+++ b/src/main/java/org/mockito/Answers.java
@@ -87,15 +87,6 @@ public enum Answers implements Answer<Object>{
this.implementation = impl... | diff --git a/src/test/java/org/mockito/runners/RunnersValidateFrameworkUsageTest.java b/src/test/java/org/mockito/runners/RunnersValidateFrameworkUsageTest.java
index 35f29a78d3..44f1de9a06 100644
--- a/src/test/java/org/mockito/runners/RunnersValidateFrameworkUsageTest.java
+++ b/src/test/java/org/mockito/runners/Runn... | train | train | 2016-03-09T16:56:37 | 2016-03-14T12:38:43Z | ChristianSchwarz | train |
mockito/mockito/407_412 | mockito/mockito | mockito/mockito/407 | mockito/mockito/412 | [
"keyword_pr_to_issue"
] | 8331e6e4bb37e459950dc12ef48ff4f5ed10f953 | 3da645d2d38e6be82bdcd2ee2bb7abf08deb74d9 | [
"This is a bug in [ForwardsInvocations](https://github.com/mockito/mockito/blob/master/src/main/java/org/mockito/internal/stubbing/defaultanswers/ForwardsInvocations.java#L41), as you already investigated the expanded varargs are passed to the delegate.\n\nThe current implementation does this:\n\n```\nresult = dele... | [
"- Looks good, can you split the test cases (empty array/ non empty array) ?\n- Can you also add a test for `invocationOf(Foo.class, \"bar\", \"baz\", new Object[] {null})` and `invocationOf(Foo.class, \"bar\", \"baz\", null)` \n- Would you mind using AssertJ's Assertions.assertThat(..).is(..), it is more readable ... | 2016-05-17T11:18:32Z | [] | Vararg method call on mock object fails when used org.mockito.AdditionalAnswers#delegatesTo | I try to mock interface with varargs method and default implementation in final class and get this error:
```
java.lang.IllegalArgumentException: wrong number of arguments
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.jav... | [
"src/main/java/org/mockito/internal/stubbing/defaultanswers/ForwardsInvocations.java"
] | [
"src/main/java/org/mockito/internal/stubbing/defaultanswers/ForwardsInvocations.java"
] | [
"src/test/java/org/mockito/internal/stubbing/defaultanswers/ForwardsInvocationsTest.java",
"src/test/java/org/mockitousage/stubbing/StubbingWithDelegateVarArgsTest.java"
] | diff --git a/src/main/java/org/mockito/internal/stubbing/defaultanswers/ForwardsInvocations.java b/src/main/java/org/mockito/internal/stubbing/defaultanswers/ForwardsInvocations.java
index 1916a62ce2..95da223adf 100644
--- a/src/main/java/org/mockito/internal/stubbing/defaultanswers/ForwardsInvocations.java
+++ b/src/m... | diff --git a/src/test/java/org/mockito/internal/stubbing/defaultanswers/ForwardsInvocationsTest.java b/src/test/java/org/mockito/internal/stubbing/defaultanswers/ForwardsInvocationsTest.java
new file mode 100644
index 0000000000..42234edc08
--- /dev/null
+++ b/src/test/java/org/mockito/internal/stubbing/defaultanswers/... | train | train | 2016-05-17T22:34:52 | 2016-05-03T07:27:24Z | iam-afk | train |
mockito/mockito/422_423 | mockito/mockito | mockito/mockito/422 | mockito/mockito/423 | [
"timestamp(timedelta=33028.0, similarity=0.8599980107043)"
] | 74e312b7a9236a43eb543bd3184607b75375bc40 | d528d12806a460dd1a646e49afc09dab3cc1c8fe | [
"Hi! Why would you even want to do that? It sounds like a absolutely terrible idea to do that. Can you provide some use case?\n",
"Thank you for the fast reply!\nI need to test that a class behaves in different ways if the log level is debug or not and so I need to mock the logger. If debug is enabled my class wi... | [] | 2016-05-31T18:51:04Z | [
"on hold"
] | Whitebox.setInternalState for private static final fields | Hello,
Can you please add the ability for [Whitebox.setInternalState](https://github.com/mockito/mockito/blob/74e312b7a9236a43eb543bd3184607b75375bc40/src/main/java/org/mockito/internal/util/reflection/Whitebox.java#L22-L31) to be invokable on classes with private static final field?
``` java
Whitebox.setInternalStat... | [
"src/main/java/org/mockito/internal/util/reflection/Whitebox.java"
] | [
"src/main/java/org/mockito/internal/util/reflection/Whitebox.java"
] | [
"src/test/java/org/mockito/internal/util/reflection/DummyParentClassForTests.java",
"src/test/java/org/mockito/internal/util/reflection/WhiteboxTest.java"
] | diff --git a/src/main/java/org/mockito/internal/util/reflection/Whitebox.java b/src/main/java/org/mockito/internal/util/reflection/Whitebox.java
index c63f59b87a..14ea30be98 100644
--- a/src/main/java/org/mockito/internal/util/reflection/Whitebox.java
+++ b/src/main/java/org/mockito/internal/util/reflection/Whitebox.ja... | diff --git a/src/test/java/org/mockito/internal/util/reflection/DummyParentClassForTests.java b/src/test/java/org/mockito/internal/util/reflection/DummyParentClassForTests.java
index 6967c02c8a..2b5da62228 100644
--- a/src/test/java/org/mockito/internal/util/reflection/DummyParentClassForTests.java
+++ b/src/test/java/... | test | train | 2016-05-27T20:52:55 | 2016-05-31T10:59:45Z | andreicristianpetcu | train |
mockito/mockito/426_432 | mockito/mockito | mockito/mockito/426 | mockito/mockito/432 | [
"keyword_pr_to_issue"
] | a1de9a5e1d38774f2f3e343e60c56e8f000b71ca | 3c4edc6b49ce4a30dcaf00a78cf014c245f2eefa | [
"@raphw thanks for merging the PR that fast! Would you mind reopening this ticket? There are more classes that can be refactored that way, I would like to extend the list.\n",
"Big :+1: for me btw, but please keep the pull requests managable and as small as possible. Preferably refactoring 1 method at a time. Th... | [
"Formatting again?\n",
"?\n",
"I added a new line in order to trigger a new build. The concurrent test are failing on every 2nd run.\n",
"tab vs. 4x space , fixed...\n"
] | 2016-06-15T13:05:28Z | [] | Refactor instance based utility classes to static utility classes | The internal implementation of Mockito contains numerous helper classed that serve as a container for useful methods. By its nature these classes don't have a state. Currently some them are instance based in other word you need to create the utility class to call a helper method. This not only pollutes the heap but als... | [
"src/main/java/org/mockito/internal/invocation/InvocationMarker.java",
"src/main/java/org/mockito/internal/verification/AtMost.java",
"src/main/java/org/mockito/internal/verification/Only.java",
"src/main/java/org/mockito/internal/verification/checkers/AtLeastXNumberOfInvocationsChecker.java",
"src/main/jav... | [
"src/main/java/org/mockito/internal/invocation/InvocationMarker.java",
"src/main/java/org/mockito/internal/verification/AtMost.java",
"src/main/java/org/mockito/internal/verification/Only.java",
"src/main/java/org/mockito/internal/verification/checkers/AtLeastXNumberOfInvocationsChecker.java",
"src/main/jav... | [
"src/test/java/org/mockito/internal/invocation/InvocationMarkerTest.java",
"src/test/java/org/mockito/internal/verification/checkers/AtLeastXNumberOfInvocationsCheckerTest.java"
] | diff --git a/src/main/java/org/mockito/internal/invocation/InvocationMarker.java b/src/main/java/org/mockito/internal/invocation/InvocationMarker.java
index 882ccf2681..f05a22158b 100644
--- a/src/main/java/org/mockito/internal/invocation/InvocationMarker.java
+++ b/src/main/java/org/mockito/internal/invocation/Invocat... | diff --git a/src/test/java/org/mockito/internal/invocation/InvocationMarkerTest.java b/src/test/java/org/mockito/internal/invocation/InvocationMarkerTest.java
index d85320c485..777e76b517 100644
--- a/src/test/java/org/mockito/internal/invocation/InvocationMarkerTest.java
+++ b/src/test/java/org/mockito/internal/invoca... | train | train | 2016-06-14T00:01:34 | 2016-06-11T13:23:18Z | ChristianSchwarz | train |
mockito/mockito/438_444 | mockito/mockito | mockito/mockito/438 | mockito/mockito/444 | [
"timestamp(timedelta=0.0, similarity=0.9620624077314136)",
"keyword_pr_to_issue"
] | d6480148b28defa299b25230abe7f463f850350a | e75b07853f855e2ae990a87a2cd50b971eed7cff | [
"@smoyer64 I think that is a reasonable addition. Do you maybe have a sample JUnit test case that I can add to our test suite as regression test?\n",
"@TimvdLippe,\n\nWill this change be going into Mockito 1.x or 2.x (or both)?\n",
"@sbrannen Mockito 2.0. We might be able to port back to Mockito 1.x but I would... | [
"Awesome! 👍 \n"
] | 2016-06-19T12:08:08Z | [
"enhancement"
] | Add ElementType.PARAMETER to @Mock | Parameterized tests are becoming more common - JUnit 5 explicitly allows parameters and the sample [MockitoExtension](https://github.com/junit-team/junit5-samples/tree/master/junit5-mockito-extension/src/main/java/com/example/mockito) currently includes an @InjectMock to trigger the creation of a mock parameter. It wo... | [
"src/main/java/org/mockito/Mock.java"
] | [
"src/main/java/org/mockito/Mock.java"
] | [] | diff --git a/src/main/java/org/mockito/Mock.java b/src/main/java/org/mockito/Mock.java
index 91cb0538c8..2988cb2cba 100644
--- a/src/main/java/org/mockito/Mock.java
+++ b/src/main/java/org/mockito/Mock.java
@@ -9,6 +9,7 @@
import java.lang.annotation.Target;
import static java.lang.annotation.ElementType.FIELD;
+im... | null | train | train | 2016-06-19T13:43:27 | 2016-06-18T17:10:29Z | smoyer64 | train |
mockito/mockito/453_454 | mockito/mockito | mockito/mockito/453 | mockito/mockito/454 | [
"keyword_pr_to_issue"
] | ce957844a9adc8403434ccf893b9d68d047573e9 | 9af742d476dbfc746e2cb09698af3524c96b49ec | [
"I can't imagine a scenario where the parameterized type cause problems and why it aids debuging if no type parameter is used.\n\n@all Do we have examples that illustrate the described problem? If not the JavaDoc should be removed!\n",
"#454 is one way we could wrap this up. Sorry for not noticing it sooner!\n",
... | [] | 2016-06-21T08:23:44Z | [] | Either revert recent Functional Interfaces change or change JavaDoc | I've been reading the Javadoc regarding `ArgumentMatcher` and I noticed a couple of things. Relating back to the changes of #338
- The example of how to override it is still based around `Object` rather than `T`
- Someone has very deliberately decided not to make it use `T` in the past and now we've changed that.
> T... | [
"src/main/java/org/mockito/ArgumentMatcher.java"
] | [
"src/main/java/org/mockito/ArgumentMatcher.java"
] | [] | diff --git a/src/main/java/org/mockito/ArgumentMatcher.java b/src/main/java/org/mockito/ArgumentMatcher.java
index 3b2e3d19c4..8b9abd0ce4 100644
--- a/src/main/java/org/mockito/ArgumentMatcher.java
+++ b/src/main/java/org/mockito/ArgumentMatcher.java
@@ -35,6 +35,8 @@
* Useful if you already have a hamcrest match... | null | val | train | 2016-06-20T00:57:18 | 2016-06-20T19:33:24Z | ashleyfrieze | train |
mockito/mockito/226_481 | mockito/mockito | mockito/mockito/226 | mockito/mockito/481 | [
"timestamp(timedelta=0.0, similarity=0.932913327674623)",
"keyword_pr_to_issue"
] | 1eddf98e096c8d55a4f5a0bc08947003e9448c81 | b0393eafeeb81b6c75e40a82b81672543777ca9a | [
"Great idea.\n"
] | [] | 2016-07-06T11:02:06Z | [
"docs",
"continuous integration"
] | Exclude internal package from javadoc | Internal package don't need to be included in the javadoc generation, just like the jdk doesn't have `com.sun` package
In the javadoc that may be done via a doclet since `exclude '**/internal/**'` raise javadoc errors
``` groovy
doclet = "qualified.name.of.DocletExclude"
docletpath = [rootProject.file('./gradle/docle... | [
"buildSrc/build.gradle",
"gradle/javadoc.gradle",
"gradle/wrapper/gradle-wrapper.properties"
] | [
"buildSrc/build.gradle",
"buildSrc/src/main/java/org/mockito/javadoc/JavadocExclude.java",
"gradle/javadoc.gradle",
"gradle/wrapper/gradle-wrapper.properties"
] | [] | diff --git a/buildSrc/build.gradle b/buildSrc/build.gradle
index 28c2cd953a..6720ba5a90 100644
--- a/buildSrc/build.gradle
+++ b/buildSrc/build.gradle
@@ -8,6 +8,7 @@ dependencies {
//TODO SF use jcabi to edit issues after the release so that they have the milestone attached
//compile "com.jcabi:jcabi-github:... | null | val | train | 2016-07-05T17:03:31 | 2015-06-06T21:23:36Z | bric3 | train |
mockito/mockito/123_483 | mockito/mockito | mockito/mockito/123 | mockito/mockito/483 | [
"keyword_issue_to_pr",
"keyword_pr_to_issue"
] | d01911eb9040d21ba6763dfb90c5210bb480e1b9 | 80ab0db765138a57b105c7a64676ebc38cb94f35 | [
"Is it still planned for 2.0 to give users an option to use an alternative to cglib (like Byte Buddy)?\n",
"This kind of feature can be added any time (e.g. it's not a backwards-incompatible change). It's just someone needs to implement it :) \n\nSo short answer is 'no', it's not planned for 2.0 (but I would love... | [] | 2016-07-07T13:52:49Z | [
"epic"
] | Release Mockito 2.0 | Incompatible changes:
- [x] stop producing mockito-all #153
- [x] stop depending on hamcrest internally #154
- [x] use newer hamcrest #232
- [x] make the anyXxx and any(Xxx) matchers intuitive #134, #194
- ~~fix the site links~~
- [x] push cglib mockmaker to a separate jar #248
- [x] stop using ant for producing OSGi b... | [
"README.md",
"buildSrc/src/main/groovy/org/mockito/release/version/VersionBumper.java",
"version.properties"
] | [
"README.md",
"buildSrc/src/main/groovy/org/mockito/release/version/VersionBumper.java",
"version.properties"
] | [
"buildSrc/src/test/groovy/org/mockito/release/version/VersionBumperTest.groovy"
] | diff --git a/README.md b/README.md
index 1ffdd450c9..d3595e27fc 100644
--- a/README.md
+++ b/README.md
@@ -17,24 +17,34 @@ See the [release notes page](https://github.com/mockito/mockito/blob/master/doc/
## Versioning
-Mockito has an automated release system, which imposed some change on how the version numbers wo... | diff --git a/buildSrc/src/test/groovy/org/mockito/release/version/VersionBumperTest.groovy b/buildSrc/src/test/groovy/org/mockito/release/version/VersionBumperTest.groovy
index db1c3d6835..b34bcda696 100644
--- a/buildSrc/src/test/groovy/org/mockito/release/version/VersionBumperTest.groovy
+++ b/buildSrc/src/test/groov... | train | train | 2016-08-22T09:50:54 | 2014-11-22T21:31:43Z | mockitoguy | train |
mockito/mockito/478_483 | mockito/mockito | mockito/mockito/478 | mockito/mockito/483 | [
"keyword_issue_to_pr"
] | d01911eb9040d21ba6763dfb90c5210bb480e1b9 | 80ab0db765138a57b105c7a64676ebc38cb94f35 | [
"I don't think so, I believe we should keep up-to-date javadoc, but maybe pointing to released versions javadocs.\n",
"Or we could tweak the layout :\n- `current` == latest released version => `http://site.mockito.org/mockito/docs/current/org/mockito/Mockito.html`\n- `release/2.0.0` => `http://site.mockito.org/mo... | [] | 2016-07-07T13:52:49Z | [
"docs",
"continuous integration"
] | Improve release generator | Currently releases are generated automatically and documentation pushed to the website. However, when we are publishing a major release, this should be changed.
Probably the best solution is to disable the automatic generation for now and invoke this manually. This does require some changes to the current Gradle relea... | [
"README.md",
"buildSrc/src/main/groovy/org/mockito/release/version/VersionBumper.java",
"version.properties"
] | [
"README.md",
"buildSrc/src/main/groovy/org/mockito/release/version/VersionBumper.java",
"version.properties"
] | [
"buildSrc/src/test/groovy/org/mockito/release/version/VersionBumperTest.groovy"
] | diff --git a/README.md b/README.md
index 1ffdd450c9..d3595e27fc 100644
--- a/README.md
+++ b/README.md
@@ -17,24 +17,34 @@ See the [release notes page](https://github.com/mockito/mockito/blob/master/doc/
## Versioning
-Mockito has an automated release system, which imposed some change on how the version numbers wo... | diff --git a/buildSrc/src/test/groovy/org/mockito/release/version/VersionBumperTest.groovy b/buildSrc/src/test/groovy/org/mockito/release/version/VersionBumperTest.groovy
index db1c3d6835..b34bcda696 100644
--- a/buildSrc/src/test/groovy/org/mockito/release/version/VersionBumperTest.groovy
+++ b/buildSrc/src/test/groov... | val | train | 2016-08-22T09:50:54 | 2016-07-03T20:28:25Z | TimvdLippe | train |
mockito/mockito/465_493 | mockito/mockito | mockito/mockito/465 | mockito/mockito/493 | [
"keyword_pr_to_issue"
] | 5dd0f71ae37f75f3abc9b3d9ba7ad5cb4b79f38a | 272b32bb11a41d757c535675b9bfda0fa6ffd90b | [] | [
"This can be a _oneliner_ I believe \n\n```\nif [[ $(git log --format=%B -n 1) != *\"[ci skip-release]\"* ]] ; then ./gradlew release; fi\n```\n",
"The git log command was from a travis issue as there is an intent to add the new environment variable. The command is kinda magic, so naming the variable makes it imo... | 2016-07-10T21:46:47Z | [] | Delivery drone breaks codecov | Since the commits of the delivery drone have `[ci skip]`, there is no coverage report for that specific commit. As a result, when a pull request has as base such a commit, CodeCov reports that it could not generate a coverage report.
Maybe we can depend executing `gradle release` if the commit is from a user other tha... | [
".travis.yml",
"dummy-commit.txt",
"gradle/release.gradle"
] | [
".travis.yml",
"dummy-commit.txt",
"gradle/release.gradle"
] | [] | diff --git a/.travis.yml b/.travis.yml
index 20b34b70df..e1b7d261d7 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -39,7 +39,9 @@ branches:
install:
- true
script:
- - ./gradlew ciBuild release
+ - TRAVIS_MESSAGE="$(git log --format=%B -n 1)"
+ - ./gradlew ciBuild
+ - if [[ $TRAVIS_MESSAGE != *"[ci skip-release]... | null | train | train | 2016-07-10T22:07:23 | 2016-06-24T11:15:49Z | TimvdLippe | train |
mockito/mockito/482_494 | mockito/mockito | mockito/mockito/482 | mockito/mockito/494 | [
"timestamp(timedelta=54.0, similarity=0.8480688334209667)"
] | 5dd0f71ae37f75f3abc9b3d9ba7ad5cb4b79f38a | 038637612ac8abe962094d87c9cf6252f60a49dc | [
"On a related note adding a \"as of\" to the deprecated description would also be useful:\n\n``` java\n/**\n * @deprecated as of 2.0 in favor of using the enum-constant directly. This method will be removed in a future release<br> \n * E.g. instead of <code>Answers.CALLS_REAL_METHODS.get()</code> use <code>Answers.... | [] | 2016-07-11T13:12:41Z | [
"bug"
] | Restore depecated Answers.get() method | Commit da5e750957b494e7fa0548bf1286d67b8b0386d5 removed the deprecated `Answers.get()` method, however the method was only deprecated in the 2.0 BETA line and never made it into a GA release. It would be helpful if the method could remain in the deprecated form in 2.0 to give people an opportunity to move away from it.... | [
"src/main/java/org/mockito/Answers.java"
] | [
"src/main/java/org/mockito/Answers.java"
] | [] | diff --git a/src/main/java/org/mockito/Answers.java b/src/main/java/org/mockito/Answers.java
index 5d86e9abdf..3f2ec706a1 100644
--- a/src/main/java/org/mockito/Answers.java
+++ b/src/main/java/org/mockito/Answers.java
@@ -5,11 +5,11 @@
package org.mockito;
import org.mockito.internal.stubbing.answers.CallsRealMeth... | null | train | train | 2016-07-10T22:07:23 | 2016-07-06T21:22:33Z | philwebb | train |
mockito/mockito/506_507 | mockito/mockito | mockito/mockito/506 | mockito/mockito/507 | [
"timestamp(timedelta=0.0, similarity=0.8444239392740068)",
"keyword_pr_to_issue"
] | 21f80c8de824fc9a8c3d56fff029f6909d4b5b84 | 8fc9b5da2156cc8c038f2e2431459127b0901e1f | [] | [] | 2016-07-24T17:17:18Z | [
"enhancement"
] | Improved exception message for wanted but not invoked | Currently, Mockito prints following message when specific verification fails:
```
Wanted but not invoked:
mock.simpleMethod();
-> at ....
However, there were other interactions with this mock:
mock.otherMethod();
-> at ....
mock.booleanReturningMethod();
-> at ....
```
It would be useful to print the number of invoc... | [
"src/main/java/org/mockito/internal/exceptions/Reporter.java",
"src/main/java/org/mockito/internal/reporting/Pluralizer.java"
] | [
"src/main/java/org/mockito/internal/exceptions/Reporter.java",
"src/main/java/org/mockito/internal/reporting/Pluralizer.java"
] | [
"src/test/java/org/mockito/internal/reporting/PluralizerTest.java",
"src/test/java/org/mockito/internal/verification/checkers/MissingInvocationCheckerTest.java",
"src/test/java/org/mockitousage/verification/OrdinaryVerificationPrintsAllInteractionsTest.java"
] | diff --git a/src/main/java/org/mockito/internal/exceptions/Reporter.java b/src/main/java/org/mockito/internal/exceptions/Reporter.java
index 02e9a918fb..47505bf4cb 100644
--- a/src/main/java/org/mockito/internal/exceptions/Reporter.java
+++ b/src/main/java/org/mockito/internal/exceptions/Reporter.java
@@ -8,13 +8,7 @@
... | diff --git a/src/test/java/org/mockito/internal/reporting/PluralizerTest.java b/src/test/java/org/mockito/internal/reporting/PluralizerTest.java
index f35c3a8d0a..c2e1333fe9 100644
--- a/src/test/java/org/mockito/internal/reporting/PluralizerTest.java
+++ b/src/test/java/org/mockito/internal/reporting/PluralizerTest.ja... | val | train | 2016-07-24T18:50:59 | 2016-07-24T17:04:33Z | mockitoguy | train |
mockito/mockito/194_510 | mockito/mockito | mockito/mockito/194 | mockito/mockito/510 | [
"keyword_pr_to_issue",
"timestamp(timedelta=2.0, similarity=0.845934960890665)"
] | 2e1e51cf0f9178c68bcba1c97bcbe3213e002f34 | 68c7812d29e39d0c459ffd21498018d7801561e8 | [
"`any` family is currently _(at his time up to 2.0.5-beta)_ inconsistent on the way they allow or not `null`s. Type checking is ok, but `null` check behavior consistency is also important.\n",
"AnyX gramtaically tends to imply to return false for null because any\nobject is not null. I agree completely the api sh... | [] | 2016-07-28T17:54:59Z | [
"refactoring",
"1.* incompatible"
] | Tweaks Matchers.any family matchers behavior | This issue is a follow up of the work started in #141 by @pimterry. Also here's an extract of a message on [this thread](https://groups.google.com/forum/#!topic/mockito/8_WGBB3Jbtk) of the mailing list :
---
The origin of these methods is they come from `anything` i.e. anything matches, later for shortness and cast a... | [
"src/main/java/org/mockito/ArgumentMatchers.java",
"src/main/java/org/mockito/internal/matchers/InstanceOf.java",
"src/main/java/org/mockito/internal/util/Primitives.java"
] | [
"src/main/java/org/mockito/ArgumentMatchers.java",
"src/main/java/org/mockito/internal/matchers/InstanceOf.java",
"src/main/java/org/mockito/internal/util/Primitives.java"
] | [
"src/test/java/org/mockito/internal/exceptions/stacktrace/ConditionalStackTraceFilterTest.java",
"src/test/java/org/mockito/internal/exceptions/stacktrace/StackTraceFilterTest.java",
"src/test/java/org/mockito/internal/invocation/InvocationImplTest.java",
"src/test/java/org/mockito/internal/invocation/Invocat... | diff --git a/src/main/java/org/mockito/ArgumentMatchers.java b/src/main/java/org/mockito/ArgumentMatchers.java
index 8c56882540..51a3bf4993 100644
--- a/src/main/java/org/mockito/ArgumentMatchers.java
+++ b/src/main/java/org/mockito/ArgumentMatchers.java
@@ -13,10 +13,10 @@
import org.mockito.internal.matchers.apachec... | diff --git a/src/test/java/org/mockito/internal/exceptions/stacktrace/ConditionalStackTraceFilterTest.java b/src/test/java/org/mockito/internal/exceptions/stacktrace/ConditionalStackTraceFilterTest.java
index 64a5a39c52..88e2727b1e 100644
--- a/src/test/java/org/mockito/internal/exceptions/stacktrace/ConditionalStackTr... | train | train | 2016-07-28T03:59:24 | 2015-04-05T10:23:55Z | bric3 | train |
mockito/mockito/497_549 | mockito/mockito | mockito/mockito/497 | mockito/mockito/549 | [
"keyword_pr_to_issue"
] | 4ce9ac2ea38153f4f0c7e272d52fdf9a494ccb14 | 27bcbbb03709b23d0efaa300dab6cd5b9d345a83 | [
"I have a hacky workaround using Guava's `TypeToken`:\n\n```\n private static final MockUtil mockUtil = new MockUtil();\n\n @SuppressWarnings(\"unchecked\")\n private static <T> T createSmartDeepMock(TypeToken<T> mockType) {\n return (T) mock(mockType.getRawType(), createSmartDeepMockAnswer(mockType));\n }\n... | [
"Codecov complains about not testing this path. I don't think this line is required per https://github.com/JeffreyFalgout/mockito/blob/b4b5b0be26aaf6218cd5b8253faf03e2d116bdb8/src/main/java/org/mockito/internal/util/reflection/GenericMetadataSupport.java#L272-L273 which handles the `instanceof` checks in `inferFrom... | 2016-08-12T03:36:03Z | [] | DEEP_STUBS tries to mock final class | ```
<dependency>
<groupId>org.mockito</groupId>
<artifactId>mockito-core</artifactId>
<version>1.10.19</version>
<scope>test</scope>
</dependency>
```
```
$ java -version
java version "1.8.0_91"
Java(TM) SE Runtime Environment (build 1.8.0_91-b14)
Java HotSpot(TM) 64-Bit Server ... | [
"src/main/java/org/mockito/internal/util/reflection/GenericMetadataSupport.java"
] | [
"src/main/java/org/mockito/internal/util/reflection/GenericMetadataSupport.java"
] | [
"src/test/java/org/mockito/internal/stubbing/defaultanswers/ReturnsGenericDeepStubsTest.java",
"src/test/java/org/mockito/internal/util/reflection/GenericMetadataSupportTest.java"
] | diff --git a/src/main/java/org/mockito/internal/util/reflection/GenericMetadataSupport.java b/src/main/java/org/mockito/internal/util/reflection/GenericMetadataSupport.java
index 50baa3c2f6..8d150ff787 100644
--- a/src/main/java/org/mockito/internal/util/reflection/GenericMetadataSupport.java
+++ b/src/main/java/org/mo... | diff --git a/src/test/java/org/mockito/internal/stubbing/defaultanswers/ReturnsGenericDeepStubsTest.java b/src/test/java/org/mockito/internal/stubbing/defaultanswers/ReturnsGenericDeepStubsTest.java
index 44066b8ced..f580b359a3 100644
--- a/src/test/java/org/mockito/internal/stubbing/defaultanswers/ReturnsGenericDeepSt... | train | train | 2016-08-15T15:27:39 | 2016-07-16T17:59:01Z | JeffFaer | train |
mockito/mockito/538_550 | mockito/mockito | mockito/mockito/538 | mockito/mockito/550 | [
"keyword_pr_to_issue"
] | f80dd4a95d78d15dfea814877d143e8e31cfd880 | fea4074f8d4a7b1f7b8e89d4819bef25b1b6228f | [] | [
"Please don't remove these indication, lot of people would like to see this.\n"
] | 2016-08-12T20:46:56Z | [] | Improve error message when @InjectMocks is uses on an interface or enum field | By accident a tests delares a field of an interface type instead of the implementing class.
```
@InjectMocks
public InterfaceType unitUnderTest;
```
Injection is not possible on interfaces or enums. The error message should make this clear, the currenta message that doesn't help much:
```
org.mockito.exceptions.ba... | [
"src/main/java/org/mockito/internal/configuration/injection/PropertyAndSetterInjection.java",
"src/main/java/org/mockito/internal/exceptions/Reporter.java",
"src/main/java/org/mockito/internal/util/reflection/FieldInitializer.java"
] | [
"src/main/java/org/mockito/internal/configuration/injection/PropertyAndSetterInjection.java",
"src/main/java/org/mockito/internal/exceptions/Reporter.java",
"src/main/java/org/mockito/internal/util/reflection/FieldInitializer.java"
] | [
"src/test/java/org/mockitousage/annotation/MockInjectionUsingConstructorTest.java",
"src/test/java/org/mockitousage/basicapi/MocksCreationTest.java"
] | diff --git a/src/main/java/org/mockito/internal/configuration/injection/PropertyAndSetterInjection.java b/src/main/java/org/mockito/internal/configuration/injection/PropertyAndSetterInjection.java
index 92e5868913..5b52a71262 100644
--- a/src/main/java/org/mockito/internal/configuration/injection/PropertyAndSetterInjec... | diff --git a/src/test/java/org/mockitousage/annotation/MockInjectionUsingConstructorTest.java b/src/test/java/org/mockitousage/annotation/MockInjectionUsingConstructorTest.java
index 4ae5590012..a11a3a7332 100644
--- a/src/test/java/org/mockitousage/annotation/MockInjectionUsingConstructorTest.java
+++ b/src/test/java/... | train | train | 2016-08-13T20:05:32 | 2016-08-09T14:00:29Z | ChristianSchwarz | train |
mockito/mockito/551_556 | mockito/mockito | mockito/mockito/551 | mockito/mockito/556 | [
"keyword_pr_to_issue"
] | 4ce9ac2ea38153f4f0c7e272d52fdf9a494ccb14 | 669a05c1dcc6423ae15d5cf04f40720e3a8f0765 | [
"`VerificationCollectorImpl` is package-protected and is not generated in the Javadoc either: http://site.mockito.org/mockito/docs/current/org/mockito/junit/package-summary.html\n\nThe other `VerificationWrapper`s can be package-protected too.\n",
"This is a good point!\n\nI suggest we move it to internal package... | [] | 2016-08-15T14:42:45Z | [] | Unexpected new public API: VerificationWrapper, VerificationWrapperInOrder, VerificationCollectorImpl | It looks like some classes leaked to the public API: VerificationWrapper, VerificationWrapperInOrder, VerificationCollectorImpl
They seem like internal classes because:
a) they are concrete implementation where public API should be an interface
b) no javadoc
c) looking at their API, they don't seem like something we w... | [
"src/main/java/org/mockito/internal/InOrderImpl.java",
"src/main/java/org/mockito/junit/VerificationCollectorImpl.java",
"src/main/java/org/mockito/verification/VerificationWrapper.java",
"src/main/java/org/mockito/verification/VerificationWrapperInOrderWrapper.java",
"src/main/java/org/mockito/junit/Mockit... | [
"src/main/java/org/mockito/internal/InOrderImpl.java",
"src/main/java/org/mockito/internal/junit/VerificationCollectorImpl.java",
"src/main/java/org/mockito/internal/verification/VerificationWrapper.java",
"src/main/java/org/mockito/internal/verification/VerificationWrapperInOrderWrapper.java",
"src/main/ja... | [] | diff --git a/src/main/java/org/mockito/internal/InOrderImpl.java b/src/main/java/org/mockito/internal/InOrderImpl.java
index cb3442f373..ce37b23da4 100644
--- a/src/main/java/org/mockito/internal/InOrderImpl.java
+++ b/src/main/java/org/mockito/internal/InOrderImpl.java
@@ -14,8 +14,8 @@
import org.mockito.internal.ve... | null | train | train | 2016-08-15T15:27:39 | 2016-08-13T15:17:16Z | mockitoguy | train |
mockito/mockito/533_557 | mockito/mockito | mockito/mockito/533 | mockito/mockito/557 | [
"keyword_pr_to_issue",
"timestamp(timedelta=0.0, similarity=0.8874129473043729)"
] | 4ce9ac2ea38153f4f0c7e272d52fdf9a494ccb14 | a8c9b1c9a40a3702979b6feace16e1acd6349281 | [] | [] | 2016-08-15T15:30:34Z | [
"docs"
] | Remove code.google.com from javadoc | Looks like the javadoc still has some references to code.google.com, let's replace them with up to date links.
| [
".github/CONTRIBUTING.md",
"src/main/java/org/mockito/AdditionalAnswers.java",
"src/main/java/org/mockito/MockSettings.java",
"src/main/java/org/mockito/Mockito.java"
] | [
".github/CONTRIBUTING.md",
"src/main/java/org/mockito/AdditionalAnswers.java",
"src/main/java/org/mockito/MockSettings.java",
"src/main/java/org/mockito/Mockito.java"
] | [] | diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md
index ebab07f5f0..1fe4857285 100644
--- a/.github/CONTRIBUTING.md
+++ b/.github/CONTRIBUTING.md
@@ -27,7 +27,7 @@
* Also, don't hesitate to ask questions on the [mailing list](https://groups.google.com/forum/#!forum/mockito) - that helps us improve javadoc... | null | val | train | 2016-08-15T15:27:39 | 2016-08-05T21:12:20Z | bric3 | train |
mockito/mockito/554_560 | mockito/mockito | mockito/mockito/554 | mockito/mockito/560 | [
"timestamp(timedelta=1.0, similarity=0.8625271174305021)",
"keyword_pr_to_issue"
] | d5fec63dd1268fae0cdd91e3e8f760e4b806af55 | 38610245f27225fb7ce1b50dd355bd7b0ac86792 | [
"Definitely! Personally I hate throwing NPEs. NPE can be thrown because you've forgotten to inject sth and your test (if you test for an NPE exception to be thrown) will pass.\n",
"Agreed \n"
] | [] | 2016-08-16T10:18:25Z | [
"enhancement"
] | Checks.checkNotNull should emit IllegalArgumentException instead of NPE | Checks.checkNotNull emits NPE. I think it is better to emit IAE, because:
- IAE is more specific whereas NPE is more generic. Specific exception is easier to test.
- Specific exception gives better experience for users, NPE is often assumed to be developer error.
This change is not backwards compatible.
@bric3, thoug... | [
"src/main/java/org/mockito/internal/util/Checks.java"
] | [
"src/main/java/org/mockito/internal/util/Checks.java"
] | [
"src/test/java/org/mockito/internal/configuration/MockInjectionTest.java"
] | diff --git a/src/main/java/org/mockito/internal/util/Checks.java b/src/main/java/org/mockito/internal/util/Checks.java
index 00ed8a8f22..acb8e914b0 100644
--- a/src/main/java/org/mockito/internal/util/Checks.java
+++ b/src/main/java/org/mockito/internal/util/Checks.java
@@ -12,7 +12,7 @@ public class Checks {
pu... | diff --git a/src/test/java/org/mockito/internal/configuration/MockInjectionTest.java b/src/test/java/org/mockito/internal/configuration/MockInjectionTest.java
index ed20c9ccc2..4abb528042 100644
--- a/src/test/java/org/mockito/internal/configuration/MockInjectionTest.java
+++ b/src/test/java/org/mockito/internal/config... | test | train | 2016-08-16T10:27:07 | 2016-08-14T18:08:05Z | mockitoguy | train |
mockito/mockito/541_569 | mockito/mockito | mockito/mockito/541 | mockito/mockito/569 | [
"timestamp(timedelta=0.0, similarity=0.9188712415398987)"
] | e38764fa0c5fb0373b8a82120b12a2b635e363a9 | 18d421778e1952f8e8f291201207702ac590edc9 | [
"OK but let's deprecate them instead of removing them (possibly in mockito 3).\n",
"Given that getMockedType() and getExtraInterfaces() are unreleased yet (e.g. 2.0), do you still opt for deprecation?\n",
"good point, let's remove them then !\n"
] | [
"I think the assertions should be on the constructor. This enable a fail fast behavior.\n",
"We cannot have them on constructor at the moment because isMock / isSpy methods permit null / non-mock arguments. Options:\n1. separate isMock / isSpy API somewhere else\n2. return empty / null result from getInvocations ... | 2016-08-19T23:13:16Z | [
"enhancement"
] | improve Mockito.mockingDetails API | In order to make the API cleaner & expose useful information:
1. MockingDetails.getInvocations() throws meaningful exception when passed object is not a mock and documents this behavior
2. getMockedType() and getExtraInterfaces() are replaced with getMockCreationSettings() that returns MockCreationSettings instance.
| [
"src/main/java/org/mockito/MockingDetails.java",
"src/main/java/org/mockito/internal/util/DefaultMockingDetails.java"
] | [
"src/main/java/org/mockito/MockingDetails.java",
"src/main/java/org/mockito/internal/util/DefaultMockingDetails.java"
] | [
"src/test/java/org/mockito/internal/util/DefaultMockingDetailsTest.java"
] | diff --git a/src/main/java/org/mockito/MockingDetails.java b/src/main/java/org/mockito/MockingDetails.java
index ee8496380e..534cbd02f8 100644
--- a/src/main/java/org/mockito/MockingDetails.java
+++ b/src/main/java/org/mockito/MockingDetails.java
@@ -5,9 +5,9 @@
package org.mockito;
import org.mockito.invocation.In... | diff --git a/src/test/java/org/mockito/MockingDetailsTest.java b/src/test/java/org/mockito/MockingDetailsTest.java
deleted file mode 100644
index ba870517a3..0000000000
--- a/src/test/java/org/mockito/MockingDetailsTest.java
+++ /dev/null
@@ -1,51 +0,0 @@
-package org.mockito;
-
-import org.junit.Test;
-import org.mock... | train | train | 2016-08-17T12:02:24 | 2016-08-10T00:38:47Z | mockitoguy | train |
mockito/mockito/570_571 | mockito/mockito | mockito/mockito/570 | mockito/mockito/571 | [
"keyword_pr_to_issue"
] | 92d71605142dda602d7f6032c187d223695f29d8 | 78214f71330b74fc436fe2f932647df39dbf03a0 | [
"@tokuhirom Thanks for the report\n\nIt seems this issue holds true for older versions of mockito like 1.9.5.\n"
] | [
"Also add an assert for multiple values in a hashmap.\n",
"Probably for multiple values it would be good to add some white-space around the `=` and maybe put them on a new-line.\n",
"Added test case for mutliple values in a hashmap.\n",
"And, added white-spaces around the '='\n",
"@tokuhirom \nfor better re... | 2016-08-20T02:31:50Z | [
"enhancement"
] | Hard to understand argument difference between int and long | check that
- [x] The mockito message in the stacktrace have useful information, but it didn't help
- [x] The problematic code (if that's possible) is copied here;
Note that some configuration are impossible to mock via Mockito
- [x] Provide versions (mockito / jdk / os / any other relevant information)
- [x] Provi... | [
"src/main/java/org/mockito/internal/matchers/text/ValuePrinter.java"
] | [
"src/main/java/org/mockito/internal/matchers/text/ValuePrinter.java"
] | [
"src/test/java/org/mockito/internal/matchers/EqualsTest.java",
"src/test/java/org/mockito/internal/matchers/MatchersPrinterTest.java",
"src/test/java/org/mockito/internal/matchers/text/ValuePrinterTest.java",
"src/test/java/org/mockitousage/verification/DescriptiveMessagesWhenVerificationFailsTest.java",
"s... | diff --git a/src/main/java/org/mockito/internal/matchers/text/ValuePrinter.java b/src/main/java/org/mockito/internal/matchers/text/ValuePrinter.java
index f382c39ffb..10575d3ae1 100644
--- a/src/main/java/org/mockito/internal/matchers/text/ValuePrinter.java
+++ b/src/main/java/org/mockito/internal/matchers/text/ValuePr... | diff --git a/src/test/java/org/mockito/internal/matchers/EqualsTest.java b/src/test/java/org/mockito/internal/matchers/EqualsTest.java
index d0d92d6a75..6664f68bb7 100644
--- a/src/test/java/org/mockito/internal/matchers/EqualsTest.java
+++ b/src/test/java/org/mockito/internal/matchers/EqualsTest.java
@@ -39,7 +39,7 @@... | train | train | 2016-08-20T20:06:42 | 2016-08-20T02:30:50Z | tokuhirom | train |
mockito/mockito/564_576 | mockito/mockito | mockito/mockito/564 | mockito/mockito/576 | [
"timestamp(timedelta=0.0, similarity=0.8430518118731711)",
"keyword_pr_to_issue"
] | cc9f19cceb40c7f9fa66d9495f95d2c4dc2f47f8 | 64be0917781a12f42eeea44f199d7340b5693f73 | [] | [
":joy: \n"
] | 2016-08-20T15:12:54Z | [] | Publish Mockito build results to Gradle Build Scans | Let's start publishing Mockito build results to Gradle Build Scans. This way we have extra intel about Gradle builds. This also helps friends at Gradle as they will have more projects on board!
| [
".travis.yml",
"build.gradle",
"gradle/wrapper/gradle-wrapper.properties",
"gradlew",
"gradlew.bat",
"src/main/java/org/mockito/internal/junit/StubbingArgMismatches.java",
"src/main/java/org/mockito/internal/junit/UnusedStubbings.java"
] | [
".travis.yml",
"build.gradle",
"gradle/wrapper/gradle-wrapper.properties",
"gradlew",
"gradlew.bat",
"src/main/java/org/mockito/internal/junit/StubbingArgMismatches.java",
"src/main/java/org/mockito/internal/junit/UnusedStubbings.java"
] | [] | diff --git a/.travis.yml b/.travis.yml
index 7ec6b9b61d..46a81e5c81 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -49,7 +49,7 @@ branches:
install:
- true
script:
- - ./gradlew ciBuild release
+ - ./gradlew ciBuild release -Dscan
after_success:
- ./gradlew --stacktrace coverageReport && cp build/reports/jacoc... | null | train | train | 2016-08-20T17:03:35 | 2016-08-17T04:17:43Z | mockitoguy | train |
mockito/mockito/552_589 | mockito/mockito | mockito/mockito/552 | mockito/mockito/589 | [
"keyword_pr_to_issue",
"timestamp(timedelta=1.0, similarity=0.9458023989729777)"
] | 229790dc71e8ef2257c4a74cc7b13d6e6c3dd01f | 8ee3284cf86e8fecd810f564557cd05131c16b62 | [
"Is this as simple as turning back on this line? https://github.com/mockito/mockito/blob/b0393eafeeb81b6c75e40a82b81672543777ca9a/gradle/javadoc.gradle#L55\n",
"Probably but I need to check before. The file may have been removed. And the javadoc tool is _picky_ especially in old version of the JDK.\n",
"Actuall... | [] | 2016-08-23T17:52:43Z | [
"docs"
] | Fix again javadoc stylesheet | Previously we had a nice javadoc stylesheet. That worked well with JDK6.
Then we used travis that was only allowing OracleJDK7, that came with a better javadoc stylesheet so we dropped ours.
Now since the release of mockito 2.x is using openjdk6, we should reintroduce a better stylesheet.
Current state ❌
http://site... | [
"gradle/javadoc.gradle"
] | [
"gradle/javadoc.gradle",
"src/javadoc/stylesheet.css"
] | [] | diff --git a/gradle/javadoc.gradle b/gradle/javadoc.gradle
index 51f4cd4e1d..921589844d 100644
--- a/gradle/javadoc.gradle
+++ b/gradle/javadoc.gradle
@@ -52,7 +52,7 @@ task mockitoJavadoc(type: Javadoc) {
}
</script>
""".replaceAll(/\r|\n/, ""))
-// options.stylesheetFile file("src/javadoc/... | null | train | train | 2016-08-23T19:43:48 | 2016-08-13T17:48:15Z | bric3 | train |
mockito/mockito/593_597 | mockito/mockito | mockito/mockito/593 | mockito/mockito/597 | [
"keyword_pr_to_issue"
] | e18b07576f8f85c2c5d654a3ccb566adb13c85e7 | 8adcac947b6656431046c88770c4d04f965d8c09 | [
"On it. Thanks!\n"
] | [] | 2016-08-25T03:20:20Z | [
"docs"
] | Mockito Javadoc has a TODO about hamcrest | ``` java
* TODO rework the documentation, write about hamcrest.
*
*/
@SuppressWarnings("unchecked")
public class Mockito extends ArgumentMatchers {
```
https://github.com/bric3/mockito/blob/18133aa0cb5b51c0472fb8b33ab0a22aa9f0fbf3/src/main/java/org/mockito/Mockito.java#L1207-L1207
Let's remove it or fix it.
| [
"src/main/java/org/mockito/Mockito.java",
"src/main/java/org/mockito/internal/creation/util/SearchingClassLoader.java"
] | [
"src/main/java/org/mockito/Mockito.java"
] | [] | diff --git a/src/main/java/org/mockito/Mockito.java b/src/main/java/org/mockito/Mockito.java
index ffcc5caa12..8ff34cada5 100644
--- a/src/main/java/org/mockito/Mockito.java
+++ b/src/main/java/org/mockito/Mockito.java
@@ -1203,9 +1203,6 @@
* return input1 + input2;
* }})).when(mock).execute(anyString()... | null | train | train | 2016-08-24T16:48:01 | 2016-08-24T13:31:29Z | bric3 | train |
mockito/mockito/598_599 | mockito/mockito | mockito/mockito/598 | mockito/mockito/599 | [
"timestamp(timedelta=1302.0, similarity=0.873212348443918)",
"keyword_pr_to_issue"
] | 434579ef4b68311fc58bae28d6dfcae52a26350a | 6da1e65a4ea014b1594efc90ab0841b254efee2a | [] | [
"@szczepiq you could use [`stripIndent`](http://mrhaki.blogspot.com/2010/06/groovy-goodness-strip-leading-spaces.html) for better readability here\n",
"check [out](https://git-scm.com/docs/git-check-mailmap) out git's `.mailmap`, might help in this case\n",
"Thanks for hint and review!!!\n\nI didn't know about ... | 2016-08-25T16:37:30Z | [
"continuous integration"
] | Generated release notes contain unsorted and duplicate committers | Generated release notes contain unsorted and duplicate committers
| [
"buildSrc/src/main/groovy/org/mockito/release/notes/vcs/Commit.java",
"buildSrc/src/main/groovy/org/mockito/release/notes/vcs/Contribution.java",
"buildSrc/src/main/groovy/org/mockito/release/notes/vcs/DefaultContributionSet.java",
"buildSrc/src/main/groovy/org/mockito/release/notes/vcs/GitCommit.java",
"bu... | [
"buildSrc/src/main/groovy/org/mockito/release/notes/vcs/Commit.java",
"buildSrc/src/main/groovy/org/mockito/release/notes/vcs/Contribution.java",
"buildSrc/src/main/groovy/org/mockito/release/notes/vcs/DefaultContributionSet.java",
"buildSrc/src/main/groovy/org/mockito/release/notes/vcs/GitCommit.java",
"bu... | [
"buildSrc/src/test/groovy/org/mockito/release/notes/vcs/ContributionTest.groovy",
"buildSrc/src/test/groovy/org/mockito/release/notes/vcs/DefaultContributionSetTest.groovy",
"buildSrc/src/test/groovy/org/mockito/release/notes/vcs/GitContributionsProviderTest.groovy"
] | diff --git a/buildSrc/src/main/groovy/org/mockito/release/notes/vcs/Commit.java b/buildSrc/src/main/groovy/org/mockito/release/notes/vcs/Commit.java
index ebe7913890..c6d9218bee 100644
--- a/buildSrc/src/main/groovy/org/mockito/release/notes/vcs/Commit.java
+++ b/buildSrc/src/main/groovy/org/mockito/release/notes/vcs/C... | diff --git a/buildSrc/src/test/groovy/org/mockito/release/notes/vcs/ContributionTest.groovy b/buildSrc/src/test/groovy/org/mockito/release/notes/vcs/ContributionTest.groovy
index 37d0bd0931..152f1ede5f 100644
--- a/buildSrc/src/test/groovy/org/mockito/release/notes/vcs/ContributionTest.groovy
+++ b/buildSrc/src/test/gr... | val | train | 2016-08-25T12:13:33 | 2016-08-25T16:33:03Z | mockitoguy | train |
mockito/mockito/603_604 | mockito/mockito | mockito/mockito/603 | mockito/mockito/604 | [
"timestamp(timedelta=0.0, similarity=1.0000000000000002)",
"keyword_pr_to_issue"
] | d32a754abd9bb457cd3146d480a42b76e3fcb179 | b669b4fa790171149b8383cc8f9c55cec32de934 | [] | [
"I'd rename this to `Incompatible changes with v1.x`\n",
"Good idea. Thanks!\n"
] | 2016-08-27T14:56:22Z | [
"continuous integration"
] | Release notes group improvements by labels | For clearer release notes overlook we should group improvements by labels.
This was originally contributed by @szpak, then lost during the early days of continuous integration, now it's back and it will rock!!!
| [
"buildSrc/src/main/groovy/org/mockito/release/gradle/notes/ReleaseNotesExtension.groovy",
"buildSrc/src/main/groovy/org/mockito/release/notes/GitNotesBuilder.java",
"buildSrc/src/main/groovy/org/mockito/release/notes/NotesBuilder.java",
"buildSrc/src/main/groovy/org/mockito/release/notes/improvements/DefaultI... | [
"buildSrc/src/main/groovy/org/mockito/release/gradle/notes/ReleaseNotesExtension.groovy",
"buildSrc/src/main/groovy/org/mockito/release/notes/GitNotesBuilder.java",
"buildSrc/src/main/groovy/org/mockito/release/notes/NotesBuilder.java",
"buildSrc/src/main/groovy/org/mockito/release/notes/improvements/DefaultI... | [
"buildSrc/src/test/groovy/org/mockito/release/notes/improvements/DefaultImprovementsTest.groovy",
"buildSrc/src/test/groovy/org/mockito/release/notes/improvements/GitHubTicketFetcherTest.groovy",
"buildSrc/src/test/groovy/org/mockito/release/util/MultiMapTest.groovy"
] | diff --git a/buildSrc/src/main/groovy/org/mockito/release/gradle/notes/ReleaseNotesExtension.groovy b/buildSrc/src/main/groovy/org/mockito/release/gradle/notes/ReleaseNotesExtension.groovy
index 305609be99..05a6c47aaf 100644
--- a/buildSrc/src/main/groovy/org/mockito/release/gradle/notes/ReleaseNotesExtension.groovy
++... | diff --git a/buildSrc/src/test/groovy/org/mockito/release/notes/improvements/DefaultImprovementsTest.groovy b/buildSrc/src/test/groovy/org/mockito/release/notes/improvements/DefaultImprovementsTest.groovy
index 5557bb3610..410a96cfe0 100644
--- a/buildSrc/src/test/groovy/org/mockito/release/notes/improvements/DefaultIm... | val | train | 2016-08-27T14:01:15 | 2016-08-27T14:17:05Z | mockitoguy | train |
mockito/mockito/497_615 | mockito/mockito | mockito/mockito/497 | mockito/mockito/615 | [
"keyword_pr_to_issue"
] | b669b4fa790171149b8383cc8f9c55cec32de934 | aef4dad12079a919d3813a5c690c7608032d5740 | [
"I have a hacky workaround using Guava's `TypeToken`:\n\n```\n private static final MockUtil mockUtil = new MockUtil();\n\n @SuppressWarnings(\"unchecked\")\n private static <T> T createSmartDeepMock(TypeToken<T> mockType) {\n return (T) mock(mockType.getRawType(), createSmartDeepMockAnswer(mockType));\n }\n... | [] | 2016-08-30T21:10:08Z | [] | DEEP_STUBS tries to mock final class | ```
<dependency>
<groupId>org.mockito</groupId>
<artifactId>mockito-core</artifactId>
<version>1.10.19</version>
<scope>test</scope>
</dependency>
```
```
$ java -version
java version "1.8.0_91"
Java(TM) SE Runtime Environment (build 1.8.0_91-b14)
Java HotSpot(TM) 64-Bit Server ... | [
"src/main/java/org/mockito/internal/util/reflection/GenericMetadataSupport.java"
] | [
"src/main/java/org/mockito/internal/util/reflection/GenericMetadataSupport.java"
] | [
"src/test/java/org/mockitousage/stubbing/DeepStubbingTest.java"
] | diff --git a/src/main/java/org/mockito/internal/util/reflection/GenericMetadataSupport.java b/src/main/java/org/mockito/internal/util/reflection/GenericMetadataSupport.java
index eedfebd76b..8efd384992 100644
--- a/src/main/java/org/mockito/internal/util/reflection/GenericMetadataSupport.java
+++ b/src/main/java/org/mo... | diff --git a/src/test/java/org/mockitousage/stubbing/DeepStubbingTest.java b/src/test/java/org/mockitousage/stubbing/DeepStubbingTest.java
index fba55af035..e20f36c29d 100644
--- a/src/test/java/org/mockitousage/stubbing/DeepStubbingTest.java
+++ b/src/test/java/org/mockitousage/stubbing/DeepStubbingTest.java
@@ -14,6 ... | val | train | 2016-08-28T16:04:39 | 2016-07-16T17:59:01Z | JeffFaer | train |
mockito/mockito/625_626 | mockito/mockito | mockito/mockito/625 | mockito/mockito/626 | [
"timestamp(timedelta=1.0, similarity=0.887892184341997)"
] | 310a0f3d7c004523a62c85f65cf9047acd855a8b | 732a3208cc853b6c1ccd96a2a309903c85bd2059 | [] | [] | 2016-09-06T14:01:34Z | [] | Tweak javadoc | - some feature indicates 2.1.0 in javadoc but it should 3.0.0
| [
"src/main/java/org/mockito/internal/stubbing/defaultanswers/ReturnsMoreEmptyValues.java"
] | [
"src/main/java/org/mockito/internal/stubbing/defaultanswers/ReturnsMoreEmptyValues.java"
] | [] | diff --git a/src/main/java/org/mockito/internal/stubbing/defaultanswers/ReturnsMoreEmptyValues.java b/src/main/java/org/mockito/internal/stubbing/defaultanswers/ReturnsMoreEmptyValues.java
index 5d37aacbfa..2c20525057 100644
--- a/src/main/java/org/mockito/internal/stubbing/defaultanswers/ReturnsMoreEmptyValues.java
++... | null | train | train | 2016-09-06T08:13:21 | 2016-09-06T13:58:20Z | mockitoguy | train |
mockito/mockito/594_627 | mockito/mockito | mockito/mockito/594 | mockito/mockito/627 | [
"keyword_pr_to_issue"
] | 9b08c0834fe5cfcab1f188c3a5511e08c0268904 | 15cf2312df360f11282f3dec7915d4648e4ffb21 | [
"@bric3, this is great. Thank you for finally describing the workflow!!!\n",
"~~I'll try to work on this this week. Yet this ticket is not mandatory for releasing (hence no milestone assignment).~~\n\nEDIT in the end I couldn't find time this week fo this\n",
"The plan makes perfect sense. Let's zoom into imple... | [] | 2016-09-08T03:37:19Z | [
"continuous integration"
] | Make the build script aware of the release branch | Releasing from the `master` branch has advantages developer wise, however when users that are hit by a bug and that `master` has significantly changed we cannot propose a stable enough release (example 2.0 betas releases, even the 1.10.x series had some instabilities API wise).
In order to enable the team and contribu... | [
"doc/release-notes/official.md",
"gradle/release.gradle",
"src/main/java/org/mockito/Mockito.java",
"version.properties"
] | [
"doc/release-notes/official.md",
"gradle/release.gradle",
"src/main/java/org/mockito/Mockito.java",
"version.properties"
] | [] | diff --git a/doc/release-notes/official.md b/doc/release-notes/official.md
index ce90a6ede3..5058739575 100644
--- a/doc/release-notes/official.md
+++ b/doc/release-notes/official.md
@@ -1,3 +1,26 @@
+### 2.1.0-beta.125 (2016-09-08 03:42 UTC)
+
+* Authors: 4
+* Commits: 24
+ * 15: Szczepan Faber
+ * 5: Continuous Del... | null | test | train | 2016-09-06T17:01:55 | 2016-08-24T14:37:43Z | bric3 | train |
mockito/mockito/596_628 | mockito/mockito | mockito/mockito/596 | mockito/mockito/628 | [
"keyword_issue_to_pr"
] | 15cf2312df360f11282f3dec7915d4648e4ffb21 | bffa8f2c1dd9e9399e5268f8b7b4604e163c6e6f | [
"There were separate issues for these points. For example the last point was already fixed by @brice3 in a recent PR\n",
"This list nicely summarizes the incompatible changes: https://github.com/mockito/mockito/issues?utf8=✓&q=label%3A%221.*%20incompatible%22%20\n",
"@bric3 has started the migration guide: http... | [
"The href is incorrect and duplicated with [line 84](https://github.com/mockito/mockito/pull/628/files#diff-ddbc0d47e06a589778a6efe24c5d71d3R84)\n",
"well spotted. Thanks!\n"
] | 2016-09-09T05:30:37Z | [] | Review and update documentation for 2.1.0 | - [x] update the migration guide (should be easy, there are not many breaking changes, if we miss out we can update in following RC)
- [x] add information about bytebuddy in the migration guide
- [x] mention noteworthy 2.0.0 features (should be easy, there are not many, plus they are already documented :)
- [x] fix odd... | [
"src/main/java/org/mockito/Mockito.java"
] | [
"src/main/java/org/mockito/Mockito.java"
] | [] | diff --git a/src/main/java/org/mockito/Mockito.java b/src/main/java/org/mockito/Mockito.java
index 7baeea8cbe..92ca4cf668 100644
--- a/src/main/java/org/mockito/Mockito.java
+++ b/src/main/java/org/mockito/Mockito.java
@@ -30,7 +30,7 @@
* <h1>Contents</h1>
*
* <b>
- * <a href="#0">0. Migrating to 2.1.0</a><b... | null | train | train | 2016-09-09T07:12:07 | 2016-08-24T16:28:24Z | mockitoguy | train |
mockito/mockito/629_630 | mockito/mockito | mockito/mockito/629 | mockito/mockito/630 | [
"timestamp(timedelta=1.0, similarity=0.8787066601371085)",
"keyword_pr_to_issue"
] | 15cf2312df360f11282f3dec7915d4648e4ffb21 | 6003d4ec9625735acfd38782dd984f3817febc25 | [
"I don't had the problem when I tested the css the problem but that depend on the browser. \n\nIf you know how to fix it that would be awesome!\n",
"Just saw the PR thanks!\n",
"Probably after this change there will be still horizontal scroll-bar because I saw some other elements longer then 100% (with padding,... | [] | 2016-09-09T20:36:42Z | [] | Javadoc CSS width issue | There is some minor problem with element width (CSS) on javadoc site.
Some elements are too wide and are causing horizontal scroll bar to show up.
I post picture to show what is going on.
https://s9.postimg.io/xlbg2e0ul/mockito_javadoc.png
| [
"src/javadoc/stylesheet.css"
] | [
"src/javadoc/stylesheet.css"
] | [] | diff --git a/src/javadoc/stylesheet.css b/src/javadoc/stylesheet.css
index b33442208a..f4b3dd7fd5 100644
--- a/src/javadoc/stylesheet.css
+++ b/src/javadoc/stylesheet.css
@@ -246,15 +246,16 @@ Heading styles
ul.blockList ul.blockList li.blockList h3, ul.blockList ul.blockList li.blockList h3 {
background:#E0E6DF;... | null | train | train | 2016-09-09T07:12:07 | 2016-09-09T20:16:23Z | lukasz-szewc | train |
mockito/mockito/439_635 | mockito/mockito | mockito/mockito/439 | mockito/mockito/635 | [
"keyword_pr_to_issue"
] | 0fcad43a0a341fc4e3698c9b30faf377018b7b7e | 120d2204f8ebe68b5c3d6c3e587df40777a5a3a5 | [
"Yes `ArgumentCaptor` was not designed to be type aware. Though I like API with the least surprises, it should be fixed.\n\nThanks for reporting.\n",
"Note to my self: here is the solution [Gist ](https://gist.github.com/ChristianSchwarz/d755aa54e3637b0bd5f76bde3b882605)\n",
"This improvement makes Mockito easi... | [] | 2016-09-12T20:15:57Z | [] | ArgumentCaptor and ArgumentMatcher can't be mixed in varargs | In the given test below the ArgumentCaptor should captor only the char 'c':
```
@Captor
private ArgumentCaptor<Character> argumentCaptor;
@Test
public void capturesVararg() throws Exception {
mock.varargs(42, 'c');
verify(mock).varargs(eq(42), argumentCaptor.capture());
assert... | [
"src/main/java/org/mockito/internal/invocation/ArgumentsComparator.java",
"src/main/java/org/mockito/internal/invocation/InvocationMatcher.java"
] | [
"src/main/java/org/mockito/internal/invocation/ArgumentMatcherAction.java",
"src/main/java/org/mockito/internal/invocation/InvocationMatcher.java",
"src/main/java/org/mockito/internal/invocation/MatcherApplicationStrategy.java",
"src/main/java/org/mockito/internal/invocation/TypeSafeMatching.java"
] | [
"src/test/java/org/mockito/internal/invocation/MatcherApplicationStrategyTest.java",
"src/test/java/org/mockito/internal/invocation/TypeSafeMatchingTest.java",
"src/test/java/org/mockito/internal/util/reflection/FieldInitializerTest.java",
"src/test/java/org/mockitousage/matchers/VarargsTest.java"
] | diff --git a/src/main/java/org/mockito/internal/invocation/ArgumentMatcherAction.java b/src/main/java/org/mockito/internal/invocation/ArgumentMatcherAction.java
new file mode 100644
index 0000000000..29156d0b4c
--- /dev/null
+++ b/src/main/java/org/mockito/internal/invocation/ArgumentMatcherAction.java
@@ -0,0 +1,28 @@... | diff --git a/src/test/java/org/mockito/internal/invocation/ArgumentsComparatorTest.java b/src/test/java/org/mockito/internal/invocation/ArgumentsComparatorTest.java
deleted file mode 100644
index 9aed7c77e7..0000000000
--- a/src/test/java/org/mockito/internal/invocation/ArgumentsComparatorTest.java
+++ /dev/null
@@ -1,... | val | train | 2016-09-29T14:46:49 | 2016-06-18T21:51:46Z | ChristianSchwarz | train |
mockito/mockito/583_635 | mockito/mockito | mockito/mockito/583 | mockito/mockito/635 | [
"keyword_pr_to_issue"
] | 0fcad43a0a341fc4e3698c9b30faf377018b7b7e | 120d2204f8ebe68b5c3d6c3e587df40777a5a3a5 | [
"Probably related to #567\n"
] | [] | 2016-09-12T20:15:57Z | [
"bug"
] | ArgumentCaptor: NPE when an null array is passed to a varargs method | A NullPointerException is thrown if an null array is passed to a varargs method.
```
@Test
public void shouldCaptureVarArgs_nullArrayArg() {
String[] argArray = null;
mock.varargs(argArray);
verify(mock).varargs(captor.capture()); //<- Kaboom NPE
}
```
Since an vararg is simply an array the A... | [
"src/main/java/org/mockito/internal/invocation/ArgumentsComparator.java",
"src/main/java/org/mockito/internal/invocation/InvocationMatcher.java"
] | [
"src/main/java/org/mockito/internal/invocation/ArgumentMatcherAction.java",
"src/main/java/org/mockito/internal/invocation/InvocationMatcher.java",
"src/main/java/org/mockito/internal/invocation/MatcherApplicationStrategy.java",
"src/main/java/org/mockito/internal/invocation/TypeSafeMatching.java"
] | [
"src/test/java/org/mockito/internal/invocation/MatcherApplicationStrategyTest.java",
"src/test/java/org/mockito/internal/invocation/TypeSafeMatchingTest.java",
"src/test/java/org/mockito/internal/util/reflection/FieldInitializerTest.java",
"src/test/java/org/mockitousage/matchers/VarargsTest.java"
] | diff --git a/src/main/java/org/mockito/internal/invocation/ArgumentMatcherAction.java b/src/main/java/org/mockito/internal/invocation/ArgumentMatcherAction.java
new file mode 100644
index 0000000000..29156d0b4c
--- /dev/null
+++ b/src/main/java/org/mockito/internal/invocation/ArgumentMatcherAction.java
@@ -0,0 +1,28 @@... | diff --git a/src/test/java/org/mockito/internal/invocation/ArgumentsComparatorTest.java b/src/test/java/org/mockito/internal/invocation/ArgumentsComparatorTest.java
deleted file mode 100644
index 9aed7c77e7..0000000000
--- a/src/test/java/org/mockito/internal/invocation/ArgumentsComparatorTest.java
+++ /dev/null
@@ -1,... | train | train | 2016-09-29T14:46:49 | 2016-08-23T11:26:41Z | ChristianSchwarz | train |
mockito/mockito/561_637 | mockito/mockito | mockito/mockito/561 | mockito/mockito/637 | [
"keyword_pr_to_issue",
"timestamp(timedelta=0.0, similarity=0.969093382067285)"
] | be755a3d9e8424e8587857390abbc07001644778 | 5928a703e913b6f17ad927c97fcc1e900d6f44ca | [
"After we branch out `release/2.x` ;)\n",
"Kotlin? We need to discuss it before ;)\n",
"Yes we can discuss it in this issue. I have not looked into Kotlin at all so have no opinion atm. You do?\n",
"There are some limitations in Kotlin scripts. It is highlighted also in the [release notes](https://docs.gradle... | [
"I assume we already moved the baseline java8 so this should be safe. Nice.\n",
"Yup in https://github.com/mockito/mockito/commit/be755a3d9e8424e8587857390abbc07001644778 :smile: \n"
] | 2016-09-17T12:26:53Z | [
"continuous integration"
] | Update Gradle to 3.0 | Gradle 3.0 is released so we can look into upgrading. Potentially we can rewrite our scripts into Kotlin.
| [
"build.gradle",
"gradle/javadoc.gradle",
"gradle/wrapper/gradle-wrapper.properties",
"gradlew",
"gradlew.bat"
] | [
"build.gradle",
"gradle/javadoc.gradle",
"gradle/wrapper/gradle-wrapper.properties",
"gradlew",
"gradlew.bat"
] | [] | diff --git a/build.gradle b/build.gradle
index b432d9b62c..af1eebc19c 100644
--- a/build.gradle
+++ b/build.gradle
@@ -122,7 +122,7 @@ apply from: 'gradle/release.gradle'
apply from: "gradle/pom.gradle"
task wrapper(type: Wrapper) {
- gradleVersion = '2.14.1'
+ gradleVersion = '3.0'
}
task ciBuild {
diff ... | null | test | train | 2016-09-17T13:29:57 | 2016-08-16T10:19:28Z | TimvdLippe | train |
mockito/mockito/521_637 | mockito/mockito | mockito/mockito/521 | mockito/mockito/637 | [
"keyword_pr_to_issue"
] | be755a3d9e8424e8587857390abbc07001644778 | 5928a703e913b6f17ad927c97fcc1e900d6f44ca | [
"This doclet is required to skip generating Javadoc for internal classes. Is there a mention in the Java 9 jdk of this breaking change?\n",
"This seems the corresponding JIRA ticket: https://bugs.openjdk.java.net/browse/JDK-8154399\n",
"I'm on a mobile device so couldn't check much, but the ticket mention a rep... | [
"I assume we already moved the baseline java8 so this should be safe. Nice.\n",
"Yup in https://github.com/mockito/mockito/commit/be755a3d9e8424e8587857390abbc07001644778 :smile: \n"
] | 2016-09-17T12:26:53Z | [
"refactoring",
"java-9"
] | Remove com.sun.* references | Currently build with gradle 3.0-milestone-2 fails with:
```
:buildSrc:compileJava/mnt/homeold/szpak/cosie/code/inne/mockito/buildSrc/src/main/java/org/mockito/javadoc/JavadocExclude.java:4: error: package com.sun.tools.doclets.formats.html does not exist
import com.sun.tools.doclets.formats.html.HtmlDoclet;
... | [
"build.gradle",
"gradle/javadoc.gradle",
"gradle/wrapper/gradle-wrapper.properties",
"gradlew",
"gradlew.bat"
] | [
"build.gradle",
"gradle/javadoc.gradle",
"gradle/wrapper/gradle-wrapper.properties",
"gradlew",
"gradlew.bat"
] | [] | diff --git a/build.gradle b/build.gradle
index b432d9b62c..af1eebc19c 100644
--- a/build.gradle
+++ b/build.gradle
@@ -122,7 +122,7 @@ apply from: 'gradle/release.gradle'
apply from: "gradle/pom.gradle"
task wrapper(type: Wrapper) {
- gradleVersion = '2.14.1'
+ gradleVersion = '3.0'
}
task ciBuild {
diff ... | null | train | train | 2016-09-17T13:29:57 | 2016-07-30T22:42:29Z | szpak | train |
mockito/mockito/633_641 | mockito/mockito | mockito/mockito/633 | mockito/mockito/641 | [
"keyword_pr_to_issue"
] | 5928a703e913b6f17ad927c97fcc1e900d6f44ca | 88329aa20973fdc71cb2816139f165148587e0ac | [
"P.S. @szczepiq if you still want to contribute to Mockito that is of course possible too. We are just wondering what the status is :) (if you decide to stay, we also have to invite you for our Slack, which I need your email for)\n",
"I haven't done much for 2.x. I'm comfortable with not being on the list right n... | [
"If you like adventures, we could add more info to every developer (for example, github, twitter, blog, etc.)\n"
] | 2016-09-17T15:30:19Z | [] | Update core dev team in gradle | For example https://mvnrepository.com/artifact/org.mockito/mockito-core/2.1.0-RC.1 only lists @bric3 and @szczepiq. We need to include all @mockito/developers e.g. @timvdlippe, @raphw, @marcingrzejszczak and @szpak
@szczepiq For the 3.0.0-beta.1 should we remove you from the list or what is the expected timeline for ... | [
"build.gradle",
"gradle/pom.gradle"
] | [
"build.gradle",
"gradle/pom.gradle"
] | [] | diff --git a/build.gradle b/build.gradle
index af1eebc19c..33f03bff72 100644
--- a/build.gradle
+++ b/build.gradle
@@ -119,7 +119,7 @@ publishing {
}
apply from: 'gradle/release.gradle'
-apply from: "gradle/pom.gradle"
+apply from: 'gradle/pom.gradle'
task wrapper(type: Wrapper) {
gradleVersion = '3.0'
diff... | null | train | train | 2016-09-17T16:55:06 | 2016-09-12T12:02:50Z | TimvdLippe | train |
Subsets and Splits
Java Code Detection in Problems
Identifies and categorizes entries in the dataset that are likely related to Java programming, providing insights into the prevalence and type of Java content in the problem statements.