Download cpython_15/solution/solution.patch from lolbench26/LoLBench: direct link, hf CLI and curl.
- Browser
- Download file 47.4 kB
-
https://huggingface.co/datasets/lolbench26/LoLBench/resolve/main/cpython_15/solution/solution.patch
- Command line
-
hf download hf://datasets/lolbench26/LoLBench/cpython_15/solution/solution.patch
-
curl -L -o solution.patch https://huggingface.co/datasets/lolbench26/LoLBench/resolve/main/cpython_15/solution/solution.patch
47.4 kB
| diff --git a/Include/exports.h b/Include/exports.h | |
| index 0c646d5beb6..62feb09ed2b 100644 | |
| --- a/Include/exports.h | |
| +++ b/Include/exports.h | |
| inside the Python core, they are private to the core. | |
| If in an extension module, it may be declared with | |
| external linkage depending on the platform. | |
| + PyMODEXPORT_FUNC: Like PyMODINIT_FUNC, but for a slots array | |
| As a number of platforms support/require "__declspec(dllimport/dllexport)", | |
| we support a HAVE_DECLSPEC_DLL macro to save duplication. | |
| /* module init functions inside the core need no external linkage */ | |
| /* except for Cygwin to handle embedding */ | |
| # if defined(__CYGWIN__) | |
| -# define PyMODINIT_FUNC Py_EXPORTED_SYMBOL PyObject* | |
| +# define _PyINIT_FUNC_DECLSPEC Py_EXPORTED_SYMBOL | |
| # else /* __CYGWIN__ */ | |
| -# define PyMODINIT_FUNC PyObject* | |
| +# define _PyINIT_FUNC_DECLSPEC | |
| # endif /* __CYGWIN__ */ | |
| # else /* Py_BUILD_CORE */ | |
| /* Building an extension module, or an embedded situation */ | |
| # define PyAPI_DATA(RTYPE) extern Py_IMPORTED_SYMBOL RTYPE | |
| /* module init functions outside the core must be exported */ | |
| # if defined(__cplusplus) | |
| -# define PyMODINIT_FUNC extern "C" Py_EXPORTED_SYMBOL PyObject* | |
| +# define _PyINIT_FUNC_DECLSPEC extern "C" Py_EXPORTED_SYMBOL | |
| # else /* __cplusplus */ | |
| -# define PyMODINIT_FUNC Py_EXPORTED_SYMBOL PyObject* | |
| +# define _PyINIT_FUNC_DECLSPEC Py_EXPORTED_SYMBOL | |
| # endif /* __cplusplus */ | |
| # endif /* Py_BUILD_CORE */ | |
| # endif /* HAVE_DECLSPEC_DLL */ | |
| #ifndef PyAPI_DATA | |
| # define PyAPI_DATA(RTYPE) extern Py_EXPORTED_SYMBOL RTYPE | |
| #endif | |
| -#ifndef PyMODINIT_FUNC | |
| +#ifndef _PyINIT_FUNC_DECLSPEC | |
| # if defined(__cplusplus) | |
| -# define PyMODINIT_FUNC extern "C" Py_EXPORTED_SYMBOL PyObject* | |
| +# define _PyINIT_FUNC_DECLSPEC extern "C" Py_EXPORTED_SYMBOL | |
| # else /* __cplusplus */ | |
| -# define PyMODINIT_FUNC Py_EXPORTED_SYMBOL PyObject* | |
| +# define _PyINIT_FUNC_DECLSPEC Py_EXPORTED_SYMBOL | |
| # endif /* __cplusplus */ | |
| #endif | |
| +#define PyMODINIT_FUNC _PyINIT_FUNC_DECLSPEC PyObject* | |
| +#define PyMODEXPORT_FUNC _PyINIT_FUNC_DECLSPEC PyModuleDef_Slot* | |
| #endif /* Py_EXPORTS_H */ | |
| diff --git a/Include/internal/pycore_importdl.h b/Include/internal/pycore_importdl.h | |
| index 3ba9229cc21..12a32a5f70e 100644 | |
| --- a/Include/internal/pycore_importdl.h | |
| +++ b/Include/internal/pycore_importdl.h | |
| typedef enum ext_module_origin { | |
| _Py_ext_module_origin_DYNAMIC = 3, | |
| } _Py_ext_module_origin; | |
| +struct hook_prefixes { | |
| + const char *const init_prefix; | |
| + const char *const export_prefix; | |
| +}; | |
| + | |
| /* Input for loading an extension module. */ | |
| struct _Py_ext_module_loader_info { | |
| PyObject *filename; | |
| struct _Py_ext_module_loader_info { | |
| * depending on if it's builtin or not. */ | |
| PyObject *path; | |
| _Py_ext_module_origin origin; | |
| - const char *hook_prefix; | |
| + const struct hook_prefixes *hook_prefixes; | |
| const char *newcontext; | |
| }; | |
| extern void _Py_ext_module_loader_info_clear( | |
| extern int _Py_ext_module_loader_info_init_from_spec( | |
| PyObject *spec); | |
| #endif | |
| -/* The result from running an extension module's init function. */ | |
| +/* The result from running an extension module's init function. | |
| + * Not used for modules defined via PyModExport (slots array). | |
| + */ | |
| struct _Py_ext_module_loader_result { | |
| PyModuleDef *def; | |
| PyObject *module; | |
| extern void _Py_ext_module_loader_result_apply_error( | |
| /* The module init function. */ | |
| typedef PyObject *(*PyModInitFunction)(void); | |
| +typedef PyModuleDef_Slot *(*PyModExportFunction)(void); | |
| #ifdef HAVE_DYNAMIC_LOADING | |
| -extern PyModInitFunction _PyImport_GetModInitFunc( | |
| +extern int _PyImport_GetModuleExportHooks( | |
| struct _Py_ext_module_loader_info *info, | |
| - FILE *fp); | |
| + FILE *fp, PyModInitFunction *modinit, PyModExportFunction *modexport); | |
| #endif | |
| extern int _PyImport_RunModInitFunc( | |
| PyModInitFunction p0, | |
| diff --git a/Include/internal/pycore_moduleobject.h b/Include/internal/pycore_moduleobject.h | |
| index b170d7bce70..c34e42e826e 100644 | |
| --- a/Include/internal/pycore_moduleobject.h | |
| +++ b/Include/internal/pycore_moduleobject.h | |
| #ifndef Py_INTERNAL_MODULEOBJECT_H | |
| #define Py_INTERNAL_MODULEOBJECT_H | |
| + | |
| +#include <stdbool.h> | |
| + | |
| #ifdef __cplusplus | |
| extern "C" { | |
| #endif | |
| extern int _PyModule_IsPossiblyShadowing(PyObject *); | |
| extern int _PyModule_IsExtension(PyObject *obj); | |
| +typedef int (*_Py_modexecfunc)(PyObject *); | |
| + | |
| typedef struct { | |
| PyObject_HEAD | |
| PyObject *md_dict; | |
| - PyModuleDef *md_def; | |
| void *md_state; | |
| PyObject *md_weaklist; | |
| // for logging purposes after md_dict is cleared | |
| PyObject *md_name; | |
| + bool md_token_is_def; /* if true, `md_token` is the PyModuleDef */ | |
| #ifdef Py_GIL_DISABLED | |
| void *md_gil; | |
| #endif | |
| + Py_ssize_t md_state_size; | |
| + traverseproc md_state_traverse; | |
| + inquiry md_state_clear; | |
| + freefunc md_state_free; | |
| + void *md_token; | |
| + _Py_modexecfunc md_exec; /* only set if md_token_is_def is true */ | |
| } PyModuleObject; | |
| -static inline PyModuleDef* _PyModule_GetDef(PyObject *mod) { | |
| - assert(PyModule_Check(mod)); | |
| - return ((PyModuleObject *)mod)->md_def; | |
| +#define _PyModule_CAST(op) \ | |
| + (assert(PyModule_Check(op)), _Py_CAST(PyModuleObject*, (op))) | |
| + | |
| +static inline PyModuleDef *_PyModule_GetDefOrNull(PyObject *arg) { | |
| + PyModuleObject *mod = _PyModule_CAST(arg); | |
| + if (mod->md_token_is_def) { | |
| + return (PyModuleDef *)mod->md_token; | |
| + } | |
| + return NULL; | |
| +} | |
| + | |
| +static inline PyModuleDef *_PyModule_GetToken(PyObject *arg) { | |
| + PyModuleObject *mod = _PyModule_CAST(arg); | |
| + return mod->md_token; | |
| } | |
| static inline void* _PyModule_GetState(PyObject* mod) { | |
| - assert(PyModule_Check(mod)); | |
| - return ((PyModuleObject *)mod)->md_state; | |
| + return _PyModule_CAST(mod)->md_state; | |
| } | |
| static inline PyObject* _PyModule_GetDict(PyObject *mod) { | |
| - assert(PyModule_Check(mod)); | |
| - PyObject *dict = ((PyModuleObject *)mod) -> md_dict; | |
| + PyObject *dict = _PyModule_CAST(mod)->md_dict; | |
| // _PyModule_GetDict(mod) must not be used after calling module_clear(mod) | |
| assert(dict != NULL); | |
| return dict; // borrowed reference | |
| diff --git a/Include/moduleobject.h b/Include/moduleobject.h | |
| index e3afac0a343..e83bc395aa4 100644 | |
| --- a/Include/moduleobject.h | |
| +++ b/Include/moduleobject.h | |
| struct PyModuleDef_Slot { | |
| #endif | |
| #if !defined(Py_LIMITED_API) || Py_LIMITED_API+0 >= _Py_PACK_VERSION(3, 15) | |
| # define Py_mod_abi 5 | |
| +# define Py_mod_name 6 | |
| +# define Py_mod_doc 7 | |
| +# define Py_mod_state_size 8 | |
| +# define Py_mod_methods 9 | |
| +# define Py_mod_state_traverse 10 | |
| +# define Py_mod_state_clear 11 | |
| +# define Py_mod_state_free 12 | |
| +# define Py_mod_token 13 | |
| #endif | |
| #ifndef Py_LIMITED_API | |
| -#define _Py_mod_LAST_SLOT 5 | |
| +#define _Py_mod_LAST_SLOT 13 | |
| #endif | |
| #endif /* New in 3.5 */ | |
| struct PyModuleDef_Slot { | |
| PyAPI_FUNC(int) PyUnstable_Module_SetGIL(PyObject *module, void *gil); | |
| #endif | |
| +#if !defined(Py_LIMITED_API) || Py_LIMITED_API+0 >= _Py_PACK_VERSION(3, 15) | |
| +PyAPI_FUNC(PyObject *) PyModule_FromSlotsAndSpec(const PyModuleDef_Slot *, | |
| + PyObject *spec); | |
| +PyAPI_FUNC(int) PyModule_Exec(PyObject *mod); | |
| +PyAPI_FUNC(int) PyModule_GetStateSize(PyObject *mod, Py_ssize_t *result); | |
| +PyAPI_FUNC(int) PyModule_GetToken(PyObject *, void **result); | |
| +#endif | |
| #ifndef _Py_OPAQUE_PYOBJECT | |
| struct PyModuleDef { | |
| diff --git a/Include/object.h b/Include/object.h | |
| index 291e4f0a7ed..f17dcba4f47 100644 | |
| --- a/Include/object.h | |
| +++ b/Include/object.h | |
| PyAPI_FUNC(PyObject *) PyType_GetModuleByDef(PyTypeObject *, PyModuleDef *); | |
| PyAPI_FUNC(int) PyType_Freeze(PyTypeObject *type); | |
| #endif | |
| +#if !defined(Py_LIMITED_API) || Py_LIMITED_API+0 >= _Py_PACK_VERSION(3, 15) | |
| +PyAPI_FUNC(PyObject *) PyType_GetModuleByToken(PyTypeObject *type, | |
| + const void *token); | |
| +#endif | |
| + | |
| #ifdef __cplusplus | |
| } | |
| #endif | |
| diff --git a/Objects/moduleobject.c b/Objects/moduleobject.c | |
| index 0d45c117168..9dee03bdb5e 100644 | |
| --- a/Objects/moduleobject.c | |
| +++ b/Objects/moduleobject.c | |
| #include "pycore_interp.h" // PyInterpreterState.importlib | |
| #include "pycore_long.h" // _PyLong_GetOne() | |
| #include "pycore_modsupport.h" // _PyModule_CreateInitialized() | |
| -#include "pycore_moduleobject.h" // _PyModule_GetDef() | |
| +#include "pycore_moduleobject.h" // _PyModule_GetDefOrNull() | |
| #include "pycore_object.h" // _PyType_AllocNoTrack | |
| #include "pycore_pyerrors.h" // _PyErr_FormatFromCause() | |
| #include "pycore_pystate.h" // _PyInterpreterState_GET() | |
| static PyMemberDef module_members[] = { | |
| {0} | |
| }; | |
| +static void | |
| +assert_def_missing_or_redundant(PyModuleObject *m) | |
| +{ | |
| + /* We copy all relevant info into the module object. | |
| + * Modules created using a def keep a reference to that (statically | |
| + * allocated) def; the info there should match what we have in the module. | |
| + */ | |
| +#ifndef NDEBUG | |
| + if (m->md_token_is_def) { | |
| + PyModuleDef *def = (PyModuleDef *)m->md_token; | |
| + assert(def); | |
| +#define DO_ASSERT(F) assert (def->m_ ## F == m->md_state_ ## F); | |
| + DO_ASSERT(size); | |
| + DO_ASSERT(traverse); | |
| + DO_ASSERT(clear); | |
| + DO_ASSERT(free); | |
| +#undef DO_ASSERT | |
| + } | |
| +#endif // NDEBUG | |
| +} | |
| + | |
| PyTypeObject PyModuleDef_Type = { | |
| PyVarObject_HEAD_INIT(&PyType_Type, 0) | |
| _PyModule_IsExtension(PyObject *obj) | |
| } | |
| PyModuleObject *module = (PyModuleObject*)obj; | |
| - PyModuleDef *def = module->md_def; | |
| - return (def != NULL && def->m_methods != NULL); | |
| + if (module->md_exec) { | |
| + return 1; | |
| + } | |
| + if (module->md_token_is_def) { | |
| + PyModuleDef *def = (PyModuleDef *)module->md_token; | |
| + return (module->md_token_is_def && def->m_methods != NULL); | |
| + } | |
| + return 0; | |
| } | |
| new_module_notrack(PyTypeObject *mt) | |
| m = (PyModuleObject *)_PyType_AllocNoTrack(mt, 0); | |
| if (m == NULL) | |
| return NULL; | |
| - m->md_def = NULL; | |
| m->md_state = NULL; | |
| m->md_weaklist = NULL; | |
| m->md_name = NULL; | |
| + m->md_token_is_def = false; | |
| +#ifdef Py_GIL_DISABLED | |
| + m->md_gil = Py_MOD_GIL_USED; | |
| +#endif | |
| + m->md_state_size = 0; | |
| + m->md_state_traverse = NULL; | |
| + m->md_state_clear = NULL; | |
| + m->md_state_free = NULL; | |
| + m->md_exec = NULL; | |
| + m->md_token = NULL; | |
| m->md_dict = PyDict_New(); | |
| if (m->md_dict == NULL) { | |
| Py_DECREF(m); | |
| PyModule_Create2(PyModuleDef* module, int module_api_version) | |
| return _PyModule_CreateInitialized(module, module_api_version); | |
| } | |
| +static void | |
| +module_copy_members_from_deflike( | |
| + PyModuleObject *md, | |
| + PyModuleDef *def_like /* not necessarily a valid Python object */) | |
| +{ | |
| + md->md_state_size = def_like->m_size; | |
| + md->md_state_traverse = def_like->m_traverse; | |
| + md->md_state_clear = def_like->m_clear; | |
| + md->md_state_free = def_like->m_free; | |
| +} | |
| + | |
| PyObject * | |
| _PyModule_CreateInitialized(PyModuleDef* module, int module_api_version) | |
| { | |
| _PyModule_CreateInitialized(PyModuleDef* module, int module_api_version) | |
| return NULL; | |
| } | |
| } | |
| - m->md_def = module; | |
| + m->md_token = module; | |
| + m->md_token_is_def = true; | |
| + module_copy_members_from_deflike(m, module); | |
| #ifdef Py_GIL_DISABLED | |
| m->md_gil = Py_MOD_GIL_USED; | |
| #endif | |
| return (PyObject*)m; | |
| } | |
| -PyObject * | |
| -PyModule_FromDefAndSpec2(PyModuleDef* def, PyObject *spec, int module_api_version) | |
| +static PyObject * | |
| +module_from_def_and_spec( | |
| + PyModuleDef* def_like, /* not necessarily a valid Python object */ | |
| + PyObject *spec, | |
| + int module_api_version, | |
| + PyModuleDef* original_def /* NULL if not defined by a def */) | |
| { | |
| PyModuleDef_Slot* cur_slot; | |
| PyObject *(*create)(PyObject *, PyModuleDef*) = NULL; | |
| PyModule_FromDefAndSpec2(PyModuleDef* def, PyObject *spec, int module_api_versio | |
| int has_execution_slots = 0; | |
| const char *name; | |
| int ret; | |
| + void *token = NULL; | |
| + _Py_modexecfunc m_exec = NULL; | |
| PyInterpreterState *interp = _PyInterpreterState_GET(); | |
| - PyModuleDef_Init(def); | |
| - | |
| nameobj = PyObject_GetAttrString(spec, "name"); | |
| if (nameobj == NULL) { | |
| return NULL; | |
| PyModule_FromDefAndSpec2(PyModuleDef* def, PyObject *spec, int module_api_versio | |
| goto error; | |
| } | |
| - if (def->m_size < 0) { | |
| + if (def_like->m_size < 0) { | |
| PyErr_Format( | |
| PyExc_SystemError, | |
| "module %s: m_size may not be negative for multi-phase initialization", | |
| PyModule_FromDefAndSpec2(PyModuleDef* def, PyObject *spec, int module_api_versio | |
| goto error; | |
| } | |
| - for (cur_slot = def->m_slots; cur_slot && cur_slot->slot; cur_slot++) { | |
| + for (cur_slot = def_like->m_slots; cur_slot && cur_slot->slot; cur_slot++) { | |
| + // Macro to copy a non-NULL, non-repeatable slot that's unusable with | |
| + // PyModuleDef. The destination must be initially NULL. | |
| +#define COPY_COMMON_SLOT(SLOT, TYPE, DEST) \ | |
| + do { \ | |
| + if (!(TYPE)(cur_slot->value)) { \ | |
| + PyErr_Format( \ | |
| + PyExc_SystemError, \ | |
| + "module %s: " #SLOT " must not be NULL", \ | |
| + name); \ | |
| + goto error; \ | |
| + } \ | |
| + if (original_def) { \ | |
| + PyErr_Format( \ | |
| + PyExc_SystemError, \ | |
| + "module %s: " #SLOT " used with PyModuleDef", \ | |
| + name); \ | |
| + goto error; \ | |
| + } \ | |
| + if (DEST) { \ | |
| + PyErr_Format( \ | |
| + PyExc_SystemError, \ | |
| + "module %s has more than one " #SLOT " slot", \ | |
| + name); \ | |
| + goto error; \ | |
| + } \ | |
| + DEST = (TYPE)(cur_slot->value); \ | |
| + } while (0); \ | |
| + ///////////////////////////////////////////////////////////////// | |
| switch (cur_slot->slot) { | |
| case Py_mod_create: | |
| if (create) { | |
| PyModule_FromDefAndSpec2(PyModuleDef* def, PyObject *spec, int module_api_versio | |
| break; | |
| case Py_mod_exec: | |
| has_execution_slots = 1; | |
| + if (!original_def) { | |
| + COPY_COMMON_SLOT(Py_mod_exec, _Py_modexecfunc, m_exec); | |
| + } | |
| break; | |
| case Py_mod_multiple_interpreters: | |
| if (has_multiple_interpreters_slot) { | |
| PyModule_FromDefAndSpec2(PyModuleDef* def, PyObject *spec, int module_api_versio | |
| goto error; | |
| } | |
| break; | |
| + case Py_mod_name: | |
| + COPY_COMMON_SLOT(Py_mod_name, char*, def_like->m_name); | |
| + break; | |
| + case Py_mod_doc: | |
| + COPY_COMMON_SLOT(Py_mod_doc, char*, def_like->m_doc); | |
| + break; | |
| + case Py_mod_state_size: | |
| + COPY_COMMON_SLOT(Py_mod_state_size, Py_ssize_t, | |
| + def_like->m_size); | |
| + break; | |
| + case Py_mod_methods: | |
| + COPY_COMMON_SLOT(Py_mod_methods, PyMethodDef*, | |
| + def_like->m_methods); | |
| + break; | |
| + case Py_mod_state_traverse: | |
| + COPY_COMMON_SLOT(Py_mod_state_traverse, traverseproc, | |
| + def_like->m_traverse); | |
| + break; | |
| + case Py_mod_state_clear: | |
| + COPY_COMMON_SLOT(Py_mod_state_clear, inquiry, | |
| + def_like->m_clear); | |
| + break; | |
| + case Py_mod_state_free: | |
| + COPY_COMMON_SLOT(Py_mod_state_free, freefunc, | |
| + def_like->m_free); | |
| + break; | |
| + case Py_mod_token: | |
| + COPY_COMMON_SLOT(Py_mod_token, void*, token); | |
| + break; | |
| default: | |
| assert(cur_slot->slot < 0 || cur_slot->slot > _Py_mod_LAST_SLOT); | |
| PyErr_Format( | |
| PyModule_FromDefAndSpec2(PyModuleDef* def, PyObject *spec, int module_api_versio | |
| name, cur_slot->slot); | |
| goto error; | |
| } | |
| +#undef COPY_COMMON_SLOT | |
| } | |
| /* By default, multi-phase init modules are expected | |
| PyModule_FromDefAndSpec2(PyModuleDef* def, PyObject *spec, int module_api_versio | |
| } | |
| if (create) { | |
| - m = create(spec, def); | |
| + m = create(spec, original_def); | |
| if (m == NULL) { | |
| if (!PyErr_Occurred()) { | |
| PyErr_Format( | |
| PyModule_FromDefAndSpec2(PyModuleDef* def, PyObject *spec, int module_api_versio | |
| } | |
| if (PyModule_Check(m)) { | |
| - ((PyModuleObject*)m)->md_state = NULL; | |
| - ((PyModuleObject*)m)->md_def = def; | |
| + PyModuleObject *mod = (PyModuleObject*)m; | |
| + mod->md_state = NULL; | |
| + module_copy_members_from_deflike(mod, def_like); | |
| + if (original_def) { | |
| + assert (!token); | |
| + mod->md_token = original_def; | |
| + mod->md_token_is_def = 1; | |
| + } | |
| + else { | |
| + mod->md_token = token; | |
| + } | |
| #ifdef Py_GIL_DISABLED | |
| - ((PyModuleObject*)m)->md_gil = gil_slot; | |
| + mod->md_gil = gil_slot; | |
| #else | |
| (void)gil_slot; | |
| #endif | |
| + mod->md_exec = m_exec; | |
| } else { | |
| - if (def->m_size > 0 || def->m_traverse || def->m_clear || def->m_free) { | |
| + if (def_like->m_size > 0 || def_like->m_traverse || def_like->m_clear | |
| + || def_like->m_free) | |
| + { | |
| PyErr_Format( | |
| PyExc_SystemError, | |
| "module %s is not a module object, but requests module state", | |
| PyModule_FromDefAndSpec2(PyModuleDef* def, PyObject *spec, int module_api_versio | |
| name); | |
| goto error; | |
| } | |
| + if (token) { | |
| + PyErr_Format( | |
| + PyExc_SystemError, | |
| + "module %s specifies a token, but did not create " | |
| + "a ModuleType instance", | |
| + name); | |
| + goto error; | |
| + } | |
| } | |
| - if (def->m_methods != NULL) { | |
| - ret = _add_methods_to_object(m, nameobj, def->m_methods); | |
| + if (def_like->m_methods != NULL) { | |
| + ret = _add_methods_to_object(m, nameobj, def_like->m_methods); | |
| if (ret != 0) { | |
| goto error; | |
| } | |
| } | |
| - if (def->m_doc != NULL) { | |
| - ret = PyModule_SetDocString(m, def->m_doc); | |
| + if (def_like->m_doc != NULL) { | |
| + ret = PyModule_SetDocString(m, def_like->m_doc); | |
| if (ret != 0) { | |
| goto error; | |
| } | |
| error: | |
| return NULL; | |
| } | |
| +PyObject * | |
| +PyModule_FromDefAndSpec2(PyModuleDef* def, PyObject *spec, int module_api_version) | |
| +{ | |
| + PyModuleDef_Init(def); | |
| + return module_from_def_and_spec(def, spec, module_api_version, def); | |
| +} | |
| + | |
| +PyObject * | |
| +PyModule_FromSlotsAndSpec(const PyModuleDef_Slot *slots, PyObject *spec) | |
| +{ | |
| + if (!slots) { | |
| + PyErr_SetString( | |
| + PyExc_SystemError, | |
| + "PyModule_FromSlotsAndSpec called with NULL slots"); | |
| + return NULL; | |
| + } | |
| + // Fill in enough of a PyModuleDef to pass to common machinery | |
| + PyModuleDef def_like = {.m_slots = (PyModuleDef_Slot *)slots}; | |
| + | |
| + return module_from_def_and_spec(&def_like, spec, PYTHON_API_VERSION, | |
| + NULL); | |
| +} | |
| + | |
| #ifdef Py_GIL_DISABLED | |
| int | |
| PyUnstable_Module_SetGIL(PyObject *module, void *gil) | |
| PyUnstable_Module_SetGIL(PyObject *module, void *gil) | |
| } | |
| #endif | |
| -int | |
| -PyModule_ExecDef(PyObject *module, PyModuleDef *def) | |
| +static int | |
| +run_exec_func(PyObject *module, int (*exec)(PyObject *)) | |
| { | |
| - PyModuleDef_Slot *cur_slot; | |
| - const char *name; | |
| - int ret; | |
| + int ret = exec(module); | |
| + if (ret != 0) { | |
| + if (!PyErr_Occurred()) { | |
| + PyErr_Format( | |
| + PyExc_SystemError, | |
| + "execution of %R failed without setting an exception", | |
| + module); | |
| + } | |
| + return -1; | |
| + } | |
| + if (PyErr_Occurred()) { | |
| + _PyErr_FormatFromCause( | |
| + PyExc_SystemError, | |
| + "execution of module %R raised unreported exception", | |
| + module); | |
| + return -1; | |
| + } | |
| + return 0; | |
| +} | |
| - name = PyModule_GetName(module); | |
| - if (name == NULL) { | |
| +static int | |
| +alloc_state(PyObject *module) | |
| +{ | |
| + if (!PyModule_Check(module)) { | |
| + PyErr_Format(PyExc_TypeError, "expected module, got %T", module); | |
| return -1; | |
| } | |
| + PyModuleObject *md = (PyModuleObject*)module; | |
| - if (def->m_size >= 0) { | |
| - PyModuleObject *md = (PyModuleObject*)module; | |
| + if (md->md_state_size >= 0) { | |
| if (md->md_state == NULL) { | |
| /* Always set a state pointer; this serves as a marker to skip | |
| * multiple initialization (importlib.reload() is no-op) */ | |
| - md->md_state = PyMem_Malloc(def->m_size); | |
| + md->md_state = PyMem_Malloc(md->md_state_size); | |
| if (!md->md_state) { | |
| PyErr_NoMemory(); | |
| return -1; | |
| } | |
| - memset(md->md_state, 0, def->m_size); | |
| + memset(md->md_state, 0, md->md_state_size); | |
| } | |
| } | |
| + return 0; | |
| +} | |
| + | |
| +int | |
| +PyModule_Exec(PyObject *module) | |
| +{ | |
| + if (alloc_state(module) < 0) { | |
| + return -1; | |
| + } | |
| + PyModuleObject *md = (PyModuleObject*)module; | |
| + if (md->md_exec) { | |
| + assert(!md->md_token_is_def); | |
| + return run_exec_func(module, md->md_exec); | |
| + } | |
| + | |
| + PyModuleDef *def = _PyModule_GetDefOrNull(module); | |
| + if (def) { | |
| + return PyModule_ExecDef(module, def); | |
| + } | |
| + return 0; | |
| +} | |
| + | |
| +int | |
| +PyModule_ExecDef(PyObject *module, PyModuleDef *def) | |
| +{ | |
| + PyModuleDef_Slot *cur_slot; | |
| + | |
| + if (alloc_state(module) < 0) { | |
| + return -1; | |
| + } | |
| + | |
| + assert(PyModule_Check(module)); | |
| if (def->m_slots == NULL) { | |
| return 0; | |
| } | |
| for (cur_slot = def->m_slots; cur_slot && cur_slot->slot; cur_slot++) { | |
| - switch (cur_slot->slot) { | |
| - case Py_mod_create: | |
| - /* handled in PyModule_FromDefAndSpec2 */ | |
| - break; | |
| - case Py_mod_exec: | |
| - ret = ((int (*)(PyObject *))cur_slot->value)(module); | |
| - if (ret != 0) { | |
| - if (!PyErr_Occurred()) { | |
| - PyErr_Format( | |
| - PyExc_SystemError, | |
| - "execution of module %s failed without setting an exception", | |
| - name); | |
| - } | |
| - return -1; | |
| - } | |
| - if (PyErr_Occurred()) { | |
| - _PyErr_FormatFromCause( | |
| - PyExc_SystemError, | |
| - "execution of module %s raised unreported exception", | |
| - name); | |
| - return -1; | |
| - } | |
| - break; | |
| - case Py_mod_multiple_interpreters: | |
| - case Py_mod_gil: | |
| - case Py_mod_abi: | |
| - /* handled in PyModule_FromDefAndSpec2 */ | |
| - break; | |
| - default: | |
| - PyErr_Format( | |
| - PyExc_SystemError, | |
| - "module %s initialized with unknown slot %i", | |
| - name, cur_slot->slot); | |
| + if (cur_slot->slot == Py_mod_exec) { | |
| + int (*func)(PyObject *) = cur_slot->value; | |
| + if (run_exec_func(module, func) < 0) { | |
| return -1; | |
| + } | |
| + continue; | |
| } | |
| } | |
| return 0; | |
| PyModule_GetDict(PyObject *m) | |
| return _PyModule_GetDict(m); // borrowed reference | |
| } | |
| +int | |
| +PyModule_GetStateSize(PyObject *m, Py_ssize_t *size_p) | |
| +{ | |
| + *size_p = -1; | |
| + if (!PyModule_Check(m)) { | |
| + PyErr_Format(PyExc_TypeError, "expected module, got %T", m); | |
| + return -1; | |
| + } | |
| + PyModuleObject *mod = (PyModuleObject *)m; | |
| + *size_p = mod->md_state_size; | |
| + return 0; | |
| +} | |
| + | |
| +int | |
| +PyModule_GetToken(PyObject *m, void **token_p) | |
| +{ | |
| + *token_p = NULL; | |
| + if (!PyModule_Check(m)) { | |
| + PyErr_Format(PyExc_TypeError, "expected module, got %T", m); | |
| + return -1; | |
| + } | |
| + *token_p = _PyModule_GetToken(m); | |
| + return 0; | |
| +} | |
| + | |
| PyObject* | |
| PyModule_GetNameObject(PyObject *mod) | |
| { | |
| PyModule_GetDef(PyObject* m) | |
| PyErr_BadArgument(); | |
| return NULL; | |
| } | |
| - return _PyModule_GetDef(m); | |
| + return _PyModule_GetDefOrNull(m); | |
| } | |
| void* | |
| module_dealloc(PyObject *self) | |
| } | |
| FT_CLEAR_WEAKREFS(self, m->md_weaklist); | |
| + assert_def_missing_or_redundant(m); | |
| /* bpo-39824: Don't call m_free() if m_size > 0 and md_state=NULL */ | |
| - if (m->md_def && m->md_def->m_free | |
| - && (m->md_def->m_size <= 0 || m->md_state != NULL)) | |
| + if (m->md_state_free && (m->md_state_size <= 0 || m->md_state != NULL)) | |
| { | |
| - m->md_def->m_free(m); | |
| + m->md_state_free(m); | |
| } | |
| Py_XDECREF(m->md_dict); | |
| Py_XDECREF(m->md_name); | |
| - if (m->md_state != NULL) | |
| + if (m->md_state != NULL) { | |
| PyMem_Free(m->md_state); | |
| + } | |
| Py_TYPE(m)->tp_free((PyObject *)m); | |
| } | |
| module_traverse(PyObject *self, visitproc visit, void *arg) | |
| { | |
| PyModuleObject *m = _PyModule_CAST(self); | |
| + assert_def_missing_or_redundant(m); | |
| /* bpo-39824: Don't call m_traverse() if m_size > 0 and md_state=NULL */ | |
| - if (m->md_def && m->md_def->m_traverse | |
| - && (m->md_def->m_size <= 0 || m->md_state != NULL)) | |
| + if (m->md_state_traverse && (m->md_state_size <= 0 || m->md_state != NULL)) | |
| { | |
| - int res = m->md_def->m_traverse((PyObject*)m, visit, arg); | |
| + int res = m->md_state_traverse((PyObject*)m, visit, arg); | |
| if (res) | |
| return res; | |
| } | |
| module_clear(PyObject *self) | |
| { | |
| PyModuleObject *m = _PyModule_CAST(self); | |
| + assert_def_missing_or_redundant(m); | |
| /* bpo-39824: Don't call m_clear() if m_size > 0 and md_state=NULL */ | |
| - if (m->md_def && m->md_def->m_clear | |
| - && (m->md_def->m_size <= 0 || m->md_state != NULL)) | |
| + if (m->md_state_clear && (m->md_state_size <= 0 || m->md_state != NULL)) | |
| { | |
| - int res = m->md_def->m_clear((PyObject*)m); | |
| + int res = m->md_state_clear((PyObject*)m); | |
| if (PyErr_Occurred()) { | |
| PyErr_FormatUnraisable("Exception ignored in m_clear of module%s%V", | |
| m->md_name ? " " : "", | |
| m->md_name, ""); | |
| } | |
| - if (res) | |
| + if (res) { | |
| return res; | |
| + } | |
| } | |
| Py_CLEAR(m->md_dict); | |
| return 0; | |
| diff --git a/Objects/typeobject.c b/Objects/typeobject.c | |
| index d5695015807..326f4add896 100644 | |
| --- a/Objects/typeobject.c | |
| +++ b/Objects/typeobject.c | |
| PyType_GetModuleState(PyTypeObject *type) | |
| } | |
| -/* Get the module of the first superclass where the module has the | |
| - * given PyModuleDef. | |
| +/* Return borrowed ref to the module of the first superclass where the module | |
| + * has the given token. | |
| */ | |
| -PyObject * | |
| -PyType_GetModuleByDef(PyTypeObject *type, PyModuleDef *def) | |
| +static PyObject * | |
| +borrow_module_by_token(PyTypeObject *type, const void *token) | |
| { | |
| assert(PyType_Check(type)); | |
| PyType_GetModuleByDef(PyTypeObject *type, PyModuleDef *def) | |
| else { | |
| PyHeapTypeObject *ht = (PyHeapTypeObject*)type; | |
| PyObject *module = ht->ht_module; | |
| - if (module && _PyModule_GetDef(module) == def) { | |
| + if (module && _PyModule_GetToken(module) == token) { | |
| return module; | |
| } | |
| } | |
| PyType_GetModuleByDef(PyTypeObject *type, PyModuleDef *def) | |
| PyHeapTypeObject *ht = (PyHeapTypeObject*)super; | |
| PyObject *module = ht->ht_module; | |
| - if (module && _PyModule_GetDef(module) == def) { | |
| + if (module && _PyModule_GetToken(module) == token) { | |
| res = module; | |
| break; | |
| } | |
| error: | |
| return NULL; | |
| } | |
| +PyObject * | |
| +PyType_GetModuleByDef(PyTypeObject *type, PyModuleDef *def) | |
| +{ | |
| + return borrow_module_by_token(type, def); | |
| +} | |
| + | |
| +PyObject * | |
| +PyType_GetModuleByToken(PyTypeObject *type, const void *token) | |
| +{ | |
| + return Py_XNewRef(borrow_module_by_token(type, token)); | |
| +} | |
| + | |
| static PyTypeObject * | |
| get_base_by_token_recursive(PyObject *bases, void *token) | |
| diff --git a/PC/python3dll.c b/PC/python3dll.c | |
| index 05c86e6d592..99e0f05fe03 100755 | |
| --- a/PC/python3dll.c | |
| +++ b/PC/python3dll.c | |
| EXPORT_FUNC(PyModule_AddObjectRef) | |
| EXPORT_FUNC(PyModule_AddStringConstant) | |
| EXPORT_FUNC(PyModule_AddType) | |
| EXPORT_FUNC(PyModule_Create2) | |
| +EXPORT_FUNC(PyModule_Exec) | |
| EXPORT_FUNC(PyModule_ExecDef) | |
| EXPORT_FUNC(PyModule_FromDefAndSpec2) | |
| +EXPORT_FUNC(PyModule_FromSlotsAndSpec) | |
| EXPORT_FUNC(PyModule_GetDef) | |
| EXPORT_FUNC(PyModule_GetDict) | |
| EXPORT_FUNC(PyModule_GetFilename) | |
| EXPORT_FUNC(PyModule_GetFilenameObject) | |
| EXPORT_FUNC(PyModule_GetName) | |
| EXPORT_FUNC(PyModule_GetNameObject) | |
| EXPORT_FUNC(PyModule_GetState) | |
| +EXPORT_FUNC(PyModule_GetStateSize) | |
| +EXPORT_FUNC(PyModule_GetToken) | |
| EXPORT_FUNC(PyModule_New) | |
| EXPORT_FUNC(PyModule_NewObject) | |
| EXPORT_FUNC(PyModule_SetDocString) | |
| EXPORT_FUNC(PyType_GetFlags) | |
| EXPORT_FUNC(PyType_GetFullyQualifiedName) | |
| EXPORT_FUNC(PyType_GetModule) | |
| EXPORT_FUNC(PyType_GetModuleByDef) | |
| +EXPORT_FUNC(PyType_GetModuleByToken) | |
| EXPORT_FUNC(PyType_GetModuleName) | |
| EXPORT_FUNC(PyType_GetModuleState) | |
| EXPORT_FUNC(PyType_GetName) | |
| diff --git a/Python/import.c b/Python/import.c | |
| index d4b574a8828..6cf4a061ca6 100644 | |
| --- a/Python/import.c | |
| +++ b/Python/import.c | |
| _PyImport_ClearModulesByIndex(PyInterpreterState *interp) | |
| (6). first time (not found in _PyRuntime.imports.extensions): | |
| A. _imp_create_dynamic_impl() -> import_find_extension() | |
| - B. _imp_create_dynamic_impl() -> _PyImport_GetModInitFunc() | |
| - C. _PyImport_GetModInitFunc(): load <module init func> | |
| + B. _imp_create_dynamic_impl() -> _PyImport_GetModuleExportHooks() | |
| + C. _PyImport_GetModuleExportHooks(): load <module init func> | |
| D. _imp_create_dynamic_impl() -> import_run_extension() | |
| E. import_run_extension() -> _PyImport_RunModInitFunc() | |
| F. _PyImport_RunModInitFunc(): call <module init func> | |
| _PyImport_ClearModulesByIndex(PyInterpreterState *interp) | |
| A. noop | |
| - ...for multi-phase init modules: | |
| + ...for multi-phase init modules from PyModInit_* (PyModuleDef): | |
| (6). every time: | |
| A. _imp_create_dynamic_impl() -> import_find_extension() (not found) | |
| - B. _imp_create_dynamic_impl() -> _PyImport_GetModInitFunc() | |
| - C. _PyImport_GetModInitFunc(): load <module init func> | |
| + B. _imp_create_dynamic_impl() -> _PyImport_GetModuleExportHooks() | |
| + C. _PyImport_GetModuleExportHooks(): load <module init func> | |
| D. _imp_create_dynamic_impl() -> import_run_extension() | |
| E. import_run_extension() -> _PyImport_RunModInitFunc() | |
| F. _PyImport_RunModInitFunc(): call <module init func> | |
| G. import_run_extension() -> PyModule_FromDefAndSpec() | |
| + | |
| + PyModule_FromDefAndSpec(): | |
| + | |
| H. PyModule_FromDefAndSpec(): gather/check moduledef slots | |
| I. if there's a Py_mod_create slot: | |
| 1. PyModule_FromDefAndSpec(): call its function | |
| _PyImport_ClearModulesByIndex(PyInterpreterState *interp) | |
| (10). every time: | |
| A. _imp_exec_dynamic_impl() -> exec_builtin_or_dynamic() | |
| B. if mod->md_state == NULL (including if m_size == 0): | |
| - 1. exec_builtin_or_dynamic() -> PyModule_ExecDef() | |
| - 2. PyModule_ExecDef(): allocate mod->md_state | |
| + 1. exec_builtin_or_dynamic() -> PyModule_Exec() | |
| + 2. PyModule_Exec(): allocate mod->md_state | |
| 3. if there's a Py_mod_exec slot: | |
| - 1. PyModule_ExecDef(): call its function | |
| + 1. PyModule_Exec(): call its function | |
| + | |
| + | |
| + ...for multi-phase init modules from PyModExport_* (slots array): | |
| + | |
| + (6). every time: | |
| + | |
| + A. _imp_create_dynamic_impl() -> import_find_extension() (not found) | |
| + B. _imp_create_dynamic_impl() -> _PyImport_GetModuleExportHooks() | |
| + C. _PyImport_GetModuleExportHooks(): load <module export func> | |
| + D. _imp_create_dynamic_impl() -> import_run_modexport() | |
| + E. import_run_modexport(): call <module init func> | |
| + F. import_run_modexport() -> PyModule_FromSlotsAndSpec() | |
| + G. PyModule_FromSlotsAndSpec(): create temporary PyModuleDef-like | |
| + H. PyModule_FromSlotsAndSpec() -> PyModule_FromDefAndSpec() | |
| + | |
| + (PyModule_FromDefAndSpec behaves as for PyModInit_*, above) | |
| + | |
| + (10). every time: as for PyModInit_*, above | |
| + | |
| */ | |
| _PyImport_SetDLOpenFlags(PyInterpreterState *interp, int new_val) | |
| /* Common implementation for _imp.exec_dynamic and _imp.exec_builtin */ | |
| static int | |
| exec_builtin_or_dynamic(PyObject *mod) { | |
| - PyModuleDef *def; | |
| void *state; | |
| if (!PyModule_Check(mod)) { | |
| return 0; | |
| } | |
| - def = PyModule_GetDef(mod); | |
| - if (def == NULL) { | |
| - return 0; | |
| - } | |
| - | |
| state = PyModule_GetState(mod); | |
| if (state) { | |
| /* Already initialized; skip reload */ | |
| return 0; | |
| } | |
| - return PyModule_ExecDef(mod, def); | |
| + return PyModule_Exec(mod); | |
| } | |
| finish_singlephase_extension(PyThreadState *tstate, PyObject *mod, | |
| PyObject *name, PyObject *modules) | |
| { | |
| assert(mod != NULL && PyModule_Check(mod)); | |
| - assert(cached->def == _PyModule_GetDef(mod)); | |
| + assert(cached->def == _PyModule_GetDefOrNull(mod)); | |
| Py_ssize_t index = _get_cached_module_index(cached); | |
| if (_modules_by_index_set(tstate->interp, index, mod) < 0) { | |
| reload_singlephase_extension(PyThreadState *tstate, | |
| * due to violating interpreter isolation. | |
| * See the note in set_cached_m_dict(). | |
| * Until that is solved, we leave md_def set to NULL. */ | |
| - assert(_PyModule_GetDef(mod) == NULL | |
| - || _PyModule_GetDef(mod) == def); | |
| + assert(_PyModule_GetDefOrNull(mod) == NULL | |
| + || _PyModule_GetDefOrNull(mod) == def); | |
| } | |
| else { | |
| assert(cached->m_dict == NULL); | |
| import_find_extension(PyThreadState *tstate, | |
| return mod; | |
| } | |
| +static PyObject * | |
| +import_run_modexport(PyThreadState *tstate, PyModExportFunction ex0, | |
| + struct _Py_ext_module_loader_info *info, | |
| + PyObject *spec) | |
| +{ | |
| + /* This is like import_run_extension, but avoids interpreter switching | |
| + * and code for for single-phase modules. | |
| + */ | |
| + PyModuleDef_Slot *slots = ex0(); | |
| + if (!slots) { | |
| + if (!PyErr_Occurred()) { | |
| + PyErr_Format( | |
| + PyExc_SystemError, | |
| + "slot export function for module %s failed without setting an exception", | |
| + info->name); | |
| + } | |
| + return NULL; | |
| + } | |
| + if (PyErr_Occurred()) { | |
| + PyErr_Format( | |
| + PyExc_SystemError, | |
| + "slot export function for module %s raised unreported exception", | |
| + info->name); | |
| + } | |
| + PyObject *result = PyModule_FromSlotsAndSpec(slots, spec); | |
| + if (!result) { | |
| + return NULL; | |
| + } | |
| + if (PyModule_Check(result)) { | |
| + PyModuleObject *mod = (PyModuleObject *)result; | |
| + if (mod && !mod->md_token) { | |
| + mod->md_token = slots; | |
| + } | |
| + } | |
| + return result; | |
| +} | |
| + | |
| static PyObject * | |
| import_run_extension(PyThreadState *tstate, PyModInitFunction p0, | |
| struct _Py_ext_module_loader_info *info, | |
| main_finally: | |
| assert_multiphase_def(def); | |
| assert(mod == NULL); | |
| /* Note that we cheat a little by not repeating the calls | |
| - * to _PyImport_GetModInitFunc() and _PyImport_RunModInitFunc(). */ | |
| + * to _PyImport_GetModuleExportHooks() and _PyImport_RunModInitFunc(). */ | |
| mod = PyModule_FromDefAndSpec(def, spec); | |
| if (mod == NULL) { | |
| goto error; | |
| _PyImport_FixupBuiltin(PyThreadState *tstate, PyObject *mod, const char *name, | |
| return -1; | |
| } | |
| - PyModuleDef *def = PyModule_GetDef(mod); | |
| + PyModuleDef *def = _PyModule_GetDefOrNull(mod); | |
| if (def == NULL) { | |
| + assert(!PyErr_Occurred()); | |
| PyErr_BadInternalCall(); | |
| goto finally; | |
| } | |
| create_builtin(PyThreadState *tstate, PyObject *name, PyObject *spec) | |
| assert(!_PyErr_Occurred(tstate)); | |
| assert(cached != NULL); | |
| /* The module might not have md_def set in certain reload cases. */ | |
| - assert(_PyModule_GetDef(mod) == NULL | |
| - || cached->def == _PyModule_GetDef(mod)); | |
| + assert(_PyModule_GetDefOrNull(mod) == NULL | |
| + || cached->def == _PyModule_GetDefOrNull(mod)); | |
| assert_singlephase(cached); | |
| goto finally; | |
| } | |
| _imp_create_dynamic_impl(PyObject *module, PyObject *spec, PyObject *file) | |
| assert(!_PyErr_Occurred(tstate)); | |
| assert(cached != NULL); | |
| /* The module might not have md_def set in certain reload cases. */ | |
| - assert(_PyModule_GetDef(mod) == NULL | |
| - || cached->def == _PyModule_GetDef(mod)); | |
| + assert(_PyModule_GetDefOrNull(mod) == NULL | |
| + || cached->def == _PyModule_GetDefOrNull(mod)); | |
| assert_singlephase(cached); | |
| goto finally; | |
| } | |
| _imp_create_dynamic_impl(PyObject *module, PyObject *spec, PyObject *file) | |
| } | |
| /* We would move this (and the fclose() below) into | |
| - * _PyImport_GetModInitFunc(), but it isn't clear if the intervening | |
| + * _PyImport_GetModuleExportHooks(), but it isn't clear if the intervening | |
| * code relies on fp still being open. */ | |
| FILE *fp; | |
| if (file != NULL) { | |
| _imp_create_dynamic_impl(PyObject *module, PyObject *spec, PyObject *file) | |
| fp = NULL; | |
| } | |
| - PyModInitFunction p0 = _PyImport_GetModInitFunc(&info, fp); | |
| + PyModInitFunction p0 = NULL; | |
| + PyModExportFunction ex0 = NULL; | |
| + _PyImport_GetModuleExportHooks(&info, fp, &p0, &ex0); | |
| + if (ex0) { | |
| + mod = import_run_modexport(tstate, ex0, &info, spec); | |
| + goto cleanup; | |
| + } | |
| if (p0 == NULL) { | |
| goto finally; | |
| } | |
| _imp_create_dynamic_impl(PyObject *module, PyObject *spec, PyObject *file) | |
| } | |
| #endif | |
| +cleanup: | |
| // XXX Shouldn't this happen in the error cases too (i.e. in "finally")? | |
| if (fp) { | |
| fclose(fp); | |
| diff --git a/Python/importdl.c b/Python/importdl.c | |
| index 802843fe7b9..23a55c39677 100644 | |
| --- a/Python/importdl.c | |
| +++ b/Python/importdl.c | |
| #include "pycore_call.h" // _PyObject_CallMethod() | |
| #include "pycore_import.h" // _PyImport_SwapPackageContext() | |
| #include "pycore_importdl.h" | |
| -#include "pycore_moduleobject.h" // _PyModule_GetDef() | |
| +#include "pycore_moduleobject.h" // _PyModule_GetDefOrNull() | |
| #include "pycore_pyerrors.h" // _PyErr_FormatFromCause() | |
| #include "pycore_runtime.h" // _Py_ID() | |
| extern dl_funcptr _PyImport_FindSharedFuncptr(const char *prefix, | |
| /* module info to use when loading */ | |
| /***********************************/ | |
| -static const char * const ascii_only_prefix = "PyInit"; | |
| -static const char * const nonascii_prefix = "PyInitU"; | |
| +static const struct hook_prefixes ascii_only_prefixes = { | |
| + "PyInit", "PyModExport"}; | |
| +static const struct hook_prefixes nonascii_prefixes = { | |
| + "PyInitU", "PyModExportU"}; | |
| /* Get the variable part of a module's export symbol name. | |
| * Returns a bytes instance. For non-ASCII-named modules, the name is | |
| static const char * const nonascii_prefix = "PyInitU"; | |
| * nonascii_prefix, as appropriate. | |
| */ | |
| static PyObject * | |
| -get_encoded_name(PyObject *name, const char **hook_prefix) { | |
| +get_encoded_name(PyObject *name, const struct hook_prefixes **hook_prefixes) { | |
| PyObject *tmp; | |
| PyObject *encoded = NULL; | |
| PyObject *modname = NULL; | |
| get_encoded_name(PyObject *name, const char **hook_prefix) { | |
| /* Encode to ASCII or Punycode, as needed */ | |
| encoded = PyUnicode_AsEncodedString(name, "ascii", NULL); | |
| if (encoded != NULL) { | |
| - *hook_prefix = ascii_only_prefix; | |
| + *hook_prefixes = &ascii_only_prefixes; | |
| } else { | |
| if (PyErr_ExceptionMatches(PyExc_UnicodeEncodeError)) { | |
| PyErr_Clear(); | |
| get_encoded_name(PyObject *name, const char **hook_prefix) { | |
| if (encoded == NULL) { | |
| goto error; | |
| } | |
| - *hook_prefix = nonascii_prefix; | |
| + *hook_prefixes = &nonascii_prefixes; | |
| } else { | |
| goto error; | |
| } | |
| _Py_ext_module_loader_info_init(struct _Py_ext_module_loader_info *p_info, | |
| assert(PyUnicode_GetLength(name) > 0); | |
| info.name = Py_NewRef(name); | |
| - info.name_encoded = get_encoded_name(info.name, &info.hook_prefix); | |
| + info.name_encoded = get_encoded_name(info.name, &info.hook_prefixes); | |
| if (info.name_encoded == NULL) { | |
| _Py_ext_module_loader_info_clear(&info); | |
| return -1; | |
| _Py_ext_module_loader_info_init_for_builtin( | |
| /* We won't need filename. */ | |
| .path=name, | |
| .origin=_Py_ext_module_origin_BUILTIN, | |
| - .hook_prefix=ascii_only_prefix, | |
| + .hook_prefixes=&ascii_only_prefixes, | |
| .newcontext=NULL, | |
| }; | |
| return 0; | |
| _Py_ext_module_loader_result_apply_error( | |
| /********************************************/ | |
| #ifdef HAVE_DYNAMIC_LOADING | |
| -PyModInitFunction | |
| -_PyImport_GetModInitFunc(struct _Py_ext_module_loader_info *info, | |
| - FILE *fp) | |
| +static dl_funcptr | |
| +findfuncptr(const char *prefix, const char *name_buf, | |
| + struct _Py_ext_module_loader_info *info, | |
| + FILE *fp) | |
| { | |
| - const char *name_buf = PyBytes_AS_STRING(info->name_encoded); | |
| - dl_funcptr exportfunc; | |
| #ifdef MS_WINDOWS | |
| - exportfunc = _PyImport_FindSharedFuncptrWindows( | |
| - info->hook_prefix, name_buf, info->filename, fp); | |
| + return _PyImport_FindSharedFuncptrWindows( | |
| + prefix, name_buf, info->filename, fp); | |
| #else | |
| - { | |
| - const char *path_buf = PyBytes_AS_STRING(info->filename_encoded); | |
| - exportfunc = _PyImport_FindSharedFuncptr( | |
| - info->hook_prefix, name_buf, path_buf, fp); | |
| - } | |
| + const char *path_buf = PyBytes_AS_STRING(info->filename_encoded); | |
| + return _PyImport_FindSharedFuncptr( | |
| + prefix, name_buf, path_buf, fp); | |
| #endif | |
| +} | |
| - if (exportfunc == NULL) { | |
| - if (!PyErr_Occurred()) { | |
| - PyObject *msg; | |
| - msg = PyUnicode_FromFormat( | |
| - "dynamic module does not define " | |
| - "module export function (%s_%s)", | |
| - info->hook_prefix, name_buf); | |
| - if (msg != NULL) { | |
| - PyErr_SetImportError(msg, info->name, info->filename); | |
| - Py_DECREF(msg); | |
| - } | |
| - } | |
| - return NULL; | |
| +int | |
| +_PyImport_GetModuleExportHooks( | |
| + struct _Py_ext_module_loader_info *info, | |
| + FILE *fp, | |
| + PyModInitFunction *modinit, | |
| + PyModExportFunction *modexport) | |
| +{ | |
| + *modinit = NULL; | |
| + *modexport = NULL; | |
| + | |
| + const char *name_buf = PyBytes_AS_STRING(info->name_encoded); | |
| + dl_funcptr exportfunc; | |
| + | |
| + exportfunc = findfuncptr( | |
| + info->hook_prefixes->export_prefix, | |
| + name_buf, info, fp); | |
| + if (exportfunc) { | |
| + *modexport = (PyModExportFunction)exportfunc; | |
| + return 2; | |
| + } | |
| + | |
| + exportfunc = findfuncptr( | |
| + info->hook_prefixes->init_prefix, | |
| + name_buf, info, fp); | |
| + if (exportfunc) { | |
| + *modinit = (PyModInitFunction)exportfunc; | |
| + return 1; | |
| } | |
| - return (PyModInitFunction)exportfunc; | |
| + if (!PyErr_Occurred()) { | |
| + PyObject *msg; | |
| + msg = PyUnicode_FromFormat( | |
| + "dynamic module does not define " | |
| + "module export function (%s_%s or %s_%s)", | |
| + info->hook_prefixes->export_prefix, name_buf, | |
| + info->hook_prefixes->init_prefix, name_buf); | |
| + if (msg != NULL) { | |
| + PyErr_SetImportError(msg, info->name, info->filename); | |
| + Py_DECREF(msg); | |
| + } | |
| + } | |
| + return -1; | |
| } | |
| #endif /* HAVE_DYNAMIC_LOADING */ | |
| _PyImport_RunModInitFunc(PyModInitFunction p0, | |
| res.def = (PyModuleDef *)m; | |
| /* Run PyModule_FromDefAndSpec() to finish loading the module. */ | |
| } | |
| - else if (info->hook_prefix == nonascii_prefix) { | |
| + else if (info->hook_prefixes == &nonascii_prefixes) { | |
| /* Non-ASCII is only supported for multi-phase init. */ | |
| res.kind = _Py_ext_module_kind_MULTIPHASE; | |
| /* Don't allow legacy init for non-ASCII module names. */ | |
| _PyImport_RunModInitFunc(PyModInitFunction p0, | |
| goto error; | |
| } | |
| - res.def = _PyModule_GetDef(m); | |
| + res.def = _PyModule_GetDefOrNull(m); | |
| if (res.def == NULL) { | |
| PyErr_Clear(); | |
| _Py_ext_module_loader_result_set_error( | |