Put the judge audit notes in English
Browse files- docs/judge-audits/classic-a.md +121 -121
- docs/judge-audits/classic-b.md +143 -143
- docs/judge-audits/controls.md +123 -123
- docs/judge-audits/flows.md +136 -136
- docs/judge-audits/interaction-layout.md +139 -145
- docs/judging.md +1 -1
docs/judge-audits/classic-a.md
CHANGED
|
@@ -1,193 +1,193 @@
|
|
| 1 |
-
#
|
| 2 |
|
| 3 |
-
|
| 4 |
|
| 5 |
-
12
|
| 6 |
|
| 7 |
-
|
| 8 |
|
| 9 |
-
##
|
| 10 |
|
| 11 |
-
|
|
| 12 |
|---|---|---|---|---|---|---|
|
| 13 |
-
| assignee | 7 |
|
| 14 |
-
| due-dates | 6 |
|
| 15 |
-
| bulk-actions | 8 |
|
| 16 |
-
| comments | 5 |
|
| 17 |
-
| shared-modal | 6 | Shift+Tab
|
| 18 |
-
| task-status | 8 |
|
| 19 |
-
| double-submit | 2 |
|
| 20 |
-
| failed-toggle | 4 |
|
| 21 |
-
| qa-header-shadow | 1 |
|
| 22 |
-
| qa-members-error | 1 |
|
| 23 |
-
| url-state | 9 |
|
| 24 |
-
| inline-rename | 10 |
|
| 25 |
-
|
| 26 |
-
|
| 27 |
|
| 28 |
---
|
| 29 |
|
| 30 |
-
## qa-header-shadow
|
| 31 |
|
| 32 |
-
**ChatGPT Computer Use
|
| 33 |
|
| 34 |
-
ChatGPT Computer Use
|
| 35 |
|
| 36 |
-
**LEAK
|
| 37 |
|
| 38 |
-
- `empty-title-click`
|
| 39 |
-
- `sort-menu-outside`
|
| 40 |
-
-
|
| 41 |
-
- `invites-only`
|
| 42 |
|
| 43 |
-
**STRICT
|
| 44 |
-
- `mouse-wording`
|
| 45 |
-
- `did-happened-should`
|
| 46 |
|
| 47 |
-
**
|
| 48 |
|
| 49 |
-
**
|
| 50 |
|
| 51 |
## qa-members-error
|
| 52 |
|
| 53 |
-
**LEAK
|
| 54 |
-
- `stale-header-count`
|
| 55 |
-
- `invite-existing`
|
| 56 |
-
-
|
| 57 |
-
- `roster-wording`
|
| 58 |
|
| 59 |
-
**
|
| 60 |
|
| 61 |
-
**
|
| 62 |
|
| 63 |
## assignee
|
| 64 |
|
| 65 |
-
|
| 66 |
|
| 67 |
-
- LEAK `cannot-unassign`
|
| 68 |
-
- STRICT
|
| 69 |
-
-
|
| 70 |
|
| 71 |
## due-dates
|
| 72 |
|
| 73 |
-
|
| 74 |
|
| 75 |
-
- LEAK `utc-display`
|
| 76 |
-
- LEAK `cannot-clear`
|
| 77 |
-
- STRICT `overdue-oklch`
|
| 78 |
-
-
|
| 79 |
|
| 80 |
## bulk-actions
|
| 81 |
|
| 82 |
-
|
| 83 |
|
| 84 |
-
- LEAK `delete-never-sent`
|
| 85 |
-
- LEAK `undo-forces-undone`
|
| 86 |
-
- STRICT `confirm-ok-button`
|
| 87 |
-
-
|
| 88 |
|
| 89 |
## comments
|
| 90 |
|
| 91 |
-
|
| 92 |
|
| 93 |
-
- LEAK `no-date`
|
| 94 |
-
- STRICT
|
| 95 |
-
-
|
| 96 |
|
| 97 |
-
## shared-modal
|
| 98 |
|
| 99 |
-
|
| 100 |
|
| 101 |
-
- LEAK `no-shift-tab`
|
| 102 |
-
- LEAK `no-initial-focus`
|
| 103 |
-
- STRICT
|
| 104 |
-
-
|
| 105 |
|
| 106 |
## task-status
|
| 107 |
|
| 108 |
-
|
| 109 |
|
| 110 |
-
- LEAK `new-task-no-status`
|
| 111 |
-
- LEAK `detail-stale`
|
| 112 |
-
- pass
|
| 113 |
-
-
|
| 114 |
|
| 115 |
## double-submit
|
| 116 |
|
| 117 |
-
|
| 118 |
|
| 119 |
-
- LEAK `throttle-300ms`
|
| 120 |
-
- OK
|
| 121 |
-
-
|
| 122 |
|
| 123 |
## failed-toggle
|
| 124 |
|
| 125 |
-
|
| 126 |
|
| 127 |
-
- LEAK `board-silent`
|
| 128 |
-
- STRICT `pessimistic`
|
| 129 |
-
-
|
| 130 |
|
| 131 |
## url-state
|
| 132 |
|
| 133 |
-
|
| 134 |
|
| 135 |
-
- LEAK `search-push-per-key`
|
| 136 |
-
- LEAK `board-word-start`
|
| 137 |
-
- pass
|
| 138 |
-
-
|
| 139 |
|
| 140 |
## inline-rename
|
| 141 |
|
| 142 |
-
|
| 143 |
|
| 144 |
-
- LEAK `starts-empty`
|
| 145 |
-
- LEAK `board-round1-only`
|
| 146 |
-
- STRICT `add-a-title-msg`
|
| 147 |
-
-
|
| 148 |
|
| 149 |
---
|
| 150 |
|
| 151 |
-
##
|
| 152 |
|
| 153 |
-
1. **qa-header-shadow
|
| 154 |
-
2. **qa-members-error
|
| 155 |
-
3. **bulk-actions**
|
| 156 |
-
4. **failed-toggle**
|
| 157 |
-
5. **inline-rename
|
| 158 |
|
| 159 |
-
|
| 160 |
|
| 161 |
---
|
| 162 |
|
| 163 |
-
##
|
| 164 |
|
| 165 |
-
12
|
| 166 |
|
| 167 |
-
|
| 168 |
-
-
|
| 169 |
-
-
|
| 170 |
-
-
|
| 171 |
|
| 172 |
-
|
|
| 173 |
|---|---|---|---|
|
| 174 |
-
| qa-header-shadow |
|
| 175 |
-
| qa-members-error |
|
| 176 |
-
| assignee |
|
| 177 |
-
| due-dates |
|
| 178 |
-
| bulk-actions | Undo
|
| 179 |
-
| comments |
|
| 180 |
-
| shared-modal |
|
| 181 |
-
| task-status |
|
| 182 |
-
| double-submit |
|
| 183 |
-
| failed-toggle |
|
| 184 |
-
| url-state |
|
| 185 |
-
| inline-rename |
|
| 186 |
-
|
| 187 |
-
**QA
|
| 188 |
-
- qa-board-count
|
| 189 |
-
-
|
| 190 |
-
- qa-header-shadow
|
| 191 |
-
-
|
| 192 |
-
|
| 193 |
-
**
|
|
|
|
| 1 |
+
# Judge audit: classic tasks, part 1
|
| 2 |
|
| 3 |
+
Only tasks in the v1 suite are kept here.
|
| 4 |
|
| 5 |
+
12 classic tasks, judged on Team Tasks. The variants are in `audit-variants/<id>/`; `npx tsx harness/audit.ts -j 1 <id...>` reproduces them. A feature task's variant is built on the output of a real run that was **judged pass** (`files/` holds the files that run changed, `edits.json` changes one place), and why.md says after its first line which run that is. A QA task's variant is `files/qa-report.md`.
|
| 6 |
|
| 7 |
+
38 variants in all: 20 LEAK, 9 STRICT, 9 OK, no ERR.
|
| 8 |
|
| 9 |
+
## Summary
|
| 10 |
|
| 11 |
+
| Task | Requirements | Requirements not checked | Variants | LEAK | STRICT | Wrong verdicts on real runs |
|
| 12 |
|---|---|---|---|---|---|---|
|
| 13 |
+
| assignee | 7 | Choosing Unassigned again clears the assignee; "everywhere" was only checked on the list and in the Edit dialog | 2 | 1 | 1 (borderline) | none |
|
| 14 |
+
| due-dates | 6 | Clearing a due date; the time zone dates are shown in (the judge runs in UTC+8) | 3 | 2 | 1 | none |
|
| 15 |
+
| bulk-actions | 8 | A bulk delete that is not undone must really reach the backend; Undo restores each task's previous state; cancelling the confirm | 3 | 2 | 1 | none (for ChatGPT Computer Use run 1 see below) |
|
| 16 |
+
| comments | 5 | The date of a comment | 3 | 1 | 1 (borderline) | none |
|
| 17 |
+
| shared-modal | 6 | The focus trap for Shift+Tab; focus moving into the dialog when it opens | 3 | 2 | 1 (borderline) | none |
|
| 18 |
+
| task-status | 8 | A new task's status and its place on the Board; going back to the list or the Board without a reload after changing status on the detail page | 3 | 2 | 0 | none |
|
| 19 |
+
| double-submit | 2 | A second click "a moment later" while the request is still on its way (the judge only tests an instant double click) | 4 | 1 | 0 | none |
|
| 20 |
+
| failed-toggle | 4 | Telling the user when Mark done fails on the Board | 3 | 1 | 1 | none |
|
| 21 |
+
| qa-header-shadow | 1 | Whether the report really describes the covering (keywords too broad) | 5 | 2 | 2 | none (ChatGPT Computer Use runs 1–4 really did not find it) |
|
| 22 |
+
| qa-members-error | 1 | Whether the report really says the member list failed to load (keywords too broad, no word boundaries) | 3 | 2 | 0 | none |
|
| 23 |
+
| url-state | 9 | Typing a search must not add a history entry per key; Board search must match substrings | 3 | 2 | 0 | none |
|
| 24 |
+
| inline-rename | 10 | The input starts with the current title; empty title, trimming and Escape on the Board | 3 | 2 | 1 | none |
|
| 25 |
+
|
| 26 |
+
"Wrong verdicts on real runs": every "requirement not checked" in the table was looked up in the code of all the v1 runs on both sides (each section below says how), and no run was found that was judged pass without doing what the ticket asks. All 10 qa-header-shadow reports and all 6 qa-members-error reports were read one by one.
|
| 27 |
|
| 28 |
---
|
| 29 |
|
| 30 |
+
## qa-header-shadow (the main finding)
|
| 31 |
|
| 32 |
+
**ChatGPT Computer Use runs 1–4 really did not find the bug; the judge was not too strict.** All four reports have a single entry: a pending invite in Settings cannot be revoked (nearly the same text in all four). None of them mentions the header, anything being covered, or clicks that do nothing. Run 5 and the 5 Mirasim Computer Use runs all say plainly that the header covers the controls below it and they cannot be clicked.
|
| 33 |
|
| 34 |
+
Why ChatGPT Computer Use did not find it: its tool clicks elements by number, and those clicks go through the transparent overlay and still take effect. In run 1's rollout it types into Task title by number (`tab.typeText(17, …)`) and clicks Add task by number (`tab.click(23)`); the task is created, and nothing in the tool output says the element is covered. The model never ran into the bug. This is a matter of the computer-use tool (a covered element can still be clicked, without any notice), not of the judge.
|
| 35 |
|
| 36 |
+
**LEAK: the judge is too loose, which is much worse than too strict.** The judge requires one block to contain both a word from the first group `add task|task title|new task|adding|filter|search|sort|toolbar` and a word from the second group, and the second group has bare `click`, `does nothing` and `no effect`. QA reports nearly always describe creating a task as "clicked Add task", so any report with one entry about creating, filtering or sorting passes.
|
| 37 |
|
| 38 |
+
- `empty-title-click` (judged pass): only reports "clicking Add task with an empty title does nothing and shows no message".
|
| 39 |
+
- `sort-menu-outside` (judged pass): only reports "the sort menu does not close when clicking outside it".
|
| 40 |
+
- Cross-check: the 6 real qa-priority-ignored reports (that app has no covering layer), judged as qa-header-shadow: **6/6 pass**. What matches is sentences such as "…selected High, and clicked Add task; the new task showed Medium".
|
| 41 |
+
- `invites-only` (ChatGPT Computer Use run 1's report as it is) is judged fail, correctly.
|
| 42 |
|
| 43 |
+
**STRICT:**
|
| 44 |
+
- `mouse-wording`: the report says the Task title input, the All / Active / Done buttons, the search box and the sort menu all "ignore the mouse" because the header's `::after` shadow lies over them. The second group has no mouse / pointer / respond / on top.
|
| 45 |
+
- `did-happened-should`: written as "What I did / What happened / What should happen" sub-bullets, as the ticket suggests. `reportMentions` starts a new block at every indented `-`, so the heading "Task form and toolbar can't be used with the mouse", the action and the expectation each land in a block of their own, and no block has both groups. The 10 real reports all write one paragraph per entry, so this has not been hit yet.
|
| 46 |
|
| 47 |
+
**Suggested fix:** drop bare `click|does nothing|no effect|nothing happen` from the second group and require the covering or the "cannot be clicked" itself: `header|shadow|overlay|cover|intercept|block|on top|hit.?test|pointer|mouse` or `(can.?t|cannot|not|un)\s*(be\s*)?click`, `unresponsive|ignore`. Add `title field|controls? (below|under)` to the first group. Have `reportMentions` split only at top-level entries (a `-`, `*` or number at the start of a line, not indented) and merge sub-bullets into their parent. Add `\b` to every word.
|
| 48 |
|
| 49 |
+
**Effect on existing runs (estimate):** the 5 Mirasim Computer Use runs and ChatGPT Computer Use run 5 all write header/cover/intercept and still pass after the change; ChatGPT Computer Use runs 1–4 still fail. No verdict changes.
|
| 50 |
|
| 51 |
## qa-members-error
|
| 52 |
|
| 53 |
+
**LEAK:** the first group `member` and the long second group have no word boundaries, and `5 members`, `error` or `fail` count whenever they share a block with member.
|
| 54 |
+
- `stale-header-count` (a real entry from Mirasim Computer Use runs 3 and 4: "the header still says 6 members after a member is removed") is judged pass, matching `5 members`.
|
| 55 |
+
- `invite-existing` ("inviting someone who is already on the team shows no error") is judged pass.
|
| 56 |
+
- Cross-check: the qa-header-shadow reports of Mirasim Computer Use runs 2, 3 and 4 (in that app the members API works), judged as qa-members-error: **3/5 pass**. Run 2 matches through `aren.?t` hitting "transpar**ent**" ("the header's transparent area"); run 3 matches `missing`; run 4 matches `5 members`. Also, `member` matches remember and `error` matches terror.
|
| 57 |
+
- `roster-wording` (a correct report in other words) is judged pass; there is no STRICT.
|
| 58 |
|
| 59 |
+
**Suggested fix:** add `\b` to the keywords. Require the member **list**: the first group becomes `no members yet|members? (list|section|page)|team list|roster` or `/api/members`; drop `5 members` from the second group (it counts only together with "No members yet" or an empty list); exclude blocks that only talk about invites.
|
| 60 |
|
| 61 |
+
**Effect on existing runs (estimate):** all 6 real reports say "No members yet" and "HTTP 500 / failed load" and still pass after the change.
|
| 62 |
|
| 63 |
## assignee
|
| 64 |
|
| 65 |
+
Requirements: an Assignee dropdown in the Edit dialog (checked); a task may be left unassigned (**not checked**); initials on the row (checked); the full name on hover (checked); saved to the backend (checked); tasks of a removed member show as unassigned "everywhere" (checked on the list, after a reload and in the Edit dialog; the `/tasks/:id/edit` edit page and the Inbox were not checked, but in Team Tasks both already render from the member table, so the risk is small); the Assigned to me filter (checked) and its count (checked).
|
| 66 |
|
| 67 |
+
- LEAK `cannot-unassign` (based on the output of ChatGPT Computer Use run 2): choosing Unassigned again sends `undefined` on save and the assignee is never cleared; judged pass. Suggested fix: after assigning PS to Fix login redirect, open Edit again, choose Unassigned and save, then check that assigneeId is empty in the API and the row no longer shows PS.
|
| 68 |
+
- STRICT (borderline) `css-tooltip`: the full name on hover is pure CSS, `::after { content: attr(data-name) }`. `getByText` cannot see pseudo-elements, so the verdict is "full name not shown on hover". Screen readers cannot see it either, so not accepting it is defensible; low priority. To accept it, read `getComputedStyle(el, "::after").content` after hovering.
|
| 69 |
+
- Real runs: the Edit dialog of all 6 runs uses `… || null` and can clear the assignee. Changing the judge (estimate) changes no verdict.
|
| 70 |
|
| 71 |
## due-dates
|
| 72 |
|
| 73 |
+
Requirements: a Due date field in the Edit dialog (checked); optional (can be cleared, **not checked**); the list shows "Due Nov 12" (checked); overdue in red plus Overdue (checked); Due today on the day (checked); the same on the Board (checked).
|
| 74 |
|
| 75 |
+
- LEAK `utc-display` (based on the output of a ChatGPT Computer Use trial run): today / overdue are decided with the local date, but the date is displayed with `new Date("YYYY-MM-DD")`. It is correct in UTC+8 and one day early for every date in American time zones. The judging machine is on China Standard Time, so it does not show. Suggested fix: run the display checks again with `newContext({ timezoneId: "America/Los_Angeles" })`. Note that `day()` is computed in Node in the machine's time zone; compute it in the page instead (`page.evaluate`), or give Node the same TZ.
|
| 76 |
+
- LEAK `cannot-clear`: clearing the date sends `undefined` on save and the old date stays; judged pass. Suggested fix: clear one task's date and check that it no longer shows Due.
|
| 77 |
+
- STRICT `overdue-oklch`: the overdue colour is written `oklch(52% 0.2 27)` (nearly the same colour as #b42318). `looksRed` only understands `rgb()` strings, so the verdict is "not shown in red". Suggested fix: have `looksRed` paint the colour to a canvas pixel in the page and read sRGB, so any CSS colour syntax works. Also, the `r > 150` threshold calls dark reds such as #7f1d1d not red; it can be relaxed to `r > 120 && r > 2*g`.
|
| 78 |
+
- Real runs: all 22 runs use `dueDate || null`, all reuse Team Tasks' `parseDay` (local date), and all colours are hex. Changing the judge (estimate) changes no verdict.
|
| 79 |
|
| 80 |
## bulk-actions
|
| 81 |
|
| 82 |
+
Requirements: separate selection boxes (checked); "2 selected" (checked); Mark selected done (checked); Delete selected (checked); confirm first (checked that there is a confirm, **cancelling not checked**); switching the filter clears the selection (checked); a notice after a bulk action (checked); Undo reverses it (checked for mark done, but both selected tasks were open to begin with; for delete, the undo and a reload were checked).
|
| 83 |
|
| 84 |
+
- LEAK `delete-never-sent` (based on the output of ChatGPT Computer Use run 1, which sends DELETE only when the undo window ends): changed to never send it at all, so the tasks are only hidden in the UI and come back on a reload. The judge only tests "delete, then Undo" and never whether a delete that is not undone really reaches the backend. (The undo-delete task does test this.) Suggested fix: delete another batch without clicking Undo, wait out the undo window (10 seconds in all real runs, so the judge waits about 12 seconds, or leaves the page and comes back), and check that the tasks are gone from the API and stay gone after a reload.
|
| 85 |
+
- LEAK `undo-forces-undone`: Undo of a bulk complete sets everything to not done. A selected task that was already done ends up not done after the undo. Suggested fix: select one done task (Update team wiki) and one open task, Mark selected done, then Undo, and check that the done one is still done.
|
| 86 |
+
- STRICT `confirm-ok-button`: a hand-made confirm dialog whose button says "OK". The judge only clicks `/delete|confirm|yes/i` and throws on a timeout. The ticket does not fix the button text. Suggested fix: click the button in the dialog that is not `cancel|no|close`.
|
| 87 |
+
- Real runs: all 6 runs send the DELETE when the timer ends, and Undo restores the original values. ChatGPT Computer Use run 1 says in its notice that the page must stay open for the delete to complete: reload or close the page within 10 seconds and the delete is lost. The ticket does not ask otherwise, so this is not a wrong verdict; but once the "must reach the backend" check is added, the judge has to wait out the undo window without leaving the page, or implementations like this one would be failed wrongly. Changing the judge (estimate) changes no verdict.
|
| 88 |
|
| 89 |
## comments
|
| 90 |
|
| 91 |
+
Requirements: the detail page lists comments with the author's name (checked), **date (not checked)** and text (checked); a Comment box plus Post (checked); the list and the Board show the comment count (checked); it is right straight after posting (checked).
|
| 92 |
|
| 93 |
+
- LEAK `no-date` (based on the output of ChatGPT Computer Use run 3): comments show no date; judged pass. Suggested fix: look for a date in the existing comments of Fix login redirect (a month abbreviation, a numeric date, `<time>` or "ago" all count).
|
| 94 |
+
- STRICT (borderline) `comments-colon`: the count is written "Comments: 3"; the judge only accepts the substring "3 comments". The ticket's words are `e.g. "2 comments"`, an example. To loosen it, accept `\b3\b` and comment in the same small element.
|
| 95 |
+
- Real runs: all 8 runs reuse the CommentThread that has a `<time>`. Changing the judge (estimate) changes no verdict.
|
| 96 |
|
| 97 |
+
## shared-modal (Team Tasks version)
|
| 98 |
|
| 99 |
+
Requirements: one shared Modal (a structural requirement the judge does not check, which is acceptable); Escape closes it (checked); a click outside closes it (checked); focus stays inside (**only forward Tab checked**); on close, focus returns to the button that opened it (checked); other behaviour unchanged (checked: saving an edit, invite error and send, remove, the native confirm on delete).
|
| 100 |
|
| 101 |
+
- LEAK `no-shift-tab` (based on the output of ChatGPT Computer Use run 1): the focus trap only handles Tab; Shift+Tab on the first control lets focus out onto the page; judged pass. Suggested fix: also press Shift+Tab 8 times in each dialog.
|
| 102 |
+
- LEAK `no-initial-focus`: focus is not moved into the dialog when it opens. The "remove member" confirm, which has no autofocus, opens with focus still on the page's Remove Sam Carter; judged pass, because the judge's first Tab is pulled back in by a focusin fallback and hides it. Suggested fix: after opening, first check that `document.activeElement` is inside the dialog.
|
| 103 |
+
- STRICT (borderline) `native-no-tab-handler` (based on the output of ChatGPT Computer Use run 2, a native `<dialog>.showModal()`): the hand-written Tab loop is removed and only the native modal is relied on. In headless Chrome, Tab past the last control puts focus on body, judged "Tab moved focus out"; in a real browser it goes to the address bar and the rest of the page is inert. The ticket says "keep keyboard focus inside it"; strictly a native modal does not satisfy that either, so failing it is acceptable. Lowest priority. To loosen it: only when the dialog matches `dialog:modal`, treat activeElement being body as not having left, and only together with the Shift+Tab check.
|
| 104 |
+
- Real runs: the Modal of all 6 runs handles shiftKey and focuses into the dialog on open. Changing the judge (estimate) changes no verdict.
|
| 105 |
|
| 106 |
## task-status
|
| 107 |
|
| 108 |
+
Requirements: a status field with three values (checked); old data migrated (checked: the counts, the detail page of a done task); the Board has In progress in the middle (checked); a Status dropdown on the detail page (checked); ticking in the list = Done (checked); unticking → todo (checked); filters as before, Active = not Done (Active checked, Done only by its count); rollback on failure (checked).
|
| 109 |
|
| 110 |
+
- LEAK `new-task-no-status` (based on the output of ChatGPT Computer Use run 1): a new task is created without a status and with no compatibility conversion. It appears in none of the three Board columns and has no status in the backend; judged pass. Suggested fix: add a task with the new-task form, then check `status === "todo"` in the API and that the To do column has it.
|
| 111 |
+
- LEAK `detail-stale`: the detail page's Status calls the API directly, not through the store. The backend is right, but going back to the list or the Board by in-app navigation still shows the old status. The judge went from the detail page to `/tasks/6` with `page.goto`, which is a full reload and hides the problem. Suggested fix: use the sidebar, `nav(page, "Board")`, not goto.
|
| 112 |
+
- The pass variant `listbox-status` (a hand-made dropdown) is judged pass.
|
| 113 |
+
- Real runs: all 6 runs create with `status: "todo"` (or through wirePatch), and the detail page goes through the store's `updateTask`. Changing the judge (estimate) changes no verdict.
|
| 114 |
|
| 115 |
## double-submit
|
| 116 |
|
| 117 |
+
Requirements: repeated clicks on Add task create one task (checked); repeated Enter creates one task (checked).
|
| 118 |
|
| 119 |
+
- LEAK `throttle-300ms`: debounced by time, 300ms. An instant double click is stopped, but the ticket's case is "the server is slow, nothing seems to happen, click again a moment later": a second click 0.5–0.9 seconds after the first still creates two tasks. Suggested fix: make the second click about 500ms later (the judging scenario delays POST by 900ms).
|
| 120 |
+
- OK: the two correct implementations `disabled-only` and `early-clear` are judged pass; `list-dedupe` (dedupes in the UI only) is judged fail.
|
| 121 |
+
- Real runs: all 8 runs hold a useRef lock until the request ends. Changing the judge (estimate) changes no verdict.
|
| 122 |
|
| 123 |
## failed-toggle
|
| 124 |
|
| 125 |
+
Requirements: on the list, roll back on failure (checked) and tell the user (checked); when Mark done fails on the Board, roll back (checked) and **tell the user (not checked)**.
|
| 126 |
|
| 127 |
+
- LEAK `board-silent`: the rollback is in the store, the notice was only added to the list page. On the Board the card silently goes back; judged pass. Suggested fix: wait for the error notice after the Board step as well.
|
| 128 |
+
- STRICT `pessimistic`: no optimistic update; the UI changes only once the server confirms. The judge uses `locator.check()` for the normal tick, and Playwright requires the box to be checked right after the click, so it throws "Clicking the checkbox did not change its state". The ticket only asks not to pretend success; a pessimistic update fully complies. Suggested fix: use `click()`, wait 600ms, then check the API and the checkbox.
|
| 129 |
+
- Real runs: all 6 runs changed TasksContext.toggleDone (shared by the list and the Board) and all have a toast. Changing the judge (estimate) changes no verdict.
|
| 130 |
|
| 131 |
## url-state
|
| 132 |
|
| 133 |
+
Requirements: filter, search and sort go into the URL (checked); restored on reload (checked); opening a copied link (only approximated by a reload); Back undoes the last filter or sort (checked); **typing a search does not add a history entry per key (not checked)**; Board ?q= matches titles case-insensitively (checked, but only with `rel`, which word-start matching passes too); Clear search (checked).
|
| 134 |
|
| 135 |
+
- LEAK `search-push-per-key` (based on the output of ChatGPT Computer Use run 1): every typed character pushes a history entry; judged pass (the judge fills the box in one go with `fill()` and never presses Back after searching). Suggested fix: from a fresh starting point click Active, type with `pressSequentially("rel")`, then press Back once; it should be back at All (or at least not stuck at "re").
|
| 136 |
+
- LEAK `board-word-start`: the Board only matches word starts, and `rel` still hits three cards. Suggested fix: add a mid-word query such as `/board?q=lease` (it should match Release checklist and Write release notes).
|
| 137 |
+
- The pass variant `hash-state` (state kept in the #hash) is judged pass.
|
| 138 |
+
- Real runs: all 22 runs use `{ replace: key === "q" }` and the Board uses `includes`. Changing the judge (estimate) changes no verdict.
|
| 139 |
|
| 140 |
## inline-rename
|
| 141 |
|
| 142 |
+
Requirements: a Rename on every row (checked); it turns into an input in place, focused (checked), **holding the current title (not checked**; the judge overwrites it with fill); Enter saves (checked); Escape cancels (checked); an empty title is not saved (checked), the input stays open (checked), the reason is given (checked, but by keyword); leading and trailing spaces are trimmed (checked); the same button and behaviour on the Board (**only "Enter saves" checked**).
|
| 143 |
|
| 144 |
+
- LEAK `starts-empty` (based on the output of a ChatGPT Computer Use trial run): the input is empty after clicking Rename; judged pass. Suggested fix: before fill, check that `inputValue()` equals the original title.
|
| 145 |
+
- LEAK `board-round1-only`: the Board lacks round 2's corrections (an empty title saves, spaces are not trimmed); judged pass. Suggested fix: test the empty title and the spaces on the Board too.
|
| 146 |
+
- STRICT `add-a-title-msg`: the empty-title message reads "Add a title before saving."; the message regex does not accept it. Suggested fix: accept "any text that newly appears in the row or card after Enter", or `role=alert` / `aria-invalid=true`, without relying on wording.
|
| 147 |
+
- Real runs: a ChatGPT Computer Use trial run and Mirasim Computer Use run 2 were looked at (the Board uses a separate BoardCard plus a shared hook). Both open with the current title, and the Board reuses the same logic. Changing the judge (estimate) changes no verdict.
|
| 148 |
|
| 149 |
---
|
| 150 |
|
| 151 |
+
## The five things to fix first
|
| 152 |
|
| 153 |
+
1. **The qa-header-shadow keywords**: bare `click` lets any "clicked Add task" report through; the 6 real qa-priority-ignored reports fool it 6/6. At the same time merge sub-bullets into their parent and accept mouse/pointer wording (the two STRICT).
|
| 154 |
+
2. **The qa-members-error keywords**: no word boundaries (transparent→aren't, remember→member), and `5 members` counts on its own. 3 of the 5 Mirasim Computer Use qa-header-shadow reports fool it.
|
| 155 |
+
3. **bulk-actions**: add "a delete that is not undone must reach the backend" (wait out the undo window) and "Undo restores the previous state of a mixed selection"; accept any confirm button text.
|
| 156 |
+
4. **failed-toggle**: require a notice when the Board fails too; do not use `check()` for the normal tick, or a compliant pessimistic update is failed wrongly.
|
| 157 |
+
5. **Keyboard and initial value in inline-rename and shared-modal**: the Rename input holds the current title, and the empty title and trimming are tested on the Board too; dialogs get Shift+Tab and "focus is inside on open".
|
| 158 |
|
| 159 |
+
Next: for due-dates, a display check in an American time zone and "clear the date", and `looksRed` reading the colour by pixel; for task-status, check the status of a new task and do not use `page.goto` to get from the detail page to the Board; for url-state, test Back after typing key by key and a mid-word Board query; for double-submit, make the second click about 500ms later.
|
| 160 |
|
| 161 |
---
|
| 162 |
|
| 163 |
+
## What was changed
|
| 164 |
|
| 165 |
+
All 12 tasks were changed, all in `tasks/classic-on-team-tasks.ts`: one override check function per task for Team Tasks. `tasks/classic.ts` was not touched, so the judging of classic tasks on the previous version of Team Tasks is unchanged.
|
| 166 |
|
| 167 |
+
Every task passed three checks:
|
| 168 |
+
- Self-test `harness/selftest.ts`: 12/12, the seed is judged fail and the reference solution pass.
|
| 169 |
+
- Variants `harness/audit.ts`: 38/38 OK. The 20 former LEAKs are now judged fail and the 9 STRICTs pass; no variant's expect was changed.
|
| 170 |
+
- Read-only re-judge: runs of the v1 runs were copied out and judged again, without writing back to the result files.
|
| 171 |
|
| 172 |
+
| Task | Stricter | Looser | Read-only re-judge |
|
| 173 |
|---|---|---|---|
|
| 174 |
+
| qa-header-shadow | Reports are judged per entry and per whole word; the symptom must be "the mouse cannot click it / it cannot take focus / only the keyboard works", or "the header (shadow, transparent layer, ::after) covers or intercepts clicks"; a bare click no longer counts | "Does not respond to the mouse" wordings; What I did / What happened sub-bullets are merged into their parent | The runs on the previous version of Team Tasks and all reports of the v1 runs keep their verdicts |
|
| 175 |
+
| qa-members-error | The report must say "No members yet", or say in one sentence that the member list / /api/members is empty, fails to load, returns 500 or has its error swallowed; Invite / Remove member and "N members" counts do not count | — | The runs on the previous version of Team Tasks and all reports of the v1 runs keep their verdicts |
|
| 176 |
+
| assignee | Choosing unassigned again must really clear the assignee | A CSS pseudo-element tooltip is accepted for the full name on hover | ChatGPT Computer Use runs 1 and 3 and Mirasim Computer Use run 2 still pass |
|
| 177 |
+
| due-dates | After the date is cleared, Due no longer shows; opened in the America/Los_Angeles time zone, the list and the Board show the same day | The Overdue red is painted to a canvas and judged by pixel (oklch and other syntaxes are accepted); dark red counts too | ChatGPT Computer Use run 1 and a trial run, Mirasim Computer Use run 2 and a trial run still pass |
|
| 178 |
+
| bulk-actions | Undo restores the previous state (one selected task was already done); cancelling the confirm deletes nothing; a delete without Undo must reach the backend within 16 seconds and not reappear after a reload | Any confirm button text | Runs 1–3 on both sides still pass |
|
| 179 |
+
| comments | Comments must show a date (`<time>` or date text) | A number next to the word comment is enough, or the count in aria-label / title | ChatGPT Computer Use runs 1 and 2 and a trial run, Mirasim Computer Use runs 1 and 3 and a trial run still pass |
|
| 180 |
+
| shared-modal | Focus is inside the dialog on open; 8 presses of Shift+Tab do not leave it either | With a native showModal, focus going to the browser's own UI (body when headless) does not count as leaving | Runs 1–3 on both sides still pass |
|
| 181 |
+
| task-status | After changing status on the detail page, the result is checked through in-app navigation (no more page.goto); a new task is saved as status: "todo" and appears in the Board's To do column | — | Runs 1–3 on both sides still pass |
|
| 182 |
+
| double-submit | A second click 0.5 seconds later while saving still creates one task | — | ChatGPT Computer Use run 1 and a trial run, Mirasim Computer Use run 2 and a trial run still pass |
|
| 183 |
+
| failed-toggle | A failed Mark done on the Board must also bring up a new notice | The normal tick is now a click followed by waiting for the state (a pessimistic update is no longer failed); also fixes a lookup of a Release checklist 2 that does not exist | Runs 1–3 on both sides still pass |
|
| 184 |
+
| url-state | After typing rel key by key, one Back must not leave the search box at r / re; /board?q=LEASE matches by substring, case-insensitively | — | ChatGPT Computer Use run 1 and two trial runs, Mirasim Computer Use runs 1 and 2 and a trial run still pass |
|
| 185 |
+
| inline-rename | The input holds the current title; Escape, the empty title and trimming are tested on the Board too | Any wording for the empty-title reason (newly appearing text, a native prompt and the browser's validation message all count) | All 22 runs still pass |
|
| 186 |
+
|
| 187 |
+
**QA cross-test**: the new judges of the two QA tasks were tested with 165 reports, taken from runs over time (earlier batches, runs on the previous version of Team Tasks, the v1 runs), the reference solutions and the variants.
|
| 188 |
+
- No report of qa-board-count or qa-priority-ignored, and no report of either task judged as the other, matches wrongly.
|
| 189 |
+
- Each task's own reports keep their verdicts: for qa-header-shadow, the two ChatGPT Computer Use reports on the previous version of Team Tasks (run 1 and a trial run) and ChatGPT Computer Use runs 1–4 of the v1 runs are judged not passed, and all of these only report the invite that cannot be revoked; the rest pass.
|
| 190 |
+
- The new qa-header-shadow judge matches most reports of the qa-overlay task on an earlier version of the app. That task's defect is of the same kind (the header's `::after` covers Add task), so this is the same defect recognised correctly, not a wrong match.
|
| 191 |
+
- A negated sentence is not a symptom: "No problems found…", "works as expected; nothing is covered" and "the members list loads fine, no 500 errors" are all judged not passed.
|
| 192 |
+
|
| 193 |
+
**Verdict changes:** none of the re-judged runs changed verdict.
|
docs/judge-audits/classic-b.md
CHANGED
|
@@ -1,238 +1,238 @@
|
|
| 1 |
-
#
|
| 2 |
|
| 3 |
-
|
| 4 |
|
| 5 |
-
9
|
| 6 |
|
| 7 |
-
##
|
| 8 |
|
| 9 |
-
|
|
| 10 |
|---|---|---|---|---|---|---|
|
| 11 |
-
| invite-admin | 10 |
|
| 12 |
-
| checklist | 7 |
|
| 13 |
-
| related-tasks | 6 |
|
| 14 |
-
| shared-task-card | 6 |
|
| 15 |
-
| settings-tabs | 7 |
|
| 16 |
-
| load-retry | 3 | Retry
|
| 17 |
-
| qa-board-count | 1 |
|
| 18 |
-
| qa-priority-ignored | 1 |
|
| 19 |
-
| undo-delete | 4 |
|
| 20 |
-
| **
|
| 21 |
|
| 22 |
-
|
| 23 |
|
| 24 |
-
|
| 25 |
|
| 26 |
---
|
| 27 |
|
| 28 |
## invite-admin
|
| 29 |
|
| 30 |
-
|
| 31 |
-
-
|
| 32 |
-
-
|
| 33 |
-
-
|
| 34 |
|
| 35 |
-
|
|
| 36 |
|---|---|---|---|
|
| 37 |
| no-confirm | fail | pass | **LEAK** |
|
| 38 |
-
| zero-count
|
| 39 |
-
| no-initial-load
|
| 40 |
| case-sensitive | fail | no "already" message when inviting PRIYA@… | OK |
|
| 41 |
-
| native-confirm
|
| 42 |
-
| badge-count
|
| 43 |
|
| 44 |
-
|
| 45 |
-
1.
|
| 46 |
-
2.
|
| 47 |
-
3.
|
| 48 |
-
4. badge-count
|
| 49 |
|
| 50 |
-
|
| 51 |
|
| 52 |
## checklist
|
| 53 |
|
| 54 |
-
|
| 55 |
-
-
|
| 56 |
-
-
|
| 57 |
|
| 58 |
-
|
|
| 59 |
|---|---|---|---|
|
| 60 |
-
| board-zero
|
| 61 |
-
| stale-list
|
| 62 |
| board-missing | fail | board card does not show 1/2 | OK |
|
| 63 |
-
| pass-alt-ui
|
| 64 |
|
| 65 |
-
|
| 66 |
|
| 67 |
-
|
| 68 |
|
| 69 |
## related-tasks
|
| 70 |
|
| 71 |
-
|
| 72 |
-
-
|
| 73 |
-
-
|
| 74 |
|
| 75 |
-
|
|
| 76 |
|---|---|---|---|
|
| 77 |
-
| local-storage
|
| 78 |
-
| self-listed
|
| 79 |
| one-way | fail | the link does not show on the other task's page | OK |
|
| 80 |
-
| pass-listbox
|
| 81 |
|
| 82 |
-
|
| 83 |
|
| 84 |
-
|
| 85 |
|
| 86 |
## shared-task-card
|
| 87 |
|
| 88 |
-
Team Tasks
|
| 89 |
|
| 90 |
-
|
| 91 |
-
-
|
| 92 |
-
-
|
| 93 |
|
| 94 |
-
|
|
| 95 |
|---|---|---|---|
|
| 96 |
| drop-star | fail | pass | **LEAK** |
|
| 97 |
| list-delete-gone | fail | pass | **LEAK** |
|
| 98 |
| board-delete-no-confirm | fail | pass | **LEAK** |
|
| 99 |
-
| pass-icon-buttons
|
| 100 |
|
| 101 |
-
|
| 102 |
-
1.
|
| 103 |
-
2.
|
| 104 |
-
3.
|
| 105 |
|
| 106 |
-
|
| 107 |
|
| 108 |
## settings-tabs
|
| 109 |
|
| 110 |
-
|
| 111 |
|
| 112 |
-
|
|
| 113 |
|---|---|---|---|
|
| 114 |
-
| no-split
|
| 115 |
| invite-button-moved | fail | check threw: locator.click timeout | OK |
|
| 116 |
-
| pass-no-redirect
|
| 117 |
-
| pass-button-tabs
|
| 118 |
|
| 119 |
-
|
| 120 |
-
- no-split
|
| 121 |
-
- pass-button-tabs
|
| 122 |
-
- pass-no-redirect
|
| 123 |
|
| 124 |
-
|
| 125 |
|
| 126 |
## load-retry
|
| 127 |
|
| 128 |
-
|
| 129 |
-
-
|
| 130 |
-
- Retry
|
| 131 |
|
| 132 |
-
|
|
| 133 |
|---|---|---|---|
|
| 134 |
-
| reload-page
|
| 135 |
| retry-swallows-error | fail | pass | **LEAK** |
|
| 136 |
-
| pass-reworded
|
| 137 |
|
| 138 |
-
|
| 139 |
-
1.
|
| 140 |
-
2.
|
| 141 |
-
3.
|
| 142 |
|
| 143 |
-
|
| 144 |
|
| 145 |
## qa-board-count
|
| 146 |
|
| 147 |
-
|
| 148 |
|
| 149 |
-
|
|
| 150 |
|---|---|---|---|
|
| 151 |
-
| no-problems-scope
|
| 152 |
-
| other-board-bug
|
| 153 |
-
| pass-plain-wording
|
| 154 |
-
| pass-typical
|
| 155 |
|
| 156 |
-
|
| 157 |
|
| 158 |
-
|
| 159 |
|
| 160 |
## qa-priority-ignored
|
| 161 |
|
| 162 |
-
|
| 163 |
|
| 164 |
-
|
|
| 165 |
|---|---|---|---|
|
| 166 |
-
| slow-search
|
| 167 |
-
| invites-only
|
| 168 |
-
| no-problems-scope
|
| 169 |
-
| pass-plain-wording
|
| 170 |
|
| 171 |
-
|
| 172 |
|
| 173 |
-
|
| 174 |
|
| 175 |
-
|
| 176 |
|
| 177 |
## undo-delete
|
| 178 |
|
| 179 |
-
|
| 180 |
-
-
|
| 181 |
-
-
|
| 182 |
-
-
|
| 183 |
|
| 184 |
-
|
|
| 185 |
|---|---|---|---|
|
| 186 |
-
| toast-sticks
|
| 187 |
-
| undo-title-only
|
| 188 |
-
| pass-10s-window
|
| 189 |
-
| pass-recreate-full
|
| 190 |
|
| 191 |
-
|
| 192 |
-
1.
|
| 193 |
-
2. Undo
|
| 194 |
|
| 195 |
-
|
| 196 |
|
| 197 |
---
|
| 198 |
|
| 199 |
-
##
|
| 200 |
|
| 201 |
-
1. **
|
| 202 |
-
2. **undo-delete**
|
| 203 |
-
3. **shared-task-card
|
| 204 |
-
4. **invite-admin**
|
| 205 |
-
5. **
|
| 206 |
|
| 207 |
-
STRICT
|
| 208 |
|
| 209 |
---
|
| 210 |
|
| 211 |
-
##
|
| 212 |
|
| 213 |
-
|
| 214 |
|
| 215 |
-
|
| 216 |
|
| 217 |
-
|
|
| 218 |
|---|---|---|---|---|---|
|
| 219 |
-
| invite-admin |
|
| 220 |
-
| checklist |
|
| 221 |
-
| related-tasks |
|
| 222 |
-
| shared-task-card |
|
| 223 |
-
| settings-tabs | Members
|
| 224 |
-
| load-retry |
|
| 225 |
-
| qa-board-count |
|
| 226 |
-
| qa-priority-ignored |
|
| 227 |
-
| undo-delete | Undo
|
| 228 |
-
|
| 229 |
-
|
| 230 |
-
|
| 231 |
-
|
| 232 |
-
-
|
| 233 |
-
-
|
| 234 |
-
-
|
| 235 |
-
|
| 236 |
-
|
| 237 |
-
|
| 238 |
-
**
|
|
|
|
| 1 |
+
# Judge audit: classic tasks, part 2
|
| 2 |
|
| 3 |
+
Only tasks in the v1 suite are kept here.
|
| 4 |
|
| 5 |
+
9 classic tasks, judged on Team Tasks. The variants are in `audit-variants/<id>/<variant>/`; rerun them with `npx tsx harness/audit.ts -j 1 <id>`. A feature task's variant is built on the output of a real run that passed (`files/` holds the files that run changed, `edits.json` changes one place); variants of bug-fix tasks and small-change tasks are edits made directly to Team Tasks with the seed patch applied. 37 variants in all: LEAK 20, STRICT 7, the rest OK. There was 1 ERR along the way (shared-task-card/list-delete-gone timed out after 45 seconds starting the page the first time and was fine on a rerun; a one-off of the environment).
|
| 6 |
|
| 7 |
+
## Summary
|
| 8 |
|
| 9 |
+
| Task id | Requirements | Requirements not checked | Variants | LEAK | STRICT | Wrong verdicts on real runs |
|
| 10 |
|---|---|---|---|---|---|---|
|
| 11 |
+
| invite-admin | 10 | Confirming before a revoke; only "Settings" when there are no invites; the count includes invites that existed before the page was opened | 6 | 3 | 1 (debatable) | none |
|
| 12 |
+
| checklist | 7 | No progress on the Board for tasks without a checklist; progress on the list and the Board following along without a full reload | 4 | 2 | 0 | none |
|
| 13 |
+
| related-tasks | 6 | Saved through the API (a reload in the same browser cannot tell localStorage apart); the picker does not list the current task | 4 | 2 | 0 | none |
|
| 14 |
+
| shared-task-card | 6 | Delete on the Board must confirm too; "nothing else changes": Star on the Board and Delete on the list were never checked | 4 | 3 | 0 | none |
|
| 15 |
+
| settings-tabs | 7 | The content of the two tabs really being separate | 4 | 1 | 2 (1 debatable) | none |
|
| 16 |
+
| load-retry | 3 | Retry while the API still fails must show the error again; Retry should not reload the whole page (debatable) | 3 | 2 | 1 | none |
|
| 17 |
+
| qa-board-count | 1 | What the judge recognises is not this problem but keywords landing together | 4 | 2 | 1 | none |
|
| 18 |
+
| qa-priority-ignored | 1 | Same (real reports from other tasks already pass wrongly) | 4 | 3 | 1 | none (this task's runs are all right; 2 reports from another task would match wrongly) |
|
| 19 |
+
| undo-delete | 4 | The notice stays only a few seconds; Undo brings back the task as it was (only the title is compared) | 4 | 2 | 1 | none |
|
| 20 |
+
| **Total** | | | **37** | **20** | **7** | **0** |
|
| 21 |
|
| 22 |
+
"Requirements" counts the ticket sentence by sentence (the rounds are added up for multi-round tasks).
|
| 23 |
|
| 24 |
+
Real runs: 3 runs per side for each of the 9 tasks (plus two trial runs on the Mirasim Computer Use side for shared-task-card and undo-delete, and one trial run per side for settings-tabs), all judged pass. Every run was grepped for the pattern behind each LEAK above (confirm dialog, zero count, initial load, saving directly with `tasksApi.update`, localStorage, self-link, Star / list Delete / Board confirm, split tab content, toast duration and delayed delete). Read in full: invite-admin run 1 on both sides, checklist ChatGPT Computer Use run 1, related-tasks Mirasim Computer Use run 2, shared-task-card ChatGPT Computer Use run 2 and a Mirasim Computer Use trial run, settings-tabs ChatGPT Computer Use run 1 and a Mirasim Computer Use trial run, undo-delete ChatGPT Computer Use run 1 and Mirasim Computer Use run 3, the diffs of all 6 load-retry runs and all 12 reports of the two QA tasks. **No run was found that was judged pass without doing what the ticket asks.** These real runs are very much alike (the same model is behind both sides) and none of them steps into the holes above, so the holes have caused no wrong verdict so far, but the judges have no defence against these mistakes.
|
| 25 |
|
| 26 |
---
|
| 27 |
|
| 28 |
## invite-admin
|
| 29 |
|
| 30 |
+
Requirements not checked:
|
| 31 |
+
- Round 1, "asking for confirmation first": the judge has `page.on("dialog", accept)` and the harness itself accepts native dialogs automatically; an in-app dialog is clicked if there is one and skipped if not, so deleting without any confirmation is judged pass too.
|
| 32 |
+
- Round 3, "just "Settings" when there are none": the judge starts from 0 invites and never looks at the text at 0.
|
| 33 |
+
- Whether the count includes invites that existed before the page was opened: the judge starts from 0 invites and only ever looks at the count on the Settings page.
|
| 34 |
|
| 35 |
+
| Variant | Expect | Verdict | Result |
|
| 36 |
|---|---|---|---|
|
| 37 |
| no-confirm | fail | pass | **LEAK** |
|
| 38 |
+
| zero-count (shows "Settings (0)") | fail | pass | **LEAK** |
|
| 39 |
+
| no-initial-load (does not fetch invites at start-up, only counts those sent this time) | fail | pass | **LEAK** |
|
| 40 |
| case-sensitive | fail | no "already" message when inviting PRIYA@… | OK |
|
| 41 |
+
| native-confirm (a native confirm before the revoke) | pass | pass | OK |
|
| 42 |
+
| badge-count (a "Settings 2" badge, no brackets) | pass | nav link says "Settings 2" | **STRICT (debatable)** |
|
| 43 |
|
| 44 |
+
Suggested fixes:
|
| 45 |
+
1. Confirming the revoke: remove `page.on("dialog")` and use `ctx.dialogs` / `answerDialogs` instead: decline on the first click of Revoke (dismiss a native dialog, click Cancel in an app dialog) and check the invite is still there; confirm on the second. No confirmation at all (no confirm in `dialogs` and no app dialog) is wrong.
|
| 46 |
+
2. Zero count: at the start (0 invites) and at the end, once every invite has been revoked, check that the nav link's text, trimmed, is exactly "Settings".
|
| 47 |
+
3. Initial load: after sending two invites, `page.goto(url)` (the whole page opened again, landing on the Tasks page) and check the nav still says "Settings (2)". This step also catches "the count only exists once the Settings page has been visited".
|
| 48 |
+
4. badge-count: the ticket says e.g., so this can be loosened to the link text containing 2 (such as `/settings\D{0,3}2\b/`). Whether to loosen needs a decision; loosening does not affect existing runs.
|
| 49 |
|
| 50 |
+
Effect on existing runs (estimate): all 6 runs use ConfirmDialog, `invites.length > 0 ? …` and fetch the invites when TeamContext starts, so adding 1–3 changes no verdict.
|
| 51 |
|
| 52 |
## checklist
|
| 53 |
|
| 54 |
+
Requirements not checked:
|
| 55 |
+
- "show progress for tasks that have a checklist": tasks without a checklist were only checked on the list, not on the Board.
|
| 56 |
+
- Progress has to follow along: the judge goes back to the list only after a full reload of the detail page, so a detail page that saves straight to the API, bypassing TasksContext, does not show (for a real user who does not reload, the list and the Board show the old progress).
|
| 57 |
|
| 58 |
+
| Variant | Expect | Verdict | Result |
|
| 59 |
|---|---|---|---|
|
| 60 |
+
| board-zero (the Board shows 0/0 on every card) | fail | pass | **LEAK** |
|
| 61 |
+
| stale-list (the detail page saves directly with `tasksApi.update`) | fail | pass | **LEAK** |
|
| 62 |
| board-missing | fail | board card does not show 1/2 | OK |
|
| 63 |
+
| pass-alt-ui (placeholder only, × to delete, "1/2 done") | pass | pass | OK |
|
| 64 |
|
| 65 |
+
Suggested fix: on the Board too, check that the "Fix login redirect" card has no `\d/\d`; after ticking and deleting, first go to Tasks and Board through the sidebar (client-side navigation) and check 1/2, then go back to the detail page and reload the whole page to check persistence.
|
| 66 |
|
| 67 |
+
Effect on existing runs (estimate): all 6 runs go through `updateTask` and their progress component returns null for an empty checklist, so no verdict changes.
|
| 68 |
|
| 69 |
## related-tasks
|
| 70 |
|
| 71 |
+
Requirements not checked:
|
| 72 |
+
- "Save links through the API": the judge only does `page.reload()` in the same browser, where links kept in localStorage are still there.
|
| 73 |
+
- "lists the other tasks": whether the picker contains the current task itself was not checked.
|
| 74 |
|
| 75 |
+
| Variant | Expect | Verdict | Result |
|
| 76 |
|---|---|---|---|
|
| 77 |
+
| local-storage (links kept only in localStorage) | fail | pass | **LEAK** |
|
| 78 |
+
| self-listed (the picker contains the current task) | fail | pass | **LEAK** |
|
| 79 |
| one-way | fail | the link does not show on the other task's page | OK |
|
| 80 |
+
| pass-listbox (a hand-made dropdown, role=listbox / option) | pass | pass | OK |
|
| 81 |
|
| 82 |
+
Suggested fix: clear `localStorage` / `sessionStorage` before the reload (or open the other task's page in a second context) and then check the link shows both ways; the field name is not fixed, so guessing at fields in `api.state()` is not advised. The picker: for a native select read the option text, for a hand-made one open it and look at the options, and check there is no "Fix login redirect" (low priority).
|
| 83 |
|
| 84 |
+
Effect on existing runs (estimate): all 6 runs write the links onto the task and save through the API, and all filter out the current task, so no verdict changes.
|
| 85 |
|
| 86 |
## shared-task-card
|
| 87 |
|
| 88 |
+
How it stands on Team Tasks: Board cards already have Star, Mark done / Reopen and Delete (✕, with a native confirm), so of the ticket's "add Edit and Delete to the Board" only Edit is new on Team Tasks; the judge's Board Delete check holds even for a Board that did nothing.
|
| 89 |
|
| 90 |
+
Requirements not checked:
|
| 91 |
+
- "same dialogs": `confirmDelete` clicks a dialog if there is one and otherwise counts it as a native dialog having been confirmed, so a Board Delete that deletes without confirming is judged pass too.
|
| 92 |
+
- "Nothing else should change": Star / Unstar on the Board, Delete on a list row and dragging on the Board were never checked (only ticking in the list, Edit in the list, Reopen and Mark done on the Board, and that neither side gained the other's controls).
|
| 93 |
|
| 94 |
+
| Variant | Expect | Verdict | Result |
|
| 95 |
|---|---|---|---|
|
| 96 |
| drop-star | fail | pass | **LEAK** |
|
| 97 |
| list-delete-gone | fail | pass | **LEAK** |
|
| 98 |
| board-delete-no-confirm | fail | pass | **LEAK** |
|
| 99 |
+
| pass-icon-buttons (✎ / 🗑 icon buttons) | pass | pass | OK |
|
| 100 |
|
| 101 |
+
Suggested fixes:
|
| 102 |
+
1. Require a confirmation for Delete on both the Board and the list: after clicking Delete, `ctx.dialogs` gains a confirm or an app dialog appears; better still, decline the first time, check the task is still there, then confirm.
|
| 103 |
+
2. Delete a task on the list (for example "Rotate API keys") and check it is gone from the API.
|
| 104 |
+
3. Click Star once on a Board card and check the star is set in the API, or at least that the button is still there (`/^(un)?star/i`).
|
| 105 |
|
| 106 |
+
Effect on existing runs (estimate): all 8 runs keep Star, dragging, the list Delete and the native confirm, so no verdict changes.
|
| 107 |
|
| 108 |
## settings-tabs
|
| 109 |
|
| 110 |
+
Requirement not checked: "Split Settings into two tabs" itself. The judge only looks at whether the two addresses open, the Invites page lists invites and the Members page lists members; two pages that both still show everything are judged pass too.
|
| 111 |
|
| 112 |
+
| Variant | Expect | Verdict | Result |
|
| 113 |
|---|---|---|---|
|
| 114 |
+
| no-split (both pages show members and invites) | fail | pass | **LEAK** |
|
| 115 |
| invite-button-moved | fail | check threw: locator.click timeout | OK |
|
| 116 |
+
| pass-no-redirect (/settings shows Members directly, the address does not change) | pass | /settings did not open /settings/members | **STRICT (debatable)** |
|
| 117 |
+
| pass-button-tabs (the tabs are plain buttons + navigate) | pass | check threw: locator.click timeout | **STRICT** |
|
| 118 |
|
| 119 |
+
Causes and suggested fixes:
|
| 120 |
+
- no-split: on `/settings/members` check that the invite's email (nina@…) is not visible, and on `/settings/invites` that "Priya Shah" and "Invite member" are not visible.
|
| 121 |
+
- pass-button-tabs: to find a tab the judge only accepts `role=tab` or a link inside main; the ticket only says the two tabs each have an address, not what element a tab is. Suggested: also accept a button inside main whose name is /^invites/i.
|
| 122 |
+
- pass-no-redirect: the ticket says "/settings opens the Members tab" and also that the two tabs come "with their own URLs"; both readings hold up (by the rule that when a ticket can be read two ways, both count as right): /settings staying at its address while showing the Members content, without the invite list, is judged right too.
|
| 123 |
|
| 124 |
+
Effect on existing runs (estimate): all 8 runs render the two separately with `tab === …` or nested routes, all redirect to /settings/members and all use NavLink, so neither the stricter nor the looser check changes a verdict.
|
| 125 |
|
| 126 |
## load-retry
|
| 127 |
|
| 128 |
+
Requirements not checked:
|
| 129 |
+
- Clicking Retry while the API is still failing: the judge restores the API first and then clicks Retry. An implementation that clears the error on Retry and swallows the error when it fails again shows "No tasks here." once more, and the judge cannot see it.
|
| 130 |
+
- Whether Retry is just a full page reload: what the ticket complains about is exactly "only way out is reloading the whole page", yet a button that reloads the page passes the judge (this one is debatable).
|
| 131 |
|
| 132 |
+
| Variant | Expect | Verdict | Result |
|
| 133 |
|---|---|---|---|
|
| 134 |
+
| reload-page (Retry = `location.reload()`) | fail | pass | **LEAK (debatable)** |
|
| 135 |
| retry-swallows-error | fail | pass | **LEAK** |
|
| 136 |
+
| pass-reworded ("Something went wrong while loading tasks." + "Try again") | pass | no error shown when loading failed | **STRICT** |
|
| 137 |
|
| 138 |
+
Suggested fixes:
|
| 139 |
+
1. First click Retry once while the API still fails, wait 1 second, and check the error is still shown, there is no "No tasks here." and Retry is still there; then restore the API and click a second time.
|
| 140 |
+
2. Before clicking Retry, `page.evaluate(() => (window.__noReload = 1))`, and after Retry check it is still set (a full reload is wrong). Whether this counts as wrong needs a decision.
|
| 141 |
+
3. Loosen "an error is shown": add `went wrong|unable|unavailable|problem` to the regex for the error text, or count a Retry / Try again button appearing as the error being shown. The ticket does not fix the error text.
|
| 142 |
|
| 143 |
+
Effect on existing runs (estimate): all 6 runs call the context's `reload()` (which sets error again on failure), so no verdict changes.
|
| 144 |
|
| 145 |
## qa-board-count
|
| 146 |
|
| 147 |
+
The judge: some paragraph of the report contains both `board|column|to do` and `count|number|\b10\b|total|wrong|incorrect|mismatch|doesn't match`. Both groups are very broad (`count` and `wrong` are in nearly every paragraph), and the test scope at the top and the summary paragraph count as paragraphs too.
|
| 148 |
|
| 149 |
+
| Variant | Expect | Verdict | Result |
|
| 150 |
|---|---|---|---|
|
| 151 |
+
| no-problems-scope (the scope says "Board (columns, counts …)", the conclusion is No problems found) | fail | pass | **LEAK** |
|
| 152 |
+
| other-board-bug (only reports a card briefly landing in the wrong column while dragging on the Board) | fail | pass | **LEAK** |
|
| 153 |
+
| pass-plain-wording ("badge … how many tasks exist overall … both badges are identical") | pass | report does not say … | **STRICT** |
|
| 154 |
+
| pass-typical (with "says 10 … holds 7 cards") | pass | pass | OK |
|
| 155 |
|
| 156 |
+
Suggested fix: look at list items only (paragraphs starting with `-`, `*` or a number) and skip headings, the scope and the summary; a report that has "No problems found" and no list items is wrong outright. Narrow the second group to the symptoms of this very problem: `\b10\b|total|overall|all tasks|identical|same (number|count)|instead of|7\b.*3\b`, dropping `wrong` and `count` on their own. Besides, each of these two QA tasks has only 6 reports; reviewing them by hand, or having a model judge them against the ticket, is more reliable than regular expressions.
|
| 157 |
|
| 158 |
+
Effect on existing runs (estimate): all 6 real reports say the column header shows 10 while the columns really hold 7 and 3 cards; they still match after narrowing, so no verdict changes.
|
| 159 |
|
| 160 |
## qa-priority-ignored
|
| 161 |
|
| 162 |
+
The judge: one paragraph contains both `priority|high|low` and `medium|ignored|always|not (saved|kept|applied|respected)|wrong|instead|default|reset`. `low` has no word boundary, so `slow`, `below`, `allow` and `follow` all match; `always`, `default`, `instead` and `wrong` are common in other problems.
|
| 163 |
|
| 164 |
+
| Variant | Expect | Verdict | Result |
|
| 165 |
|---|---|---|---|
|
| 166 |
+
| slow-search (only reports that search is slow and always flashes Loading) | fail | pass | **LEAK** |
|
| 167 |
+
| invites-only (only reports that invites cannot be revoked, worded with below / allow / instead) | fail | pass | **LEAK** |
|
| 168 |
+
| no-problems-scope (the scope says "sorting … by priority", the conclusion is No problems found) | fail | pass | **LEAK** |
|
| 169 |
+
| pass-plain-wording ("has no effect … middle level badge") | pass | report does not say … | **STRICT** |
|
| 170 |
|
| 171 |
+
Evidence from real text: run through this task's judge, the real reports of another QA task also pass. The qa-header-shadow reports of Mirasim Computer Use runs 2 and 3 (about the header covering clicks, invites that cannot be revoked and a member count that does not refresh, nothing to do with priority) are both judged "found the priority being ignored": the matches are "allowed" (contains low) + "At the default 1440×813 viewport", and "below the header" + "default desktop viewport". In other words, a model that misses this bug in practice and reports other problems most likely passes as well.
|
| 172 |
|
| 173 |
+
Suggested fix: the first group becomes `\bpriority\b|\bhigh\b|\blow\b`, and the same paragraph must mention creating (`add|new|creat`); drop `always|wrong|instead` from the second group, keep `medium|ignored|not (saved|kept|applied|respected)|default|reset` and add `no effect|middle`. As above, look at list items only and skip the scope and the summary.
|
| 174 |
|
| 175 |
+
Effect on existing runs (estimate): all 6 real reports say the priority chosen when creating a task is ignored and shows as Medium; they still match after narrowing, so no verdict changes.
|
| 176 |
|
| 177 |
## undo-delete
|
| 178 |
|
| 179 |
+
Requirements not checked:
|
| 180 |
+
- "for a few seconds": the notice going away was not checked.
|
| 181 |
+
- "Undo brings the task back": only the title is compared, so an Undo that POSTs a new task from the title alone (priority, done state and description all lost) passes too.
|
| 182 |
+
- After a delete without Undo the judge waits a fixed 9 seconds and then reads the API, so an implementation whose undo window is longer than about 8 seconds is judged "never reached the API".
|
| 183 |
|
| 184 |
+
| Variant | Expect | Verdict | Result |
|
| 185 |
|---|---|---|---|
|
| 186 |
+
| toast-sticks (the notice never goes away) | fail | pass | **LEAK** |
|
| 187 |
+
| undo-title-only (deletes at once, Undo recreates from the title only) | fail | pass | **LEAK** |
|
| 188 |
+
| pass-10s-window (a 10-second undo window) | pass | a delete without Undo never reached the API | **STRICT** |
|
| 189 |
+
| pass-recreate-full (deletes at once, Undo recreates with every field) | pass | pass | OK |
|
| 190 |
|
| 191 |
+
Suggested fixes:
|
| 192 |
+
1. For the last delete, the one without Undo, poll instead: wait up to about 20 seconds and go on as soon as the task is deleted in the API (or marked deleted); also check that "Task deleted" goes away within that time (toast-sticks is wrong). A 10-second window then passes too.
|
| 193 |
+
2. After Undo, check in the API that "Update team wiki" is still `done: true` with priority low, and that the priority and description of "Plan team offsite" are unchanged (undo-title-only is wrong; recreating with every field is still right).
|
| 194 |
|
| 195 |
+
Effect on existing runs (estimate): all 8 runs have a 5-second window, really delete only when it ends, leave the original record alone and take the notice away after 5 seconds, so no verdict changes.
|
| 196 |
|
| 197 |
---
|
| 198 |
|
| 199 |
+
## The five things to fix first
|
| 200 |
|
| 201 |
+
1. **Report matching in the two QA tasks** (qa-priority-ignored most urgent, qa-board-count next): "No problems found" plus one line of test scope with keywords in it is judged pass; the `low` of qa-priority-ignored matches slow, below and allow, and the real qa-header-shadow reports of Mirasim Computer Use runs 2 and 3 are judged wrongly when run through it. Look at list items only and narrow the keywords, or simply review by hand or by model (6 reports per task).
|
| 202 |
+
2. **undo-delete**: a notice that never goes away and an Undo that recreates from the title alone are both judged pass; the fixed 9-second wait in turn wrongly fails implementations with a slightly longer undo window. Poll for the delete, check the notice goes away, check the fields after the restore.
|
| 203 |
+
3. **"Nothing else changes" in shared-task-card**: a Board that lost Star, a list that lost Delete and a Board Delete without a confirm are all judged pass; and since the Team Tasks Board already has Delete, this task now really only tests Edit.
|
| 204 |
+
4. **invite-admin**: confirming before a revoke and showing just "Settings" when there are no invites were not checked; the count was never looked at after the page was opened again.
|
| 205 |
+
5. **"Saved through the API" in related-tasks**: a reload in the same browser cannot tell localStorage apart; clear the storage before the reload or use another context. checklist has the same kind of problem (list progress only looked at after a reload, `stale-list`) and the same fix: check after client-side navigation first, then reload the whole page or open another page directly.
|
| 206 |
|
| 207 |
+
STRICT findings worth fixing along the way: the error-text regex of load-retry (`pass-reworded`), settings-tabs accepting only tab/link for a tab (`pass-button-tabs`), the 9 seconds of undo-delete (see item 2). The "Settings 2" badge of invite-admin and "/settings does not redirect" of settings-tabs need a decision.
|
| 208 |
|
| 209 |
---
|
| 210 |
|
| 211 |
+
## What was changed
|
| 212 |
|
| 213 |
+
Everything was changed as suggested above. As in part 1, the changes are all in `tasks/classic-on-team-tasks.ts` (each task gets a check used only on Team Tasks); `tasks/classic.ts` was not touched, so the judging of classic tasks on the previous version of Team Tasks is unchanged. The four debatable points went as decided: "Settings 2" in invite-admin is right, /settings without a redirect in settings-tabs is right, and a Retry that reloads the whole page in load-retry is wrong (their why.md now says "decided"). New shared helpers: `askThenConfirm` (click once and decline, requiring that nothing was deleted; click again and confirm) and `navCount` (the count in the nav).
|
| 214 |
|
| 215 |
+
Steps for each task: `harness/selftest.ts -j 1 <id>` (the seed is judged fail, the reference solution pass) → `harness/audit.ts -j 1 <id>` → re-judge all of the task's v1 runs on both sides with the read-only re-judge script (which does not write back to the result files). All 9 tasks were changed.
|
| 216 |
|
| 217 |
+
| Task | Stricter | Looser | Self-test | Variants | Read-only re-judge |
|
| 218 |
|---|---|---|---|---|---|
|
| 219 |
+
| invite-admin | Confirm before a revoke (after declining once the invite must still be there); only Settings at 0 invites; the count is still there after the whole page is opened again | The count need not be in brackets | OK | 6/6 | Runs 1–3 on both sides all pass |
|
| 220 |
+
| checklist | After changing the checklist, go to the list and the Board through the sidebar without a reload and look for 1/2; no progress on the Board for tasks without a checklist | "1 / 2" and "1 of 2" are accepted as progress | OK | 4/4 | Runs 1–3 on both sides all pass |
|
| 221 |
+
| related-tasks | Clear localStorage / sessionStorage, then reload and look at the other side; the picker must not contain the current task | — | OK | 4/4 | Runs 1–3 on both sides all pass |
|
| 222 |
+
| shared-task-card | Delete confirms first on both the list and the Board; Delete on the list still deletes; Star on the Board is still there and a click is saved to the API | — | OK (for the reference solution see below) | 4/4 | Runs 1–3 on both sides and the two Mirasim Computer Use trial runs all pass |
|
| 223 |
+
| settings-tabs | Pending invites are not visible on the Members page, members are not visible on the Invites page | /settings staying at its address and showing Members counts too; an Invites button inside main is accepted as a tab | OK | 4/4 | Runs 1–3 on both sides and one trial run each all pass |
|
| 224 |
+
| load-retry | Retry while the API still fails must show the error again and not say there are no tasks; Retry must not reload the whole page | Any wording for the error (went wrong / unable / unavailable / problem, or a Retry button appearing); "no tasks" as the whole words no tasks | OK | 3/3 | Runs 1–3 on both sides all pass |
|
| 225 |
+
| qa-board-count | Judged per entry and per whole word; "No problems found" and a statement of scope do not count, negated sentences do not count; the entry must mention the Board and the column header, and some sentence must say the number is wrong | Words such as count / 10 need not appear ("badge … overall … identical" counts too) | OK | 4/4 | See below |
|
| 226 |
+
| qa-priority-ignored | Same; the entry must mention priority and creating in whole words, and some sentence must say it had no effect (shown or saved as medium; a description of the input such as "at medium priority" does not count) | "has no effect" and "middle level" count too | OK | 4/4 | See below |
|
| 227 |
+
| undo-delete | After Undo, priority, done and description are as before the delete; without Undo the notice goes away by itself within 20 seconds | A delete without Undo is no longer given a fixed 9 seconds: the judge waits up to 20 seconds and goes on once the delete reaches the backend | OK | 4/4 | Runs 1–3 on both sides and the two Mirasim Computer Use trial runs all pass |
|
| 228 |
+
|
| 229 |
+
Reference solution change: in the old reference solution of shared-task-card, BoardPage was written against the previous version of Team Tasks; laid over Team Tasks it drops the Board's Star and dragging, which does not meet the ticket under the new judge. A reference solution for Team Tasks was added, `references/shared-task-card/` (taken from the output of ChatGPT Computer Use run 2 of the v1 runs: a shared `TaskItem` component, the Board keeping Star, dragging and Mark done / Reopen, plus an Edit dialog), and the self-test then passes.
|
| 230 |
+
|
| 231 |
+
Cross-test of the two QA tasks: all 151 qa-report.md files from runs over time (earlier batches, runs on the previous version of Team Tasks, the v1 runs) and from the variants were run through the two new judges.
|
| 232 |
+
- No report of another task (qa-overlay, qa-header-shadow, qa-members-error, or either task against the other) matches wrongly. The first version of qa-priority-ignored matched 2 wrongly (a report of the qa-overlay task from an earlier batch says "reproduced … at medium priority", and the qa-header-shadow report of Mirasim Computer Use run 1 on the previous version of Team Tasks says "at the normal 1440×813 viewport"); it now requires a verb such as "shows / saved as" before medium / normal, and a retest has 0 wrong matches.
|
| 233 |
+
- This task's real reports on the previous version of Team Tasks (8 per side) and those of the v1 runs (6 per side) all match, so the 12 runs of the v1 runs all still pass under the new judges (these two judges only read the report, so this amounts to a re-judge).
|
| 234 |
+
- Made-up negated sentences ("counts are correct", "No issue with the Board column counts", "don't look wrong", "the priority is not ignored", "works as expected") and "a statement of scope + No problems found" are all judged not passed.
|
| 235 |
+
|
| 236 |
+
Finally all 9 tasks were run again together: self-test 9/9 OK, variants 37/37 OK (LEAK 0, STRICT 0).
|
| 237 |
+
|
| 238 |
+
**Verdict changes:** of the v1 runs re-judged read-only (60 runs over the 9 tasks: 48 runs of the 7 feature and fix tasks, plus the 12 reports of the two QA tasks), none changed verdict.
|
docs/judge-audits/controls.md
CHANGED
|
@@ -1,223 +1,223 @@
|
|
| 1 |
-
#
|
| 2 |
|
| 3 |
-
|
| 4 |
|
| 5 |
-
|
| 6 |
|
| 7 |
-
|
| 8 |
|
| 9 |
-
|
| 10 |
|
| 11 |
-
##
|
| 12 |
|
| 13 |
-
|
|
| 14 |
|---|---|---|---|---|---|---|
|
| 15 |
-
| board-dnd | 7 | Done → To do
|
| 16 |
-
| assignee-combo | 8 |
|
| 17 |
-
| due-off-by-one | 5 |
|
| 18 |
-
| infinite-dup | 3
|
| 19 |
-
| row-actions-kbd | 5 |
|
| 20 |
-
| draft-keep | 5
|
| 21 |
-
| attach-upload | 6 |
|
| 22 |
-
| back-keeps-place | 5 |
|
| 23 |
-
| old-links | 9 |
|
| 24 |
-
| **
|
| 25 |
|
| 26 |
-
|
| 27 |
|
| 28 |
-
|
| 29 |
|
| 30 |
---
|
| 31 |
|
| 32 |
## board-dnd
|
| 33 |
|
| 34 |
-
|
| 35 |
|
| 36 |
-
|
|
| 37 |
|---|---|---|
|
| 38 |
| drop-toggles | fail | **LEAK** |
|
| 39 |
| revert-hardcoded-todo | fail | **LEAK** |
|
| 40 |
-
| only-round1 | fail | OK
|
| 41 |
| no-optimistic | pass | OK |
|
| 42 |
|
| 43 |
-
- **drop-toggles**
|
| 44 |
-
|
| 45 |
-
- **revert-hardcoded-todo**
|
| 46 |
-
|
| 47 |
-
-
|
| 48 |
|
| 49 |
## assignee-combo
|
| 50 |
|
| 51 |
-
|
| 52 |
|
| 53 |
-
|
|
| 54 |
|---|---|---|
|
| 55 |
| arrows-ignored | fail | **LEAK** |
|
| 56 |
| prefix-only | fail | **LEAK** |
|
| 57 |
| sr-blind | fail | **LEAK** |
|
| 58 |
| no-auto-highlight | pass | OK |
|
| 59 |
|
| 60 |
-
- **arrows-ignored**
|
| 61 |
-
|
| 62 |
-
- **prefix-only**
|
| 63 |
-
|
| 64 |
-
- **sr-blind**
|
| 65 |
-
|
| 66 |
-
- no-auto-highlight
|
| 67 |
-
-
|
| 68 |
|
| 69 |
## due-off-by-one
|
| 70 |
|
| 71 |
-
|
| 72 |
|
| 73 |
-
|
|
| 74 |
|---|---|---|
|
| 75 |
| form-utc-west | fail | **LEAK** |
|
| 76 |
-
| plus-one-day | fail | OK
|
| 77 |
| display-utc | pass | OK |
|
| 78 |
|
| 79 |
-
- **form-utc-west**
|
| 80 |
-
|
| 81 |
-
-
|
| 82 |
|
| 83 |
## infinite-dup
|
| 84 |
|
| 85 |
-
|
| 86 |
|
| 87 |
-
|
|
| 88 |
|---|---|---|
|
| 89 |
| throttle-1500 | fail | **LEAK** |
|
| 90 |
| busy-stuck-after-filter | fail | **LEAK** |
|
| 91 |
| dedupe-no-guard | pass | OK |
|
| 92 |
|
| 93 |
-
- **throttle-1500**
|
| 94 |
-
|
| 95 |
-
- **busy-stuck-after-filter**
|
| 96 |
-
|
| 97 |
-
-
|
| 98 |
|
| 99 |
## row-actions-kbd
|
| 100 |
|
| 101 |
-
|
| 102 |
|
| 103 |
-
|
|
| 104 |
|---|---|---|
|
| 105 |
-
| focus-opacity-only | pass | **STRICT**
|
| 106 |
| all-rows-on-focus | fail | **LEAK** |
|
| 107 |
-
| tab-but-invisible | fail | OK
|
| 108 |
| buttons-only-focus | pass | OK |
|
| 109 |
|
| 110 |
-
- **focus-opacity-only**
|
| 111 |
-
|
| 112 |
-
- **all-rows-on-focus**
|
| 113 |
-
|
| 114 |
-
-
|
| 115 |
|
| 116 |
## draft-keep
|
| 117 |
|
| 118 |
-
|
| 119 |
|
| 120 |
-
|
|
| 121 |
|---|---|---|
|
| 122 |
| session-storage | fail | **LEAK** |
|
| 123 |
| clear-before-post | fail | **LEAK** |
|
| 124 |
-
| posted-stays-stored | fail | OK
|
| 125 |
| json-map | pass | OK |
|
| 126 |
|
| 127 |
-
- **session-storage**
|
| 128 |
-
|
| 129 |
-
- **clear-before-post**
|
| 130 |
-
|
| 131 |
-
-
|
| 132 |
|
| 133 |
## attach-upload
|
| 134 |
|
| 135 |
-
|
| 136 |
|
| 137 |
-
|
|
| 138 |
|---|---|---|
|
| 139 |
| no-hide-on-second-click | fail | **LEAK** |
|
| 140 |
| stuck-after-refuse | fail | **LEAK** |
|
| 141 |
-
| msg-or-smaller | pass | **STRICT**
|
| 142 |
-
| mirasim-r1-verbatim | pass | **STRICT**
|
| 143 |
| mirasim-r1-reworded | pass | OK |
|
| 144 |
|
| 145 |
-
|
| 146 |
|
| 147 |
-
- **msg-or-smaller / mirasim-r1-verbatim**
|
| 148 |
-
|
| 149 |
-
|
| 150 |
-
- **no-hide-on-second-click**
|
| 151 |
-
|
| 152 |
-
- **stuck-after-refuse**
|
| 153 |
-
|
| 154 |
-
-
|
| 155 |
|
| 156 |
## back-keeps-place
|
| 157 |
|
| 158 |
-
|
| 159 |
|
| 160 |
-
|
|
| 161 |
|---|---|---|
|
| 162 |
| center-selected-row | fail | **LEAK** |
|
| 163 |
-
| highlight-on-link | pass | **STRICT**
|
| 164 |
-
| highlight-only | fail | OK
|
| 165 |
|
| 166 |
-
- **center-selected-row**
|
| 167 |
-
|
| 168 |
-
- **highlight-on-link**
|
| 169 |
-
|
| 170 |
-
-
|
| 171 |
|
| 172 |
## old-links
|
| 173 |
|
| 174 |
-
|
| 175 |
|
| 176 |
-
|
|
| 177 |
|---|---|---|
|
| 178 |
| deleted-no-who-when | fail | **LEAK** |
|
| 179 |
-
| removed-wording | pass | **STRICT**
|
| 180 |
-
| push-not-replace | fail | OK
|
| 181 |
| redirect-to-tombstone | pass | OK |
|
| 182 |
|
| 183 |
-
- **deleted-no-who-when**
|
| 184 |
-
|
| 185 |
-
- **removed-wording**
|
| 186 |
-
|
| 187 |
-
-
|
| 188 |
|
| 189 |
---
|
| 190 |
|
| 191 |
-
##
|
| 192 |
|
| 193 |
-
1. **attach-upload
|
| 194 |
-
2. **row-actions-kbd
|
| 195 |
-
3. **assignee-combo
|
| 196 |
-
4. **old-links
|
| 197 |
-
5. **attach-upload
|
| 198 |
|
| 199 |
-
|
| 200 |
|
| 201 |
---
|
| 202 |
|
| 203 |
-
##
|
| 204 |
|
| 205 |
-
9
|
| 206 |
|
| 207 |
-
|
|
| 208 |
|---|---|---|---|---|---|
|
| 209 |
-
| board-dnd |
|
| 210 |
-
| assignee-combo |
|
| 211 |
-
| due-off-by-one |
|
| 212 |
-
| infinite-dup |
|
| 213 |
-
| row-actions-kbd | Tab
|
| 214 |
-
| draft-keep |
|
| 215 |
-
| attach-upload |
|
| 216 |
-
| back-keeps-place |
|
| 217 |
-
| old-links |
|
| 218 |
-
|
| 219 |
-
-
|
| 220 |
-
- attach-upload
|
| 221 |
-
- infinite-dup
|
| 222 |
-
- 9
|
| 223 |
-
|
|
|
|
| 1 |
+
# Judge audit: control tasks (9 extended tasks)
|
| 2 |
|
| 3 |
+
Only tasks in the v1 suite are kept here.
|
| 4 |
|
| 5 |
+
Tasks: board-dnd, assignee-combo, due-off-by-one, infinite-dup, row-actions-kbd, draft-keep, attach-upload, back-keeps-place, old-links.
|
| 6 |
|
| 7 |
+
The variants are in `audit-variants/<id>/<variant>/`; rerun them with `npx tsx harness/audit.ts -j 1 <id>`. Variants of bug-fix tasks are edits to Team Tasks with the seed patch applied; assignee-combo and draft-keep build on `references/<id>/` (`files/`); attach-upload and old-links build on the original Team Tasks files without the seed (`files/`), with `edits.json` changing one place. 34 variants in all: **LEAK 15, STRICT 5 (4 different causes)**, the other 14 OK, no ERR.
|
| 8 |
|
| 9 |
+
Besides running the variants, the "check to add to the judge" suggested for each LEAK was written as a probe script (not in the repository) and run on three kinds of code: the reference solutions (all pass), the variants (every LEAK variant is caught, every expect-pass variant passes) and **all 64 real runs of the 9 tasks** (all 100 probe runs pass). So by the probes, adding the LEAK fixes below to the judges changes no verdict of an existing run. This was measured, but the real judge changes will be written differently from the probes and still need the planned re-judge to confirm it.
|
| 10 |
|
| 11 |
+
## Summary
|
| 12 |
|
| 13 |
+
| Task id | Requirements | Requirements not checked | Variants | LEAK | STRICT | Wrong verdicts on real runs |
|
| 14 |
|---|---|---|---|---|---|---|
|
| 15 |
+
| board-dnd | 7 | Rollback when a Done → To do save fails; a drop back into the same column or outside the columns should not move the card | 4 | 2 | 0 | none |
|
| 16 |
+
| assignee-combo | 8 | Arrow keys (every input the judge types leaves one match, so the arrow keys are never used); typing a middle part of a name; a screen reader knowing which option is highlighted | 4 | 3 | 0 | none |
|
| 17 |
+
| due-off-by-one | 5 | In a western time zone (Seattle), what the edit page shows and "saving again does not shift it" (only checked in Shanghai) | 3 | 1 | 0 | none |
|
| 18 |
+
| infinite-dup | 3 (+1 implied) | Independence from backend speed (only checked at 1 second per page); implied: the list still scrolls to the end after the filter changes mid-load | 3 | 2 | 0 | none |
|
| 19 |
+
| row-actions-kbd | 5 | Other rows staying hidden (only the focused row is looked at) | 4 | 1 | 1 | none |
|
| 20 |
+
| draft-keep | 5 (+1 implied) | "In this browser" (still there in another tab); implied: a failed send does not lose the draft | 4 | 2 | 0 | none |
|
| 21 |
+
| attach-upload | 6 | Clicking the file name again hides the preview; uploads still work after an oversized file is refused | 5 | 2 | 2 (same cause) | **Mirasim Computer Use run 1 wrongly judged not passed** |
|
| 22 |
+
| back-keeps-place | 5 | Staying "exactly" where it was (a 48px tolerance plus picking a row in the middle of the viewport lets centring that row pass) | 3 | 1 | 1 | none |
|
| 23 |
+
| old-links | 9 | "Who deleted it and when" in the deleted-task notice | 4 | 1 | 1 (debatable) | none |
|
| 24 |
+
| **Total** | | | **34** | **15** | **5** | **1** |
|
| 25 |
|
| 26 |
+
"Requirements" counts the ticket sentence by sentence (the rounds are added up for multi-round tasks). "Implied" is behaviour the ticket does not state but Team Tasks already had, so breaking it is a regression.
|
| 27 |
|
| 28 |
+
Real runs: 64 runs over both sides of the 9 tasks (runs 1–3 per side per task; one more trial run per side for board-dnd and assignee-combo; for old-links two more trial runs on the ChatGPT Computer Use side and four more on the Mirasim Computer Use side), all judged pass except Mirasim Computer Use run 1 of attach-upload. The diffs of 2–6 runs per task were read (board-dnd 4 runs, the new component of 8 assignee-combo runs, due-off-by-one 2, infinite-dup 6, row-actions-kbd 2, draft-keep 6, attach-upload 6, back-keeps-place 2, old-links 4), and then the probes above were run over all 64 runs: **no run was judged pass without doing what the ticket asks**; **1 run was judged not passed although it is right** (Mirasim Computer Use run 1 of attach-upload, see below). These runs are much alike: board-dnd is always `elementsFromPoint` skipping the card, or `pointer-events: none` with a `finally`; all 6 row-actions-kbd runs remove `tabIndex={-1}` and add `:focus-within` (with `pointer-events: auto`); all 6 due-off-by-one runs go back to `f.dueDate || null`. The holes below have caused no wrongly passed run so far, but the judges have no defence against these mistakes.
|
| 29 |
|
| 30 |
---
|
| 31 |
|
| 32 |
## board-dnd
|
| 33 |
|
| 34 |
+
Requirements: ① a drag from To do → Done is saved; ② so is Done → To do; ③ the card shows in the new column; ④ it works for every card; ⑤ a failed save shows a notice; ⑥ after a failure the card goes back to the column it came from; ⑦ (only a drop on the other column counts as a move: the ticket says "carry it over to the other column"). The judge checked ①②③⑤, ④ on 3 cards, ⑥ only in the To do → Done direction, and not ⑦. It also checked that dragging still works after a failure and that clicking a card still opens it.
|
| 35 |
|
| 36 |
+
| Variant | Expect | Result |
|
| 37 |
|---|---|---|
|
| 38 |
| drop-toggles | fail | **LEAK** |
|
| 39 |
| revert-hardcoded-todo | fail | **LEAK** |
|
| 40 |
+
| only-round1 | fail | OK (after a failed save the card stays in Done…) |
|
| 41 |
| no-optimistic | pass | OK |
|
| 42 |
|
| 43 |
+
- **drop-toggles** (LEAK): does not fix where the drop lands at all (the dragged card still blocks `elementFromPoint`, so the drop target is always the original column) and instead "flips the card to the other column whenever it was dragged". The judge's three drags all cross columns and all pass; but dragging a card back into its own column, or releasing it outside the columns, still moves and saves it. The probe "drag Write release notes back into To do; 1.5 seconds later it is still not done" passes on the reference solution and on the 8 real runs and fails on this variant.
|
| 44 |
+
Suggested fix: add a step at the start of the judge, "drop back into the same column → task 1 is still not done and the card is still in To do".
|
| 45 |
+
- **revert-hardcoded-todo** (LEAK): on failure pending is hard-coded to `done: false`. A failed To do → Done looks right; after a failed Done → To do the card stays in To do (the column it was dropped on) and does not return to Done. The judge's failure scenario only has task 8 (in To do).
|
| 46 |
+
Suggested fix: have the judging scenario also fail the PATCH of a Done card (such as task 6); dragged to To do it should still be in Done. The existing step with task 6 then needs another Done card for the successful drag. The probe (task 6 fails, dragged to To do, still in Done after 2.5 seconds) passes on the reference solution and on the 8 runs.
|
| 47 |
+
- Effect on existing runs: all 16 probe runs pass; the estimate is no verdict changes.
|
| 48 |
|
| 49 |
## assignee-combo
|
| 50 |
|
| 51 |
+
Requirements: ① typing part of a name narrows the list to the matches; ② the arrow keys move between matches; ③ Enter picks the highlighted one and does not submit the whole form; ④ Esc closes the list without changing the choice; ⑤ clicking a match with the mouse works too; ⑥ Unassigned can still be chosen; ⑦ the label is still Assignee; ⑧ usable by keyboard and screen-reader users like a standard combobox. The judge checked ③④⑤⑥⑦; ① only with the start of a name (dieg, pri, mei, unass); ② in fact not at all: each of those four inputs leaves one match, the highlight in the judge's loop starts on the target, and no arrow key is ever pressed; ⑧ only role=combobox / option, and the highlight may rest on a class name alone.
|
| 52 |
|
| 53 |
+
| Variant | Expect | Result |
|
| 54 |
|---|---|---|
|
| 55 |
| arrows-ignored | fail | **LEAK** |
|
| 56 |
| prefix-only | fail | **LEAK** |
|
| 57 |
| sr-blind | fail | **LEAK** |
|
| 58 |
| no-auto-highlight | pass | OK |
|
| 59 |
|
| 60 |
+
- **arrows-ignored** (LEAK): the arrow keys do nothing and Enter always picks the first match.
|
| 61 |
+
Suggested fix: add a step that types something matching several people (such as "a"), presses ↓↓↑↓ and then Enter; the pick should not be the first match (the probe is written this way; whether the highlight starts on the first option or nowhere, a correct implementation ends on the 2nd or 3rd).
|
| 62 |
+
- **prefix-only** (LEAK): filters with `startsWith(full name)`, so typing the surname "alvar" does not find Diego Alvarez. The ticket says "type part of a person's name".
|
| 63 |
+
Suggested fix: change one of the inputs to part of a surname (such as "alvar" or "shah").
|
| 64 |
+
- **sr-blind** (LEAK): `aria-activedescendant` is removed and `aria-selected` is false on every option; the highlight rests on the `.active` class alone. A screen reader does not announce the current option. The last tier of the judge's `highlightedOption` accepts a class name.
|
| 65 |
+
Suggested fix: after arrow keys were pressed, require focus on an option or the input's `aria-activedescendant` pointing at an option (the two standard ways a screen reader can tell), and drop the "the only active class" tier (the `aria-selected` tier can stay). All 8 real runs use `aria-activedescendant`.
|
| 66 |
+
- no-auto-highlight (no highlight after typing, only after ↓) is judged pass; the judge is not strict on this legitimate approach, which is what one trial run on each side does.
|
| 67 |
+
- Effect on existing runs: the three probes pass all 24 times on the 8 runs; the estimate is no verdict changes.
|
| 68 |
|
| 69 |
## due-off-by-one
|
| 70 |
|
| 71 |
+
Requirements: ① the day picked is the day saved; ② the task shows that day; ③ the edit page shows that day; ④ changing another field and saving again does not shift it; ⑤ right for people in Shanghai, Berlin and Seattle. The judge checked ①②③④ in Shanghai and only ①② in Seattle. Berlin is not checked, but it lies east of UTC like Shanghai and goes wrong the same way, so that is no gap.
|
| 72 |
|
| 73 |
+
| Variant | Expect | Result |
|
| 74 |
|---|---|---|
|
| 75 |
| form-utc-west | fail | **LEAK** |
|
| 76 |
+
| plus-one-day | fail | OK (in Seattle, picking Dec 1 saved "2026-12-02") |
|
| 77 |
| display-utc | pass | OK |
|
| 78 |
|
| 79 |
+
- **form-utc-west** (LEAK): saving is fixed, but the edit page reads the date back with `new Date("YYYY-MM-DD").toLocaleDateString("en-CA")`. Right in Shanghai; in Seattle the edit page shows 11-30 and another save shifts the date a day earlier, which is exactly Mei's "edit twice, two days off" in the ticket.
|
| 80 |
+
Suggested fix: in the Seattle part too, reopen the edit page and check what it shows, then change Notes, save and check the date is unchanged (mirroring the Shanghai part).
|
| 81 |
+
- Effect on existing runs: all 6 runs changed only the line that saves; the probe passes all 6 times; the estimate is no verdict changes.
|
| 82 |
|
| 83 |
## infinite-dup
|
| 84 |
|
| 85 |
+
Requirements: ① each task appears once; ② in order; ③ scrolling to the end gets every task. The judge checked ①②③ against a slow backend at 1 second per page. Implied: after the filter or the search changes mid-load, the list still scrolls to the end (the original `reload` of Team Tasks releases the lock).
|
| 86 |
|
| 87 |
+
| Variant | Expect | Result |
|
| 88 |
|---|---|---|
|
| 89 |
| throttle-1500 | fail | **LEAK** |
|
| 90 |
| busy-stuck-after-filter | fail | **LEAK** |
|
| 91 |
| dedupe-no-guard | pass | OK |
|
| 92 |
|
| 93 |
+
- **throttle-1500** (LEAK): a 1.5-second throttle in place of "no new request while one is on its way". It holds in the judging scenario at 1 second per page; with the scenario at 2 seconds per page the same code gives "90 tasks are listed twice". The reference solution, dedupe-no-guard and the 6 real runs all pass at 2 seconds (measured).
|
| 94 |
+
Suggested fix: make the slow page 2–2.5 seconds in the judging scenario (the 40-second limit of the judge's loop is enough), or run both speeds.
|
| 95 |
+
- **busy-stuck-after-filter** (implied requirement, LEAK): a lock was added, but `reload` does not release it and the `finally` releases it only within the same generation. Change Status once while the next page is on its way and the lock is never released; back on All only 20 rows are left (the probe measured 20 / 100).
|
| 96 |
+
Suggested fix: add a step, "after scrolling triggers the next page, change Status at once and change back to All; scrolled to the end, the row count equals the total". The reference solution and the 6 real runs all pass (their `reload` resets the lock).
|
| 97 |
+
- Effect on existing runs: both probes pass on all 6 runs; the estimate is no verdict changes.
|
| 98 |
|
| 99 |
## row-actions-kbd
|
| 100 |
|
| 101 |
+
Requirements: ① the keyboard reaches Complete / Star; ② they can be used from the keyboard; ③ they are visible while focus is on them; ④ otherwise hidden until hover; ⑤ hover shows them as before. The judge checked all of these, ④ only on the focused row.
|
| 102 |
|
| 103 |
+
| Variant | Expect | Result |
|
| 104 |
|---|---|---|
|
| 105 |
+
| focus-opacity-only | pass | **STRICT** (the focused Complete button is covered by something) |
|
| 106 |
| all-rows-on-focus | fail | **LEAK** |
|
| 107 |
+
| tab-but-invisible | fail | OK (the focused Complete button is invisible) |
|
| 108 |
| buttons-only-focus | pass | OK |
|
| 109 |
|
| 110 |
+
- **focus-opacity-only** (STRICT): a very common correct approach, `.inbox-row:focus-within .row-actions { opacity: 1; }`, with `pointer-events` still switched on by `:hover` alone. Keyboard use does not need `pointer-events`, and as soon as the mouse is over the row `:hover` switches it on, so the user sees no difference. The judge's "covered" check uses `elementFromPoint`, and hit testing skips elements with `pointer-events: none`, hence the verdict "covered by something".
|
| 111 |
+
Suggested fix: set the focused element to `pointer-events: auto` for the duration of the hit test (an explicit auto on a child overrides the inherited none) and restore it after; or use `elementsFromPoint` and only look at whether something opaque that does not belong to the focused element lies in front of it.
|
| 112 |
+
- **all-rows-on-focus** (LEAK): `.inbox-list:focus-within .row-actions` shows the buttons on every row while focus is anywhere in the list, against "stay hidden otherwise; the design wants a quiet list".
|
| 113 |
+
Suggested fix: when Tab reaches a row's button, take another row (not the focused one) and check its Star button has `shown < 0.2`.
|
| 114 |
+
- Effect on existing runs: all 6 runs use `:hover, :focus-within { opacity: 1; pointer-events: auto; }`, which the STRICT fix does not touch; the probe passes all 6 times; the estimate is no verdict changes.
|
| 115 |
|
| 116 |
## draft-keep
|
| 117 |
|
| 118 |
+
Requirements: ① each task has its own draft; ② saved "in this browser"; ③ still there after a reload; ④ still there on coming back to the task (including back and forward); ⑤ cleared once posted. The judge checked ①③④⑤ and not ②. Implied: a failed send should not lose the draft ("Once the comment is posted, its draft is cleared").
|
| 119 |
|
| 120 |
+
| Variant | Expect | Result |
|
| 121 |
|---|---|---|
|
| 122 |
| session-storage | fail | **LEAK** |
|
| 123 |
| clear-before-post | fail | **LEAK** |
|
| 124 |
+
| posted-stays-stored | fail | OK (a posted comment comes back as a draft after a reload) |
|
| 125 |
| json-map | pass | OK |
|
| 126 |
|
| 127 |
+
- **session-storage** (LEAK): sessionStorage instead of localStorage. The draft survives a reload and back / forward in the same tab and is gone in a new tab. The judge uses a single tab throughout.
|
| 128 |
+
Suggested fix: at the end, open a new page in the same context at `/inbox/4`; draft B is still there. Whether this is wrong has a little room ("in this browser" can also be read as "this tab"), but a new tab without the draft looks like "lost" to the user, so the suggestion is to count it as wrong.
|
| 129 |
+
- **clear-before-post** (LEAK): on Post the stored draft is deleted before the request is sent, so after a failed send a reload loses it.
|
| 130 |
+
Suggested fix: add a step in which the comment POST returns 500; after the failure and a reload the draft is still there. An implied requirement, low priority.
|
| 131 |
+
- Effect on existing runs: all 6 runs use localStorage and clear only after success; the probes pass all 12 times; the estimate is no verdict changes.
|
| 132 |
|
| 133 |
## attach-upload
|
| 134 |
|
| 135 |
+
Requirements: ① clicking a file name shows a preview inside the task (below the list); ② another click hides it; ③ a file just uploaded opens in the preview directly; ④ a file over 1 MB is refused at once, without a request; ⑤ the message states the limit; ⑥ files up to 1 MB upload as before. The judge checked ①③④⑤⑥; not ②; ⑥ only once, before the refusal.
|
| 136 |
|
| 137 |
+
| Variant | Expect | Result |
|
| 138 |
|---|---|---|
|
| 139 |
| no-hide-on-second-click | fail | **LEAK** |
|
| 140 |
| stuck-after-refuse | fail | **LEAK** |
|
| 141 |
+
| msg-or-smaller | pass | **STRICT** (picking a 1.5 MB file does not say right away that files can be up to 1 MB) |
|
| 142 |
+
| mirasim-r1-verbatim | pass | **STRICT** (same) |
|
| 143 |
| mirasim-r1-reworded | pass | OK |
|
| 144 |
|
| 145 |
+
(`mirasim-r1` in the variant names stands for Mirasim Computer Use run 1.)
|
| 146 |
|
| 147 |
+
- **msg-or-smaller / mirasim-r1-verbatim** (STRICT, has caused a wrong verdict): the judge requires the message to contain "1 MB" together with one of `too (big|large)|up to|limit|max|exceed|larger|bigger|over`. "Files must be 1 MB or smaller." states the limit plainly and is still judged wrong because smaller is not on the list; "at most 1 MB" and "1 MB or less" would be judged wrong too. mirasim-r1-verbatim is the 4 files Mirasim Computer Use run 1 changed, as they are; mirasim-r1-reworded only rewrites that sentence as "Files can be up to 1 MB.", and it passes. So **Mirasim Computer Use run 1 failed on the wording alone; everything else (preview, hiding on a second click, opening after upload, refusing before any request) is right**.
|
| 148 |
+
Suggested fix: only require that text containing "1 MB" (`(^|[^\d.])1(\.0+)?\s?MB`, which excludes "1.5 MB") appears on the page within 1.5 seconds of picking the 1.5 MB file, and drop the keyword list; or add `smaller|less|at most|limit` to the list.
|
| 149 |
+
Effect on existing runs: Mirasim Computer Use run 1 should become a pass (measured with mirasim-r1-reworded); the messages of the other 5 runs all contain "maximum" or "limit" and are not affected.
|
| 150 |
+
- **no-hide-on-second-click** (LEAK): clicking the file name always opens the preview and a second click does not hide it.
|
| 151 |
+
Suggested fix: after the first click opens it, click once more; the iframe should be gone (or not visible).
|
| 152 |
+
- **stuck-after-refuse** (LEAK): the size check sits after `setUploading(true)` and on a refusal returns without resetting it, so the button stays at "Uploading…", disabled, and small files cannot be uploaded afterwards either. The judge has the oversized file as its last step; and Playwright's `setInputFiles` puts files even into a disabled input, so just uploading again after the refusal would not catch it.
|
| 153 |
+
Suggested fix: after the refusal check that the file input is not disabled and the page has no "Uploading", then upload a small file and check it is saved.
|
| 154 |
+
- Effect on existing runs: the two probes pass all 12 times on the 6 runs; the estimate is no verdict changes.
|
| 155 |
|
| 156 |
## back-keeps-place
|
| 157 |
|
| 158 |
+
Requirements (390×844): ① going back to the list with ← Inbox keeps the place; ② so does the browser's Back; ③ the list stays "exactly" where it was; ④ the batches already loaded are still there; ⑤ the task just viewed is highlighted. The judge checked all of these, but ③ by picking a row at 45% of the viewport and allowing its distance from the top to differ by ≤ 48px on return; ⑤ only by the `li`'s own class name / aria and the `li`'s own background, shadow and outline.
|
| 159 |
|
| 160 |
+
| Variant | Expect | Result |
|
| 161 |
|---|---|---|
|
| 162 |
| center-selected-row | fail | **LEAK** |
|
| 163 |
+
| highlight-on-link | pass | **STRICT** (after the browser's Back the task you came from is not highlighted) |
|
| 164 |
+
| highlight-only | fail | OK (…the task you came from is not in the list) |
|
| 165 |
|
| 166 |
+
- **center-selected-row** (LEAK): does not restore the scroll position; on return it calls `scrollIntoView({ block: "center" })` on the row just viewed. The row the judge picks is in the middle of the viewport already, so centring moves it by less than 48px. The probe instead opens a row near the top of the viewport and compares the scroll area's `scrollTop` (8px tolerance): the same before and after on the reference solution, 1500 → 1292 on this variant.
|
| 167 |
+
Suggested fix: compare the scroll area's `scrollTop` before opening and after coming back (a tolerance of about 8px), or pick a row near the top of the viewport. The ticket says "exactly where it was", so a strict comparison is not too strict.
|
| 168 |
+
- **highlight-on-link** (STRICT): the row just viewed gets a class of its own, `recently-opened`, and the background is drawn on the title link inside the row (the link takes up most of the row), without `aria-current`. To the eye it is highlighted, but the `li` itself has a transparent background and the judge does not recognise it.
|
| 169 |
+
Suggested fix: in the "look at the style" tier of `highlighted`, compare the `li` and its direct child (the title link) with the corresponding elements of a neighbouring row for background / shadow / outline; or screenshot the two rows and compare pixels.
|
| 170 |
+
- Effect on existing runs: all 6 runs use the existing `selected` class (ChatGPT Computer Use run 3 also changes hiding on narrow screens to `visibility: hidden` and refetches the loaded pages on return); the probe passes all 6 times; the estimate is no verdict changes.
|
| 171 |
|
| 172 |
## old-links
|
| 173 |
|
| 174 |
+
Requirements: ① an old link goes to the task's new address; ② Back returns to the page from before it was opened; ③ an old link to a deleted task says clearly "deleted"; ④ and who deleted it and when; ⑤ an old link to a task that never existed still says not found; ⑥ Copy link on the task page copies the new address; ⑦ so does the one in the Inbox; ⑧ and the one in the row's ⋯ menu; ⑨ a new task's link opens. The judge checked everything except ④ (for ③ it also requires the task's name, which the ticket does not state, but TaskGone carries the name already, so this is not too strict).
|
| 175 |
|
| 176 |
+
| Variant | Expect | Result |
|
| 177 |
|---|---|---|
|
| 178 |
| deleted-no-who-when | fail | **LEAK** |
|
| 179 |
+
| removed-wording | pass | **STRICT** (an old link to a deleted task does not say the task was deleted) |
|
| 180 |
+
| push-not-replace | fail | OK (Back … goes to /tasks/2) |
|
| 181 |
| redirect-to-tombstone | pass | OK |
|
| 182 |
|
| 183 |
+
- **deleted-no-who-when** (LEAK): for an old link to a deleted task it writes its own "This task was deleted" plus the task's name, with no who or when. The ticket says so in brackets: "(by whom, and when)".
|
| 184 |
+
Suggested fix: wait until the person who deleted it (Alex Kim in the judging scenario) and a date appear on the page. The probe passes on the reference solution, redirect-to-tombstone, removed-wording and the 12 real runs. Note that the member list loads asynchronously, so "by Alex Kim" appears later than the heading; wait for it instead of reading once (the first version of the probe read once and wrongly failed the reference solution).
|
| 185 |
+
- **removed-wording** (STRICT, debatable): the deleted page says "This task was removed" and "… was removed by X on …"; who and when are both there, only the word deleted is not used. The ticket wants it to "say clearly that the task was deleted"; removed means the same, but all 12 runs this time use TaskGone as it is and nobody changed the wording.
|
| 186 |
+
Suggested fix: `/deleted|removed/i`, and the reverse check in the "link to a task that never existed" step changes to the same words. Low priority.
|
| 187 |
+
- Effect on existing runs: the probe passes all 12 times; the estimate is no verdict changes.
|
| 188 |
|
| 189 |
---
|
| 190 |
|
| 191 |
+
## The five things to fix first
|
| 192 |
|
| 193 |
+
1. **The keyword list for the attach-upload message** (STRICT, has caused a wrong verdict): accept "1 MB" itself and drop or loosen the `too big|up to|limit|…` list. On a re-judge after the change, Mirasim Computer Use run 1 should become a pass.
|
| 194 |
+
2. **The "covered" check of row-actions-kbd** (STRICT): `elementFromPoint` skips `pointer-events: none` and judges the very common correct "focus only switches opacity" approach as covered. Set the focused element to `pointer-events: auto` for the hit test. None of the 6 runs hits it so far, but another model easily could.
|
| 195 |
+
3. **The arrow keys of assignee-combo are not really tested** (LEAK, stated in the ticket): add an input that matches several people, press the arrow keys a few times and then Enter, and the pick is not the first; along the way change one input to part of a surname (prefix-only) and tighten highlight detection to `aria-activedescendant` / focus / `aria-selected` (sr-blind).
|
| 196 |
+
4. **old-links does not check "who deleted it and when"** (LEAK, stated in the ticket): wait for the person and the date to appear.
|
| 197 |
+
5. **attach-upload does not check "another click hides it" or "uploads still work after a refusal"** (LEAK, stated in the ticket): add a step for each; after the refusal check the input is not disabled, which `setInputFiles` alone cannot show.
|
| 198 |
|
| 199 |
+
Next: in board-dnd a drop back into the same column should not move the card (drop-toggles gets around the task's core bug and still passes everything), due-off-by-one checks the edit page and a second save in Seattle too, the slow page of infinite-dup goes above 2 seconds, back-keeps-place compares `scrollTop` and loosens highlight detection.
|
| 200 |
|
| 201 |
---
|
| 202 |
|
| 203 |
+
## What was changed (as decided: "change them all")
|
| 204 |
|
| 205 |
+
The judges of all 9 tasks were changed, touching only `tasks/controls.ts` (back-keeps-place also got one sanity variant), one commit per task. For every task these were run: `harness/selftest.ts` (the seed is judged fail, the reference solution pass), `harness/audit.ts` (all OK), and a read-only re-judge of **all** existing runs of the task with the changed judge (with the read-only re-judge script, which does not write back to the runs' verdicts).
|
| 206 |
|
| 207 |
+
| Task | Stricter | Looser | Self-test | Variants | Read-only re-judge |
|
| 208 |
|---|---|---|---|---|---|
|
| 209 |
+
| board-dnd | At the start, a drop back into the same column must not save and must not leave To do; at the end, a Done card (task 9) whose save fails must return to Done after a drag to To do, with the API unchanged | — | 1/1 | 4/4 | 8 runs unchanged |
|
| 210 |
+
| assignee-combo | An added step types "a" (matching several people); after ↓↓↑↓ the highlight must not still be on the first option, and Enter picks the highlighted one; Diego is now found by typing "alvar"; the highlight is only accepted as aria-activedescendant / focus / the only aria-selected, without the class-name tier | — | 1/1 | 4/4 | 8 runs unchanged |
|
| 211 |
+
| due-off-by-one | In Seattle too, the edit page is reopened and what it shows is checked, then only Notes is changed and saved and the date must not change | — | 1/1 | 3/3 | 6 runs unchanged |
|
| 212 |
+
| infinite-dup | The slow page of the judging scenario goes from 1 second to 2.2 seconds; after scrolling to the end, switch to Done and, as the next page is triggered, straight back to All, then scroll to the end again and check count, duplicates and order as before | — | 1/1 | 3/3 | 6 runs unchanged |
|
| 213 |
+
| row-actions-kbd | When Tab reaches a row's Complete, another row's Star must still be hidden | Before the "covered" check the focused button is given `pointer-events: auto` for the test | 1/1 | 4/4 | 6 runs unchanged |
|
| 214 |
+
| draft-keep | Task 4 opened in a new tab of the same browser must have the draft; when the comment POST returns 500, the draft must still be there after clicking Post and reloading | — | 1/1 | 4/4 | 6 runs unchanged |
|
| 215 |
+
| attach-upload | With the preview open, another click on the file name must hide it; after an oversized file is refused the upload field must not be disabled or stuck at "Uploading…", and a small file must then save | The size-limit message only has to newly show "1 MB" (or 1024 KB), without words such as too big / up to / limit | 1/1 | 5/5 | **Mirasim Computer Use run 1 not passed → pass**, the other 5 runs unchanged |
|
| 216 |
+
| back-keeps-place | Picks a row at 20% of the viewport (was 45%); the position tolerance goes from 48px to 16px | The highlight also compares the row's direct child (the title link), with the mouse moved away first to rule out the hover background; a new variant no-highlight (fixes the position without highlighting, expect fail) confirms nothing is recognised by mistake | 1/1 | 4/4 | 6 runs unchanged |
|
| 217 |
+
| old-links | The deleted-task notice must come to show the person who deleted it (taken from the backend record) and a date | "deleted" or "removed" both count (as decided); the reverse check in the step for a link to a task that never existed accepts both words too | 1/1 | 4/4 | 12 runs unchanged |
|
| 218 |
+
|
| 219 |
+
- No variant's expect was changed: as decided, old-links/removed-wording was expect pass from the start, and it does say who deleted the task and when.
|
| 220 |
+
- Mirasim Computer Use run 1 of attach-upload was looked at in detail: the preview, hiding on a second click, opening after upload and refusing an oversized file before any request are all done, and the message is "Files must be 1 MB or smaller."; passing it after the change agrees with the ticket. The run's verdict was not written back; that is left to the formal re-judge.
|
| 221 |
+
- After the change one infinite-dup run takes 40–70 seconds to judge (about 30 seconds before), because of the extra "scroll to the end after a filter change".
|
| 222 |
+
- After all 9 tasks were changed, the self-test and the variants were run again for the whole group; the result is on the next line.
|
| 223 |
+
Rerun of the whole group: self-test 9/9 OK, variants 35/35 OK (the 34 existing ones + no-highlight).
|
docs/judge-audits/flows.md
CHANGED
|
@@ -1,214 +1,214 @@
|
|
| 1 |
-
#
|
| 2 |
|
| 3 |
-
|
| 4 |
|
| 5 |
-
|
| 6 |
-
|
| 7 |
|
| 8 |
-
##
|
| 9 |
|
| 10 |
-
|
|
| 11 |
|---|---|---|---|---|---|---|
|
| 12 |
-
| login-return | 2 |
|
| 13 |
-
| viewer-role | 7 |
|
| 14 |
-
| session-expiry | 5 |
|
| 15 |
-
| checkout-return | 7 |
|
| 16 |
-
| balance-refresh | 4 |
|
| 17 |
-
| white-screen | 3 |
|
| 18 |
-
| wrong-param | 3 | Active
|
| 19 |
-
| activity-log | 19 | Orders / Attachments
|
| 20 |
-
| notify-center | 16 |
|
| 21 |
-
| recurring | 17 |
|
| 22 |
-
| **
|
| 23 |
-
|
| 24 |
-
|
| 25 |
|
| 26 |
---
|
| 27 |
|
| 28 |
## login-return
|
| 29 |
|
| 30 |
-
|
| 31 |
|
| 32 |
-
|
| 33 |
|
| 34 |
## viewer-role
|
| 35 |
|
| 36 |
-
|
| 37 |
|
| 38 |
-
|
| 39 |
|
| 40 |
-
**LEAK `toast-no-rollback`**
|
| 41 |
-
-
|
| 42 |
-
-
|
| 43 |
|
| 44 |
-
**STRICT `alert-refusal`**
|
| 45 |
-
-
|
| 46 |
-
-
|
| 47 |
|
| 48 |
-
|
| 49 |
|
| 50 |
## session-expiry
|
| 51 |
|
| 52 |
-
|
| 53 |
|
| 54 |
-
|
| 55 |
|
| 56 |
-
**STRICT `own-error-text`**
|
| 57 |
-
-
|
| 58 |
-
-
|
| 59 |
|
| 60 |
-
|
| 61 |
|
| 62 |
## checkout-return
|
| 63 |
|
| 64 |
-
|
| 65 |
|
| 66 |
-
|
| 67 |
|
| 68 |
-
**LEAK `noopener-says-blocked`**
|
| 69 |
-
-
|
| 70 |
-
-
|
| 71 |
|
| 72 |
-
|
| 73 |
|
| 74 |
## balance-refresh
|
| 75 |
|
| 76 |
-
|
| 77 |
|
| 78 |
-
|
| 79 |
|
| 80 |
## white-screen
|
| 81 |
|
| 82 |
-
|
| 83 |
|
| 84 |
-
|
| 85 |
|
| 86 |
-
**LEAK `omit-empty-on-save`**
|
| 87 |
-
**LEAK `empty-string-due`**
|
| 88 |
-
-
|
| 89 |
-
-
|
| 90 |
|
| 91 |
-
|
| 92 |
|
| 93 |
## wrong-param
|
| 94 |
|
| 95 |
-
|
| 96 |
|
| 97 |
-
|
| 98 |
|
| 99 |
-
## activity-log
|
| 100 |
|
| 101 |
-
|
| 102 |
-
-
|
| 103 |
-
-
|
| 104 |
-
-
|
| 105 |
-
-
|
| 106 |
-
-
|
| 107 |
|
| 108 |
-
|
| 109 |
|
| 110 |
-
**LEAK `newer-older-kept`**
|
| 111 |
-
-
|
| 112 |
-
-
|
| 113 |
|
| 114 |
-
**LEAK `orders-type-wrong`**
|
| 115 |
-
-
|
| 116 |
-
-
|
| 117 |
|
| 118 |
-
**LEAK `person-ignored-on-task`**
|
| 119 |
-
-
|
| 120 |
-
-
|
| 121 |
|
| 122 |
-
⑤
|
| 123 |
|
| 124 |
-
**
|
| 125 |
|
| 126 |
-
|
| 127 |
|
| 128 |
-
## notify-center
|
| 129 |
|
| 130 |
-
|
| 131 |
-
-
|
| 132 |
-
-
|
| 133 |
-
-
|
| 134 |
-
-
|
| 135 |
-
-
|
| 136 |
|
| 137 |
-
|
| 138 |
|
| 139 |
-
**LEAK `no-mark-all-on-page`**
|
| 140 |
-
-
|
| 141 |
-
-
|
| 142 |
|
| 143 |
-
**LEAK `kept-survives-leave`**
|
| 144 |
-
-
|
| 145 |
-
-
|
| 146 |
|
| 147 |
-
③
|
| 148 |
|
| 149 |
-
**
|
| 150 |
|
| 151 |
-
|
| 152 |
|
| 153 |
-
## recurring
|
| 154 |
|
| 155 |
-
|
| 156 |
-
-
|
| 157 |
-
-
|
| 158 |
-
-
|
| 159 |
-
-
|
| 160 |
-
-
|
| 161 |
|
| 162 |
-
|
| 163 |
|
| 164 |
-
**LEAK `retick-guard-list-only`**
|
| 165 |
-
**LEAK `stop-only-this`**
|
| 166 |
-
**LEAK `future-skips-open-siblings`**
|
| 167 |
-
**LEAK `daily-late-from-due`**
|
| 168 |
-
-
|
| 169 |
-
1.
|
| 170 |
-
2.
|
| 171 |
-
3.
|
| 172 |
-
4.
|
| 173 |
-
-
|
| 174 |
|
| 175 |
-
**STRICT `scope-radio-dialog`**
|
| 176 |
-
-
|
| 177 |
-
-
|
| 178 |
|
| 179 |
-
⑫
|
| 180 |
|
| 181 |
---
|
| 182 |
|
| 183 |
-
##
|
| 184 |
|
| 185 |
-
1. **viewer-role
|
| 186 |
-
2. **recurring
|
| 187 |
-
3. **activity-log
|
| 188 |
-
4. **white-screen
|
| 189 |
-
5. **
|
| 190 |
|
| 191 |
-
|
| 192 |
|
| 193 |
---
|
| 194 |
|
| 195 |
-
##
|
| 196 |
|
| 197 |
-
|
| 198 |
|
| 199 |
-
|
|
| 200 |
|---|---|---|---|---|
|
| 201 |
-
| viewer-role |
|
| 202 |
-
| session-expiry |
|
| 203 |
-
| checkout-return |
|
| 204 |
-
| white-screen |
|
| 205 |
-
| activity-log |
|
| 206 |
-
| notify-center |
|
| 207 |
-
| recurring |
|
| 208 |
-
| login-return
|
| 209 |
-
|
| 210 |
-
|
| 211 |
-
|
| 212 |
-
|
| 213 |
-
- **session-expiry
|
| 214 |
-
- **recurring
|
|
|
|
| 1 |
+
# Judge audit: flow tasks (10 tasks)
|
| 2 |
|
| 3 |
+
Only tasks in the v1 suite are kept here.
|
| 4 |
|
| 5 |
+
The variants are in `audit-variants/<id>/`, 45 in all (33 expect fail, 12 expect pass). All were run with `npx tsx harness/audit.ts -j 1 <id>`, with no ERR.
|
| 6 |
+
Real runs: for the 7 bug-fix tasks the diff of every run was read; for the 3 long tasks a read-only probe was written as well (it copies the code and then, on the mock backend (apps/mock-api/server.mjs) + Vite, goes through the scenarios the judge does not), and it was run over every run on both sides, ChatGPT Computer Use and Mirasim Computer Use.
|
| 7 |
|
| 8 |
+
## Summary
|
| 9 |
|
| 10 |
+
| Task id | Requirements | Requirements not checked | Variants | LEAK | STRICT | Wrong verdicts on real runs |
|
| 11 |
|---|---|---|---|---|---|---|
|
| 12 |
+
| login-return | 2 | none | 4 | 0 | 0 | none (6 runs) |
|
| 13 |
+
| viewer-role | 7 | The Settings page, the Inbox comment box, attachment upload, the edit page; putting things back after a refusal is in fact not checked (a race) | 5 | 1 | 1 | none (all 6 runs wait for the server before removing) |
|
| 14 |
+
| session-expiry | 5 | Resending Save description on the task page after the session expires | 4 | 0 | 1 | none (6 runs) |
|
| 15 |
+
| checkout-return | 7 | No further payment from the old checkout link (left to the backend alone); a false "blocked by the browser" | 4 | 1 | 0 | none (8 runs) |
|
| 16 |
+
| balance-refresh | 4 | none | 3 | 0 | 0 | none (8 runs) |
|
| 17 |
+
| white-screen | 3 | A task already saved as null can be opened again; what is shown after the due date is cleared | 4 | 2 | 0 | none (the 8 runs make exactly the same change) |
|
| 18 |
+
| wrong-param | 3 | Later pages when scrolling down Active (minor) | 3 | 0 | 0 | none (6 runs) |
|
| 19 |
+
| activity-log | 19 | Whether the Orders / Attachments options work; Person stacked on a single task; whether Newer / Older were removed; going back to the first batch when the filter changes after Load more | 6 | 3 | 0 | none (the probe passes on all 24 runs) |
|
| 20 |
+
| notify-center | 16 | Mark all as read on the page; unread standing out / read dimmed; no longer kept after "leaving the page" | 5 | 2 | 0 | none (the probe passes on all 17 runs; one Mirasim Computer Use trial run was judged fail to begin with) |
|
| 21 |
+
| recurring | 17 | Unticking and ticking again on the task page / edit page; Stop repeating on a completed task; This and future changing the other open tasks of the series; a daily task completed late; the Cancel button | 7 | 4 | 1 | none (the probe passes on all 10 runs) |
|
| 22 |
+
| **Total** | | | **45** | **13** | **3** | **none** |
|
| 23 |
+
|
| 24 |
+
The conclusion first: no existing run of these tasks was found to be judged wrongly, and the high pass rate looks like the model really getting them right (the changes in the bug-fix tasks are nearly all identical, and the long-task probe passes everywhere). But the judges let wrong implementations through in 13 places. The one in viewer-role is a hole in how the judge is written (the core requirement is in fact not checked), and several in the long tasks are requirements from earlier rounds that are only half checked in later rounds.
|
| 25 |
|
| 26 |
---
|
| 27 |
|
| 28 |
## login-return
|
| 29 |
|
| 30 |
+
Requirements: ① after signing in from a link such as `/tasks/4`, return to that task; ② after signing in from `/inbox/5?status=active`, return to that Inbox item with the filter. The judge also checked "opening `/login?next=` while signed in goes straight to next" and "next must not lead off the site"; the ticket states neither, but the seed's comment names the open redirect and the baseline Team Tasks already behaves this way, so this is not overreach.
|
| 31 |
|
| 32 |
+
Variants: `drop-query`, `tasks-only` and `open-redirect` (fail) are all judged fail; `url-origin` (pass, compares origins with `new URL`) is judged pass. No problems.
|
| 33 |
|
| 34 |
## viewer-role
|
| 35 |
|
| 36 |
+
Requirements: for a read-only member ① the task list has no new-task box; ② the list has no Edit / Delete / checkbox; ③ the task page has no controls that change anything; ④ nor has the Board; ⑤ "anywhere" (Inbox, Settings, the edit page and so on); when the server refuses, ⑥ tell the user and ⑦ put things back as they were.
|
| 37 |
|
| 38 |
+
Not checked: for ⑤ only the Inbox's buttons and ⋯ menu were looked at; Invite / Remove on the Settings page, the Inbox comment box and attachment upload, and `/tasks/:id/edit` were not (the seed breaks a single line that compares roles, so fixing the root cause fixes everything; low risk). ⑥⑦ are only checked on deleting and ticking in the task list.
|
| 39 |
|
| 40 |
+
**LEAK `toast-no-rollback`** (judged pass): an optimistic delete that shows an error notice on refusal but does not put the task back. The cause is not something left out of the judge, it is a **race**: after `page.goto(url)` the judge switches to Viewer and clicks as soon as it sees the Delete button, while under React StrictMode in development the first-screen `GET /api/tasks` is sent twice; the second response lands after the optimistic delete and puts the task back in the list (the server did not delete it, so the response naturally has it). Logging added in the variant's directory confirmed this: clicked at once, the tasks go to 9 and then back to 10; clicked after waiting 1.5 seconds, the task disappears and does not come back. So as written, the step "after the server refused the delete, the task vanished" can hardly ever trigger, and the seed itself (`role-only`) fails on "no notice", not on "vanished".
|
| 41 |
+
- Suggested fix: after `page.goto(url)`, `await settle(page)` (already in `harness/env.ts`) or wait 1 second before switching to Viewer and clicking Delete; for "vanished", look repeatedly over 1.5 seconds and fail if the task is missing even once.
|
| 42 |
+
- Existing runs (estimate): the `deleteTask` of all 6 runs went back to "wait for the server, then remove", so changing the judge changes no verdict.
|
| 43 |
|
| 44 |
+
**STRICT `alert-refusal`** (judged fail: the user is not told): on refusal a native `window.alert` says "You don't have permission…" and the task stays where it is. The judge only counts refusal wording in the page's innerText and cannot see the native dialog; `ctx.dialogs` did in fact record it.
|
| 45 |
+
- Suggested fix: "the user was told" = the page text gained refusal wording, or `ctx.dialogs` gained an alert whose message matches the same regex.
|
| 46 |
+
- Existing runs (estimate): no run uses alert; not affected.
|
| 47 |
|
| 48 |
+
The rest: `role-only` and `silent-rollback` are judged fail; `optimistic-rollback` (pass: optimistic delete, rollback on failure, error thrown) is judged pass.
|
| 49 |
|
| 50 |
## session-expiry
|
| 51 |
|
| 52 |
+
Requirements: ① on expiry, ask for sign-in again in place; ② keep what was typed; ③ after sign-in, finish the save that was pressed; ④ the same for Save description on the task page; ⑤ the same for posting a comment in the Inbox.
|
| 53 |
|
| 54 |
+
Not checked: ④. The seed is global (it replaces the 401 handling with going back to the sign-in page), and a global fix makes ④ right as a matter of course; only a fix that "handles 401 on each page separately" would miss it, which has not been seen in practice.
|
| 55 |
|
| 56 |
+
**STRICT `own-error-text`** (judged fail: a wrong password in the sign-in prompt shows no error): on a wrong password the re-sign-in dialog shows a text of its own, "That password didn't work…". The ticket says nothing about how a wrong password should be reported, yet the judge requires text matching `/wrong|incorrect|invalid|didn.?t match|try again/`.
|
| 57 |
+
- Suggested fix: loosen to "some notice appears (`role=alert`, or a new piece of text on the page) and the dialog is still there", or only require "on a wrong password nothing is saved and the dialog is still there", regardless of wording.
|
| 58 |
+
- Existing runs (estimate): ChatGPT Computer Use runs 2 and 3 and Mirasim Computer Use run 1, which changed the dialog, all keep the server's error text; runs judged pass are not affected.
|
| 59 |
|
| 60 |
+
The rest: `no-retry` and `patch-only` (re-sign-in wired only to PATCH; posting a comment just errors) are judged fail; `editable-email-dialog` (pass) is judged pass.
|
| 61 |
|
| 62 |
## checkout-return
|
| 63 |
|
| 64 |
+
Requirements: ① the checkout opens in a new tab; ② the Credits page stays where it is; ③ coming back with "Cancel and return" must void the order; ④ the page returned to shows Cancelled; ⑤ so does the Credits page that stayed open; ⑥ no further payment from the checkout link; ⑦ paying works as before.
|
| 65 |
|
| 66 |
+
Not checked: ⑥ is only ensured indirectly through "the backend state is cancelled" (the backend refuses payment for a voided order), which is acceptable.
|
| 67 |
|
| 68 |
+
**LEAK `noopener-says-blocked`** (judged pass): `window.open(url, "_blank", "noopener")` returns null; the checkout opens as usual, yet the Credits page shows "Your browser blocked the checkout tab" at the same time. This breaks an existing notice, which the ticket does not mention; low severity.
|
| 69 |
+
- Suggested fix (optional): after clicking Buy, assert the page has no `/blocked/i`.
|
| 70 |
+
- Existing runs (estimate): the real runs all open `about:blank` first and then set `opener = null`; the return value is not null, so they are not affected.
|
| 71 |
|
| 72 |
+
The rest: `newtab-only` and `cancel-local-only` are judged fail; `blank-first-canceled` (pass: opens a blank page first and then navigates, status written as Canceled) is judged pass.
|
| 73 |
|
| 74 |
## balance-refresh
|
| 75 |
|
| 76 |
+
Requirements: ① the balance updates by itself; ② the order shows Paid; ③ the bell gets Payment received; ④ it also updates when the payment completes only after switching back. All checked. The judge also checks "it still updates after one dropped connection"; the ticket does not state it, but EventSource reconnects by itself after a drop, so any implementation that fixes the events passes, and this is not too strict.
|
| 77 |
|
| 78 |
+
Variants: `focus-only` (only refreshes on regaining focus) and `poll-billing` (the Credits page polls, the bell does not move) are judged fail; `sse-only` (pass: only the events fixed, no refresh on focus) is judged pass. No problems.
|
| 79 |
|
| 80 |
## white-screen
|
| 81 |
|
| 82 |
+
Requirements: ① after a save on the edit page the task page is no longer blank; ② a task that already went blank ("from then on that task always opens white") can be opened again; ③ other tasks as before.
|
| 83 |
|
| 84 |
+
Not checked: ② the judge starts from clean data, with no "task already saved as null"; after the save it only looks at whether the title shows, not at what the page displays or what was saved.
|
| 85 |
|
| 86 |
+
**LEAK `omit-empty-on-save`** (judged pass): only the saving side is changed, and `dueDate` is not sent when the due date is empty. The blank screen no longer appears, but clearing the due date and saving has no effect (the task page still shows Due Dec 1, 2026), and a task already saved as null still opens blank.
|
| 87 |
+
**LEAK `empty-string-due`** (judged pass): only the saving side is changed, and an empty due date is saved as `""`. `formatDay("")` does not throw, and the task page shows "Due Invalid Date".
|
| 88 |
+
- Suggested fix: at the start of the judge, set the `dueDate` of some task to null through the backend (`PATCH /tasks/3 {dueDate:null}`), then open it and require that it is not blank; after the step that clears the due date, require the backend's `dueDate` to be empty (null / absent / "") and the task page to show neither `Dec 1, 2026` nor `Invalid Date`.
|
| 89 |
+
- Existing runs (estimate): all 8 runs change the condition on the detail page to `task.dueDate &&`; they still all pass with these checks added.
|
| 90 |
|
| 91 |
+
The rest: `undefined-check` (changed to `!== undefined`) is judged fail; `no-due-text` (pass: writes No due date when there is none) is judged pass.
|
| 92 |
|
| 93 |
## wrong-param
|
| 94 |
|
| 95 |
+
Requirements: ① choosing Done lists only completed tasks; ② choosing Active lists only open ones; ③ the count next to the heading follows. All checked (Done is also scrolled to the end). For Active only the first page and the count are looked at, and later pages are not scrolled; the effect is small.
|
| 96 |
|
| 97 |
+
Variants: `client-filter` (filters in the front end, the count taken after filtering) and `loadmore-drops-status` are judged fail; `send-both` (pass) is judged pass. No problems.
|
| 98 |
|
| 99 |
+
## activity-log (5 rounds)
|
| 100 |
|
| 101 |
+
Requirements the final code should meet (round 4 replaces Newer / Older with Load more; the requirements of the other rounds all stay):
|
| 102 |
+
- Round 1: a Type filter with All activity / Tasks / Comments / Attachments / Orders ①; a Person filter ②; filters are in the address, the same on reload and when shared ③; Back undoes the last filter ④; a filter change starts from the first batch ⑤.
|
| 103 |
+
- Round 2: a View activity link on the task page ⑥; it says which task ⑦; a way back to all activity ⑧; Type and Person can be stacked on it ⑨.
|
| 104 |
+
- Round 3: every entry has Delete ⑩; a native confirm that names the entry ⑪; cancelling deletes nothing ⑫; the filter is unchanged after a delete ⑬; a Viewer has no Delete ⑭.
|
| 105 |
+
- Round 4: Load more adds 20 entries below ⑮; it goes away when there are no more ⑯; Newer / Older are removed ⑰ (the address no longer needs a page number; not a requirement).
|
| 106 |
+
- Round 5: after deleting an entry, Load more skips nothing ⑱; after new activity it repeats nothing ⑲.
|
| 107 |
|
| 108 |
+
The judge checked ②③④⑥⑦⑧⑩–⑯⑱⑲; ① only for Tasks and Comments, ⑨ only for Type. Not checked:
|
| 109 |
|
| 110 |
+
**LEAK `newer-older-kept`** (judged pass): Load more was added and the Newer / Older buttons of round 1 are still underneath. For the changed requirement of round 4 the judge only checks "there is a Load more", not "the old pagination is gone".
|
| 111 |
+
- Suggested fix: add to the Load more part: `main` has no button or link whose name matches `/^(← )?newer|older( →)?$/i` (the text `/page \d+ of \d+/i` can help too).
|
| 112 |
+
- Existing runs (estimate): the source of the 24 runs has no Newer / Older button (two trial runs only have a function named `listOlder`); not affected.
|
| 113 |
|
| 114 |
+
**LEAK `orders-type-wrong`** (judged pass): the value of the Orders option is written `orders`, and choosing Orders always gives an empty list.
|
| 115 |
+
- Suggested fix: choose Orders for Type and compare (the initial data has 2 order.* entries); Attachments has 0 entries in the initial data, so to check it first upload an attachment through the backend.
|
| 116 |
+
- Existing runs: on all 24 runs the probe shows 2 entries for Orders, matching the backend; not affected (measured).
|
| 117 |
|
| 118 |
+
**LEAK `person-ignored-on-task`** (judged pass): the single-task view ignores Person.
|
| 119 |
+
- Suggested fix: after "one task's activity + Type Comments", also choose Person = Priya Shah and compare with `activityOf(api, {taskId: 2, actorId: "m2", type: "comment"})`.
|
| 120 |
+
- Existing runs: on all 24 runs the probe shows 3 entries for "task 2 + Priya Shah", matching the backend; not affected (measured).
|
| 121 |
|
| 122 |
+
No variant was written for ⑤ (going back to the first batch when the filter changes after Load more): `matches` allows the number of entries shown to be anywhere from n to all of them, so showing more counts as right; a user can hardly tell the difference, and adding a check just for this is not advised.
|
| 123 |
|
| 124 |
+
**Is the loosening of "back to all activity" too loose?** It was decided earlier that when a ticket can be read two ways, both count as right, so "back to all" may clear only the task or the Type along with it. `link-clears-all` (pass: `<Link to="/activity">` clears the Type too) is judged pass, in line with that rule. A few wrong ways of going back were also worked through: a "Show all" that keeps the task and clears only the Type, or a list that does not refresh after going back; the loosened branch fails both, as "neither all comments nor all activity". After going back to all, Comments is also selected once more and compared, so the loosening lets nothing wrong through. Not too loose.
|
| 125 |
|
| 126 |
+
The rest: `no-dedupe` (the round 5 bug) and `filter-replace-history` (Back cannot undo) are judged fail.
|
| 127 |
|
| 128 |
+
## notify-center (5 rounds)
|
| 129 |
|
| 130 |
+
Final requirements:
|
| 131 |
+
- Round 1: a sidebar link with the unread count ①; `/notifications` lists everything, newest first ②; unread ones stand out ③; Mark as read on each ④; Mark all as read ⑤; clicking a notification about a task opens the task and marks it read ⑥; bell, sidebar and page agree and are live ⑦.
|
| 132 |
+
- Round 2: All / Unread tabs ⑧; the tab is in the address and survives reload / Back ⑨; in Unread, an item marked read stays (dimmed) until you leave the page or reload ⑩.
|
| 133 |
+
- Round 3: a popup with the title and View ⑪; no popup while on the notifications page ⑫.
|
| 134 |
+
- Round 4 (changed requirement): popups only for tasks assigned to me ⑬; the tab title `(3) Team Tasks` ⑭.
|
| 135 |
+
- Round 5: while disconnected, the bell panel and the notifications page show Reconnecting… ⑮; what was missed is caught up on reconnect ⑯.
|
| 136 |
|
| 137 |
+
The judge checked ①②④⑥–⑨⑪–⑯; for ⑩ only "not kept after a reload". Round 3's "popup" is narrowed by round 4, and the judge follows round 4 (`popup-any-task` is judged fail), so it keeps up. Not checked:
|
| 138 |
|
| 139 |
+
**LEAK `no-mark-all-on-page`** (judged pass): the notifications page has no Mark all as read (the bell panel had one already). Round 1 of the ticket lists it among the page's requirements.
|
| 140 |
+
- Suggested fix: require a `/mark all as read/i` button on the notifications page; it can be clicked just before the final "catch up after a disconnect" to check all three places go to 0 and everything is read in the backend.
|
| 141 |
+
- Existing runs: all 17 runs have this button on the page (measured).
|
| 142 |
|
| 143 |
+
**LEAK `kept-survives-leave`** (judged pass): the record of "marked read but kept for now" in Unread lives in a module variable. A reload clears it; after leaving the page (clicking through to a task) and coming Back, the read item is still in Unread. ⑩ says "until you leave the page or reload", and the judge only checks the reload.
|
| 144 |
+
- Suggested fix: after marking one item read in Unread, open another notification to go to its task page, come Back to Unread and require the item to be gone (or, under the earlier reading "kept but shown as read is right too", shown as read; but once the page "has been left" it should be gone under both readings).
|
| 145 |
+
- Existing runs: none of the 17 runs keeps it after leaving and coming back (except the one Mirasim Computer Use trial run that was judged fail to begin with, where the probe cannot click through); not affected (measured).
|
| 146 |
|
| 147 |
+
No variant was written for ③ "unread stands out / read is dimmed": it is styling, hard for a judge to check in a general way. A fallback would be to check only that "an unread and a read item on the same page differ in class or in font-weight / opacity"; optional.
|
| 148 |
|
| 149 |
+
**Is the loosening of "kept but shown as read" too loose?** It only allows "A is in Unread but shown as read (Mark as read not visible or disabled)". An implementation that does not filter at all still fails, because "seeded[2], read from the start, is still there"; one that keeps A as unread (the button still clickable) fails too. `link-tabs` (pass: link-style tabs, `?filter=unread`, kept items showing the word Read) is judged pass. The loosening itself is not loose; what is loose is the missing "leaving the page" check above, which has nothing to do with it.
|
| 150 |
|
| 151 |
+
The rest: `no-catchup` is judged fail.
|
| 152 |
|
| 153 |
+
## recurring (5 rounds)
|
| 154 |
|
| 155 |
+
Final requirements:
|
| 156 |
+
- Round 1: completing through any of the four entry points creates the next task ①; title / priority / description / assignee / rule are copied ②; it is not done ③; the date moves on from the old due date by the rule (every 2 weeks +14 days, monthly on the same day) ④ (partly changed by round 4); with no due date, counted from today ⑤; the completed one stays completed ⑥.
|
| 157 |
+
- Round 2: the task page and the Board card show the rule and the due date ⑦⑧.
|
| 158 |
+
- Round 3: saving asks Only this task / This and future tasks ⑨; only this one changes and the next follows the old series ⑩; this and future: this one, every open one in the series and those created later all change ⑪; Cancel or Escape saves nothing and keeps the input ⑫.
|
| 159 |
+
- Round 4 (changed requirement): a daily / weekly task completed late counts from the completion day ⑬; monthly still adds a month to the old due date ⑭.
|
| 160 |
+
- Round 5: unticking and ticking again creates nothing more ⑮; Stop repeating switches off this task and the open ones of the series, deleting nothing ⑯⑰.
|
| 161 |
|
| 162 |
+
The judge keeps up with the changed requirements: `r1-rule-kept` (a weekly task completed late still counted from the old due date) and `monthly-from-completion` (monthly also counted from the completion day) are both judged fail. But the requirements of rounds 3, 4 and 5 are each checked along the "easiest" path only:
|
| 163 |
|
| 164 |
+
**LEAK `retick-guard-list-only`** (judged pass): "creates nothing more" is guarded only in toggleDone (list / Board); the Completed box on the task page and Status on the edit page go through updateTask, and unticking and ticking again adds another task. The judge only unticks and ticks in the task list.
|
| 165 |
+
**LEAK `stop-only-this`** (judged pass): Stop repeating only switches off the current task. The judge clicks Stop on the only open task of the series, so "along with the open ones of the series" was never checked.
|
| 166 |
+
**LEAK `future-skips-open-siblings`** (judged pass): This and future tasks does not change the other open tasks of the series. When the judge does this step the series has a single open task.
|
| 167 |
+
**LEAK `daily-late-from-due`** (judged pass): round 4 was only applied to weekly; a daily task completed late still counts from the old due date. The only daily task in the judge has no due date.
|
| 168 |
+
- Suggested fixes (all four can go into the existing flow together, which is the route the probe takes):
|
| 169 |
+
1. On the task page, untick and tick again a completed repeating task; there is still just 1 open task of that name;
|
| 170 |
+
2. On the task page of the completed previous task (such as n2) click Stop repeating and require the `recurrence` of the next one (n3) to become empty; if a completed task is thought not to need a Stop button, this can instead be "with two open tasks in the series (untick the previous one), click Stop on one of them and the other stops too";
|
| 171 |
+
3. In the same "two open tasks" state, choose This and future tasks on one of them to change the priority; the other must change too;
|
| 172 |
+
4. Add a daily task with a due date in the past; after completing it the next one is due tomorrow.
|
| 173 |
+
- Existing runs: the probe passes all four on the 10 runs (measured); adding them changes no verdict.
|
| 174 |
|
| 175 |
+
**STRICT `scope-radio-dialog`** (judged fail: does not ask Only this task / This and future tasks): the scope is asked with two radio options plus OK / Cancel (as Google Calendar does). The judge only accepts a **button** whose name matches `/only this/i`. The ticket only says "ask whether … Only this task or This and future tasks"; radio plus confirm is a reasonable way to do it.
|
| 176 |
+
- Suggested fix: accept `getByRole("button")` or `getByRole("radio")` or `getByLabel`; for a radio, select it first and then click OK / Save / Confirm / Apply in the dialog.
|
| 177 |
+
- Existing runs (estimate): all 10 runs use two buttons; not affected.
|
| 178 |
|
| 179 |
+
For ⑫ only Escape was checked, not the Cancel button; the risk is small and no variant was written.
|
| 180 |
|
| 181 |
---
|
| 182 |
|
| 183 |
+
## The five things to fix first
|
| 184 |
|
| 185 |
+
1. **viewer-role: remove the "clicked too early" race.** After `goto`, `settle(page)` first, then switch to Viewer and click Delete; along the way count a native alert as "told the user". At present the step "the task vanishes after the refusal" in fact cannot be checked, and an optimistic delete without rollback is judged pass.
|
| 186 |
+
2. **recurring: give the series operations of rounds 3 and 5 a path with "two tasks in the series"** (unticking and ticking again on the task page, Stop on a completed task, This and future with two open tasks), plus a daily task completed late. All four LEAKs are requirements from earlier rounds checked along the easiest path only.
|
| 187 |
+
3. **activity-log: after the changed requirement of round 4, check that Newer / Older are gone; compare the data once each for the Orders option and for "single task + Person".**
|
| 188 |
+
4. **white-screen: put in a task whose dueDate is null and open it; after clearing the due date, check the backend value and that the page shows neither the old date nor Invalid Date.** A half fix on the saving side alone is judged pass at present.
|
| 189 |
+
5. **Loosen three checks that accept a single way of doing it**: the scope dialog of recurring accepts radios; the wrong-password notice of session-expiry is not judged by wording; notify-center also gets "Mark all as read on the page" and "after leaving the page Unread no longer keeps the read item".
|
| 190 |
|
| 191 |
+
Going by the real runs so far, the verdicts of existing runs are expected not to change after these 5 fixes (1, 4 and 5 are estimates; 2, 3 and the two notify-center points were measured with the probe on every run).
|
| 192 |
|
| 193 |
---
|
| 194 |
|
| 195 |
+
## What was changed (second step)
|
| 196 |
|
| 197 |
+
Following the report above, all 13 LEAKs and 3 STRICTs were fixed in `tasks/flows.ts`, one change per task. The self-test is `harness/selftest.ts -j 1`, the variants `harness/audit.ts -j 1`; the spot re-judge runs on copies of real runs (the code is copied and judged, without writing back to the original verdicts).
|
| 198 |
|
| 199 |
+
| Task | What changed | Self-test | Variants | Spot re-judge |
|
| 200 |
|---|---|---|---|---|
|
| 201 |
+
| viewer-role | Stricter: `settle` before clicking Delete, fixing the race in which the duplicate first-screen request puts the task back; looser: a native alert that explains the refusal counts as telling the user | OK | 5/5 OK | ChatGPT Computer Use run 1, Mirasim Computer Use runs 2 and 3: pass → pass |
|
| 202 |
+
| session-expiry | Looser: the wrong-password notice is not judged by wording (role=alert or a new line of text, with the password still being asked for); race fixed: `settle` in two places before the session is made to expire; new variant `no-error-shown` | OK | 5/5 OK | ChatGPT Computer Use run 2 (re-judged 4 times) and run 3, Mirasim Computer Use runs 1 and 2: pass → pass |
|
| 203 |
+
| checkout-return | Stricter: once the checkout has opened, the Credits page must not show blocked | OK | 4/4 OK | ChatGPT Computer Use run 2, the two Mirasim Computer Use trial runs: pass → pass |
|
| 204 |
+
| white-screen | Stricter: the dueDate of task 3 is set to null first and the task then opened; after the due date is cleared the backend must be cleared and the page must not show the old date; no Invalid Date / NaN; new variants `omit-empty-and-guard`, `empty-string-null-guard` | OK | 6/6 OK | ChatGPT Computer Use run 1 and a trial run, Mirasim Computer Use run 3: pass → pass |
|
| 205 |
+
| activity-log | Stricter: no Newer / Older may remain after Load more; Person is stacked on single task + Type Comments; Orders is chosen on all activity and compared with the data. The loosening of "back to all activity" is unchanged | OK | 6/6 OK | ChatGPT Computer Use run 1 and a trial run, Mirasim Computer Use run 4 and a trial run: pass → pass |
|
| 206 |
+
| notify-center | Stricter: after marking an item read in Unread, leaving the page and coming Back, the item must not still be there; Mark all as read on the page must work. The loosening of "kept but shown as read" is unchanged | OK | 5/5 OK | ChatGPT Computer Use run 3 and a trial run, Mirasim Computer Use run 1 and a trial run: pass → pass; another Mirasim Computer Use trial run: not passed → not passed (same cause) |
|
| 207 |
+
| recurring | Stricter: a daily task completed late (task 10); unticking and ticking the Completed box on the task page; with two open tasks in the series, This and future and Stop repeating must both reach the other one (the judge waits for it); new tasks counted go from 6 to 7. Looser: radios plus a confirm button are accepted for the scope question | OK | 7/7 OK | ChatGPT Computer Use runs 1–5 and Mirasim Computer Use runs 1–5, 10 runs: all pass → pass |
|
| 208 |
+
| login-return, balance-refresh, wrong-param | Not changed: the audit found no LEAK / STRICT | OK | 10/10 OK | — |
|
| 209 |
+
|
| 210 |
+
Self-test 10/10 OK, variants 48/48 OK (the 45 original ones + 3 new).
|
| 211 |
+
|
| 212 |
+
No run changed verdict in the spot re-judge. Twice along the way the new judge itself gave a wrong verdict; both are fixed:
|
| 213 |
+
- **session-expiry, ChatGPT Computer Use run 2**: when only the wording had been changed at first, this run was judged fail in 2 of 4 re-judges (the save was not finished after sign-in). The cause: the judge let the session expire while the page's loading requests were still out; a late request hit the 401 first and brought up the re-sign-in dialog early, which blocked the click on Save that followed (the failed click was swallowed by `.catch`). The old judge had this race too and just never met it. With `settle` added, all 4 pass.
|
| 214 |
+
- **recurring, ChatGPT Computer Use run 4**: the judge read the other task straight after Stop repeating, while this run changes this task first and then the others of the series one by one; the judge read too early. Changed to wait for it, and the run passes.
|
docs/judge-audits/interaction-layout.md
CHANGED
|
@@ -1,245 +1,239 @@
|
|
| 1 |
-
#
|
| 2 |
|
| 3 |
-
|
| 4 |
|
| 5 |
-
|
| 6 |
`npx tsx harness/audit.ts -j 1 divider-lock card-stretch loading-veil sticky-save hover-ghost menu-clip narrow-nav dark-mode scroll-tail mention-trim type-scale`
|
| 7 |
-
→ 37/53 OK
|
| 8 |
|
| 9 |
-
|
| 10 |
-
|
| 11 |
-
**没有发现「判了通过但其实没做到题面要求」的局。**
|
| 12 |
|
| 13 |
-
##
|
| 14 |
|
| 15 |
-
|
|
| 16 |
|---|---|---|---|---|---|---|
|
| 17 |
-
| divider-lock | 3 | — | 4 | 0 | 0 |
|
| 18 |
-
| card-stretch | 4 | — | 4 | 0 | 0 |
|
| 19 |
-
| loading-veil | 5 |
|
| 20 |
-
| sticky-save | 4 | Notes
|
| 21 |
-
| hover-ghost | 3 | — | 5 | 0 | **2** |
|
| 22 |
-
| menu-clip | 3 | — | 4 | 0 | 0 |
|
| 23 |
-
| narrow-nav | 5 |
|
| 24 |
-
| dark-mode | 4 |
|
| 25 |
-
| scroll-tail | 2 | — | 4 | 0 | 0 |
|
| 26 |
-
| mention-trim | 6 |
|
| 27 |
-
| type-scale |
|
| 28 |
-
|
|
| 29 |
-
|
| 30 |
-
|
| 31 |
|
| 32 |
---
|
| 33 |
|
| 34 |
## divider-lock
|
| 35 |
|
| 36 |
-
|
| 37 |
|
| 38 |
-
|
|
| 39 |
|---|---|---|
|
| 40 |
-
| up-on-divider
|
| 41 |
-
| shield-passthrough
|
| 42 |
-
| pointer-capture
|
| 43 |
-
| buttons-released
|
| 44 |
|
| 45 |
-
10
|
| 46 |
|
| 47 |
## card-stretch
|
| 48 |
|
| 49 |
-
|
| 50 |
|
| 51 |
-
|
|
| 52 |
|---|---|---|
|
| 53 |
-
| raise-footer
|
| 54 |
-
| after-no-pointer
|
| 55 |
-
| star-only
|
| 56 |
-
| js-card-click
|
| 57 |
|
| 58 |
-
10
|
| 59 |
|
| 60 |
## loading-veil
|
| 61 |
|
| 62 |
-
|
| 63 |
|
| 64 |
-
|
| 65 |
|
| 66 |
-
|
|
| 67 |
|---|---|---|
|
| 68 |
| raise-links | fail | OK |
|
| 69 |
| no-spinner | fail | OK |
|
| 70 |
-
| **no-initial-spinner**
|
| 71 |
| visibility-hidden | pass | OK |
|
| 72 |
-
| **fade-with-spinner**
|
| 73 |
|
| 74 |
-
- LEAK no-initial-spinner
|
| 75 |
-
- STRICT fade-with-spinner
|
| 76 |
|
| 77 |
## sticky-save
|
| 78 |
|
| 79 |
-
|
| 80 |
|
| 81 |
-
|
|
| 82 |
|---|---|---|
|
| 83 |
-
| header-only-margin
|
| 84 |
-
| basics-only
|
| 85 |
-
| unstick-toolbar
|
| 86 |
-
| scroll-padding-html
|
| 87 |
|
| 88 |
-
10
|
| 89 |
|
| 90 |
## hover-ghost
|
| 91 |
|
| 92 |
-
|
| 93 |
|
| 94 |
-
|
|
| 95 |
|---|---|---|
|
| 96 |
-
| always-visible
|
| 97 |
-
| no-restore-pointer
|
| 98 |
-
| raise-title-link
|
| 99 |
-
| **display-none-hover**
|
| 100 |
-
| **visibility-hidden**
|
| 101 |
|
| 102 |
-
- STRICT
|
| 103 |
-
-
|
| 104 |
-
-
|
| 105 |
|
| 106 |
## menu-clip
|
| 107 |
|
| 108 |
-
|
| 109 |
|
| 110 |
-
|
|
| 111 |
|---|---|---|
|
| 112 |
-
| portal-no-flip
|
| 113 |
-
| open-upward-always
|
| 114 |
-
| unclip-inbox-only
|
| 115 |
-
| inplace-flip
|
| 116 |
|
| 117 |
-
|
| 118 |
|
| 119 |
## narrow-nav
|
| 120 |
|
| 121 |
-
|
| 122 |
|
| 123 |
-
|
| 124 |
|
| 125 |
-
|
|
| 126 |
|---|---|---|
|
| 127 |
-
| **menu-button-on-desktop**
|
| 128 |
-
| inflow-drawer
|
| 129 |
-
| inflow-no-close
|
| 130 |
-
| overlay-no-close
|
| 131 |
-
| right-drawer-named
|
| 132 |
-
| **toggle-sidebar-label**
|
| 133 |
|
| 134 |
-
- LEAK menu-button-on-desktop
|
| 135 |
-
- STRICT toggle-sidebar-label
|
| 136 |
|
| 137 |
## dark-mode
|
| 138 |
|
| 139 |
-
|
| 140 |
|
| 141 |
-
|
| 142 |
-
-
|
| 143 |
-
-
|
| 144 |
|
| 145 |
-
|
|
| 146 |
|---|---|---|
|
| 147 |
-
| **session-storage**
|
| 148 |
-
| no-system-default
|
| 149 |
-
| round1-only
|
| 150 |
-
| **dim-secondary**
|
| 151 |
-
| select-picker
|
| 152 |
|
| 153 |
-
- LEAK session-storage
|
| 154 |
-
- LEAK dim-secondary
|
| 155 |
|
| 156 |
## scroll-tail
|
| 157 |
|
| 158 |
-
|
| 159 |
|
| 160 |
-
|
|
| 161 |
|---|---|---|
|
| 162 |
-
| calc-short
|
| 163 |
-
| box-overflow-visible
|
| 164 |
-
| scroll-on-post
|
| 165 |
-
| grid-box
|
| 166 |
|
| 167 |
## mention-trim
|
| 168 |
|
| 169 |
-
|
| 170 |
|
| 171 |
-
|
| 172 |
|
| 173 |
-
|
|
| 174 |
|---|---|---|
|
| 175 |
-
| **no-avatar**
|
| 176 |
-
| **arrowup-broken**
|
| 177 |
| esc-broken | fail | OK |
|
| 178 |
-
| no-roles-esc-broken
|
| 179 |
-
| hidden-flex
|
| 180 |
-
| **no-roles**
|
| 181 |
|
| 182 |
-
- LEAK no-avatar
|
| 183 |
-
- LEAK arrowup-broken
|
| 184 |
-
- STRICT no-roles
|
| 185 |
|
| 186 |
## type-scale
|
| 187 |
|
| 188 |
-
|
| 189 |
|
| 190 |
-
|
| 191 |
-
-
|
| 192 |
-
-
|
| 193 |
|
| 194 |
-
|
|
| 195 |
|---|---|---|
|
| 196 |
| **avatar-12** | fail | **LEAK** |
|
| 197 |
| **done-13** | fail | **LEAK** |
|
| 198 |
| **comments-heading-13** | fail | **LEAK** |
|
| 199 |
| **title-bar-buttons-13** | fail | **LEAK** |
|
| 200 |
| **list-filters-13** | fail | **LEAK** |
|
| 201 |
-
| vars-in-global
|
| 202 |
|
| 203 |
-
-
|
| 204 |
-
-
|
| 205 |
-
-
|
| 206 |
|
| 207 |
---
|
| 208 |
|
| 209 |
-
##
|
| 210 |
|
| 211 |
-
1. **hover-ghost
|
| 212 |
-
2. **dark-mode
|
| 213 |
-
3. **type-scale
|
| 214 |
-
4. **mention-trim
|
| 215 |
-
5. **narrow-nav
|
| 216 |
|
| 217 |
-
|
| 218 |
|
| 219 |
-
|
| 220 |
|
| 221 |
---
|
| 222 |
|
| 223 |
-
##
|
| 224 |
|
| 225 |
-
|
| 226 |
-
|
| 227 |
-
|
| 228 |
|
| 229 |
-
|
|
| 230 |
|---|---|---|---|
|
| 231 |
-
| loading-veil |
|
| 232 |
-
| hover-ghost |
|
| 233 |
-
| narrow-nav |
|
| 234 |
-
| dark-mode |
|
| 235 |
-
| mention-trim |
|
| 236 |
-
| type-scale |
|
| 237 |
-
|
| 238 |
-
|
| 239 |
-
|
| 240 |
-
**hover-ghost
|
| 241 |
-
「点任务名打不开(点在 div.row-actions 上)」。原因是这两个变体只换了隐藏方式,悬停时那个整行宽的透明容器
|
| 242 |
-
照样显示、盖住任务名,工单的 bug 根本没修。所以它们是错的实现,why.md 改成 expect fail 并写明理由;审计时
|
| 243 |
-
记的这 2 处 STRICT,实质是判分抛错(includeHidden 的问题确实存在,已改)。另加 display-none-compact、
|
| 244 |
-
visibility-compact(容器 pointer-events: none、按钮 auto,再用 display / visibility 隐藏)作为真正对的
|
| 245 |
-
换写法,旧判分会因找不到按钮抛错,新判分判通过。
|
|
|
|
| 1 |
+
# Judge audit: interaction and layout tasks (11 tasks)
|
| 2 |
|
| 3 |
+
Only tasks in the v1 suite are kept here.
|
| 4 |
|
| 5 |
+
The variants are in `audit-variants/<id>/`, 53 in all (including the 3 that hover-ghost already had). The last full run:
|
| 6 |
`npx tsx harness/audit.ts -j 1 divider-lock card-stretch loading-veil sticky-save hover-ghost menu-clip narrow-nav dark-mode scroll-tail mention-trim type-scale`
|
| 7 |
+
→ 37/53 OK, **LEAK 11, STRICT 5**, ERR 0.
|
| 8 |
|
| 9 |
+
Real runs: the diffs of every run on both sides, ChatGPT Computer Use and Mirasim Computer Use, were read for all 11 tasks (6–13 runs per task, all judged pass). For a few things the judge did not measure, a read-only script measured them on the code of existing runs: 8 type-scale runs, 10 narrow-nav runs and 6 dark-mode runs (see each section).
|
| 10 |
+
**No run was found that was judged pass without doing what the ticket asks.**
|
|
|
|
| 11 |
|
| 12 |
+
## Summary
|
| 13 |
|
| 14 |
+
| Task id | Requirements | Requirements not checked | Variants | LEAK | STRICT | Wrong verdicts on real runs |
|
| 15 |
|---|---|---|---|---|---|---|
|
| 16 |
+
| divider-lock | 3 | — | 4 | 0 | 0 | none |
|
| 17 |
+
| card-stretch | 4 | — | 4 | 0 | 0 | none |
|
| 18 |
+
| loading-veil | 5 | The spinner on the first load | 5 | 1 | 1 (borderline) | none |
|
| 19 |
+
| sticky-save | 4 | The Notes link (the page is already at the bottom, so it cannot be tested; can be left) | 4 | 0 | 0 | none |
|
| 20 |
+
| hover-ghost | 3 | — | 5 | 0 | **2** | none |
|
| 21 |
+
| menu-clip | 3 | — | 4 | 0 | 0 | none |
|
| 22 |
+
| narrow-nav | 5 | No extra Menu button in the header on wide screens; the button being in the header | 6 | 1 | 1 (borderline) | none |
|
| 23 |
+
| dark-mode | 4 | Remembered "on a later visit"; secondary text readable | 5 | 2 | 0 | none |
|
| 24 |
+
| scroll-tail | 2 | — | 4 | 0 | 0 | none |
|
| 25 |
+
| mention-trim | 6 | The avatar still being there; the ↑ key | 6 | 2 | 1 | none |
|
| 26 |
+
| type-scale | about 25 | Avatar initials, Edit / Copy link in the task page header, and the list header and filters left alone; Done=12 and Comments=14 only checked as "one of the three sizes" | 6 | 5 | 0 | none |
|
| 27 |
+
| Total | | | 53 | 11 | 5 | |
|
| 28 |
+
|
| 29 |
+
Under "would changing the judge affect existing runs", "measured" means measured by script on the code of existing runs, and "estimate" means only the diff was read.
|
| 30 |
|
| 31 |
---
|
| 32 |
|
| 33 |
## divider-lock
|
| 34 |
|
| 35 |
+
Requirements: after a drag the page can be clicked (tasks, buttons); the cursor is restored; dragging still changes the width and stops on release. All checked.
|
| 36 |
|
| 37 |
+
| Variant | Expect | Result |
|
| 38 |
|---|---|---|
|
| 39 |
+
| up-on-divider (release handled in the divider's onPointerUp, no capture) | fail | OK |
|
| 40 |
+
| shield-passthrough (the shield gets pointer-events: none and loses the cursor; the drag never ends) | fail | OK |
|
| 41 |
+
| pointer-capture (setPointerCapture + onPointerUp) | pass | OK |
|
| 42 |
+
| buttons-released (ends the drag when pointermove finds the button released) | pass | OK |
|
| 43 |
|
| 44 |
+
All 10 runs change mouseup → pointerup; no problem with the judge.
|
| 45 |
|
| 46 |
## card-stretch
|
| 47 |
|
| 48 |
+
Requirements: ★, Mark done and ✕ can be clicked without navigating; the rest of the card (including the empty part of the footer and the title) still opens the task. All checked; the three buttons are clicked one by one on three different cards, and the empty part of the footer is clicked too.
|
| 49 |
|
| 50 |
+
| Variant | Expect | Result |
|
| 51 |
|---|---|---|
|
| 52 |
+
| raise-footer (the whole footer raised above the stretched layer) | fail | OK (the empty part of the footer no longer opens the task) |
|
| 53 |
+
| after-no-pointer (pointer-events: none on ::after) | fail | OK |
|
| 54 |
+
| star-only (only the star fixed) | fail | OK |
|
| 55 |
+
| js-card-click (::after removed, onClick on the li navigates) | pass | OK |
|
| 56 |
|
| 57 |
+
All 10 runs use `.card-actions button { position: relative; z-index: 2 }`; no problem with the judge.
|
| 58 |
|
| 59 |
## loading-veil
|
| 60 |
|
| 61 |
+
Requirements: on a slow network, once the list has loaded a task can be opened by clicking; hover brings out ✓/☆; ⋯ opens; the same after switching Status; a spinner keeps showing while loading.
|
| 62 |
|
| 63 |
+
Not checked: **the spinner on the first load**. At its start the judge only waits for the loading indicator to go away and never requires it to have appeared; it requires it to appear only on the filter switch.
|
| 64 |
|
| 65 |
+
| Variant | Expect | Result |
|
| 66 |
|---|---|---|
|
| 67 |
| raise-links | fail | OK |
|
| 68 |
| no-spinner | fail | OK |
|
| 69 |
+
| **no-initial-spinner** (the veil only covers the list when it already has tasks; nothing on the first load) | fail | **LEAK** |
|
| 70 |
| visibility-hidden | pass | OK |
|
| 71 |
+
| **fade-with-spinner** (the fading veil gets pointer-events: none; the spinner fades with it and stays in the DOM) | pass | **STRICT**: the loading indicator never goes away |
|
| 72 |
|
| 73 |
+
- LEAK no-initial-spinner: suggested fix, before `openInbox` (or with a goto first and a wait after) require a loading indicator on the list within 1s (the judging scenario has a 1200ms delay and the veil appears after 300ms, so there is time). Effect on existing runs: none by estimate; none of the 12 runs puts a condition such as "only when there is data" on the veil.
|
| 74 |
+
- STRICT fade-with-spinner (borderline): `loadingShown` uses Playwright's `isVisible()`, which does not look at opacity, so a spinner at opacity 0 counts as "still there". This approach looks right and clicks right, but the role=status "Loading tasks" stays in the accessibility tree and a screen reader keeps reading it, so whether it is right is open to discussion. To loosen it: have `loadingShown` use `checkVisibility({ opacityProperty: true, visibilityProperty: true })`. Effect on existing runs: none (no run keeps the spinner).
|
| 75 |
|
| 76 |
## sticky-save
|
| 77 |
|
| 78 |
+
Requirements: clicking Basics from the bottom leaves Title not covered by the toolbar and clickable; the same for the first line of Planning; (the same for the other section links); the toolbar still sticks to the top. The judge checked Basics, Planning, Repeat, the sticking and saving. Notes was not checked (from the bottom, jumping to Notes does not move the page, so nothing can be seen; can be left).
|
| 79 |
|
| 80 |
+
| Variant | Expect | Result |
|
| 81 |
|---|---|---|
|
| 82 |
+
| header-only-margin (only the header's height is allowed for) | fail | OK |
|
| 83 |
+
| basics-only (only Basics fixed) | fail | OK |
|
| 84 |
+
| unstick-toolbar (the sticking removed) | fail | OK |
|
| 85 |
+
| scroll-padding-html (scroll-padding-top on html) | pass | OK |
|
| 86 |
|
| 87 |
+
All 10 runs measure the toolbar's height into a variable and use scroll-margin-top; no problem with the judge.
|
| 88 |
|
| 89 |
## hover-ghost
|
| 90 |
|
| 91 |
+
Requirements: clicking a task's name opens it; the ✓/☆ that hover brings out can be clicked as before; they do not show otherwise. All checked.
|
| 92 |
|
| 93 |
+
| Variant | Expect | Result |
|
| 94 |
|---|---|---|
|
| 95 |
+
| always-visible (sample) | fail | OK |
|
| 96 |
+
| no-restore-pointer (sample) | fail | OK |
|
| 97 |
+
| raise-title-link (the link raised above the hover layer, covering the buttons) | fail | OK |
|
| 98 |
+
| **display-none-hover** (sample: display: none normally, display: flex on hover) | pass | **STRICT**: check threw: locator.evaluate: Timeout 5000ms exceeded |
|
| 99 |
+
| **visibility-hidden** (visibility: hidden normally, visible on hover) | pass | **STRICT**: same |
|
| 100 |
|
| 101 |
+
- Cause of the STRICT: as its first step the judge finds the button with `page.getByRole("button", { name: "Star Release checklist" })` and then uses `evaluate(checkVisibility)` to see whether it is hidden. By default `getByRole` does not match elements with display: none / visibility: hidden (they are not in the accessibility tree), so it finds nothing, waits 5 seconds and throws. These are the two most common ways to hide something, and both are judged fail.
|
| 102 |
+
- Suggested fix: change this step to `getByRole("button", { name, includeHidden: true })`, or treat "not found" as "not shown"; the later lookups after hovering need no change.
|
| 103 |
+
- Effect on existing runs: none. All 13 runs use opacity + pointer-events (measured: every diff was read).
|
| 104 |
|
| 105 |
## menu-clip
|
| 106 |
|
| 107 |
+
Requirements: the ⋯ menu of the last rows of the list shows in full, and Move to Done and Delete can be clicked; the menus of rows higher up still open next to ⋯. All checked.
|
| 108 |
|
| 109 |
+
| Variant | Expect | Result |
|
| 110 |
|---|---|---|
|
| 111 |
+
| portal-no-flip (attached to body but always opens downwards) | fail | OK (Delete is outside the window) |
|
| 112 |
+
| open-upward-always (in place, always opens upwards) | fail | OK (clipped on the first row) |
|
| 113 |
+
| unclip-inbox-only (only the outer frame's overflow: hidden removed) | fail | OK |
|
| 114 |
+
| inplace-flip (not attached to body; measures the height left in the scroll area and opens upwards when it does not fit) | pass | OK |
|
| 115 |
|
| 116 |
+
The judge does not require a portal, so another approach is not failed wrongly. All 10 runs use a portal + flip.
|
| 117 |
|
| 118 |
## narrow-nav
|
| 119 |
|
| 120 |
+
Requirements: no horizontal scrolling at 390px wide; the navigation is tucked behind a Menu button in the header; opened, it lies over the page; choosing a page goes there and closes it; in a desktop window the sidebar (and the header) stay as they were.
|
| 121 |
|
| 122 |
+
Not checked: **an extra Menu button in the header on wide screens** (at 1200px the judge only looks at whether the sidebar links are still on the left); whether the Menu button is in the header (it looks for any visible button on the page whose name has menu/navigation in it).
|
| 123 |
|
| 124 |
+
| Variant | Expect | Result |
|
| 125 |
|---|---|---|
|
| 126 |
+
| **menu-button-on-desktop** (the drawer is right, the Menu button also shows on wide screens) | fail | **LEAK** |
|
| 127 |
+
| inflow-drawer (the navigation is inserted at the top of the page and pushes the content down) | fail | OK (the judge scrolls a task into view first, and the navigation opened at the top is then off screen) |
|
| 128 |
+
| inflow-no-close (same, and choosing a page does not close it) | fail | OK (same; fails at the first step) |
|
| 129 |
+
| overlay-no-close (the reference drawer, not closed when a page is chosen) | fail | OK |
|
| 130 |
+
| right-drawer-named (the button is called Open navigation and it slides in from the right) | pass | OK |
|
| 131 |
+
| **toggle-sidebar-label** (the reference solution with the button's accessible name Toggle sidebar) | pass | **STRICT** (borderline): there is no Menu button |
|
| 132 |
|
| 133 |
+
- LEAK menu-button-on-desktop: suggested fix, add to the 1200px part: no visible button whose name matches `/menu|navigation/i` (or the number of buttons in the header is the same as before). Effect on existing runs: none (measured: at 1200px the visible buttons of the 10 runs are only Notifications, Dark mode and the page's own buttons).
|
| 134 |
+
- STRICT toggle-sidebar-label (borderline): the ticket's words are "a Menu button", so requiring it to be called Menu is defensible; to loosen it, accept a button in the header whose `aria-controls` points at the navigation, or one with `aria-expanded`. Effect on existing runs: none.
|
| 135 |
|
| 136 |
## dark-mode
|
| 137 |
|
| 138 |
+
Requirements: 1) follows the system when nothing was chosen; 2) a choice is remembered across a reload; 3) remembered on a later visit (come back later); 4) the Inbox is dark and the text readable.
|
| 139 |
|
| 140 |
+
Not checked:
|
| 141 |
+
- "A later visit": both of the judge's "remembered" checks happen in the same tab (`reload` and `goto`), which sessionStorage passes too.
|
| 142 |
+
- "Readable" was only measured on the main text (titles, descriptions, comment bodies, section headings), not on secondary text (priority / Done in a row, field names, comment author and time, attachment size, the task count).
|
| 143 |
|
| 144 |
+
| Variant | Expect | Result |
|
| 145 |
|---|---|---|
|
| 146 |
+
| **session-storage** (the choice kept in sessionStorage) | fail | **LEAK** |
|
| 147 |
+
| no-system-default (does not follow the system) | fail | OK |
|
| 148 |
+
| round1-only (round 2 not done) | fail | OK |
|
| 149 |
+
| **dim-secondary** (the Inbox is dark, secondary text #39404d, about 1.6:1) | fail | **LEAK** |
|
| 150 |
+
| select-picker (the switch replaced by a System / Light / Dark dropdown) | pass | OK |
|
| 151 |
|
| 152 |
+
- LEAK session-storage: suggested fix, after choosing, open the app with `newPage()` in the same context (a new tab shares localStorage and not sessionStorage) and look at the theme; or carry the storageState into a new context. Effect on existing runs: none (all 6 runs use localStorage; the diffs were read).
|
| 153 |
+
- LEAK dim-secondary: suggested fix, add a few secondary texts to `checks` (the meta of a list row, the dt field names, comment author and time, attachment size), with a threshold of 3:1 or 4.5:1. The lowest measured on the reference solution is the comment time at 5.2:1, so 4.5 passes too. Effect on existing runs: none (measured: the lowest of these texts over the 6 runs is 6.2:1).
|
| 154 |
|
| 155 |
## scroll-tail
|
| 156 |
|
| 157 |
+
Requirements: scrolled to the end, the last item shows in full; a newly posted comment is not hidden. All checked.
|
| 158 |
|
| 159 |
+
| Variant | Expect | Result |
|
| 160 |
|---|---|---|
|
| 161 |
+
| calc-short (too little height subtracted) | fail | OK |
|
| 162 |
+
| box-overflow-visible (the outer frame's clipping removed; the list runs over the comment box) | fail | OK |
|
| 163 |
+
| scroll-on-post (only scrolls to the end after a comment is posted) | fail | OK |
|
| 164 |
+
| grid-box (outer frame grid, list minmax(0, 1fr)) | pass | OK |
|
| 165 |
|
| 166 |
## mention-trim
|
| 167 |
|
| 168 |
+
Requirements: each row keeps only the avatar and the name; the email is removed; the ID is removed; the name takes the whole row and a long name shows on one line; on the keyboard ↑↓ move, Enter/Tab pick, Esc closes.
|
| 169 |
|
| 170 |
+
Not checked: **the avatar still being there**; **the ↑ key** (only ↓ was pressed).
|
| 171 |
|
| 172 |
+
| Variant | Expect | Result |
|
| 173 |
|---|---|---|
|
| 174 |
+
| **no-avatar** (the avatar removed too) | fail | **LEAK** |
|
| 175 |
+
| **arrowup-broken** (↑ no longer moves) | fail | **LEAK** |
|
| 176 |
| esc-broken | fail | OK |
|
| 177 |
+
| no-roles-esc-broken (roles removed and Esc broken) | fail | OK (but see the STRICT below: it is failed by another step) |
|
| 178 |
+
| hidden-flex (JSX untouched, email/ID display: none, the row changed to flex) | pass | OK |
|
| 179 |
+
| **no-roles** (the reference solution with only the listbox/option roles removed) | pass | **STRICT**: typing @maxi does not show the matching member |
|
| 180 |
|
| 181 |
+
- LEAK no-avatar: suggested fix, each option must have an avatar (for example a non-text element of ≥16px to the left of the name inside the option, or an element with the member's initials). Effect on existing runs: none (the diffs of the 8 runs only remove the two spans for the email and the ID).
|
| 182 |
+
- LEAK arrowup-broken: suggested fix, change the keyboard part to ↓↓↑ and then Enter, requiring the second option to be picked. Effect on existing runs: none (none of the 8 runs touches the key handling).
|
| 183 |
+
- STRICT no-roles (borderline): without a listbox, `mentionPopup` falls back to "a container that holds both Priya Shah and Diego Alvarez"; after typing @maxi the filter leaves one person and it can never be found. Also, the Esc step only counts `role=option`, so without roles "not closed" does not show either. Suggested fix: remember the popup the first time it is found (or its id / class name) and use the same element afterwards to tell whether it is still shown. Effect on existing runs: none (all 8 runs keep the roles).
|
| 184 |
|
| 185 |
## type-scale
|
| 186 |
|
| 187 |
+
Requirements (about 25): the three sizes are used for the kinds of text the ticket lists; avatar initials, Board column headings, the task page header (title, Edit, Copy link), the list header and filters, and other pages are left alone.
|
| 188 |
|
| 189 |
+
The judge measures most of the named elements exactly and for the rest only requires "one of 12/13/14". Not checked, or only checked for the range:
|
| 190 |
+
- Left alone: **avatar initials** (they have aria-hidden, which `sizesIn` skips outright), **Edit / Copy link in the task page header** (`sizesIn(pane, head)` excludes the header, and only the title is measured), **the list header and filters** (Status, the search box and the task count were not measured).
|
| 191 |
+
- Range only: **the Done mark should be 12**, **the Comments section heading should be 14**, Attach file and the "Add a comment" label should be 13.
|
| 192 |
|
| 193 |
+
| Variant | Expect | Result |
|
| 194 |
|---|---|---|
|
| 195 |
| **avatar-12** | fail | **LEAK** |
|
| 196 |
| **done-13** | fail | **LEAK** |
|
| 197 |
| **comments-heading-13** | fail | **LEAK** |
|
| 198 |
| **title-bar-buttons-13** | fail | **LEAK** |
|
| 199 |
| **list-filters-13** | fail | **LEAK** |
|
| 200 |
+
| vars-in-global (the three sizes written in the global styles.css with CSS variables and other selectors) | pass | OK |
|
| 201 |
|
| 202 |
+
- Suggested fix: add the exact values item by item from the ticket: avatar initials 11px (the original value), Edit / Copy link 15px (the original value), the Status filter and the search box 15px, the task count 13px, Done 12px, the Comments heading 14px, Attach file and Add a comment 13px. `sizesIn` skips aria-hidden so as not to count the avatar among the three sizes, which is fine; the avatar just has to be measured once on its own.
|
| 203 |
+
- Effect on existing runs: none (measured: on the 8 runs all of these values agree with the ticket).
|
| 204 |
+
- In passing: the first version of vars-in-global was judged fail because the variant's own selector specificity was wrong (the attachment name was overridden by 13px); corrected, it passes. Not a STRICT.
|
| 205 |
|
| 206 |
---
|
| 207 |
|
| 208 |
+
## The five things to fix first
|
| 209 |
|
| 210 |
+
1. **hover-ghost: `getByRole` does not find a button with display: none / visibility: hidden, and the judge throws** (STRICT ×2). The two most common ways to hide something are both failed wrongly. Change the first step to `includeHidden: true`, or treat "not found" as "not shown".
|
| 211 |
+
2. **dark-mode: "still remembered on a later visit" is not tested** (LEAK). sessionStorage passes. After choosing, `context.newPage()` and look at the theme. Measure the contrast of secondary text along the way (LEAK dim-secondary).
|
| 212 |
+
3. **type-scale: the "leave alone" places and the Done / Comments heading are not measured exactly** (LEAK ×5). Add the exact values item by item from the ticket and measure the avatar initials once on their own.
|
| 213 |
+
4. **mention-trim: the avatar and the ↑ key are not checked** (LEAK ×2). Both are stated in the ticket and take one line each in the judge.
|
| 214 |
+
5. **narrow-nav: an extra Menu button on wide screens is not checked** (LEAK). Likewise one line.
|
| 215 |
|
| 216 |
+
Next: the spinner on the first load of loading-veil (LEAK), the popup fallback of mention-trim (STRICT, borderline), `isVisible` not looking at opacity in loading-veil (STRICT, borderline), narrow-nav accepting only a button with menu/navigation in its name (STRICT, borderline).
|
| 217 |
|
| 218 |
+
All of these judge changes only make implementations that "miss something the ticket asks for" fail, or make correct implementations done another way pass; by the measured data and the diffs, **the verdict of no existing run changes**.
|
| 219 |
|
| 220 |
---
|
| 221 |
|
| 222 |
+
## What was changed (everything in the report)
|
| 223 |
|
| 224 |
+
6 tasks were changed. The judge code is only touched in `tasks/interaction.ts` and `tasks/layout.ts`; shared files, Team Tasks, the reference solutions and the seeds were not touched.
|
| 225 |
+
The last full `npx tsx harness/audit.ts -j 1` (11 tasks): **55/55 OK**; `harness/selftest.ts` for the 6 tasks all gives "the seed is judged fail, the reference solution pass".
|
| 226 |
+
The spot re-judge used the read-only re-judge script (which does not write back to the result files): **30 runs in all, every one still judged pass, no verdict changed**.
|
| 227 |
|
| 228 |
+
| Task | What changed | Variants | Spot re-judge (read-only) |
|
| 229 |
|---|---|---|---|
|
| 230 |
+
| loading-veil | Stricter: opening the Inbox for the first time (slow network) must show a loading indicator within 1.5s. Looser: whether the loading indicator is shown now uses checkVisibility (which looks at opacity) | 5/5 OK (no-initial-spinner is judged fail, fade-with-spinner pass) | ChatGPT Computer Use runs 1 and 3, Mirasim Computer Use runs 4 and 5 pass |
|
| 231 |
+
| hover-ghost | Looser: ✓/☆ are found with includeHidden; the row is hovered before ☆ is clicked | 7/7 OK, see below | ChatGPT Computer Use runs 1 and 5, Mirasim Computer Use run 2 and a trial run pass |
|
| 232 |
+
| narrow-nav | Stricter: at 1200px the narrow-screen menu button must not still show. Looser: a menu button with sidebar in its name, or with aria-controls pointing at the main navigation, is accepted too | 6/6 OK | ChatGPT Computer Use run 1 and a trial run, two Mirasim Computer Use trial runs pass |
|
| 233 |
+
| dark-mode | Stricter: after choosing light and reloading, a new tab (with the system still dark) must be light too; in dark, the contrast of 6 pieces of secondary text is ≥ 3:1 | 5/5 OK | ChatGPT Computer Use runs 1–3, Mirasim Computer Use runs 1–3 pass |
|
| 234 |
+
| mention-trim | Stricter: each row must have an avatar to the left of the name; the keyboard part is now ↓↓↑ and Enter picking the second option. Looser: without a listbox, the popup found the first time is remembered (tag + class name) and looked up again; whether Esc closed it is judged on that popup too | 6/6 OK | ChatGPT Computer Use runs 1 and 2, Mirasim Computer Use run 2 and a trial run pass |
|
| 235 |
+
| type-scale | Stricter: Done 12, the Comments heading 14, and Attach file and Add a comment 13 are now exact values; avatar initials 11, Edit / Copy link in the task page header 15, the Status filter and the search box 15 and the task count 13 must keep their original values | 6/6 OK | ChatGPT Computer Use runs 1–3, Mirasim Computer Use runs 1–3 and two trial runs pass (all 8 runs judged) |
|
| 236 |
+
|
| 237 |
+
The 5 tasks not changed: divider-lock, card-stretch, sticky-save, menu-clip, scroll-tail; the audit found no LEAK / STRICT in them.
|
| 238 |
+
|
| 239 |
+
**The verdict on hover-ghost's sample variants changed**: once the judge was fixed and no longer throws, display-none-hover and visibility-hidden are both judged "clicking the task's name does not open it (the click lands on div.row-actions)". The cause is that these two variants only change how things are hidden; on hover the transparent container as wide as the row still shows and covers the task's name, so the ticket's bug is not fixed at all. They are therefore wrong implementations, and their why.md was changed to expect fail with the reason given; the 2 STRICTs recorded in the audit were in substance the judge throwing (the includeHidden problem is real and is fixed). display-none-compact and visibility-compact were added (container pointer-events: none, buttons auto, then hidden with display / visibility) as the really correct alternatives: the old judge throws because it cannot find the button, and the new judge passes them.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
docs/judging.md
CHANGED
|
@@ -28,7 +28,7 @@ Each task has a script in `judges/real-projects/` that takes the dev server's UR
|
|
| 28 |
| Real projects, fix | `... --dry --fixed` | The upstream fix (`git diff base merge -- fixPaths`, source files only) must pass |
|
| 29 |
| Real projects, live fix | `... --dry --fixed --live` | The fix applied while the dev server runs must pass after hot reload, so a fix made by the agent is visible to the judge |
|
| 30 |
|
| 31 |
-
The audit was done task by task: list every requirement in the ticket, check which ones the judge tests, write variants for the gaps, fix the judge, and re-read the real runs for verdicts that would change. Notes per group of tasks
|
| 32 |
|
| 33 |
## Re-judging
|
| 34 |
|
|
|
|
| 28 |
| Real projects, fix | `... --dry --fixed` | The upstream fix (`git diff base merge -- fixPaths`, source files only) must pass |
|
| 29 |
| Real projects, live fix | `... --dry --fixed --live` | The fix applied while the dev server runs must pass after hot reload, so a fix made by the agent is visible to the judge |
|
| 30 |
|
| 31 |
+
The audit was done task by task: list every requirement in the ticket, check which ones the judge tests, write variants for the gaps, fix the judge, and re-read the real runs for verdicts that would change. Notes per group of tasks: [`docs/judge-audits/`](judge-audits/).
|
| 32 |
|
| 33 |
## Re-judging
|
| 34 |
|