mtybilly commited on
Commit
7d42e6f
·
verified ·
1 Parent(s): cb3c14c

Say that the fs rule errs toward removing more

Browse files
Files changed (1) hide show
  1. README.md +3 -0
README.md CHANGED
@@ -168,6 +168,9 @@ pinned revisions. It needs `rdkit` and `pandas`.
168
  high: the upstream corpus covers few distinct conditions. Each removed row's
169
  correct mechanism description appears verbatim in the test split, so the cut
170
  is warranted even though no molecule is involved.
 
 
 
171
  - Reaction subtasks are keyed on the reaction the question names, not on every
172
  molecule it mentions. Common solvents and reagents recur throughout both
173
  splits and keying on them would empty the training set for no gain.
 
168
  high: the upstream corpus covers few distinct conditions. Each removed row's
169
  correct mechanism description appears verbatim in the test split, so the cut
170
  is warranted even though no molecule is involved.
171
+ - `fs` is keyed on the reactants whichever of its two questions a row asks, so a
172
+ byproduct training row that shares reactants with a major-product test row is
173
+ removed too. That errs toward removing more, not less.
174
  - Reaction subtasks are keyed on the reaction the question names, not on every
175
  molecule it mentions. Common solvents and reagents recur throughout both
176
  splits and keying on them would empty the training set for no gain.