File size: 14,704 Bytes
f3b0a91 | 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 57 58 59 60 61 62 63 64 65 66 67 68 69 70 71 72 73 74 75 76 77 78 79 80 81 82 83 84 85 86 87 88 89 90 91 92 93 94 95 96 97 98 99 100 101 102 103 104 105 106 107 108 109 110 111 112 113 114 115 116 117 118 119 120 121 122 123 124 125 126 127 128 129 130 131 132 133 134 135 136 137 138 139 140 141 142 143 144 145 146 147 148 149 150 151 152 153 154 155 156 157 158 159 160 161 162 163 164 165 166 167 168 169 170 171 172 173 174 175 176 177 178 179 180 181 182 183 184 185 186 187 188 189 190 191 192 193 194 195 196 197 198 199 200 201 202 203 204 205 206 207 208 209 210 211 212 213 214 215 216 217 218 219 220 221 222 223 224 225 226 227 228 229 230 231 232 233 234 235 236 237 238 239 240 241 242 243 244 245 246 247 248 249 250 251 252 253 254 255 256 257 258 259 260 261 262 263 264 265 266 267 268 269 270 271 272 273 274 275 276 277 278 279 280 281 282 283 284 285 286 287 288 289 290 291 292 | """AlertForge grader: one source of truth for Harbor (tests/grade.py) and the OpenEnv server.
Usage (inside the verifier):
python3 -I /tests/grade.py --workspace /workspace/monitoring --spec /tests/spec.json \
--hidden /tests/hidden --out /logs/verifier/reward.json --details /logs/verifier/details.json
"""
from __future__ import annotations
import argparse
import json
import os
import shutil
import tempfile
import time
from . import amcheck
from .loader import YamlError, index_rules, safe_yaml, scan
from .promrun import alert_count_expr, check_rules, dyn_probe, run_tests, write_rule_files
from .static import am_tamper, best_definition, preservation, rule_tamper, template_labels
KEYS = ["reward", "solved", "outcome", "progress", "preservation", "req_alerts", "req_repairs",
"req_recording", "req_routing", "req_inhibit", "fire_rate", "silent_rate", "label_rate",
"check_pass_rate", "syntax_ok", "tamper"]
CATEGORIES = ["req_alerts", "req_repairs", "req_recording", "req_routing", "req_inhibit"]
DUP_FACTOR = 0.8
S_MIN = -0.25
def _mean(xs) -> float:
xs = list(xs)
return sum(xs) / len(xs) if xs else 1.0
def zero_keys(tamper: bool) -> dict:
d = {k: 0.0 for k in KEYS}
d["tamper"] = 1.0 if tamper else 0.0
return d
def load_hidden(hidden_dir: str) -> tuple[list[dict], list]:
with open(os.path.join(hidden_dir, "scenarios.json")) as fh:
groups = json.load(fh)
oracle_records = []
p = os.path.join(hidden_dir, "oracle_records.yml")
if os.path.exists(p):
with open(p) as fh:
oracle_records = (safe_yaml(fh.read()) or {}).get("groups") or []
return groups, oracle_records
class Grader:
"""Grades a workspace against one task's hidden spec. Reusable across calls (OpenEnv caching)."""
def __init__(self, spec: dict, hidden_dir: str):
self.spec = spec
self.groups, self.oracle_records = load_hidden(hidden_dir)
self._cache: dict[str, tuple[dict, dict]] = {}
# ------------------------------------------------------------------ public
def grade(self, workspace: str) -> tuple[dict, dict]:
ws = scan(workspace)
if ws.fingerprint in self._cache and not ws.tamper:
return self._cache[ws.fingerprint]
tmp = tempfile.mkdtemp(prefix="af-grade-")
try:
out = self._grade(ws, tmp)
finally:
if os.environ.get("AF_KEEP_TMP"): # debugging: keep promtool inputs and JUnit output
print(f"af-grade: kept {tmp}")
else:
shutil.rmtree(tmp, ignore_errors=True)
self._cache[ws.fingerprint] = out
return out
# ------------------------------------------------------------------ internals
def _grade(self, ws, tmp: str) -> tuple[dict, dict]:
t0 = time.time()
spec = self.spec
syntax_err = check_rules(ws.rule_files, os.path.join(tmp, "check"))
ok_files = [f for f in ws.rule_files if f.groups is not None and f.path not in syntax_err]
alerts, records, every = index_rules(ok_files)
tamper = list(ws.tamper) + rule_tamper(every, set(spec.get("input_metrics", [])))
am, am_ok, am_msg, am_path = None, False, "alertmanager.yml missing", ""
if ws.am_text is not None:
try:
am = safe_yaml(ws.am_text)
if isinstance(am, dict):
am_path = amcheck.route_config_path(tmp, ws.am_text)
am_ok, am_msg = amcheck.check_config(am_path, ws.am_text)
tamper += am_tamper(am)
else:
am_msg = "alertmanager.yml is not a mapping"
except YamlError as e:
am_msg = str(e)
syntax_ok = not syntax_err and am_ok
details: dict = {"syntax_errors": syntax_err, "alertmanager": am_msg, "tamper": tamper,
"requirements": {}, "checks": {}}
if tamper:
details["seconds"] = round(time.time() - t0, 3)
return zero_keys(True), details
reqs = spec["requirements"]
static, extra = self._static_and_dynamic(reqs, alerts)
order: list[str] = []
rule_paths = write_rule_files(ok_files, os.path.join(tmp, "int"), order=order)
integrated = run_tests(self.groups, rule_paths, extra, tmp, "int", order)
dec_reqs = {r["id"] for r in reqs if r.get("alert", {}).get("reads_required_records")}
decoupled: dict[str, bool] = {}
if dec_reqs and spec.get("required_records"):
dec_groups = [g for g in self.groups if g["req"] in dec_reqs]
oracle_path = os.path.join(tmp, "oracle_records.yml")
with open(oracle_path, "w") as fh:
fh.write(json.dumps({"groups": self.oracle_records}))
dec_order = [g["name"] for g in self.oracle_records]
dec_paths = write_rule_files(ok_files, os.path.join(tmp, "dec"), set(spec["required_records"]), dec_order)
decoupled = run_tests(dec_groups, [oracle_path] + dec_paths, extra, tmp, "dec", dec_order)
route_res = self._route_results(reqs, alerts, am if am_ok else None, am_path, ws.am_text)
inh_res = self._inhibit_results(reqs, am if am_ok else None)
pres = spec.get("preserve", {})
prr = [bool(am_ok) and amcheck.resolve(am_path, ws.am_text, c["labels"]) == sorted(c["expect"])
for c in pres.get("route_cases", [])]
pir = [bool(am_ok) and isinstance(am, dict) and amcheck.inhibited(am, c["source"], c["target"]) == c["expect"]
for c in pres.get("inhibit_cases", [])]
P, pitems = preservation(every, alerts, pres, am if isinstance(am, dict) else None, prr, pir)
by_cat: dict[str, list[tuple[float, float]]] = {c: [] for c in CATEGORIES}
s_all, checks = [], {}
for r in reqs:
q, fams = self._score_req(r, alerts, records, static, integrated, decoupled, route_res,
inh_res, pres, pir)
qp = float(r.get("q_pristine", 0.0))
s = 1.0 if q >= 1 - 1e-9 else (q - qp) / (1 - qp) if qp < 1 else 0.0
s = max(S_MIN, min(1.0, s))
by_cat[r["category"]].append((s, r["weight"]))
s_all.append((s, r["weight"]))
details["requirements"][r["id"]] = {"q": round(q, 6), "s": round(s, 6), "q_pristine": qp,
"families": fams}
checks.update({f"{r['id']}:{k}": v for k, v in fams.get("_checks", {}).items()})
fams.pop("_checks", None)
phi_raw = sum(s * w for s, w in s_all) / sum(w for _, w in s_all)
progress = max(0.0, (0.5 + 0.5 * P) * phi_raw)
all_solved = all(s >= 1 - 1e-9 for s, _ in s_all)
outcome = 1.0 if (all_solved and P >= 1 - 1e-9 and syntax_ok) else 0.0
keys = zero_keys(False)
keys.update({
"outcome": outcome, "solved": outcome, "progress": round(progress, 6),
"preservation": round(P, 6), "syntax_ok": 1.0 if syntax_ok else 0.0,
"reward": round(0.6 * outcome + 0.4 * progress, 6),
})
for c in CATEGORIES:
vals = by_cat[c]
keys[c] = round(max(0.0, sum(s * w for s, w in vals) / sum(w for _, w in vals)), 6) if vals else 0.0
fam_of = {p["id"]: p.get("family", "") for g in self.groups for p in g["probes"]}
fire = [v for k, v in integrated.items() if fam_of.get(k) in ("fire", "timing")]
silent = [v for k, v in integrated.items() if fam_of.get(k) == "silent"]
label = [v for k, v in checks.items() if ":label" in k or ":annot" in k]
allc = list(integrated.values()) + [v for k, v in checks.items() if ":probe" not in k]
keys["fire_rate"] = round(_mean(fire), 6) if fire else 0.0
keys["silent_rate"] = round(_mean(silent), 6) if silent else 0.0
keys["label_rate"] = round(_mean(label), 6) if label else 0.0
keys["check_pass_rate"] = round(_mean(allc), 6) if allc else 0.0
details.update({"preservation_items": pitems, "checks": {**checks, **{f"probe:{k}": v for k, v in integrated.items()}},
"decoupled": decoupled, "seconds": round(time.time() - t0, 3)})
return keys, details
def _static_and_dynamic(self, reqs, alerts):
static, extra = {}, {}
for r in reqs:
a = r.get("alert")
if not a:
continue
defs = alerts.get(a["name"], [])
best, res = best_definition(defs, a["labels"], a["runbook"])
fp = a["fire_point"]
dyn = [dyn_probe(f"{r['id']}.label.dyn", alert_count_expr(a["name"], fp["service"], a["labels"]),
fp["t"], 1)]
refs = sorted(template_labels(best.rule))[:6] if best else []
for lbl in refs:
dyn.append(dyn_probe(f"{r['id']}.annot.lbl_{lbl}", alert_count_expr(a["name"], fp["service"], {lbl: None}),
fp["t"], 1))
extra.setdefault(fp["group"], []).extend(dyn)
static[r["id"]] = {"best": best, "res": res, "count": len(defs), "dyn": [d["id"] for d in dyn]}
return static, extra
def _alert_q(self, r, st, results) -> tuple[float, dict]:
rid = r["id"]
ids = [p["id"] for g in self.groups if g["req"] == rid for p in g["probes"]]
fam = {p["id"]: p["family"] for g in self.groups if g["req"] == rid for p in g["probes"]}
fire = [results.get(i, False) for i in ids if fam[i] in ("fire", "timing")]
silent = [results.get(i, False) for i in ids if fam[i] == "silent"]
res = st["res"]
lab = [res["labels"], results.get(f"{rid}.label.dyn", False)]
ann = [res["summary"], res["runbook"]] + [results.get(i, False) for i in st["dyn"][1:]]
E = 1.0 if st["count"] >= 1 else 0.0
dup = DUP_FACTOR if st["count"] > r["alert"].get("expected_count", 1) else 1.0
q = E * dup * _mean(fire) * _mean(silent) * (0.7 + 0.3 * _mean(lab + ann))
return q, {"E": E, "dup": dup, "fire": _mean(fire), "silent": _mean(silent), "label_annot": _mean(lab + ann)}
def _score_req(self, r, alerts, records, static, integrated, decoupled, route_res, inh_res, pres, pir):
rid, kind = r["id"], r["kind"]
if kind in ("new_alert", "repair"):
st = static[rid]
q_int, fams = self._alert_q(r, st, integrated)
checks = {f"label:static": st["res"]["labels"], "annot:summary": st["res"]["summary"],
"annot:runbook": st["res"]["runbook"]}
if rid in {g["req"] for g in self.groups} and decoupled and r["alert"].get("reads_required_records"):
q_dec, fd = self._alert_q(r, st, decoupled)
fams = {"integrated": fams, "decoupled": fd}
return 0.5 * q_int + 0.5 * q_dec, {**fams, "_checks": checks}
return q_int, {**fams, "_checks": checks}
if kind == "recording":
ids = [p["id"] for g in self.groups if g["req"] == rid for p in g["probes"]]
exp = r["records"]["expected_count"]
dup = DUP_FACTOR if any(len(records.get(n, [])) > c for n, c in exp.items()) else 1.0
m = _mean(integrated.get(i, False) for i in ids)
return dup * m, {"values": m, "dup": dup}
if kind == "route":
pos, neg = route_res[rid]
q = _mean(pos) * _mean(1.0 if x else 0.0 for x in neg)
return q, {"pos": pos, "neg": neg, "_checks": {f"route:neg{i}": x for i, x in enumerate(neg)}}
if kind == "inhibit":
sup, notsup = inh_res[rid]
notsup = notsup + [ok for c, ok in zip(pres.get("inhibit_cases", []), pir) if c.get("req") == rid]
q = _mean(1.0 if x else 0.0 for x in sup) * _mean(1.0 if x else 0.0 for x in notsup)
return q, {"suppressed": sup, "not_suppressed": notsup,
"_checks": {f"inhibit:{i}": x for i, x in enumerate(sup + notsup)}}
raise ValueError(kind)
def _route_results(self, reqs, alerts, am, am_path, am_text):
out = {}
for r in reqs:
if r["kind"] != "route":
continue
rt = r["route"]
pos, neg = [], []
for c in rt["pos"]:
got = amcheck.resolve(am_path, am_text, c["labels"]) if am else None
pos.append(amcheck.jaccard(set(c["expect"]), set(got)) if got is not None else 0.0)
ch = rt.get("chain")
if ch:
defs = alerts.get(ch["alert"], [])
best, _ = best_definition(defs, ch["required_labels"], ch.get("runbook", ""))
if best is None or not am:
pos.append(0.0)
else:
lab = {str(k): str(v) for k, v in (best.rule.get("labels") or {}).items()
if isinstance(best.rule.get("labels"), dict)}
lab.update({"alertname": ch["alert"], "service": ch["service"]})
got = amcheck.resolve(am_path, am_text, lab)
pos.append(amcheck.jaccard(set(ch["expect"]), set(got)) if got is not None else 0.0)
for c in rt["neg"]:
got = amcheck.resolve(am_path, am_text, c["labels"]) if am else None
neg.append(got is not None and not (set(got) & set(c["forbid"])))
out[r["id"]] = (pos, neg)
return out
def _inhibit_results(self, reqs, am):
out = {}
for r in reqs:
if r["kind"] != "inhibit":
continue
sup, notsup = [], []
for c in r["inhibit"]["cases"]:
got = amcheck.inhibited(am, c["source"], c["target"]) if isinstance(am, dict) else None
(sup if c["expect"] else notsup).append(got is not None and got == c["expect"])
out[r["id"]] = (sup, notsup)
return out
def main(argv=None) -> int:
ap = argparse.ArgumentParser(description="AlertForge grader")
ap.add_argument("--workspace", required=True)
ap.add_argument("--spec", required=True)
ap.add_argument("--hidden", required=True)
ap.add_argument("--out", required=True)
ap.add_argument("--details")
a = ap.parse_args(argv)
with open(a.spec) as fh:
spec = json.load(fh)
keys, details = Grader(spec, a.hidden).grade(a.workspace)
with open(a.out, "w") as fh:
json.dump(keys, fh)
if a.details:
with open(a.details, "w") as fh:
json.dump(details, fh, indent=1, default=str)
print(json.dumps(keys))
return 0
|